Timeline



Feb 25, 2005:

5:41 PM Changeset in webkit [8713] by darin
  • 5 edits in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/4025618> Crash while searching at hollywoodvideo.com
  • khtml/html/html_formimpl.h: Added valueWithDefault.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Call valueWithDefault instead of going at the render object to try to get the default value; there may be no render object if this is display:none. (DOM::HTMLInputElementImpl::valueWithDefault): Added. Knows about the defaults for "submit" and "reset" buttons; otherwise just returns the value as-is.
  • khtml/rendering/render_form.h: Removed the defaultLabel member functions.
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Call valueWithDefault instead of using defaultLabel function here on the render side. The DOM needs to know how to deal with the default anyway for form submission. (RenderSubmitButton::defaultLabel): Removed. (RenderResetButton::defaultLabel): Removed. (RenderPushButton::defaultLabel): Removed.
5:03 PM Changeset in webkit [8712] by darin
  • 7 edits in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/4025088> window onblur and onfocus don't fire when text field has focus
  • kwq/KWQKHTMLPart.h: Added setWindowHasFocus function and m_windowHasFocus data member.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::setDisplaysWithFocusAttributes): Took out the code that sends the focus and blur events. (KWQKHTMLPart::setWindowHasFocus): Put that code here instead.
  • kwq/WebCoreBridge.h: Added setWindowHasFocus: method to the bridge.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setWindowHasFocus:]): Added. Calls method on the part.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/4025088> window onblur and onfocus don't fire when text field has focus
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView updateFocusState]): Renamed from updateFocusDisplay. Added call to setWindowHasFocus: method. (-[WebHTMLView viewDidMoveToWindow]): Call method by new name. (-[WebHTMLView windowDidBecomeKey:]): Ditto. (-[WebHTMLView windowDidResignKey:]): Ditto. (-[WebHTMLView becomeFirstResponder]): Ditto. (-[WebHTMLView resignFirstResponder]): Ditto.
4:43 PM Changeset in webkit [8711] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • re-fixed <rdar://problem/3665430> horizontal scroll bar of text area does not show, even when text is wide in "no wrap" mode
  • kwq/KWQTextArea.mm: (-[KWQTextArea _updateTextViewWidth]): Don't change the text view width to match the text area's width in the "wrap" case.
3:51 PM Changeset in webkit [8710] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4021518> 8A394 Mail crashes during paste: khtml::RootInlineBox::closestLeafChildForXPos

  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Adding an updateLayout call at the start of the function fixes the crash, since we caught line boxes in a not-completely-updated state. (khtml::nextLinePosition): Ditto.
3:49 PM Changeset in webkit [8709] by hyatt
  • 2 edits in trunk/WebCore

Fix for 4010774, make sure to avoid an O(N2) algorithm in nextRenderer() that is triggered when large
DOM subtrees are inserted into documents via one insert/append call.

Reviewed by kocienda

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::nextRenderer):
3:41 PM Changeset in webkit [8708] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3382926> Bidi neutrals at RTL/LTR boundaries not handled correctly.

Second pass at fixing 3382926 w/o causing layout regressions. Same concept:
if directionality of text's element is RTL and first character has neutral directionality
then set the initial directionality to RTL.

Reviewed by Hyatt.

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::determineStartPosition):
2:16 PM Changeset in webkit [8707] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (400+)

2:10 PM Changeset in webkit [8706]
  • 1 copy in tags/Safari-300

This commit was manufactured by cvs2svn to create tag 'Safari-300'.

2:10 PM Changeset in webkit [8705] by vicki
  • 3 edits in trunk

Safari 1.3 (300) stamp, for 10.3 Panther

2:05 PM Changeset in webkit [8704]
  • 1 copy in tags/Safari-400

This commit was manufactured by cvs2svn to create tag 'Safari-400'.

2:05 PM Changeset in webkit [8703] by vicki
  • 6 edits in trunk

Safari-400 stamp

This is our first build with the new versioning scheme. Versions are Safari 2.0 (400) on 10.4, and Safari (1.3) 300 for 10.3. See this bug for details:

<rdar://problem/3962707> upgrade install of Tiger over SUPanWheat leaves Panther version of WebKit (need new version numbering scheme)

1:33 PM Changeset in webkit [8702] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by me

Roll out Chris' change to fix this bug:

<rdar://problem/4023566> Stickies: Crash in ReplacementFragment::insertFragmentForTestRendering on paste

That code change is responsible for all these new crashers:

<rdar://problem/4025177> crash copying safari.apple.com into Blot document
<rdar://problem/4025184> crash in DOM::NodeImpl::parentNode copying "New!" from google.com to Blot
<rdar://problem/4025214> crash in DOM::NodeImpl::getRect loading paste-match-style-001.html

Since we wish to close the tree for a build right now, I am rolling out rather than investigating.

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded) (khtml::ReplacementFragment::insertFragmentForTestRendering) (khtml::createDefaultParagraphElement) (khtml::createBlockPlaceholderElement) (khtml::createFontElement) (khtml::createStyleSpanElement)
  • khtml/editing/htmlediting.h
12:54 PM Changeset in webkit [8701] by rjw
  • 2 edits in trunk/WebKit

Fixed <rdar://problem/4000962> 8A375: Help Viewer displays voiced sound and semi-voiced characters strangely (characters don't seem to be composed)

Added special case for voiced marks.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):
11:42 AM Changeset in webkit [8700] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/4020108> Pasting text into message makes Mail crash reproducibly

Note that, even with this fix, development build will crash until this bug is fixed:
<rdar://problem/4024996> Applying block styles can cause assertion failure in inline style removal

This will not crash deployment builds, so I am going to land.

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Applying block styles can make the loop to reach beyondEnd fail since the structure of the document can change. Cache the next node first before operating on it, as we do elsewhere.
11:38 AM Changeset in webkit [8699] by vicki
  • 4 edits in trunk/WebCore
  • recommit this change, since rolling it out did NOT fix the performance regression!

2005-02-23 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/4011405> REGRESSION (180-181): Unconfirmed text disappears when text focus moves

The key was to change things around so that we don't push text from the DOM to the widget
unless the DOM has actually been changed. This prevents the code path that wipes out inline input
during the blur process.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::HTMLInputElementImpl): Start m_valueMatchesRenderer as false. (DOM::HTMLInputElementImpl::parseHTMLAttribute): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValue): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValueFromRenderer): Added. Sets m_value, sets m_valueMatchesRenderer to true, and also sends out the input event. It's better to have this here than in the renderer code. (DOM::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): Start m_valueIsValid as false (replaces m_dirtyvalue) and m_valueMatchesRenderer as false. (DOM::HTMLTextAreaElementImpl::updateValue): Added. Factored this out from the value function. Uses the new booleans and keeps them up to date, specifically setting m_valueMatchesRenderer based on where the value came from. (DOM::HTMLTextAreaElementImpl::value): Updated to call updateValue to do most of the work. (DOM::HTMLTextAreaElementImpl::setValue): Set both m_valueIsValid and m_valueMatchesRenderer. (DOM::HTMLTextAreaElementImpl::setDefaultValue): Take parameter by reference.
  • khtml/html/html_formimpl.h: Added setValueFromRenderer, valueMatchesRenderer, setValueMatchesRenderer, and m_valueMatchesRenderer to input element. For textarea element, made some parameters pass DOMString by reference, and added invalidateValue, updateValue, valueMatchesRenderer, and setValueMatchesRenderer.
  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Don't re-get the value from the DOM if valueMatchesRenderer is true. (RenderLineEdit::slotTextChanged): Call setValueFromRenderer instead of manipulating the DOM directly. (RenderTextArea::detach): Call updateValue instead of calling value for its side effect. (RenderTextArea::handleFocusOut): Ditto. (RenderTextArea::updateFromElement): Call updateValue and then not re-get the value from the DOM if valueMatchesRenderer is true. (RenderTextArea::slotTextChanged): Call invalidateValue instead of directly setting m_dirtyvalue to true.
11:34 AM Changeset in webkit [8698] by cblu
  • 3 edits in trunk/WebCore

Fixed: <rdar://problem/4023566> Stickies: Crash in ReplacementFragment::insertFragmentForTestRendering on paste

Reviewed by darin.

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ReplacementFragment::insertFragmentForTestRendering): (khtml::floatRefdElement): (khtml::createDefaultParagraphElement): (khtml::createBlockPlaceholderElement): (khtml::createFontElement): (khtml::createStyleSpanElement):
  • khtml/editing/htmlediting.h:
10:48 AM Changeset in webkit [8697] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/4019823> Seed: Control-Y doesn't work
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Call _handleKillRing after setting the selection, since it uses the selection to get the text. (-[WebHTMLView _insertText:selectInsertedText:]): Check for empty string to avoid an assertion on the other side of the bridge when you yank the empty string.
10:38 AM Changeset in webkit [8696] by darin
  • 2 edits in trunk/WebCore
  • kwq/character-sets.txt: Checked in updated file. This new file has no effect, because none of the changes affect character sets that we support, but it's good to have the latest file in here, and completely safe because I checked that the generated files have not changed.
10:36 AM Changeset in webkit [8695] by vicki
  • 4 edits in trunk/WebCore

Reviewed by Darin.

  • back out this change, since it causes a 3.5% performance regression

2005-02-23 Darin Adler <Darin Adler>

Reviewed by John.

  • fixed <rdar://problem/4011405> REGRESSION (180-181): Unconfirmed text disappears when text focus moves

The key was to change things around so that we don't push text from the DOM to the widget
unless the DOM has actually been changed. This prevents the code path that wipes out inline input
during the blur process.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::HTMLInputElementImpl): Start m_valueMatchesRenderer as false. (DOM::HTMLInputElementImpl::parseHTMLAttribute): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValue): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValueFromRenderer): Added. Sets m_value, sets m_valueMatchesRenderer to true, and also sends out the input event. It's better to have this here than in the renderer code. (DOM::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): Start m_valueIsValid as false (replaces m_dirtyvalue) and m_valueMatchesRenderer as false. (DOM::HTMLTextAreaElementImpl::updateValue): Added. Factored this out from the value function. Uses the new booleans and keeps them up to date, specifically setting m_valueMatchesRenderer based on where the value came from. (DOM::HTMLTextAreaElementImpl::value): Updated to call updateValue to do most of the work. (DOM::HTMLTextAreaElementImpl::setValue): Set both m_valueIsValid and m_valueMatchesRenderer. (DOM::HTMLTextAreaElementImpl::setDefaultValue): Take parameter by reference.
  • khtml/html/html_formimpl.h: Added setValueFromRenderer, valueMatchesRenderer, setValueMatchesRenderer, and m_valueMatchesRenderer to input element. For textarea element, made some parameters pass DOMString by reference, and added invalidateValue, updateValue, valueMatchesRenderer, and setValueMatchesRenderer.
  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Don't re-get the value from the DOM if valueMatchesRenderer is true. (RenderLineEdit::slotTextChanged): Call setValueFromRenderer instead of manipulating the DOM directly. (RenderTextArea::detach): Call updateValue instead of calling value for its side effect. (RenderTextArea::handleFocusOut): Ditto. (RenderTextArea::updateFromElement): Call updateValue and then not re-get the value from the DOM if valueMatchesRenderer is true. (RenderTextArea::slotTextChanged): Call invalidateValue instead of directly setting m_dirtyvalue to true.
10:29 AM Changeset in webkit [8694] by darin
  • 2 edits in trunk/WebCore

Reviewed by Chris.

  • fixed <rdar://problem/4024786> REGRESSION (Mail): "Smart paste" plain-text word into Blot leaves insertion point misplaced
  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Use the insertNodeAfterAndUpdateNodesInserted and insertNodeBeforeAndUpdateNodesInserted functions to add the leading and trailing spaces for smart paste.
9:43 AM Changeset in webkit [8693] by hyatt
  • 2 edits in trunk/WebCore

Back out fix for 3382926, since it breaks LTR text inside RTL contexts.

Reviewed by john

  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):
9:33 AM Changeset in webkit [8692] by hyatt
  • 4 edits in trunk/WebCore

Fix for 3975039, scrolling is slow in huge RSS views. Optimize the calculation of clip rects for overflow:hidden
layers. Also optimize layer movement when scrolling overflow sections.

Reviewed by darin

  • khtml/rendering/render_layer.cpp: (throw): (ClipRects::operator delete): (ClipRects::detach): (RenderLayer::RenderLayer): (RenderLayer::~RenderLayer): (RenderLayer::updateLayerPosition): (RenderLayer::removeOnlyThisLayer): (RenderLayer::insertOnlyThisLayer): (RenderLayer::scrollToOffset): (RenderLayer::hitTest): (RenderLayer::calculateClipRects): (RenderLayer::calculateRects): (RenderLayer::containsPoint): (RenderLayer::clearClipRects): (RenderLayer::clearClipRect):
  • khtml/rendering/render_layer.h: (khtml::ClipRects::m_refCnt): (khtml::ClipRects::overflowClipRect): (khtml::ClipRects::fixedClipRect): (khtml::ClipRects::posClipRect): (khtml::ClipRects::ref): (khtml::ClipRects::deref): (khtml::RenderLayer::clipRects):
  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):

Feb 24, 2005:

7:41 PM Changeset in webkit [8691] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin and Dave a while ago.

<rdar://problem/3996685> REGRESSION: Crash in KWQVectorImpl::at loading ​http://maps.google.com/mapfiles/homepanel.xsl

  • kwq/WebCoreBridge.mm: (formElementFromDOMElement): Check for isHTMLElement() as well as id() == ID_FORM. This seems like an impossible situation, but papering over it seems more expedient for the time being.
5:33 PM Changeset in webkit [8690] by rjw
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebImageRenderer.m

Fixed panther build problem.

4:50 PM Changeset in webkit [8689] by rjw
  • 4 edits in trunk

WebCore

Fixed <rdar://problem/3382926> Bidi neutrals at RTL/LTR boundaries not handled correctly.

Use mirror characters correctly when rendering with RTL directionality.

Reviewed by Hyatt.

  • khtml/rendering/bidi.cpp: (khtml::BidiIterator::direction):

WebKit

Fixed <rdar://problem/3382926> Bidi neutrals at RTL/LTR boundaries not handled correctly.

If directionality is specified use that as initial directionality,
rather than neutral directionality.

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebTextRenderer.m: (widthForNextCharacter):
4:33 PM Changeset in webkit [8688] by adele
  • 2 edits in trunk/WebKit

Reviewed by Chris.

Fix for <rdar://problem/4023393> Safari crashed in khtml::RenderObject::repaintAfterLayoutIfNeeded(QRect const&, QRect const&)

We were crashing after hitting PageDown when viewing a pdf because
WebKit was calling over to WebCore to scroll overflow areas.
Since this only needs to be done if we're dealing with a WebHTMLView,
I added a wrapper function to check the documentView before calling
over to WebCore.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _scrollOverflowInDirection:granularity:]): added wrapper function that checks if documentView is a WebHTMLView (-[WebFrameView scrollToBeginningOfDocument:]): uses new wrapper function now (-[WebFrameView scrollToEndOfDocument:]): uses new wrapper function now (-[WebFrameView _pageVertically:]): uses new wrapper function now (-[WebFrameView _pageHorizontally:]): uses new wrapper function now (-[WebFrameView _scrollLineVertically:]): uses new wrapper function now (-[WebFrameView _scrollLineHorizontally:]): uses new wrapper function now
4:25 PM Changeset in webkit [8687] by rjw
  • 14 edits in trunk

WebCore:

Fixed <rdar://problem/3985889> REGRESSION (125-180): setting <img> src to GIF that already animated does not animate; just shows final frame

Reviewed by Hyatt.

  • WebCore.pbproj/project.pbxproj:
  • khtml/html/html_imageimpl.cpp: (HTMLImageLoader::updateFromElement):
  • khtml/rendering/render_image.cpp: (RenderImage::resetAnimation):
  • khtml/rendering/render_image.h:
  • khtml/rendering/render_list.cpp: (RenderListMarker::setStyle): (RenderListMarker::paint):
  • khtml/rendering/render_list.h:
  • kwq/KWQPixmap.h:
  • kwq/KWQPixmap.mm:

WebKit:

Fixed <rdar://problem/3985889> REGRESSION (125-180): setting <img> src to GIF that already animated does not animate; just shows final frame

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebImageData.h:
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData resetAnimation]):
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer resetAnimation]): (-[WebInternalImage resetAnimation]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
4:00 PM Changeset in webkit [8686] by cblu
  • 2 edits in trunk/WebCore

Fixed: <rdar://problem/4020110> Safari crashes in setAllData while taking a www.zoomerang.com survey

Reviewed by rjw.

  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader finishJobAndHandle:]): clear the job after we've deleted to avoid reentrancy
3:07 PM Changeset in webkit [8685] by kdecker
  • 5 edits in trunk/WebKit

Reviewed by John.

Fixed <rdar://problem/3962401> Don't load multipart/x-mixed-replace content to prevent memory leak

Since we're not going to fix <rdar://problem/3087535> for Tiger, we should not load multipart/x-mixed-replace content. Pages with such content contain what is essentially an infinite load and therefore may leak.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): Disabled loading of multipart/x-mixed-replace content until we fully implement server side push.
    • WebCoreSupport.subproj/WebSubresourceClient.m:

(-[WebSubresourceClient didReceiveResponse:]): Ditto. Same exact thing for sub resources.

2:35 PM Changeset in webkit [8684] by darin
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fixed <rdar://problem/4023360> REGRESSION (186-187): image file upload is broken at pep.apple.com
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::appendFormData): Return true after setting up the form data for an uploaded file. The old code would fall through to the ISINDEX case and send double form data (the filename instead of the file contents the second time).
2:17 PM Changeset in webkit [8683] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3990849> AX: textMarkerRange for an AXUIElement within an AXWebArea

  • kwq/KWQAccObject.mm: (-[KWQAccObject textMarkerRange]): (-[KWQAccObject accessibilityParameterizedAttributeNames]): (-[KWQAccObject doAXTextMarkerRangeForUIElement:]): (-[KWQAccObject accessibilityAttributeValue:forParameter:]): Added AXTextMarkerRangeForUIElement, or you can send textMarkerRange to the UIElement itself.
1:28 PM Changeset in webkit [8682] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

<rdar://problem/4004279> 3 AXSelectedTextChanged notifications are firing each time I type a character

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::updateSelection): Send notification only if the selection is not null. This safely ignores transitory selections set during editing.
9:59 AM Changeset in webkit [8681] by darin
  • 5 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3987619> in some cases, text doesn't resize with Format->Style->Bigger/Smaller
  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): Only call nodeFullySelected for non-text nodes. Text nodes are already split so they're either in the range and full selected or out of the range. And nodeFullySelected doesn't work for text nodes. (khtml::ApplyStyleCommand::nodeFullySelected): Add an assertion, since this function only works for elements, not text nodes. (khtml::ApplyStyleCommand::nodeFullyUnselected): Ditto.
  • make big improvement in <rdar://problem/3953636> Mail hung for ~10sec changing font of 84328 characters: khtml::ApplyStyleCommand::nodeFullySelected
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::compareBoundaryPoints): Improve algorithm based on suggestion from Nate Begeman.
  • fixed <rdar://problem/4020305> REGRESSION (185-186): loading image in new window using document.write fails
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::open): If there is no parent document, don't blow away the base URL.
  • fixed <rdar://problem/4021701> REGRESSION (188-188+): form not submitted after pressing <return> at ​http://hrweb.apple.com
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchMouseEvent): Send activate event in the case where the event sent is a KHTML_CLICK_EVENT, not CLICK_EVENT.
7:30 AM Changeset in webkit [8680] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by mjs

Fixed <rdar://problem/4020747> REGRESSION: stray </applet> tags crash Safari

  • khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag): Made a typesafe check that prevents crashes whenever there is a closing applet tag without an actual <applet> in the first place. Now verifies the current token is ID_APPLET before casting it to an HTMLAppletElementImpl.

Feb 23, 2005:

4:35 PM Changeset in webkit [8679] by kocienda
  • 2 edits
    2 adds in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3977962> font loses bold style after pasting next to existing text and pressing return

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Problem here was that we were doing work in cases where we should not, and content whose style would have been correct if we had done nothing was getting clobbered. It turns out that extra work to apply style to the new paragraph added in this command only needs to be done if we're at the boundaries of a paragraph. Otherwise, content that is moved as part of the work of the command will lend their styles to the new paragraph without any extra work needed. So, make this position check and return unless at a paragraph boundary.

New test:

  • layout-tests/editing/style/block-styles-007-expected.txt
  • layout-tests/editing/style/block-styles-007.html
2:59 PM Changeset in webkit [8678] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ken.

  • fixed <rdar://problem/4021370> REGRESSION (Tiger): WebKit part of fix for shift-tab on tivofaq doing the wrong thing
  • WebView.subproj/WebFrameView.m: (-[WebFrameView becomeFirstResponder]): If our previousValidKeyView is nil or self (same as nil modulo AppKit oddness), look out of the box and get the previousValidKeyView of our webview.
2:11 PM Changeset in webkit [8677] by kocienda
  • 5 edits
    8 adds in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4017641> REGRESSION (Mail): you can only bold/unbold a selection starting from end of line once

Problem is with the way we figure out whether to add or remove a style based on
the current selection. In this case, the code is looking at the end of the
previous line, which is not bold, and deduces incorrectly that the operation is
a "make bold". Then the style code runs to make bold, but there is nothing on
the end of the previous line to embolden, so we get into a cycle where the same
thing happens each time cmd-b is hit.

  • khtml/khtml_part.cpp: (KHTMLPart::selectionComputedStyle): Call editingStartPosition() to get the right position for the font determination.
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::editingStartPosition): New helper function that "does the right thing" based on whether the selection is a caret or a range, moving upstream for the former, and downstream for the latter.
  • khtml/xml/dom2_rangeimpl.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Call editingStartPosition() to get the right position for the font determination.

New tests:

  • layout-tests/editing/style/style-boundary-001-expected.txt
  • layout-tests/editing/style/style-boundary-001.html
  • layout-tests/editing/style/style-boundary-002-expected.txt
  • layout-tests/editing/style/style-boundary-002.html
  • layout-tests/editing/style/style-boundary-003-expected.txt
  • layout-tests/editing/style/style-boundary-003.html
  • layout-tests/editing/style/style-boundary-004-expected.txt
  • layout-tests/editing/style/style-boundary-004.html
2:04 PM Changeset in webkit [8676] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/3985579> 8A367: Dashboard: Stock widget not visible when click remove to remove single char ticker symbol

Explicitly remove scroll bar views when removing them from
the overflow.

Don't paint synchronously when the scroll position changes,
this caused funky clip problems.

Reviewed by Hyatt.

  • khtml/rendering/render_layer.cpp: (RenderLayer::scrollToOffset): (RenderLayer::setHasHorizontalScrollbar): (RenderLayer::setHasVerticalScrollbar): (RenderLayer::updateScrollInfoAfterLayout):
1:38 PM Changeset in webkit [8675] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3959996> REGRESSION (Mail): cursor moves to beginning of document when click is past end

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::positionForCoordinates): Skip blocks that are invisible or have no height when looking for a child to pass off to. And save away the last visible block with a height to pass off to if there is no child at the right y-coordinate.
1:25 PM Changeset in webkit [8674] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4010059> BoundsForTextMarkerRange does not update with scrolled web area

  • kwq/KWQAccObject.mm: (-[KWQAccObject doAXBoundsForTextMarkerRange:]): Adjust for scrolling.
12:22 PM Changeset in webkit [8673] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Ken.

<rdar://problem/3949790> hitting return after pasted styled line results in extra content getting the style

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): In the case where the start block is the root, insert the newly created DIV at the end of the root block instead of after the last sibling in the start node, since the start node could be inside other style-affecting nodes and we don't want to reparent its cousins into that.
12:09 PM Changeset in webkit [8672] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

<rdar://problem/4014691> switch to correctly spelled NSAccessibilityForegroundColorTextAttribute constant

Also removed two older, now unneeded, wrappers.

  • kwq/KWQAccObject.mm: (-[KWQAccObject visiblePositionForStartOfTextMarkerRange:]): (-[KWQAccObject visiblePositionForEndOfTextMarkerRange:]): Removed these older, now unneeded, wrappers.

(NSAccessibilityForegroundColorTextAttributeWrapper):
New wrapper for NSAccessibilityForegroundColorTextAttribute.

(AXAttributeStringSetStyle):
Use NSAccessibilityForegroundColorTextAttributeWrapper.

(-[KWQAccObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
Remove uses of visiblePositionForStartOfTextMarkerRange and visiblePositionForEndOfTextMarkerRange.

11:07 AM Changeset in webkit [8671] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

<rdar://problem/3524784> AX hit test doesn't return info when done in empty space of content area

  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityHitTest:]): Return unignored object.
11:06 AM Changeset in webkit [8670] by darin
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • fixed <rdar://problem/4010196> REGRESSION (125-186+): 8-character timestamps in gmail wrap to 2 lines (width:8ex; font-size:80%)
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Return the maximum of the "x" height and width. Comment in the code explains why in more detail.
10:23 AM Changeset in webkit [8669] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/4006509> REGRESSION (171-172): Setting CSS -khtml-user-modify property triggers crash
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Removed the code that changes the style of the element. This was never needed, and caused the style to be modified while we were iterating it.
9:54 AM Changeset in webkit [8668] by kocienda
  • 7 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3980209> Mail crashed when I pressed Cmd-Shift-[ (nil-deref in ApplyStyleCommand::addBlockStyleIfNeeded)

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Reordered the new block insertion so that it come before the move. The logic stays exactly the same, however, with the old ordering, the new block could want to become a child of itself come insertion time. I considered making a more complicated code change to fix this problem, but the simple reordering works just as well, and seems less risky.

These all changed in an insignificant way. It seems that with the new code, some empty text nodes
got reordered in the document. This has no effect on anything visible to the user.

  • layout-tests/editing/style/create-block-for-style-003-expected.txt
  • layout-tests/editing/style/create-block-for-style-004-expected.txt
  • layout-tests/editing/style/create-block-for-style-009-expected.txt
  • layout-tests/editing/style/create-block-for-style-011-expected.txt
  • layout-tests/editing/style/create-block-for-style-013-expected.txt
9:42 AM Changeset in webkit [8667] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4013986> REGRESSION (173-174): onclick event not sent when mouse click on checkbox is double-click

We need to send an onclick event *and* an ondblclick event when we process a double click.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): In the case where we're sending a CLICK_EVENT, follow it by a KHTML_CLICK_EVENT, a KHTML_DBLCLICK_EVENT when handling a double click, and a DOMACTIVATE_EVENT. We no longer do the DOMACTIVATE_EVENT in dispatchGenericEvent.
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotClicked): send only CLICK_EVENT here, and lets dispatchMouseEvent deal with the other subsequent events.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent): Remove the code that sends a DOMACTIVATE_EVENT, since there's no longer a good way to figure out if this is the last event that should be sent before it is. (NodeImpl::dispatchMouseEvent): Set the meta key modifier here (as it already is set elsewhere), and follow up a CLICK_EVENT with KHTML_CLICK_EVENT, a KHTML_DBLCLICK_EVENT, and DOMACTIVATE_EVENT as above.
9:35 AM Changeset in webkit [8666] by darin
  • 4 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4011405> REGRESSION (180-181): Unconfirmed text disappears when text focus moves

The key was to change things around so that we don't push text from the DOM to the widget
unless the DOM has actually been changed. This prevents the code path that wipes out inline input
during the blur process.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::HTMLInputElementImpl): Start m_valueMatchesRenderer as false. (DOM::HTMLInputElementImpl::parseHTMLAttribute): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValue): Set m_valueMatchesRenderer to false when a new value is set here. (DOM::HTMLInputElementImpl::setValueFromRenderer): Added. Sets m_value, sets m_valueMatchesRenderer to true, and also sends out the input event. It's better to have this here than in the renderer code. (DOM::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): Start m_valueIsValid as false (replaces m_dirtyvalue) and m_valueMatchesRenderer as false. (DOM::HTMLTextAreaElementImpl::updateValue): Added. Factored this out from the value function. Uses the new booleans and keeps them up to date, specifically setting m_valueMatchesRenderer based on where the value came from. (DOM::HTMLTextAreaElementImpl::value): Updated to call updateValue to do most of the work. (DOM::HTMLTextAreaElementImpl::setValue): Set both m_valueIsValid and m_valueMatchesRenderer. (DOM::HTMLTextAreaElementImpl::setDefaultValue): Take parameter by reference.
  • khtml/html/html_formimpl.h: Added setValueFromRenderer, valueMatchesRenderer, setValueMatchesRenderer, and m_valueMatchesRenderer to input element. For textarea element, made some parameters pass DOMString by reference, and added invalidateValue, updateValue, valueMatchesRenderer, and setValueMatchesRenderer.
  • khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Don't re-get the value from the DOM if valueMatchesRenderer is true. (RenderLineEdit::slotTextChanged): Call setValueFromRenderer instead of manipulating the DOM directly. (RenderTextArea::detach): Call updateValue instead of calling value for its side effect. (RenderTextArea::handleFocusOut): Ditto. (RenderTextArea::updateFromElement): Call updateValue and then not re-get the value from the DOM if valueMatchesRenderer is true. (RenderTextArea::slotTextChanged): Call invalidateValue instead of directly setting m_dirtyvalue to true.

Feb 22, 2005:

7:44 PM Changeset in webkit [8665] by rjw
  • 9 edits in trunk

WebCore:

Fixed <rdar://problem/3937203> when a div adds a scrollbar (overflow:auto) we do not get regions

Just set dashboard dirty bit when overflow scrolling changes.

Don't do comparison of regions in before scroll regions are
added, instead do it in WebKit after automatic scroll regions
are added.

Reviewed by Maciej.

  • khtml/css/cssparser.cpp: (CSSParser::parseDashboardRegions): Cleaned up comments
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::styleForElement): Cleaned up comments
  • khtml/khtmlview.cpp: (KHTMLView::updateDashboardRegions):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateScrollInfoAfterLayout):
  • kwq/WebDashboardRegion.m: (-[WebDashboardRegion isEqual:]):

Webkit:

Fixed <rdar://problem/3937203> when a div adds a scrollbar (overflow:auto) we do not get regions

Compare regions after automatice scroll regions have been
added.

Reviewed by Maciej.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dealloc]): (-[WebBridge _compareDashboardRegions:]): (-[WebBridge dashboardRegionsChanged:]):
7:34 PM Changeset in webkit [8664] by rjw
  • 3 edits in trunk/WebKit

Fixed <rdar://problem/4012463> Dashboard widgets don't work with authenticating proxies

Added new SPI for dashboard that just calls default delegate
behavior.

Reviewed by Maciej.

  • WebView.subproj/WebView.m: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
  • WebView.subproj/WebViewPrivate.h:
6:34 PM Changeset in webkit [8663] by cblu
  • 11 edits
    4 adds in trunk

WebCore:

Fixed: <rdar://problem/3976872> Pasted plain text doesn't get the proper style if pasted into newlines

Reviewed by mjs.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): don't clear the typing style when matching style (khtml::ReplaceSelectionCommand::completeHTMLReplacement): apply the typing style when matching style
  • khtml/editing/jsediting.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::pasteAndMatchStyle): new
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issuePasteAndMatchStyleCommand): new
  • kwq/WebCoreBridge.h:
  • layout-tests/editing/editing.js:

WebKit:

Reviewed by mjs.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issuePasteAndMatchStyleCommand]): support for new "PasteAndMatchStyle" exec command
5:27 PM Changeset in webkit [8662] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • fixed <rdar://problem/4006596> REGRESSION (183-184): crash in DOM::DocumentImpl::setFocusNode(DOM::NodeImpl*)
  • khtml/xml/dom_docimpl.cpp: (widgetForNode): Added helper. (DocumentImpl::setFocusNode): Re-get the widget for the node after calling updateLayout. The updateLayout can destroy the old widget, so we can't keep a stale widget pointer around.
4:10 PM Changeset in webkit [8661] by kocienda
  • 10 edits in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4003463> Mail.app HTML uses inline styling markup not understood by Entourage and Eudora

  • khtml/editing/htmlediting.cpp: (khtml::isEmptyFontTag): Helper for removing <font> tags. (khtml::StyleChange::styleModeForParseMode): Helper to map a document parse mode to a use/don't use legacy-html-styles value. (khtml::StyleChange::checkForLegacyHTMLStyleChange): Add support for colors, font faces, and font sizes. (khtml::ApplyStyleCommand::isHTMLStyleNode): (khtml::ApplyStyleCommand::removeHTMLFontStyle): (khtml::ApplyStyleCommand::applyTextDecorationStyle): Now call styleModeForParseMode to determine whether to use legacy html styles or not. (khtml::ApplyStyleCommand::removeInlineStyle): Now properly removes <font> styles. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::createFontElement): Helper for applying <font> elements.
  • khtml/editing/htmlediting.h: All the following support the new bits of data we need to store. (khtml::StyleChange::applyFontColor) (khtml::StyleChange::applyFontFace) (khtml::StyleChange::applyFontSize) (khtml::StyleChange::fontColor) (khtml::StyleChange::fontFace) (khtml::StyleChange::fontSize)

Test results updated now that we will write out <font> tags for quirks mode documents.

  • layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt
  • layout-tests/editing/style/block-style-004-expected.txt
  • layout-tests/editing/editing/pasteboard/paste-text-011-expected.txt
  • layout-tests/editing/style/block-style-005-expected.txt
  • layout-tests/editing/style/block-style-006-expected.txt
  • layout-tests/editing/style/smoosh-styles-001-expected.txt
  • layout-tests/editing/style/smoosh-styles-002-expected.txt
4:00 PM Changeset in webkit [8660] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

<rdar://problem/4017066> crash in KJS::ValueImp::dispatchType() every time I load www.nytimes.com/pages/automobiles

When creating option elements, use lowercase "option" instead of
uppercase "OPTION" to create option elements, because only
lowercase works for XHTML.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLSelectCollection::tryPut): (OptionConstructorImp::construct):
3:22 PM Changeset in webkit [8659] by cblu
  • 2 edits
    2 adds in trunk

WebCore fix for: <rdar://problem/3918056> Mail not line breaking my <pre> formatted emails on replies

Mail must 4018993 to fully address the problem.

Reviewed by kocienda.

  • khtml/editing/markup.cpp: (khtml::startMarkup): don't compute style for text in PRE tags (khtml::createMarkup): include PRE if it is an ancestor of the nodes in the range

Feb 21, 2005:

5:32 PM Changeset in webkit [8658] by rjw
  • 2 edits in trunk/WebCore

Fixed <rdar://problem/4008338> REGRESSION (125-178): opacity style not working, breaks fading images on okcupid.com

There was a long standing bug in cssText(). Double value were always cast int! So,
opacity values values were incorrectly converted to text, i.e. 0.75 became 0.

The problem was newly triggered because we parse the css for opacity *TWICE*. This is a result of
incorrectly "invalidating" the style attribute (from fix for 3790449). The second parse was from
the cssText() of the style.

Reviewed by Hyatt.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::cssText):
4:19 PM Changeset in webkit [8657] by hyatt
  • 2 edits in trunk/WebCore

Fix for 4017204, apply the same fix to the base class nodeAtPoint that was already applied to RenderBlock.
Skip elements with layers and inline flows. Demoted <form>s can end up causing trouble otherwise.

Reviewed by Richard Williamson

  • khtml/rendering/render_box.cpp: (RenderBox::nodeAtPoint):
3:36 PM Changeset in webkit [8656] by hyatt
  • 9 edits in trunk/WebCore

Fix for 4017033, CSS is being parsed twice. Make sure to always validate the style attribute when it is
initially parsed. Add code to clean up decls when the style attribute is completely removed. Add a new
synchronizing boolean that avoids reparsing the style declaration when the attribute is simply
being synced up to the declaration.

Reviewed by John

  • khtml/css/css_valueimpl.cpp: (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::invalidateStyleAttribute): (HTMLElementImpl::updateStyleAttributeIfNeeded): (HTMLElementImpl::HTMLElementImpl): (HTMLElementImpl::~HTMLElementImpl): (HTMLElementImpl::destroyInlineStyleDecl): (HTMLElementImpl::mapToEntry): (HTMLElementImpl::parseHTMLAttribute):
  • khtml/html/html_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): (ElementImpl::setAttribute):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::updateStyleAttributeIfNeeded):
3:24 PM Changeset in webkit [8655] by vicki
  • 3 edits in trunk

versioning for TOT, Safari 2.0 (188+)

3:17 PM Changeset in webkit [8654]
  • 1 copy in tags/Safari-188

This commit was manufactured by cvs2svn to create tag 'Safari-188'.

3:17 PM Changeset in webkit [8653] by vicki
  • 6 edits in trunk

Safari-188 stamp

2:02 PM Changeset in webkit [8652] by kocienda
  • 9 edits in trunk

Tree was closed. Rolling out.

2:01 PM Changeset in webkit [8651] by kocienda
  • 9 edits in trunk

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4003463> Mail.app HTML uses inline styling markup not understood by Entourage and Eudora

  • khtml/editing/htmlediting.cpp: (khtml::isEmptyFontTag): Helper for removing <font> tags. (khtml::StyleChange::styleModeForParseMode): Helper to map a document parse mode to a use/don't use legacy-html-styles value. (khtml::StyleChange::checkForLegacyHTMLStyleChange): Add support for colors, font faces, and font sizes. (khtml::ApplyStyleCommand::isHTMLStyleNode): (khtml::ApplyStyleCommand::removeHTMLFontStyle): (khtml::ApplyStyleCommand::applyTextDecorationStyle): Now call styleModeForParseMode to determine whether to use legacy html styles or not. (khtml::ApplyStyleCommand::removeInlineStyle): Now properly removes <font> styles. (khtml::ApplyStyleCommand::addBlockStyleIfNeeded): Ditto. (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto. (khtml::createFontElement): Helper for applying <font> elements.
  • khtml/editing/htmlediting.h: All the following support the new bits of data we need to store. (khtml::StyleChange::applyFontColor) (khtml::StyleChange::applyFontFace) (khtml::StyleChange::applyFontSize) (khtml::StyleChange::fontColor) (khtml::StyleChange::fontFace) (khtml::StyleChange::fontSize)

Test results updated now that we will write out <font> tags for quirks mode documents.

  • layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt
  • layout-tests/editing/style/block-style-004-expected.txt
  • layout-tests/editing/style/block-style-005-expected.txt
  • layout-tests/editing/style/block-style-006-expected.txt
  • layout-tests/editing/style/smoosh-styles-001-expected.txt
  • layout-tests/editing/style/smoosh-styles-002-expected.txt
1:55 PM Changeset in webkit [8650] by darin
  • 2 edits in trunk/WebCore
  • fixed Panther deployment build
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Put more stuff inside #if.
11:56 AM Changeset in webkit [8649] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3943090> REGRESSION (Mail): Spelling underline incompletely erased following certain steps

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer misspellingLineThickness]): (-[WebTextRenderer misspellingLinePatternWidth]): Replaced #defines with these methods, so others can get the same info.

(-[WebTextRenderer drawLineForMisspelling:withWidth:]):
Keep underline within originally specified bounds.

11:56 AM Changeset in webkit [8648] by harrison
  • 5 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3943090> REGRESSION (Mail): Spelling underline incompletely erased following certain steps

  • khtml/rendering/render_text.cpp: (InlineTextBox::paintMarker): Make sure underline is placed within the text bounds.
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::misspellingLineThickness):
  • kwq/WebCoreTextRenderer.h: Add misspellingLineThickness for use by InlineTextBox::paintMarker.
11:50 AM Changeset in webkit [8647] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4012978> -[DOMRange markupString] crashes when range contains only a text node with a single space
  • khtml/editing/markup.cpp: (khtml::createMarkup): Added updateLayout calls, and added a missing nil check.
9:50 AM Changeset in webkit [8646] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4005435> Safari hung while pasting text into a <textarea> (Panther-only)
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Don't setAutohidesScrollers:YES on Panther.
9:45 AM Changeset in webkit [8645] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
  • Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.
9:33 AM Changeset in webkit [8644] by kocienda
  • 3 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/4015499> REGRESSION (186-187): pasted quoted text starting with a blank line increases quote level of pasted text when pasted

  • khtml/editing/markup.cpp: (khtml::markup): Changed over to ASSERT instead of assert. (khtml::createMarkup): The issue was that the code to add parents all the way back to the common ancestor block did not check for blocks whose markup had already been added, and could result in adding markup for nodes twice (hence the additional and erroneous quote level). Now there is a new check that will only add markup for those nodes before the start of the selection range. This fixes the bug. (khtml::createFragmentFromMarkup): Changed over to ASSERT instead of assert. (khtml::createFragmentFromText): Ditto.
9:32 AM Changeset in webkit [8643] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/date_object.cpp: (timetUsingCF): Fixed indenting.
Note: See TracTimeline for information about the timeline view.