Timeline


and

03/05/05:

19:36 Changeset [8800] by kdecker

Reviewed by Darin.

Fixed: <rdar://problem/4038529> Infinite progress bar loading webcams and other sites that use multipart/x-mixed-replace

The previous patch I landed prevented us from loading multipart/x-mixed-replace but did not always update the progress bar accordingly.
This stops websites from having seemingly infinite progress in the browser UI.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): If this is "multipart/x-mixed-replace", remove the WebBaseResourceHandleDelegate client from the datasource's subresource array, otherwise -[WebDataSource isLoading] incorrectly returns YES. Also it's possible at this point in time we're done loading now (loaded everything else except for the multipart/x-mixed-replace content) so go ahead and check to see if in fact we're complete.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): ditto
17:37 Changeset [8799] by sullivan

Reviewed by Maciej.

  • fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange when composing a reply
  • khtml/editing/htmlediting.cpp: (khtml::StyleChange::checkForLegacyHTMLStyleChange): Added missing nil check.
15:35 Changeset [8798] by rjw

Fixed panther build problem. Shouldn't include
changes for 3968753 on panther.

Reviewed by John.

  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
15:20 Changeset [8797] by darin

Reviewed by Don.

  • fixed <rdar://problem/4038478> Crash in renderer viewing RSS feed at feed://wvs.topleftpixel.com/index.rdf
  • khtml/xml/dom_docimpl.cpp: (widgetForNode): Check for nil before going from node to renderer.
15:08 Changeset [8796] by darin

Reviewed by Richard.

  • fixed <rdar://problem/4037700> Every character typed causes stat call for /usr/share/icu/icudt32b_char.brk
  • khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Added. Helper that sets up an iterator for the passed-in text. Shares a single global iterator (fast, albeit not thread-safe). (RenderText::previousOffset): Changed to call getCharacterBreakIterator. (RenderText::nextOffset): Ditto.
14:40 Changeset [8795] by kocienda

Reviewed by Darin

Fix for this bug:

<rdar://problem/4038267> REGRESSION (Mail): Crash copying and pasting end of paragraph

Code to handle content that has a "logical" newline at the end of the pasted content, and the code
to adjust the selection at the end of the paste operation made an assumption that at least one
node had been inserted by the paste command. This is not necessarily true in the case where the sole content
in the pasted content is one of these "logical" newlines. Adjust some code around so that we don't deref
null, but still adjust the selection correctly for this case. In each of the two functions below, some
null checks have been added, and some code has been rearranged a little bit to continue on through
the end of completeHTMLReplacement, even if no nodes have been inserted. The patch looks bigger and more
complicated than the conceptual change.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply) (khtml::ReplaceSelectionCommand::completeHTMLReplacement)
  • layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-4038267-fix.html: Added.
11:20 Changeset [8794] by darin

Reviewed by John.

  • fixed <rdar://problem/4025918> images copied from Safari with relative src URLs aren't pasted into Mail messages (KURL resolves base URLs incorrectly)
  • kwq/KWQKURL.mm: (KURL::KURL): Add a slash at the start of the path if a relative part is adding a path onto a URL that has "pre-path" bits like host name, but no path yet. This doesn't come up for http because in that case we add a trailing "/" as part of canonicalization.
11:17 Changeset [8793] by darin

Reviewed by John.

  • fixed <rdar://problem/4034603> REGRESSION (185-188): RadarWeb can't send enclosures anymore
  • WebView.subproj/WebFormDataStream.m: (closeCurrentStream): Release currentData when closing the stream. (advanceCurrentStream): Set up and retain currentData when the current stream is reading that data, so the data won't be released while in use. (formCreate): Initialize currentData to NULL.
  • fixed <rdar://problem/4037562> Tiger8A402: Help Viewer crashed when viewing help for iChat (infinite recursion in WebView)
  • WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): Check for the case where we ourselves are the responder. This avoids an infinite loop. The actual code to perform operations avoids this with a global variable, but this lighter weight solution is sufficient here because validate operations don't call through to the next responder.
07:39 Changeset [8792] by sullivan

Rolled out a couple of assertion-related changes I accidentally checked in.

03/04/05:

19:15 Changeset [8791] by kali
  • forgot to check this in for the previous fix
17:50 Changeset [8790] by sullivan

Reviewed by Kevin.

  • fixed <rdar://problem/4033705> REGRESSION (Mail): Copy/Paste from Excel crashes Mail in KWQKHTMLPart::fontForSelection(bool*) const + 232
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Check for nil startNode, not just nil renderer.
17:33 Changeset [8789] by rjw

Fixed <rdar://problem/3968753> REGRESSION: Poor performance with differing multiple animated GIFs (was fast in Panther)

Disable coalesced updates (in CG). This restores the
panther behavior.

Reviewed by David Harrison.

  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
17:28 Changeset [8788] by adele

Reviewed by Darin.

  • English.lproj/StringsNotToBeLocalized.txt: added new strings "text/x-vcf" and "text/x-csv" to the list
17:17 Changeset [8787] by harrison

Reviewed by Ken, Richard.

<rdar://problem/3996383> REGRESSION (Mail): Deleting all of first line also deletes line ending

Problem was the placeholder check was based on 0 height block, but the block in this
case is the BODY, which has other content even though the paragraph is gone.

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholder): Now does insert instead of append!

(khtml::CompositeEditCommand::appendBlockPlaceholder):
New. Actually does append.

(khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded):
Renamed from insertBlockPlaceholderIfNeeded because it can insert or append. Also accepts "force insert" flag.

(khtml::CompositeEditCommand::removeBlockPlaceholder):
Renamed for succinctness from removeBlockPlaceholderIfNeeded.

(khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
(khtml::DeleteSelectionCommand::moveNodesAfterNode):
Use renamed methods.

(khtml::DeleteSelectionCommand::doApply):
Use addBlockPlaceholderIfNeeded "force insert" flag if deleting whole paragraphs did not leave an empty one.

(khtml::InsertParagraphSeparatorCommand::doApply):
(khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
(khtml::InsertTextCommand::input):
Use renamed methods.

  • khtml/editing/htmlediting.h: Renamed and new methods per above.
17:02 Changeset [8786] by cblu

Fixed: <rdar://problem/4032840> REGRESSION (Mail): crash in RemoveNodeCommand after pasting attachment at end of message

Reviewed by darin.

  • khtml/editing/visible_units.cpp: (khtml::endOfParagraph): don't consider text nodes that have no rendered characters
16:02 Changeset [8785] by adele

Reviewed by Chris.

Fix for <rdar://problem/4032982> Sun iPlanet app: not able to import AddressBook CSV format addresses properly
Fix for <rdar://problem/4032985> Sun iPlanet app: not able to import vCard format addresses properly

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-csv" and "text/x-vcf" to the list of MIME types that our text view doesn't handle
15:59 Changeset [8784] by rjw

Fixed <rdar://problem/4034764> REGRESSION(125-188)Viewing text/plain page and going back/forward corrupts HTML pages (google.com)

The parse mode wasn't be restored to the document when going
back.

Reviewed by Hyatt.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]):
14:47 Changeset [8783] by darin

Rolled in changes from Tiger for IDN spoofing.

2005-03-04 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
  • Resources/IDNScriptWhiteList.txt: Added.
  • WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
  • Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

2005-02-21 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
  • Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.
14:47 Changeset [8782] by kocienda

Reviewed by me

  • layout-tests/editing/style/create-block-for-style-012-expected.txt: Shame on me! I landed my last fix without running layout tests. This one changes in a subtle, but acceptable way.
14:32 Changeset [8781] by kocienda

Reviewed by Harrison

Fix for this bug:

<rdar://problem/4032543> REGRESSION (Mail): Mail hangs when quoted text is pasted twice

This code change fixes the bug in a non-obvious way. The root cause of the problem was
that a VisiblePosition created using an affinity originating in Mail code caused
two VisiblePosition objects that should have been equal to differ only in their
affinities, which in turn caused us to run a code path that should not have run.

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Added copy constructor. (khtml::VisiblePosition::next): Factored out inline code that used to be here into new setAffinityUsingLinePosition() function. (khtml::isEqualIgnoringAffinity): New helper to handle cases when affinity in equality check does not matter. However, we want to know about such cases where a VisiblePosition differs only by affinity, and the code will assert in development when this happens. (khtml::isNotEqualIgnoringAffinity): Ditto, but not. :) (khtml::setAffinityUsingLinePosition): New helper function mentioned above. This will "correct" upstream affinity to downstream if the affinity does not make a difference for the position.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h: Wacky bug. The operator== for this class took VisiblePosition classes!
  • khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): Now performs equality check without regard to affinity. (khtml::isEndOfParagraph): Ditto. (khtml::isStartOfBlock): Ditto. (khtml::isEndOfBlock): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Adjusts the affinity using setAffinityUsingLinePosition() if necessary.
14:24 Changeset [8780] by darin

WebCore:

Reviewed by John.

  • fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
  • khtml/editing/htmlediting.h: Added insertTextRunWithoutNewlines.
  • khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Added assertion to make sure strings with newlines don't get down to this level. (khtml::TypingCommand::insertText): Added. Takes the name of the old function, but is a new level that breaks runs into lines and inserts each one separately. (khtml::TypingCommand::insertTextRunWithoutNewlines): Renamed old insertText to this.
  • khtml/dom/dom_string.h: Made substring be a const member function.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Made this const.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Merged _handleKillRing behavior into this function, since there's now a more-complicated way the startNewKillRingSequence boolean needs to be handled. Set the startNewKillRingSequence boolean after the entire process so changing the selection before and during the editing dosn't clear it. Also change "isTypingAction" parameter to "deletionAction" so we can handle forward delete with this method. (-[WebHTMLView _deleteSelection]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Refactor to use the _deleteRange method above. Also calls _shouldDeleteRange: for the pre-existing selection case; not doing that before was a bug. (-[WebHTMLView deleteToMark:]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter.
11:37 Changeset [8779] by darin

WebCore:

Reviewed by John.

  • fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
  • khtml/css/css_valueimpl.cpp: (DOM::isLegalIdentifier): Added. Commented out and not used. (DOM::quoteStringIfNeeded): Quotes the string if needed. For now only if it starts with "#". (DOM::CSSPrimitiveValueImpl::cssText): Call quoteStringIfNeeded when asked for cssText for an arbitrary string, since we need text you can re-parse. (DOM::FontFamilyValueImpl::cssText): Ditto.
  • khtml/editing/markup.cpp: (khtml::startMarkup): Added comments about lack of quoting for attributes. (khtml::createMarkup): Ditto.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Quote font name when calling setFontFamily. (-[WebHTMLView _addToStyle:fontA:fontB:]): Ditto.
11:16 Changeset [8778] by adele

Reviewed by Maciej

Fix for <rdar://problem/4021711> REGRESSION(125-188) blank pages when browsing forum at cooperativeresearch.org - cached external script problem

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): set flag needToRefCachedScript so we can make sure notifyFinished is called after pendingSrc is set up with the right data from the cached script
09:54 Changeset [8777]

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

09:54 Changeset [8776] by darin

Reviewed by John.

  • fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
  • Resources/IDNScriptWhiteList.txt: Added.
  • WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
  • Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
09:37 Changeset [8775] by darin

Reviewed by John.

  • fixed <rdar://problem/3937667> REGRESSION (Mail): Zooming a window from titlebar button doesn't paint newly-exposed portions of window
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Re-set-up the visRect if the bounds changes due to layout.
09:18 Changeset [8774] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4029632> Tiger 8A398:- Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): VisiblePosition constructor was failing to yield a position for a node just pasted into the document since a layout was needed for the calculation to come out right. Layout added. Crash gone.
00:58 Changeset [8773] by kali
  • made RenderText::caretRect handle BIDI text correctly in its calculations (3587614)

03/03/05:

23:45 Changeset [8772] by vicki

versioning for TOT, Safari 2.0 (v402+). The tree is open.

23:38 Changeset [8771]

This commit was manufactured by cvs2svn to create tag 'Safari-302'.

23:38 Changeset [8770] by vicki

versioning for SUPanWheat, Safari 1.3 (v302)

23:29 Changeset [8769]

This commit was manufactured by cvs2svn to create tag 'Safari-402'.

23:29 Changeset [8768] by vicki

Safari-402 stamp

17:22 Changeset [8767] by cblu

Fixed: <rdar://problem/3992803> Cannot navigate through list items with the keyboard, you're stuck in the same <li> block unless you click out

Reviewed by harrison.

  • khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos): avoid returning list markers when possible. Also improved heuristic for returning the best InlineBox given the passed X position.
16:05 Changeset [8766] by jens

<rdar://problem/3991818> REGRESSION: Images scale while loading

15:54 Changeset [8765] by hyatt

Fix for 3841186, scrollbar shows up disabled when it should not appear at all. Make sure updateScrollers
is never allowed to be re-entrant from any call point by moving the guard inside the function itself.

Reviewed by John Sullivan

  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
15:08 Changeset [8764] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4035198> Pasting text with different styles does not get reproducible results

I had a good idea yesterday to improve the way we "fixup" styles after
pasting, but i chose a poor data structure to do it, a map of
nodes-to-styles. In the fixup step, I iterated over the map elements and
did the fixup. However, since the order in which the items would come
out of the map is indeterminate, we got unpredictable results.

So, the concept was good, but the implementation was flawed. I have
fixed this mapping to be a list instead, so the order that nodes are
evaluated in the fixup step is document order. This works nicely.

  • khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::~ReplacementFragment): No longer need to explicity deref nodes and styles saved away for later fixup. This is now handled by the new NodeDesiredStyle class. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. Now accepts a QValueList<NodeDesiredStyle> in place of the old map. (khtml::NodeDesiredStyle::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::NodeDesiredStyle::~NodeDesiredStyle): Ditto. (khtml::NodeDesiredStyle::operator=): Ditto. (khtml::ReplaceSelectionCommand::doApply): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Now operates on a QValueList<NodeDesiredStyle> in place of the old map. (khtml::computeAndStoreNodeDesiredStyle): Renamed from mapDesiredStyleForNode. Now operates on a QValueList<NodeDesiredStyle> in place of the old map.
  • khtml/editing/htmlediting.h: (khtml::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::ReplacementFragment::desiredStyles): Now returns a QValueList<NodeDesiredStyle> in place of the old map.
  • layout-tests/editing/style/typing-style-003-expected.txt: Results changed in an acceptable way.

03/02/05:

17:13 Changeset [8763] by cblu

Fixed: <rdar://problem/4029010> Expose method to retrieve drag image for WebView's selection

Reviewed by sullivan.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): call _selectionDraggingImage (-[WebHTMLView _selectionDraggingImage]): new SPI for Mail, factored from previous method (-[WebHTMLView _selectionDraggingRect]): new SPI for Mail
  • WebView.subproj/WebHTMLViewPrivate.h:
17:12 Changeset [8762] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/4029741> REGRESSION (188-189): <input type=text> are cleared when you hide/show them
  • khtml/html/html_formimpl.h: Added detach functions for both input and text area elements, since both have m_valueMatchesRenderer flags.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::detach): Set m_valueMatchesRenderer to false, since the renderer is going away. (DOM::HTMLTextAreaElementImpl::detach): Ditto.
17:00 Changeset [8761] by kocienda

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4006151> in reply, caret moves to next line after toggling bold style then typing

  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::applyInlineStyle): Defer cleaning up empty style until the end of the function. In some situations, the render tree can get confused when we do this removal up front. I wish I understood the reasons more deeply, but this bit of code shuffling seems harmless, and fixes the bug.
16:59 Changeset [8760] by darin

Roll out two files I just checked in by accident.

16:58 Changeset [8759] by darin

Reviewed by Maciej.

  • fixed <rdar://problem/4024966> crash happened twice in [KWQTextField setHasFocus:] + 0xe8

Added more nil checks to the widget implementations. Anywhere a widget pointer is used, do a nil check,
rather than relying on high level assumptions about which calls can and can't destroy the HTML element
(and hence the widget). The case in the bug seems to be a case where scrolling destroyed the element.
We can't be sure this fixes the bug, but we can be relatively sure we didn't introduce any new problems,
because this just avoids nil-dereferencing.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): (-[KWQButton nextKeyView]): (-[KWQButton previousKeyView]):
  • kwq/KWQListBox.mm: (-[KWQTableView mouseDown:]): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView numberOfRowsInTableView:]): (-[KWQTableView tableViewSelectionDidChange:]): (-[KWQTableView tableView:shouldSelectRow:]): (-[KWQTableView selectionShouldChangeInTableView:]):
  • kwq/KWQScrollBar.mm: (-[KWQScrollBar scroll:]):
  • kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider slide:]): (-[KWQSlider becomeFirstResponder]): (-[KWQSlider nextKeyView]): (-[KWQSlider previousKeyView]):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView mouseDown:]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setHasFocus:]):
16:38 Changeset [8758] by rjw

Fixed <rdar://problem/4031483> Leak (RenderObject::createInlineBox) reproducible with Stock widget

We were leaking inline block line boxes. Argh!

Reviewed by Hyatt.

  • khtml/rendering/render_flow.cpp: (RenderFlow::dirtyLineBoxes):
  • khtml/rendering/render_line.cpp: (khtml::InlineBox::deleteLine):
16:31 Changeset [8757] by cblu

Fixed: <rdar://problem/3976872> REGRESSION (Mail): Pasted plain text doesn't get the proper style if pasted into newlines

Reviewed by kocienda.

  • khtml/editing/htmlediting.cpp: (khtml::EditCommand::styleAtPosition): new, factored out from calculateStyleBeforeInsertion (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): call styleAtPosition (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand): clear new m_insertionStyle ivar (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand): deref new m_insertionStyle ivar (khtml::ReplaceSelectionCommand::doApply): store the style so it later be applied when matching style (khtml::ReplaceSelectionCommand::completeHTMLReplacement): apply style from m_insertionStyle when matching style
  • khtml/editing/htmlediting.h:
16:30 Changeset [8756] by mjs

Reviewed by Darin.

<rdar://problem/4031718> REGRESSION (401-401+): Safari reproducible crash setting up scope in JSLazyEventListener::parseCode authenticating to bugweb

  • khtml/ecma/kjs_events.cpp: (JSLazyEventListener::parseCode): If originalNode is NULL, don't mess with the scope chain.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseHTMLAttribute): For handlers that are delcared on body but set on the document, pass NULL to avoid swizzling the scope chain. It turns out that this is what browsers do, and it finesses the crash.
16:10 Changeset [8755] by sullivan

Reviewed by Adele.

  • fixed <rdar://problem/4023337> Safari stops loading any page (-[NSCFDictionary setObject:forKey:]: attempt to insert nil key)

It is very likely that the exception being hit is caused by the same problem as WebFoundation
bug 4018486. This change makes the code robust against this kind of problem regardless.

  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate saveResource]): Don't call addSubresource if newly-created resource is nil (but do assert on debug builds). Also assert that originalURL and MIMEType are not nil.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource addSubresource:]): Don't add nil subresource to dictionary, but do assert on debug builds.
14:59 Changeset [8754] by harrison

Reviewed by Ken.

<rdar://problem/3948453> Can't type accented chars as first character in Stickies widget

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply):
14:05 Changeset [8753] by rjw

Fixed comment in ChangeLog.

12:58 Changeset [8752] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4020574> REGRESSION (Mail): copy/paste first part of reply-quoted text alters downstream style

The problem was that the operation to move nodes following the newly-pasted nodes did not preserve the
style of these moved nodes. I have generalized some of the functions that compute and preserve styles
for nodes and then apply these styles after a DOM operation.

  • khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::~ReplacementFragment): Call new derefNodesAndStylesInMap() helper function in place of old code that had this deref'ing inline. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Now calls new mapDesiredStyleForNode() helper function place of old code that had this style computation inline. (khtml::ReplacementFragment::removeStyleNodes): Updated comment for new helper name. (khtml::ReplaceSelectionCommand::doApply): Now calls new helpers in place of helpers whose names were changed, or in place of pre-refactored inline code. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Renamed from applyStyleToInsertedNodes(). Now generalized to take the map of nodes to use for the fixup. This makes it possible to call this code with different maps, and that is needed to fix the bug. (khtml::mapDesiredStyleForNode): New helper function to compute the inheritable styles for a given node and map this style to the given node in the given map. This function now also includes the code that was in the removeBlockquoteColorsIfNeeded(). This latter helper has now been removed. (khtml::derefNodesAndStylesInMap): Simple helper to deref map members.
  • khtml/editing/htmlediting.h: (khtml::ReplacementFragment::desiredStyles): New helper to return map of nodes-to-desiredStyles.
11:52 Changeset [8751] by vicki

move changes for rdar://problem/4003774 and rdar://problem/3990258 above the Safari-401 release marker -- neither of these changes are included in Safari-401

09:12 Changeset [8750] by kocienda

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4011358> REGRESSION(Mail): after dragging text to mail message and deleting, typing or dragging new text doesn't work

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::isCandidate): Insertion point disappearing was due to a failed check here after deleting all the content in the body element. The special "empty block" needs to add check for DOM children. A block may have straggling anonymous render children in
some cases, and so the check needs to be (!DOM-kids
!render-kids).

Also, I botched the last checkin trying to split these two patches in my tree. Wrong layout tests
got checked in, I checked in a conflict marker in the Changelog, etc. I fixed everything with this checkin.

09:08 Changeset [8749] by kocienda

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/4011358> REGRESSION(Mail): after dragging text to mail message and deleting, typing or dragging new text doesn't work

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::isCandidate): Insertion point disappearing was due to a failed check here after deleting all the content in the body element. The special "empty block" needs to add check for DOM children. A block may have straggling anonymous render children in
some cases, and so the check needs to be (!DOM-kids
!render-kids).
09:04 Changeset [8748] by kocienda

2005-03-01 Ken Kocienda <kocienda@apple.com>

Reviewed by Maciej

Improved fix for this bug:

<rdar://problem/3996605> Insert paragraph command puts new block in wrong place, creating difficult-to-handle HTML

Maciej and I discussed this situation at length, and we came up with a better fix than I did earlier.

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Simplify one special case so that it only handles the "last in block" situation. Remove special case for "downstream node is in different block" and handle this case with a little bit of special code in the general insertion case.

Results studied to make sure there were no problems.

  • layout-tests/editing/deleting/delete-3959464-fix-expected.txt
  • layout-tests/editing/inserting/insert-div-001-expected.txt
  • layout-tests/editing/inserting/insert-div-002-expected.txt
  • layout-tests/editing/inserting/insert-div-004-expected.txt
  • layout-tests/editing/inserting/insert-div-005-expected.txt
  • layout-tests/editing/inserting/insert-div-009-expected.txt
  • layout-tests/editing/inserting/insert-div-014-expected.txt
  • layout-tests/editing/inserting/insert-div-018-expected.txt
  • layout-tests/editing/inserting/insert-div-024-expected.txt
  • layout-tests/editing/pasteboard/paste-text-011-expected.txt
  • layout-tests/editing/pasteboard/paste-text-013-expected.txt
  • layout-tests/editing/pasteboard/paste-text-015-expected.txt
  • layout-tests/editing/style/block-style-004-expected.txt
  • layout-tests/editing/style/block-style-005-expected.txt
  • layout-tests/editing/style/block-style-006-expected.txt

New test:

  • layout-tests/editing/inserting/insert-div-027.html
  • layout-tests/editing/inserting/insert-div-027-expected.txt

03/01/05:

20:33 Changeset [8747] by hyatt

Fix for 4030890, regression with <sup> on Google. Fix some bogus != comparison checks in verticalPositionHint.

Reviewed by John

(RenderObject::getVerticalPosition):

19:38 Changeset [8746] by cblu

Fixed: <rdar://problem/4030669> smart delete does not delete spaces from pasted content

Reviewed by rjw.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): pass true for treatNBSPAsWhiteSpace to leadingWhitespacePosition and trailingWhitespacePosition when testing whether or not we have to delete those characters as well.
  • khtml/editing/jsediting.cpp: pass true for smartDelete when the selection granularity is WORD. This allows us to write smart delete layout tests.
  • layout-tests/editing/deleting/smart-delete-001-expected.txt: Added.
  • layout-tests/editing/deleting/smart-delete-001.html: Added.
  • layout-tests/editing/deleting/smart-delete-002-expected.txt: Added.
  • layout-tests/editing/deleting/smart-delete-002.html: Added.
18:17 Changeset [8745] by rjw

Fixed <rdar://problem/4027928> Tiger_8A394:Acrobat crashes while tried to remove the subscription errors by clicking on "Would you like to remove the subscription" from Tracker details view pane

The string objects created by KWQHeaderStringFromDictionary() leaked.

Reviewed by John Louch.

  • kwq/KWQLoader.mm: (KWQHeaderStringFromDictionary):
17:38 Changeset [8744] by jens

<rdar://problem/4004531> Simple Sun Signed Applet throws exceptions; doesn't run

17:21 Changeset [8743] by rjw

Re-checkin after previously backing out:

Fixed <rdar://problem/3990258> REGRESSION (125.12-181): top of picture that spans two pages is cut off on print from Safari

The problem was due to incorrect "object truncation" in RenderFlow::paintLines.
We attempt to push objects down if they don't fit on a page at
paint time. If the attempt to push object down failed we just
didn't paint at all.

Reviewed by Hyatt.

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
17:18 Changeset [8742] by vicki

versioning for TOT, Safari 2.0 (401+) -- the tree is open!

17:12 Changeset [8741]

This commit was manufactured by cvs2svn to create tag 'Safari-301'.

17:12 Changeset [8740] by vicki

versioning for SUPanWheat, Safari 1.3 (v301)

17:07 Changeset [8739]

This commit was manufactured by cvs2svn to create tag
'Safari-401-test'.

17:07 Changeset [8738]

This commit was manufactured by cvs2svn to create tag 'Safari-401'.

17:07 Changeset [8737] by vicki

Safari-401 stamp

17:00 Changeset [8736] by cblu

Backed out my patch since the tree was closed.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):
  • khtml/editing/jsediting.cpp:
16:49 Changeset [8735] by rjw

Backed out change. Tree is closed.

16:47 Changeset [8734] by rjw

Fixed <rdar://problem/3990258> REGRESSION (125.12-181): top of picture that spans two pages is cut off on print from Safari

The problem was due to incorrect "object truncation" in RenderFlow::paintLines.
We attempt to push objects down if they don't fit on a page at
paint time. If the attempt to push object down failed we just
didn't paint at all.

Reviewed by Hyatt.

  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines):
15:26 Changeset [8733] by cblu

Fixed: <rdar://problem/4030669> smart delete does not delete spaces from pasted content

Reviewed by rjw.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): pass true for treatNBSPAsWhiteSpace to leadingWhitespacePosition and trailingWhitespacePosition when testing whether or not we have to delete those characters as well.
  • khtml/editing/jsediting.cpp: pass true for smartDelete when the selection granularity is WORD. This allows us to write smart delete layout tests.
  • layout-tests/editing/deleting/smart-delete-001-expected.txt: Added.
  • layout-tests/editing/deleting/smart-delete-001.html: Added.
  • layout-tests/editing/deleting/smart-delete-002-expected.txt: Added.
  • layout-tests/editing/deleting/smart-delete-002.html: Added.
14:46 Changeset [8732] by kocienda

Reviewed by Vicki

Fix for this bug:

<rdar://problem/4030068> Trailing <return> gets eaten when pasted at the end of a document

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Add code to handle formerly-unhandled end-of-document case.
14:42 Changeset [8731] by mjs

Reviewed by Vicki.

<rdar://problem/4003774> REGRESSION(125-181): JavaScript problems @ Yankee/Dixie quiz

Reworked how scopes are set up for event handlers to match other
browser. This includes the following changes:

  • Special scope entries are set up at the time the event handler is created, not at the time it fires.
  • Special scope is only set up for event handlers set in the html source through an html attribute, not for handlers set using addEventHandler or setting JS properties like onclick through JavaScript.
  • Special scope is based on the DOM node on which the handler is an attribute, not the event target.

This fixes the regression while allowing the fix to
<rdar://problem/3798453> (DIG: getting variable with same name as
DOM element attribute gets attribute value instead) to keep
working correctly.

  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): (JSLazyEventListener::JSLazyEventListener): (JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::createHTMLEventHandler):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.cpp: (Window::getJSLazyEventListener):
  • khtml/ecma/kjs_window.h:
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseHTMLAttribute): (HTMLFrameElementImpl::parseHTMLAttribute): (HTMLFrameSetElementImpl::parseHTMLAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseHTMLAttribute):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseHTMLAttribute): (DOM::HTMLButtonElementImpl::parseHTMLAttribute): (DOM::HTMLInputElementImpl::parseHTMLAttribute): (DOM::HTMLLabelElementImpl::parseHTMLAttribute): (DOM::HTMLSelectElementImpl::parseHTMLAttribute): (DOM::HTMLTextAreaElementImpl::parseHTMLAttribute):
  • khtml/html/html_imageimpl.cpp: (HTMLImageElementImpl::parseHTMLAttribute):
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::parseHTMLAttribute):
  • khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener):
  • khtml/khtml_part.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener):
  • khtml/xml/dom_docimpl.h:
14:27 Changeset [8730] by sullivan

Reviewed by Darin.

  • fixed <rdar://problem/3987482> Format>Style>Italic is not enabled when a compose window is empty (works in Blot)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): call _updateFontPanel here so NSFontManager knows the right font for the menu items and the font panel
13:53 Changeset [8729] by harrison

Reviewed by Chris.

<rdar://problem/3915560> Mail would like an SPI to enable "smart" text paste/drop

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _smartDeleteRangeForProposedRange:]): (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): New.
13:53 Changeset [8728] by harrison

Reviewed by Chris.

<rdar://problem/3915560> Mail would like an SPI to enable "smart" text paste/drop

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge smartDeleteRangeForProposedRange:]): (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]): New.
13:15 Changeset [8727] by cblu

Fixed: <rdar://problem/4030404> selection granularity should be set when extending selection via JS

Reviewed by kocienda.

  • khtml/ecma/kjs_window.cpp: (SelectionFunc::tryCall): set the granularity on the part. This will allow us to write smart paste layout tests.
  • layout-tests/editing/pasteboard/smart-paste-001-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-001.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-002-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-002.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-003-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-003.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-004-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-004.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-005-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-005.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-006-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-006.html: Added.
  • layout-tests/editing/pasteboard/smart-paste-007-expected.txt: Added.
  • layout-tests/editing/pasteboard/smart-paste-007.html: Added.
11:16 Changeset [8726] by cblu

Fixed: <rdar://problem/4029934> smart paste with plain text can add too many spaces

Reviewed by kocienda.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): pass true for treatNBSPAsWhitespace to leadingWhitespacePosition and trailingWhitespacePosition
  • khtml/xml/dom_position.cpp: (DOM::isWS): take treatNBSPAsWhitespace param (DOM::Position::leadingWhitespacePosition): ditto (DOM::Position::trailingWhitespacePosition): ditto
  • khtml/xml/dom_position.h:
09:48 Changeset [8725] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/3996605> Insert paragraph command puts new block in wrong place, creating difficult-to-handle HTML

  • khtml/editing/htmlediting.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Look for the upstream-most block to insert after when at the visible end of a block. This helps to avoid some undesirable sequences of markup which Dave says will be vary hard to render. Changing the command in this way avoids the "limitations" of the render tree by not asking it to render markup we do not want to make anyway.

All these tests change, but either in insignificant ways, or for the better.

  • layout-tests/editing/deleting/delete-3959464-fix-expected.txt:
  • layout-tests/editing/inserting/insert-div-001-expected.txt:
  • layout-tests/editing/inserting/insert-div-002-expected.txt:
  • layout-tests/editing/inserting/insert-div-004-expected.txt:
  • layout-tests/editing/inserting/insert-div-005-expected.txt:
  • layout-tests/editing/inserting/insert-div-009-expected.txt:
  • layout-tests/editing/inserting/insert-div-024-expected.txt:
  • layout-tests/editing/pasteboard/paste-text-011-expected.txt:
  • layout-tests/editing/pasteboard/paste-text-013-expected.txt:
  • layout-tests/editing/pasteboard/paste-text-015-expected.txt:
  • layout-tests/editing/style/block-style-004-expected.txt:
  • layout-tests/editing/style/block-style-005-expected.txt:
  • layout-tests/editing/style/block-style-006-expected.txt:
  • layout-tests/editing/style/remove-underline-across-paragraph-expected.txt:
  • layout-tests/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • layout-tests/editing/style/remove-underline-after-paragraph-expected.txt:
  • layout-tests/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:

New test to check specific problem mentioned in the bug.

  • layout-tests/editing/inserting/insert-div-026-expected.txt: Added.
  • layout-tests/editing/inserting/insert-div-026.html: Added.
Note: See TracTimeline for information about the timeline view.