Timeline


and

03/07/05:

18:27 Changeset [8823] by rjw

More bullet proofing for <rdar://problem/4038304> CrashTracer: ....9 crashes at com.apple.WebKit: -[WebTextRenderer initWithFont:usingPrinterFont:] + 840

Protect against removal of Times and Times New Roman from
system. If these fonts are removed attempt to get system font
instead of FATAL_ALWAYS.

Reviewed by John.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:usingPrinterFont:]):
18:27 Changeset [8822] by sullivan

Reviewed by Darin.

  • <rdar://problem/4040868> REGRESSION (Mail, 403-403+): Drag and drop deletes text, many other bad editing problems
  • khtml/rendering/render_text.cpp: (RenderText::caretMaxOffset): A "-" should have been a "+" in this method that was tweaked an hour ago. Editing was completely horked.
17:46 Changeset [8821] by rjw

Additional nil check from fix for 4040749.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
17:38 Changeset [8820] by rjw

Additional nil check from fix for 4040749.

  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
17:30 Changeset [8819] by harrison

Reviewed by Darin.

<rdar://problem/4033202> REGRESSION (Mail): Can't arrow up at a particular spot in a particular Mail message

Doublecheck that new position is really on a different line, because the VisiblePosition constructor does not.
Filed <rdar://problem/4040763> for that problem.

  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition):
17:11 Changeset [8818] by rjw

Fixed <rdar://problem/4040749> REGRESSION (125-178): opacity style not working, breaks fading images on okcupid.com

When layers are dynamically created/removed as a result of changing opacity they weren't being correctly
sized and positioned. This happens whenever opacity goes from < 1 to 1.

Reviewed by Darin.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_layer.cpp: (RenderLayer::updateLayerPosition):
17:05 Changeset [8817]

This commit was manufactured by cvs2svn to create tag
'WebKit-125~5~7'.

17:05 Changeset [8816] by adele

versioning for Security Update 2005-003, WebKit-125.5.7

17:00 Changeset [8815] by kali
  • fixed handling of min max caret position to take into account the possibility of BIDI text (4016072)
16:24 Changeset [8814] by harrison

Reviewed by Ken.

<rdar://problem/4029225> REGRESSION (Mail): Crash if hit return after dragging in attachment - DeleteSelectionCommand::initializePositionData

Work around the fact that the height() of a BR is 0 if there are no text elements on the line, even if there are replaced elements.
Filed <rdar://problem/4040358> RenderBR height() is not accurate.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): When height is 0, double check that the placeholder is the first position on the line.
15:35 Changeset [8813] by vicki

versioning for TOT, Safari 2.0 (403+). The tree is open!

15:23 Changeset [8812]

This commit was manufactured by cvs2svn to create tag 'Safari-303'.

15:23 Changeset [8811] by vicki

versioning for SUPanWheat, Safari 1.3 (v303)

15:17 Changeset [8810]

This commit was manufactured by cvs2svn to create tag 'Safari-403'.

15:17 Changeset [8809] by vicki

Safari-403 stamp

14:36 Changeset [8808] by adele

2005-03-07 Adele Amchan <adele@apple.com>

Reviewed by Darin.

  • Resources/IDNScriptWhiteList.txt: Took out Katakana_Or_Hiragana, since the Panther version of ICU doesn't have this script.
14:04 Changeset [8807] by kocienda

Reviewed by Vicki

Fix for this bug:

<rdar://problem/4040136> Expose SPI for WebCore's functions to create document fragments from plain text and markup strings

  • kwq/DOMHTML.mm: Add two new SPI functions. (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]) (-[DOMHTMLDocument _createDocumentFragmentWithText:])
  • kwq/DOMPrivate.h: Declare the new SPI here, a privately-exported header, so Mail can make use of it.
13:18 Changeset [8806] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4039676> REGRESSION (Mail): in reply, <cr> on pasted text (without trailing newline) is eaten when pasted above date

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply): Code to "eat" a <br> element, that was creating an otherwise empty line, was running when it should not. If the content being pasted in does not end in a "logical" newline itself, then the <br> already in the content needs to be preserved. A simple one-line change now sees to this.
  • layout-tests/editing/pasteboard/paste-text-010-expected.txt: This test now has an extra, but harmless, <br> at the end of a paragraph. This makes sense given the code change.

New test:

  • layout-tests/editing/pasteboard/paste-text-018-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-text-018.html: Added.
08:19 Changeset [8805] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4035648> REGRESSION (Mail): line feed in source HTML file causes bad copy/paste behavior

The createMarkup() function in markup.cpp iterates over the nodes in a range,
and does some bookkeeping to figure out when to add close tags to the markup.
Some code added at the start of the loop to prevent markup from being written
for unrendered nodes short-circuited the rest of the loop, and so prevented
the close-tag-writing code from running when it should.

This is why the "plain" text wound up inside of the bold tag in the example
above. The addition of the unrendered return character caused an incorrect
delay in the close tag for the bold element from being written out, with the
result being that it wound up including additional content.

The fix is to add checks for node renderers throughout the loop at the points
where markup is written out for each node. This allows the additional close
tag logic to run as needed.

All layout tests pass with this change.

  • khtml/editing/markup.cpp: (khtml::createMarkup)

New test:

  • layout-tests/editing/pasteboard/paste-4035648-fix-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-4035648-fix.html: Added.

03/06/05:

19:48 Changeset [8804] by darin

Rolled in fix from Tiger for IDN spoofing.

2005-03-06 Darin Adler <darin@apple.com>

  • fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.
19:46 Changeset [8803] by darin
  • fixed obvious mistake in IDN script code (luckily it hasn't been in a submission yet!)
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Use "index" to index into the array, not "script", which is the script number, not the 32-bit-word index.
14:33 Changeset [8802] by kali
  • fixed text box search code for caret rect to properly account for BIDI text (4038674)
00:03 Changeset [8801] by kali
  • fixed problem with searching for BIDI text boxes (3587609)
  • fixed missing initalizer of RTL flag in WebCoreStyle

03/05/05:

19:36 Changeset [8800] by kdecker

Reviewed by Darin.

Fixed: <rdar://problem/4038529> Infinite progress bar loading webcams and other sites that use multipart/x-mixed-replace

The previous patch I landed prevented us from loading multipart/x-mixed-replace but did not always update the progress bar accordingly.
This stops websites from having seemingly infinite progress in the browser UI.

  • WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient didReceiveResponse:]): If this is "multipart/x-mixed-replace", remove the WebBaseResourceHandleDelegate client from the datasource's subresource array, otherwise -[WebDataSource isLoading] incorrectly returns YES. Also it's possible at this point in time we're done loading now (loaded everything else except for the multipart/x-mixed-replace content) so go ahead and check to see if in fact we're complete.
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient connection:didReceiveResponse:]): ditto
17:37 Changeset [8799] by sullivan

Reviewed by Maciej.

  • fixed <rdar://problem/4038417> Mail crashed in StyleChange::checkForLegacyHTMLStyleChange when composing a reply
  • khtml/editing/htmlediting.cpp: (khtml::StyleChange::checkForLegacyHTMLStyleChange): Added missing nil check.
15:35 Changeset [8798] by rjw

Fixed panther build problem. Shouldn't include
changes for 3968753 on panther.

Reviewed by John.

  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
15:20 Changeset [8797] by darin

Reviewed by Don.

  • fixed <rdar://problem/4038478> Crash in renderer viewing RSS feed at feed://wvs.topleftpixel.com/index.rdf
  • khtml/xml/dom_docimpl.cpp: (widgetForNode): Check for nil before going from node to renderer.
15:08 Changeset [8796] by darin

Reviewed by Richard.

  • fixed <rdar://problem/4037700> Every character typed causes stat call for /usr/share/icu/icudt32b_char.brk
  • khtml/rendering/render_text.cpp: (getCharacterBreakIterator): Added. Helper that sets up an iterator for the passed-in text. Shares a single global iterator (fast, albeit not thread-safe). (RenderText::previousOffset): Changed to call getCharacterBreakIterator. (RenderText::nextOffset): Ditto.
14:40 Changeset [8795] by kocienda

Reviewed by Darin

Fix for this bug:

<rdar://problem/4038267> REGRESSION (Mail): Crash copying and pasting end of paragraph

Code to handle content that has a "logical" newline at the end of the pasted content, and the code
to adjust the selection at the end of the paste operation made an assumption that at least one
node had been inserted by the paste command. This is not necessarily true in the case where the sole content
in the pasted content is one of these "logical" newlines. Adjust some code around so that we don't deref
null, but still adjust the selection correctly for this case. In each of the two functions below, some
null checks have been added, and some code has been rearranged a little bit to continue on through
the end of completeHTMLReplacement, even if no nodes have been inserted. The patch looks bigger and more
complicated than the conceptual change.

  • khtml/editing/htmlediting.cpp: (khtml::ReplaceSelectionCommand::doApply) (khtml::ReplaceSelectionCommand::completeHTMLReplacement)
  • layout-tests/editing/pasteboard/paste-4038267-fix-expected.txt: Added.
  • layout-tests/editing/pasteboard/paste-4038267-fix.html: Added.
11:20 Changeset [8794] by darin

Reviewed by John.

  • fixed <rdar://problem/4025918> images copied from Safari with relative src URLs aren't pasted into Mail messages (KURL resolves base URLs incorrectly)
  • kwq/KWQKURL.mm: (KURL::KURL): Add a slash at the start of the path if a relative part is adding a path onto a URL that has "pre-path" bits like host name, but no path yet. This doesn't come up for http because in that case we add a trailing "/" as part of canonicalization.
11:17 Changeset [8793] by darin

Reviewed by John.

  • fixed <rdar://problem/4034603> REGRESSION (185-188): RadarWeb can't send enclosures anymore
  • WebView.subproj/WebFormDataStream.m: (closeCurrentStream): Release currentData when closing the stream. (advanceCurrentStream): Set up and retain currentData when the current stream is reading that data, so the data won't be released while in use. (formCreate): Initialize currentData to NULL.
  • fixed <rdar://problem/4037562> Tiger8A402: Help Viewer crashed when viewing help for iChat (infinite recursion in WebView)
  • WebView.subproj/WebView.m: (-[WebView _responderValidateUserInterfaceItem:]): Check for the case where we ourselves are the responder. This avoids an infinite loop. The actual code to perform operations avoids this with a global variable, but this lighter weight solution is sufficient here because validate operations don't call through to the next responder.
07:39 Changeset [8792] by sullivan

Rolled out a couple of assertion-related changes I accidentally checked in.

03/04/05:

19:15 Changeset [8791] by kali
  • forgot to check this in for the previous fix
17:50 Changeset [8790] by sullivan

Reviewed by Kevin.

  • fixed <rdar://problem/4033705> REGRESSION (Mail): Copy/Paste from Excel crashes Mail in KWQKHTMLPart::fontForSelection(bool*) const + 232
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForSelection): Check for nil startNode, not just nil renderer.
17:33 Changeset [8789] by rjw

Fixed <rdar://problem/3968753> REGRESSION: Poor performance with differing multiple animated GIFs (was fast in Panther)

Disable coalesced updates (in CG). This restores the
panther behavior.

Reviewed by David Harrison.

  • WebView.subproj/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
17:28 Changeset [8788] by adele

Reviewed by Darin.

  • English.lproj/StringsNotToBeLocalized.txt: added new strings "text/x-vcf" and "text/x-csv" to the list
17:17 Changeset [8787] by harrison

Reviewed by Ken, Richard.

<rdar://problem/3996383> REGRESSION (Mail): Deleting all of first line also deletes line ending

Problem was the placeholder check was based on 0 height block, but the block in this
case is the BODY, which has other content even though the paragraph is gone.

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::insertBlockPlaceholder): Now does insert instead of append!

(khtml::CompositeEditCommand::appendBlockPlaceholder):
New. Actually does append.

(khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded):
Renamed from insertBlockPlaceholderIfNeeded because it can insert or append. Also accepts "force insert" flag.

(khtml::CompositeEditCommand::removeBlockPlaceholder):
Renamed for succinctness from removeBlockPlaceholderIfNeeded.

(khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
(khtml::DeleteSelectionCommand::moveNodesAfterNode):
Use renamed methods.

(khtml::DeleteSelectionCommand::doApply):
Use addBlockPlaceholderIfNeeded "force insert" flag if deleting whole paragraphs did not leave an empty one.

(khtml::InsertParagraphSeparatorCommand::doApply):
(khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply):
(khtml::InsertTextCommand::input):
Use renamed methods.

  • khtml/editing/htmlediting.h: Renamed and new methods per above.
17:02 Changeset [8786] by cblu

Fixed: <rdar://problem/4032840> REGRESSION (Mail): crash in RemoveNodeCommand after pasting attachment at end of message

Reviewed by darin.

  • khtml/editing/visible_units.cpp: (khtml::endOfParagraph): don't consider text nodes that have no rendered characters
16:02 Changeset [8785] by adele

Reviewed by Chris.

Fix for <rdar://problem/4032982> Sun iPlanet app: not able to import AddressBook CSV format addresses properly
Fix for <rdar://problem/4032985> Sun iPlanet app: not able to import vCard format addresses properly

  • WebView.subproj/WebTextView.m: (+[WebTextView unsupportedTextMIMETypes]): added "text/x-csv" and "text/x-vcf" to the list of MIME types that our text view doesn't handle
15:59 Changeset [8784] by rjw

Fixed <rdar://problem/4034764> REGRESSION(125-188)Viewing text/plain page and going back/forward corrupts HTML pages (google.com)

The parse mode wasn't be restored to the document when going
back.

Reviewed by Hyatt.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache):
  • kwq/KWQPageState.h:
  • kwq/KWQPageState.mm: (-[KWQPageState initWithDocument:URL:windowProperties:locationProperties:interpreterBuiltins:]):
14:47 Changeset [8783] by darin

Rolled in changes from Tiger for IDN spoofing.

2005-03-04 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
  • Resources/IDNScriptWhiteList.txt: Added.
  • WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
  • Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

2005-02-21 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/4016358> don't ever display IDN URLs with characters from "possible Latin look-alike" scripts
  • Misc.subproj/WebNSURLExtras.m: (containsPossibleLatinLookalikes): Added. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call containsPossibleLatinLookalikes, and if true, don't decode the host name.
14:47 Changeset [8782] by kocienda

Reviewed by me

  • layout-tests/editing/style/create-block-for-style-012-expected.txt: Shame on me! I landed my last fix without running layout tests. This one changes in a subtle, but acceptable way.
14:32 Changeset [8781] by kocienda

Reviewed by Harrison

Fix for this bug:

<rdar://problem/4032543> REGRESSION (Mail): Mail hangs when quoted text is pasted twice

This code change fixes the bug in a non-obvious way. The root cause of the problem was
that a VisiblePosition created using an affinity originating in Mail code caused
two VisiblePosition objects that should have been equal to differ only in their
affinities, which in turn caused us to run a code path that should not have run.

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::VisiblePosition): Added copy constructor. (khtml::VisiblePosition::next): Factored out inline code that used to be here into new setAffinityUsingLinePosition() function. (khtml::isEqualIgnoringAffinity): New helper to handle cases when affinity in equality check does not matter. However, we want to know about such cases where a VisiblePosition differs only by affinity, and the code will assert in development when this happens. (khtml::isNotEqualIgnoringAffinity): Ditto, but not. :) (khtml::setAffinityUsingLinePosition): New helper function mentioned above. This will "correct" upstream affinity to downstream if the affinity does not make a difference for the position.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h: Wacky bug. The operator== for this class took VisiblePosition classes!
  • khtml/editing/visible_units.cpp: (khtml::isStartOfParagraph): Now performs equality check without regard to affinity. (khtml::isEndOfParagraph): Ditto. (khtml::isStartOfBlock): Ditto. (khtml::isEndOfBlock): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:]): Adjusts the affinity using setAffinityUsingLinePosition() if necessary.
14:24 Changeset [8780] by darin

WebCore:

Reviewed by John.

  • fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
  • khtml/editing/htmlediting.h: Added insertTextRunWithoutNewlines.
  • khtml/editing/htmlediting.cpp: (khtml::InsertTextCommand::input): Added assertion to make sure strings with newlines don't get down to this level. (khtml::TypingCommand::insertText): Added. Takes the name of the old function, but is a new level that breaks runs into lines and inserts each one separately. (khtml::TypingCommand::insertTextRunWithoutNewlines): Renamed old insertText to this.
  • khtml/dom/dom_string.h: Made substring be a const member function.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::substring): Made this const.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/4036817> REGRESSION: ctrl-y broken when a line + carriage return cut
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]): Merged _handleKillRing behavior into this function, since there's now a more-complicated way the startNewKillRingSequence boolean needs to be handled. Set the startNewKillRingSequence boolean after the entire process so changing the selection before and during the editing dosn't clear it. Also change "isTypingAction" parameter to "deletionAction" so we can handle forward delete with this method. (-[WebHTMLView _deleteSelection]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter. (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Refactor to use the _deleteRange method above. Also calls _shouldDeleteRange: for the pre-existing selection case; not doing that before was a bug. (-[WebHTMLView deleteToMark:]): Pass deleteSelectionAction for action rather than NO for isTypingAction, which is the way to say the same thing using the new parameter.
11:37 Changeset [8779] by darin

WebCore:

Reviewed by John.

  • fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
  • khtml/css/css_valueimpl.cpp: (DOM::isLegalIdentifier): Added. Commented out and not used. (DOM::quoteStringIfNeeded): Quotes the string if needed. For now only if it starts with "#". (DOM::CSSPrimitiveValueImpl::cssText): Call quoteStringIfNeeded when asked for cssText for an arbitrary string, since we need text you can re-parse. (DOM::FontFamilyValueImpl::cssText): Ditto.
  • khtml/editing/markup.cpp: (khtml::startMarkup): Added comments about lack of quoting for attributes. (khtml::createMarkup): Ditto.

WebKit:

Reviewed by John.

  • fixed <rdar://problem/4020413> REGRESSION (Mail): can't use fonts with names that start with "#" in Mail (Korean fonts)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _styleFromFontAttributes:]): Quote font name when calling setFontFamily. (-[WebHTMLView _addToStyle:fontA:fontB:]): Ditto.
11:16 Changeset [8778] by adele

Reviewed by Maciej

Fix for <rdar://problem/4021711> REGRESSION(125-188) blank pages when browsing forum at cooperativeresearch.org - cached external script problem

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): set flag needToRefCachedScript so we can make sure notifyFinished is called after pendingSrc is set up with the right data from the cached script
09:54 Changeset [8777]

This commit was manufactured by cvs2svn to create branch
'Safari-1-2-branch'.

09:54 Changeset [8776] by darin

Reviewed by John.

  • fixed <rdar://problem/3965666> IDN spoofing vulnerability caused by Unicode characters that look like ASCII characters
  • Misc.subproj/WebNSURLExtras.m: (readIDNScriptWhiteListFile): Added. Reads file and parses script names. (readIDNScriptWhiteList): Added. Calls readIDNScriptWhiteList on each of the white list locations in succession. (allCharactersInIDNScriptWhiteList): Renamed from containsPossibleLatinLookalikes and changed sense. Now calls readIDNScriptWhiteList first time, and then uses the read-in list to check the scripts. (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Call allCharactersInIDNScriptWhiteList instead of containsPossibleLatinLookalikes.
  • Resources/IDNScriptWhiteList.txt: Added.
  • WebKit.pbproj/project.pbxproj: Added IDNScriptWhiteList.txt file.
  • Misc.subproj/WebKitLocalizableStrings.m: Removed. This is simply unused.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
09:37 Changeset [8775] by darin

Reviewed by John.

  • fixed <rdar://problem/3937667> REGRESSION (Mail): Zooming a window from titlebar button doesn't paint newly-exposed portions of window
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _recursiveDisplayAllDirtyWithLockFocus:visRect:]): Re-set-up the visRect if the bounds changes due to layout.
09:18 Changeset [8774] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4029632> Tiger 8A398:- Mail crashes in DOM::NodeImpl::isBlockFlow() after pasting text with alignment style and BR element from Safari

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): VisiblePosition constructor was failing to yield a position for a node just pasted into the document since a layout was needed for the calculation to come out right. Layout added. Crash gone.
00:58 Changeset [8773] by kali
  • made RenderText::caretRect handle BIDI text correctly in its calculations (3587614)

03/03/05:

23:45 Changeset [8772] by vicki

versioning for TOT, Safari 2.0 (v402+). The tree is open.

23:38 Changeset [8771]

This commit was manufactured by cvs2svn to create tag 'Safari-302'.

23:38 Changeset [8770] by vicki

versioning for SUPanWheat, Safari 1.3 (v302)

23:29 Changeset [8769]

This commit was manufactured by cvs2svn to create tag 'Safari-402'.

23:29 Changeset [8768] by vicki

Safari-402 stamp

17:22 Changeset [8767] by cblu

Fixed: <rdar://problem/3992803> Cannot navigate through list items with the keyboard, you're stuck in the same <li> block unless you click out

Reviewed by harrison.

  • khtml/rendering/render_line.cpp: (khtml::RootInlineBox::closestLeafChildForXPos): avoid returning list markers when possible. Also improved heuristic for returning the best InlineBox given the passed X position.
16:05 Changeset [8766] by jens

<rdar://problem/3991818> REGRESSION: Images scale while loading

15:54 Changeset [8765] by hyatt

Fix for 3841186, scrollbar shows up disabled when it should not appear at all. Make sure updateScrollers
is never allowed to be re-entrant from any call point by moving the guard inside the function itself.

Reviewed by John Sullivan

  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView reflectScrolledClipView:]):
15:08 Changeset [8764] by kocienda

Reviewed by John

Fix for this bug:

<rdar://problem/4035198> Pasting text with different styles does not get reproducible results

I had a good idea yesterday to improve the way we "fixup" styles after
pasting, but i chose a poor data structure to do it, a map of
nodes-to-styles. In the fixup step, I iterated over the map elements and
did the fixup. However, since the order in which the items would come
out of the map is indeterminate, we got unpredictable results.

So, the concept was good, but the implementation was flawed. I have
fixed this mapping to be a list instead, so the order that nodes are
evaluated in the fixup step is document order. This works nicely.

  • khtml/editing/htmlediting.cpp: (khtml::ReplacementFragment::~ReplacementFragment): No longer need to explicity deref nodes and styles saved away for later fixup. This is now handled by the new NodeDesiredStyle class. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. Now accepts a QValueList<NodeDesiredStyle> in place of the old map. (khtml::NodeDesiredStyle::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::NodeDesiredStyle::~NodeDesiredStyle): Ditto. (khtml::NodeDesiredStyle::operator=): Ditto. (khtml::ReplaceSelectionCommand::doApply): Now calls computeAndStoreNodeDesiredStyle, function renamed from mapDesiredStyleForNode. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Now operates on a QValueList<NodeDesiredStyle> in place of the old map. (khtml::computeAndStoreNodeDesiredStyle): Renamed from mapDesiredStyleForNode. Now operates on a QValueList<NodeDesiredStyle> in place of the old map.
  • khtml/editing/htmlediting.h: (khtml::NodeDesiredStyle): New class that represents a node-to-style mapping. (khtml::ReplacementFragment::desiredStyles): Now returns a QValueList<NodeDesiredStyle> in place of the old map.
  • layout-tests/editing/style/typing-style-003-expected.txt: Results changed in an acceptable way.
Note: See TracTimeline for information about the timeline view.