Timeline



May 2, 2005:

6:17 PM Changeset in webkit [9092] by darin
  • 16 edits
    5 adds
    73 deletes in trunk

top level:

  • move to Xcode native targets and stop checking in generated files
  • configure.in: Removed gperf and yacc sections, and all the makefile paths for subdirectories of JavaScriptCore and WebCore, since those directories no longer have makefiles.

Tools:

  • move to Xcode native targets and stop checking in generated files
  • CommitLogEditor/CommitLogEditor.pbproj/project.pbxproj: Updated to use native targets.
  • CommitLogEditor/Info.plist: Added. Native targets use a separate file for this.
  • HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: Updated to use native targets.
  • HotSpotFinder/Info.plist: Added. Native targets use a separate file for this.

JavaScriptCore:

  • move to Xcode native targets and stop checking in generated files
  • JavaScriptCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
  • Info.plist: Added. Native targets use a separate file for this.
  • Makefile.am: Removed pcre and kjs SUBDIRS. Also removed code that deleted the embedded copy of this framework, since we haven't been embedding it for some time.
  • kjs/grammar_wrapper.cpp: Added. Shell used to compile grammar.cpp since we can't add a generated file easily to the list of files to be compiled.
  • kjs/.cvsignore: Removed.
  • kjs/Makefile.am: Removed.
  • kjs/array_object.lut.h: Removed.
  • kjs/date_object.lut.h: Removed.
  • kjs/grammar.cpp: Removed.
  • kjs/grammar.cpp.h: Removed.
  • kjs/grammar.h: Removed.
  • kjs/lexer.lut.h: Removed.
  • kjs/math_object.lut.h: Removed.
  • kjs/number_object.lut.h: Removed.
  • kjs/string_object.lut.h: Removed.
  • pcre/.cvsignore: Removed.
  • pcre/Makefile.am: Removed.
  • pcre/chartables.c: Removed.

WebCore:

  • move to Xcode native targets and stop checking in generated files
  • WebCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
  • Info.plist: Added. Native targets use a separate file for this.
  • Makefile.am: Removed rule to generate WebCore-combined.exp since this is now handled by the Xcode project. Removed the code to remove the embedded copy of the framework since we don't do that any more. Removed timestamp cleaning rules since we don't use those any more.
  • WebCore-tests.exp: Removed symbols that aren't really needed. The native target gives an error when you mention a nonexistent symbol, so we can't have them any more.
  • khtml/css/parser_wrapper.cpp: Added. Shell used to compile parser.cpp since we can't add a generated file easily to the list of files to be compiled.
  • .cvsignore: Removed various timestamp files.
  • WebCore-combined.exp: Removed.
  • force-clean-timestamp: Removed.
  • force-js-clean-timestamp: Removed.
  • khtml/.cvsignore: Removed.
  • khtml/Makefile.am: Removed.
  • khtml/css/.cvsignore: Removed.
  • khtml/css/Makefile.am: Removed.
  • khtml/css/cssproperties.c: Removed.
  • khtml/css/cssproperties.h: Removed.
  • khtml/css/cssvalues.c: Removed.
  • khtml/css/cssvalues.h: Removed.
  • khtml/css/parser.cpp: Removed.
  • khtml/css/parser.h: Removed.
  • khtml/css/tokenizer.cpp: Removed.
  • khtml/ecma/.cvsignore: Removed.
  • khtml/ecma/Makefile.am: Removed.
  • khtml/ecma/kjs_css.lut.h: Removed.
  • khtml/ecma/kjs_dom.lut.h: Removed.
  • khtml/ecma/kjs_events.lut.h: Removed.
  • khtml/ecma/kjs_html.lut.h: Removed.
  • khtml/ecma/kjs_navigator.lut.h: Removed.
  • khtml/ecma/kjs_range.lut.h: Removed.
  • khtml/ecma/kjs_traversal.lut.h: Removed.
  • khtml/ecma/kjs_views.lut.h: Removed.
  • khtml/ecma/kjs_window.lut.h: Removed.
  • khtml/ecma/xmlhttprequest.lut.h: Removed.
  • khtml/ecma/xmlserializer.lut.h: Removed.
  • khtml/html/.cvsignore: Removed.
  • khtml/html/Makefile.am: Removed.
  • khtml/html/doctypes.cpp: Removed.
  • khtml/html/kentities.c: Removed.
  • khtml/misc/.cvsignore: Removed.
  • khtml/misc/Makefile.am: Removed.
  • khtml/misc/htmlattrs.c: Removed.
  • khtml/misc/htmlattrs.h: Removed.
  • khtml/misc/htmltags.c: Removed.
  • khtml/misc/htmltags.h: Removed.
  • kwq/.cvsignore: Removed.
  • kwq/KWQCharsetData.c: Removed.
  • kwq/KWQColorData.c: Removed.
  • kwq/Makefile.am: Removed.

WebKit:

  • move to Xcode native targets and stop checking in generated files
  • WebKit.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
  • Info.plist: Added. Native targets use a separate file for this.
  • Plugins.subproj/npapi.m: Fixed import statement to get npapi.h from <WebKit/> rather than current directory.
  • Makefile.am: Removed timestamp cleaning rules since we don't use it any more.
  • .cvsignore: Removed various timestamp files.
  • DOM.subproj/DOM-compat.h: Removed.
  • DOM.subproj/DOM.h: Removed.
  • DOM.subproj/DOMCSS.h: Removed.
  • DOM.subproj/DOMCore.h: Removed.
  • DOM.subproj/DOMEvents.h: Removed.
  • DOM.subproj/DOMExtensions.h: Removed.
  • DOM.subproj/DOMHTML.h: Removed.
  • DOM.subproj/DOMPrivate.h: Removed.
  • DOM.subproj/DOMRange.h: Removed.
  • DOM.subproj/DOMStylesheets.h: Removed.
  • DOM.subproj/DOMTraversal.h: Removed.
  • DOM.subproj/DOMViews.h: Removed.
  • Plugins.subproj/WebScriptObject.h: Removed.
  • Plugins.subproj/npapi.h: Removed.
  • Plugins.subproj/npruntime.h: Removed.
  • copy-webcore-files-to-webkit: Removed.
  • embed-frameworks.sh: Removed.
  • force-clean-timestamp: Removed.

WebBrowser:

  • move to Xcode native targets and stop checking in generated files
  • WebBrowser.pbproj/project.pbxproj: Updated to use native target.
  • Info.plist: Added. Native targets use a separate file for this.
  • .cvsignore: Took out .DS_Store, since that's always ignored server-wide.
  • English.lproj/.cvsignore: Removed.
  • Preferences.subproj/.cvsignore: Removed.
  • Resources/.cvsignore: Removed.
  • Resources/Images/.cvsignore: Removed.

WebKitExamples:

  • move to Xcode native targets and stop checking in generated files
  • Blot/Blot.xcode/project.pbxproj: Updated to use a native target.
4:05 PM Changeset in webkit [9091] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix layout test paths.

2:37 PM Changeset in webkit [9090] by sullivan
  • 4 edits
    1 add in branches/experimental-ui-branch/WebCore

Reviewed by Chris.

Improvements to resizable textarea experiment:

  • resize image is now drawn in the resize corner
  • cursor sometimes tracks to arrow when over resize corner (but usually not)
  • cursor changes to arrow on mouse down in any case
  • Resources/textAreaResizeCorner.tiff: Added.
  • WebCore.pbproj/project.pbxproj: updated for added image file
  • kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): Rolled in a fix to this method from tip of tree since it affects the demo.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerImage]): new method, reads resize image once and caches it (-[KWQTextAreaTextView _resizeCornerRect]): new method, computes rect from image (-[KWQTextAreaTextView resetCursorRects]): overridden to attempt to make the cursor change to an arrow when over this corner. Only works sometimes, as explained in comments. (-[KWQTextAreaTextView drawRect:]): overridden to draw resize image (-[KWQTextAreaTextView mouseDown:]): now uses _resizeCornerRect, and sets cursor to arrow when pressed in resize corner
12:04 PM Changeset in webkit [9089]
  • 34 copies
    2 deletes in tags/WebCore-415~2

This commit was manufactured by cvs2svn to create tag
'WebCore-415~2'.

12:04 PM Changeset in webkit [9088] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiAtlanta - WebCore-415.2

11:54 AM Changeset in webkit [9087] by cpetersen
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Adele. Merging changes for SUTiAtlanta.

2005-04-29 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.

11:39 AM Changeset in webkit [9086] by darin
  • 2 edits
    5 adds in trunk

Reviewed by Vicki.
Added two layout tests for regression testing.

  • redid frameElement (fix for 4091082 below)

The first version lacked a security check, and was also broken.

  • khtml/ecma/kjs_window.cpp: (frameElement): Refactored into separate function; added isSafeScript check. (Window::get): Call the new frameElement function.
  • fast/frames/frameElement-frame.html: Added.
  • fast/frames/frameElement-frame-expected.txt: Added.
  • fast/frames/frameElement-iframe.html: Added.
  • fast/frames/frameElement-iframe-expected.txt: Added.
  • fast/frames/resources/frameElement-contents.html: Added.
10:11 AM Changeset in webkit [9085] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

Fix isStartOfEditableContent and isEndOfEditableContent to return actual, rather than inverted, answers.
No Radar. Found this when trying to use isEndOfEditableContent() in some new code.

  • khtml/editing/visible_units.cpp: (khtml::isStartOfEditableContent): (khtml::isEndOfEditableContent): Flip expressions.

Apr 29, 2005:

3:34 PM Changeset in webkit [9084] by darin
  • 2 edits in trunk/WebCore

Reviewed by David Harrison.

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::displayNode): Turn newlines into \n for better dumping.
1:13 PM Changeset in webkit [9083] by harrison
  • 2 edits
    2 adds in trunk

Reviewed by Darin.

<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.

  • layout-tests/editing/deleting/delete-4083333-fix-expected.txt: Added.
  • layout-tests/editing/deleting/delete-4083333-fix.html: Added.
12:10 PM Changeset in webkit [9082] by darin
  • 294 edits in trunk

Reviewed by Dave Harrison.

  • changed layout tests to dump more minimal information about caret and selection
  • kwq/KWQRenderTreeDebug.cpp: (nodePosition): Changed name; now does position relative to document. (writeSelection): Removed upstream/downstream code and changed format slightly.
  • layout-tests/editing/*-expected.txt: Regenerated in new format.
10:28 AM Changeset in webkit [9081] by darin
  • 7 edits
    4 adds in trunk

Reviewed by Chris Blumenberg.
Added two layout tests for regression testing.

  • fixed <rdar://problem/4097849> REGRESSION (162-163): importNode creates non-HTML elements, thus style attributes (and some others) don't work
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::importNode): Reorganized and partly rewrote this. The change that fixes the bug at hand is to explicitly use XHTML_NAMESPACE for HTML elements, since the old way of getting the namespace will return the null string for HTML elements, and createElementNS will not create an HTML element if passed a null string for the namespace. (DocumentImpl::processHttpEquiv): Removed some bogus getDocument() calls -- no need to call getDocument() in a document object. (DocumentImpl::attrName): Ditto. (DocumentImpl::tagName): Ditto. (DocumentImpl::setFocusNode): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::cloneNode): Moved the actual cloning here from ElementImpl::cloneNode, because XMLElementImpl already had its own version, and in here we can use createHTMLElement, which will work properly even in an XML document, and is also slightly more efficient.
  • khtml/xml/dom_nodeimpl.h: Added a namespaceURI method function to go along with localName.
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::namespaceURI): Added. Returns null string to be consistent with localName (only works on certain types of elements as documented).
  • khtml/xml/dom_elementimpl.h: Removed ElementImpl::cloneNode (see above). Added an override of namespaceURI for XMLElementImpl.
  • khtml/xml/dom_elementimpl.cpp: (XMLElementImpl::namespaceURI): Added. Returns the namespace (consistent with localName).
  • layout-tests/fast/dom/importNodeHTML.html: Added. Tests both importNode and cloneNode (for comparison).
  • layout-tests/fast/dom/importNodeHTML-expected.txt: Added.
  • layout-tests/fast/dom/importNodeXML.xhtml: Added. XML version of the same test as above. Tests a different code path, so useful to have.
  • layout-tests/fast/dom/importNodeXML-expected.txt: Added.

Apr 28, 2005:

6:13 PM Changeset in webkit [9080] by darin
  • 7 edits in trunk/WebKit

Reviewed by Maciej.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
  • WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.
5:31 PM Changeset in webkit [9079] by darin
  • 21 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
  • khtml/css/parser.cpp: Regenerated.
  • khtml/css/parser.h: Regenerated.
  • khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
  • kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
  • kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
  • kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
  • kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • WebCore-combined.exp: Regenerated.
  • WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.
5:22 PM Changeset in webkit [9078] by darin
  • 9 edits in trunk/JavaScriptCore

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
  • bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
  • kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
  • kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
  • kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
  • kjs/string_object.cpp: (replace): Ditto.
5:07 PM Changeset in webkit [9077] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix ChangeLog

5:07 PM Changeset in webkit [9076] by darin
  • 2 edits in trunk/WebCore
  • WebCore.pbproj/project.pbxproj: Add back the main_thread_malloc files, rolled out by accident.
Note: See TracTimeline for information about the timeline view.