Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 4, 2005:

11:04 PM Changeset in webkit [9116] by mjs

• 12 edits in trunk/WebCore

Reviewed by Vicki.

• renamed NodeBaseImpl to ContainerNodeImpl

• khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Avoid use of NodeBaseImpl and avoid use of obsolete checkNoOwner call, use isAncestor instead.
• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterText): Avoid gratuitous use of NodeBaseImpl.
• khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::checkNoOwner): Removed.

Ther rest is all just simple renaming.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::attach): (DocumentImpl::detach): (DocumentFragmentImpl::DocumentFragmentImpl):
• khtml/xml/dom_docimpl.h:
• khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): (ElementImpl::ElementImpl): (ElementImpl::insertedIntoDocument): (ElementImpl::removedFromDocument): (ElementImpl::attach): (ElementImpl::dump):
• khtml/xml/dom_elementimpl.h:
• khtml/xml/dom_nodeimpl.cpp: (ContainerNodeImpl::ContainerNodeImpl): (ContainerNodeImpl::~ContainerNodeImpl): (ContainerNodeImpl::firstChild): (ContainerNodeImpl::lastChild): (ContainerNodeImpl::insertBefore): (ContainerNodeImpl::replaceChild): (ContainerNodeImpl::removeChild): (ContainerNodeImpl::removeChildren): (ContainerNodeImpl::appendChild): (ContainerNodeImpl::hasChildNodes): (ContainerNodeImpl::setFirstChild): (ContainerNodeImpl::setLastChild): (ContainerNodeImpl::checkSameDocument): (ContainerNodeImpl::checkIsChild): (ContainerNodeImpl::addChild): (ContainerNodeImpl::attach): (ContainerNodeImpl::detach): (ContainerNodeImpl::insertedIntoDocument): (ContainerNodeImpl::removedFromDocument): (ContainerNodeImpl::cloneChildNodes): (ContainerNodeImpl::getElementsByTagNameNS): (ContainerNodeImpl::getUpperLeftCorner): (ContainerNodeImpl::getLowerRightCorner): (ContainerNodeImpl::getRect): (ContainerNodeImpl::setFocus): (ContainerNodeImpl::setActive): (ContainerNodeImpl::childNodeCount): (ContainerNodeImpl::childNode): (ContainerNodeImpl::dispatchChildInsertedEvents): (ContainerNodeImpl::dispatchChildRemovalEvents):
• khtml/xml/dom_nodeimpl.h:
• khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::EntityReferenceImpl::EntityReferenceImpl): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl):
• khtml/xml/dom_xmlimpl.h:

5:29 PM Changeset in webkit [9115] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4086570> Crash in JavaScriptCore with RSS Visualizer

• kjs/internal.cpp: (InterpreterImp::mark): mark staticNaN, it is usually protected by the Number prototype but there is a small window where it can get collected.

5:19 PM Changeset in webkit [9114]

• 14 copies
  2 deletes in tags/WebCore-315~2

This commit was manufactured by cvs2svn to create tag
'WebCore-315~2'.

5:19 PM Changeset in webkit [9113] by adele

• 2 edits in branches/Safari-1-3-branch/WebCore

Versioning for Oracle Seed - WebCore-315.2

5:16 PM Changeset in webkit [9112] by vicki

• 2 edits in trunk/WebCore

Reviewed by Darin.

• fix mismatched parentheses in one of the ifdefs

• khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::childrenChanged):

5:15 PM Changeset in webkit [9111] by adele

• 5 edits in branches/Safari-1-3-branch/WebCore

Merged fix for <rdar://problem/3986228> from TOT for Oracle Seed.

2005-05-04 Vicki Murley <​vicki@apple.com>

Reviewed by darin.

• fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

• khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
• khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):

5:07 PM Changeset in webkit [9110] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

• another gcc-4.0-related fix

• bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.

4:52 PM Changeset in webkit [9109] by darin

• 3 edits in trunk/WebKit

Reviewed by Dave Hyatt.

• fixed layout tests

• WebKit.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3. Because our deployment target was not set, we ran into this bug:

<rdar://problem/4108717> CTFontGetGlyphWithName doesn't work with some strings

• Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.

4:51 PM Changeset in webkit [9108] by darin

• 3 edits in trunk/WebCore

Reviewed by Dave Hyatt.

• fixed build rules to match other projects

• WebCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.

• Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.

4:50 PM Changeset in webkit [9107] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

• fixed build rules to match other projects

• JavaScriptCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.

• Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.

2:37 PM Changeset in webkit [9106] by mjs

• 2 edits in trunk/JavaScriptCore

• revert presumably accidental change to mozilla JS test expected results, this was making the tests fail.

• tests/mozilla/expected.html:

2:11 PM Changeset in webkit [9105] by vicki

• 5 edits in trunk/WebCore

Reviewed by darin.

• fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

• khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
• khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
• khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
• khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):

11:50 AM Changeset in webkit [9104] by cblu

• 6 edits in trunk/WebKit

Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value

Reviewed by john.

Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
• WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
• WebView.subproj/WebResourcePrivate.h:

May 3, 2005:

5:16 PM Changeset in webkit [9103] by hyatt

• 1 edit in trunk/WebCore/khtml/css/css_valueimpl.cpp

Fix build bustage.

5:09 PM Changeset in webkit [9102] by rjw

• 2 edits in trunk/JavaScriptCore

Fixed <rdar://problem/4102644> Crash in LiveConnect below KJS::Bindings::JavaInstance::stringValue() const

Correctly handle accessing nil objects from a Java object array.

Reviewed by John.

• bindings/jni/jni_runtime.cpp: (JavaArray::valueAt):

4:08 PM Changeset in webkit [9101] by hyatt

• 7 edits in trunk/WebCore

Normalize all our custom properties in our implementation to be -khtml (remove all the -apple).

Make sure that -apple, -khtml, and -moz are all able to be used. -apple and -moz just map to -khtml.

Add support for automatically converting -khtml-opacity to opacity (for legacy Safari 1.1 compat).

Reviewed by darin

• khtml/css/css_computedstyle.cpp: (DOM::): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
• khtml/css/cssparser.cpp: (CSSParser::parseValue):
• khtml/css/cssproperties.in:
• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty):
• khtml/css/parser.y:
• khtml/ecma/kjs_css.cpp: (cssPropertyName):

3:50 PM Changeset in webkit [9100] by darin

• 2 edits in trunk/WebCore

• fix the build

• WebCore.pbproj/project.pbxproj: Fix some SYMROOTS that should have been SYMROOT.

2:46 PM Changeset in webkit [9099] by hyatt

• 2 edits
  2 adds in trunk

Fix for 4098281, news.com missing a bunch of content. Make sure not to apply strict SGML parsing
when stripping comments out of scripts.

New test is comments-in-script.html

• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):

2:34 PM Changeset in webkit [9098] by hyatt

• 4 edits in trunk/WebCore

Remove unused notification to avoid ERROR messages spewing on the acid2 test.

Reviewed by darin

• khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest):
• khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
• khtml/rendering/render_frames.h:

1:57 PM Changeset in webkit [9097] by hyatt

• 2 adds in trunk/LayoutTests/fast/css

Adding acid2 test to layout tests.

1:55 PM Changeset in webkit [9096] by darin

• 11 edits in trunk/WebCore

Reviewed by Dave Hyatt.
No new layout tests needed.

• eliminated the bogus kMin/kMax macros that we had in addition to inline functions of the same name

• kwq/KWQKGlobal.h: Remove the kMin/kMax macros.

• khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Change type of constant so both sides of kMin calls match. (khtml::CSSStyleSelector::fontSizeForKeyword): Ditto.
• khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Ditto.

• remove unused parameter to dirtyLinesFromChangedChild for clarity

• khtml/rendering/render_object.h: Don't take the parameter.
• khtml/rendering/render_object.cpp: (RenderObject::dirtyLinesFromChangedChild): Ditto.

• khtml/rendering/render_flow.h: Don't take the parameter.
• khtml/rendering/render_flow.cpp: (RenderFlow::detach): Don't pass the parameter. (RenderFlow::dirtyLinesFromChangedChild): Don't take the parameter.

• khtml/rendering/render_text.cpp: (RenderText::detach): Don't pass the parameter.

• convert DOM::NodeImpl into an abstract base class by making a couple of functions pure virtual for clarity

• khtml/xml/dom_nodeimpl.h: Made nodeName and nodeType pure virtual.
• khtml/xml/dom_nodeimpl.cpp: Remove bodies of nodeName and nodeType.

1:47 PM Changeset in webkit [9095] by hyatt

• 13 edits in trunk/WebCore

Fix for object element to support fallback content. WIth this change Safari passes the Acid2 test.

Reviewed by Maciej

• khtml/css/html4.css:
• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::parseHTMLAttribute): (HTMLObjectElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::createRenderer): (HTMLObjectElementImpl::attach): (HTMLObjectElementImpl::detach): (HTMLObjectElementImpl::recalcStyle): (HTMLObjectElementImpl::childrenChanged): (HTMLObjectElementImpl::isURLAttribute): (HTMLObjectElementImpl::isImageType): (HTMLObjectElementImpl::renderFallbackContent):
• khtml/html/html_objectimpl.h:
• khtml/khtml_part.cpp: (KHTMLPart::requestObject): (KHTMLPart::selectFrameElementInParentIfFullySelected): (KHTMLPart::handleFallbackContent):
• khtml/khtml_part.h:
• khtml/khtmlpart_p.h: (khtml::ChildFrame::ChildFrame):
• khtml/rendering/render_frames.cpp: (RenderPartObject::RenderPartObject): (RenderPartObject::updateWidget):
• khtml/rendering/render_frames.h: (khtml::RenderPart::hasFallbackContent):
• khtml/rendering/render_replaced.cpp: (RenderReplaced::RenderReplaced):
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge mainResourceError]):

1:44 PM Changeset in webkit [9094] by hyatt

• 5 edits in trunk/WebKit

Fix object element support so that fallback content works. With this change Safari passes the Acid2 test.

Reviewed by Maciej

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):
• WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):

1:32 PM Changeset in webkit [9093] by darin

• 2 edits in trunk/WebKit

• WebView.subproj/WebUIDelegate.h: Fixed incorrect comment.

May 2, 2005:

6:17 PM Changeset in webkit [9092] by darin

• 16 edits
  5 adds
  73 deletes in trunk

top level:

• move to Xcode native targets and stop checking in generated files

• configure.in: Removed gperf and yacc sections, and all the makefile paths for subdirectories of JavaScriptCore and WebCore, since those directories no longer have makefiles.

Tools:

• move to Xcode native targets and stop checking in generated files

• CommitLogEditor/CommitLogEditor.pbproj/project.pbxproj: Updated to use native targets.
• CommitLogEditor/Info.plist: Added. Native targets use a separate file for this.

• HotSpotFinder/HotSpotFinder.pbproj/project.pbxproj: Updated to use native targets.
• HotSpotFinder/Info.plist: Added. Native targets use a separate file for this.

JavaScriptCore:

• move to Xcode native targets and stop checking in generated files

• JavaScriptCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
• Info.plist: Added. Native targets use a separate file for this.

• Makefile.am: Removed pcre and kjs SUBDIRS. Also removed code that deleted the embedded copy of this framework, since we haven't been embedding it for some time.

• kjs/grammar_wrapper.cpp: Added. Shell used to compile grammar.cpp since we can't add a generated file easily to the list of files to be compiled.

• kjs/.cvsignore: Removed.
• kjs/Makefile.am: Removed.
• kjs/array_object.lut.h: Removed.
• kjs/date_object.lut.h: Removed.
• kjs/grammar.cpp: Removed.
• kjs/grammar.cpp.h: Removed.
• kjs/grammar.h: Removed.
• kjs/lexer.lut.h: Removed.
• kjs/math_object.lut.h: Removed.
• kjs/number_object.lut.h: Removed.
• kjs/string_object.lut.h: Removed.
• pcre/.cvsignore: Removed.
• pcre/Makefile.am: Removed.
• pcre/chartables.c: Removed.

WebCore:

• move to Xcode native targets and stop checking in generated files

• WebCore.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
• Info.plist: Added. Native targets use a separate file for this.

• Makefile.am: Removed rule to generate WebCore-combined.exp since this is now handled by the Xcode project. Removed the code to remove the embedded copy of the framework since we don't do that any more. Removed timestamp cleaning rules since we don't use those any more.

• WebCore-tests.exp: Removed symbols that aren't really needed. The native target gives an error when you mention a nonexistent symbol, so we can't have them any more.

• khtml/css/parser_wrapper.cpp: Added. Shell used to compile parser.cpp since we can't add a generated file easily to the list of files to be compiled.

• .cvsignore: Removed various timestamp files.

• WebCore-combined.exp: Removed.
• force-clean-timestamp: Removed.
• force-js-clean-timestamp: Removed.
• khtml/.cvsignore: Removed.
• khtml/Makefile.am: Removed.
• khtml/css/.cvsignore: Removed.
• khtml/css/Makefile.am: Removed.
• khtml/css/cssproperties.c: Removed.
• khtml/css/cssproperties.h: Removed.
• khtml/css/cssvalues.c: Removed.
• khtml/css/cssvalues.h: Removed.
• khtml/css/parser.cpp: Removed.
• khtml/css/parser.h: Removed.
• khtml/css/tokenizer.cpp: Removed.
• khtml/ecma/.cvsignore: Removed.
• khtml/ecma/Makefile.am: Removed.
• khtml/ecma/kjs_css.lut.h: Removed.
• khtml/ecma/kjs_dom.lut.h: Removed.
• khtml/ecma/kjs_events.lut.h: Removed.
• khtml/ecma/kjs_html.lut.h: Removed.
• khtml/ecma/kjs_navigator.lut.h: Removed.
• khtml/ecma/kjs_range.lut.h: Removed.
• khtml/ecma/kjs_traversal.lut.h: Removed.
• khtml/ecma/kjs_views.lut.h: Removed.
• khtml/ecma/kjs_window.lut.h: Removed.
• khtml/ecma/xmlhttprequest.lut.h: Removed.
• khtml/ecma/xmlserializer.lut.h: Removed.
• khtml/html/.cvsignore: Removed.
• khtml/html/Makefile.am: Removed.
• khtml/html/doctypes.cpp: Removed.
• khtml/html/kentities.c: Removed.
• khtml/misc/.cvsignore: Removed.
• khtml/misc/Makefile.am: Removed.
• khtml/misc/htmlattrs.c: Removed.
• khtml/misc/htmlattrs.h: Removed.
• khtml/misc/htmltags.c: Removed.
• khtml/misc/htmltags.h: Removed.
• kwq/.cvsignore: Removed.
• kwq/KWQCharsetData.c: Removed.
• kwq/KWQColorData.c: Removed.
• kwq/Makefile.am: Removed.

WebKit:

• move to Xcode native targets and stop checking in generated files

• WebKit.pbproj/project.pbxproj: Updated to use native targets and generate all the generated files, so we don't have to check them in any more.
• Info.plist: Added. Native targets use a separate file for this.

• Plugins.subproj/npapi.m: Fixed import statement to get npapi.h from <WebKit/> rather than current directory.

• Makefile.am: Removed timestamp cleaning rules since we don't use it any more.

• .cvsignore: Removed various timestamp files.

• DOM.subproj/DOM-compat.h: Removed.
• DOM.subproj/DOM.h: Removed.
• DOM.subproj/DOMCSS.h: Removed.
• DOM.subproj/DOMCore.h: Removed.
• DOM.subproj/DOMEvents.h: Removed.
• DOM.subproj/DOMExtensions.h: Removed.
• DOM.subproj/DOMHTML.h: Removed.
• DOM.subproj/DOMPrivate.h: Removed.
• DOM.subproj/DOMRange.h: Removed.
• DOM.subproj/DOMStylesheets.h: Removed.
• DOM.subproj/DOMTraversal.h: Removed.
• DOM.subproj/DOMViews.h: Removed.
• Plugins.subproj/WebScriptObject.h: Removed.
• Plugins.subproj/npapi.h: Removed.
• Plugins.subproj/npruntime.h: Removed.
• copy-webcore-files-to-webkit: Removed.
• embed-frameworks.sh: Removed.
• force-clean-timestamp: Removed.

WebBrowser:

• move to Xcode native targets and stop checking in generated files

• WebBrowser.pbproj/project.pbxproj: Updated to use native target.
• Info.plist: Added. Native targets use a separate file for this.

• .cvsignore: Took out .DS_Store, since that's always ignored server-wide.

• English.lproj/.cvsignore: Removed.
• Preferences.subproj/.cvsignore: Removed.
• Resources/.cvsignore: Removed.
• Resources/Images/.cvsignore: Removed.

WebKitExamples:

• move to Xcode native targets and stop checking in generated files

• Blot/Blot.xcode/project.pbxproj: Updated to use a native target.

4:05 PM Changeset in webkit [9091] by darin

• 1 edit in trunk/WebCore/ChangeLog-2005-08-23

Fix layout test paths.

2:37 PM Changeset in webkit [9090] by sullivan

• 4 edits
  1 add in branches/experimental-ui-branch/WebCore

Reviewed by Chris.

Improvements to resizable textarea experiment:

• resize image is now drawn in the resize corner
• cursor sometimes tracks to arrow when over resize corner (but usually not)
• cursor changes to arrow on mouse down in any case

• Resources/textAreaResizeCorner.tiff: Added.
• WebCore.pbproj/project.pbxproj: updated for added image file

• kwq/DOMHTML.mm: (-[DOMHTMLTextAreaElement cols]): Rolled in a fix to this method from tip of tree since it affects the demo.

• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerImage]): new method, reads resize image once and caches it (-[KWQTextAreaTextView _resizeCornerRect]): new method, computes rect from image (-[KWQTextAreaTextView resetCursorRects]): overridden to attempt to make the cursor change to an arrow when over this corner. Only works sometimes, as explained in comments. (-[KWQTextAreaTextView drawRect:]): overridden to draw resize image (-[KWQTextAreaTextView mouseDown:]): now uses _resizeCornerRect, and sets cursor to arrow when pressed in resize corner

12:04 PM Changeset in webkit [9089]

• 34 copies
  2 deletes in tags/WebCore-415~2

This commit was manufactured by cvs2svn to create tag
'WebCore-415~2'.

12:04 PM Changeset in webkit [9088] by cpetersen

• 2 edits in branches/Safari-2-0-branch/WebCore

Versioning for SUTiAtlanta - WebCore-415.2

11:54 AM Changeset in webkit [9087] by cpetersen

• 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Adele. Merging changes for SUTiAtlanta.

2005-04-29 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4083333> When deleting link at end of sentence, entire sentence gets deleted

• khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData): Work around bug #4103339 (whose real fix is somewhat risky), so this fix can get into a software update.

(khtml::DeleteSelectionCommand::handleGeneralDelete):
Add isAncestor check when comparing m_downstreamEnd.node() and m_startNode.

11:39 AM Changeset in webkit [9086] by darin

• 2 edits
  5 adds in trunk

Reviewed by Vicki.
Added two layout tests for regression testing.

• redid frameElement (fix for 4091082 below)

The first version lacked a security check, and was also broken.

• khtml/ecma/kjs_window.cpp: (frameElement): Refactored into separate function; added isSafeScript check. (Window::get): Call the new frameElement function.

• fast/frames/frameElement-frame.html: Added.
• fast/frames/frameElement-frame-expected.txt: Added.
• fast/frames/frameElement-iframe.html: Added.
• fast/frames/frameElement-iframe-expected.txt: Added.
• fast/frames/resources/frameElement-contents.html: Added.

10:11 AM Changeset in webkit [9085] by harrison

• 2 edits in trunk/WebCore

Reviewed by Vicki.

Fix isStartOfEditableContent and isEndOfEditableContent to return actual, rather than inverted, answers.
No Radar. Found this when trying to use isEndOfEditableContent() in some new code.

• khtml/editing/visible_units.cpp: (khtml::isStartOfEditableContent): (khtml::isEndOfEditableContent): Flip expressions.