Timeline


and

05/07/05:

10:53 Changeset [9136]

This commit was manufactured by cvs2svn to create tag
'WebCore-415~5'.

10:53 Changeset [9135] by adele

Versioning for SUTiAtlanta - WebCore-415.5 (skipping the .4)

10:46 Changeset [9134] by adele

Merged fix for <rdar://problem/4110366> from TOT for SUTiAtlanta

2005-05-07 David Harrison <harrison@apple.com>

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
10:37 Changeset [9133] by harrison

Reviewed by John.

<rdar://problem/4110366> Deleting text at the end of email moves insertion point to the top of the document

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::handleGeneralDelete): Update m_upstreamStart when deleting m_downstreamEnd.node() if the former is no longer in the document. Better to update here than trying to recover later in calculateEndingPosition().
05:24 Changeset [9132] by harrison

Remove workaround for <rdar://problem/4103339>.

  • khtml/editing/htmlediting.cpp: (khtml::DeleteSelectionCommand::initializePositionData):
00:02 Changeset [9131] by mjs

Reviewed by Dave Harrison.

  • make StayInBlock vs DoNotStayInBlock explicit in all calls to upstream/downstream, in preparation for phasing out the DoNotStayInBlock variant.
  • khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::nodeFullySelected): (khtml::ApplyStyleCommand::nodeFullyUnselected): (khtml::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (khtml::InsertParagraphSeparatorInQuotedContentCommand::doApply): (khtml::InsertTextCommand::insertSpace): (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/markup.cpp: (khtml::createMarkup):
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition):
  • khtml/xml/dom_position.h:

05/06/05:

17:45 Changeset [9130] by harrison

Reviewed by Maciej, Darin.

<rdar://problem/4103339> VisiblePosition and PositionIterator iterators do not return positions in order

  • WebCore.pbproj/project.pbxproj: Removed dom_positioniterator.h and dom_positioniterator.cpp.
  • khtml/editing/htmlediting.cpp: Removed unused include of dom_positioniterator.h and "using" of PositionIterator.
  • khtml/editing/selection.cpp: Removed unused include of dom_positioniterator.h.
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::downstreamDeepEquivalent): Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of duplicated code.
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::maxDeepOffset): Added to support Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
  • khtml/xml/dom_position.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::previous): (DOM::Position::next): (DOM::Position::atStart): (DOM::Position::atEnd): Moved here, replacing VisiblePosition's duplicate and PositionIterator. Fixed to return positions in order and not skip positions.

(DOM::Position::previousCharacterPosition):
(DOM::Position::nextCharacterPosition):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

(DOM::isStreamer):
(DOM::Position::upstream):
(DOM::Position::downstream):
Use Position::next(), Position::previous(), Position::atStart(), Position::atEnd() instead of PositionIterator.

  • khtml/xml/dom_positioniterator.cpp: Removed.
  • khtml/xml/dom_positioniterator.h: Removed. Removed in favor of Position::next(), Position::previous(), Position::atStart(), Position::atEnd()
13:40 Changeset [9129] by mjs

Reviewed by Darin.

<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively

Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.

  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
  • khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
  • khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
  • khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
  • khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
  • khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
12:39 Changeset [9128] by darin

top level:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • configure.in: Update code to set up Xcode build directory instead of setting the Project Builder build directory.
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tools:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • CommitLogEditor/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • HotSpotFinder/Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • jst/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

JavaScriptCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

Tests:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.
  • TestBindingsPlugin/Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebCore:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebKit:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

WebBrowser:

Reviewed by Maciej.

  • make building multiple trees with make work better
  • Makefile.am: Set up Xcode build directory before invoking xcodebuild.

05/05/05:

13:24 Changeset [9127] by hyatt

Eliminate the FOUCS on wired.com. innerWidth and innerHeight on window should not do a layout that ignores
pending stylesheets, since even if stylesheets are loading the correct window dimensions can be determined with
a normal layout.

The radar # is 4109888.

Reviewed by rjw

  • khtml/ecma/kjs_window.cpp: (Window::get): (Window::updateLayout):
  • khtml/ecma/kjs_window.h:
11:35 Changeset [9126] by hyatt

Fix for 4109667, sIFR flash replacement technique often malfunctions. This bug occurs when the plugin
widget update causes the onload for the document to fire. Because you can be in the middle of a style
recalc when doing an attach (in response to a stylesheet load), the onload fires in the middle of the attach
process when the tree is in a bogus state.

The fix is to add a bit to the document that tells style recalc that the implicitClose() method was invoked
during the style recalc process and the code has been patched so that when this situation occurs, the close is
deferred until after the style recalc has finished.

Reviewed by John Sullivan

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::recalcStyle): (DocumentImpl::implicitClose):
  • khtml/xml/dom_docimpl.h:
  • layout-tests/fast/dynamic/flash-replacement-test.html: Added.
11:28 Changeset [9125]

This commit was manufactured by cvs2svn to create tag
'WebCore-415~3'.

11:28 Changeset [9124] by adele

Versioning for SUTiAtlanta - WebCore-415.3

11:27 Changeset [9123] by adele

Merging fix for <rdar://problem/4109564> from TOT for SUTiAtlanta.

2005-05-05 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
  • khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
11:13 Changeset [9122]

This commit was manufactured by cvs2svn to create tag
'WebCore-315~3'.

11:13 Changeset [9121] by adele

Versioning for Oracle Seed - WebCore-315.3

11:11 Changeset [9120] by adele

Merged fix for <rdar://problem/4065447> from TOT for Oracle Seed.

2005-04-20 Vicki Murley <vicki@apple.com>

Reviewed by hyatt.

  • fixed <rdar://problem/4065447> support outerHTML on IMG elements
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterHTML):
10:55 Changeset [9119] by darin

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4109564> REGRESSION (Atlanta): maps.google.com doesn't always center California correctly
  • khtml/ecma/kjs_events.cpp: (offsetFromTarget): Fix two places that said X where they should say Y.
10:01 Changeset [9118] by harrison

Reviewed by me.

Restore fixed setEndingSelection. Fixed method was ifdef'd out
because change was at end of Tiger development, but method is
unused. You just can never be _too_ safe.

  • khtml/editing/htmlediting.cpp: (khtml::EditCommandPtr::setEndingSelection):
09:09 Changeset [9117] by sullivan

Reviewed by Chris.

  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _resizeCornerRect]): Get corner rect from enclosing clipView, rather than using visibleRect. VisibleRect would return the wrong result when the textarea was clipped by the bottom of the window, leading to redraw schmutz among other things.

05/04/05:

23:04 Changeset [9116] by mjs

Reviewed by Vicki.

  • renamed NodeBaseImpl to ContainerNodeImpl
  • khtml/ecma/kjs_dom.cpp: (DOMNodeProtoFunc::tryCall): Avoid use of NodeBaseImpl and avoid use of obsolete checkNoOwner call, use isAncestor instead.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setOuterText): Avoid gratuitous use of NodeBaseImpl.
  • khtml/xml/dom_nodeimpl.cpp: (NodeBaseImpl::checkNoOwner): Removed.

Ther rest is all just simple renaming.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::attach): (DocumentImpl::detach): (DocumentFragmentImpl::DocumentFragmentImpl):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::AttrImpl): (ElementImpl::ElementImpl): (ElementImpl::insertedIntoDocument): (ElementImpl::removedFromDocument): (ElementImpl::attach): (ElementImpl::dump):
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_nodeimpl.cpp: (ContainerNodeImpl::ContainerNodeImpl): (ContainerNodeImpl::~ContainerNodeImpl): (ContainerNodeImpl::firstChild): (ContainerNodeImpl::lastChild): (ContainerNodeImpl::insertBefore): (ContainerNodeImpl::replaceChild): (ContainerNodeImpl::removeChild): (ContainerNodeImpl::removeChildren): (ContainerNodeImpl::appendChild): (ContainerNodeImpl::hasChildNodes): (ContainerNodeImpl::setFirstChild): (ContainerNodeImpl::setLastChild): (ContainerNodeImpl::checkSameDocument): (ContainerNodeImpl::checkIsChild): (ContainerNodeImpl::addChild): (ContainerNodeImpl::attach): (ContainerNodeImpl::detach): (ContainerNodeImpl::insertedIntoDocument): (ContainerNodeImpl::removedFromDocument): (ContainerNodeImpl::cloneChildNodes): (ContainerNodeImpl::getElementsByTagNameNS): (ContainerNodeImpl::getUpperLeftCorner): (ContainerNodeImpl::getLowerRightCorner): (ContainerNodeImpl::getRect): (ContainerNodeImpl::setFocus): (ContainerNodeImpl::setActive): (ContainerNodeImpl::childNodeCount): (ContainerNodeImpl::childNode): (ContainerNodeImpl::dispatchChildInsertedEvents): (ContainerNodeImpl::dispatchChildRemovalEvents):
  • khtml/xml/dom_nodeimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::EntityImpl): (DOM::EntityReferenceImpl::EntityReferenceImpl): (DOM::NotationImpl::NotationImpl): (DOM::ProcessingInstructionImpl::ProcessingInstructionImpl):
  • khtml/xml/dom_xmlimpl.h:
17:29 Changeset [9115] by mjs

Reviewed by Darin.

<rdar://problem/4086570> Crash in JavaScriptCore with RSS Visualizer

  • kjs/internal.cpp: (InterpreterImp::mark): mark staticNaN, it is usually protected by the Number prototype but there is a small window where it can get collected.
17:19 Changeset [9114]

This commit was manufactured by cvs2svn to create tag
'WebCore-315~2'.

17:19 Changeset [9113] by adele

Versioning for Oracle Seed - WebCore-315.2

17:16 Changeset [9112] by vicki

Reviewed by Darin.

  • fix mismatched parentheses in one of the ifdefs
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::childrenChanged):
17:15 Changeset [9111] by adele

Merged fix for <rdar://problem/3986228> from TOT for Oracle Seed.

2005-05-04 Vicki Murley <vicki@apple.com>

Reviewed by darin.

  • fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
  • khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
17:07 Changeset [9110] by darin

Reviewed by Dave Hyatt.

  • another gcc-4.0-related fix
  • bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.
16:52 Changeset [9109] by darin

Reviewed by Dave Hyatt.

  • fixed layout tests
  • WebKit.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3. Because our deployment target was not set, we ran into this bug:

<rdar://problem/4108717> CTFontGetGlyphWithName doesn't work with some strings

  • Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
16:51 Changeset [9108] by darin

Reviewed by Dave Hyatt.

  • fixed build rules to match other projects
  • WebCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.
  • Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
16:50 Changeset [9107] by darin

Reviewed by Dave Hyatt.

  • fixed build rules to match other projects
  • JavaScriptCore.pbproj/project.pbxproj: Set deployment target to 10.3 in the build styles. When built without a build style (by Apple B&I) we want to get the target from the environment. But when built with a build style (by Safari engineers and others), we want to use 10.3.
  • Makefile.am: Took out extra parameters that make command-line building different from Xcode building. Now that this is fixed, you should not get a full rebuild if you switch from command line to Xcode or back.
14:37 Changeset [9106] by mjs
  • revert presumably accidental change to mozilla JS test expected results, this was making the tests fail.
  • tests/mozilla/expected.html:
14:11 Changeset [9105] by vicki

Reviewed by darin.

  • fixed <rdar://problem/3986228> Not able to load additional script blocks dynamically

Run scripts when they're inserted into the document. Use createdByParser bit to make sure
that scripts aren't run twice, once while parsing and again when inserting.

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::HTMLScriptElementImpl): (HTMLScriptElementImpl::~HTMLScriptElementImpl): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::removedFromDocument): (HTMLScriptElementImpl::notifyFinished):
  • khtml/html/html_headimpl.h: (DOM::HTMLScriptElementImpl::setCreatedByParser):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::startElement):
11:50 Changeset [9104] by cblu

Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value

Reviewed by john.

Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
  • WebView.subproj/WebResourcePrivate.h:

05/03/05:

17:16 Changeset [9103] by hyatt

Fix build bustage.

17:09 Changeset [9102] by rjw

Fixed <rdar://problem/4102644> Crash in LiveConnect below KJS::Bindings::JavaInstance::stringValue() const

Correctly handle accessing nil objects from a Java object array.

Reviewed by John.

  • bindings/jni/jni_runtime.cpp: (JavaArray::valueAt):
16:08 Changeset [9101] by hyatt

Normalize all our custom properties in our implementation to be -khtml (remove all the -apple).

Make sure that -apple, -khtml, and -moz are all able to be used. -apple and -moz just map to -khtml.

Add support for automatically converting -khtml-opacity to opacity (for legacy Safari 1.1 compat).

Reviewed by darin

  • khtml/css/css_computedstyle.cpp: (DOM::): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • khtml/css/cssparser.cpp: (CSSParser::parseValue):
  • khtml/css/cssproperties.in:
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyDeclarations): (khtml::CSSStyleSelector::applyProperty):
  • khtml/css/parser.y:
  • khtml/ecma/kjs_css.cpp: (cssPropertyName):
15:50 Changeset [9100] by darin
  • fix the build
  • WebCore.pbproj/project.pbxproj: Fix some SYMROOTS that should have been SYMROOT.
14:46 Changeset [9099] by hyatt

Fix for 4098281, news.com missing a bunch of content. Make sure not to apply strict SGML parsing
when stripping comments out of scripts.

New test is comments-in-script.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
14:34 Changeset [9098] by hyatt

Remove unused notification to avoid ERROR messages spewing on the acid2 test.

Reviewed by darin

  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest):
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • khtml/rendering/render_frames.h:
13:57 Changeset [9097] by hyatt

Adding acid2 test to layout tests.

13:55 Changeset [9096] by darin

Reviewed by Dave Hyatt.
No new layout tests needed.

  • eliminated the bogus kMin/kMax macros that we had in addition to inline functions of the same name
  • kwq/KWQKGlobal.h: Remove the kMin/kMax macros.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::applyProperty): Change type of constant so both sides of kMin calls match. (khtml::CSSStyleSelector::fontSizeForKeyword): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Ditto.
  • remove unused parameter to dirtyLinesFromChangedChild for clarity
  • khtml/rendering/render_object.h: Don't take the parameter.
  • khtml/rendering/render_object.cpp: (RenderObject::dirtyLinesFromChangedChild): Ditto.
  • khtml/rendering/render_flow.h: Don't take the parameter.
  • khtml/rendering/render_flow.cpp: (RenderFlow::detach): Don't pass the parameter. (RenderFlow::dirtyLinesFromChangedChild): Don't take the parameter.
  • khtml/rendering/render_text.cpp: (RenderText::detach): Don't pass the parameter.
  • convert DOM::NodeImpl into an abstract base class by making a couple of functions pure virtual for clarity
  • khtml/xml/dom_nodeimpl.h: Made nodeName and nodeType pure virtual.
  • khtml/xml/dom_nodeimpl.cpp: Remove bodies of nodeName and nodeType.
13:47 Changeset [9095] by hyatt

Fix for object element to support fallback content. WIth this change Safari passes the Acid2 test.

Reviewed by Maciej

  • khtml/css/html4.css:
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::parseHTMLAttribute): (HTMLObjectElementImpl::rendererIsNeeded): (HTMLObjectElementImpl::createRenderer): (HTMLObjectElementImpl::attach): (HTMLObjectElementImpl::detach): (HTMLObjectElementImpl::recalcStyle): (HTMLObjectElementImpl::childrenChanged): (HTMLObjectElementImpl::isURLAttribute): (HTMLObjectElementImpl::isImageType): (HTMLObjectElementImpl::renderFallbackContent):
  • khtml/html/html_objectimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::requestObject): (KHTMLPart::selectFrameElementInParentIfFullySelected): (KHTMLPart::handleFallbackContent):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (khtml::ChildFrame::ChildFrame):
  • khtml/rendering/render_frames.cpp: (RenderPartObject::RenderPartObject): (RenderPartObject::updateWidget):
  • khtml/rendering/render_frames.h: (khtml::RenderPart::hasFallbackContent):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::RenderReplaced):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createPart):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge mainResourceError]):
13:44 Changeset [9094] by hyatt

Fix object element support so that fallback content works. With this change Safari passes the Acid2 test.

Reviewed by Maciej

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge determineObjectFromMIMEType:URL:]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]):
13:32 Changeset [9093] by darin
  • WebView.subproj/WebUIDelegate.h: Fixed incorrect comment.
Note: See TracTimeline for information about the timeline view.