Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

May 18, 2005:

5:53 PM Changeset in webkit [9180] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• got rid of code that depended on RTTI

• kjs/collector.cpp: (KJS::className): Added. Gets class name in a KJS way, rather than a C++ RTTI way. (KJS::Collector::rootObjectClasses): Use className instead of typeid names.

5:50 PM Changeset in webkit [9179] by darin

• 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

• fix a failure seen in the Mozilla JavaScript tests where a live object was garbage-collected when the only reference to it was in an argList on the stack

• kjs/list.h: Moved the operator= function into the .cpp file since it's too big to be a good choice to inline.
• kjs/list.cpp: (KJS::List::operator=): Moved this formerly-inline function into a separate file and added missing code to update valueRefCount. It's the latter that fixes the bug.

2:10 PM Changeset in webkit [9178] by darin

• 25 edits in trunk/WebCore

Reviewed by Maciej.
No new layout tests required.

• remove all dependencies on exceptions and RTTI (but don't turn them off yet, that will be in a later patch)

• WebCore.pbproj/project.pbxproj: Set a new KHTML_NO_CPLUSPLUS_DOM define. Removed all C++ DOM wrapper files that we don't need to compile any more.

• khtml/dom/css_stylesheet.h: Added more KHTML_NO_CPLUSPLUS_DOM checks so we don't include any headers when including this file.

• khtml/dom/dom2_events.h: Fixed up KHTML_NO_CPLUSPLUS_DOM checks so that everything but EventListener is turned off when that's on. Also moved the public so that the constants from KeyboardEvent are public.
• khtml/dom/dom2_events.cpp: Put everything except for EventListener inside KHTML_NO_CPLUSPLUS_DOM.

• khtml/dom/dom2_range.h: Added KHTML_NO_CPLUSPLUS_DOM checks so that only the constants are defined, no classes.

• khtml/dom/dom2_traversal.cpp: Put everything except for NodeFilterCondition inside KHTML_NO_CPLUSPLUS_DOM.

• khtml/dom/dom_node.h: Added more KHTML_NO_CPLUSPLUS_DOM checks so we don't include any headers when including this file.

• khtml/ecma/kjs_binding.cpp: (KJS::DOMObject::get): Removed exception-handling code. Now we can eliminate tryGet altogether. (KJS::DOMObject::put): Ditto. (KJS::DOMFunction::get): Ditto. (KJS::DOMFunction::call): Ditto.

• khtml/editing/visible_text.h: Added an include of <qstring.h>.

• khtml/misc/loader.h: Added isKHTMLLoader.
• khtml/misc/loader.cpp: (Loader::isKHTMLLoader): Added. Poor-man's replacement for dynamic_cast.

• khtml/rendering/render_form.h:
• khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): Added. Hack to make KWQSlot work for this function.

• khtml/xml/dom2_rangeimpl.h: Added a forward declaration of class DOMString, needed now that the C++ DOM wrappers aren't defining it.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::defaultEventHandler): Changed to call handleEventImpl so we don't have to make the C++ DOM wrapper for the event.
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::handleLocalEvents): Ditto. (ContainerNodeImpl::insertBefore): Used SharedPtr<NodeImpl> rather than Node to protect the child node. (ContainerNodeImpl::replaceChild): Ditto. (ContainerNodeImpl::appendChild): Ditto. (ContainerNodeImpl::addChild): Ditto.

• kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode): Update to add a KHTML_NO_CPLUSPLUS_DOM check since FilterCondition has a different API depending on the state. (-[DOMDocument createNodeIterator::::]): Rewrote to use NodeFilterImpl instead of NodeFilter. (-[DOMDocument createTreeWalker::::]): Ditto.

• kwq/KWQAccObject.mm: (-[KWQAccObject role]): Use identifier instead of casting to Node and using elementId. (-[KWQAccObject title]): Ditto. (-[KWQAccObject accessibilityIsIgnored]): Ditto. (-[KWQAccObject rendererForView:]): Ditto.

• kwq/KWQFrame.mm: (QFrame::setFrameStyle): Use isKHTMLView instead of dynamic_cast.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::currentForm): Use focusNode instead of activeNode. (KWQKHTMLPart::nextKeyViewInFrame): Use isWidget instead of dynamic_cast. (KWQKHTMLPart::currentEventIsMouseDownInWidget): Use KHTMLView's nodeUnderMouse instead of our public one that uses a DOM C++ wrapper. (KWQKHTMLPart::partForWidget): Use isKHTMLView instead of dynamic_cast. (KWQKHTMLPart::passSubframeEventToSubframe): Use isWidget instead of dynamic_cast.

• kwq/KWQObject.h: Made isXXX functions all public since we use them in a few more places now. Also added isKHTMLLoader.
• kwq/KWQObject.mm: (QObject::isKHTMLLoader): Added. Returns false by default.

• kwq/KWQSlot.mm: Removed all uses of dynamic_cast.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge stringForRange:]): Used plainText instead of text. (-[WebCoreBridge copyRenderNode:copier:]): Used isWidget instead of dynamic_cast.

May 17, 2005:

10:55 AM Changeset in webkit [9177] by cblu

• 3 edits in trunk/WebKit

Fixed: <rdar://problem/4119282> clicking a link in an RTF file opens the link with NSWorkspace without the usual security checks or WebView delegate control

Reviewed by mjs.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): pass the passed referrer to canLoadURL::: not [self referrer] (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): ditto
• WebView.subproj/WebTextView.m: (-[WebTextView clickedOnLink:atIndex:]): call the loadURL bridge method so that security checks are made, command/option clicks work, policy delegate is consulted etc.

9:28 AM Changeset in webkit [9176] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

Reviewed by mjs.

• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): if the WebKit client has chosen to "use" a remote web archive, stop the load with an error

WebBrowser:

Fixed: <rdar://problem/4120255> web archives on remote servers can be viewed directly (with major security issues); should download instead

• BrowserWebView.m: (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]): download remote web archives

May 16, 2005:

3:11 PM Changeset in webkit [9175] by darin

• 4 edits in trunk

WebCore:

• attempt to get things building under "Saffron" development tools

• WebCore.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.

WebKit:

• attempt to get things building under "Saffron" development tools

• WebKit.pbproj/project.pbxproj: Use BUILT_PRODUCTS_DIR instead of SYMROOT.

3:03 PM Changeset in webkit [9174] by adele

• 5 edits in trunk

Tests:

Changes by Darin. Reviewed by myself.

Added new layoutTestController method to dump the document as text.

• DumpRenderTree/main.m: (-[LayoutTestController dumpAsText]): new method on layoutTestController to dump the innerText of the body instead of dumping the render tree; better for tests that are not really about layout (+[LayoutTestController isSelectorExcludedFromWebScript:]): added new dumpAsText selector (dump): changed name of showRenderTree since it now sometimes dumps text instead (-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): calls new dump function (-[LayoutTestController notifyDone]): calls new dump function (dumpRenderTree): initializes global variables dumpAsText and waitLayoutTest

WebCore:

Changes by Darin. Reviewed by myself.

Changed the Render Tree debug code to write out an indication that the affinity is upstream
when writing out caret position. Updated the one layout test with output affected by the change.
Also updated one test to use the new dumpAsText method in dumpRenderTree.

• kwq/KWQRenderTreeDebug.cpp: (writeSelection): writes out affinity if it's upstream in the caret case
• layout-tests/editing/style/create-block-for-style-004-expected.txt: new results that contain the affinity
• layout-tests/fast/js/char-at.html: now calls layoutController.dumpAsText()
• layout-tests/fast/js/char-at-expected.txt: plain text result (replaces old render tree result)

12:19 PM Changeset in webkit [9173] by darin

• 14 edits in trunk/WebCore

Reviewed by Adele.

• fixed issues preventing us from compiling with newer versions of gcc 4.0

• khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.

• khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.

• khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
• khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
• khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
• khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
• khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.

• khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
• khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.

• khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!

• kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

11:57 AM Changeset in webkit [9172] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Adele.

• fixed issues preventing us from compiling with newer versions of gcc 4.0

• kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.