Timeline


and

05/26/05:

18:17 Changeset [9222] by darin

Reviewed by me, patch by Mitz Pettel.

  • fixed <rdar://problem/4106907> bidi algorithm bug fixed for KHTML should be fixed in WebCore too

Test cases added:

  • layout-tests/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
  • layout-tests/fast/text/international/bidi-neutral-directionality-paragraph-start.html: Added.
17:03 Changeset [9221] by darin

Reviewed by John.

  • fix build failure from when I removed WebCoreUnicode
  • WebCoreSupport.subproj/WebTextRenderer.m: Removed import of WebUnicode.h that I missed. (-[WebTextRenderer _convertUnicodeCharacters:length:toGlyphs:]): Switch from our own macros to the ICU macros for surrogate pairs. (widthForNextCharacter): Ditto.
15:48 Changeset [9220] by harrison

<rdar://problem/4120518> Mail: control-T in an empty message crashes mail

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge issueTransposeCommand]): New, to support transpose in JS.
15:15 Changeset [9219] by darin

top level:

Reviewed by Richard and Dave Harrison.

  • configure.in: Turn off exceptions and RTTI for C++ test programs. This makes them work with WebCore, which now has them off, under gcc 4.0.

Tests:

Reviewed by Richard and Dave Harrison.

  • qt/Makefile.am: Add -licucore so we can continue to compile with the changed QChar.

WebCore:

Reviewed by Richard and Dave Harrison.
No new test cases needed for this change.

  • eliminate WebCoreUnicode and use ICU directly instead
  • fixed compiling with gcc 4.0 (was broken for Development only)
  • WebCore.exp: Removed the WebCoreXXXFunction exports.
  • WebCore-tests.exp: Removed some QChar functions that are now inlines. Removed some typeinfo exports that are no longer appropriate since we use -fno-rtti.
  • kwq/KWQString.h: (QChar::isDigit): Changed to call u_isdigit when non-ASCII. We should probably phase this out since it's only used in places where we don't want to handle non-ASCII decimal digits. (QChar::isLetter): Changed to call u_isalpha when non-ASCII. (QChar::isNumber): Changed to call u_isdigit when non-ASCII. This probably should be removed, since we always want to call isDigit instead. (QChar::isLetterOrNumber): Changed to call u_isalnum when non-ASCII. (QChar::isPunct): Changed to call u_ispunct when non-ASCII. (QChar::digitValue): Changed to call u_charDigitValue when not '0'-'9'. We should probably phase this out since it's only used in places where we don't want to handle non-ASCII decimal digits. (QChar::lower): Changed to call u_tolower when non-ASCII. (QChar::upper): Changed to call u_toupper when non-ASCII. (QChar::direction): Made inline. Calls u_charDirection. (QChar::mirrored): Made inline. Calls u_isMirrored. (QChar::mirroredChar): Made inline. Calls u_charMirror.
  • kwq/KWQChar.mm: Removed.
  • kwq/WebCoreUnicode.cpp: Removed.
  • kwq/WebCoreUnicode.h: Removed.
  • WebCore.pbproj/project.pbxproj: Removed files.

WebKit:

Reviewed by Richard and Dave Harrison.

  • eliminate WebCoreUnicode and use ICU directly instead
  • Misc.subproj/WebKitNSStringExtras.m: (canUseFastRenderer): Use u_charDirection directly.
  • WebCoreSupport.subproj/WebTextRenderer.m: Removed import of <WebCore/WebCoreUnicode.h>.
  • WebView.subproj/WebHTMLView.m: (+[WebHTMLView initialize]): Removed call to WebKitInitializeUnicode.
  • Misc.subproj/WebUnicode.h: Removed.
  • Misc.subproj/WebUnicode.m: Removed.
  • Misc.subproj/WebUnicodeTables.m: Removed.
  • WebKit.pbproj/project.pbxproj: Removed files.
13:32 Changeset [9218] by harrison

Missed this in previous commit.

13:30 Changeset [9217] by harrison

Reviewed by John.

<rdar://problem/4120518> Mail: control-T in an empty message crashes mail

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge rangeOfCharactersAroundCaret]): Nil-check result of VisiblePosition previous() and next().
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): (khtml::VisiblePosition::previousVisiblePosition): Make sure previous() does not return the original position. Also, simplified. Commented odd, but required, behavior in previousVisiblePosition().
  • khtml/editing/visible_units.cpp: (khtml::startOfEditableContent): (khtml::endOfEditableContent): Removed redundant check for isEditableContent().
  • khtml/editing/jsediting.cpp:
  • khtml/khtml_part.cpp: (KHTMLPart::transpose):
  • khtml/khtml_part.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::issueTransposeCommand):
  • layout-tests/editing/editing.js:
  • kwq/WebCoreBridge.h: Add support for transpose command in JavaScript and therefore layout tests.
  • layout-tests/editing/deleting/transpose-empty-expected.txt: Added.
  • layout-tests/editing/deleting/transpose-empty.html: Added. New test for this bug.
13:26 Changeset [9216] by cpetersen

Merged fix for <rdar://problem/4086570> from TOTO to SUTiCambridge.

2005-05-04 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/4086570> Crash in JavaScriptCore with RSS Visualizer

  • kjs/internal.cpp: (InterpreterImp::mark): mark staticNaN, it is usually protected by the Number prototype but there is a small window where it can get collected.
11:31 Changeset [9215]

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-412~2'.

11:31 Changeset [9214] by adele

Versioning for SUTiCambridge - JavaScriptCore-412.2
(JavaScriptCore-412.1 is already in use in TOT)

05/24/05:

18:33 Changeset [9213] by rjw

Fixed <rdar://problem/4127061> <canvas> backing store should be zero filled

Use calloc instead of malloc to ensure zero filled backing store.

Reviewed by Darin.

  • khtml/rendering/render_canvasimage.cpp: (RenderCanvasImage::createDrawingContext):
18:28 Changeset [9212] by rjw

Fixed <rdar://problem/4097289> -[WebView elementAtPoint:] failing when WebView is nested and offset

Code to determine the correct frame under the window point was
converting the point incorrectly.

Reviewed by Chris.

  • WebView.subproj/WebView.m: (-[WebView _frameViewAtWindowPoint:]):
17:06 Changeset [9211] by darin

JavaScriptCore:

Rolled in changes to compile with gcc 4.0 from TOT.

2005-05-16 Darin Adler <darin@apple.com>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • kjs/ustring.cpp: (KJS::operator==): Remove redundant and illegal KJS:: prefix on this function's definition. (KJS::operator<): Ditto. (KJS::compare): Ditto.

2005-05-04 Darin Adler <darin@apple.com>

Reviewed by Dave Hyatt.

  • another gcc-4.0-related fix
  • bindings/runtime_root.h: Take off extra namespace prefixes that apparently cause problems compiling with gcc 4.0, although I have not observed the problems.

2005-04-28 Darin Adler <darin@apple.com>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • JavaScriptCore.pbproj/project.pbxproj: Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • bindings/jni/jni_jsobject.cpp: (JSObject::getSlot): Changed some %d to %ld where the parameters where long ints. (JSObject::setSlot): Ditto.
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): Ditto. (KJS::Bindings::getJNIEnv): Ditto.
  • bindings/objc/objc_utility.mm: Fixed include of <JavascriptCore/internal.h> that needed the letter "S" capitalized.
  • kjs/bool_object.cpp: (BooleanProtoFuncImp::call): Rearranged how this function returns to avoid incorrect gcc 4.0 warning.
  • kjs/collector.cpp: (KJS::Collector::markStackObjectsConservatively): Changed code to check the alignment of the passed-in pointers to only require pointer-level alignment, not 8-byte alignment. Prevents a crash on garbage collect when compiled with gcc 4.0.
  • kjs/nodes.cpp: (WhileNode::execute): Added a redundant return after an infinite loop to work around incorrect gcc 4.0 warning. (ForNode::execute): Ditto. (SwitchNode::execute):Rearranged how this function returns to avoid incorrect gcc 4.0 warning. (LabelNode::execute): Ditto.
  • kjs/string_object.cpp: (replace): Ditto.

WebCore:

Rolled in changes to compile with gcc 4.0 from TOT.

2005-05-16 Darin Adler <darin@apple.com>

Reviewed by Adele.

  • fixed issues preventing us from compiling with newer versions of gcc 4.0
  • khtml/dom/dom2_events.cpp: Add definitions of some static data member constants, as required by the C++ standard and the gcc 4.0 compiler.
  • khtml/editing/selection.h: Specified KHTMLPart friend class as ::KHTMLPart, since if it's not explicitly qualified, it means DOM::KHTMLPart.
  • khtml/dom/dom_string.cpp: (DOM::strcasecmp): Removed redundant and illegal DOM:: prefix. (DOM::operator==): Ditto.
  • khtml/ecma/kjs_binding.cpp: (KJS::getStringOrNull): Removed redundant and illegal KJS:: prefix. (KJS::ValueToVariant): Ditto.
  • khtml/ecma/kjs_css.cpp: (KJS::getCSSRuleConstructor): Ditto. (KJS::getCSSValueConstructor): Ditto. (KJS::getCSSPrimitiveValueConstructor): Ditto.
  • khtml/ecma/kjs_events.cpp: (KJS::getEventConstructor): Ditto. (KJS::getEventExceptionConstructor): Ditto. (KJS::getMutationEventConstructor): Ditto.
  • khtml/ecma/kjs_traversal.cpp: (KJS::getNodeFilterConstructor): Ditto.
  • khtml/misc/loader_client.h: Added an empty virtual destructor to CachedObjectClient to quiet the compiler. This doesn't really do any good, but also does no harm.
  • khtml/misc/loader.cpp: (CachedObjectClient::~CachedObjectClient): Added.
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::fillBlockSelectionGaps): Initialize a couple of variables that should have been initialized to 0. Not just about making the compiler happy -- warning found a real bug!
  • kwq/KWQTextArea.mm: (RangeOfParagraph): Change else structure to work around compiler warning bug.

2005-04-28 Darin Adler <darin@apple.com>

Reviewed by Dave Harrison.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebCore.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • khtml/css/parser.y: Changed some rules that were using a float to pass around an enum to use an int instead to avoid a warning.
  • khtml/css/parser.cpp: Regenerated.
  • khtml/css/parser.h: Regenerated.
  • khtml/ecma/kjs_dom.cpp: (DOMTextProtoFunc::tryCall): Rearranged a return statement to avoid an incorrect warning.
  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::tryCall): Initialized a couple of variables to avoid an incorrect warning.
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Rearranged how we exit from the function to avoid an incorret warning.
  • khtml/editing/selection.cpp: (khtml::Selection::debugPosition): Changed some %d to %ld where the parameters where long ints.
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::debugPosition): Ditto.
  • khtml/xml/dom_position.cpp: (DOM::Position::debugPosition): Ditto.
  • kwq/DOMEvents.mm: (-[DOMMouseEvent initMouseEvent:::::::::::::::]): Rearranged code to avoid a cast that was causing an incorrect warning.
  • kwq/DOMUtility.mm: (createObjCDOMNode): Broke out as a separate function. (KJS::ScriptInterpreter::createObjcInstanceForValue): Rearranged code to avoid a namespace collision with KJS::DOMNode and the Objective-C DOMNode class.
  • kwq/KWQFileButton.mm: Made fields of KWQFileButtonAdapter public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::matchLabelsAgainstElement): Rearranged a return statement to avoid an incorrect warning. (KWQKHTMLPart::imageFromRect): Rearranged how this function does its exception handling to avoid a "may be clobbered" warning.
  • kwq/KWQKJavaAppletWidget.mm: Fixed incorrect import that said "KHTMLView.h" instead of "khtmlview.h".
  • kwq/KWQObject.mm: Made fields of KWQObjectTimerTarget public to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • kwq/WebCoreBridge.mm: (partHasSelection): Used [bridge part] instead of getting directly at instance variable to avoid an error, new to gcc 4.0, about accessing protected Objective-C fields.
  • WebCore-combined.exp: Regenerated.
  • WebCore-tests.exp: Added some additional symbols needed by the tests under gcc 4.0.

WebKit:

Rolled in changes to compile with gcc 4.0 from TOT.

2005-04-28 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fixed problems preventing us from compiling with gcc 4.0
  • WebKit.pbproj/project.pbxproj: Removed -fobjc-exceptions because I can't figure out an easy way to pass it only when compiling Objective-C/C++. Removed -Wmissing-prototypes from WARNING_CPLUSPLUSFLAGS since it's now a C-only warning.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem pageCache]): Changed return type to match the declaration.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed a BOOL that should have been a Boolean.
  • WebCoreSupport.subproj/WebTextRenderer.m: Removed redundant copy of ROUND_TO_INT, also in a WebCore header. (-[WebTextRenderer _computeWidthForSpace]): Had to add cast because of difference in type of ROUND_TO_INT vs. CEIL_TO_INT. (pathFromFont): Added a cast to convert UInt8 * to char *.
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Fixed parameter type to match the declaration. (-[WebFrameView documentView]): Fixed return type to match the declaration.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Initialized a variable to quiet an incorrect gcc 4.0 uninitialized variable warning. (-[WebHTMLView deleteToMark:]): Switched from @try style to NS_DURING style of exception handler because we can't pass -fobjc-exceptions just to Objective-C at the moment (see above). (-[WebHTMLView selectToMark:]): Ditto. (-[WebHTMLView swapWithMark:]): Ditto.

WebBrowser:

Rolled in changes to compile with gcc 4.0 from TOT.

2005-04-28 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fixed problems preventing us from compiling with gcc 4.0
  • AccessibilityButtonInfo.m: (+[AccessibilityButtonInfo infoWithParent:identifier:]): Fixed return type to match declaration.
  • AppController.m: Added forward declaration of "struct mach_header".
  • BrowserNSDataExtras.m: (-[NSData indexOfCString:startOffset:]): Added a cast to convert a char * to a UInt8 *.
  • BrowserNSStringExtras.m: (-[NSString encodeStringBase64]): Ditto.
  • BrowserNSWorkspaceExtras.m: (-[NSWorkspace noteDirectoryContentsChangedAtPath:]): Ditto.
  • BrowserWebController.m: (-[BrowserWebView setSheetRequest:]): Fixed parameter type to match declaration.
  • HTMLSourceController.m: (-[HTMLSourceController rangeForLine:]): Changed from int to unsigned.
  • InternetConfigUtilities.m: (setDownloadPath): Added a cast to convert a char * to a UInt8 *. (downloadPathForICInstance): Same thing, in the other direction.
  • LocationChangeHandler.m: (-[Logger initWithWebView:]): Fixed parameter type to match declaration.
  • MenuIconRefFactory.m: (_NSAddQuickDrawIconFamilyColorElement): Added a cast to convert a UInt8 * to a char *. (_NSAddQuickDrawIconFamilyMaskElement): Ditto.
  • NetworkController.m: (+[NetworkController sharedInstance]): Fixed return type to match declaration.
  • Preferences.subproj/AdvancedPreferences.m: (systemIsInFullKeyboardAccessMode): Fix a BOOL that should have been a Boolean.
  • WebBrowserPrefix.h: Use <malloc/malloc.h> rather than <obc/malloc.h>.
  • Test/PageLoadTestRunner.m: Ditto.
16:49 Changeset [9210] by sullivan

Reviewed by Dave Hyatt.

  • fixed these bugs: <rdar://problem/4118510> Textareas with a vertical scroll bar should have their resize corner under the scroll bar <rdar://problem/4118523> Resize image in textareas is drawn repeatedly when scrolling vertically with scrollbar

Test cases added: none; doesn't affect page layout

  • kwq/KWQTextArea.h: added inInitWithFrame ivar
  • kwq/KWQTextArea.mm: (+[KWQTextArea _resizeCornerImage]): moved here from KWQTextAreaTextView; now it's a class method so we only look up the image once. (-[KWQTextArea initWithFrame:]): set and clear inInitWithFrame ivar, used by -tile (-[KWQTextArea _isResizableByUser]): renamed with an underscore for consistency (-[KWQTextArea _textViewShouldHandleResizing]): new method, returns YES if the textarea is user-resizable and the enclosed textview is responsible for drawing and tracking the resize corner. (-[KWQTextArea tile]): shrink the vertical scroller if appropriate to account for the resize corner (-[KWQTextArea _resizeCornerRect]): new method, returns the bottom-right corner rect, where the resize image goes (-[KWQTextArea _trackResizeFromMouseDown:]): moved here from KWQTextAreaTextView. The only changes were to move the [NSCursor set] call inside here (was in the caller), and to use self where it was using [self _enclosingTextArea], and to move a comment in here that was in the caller (-[KWQTextArea mouseDown:]): track resizing if appropriate (-[KWQTextArea drawRect:]): draw the resize corner if appropriate (-[KWQTextAreaTextView _resizeCornerRect]): get the resize image from KWQTextArea (-[KWQTextAreaTextView resetCursorRects]): check _textViewShouldHandleResizing (-[KWQTextAreaTextView drawRect:]): ditto (-[KWQTextAreaTextView mouseDown:]): ditto; also, make the textarea handle the resize tracking now
15:46 Changeset [9209]

This commit was manufactured by cvs2svn to create tag 'WebKit-412~2'.

15:46 Changeset [9208] by cpetersen

Versioning for SUTiCambridge - WebKit-412.2

15:37 Changeset [9207]

This commit was manufactured by cvs2svn to create tag
'WebCore-415~6'.

15:37 Changeset [9206] by cpetersen

Versioning for SUTiCambridge - WebCore-415.6

15:31 Changeset [9205] by cpetersen

Versioning for SutiCambridge - JavaScriptCore-412.1

15:08 Changeset [9204] by adele

WebCore:

Merged fix for <rdar://problem/3598589> from TOT for SUTiCambridge

2005-05-24 Maciej Stachowiak <mjs@apple.com>

Reviewed by John.

  • fixed <rdar://problem/3598589> onunload handler doesn't fire when a window is closed
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Don't remove all event handlers from the document here...
  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): ...instead do it here, after firing the unload event, but only if the document is not in the back/forward cache...
  • kwq/KWQPageState.mm: (-[KWQPageState finalize]): ...and take care of the back/forward cache case here.

WebKit:

Merged fix for 4077106 from TOT to SUTiCambridge

2005-04-05 David Hyatt <hyatt@apple.com>

Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.

Reviewed by darin

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):
14:25 Changeset [9203] by darin

Added a missing bug number.

14:16 Changeset [9202] by darin
  • another gcc 4.0 fix

No new test cases needed.

  • khtml/dom/dom2_events.cpp: Moved constants out of the KHTML_NO_CPLUSPLUS_DOM #if.
14:16 Changeset [9201] by darin

Reviewed by Vicki.

  • WebCore.exp: Added exports for many classes in the public DOM headers that were omitted before. Also removed one symbol that was listed twice.
10:44 Changeset [9200] by mjs

Reviewed by John.

  • fixed <rdar://problem/3598589> onunload handler doesn't fire when a window is closed

Test cases added:

  • layout-tests/fast/events/onunload-expected.txt: Added.
  • layout-tests/fast/events/onunload.html: Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::detach): Don't remove all event handlers from the document here...
  • khtml/khtml_part.cpp: (KHTMLPart::closeURL): ...instead do it here, after firing the unload event, but only if the document is not in the back/forward cache...
  • kwq/KWQPageState.mm: (-[KWQPageState finalize]): ...and take care of the back/forward cache case here.
10:37 Changeset [9199] by mjs

Added missing file.

10:20 Changeset [9198] by sullivan

WebCore:

Reviewed by Kevin.

  • WebCore part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable
  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::textAreasAreResizable): new getter (KHTMLSettings::setTextAreasAreResizable): new setter
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: eliminated ALLOW_RESIZING_TEXT_AREAS #define in favor of using runtime setting (-[KWQTextArea isResizableByUser]): get value from settings, and cache it in KWQTextArea instance (-[KWQTextAreaTextView _enclosingTextArea]): new convenience method, extracted from _trackResizeFromMouseDown: (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): now uses extracted method

(-[KWQTextAreaTextView drawRect:]):
now checks isResizableByUser
(-[KWQTextAreaTextView mouseDown:]):
ditto

  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings setTextAreasAreResizable:]): new setter (-[WebCoreSettings textAreasAreResizable]): new getter

WebKit:

Reviewed by Kevin.

  • WebKit part of <rdar://problem/4125783> WebKit needs a way to control whether textareas are resizable
  • WebView.subproj/WebPreferencesPrivate.h: added private-for-now getter and setter for new preference
  • WebView.subproj/WebPreferenceKeysPrivate.h: added private preference key controlling whether textareas are resizable
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]): initial value of new preference is NO, so other clients' behavior doesn't change (-[WebPreferences textAreasAreResizable]): new getter (-[WebPreferences setTextAreasAreResizable:]): new setter
  • WebView.subproj/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): update this new setting in WebCore
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes

WebBrowser:

Reviewed by Kevin.

  • added debug menu item to toggle resizable textareas
  • Debug/DebugUtilities.m: (-[DebugUtilities createDebugMenu]): add "Allow Resizing Text Areas" item and separator (-[BrowserDocument toggleAllowResizingTextAreas:]): toggle WebPreferences setting (-[BrowserDocument validate_toggleAllowResizingTextAreas:]): sync checkmark with setting
10:06 Changeset [9197] by cpetersen

JavaScriptCore:

Merged addition fix for <rdar://problem/4058167> from TOT to SUTiCambridge

2005-05-18 Darin Adler <darin@apple.com>

Reviewed by Maciej.

  • fix a failure seen in the Mozilla JavaScript tests where a live object was garbage-collected when the only reference to it was in an argList on the stack
  • kjs/list.h: Moved the operator= function into the .cpp file since it's too big to be a good choice to inline.
  • kjs/list.cpp: (KJS::List::operator=): Moved this formerly-inline function into a separate file and added missing code to update valueRefCount. It's the latter that fixes the bug.

WebCore:

Merged fix for <rdar://problem/4058167> from TOT to SUTiCambridge

2005-05-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

<rdar://problem/4058167> Unit Converter and Weather widgets crashed in KJS::Collector::markCurrentThreadConservatively

Avoid possibly allocating new prototype objects as parameters to
superclass constructors - there may be an allocated but
uninitilized object so this is a bad time to allocate. Instead,
set the prototype in the constructor body, since the object is
happily allocated by then.

  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (DOMMediaList::DOMMediaList): (DOMCSSStyleSheet::DOMCSSStyleSheet): (DOMCSSPrimitiveValue::DOMCSSPrimitiveValue): (DOMCSSValueList::DOMCSSValueList):
  • khtml/ecma/kjs_css.h: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMCSSValue::DOMCSSValue):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::DOMNode): (DOMDocument::DOMDocument): (DOMElement::DOMElement): (DOMDOMImplementation::DOMDOMImplementation): (DOMNamedNodeMap::DOMNamedNodeMap): (DOMNamedNodesCollection::DOMNamedNodesCollection): (DOMCharacterData::DOMCharacterData): (DOMText::DOMText):
  • khtml/ecma/kjs_dom.h: (KJS::NodeConstructor::NodeConstructor): (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
  • khtml/ecma/kjs_events.cpp: (DOMEvent::DOMEvent): (Clipboard::Clipboard):
  • khtml/ecma/kjs_html.cpp: (HTMLCollection::HTMLCollection):
  • khtml/ecma/kjs_range.cpp: (DOMRange::DOMRange):
  • khtml/ecma/kjs_traversal.cpp: (DOMNodeIterator::DOMNodeIterator): (DOMNodeFilter::DOMNodeFilter): (DOMTreeWalker::DOMTreeWalker):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest):
  • khtml/ecma/xmlserializer.cpp: (KJS::XMLSerializer::XMLSerializer):
00:21 Changeset [9196] by mjs

Reviewed by John.

  • split remaining editing command classes out of htmlediting.cpp
  • rename InsertParagraphSeparatorInQuotedContentCommand to BreakBlockquoteCommand

No layout tests needed - this is a pure refactoring change.

  • WebCore.pbproj/project.pbxproj:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp: Added.
  • khtml/editing/break_blockquote_command.h: Added.
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/edit_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_line_break_command.cpp: Added.
  • khtml/editing/insert_line_break_command.h: Added.
  • khtml/editing/insert_paragraph_separator_command.cpp: Added.
  • khtml/editing/insert_paragraph_separator_command.h: Added.
  • khtml/editing/insert_text_command.cpp: Added.
  • khtml/editing/insert_text_command.h: Added.
  • khtml/editing/join_text_nodes_command.cpp: Added.
  • khtml/editing/join_text_nodes_command.h: Added.
  • khtml/editing/merge_identical_elements_command.cpp: Added.
  • khtml/editing/merge_identical_elements_command.h: Added.
  • khtml/editing/move_selection_command.cpp: Added.
  • khtml/editing/move_selection_command.h: Added.
  • khtml/editing/rebalance_whitespace_command.cpp: Added.
  • khtml/editing/rebalance_whitespace_command.h: Added.
  • khtml/editing/remove_css_property_command.cpp: Added.
  • khtml/editing/remove_css_property_command.h: Added.
  • khtml/editing/remove_node_attribute_command.cpp: Added.
  • khtml/editing/remove_node_attribute_command.h: Added.
  • khtml/editing/remove_node_command.cpp: Added.
  • khtml/editing/remove_node_command.h: Added.
  • khtml/editing/remove_node_preserving_children_command.cpp: Added.
  • khtml/editing/remove_node_preserving_children_command.h: Added.
  • khtml/editing/replace_selection_command.cpp: Added.
  • khtml/editing/replace_selection_command.h: Added.
  • khtml/editing/set_node_attribute_command.cpp: Added.
  • khtml/editing/set_node_attribute_command.h: Added.
  • khtml/editing/split_element_command.cpp: Added.
  • khtml/editing/split_element_command.h: Added.
  • khtml/editing/split_text_node_command.cpp: Added.
  • khtml/editing/split_text_node_command.h: Added.
  • khtml/editing/split_text_node_containing_element_command.h: Added.
  • khtml/editing/typing_command.cpp: Added.
  • khtml/editing/typing_command.h: Added.
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: Added.
  • khtml/editing/wrap_contents_in_dummy_span_command.h: Added.

05/23/05:

18:38 Changeset [9195] by cpetersen

WebCore:

Merged fix for 4077106 from TOT to SUTiCambridge

2005-04-05 David Hyatt <hyatt@apple.com>

Fix for 4077106, make sure that mouse wheeling in overflow sections uses 40 rather than 10 as the base line
step.

Reviewed by darin

  • khtml/rendering/render_layer.cpp: (RenderLayer::positionScrollbars):
  • kwq/KWQScrollBar.mm: (QScrollBar::scroll):

WebKit:

Merged fix for 4077106 from TOT to SUTiCambridge

2005-04-05 David Hyatt <hyatt@apple.com>

Fix for 4077106, wheel scroll amount smaller in Tiger. All along wheeling should have been 4x the default
line height of 10 (just as arrow keys did). Scroll arrows should have done this too for scroll views (they did
already for overflow sections). This patch puts the override into the scrollview itself, and removes the
multipliers in the private frame methods.

Reviewed by darin

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _verticalKeyboardScrollDistance]): (-[WebFrameView initWithFrame:]): (-[WebFrameView _horizontalKeyboardScrollDistance]):
18:22 Changeset [9194] by cpetersen

Merged changes for <rdar://problem/4072280> from TOT to SUTiCambridge

2005-05-04 Chris Blumenberg <cblu@apple.com>

Fixed:
<rdar://problem/4078417> REGRESSION (125-412): MLB gameday page doesn't update (Flash)
<rdar://problem/4072280> XMLHttpRequest calls onReadyStateChange callback with bogus status value

Reviewed by john.

Our WebKit-level caching of subresources "dumbed-down" information held in NSURLResponse. This caused some loads to lack response headers and thus disabling cache directives. Status codes were also not retained and this caused XMLHttpRequest to fail frequently. The fix is to have WebResource retain the NSURLResponse and to use the NSURLResponse when we decide to load from WebResources.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _canUseResourceWithResponse:]): new, checks response cache directives (-[WebBaseResourceHandleDelegate loadWithRequest:]): call _canUseResourceWithResponse: (-[WebBaseResourceHandleDelegate saveResource]): call new [WebResource _initWithData:URL:response:]
  • WebView.subproj/WebResource.m: (-[WebResourcePrivate dealloc]): (-[WebResource initWithData:URL:MIMEType:textEncodingName:frameName:]): call renamed _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData: (-[WebResource initWithCoder:]): decode the NSURLReponse (-[WebResource encodeWithCoder:]): encode the NSURLReponse (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): take the NSURLReponse (-[WebResource _initWithData:URL:response:]): new (-[WebResource _initWithPropertyList:]): decode the NSURLReponse (-[WebResource _propertyListRepresentation]): encode the NSURLReponse (-[WebResource _response]): return ivar if we have one
  • WebView.subproj/WebResourcePrivate.h:
18:10 Changeset [9193] by cpetersen

Reviewed by Adele.

  • khtml/ecma/kjs_window.cpp: (Window::get): Merged final change for frameElement from TOT.
17:52 Changeset [9192] by cpetersen

JavaScriptCore:

Merging fix for <rdar://problem/4098713> from TOT to SUTiCambridge

2005-04-26 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

We were incompatible with Mozilla's implementation of the scripting APIs in
two ways:

Their NPN_SetException has the following signature:

void NPN_SetException(NPObject *npobj, const NPUTF8 *message);

ours has:

void NPN_SetException (NPObject * npobj, const NPString *message);

Also, they expect the string returned from NPN_UTF8FromIdentifier() to be freed by caller.
We do not.

I changed both behaviors to match Mozilla.

Reviewed by Chris.

  • bindings/NP_jsobject.cpp: (_NPN_SetException):
  • bindings/npruntime.cpp: (_NPN_UTF8FromIdentifier): (_NPN_IntFromIdentifier): (_NPN_SetExceptionWithUTF8):
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:

WebCore:

Merged fix for <rdar://problem/4091956> from TOT to SUTiCambridge

2005-04-25 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/4091956> JavaScript drop handlers don't receive more than one dropped item
  • kwq/KWQClipboard.mm: (cocoaTypeFromMIMEType): Remove some use of compare -- less efficient than a simpler "==" check. Fixed non-GC-safe code to use KWQCFAutorelease instead. (MIMETypeFromCocoaType): Use fromCFString instead of fromNSString to avoid a cast. (KWQClipboard::getData): Rearrange so that we'll use filenames if both filenames and a URL are present, since filenames can accomodate multiple items. Fix bug where we'd return multiple filenames when the type requested is "URL". Fixed loop that computed the count over and over again for the loop termination condition. Check that the data for NSFilenamesPboardType is an NSArray instead of assuming it is. (KWQClipboard::setData): Use isEqualToString: instead of == when comparing types.

WebKit:

Merged changes for <rdar://problem/4098713> from TOT to SUTiCambridge

2005-04-26 Richard Williamson <rjw@apple.com>

Fixed <rdar://problem/4098713> Scripting API is incompatible with Mozilla

Reviewed by Chris.

  • Plugins.subproj/npfunctions.h:
  • Plugins.subproj/npruntime.h:
17:34 Changeset [9191] by darin
  • WebCore.exp: Sorted file for more readable diffs.
17:17 Changeset [9190] by cpetersen

Merged fix for <rdar://problem/4091082> from TOT for SUTiCambridge

2005-04-22 Darin Adler <darin@apple.com>

Reviewed by John.

  • fixed <rdar://problem/4091082> Google Suggest no longer works due to lack of "frameElement"
  • khtml/ecma/kjs_window.h: Added FrameElement.
  • khtml/ecma/kjs_window.cpp: (Window::get): Added "frameElement".
  • khtml/ecma/kjs_window.lut.h: Regenerated.
14:09 Changeset [9189] by adele

Reviewed by Darin.

fix for <rdar://problem/4122661> Regression: 10.3.8-10.3.9: Next lesson doesn't work on Dale Carnegie Action Systems page

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::tryCall): added checks for NaN, in case it is passed into window.open for screenx, screeny, left, top, height, or width.
14:03 Changeset [9188] by cblu

Changed type for identifier parameter in WebResourceLoadDelegate-related calls to id from NSString.

Reviewed by kevin.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _requestFromDelegateForRequest:identifier:error:]): (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrame _saveResourceAndSendRemainingDelegateMessagesWithRequest:identifier:response:data:error:]):
  • WebView.subproj/WebFrameInternal.h:
13:39 Changeset [9187] by harrison

Reviewed by Darin.

Prevent crash when going from no selection to selection with mispelling checks enabled.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::markMisspellings): Repair check for null searchRange. Was inadvertently broken in recent checkin.
13:30 Changeset [9186] by sullivan

Reviewed by Dave Hyatt.

  • fixed <rdar://problem/4123592> Can't resize textareas that have a width specified by a style
  • kwq/KWQTextArea.mm: (-[KWQTextArea getNumColumns:andNumRows:forSize:]): removed this method, which I had added earlier to set cols and rows correctly (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): set width and height instead of cols and rows; handle the intrinsic margin that sometimes appears on form elements

05/22/05:

17:57 Changeset [9185] by adele

Reviewed by Maciej.

fix for <rdar://problem/4127101> REGRESSION(412-TOT) crash when creating Option element

  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct): Changed ElementImpl pointer to a SharedPtr because it was getting destroyed before we were done with it.
Note: See TracTimeline for information about the timeline view.