Context Navigation

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObjectForDocument): New function - allows nodes that get removed from the document to go away from the cache if not referenced. (KJS::ScriptInterpreter::mark): Don't mark nodes that aren't in the document, they can stay in the cache but only if they have another source of life. (KJS::ScriptInterpreter::domNodesPerDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::getDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::putDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::updateDOMNodeDocument): Renamed and changed parameter types.
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): call forgetDOMObjectForDocument. (KJS::DOMNode::mark): If the node is not in the document, make sure to mark all wrappers in its detached piece of the tree. (KJS::getDOMNode): Updated for renames
khtml/ecma/kjs_dom.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Updated for renames.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Updated for renames.

10:10 AM Changeset in webkit [9234] by cpetersen

4 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4067761> from TOT to SUTiCambridge.

2005-05-27 Adele Peterson <adele@apple.com>

Change by Darin, reviewed by me.

fix for <rdar://problem/4067761> 8A425: reload stock widget over and over and crash in XMLHttpRequest::changeState

khtml/khtml_part.cpp: (KHTMLPart::closeURL): now cancels XMLHttpRequests
khtml/ecma/xmlhttprequest.h: Added cancelRequests, addToRequestsByDocument, and RemoveFromRequestsByDocument methods. Added requestsByDocument dictionary.
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): calls addToRequestsByDocument (KJS::XMLHttpRequest::abort): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::slotFinished): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::requestsByDocument): creates dictionary to manage requests. (KJS::XMLHttpRequest::addToRequestsByDocument): adds this request to dict. (KJS::XMLHttpRequest::removeFromRequestsByDocument): removes this request from dict. (KJS::XMLHttpRequest::cancelRequests): goes and cancels requests in the doc

9:57 AM Changeset in webkit [9233] by cpetersen

3 edits in branches/Safari-2-0-branch/WebCore

Merged fix for <rdar://problem/4121747> from TOT for SUTiCambridge.

2005-05-27 Adele Peterson <adele@apple.com>

Reviewed by Darin.

fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)

khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.

May 30, 2005:

10:48 PM Changeset in webkit [9232] by darin

5 edits
4 adds in trunk

Reviewed by John (fix for Radar bug) and Vicki (all the rest).

fixed <rdar://problem/4105097> REGRESSION (138-139): Hitting Enter on a checkbox toggles check mark instead of submitting form
fixed other problems discovered while trying to make a layout test to test this work:
- added newer DOM 3 event type constants
- fixed prototype setup bug preventing event initialization functions from being called
- fixed bug where any function taking an event parameter would crash with a nil-deref
- fixed incorrect ref/deref bug in MutationEventImpl that would cause a crash crash

Test cases added:

layout-tests/fast/forms/check-box-enter-key-expected.txt: Added.
layout-tests/fast/forms/check-box-enter-key.html: Added.
layout-tests/fast/events/event-creation-expected.txt: Added.
layout-tests/fast/events/event-creation.html: Added.

khtml/html/html_formimpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): Separate the checks for the space bar and the Enter key and make Enter submit the form on a check box or radio button.

khtml/ecma/kjs_events.cpp: (KJS::toEvent): Fixed bug where this was checking for DOMNode rather than DOMEvent, so always returning 0. Without this, both test cases above will crash. (KJS::DOMUIEvent::DOMUIEvent): Set prototype; without this, the event-creation test case will fail. (KJS::DOMMouseEvent::DOMMouseEvent): Set prototype; without this, the event-creation test case will fail. (KJS::DOMKeyboardEvent::DOMKeyboardEvent): Set prototype; without this, both test cases above will fail. (KJS::DOMMutationEvent::DOMMutationEvent): Set prototype; without this, both test cases above will fail.

khtml/xml/dom2_eventsimpl.cpp: (MutationEventImpl::MutationEventImpl): Fix typo where the wrong object was ref'd. (MutationEventImpl::initMutationEvent): Ditto. This was causing the layout tests to crash with the new tests above.

khtml/xml/dom_docimpl.cpp: (DocumentImpl::createEvent): Added new event types to match the current DOM Level 3 specification. The test above tests both the new event types and the old ones.

8:08 PM Changeset in webkit [9231] by darin

2 edits in trunk/WebCore

Reviewed by John.
No test case added because our layout test system doesn't allow us to do inline input.

fixed <rdar://problem/4094066> REGRESSION (1.2.5-1.3): unconfirmed inline input is ignored in <textarea>, lost when form is submitted

kwq/KWQTextArea.mm: (-[KWQTextArea _createTextView]): Call setWantsNotificationForMarkedText:YES.

6:20 PM Changeset in webkit [9230] by mjs

7 edits
6 adds in trunk

Reviewed by Darin.

fixed <rdar://problem/4125222> Dashboard heap size grows over time (leak caused by JavaScript DOM node wrappers?)

changed per-document DOMObject caching to work with DOMNodes, since that is all it was used for anyway.

Test cases added: (these tests actually ensure that DOM wrappers
are sufficiently protected from GC to match other browsers, they
do not verify that the leak is fixed since there's no way to test
that with layout tests).

layout-tests/fast/dom/gc-1-expected.txt: Added.
layout-tests/fast/dom/gc-1.html: Added.
layout-tests/fast/dom/gc-2-expected.txt: Added.
layout-tests/fast/dom/gc-2.html: Added.
layout-tests/fast/dom/gc-3-expected.txt: Added.
layout-tests/fast/dom/gc-3.html: Added.

khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMObjectForDocument): New function - allows nodes that get removed from the document to go away from the cache if not referenced. (KJS::ScriptInterpreter::mark): Don't mark nodes that aren't in the document, they can stay in the cache but only if they have another source of life. (KJS::ScriptInterpreter::domNodesPerDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::getDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::putDOMNodeForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Renamed and changed parameter types. (KJS::ScriptInterpreter::updateDOMNodeDocument): Renamed and changed parameter types.
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): call forgetDOMObjectForDocument. (KJS::DOMNode::mark): If the node is not in the document, make sure to mark all wrappers in its detached piece of the tree. (KJS::getDOMNode): Updated for renames
khtml/ecma/kjs_dom.h:
khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): Updated for renames.
khtml/xml/dom_nodeimpl.cpp: (NodeImpl::checkAddChild): Updated for renames.

5:15 PM Changeset in webkit [9229] by darin

2 edits in trunk/WebCore

Reviewed by John.
Could not figure out how to make an <object> fallback, so for now, no layout test.

fixed <rdar://problem/4134124> REGRESSION (tip of tree): crash in QWidget::getView handling onunload event (yahoo.com)

khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::getObjectInstance): Check type of RenderObject to be sure it is a RenderWidget before calling widget() on it.

May 27, 2005:

5:42 PM Changeset in webkit [9228] by adele

4 edits in trunk/WebCore

Change by Darin, reviewed by me.

fix for <rdar://problem/4067761> 8A425: reload stock widget over and over and crash in XMLHttpRequest::changeState

khtml/khtml_part.cpp: (KHTMLPart::closeURL): now cancels XMLHttpRequests
khtml/ecma/xmlhttprequest.h: Added cancelRequests, addToRequestsByDocument, and RemoveFromRequestsByDocument methods. Added requestsByDocument dictionary.
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): calls addToRequestsByDocument (KJS::XMLHttpRequest::abort): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::slotFinished): calls removeFromRequestsByDocument (KJS::XMLHttpRequest::requestsByDocument): creates dictionary to manage requests. (KJS::XMLHttpRequest::addToRequestsByDocument): adds this request to dict. (KJS::XMLHttpRequest::removeFromRequestsByDocument): removes this request from dict. (KJS::XMLHttpRequest::cancelRequests): goes and cancels requests in the doc

5:26 PM Changeset in webkit [9227] by adele

2 edits in trunk/WebCore

Reviewed by me, done by Darin.

Darin fixed a regression I found from Darin's recent DOM change that broke GMail

khtml/ecma/kjs_window.cpp: (KJS::Window::get): Added nil check for document. (KJS::Window::hasProperty): Ditto.

Test cases added: None (Darin should write one).

3:55 PM Changeset in webkit [9226] by adele

3 edits
3 adds in trunk

Reviewed by Darin.

fix for <rdar://problem/4121747> Cannot log into Cingular.com account page (load event delivered while still processing incoming data)

khtml/misc/loader.cpp: (DocLoader::DocLoader): Initialized m_loadInProgress to false. (DocLoader::setLoadInProgress): Added. (Loader::slotFinished): sets the m_loadInProgress flag to reflect the fact that we're not really done loading this request until we emit the signal with the request status. (Loader::numRequests): If there's a load in progress, we increment the number of requests so it doesn't seem like the load is done.
khtml/misc/loader.h: (khtml::DocLoader::loadInProgress): Added.

Test cases added:

layout-tests/fast/loader/loadInProgress.html: Added
layout-tests/fast/loader/loadInProgress-expected.html: Added

3:48 PM Changeset in webkit [9225] by darin

2 edits
3 adds in trunk

Reviewed by Vicki.

fixed <rdar://problem/4125212> form submission delayed until you are on the next page on XML/XSL page (security hole)

khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::documentFromXMLDocPtr): Call setParsing(false) explicitly here. It's really annoying that setParsing(true) is done inside DOM::DocumentImpl and setParsing(false) is done by KHTMLPart, so that should be fixed some day, but for now this is the way to do it.

Test cases added:

layout-tests/fast/events/xsl-onload-expected.txt: Added.
layout-tests/fast/events/xsl-onload.xhtml: Added.
layout-tests/fast/events/xsl-onload.xsl: Added.

2:39 PM Changeset in webkit [9224] by sullivan

2 edits in trunk/WebCore

Reviewed by Darin

WebCore-tests.exp: took out symbol ZNK5QChar7isPunctEv; it was obsolete and causing build trouble

1:54 PM Changeset in webkit [9223] by darin

3 edits in trunk/WebCore

Reviewed by Adele.

remove HAVE_ICU_LIBRARY ifdefs

khtml/rendering/render_text.cpp: Just use ICU all the time; no ifdef.
kwq/KWQKURL.mm: Ditto.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed