Timeline


and

12/03/05:

17:22 Changeset [11429] by ggaren

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
17:21 Changeset [11428] by ggaren

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
16:53 Changeset [11427] by justing

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
16:48 Changeset [11426] by justing

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
16:32 Changeset [11425] by ggaren

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<​http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 Changeset [11424] by andersca

Didn't mean to commit this.

12:16 Changeset [11423] by andersca

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
08:56 Changeset [11422] by darin

Improved ChangeLog comment.

12/02/05:

18:33 Changeset [11421] by bdakin

Bug #:
Submitted by:
Reviewed by:

17:44 Changeset [11420] by eseidel

Bug #: none
Submitted by: eseidel
Reviewed by: tim h

Added ending newlines to files missing them.

  • ForwardingHeaders/kjs/property_map.h:
  • khtml/rendering/break_lines.cpp:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • kwq/DOM-compat.h:
  • kwq/KWQTextUtilities.h:
  • kwq/WebCoreKeyboardAccess.h:
17:32 Changeset [11419] by eseidel

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed, svg build fix only.

SVG Build fix after SharedPtr -> RefPtr changes.

  • ksvg2/events/SVGZoomEventImpl.h:
  • ksvg2/svg/SVGAElementImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateTransformElementImpl.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElementImpl.h:
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.h:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.h:
  • ksvg2/svg/SVGCursorElementImpl.h:
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGExternalResourcesRequiredImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.h:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.h:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.h:
  • ksvg2/svg/SVGFECompositeElementImpl.h:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.h:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.h:
  • ksvg2/svg/SVGFEImageElementImpl.h:
  • ksvg2/svg/SVGFELightElementImpl.h:
  • ksvg2/svg/SVGFEMergeNodeElementImpl.h:
  • ksvg2/svg/SVGFEOffsetElementImpl.h:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.h:
  • ksvg2/svg/SVGFETileElementImpl.h:
  • ksvg2/svg/SVGFETurbulenceElementImpl.h:
  • ksvg2/svg/SVGFilterElementImpl.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.h:
  • ksvg2/svg/SVGFitToViewBoxImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.h:
  • ksvg2/svg/SVGHelper.h: (KSVG::lazy_create):
  • ksvg2/svg/SVGImageElementImpl.h:
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGLinearGradientElementImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPatternElementImpl.h:
  • ksvg2/svg/SVGPolyElementImpl.h:
  • ksvg2/svg/SVGRadialGradientElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGStopElementImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGStyledTransformableElementImpl.h:
  • ksvg2/svg/SVGTestsImpl.h:
  • ksvg2/svg/SVGTextContentElementImpl.h:
  • ksvg2/svg/SVGTextPositioningElementImpl.h:
  • ksvg2/svg/SVGTransformImpl.h:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGUseElementImpl.h:
  • ksvg2/svg/SVGViewElementImpl.h:
17:30 Changeset [11418] by eseidel

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

No review needed.

  • ksvg2/scripts/make_names.pl: Add standard license header.
17:18 Changeset [11417]

This commit was manufactured by cvs2svn to create tag 'WebKit-417~6'.

17:18 Changeset [11416] by thatcher

Versioning to WebKit-417.6

17:17 Changeset [11415]

This commit was manufactured by cvs2svn to create tag
'WebCore-417~8'.

17:17 Changeset [11414] by thatcher

Versioning to WebCore-417.8

17:06 Changeset [11413] by adele

LayoutTests:

Updating test for latest changes in:
<rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • fast/replaced/width100percent.html:

WebCore:

Reviewed by Hyatt.

  • fix for <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

We're backing out the fix for <rdar://problem/3952698>.
With the new button implementation, the buttons will
not overlap for the telia webmail case. We may need to address
the minWidth behavior for other elements at a later time.

  • khtml/rendering/render_form.cpp: (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
17:06 Changeset [11412] by adele

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
16:54 Changeset [11411] by thatcher

Build fix.

16:00 Changeset [11410] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
15:58 Changeset [11409] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Eric.

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
15:19 Changeset [11408] by ggaren

Reviewed by NOBODY (OOPS!).

Fixed <rdar://problem/4344954> Glendale REGRESSION (Safari 416.12-417.2)
cannot tab to next input field after tab-completing an email address in
gmail.

Implemented work-around to conceal the selectionEnd property if the
document is on the gmail domain. We'll remove this code once Google
fixes its site.

No testcase because this is a domain-specific work-around.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::textAreaGetter):
14:53 Changeset [11407] by justing

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
14:44 Changeset [11406] by mjs

SVG build fix, not reviewed.

  • land the ksvg2 part of my SharedPtr --> RefPtr change, which I forgot about before.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent): (SVGAnimateTransformElementImpl::parseTransformValue): (SVGAnimateTransformElementImpl::initialMatrix):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::~SVGDocumentImpl): (SVGDocumentImpl::dispatchZoomEvent): (SVGDocumentImpl::dispatchScrollEvent): (SVGDocumentImpl::dispatchKeyEvent): (SVGDocumentImpl::executeScripts): (SVGDocumentImpl::dispatchUIEvent): (SVGDocumentImpl::dispatchMouseEvent):
  • ksvg2/svg/SVGLocatableImpl.cpp: (SVGLocatableImpl::getCTM): (SVGLocatableImpl::getScreenCTM):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (SVGMarkerElementImpl::canvasResource):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::drawPatternContentIntoTile): (SVGPatternElementImpl::getCTM):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::viewport): (SVGSVGElementImpl::checkIntersection): (SVGSVGElementImpl::checkEnclosure): (SVGSVGElementImpl::getCTM): (SVGSVGElementImpl::getScreenCTM):
  • ksvg2/svg/SVGScriptElementImpl.cpp: (SVGScriptElementImpl::executeScript):
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::updateLocalTransform):
13:26 Changeset [11405] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Vicki Murley <​vicki@apple.com>

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
13:17 Changeset [11404] by thatcher

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
13:16 Changeset [11403] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
13:13 Changeset [11402] by vicki

Reviewed by Darin.

  • fix <rdar://problem/4361048> Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passWheelEventToChildWidget):
  • manual-tests/resources/lorem-text.html: Added.
  • manual-tests/resources/nestedframesets.html: Added.
  • manual-tests/scrolling-nestedframesets.html: Added.
13:13 Changeset [11401] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-12-02 David Hyatt <​hyatt@apple.com>

<rdar://problem/4356387> Glendale Regression: Some text
does not render in the CIFilterBrowser widget anymore (tables overflow)

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
12:58 Changeset [11400] by aboule

Reviewed by rjw.

Added #else for XSLT ifdef to make sure switch case
doesn't fall through when feature turned off.

  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
12:32 Changeset [11399] by hyatt

Add layout test for new clipping behavior.

12:23 Changeset [11398] by hyatt

Fix for overflow clipping bug when a positioned element is
inserted in between two overflow:hidden elements in a
document.

Reviewed by beth

fast/clip/018.html

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::calculateClipRects):
01:19 Changeset [11397] by andersca

2005-12-02 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy.

  • WebCore.xcodeproj/project.pbxproj: Remove KWQRefPtr.h
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Remove a call to notNull here.
01:13 Changeset [11396] by thatcher

Reviewed by Maciej.

Cache the lastItem and lastItemOffset for fast retrieval of the
same index or indeicies greater than lastItemOffset. Also cache
the length. Like other node lists these cached values rest when the
subtree under the root node changes.

  • khtml/xml/dom_nodeimpl.cpp: (ChildNodeListImpl::length): Use cachedLength when possible. (ChildNodeListImpl::item): Use lastItemOffset and lastItem if we can.
01:00 Changeset [11395] by justing

Reviewed by justin

Updated/added tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

  • editing/deleting/delete-3775172-fix-expected.txt: Fixed.
  • editing/inserting/editing-empty-divs-expected.checksum: Added.
  • editing/inserting/editing-empty-divs-expected.png: Added.
  • editing/inserting/editing-empty-divs-expected.txt: Added.
  • editing/inserting/editing-empty-divs.html: Added.
01:00 Changeset [11394] by justing

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4003>
contentEditable div cannot be edited if it starts out with empty or <p/>

Reviewed/tweaked/landed by justin

  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): A position at the original block shouldn't be considered 'outside' the original block. (khtml::hasRenderedChildrenWithHeight): Added. (khtml::VisiblePosition::isCandidate): A block flow element with rendered children may be considered a candidate for a visible position, as long as its children do not have a positive height.
00:33 Changeset [11393] by andersca

Remove duplicate entry

12/01/05:

19:48 Changeset [11392] by mjs

JavaScriptCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • kxmlcore/RefPtr.h:

WebCore:

Reviewed by Tim Hatcher.

  • removed deprecated reset, isNull and nonNull methods
  • replaced use of KWQRefPtr with RefPtr
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toBoolean): (KJS::DOMNode::toPrimitive): (KJS::DOMNode::toString): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_html.cpp: (KJS::OptionConstructorImp::construct):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): (KJS::XMLHttpRequest::putValueProperty): (KJS::XMLHttpRequest::mark): (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequest::open):
  • khtml/editing/edit_command.cpp:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell):
  • khtml/khtml_part.cpp: (KHTMLPart::scheduleScript): (KHTMLPart::executeScheduledScript): (KHTMLPart::clear): (KHTMLPart::khtmlMousePressEvent):
  • khtml/khtmlview.cpp: (KHTMLViewPrivate::reset): (KHTMLView::updateDragAndDrop): (KHTMLView::cancelDragAndDrop): (KHTMLView::performDragAndDrop):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_text.cpp: (RenderText::setStyle):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::prepareMouseEvent):
  • khtml/xml/dom_elementimpl.cpp: (NamedAttrMapImpl::setNamedItem):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::MouseEvent::MouseEvent):
  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::KWQArrayPrivate::KWQArrayPrivate): (KWQArrayImpl::duplicate): (KWQArrayImpl::detach):
  • kwq/KWQClipboard.mm: (KWQClipboard::setDragImage): (KWQClipboard::dragNSImage):
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetrics::setFont): (QFontMetrics::ascent): (QFontMetrics::descent): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::checkSelectionPoint):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): (KWQKHTMLPart::openURLFromPageCache): (KWQKHTMLPart::khtmlMousePressEvent): (KWQKHTMLPart::khtmlMouseMoveEvent): (KWQKHTMLPart::dragSourceMovedTo): (KWQKHTMLPart::dragSourceEndedAt): (KWQKHTMLPart::mouseDown): (KWQKHTMLPart::snapshotDragImage): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::setMarkedTextRange):
  • kwq/KWQMapImpl.h:
  • kwq/KWQMapImpl.mm: (KWQMapImpl::KWQMapPrivate::KWQMapPrivate): (KWQMapImpl::copyOnWrite): (KWQMapImpl::swap):
  • kwq/KWQRefPtr.h: Removed.
  • kwq/KWQRegExp.h:
  • kwq/KWQRegExp.mm: (QRegExp::KWQRegExpPrivate::KWQRegExpPrivate): (QRegExp::operator=):
  • kwq/KWQValueListImpl.h:
  • kwq/KWQValueListImpl.mm: (KWQValueListImpl::KWQValueListPrivate::KWQValueListPrivate): (KWQValueListImpl::operator=): (KWQValueListImpl::copyOnWrite):
  • kwq/KWQVariant.h:
  • kwq/KWQVariant.mm: (QVariant::QVariantPrivate::): (QVariant::QVariantPrivate::QVariantPrivate):
16:41 Changeset [11391] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
16:38 Changeset [11390] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Adele Peterson <​adele@apple.com>

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
16:04 Changeset [11389] by thatcher

Merged fix from TOT to Safari-2-0-branch
More fixes NULL checks for button and slider that were not on TOT.

2005-10-28 Beth Dakin <​bdakin@apple.com>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
15:57 Changeset [11388] by thatcher

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
15:55 Changeset [11387] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-10-28 Beth Dakin <​bdakin@apple.com>

Reviewed by John

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQButton.mm: (-[KWQButton becomeFirstResponder]): Added nil check. (-[KWQButton resignFirstResponder]): Added nil check.
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added nil check. (-[KWQPopUpButton resignFirstResponder]): Added nil check.
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): Added nil check. (-[KWQTableView resignFirstResponder]): Added nil check.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added nil check. (-[KWQTextAreaTextView resignFirstResponder]): Added nil check.
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added nil check.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementForView:]): Added nil check.
15:50 Changeset [11386] by thatcher

Reviewed by Beth.

Another fix for 4098083 to apply to sliders.

<rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Since it is possible that a render widget's eventFilterObject
has been destroyed even though the render widget is still ref-ed,
we need to nil-check the eventFilterObject before we use it to get
the eventFilter.

  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added nil check. (-[KWQSlider resignFirstResponder]): Added nil check.
15:45 Changeset [11385] by adele

LayoutTests:

Added test for <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

  • editing/selection/focus_editable_html-expected.checksum: Added.
  • editing/selection/focus_editable_html-expected.png: Added.
  • editing/selection/focus_editable_html-expected.txt: Added.
  • editing/selection/focus_editable_html.html: Added.

WebCore:

Reviewed by Vicki and Dave Harrsion.

  • fixed <rdar://problem/4356771> Regression: Mail always scrolls to the bottom of a message when replying/forwarding

Fixed a bug in getRect where the code would return a zero sized rect at the
lower right corner if the origin was 0,0. This was causing the scrolling code to
attempt to scroll to the lower left corner of the editable html element in Mail.

Added test:

  • editing/selection/focus_editable_html.html
  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::getRect):
15:25 Changeset [11384] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-12-01 Darin Adler <​darin@apple.com>

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
15:16 Changeset [11383] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-07-30 Darin Adler <​darin@apple.com>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
15:15 Changeset [11382] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-07-30 Darin Adler <​darin@apple.com>

Reviewed by me, change by Dave Hyatt.

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_hovered to false.
13:59 Changeset [11381] by vicki

Reviewed by Vicki.

  • fix <rdar://problem/4349721> Regression: Hovering over menu item doesn't highlight menu item or mousing up on menu item in applet does not open URL in new window at smartmoney.com

Since Java depends on doing a hit test inside it's mouse moved handling, let hit testing on Java
applets go through the standard NSView code path. Since this should only happen for Java, add a global
so that we can Use our own WebHTMLView hit testing when calling from _updateMouseoverWithEvent.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hitViewForEvent:]): rename forceRealHitTest to forceNSViewHitTest (-[WebHTMLView _updateMouseoverWithEvent:]): set global variable to force a WebHTMLView-style hit test from here (-[WebHTMLView hitTest:]): perform the appropriate hit test based on global variables
12:10 Changeset [11380] by thatcher

Fix by Geoff

  • <rdar://problem/4352697> Glendale Regression: Some widgets don't get keyboard input (also affects Scrabble website)
  • khtml/xml/dom2_eventsimpl.cpp: add beforeonload to the event names
10:34 Changeset [11379] by thatcher

Merged fix from TOT to Safari-1-3-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
10:26 Changeset [11378] by thatcher

Merged fix from TOT to Safari-2-0-branch
Fixes: <rdar://problem/4344760> Glendale REGRESSION (Safari 416.12-417.2)
gmail 'reply' does not fill in to: field or quoted message (3751)

2005-07-09 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::attach):
  • khtml/html/html_formimpl.h: Update the value after attaching so we'll be sure that the text renderer has a valid value.
09:59 Changeset [11377] by andersca

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Patch by Mark Rowe.

  • kjs/nodes2string.cpp: (ForInNode::streamTo): Add lexpr if there's no varDecl.
09:58 Changeset [11376] by andersca

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • fast/js/for-in-to-text-expected.txt: Added.
  • fast/js/for-in-to-text.html: Added.
02:32 Changeset [11375] by mjs

JavaScriptCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp: (KJS::Parser::parse): (KJS::InterpreterImp::checkSyntax): (KJS::InterpreterImp::evaluate):
  • kjs/internal.h:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp: (KJS::SourceStream::operator<<):
  • kjs/protect.h:
  • kxmlcore/RefPtr.h: Added. (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::~RefPtr): (KXMLCore::RefPtr::isNull): (KXMLCore::RefPtr::notNull): (KXMLCore::RefPtr::reset): (KXMLCore::RefPtr::get): (KXMLCore::RefPtr::operator*): (KXMLCore::RefPtr::operator->): (KXMLCore::RefPtr::operator!): (KXMLCore::RefPtr::operator UnspecifiedBoolType): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):
  • kxmlcore/SharedPtr.h: Removed.

WebCore:

Rubber stamped by Eric.

  • renamed SharedPtr to RefPtr via script
  • ForwardingHeaders/kxmlcore/RefPtr.h: Added.
  • ForwardingHeaders/kxmlcore/SharedPtr.h: Removed.
  • khtml/css/css_computedstyle.h:
  • khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/XSLTProcessor.h:
  • khtml/ecma/domparser.h:
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): (KJS::KJS::HTMLCollection::getNamedItems): (KJS::OptionConstructorImp::construct):
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_range.h:
  • khtml/ecma/kjs_traversal.h:
  • khtml/ecma/kjs_views.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::toRange):
  • khtml/editing/SelectionController.h:
  • khtml/editing/apply_style_command.cpp: (khtml::StyleChange::init): (khtml::StyleChange::currentlyHasStyle): (khtml::ApplyStyleCommand::doApply): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::removeCSSStyle): (khtml::hasTextDecorationProperty): (khtml::ApplyStyleCommand::extractTextDecorationStyle): (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle): (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::addInlineStyleIfNeeded): (khtml::ApplyStyleCommand::computedFontSize):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/edit_command.cpp: (khtml::EditCommandPtr::EditCommandPtr): (khtml::EditCommandPtr::operator=):
  • khtml/editing/edit_command.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup):
  • khtml/editing/visible_position.cpp: (khtml::makeRange):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_range.h:
  • khtml/editing/visible_text.cpp: (khtml::TextIterator::range): (khtml::SimplifiedBackwardsTextIterator::range): (khtml::CharacterIterator::range): (khtml::TextIterator::rangeFromLocationAndLength): (khtml::findPlainText):
  • khtml/editing/visible_text.h: (khtml::WordAwareIterator::range):
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::children):
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::elements): (DOM::HTMLSelectElementImpl::add): (DOM::HTMLSelectElementImpl::optionsHTMLCollection):
  • khtml/html/html_formimpl.h:
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLMapElementImpl::areas):
  • khtml/html/html_imageimpl.h:
  • khtml/html/html_miscimpl.cpp: (DOM::HTMLCollectionImpl::namedItems):
  • khtml/html/html_miscimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::rows): (DOM::HTMLTableElementImpl::tBodies): (DOM::HTMLTableSectionElementImpl::insertRow): (DOM::HTMLTableSectionElementImpl::deleteRow): (DOM::HTMLTableSectionElementImpl::rows): (DOM::HTMLTableRowElementImpl::insertCell): (DOM::HTMLTableRowElementImpl::deleteCell): (DOM::HTMLTableRowElementImpl::cells):
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): (HTMLParser::insertNode):
  • khtml/khtml_events.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectionHasStyle): (KHTMLPart::selectionStartHasStyle): (KHTMLPart::selectionComputedStyle): (KHTMLPart::applyEditingStyleToBodyElement): (KHTMLPart::removeEditingStyleFromBodyElement):
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::dispatchMouseEvent):
  • khtml/misc/shared.h:
  • khtml/rendering/bidi.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_line.h:
  • khtml/rendering/render_text.cpp: (RenderText::setStyle): (RenderText::originalString): (RenderTextFragment::originalString):
  • khtml/rendering/render_text.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::rangeOfContents):
  • khtml/xml/dom2_rangeimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::adoptNode): (DocumentImpl::setFocusNode): (DocumentImpl::addMarker): (DocumentImpl::removeMarkers): (DocumentImpl::applyXSLTransform): (DocumentImpl::images): (DocumentImpl::applets): (DocumentImpl::embeds): (DocumentImpl::objects): (DocumentImpl::links): (DocumentImpl::forms): (DocumentImpl::anchors): (DocumentImpl::all): (DocumentImpl::windowNamedItems): (DocumentImpl::documentNamedItems): (DocumentImpl::getElementsByName):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::transformSourceDocument):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttributeNode): (ElementImpl::removeAttributeNode): (NamedAttrMapImpl::removeNamedItemNS): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem):
  • khtml/xml/dom_elementimpl.h: (DOM::ElementImpl::setAttributeNodeNS):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::childNodes): (DOM::NodeImpl::dispatchWindowEvent): (DOM::NodeImpl::dispatchMouseEvent): (DOM::NodeImpl::getElementsByTagNameNS): (DOM::ContainerNodeImpl::insertBefore): (DOM::ContainerNodeImpl::replaceChild): (DOM::ContainerNodeImpl::appendChild): (DOM::ContainerNodeImpl::addChild):
  • khtml/xml/dom_nodeimpl.h: (DOM::NodeImpl::getElementsByTagName): (DOM::NamedNodeMapImpl::removeNamedItem): (DOM::NamedNodeMapImpl::setNamedItemNS):
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): (DOM::createFragmentFromSource): (DOM::xsltStylesheetPointer): (DOM::xmlDocPtrFromNode): (DOM::XSLTProcessorImpl::transformToString): (DOM::XSLTProcessorImpl::transformToDocument): (DOM::XSLTProcessorImpl::transformToFragment): (DOM::XSLTProcessorImpl::getParameter):
  • khtml/xsl/xslt_processorimpl.h:
  • kwq/KWQClipboard.h:
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): (KWQKHTMLPart::advanceToNextMisspelling): (KWQKHTMLPart::fontForSelection): (KWQKHTMLPart::markMisspellings): (KWQKHTMLPart::shouldClose):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge convertToNSRange:DOM::]):
00:38 Changeset [11374] by mjs

JavaScriptCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • kjs/protect.h: (KJS::ProtectedPtr::operator UnspecifiedBoolType):
  • kxmlcore/SharedPtr.h: (KXMLCore::SharedPtr::operator UnspecifiedBoolType):

WebCore:

Reviewed by Dave Hyatt.

  • change idiom used for implicit bool conversion of smart pointers, because the old one gives weird error messages sometimes
  • khtml/xml/DocPtr.h: (DOM::DocPtr::operator UnspecifiedBoolType):

11/30/05:

15:04 Changeset [11373] by eseidel

Bug #: 5890
Submitted by: eseidel
Reviewed by: darin

No additional tests needed, acid2 covers this case.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): call down into NodeImpl if needed.
14:46 Changeset [11372] by thatcher

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
14:44 Changeset [11371] by thatcher

Fix by Beth and Darin

  • <rdar://problem/4356694> Glendale Regression: Widget browser list field displays multiple selected items when page is rendered
  • khtml/xml/dom_nodeimpl.cpp: initialize m_inActiveChain
14:40 Changeset [11370] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
14:39 Changeset [11369] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-11-28 Adele Peterson <​adele@apple.com>

Reviewed by Justin.

  • <rdar://problem/4356593> Regression: Crash in scrollRectToVisible
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Make sure there's still a renderer after updating the layout.
14:25 Changeset [11368] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Beth Dakin <​bdakin@apple.com>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
14:24 Changeset [11367] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Beth Dakin <​bdakin@apple.com>

Reviewed by Darin

Fix for <rdar://problem/4098083> REGRESSION (125-312): crash
in [KWQTableView resignFirstResponder] selecting from JS menu
(car4you.at, etc.)

Though this crash is only currently reproducible on the branch
and not on TOT, the fix should be in both.

  • kwq/KWQWidget.mm: (QWidget::removeFromSuperview): The call to removeFromSuperview could destroy data, so we should only reference it before the call.
14:15 Changeset [11366] by thatcher

Merged fix from TOT to Safari-1-3-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
14:14 Changeset [11365] by thatcher

Merged fix from TOT to Safari-2-0-branch

2005-11-29 Vicki Murley <​vicki@apple.com>

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
13:53 Changeset [11364] by ggaren

Added layout test for <rdar://problem/4344760> REGRESSION
(Safari 416.12-417.2) gmail 'reply' does not fill in to: field or
quoted message (3751)

  • fast/forms/textarea-setvalue-without-renderer-expected.txt: Added.
  • fast/forms/textarea-setvalue-without-renderer.html: Added.
03:49 Changeset [11363] by eseidel

Bug #: 5887
Submitted by: eseidel
Reviewed by: mjs

No functionality change, no tests needed.

Make make_names.pl namespace agnostic and add XLinkNames.* for SVG

  • WebCore+SVG/XLinkNamesWrapper.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: added files, build rule.
  • khtml/khtml_part.cpp: (KHTMLPart::init): init XLinkNames
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::rendererIsNeeded): remove foreignObjectTag (temp.)
  • ksvg2/misc/xlinkattrs.in: Added.
  • ksvg2/scripts/make_names.pl: make namespace agnostic
  • ksvg2/svg/SVGLocatableImpl.cpp: remove foreignObjectTag (temp.) (SVGLocatableImpl::nearestViewportElement): (SVGLocatableImpl::farthestViewportElement):
  • ksvg2/svg/SVGURIReferenceImpl.cpp: use XLinkNames (SVGURIReferenceImpl::parseMappedAttribute):
  • ksvg2/svg/svgattrs.in: remove href
  • ksvg2/svg/svgtags.in: comment out unused tags
03:07 Changeset [11362] by eseidel

Bug #: none
Submitted by: eseidel
Reviewed by: none neede, removing unused test results only.

Removing erroneously committed results content.

  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-add-BE-09-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image1-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image2-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/animation-extRef-image3-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/coords-units-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/ext-TestComic-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-blend-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-color-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-composite-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-conv-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-diffuse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/filters-example-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-dom-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-02-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/interact-order-03-b-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linking-uri-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingCircle-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/linkingToc-t-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/paths-data-04-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/rects_b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-ellipse-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-b-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/shapes-rect-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/struct-frag-01-B-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-02-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-align-03-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-altglyph-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-extTref-BE-18-targ-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-intro-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-tref-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/text-ws-01-f-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-sv-expected.txt: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.checksum: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.png: Removed.
  • svg/W3C-SVG-1.1/Resources/toc-svcmp-expected.txt: Removed.
01:21 Changeset [11361] by eseidel

Bug #: 5881
Submitted by: Rob Buis <​rwlbuis@xs4all.nl>
Reviewed by: eseidel

Fixes 5 test cases:

  • paths-data-02-t.svg (most noticeable)
  • fonts-elem-01-t.svg
  • fonts-elem-02-t.svg
  • fonts-elem-03-t.svg
  • fonts-elem-04-t.svg

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5881
Quadratic bezier path render error

  • ksvg2/svg/svgpathparser.cpp: (SVGPathParser::parseSVG):

11/29/05:

19:12 Changeset [11360] by eseidel

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • fast/dom/HTMLScriptElement/resources/script-set-src-p1fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p2fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p3pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p4pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5fail.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p5pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p6pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p7pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p8pass.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failAfter.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9failBefore.js: Added.
  • fast/dom/HTMLScriptElement/resources/script-set-src-p9pass.js: Added.
  • fast/dom/HTMLScriptElement/script-set-src-expected.txt: Added.
  • fast/dom/HTMLScriptElement/script-set-src.html: Added.
19:12 Changeset [11359] by eseidel

Bug #: 4403
Submitted by: mitz
Reviewed by: darin

Test: fast/dom/HTMLScriptElement/script-set-src.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4403
Script element doesn't load if on set src if already in document

  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): (HTMLScriptElementImpl::closeRenderer):
  • khtml/html/html_headimpl.h:
18:55 Changeset [11358] by eseidel

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820

  • fast/table/cell-width-auto-expected.checksum: Added.
  • fast/table/cell-width-auto-expected.png: Added.
  • fast/table/cell-width-auto-expected.txt: Added.
  • fast/table/cell-width-auto.html: Added.
18:51 Changeset [11357] by eseidel

Bug #: 5820
Submitted by: mitz
Reviewed by: darin

Test: fast/table/cell-width-auto.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5820
Table cells with width:auto should use width from their <col>

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::calcMinMaxWidth):
  • khtml/rendering/render_table.cpp: (RenderTableCell::styleOrColWidth): (RenderTableCell::calcMinMaxWidth):
  • khtml/rendering/render_table.h:
  • khtml/rendering/table_layout.cpp: (FixedTableLayout::calcWidthArray): (AutoTableLayout::recalcColumn): (AutoTableLayout::calcEffectiveWidth):
18:42 Changeset [11356] by eseidel

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Updated results for word space fix:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695

  • fast/css/word-space-extra-expected.checksum:
  • fast/css/word-space-extra-expected.png:
  • fast/css/word-space-extra-expected.txt:
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.checksum: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.png: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt: Added.
  • fast/text/whitespace/span-in-word-space-causes-overflow.html: Added.
18:40 Changeset [11355] by eseidel

Bug #: 4695
Submitted by: mitz
Reviewed by: hyatt

Test: fast/text/span-in-word-space-causes-overflow.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4695
<span> in word-spaced text breaks width calc, causes overflow

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
18:07 Changeset [11354] by eseidel

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentWithPaths:]):
18:06 Changeset [11353] by eseidel

Bug #: 4726
Submitted by: Andrew Wellington <​proton@wiretapped.net>
Reviewed by: darin

No automated test possible.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4726
Drop of multiple non-image file URLs only yields one item

  • khtml/editing/markup.cpp: (khtml::createFragmentFromNodeList):
  • khtml/editing/markup.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
17:58 Changeset [11352] by eseidel

Bug #: 5800
Submitted by: mitz
Reviewed by: eseidel

Test case: fast/css/absolute-poition-in-rtl-parent.html
Fix for bug: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontal):
17:53 Changeset [11351] by eseidel

Bug #: 5800
Submitted by: mitz
Reviewed by: darin

Test cases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5800

  • fast/css/absolute-poition-in-rtl-parent-expected.checksum: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.png: Added.
  • fast/css/absolute-poition-in-rtl-parent-expected.txt: Added.
  • fast/css/absolute-poition-in-rtl-parent.html: Added.
16:57 Changeset [11350] by bdakin

Bug #:
Submitted by:
Reviewed by:

16:29 Changeset [11349] by eseidel

Bug #: 5879
Submitted by: mitz
Reviewed by: eseidel

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5879
REGRESSION: Buttons go into pushed state when moused over when text field has focus

  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::NodeImpl): Initialize m_inActiveChain to false.
16:11 Changeset [11348] by eseidel

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Fixes W3C events tests, no additional tests necessary.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5876

  • ksvg2/css/svg.css: added namespace declaration
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): added support of on* attrs
16:03 Changeset [11347] by eseidel

Bug #: 5873
Submitted by: eseidel
Reviewed by: darin

Update scripts to run SVG tests automatically (w/o --svg) if
WebCore is built with SVG support.

  • Scripts/build-drawtest: SVG support required
  • Scripts/build-dumpkcanvastree: Removed.
  • Scripts/run-drawtest: SVG support required to run
  • Scripts/run-webkit-tests: pass *.svg files if WebCore has support
  • Scripts/webkitdirs.pm: changed CheckWebCoreSVGSupport
14:34 Changeset [11346] by tomernic

Reviewed by John Sullivan, Eric Seidel

<rdar://problem/4340787> Safari sometimes creates 2 instances of plug-ins

  • WebView.subproj/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): Instead of creating a new WebDocumentView, use the WebDataSource's representation if it is a WebDocumentView of the appropriate class. Right now, this can only happen when the loading document is a standalone WebKit plugin, because WebPluginDocumentView is both the WebDocumentView and the WebDocumentRepresentation for that kind of page load.

I have verified that this does not affect other kinds of page loads; in all other cases, the representation
class is distinct from the document view class.

I talked with Chris Blumenberg about this change (he knows this code), and he agreed that this is the right
approach.

14:14 Changeset [11345] by harrison

Reviewed by John Sullivan.

Test cases added: None. Manual testing is way to awkward, and automated testing
is not possible. See following bug...
<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::removedFromTree): Replace tab with spaces. Remove braces from one line "if".
  • kwq/KWQAccObject.mm: (-[KWQAccObject detach]): Send unregisterUniqueIdForUIElement unconditionally, for safety. (-[KWQAccObject dealloc]): New. Send [self detach] so KWQObject gets unregistered and other cleanup happens as well. (CreateCGColorIfDifferent): Replace tab with spaces. (-[KWQAccObject removeAccObjectID]): Early to prevent a crash if called on a detached KWQAccObject (i.e. m_renderer == 0).
11:55 Changeset [11344] by vicki

fixed a typo in the Changelog

11:49 Changeset [11343] by vicki

Changes by Mitz Pettel, reviewed by Maciej.

  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTestLayer): don't add left and bottom borders when hit testing
  • manual-tests/scrollbar-hittest.html: Added.
09:52 Changeset [11342] by darin

Reviewed by Maciej.

  • kwq/KWQKURL.h: Added declaration of createCFURL function.
  • kwq/KWQKURL.mm: (KURL::createCFURL): Moved body of getNSURL in here. (KURL::getNSURL): Changed to createCFURL.
09:44 Changeset [11341] by darin
  • fixed broken tree (from my last check-in)
  • kwq/DOM-CSS.mm: Added "using namespace DOM" and an import of "dom_docimpl.h".
09:28 Changeset [11340] by darin

Reviewed by Maciej.

  • kwq/DOM.mm: Removed extra implementation of -[DOMDocument getComputedStyle::].
  • kwq/DOM-CSS.mm: (-[DOMDocument getComputedStyle::]): Copied slightly better implementation from DOM.mm in here.
09:22 Changeset [11339] by darin

Reviewed by Eric.

  • kwq/KWQFontFamily.h: Replace _NSFamily with _CFFamily.
  • kwq/KWQFontFamily.mm: (KWQFontFamily::KWQFontFamily): Ditto. (KWQFontFamily::operator=): Ditto. (KWQFontFamily::getNSFamily): More of the same. (KWQFontFamily::setFamily): Ditto.
09:17 Changeset [11338] by darin

Reviewed by Geoff.

  • kwq/KWQDateTime.mm: (QTime::msec): Just multiply and mod the time in seconds, don't bother converting to a Gregorian date first, since that won't affect fractional seconds. (QTime::addMSecs): Multiply by 1/1000 instead of dividing by 1000.
09:14 Changeset [11337] by darin

Reviewed by Geoff.

  • kwq/KWQEvent.mm: (WindowsKeyCodeForKeyEvent): Add case for tab key. (QKeyEvent::QKeyEvent): Force use of character code 9 for tab key regardless of what AppKit returns.
  • manual-tests/log-keypress-events.html: Added.
09:03 Changeset [11336] by darin

Reviewed by Maciej.

  • khtml/html/html_imageimpl.h: Removed unused currentImage function.
  • khtml/html/html_imageimpl.cpp: Bits of cleanup in many functins, and: (DOM::HTMLMapElementImpl::mapMouseEvent): Simplified by using traverseNextNode. (DOM::HTMLMapElementImpl::parseMappedAttribute): Fixed bug where parsing a name or attribute value with a "#" prefix would actually modify the value itself by changing the DOMString. Changed the code to make a copy in this case. (DOM::HTMLAreaElementImpl::getRegion): Rearranged to be more readable.
08:35 Changeset [11335] by darin
08:15 Changeset [11334] by darin
  • fixed deployment builds
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): Put decoder local variable inside if statement.
03:20 Changeset [11333] by eseidel

Bug #: 5842
Submitted by: eseidel
Reviewed by: mjs

3 test cases added to cover CSS updates and CDF support.
Updated all test results for absolute bbox change.

Fixed in this patch:

  • kcanvas/KCanvasContainer.cpp: (KCanvasContainer::KCanvasContainer): make "replaced" element
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): added parent offset ASSERT
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): account for parent offset (KCanvasContainerQuartz::absoluteTransform): reflect viewport
  • khtml/css/css_valueimpl.cpp: remove HTML special case (DOM::CSSMutableStyleDeclarationImpl::setChanged):
  • khtml/css/cssstyleselector.cpp: remove HTML special case (khtml::CSSStyleSelector::locateCousinList):
  • khtml/rendering/render_object.cpp: (RenderObject::containingBlock): special case KCanvasContainer
  • khtml/rendering/render_style.cpp: (RenderStyle::operator==): fix call into SVGRenderStyle (RenderStyle::inheritedNotEqual): calls into SVGRenderStyle (RenderStyle::diff): calls into SVGRenderStyle
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::equals): include flags in comparison (SVGRenderStyle::inheritedNotEqual): added
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::parseMappedAttribute): clear path first
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::attributeChanged): map to ksvg2 attributes
  • ksvg2/svg/SVGStyledElementImpl.h:
02:36 Changeset [11332] by eseidel

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Tests for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • fast/js/date-DST-pre-1970-expected.txt: Added.
  • fast/js/date-DST-pre-1970.html: Added.
02:33 Changeset [11331] by eseidel

Bug #: 5514
Submitted by: mitz
Reviewed by: ggaren

Date conversion to local time gets the DST flag wrong sometimes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5514

  • kjs/date_object.cpp: (KJS::isTime_tSigned): (KJS::DateProtoFuncImp::callAsFunction):
02:11 Changeset [11330] by eseidel

Bug #: 5310
Submitted by: mitz
Reviewed by: hyatt

Not possible to test (functionality shouldn't change).

Switch QRegion from using NSBezierPath to CGPath
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5310

  • kwq/KWQRegion.h:
  • kwq/KWQRegion.mm: (QRegion::QRegion): (QRegion::~QRegion): (QRegion::operator=): (QRegion::contains): (QRegion::translate): (QRegion::boundingRect):
01:55 Changeset [11329] by eseidel

Bug #: 5316
Submitted by: darin
Reviewed by: eseidel

Re-enabling hc_noderemovechild.xhtml and fixing bug (hang).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5316

  • dom/xhtml/level1/core/hc_noderemovechild-expected.txt: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.js: hang workaround.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml: Added.
  • dom/xhtml/level1/core/hc_noderemovechild.xhtml-disabled: Removed.
01:07 Changeset [11328] by mjs

LayoutTests:

Reviewed by Darin. Commited by Maciej.

  • fast/dom/Document/document-charset-expected.txt: Added.
  • fast/dom/Document/document-charset.html: Added.

WebCore:

Reviewed by Darin. Commited by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMDocument::):
Note: See TracTimeline for information about the timeline view.