Timeline



Feb 4, 2006:

9:44 PM Changeset in webkit [12568] by mjs
  • 14 edits in trunk/WebCore

Reviewed by Darin.

  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): (WebCore::HTMLOptGroupElementImpl::replaceChild): (WebCore::HTMLOptGroupElementImpl::removeChild): (WebCore::HTMLOptGroupElementImpl::appendChild):
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::insertBefore): (WebCore::HTMLSelectElementImpl::replaceChild): (WebCore::HTMLSelectElementImpl::removeChild): (WebCore::HTMLSelectElementImpl::appendChild):
  • khtml/html/HTMLSelectElementImpl.h:
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::createTFoot):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::insertBefore): (WebCore::NodeImpl::replaceChild): (WebCore::NodeImpl::removeChild): (WebCore::NodeImpl::appendChild):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
9:24 PM Changeset in webkit [12567] by mjs
  • 17 edits
    110 deletes in trunk

LayoutTests:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • fast/media/001-expected.checksum: Removed.
  • fast/media/001-expected.png: Removed.
  • fast/media/001-expected.txt: Removed.
  • fast/media/001.html: Removed.
  • fast/media/002-expected.checksum: Removed.
  • fast/media/002-expected.png: Removed.
  • fast/media/002-expected.txt: Removed.
  • fast/media/002.html: Removed.
  • fast/media/003-expected.checksum: Removed.
  • fast/media/003-expected.png: Removed.
  • fast/media/003-expected.txt: Removed.
  • fast/media/003.html: Removed.
  • fast/media/004-expected.checksum: Removed.
  • fast/media/004-expected.png: Removed.
  • fast/media/004-expected.txt: Removed.
  • fast/media/004.html: Removed.
  • fast/media/005-expected.checksum: Removed.
  • fast/media/005-expected.png: Removed.
  • fast/media/005-expected.txt: Removed.
  • fast/media/005.html: Removed.
  • fast/media/006-expected.checksum: Removed.
  • fast/media/006-expected.png: Removed.
  • fast/media/006-expected.txt: Removed.
  • fast/media/006.html: Removed.
  • fast/media/007-expected.checksum: Removed.
  • fast/media/007-expected.png: Removed.
  • fast/media/007-expected.txt: Removed.
  • fast/media/007.html: Removed.
  • fast/media/008-expected.checksum: Removed.
  • fast/media/008-expected.png: Removed.
  • fast/media/008-expected.txt: Removed.
  • fast/media/008.html: Removed.
  • fast/media/009-expected.checksum: Removed.
  • fast/media/009-expected.png: Removed.
  • fast/media/009-expected.txt: Removed.
  • fast/media/009.html: Removed.
  • fast/media/010-expected.checksum: Removed.
  • fast/media/010-expected.png: Removed.
  • fast/media/010-expected.txt: Removed.
  • fast/media/010.html: Removed.
  • fast/media/011-expected.checksum: Removed.
  • fast/media/011-expected.png: Removed.
  • fast/media/011-expected.txt: Removed.
  • fast/media/011.html: Removed.
  • fast/media/012-expected.checksum: Removed.
  • fast/media/012-expected.png: Removed.
  • fast/media/012-expected.txt: Removed.
  • fast/media/012.html: Removed.
  • fast/media/013-expected.checksum: Removed.
  • fast/media/013-expected.png: Removed.
  • fast/media/013-expected.txt: Removed.
  • fast/media/013.html: Removed.
  • fast/media/014-expected.checksum: Removed.
  • fast/media/014-expected.png: Removed.
  • fast/media/014-expected.txt: Removed.
  • fast/media/014.html: Removed.
  • fast/media/015-expected.checksum: Removed.
  • fast/media/015-expected.png: Removed.
  • fast/media/015-expected.txt: Removed.
  • fast/media/015.html: Removed.
  • fast/media/016-expected.checksum: Removed.
  • fast/media/016-expected.png: Removed.
  • fast/media/016-expected.txt: Removed.
  • fast/media/016.html: Removed.
  • fast/media/017-expected.checksum: Removed.
  • fast/media/017-expected.png: Removed.
  • fast/media/017-expected.txt: Removed.
  • fast/media/017.html: Removed.
  • fast/media/018-expected.checksum: Removed.
  • fast/media/018-expected.png: Removed.
  • fast/media/018-expected.txt: Removed.
  • fast/media/018.html: Removed.
  • fast/media/019-expected.checksum: Removed.
  • fast/media/019-expected.png: Removed.
  • fast/media/019-expected.txt: Removed.
  • fast/media/019.html: Removed.
  • fast/media/020-expected.checksum: Removed.
  • fast/media/020-expected.png: Removed.
  • fast/media/020-expected.txt: Removed.
  • fast/media/020.html: Removed.
  • fast/media/021-expected.checksum: Removed.
  • fast/media/021-expected.png: Removed.
  • fast/media/021-expected.txt: Removed.
  • fast/media/021.html: Removed.
  • fast/media/022-expected.checksum: Removed.
  • fast/media/022-expected.png: Removed.
  • fast/media/022-expected.txt: Removed.
  • fast/media/022.html: Removed.
  • fast/media/023-expected.checksum: Removed.
  • fast/media/023-expected.png: Removed.
  • fast/media/023-expected.txt: Removed.
  • fast/media/023.html: Removed.
  • fast/media/024-expected.checksum: Removed.
  • fast/media/024-expected.png: Removed.
  • fast/media/024-expected.txt: Removed.
  • fast/media/024.html: Removed.
  • fast/media/025-expected.checksum: Removed.
  • fast/media/025-expected.png: Removed.
  • fast/media/025-expected.txt: Removed.
  • fast/media/025.html: Removed.
  • fast/media/026-expected.checksum: Removed.
  • fast/media/026-expected.png: Removed.
  • fast/media/026.html: Removed.
  • fast/media/import-p-green.css: Removed.

WebCore:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Removed.
  • css/css_mediaqueryeval.h: Removed.
  • css/css_mediaqueryimpl.cpp: Removed.
  • css/css_mediaqueryimpl.h: Removed.
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::contains): (MediaListImpl::deleteMedium): (MediaListImpl::mediaText): (MediaListImpl::setMediaText):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::item): (DOM::MediaListImpl::appendMedium):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Removed.
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Removed.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm:
5:48 PM Changeset in webkit [12566] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts
5:43 PM Changeset in webkit [12565] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/js/for-in-var-scope.html: Added.
  • fast/js/resources/for-in-var-scope.js: Added.
  • fast/js/for-in-var-scope-expected.txt: Added.
5:43 PM Changeset in webkit [12564] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Test: fast/js/for-in-var-scope.html

  • kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.
  • other cleanup
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
  • kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.
5:09 PM Changeset in webkit [12563] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Oops, rolled out part that wasn't supposed to be here.

5:07 PM Changeset in webkit [12562] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result due to revised fix for <ol> number
  • fast/lists/olstart-expected.txt: Updated.
5:03 PM Changeset in webkit [12561] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Add a compatibilty hack for people with old Configuration files that say Development or Deployment in them.
4:49 PM Changeset in webkit [12560] by darin
  • 4 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • fixed regressions caused by fix for bug 5776 earlier today
  • rendering/render_list.h: Remove m_value from RenderListMarker, add it to RenderListItem. A few other tweaks, including getting rid of "friend" relationship.
  • rendering/render_list.cpp: (RenderListItem::RenderListItem): Initialize m_value. (RenderListItem::setStyle): Restore old behavior of making no marker for LNONE case. (RenderListItem::calcValue): Work on m_value, not m_marker->m_value. (RenderListItem::resetValue): Reset m_value, even if there's no marker. (RenderListMarker::RenderListMarker): Remove code to set up m_value. (RenderListMarker::calcMinMaxWidth): Get marker value from list item.
  • rendering/RenderContainer.cpp: (updateListMarkerNumbers): Call resetValue by its new name.
3:29 PM Changeset in webkit [12559] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Hyatt.



  • kjs/collector.cpp: (KJS::Collector::numProtectedObjects): renamed from numReferencedObjects (KJS::typeName): (KJS::Collector::rootObjectTypeCounts): renamed from rootObjectClasses, use HashSet
  • kjs/collector.h: (KJS::Collector::isOutOfMemory): Renamed from outOfMemory.
  • kjs/nodes.cpp:

WebCore:

Reviewed by Hyatt.

  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript protectedObjectCount]): Renamed from referencedObjectCounts (+[WebCoreJavaScript rootObjectTypeCounts]): Renamed from rootObjectClasses, changed from NSSet to NSCountedSet.

WebKit:

Reviewed by Hyatt.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.
2:59 PM Changeset in webkit [12558] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: reordered slightly.
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame): Don't take isObject parameter, just check tag name
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::prepareSubmit): remove obsolete hasOnlyLocalReferences check
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): remove obsolete hasOnlyLocalReferences check
  • loader/DocLoader.cpp: (khtml::DocLoader::requestImage): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestStyleSheet): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestScript): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestXSLStyleSheet): remove obsolete hasOnlyLocalReferences check
  • page/Frame.cpp: (WebCore::Frame::requestFrame): refactored and simplified (WebCore::Frame::requestObject): ditto (WebCore::Frame::shouldUsePlugin): ditto (WebCore::Frame::loadPlugin): ditto (WebCore::Frame::loadSubframe): ditto (WebCore::Frame::frameNames): remove obsolete m_bPreloaded check (WebCore::Frame::frames): ditto (WebCore::Frame::connectChild): check isFrame, not child type (WebCore::Frame::disconnectChild): ditto (WebCore::Frame::handleFallbackContent): greatly simplify using onwerElement (WebCore::Frame::updateBaseURLForEmptyDocument): use ownerElement, notChildFrame (WebCore::Frame::onlyLocalReferences): removed (WebCore::Frame::setOnlyLocalReferences): removed
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame::ChildFrame): remove most fields.
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Remove redundant setting of base URL for child document of iframe, Frame itself takes care of this already
10:51 AM Changeset in webkit [12557] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled wrapper already in the directory.
  • Scripts/svn-apply: Handle additions and deletions properly -- I've been noticing these haven't been working at all.
  • Scripts/svn-unapply: Ditto.
10:30 AM Changeset in webkit [12556] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed reviewer name.

8:42 AM Changeset in webkit [12555] by darin
  • 1 edit in trunk/WebCore/khtml/html/html_listimpl.cpp

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly

Feb 3, 2006:

8:57 PM Changeset in webkit [12554] by darin
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).


Layout tests for bug 5776: Generated numbers of ordered lists (OL) are
not calculated right

  • fast/lists/ol-display-types-expected.checksum: Added.
  • fast/lists/ol-display-types-expected.png: Added.
  • fast/lists/ol-display-types-expected.txt: Added.
  • fast/lists/ol-display-types.html: Added.
  • fast/lists/olstart-expected.checksum: Added.
  • fast/lists/olstart-expected.png: Added.
  • fast/lists/olstart-expected.txt: Added.
  • fast/lists/olstart.html: Added.
8:56 PM Changeset in webkit [12553] by darin
  • 2 edits in trunk/WebCore

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly
6:54 PM Changeset in webkit [12552] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Correct the ChangeLog to credit Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

6:14 PM Changeset in webkit [12551] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

beth felt like the changelog was judging her

6:12 PM Changeset in webkit [12550] by ggaren
  • 3 edits in trunk/WebCore

Reviewed beth.

  • Fixed <rdar://problem/4394868> window.open fails to parse "width=200px"

Cause: QString::toInt() is too aggressive; it parses letters as numbers.
The fix is to switch to DOMString. It's all the rage these days,
and its toInt() behavior matches what we want.

  • manual-tests/window-open-features-parsing.html: Added "px" case to giant evil string.
  • khtml/ecma/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::WindowFunc::callAsFunction):
6:01 PM Changeset in webkit [12549] by thatcher
  • 17 edits
    111 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt, Tim H.

Layout tests for:
Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

  • ChangeLog:
  • fast/media: Added.
  • fast/media/001-expected.checksum: Added.
  • fast/media/001-expected.png: Added.
  • fast/media/001-expected.txt: Added.
  • fast/media/001.html: Added.
  • fast/media/002-expected.checksum: Added.
  • fast/media/002-expected.png: Added.
  • fast/media/002-expected.txt: Added.
  • fast/media/002.html: Added.
  • fast/media/003-expected.checksum: Added.
  • fast/media/003-expected.png: Added.
  • fast/media/003-expected.txt: Added.
  • fast/media/003.html: Added.
  • fast/media/004-expected.checksum: Added.
  • fast/media/004-expected.png: Added.
  • fast/media/004-expected.txt: Added.
  • fast/media/004.html: Added.
  • fast/media/005-expected.checksum: Added.
  • fast/media/005-expected.png: Added.
  • fast/media/005-expected.txt: Added.
  • fast/media/005.html: Added.
  • fast/media/006-expected.checksum: Added.
  • fast/media/006-expected.png: Added.
  • fast/media/006-expected.txt: Added.
  • fast/media/006.html: Added.
  • fast/media/007-expected.checksum: Added.
  • fast/media/007-expected.png: Added.
  • fast/media/007-expected.txt: Added.
  • fast/media/007.html: Added.
  • fast/media/008-expected.checksum: Added.
  • fast/media/008-expected.png: Added.
  • fast/media/008-expected.txt: Added.
  • fast/media/008.html: Added.
  • fast/media/009-expected.checksum: Added.
  • fast/media/009-expected.png: Added.
  • fast/media/009-expected.txt: Added.
  • fast/media/009.html: Added.
  • fast/media/010-expected.checksum: Added.
  • fast/media/010-expected.png: Added.
  • fast/media/010-expected.txt: Added.
  • fast/media/010.html: Added.
  • fast/media/011-expected.checksum: Added.
  • fast/media/011-expected.png: Added.
  • fast/media/011-expected.txt: Added.
  • fast/media/011.html: Added.
  • fast/media/012-expected.checksum: Added.
  • fast/media/012-expected.png: Added.
  • fast/media/012-expected.txt: Added.
  • fast/media/012.html: Added.
  • fast/media/013-expected.checksum: Added.
  • fast/media/013-expected.png: Added.
  • fast/media/013-expected.txt: Added.
  • fast/media/013.html: Added.
  • fast/media/014-expected.checksum: Added.
  • fast/media/014-expected.png: Added.
  • fast/media/014-expected.txt: Added.
  • fast/media/014.html: Added.
  • fast/media/015-expected.checksum: Added.
  • fast/media/015-expected.png: Added.
  • fast/media/015-expected.txt: Added.
  • fast/media/015.html: Added.
  • fast/media/016-expected.checksum: Added.
  • fast/media/016-expected.png: Added.
  • fast/media/016-expected.txt: Added.
  • fast/media/016.html: Added.
  • fast/media/017-expected.checksum: Added.
  • fast/media/017-expected.png: Added.
  • fast/media/017-expected.txt: Added.
  • fast/media/017.html: Added.
  • fast/media/018-expected.checksum: Added.
  • fast/media/018-expected.png: Added.
  • fast/media/018-expected.txt: Added.
  • fast/media/018.html: Added.
  • fast/media/019-expected.checksum: Added.
  • fast/media/019-expected.png: Added.
  • fast/media/019-expected.txt: Added.
  • fast/media/019.html: Added.
  • fast/media/020-expected.checksum: Added.
  • fast/media/020-expected.png: Added.
  • fast/media/020-expected.txt: Added.
  • fast/media/020.html: Added.
  • fast/media/021-expected.checksum: Added.
  • fast/media/021-expected.png: Added.
  • fast/media/021-expected.txt: Added.
  • fast/media/021.html: Added.
  • fast/media/022-expected.checksum: Added.
  • fast/media/022-expected.png: Added.
  • fast/media/022-expected.txt: Added.
  • fast/media/022.html: Added.
  • fast/media/023-expected.checksum: Added.
  • fast/media/023-expected.png: Added.
  • fast/media/023-expected.txt: Added.
  • fast/media/023.html: Added.
  • fast/media/024-expected.checksum: Added.
  • fast/media/024-expected.png: Added.
  • fast/media/024-expected.txt: Added.
  • fast/media/024.html: Added.
  • fast/media/025-expected.checksum: Added.
  • fast/media/025-expected.png: Added.
  • fast/media/025-expected.txt: Added.
  • fast/media/025.html: Added.
  • fast/media/026-expected.checksum: Added.
  • fast/media/026-expected.png: Added.
  • fast/media/026.html: Added.
  • fast/media/import-p-green.css: Added.

WebCore:

Reviewed by Dave Hyatt and Tim H.

Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

http://www.w3.org/TR/css3-mediaqueries/

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Added. (MediaQueryEvaluator): (MediaQueryEvaluator::~MediaQueryEvaluator): (MediaQueryEvaluator::mediaTypeMatch): (applyRestrictor): (MediaQueryEvaluator::eval): (parseAspectRatio):
  • css/css_mediaqueryeval.h: Added.
  • css/css_mediaqueryimpl.cpp: Added. (MediaQueryExpImpl::MediaQueryExpImpl): (MediaQueryExpImpl::~MediaQueryExpImpl): (MediaQueryExpImpl::mediaFeature): (MediaQueryExpImpl::value): (MediaQueryImpl::MediaQueryImpl): (MediaQueryImpl::~MediaQueryImpl): (MediaQueryImpl::restrictor): (MediaQueryImpl::expressions): (MediaQueryImpl::mediaType): (MediaQueryImpl::operator==):
  • css/css_mediaqueryimpl.h: Added. (DOM::MediaQueryExpImpl::operator==): (DOM::MediaQueryExpListImpl::MediaQueryExpListImpl): (DOM::MediaQueryExpListImpl::append): (DOM::MediaQueryExpListImpl::list): (DOM::MediaQueryImpl::):
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::deleteMedium): (mediaQueryAsDOMString): (MediaListImpl::mediaText): (MediaListImpl::setMediaText): (MediaListImpl::item): (MediaListImpl::appendMedium): (MediaListImpl::appendMediaQuery):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::mediaQueries):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Added.
  • css/cssparser.cpp: (CSSParser::parseMediaQuery):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::defaultStyleForRoot):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Added.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
5:48 PM Changeset in webkit [12548] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.


  • change spellchecker preflighting to happen via class methods instead of object methods.
  • WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]): (+[WebView _preflightSpellCheckerNow:]): (+[WebView _preflightSpellChecker]):
3:34 PM Changeset in webkit [12547] by thatcher
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

JavaScriptGlue:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/set-webkit-configuration:
  • Scripts/webkitdirs.pm:
2:46 PM Changeset in webkit [12546] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

No test cases added because this is an unreproducible crash.

This is a speculative fix for <rdar://problem/4048026>
CrashTracer: [BOUNCE BACK] 1219 crashes in Safari at
com.apple.WebCore: KHTMLParser::popOneBlock + 36

It seems possible that current could be nil when this function is
called, so the speculative fix is to add a nil check.

3:22 AM Changeset in webkit [12545] by hyatt
  • 4 edits
    6 adds in trunk/WebCore

Refactoring of the image classes to make them even more
portable.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • platform/ImageData.cpp: Added. (WebCore::FrameData::clear): (WebCore::ImageData::ImageData): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setNativeData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation):
  • platform/ImageData.h: Added. (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame):
  • platform/ImageDecoder.h:
  • platform/mac/Image.mm: (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::graphicsContext): (WebCore::setCompositingOperation): (WebCore::fillSolidColorInRect): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/ImageData.mm: Added. (WebCore::setCompositingOperation): (WebCore::ImageData::invalidateAppleSpecificData): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage):
  • platform/mac/PDFDocumentImage.h: Added.
  • platform/mac/PDFDocumentImage.mm: Added. (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw):
1:11 AM Changeset in webkit [12544] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Make a new class called ImageDecoder that wraps a CGImageSource.
This paves the way for ImageData to become portable as well.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ImageDecoder.h: Added.
  • platform/mac/Image.mm: (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::size): (WebCore::ImageData::setCFData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::drawInRect):
  • platform/mac/ImageDecoder.cpp: Added. (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::imageSourceOptions): (WebCore::ImageDecoder::initialized): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::createFrameAtIndex): (WebCore::ImageDecoder::frameDurationAtIndex):

Feb 2, 2006:

11:32 PM Changeset in webkit [12543] by hyatt
  • 5 edits
    1 add in trunk/WebCore

Move ImageAnimationObserver into its own file.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedImage.h:
  • platform/Image.h:
  • platform/ImageAnimationObserver.h: Added. (WebCore::ImageAnimationObserver::~ImageAnimationObserver):
  • platform/mac/Image.mm:
11:18 PM Changeset in webkit [12542] by mjs
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • remove all use of the ChildFrame from outside Frame.cpp, in preparation for removing it
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::frameDetached): Factor out the ChildFrame manipulations into a base class method. (WebCore::MacFrame::objectContentType): factored out from createPart, calls the bridge to determine contents for an Object tag. (WebCore::MacFrame::createPlugin): factor out code from createPart that makes a Plugin. (WebCore::MacFrame::createFrame): ditto for code that makes a Frame. (WebCore::MacFrame::createEmptyDocument): factored out part into the superclass
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): Call new ownerElement method on Frame instead of mucking at Frame internals.
  • page/Frame.cpp: (WebCore::Frame::createPart): Moved here from MacFrame, but some of the guts were factored out. (WebCore::Frame::ownerElement): New method, logic moved from DocumentImpl. (WebCore::Frame::frameDetached): New virtual method, the part of this that pokes at ChildFrame structures. (WebCore::Frame::updateBaseURLForEmptyDocument): Helper that looks at the ChildFrame array for the benefit of createEmptyDocument.
  • page/Frame.h:
  • page/Page.h: Fix up modeline.
  • page/Plugin.h: Added. (WebCore::Plugin::Plugin): Moved here from MacFrame.mm, since it is now used by Frame. (WebCore::Plugin::view): ditto
9:47 PM Changeset in webkit [12541] by hyatt
  • 2 edits in trunk/WebCore

Avoid extra copies of all the decoded image bytes.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::ImageData::setData):
5:16 PM Changeset in webkit [12540] by justing
  • 141 edits
    4 adds in trunk/LayoutTests

Reviewed by harrison


Turned on continuous spell checking to test the fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Added:

  • editing/selection/end-of-document.html

Pixel results for editing tests now include misspelling markers.
A few of them are incorrect, filed 7038 to cover this.

  • editing/deleting/delete-3928305-fix-expected.checksum:
  • editing/deleting/delete-3928305-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-block-contents-003-expected.checksum:
  • editing/deleting/delete-block-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • editing/deleting/delete-contiguous-ws-001-expected.png:
  • editing/deleting/delete-tab-002-expected.checksum:
  • editing/deleting/delete-tab-002-expected.png:
  • editing/deleting/delete-tab-003-expected.checksum:
  • editing/deleting/delete-tab-003-expected.png:
  • editing/deleting/delete-trailing-ws-002-expected.checksum:
  • editing/deleting/delete-trailing-ws-002-expected.png:
  • editing/deleting/delete-ws-fixup-001-expected.checksum:
  • editing/deleting/delete-ws-fixup-001-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/insert-3659587-fix-expected.checksum:
  • editing/inserting/insert-3659587-fix-expected.png:
  • editing/inserting/insert-br-004-expected.checksum:
  • editing/inserting/insert-br-004-expected.png:
  • editing/inserting/insert-br-005-expected.checksum:
  • editing/inserting/insert-br-005-expected.png:
  • editing/inserting/insert-br-007-expected.checksum:
  • editing/inserting/insert-br-007-expected.png:
  • editing/inserting/insert-div-007-expected.checksum:
  • editing/inserting/insert-div-007-expected.png:
  • editing/inserting/insert-div-012-expected.checksum:
  • editing/inserting/insert-div-012-expected.png:
  • editing/inserting/insert-div-013-expected.checksum:
  • editing/inserting/insert-div-013-expected.png:
  • editing/inserting/insert-div-014-expected.checksum:
  • editing/inserting/insert-div-014-expected.png:
  • editing/inserting/insert-div-015-expected.checksum:
  • editing/inserting/insert-div-015-expected.png:
  • editing/inserting/insert-div-016-expected.checksum:
  • editing/inserting/insert-div-016-expected.png:
  • editing/inserting/insert-div-017-expected.checksum:
  • editing/inserting/insert-div-017-expected.png:
  • editing/inserting/insert-div-018-expected.checksum:
  • editing/inserting/insert-div-018-expected.png:
  • editing/inserting/insert-div-019-expected.checksum:
  • editing/inserting/insert-div-019-expected.png:
  • editing/inserting/insert-div-020-expected.checksum:
  • editing/inserting/insert-div-020-expected.png:
  • editing/inserting/insert-div-021-expected.checksum:
  • editing/inserting/insert-div-021-expected.png:
  • editing/inserting/insert-div-022-expected.checksum:
  • editing/inserting/insert-div-022-expected.png:
  • editing/inserting/insert-div-025-expected.checksum:
  • editing/inserting/insert-div-025-expected.png:
  • editing/inserting/insert-div-027-expected.checksum:
  • editing/inserting/insert-div-027-expected.png:
  • editing/inserting/insert-tab-002-expected.checksum:
  • editing/inserting/insert-tab-002-expected.png:
  • editing/inserting/insert-tab-003-expected.checksum:
  • editing/inserting/insert-tab-003-expected.png:
  • editing/inserting/insert-text-with-newlines-expected.checksum:
  • editing/inserting/insert-text-with-newlines-expected.png:
  • editing/inserting/return-key-with-selection-001-expected.checksum:
  • editing/inserting/return-key-with-selection-001-expected.png:
  • editing/inserting/return-key-with-selection-002-expected.checksum:
  • editing/inserting/return-key-with-selection-002-expected.png:
  • editing/inserting/return-key-with-selection-003-expected.checksum:
  • editing/inserting/return-key-with-selection-003-expected.png:
  • editing/inserting/typing-002-expected.checksum:
  • editing/inserting/typing-002-expected.png:
  • editing/inserting/typing-around-br-001-expected.checksum:
  • editing/inserting/typing-around-br-001-expected.png:
  • editing/pasteboard/cut-text-001-expected.checksum:
  • editing/pasteboard/cut-text-001-expected.png:
  • editing/pasteboard/paste-list-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.png:
  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-013-expected.checksum:
  • editing/pasteboard/paste-text-013-expected.png:
  • editing/pasteboard/paste-text-014-expected.checksum:
  • editing/pasteboard/paste-text-014-expected.png:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/extend-by-word-001-expected.checksum:
  • editing/selection/extend-by-word-001-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/move-backwords-by-word-001-expected.checksum:
  • editing/selection/move-backwords-by-word-001-expected.png:
  • editing/selection/move-by-character-001-expected.checksum:
  • editing/selection/move-by-character-001-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/selection/move-by-word-001-expected.checksum:
  • editing/selection/move-by-word-001-expected.png:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/style/block-styles-007-expected.checksum:
  • editing/style/block-styles-007-expected.png:
  • editing/style/create-block-for-style-002-expected.checksum:
  • editing/style/create-block-for-style-002-expected.png:
  • editing/style/create-block-for-style-003-expected.checksum:
  • editing/style/create-block-for-style-003-expected.png:
  • editing/style/create-block-for-style-004-expected.checksum:
  • editing/style/create-block-for-style-004-expected.png:
  • editing/style/create-block-for-style-006-expected.checksum:
  • editing/style/create-block-for-style-006-expected.png:
  • editing/style/create-block-for-style-008-expected.checksum:
  • editing/style/create-block-for-style-008-expected.png:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-012-expected.checksum:
  • editing/style/create-block-for-style-012-expected.png:
  • editing/style/create-block-for-style-013-expected.checksum:
  • editing/style/create-block-for-style-013-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • fast/dom/blur-contenteditable-expected.checksum:
  • fast/dom/blur-contenteditable-expected.png:
5:14 PM Changeset in webkit [12539] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Enabled spell checking for layout tests.


  • DumpRenderTree/DumpRenderTree.m: (main):
5:14 PM Changeset in webkit [12538] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin, harrison


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Calling range() on a WordIterator destroyed its RangeImpl, use
RefPtr instead of PassRefPtr.
Turned on continuous spell checking to test the fix, found
a crasher caused by invalid positions created in
previousBoundary.

Added layout test:

  • editing/selection/end-of-document.html
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary):
4:02 PM Changeset in webkit [12537] by hyatt
  • 2 edits in trunk/WebCore

Vectorize Image. Optimize so that we no longer throw away
all CGImageRefs. Now we just throw away the last frame.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::FrameData::clear): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex):
3:18 PM Changeset in webkit [12536] by ggaren
  • 6 edits in trunk/WebCore

Reviewed by mjs.

Cleaned up some stuff I came across when working with JS enabled/
disabled code:

(1) Renamed initScript to initScriptIfNeeded, because that's what it

does

(2) Removed dead or otherwise irrelevent code
(3) Fixed up comments
(4) Removed NULL checks for interpreter() since it never returns NULL,

replaced with single assert().

No test case because there's no change in behavior.

  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate): 1 (WebCore::KJSProxyImpl::createHTMLEventHandler): 1 (WebCore::KJSProxyImpl::createSVGEventHandler): 1 (WebCore::KJSProxyImpl::interpreter): 4 (WebCore::KJSProxyImpl::initScriptIfNeeded): 1
  • khtml/ecma/kjs_proxy.h: 1
  • page/Frame.cpp: (Frame::didOpenURL): 2, 3 (Frame::stopLoading): 2 (Frame::jScriptEnabled): 2 (Frame::jScript): changed method call to data member access to match

style of rest of class

(Frame::javaEnabled): 2
(Frame::pluginsEnabled): 2
(Frame::begin): 3
(Frame::userGestureHint): 4
(Frame::pauseTimeouts): collapsed a line
(Frame::resumeTimeouts): ditto
(Frame::saveInterpreterBuiltins): 4
(Frame::restoreInterpreterBuiltins): 4

  • page/Frame.h: 2
  • page/FramePrivate.h: 2 (FramePrivate::FramePrivate): 2
1:19 PM Changeset in webkit [12535] by hyatt
  • 2 edits in trunk/WebCore

Fix for PLT performance regression. Make sure that the document's load event timer
isn't started again if it's already active.

Reviewed by mjs

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::dispatchImageLoadEventSoon):
1:00 PM Changeset in webkit [12534] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/lookup.h: Fix compile, merged from KDE.
9:32 AM Changeset in webkit [12533] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • fast/events/onunload-body-property.html: Added.
  • fast/events/onunload-body-property-expected.txt: Added.
  • fast/events/onunload-window-property.html: Added.
  • fast/events/onunload-window-property-expected.txt: Added.
9:31 AM Changeset in webkit [12532] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/events/onunload-body-property.html
  • fast/events/onunload-window-property.html
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): Change onunload case to use unloadEvent, not scrollEvent. (KJS::DOMNode::putValueProperty): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::putValueProperty): Ditto.

Reviewed by Hyatt.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowQObject::installTimeout): When converting the timeout number from an integer ms to a double seconds, use a 10 ms minimum.
9:15 AM Changeset in webkit [12531] by darin
  • 2 edits in trunk/WebCore
  • added a FIXME about an incorrect change made to FloatRect to fix the Win32 compile
  • platform/FloatRect.cpp: (WebCore::enclosingIntRect): Added FIXME because this should do a ceil operation, not a round operation.
1:29 AM Changeset in webkit [12530] by hyatt
  • 3 edits in trunk/WebCore

Fix win32 bustage. #ifdef enclosingIntRect using. Remove floorf and ceilf from enclosingIntRect impl since it's not needed. Fix the bad #import in qmatrix.h

1:00 AM Changeset in webkit [12529] by darin
  • 2 deletes in trunk/WebCore/platform

Deleted these files, Dave checked them in by mistake.

12:52 AM Changeset in webkit [12528] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/006-expected.txt

Check in revised results for 006.html test.

12:40 AM Changeset in webkit [12527] by hyatt
  • 33 edits
    2 copies in trunk/WebCore

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).


Reviewed by darin

  • WebCore.exp:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::imageChanged):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::drawPattern):
  • kwq/KWQClipboard.h: (WebCore::KWQClipboard::setDragHasStarted):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor):
  • kwq/KWQPainter.h: (WebCore::QPainter::):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::inWindow):
  • kwq/WebCoreImageRendererFactory.h:
  • kwq/WebCoreImageRendererFactory.m:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::shouldStopAnimation): (WebCore::CachedImage::animationAdvanced):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged): (WebCore::CachedObjectClient::willRenderImage):
  • platform/Image.h: (WebCore::ImageAnimationObserver::~ImageAnimationObserver): (WebCore::Image::animationObserver): (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame): (WebCore::m_PDFDoc): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setCFData): (WebCore::ImageData::imageSourceOptions): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation): (WebCore::ImageData::setCompositingOperation): (WebCore::ImageData::fillSolidColorInRect): (WebCore::ImageData::drawInRect): (WebCore::drawPattern): (WebCore::): (WebCore::ImageData::tileInRect): (WebCore::ImageData::scaleAndTileInRect): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::graphicsContext): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged):
  • rendering/render_image.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::willRenderImage):
  • rendering/render_object.h:
12:37 AM Changeset in webkit [12526] by hyatt
  • 10 edits in trunk/WebKit

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).

Reviewed by darin

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]):
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData init]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (+[WebImageRendererFactory shouldUseThreadedDecoding]): (+[WebImageRendererFactory setShouldUseThreadedDecoding:]): (-[WebImageRendererFactory setPatternPhaseForContext:inUserSpace:]): (-[WebImageRendererFactory imageDataForName:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
12:36 AM Changeset in webkit [12525] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/block/positioning/height-change-expected.checksum: Added.
  • fast/block/positioning/height-change-expected.png: Added.
  • fast/block/positioning/height-change-expected.txt: Added.
  • fast/block/positioning/height-change.html: Added.
12:35 AM Changeset in webkit [12524] by darin
  • 3 edits in trunk/WebCore

Test: LayoutTests/fast/block/positioning/height-change.html

Reviewed by Hyatt.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Relayout positioned children if the block's height changed during layout.
  • rendering/render_flexbox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
12:22 AM Changeset in webkit [12523] by darin
  • 10 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kjs/function.h:
  • kjs/function.cpp: Use OwnPtr for Parameter pointers.
  • kjs/internal.h: Use Noncopyable for LabelStack.
  • kjs/list.cpp: Use OwnArrayPtr for overflow.
  • kjs/property_map.h:
  • kjs/property_map.cpp: Use OwnArrayPtr for SavedProperties. Use Vector for some stack buffers.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: Use OwnArrayPtr for lastOvector.
12:07 AM Changeset in webkit [12522] by darin
  • 1 edit
    4 adds in trunk/JavaScriptGlue
  • added some forwarding headers to make new JavaScriptCore changes work
  • kxmlcore/Assertions.h: Added.
  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.

Feb 1, 2006:

11:42 PM Changeset in webkit [12521] by mjs
  • 16 edits in trunk/WebCore

Reviewed by Darin.

  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::generateFrameName): (WebCore::MacFrame::submitForm): (WebCore::Frame::frameDetached): (WebCore::MacFrame::nextKeyViewInFrameHierarchy): (WebCore::MacFrame::createEmptyDocument):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): (WebCore::DocumentImpl::parentDocument):
  • page/Frame.cpp: (WebCore::Frame::checkCompleted): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::requestFrameName): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::handleFallbackContent): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • page/FrameTreeNode.cpp: (WebCore::FrameTreeNode::setName): (WebCore::FrameTreeNode::appendChild): (WebCore::FrameTreeNode::removeChild):
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent):
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
11:04 PM Changeset in webkit [12520] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/float/031.html

Back out the changes to 031.html's HTML because of the 4959 partial backout.

11:02 PM Changeset in webkit [12519] by hyatt
  • 4 deletes in trunk/LayoutTests/fast/parser

Remove residual style span form test case because of the backout.

10:45 PM Changeset in webkit [12518] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Back out half of the residual style fix for bug 4959, since treating <span> like residual style breaks fast/block/float/031.html (despite buildbot and people on the outside not seeing it... how weird is that).

9:16 PM Changeset in webkit [12517] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/dom/Window/clear-timeout.html: Added.
  • fast/dom/Window/clear-timeout-expected.txt: Added.
9:15 PM Changeset in webkit [12516] by darin
  • 2 edits in trunk/WebCore

Checking in without review because I *just* broke this with my last check-in.

Test: fast/dom/Window/clear-timeout.html

  • khtml/ecma/kjs_window.cpp: (WindowQObject::clearTimeout): Fixed a != that should have been a ==.
6:51 PM Changeset in webkit [12515] by darin
  • 30 edits
    3 adds
    3 deletes in trunk/WebCore

Reviewed by Hyatt.

  • use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Added.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Added.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Added.
  • ForwardingHeaders/qtimer.h: Removed.
  • kwq/KWQTimer.cpp: Removed.
  • kwq/KWQTimer.h: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Remove timer-related features.
  • kwq/KWQEvent.h: Remove QTimerEvent.
  • WebCore.xcodeproj/project.pbxproj: Updated for file changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/Timer.h: Change to use nextFireInterval rather than nextFireTime. More convenient and also no need to define what the epoch is. Change TimerBase to use a virtual function rather than a function pointer. Added setDeferringTimers function to ensure timers don't fire while handling an event.
  • platform/mac/Timer.cpp: (WebCore::timerFired): Added deferral support. (WebCore::fireDeferred): Added. (WebCore::TimerBase::TimerBase): Simplify to remove function pointer. (WebCore::TimerBase::~TimerBase): Put in here, no longer inline. (WebCore::TimerBase::start): Change to use interval. (WebCore::TimerBase::startRepeating): Change since we use interval now. (WebCore::TimerBase::startOneShot): Ditto. (WebCore::TimerBase::stop): Added deferral support. (WebCore::TimerBase::nextFireInterval): Added. (WebCore::TimerBase::fire): Added. (WebCore::isDeferringTimers): Added. (WebCore::setDeferringTimers): Added.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Update for change to Timer class. (WebCore::MacFrame::passMouseDownEventToWidget): Update to use setDeferringTimers instead of QObject::setDefersTimers.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer): Added. Class for JavaScript "timeout". (KJS::WindowQObject::parentDestroyed): Update to use DOMWindowTimer. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerFired): Ditto. (KJS::DOMWindowTimer::fired): Added.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): Use Timer instead of timer ID. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::continueProcessing): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::stopParsing): Ditto. (WebCore::HTMLTokenizer::processingData): Ditto. (WebCore::HTMLTokenizer::timerFired): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Updated for changes to use RefPtr more cases, and not use it for m_svgExtensions. (WebCore::DocumentImpl::~DocumentImpl): Delete m_svgExtensions instead of just deref'ing it since it's no longer shared. (WebCore::DocumentImpl::implementation): Update for RefPtr. (WebCore::DocumentImpl::elementSheet): Ditto. (WebCore::DocumentImpl::styleSheets): Ditto. (WebCore::DocumentImpl::recalcStyleSelector): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventSoon): Update to use new style timer. (WebCore::DocumentImpl::removeImage): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventsNow): Ditto. (WebCore::DocumentImpl::imageLoadEventTimerFired): Ditto. (WebCore::DocumentImpl::svgExtensions): Update for RefPtr. (WebCore::DocumentImpl::accessSVGExtensions): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.h: (WebCore::TimeScheduler::document):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::downcast): (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::start): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify): (WebCore::TimeScheduler::TimeScheduler): (WebCore::TimeScheduler::~TimeScheduler): (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired): Rework to use new timer.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp: Make SVGDocumentExtensions no longer be shared, be solely owned by the document.
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::createStyleSelector): Update for RefPtr use.
  • kwq/KWQSlot.cpp: Remove endLifeSupport and timerNotify slots.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Update to use new style timer. (WebCore::Frame::caretBlinkTimerFired): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Update to use new style timer. (WebCore::FrameView::clear): Ditto. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::layoutTimerFired): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::layoutPending): Ditto. (WebCore::FrameView::haveDelayedLayoutScheduled): Ditto. (WebCore::FrameView::unscheduleRelayout): Ditto.
  • page/ObjectContents.h: Remove unneeded includes.
  • rendering/render_frames.cpp: Removed include of <qtimer.h>.
  • rendering/render_layer.h:
  • rendering/render_layer.cpp: (WebCore::Marquee::Marquee): Use new style timers. (WebCore::Marquee::start): Ditto. (WebCore::Marquee::suspend): Ditto. (WebCore::Marquee::stop): Ditto. (WebCore::Marquee::updateMarqueeStyle): Ditto. (WebCore::Marquee::timerFired): Ditto.
2:36 PM Changeset in webkit [12514] by bdakin
  • 3 edits in trunk/WebCore

Patch by Darin. Reviewed by Beth.

Fix for <rdar://problem/4424126> REGRESSION(412-420+): yellow
highlight fails to follow cursor when mousing over star rating
(6232)

Event coordinates cannot be calculated until there is a target.
This patch restructures the code so that the coordinates are
initialized when the mouse event is created but are not calculated
until the target is set.

Jan 31, 2006:

10:30 PM Changeset in webkit [12513] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/layer-hit-test-crash-expected.checksum: Added.
  • fast/dynamic/layer-hit-test-crash-expected.png: Added.
  • fast/dynamic/layer-hit-test-crash-expected.txt: Added.
  • fast/dynamic/layer-hit-test-crash.html: Added.

WebCore:

Reviewed by Darin.

  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTestLayer): Iterate vectors in a way that won't break on empty ones.
10:24 PM Changeset in webkit [12512] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • fixed leak of hundreds of thousands of JS parser nodes on the layout tests, and added an exit counter that would catch them
  • kjs/nodes.cpp: (NodeCounter::~NodeCounter): Added debug-only node counter. (Node::Node): (Node::~Node):
  • kxmlcore/VectorTraits.h: Simple classes like RefPtr do in fact need destruction.
8:33 PM Changeset in webkit [12511] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • added deleteAllValues for HashSet as well as HashMap
  • fixed conversion from const_iterator to iterator, which I broke a while back
  • kxmlcore/HashMap.h: Updated copyright date.
  • kxmlcore/HashSet.h: (KXMLCore::deleteAllValues): Added.
  • kxmlcore/HashTable.h: (KXMLCore::HashTableIterator::operator const_iterator): Added.
6:44 PM Changeset in webkit [12510] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/input-changing-value-expected.txt: Added.
  • fast/forms/input-changing-value.html: Added.

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
Input's value doesn't get updated after typing in new text field

Added test:
fast/forms/input-changing-value.html

Added an event listener for a DOMCharacterDataModifiedEvent on the inner div.
When we get the event, then we update the input element's value field.

There may be performance problems with this approach that we will have to
address before flipping the switch to use these new text fields.

  • rendering/RenderTextField.cpp: (WebCore::InputMutationListener::handleEvent): calls subtreeHasChanged (WebCore::m_mutationListener): (WebCore::RenderTextField::~RenderTextField): remove the event listener. (WebCore::RenderTextField::setStyle): Remove unnecessary setStyle on text node. It should inherit style from the div already. (WebCore::RenderTextField::updateFromElement): add the event listener. (WebCore::RenderTextField::subtreeHasChanged): updates the input element's value.
  • rendering/RenderTextField.h: (WebCore::InputMutationListener::InputMutationListener): Added. (WebCore::InputMutationListener::renderTextField): Added. (WebCore::InputMutationListener::setInputElement): Added.
5:49 PM Changeset in webkit [12509] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4267144> REGRESSION (10.4.2): Safari pages auto-scroll too easily during drag over content [5853]


There were two issues here:
(1) dragging over a non-editable webview (such as a typical Safari page) should not have
auto-scrolled at all; the fact that it did was an uninentional side effect of making
auto-scroll work for editable webviews a la Blot.
(2) the speed & hot area of the auto-scroll changed between 10.4.1 and 10.4.2.


I have a fix for (1), which is the much more important issue. I'll modify the bugzilla bug
to be about the remaining issue.

  • WebView.subproj/WebView.m: (-[WebView _autoscrollForDraggingInfo:timeDelta:]): do nothing if not editable (-[WebView _shouldAutoscrollForDraggingInfo:]): return NO if not editable
5:18 PM Changeset in webkit [12508] by thatcher
  • 11 edits
    4 adds in trunk

LayoutTests:

Adding test cases for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

Updated older tests/results to work with the patch.
Some of the tests had an open <span> with no close.

  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-003.html:
  • editing/undo/redo-typing-001-expected.txt:
  • editing/undo/redo-typing-001.html:
  • editing/undo/undo-typing-001-expected.txt:
  • editing/undo/undo-typing-001.html:
  • fast/block/float/031.html:
  • fast/parser/residual-style-span-form-expected.checksum: Added.
  • fast/parser/residual-style-span-form-expected.png: Added.
  • fast/parser/residual-style-span-form-expected.txt: Added.
  • fast/parser/residual-style-span-form.html: Added.
  • fast/text/whitespace/006-expected.txt:

WebCore:

Reviewed by Dave Hyatt.
Landed by Timothy Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

  • khtml/html/htmlparser.cpp: (HTMLParser::isResidualStyleTag): add <span> as residual style tag (HTMLParser::isAffectedByResidualStyle): add <form> as tag affected by residual style
4:24 PM Changeset in webkit [12507] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Adding -Wno-long-double to avoid a warning.

3:59 PM Changeset in webkit [12506] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


Support for programmatic scrolling one line at a time for PDFs. (We already had support for
programmatic scrolling one page at a time, and to top/end.)

  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): generalized comment (-[WebPDFView scrollLineDown:]): pass a faked arrow-down key event (-[WebPDFView scrollLineUp:]): pass a faked arrow-up key event
3:38 PM Changeset in webkit [12505] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fixed an invalid assertion that UTF8Chars is not NULL. It is valid for it to be NULL as long as UTF8Length is 0. This fixes an assertion failure on TOT at <http://www.musicindiaonline.com/p/x/tJO0OOBME9.As1NMvHdW/>, where JavaScript is getting a NULL string back from some call on the Real Player plugin.
1:50 PM Changeset in webkit [12504] by vicki
  • 3 edits
    4 adds
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4426668> REGRESSION: sometimes URLs with named anchors in a page don't jump to proper location in document (6916). Added test cases for this fix and past link jumping bug fixes.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Traverse up the parent node chain until you find one that has a sibling.
  • manual-tests/linkjump-1.html: Added a note here - the bug for this test case is still broken in TOT.
  • manual-tests/linkjump-2.html: Added. Renamed scrollToAnchor.html, to group it with the rest of the link jumping tests.
  • manual-tests/linkjump-3.html: Added. Test case for this bug, <rdar://problem/4426668>.
  • manual-tests/linkjump-4.html: Added. Test case for past fix, <rdar://problem/4247537>.
  • manual-tests/linkjump-5.html: Added. Test case for past fix, <rdar://problem/4256060>.
  • manual-tests/scrollToAnchor.html: Removed.
12:41 PM Changeset in webkit [12503] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test cases for:
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy


  • editing/pasteboard/paste-empty-startcontainer-expected.png: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.checksum: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Added.
  • editing/pasteboard/paste-empty-startcontainer.html: Added.
12:41 PM Changeset in webkit [12502] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy

Layout test added:

  • editing/pasteboard/paste-empty-startcontainer.html


  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::startNode):
  • use empty non-textual m_startContainer itself if m_startOffset is 0, rather then nextSibling()
10:55 AM Changeset in webkit [12501] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


  • fast/forms/selected-index-assert-expected.txt: Added.
  • fast/forms/selected-index-assert.html: Added.

WebCore:

Test: fast/forms/selected-index-assert.html.

Reviewed by Adele.


  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::selectedIndex): Removed bogus assert. -1 is the correct value to return if no option is selected.
10:14 AM Changeset in webkit [12500] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fixing build bustage. Removing include of khtml_factory.h since it
has been removed.

9:45 AM Changeset in webkit [12499] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • fast/forms/button-cannot-be-nested-expected.png: Added.
  • fast/forms/button-cannot-be-nested-expected.txt: Added.
  • fast/forms/button-cannot-be-nested.html: Added.
9:45 AM Changeset in webkit [12498] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • khtml/html/htmlparser.cpp: (HTMLParser::getNode): Add buttonTag to error handling table to take care of unclosed tags.
9:41 AM Changeset in webkit [12497] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.


  • fast/parser/script-after-frameset-assert-expected.txt: Added.
  • fast/parser/script-after-frameset-assert.html: Added.
9:41 AM Changeset in webkit [12496] by darin
  • 2 edits in trunk/WebCore

Test: fast/parser/script-after-frameset-assert.html

Reviewed by Darin.


  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Reset scriptNode to 0 if the script is being skipped.
9:36 AM Changeset in webkit [12495] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/fixed-table-non-cell-in-row.html: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.png: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.checksum: Added.
9:31 AM Changeset in webkit [12494] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): Remove the assertion.
9:18 AM Changeset in webkit [12493] by andersca
  • 5 edits in trunk

2006-01-31 Anders Carlsson <andersca@mac.com>

Reviewed by John.


  • khtml/ecma/kjs_html.cpp: (KJS::ImagePattern::createPattern): Don't mirror the x coordinate when creating the pattern.
9:09 AM Changeset in webkit [12492] by darin
  • 66 edits
    2 adds
    3 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • added a Timer class
  • used the Timer class for the redirection timer
  • moved Frame, FrameView, MacFrame, and FrameNodeTree into WebCore namespace
  • removed more KWQ
  • ForwardingHeaders/khtml_factory.h: Removed.
  • kwq/KWQKHTMLFactory.cpp: Removed.
  • kwq/KWQKHTMLFactory.h: Removed.
  • platform/Timer.h: Added.
  • platform/mac/Timer.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for added and removed files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::init): Remove code to set up slotRedirect. (WebCore::Frame::checkCompleted): Call start/stopRedirectionTimer instead of using the redirection timer directly. (WebCore::Frame::scheduleRedirection): Ditto. (WebCore::Frame::scheduleLocationChange): Ditto. (WebCore::Frame::scheduleHistoryNavigation): Ditto. (WebCore::Frame::cancelRedirection): Ditto. (WebCore::Frame::redirectionTimerFired): Renamed from slotRedirect. (WebCore::Frame::slotParentCompleted): More startRedirectionTimer. (WebCore::Frame::startRedirectionTimer): Added. Virtual bottleneck to start the redirection timer. (WebCore::Frame::stopRedirectionTimer): Added. Virtual bottleneck to stop the redirection timer.
  • page/FramePrivate.h: Changed m_redirectionTimer from a QTimer to a Timer.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Added. Avoids the need for the QTimer "monitor" feature that I had added a while back to implement the client-redirected callback. (WebCore::MacFrame::stopRedirectionTimer): Ditto.
  • kwq/KWQSlot.cpp: Removed slotRedirected.
  • ForwardingHeaders/ksvg2/KSVGPart.h: Removed using to put Frame into various namespaces (all of which are WebCore now anyway).
  • bindings/objc/DOMInternal.mm:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/KWQKHTMLView.cpp:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/SelectionController.h:
  • khtml/editing/jsediting.h:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQClipboard.h:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.h:
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQListBox.mm:
  • kwq/KWQSignalStubs.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQWidget.mm:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • loader/DocLoader.h:
  • page/FrameTreeNode.cpp:
  • page/FrameTreeNode.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • rendering/InlineTextBox.h:
  • rendering/font.cpp:
  • rendering/render_canvas.h:
  • rendering/render_frames.h:
  • rendering/render_object.h:
  • rendering/render_replaced.h: Updated for namespace and header changes.

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Updated for name change.
5:21 AM Changeset in webkit [12491] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Added test case I forgot to commit earlier.


  • fast/parser/remove-block-in-residual-style.html: Added.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Added.
  • fast/parser/remove-block-in-residual-style-expected.png: Added.
  • fast/parser/remove-block-in-residual-style-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.