Timeline


and

03/03/06:

23:42 Changeset [13123] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
  • rendering/RenderThemeWin.h: Added.
23:29 Changeset [13122] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
  • Scripts/run-webkit-tests:
17:35 Changeset [13121] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):
15:33 Changeset [13120] by ggaren

JavaScriptCore:

Reviewed by Darin.

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

  • kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

  • manual-tests/property-map-save-crash.html: Added.
14:10 Changeset [13119] by lypanov

2006-03-03 Alexander Kellett <lypanov@kde.org>

  • local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
11:43 Changeset [13118] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
  • platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):
07:59 Changeset [13117] by darin

LayoutTests:

Reviewed by Eric.

  • fast/innerHTML/innerHTML-custom-tag.html: Added.
  • fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.
  • fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.
  • editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

Test: fast/innerHTML/innerHTML-custom-tag.html

  • editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.
01:54 Changeset [13116] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

  • Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
  • Spinneret/Spinneret/WebFrame.h: Added.
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
01:44 Changeset [13115] by mjs

Rubber stamped by Eric.

  • add new files to build, fix link stubs.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
  • platform/win/TransferJobWin.cpp: Added.
01:31 Changeset [13114] by mjs
  • add file I forgot in my last commit.
  • platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):
01:30 Changeset [13113] by eseidel

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

  • Viewer/ImageDocument.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
  • platform/IntRect.h: (WebCore::IntRect::IntRect):
  • platform/Widget.h:
  • platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
  • platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
  • platform/win/MouseEventWin.cpp:
  • platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
  • platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):
01:19 Changeset [13112] by mjs

Reviewed by Eric.

  • move TransferJob from kwq to platform, separate platform from non-platform bits
  • ForwardingHeaders/kio/job.h: Removed.
  • ForwardingHeaders/kio/jobclasses.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • dom/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/KWQKJobClasses.h: Removed.
  • kwq/KWQKJobClasses.mm: Removed.
  • kwq/KWQLoader.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/TransferJobClient.h: Removed.
  • loader/Cache.cpp:
  • loader/loader.cpp:
  • page/Frame.cpp:
  • platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
  • platform/TransferJob.h: Added.
  • platform/TransferJobClient.h: Added.
  • platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
  • xml/xmlhttprequest.cpp:
01:18 Changeset [13111] by mjs

Reviewed by Eric.

  • enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):

03/02/06:

23:44 Changeset [13110] by mjs

Rubber stamped by Eric.

  • remove function that is now gone
  • platform/win/TemporaryLinkStubs.cpp:
23:41 Changeset [13109] by mjs

Reviewed by Eric.


  • move logic to kick off load from KWQLoader function to a TransferJob method
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJob::start):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
23:16 Changeset [13108] by mjs

Rubber stamped by Eric.

  • remove unused loader parameter to KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
22:58 Changeset [13107] by mjs

Reviewed by Eric.

  • remove one of the versions of KWQServeRequest.
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • platform/win/TemporaryLinkStubs.cpp: (Widget::isEnabled): (KWQServeRequest):
22:13 Changeset [13106] by mjs

Rubber stamped by Eric.

  • win32 build fix.
  • platform/win/MouseEventWin.cpp:
21:37 Changeset [13105] by eseidel

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

  • quality/reporting.html: display a nicer message to those using 10.2
18:53 Changeset [13104] by justing

Reviewed by eric


<http://bugzilla.opendarwin.org/show_bug.cgi?id=3894>
uses of <cmath> should change to <math>

  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGLengthImpl.cpp:
17:52 Changeset [13103] by bdakin

Reviewed by Darin, landed by Beth.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Update existing tests for new results and add new test

17:46 Changeset [13102] by bdakin

Reviewed by Darin, landed by Beth

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3230
CSS1: Words with inline elements get extra capital letters

Does not use UBreakIterator (yet?) for this, but a relatively
simple change that fixes our failure in the CSS1 test suite
(5.4.5).

13:46 Changeset [13101] by eseidel

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
13:45 Changeset [13100] by justing

LayoutTests:

Patch reviewed by sullivan
Test written by mitz


<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • fast/lists/scrolled-marker-paint-expected.checksum: Added.
  • fast/lists/scrolled-marker-paint-expected.png: Added.
  • fast/lists/scrolled-marker-paint-expected.txt: Added.
  • fast/lists/scrolled-marker-paint.html: Added.

WebCore:

Reviewed by sullivan


<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
13:41 Changeset [13099] by eseidel

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Add (partially stubbed out) mouse event handling for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntPoint.h:
  • platform/MouseEvent.h:
  • platform/win/IntPointWin.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINT):
  • platform/win/MouseEventWin.cpp: Added. (WebCore::MouseEvent::MouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setMaxLength): (ScrollView::scrollBy): (WebCore::Widget::setFocus): (FrameWin::respondToChangedSelection): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::registerCommandForUndo): (FrameWin::addMessageToConsole): (FrameWin::mimeTypeForFileName): (FrameWin::shouldChangeSelection): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::personalbarVisible): (FrameWin::objectContentType): (FrameWin::createFrame): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (FrameWin::passSubframeEventToSubframe): (FrameWin::lastEventIsMouseUp): (BrowserExtensionWin::BrowserExtensionWin): (Widget::setCursor): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents): (TransferJob::TransferJob): (TransferJob::addMetaData):
11:40 Changeset [13098] by justing

LayoutTests:

Reviewed by mjs


<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

  • editing/undo/undo-iframe-location-change-expected.txt: Added.
  • editing/undo/undo-iframe-location-change.html: Added.

WebCore:

Reviewed by mjs


<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed


Can't clear undo/redo operations registered by subframes in didOpenURL,
because subframes have already been detached.

  • page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::closeURL):
11:37 Changeset [13097] by thatcher

New tag part two).

11:37 Changeset [13096] by thatcher

New tag.

11:35 Changeset [13095] by thatcher

Versioning to WebCore-417.23

11:32 Changeset [13094] by thatcher

Merged fix from TOT to Safari-2-0-branch
This also includes the http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 fix
<rdar://problem/4462712> REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

2006-02-17 Vicki Murley <vicki@apple.com>

Reviewed by Justin.


Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
  • rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
  • rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
  • rendering/render_replaced.h: Remove handleFocusOut().
  • rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.
02:35 Changeset [13093] by mjs
  • now fix mac build again
  • kjs/identifier.cpp:
02:20 Changeset [13092] by mjs

Rubber stamped by Anders and Eric.

  • add fpconst.cpp to win32 build, it is now needed
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/fpconst.cpp:
02:10 Changeset [13091] by mjs

Reviewed by Eric.

  • fix windows build, broken by my last patch
  • kjs/JSImmediate.cpp:
  • kjs/identifier.cpp:
  • kxmlcore/FastMalloc.cpp:
  • kxmlcore/Platform.h:
01:21 Changeset [13090] by eseidel

Add svn:eol-style=native, and fix line endings.

01:12 Changeset [13089] by mjs

JavaScriptCore:

Reviewed by Darin.


  • Set up new prototype macros and avoid using #if without defined() in JSC


Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
are defined, and to separate core OS-level dependencies from operating environment
dependencies so you can, e.g., build KDE on Mac or Windows.

  • kxmlcore/Platform.h: Added.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/objc_instance.mm: (ObjcInstance::end):
  • bindings/softlinking.h:
  • bindings/testbindings.mm: (main):
  • kjs/JSLock.cpp:
  • kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively):
  • kjs/config.h:
  • kjs/date_object.cpp: (gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::makeTime):
  • kjs/dtoa.cpp:
  • kjs/fpconst.cpp: (KJS::sizeof): (KJS::):
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate): (KJS::Interpreter::createLanguageInstanceForValue):
  • kjs/interpreter.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf):
  • kjs/operations.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h:
  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/Assertions.cpp:
  • kxmlcore/Assertions.h:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::):
  • kxmlcore/FastMalloc.h:
  • kxmlcore/FastMallocInternal.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
  • kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
  • os-win32/stdint.h:

JavaScriptGlue:

Not reviewed, but I noticed these trivial extra changes were needed to avoid
breaking the build with my reviewed patch for:


http://bugzilla.opendarwin.org/show_bug.cgi?id=7387


Add config.h, includes of it, and Platform.h forwarding header.

  • JSBase.cpp:
  • JSObject.cpp:
  • JSRun.cpp:
  • JSUtils.cpp:
  • JSValueWrapper.cpp:
  • JavaScriptGlue.cpp:
  • UserObjectImp.cpp:
  • config.h: Added.
  • kxmlcore/Platform.h: Added.

WebCore:

Reviewed by Darin.


Add Platform.h

  • ForwardingHeaders/kxmlcore/Platform.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m:
  • bridge/mac/WebCoreViewFactory.m:
  • bridge/mac/WebDashboardRegion.m:
  • config.h:
  • platform/Logging.cpp:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
  • platform/mac/WebCoreCookieAdapter.m:
  • platform/mac/WebCoreGraphicsBridge.m:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreImageRendererFactory.m:
  • platform/mac/WebCoreKeyGenerator.m:
  • platform/mac/WebCoreView.m:
00:39 Changeset [13088] by eseidel

2006-03-02 Eric Seidel <eseidel@apple.com>

  • WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build
00:21 Changeset [13087] by eseidel

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

Make spinneret take advantage of the new GraphicsContextCairo.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): updated to match style guidelines.
  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h:
00:20 Changeset [13086] by eseidel

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Add first-stab GraphicsContextCairo.

Shuffle a few more link stubs around, remove uncessary WebCore
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/GraphicsContext.cpp: Added.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::setColor): (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::adjustLineToPixelBounderies): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled):
  • platform/cairo/ImageCairo.cpp:
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (Widget::mapFromGlobal): (QLineEdit::cursorPosition): (QTextEdit::setScrollBarModes): (QTextEdit::selectAll): (QComboBox::focusPolicy): (GraphicsContext::clearShadow): (QTextEdit::setCursorPosition): (GraphicsContext::drawText): (QLineEdit::setLiveSearch): (QComboBox::QComboBox): (Widget::lockDrawingFocus): (QTextEdit::setSelectionRange): (QSlider::QSlider): (ScrollView::scrollYOffset): (QComboBox::sizeHint): (QLineEdit::edited): (QTextEdit::text): (QSlider::value): (WebCore::Widget::setFocus): (WebCore::TransferJob::addMetaData): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::registerCommandForUndo): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::addMessageToConsole): (FrameWin::passWheelEventToChildWidget): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::shouldChangeSelection): (FrameWin::scheduleClose): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::lastEventIsMouseUp): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::userAgent): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::objectContentType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (FrameWin::generateFrameName): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (GraphicsContext::GraphicsContext): (QFontMetrics::isFixedPitch): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::setTitle): (FrameWin::handledOnloadEvents): (FrameWin::markedTextRange): (GraphicsContext::font): (GraphicsContext::setFont):

03/01/06:

22:24 Changeset [13085] by ap

Fixed a typo in the comments added in the previous checkin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
21:58 Changeset [13084] by ap

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET. (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.m: Ditto. Also removed a stale comment about XMLHTTPRequests. (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):
21:55 Changeset [13083] by ap

Reviewed by Darin.

Changed an Objective-C forward declaration from "class" to "@class".
This doesn't appear to fix any problems, though.

  • platform/StringImpl.h:
21:24 Changeset [13082] by justing

harrison forgot to update these pixel results. We should probably move this test out of unsupported-content, since lists are no longer unsupported, but i'll let him do that when he gets back.

21:12 Changeset [13081] by justing

LayoutTests:

Reviewed by darin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • editing/resources/select-all-iframe-src.html: Added.
  • editing/selection/select-all-iframe-expected.checksum: Added.
  • editing/selection/select-all-iframe-expected.png: Added.
  • editing/selection/select-all-iframe-expected.txt: Added.
  • editing/selection/select-all-iframe.html: Added.

WebCore:

Reviewed by darin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

  • page/Frame.cpp: (WebCore::Frame::selectFrameElementInParentIfFullySelected):

WebKitTools:

Reviewed by darin


Give the events that eventSender sends a unique eventNumber

  • DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):
19:33 Changeset [13080] by harrison

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".


  • WebView/WebHTMLView.m: (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]):
  • WebView/WebHTMLViewPrivate.h:
19:32 Changeset [13079] by harrison

Reviewed by Justin.
(missed these in my earlier commit for <rdar://problem/4359736>)

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
18:43 Changeset [13078] by eseidel

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Add a stub win32 application to test WebCore drawing on windows.

  • Spinneret: Added.
  • Spinneret/Spinneret: Added.
  • Spinneret/Spinneret.sln: Added.
  • Spinneret/Spinneret/Resource.h: Added.
  • Spinneret/Spinneret/Spinneret.cpp: Added. (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (About):
  • Spinneret/Spinneret/Spinneret.h: Added.
  • Spinneret/Spinneret/Spinneret.ico: Added.
  • Spinneret/Spinneret/Spinneret.rc: Added.
  • Spinneret/Spinneret/Spinneret.vcproj: Added.
  • Spinneret/Spinneret/WebView.cpp: Added. (WebKit::WebView::WebViewPrivate::WebViewPrivate): (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WebView::windowHandle): (WebKit::WndProc):
  • Spinneret/Spinneret/WebView.h: Added.
  • Spinneret/Spinneret/small.ico: Added.
  • Spinneret/Spinneret/stdafx.cpp: Added.
  • Spinneret/Spinneret/stdafx.h: Added.
18:17 Changeset [13077] by eseidel

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build, add IntRectWin and GraphicsContextCairo stub.

  • Viewer/ImageDocument.cpp:
  • Viewer/ImageMainFrame.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/IntRect.h:
  • platform/cairo/GraphicsContextCairo.cpp: Added.
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForText): (WebCore::GraphicsContext::fillRect): (WebCore::TransferJob::TransferJob): (GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):
18:12 Changeset [13076] by harrison

Updated test case after improving list deletion.

<rdar://problem/4359736> Support outlining ability with lists


  • unsupported-content/list-delete-002-expected.txt: Updated.
  • unsupported-content/list-delete-002.html: Updated.
18:05 Changeset [13075] by harrison

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".
Additional support is to end a list when return is typed on empty list item.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj: Added ModifySelectionListLevelCommand.cpp and ModifySelectionListLevelCommand.h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): Supply list level calls in the bridge.


  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::createListItemElement): New. Creates an li.


(WebCore::InsertParagraphSeparatorCommand::doApply):

  • slight logic cleanup
  • on empty list item, end the list


  • editing/ModifySelectionListLevelCommand.cpp: Added. (WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand): (WebCore::ModifySelectionListLevelCommand::preservesTypingStyle): (WebCore::ModifySelectionListLevelCommand::doApply): (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeAfter): (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
  • editing/ModifySelectionListLevelCommand.h: Added. New editing command for adjusting the list level.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Slight logic cleanup
  • editing/htmlediting.cpp: (WebCore::isListElement): (WebCore::enclosingListChild): New helpers.


(WebCore::isTableElement):
Allow caller to pass 0... return false in that case.


  • editing/htmlediting.h: New helpers.


  • rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): Allow for list children that are not li nodes. Ignore and continue rather than stopping.


(WebCore::RenderContainer::addChild):
Allow for nil beforeChild, meaning "add at end".

18:00 Changeset [13074] by eseidel

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Update ESelectionGranulartiy enum to use newer CamelCase styling.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
  • editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::validate):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/jsediting.cpp:
  • editing/text_granularity.h: (WebCore::):
  • page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventSelection):
12:55 Changeset [13073] by lypanov

2006-03-01 Alexander Kellett <lypanov@kde.org>

Reviewed by Maciej.

Fixes already existing test:

svg/W3C-SVG-1.1/coords-viewattr-02-b.svg

  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGImage.h:

2006-03-01 Alexander Kellett <lypanov@kde.org>

  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
09:56 Changeset [13072] by thatcher

Forgot to add the radar to my changelog entries.

09:54 Changeset [13071] by ap

Reviewed by Darin.

HEAD is currently unimplemented because of what seems to be a bug in NSURLConnection,
and does a GET instead.

WebCore:

  • kwq/KWQKJobClasses.h: Add a method parameter to TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::method):
  • bridge/mac/WebCoreFrameBridge.h: URL loading functions now take a method parameter.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • page/Frame.cpp: (WebCore::Frame::didOpenURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Honor the method passed in open().
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Don't serialize null as "null".

WebKit:

All WebKit changes are to use the method parameter passed from WebCore.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

LayoutTests:

  • http/tests/xmlhttprequest/methods-async-expected.txt: Added.
  • http/tests/xmlhttprequest/methods-async.html: Added.
  • http/tests/xmlhttprequest/methods-expected.txt: Added.
  • http/tests/xmlhttprequest/methods.cgi: Added.
  • http/tests/xmlhttprequest/methods.html: Added.
09:49 Changeset [13070] by thatcher

WebCore:

Reviewed by Darin.


http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary

Support for WebKit. This removes the old elementAtPoint: on the bridge.
WebKit now uses the bridge method getInnerNonSharedNode:innerNode:URLElement:atPoint:

  • WebCore.exp: removes the WebCore* dictionary keys
  • bindings/objc/DOM.mm: (-[DOMElement image]): new method to get an NSImage if the element has an image renderer
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): new method that returns the title after doing the backslash as currency symbol conversion (-[DOMHTMLInputElement altDisplayString]): ditto for alt (-[DOMHTMLImageElement altDisplayString]): ditto (-[DOMHTMLAppletElement altDisplayString]): ditto (-[DOMHTMLAreaElement altDisplayString]): ditto (-[DOMHTMLAnchorElement absoluteLinkURL]): new method to get the absolute NSURL (-[DOMHTMLAreaElement absoluteLinkURL]): ditto (-[DOMHTMLLinkElement absoluteLinkURL]): ditto (-[DOMHTMLInputElement absoluteImageURL]): new method to get the absolute image location as an NSURL (-[DOMHTMLImageElement absoluteImageURL]): ditto (-[DOMHTMLObjectElement absoluteImageURL]): ditto
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:]): (-[WebCoreFrameBridge isPointInsideSelection:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::backslashAsCurrencySymbol):
  • dom/DocumentImpl.h:
  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTest):
  • rendering/render_object.h: (WebCore::RenderObject::NodeInfo::URLElement): (WebCore::RenderObject::NodeInfo::setURLElement):

WebKit:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary


elementAtPoint for WebHTMLView now returns a WebElementDictionary,
when objectForKey is called it will lookup in the DOM, cache and return the value

  • Misc/WebElementDictionary.h: Added.
  • Misc/WebElementDictionary.m: Added. (addLookupKey): (cacheValueForKey): (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary initWithInnerNonSharedNode:innerNode:URLElement:andPoint:]): (-[WebElementDictionary dealloc]): (-[WebElementDictionary _fillCache]): (-[WebElementDictionary count]): (-[WebElementDictionary keyEnumerator]): (-[WebElementDictionary objectForKey:]): (-[WebElementDictionary _domNode]): (-[WebElementDictionary _webFrame]): (-[WebElementDictionary _targetWebFrame]): (-[WebElementDictionary _title]): (-[WebElementDictionary _imageRect]): (-[WebElementDictionary _isSelected]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:
08:33 Changeset [13069] by darin

LayoutTests:

Reviewed by Hyatt.

  • fast/css/hover-subselector-expected.checksum: Added.
  • fast/css/hover-subselector-expected.png: Added.
  • fast/css/hover-subselector-expected.txt: Added.
  • fast/css/hover-subselector.html: Added.

WebCore:

Test: fast/css/hover-subselector.html

Reviewed by Hyatt.

  • css/cssstyleselector.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Pass flag to indicate sub-selector. (WebCore::CSSStyleSelector::checkOneSelector): Apply the *:hover and *:active quirks only when there are no sub-selectors.
01:12 Changeset [13068] by mjs

Rubber stamped by Hyatt.

  • fix win32 build (and make dumprendertree run)
  • kwq/KWQComboBox.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::selectionEnd): (Widget::~Widget): (GraphicsContext::beginTransparencyLayer): (QComboBox::populate): (GraphicsContext::drawConvexPolygon): (QFontMetrics::selectionRectForText): (GraphicsContext::setShadow): (GraphicsContext::clearFocusRing): (GraphicsContext::drawImageInRect): (KWQFileButton::setFilename): (KWQFileButton::focusPolicy): (KWQFileButton::frameGeometry): (QSlider::focusPolicy): (WebCore::GraphicsContext::font): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (QFontMetrics::isFixedPitch): (WebCore::TransferJob::addMetaData):

02/28/06:

23:49 Changeset [13067] by darin

Reviewed by Eric.

  • platform/GraphicsContext.h: Added.
  • platform/TextDirection.h: Added.
  • platform/cg/GraphicsContextCG.cpp: Added.
  • platform/mac/GraphicsContextMac.mm: Added.
  • kwq/KWQPainter.h: Removed.
  • kwq/KWQPainter.mm: Removed.
  • ForwardingHeaders/qpainter.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for moved files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for moved files.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • editing/SelectionController.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty): (KJS::drawPattern):
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight):
  • page/FrameView.h:
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintAllMarkersOfType): (WebCore::InlineTextBox::paintMarkedTextUnderline): (WebCore::InlineTextBox::offsetForPosition):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_button.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::paintObject):
  • rendering/render_button.h: (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintFocusRing): (WebCore::RenderFlow::paintOutlines): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/render_flow.h:
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderTextArea::setStyle):
  • rendering/render_form.h: (WebCore::RenderFieldset::renderName):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintScrollbars): (WebCore::RenderLayer::paint): (WebCore::setClip): (WebCore::restoreClip): (WebCore::RenderLayer::paintLayer): (WebCore::Marquee::direction):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor):
  • rendering/render_object.h: (WebCore::RenderObject::element): (WebCore::RenderObject::document): (WebCore::RenderObject::setNode): (WebCore::RenderObject::node): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::printBoxDecorations):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h: Updated to use GraphicsContext instead of QPainter.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setWritingDirection):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setWritingDirection):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::setWritingDirection):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setWritingDirection):
  • rendering/bidi.cpp: (khtml::bidiNext): (khtml::bidiFirst): Updated to use TextDirection instead of QPainter::TextDirection and EDirection.
  • kcanvas/device/KRenderingDevice.h: Added renderingDevice here to replace QPainter::renderingDevice for now.
  • khtml/ecma/kjs_html.h: Fixed comments to mention GraphicsContext.
  • khtml/html/html_imageimpl.h:
  • page/FrameView.cpp:
  • rendering/RenderBlock.cpp: Added include needed since I reduced includes elsewhere.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Changed QChar* to be const QChar*.
  • platform/FontDescription.h: Added include that was missing.
  • rendering/render_theme.cpp: Ditto.
  • platform/Image.h: Removed unnecessary forward declaration of QPainter.
  • rendering/RenderText.h: Clean up types, use const.
  • rendering/render_style.h: Removed EDirection and replaced it with TextDirection.
  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle): (WebCore::KCanvasCreator::createRectangle): (WebCore::KCanvasCreator::createEllipse): (WebCore::KCanvasCreator::createLine):
  • kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasContainerQuartz::paint): (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::pushContext): (WebCore::KRenderingDeviceQuartz::popContext): (WebCore::renderingDevice):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer):
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource):
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: (WebCore::SVGFEDiffuseLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: (SVGFESpecularLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer):
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::canvasResource):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (WebCore::SVGMarkerElementImpl::canvasResource): (WebCore::SVGMarkerElementImpl::createRenderer):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (WebCore::SVGMaskElementImpl::drawMaskerContent): (WebCore::SVGMaskElementImpl::createRenderer): (WebCore::SVGMaskElementImpl::canvasResource):
  • ksvg2/svg/SVGPathElementImpl.cpp: (WebCore::SVGPathElementImpl::toPathData):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (WebCore::SVGPatternElementImpl::drawPatternContentIntoTile): (WebCore::SVGPatternElementImpl::createRenderer): (WebCore::SVGPatternElementImpl::canvasResource):
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData):
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::createRenderer):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (WebCore::SVGStyledElementImpl::createRenderer):
  • ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): Updated to use renderingDevice instead of QPainter::renderingDevice.
23:19 Changeset [13066] by ggaren

Reviewed by Darin.

  • Fixed <rdar://problem/4448098> Switch PropertyMap deleted entry placeholder to -1 from UString::Rep::null

This turned out to be only a small speedup (.12%). That's within the
margin of error for super accurate JS iBench, but Shark confirms the
same, so I think it's worth landing.

FYI, I also confirmed that the single entry optimization in
PropertyMap is a 3.2% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::deletedSentinel):
22:37 Changeset [13065] by darin
  • fixed part of the reason the build is broken
  • WebCore.xcodeproj/project.pbxproj: Updated project file.
22:23 Changeset [13064] by darin

Rubber-stamped by Hyatt.

  • moved the WebCoreXXX files from kwq to appropriate directories

No changes to the contents of the files.

  • WebCore.xcodeproj/project.pbxproj: Updated project file.
  • bridge/mac/WebCoreCache.h: Added.
  • bridge/mac/WebCoreCache.mm: Added.
  • bridge/mac/WebCoreEncodings.h: Added.
  • bridge/mac/WebCoreEncodings.mm: Added.
  • bridge/mac/WebCoreFrameNamespaces.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m: Added.
  • bridge/mac/WebCoreFrameView.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Added.
  • bridge/mac/WebCoreJavaScript.mm: Added.
  • bridge/mac/WebCoreKeyboardAccess.h: Added.
  • bridge/mac/WebCoreResourceLoader.h: Added.
  • bridge/mac/WebCoreScriptDebugger.h: Added.
  • bridge/mac/WebCoreScriptDebugger.mm: Added.
  • bridge/mac/WebCoreSettings.h: Added.
  • bridge/mac/WebCoreSettings.mm: Added.
  • bridge/mac/WebCoreTextDecoder.h: Added.
  • bridge/mac/WebCoreTextDecoder.mm: Added.
  • bridge/mac/WebCoreViewFactory.h: Added.
  • bridge/mac/WebCoreViewFactory.m: Added.
  • bridge/mac/WebDashboardRegion.h: Added.
  • bridge/mac/WebDashboardRegion.m: Added.
  • kwq/WebCoreCache.h: Removed.
  • kwq/WebCoreCache.mm: Removed.
  • kwq/WebCoreCookieAdapter.h: Removed.
  • kwq/WebCoreCookieAdapter.m: Removed.
  • kwq/WebCoreEncodings.h: Removed.
  • kwq/WebCoreEncodings.mm: Removed.
  • kwq/WebCoreFrameNamespaces.h: Removed.
  • kwq/WebCoreFrameNamespaces.m: Removed.
  • kwq/WebCoreFrameView.h: Removed.
  • kwq/WebCoreGraphicsBridge.h: Removed.
  • kwq/WebCoreGraphicsBridge.m: Removed.
  • kwq/WebCoreHistory.h: Removed.
  • kwq/WebCoreHistory.m: Removed.
  • kwq/WebCoreImageRenderer.h: Removed.
  • kwq/WebCoreImageRendererFactory.h: Removed.
  • kwq/WebCoreImageRendererFactory.m: Removed.
  • kwq/WebCoreJavaScript.h: Removed.
  • kwq/WebCoreJavaScript.mm: Removed.
  • kwq/WebCoreKeyGenerator.h: Removed.
  • kwq/WebCoreKeyGenerator.m: Removed.
  • kwq/WebCoreKeyboardAccess.h: Removed.
  • kwq/WebCoreResourceLoader.h: Removed.
  • kwq/WebCoreScriptDebugger.h: Removed.
  • kwq/WebCoreScriptDebugger.mm: Removed.
  • kwq/WebCoreSettings.h: Removed.
  • kwq/WebCoreSettings.mm: Removed.
  • kwq/WebCoreTextDecoder.h: Removed.
  • kwq/WebCoreTextDecoder.mm: Removed.
  • kwq/WebCoreTextRenderer.h: Removed.
  • kwq/WebCoreTextRendererFactory.h: Removed.
  • kwq/WebCoreTextRendererFactory.mm: Removed.
  • kwq/WebCoreView.h: Removed.
  • kwq/WebCoreView.m: Removed.
  • kwq/WebCoreViewFactory.h: Removed.
  • kwq/WebCoreViewFactory.m: Removed.
  • kwq/WebDashboardRegion.h: Removed.
  • kwq/WebDashboardRegion.m: Removed.
  • platform/mac/WebCoreCookieAdapter.h: Added.
  • platform/mac/WebCoreCookieAdapter.m: Added.
  • platform/mac/WebCoreGraphicsBridge.h: Added.
  • platform/mac/WebCoreGraphicsBridge.m: Added.
  • platform/mac/WebCoreHistory.h: Added.
  • platform/mac/WebCoreHistory.m: Added.
  • platform/mac/WebCoreImageRenderer.h: Added.
  • platform/mac/WebCoreImageRendererFactory.h: Added.
  • platform/mac/WebCoreImageRendererFactory.m: Added.
  • platform/mac/WebCoreKeyGenerator.h: Added.
  • platform/mac/WebCoreKeyGenerator.m: Added.
  • platform/mac/WebCoreTextRenderer.h: Added.
  • platform/mac/WebCoreTextRendererFactory.h: Added.
  • platform/mac/WebCoreTextRendererFactory.mm: Added.
  • platform/mac/WebCoreView.h: Added.
  • platform/mac/WebCoreView.m: Added.
22:16 Changeset [13063] by hyatt

Fold QFont into Font and eliminate QFont completely.

Reviewed by eric

  • ForwardingHeaders/qfont.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setFont):
  • kwq/KWQFont.h: Removed.
  • kwq/KWQFont.mm: Removed.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetricsPrivate::~QFontMetricsPrivate): (QFontMetricsPrivate::getRenderer): (QFontMetricsPrivate::fontDescription): (QFontMetricsPrivate::setFontDescription): (QFontMetricsPrivate::getWebCoreFont): (QFontMetricsPrivate::isFixedPitch): (QFontMetricsPrivate::determinePitch): (QFontMetrics::QFontMetrics): (QFontMetrics::setFontDescription): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::selectionRectForText): (QFontMetrics::checkSelectionPoint): (QFontMetrics::getWebCoreFont): (QFontMetrics::isFixedPitch):
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (-[NSSearchField _addStringToRecentSearches:]): (QLineEdit::setFont):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): (QListBox::setFont): (-[KWQTableView drawRow:clipRect:]):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::font): (WebCore::QPainter::setFont): (WebCore::QPainter::fontMetrics): (WebCore::QPainter::_updateRenderer): (WebCore::QPainter::drawText): (WebCore::QPainter::drawHighlightForText):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::setFont):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setFont):
  • platform/Font.cpp: (khtml::Font::update):
  • platform/Font.h: (WebCore::): (WebCore::Font::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::operator!=): (WebCore::Font::fontMetrics): (WebCore::Font::pixelSize): (WebCore::Font::size): (WebCore::Font::letterSpacing): (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::isPrinterFont): (WebCore::Font::firstFamily): (WebCore::Font::family): (WebCore::Font::italic): (WebCore::Font::weight): (WebCore::Font::getNSFamily): (WebCore::Font::getNSFont): (WebCore::Font::getWebCoreFont):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription):
  • platform/FontFamily.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::font): (WebCore::Widget::setFont):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::font): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::findNextLineBreak):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::fontSize): (khtml::RenderStyle::fontMetrics): (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
21:31 Changeset [13062] by darin

WebCore:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebCore.exp: Remove WebCoreScrollView class name.
  • kwq/WebCoreScrollView.h: Removed.
  • kwq/WebCoreScrollView.m: Removed.
  • WebCore.xcodeproj/project.pbxproj: Remove WebCoreScrollView source files.
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView autoforwardsScrollWheelEvents]): Added.
  • kwq/KWQTextArea.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView autoforwardsScrollWheelEvents]): Ditto.

WebKit:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebView/WebDynamicScrollBarsView.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView autoforwardsScrollWheelEvents]): Added.
18:54 Changeset [13061] by justing

Forgot to check in my changes to editing.js

17:14 Changeset [13060] by eseidel

2006-02-28 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): add ability to dump render tree and read from a local file.
17:14 Changeset [13059] by eseidel

2006-02-28 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix spacing/style on several of the stubs.
Reorganize stubs, separating empty stubs.
Remove the abort from certain stubs blocking DRT.
Add a virtual setView call to Frame baseclass.

  • bridge/mac/MacFrame.h: mark setView virtual
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): remove no-renderer hack
  • page/Frame.cpp: (WebCore::Frame::view): fix spacing (WebCore::Frame::setView): added.
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (notImplemented): make break directly into debugger. Moved, modified several other stubs not mentioned here.
13:00 Changeset [13058] by justing

LayoutTests:

Reviewed by mjs


Tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/editing.js:
  • editing/execCommand/insertHTML-expected.checksum: Added.
  • editing/execCommand/insertHTML-expected.png: Added.
  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html: Added.

WebCore:

Reviewed by mjs


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/jsediting.cpp:
11:22 Changeset [13057] by mjs

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.h: Added.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Initialize browser extension and settings.
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): Don't create renderers for now.
  • dom/EventNames.cpp: (WebCore::EventNames::init): use placement new even when not avoiding static constructors.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): ditto
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): ditto
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): Added default constructor but only in ifdef.
  • page/Frame.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init): use placement new even when not avoiding static constructors
  • platform/StaticConstructors.h: don't initialize when not avoiding static constructors, just default construct and let initialization happen normally
  • platform/win/TemporaryLinkStubs.cpp: Stub out some more things (Cursor::~Cursor): (QFont::~QFont): (QFontMetrics::~QFontMetrics): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::BrowserExtensionWin::getHistoryLength): (WebCore::BrowserExtensionWin::canRunModal): (WebCore::BrowserExtensionWin::openURLNotify): (WebCore::BrowserExtensionWin::canRunModalNow): (WebCore::BrowserExtensionWin::runModal): (WebCore::BrowserExtensionWin::goBackOrForward):
10:57 Changeset [13056] by sullivan
  • WebKitSystemInterface.h: Removed WKMouseIsDown()
  • libWebKitSystemInterface.a: ditto
10:48 Changeset [13055] by sullivan

Reviewed by Eric Seidel


Wean WebKit from one more SPI call. We learned about this new-to-Tiger
API from filing Radar 4433222.

  • WebView/WebHTMLView.m: (-[WebHTMLView _autoscroll]): use public CGEventSourceButtonState() instead of WKMouseIsDown() (which was using SPI internally)
00:30 Changeset [13054] by eseidel

Fix line endings in two files, and apply svn:eol-style=native to all source files w/o it.

00:02 Changeset [13053] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Remove abort() from constructors to allow DRT to run.

  • platform/win/TemporaryLinkStubs.cpp: (QFont::QFont): (QFontMetrics::QFontMetrics):

02/27/06:

23:56 Changeset [13052] by eseidel

Add svn:ignore property to ignore zip files

23:52 Changeset [13051] by justing

LayoutTests:

Reviewed by darin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped

  • fast/forms/textarea-hard-linewrap-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap.html: Added.
  • fast/forms/textarea-setvalue-submit-expected.txt: Added.
  • fast/forms/textarea-setvalue-submit.html: Added.

WebCore:

Reviewed by darin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped


Canonicalize line endings in textareas to avoid the workarounds that were a source of bugs,
Also call textWithHardLineWraps inside appendFormData (and nowhere else) if wrap="hard".

  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (WebCore::HTMLTextAreaElementImpl::select): (WebCore::HTMLTextAreaElementImpl::appendFormData): (WebCore::HTMLTextAreaElementImpl::rendererWillBeDestroyed): (WebCore::HTMLTextAreaElementImpl::updateValue): (WebCore::HTMLTextAreaElementImpl::value): (WebCore::HTMLTextAreaElementImpl::setValue): (WebCore::HTMLTextAreaElementImpl::defaultValue):
  • khtml/html/HTMLTextAreaElementImpl.h: (DOM::HTMLTextAreaElementImpl::invalidateValue):
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView text]): (-[KWQTextAreaTextView textWithHardLineBreaks]): (-[KWQTextAreaTextView setSelectedRange:]): (-[KWQTextAreaTextView selectedRange]): (-[KWQTextAreaTextView getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextAreaTextView textView:shouldChangeTextInRange:replacementString:]):
  • rendering/render_form.cpp: (WebCore::RenderTextArea::destroy): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks):
  • rendering/render_form.h:
23:06 Changeset [13050] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

  • Scripts/install-win-extras: fix dll permissions & download zlib too.
23:05 Changeset [13049] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Copy missing dlls to build directory.

  • Viewer.cpp: fix line endings
  • Viewer/ImageView.cpp: fix line endings
  • Viewer/stdafx.cpp: fix line endings
  • WebCore.vcproj/WebCore/build-generated-files.sh:
22:39 Changeset [13048] by darin

LayoutTests:

Reviewed by Darin.

  • fast/dom/css-selectorText-expected.checksum: Updated.
  • fast/dom/css-selectorText-expected.png: Updated.
  • fast/dom/css-selectorText-expected.txt: Updated.
  • fast/dom/css-selectorText.html: Added a case with multiple subselectors.

WebCore:

Test: added to fast/dom/css-selectorText.html

Reviewed by Darin.

  • css/css_base.cpp: (CSSSelector::selectorText): Iterate over subselectors
22:27 Changeset [13047] by darin

Oops, this was in change log, but not committed.

22:17 Changeset [13046] by mjs

Reviewed by Darin.

  • write a portable ICU version of TextEncoding::fromUnicode for use on win32
  • platform/StreamingTextDecoder.h:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): added (WebCore::getConverter): helper (WebCore::cacheConverter): ditto (WebCore::effectiveEncoding): ditto
  • platform/mac/TextEncodingMac.cpp: Add comment
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode): remove
21:55 Changeset [13045] by darin

LayoutTests:

Reviewed by Darin.

  • fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • fast/text/in-rendered-text-rtl-expected.png: Added.
  • fast/text/in-rendered-text-rtl-expected.txt: Added.
  • fast/text/in-rendered-text-rtl.html: Added.

WebCore:

Test: fast/text/in-rendered-text-rtl.html

Reviewed by Darin.

  • dom/dom_position.cpp: (WebCore::Position::inRenderedText): If the RenderText contains reversed text, the text boxes are not necessarily ordered by start position, so iterate through all of them. (WebCore::Position::isRenderedCharacter): Ditto.
21:44 Changeset [13044] by darin

LayoutTests:

Reviewed by Darin.

The head-check.html document uses an iframe as a laboratory for loading each
head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
Live DOM Viewer: http://software.hixie.ch/utilities/js/live-dom-viewer/

Each of the four head-check-N.html files tests a different code path for
creating a document's head element in WebCore/khtml/html/htmlparser.cpp.

  • editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child index for <body> since the document previously had two <head> nodes.
  • fast/dom/HTMLHeadElement: Added.
  • fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
  • fast/dom/HTMLHeadElement/head-check.html: Added.
  • fast/dom/HTMLHeadElement/resources: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check.js: Added.

WebCore:

Reviewed by Darin.

  • khtml/html/htmlparser.cpp: Handle the head node like form and map nodes. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::headCreateErrorCheck):
21:38 Changeset [13043] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add stub to make DRT link.
Make WebCore copy libxml.dll into build directory when building.

  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode):
21:03 Changeset [13042] by darin

Reviewed by Eric.

  • fix regression in layout tests
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength): Fix some code that was not properly truncating. I broke it in my string change this morning.
21:02 Changeset [13041] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Rubber-stamped by darin.

Remove fpconst.cpp, unused on win32 and the cause of linker warnings.

20:55 Changeset [13040] by mjs

Rubber stamped by Eric.

  • add stubs for FrameWin overrides of pure virtual Frame methods
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::unfocusWindow): (WebCore::FrameWin::locationbarVisible): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::issueRedoCommand): (WebCore::FrameWin::canRedo): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::canUndo): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::print): (WebCore::FrameWin::issueCutCommand): (WebCore::FrameWin::issueCopyCommand): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::issueUndoCommand): (WebCore::FrameWin::clearRecordedFormValues): (WebCore::FrameWin::issuePasteCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::menubarVisible): (WebCore::FrameWin::personalbarVisible): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::statusbarVisible): (WebCore::FrameWin::toolbarVisible): (WebCore::FrameWin::issueTransposeCommand): (WebCore::FrameWin::userAgent): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::canGoBackOrForward): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::generateFrameName):
20:27 Changeset [13039] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add constructor and destructor.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
20:23 Changeset [13038] by mjs

Rubber stamped by Eric (sorta).

  • add return values where needed
  • platform/win/TemporaryLinkStubs.cpp: (KWQServeRequest): (KWQServeSynchronousRequest):
20:13 Changeset [13037] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix Assertions.cpp to compile on win32.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kxmlcore/Assertions.cpp:
20:12 Changeset [13036] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add a couple more stubs to make Win32 link.

  • platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): (WebCore::FrameView::topLevelWidget):
19:56 Changeset [13035] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Move mac-specific logging logic up into WebCore (from JavaScriptCore).
Remove KWQ prefixes from default log channels.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • bridge/mac/WebCorePageBridge.mm: (initializeLogChannel): (initializeLoggingChannelsIfNecessary): (-[WebCorePageBridge init]):
  • page/Frame.h:
  • platform/Logging.cpp:
  • platform/Logging.h:
19:51 Changeset [13034] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Made Assertions.cpp platform independent.
Moved mac-specific logging logic up into WebCore.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kxmlcore/Assertions.cpp: Added.
  • kxmlcore/Assertions.h:
  • kxmlcore/Assertions.mm: Removed.
19:41 Changeset [13033] by darin

Reviewed by Maciej.

  • fix <rdar://problem/4104575> hang due to slow saveDocumentState method
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Change code that iterates a QStringList with indices to use iterator instead.
19:38 Changeset [13032] by mjs

Reviewed by Eric.

  • portable version of QString::utf8
  • platform/QString.cpp: (QString::utf8): moved here, rewritten to use TextCodec
  • platform/mac/QStringMac.mm: (QString::utf8): removed from here
18:53 Changeset [13031] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Rubber-stamped by mjs.

Fix FrameWin.h to use consistant line endings.
Fix TemporaryLinkStubs to better match style guidelines.

  • bridge/win/FrameWin.h: (WebCore::Win):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (Widget::mapFromGlobal): (QPainter::addClip): (QLineEdit::cursorPosition): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (QPainter::drawFocusRing): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (QComboBox::clear): (QPainter::misspellingLineThickness): (QComboBox::setFrameGeometry): (QLineEdit::maxLength): (Widget::isEnabled): (KWQServeRequest): (QTextEdit::setText): (Widget::paint): (QPainter::addRoundedRectClip): (FrameView::viewportToGlobal): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (QPainter::drawEllipse): (QTextEdit::setReadOnly): (QListBox::appendItem): (QLineEdit::setPlaceholderString): (Cursor::Cursor): (Widget::focusPolicy): (ScrollView::removeChild): (QTextEdit::selectAll): (QPainter::fillRect): (QPainter::endTransparencyLayer): (QFont::QFont): (ScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (Widget::~Widget): (QPainter::xForm): (QListBox::sizeForNumberOfLines): (ScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (FrameView::updateBorder): (QLineEdit::hasSelectedText): (QScrollBar::QScrollBar): (QListBox::doneAppendingItems): (QTextEdit::QTextEdit): (ScrollView::inWindow): (QScrollBar::setValue): (QFont::setFirstFamily): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (ScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (QTextEdit::setLineHeight): (QScrollBar::setKnobProportion): (KWQFileButton::KWQFileButton): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (QPainter::beginTransparencyLayer): (QFontMetrics::setFont): (QComboBox::setFont): (Widget::frameGeometry): (QListBox::setSelected): (QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (QPainter::restore): (QFontMetrics::width): (Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (ScrollView::setStaticBackground): (QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (QPainter::drawText): (QPainter::pen): (KJavaAppletWidget::KJavaAppletWidget): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (Widget::setIsSelected): (QLineEdit::text): (Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (QPainter::paintingDisabled): (QComboBox::QComboBox): (QPainter::drawConvexPolygon): (Widget::setFont): (QSlider::setMaxValue): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QTextEdit::setSelectionRange): (ScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (ScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (Widget::setCursor): (QLineEdit::setAutoSaveName): (QComboBox::baselinePosition): (QComboBox::appendItem): (QPainter::setShadow): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (QSlider::QSlider): (ScrollView::setVScrollBarMode): (QPainter::drawScaledAndTiledImage): (ScrollView::scrollYOffset): (QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (ScrollView::setScrollBarsMode): (QComboBox::sizeHint): (QPainter::drawRect): (QFont::setPixelSize): (Widget::setFrameGeometry): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (QFont::operator==): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (QPainter::setFont): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (QPainter::drawLineForMisspelling): (QLineEdit::setText): (QSlider::value): (QListBox::setSelectionMode): (KWQFileButton::setFilename): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (ScrollView::updateContents): (QFontMetrics::floatWidth): (ScrollView::setHScrollBarMode): (KWQFileButton::focusPolicy): (QListBox::setFont): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (KWQFileButton::setFrameGeometry): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (QTextEdit::setFont): (QLineEdit::setFont): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QSlider::setFont): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar): (Path::operator=): (QLineEdit::setColors): (QTextEdit::setColors): (searchableIndexIntroduction): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookie): (WebCore::screenRect): (WebCore::Widget::clearFocus): (WebCore::historyContains): (KWQFindNextSentenceFromIndex): (KWQFindSentenceBoundary): (KWQFindNextWordFromIndex): (KWQFindWordBoundary): (submitButtonDefaultLabel): (inputElementAltText): (resetButtonDefaultLabel): (KWQKCookieJar::cookieEnabled): (WebCore::Widget::setFocus): (WebCore::QPainter::fillRect): (WebCore::QPainter::~QPainter): (WebCore::ScrollView::viewportToContents): (WebCore::TransferJob::kill): (WebCore::TransferJob::addMetaData): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::error): (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::TransferJob::TransferJob): (WebCore::Widget::hide): (KLocale::language): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::screenDepth): (QFont::italic): (QFontMetrics::operator=): (QFontMetrics::xHeight): (WebCore::usableScreenRect): (QFont::operator=): (Widget::setActiveWindow): (KWQCheckIfReloading): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (KWQCheckCacheObjectStatus):
17:17 Changeset [13030] by tomernic

Reviewed by Adele.

<rdar://problem/4222043> Safari should reduce null events sent to invisible plugins

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Check to see if the plugin view is completely obscured (scrolled out of view, for example). If it is obscured and it wasn't before, or the other way around, then restart the null event timer so it can fire at the appropriate rate. (-[WebBaseNetscapePluginView viewHasMoved:]): If a plugin is obscured, send it null events as if it were in an inactive window.
17:00 Changeset [13029] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Fix xcode project after previous KWQLogging move.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Logging.h:
16:41 Changeset [13028] by justing

LayoutTests:

Reviewed by darin


Test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

  • fast/events/onclick-list-marker-expected.txt: Added.
  • fast/events/onclick-list-marker.html: Added.

WebCore:

Reviewed by darin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker


Consider the case of outside list markers in nodeAtPoint. Had to pull
the code out of RenderListMarker::paint that computed the position/size
of the list marker.

Added:

  • fast/events/onclick-list-marker.html
  • rendering/render_list.cpp: (RenderListItem::nodeAtPoint): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::nodeAtPoint): (RenderListMarker::getRelativeMarkerRect):
  • rendering/render_list.h:
  • rendering/render_object.h:
16:19 Changeset [13027] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Move KWQLogging to platform and rename as Logging.*, fix headers.
This will break the mac build, which I will fix on my next commit.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • dom/DocumentImpl.cpp:
  • dom/dom_position.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/markup.cpp:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQLogging.h: Removed.
  • kwq/KWQLogging.m: Removed.
  • kwq/KWQRegExp.cpp:
  • kwq/KWQTextStream.cpp:
  • platform/Logging.cpp: Added.
  • platform/Logging.h: Added.
  • platform/QString.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::vScrollBarMode): (WebCore::theme):
16:05 Changeset [13026] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix a bunch more link errors in the win32 build, mostly by adding stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
  • WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
  • platform/PlugInInfoStore.h:
  • platform/mac/PlugInInfoStoreMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs. (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::Widget::hide): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (QFont::QFont): (QFont::~QFont): (QFont::italic): (QFont::weight): (QFontMetrics::QFontMetrics): (QFontMetrics::~QFontMetrics): (QFontMetrics::xHeight): (Widget::setActiveWindow): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode):
15:47 Changeset [13025] by thatcher

New tag.

15:43 Changeset [13024] by thatcher

Versioning

15:23 Changeset [13023] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Add missing include to fix build.

  • platform/win/TemporaryLinkStubs.cpp:
15:08 Changeset [13022] by eseidel

2006-02-25 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.


Test new PlugInInfoStore class (used to be KConfig).


  • plugins/plugin-javascript-access-expected.txt: Added.
  • plugins/plugin-javascript-access.html: Added.
15:08 Changeset [13021] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Test new KConfig -> PlugInInfoStore change.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

  • DumpRenderTree/DumpRenderTree.m: (main): load test netscape plugin
  • Scripts/run-webkit-tests: style update
15:07 Changeset [13020] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Move KConfig to platform/PlugInInfoStore and add test.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

Test: plugins/plugin-javascript-access.html

  • ForwardingHeaders/kconfig.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: Removed.
  • kwq/KWQKConfigBase.mm: Removed.
  • platform/PlugInInfoStore.h: Added.
  • platform/mac/PlugInInfoStoreMac.mm: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::refreshPlugins):
14:43 Changeset [13019] by darin

Reviewed by Eric.

  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
14:42 Changeset [13018] by thatcher

Build fix for i386. Workaround for 4213314

13:55 Changeset [13017] by darin
  • fixed Mac Debug build, there was an unused parameter
  • kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread): Remove parameter name.
  • kjs/debugger.h: Fixed comment.
13:40 Changeset [13016] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

  • kxmlcore/Vector.h: (KXMLCore::deleteAllValues): fix unused variable warning
13:36 Changeset [13015] by mjs

Reviewed by Darin.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (jsAllocate): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bindings/c/c_class.h: (KJS::Bindings::CClass::constructorAt):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_objc.mm: (-[NSObject KJS::Bindings::]):
  • bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
  • bindings/objc/objc_class.h: (KJS::Bindings::ObjcClass::constructorAt):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fallbackObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::getOwnPropertySlot): (ObjcFallbackObjectImp::put): (ObjcFallbackObjectImp::canPut): (ObjcFallbackObjectImp::deleteProperty): (ObjcFallbackObjectImp::toBoolean):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createLanguageInstanceForValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField):
  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter): (RuntimeArray::put): (RuntimeArray::deleteProperty):
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::execute):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):
  • bindings/runtime_root.cpp: (performJavaScriptAccess):
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (ArrayInstance::getOwnPropertySlot): (ArrayPrototype::ArrayPrototype): (ArrayPrototype::getOwnPropertySlot):
  • kjs/bool_object.cpp: (BooleanObjectImp::BooleanObjectImp):
  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::DateObjectFuncImp): (KJS::DateObjectFuncImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorObjectImp::ErrorObjectImp): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::put):
  • kjs/function_object.cpp: (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
  • kjs/lexer.cpp: (Lexer::makeIdentifier): (Lexer::makeUString):
  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter):
  • kjs/nodes.cpp: (StatementNode::processFuncDecl): (PropertyNode::evaluate): (PropertyNameNode::evaluate):
  • kjs/number_object.cpp: (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getOwnPropertySlot):
  • kjs/object.cpp: (KJS::JSObject::defineGetter): (KJS::JSObject::defineSetter): (KJS::JSObject::hasInstance): (KJS::JSObject::propertyIsEnumerable):
  • kjs/object_object.cpp: (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): (KJS::PropertySlot::functionGetter):
  • kjs/reference.cpp: (KJS::Reference::getPropertyName):
  • kjs/reference_list.cpp: (ReferenceListIterator::operator++):
  • kjs/regexp_object.cpp: (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter): (StringPrototype::StringPrototype):
  • kxmlcore/Assertions.mm:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_PageHeap::CheckList):
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::checkValidity): (KXMLCore::IdentityHashTranslator::translate):
  • pcre/pcre_get.c: (pcre_get_stringnumber):
13:31 Changeset [13014] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Reworked KConfig and plugin architecture to be much more sane.
This is part one. Once this lands, I'll move it under platform with a better name.

Darin had several great suggested further improvements as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
I'll make some of those when I move this to platform.

No layout test possible (no way to control which plugins DRT sees).

  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: (WebCore::PluginInfoStore::PluginInfoStore):
  • kwq/KWQKConfigBase.mm: (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PluginInfoStore::pluginCount): (WebCore::refreshPlugins):
13:01 Changeset [13013] by eseidel

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Build fix: cast to unsigned from size_t.

  • platform/StreamingTextDecoder.cpp:
12:17 Changeset [13012] by mjs

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
12:11 Changeset [13011] by mjs
  • use proper header for std::min.
  • platform/StreamingTextDecoder.cpp:
11:30 Changeset [13010] by mjs

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convertUTF16):
  • platform/TextEncoding.cpp:
09:58 Changeset [13009] by darin
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.
09:23 Changeset [13008] by darin
  • css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling back to that; apologies for the churn.
09:06 Changeset [13007] by darin
  • css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.
09:00 Changeset [13006] by darin
  • css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.
08:55 Changeset [13005] by darin

Reviewed by Maciej.

  • css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than manipulating the characters directly inside a StringImpl buffer.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse it rather than going out of our way to hack StringImpl to not copy the data. It would be better not to copy, but this is one-time work.
  • dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
  • dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): (WebCore::QCharBufferTranslator::equal): (WebCore::AtomicString::add):
  • platform/StringImpl.h: (WebCore::StringImpl::unicode): Added. (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::getCharacterBreakIterator): (WebCore::RenderText::RenderText): (WebCore::RenderText::atLineWrap): (WebCore::RenderText::allAscii): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::width): (WebCore::RenderText::selectionRect): (WebCore::RenderText::caretMaxOffset):
  • rendering/RenderTextFragment.cpp: (khtml::RenderTextFragment::RenderTextFragment): (khtml::RenderTextFragment::originalString): Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Use const. (WebCore::endOfParagraph): Ditto.
02:49 Changeset [13004] by mjs
  • fix problem with a prototype that broke win32 build
  • platform/StreamingTextDecoder.h: (WebCore::StreamingTextDecoder::convert):
02:02 Changeset [13003] by mjs
  • fix debug build (broken by my last commit)
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::StreamingTextDecoder::convertUsingICU):
01:17 Changeset [13002] by mjs

Reviewed by Darin.


I renamed QTextCodec to TextEncoding and QTextDecoder to
StreamingTextDecoder. I also made a bunch of other changes to make
the API more sensible.


  • ForwardingHeaders/qtextcodec.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge textEncoding]): (+[WebCoreFrameBridge stringWithData:textEncoding:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::completeURL):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/html/FormDataList.cpp: (DOM::FormDataList::FormDataList): (DOM::FormDataList::appendString):
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::formData):
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::encodingName): (Decoder::decode):
  • khtml/misc/decoder.h: (khtml::Decoder::): (khtml::Decoder::visuallyOrdered): (khtml::Decoder::encoding):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQCharsets.cpp: Removed.
  • kwq/KWQCharsets.h: Removed.
  • kwq/KWQTextCodec.cpp: Removed.
  • kwq/KWQTextCodec.h: Removed.
  • kwq/WebCoreTextDecoder.h:
  • kwq/WebCoreTextDecoder.mm:
  • kwq/can-convert.mm: Removed.
  • kwq/character-sets.txt: Removed.
  • kwq/mac-encodings.txt: Removed.
  • kwq/make-charset-table.pl: Removed.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setCharset): (WebCore::CachedScript::data):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setCharset):
  • page/Frame.cpp: (WebCore::Frame::write): (WebCore::Frame::gotoAnchor): (WebCore::Frame::encoding): (WebCore::Frame::backslashAsCurrencySymbol):
  • platform/CharsetNames.cpp: Added. (KXMLCore::): (WebCore::EncodingHash::equal): (WebCore::EncodingHash::hash): (WebCore::buildDictionaries): (WebCore::textEncodingIDFromCharsetName): (WebCore::charsetNameFromTextEncodingID):
  • platform/CharsetNames.h: Added.
  • platform/KURL.cpp: (KURL::KURL): (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h:
  • platform/QString.cpp: (QString::fromUtf8):
  • platform/StreamingTextDecoder.cpp: Added. (WebCore::StreamingTextDecoder::StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertLatin1): (WebCore::StreamingTextDecoder::~StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertUTF16): (WebCore::effectiveEncoding): (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::unwanted): (WebCore::StreamingTextDecoder::appendOmittingUnwanted): (WebCore::StreamingTextDecoder::convertUsingICU): (WebCore::StreamingTextDecoder::convert): (WebCore::StreamingTextDecoder::toUnicode):
  • platform/StreamingTextDecoder.h: Added. (WebCore::StreamingTextDecoder::convert):
  • platform/TextEncoding.cpp: Added. (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::name): (WebCore::effectiveEncoding): (WebCore::TextEncoding::backslashAsCurrencySymbol): (WebCore::TextEncoding::toUnicode):
  • platform/TextEncoding.h: Added. (WebCore::): (WebCore::TextEncoding::): (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::isValid): (WebCore::TextEncoding::usesVisualOrdering): (WebCore::TextEncoding::isJapanese): (WebCore::TextEncoding::encodingID): (WebCore::TextEncoding::flags): (WebCore::operator==): (WebCore::operator!=):
  • platform/character-sets.txt: Added.
  • platform/mac/ExtraCFEncodings.h: Added.
  • platform/mac/QStringMac.mm:
  • platform/mac/TextEncodingMac.cpp: Added. (WebCore::effectiveEncoding): (WebCore::TextEncoding::fromUnicode):
  • platform/mac/can-convert.mm: Added.
  • platform/mac/mac-encodings.txt: Added.
  • platform/make-charset-table.pl: Added.
  • platform/win/win-encodings.txt: Added.
  • rendering/render_object.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::slotData):
00:24 Changeset [13001] by darin
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.
00:13 Changeset [13000] by darin

Reviewed by Maciej.

  • merged Job and TransferJob into TransferJob and moved it to WebCore namespace
  • changed TransferJob to use a TransferJobClient object instead of signals
  • ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
  • kwq/KWQKJob.h: Removed.
  • kwq/TransferJobClient.h: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".
  • kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor. Remove the signals from TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer. (WebCore::TransferJob::TransferJob): Store a client pointer, remove the deliverAllData boolean. (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse function; uses client instead of a signal. (WebCore::TransferJob::client): Added.
  • kwq/KWQLoader.h: Switched things to mention the WebCore namespace. Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQLoader.mm: Ditto.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Removed isKHTMLLoader.
  • kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on the job instead of emitReceivedResponse. (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the client directly instead of emitRedirection on the job. (-[KWQResourceLoader addData:]): Call receivedData function on the client directly instead of emitData on the job. (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the client directly instead of emitResult on the job. Also fixed a potential memory leak where the handle was not released if the job was 0.
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.cpp:
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.cpp: Removed the job-related signals and slots.
  • loader/CachedObject.h: Removed unneeded declaration of TransferJob.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get". Also don't connect signals. (WebCore::Loader::receivedAllData): New name for slotFinished. (WebCore::Loader::receivedResponse): New name for slotReceivedResponse. (WebCore::Loader::receivedData): New name for slotData. (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob. (WebCore::Loader::jobForRequest): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly cleaned up the logic. (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
  • page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • xml/xmlhttprequest.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject. (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions by their new names (names changed to use with TransferJobClient). (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished. (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection. (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.
Note: See TracTimeline for information about the timeline view.