Context Navigation

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::drawText):
platform/win/FontWin.cpp: Added. (WebCore::Font::drawText):
platform/win/TemporaryLinkStubs.cpp: (QComboBox::focusPolicy): (ScrollView::scrollXOffset): (Font::isFixedPitch): (Path::boundingRect):

12:48 PM Changeset in webkit [13193] by adele

3 edits in trunk/LayoutTests

Updating tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7319
Can't see caret at the end of a contenteditable div with overflow:hidden

fast/clip/outline-overflowClip-expected.txt:
fast/overflow/overflow-focus-ring-expected.txt:

11:54 AM Changeset in webkit [13192] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7319 Can't see caret at the end of a contenteditable div with overflow:hidden

No tests added since I don't think the blinking caret will show up in our tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::rightmostPosition): When calculating the rightmostPosition for editable blocks, we need to account for the caret that can be drawn 1 px past the last child inline box.

9:36 AM Changeset in webkit [13191] by darin

7 edits
14 adds
5 deletes in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

fast/js/exception-linenums-in-html-1-expected.txt: Added.
fast/js/exception-linenums-in-html-1.html: Added.

Tests line numbers from HTML source files instead of JavaScript source files
which is tested by fast/js/exception-linenums.html. This test does not test
changes made for Bug 3905, but was added for better coverage.

fast/js/exception-linenums-in-html-2-expected.txt: Added.
fast/js/exception-linenums-in-html-2.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <title> tag, which causes the code path for Bug 3905 to be tested.

fast/js/missing-title-end-tag-js-expected.txt: Added.
fast/js/missing-title-end-tag-js.html: Added.

While developing a fix for Bug 3905, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

fast/tokenizer/missing-title-end-tag-1-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-1-expected.png: Added.
fast/tokenizer/missing-title-end-tag-1-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-1.html: Added.
fast/tokenizer/missing-title-end-tag-2-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-2-expected.png: Added.
fast/tokenizer/missing-title-end-tag-2-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-2.html: Added.

The first test case contains an unclosed <title> tag in <head>, while the
second test case contains an unclosed <title> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/missing-title-end-tag-js.html
Test: fast/tokenizer/missing-title-end-tag-1.html
Test: fast/tokenizer/missing-title-end-tag-2.html

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </title> tag and handle this condition if identified.
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </title> tag, reset the state of the tokenizer and retokenize with no special handling for <title>. The parser will handle the missing </title> tag in HTMLParser::handleError().
platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): Added copy constructor. (WebCore::SegmentedString::operator=): Added assignment operator. Previously the compiler was generating a default method for the assignment operator, but it did not handle m_currentChar properly.
platform/SegmentedString.h: Added prototypes for copy constructor and assignment operator.

9:33 AM Changeset in webkit [13190] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming ideas.

1:28 AM Changeset in webkit [13189] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Fix win32 link stubs.

platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage):

1:21 AM Changeset in webkit [13188] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Still more tweaks to renaming.

1:03 AM Changeset in webkit [13187] by darin

43 edits
2 copies
7 moves
6 deletes in trunk/WebCore

Reviewed by Adele, except for the first change listed.

fix recently-introduced bug that GuardMalloc found while I was debugging my other change

rendering/render_frames.cpp: (WebCore::RenderPart::~RenderPart): Set m_widget to 0 before calling deref so we don't end up trying to do unwanted work.

removed 10 more files from KWQ

ForwardingHeaders/klocale.h: Removed.

khtml/misc/helper.cpp: Removed.
khtml/misc/helper.h: Removed.

kwq/KWQCollection.h: Removed.
kwq/KWQKCookieJar.h: Removed.
kwq/KWQKCookieJar.mm: Removed.
kwq/KWQKLocale.h: Removed.
kwq/KWQKLocale.mm: Removed.
kwq/KWQKURL.h: Removed.
kwq/KWQKURL.mm: Removed.
kwq/KWQTextUtilities.h: Removed.
kwq/KWQTextUtilities.mm: Removed.
kwq/KWQView.h: Removed.

platform/CookieJar.h: Added.
platform/Language.h: Added.
platform/LocalizedStrings.h: Added.
platform/TextBoundaries.h: Added.
platform/mac/CookieJar.mm: Added.
platform/mac/Language.mm: Added.
platform/mac/LocalizedStringsMac.mm: Added.
platform/mac/TextBoundaries.mm: Added.
platform/mac/WebCoreWidgetHolder.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removed and added files.

bridge/mac/WebCoreFrameBridge.mm: Updated includes. (-[WebCoreFrameBridge elementForView:]): Changed KWQWidgetHolder to WebCoreWidgetHolder.

editing/visible_units.cpp: (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): Call TextBoundaries.h functions instead of helper.h ones.

khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
ksvg2/svg/SVGTestsImpl.cpp: (WebCore::SVGTestsImpl::isValid): Changed to call defaultLanguage; cleaned up formatting.

khtml/html/HTMLFormElementImpl.cpp: Removed stray comment.

khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::cookie): (WebCore::HTMLDocumentImpl::setCookie): Call CookieJar.h functions.

css/css_valueimpl.cpp:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/DocumentImpl.cpp:
dom/dom_position.cpp:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLInputElementImpl.cpp:
khtml/html/html_headimpl.cpp:
khtml/html/htmlparser.cpp:
khtml/misc/decoder.cpp:
ksvg2/svg/SVGDocumentImpl.cpp:
kwq/KWQComboBox.mm:
kwq/KWQKSSLKeyGen.mm:
kwq/KWQListBox.mm:
kwq/KWQListImpl.cpp:
kwq/KWQListImpl.h:
kwq/KWQScrollBar.mm:
kwq/KWQSlider.mm:
kwq/KWQTextField.mm:
kwq/KWQValueList.h:
loader/DocLoader.cpp:
page/Frame.cpp:
page/FrameView.cpp:
platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
rendering/render_applet.cpp:
rendering/render_form.cpp:
rendering/render_image.cpp:
rendering/render_list.cpp: Updated includes and protocol names.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::write): Remove QT_VERSION code.
platform/QString.h: Remove QT_VERSION.

kwq/KWQPtrList.h: Change to no longer use QPtrCollection.

kwq/KWQRenderTreeDebug.h:
kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove unused debuggingRenderTree boolean.

12:21 AM Changeset in webkit [13186] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

platform/mac/GraphicsContextMac.mm: Add Widget.h to fix no-svg build.

Mar 6, 2006:

11:35 PM Changeset in webkit [13185] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming tweaks.

10:54 PM Changeset in webkit [13184] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Add some more planned renaming.

6:05 PM Changeset in webkit [13183] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4457574> assertion failure watching trailers at netflix.com -[WebNetscapePluginRepresentation
receivedData:withDataSource:] + 684

Plugins/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): Moved the ASSERT(instance) to the block that actually requires an assertion -- the plugin view should never have a NULL instance by the time we start the NPStream (by calling -startStreamWithResponse:). Some stream teardown logic changed with my fix to 4153419: when a WebBaseNetscapePluginStream is destroyed, it now clears its NPP instance backpointer. The WebBaseNetscapePluginStream may be destroyed from within -startStreamWithResponse: if NPP_NewStream() returns an error. We can handle this gracefully by changing the assertion before -receivedData: to a simple NULL check. This is unrelated to the Radar, but prior to this fix, we would attempt an NPP_Write() with the initial stream data even if NPP_NewStream() returned an error. Seems like that alone could cause issues, though I'm guessing that plugins handle this in practice.

4:38 PM Changeset in webkit [13182] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Make spinneret run again, fix webview to support dynamic resize.

platform/win/TemporaryLinkStubs.cpp: (Widget::setDrawingAlpha):
platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setClient): (WebCore::Widget::client): (WebCore::Widget::frameGeometry):

3:41 PM Changeset in webkit [13181] by bdakin

1 edit
4 adds in trunk/LayoutTests

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566

3:36 PM Changeset in webkit [13180] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix win32 build.

platform/win/TemporaryLinkStubs.cpp: (QScrollBar::QScrollBar): (QTextEdit::setAlignment): (Widget::client): (Widget::setClient): (QLineEdit::setAlignment):

3:32 PM Changeset in webkit [13179] by bdakin

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566 (also
<rdar://problem/4467128> ). Must call update() on a Font before
attempting to use it because the FontRenderer is not created until
update() is called.

3:17 PM Changeset in webkit [13178] by eseidel

2 edits in trunk/WebKitTools

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint): force layout before painting

3:10 PM Changeset in webkit [13177] by darin

3 edits in trunk/WebKitSite

Reviewed by Darin.

Change "Mail.app" to "Mail".

index.html:
projects/editing/index.html:

3:09 PM Changeset in webkit [13176] by darin

58 edits
1 add
11 deletes in trunk/WebCore

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7564 remove QObject, QGuardedPtr, slots, and signals

I had written a detailed change log entry, but I lost it!
I'm too annoyed to write one all over again.

ForwardingHeaders/qguardedptr.h: Removed.
ForwardingHeaders/qobject.h: Removed.

kwq/KWQGuardedPtr.cpp: Removed.
kwq/KWQGuardedPtr.h: Removed.
kwq/KWQNamespace.h: Removed.
kwq/KWQObject.cpp: Removed.
kwq/KWQObject.h: Removed.
kwq/KWQSignal.cpp: Removed.
kwq/KWQSignal.h: Removed.
kwq/KWQSlot.cpp: Removed.
kwq/KWQSlot.h: Removed.

platform/WidgetClient.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

bindings/js/JSDOMCore.cpp: Touched.
bindings/js/JSDOMEvents.cpp: Ditto.

bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementForView:]):
dom/CDATASectionImpl.cpp: (WebCore::CDATASectionImpl::cloneNode):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl):
dom/DocumentImpl.h:
kcanvas/device/KRenderingDevice.h:
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
khtml/ecma/kjs_window.cpp: (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::createTokenizer):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::finished):
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::processToken): (WebCore::parseHTMLDocumentFragment):
khtml/html/htmltokenizer.h:
kwq/KWQComboBox.h:
kwq/KWQComboBox.mm: (-[KWQPopUpButton setPopulatingMenu:QComboBox:::]): (QComboBox::itemSelected): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
kwq/KWQFileButton.h: (KWQFileButton::filename):
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::filenameChanged): (-[KWQFileButtonAdapter filenameChanged:]): (-[KWQFileButtonAdapter focusChanged:]): (-[KWQFileButtonAdapter clicked]):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setAlignment): (KWQNSTextAlignment):
kwq/KWQListBox.h: (QListBox::changingSelection):
kwq/KWQListBox.mm: (QListBox::QListBox): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView tableViewSelectionDidChange:]):
kwq/KWQScrollBar.h: (WebCore::): (QScrollBar::orientation):
kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (QScrollBar::QScrollBar): (QScrollBar::valueChanged): (QScrollBar::scroll):
kwq/KWQSlider.h:
kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider slide:]): (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (QSlider::QSlider): (QSlider::sliderValueChanged): (QSlider::dimensions):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textViewDidChangeSelection:]): (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView mouseDown:]): (-[KWQTextAreaTextView dispatchHTMLEvent:]):
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setAlignment):
kwq/KWQTextField.mm: (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController textViewDidChangeSelection:]):
loader/CachedObject.h:
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setOpener): (WebCore::Frame::nodeForWidget): (WebCore::Frame::disconnectOwnerRenderer):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
page/FrameView.cpp: (WebCore::FrameView::~FrameView):
platform/Brush.h:
platform/Pen.h:
platform/Widget.cpp: (WebCore::Widget::isFrameView):
platform/Widget.h: (WebCore::):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawText):
platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::focusPolicy): (WebCore::Widget::sendConsumedMouseUp): (WebCore::Widget::setClient): (WebCore::Widget::client):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::operator delete):
rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/render_form.cpp: (WebCore::RenderFormElement::clicked): (WebCore::RenderFormElement::textAlignment): (WebCore::RenderLineEdit::RenderLineEdit): (WebCore::RenderLineEdit::selectionChanged): (WebCore::RenderLineEdit::returnPressed): (WebCore::RenderLineEdit::performSearch): (WebCore::RenderLineEdit::valueChanged): (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::returnPressed): (WebCore::RenderFileButton::valueChanged): (WebCore::RenderLegend::RenderLegend): (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::createListBox): (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::valueChanged): (WebCore::RenderTextArea::selectionChanged): (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::valueChanged):
rendering/render_form.h: (WebCore::RenderFormElement::element): (WebCore::RenderLineEdit::element): (WebCore::RenderFileButton::element): (WebCore::RenderFileButton::isEditable): (WebCore::RenderSelect::element): (WebCore::RenderTextArea::element): (WebCore::RenderSlider::element):
rendering/render_frames.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart): (WebCore::RenderPart::setFrame): (WebCore::RenderPart::setWidget): (WebCore::RenderPart::deleteWidget): (WebCore::RenderFrame::RenderFrame): (WebCore::RenderPartObject::RenderPartObject): (WebCore::RenderPartObject::layout):
rendering/render_frames.h:
rendering/render_layer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::hitTest):
rendering/render_layer.h: (WebCore::RenderLayer::parent): (WebCore::RenderLayer::previousSibling): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::firstChild): (WebCore::RenderLayer::lastChild):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::~RenderWidget): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::layout): (WebCore::RenderWidget::sendConsumedMouseUp): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut): (WebCore::RenderWidget::scrollToVisible): (WebCore::RenderWidget::isVisible): (WebCore::RenderWidget::element): (WebCore::RenderWidget::deleteWidget):
rendering/render_replaced.h:
xml/xmlhttprequest.cpp: (WebCore::requestsByDocument): (WebCore::addToRequestsByDocument): (WebCore::removeFromRequestsByDocument): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getSpecificHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
xml/xmlhttprequest.h:

3:05 PM Changeset in webkit [13175] by ggaren

2 edits in trunk/WebKitSite

Oops, accidentally deleted the archives links.

blog/wp-content/themes/webkit/sidebar.php: Bring them back.

3:04 PM Changeset in webkit [13174] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Reorganize link stubs (alphabetically).
Stub out Path methods to make cnn.com work.

platform/win/TemporaryLinkStubs.cpp: (FrameView::viewportToGlobal): (FrameView::updateBorder): (FrameView::isFrameView): (FrameView::topLevelWidget): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (ScrollView::scrollXOffset): (QComboBox::focusPolicy): (QTextEdit::QTextEdit): (QTextEdit::~QTextEdit): (QTextEdit::textWithHardLineBreaks): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setColors): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QTextEdit::checksDescendantsForFocus): (QTextEdit::selectionStart): (QTextEdit::hasSelectedText): (QTextEdit::setReadOnly): (QTextEdit::setDisabled): (QTextEdit::setLineHeight): (QTextEdit::setSelectionStart): (QTextEdit::text): (QTextEdit::setWordWrap): (QTextEdit::setAlignment): (QTextEdit::getCursorPosition): (QTextEdit::setSelectionRange): (Widget::enableFlushDrawing): (Widget::isEnabled): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::setIsSelected): (Widget::unlockDrawingFocus): (KJavaAppletWidget::KJavaAppletWidget): (ScrollView::scrollPointRecursively): (ScrollView::scrollBy): (QLineEdit::selectAll): (QLineEdit::addSearchResult): (QLineEdit::selectionStart): (QLineEdit::hasSelectedText): (QLineEdit::selectedText): (QLineEdit::setAutoSaveName): (QLineEdit::checksDescendantsForFocus): (QLineEdit::setMaxResults): (GraphicsContext::GraphicsContext): (GraphicsContext::addFocusRingRect): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::drawFocusRing): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::drawHighlightForText): (GraphicsContext::misspellingLineThickness): (GraphicsContext::addRoundedRectClip): (QSlider::QSlider): (QSlider::sizeHint): (QSlider::setValue): (QSlider::setMaxValue): (QSlider::~QSlider): (QSlider::setFont): (QListBox::setFont): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setEnabled): (QListBox::clear): (QListBox::checksDescendantsForFocus): (KWQFileButton::KWQFileButton): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFilename): (KWQFileButton::baselinePosition): (KWQFileButton::setFrameGeometry): (QSlider::focusPolicy): (QListBox::focusPolicy): (Cursor::Cursor): (MouseEvent::MouseEvent): (KWQKCookieJar::cookieEnabled): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::createPlugin): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::inWindow): (Path::~Path): (Path::Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=):

2:57 PM Changeset in webkit [13173] by ggaren

3 edits in trunk/WebKitSite

Reviewed by Beth.

Some site cleanup.

blog/wp-content/themes/webkit/sidebar.php: sync with the sidebar for the rest of the site.
quality/lifecycle.html: add Joost's homepage to his contact info.

2:39 PM Changeset in webkit [13172] by ggaren

2 edits in trunk/WebKitSite

Doing penance after being set straight by Joost.

projects/compat/hitlist.html: Remove slur against QA. My humblest apologies.

2:33 PM Changeset in webkit [13171] by ggaren

3 edits
1 add in trunk/WebKitSite

Reviewed by Maciej, Darin.

Added Safari Compatibility Hit List.

nav.inc: Link to the hit list.
projects/compat/hitlist.html: Added.
projects/compat/index.html: Link to the hit list.

11:59 AM Changeset in webkit [13170] by ap

2 edits
3 copies in trunk/JavaScriptCore

Patch by David Carson, reviewed by Darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7582 c_utility.cpp contains CFString OS X platform-dependent code; should use ICU

Tested with test case from:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

bindings/c_utility.cpp (convertUTF8ToUTF16): Changed to using Unicode converter from ICU, and manual Latin-1 conversion.
icu/unicode/ucnv.h: Copied from WebCore.
icu/unicode/ucnv_err.h: Ditto.
icu/unicode/uenum.h: Ditto.

11:43 AM Changeset in webkit [13169] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

fast/lists/drag-into-marker-expected.checksum: Added.
fast/lists/drag-into-marker-expected.png: Added.
fast/lists/drag-into-marker-expected.txt: Added.
fast/lists/drag-into-marker.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

Call RenderObject::setInnerNode(), which sets both the
innerNode and the innerNonSharedNode.

rendering/render_list.cpp: (WebCore::RenderListItem::nodeAtPoint):
rendering/render_list.h:

WebKitTools:

Reviewed by darin

Sent the windowNumber when sending events.
Added leapForward so that we don't have to spend time waiting
in layout tests that do mouse operations that require delays.

DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController currentEventTime]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):

9:11 AM Changeset in webkit [13168] by darin

2 edits in trunk/WebCore

WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted files from the kwq directory.

8:50 AM Changeset in webkit [13167] by darin

147 edits
2 adds
2 deletes in trunk/WebCore

Reviewed by Maciej.

moved all the remnants of the public C++ DOM API out of khtml/dom
changed from "int" to "ExceptionCode" for DOM exceptions
removed unused CSS_HTML_RELATIVE
changed offsetInCharacters to be a member function of NodeImpl
changed DOM functions that take a NodeType to use NodeType instead of unsigned short for clarity (will still be unsigned short in bindings)
changed exception constants so they can be used directly in the implementation code (added in the offsets for different types of exceptions)
replaced the eventListenerType function with an isHTMLEventListener function
got rid of EventListenerEvent, which is a synonym for EventImpl*
eliminated handleEventImpl, whish is now the same as handleEvent

did other preparation for the "remove Impl suffix" renaming (tested by using a script that does the renaming)

khtml/dom/css_rule.h: Removed.
khtml/dom/css_stylesheet.h: Removed.
khtml/dom/css_value.h: Removed.
khtml/dom/dom2_events.cpp: Removed.
khtml/dom/dom2_events.h: Removed.
khtml/dom/dom2_range.h: Removed.
khtml/dom/dom2_traversal.cpp: Removed.
khtml/dom/dom2_traversal.h: Removed.
khtml/dom/dom_exception.h: Removed.
khtml/dom/dom_node.h: Removed.

dom/EventListener.h: Added.
dom/ExceptionCode.h: Added.

WebCore+SVG/kdom.h: Removed NodeType and ExceptionCodes
WebCore+SVG/kdomevents.h: Removed.

WebCore.xcodeproj/project.pbxproj: Updated for file changes.
WebCore.xcodeproj/project.pbxproj: Updated for file changes.

bindings/scripts/CodeGeneratorJS.pm: Removed unneeded DOM:: prefix. Updated file names and exception prefix for changes in DOM exceptions.

bindings/js/JSDOMCore.cpp: Touched to cause auto-generated code to be recompiled. We need to get this fixed!
bindings/js/JSDOMEvents.cpp: Ditto.

dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
dom/WheelEvent.idl: Touched all IDL files so that changes in CodeGeneratorJS.pm would take effect. Added license headers.

bindings/objc/DOM.mm: Fixed garbled license agreement. Updated includes. Changed from a single "using namespace WebCore" to individual using statements because of the imminent conflict between DOMImplementation in Objective C and WebCore::DOMImplementation (currently has an Impl suffix). Added a typedef for WebCore::DOMImplementationImpl. Changed to use ExceptionCode instead of int.

bindings/objc/DOMCSS.h: Removed DOMCSSException and the special CSS exception codes. This is a feature of DOM Level 1 only. In DOM Level 2 these were eliminated and use basic DOM exception codes instead. We might have to do something for binary compatibility eventually, but perhaps not.

bindings/objc/DOMCSS.mm:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMEventsInternal.h:
bindings/objc/DOMHTML.mm:
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMViews.mm:
bindings/objc/DOMViewsInternal.h: Fixed garbled license agreements. Changed to use ExceptionCode instead of int and name the variable "ec".

bindings/objc/DOMInternal.h: Changed addDOMWrapperImpl to take NSObject* instead of id. This helps with overload resolution when addDOMWrapperImpl is renamed to be addDOMWrapper. Changed ALLOW_DOM_CAST to always use "class" in from of the type name of the WebCore class. This helps work around what seems like a bug in namespace support in Objective-C mode, although the bug only happens after the "remove Impl" renaming.
bindings/objc/DOMInternal.mm: (getDOMWrapperImpl): Changed to use HashMap. (addDOMWrapperImpl): Ditto. (removeDOMWrapper): Ditto. (raiseDOMException): Update to use new names for exception number ranges.

bridge/mac/WebCoreFrameBridge.mm:
khtml/ecma/xmlserializer.cpp:
kwq/KWQAccObject.mm: Removed unneeded includes.

css/css_ruleimpl.h: Moved "rule type" into this header.

dom/CommentImpl.h:
dom/CommentImpl.cpp: (WebCore::CommentImpl::offsetInCharacters): Added. Returns true.

khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): Changed this around so we don't have a local variable named docImpl.

khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Updated for new form of exception constants.

khtml/ecma/kjs_events.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Changed to no longer use EventListenerEvent. (KJS::JSAbstractEventListener::isHTMLEventListener): Added.

rendering/RenderTextField.h: Updated includes. Tweaked the code formatting of InputMutationListener. (Might be unnecessary since this class might be deleted soon.)

bridge/mac/MacFrame.mm:
css/css_computedstyle.cpp:
css/css_computedstyle.h:
css/css_ruleimpl.cpp:
css/css_stylesheetimpl.cpp:
css/css_stylesheetimpl.h:
css/css_valueimpl.cpp:
css/css_valueimpl.cpp:
css/css_valueimpl.h:
css/css_valueimpl.h:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/CDATASectionImpl.cpp:
dom/CDATASectionImpl.h:
dom/CharacterDataImpl.cpp:
dom/CharacterDataImpl.h:
dom/ContainerNodeImpl.cpp:
dom/DOMImplementationImpl.cpp:
dom/DocumentFragmentImpl.cpp:
dom/DocumentFragmentImpl.h:
dom/DocumentImpl.cpp:
dom/DocumentImpl.h:
dom/DocumentTypeImpl.cpp:
dom/DocumentTypeImpl.h:
dom/NamedNodeMapImpl.h:
dom/NodeImpl.cpp:
dom/NodeImpl.h:
dom/NodeListImpl.cpp:
dom/TextImpl.cpp:
dom/TextImpl.h:
dom/dom2_eventsimpl.cpp:
dom/dom2_eventsimpl.h:
dom/dom2_rangeimpl.cpp:
dom/dom2_rangeimpl.h:
dom/dom2_traversalimpl.cpp:
dom/dom2_traversalimpl.h:
dom/dom_elementimpl.cpp:
dom/dom_elementimpl.h:
dom/dom_position.cpp:
dom/dom_xmlimpl.cpp:
dom/dom_xmlimpl.h:
dom/xml_tokenizer.cpp:
editing/AppendNodeCommand.cpp:
editing/ApplyStyleCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/InsertIntoTextNodeCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertNodeBeforeCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/JoinTextNodesCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/RemoveNodeAttributeCommand.cpp:
editing/RemoveNodeCommand.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/Selection.cpp:
editing/SelectionController.cpp:
editing/SelectionController.h:
editing/SetNodeAttributeCommand.cpp:
editing/SplitElementCommand.cpp:
editing/SplitTextNodeCommand.cpp:
editing/VisiblePosition.cpp:
editing/WrapContentsInDummySpanCommand.cpp:
editing/htmlediting.cpp:
editing/markup.cpp:
editing/visible_text.cpp:
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_css.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_html.cpp:
khtml/ecma/kjs_range.cpp:
khtml/ecma/kjs_traversal.cpp:
khtml/ecma/kjs_traversal.h:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.h:
khtml/html/HTMLOptionsCollectionImpl.cpp:
khtml/html/HTMLSelectElementImpl.cpp:
khtml/html/HTMLTextAreaElementImpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_documentimpl.h:
khtml/html/html_headimpl.cpp:
khtml/html/html_tableimpl.cpp:
khtml/html/html_tableimpl.h:
khtml/html/htmlparser.cpp:
khtml/xbl/xbl_tokenizer.cpp:
khtml/xsl/xsl_stylesheetimpl.cpp:
ksvg2/misc/SVGDocumentExtensions.cpp:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.h:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGLengthImpl.cpp:
ksvg2/svg/SVGLocatableImpl.cpp:
ksvg2/svg/SVGPolyElementImpl.cpp:
ksvg2/svg/SVGSVGElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.h:
ksvg2/svg/SVGUseElementImpl.cpp:
page/Frame.cpp:
page/FrameView.cpp:
rendering/render_object.cpp:
xml/xmlhttprequest.cpp: Changed to use ExceptionCode instead of int and name the variable "ec". Also updated use of exception codes and other constants to get them from their new locations.

2:12 AM Changeset in webkit [13166] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix more pages (apple.com, yahoo.com) by returning empty error image.
Empty a couple more stubs and clean up stub style a little.

platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
platform/win/TemporaryLinkStubs.cpp: (QListBox::isSelected): (QSlider::sizeHint): (QScrollBar::~QScrollBar): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::recordFormValue): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::passWheelEventToChildWidget): (FrameWin::createPlugin): (BrowserExtensionWin::createNewWindow): (Path::Path): (QLineEdit::~QLineEdit): (QLineEdit::setLiveSearch): (QComboBox::~QComboBox):

1:15 AM Changeset in webkit [13165] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Empty enough stubs to make apple.com load.

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (GraphicsContext::misspellingLineThickness): (QTextEdit::selectAll): (QTextEdit::setSelectionStart): (Widget::unlockDrawingFocus): (QLineEdit::setAutoSaveName): (ScrollView::scrollYOffset): (KWQFileButton::setFilename): (QListBox::setFont): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (QComboBox::QComboBox): (QComboBox::setFont): (QComboBox::baselinePosition): (QComboBox::setWritingDirection): (QComboBox::clear): (QComboBox::appendItem): (QComboBox::setCurrentItem): (QComboBox::sizeHint): (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QLineEdit::setLiveSearch):

12:39 AM Changeset in webkit [13164] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix external resource loading.
Make a bunch of stubs not abort (to fix slashdot).

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (KWQFileButton::click): (QComboBox::setFrameGeometry): (QTextEdit::setText): (QListBox::appendItem): (GraphicsContext::endTransparencyLayer): (QLineEdit::selectionStart): (QTextEdit::QTextEdit): (QListBox::isSelected): (QComboBox::focusPolicy): (QTextEdit::setCursorPosition): (QTextEdit::setAlignment): (QLineEdit::selectedText): (ScrollView::scrollPointRecursively): (QScrollBar::setSteps): (QComboBox::appendItem): (GraphicsContext::drawLineForMisspelling): (KWQFileButton::setFilename): (QListBox::setWritingDirection): (QListBox::focusPolicy): (MouseEvent::MouseEvent): (QSlider::setFont): (Widget::setEnabled): (Widget::paint): (ScrollView::addChild): (ScrollView::inWindow): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField): (QLineEdit::QLineEdit): (QLineEdit::setFont): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (QLineEdit::maxLength): (QLineEdit::setMaxLength): (QLineEdit::text): (QLineEdit::setText): (QLineEdit::cursorPosition): (QLineEdit::setCursorPosition): (QLineEdit::setEdited): (QLineEdit::setReadOnly): (QLineEdit::setPlaceholderString): (QLineEdit::setColors): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):

Mar 5, 2006:

11:38 PM Changeset in webkit [13163] by ggaren

2 edits in trunk/LayoutTests

Checked in new results for the test I just landed. Looks like I landed an old copy.

fast/dom/prototype-chain-expected.txt:

11:23 PM Changeset in webkit [13162] by darin

1 edit in trunk/WebCore/ChangeLog

Fix typo.

11:22 PM Changeset in webkit [13161] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fix failure seen running editing layout tests

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use selectNodeContents instead of rolling our own. It handles the "nothing at all" edget case properly.

11:18 PM Changeset in webkit [13160] by eseidel

3 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make updateContents invalidate entire window for now.
Fix indentation in fileLoadTimer.

platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

10:26 PM Changeset in webkit [13159] by eseidel

17 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Add missing files to vcproj (fix win32 build).
Also add svn:eol-style=native to new files.

WebCore.vcproj/WebCore/WebCore.vcproj:

10:06 PM Changeset in webkit [13158] by darin

2 edits in trunk/JavaScriptCore

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated.

9:55 PM Changeset in webkit [13157] by darin

2 edits in trunk/WebCore

fix build

rendering/render_style.h: (compareEqual): Made it inline, fixed variable name.

9:52 PM Changeset in webkit [13156] by adele

12 edits
6 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
Implement maxlength for new text fields

fast/forms/input-appearance-maxlength-expected.txt: Added.
fast/forms/input-appearance-maxlength.html: Added.

WebCore:

Reviewed by Darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6987 Implement maxlength for new text fields

Test added:

fast/forms/input-appearance-maxlength.html

WebCore.xcodeproj/project.pbxproj: Added BeforeTextInsertedEventImpl.h, BeforeTextInsertedEventImpl.cpp, HTMLTextFieldInnerElementImpl.h, and HTMLTextFieldInnerElementImpl.cpp

khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::init): initialize max length to 1024. (WebCore::HTMLInputElementImpl::defaultEventHandler): Added case to use the khtmlBeforeTextInsertedEvent to check for maxlength. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Makes sure that maxlength is between 0 and 1024.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): After doing a test insert of the fragment, Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text, and we can update the fragment.
editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text if necessary.
editing/EditCommand.cpp: (WebCore::EditCommand::apply): If we've just applied a command, send the khtmlTextInsertedEvent to the root editable element. (WebCore::EditCommand::unapply): ditto. (WebCore::EditCommand::reapply): ditto.

khtml/html/HTMLTextFieldInnerElementImpl.h: Added this class to store a pointer to the input element for the text field and to handle default events. (DOM::HTMLTextFieldInnerElementImpl::shadowParentNode): Added. (DOM::HTMLTextFieldInnerElementImpl::setShadowParentNode): Added.
khtml/html/HTMLTextFieldInnerElementImpl.cpp: Added. (WebCore::HTMLTextFieldInnerElementImpl::HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::~HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler): Sends khtmlBeforeTextInsertedEvents to the shadowParentNode, and handles khtmlTextInsertedEvents by telling the renderer that the subtree has changed.

rendering/RenderTextField.cpp: Removed InputMutationListener since subtreeHasChanged is now called from the editing code. (WebCore::RenderTextField::~RenderTextField): removed event listener code. (WebCore::RenderTextField::updateFromElement): ditto. And creates HTMLTextFieldInnerElementImpl. (WebCore::RenderTextField::subtreeHasChanged): calls new text() method. (WebCore::RenderTextField::text): created to get a String of all text in the RenderTextField.
rendering/RenderTextField.h: Removed InputMutationListener class.

dom/EventNames.h: Added khtmlTextInserted and khtmlBeforeTextInserted.
dom/BeforeTextInsertedEventImpl.cpp: Added. (WebCore::BeforeTextInsertedEventImpl::BeforeTextInsertedEventImpl):
dom/BeforeTextInsertedEventImpl.h: Added. (WebCore::BeforeTextInsertedEventImpl::isBeforeTextInsertedEvent): (WebCore::BeforeTextInsertedEventImpl::text):
dom/dom2_eventsimpl.cpp: (WebCore::EventImpl::isBeforeTextInsertedEvent): Added.
dom/dom2_eventsimpl.h: Added isBeforeTextInsertedEvent.

9:47 PM Changeset in webkit [13155] by mjs

2 edits in trunk/WebCore

fix build, give this a return type.

rendering/render_style.h: (compareEqual):

9:32 PM Changeset in webkit [13154] by ap

2 edits in trunk/JavaScriptCore

Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7601 REGRESSION (r13089): Reproducible crash dereferencing a deallocated element on google image search

kxmlcore/Platform.h: Corrected the define to enable USE(MULTIPLE_THREADS) on Mac OS X.

9:29 PM Changeset in webkit [13153] by darin

6 edits
2 copies in trunk/JavaScriptCore

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7616 get all references to KJS::Node out of internal.h

JavaScriptCore.xcodeproj/project.pbxproj: Updated for file changes.

kjs/Parser.cpp: Added.
kjs/Parser.h: Added.

kjs/internal.cpp: Removed the Parser class.
kjs/internal.h: Ditto. Also removed unnecessary declarations of classes not used in this header.

kjs/nodes.h: Added an include of "Parser.h".
kjs/function.h: Added a declaration of FunctionBodyNode.

8:56 PM Changeset in webkit [13152] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Add "Font.h" to (try to) fix the no-svg build.

platform/mac/GraphicsContextMac.mm:

8:55 PM Changeset in webkit [13151] by mjs

2 edits in trunk/WebCore

Rubber stamped by Darin.

fix win32 build by avoiding use of typeof

rendering/render_style.h: (compareEqual):

7:58 PM Changeset in webkit [13150] by ggaren

21 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

JSC support for the fix for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

kjs/lookup.h: (1) Added the KJS_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro. The class definiton macro needs to know about the prototype's prototype so that the class constructor properly sets it. (2) Removed the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro. The class implementation macro does not need to know about the prototype's prototype, since getOwnPropertySlot should only look in the current object's property map, and not its prototype's.

LayoutTests:

Reviewed by Maciej.

Layout test for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

fast/dom/prototype-chain-expected.txt: Added.
fast/dom/prototype-chain.html: Added.

WebCore:

Reviewed by Maciej.

Second cut at fixing <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

The approach here is for prototypes, in their constructor methods,
to set their own prototypes, preserving the prototype
chain in cases of multiple levels of inheritance. (Previously, our
code assumed that a prototype never had a prototype of its own,
and always used an empty object as a prototype's prototype).

bindings/scripts/CodeGeneratorJS.pm: Use the new DEFINE_PROTOTYPE_WITH_PROTOTYPE macro in place of the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro.
khtml/ecma/kjs_dom.cpp: Ditto.
khtml/ecma/kjs_dom.h: Ditto.
khtml/ecma/kjs_events.cpp: Ditto.

Touched these files to force a rebuild:

bindings/js/JSDOMCore.cpp:
bindings/js/JSDOMEvents.cpp:
dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
dom/WheelEvent.idl:

6:53 PM Changeset in webkit [13149] by mjs

40 edits in trunk/WebCore

Reviewed by Darin.

use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL) http://bugzilla.opendarwin.org/show_bug.cgi?id=7618

css/css_base.cpp: (WebCore::CSSSelector::operator == ): (WebCore::CSSSelector::selectorText):
css/css_base.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::relation):
css/css_grammar.y:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
kcanvas/KCanvasPath.h: (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::addPath):
kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
khtml/ecma/kjs_html.h:
khtml/html/HTMLButtonElementImpl.h:
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setInputType):
khtml/html/HTMLInputElementImpl.h: (DOM::HTMLInputElementImpl::inputType):
khtml/html/html_tableimpl.h:
khtml/xbl/xbl_protohandler.cpp: (XBL::m_button):
khtml/xbl/xbl_protohandler.h:
ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::): (WebCore::SVGRenderStyle::setBitDefaults):
ksvg2/svg/SVGAnimateTransformElementImpl.h:
ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
ksvg2/svg/SVGAnimationElementImpl.h:
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
ksvg2/svg/SVGLengthImpl.h:
kwq/KWQKHTMLSettings.h:
loader/CachedImage.h:
loader/DocLoader.cpp: (WebCore::DocLoader::setCachePolicy): (WebCore::DocLoader::setShowAnimations):
loader/DocLoader.h: (WebCore::DocLoader::showAnimations):
platform/FontDescription.h: (WebCore::FontDescription::genericFamily):
platform/QString.cpp: (HandleNode::):
platform/QString.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
rendering/RenderBlock.h: (WebCore::RenderBlock::selectionState): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::FloatingObject::type):
rendering/RenderTable.h: (WebCore::RenderTable::getRules):
rendering/bidi.cpp: (khtml::BidiContext::BidiContext): (khtml::operator==): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):
rendering/bidi.h: (khtml::BidiContext::dir): (khtml::BidiContext::basicDir): (khtml::BidiRun::BidiRun):
rendering/render_canvasimage.h:
rendering/render_layer.h: (WebCore::Marquee::whiteSpace):
rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
rendering/render_replaced.cpp: (WebCore::RenderWidget::setSelectionState):
rendering/render_replaced.h: (WebCore::RenderReplaced::selectionState):
rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle):
rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderValue::style): (khtml::BorderValue::nonZero): (khtml::BorderValue::operator==): (khtml::OutlineValue::operator==): (khtml::CollapsedBorderValue::style): (khtml::BorderImage::horizontalRule): (khtml::BorderImage::verticalRule): (khtml::BorderData::borderLeftWidth): (khtml::BorderData::borderRightWidth): (khtml::BorderData::borderTopWidth): (khtml::BorderData::borderBottomWidth): (khtml::BackgroundLayer::backgroundClip): (khtml::BackgroundLayer::backgroundOrigin): (khtml::BackgroundLayer::backgroundRepeat): (khtml::RenderStyle::styleType): (khtml::RenderStyle::display): (khtml::RenderStyle::originalDisplay): (khtml::RenderStyle::position): (khtml::RenderStyle::floating): (khtml::RenderStyle::borderLeftStyle): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightStyle): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopStyle): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomStyle): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::overflow): (khtml::RenderStyle::visibility): (khtml::RenderStyle::verticalAlign): (khtml::RenderStyle::unicodeBidi): (khtml::RenderStyle::clear): (khtml::RenderStyle::tableLayout): (khtml::RenderStyle::textAlign): (khtml::RenderStyle::textTransform): (khtml::RenderStyle::direction): (khtml::RenderStyle::whiteSpace): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundClip): (khtml::RenderStyle::backgroundOrigin): (khtml::RenderStyle::emptyCells): (khtml::RenderStyle::captionSide): (khtml::RenderStyle::listStyleType): (khtml::RenderStyle::listStylePosition): (khtml::RenderStyle::cursor): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::appearance): (khtml::RenderStyle::boxAlign): (khtml::RenderStyle::boxDirection): (khtml::RenderStyle::boxLines): (khtml::RenderStyle::boxOrient): (khtml::RenderStyle::boxPack): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::userModify): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::wordWrap): (khtml::RenderStyle::nbspMode): (khtml::RenderStyle::khtmlLineBreak): (khtml::RenderStyle::matchNearestMailBlockquoteColor): (khtml::RenderStyle::setBorderLeftWidth): (khtml::RenderStyle::setBorderLeftStyle): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightWidth): (khtml::RenderStyle::setBorderRightStyle): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopWidth): (khtml::RenderStyle::setBorderTopStyle): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomWidth): (khtml::RenderStyle::setBorderBottomStyle): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::pseudoState):

12:36 PM Changeset in webkit [13148] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Fix a couple of things found while testing. Script now works (after landing my two pending patches).

12:25 PM Changeset in webkit [13147] by ggaren

2 edits in trunk/WebCore

Rolled out the fix for <rdar://problem/4467143> because it's the wrong approach. Maciej and I discussed this on IRC.

khtml/ecma/kjs_dom.cpp: (KJS::): Don't use classInfo to express prototype inheritance. classInfo is only for representing a c++ superclass relationship.

11:59 AM Changeset in webkit [13146] by darin

1 edit
1 add in trunk/WebKitTools

check in a script to do a "big" rename in WebCore (can be run whenever we're ready to do it)

Scripts/do-webcore-rename: Added.

9:11 AM Changeset in webkit [13145] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Move improperly placed #endif causing no-svg build to fail.

kcanvas/device/quartz/KRenderingDeviceQuartz.h:

6:36 AM Changeset in webkit [13144] by lypanov

1 edit
6 adds in trunk/LayoutTests

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

missing results from previous commit

svg/custom/polyline-invalid-points-expected.checksum: Added.
svg/custom/polyline-invalid-points-expected.png: Added.
svg/custom/polyline-invalid-points-expected.txt: Added.
svg/custom/polyline-setattribute-points-null-expected.checksum: Added.
svg/custom/polyline-setattribute-points-null-expected.png: Added.
svg/custom/polyline-setattribute-points-null-expected.txt: Added.

6:33 AM Changeset in webkit [13143] by lypanov

3 edits
2 adds in trunk

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

new reduced testcases for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 http://bugzilla.opendarwin.org/show_bug.cgi?id=6890

svg/custom/polyline-invalid-points.svg: Added.
svg/custom/polyline-setattribute-points-null.svg: Added.

2006-03-05 Alexander Kellett <lypanov@kde.org>

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6890 and http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 by being more tolerant towards invalid points data

new tests: svg/custom/polyline-setattribute-points-null.svg svg/custom/polyline-invalid-points.svg

ksvg2/svg/svgpathparser.cpp: (SVGPolyParser::parsePoints):

3:27 AM Changeset in webkit [13142] by mjs

3 edits
3 deletes in trunk/WebCore

Rubber stamped by Eric.

remove no longer used KDOMSettings and KSVGSettings

WebCore+SVG/KDOMSettings.cpp: Removed.
WebCore+SVG/KDOMSettings.h: Removed.
WebCore.xcodeproj/project.pbxproj:
ksvg2/KSVGSettings.h: Removed.
ksvg2/svg/SVGStyledElementImpl.cpp:

3:12 AM Changeset in webkit [13141] by mjs

2 edits in trunk/WebKitTools

Reviewed by Eric.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Close file when done.

2:30 AM Changeset in webkit [13140] by eseidel

2 edits in trunk/WebCore

2006-03-05 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

platform/Font.cpp: (WebCore::Font::update): remove extra ref causing large leak.

2:10 AM Changeset in webkit [13139] by ap

5 edits
4 adds in trunk

Fix by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7589 Mouse moved events do not work in DumpRenderTree

WebKitTools:

DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseMoveToX:Y:]): Pass the correct windowNumber in the event.

LayoutTests:

fast/css/hover-subselector-expected.txt: Updated results.
fast/css/hover-subselector.html: Changed to work with the new mechanism.
fast/events/event-sender-mouse-moved-expected.checksum: Added.
fast/events/event-sender-mouse-moved-expected.png: Added.
fast/events/event-sender-mouse-moved-expected.txt: Added.
fast/events/event-sender-mouse-moved.html: Added.

1:43 AM Changeset in webkit [13138] by ap

3 edits in trunk/JavaScriptCore

Patch by Andrew Wellington, reviewed by Eric.

Remove unused breakpoint bool from StatementNodes. No test provided as there is no functionality change.

kjs/nodes.cpp: (StatementNode::StatementNode):
kjs/nodes.h:

1:42 AM Changeset in webkit [13137] by eseidel

5 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Take advantage of new GraphicsContext constructor to implement double buffering to avoid tearing.
Disable background erase to avoid tearing.
Fix potential memory smasher from extra long urls.

Spinneret/Spinneret/Spinneret.cpp: (MyRegisterClass):
Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::paint):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance):

1:41 AM Changeset in webkit [13136] by eseidel

9 edits in trunk/WebCore

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Re-work ImageViewer to use GraphicsContext.
Add GraphicsContext(cairo_t*) constructor to make double-buffering easier.
Add one more stub to prevent slashdot from crashing.
Also fixed win32 build after Font change.

Viewer.vcproj:
Viewer/ImageView.cpp:
platform/Color.h:
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

1:35 AM Changeset in webkit [13135] by ap

6 edits
1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4840 Frames only resize wider, can't make them narrower

khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): Removed unused m_resizing flag.
khtml/html/html_baseimpl.h:
manual-tests/bugzilla-4840.html: Added.
page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::setResizingFrameSet): New method. When a resizing frameset is set, mouse move and mouse release events target it instead of hit-testing.
page/FrameView.h:
rendering/render_frames.cpp: (WebCore::RenderFrameSet::setResizing): Inform the FrameView that we are resizing (or not).

Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt

23 edits
2 adds
2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

WebCore.xcodeproj/project.pbxproj:
css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
kwq/KWQFontMetrics.h: Removed.
kwq/KWQFontMetrics.mm: Removed.
platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
platform/GraphicsContext.h:
platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
platform/mac/GraphicsContextMac.mm:
rendering/InlineTextBox.h:
rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
rendering/RenderText.h:
rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
rendering/render_object.h:
rendering/render_style.h:

4:33 PM Changeset in webkit [13133] by eseidel

3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):

4:28 PM Changeset in webkit [13132] by eseidel

2 edits in trunk/WebCore

2006-03-04 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):

3:07 PM Changeset in webkit [13131] by thatcher

2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap

2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

Scripts/run-webkit-tests:

3:05 PM Changeset in webkit [13129] by mjs

3 edits in trunk/WebCore

Reviewed by Eric.

stop background image loads from crashing

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):

fix termination condition on file load loop

platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

2:57 PM Changeset in webkit [13128] by thatcher

9 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

English.lproj/Localizable.strings: removed localized strings
WebInspector.subproj/WebInspector.m: (-init): (-dealloc): (-window): (-setSearchQuery:): (-resizeTopArea): (-searchPerformed:): called from JavaScript when a search happens (-_toggleIgnoreWhitespace:): (-_exitSearch:): exit search results on double click (-_focusRootNode:): (-_revealAndSelectNodeInTree:): (-_refreshSearch): (-_update): (-_updateTraversalButtons): (-_updateRoot): (-_updateTreeScrollbar): (-_updateSystemColors): update CSS with system colors (-webView:didFinishLoadForFrame:): (-webView:plugInViewWithArguments:): (-outlineViewSelectionDidChange:): test for webViewLoaded (-[WebInspectorPrivate init]): alloc rightArrowImage and downArrowImage (-[WebInspectorPrivate dealloc]): no more matchedRules (-[DOMNode _displayName]): removed localization UI_STRING calls.
WebInspector.subproj/WebInspectorInternal.h:
WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.html:
WebInspector.subproj/webInspector/inspector.js:

12:37 PM Changeset in webkit [13127] by ggaren

3 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.

3:02 AM Changeset in webkit [13126] by mjs

3 edits in trunk/WebKitTools

Reviewed by Eric.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.

2:58 AM Changeset in webkit [13125] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

2:26 AM Changeset in webkit [13124] by mjs

10 edits in trunk/WebCore

Reviewed by Eric.

make TransferJobWin handle file: URLs, and fix other bugs as needed to make local file image loads work http://bugzilla.opendarwin.org/show_bug.cgi?id=7587

WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
platform/TransferJob.h:
platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.

Mar 3, 2006:

11:42 PM Changeset in webkit [13123] by eseidel

5 edits
2 adds in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
rendering/RenderThemeWin.h: Added.

11:29 PM Changeset in webkit [13122] by eseidel

3 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
Scripts/run-webkit-tests:

5:35 PM Changeset in webkit [13121] by eseidel

5 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):

3:33 PM Changeset in webkit [13120] by ggaren

3 edits
1 add in trunk

JavaScriptCore:

Reviewed by Darin.

Fixed <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

manual-tests/property-map-save-crash.html: Added.

2:10 PM Changeset in webkit [13119] by lypanov

2 edits in trunk/LayoutTests

2006-03-03 Alexander Kellett <lypanov@kde.org>

local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.

svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:

11:43 AM Changeset in webkit [13118] by eseidel

3 edits in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):

7:59 AM Changeset in webkit [13117] by darin

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Eric.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7480 non-HTML elems w/o children in HTML docs get serialized self-closing
update tests for problem where the HTML tokenizer would discard the first newline after </pre>

fast/innerHTML/innerHTML-custom-tag.html: Added.
fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.

fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.

editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7480 non-HTML elems w/o children in HTML docs get serialized self-closing
fix problem where the HTML tokenizer would discard the first newline after </pre>

Test: fast/innerHTML/innerHTML-custom-tag.html

editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.

1:54 AM Changeset in webkit [13116] by eseidel

5 edits
2 adds in trunk/WebKitTools

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
Spinneret/Spinneret/WebFrame.h: Added.
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

1:44 AM Changeset in webkit [13115] by mjs

3 edits
1 copy in trunk/WebCore

Rubber stamped by Eric.

add new files to build, fix link stubs.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
platform/win/TransferJobWin.cpp: Added.

1:31 AM Changeset in webkit [13114] by mjs

1 edit
1 add in trunk/WebCore

add file I forgot in my last commit.

platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):

1:30 AM Changeset in webkit [13113] by eseidel

10 edits
2 adds in trunk/WebCore

2006-03-03 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

Viewer/ImageDocument.h:
WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.cpp:
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
platform/IntRect.h: (WebCore::IntRect::IntRect):
platform/Widget.h:
platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
platform/win/MouseEventWin.cpp:
platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):

1:19 AM Changeset in webkit [13112] by mjs

11 edits
1 copy
3 moves
2 deletes in trunk/WebCore

Reviewed by Eric.

move TransferJob from kwq to platform, separate platform from non-platform bits

ForwardingHeaders/kio/job.h: Removed.
ForwardingHeaders/kio/jobclasses.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm:
dom/xml_tokenizer.cpp:
khtml/xsl/xslt_processorimpl.cpp:
kwq/KWQKJobClasses.h: Removed.
kwq/KWQKJobClasses.mm: Removed.
kwq/KWQLoader.mm:
kwq/KWQResourceLoader.mm:
kwq/TransferJobClient.h: Removed.
loader/Cache.cpp:
loader/loader.cpp:
page/Frame.cpp:
platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
platform/TransferJob.h: Added.
platform/TransferJobClient.h: Added.
platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
xml/xmlhttprequest.cpp:

1:18 AM Changeset in webkit [13111] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint

platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed