Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin

• 2 edits in trunk/WebCore

• fix Windows build

• bridge/win/FrameWin.h: Removed declaration of generateFrameName.

7:30 PM Changeset in webkit [13260] by darin

• 9 edits in trunk

WebCore:

Reviewed by Adele.

• removed some unused stuff from Frame and MacFrame

• page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
• page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
• page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.

• bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
• bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.

• bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

• WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.

7:25 PM Changeset in webkit [13259] by darin

• 2 edits in trunk/WebCore

• fix Windows build

• page/FrameTree.cpp: Add include of <stdarg.h>.

7:21 PM Changeset in webkit [13258] by darin

• 4 edits in trunk/WebKit

Reviewed by Geoff.

• change how frame namespacing works to be more completely on the WebCore side

• WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
• WebView/WebFrame.m: Ditto.

• WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].

7:17 PM Changeset in webkit [13257] by darin

• 23 edits
  1 move
  8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3308 Pop-up blocking blocks window.open for already open windows

• fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
• fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
• fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
• fast/dom/Window/open-existing-pop-up-blocking.html: Added.
• fast/dom/Window/resources/open-sibling-subframe.html: Added.
• fast/dom/Window/resources/sibling-subframe-content.html: Added.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7422 Setting a frame name to the same value resets it to a generated one

• fast/frames/frame-name-reset.html: Added.
• fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3308 Pop-up blocking blocks window.open for already open windows

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7422 Setting a frame name to the same value resets it to a generated one

• refactor frame-name-related functions into the FrameTree object

• WebCore.xcodeproj/project.pbxproj: Update for rename.
• bridge/mac/MacFrame.h: Remove generateFrameName.
• bridge/mac/MacFrame.mm: Ditto.
• bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.

• bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.

• bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
• bridge/mac/WebCoreFrameNamespaces.m: Renamed.
• bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.

• bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
• bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.

• khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.

• khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.

• khtml/html/html_baseimpl.h:
• khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.

• rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.

• page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
• page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.

• page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
• page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.

• page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
• page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.

• platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.

5:35 PM Changeset in webkit [13256] by justing

• 2 edits in trunk/WebCore

Reviewed by darin, harrison

~3x speedup pasting plain text from the console

• dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):

4:19 PM Changeset in webkit [13255] by hyatt

• 3 edits
  3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher

• 5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher

• 4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs

• 2 edits in trunk/WebCore

Reviewed by Eric.

• fix win32 networking to properly use async load API

• platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):

1:15 PM Changeset in webkit [13251] by eseidel

• 3 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Fix build.

• platform/win/FontWin.cpp: (WebCore::getFontData):
• platform/win/TemporaryLinkStubs.cpp:

1:13 PM Changeset in webkit [13250] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

• Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

• fast/forms/radio-attr-order-expected.checksum: Added.
• fast/forms/radio-attr-order-expected.png: Added.
• fast/forms/radio-attr-order-expected.txt: Added.
• fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

• fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

• khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.

1:05 PM Changeset in webkit [13249] by eseidel

• 24 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

• platform/ScrollView.h:
• platform/Widget.h:
• platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
• platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
• platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const

11:28 AM Changeset in webkit [13248] by hyatt

• 6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

• platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
• platform/Font.h:
• platform/FontDataSet.h:
• platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
• platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):

10:58 AM Changeset in webkit [13247] by hyatt

• 6 edits
  1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

• WebCore.xcodeproj/project.pbxproj:
• platform/Font.cpp: (WebCore::Font::update):
• platform/Font.h:
• platform/FontDataSet.h: Added.
• platform/FontRenderer.h: Removed.
• platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
• platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):

10:40 AM Changeset in webkit [13246] by hyatt

• 2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Mar 9, 2006:

11:37 PM Changeset in webkit [13245] by justing

• 2 edits in trunk/WebCore

Reviewed by adele

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7692>
Should use an iterator in CompositeEditCommand::doUnapply()

~30% speedup of a big undo

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): (WebCore::CompositeEditCommand::doReapply):

6:20 PM Changeset in webkit [13244] by adele

• 3 edits in trunk/WebCore

Reviewed by Tim O.

Removed unnecessary alerts in TextIterator advance methods.
We want to be able to use advance() even if the iterator is already at the end.

• editing/visible_text.cpp: (khtml::TextIterator::advance): remove assert since TextIterator will just do nothing if its already at the end. (khtml::CharacterIterator::advance): ditto.
• rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): Since the asserts in the iterator are removed, we don't have to check for it.atEnd() before calling advance.

4:13 PM Changeset in webkit [13243] by thatcher

• 5 copies in tags/JavaScriptCore-417.10/JavaScriptCore

New tag (part two).

4:12 PM Changeset in webkit [13242] by thatcher

• 1 add in tags/JavaScriptCore-417.10

New tag.

3:39 PM Changeset in webkit [13241] by hyatt

• 2 edits in trunk/WebCore

Make text paint with the pen color on Win32. Force ClearType quality. Make the face validation case-insensitive.

3:30 PM Changeset in webkit [13240] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

• Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7675 When new text fields change from visibility:hidden to visibility:visible, value doesn't display

• fast/forms/input-appearance-visibility-expected.checksum: Added.
• fast/forms/input-appearance-visibility-expected.png: Added.
• fast/forms/input-appearance-visibility-expected.txt: Added.
• fast/forms/input-appearance-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7675 When new text fields change from visibility:hidden to visibility:visible, value doesn't display

Test: fast/forms/input-appearance-visibility.html

• rendering/RenderTextField.cpp: (WebCore::RenderTextField::setStyle): Sets the style directly on the children of the inner div.

3:27 PM Changeset in webkit [13239] by thatcher

• 1 edit in branches/Safari-2-0-branch/JavaScriptCore/Info.plist

Versioning

3:21 PM Changeset in webkit [13238] by thatcher

• 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

• bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto

• bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().

2:48 PM Changeset in webkit [13237] by hyatt

• 1 edit in trunk/WebCore/platform/win/FontWin.cpp

SetBkMode to transparent so that TextOut doesn't erase the background when drawing text.

1:24 PM Changeset in webkit [13236] by hyatt

• 8 edits
  2 adds in trunk/WebCore

Check in basic text rendering on Win32.

12:02 PM Changeset in webkit [13235] by justing

• 3 edits in trunk/WebCore

Reviewed by harrison

Fixed formatting and changed functions to take in
a const Selection& instead of a Selection.

• editing/ModifySelectionListLevelCommand.cpp: (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
• editing/ModifySelectionListLevelCommand.h:

11:43 AM Changeset in webkit [13234] by adele

• 4 edits
  4 adds in trunk

LayoutTests:

• Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6814 Implement selection methods for RenderTextField

• fast/forms/input-appearance-selection-expected.checksum: Added.
• fast/forms/input-appearance-selection-expected.png: Added.
• fast/forms/input-appearance-selection-expected.txt: Added.
• fast/forms/input-appearance-selection.html: Added.

WebCore:

Reviewed by Darin.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6814 Implement selection methods for RenderTextField

Test: fast/forms/input-appearance-selection.html

• rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): removed extra space. (WebCore::RenderTextField::select): Removed checks for document and m_div since there should always be a document and m_div will be initialized as the renderer gets attached. (WebCore::RenderTextField::selectionStart): Calls indexForVisiblePosition. (WebCore::RenderTextField::selectionEnd): ditto. (WebCore::RenderTextField::setSelectionStart): calls setSelectionRange. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::setSelectionRange): gets VisiblePositions for both indices, and sets the selection. (WebCore::RenderTextField::visiblePositionForIndex): Added helper method. (WebCore::RenderTextField::indexForVisiblePosition): Added helper method.
• rendering/RenderTextField.h: Added new helper methods for selection.

9:19 AM Changeset in webkit [13233] by darin

• 5 edits in trunk/WebKitTools

Reviewed by John Sullivan.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7681 memory leak in the plug-in tests

• DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Added code to release the plug-in object. This is the leak fix. (NPP_SetWindow): Remove unneeded code to store the window pointer.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Moved the browser global in here since it's declared in this file's header. Changed the code to set up the pluginClass structure to not use function pointer casts. Those are dangerous because they can hide many types of mismatch. And indeed when I did this I discovered that many functions were missing their boolean return values or had parameter declarations with the wrong types. (pluginGetProperty): Use STRINGZ_TO_NPVARIANT macro for greater simplicity and clarity. Added boolean return value: return true when successful and false when not. (pluginSetProperty): Added boolean return value, return false since we have no properties we can set. (pluginInvoke): Added boolean return value. Return true when successful and false when not. Use NPVARIANT macros where appropriate. Added a missing release for the return value from calling the browser. Changed code to put the strings in malloc buffers instead of relying on GCC's extension that allows variable-sized arrays on the stack. (pluginInvokeDefault): Added boolean return value, return false since we have no default function to call. (pluginInvalidate): Added missing parameter. Removed comment. (pluginAllocate): Removed unneeded cast. This is C code, not C++, so you don't have to cast the result of malloc. (pluginDeallocate): Removed uneeded cast.

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Removed some unneeded includes. Changed our PluginObject to use NPObject instead of re-declaring fields that match NPObject's fields. Removed unused NPWindow pointer.

8:35 AM Changeset in webkit [13232] by darin

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Darin.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7583 DRT hangs when doing eventSender.mouseDown on native widgets

• fast/events/event-sender-mouse-click-expected.txt: Added.
• fast/events/event-sender-mouse-click.html: Added.

WebKitTools:

Test: fast/events/event-sender-mouse-click.html

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7583 DRT hangs when doing eventSender.mouseDown on native widgets

• DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController mouseClick]): Simulates a click in a native widget by queueing a mouseUp before sending the mouseDown, so that the widget's mouse tracking event loop doesn't hang indefinitely.

8:32 AM Changeset in webkit [13231] by darin

• 3 edits
  1 copy
  8 moves
  6 adds in trunk

LayoutTests:

Reviewed by Darin.

• fast/canvas: Added.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6103 Rectangles are not filled according to the Web Applications Working Draft

• fast/canvas/fillrect_gradient-expected.checksum: Added.
• fast/canvas/fillrect_gradient-expected.png: Added.
• fast/canvas/fillrect_gradient-expected.txt: Added.
• fast/canvas/fillrect_gradient.html: Added.

• moved other canvas tests here

• fast/canvas/image-object-in-canvas-expected.checksum: Added.
• fast/canvas/image-object-in-canvas-expected.png: Added.
• fast/canvas/image-object-in-canvas-expected.txt: Added.
• fast/canvas/image-object-in-canvas.html: Added.
• fast/canvas/quadraticCurveTo-expected.checksum: Added.
• fast/canvas/quadraticCurveTo-expected.png: Added.
• fast/canvas/quadraticCurveTo-expected.txt: Added.
• fast/canvas/quadraticCurveTo.xml: Added.
• fast/canvas/resources: Added.
• fast/canvas/resources/apple.gif: Added.

• fast/dom/image-object-in-canvas-expected.checksum: Removed.
• fast/dom/image-object-in-canvas-expected.png: Removed.
• fast/dom/image-object-in-canvas-expected.txt: Removed.
• fast/dom/image-object-in-canvas.html: Removed.
• fast/dom/quadraticCurveTo-expected.checksum: Removed.
• fast/dom/quadraticCurveTo-expected.png: Removed.
• fast/dom/quadraticCurveTo-expected.txt: Removed.
• fast/dom/quadraticCurveTo.xml: Removed.

WebCore:

Test: fast/canvas/fillrect_gradient.html

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6103 Rectangles are not filled according to the Web Applications Working Draft

• khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::callAsFunction): Modified fillrect function to check and use a gradient if set. Builds a path to fill rects with a gradient.

8:10 AM Changeset in webkit [13230] by darin

• 2 edits in trunk/WebCore

No test because this fixes an existing pixel test (and does not affect
the render tree).

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7664 REGRESSION: tests that include numeric list markers fail in pixel mode

• platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Restored AlignRight behavior.

8:05 AM Changeset in webkit [13229] by darin

• 2 edits in trunk/WebCore

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7680 REGRESSION: Ellipsis painted over the chrome and in invalid contexts

• rendering/render_line.cpp: (WebCore::EllipsisBox::paint): Replaced call to Font::drawText with GraphicsContext::drawText, which checks the paintingDisabled flag.

2:57 AM Changeset in webkit [13228] by mjs

• 10 edits in trunk

WebCore:

Reviewed by Eric.

• make link clicks work by propagating them up to a client

• Viewer/ImageView.cpp:
• bridge/win/FrameWin.cpp:
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):

WebKitTools:

Reviewed by Eric.

• make link clicks work by handling link click requests from WebCore

• Spinneret/Spinneret/Spinneret.cpp: (updateLocationBar):
• Spinneret/Spinneret/Spinneret.h:
• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::openURL): (WebKit::WebFrame::loadURL):
• Spinneret/Spinneret/WebFrame.h:

1:52 AM Changeset in webkit [13227] by eseidel

• 4 edits in trunk/WebKitTools

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Focus URL bar on Spinneret launch, remove border from WebView.
Stop WebFrame from deleting the job (prevent crash).

• Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::receivedAllData): (WebKit::WebFrame::paint):
• Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView):

1:49 AM Changeset in webkit [13226] by eseidel

• 8 edits in trunk/WebCore

2006-03-09 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add support for Timers under 10ms.
Fix random crashers due to multi-threaded loading.

• platform/TransferJob.h:
• platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
• platform/Widget.h:
• platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::initializeOffScreenTimerWindow): (WebCore::setSharedTimerFireTime):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::retrieveCharset):
• platform/win/TransferJobWin.cpp: (WebCore::addToOutstandingJobs): (WebCore::removeFromOutstandingJobs): (WebCore::lookupTransferJob): (WebCore::TransferJobWndProc): (WebCore::initializeOffScreenTransferJobWindow): (WebCore::TransferJob::~TransferJob): (WebCore::transferJobStatusCallback): (WebCore::TransferJob::start): (WebCore::TransferJob::cancel):
• platform/win/WidgetWin.cpp:

Mar 8, 2006:

9:49 PM Changeset in webkit [13225] by ap

• 6 edits
  2 adds in trunk

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7656 Query string always appended to Flash URLs, instead of being replaced.

WebKit:

• Misc/WebNSURLExtras.h: Added _webkit_URLByRemovingResourceSpecifier.
• Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:relativeToURL:]): Call _webkit_URLByRemovingResourceSpecifier to work around CFURL not removing non-path components from base URLs in some cases. (-[NSURL _webkit_URLByRemovingComponent:]): New generic function for removing URL components. (-[NSURL _webkit_URLByRemovingFragment]): Moved implementation to the above method. (-[NSURL _webkit_URLByRemovingResourceSpecifier]): Added.

WebKitTools:

• DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Added a method to test getURL.

LayoutTests:

• plugins/geturl-replace-query-expected.txt: Added.
• plugins/geturl-replace-query.html: Added.

6:28 PM Changeset in webkit [13224] by darin

• 1 edit in trunk/LayoutTests/ChangeLog

Added log entry that somehow didn't get checked in last night.

4:20 PM Changeset in webkit [13223] by ggaren

• 2 edits in trunk/WebKitSite

Reviewed by Beth.

Clarified that sites on the list aren't necessarily "broken."

• projects/compat/hitlist.html:

3:53 PM Changeset in webkit [13222] by hyatt

• 18 edits in trunk/WebCore/platform/cairo

merge cairo to the mozilla trunk.

3:07 PM Changeset in webkit [13221] by justing

• 8 edits
  4 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)

• editing/editing.js:
• editing/execCommand/insertImage-expected.checksum: Added.
• editing/execCommand/insertImage-expected.png: Added.
• editing/execCommand/insertImage-expected.txt: Added.
• editing/execCommand/insertImage.html: Added.
• editing/pasteboard/3976872-expected.txt:

WebCore:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7579>
TinyMCE: Implement execCommand(insertImage, ...)

Implemented InsertImage and also changed paste to use a single
rule for when to remove junk that remains after node removal.

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeNodeAndPruneAncestors): (WebCore::ReplaceSelectionCommand::doApply): (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded):
• editing/ReplaceSelectionCommand.h:
• editing/htmlediting.cpp:
• editing/jsediting.cpp:

2:51 PM Changeset in webkit [13220] by ggaren

• 2 edits in trunk/WebKitSite

Reviewed by Beth.

Updated links to gap and bananarepublic bugs.

• projects/compat/hitlist.html:

2:39 PM Changeset in webkit [13219] by thatcher

• 3 copies in tags/WebKit-418/WebKit

New tag (part 2).

2:39 PM Changeset in webkit [13218] by thatcher

• 1 add in tags/WebKit-418

New tag.

2:36 PM Changeset in webkit [13217] by thatcher

• 2 edits in branches/Safari-2-0-branch/WebKit

<rdar://problem/4464698> 10.4.6 REGRESSION: Safari 417.9 no longer works with gap.com (417.8 did)

• Info.plist: bump the version to 418 to allow GAP's >= check to work

2:20 PM Changeset in webkit [13216] by eseidel

• 2 edits in trunk/WebCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build script to properly copy dll files.

• WebCore.vcproj/WebCore/build-generated-files.sh:

1:32 PM Changeset in webkit [13215] by eseidel

• 69 edits
  4 adds in trunk

2006-03-08 Rob Buis <​buis@kde.org>

Reviewed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6899
SVG <rect> does not respect display: none

For svg elements that can render, call StyledElementImpl::rendererIsNeeded
to decide whether the element should render. In particular this way
any setting of display="none" is handled.

• ksvg2/svg/SVGAElementImpl.h: (WebCore::SVGAElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGCircleElementImpl.h: (WebCore::SVGCircleElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGEllipseElementImpl.h: (WebCore::SVGEllipseElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGForeignObjectElementImpl.h: (WebCore::SVGForeignObjectElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGGElementImpl.h: (WebCore::SVGGElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGImageElementImpl.h: (WebCore::SVGImageElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGLineElementImpl.h: (WebCore::SVGLineElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGMarkerElementImpl.h: (WebCore::SVGMarkerElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGMaskElementImpl.h: (WebCore::SVGMaskElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPathElementImpl.h: (WebCore::SVGPathElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPatternElementImpl.h: (WebCore::SVGPatternElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGPolyElementImpl.h: (WebCore::SVGPolyElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGRectElementImpl.h: (WebCore::SVGRectElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGSVGElementImpl.h: (WebCore::SVGSVGElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGSwitchElementImpl.h: (WebCore::SVGSwitchElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGTSpanElementImpl.h: (WebCore::SVGTSpanElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGTextElementImpl.h: (WebCore::SVGTextElementImpl::rendererIsNeeded):
• ksvg2/svg/SVGUseElementImpl.h: (WebCore::SVGUseElementImpl::rendererIsNeeded):

3:59 AM Changeset in webkit [13214] by mjs

• 6 edits in trunk/WebKitTools

Reviewed by Eric.

• load URLs, not file paths, in Spinneret

• Spinneret/Spinneret/Spinneret.cpp: (MyEditProc):
• Spinneret/Spinneret/Spinneret.vcproj:
• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadURL): (WebKit::WebFrame::receivedData): (WebKit::WebFrame::receivedAllData):
• Spinneret/Spinneret/WebFrame.h:
• Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):

3:56 AM Changeset in webkit [13213] by mjs

• 4 edits in trunk/WebCore

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
• platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):

3:40 AM Changeset in webkit [13212] by eseidel

• 4 edits
  1 add in trunk/WebCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add stubs to allow JavaScript-enabled WebCore to not crash.
Add ScreenWin implementation.
Add alert() support.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::runJavaScriptAlert): (WebCore::FrameWin::runJavaScriptConfirm):
• platform/win/ScreenWin.cpp: Added. (WebCore::monitorInfoForWidget): (WebCore::WebCore::screenRect): (WebCore::WebCore::screenDepth): (WebCore::WebCore::usableScreenRect):
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::canPaste): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer):

2:59 AM Changeset in webkit [13211] by eseidel

• 3 edits in trunk/JavaScriptCore

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Partially fix JS on win32 by fixing hash table generation.

• kjs/create_hash_table: limit << results to 32 bits.
• kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

1:55 AM Changeset in webkit [13210] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fix another instance of the bug I just fixed in the Macintosh-specific code path

• platform/image-decoders/gif/GIFImageReader.h: Remove not-so-useful 100ms constant.
• platform/image-decoders/gif/GIFImageReader.cpp: (GIFImageReader::read): Use the correct rule for minimum frame durations.

1:43 AM Changeset in webkit [13209] by mjs

• 3 edits in trunk/WebCore

Reviewed by Darin.

• fix win32 build

• platform/win/FontWin.cpp: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText):
• platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::clearFocusRing): (GraphicsContext::selectedTextBackgroundColor): (Font::selectionRectForText):

1:40 AM Changeset in webkit [13208] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fix one more thing from ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7528 REGRESSION: GIF animation speeds are wrong on a page with many animated GIFs

No layout test because I don't know how to test animated GIF speed.

• platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Use the correct rule for minimum frame durations. It's a bit non-intuitive, so I made the comment more explicit. The old code in WebKit had this rule.

1:26 AM Changeset in webkit [13207] by darin

• 3 edits in trunk

Reviewed by Eric.

• fixed AppleScript layout test results to not be endian-dependent (Hyatt complained to me about this one)

• DumpRenderTree/AppleScriptController.m: (-[AppleScriptController doJavaScript:]): Added specific code for dumping LongDateTime, instead of dumping the raw bytes (which are endian-dependent).

1:12 AM Changeset in webkit [13206] by hyatt

• 9 edits in trunk/WebCore

Make GraphicsContext call into Font to draw all text and eliminate
all knowledge of WebTextRenderers from it.

Reviewed by darin

• platform/Font.h:
• platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::drawLineForMisspelling): (WebCore::GraphicsContext::misspellingLineThickness):
• platform/GraphicsContext.h: (WebCore::GraphicsContext::platformContext):
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::platformContext):
• platform/mac/FontMac.mm: (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness):
• platform/mac/GraphicsContextMac.mm:
• platform/win/FontWin.cpp: (WebCore::Font::drawText):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):

1:08 AM Changeset in webkit [13205] by darin

• 2 edits in trunk/JavaScriptCore

• kxmlcore/Vector.h: Quick fix to try to get Windows compiling again.

12:59 AM Changeset in webkit [13204] by darin

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

• fixed super-fast animation of many animated GIFs

No layout test because I don't know how to test animated GIF speed.

• platform/mac/ImageSourceMac.cpp: (WebCore::ImageSource::frameDurationAtIndex): Always take the minimum duration into account, even if there's some kind of failure getting the duration from the GIF.

12:30 AM Changeset in webkit [13203] by darin

• 12 edits in trunk

JavaScriptCore:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• kjs/lexer.cpp: (Lexer::lex): Turn off the "yylex: ERROR" message.
• kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the code to log errors from PCRE to standard output. I think we should arrange for the error text to be in JavaScript exceptions instead at some point.
• kxmlcore/Vector.h: Add a check for overflow so that we'll abort if we pass a too-large size rather than allocating a buffer smaller than requested.

WebCore:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString): Pass XML_PARSE_NOERROR and XML_PARSE_NOWARNING. We don't want errors and warnings to be logged to stdout or stderr. If we later decide we want the error messages, then we should do the additional work to put them into the web page or the console (along with the JavaScript errors).

• platform/ArrayImpl.cpp: (WebCore::ArrayImpl::resize): Add a preflight to protect against integer overflow due to large array size. Noticed this while looking into the malloc error message.

WebKit:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• WebView/WebDataSourcePrivate.h:
• WebView/WebDataSource.m: (-[WebDataSource _setRepresentation:]): Clear the flag that records whether we've sent all the data to the representation or not; need this to prevent telling the same representation both that we've succeeded and then later that we've failed. (-[WebDataSource _setMainDocumentError:]): Don't send an error if representationFinishedLoading is already YES. Set representationFinishedLoading. (-[WebDataSource _finishedLoading]): Set representationFinishedLoading. (-[WebDataSource _setupForReplaceByMIMEType:]): Ditto.

WebKitTools:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• DumpRenderTree/DumpRenderTree.m: (checkedMalloc): Added. (checkedRealloc): Added. (makeLargeMallocFailSilently): Added. (main): Call makeLargeMallocFailSilently.

Mar 7, 2006:

5:37 PM Changeset in webkit [13202] by justing

• 2 edits in trunk/LayoutTests

Reviewed by harrison

I think this layout test is failing b/c the wait times are
right on the threshold of what is necessary to register a drag.

• fast/lists/drag-into-marker.html:

4:08 PM Changeset in webkit [13201] by darin

• 4 edits in trunk/WebCore

Reviewed by Adele.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7647 Crash when typing into text contols

I missed a couple places that were still saying KWQWidgetHolder
in the change I landed late last night.

• kwq/KWQTextArea.h:
• kwq/KWQTextArea.mm:
• kwq/KWQTextField.h: Changed them all to say WebCoreWidgetHolder.

3:35 PM Changeset in webkit [13200] by thatcher

• 1 edit in trunk/Makefile.shared

Add a prerequisite named 'force' to the debug and release rules to prevent the "debug is up-to-date" error. Reviewed by Eric.

2:26 PM Changeset in webkit [13199] by eseidel

• 2 edits in trunk/WebCore

2006-03-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix cursor support on win32.

• platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):

2:03 PM Changeset in webkit [13198] by hyatt

• 5 edits in trunk/WebCore

Eliminate two more unneeded arguments from drawText

1:49 PM Changeset in webkit [13197] by eseidel

• 2 edits in trunk/WebCore

2006-03-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix basic text support.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawText):

1:43 PM Changeset in webkit [13196] by hyatt

• 6 edits in trunk/WebCore

Remove unused parameters from drawText.

1:28 PM Changeset in webkit [13195] by hyatt

• 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Remove FontRendererWin.

1:21 PM Changeset in webkit [13194] by eseidel

• 4 edits
  1 add in trunk/WebCore

2006-03-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Add very basic text support.
Sort a few more stubs.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::drawText):
• platform/win/FontWin.cpp: Added. (WebCore::Font::drawText):
• platform/win/TemporaryLinkStubs.cpp: (QComboBox::focusPolicy): (ScrollView::scrollXOffset): (Font::isFixedPitch): (Path::boundingRect):

12:48 PM Changeset in webkit [13193] by adele

• 3 edits in trunk/LayoutTests

Updating tests for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7319
Can't see caret at the end of a contenteditable div with overflow:hidden

• fast/clip/outline-overflowClip-expected.txt:
• fast/overflow/overflow-focus-ring-expected.txt:

11:54 AM Changeset in webkit [13192] by adele

• 2 edits in trunk/WebCore

Reviewed by Hyatt.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7319 Can't see caret at the end of a contenteditable div with overflow:hidden

No tests added since I don't think the blinking caret will show up in our tests.

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::rightmostPosition): When calculating the rightmostPosition for editable blocks, we need to account for the caret that can be drawn 1 px past the last child inline box.

9:36 AM Changeset in webkit [13191] by darin

• 7 edits
  14 adds
  5 deletes in trunk

LayoutTests:

Reviewed by Darin.

• Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

• fast/js/exception-linenums-in-html-1-expected.txt: Added.
• fast/js/exception-linenums-in-html-1.html: Added.

Tests line numbers from HTML source files instead of JavaScript source files
which is tested by fast/js/exception-linenums.html. This test does not test
changes made for Bug 3905, but was added for better coverage.

• fast/js/exception-linenums-in-html-2-expected.txt: Added.
• fast/js/exception-linenums-in-html-2.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <title> tag, which causes the code path for Bug 3905 to be tested.

• fast/js/missing-title-end-tag-js-expected.txt: Added.
• fast/js/missing-title-end-tag-js.html: Added.

While developing a fix for Bug 3905, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

• fast/tokenizer/missing-title-end-tag-1-expected.checksum: Added.
• fast/tokenizer/missing-title-end-tag-1-expected.png: Added.
• fast/tokenizer/missing-title-end-tag-1-expected.txt: Added.
• fast/tokenizer/missing-title-end-tag-1.html: Added.
• fast/tokenizer/missing-title-end-tag-2-expected.checksum: Added.
• fast/tokenizer/missing-title-end-tag-2-expected.png: Added.
• fast/tokenizer/missing-title-end-tag-2-expected.txt: Added.
• fast/tokenizer/missing-title-end-tag-2.html: Added.

The first test case contains an unclosed <title> tag in <head>, while the
second test case contains an unclosed <title> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/missing-title-end-tag-js.html
Test: fast/tokenizer/missing-title-end-tag-1.html
Test: fast/tokenizer/missing-title-end-tag-2.html

• khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </title> tag and handle this condition if identified.
• khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </title> tag, reset the state of the tokenizer and retokenize with no special handling for <title>. The parser will handle the missing </title> tag in HTMLParser::handleError().
• platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): Added copy constructor. (WebCore::SegmentedString::operator=): Added assignment operator. Previously the compiler was generating a default method for the assignment operator, but it did not handle m_currentChar properly.
• platform/SegmentedString.h: Added prototypes for copy constructor and assignment operator.

9:33 AM Changeset in webkit [13190] by darin

• 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming ideas.

1:28 AM Changeset in webkit [13189] by eseidel

• 2 edits in trunk/WebCore

2006-03-07 Eric Seidel <​eseidel@apple.com>

Fix win32 link stubs.

• platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage):

1:21 AM Changeset in webkit [13188] by darin

• 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Still more tweaks to renaming.

1:03 AM Changeset in webkit [13187] by darin

• 43 edits
  2 copies
  7 moves
  6 deletes in trunk/WebCore

Reviewed by Adele, except for the first change listed.

• fix recently-introduced bug that GuardMalloc found while I was debugging my other change

• rendering/render_frames.cpp: (WebCore::RenderPart::~RenderPart): Set m_widget to 0 before calling deref so we don't end up trying to do unwanted work.

• removed 10 more files from KWQ

• ForwardingHeaders/klocale.h: Removed.

• khtml/misc/helper.cpp: Removed.
• khtml/misc/helper.h: Removed.

• kwq/KWQCollection.h: Removed.
• kwq/KWQKCookieJar.h: Removed.
• kwq/KWQKCookieJar.mm: Removed.
• kwq/KWQKLocale.h: Removed.
• kwq/KWQKLocale.mm: Removed.
• kwq/KWQKURL.h: Removed.
• kwq/KWQKURL.mm: Removed.
• kwq/KWQTextUtilities.h: Removed.
• kwq/KWQTextUtilities.mm: Removed.
• kwq/KWQView.h: Removed.

• platform/CookieJar.h: Added.
• platform/Language.h: Added.
• platform/LocalizedStrings.h: Added.
• platform/TextBoundaries.h: Added.
• platform/mac/CookieJar.mm: Added.
• platform/mac/Language.mm: Added.
• platform/mac/LocalizedStringsMac.mm: Added.
• platform/mac/TextBoundaries.mm: Added.
• platform/mac/WebCoreWidgetHolder.h: Added.

• WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
• WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removed and added files.

• bridge/mac/WebCoreFrameBridge.mm: Updated includes. (-[WebCoreFrameBridge elementForView:]): Changed KWQWidgetHolder to WebCoreWidgetHolder.

• editing/visible_units.cpp: (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): Call TextBoundaries.h functions instead of helper.h ones.

• khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
• ksvg2/svg/SVGTestsImpl.cpp: (WebCore::SVGTestsImpl::isValid): Changed to call defaultLanguage; cleaned up formatting.

• khtml/html/HTMLFormElementImpl.cpp: Removed stray comment.

• khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::cookie): (WebCore::HTMLDocumentImpl::setCookie): Call CookieJar.h functions.

• css/css_valueimpl.cpp:
• css/cssparser.cpp:
• css/cssstyleselector.cpp:
• dom/DocumentImpl.cpp:
• dom/dom_position.cpp:
• khtml/ecma/kjs_window.cpp:
• khtml/html/HTMLInputElementImpl.cpp:
• khtml/html/html_headimpl.cpp:
• khtml/html/htmlparser.cpp:
• khtml/misc/decoder.cpp:
• ksvg2/svg/SVGDocumentImpl.cpp:
• kwq/KWQComboBox.mm:
• kwq/KWQKSSLKeyGen.mm:
• kwq/KWQListBox.mm:
• kwq/KWQListImpl.cpp:
• kwq/KWQListImpl.h:
• kwq/KWQScrollBar.mm:
• kwq/KWQSlider.mm:
• kwq/KWQTextField.mm:
• kwq/KWQValueList.h:
• loader/DocLoader.cpp:
• page/Frame.cpp:
• page/FrameView.cpp:
• platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
• rendering/render_applet.cpp:
• rendering/render_form.cpp:
• rendering/render_image.cpp:
• rendering/render_list.cpp: Updated includes and protocol names.

• khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::write): Remove QT_VERSION code.
• platform/QString.h: Remove QT_VERSION.

• kwq/KWQPtrList.h: Change to no longer use QPtrCollection.

• kwq/KWQRenderTreeDebug.h:
• kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove unused debuggingRenderTree boolean.

12:21 AM Changeset in webkit [13186] by eseidel

• 2 edits in trunk/WebCore

2006-03-07 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

• platform/mac/GraphicsContextMac.mm: Add Widget.h to fix no-svg build.

Mar 6, 2006:

11:35 PM Changeset in webkit [13185] by darin

• 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming tweaks.

10:54 PM Changeset in webkit [13184] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: Add some more planned renaming.

6:05 PM Changeset in webkit [13183] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4457574> assertion failure watching trailers at netflix.com -[WebNetscapePluginRepresentation
receivedData:withDataSource:] + 684

• Plugins/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): Moved the ASSERT(instance) to the block that actually requires an assertion -- the plugin view should never have a NULL instance by the time we start the NPStream (by calling -startStreamWithResponse:). Some stream teardown logic changed with my fix to 4153419: when a WebBaseNetscapePluginStream is destroyed, it now clears its NPP instance backpointer. The WebBaseNetscapePluginStream may be destroyed from within -startStreamWithResponse: if NPP_NewStream() returns an error. We can handle this gracefully by changing the assertion before -receivedData: to a simple NULL check. This is unrelated to the Radar, but prior to this fix, we would attempt an NPP_Write() with the initial stream data even if NPP_NewStream() returned an error. Seems like that alone could cause issues, though I'm guessing that plugins handle this in practice.

4:38 PM Changeset in webkit [13182] by eseidel

• 3 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Make spinneret run again, fix webview to support dynamic resize.

• platform/win/TemporaryLinkStubs.cpp: (Widget::setDrawingAlpha):
• platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setClient): (WebCore::Widget::client): (WebCore::Widget::frameGeometry):

3:41 PM Changeset in webkit [13181] by bdakin

• 1 edit
  4 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7566

3:36 PM Changeset in webkit [13180] by eseidel

• 2 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix win32 build.

• platform/win/TemporaryLinkStubs.cpp: (QScrollBar::QScrollBar): (QTextEdit::setAlignment): (Widget::client): (Widget::setClient): (QLineEdit::setAlignment):

3:32 PM Changeset in webkit [13179] by bdakin

• 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7566 (also
<rdar://problem/4467128> ). Must call update() on a Font before
attempting to use it because the FontRenderer is not created until
update() is called.

3:17 PM Changeset in webkit [13178] by eseidel

• 2 edits in trunk/WebKitTools

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint): force layout before painting

3:10 PM Changeset in webkit [13177] by darin

• 3 edits in trunk/WebKitSite

Reviewed by Darin.

Change "Mail.app" to "Mail".

• index.html:
• projects/editing/index.html:

3:09 PM Changeset in webkit [13176] by darin

• 58 edits
  1 add
  11 deletes in trunk/WebCore

Reviewed by Adele.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7564 remove QObject, QGuardedPtr, slots, and signals

I had written a detailed change log entry, but I lost it!
I'm too annoyed to write one all over again.

• ForwardingHeaders/qguardedptr.h: Removed.
• ForwardingHeaders/qobject.h: Removed.

• kwq/KWQGuardedPtr.cpp: Removed.
• kwq/KWQGuardedPtr.h: Removed.
• kwq/KWQNamespace.h: Removed.
• kwq/KWQObject.cpp: Removed.
• kwq/KWQObject.h: Removed.
• kwq/KWQSignal.cpp: Removed.
• kwq/KWQSignal.h: Removed.
• kwq/KWQSlot.cpp: Removed.
• kwq/KWQSlot.h: Removed.

• platform/WidgetClient.h: Added.

• WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
• WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

• bindings/js/JSDOMCore.cpp: Touched.
• bindings/js/JSDOMEvents.cpp: Ditto.

• bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementForView:]):
• dom/CDATASectionImpl.cpp: (WebCore::CDATASectionImpl::cloneNode):
• dom/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl):
• dom/DocumentImpl.h:
• kcanvas/device/KRenderingDevice.h:
• khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
• khtml/ecma/kjs_window.cpp: (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
• khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::createTokenizer):
• khtml/html/htmlparser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::finished):
• khtml/html/htmlparser.h:
• khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::processToken): (WebCore::parseHTMLDocumentFragment):
• khtml/html/htmltokenizer.h:
• kwq/KWQComboBox.h:
• kwq/KWQComboBox.mm: (-[KWQPopUpButton setPopulatingMenu:QComboBox:::]): (QComboBox::itemSelected): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
• kwq/KWQFileButton.h: (KWQFileButton::filename):
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::filenameChanged): (-[KWQFileButtonAdapter filenameChanged:]): (-[KWQFileButtonAdapter focusChanged:]): (-[KWQFileButtonAdapter clicked]):
• kwq/KWQLineEdit.h:
• kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setAlignment): (KWQNSTextAlignment):
• kwq/KWQListBox.h: (QListBox::changingSelection):
• kwq/KWQListBox.mm: (QListBox::QListBox): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView tableViewSelectionDidChange:]):
• kwq/KWQScrollBar.h: (WebCore::): (QScrollBar::orientation):
• kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (QScrollBar::QScrollBar): (QScrollBar::valueChanged): (QScrollBar::scroll):
• kwq/KWQSlider.h:
• kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider slide:]): (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (QSlider::QSlider): (QSlider::sliderValueChanged): (QSlider::dimensions):
• kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textViewDidChangeSelection:]): (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView mouseDown:]): (-[KWQTextAreaTextView dispatchHTMLEvent:]):
• kwq/KWQTextEdit.h:
• kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setAlignment):
• kwq/KWQTextField.mm: (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController textViewDidChangeSelection:]):
• loader/CachedObject.h:
• page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setOpener): (WebCore::Frame::nodeForWidget): (WebCore::Frame::disconnectOwnerRenderer):
• page/Frame.h:
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
• page/FrameView.cpp: (WebCore::FrameView::~FrameView):
• platform/Brush.h:
• platform/Pen.h:
• platform/Widget.cpp: (WebCore::Widget::isFrameView):
• platform/Widget.h: (WebCore::):
• platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawText):
• platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::focusPolicy): (WebCore::Widget::sendConsumedMouseUp): (WebCore::Widget::setClient): (WebCore::Widget::client):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::operator delete):
• rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
• rendering/render_form.cpp: (WebCore::RenderFormElement::clicked): (WebCore::RenderFormElement::textAlignment): (WebCore::RenderLineEdit::RenderLineEdit): (WebCore::RenderLineEdit::selectionChanged): (WebCore::RenderLineEdit::returnPressed): (WebCore::RenderLineEdit::performSearch): (WebCore::RenderLineEdit::valueChanged): (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::returnPressed): (WebCore::RenderFileButton::valueChanged): (WebCore::RenderLegend::RenderLegend): (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::createListBox): (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::valueChanged): (WebCore::RenderTextArea::selectionChanged): (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::valueChanged):
• rendering/render_form.h: (WebCore::RenderFormElement::element): (WebCore::RenderLineEdit::element): (WebCore::RenderFileButton::element): (WebCore::RenderFileButton::isEditable): (WebCore::RenderSelect::element): (WebCore::RenderTextArea::element): (WebCore::RenderSlider::element):
• rendering/render_frames.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart): (WebCore::RenderPart::setFrame): (WebCore::RenderPart::setWidget): (WebCore::RenderPart::deleteWidget): (WebCore::RenderFrame::RenderFrame): (WebCore::RenderPartObject::RenderPartObject): (WebCore::RenderPartObject::layout):
• rendering/render_frames.h:
• rendering/render_layer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::hitTest):
• rendering/render_layer.h: (WebCore::RenderLayer::parent): (WebCore::RenderLayer::previousSibling): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::firstChild): (WebCore::RenderLayer::lastChild):
• rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
• rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::~RenderWidget): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::layout): (WebCore::RenderWidget::sendConsumedMouseUp): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut): (WebCore::RenderWidget::scrollToVisible): (WebCore::RenderWidget::isVisible): (WebCore::RenderWidget::element): (WebCore::RenderWidget::deleteWidget):
• rendering/render_replaced.h:
• xml/xmlhttprequest.cpp: (WebCore::requestsByDocument): (WebCore::addToRequestsByDocument): (WebCore::removeFromRequestsByDocument): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getSpecificHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
• xml/xmlhttprequest.h:

3:05 PM Changeset in webkit [13175] by ggaren

• 2 edits in trunk/WebKitSite

Oops, accidentally deleted the archives links.

• blog/wp-content/themes/webkit/sidebar.php: Bring them back.

3:04 PM Changeset in webkit [13174] by eseidel

• 2 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Reorganize link stubs (alphabetically).
Stub out Path methods to make cnn.com work.

• platform/win/TemporaryLinkStubs.cpp: (FrameView::viewportToGlobal): (FrameView::updateBorder): (FrameView::isFrameView): (FrameView::topLevelWidget): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (ScrollView::scrollXOffset): (QComboBox::focusPolicy): (QTextEdit::QTextEdit): (QTextEdit::~QTextEdit): (QTextEdit::textWithHardLineBreaks): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setColors): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QTextEdit::checksDescendantsForFocus): (QTextEdit::selectionStart): (QTextEdit::hasSelectedText): (QTextEdit::setReadOnly): (QTextEdit::setDisabled): (QTextEdit::setLineHeight): (QTextEdit::setSelectionStart): (QTextEdit::text): (QTextEdit::setWordWrap): (QTextEdit::setAlignment): (QTextEdit::getCursorPosition): (QTextEdit::setSelectionRange): (Widget::enableFlushDrawing): (Widget::isEnabled): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::setIsSelected): (Widget::unlockDrawingFocus): (KJavaAppletWidget::KJavaAppletWidget): (ScrollView::scrollPointRecursively): (ScrollView::scrollBy): (QLineEdit::selectAll): (QLineEdit::addSearchResult): (QLineEdit::selectionStart): (QLineEdit::hasSelectedText): (QLineEdit::selectedText): (QLineEdit::setAutoSaveName): (QLineEdit::checksDescendantsForFocus): (QLineEdit::setMaxResults): (GraphicsContext::GraphicsContext): (GraphicsContext::addFocusRingRect): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::drawFocusRing): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::drawHighlightForText): (GraphicsContext::misspellingLineThickness): (GraphicsContext::addRoundedRectClip): (QSlider::QSlider): (QSlider::sizeHint): (QSlider::setValue): (QSlider::setMaxValue): (QSlider::~QSlider): (QSlider::setFont): (QListBox::setFont): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setEnabled): (QListBox::clear): (QListBox::checksDescendantsForFocus): (KWQFileButton::KWQFileButton): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFilename): (KWQFileButton::baselinePosition): (KWQFileButton::setFrameGeometry): (QSlider::focusPolicy): (QListBox::focusPolicy): (Cursor::Cursor): (MouseEvent::MouseEvent): (KWQKCookieJar::cookieEnabled): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::createPlugin): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::inWindow): (Path::~Path): (Path::Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=):

2:57 PM Changeset in webkit [13173] by ggaren

• 3 edits in trunk/WebKitSite

Reviewed by Beth.

Some site cleanup.

• blog/wp-content/themes/webkit/sidebar.php: sync with the sidebar for the rest of the site.
• quality/lifecycle.html: add Joost's homepage to his contact info.

2:39 PM Changeset in webkit [13172] by ggaren

• 2 edits in trunk/WebKitSite

Doing penance after being set straight by Joost.

• projects/compat/hitlist.html: Remove slur against QA. My humblest apologies.

2:33 PM Changeset in webkit [13171] by ggaren

• 3 edits
  1 add in trunk/WebKitSite

Reviewed by Maciej, Darin.

Added Safari Compatibility Hit List.

• nav.inc: Link to the hit list.
• projects/compat/hitlist.html: Added.
• projects/compat/index.html: Link to the hit list.

11:59 AM Changeset in webkit [13170] by ap

• 2 edits
  3 copies in trunk/JavaScriptCore

Patch by David Carson, reviewed by Darin.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7582 c_utility.cpp contains CFString OS X platform-dependent code; should use ICU

Tested with test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

• bindings/c_utility.cpp (convertUTF8ToUTF16): Changed to using Unicode converter from ICU, and manual Latin-1 conversion.
• icu/unicode/ucnv.h: Copied from WebCore.
• icu/unicode/ucnv_err.h: Ditto.
• icu/unicode/uenum.h: Ditto.

11:43 AM Changeset in webkit [13169] by justing

• 6 edits
  4 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

• fast/lists/drag-into-marker-expected.checksum: Added.
• fast/lists/drag-into-marker-expected.png: Added.
• fast/lists/drag-into-marker-expected.txt: Added.
• fast/lists/drag-into-marker.html: Added.

WebCore:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

Call RenderObject::setInnerNode(), which sets both the
innerNode and the innerNonSharedNode.

• rendering/render_list.cpp: (WebCore::RenderListItem::nodeAtPoint):
• rendering/render_list.h:

WebKitTools:

Reviewed by darin

Sent the windowNumber when sending events.
Added leapForward so that we don't have to spend time waiting
in layout tests that do mouse operations that require delays.

• DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController currentEventTime]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):

9:11 AM Changeset in webkit [13168] by darin

• 2 edits in trunk/WebCore

• WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted files from the kwq directory.

8:50 AM Changeset in webkit [13167] by darin

• 147 edits
  2 adds
  2 deletes in trunk/WebCore

Reviewed by Maciej.

• moved all the remnants of the public C++ DOM API out of khtml/dom
• changed from "int" to "ExceptionCode" for DOM exceptions
• removed unused CSS_HTML_RELATIVE
• changed offsetInCharacters to be a member function of NodeImpl
• changed DOM functions that take a NodeType to use NodeType instead of unsigned short for clarity (will still be unsigned short in bindings)
• changed exception constants so they can be used directly in the implementation code (added in the offsets for different types of exceptions)
• replaced the eventListenerType function with an isHTMLEventListener function
• got rid of EventListenerEvent, which is a synonym for EventImpl*
• eliminated handleEventImpl, whish is now the same as handleEvent

• did other preparation for the "remove Impl suffix" renaming (tested by using a script that does the renaming)

• khtml/dom/css_rule.h: Removed.
• khtml/dom/css_stylesheet.h: Removed.
• khtml/dom/css_value.h: Removed.
• khtml/dom/dom2_events.cpp: Removed.
• khtml/dom/dom2_events.h: Removed.
• khtml/dom/dom2_range.h: Removed.
• khtml/dom/dom2_traversal.cpp: Removed.
• khtml/dom/dom2_traversal.h: Removed.
• khtml/dom/dom_exception.h: Removed.
• khtml/dom/dom_node.h: Removed.

• dom/EventListener.h: Added.
• dom/ExceptionCode.h: Added.

• WebCore+SVG/kdom.h: Removed NodeType and ExceptionCodes
• WebCore+SVG/kdomevents.h: Removed.

• WebCore.xcodeproj/project.pbxproj: Updated for file changes.
• WebCore.xcodeproj/project.pbxproj: Updated for file changes.

• bindings/scripts/CodeGeneratorJS.pm: Removed unneeded DOM:: prefix. Updated file names and exception prefix for changes in DOM exceptions.

• bindings/js/JSDOMCore.cpp: Touched to cause auto-generated code to be recompiled. We need to get this fixed!
• bindings/js/JSDOMEvents.cpp: Ditto.

• dom/Attr.idl:
• dom/CharacterData.idl:
• dom/DOMImplementation.idl:
• dom/DocumentType.idl:
• dom/Element.idl:
• dom/Entity.idl:
• dom/MutationEvent.idl:
• dom/Notation.idl:
• dom/ProcessingInstruction.idl:
• dom/Text.idl:
• dom/WheelEvent.idl: Touched all IDL files so that changes in CodeGeneratorJS.pm would take effect. Added license headers.

• bindings/objc/DOM.mm: Fixed garbled license agreement. Updated includes. Changed from a single "using namespace WebCore" to individual using statements because of the imminent conflict between DOMImplementation in Objective C and WebCore::DOMImplementation (currently has an Impl suffix). Added a typedef for WebCore::DOMImplementationImpl. Changed to use ExceptionCode instead of int.

• bindings/objc/DOMCSS.h: Removed DOMCSSException and the special CSS exception codes. This is a feature of DOM Level 1 only. In DOM Level 2 these were eliminated and use basic DOM exception codes instead. We might have to do something for binary compatibility eventually, but perhaps not.

• bindings/objc/DOMCSS.mm:
• bindings/objc/DOMEvents.mm:
• bindings/objc/DOMEventsInternal.h:
• bindings/objc/DOMHTML.mm:
• bindings/objc/DOMHTMLInternal.h:
• bindings/objc/DOMViews.mm:
• bindings/objc/DOMViewsInternal.h: Fixed garbled license agreements. Changed to use ExceptionCode instead of int and name the variable "ec".

• bindings/objc/DOMInternal.h: Changed addDOMWrapperImpl to take NSObject* instead of id. This helps with overload resolution when addDOMWrapperImpl is renamed to be addDOMWrapper. Changed ALLOW_DOM_CAST to always use "class" in from of the type name of the WebCore class. This helps work around what seems like a bug in namespace support in Objective-C mode, although the bug only happens after the "remove Impl" renaming.
• bindings/objc/DOMInternal.mm: (getDOMWrapperImpl): Changed to use HashMap. (addDOMWrapperImpl): Ditto. (removeDOMWrapper): Ditto. (raiseDOMException): Update to use new names for exception number ranges.

• bridge/mac/WebCoreFrameBridge.mm:
• khtml/ecma/xmlserializer.cpp:
• kwq/KWQAccObject.mm: Removed unneeded includes.

• css/css_ruleimpl.h: Moved "rule type" into this header.

• dom/CommentImpl.h:
• dom/CommentImpl.cpp: (WebCore::CommentImpl::offsetInCharacters): Added. Returns true.

• khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): Changed this around so we don't have a local variable named docImpl.

• khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Updated for new form of exception constants.

• khtml/ecma/kjs_events.h:
• khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Changed to no longer use EventListenerEvent. (KJS::JSAbstractEventListener::isHTMLEventListener): Added.

• rendering/RenderTextField.h: Updated includes. Tweaked the code formatting of InputMutationListener. (Might be unnecessary since this class might be deleted soon.)

• bridge/mac/MacFrame.mm:
• css/css_computedstyle.cpp:
• css/css_computedstyle.h:
• css/css_ruleimpl.cpp:
• css/css_stylesheetimpl.cpp:
• css/css_stylesheetimpl.h:
• css/css_valueimpl.cpp:
• css/css_valueimpl.cpp:
• css/css_valueimpl.h:
• css/css_valueimpl.h:
• css/cssparser.cpp:
• css/cssstyleselector.cpp:
• dom/CDATASectionImpl.cpp:
• dom/CDATASectionImpl.h:
• dom/CharacterDataImpl.cpp:
• dom/CharacterDataImpl.h:
• dom/ContainerNodeImpl.cpp:
• dom/DOMImplementationImpl.cpp:
• dom/DocumentFragmentImpl.cpp:
• dom/DocumentFragmentImpl.h:
• dom/DocumentImpl.cpp:
• dom/DocumentImpl.h:
• dom/DocumentTypeImpl.cpp:
• dom/DocumentTypeImpl.h:
• dom/NamedNodeMapImpl.h:
• dom/NodeImpl.cpp:
• dom/NodeImpl.h:
• dom/NodeListImpl.cpp:
• dom/TextImpl.cpp:
• dom/TextImpl.h:
• dom/dom2_eventsimpl.cpp:
• dom/dom2_eventsimpl.h:
• dom/dom2_rangeimpl.cpp:
• dom/dom2_rangeimpl.h:
• dom/dom2_traversalimpl.cpp:
• dom/dom2_traversalimpl.h:
• dom/dom_elementimpl.cpp:
• dom/dom_elementimpl.h:
• dom/dom_position.cpp:
• dom/dom_xmlimpl.cpp:
• dom/dom_xmlimpl.h:
• dom/xml_tokenizer.cpp:
• editing/AppendNodeCommand.cpp:
• editing/ApplyStyleCommand.cpp:
• editing/CompositeEditCommand.cpp:
• editing/DeleteFromTextNodeCommand.cpp:
• editing/InsertIntoTextNodeCommand.cpp:
• editing/InsertLineBreakCommand.cpp:
• editing/InsertNodeBeforeCommand.cpp:
• editing/InsertParagraphSeparatorCommand.cpp:
• editing/JoinTextNodesCommand.cpp:
• editing/MergeIdenticalElementsCommand.cpp:
• editing/RemoveNodeAttributeCommand.cpp:
• editing/RemoveNodeCommand.cpp:
• editing/ReplaceSelectionCommand.cpp:
• editing/Selection.cpp:
• editing/SelectionController.cpp:
• editing/SelectionController.h:
• editing/SetNodeAttributeCommand.cpp:
• editing/SplitElementCommand.cpp:
• editing/SplitTextNodeCommand.cpp:
• editing/VisiblePosition.cpp:
• editing/WrapContentsInDummySpanCommand.cpp:
• editing/htmlediting.cpp:
• editing/markup.cpp:
• editing/visible_text.cpp:
• khtml/ecma/kjs_binding.h:
• khtml/ecma/kjs_css.cpp:
• khtml/ecma/kjs_dom.cpp:
• khtml/ecma/kjs_html.cpp:
• khtml/ecma/kjs_range.cpp:
• khtml/ecma/kjs_traversal.cpp:
• khtml/ecma/kjs_traversal.h:
• khtml/ecma/kjs_window.cpp:
• khtml/html/HTMLElementImpl.cpp:
• khtml/html/HTMLOptionElementImpl.cpp:
• khtml/html/HTMLOptionElementImpl.h:
• khtml/html/HTMLOptionsCollectionImpl.cpp:
• khtml/html/HTMLSelectElementImpl.cpp:
• khtml/html/HTMLTextAreaElementImpl.cpp:
• khtml/html/html_documentimpl.cpp:
• khtml/html/html_documentimpl.h:
• khtml/html/html_headimpl.cpp:
• khtml/html/html_tableimpl.cpp:
• khtml/html/html_tableimpl.h:
• khtml/html/htmlparser.cpp:
• khtml/xbl/xbl_tokenizer.cpp:
• khtml/xsl/xsl_stylesheetimpl.cpp:
• ksvg2/misc/SVGDocumentExtensions.cpp:
• ksvg2/svg/SVGAnimationElementImpl.cpp:
• ksvg2/svg/SVGDOMImplementationImpl.cpp:
• ksvg2/svg/SVGDOMImplementationImpl.h:
• ksvg2/svg/SVGDocumentImpl.cpp:
• ksvg2/svg/SVGDocumentImpl.h:
• ksvg2/svg/SVGElementImpl.cpp:
• ksvg2/svg/SVGLengthImpl.cpp:
• ksvg2/svg/SVGLocatableImpl.cpp:
• ksvg2/svg/SVGPolyElementImpl.cpp:
• ksvg2/svg/SVGSVGElementImpl.cpp:
• ksvg2/svg/SVGStyleElementImpl.cpp:
• ksvg2/svg/SVGStyleElementImpl.h:
• ksvg2/svg/SVGUseElementImpl.cpp:
• page/Frame.cpp:
• page/FrameView.cpp:
• rendering/render_object.cpp:
• xml/xmlhttprequest.cpp: Changed to use ExceptionCode instead of int and name the variable "ec". Also updated use of exception codes and other constants to get them from their new locations.

2:12 AM Changeset in webkit [13166] by eseidel

• 3 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix more pages (apple.com, yahoo.com) by returning empty error image.
Empty a couple more stubs and clean up stub style a little.

• platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
• platform/win/TemporaryLinkStubs.cpp: (QListBox::isSelected): (QSlider::sizeHint): (QScrollBar::~QScrollBar): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::recordFormValue): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::passWheelEventToChildWidget): (FrameWin::createPlugin): (BrowserExtensionWin::createNewWindow): (Path::Path): (QLineEdit::~QLineEdit): (QLineEdit::setLiveSearch): (QComboBox::~QComboBox):

1:15 AM Changeset in webkit [13165] by eseidel

• 2 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Empty enough stubs to make apple.com load.

• platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (GraphicsContext::misspellingLineThickness): (QTextEdit::selectAll): (QTextEdit::setSelectionStart): (Widget::unlockDrawingFocus): (QLineEdit::setAutoSaveName): (ScrollView::scrollYOffset): (KWQFileButton::setFilename): (QListBox::setFont): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (QComboBox::QComboBox): (QComboBox::setFont): (QComboBox::baselinePosition): (QComboBox::setWritingDirection): (QComboBox::clear): (QComboBox::appendItem): (QComboBox::setCurrentItem): (QComboBox::sizeHint): (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QLineEdit::setLiveSearch):

12:39 AM Changeset in webkit [13164] by eseidel

• 3 edits in trunk/WebCore

2006-03-06 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix external resource loading.
Make a bunch of stubs not abort (to fix slashdot).

• platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (KWQFileButton::click): (QComboBox::setFrameGeometry): (QTextEdit::setText): (QListBox::appendItem): (GraphicsContext::endTransparencyLayer): (QLineEdit::selectionStart): (QTextEdit::QTextEdit): (QListBox::isSelected): (QComboBox::focusPolicy): (QTextEdit::setCursorPosition): (QTextEdit::setAlignment): (QLineEdit::selectedText): (ScrollView::scrollPointRecursively): (QScrollBar::setSteps): (QComboBox::appendItem): (GraphicsContext::drawLineForMisspelling): (KWQFileButton::setFilename): (QListBox::setWritingDirection): (QListBox::focusPolicy): (MouseEvent::MouseEvent): (QSlider::setFont): (Widget::setEnabled): (Widget::paint): (ScrollView::addChild): (ScrollView::inWindow): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField): (QLineEdit::QLineEdit): (QLineEdit::setFont): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (QLineEdit::maxLength): (QLineEdit::setMaxLength): (QLineEdit::text): (QLineEdit::setText): (QLineEdit::cursorPosition): (QLineEdit::setCursorPosition): (QLineEdit::setEdited): (QLineEdit::setReadOnly): (QLineEdit::setPlaceholderString): (QLineEdit::setColors): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
• platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):