Context Navigation

← Previous Period
Next Period →

Timeline

Mar 20, 2006:

11:57 PM Changeset in webkit [13418] by justing

1 edit
2 adds in trunk/LayoutTests

Reviewed by vicki

Testcase for fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7363>
REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

fast/forms/textfield-focus-out-expected.txt: Added.
fast/forms/textfield-focus-out.html: Added.

11:56 PM Changeset in webkit [13417] by mjs

2 edits in trunk/WebCore

touch this file in hopes of fixing build

bindings/js/JSDOMCore.cpp:

11:12 PM Changeset in webkit [13416] by mjs

1 edit in trunk/LayoutTests/ChangeLog

fix accidentally reversed changelog entries

11:08 PM Changeset in webkit [13415] by mjs

7 edits
5 adds in trunk

LayoutTests:

Reviewed by mjs.

Test for: <rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

fast/tokenizer/external-script-document-open-expected.txt: Added.
fast/tokenizer/external-script-document-open.html: Added.
fast/tokenizer/resources/external-script-document-open.js: Added.
fast/tokenizer/resources/write-external-script-open.js: Added.
fast/tokenizer/write-external-script-open-expected.txt: Added.
fast/tokenizer/write-external-script-open.html: Added.
fast/tokenizer/write-inline-script-open-expected.txt: Added.
fast/tokenizer/write-inline-script-open.html: Added.

WebCore:

Reviewed by Anders.

fixed <rdar://problem/4446749> 10.4.4: safari crash in DOM::NamedAttrMapImpl::setNamedItem

bindings/scripts/CodeGeneratorJS.pm: Add a framework for typechecking method arguments. For now only use it for parameters of type Attr.
dom/Element.idl: Arbitrary change to make it regenerate.
dom/dom_elementimpl.cpp: (WebCore::Element::setAttributeNode): ASSERT that attr is not null
khtml/ecma/kjs_dom.cpp: (KJS::toAttr): add bool ok parameter
khtml/ecma/kjs_dom.h:

11:02 PM Changeset in webkit [13414] by eseidel

1 edit
1 delete in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

ksvg2/css/SVGCSSParser.h: Removed unused file.

10:46 PM Changeset in webkit [13413] by eseidel

7 edits
8 adds in trunk

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix tokenizer crash when document.open() is called from an external script:
<rdar://problem/4483882> REGRESSION (417.8-TOT): crash at yourmovies.com.au in WebCore::HTMLTokenizer::reset() + 92 (7818)

dom/Document.cpp: (WebCore::Document::open): Check to make sure the current tokenizer isn't executing a script
dom/xml_tokenizer.h: (WebCore::Tokenizer::executingScript): Add a way for others to know if scripts are executing.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): Wire into existing m_executingScript member var.
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::executingScript):
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): Unrelated code cleanup.

10:22 PM Changeset in webkit [13412] by justing

4 edits in trunk/WebCore

Reviewed by darin

<rdar://problem/3997958>
REGRESSION (Mail): Mail takes half of forever to paste >1500 lines - replaceSelectionWithNode

dom/Position.cpp: (WebCore::Position::upstream): Avoid calling previous() when we know that it will 1) end the search and 2) be expensive to compute. (WebCore::Position::downstream): Removed some dead code. (WebCore::Position::inRenderedText): Return false for offsets inside composed characters.
dom/Position.h:
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): If there are two visually equivalent candidates, we choose the one that occurs first in document order. Using upstream() to find the one that occurs first is much faster than the old code.

9:52 PM Changeset in webkit [13411] by mjs

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test case for <rdar://problem/4362396> REGRESSION: (417-420) stopPropagation is not working for click event listener (onclick works fine)

Make sure that capturing event listeners trigger on the target and that if they
stopPropagation, then bubbling listeners on ancestors do not trigger.

fast/events/capture-on-target-expected.txt: Added.
fast/events/capture-on-target.html: Added.

WebCore:

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.

<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):

8:23 PM Changeset in webkit [13410] by eseidel

4 edits in trunk

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by adele & ggaren.

Added new cachePluginDataIfNecessary function to update
plugins and mimes arrays. Made sure to call this in
constructor as well as refresh. The crash was caused by
a refresh rendering a "plugins" object invalid.
Changed existing test case to depend on this new correct behavior.

<rdar://problem/4480571> Safari crashed at exit at KXMLCore::deleteAllValues + 24

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::cachePluginDataIfNecessary): (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh):

7:52 PM Changeset in webkit [13409] by adele

2 edits in trunk/WebCore

Reviewed by Justin.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): When calculating the VisiblePosition for the first position in the text field, it makes more sense for the position to have a downstream affinity.

5:54 PM Changeset in webkit [13408] by eseidel

1 edit
1 move
1 add in trunk/LayoutTests

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Re-enable previously failing test.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Added.
dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Removed.

5:46 PM Changeset in webkit [13407] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4458568> WebCore should not disclose https referrers

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canLoadURL:fromReferrer:hideReferrer:]): Don't send https URLs as referrers to non-secure http sites.

5:29 PM Changeset in webkit [13406] by tomernic

4 edits in trunk/WebKit

Reviewed by John Sullivan.

Moved -_contentView from WebFrameViewInternal to WebFrameViewPrivate. Safari
needs this.

WebView/WebFrameView.m: (-[WebFrameView _contentView]):
WebView/WebFrameViewInternal.h:
WebView/WebFrameViewPrivate.h:

5:15 PM Changeset in webkit [13405] by darin

84 edits
1 move
1 add in trunk/WebCore

Reviewed by Geoff.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7867 get rid of macro hacks for DOM, KDOM, KSVG, khtml, DOMString, QString

config.h: Remove the defines for DOM, KDOM, KSVG, khtml, DOMString, QString, and qstring().

WebCore.xcodeproj/project.pbxproj: Pass in WebCore instead of KSVG as the namespace for SVG names.
ksvg2/scripts/make_names.pl: Made a couple changes to trick the SVG names into recompiling, since they are in a different namespace now.

ForwardingHeaders/kjs/identifier.h: Added.

dom/PlatformWheelEvent.idl: Removed.
dom/WheelEvent.idl: Added. This file was renamed by accident.

bindings/js/JSDOMCore.cpp:
bindings/js/JSDOMEvents.cpp:
bindings/js/JSDOMHTML.cpp:
dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
html/CanvasGradient.idl:
html/CanvasPattern.idl:
html/CanvasRenderingContext2D.idl: Touched, to get CodeGeneratorJS.pm changes to take effect.

css/CSSGrammar.y:
css/css_valueimpl.cpp: (WebCore::propertyID):

Changed calls to get CSS property values to use an explicit SVG: namespace, to match what the script writes out.

khtml/ecma/kjs_binding.h: Added forward declaration of WebCore::String.

ksvg2/scripts/cssmakeget rid of macro hacks for DOM, KDOM, KSVG, khtml, DOMString, QString props: Made this compile with warnings and strict turned on. Really just a trick to get properties to recompile, which turned out to be unneeded.
ksvg2/scripts/cssmakevalues: Ditto.

ksvg2/svg/SVGAElement.cpp: (SVGAElement::parseMappedAttribute): (SVGAElement::defaultEventHandler):
ksvg2/svg/SVGAnimateTransformElement.cpp: (SVGAnimateTransformElement::parseMappedAttribute):
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::parseMappedAttribute):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
ksvg2/svg/SVGExternalResourcesRequired.cpp: (SVGExternalResourcesRequired::parseMappedAttribute):
ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::parseMappedAttribute):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::parseMappedAttribute):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::parseMappedAttribute):
ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::parseMappedAttribute):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::stringToChannel): (SVGFEDisplacementMapElement::parseMappedAttribute): (SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.h:
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::parseMappedAttribute):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::parseMappedAttribute):
ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
ksvg2/svg/SVGFEMergeNodeElement.cpp: (SVGFEMergeNodeElement::parseMappedAttribute):
ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::parseMappedAttribute):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::parseMappedAttribute):
ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::parseMappedAttribute):
ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::parseMappedAttribute):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::parseMappedAttribute):
ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::parseMappedAttribute):
ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::parseMappedAttribute):
ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::parseMappedAttribute):
ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::parseMappedAttribute):
ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::parseMappedAttribute):
ksvg2/svg/SVGViewElement.cpp: (SVGViewElement::parseMappedAttribute):
ksvg2/svg/SVGZoomAndPan.cpp: (SVGZoomAndPan::parseMappedAttribute): Changed code that converts an AtomicString to a String to do it in a more-efficient fashion that works even with all the new conversions.

page/Frame.cpp: (WebCore::getString): Removed unneeded .deprecatedString(). (WebCore::Frame::begin): Removed the only use of QSTRING_NULL.

platform/AtomicString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/AtomicString.cpp: (WebCore::AtomicString::add): Added overloads for Identifier and UString. (WebCore::AtomicString::operator Identifier): Added. (WebCore::AtomicString::operator UString): Added.

platform/DeprecatedString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/DeprecatedString.cpp: (DeprecatedString::DeprecatedString): Added overloads for Identifier and UString. (DeprecatedString::operator Identifier): Added. (DeprecatedString::operator UString): Added.

platform/PlatformString.h: Added conversion to and from KJS::Identifier and KJS::UString.
platform/String.cpp: (WebCore::String::String): Added overloads for Identifier and UString. (WebCore::String::operator Identifier): Added. (WebCore::String::operator UString): Added.

platform/StringImpl.h: Added constructors that take KJS::Identifier and KJS::UString
platform/StringImpl.cpp: (WebCore::getWordBreakIterator): Changed a use of UChar to say ::UChar instead because of ambiguity with KJS::UChar. (WebCore::StringImpl::StringImpl): Added overloads for Identifier and String.

bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): (WebCore::toHTMLCanvasStyle):
bindings/scripts/CodeGeneratorJS.pm:
bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
dom/QualifiedName.cpp: (WebCore::QualifiedName::toString):
khtml/ecma/JSDOMParser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
khtml/ecma/kjs_binding.cpp: (KJS::valueToStringWithNullCheck):
khtml/ecma/kjs_css.cpp: (KJS::cssPropertyName): (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMStyleSheetList::getOwnPropertySlot): (KJS::DOMMediaList::put): (KJS::KJS::DOMMediaListProtoFunc::callAsFunction): (KJS::DOMCSSStyleSheetProtoFunc::callAsFunction): (KJS::DOMCSSRule::putValueProperty): (KJS::DOMCSSRuleFunc::callAsFunction): (KJS::DOMCSSValue::put): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::putValueProperty): (KJS::DOMNode::toString): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::getOwnPropertySlot): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::attributeGetter): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEventProtoFunc::callAsFunction): (KJS::DOMUIEventProtoFunc::callAsFunction): (KJS::DOMMouseEventProtoFunc::callAsFunction): (KJS::DOMKeyboardEventProtoFunc::callAsFunction): (KJS::Clipboard::putValueProperty): (KJS::ClipboardProtoFunc::callAsFunction):
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::putValueProperty): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::OptionConstructorImp::construct):
khtml/ecma/kjs_navigator.cpp: (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
khtml/ecma/kjs_range.cpp: (KJS::DOMRangeProtoFunc::callAsFunction):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): (KJS::showModalDialog): (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Window::installTimeout): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction): Removed explicit calls to domString(), sometimes replacing with explicit calls to the String() constructor. Other similar changes for AtomicString and DeprecatedString use.

3:25 PM Changeset in webkit [13404] by eseidel

78 edits in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove many, many uses of DeprecatedString.
Fix various style issues throughout the touched code.

bindings/objc/DOM.mm: (-[DOMRange _text]):
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.h: (WebCore::FrameMac::bridge): (WebCore::FrameMac::markedTextRange): (WebCore::Mac):
bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::matchLabelsAgainstElement): (WebCore::FrameMac::findString): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::objectContentType): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::setTitle): (WebCore::FrameMac::setStatusBarText): (WebCore::FrameMac::advanceToNextMisspelling): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::mimeTypeForFileName): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::incomingReferrer): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::overrideMediaType): (WebCore::FrameMac::shouldClose):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge selectedString]): (-[WebCoreFrameBridge stringForRange:]): (-[WebCoreFrameBridge advanceToNextMisspelling]): (-[WebCoreFrameBridge advanceToNextMisspellingStartingJustBeforeSelection]): (-[WebCoreFrameBridge domain]):
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setFixedFontFamily:]): (-[WebCoreSettings setSerifFontFamily:]): (-[WebCoreSettings setSansSerifFontFamily:]): (-[WebCoreSettings setCursiveFontFamily:]): (-[WebCoreSettings setFantasyFontFamily:]): (-[WebCoreSettings setUserStyleSheetLocation:]): (-[WebCoreSettings setDefaultTextEncoding:]):
css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::setEncodedURL): (WebCore::cleanpath): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::convertToLength): (WebCore::colorForCSSValue): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
css/cssstyleselector.h:
dom/CDATASection.cpp: (WebCore::CDATASection::toString):
dom/Document.cpp: (WebCore::Document::recalcStyle):
dom/Document.h: (WebCore::Document::baseTarget): (WebCore::Document::setBaseTarget):
dom/dom_elementimpl.cpp: (WebCore::Element::openTagStartToString):
dom/xml_tokenizer.cpp: (WebCore::handleElementAttributes): (WebCore::XMLTokenizer::startElementNs):
editing/SelectionController.cpp: (WebCore::SelectionController::type):
editing/TextIterator.cpp: (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::CharacterIterator::advance): (WebCore::WordAwareIterator::advance): (WebCore::WordAwareIterator::length): (WebCore::WordAwareIterator::characters): (WebCore::CircularSearchBuffer::CircularSearchBuffer): (WebCore::CircularSearchBuffer::append): (WebCore::TextIterator::rangeFromLocationAndLength): (WebCore::findPlainText):
editing/TextIterator.h:
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
khtml/ecma/kjs_window.cpp: (KJS::Location::getValueProperty):
ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
ksvg2/svg/SVGAngle.cpp: (SVGAngle::calculate): (SVGAngle::setValueAsString): (SVGAngle::valueAsString): (SVGAngle::convertToSpecifiedUnits): (SVGAngle::shortestArcBisector):
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::targetElement): (SVGAnimationElement::parseMappedAttribute): (SVGAnimationElement::parseClockValue): (SVGAnimationElement::targetAttribute): (SVGAnimationElement::setTargetAttribute): (SVGAnimationElement::detectAnimationMode): (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
ksvg2/svg/SVGColor.cpp: (SVGColor::setRGBColor):
ksvg2/svg/SVGDOMImplementation.cpp: (svgFeatureSet): (SVGDOMImplementation::self): (SVGDOMImplementation::hasFeature): (SVGDOMImplementation::createDocumentType): (SVGDOMImplementation::createDocument):
ksvg2/svg/SVGDOMImplementation.h:
ksvg2/svg/SVGPaint.cpp: (SVGPaint::cssText):
ksvg2/svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::toString):
ksvg2/svg/SVGPreserveAspectRatio.cpp: (SVGPreserveAspectRatio::parsePreserveAspectRatio): (SVGPreserveAspectRatio::getCTM):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
ksvg2/svg/SVGURIReference.cpp: (SVGURIReference::getTarget):
kwq/ClipboardMac.mm: (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setEffectAllowed): (WebCore::cocoaOpFromIEOp): (WebCore::IEOpFromCocoaOp): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
kwq/KWQCString.cpp: (DeprecatedCString::append):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::stdFontName): (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName): (KHTMLSettings::sansSerifFontName): (KHTMLSettings::cursiveFontName): (KHTMLSettings::fantasyFontName): (KHTMLSettings::minFontSize): (KHTMLSettings::minLogicalFontSize): (KHTMLSettings::mediumFontSize): (KHTMLSettings::mediumFixedFontSize): (KHTMLSettings::autoLoadImages): (KHTMLSettings::isJavaScriptEnabled): (KHTMLSettings::JavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::isJavaEnabled): (KHTMLSettings::isPluginsEnabled): (KHTMLSettings::encoding): (KHTMLSettings::userStyleSheet): (KHTMLSettings::shouldPrintBackgrounds): (KHTMLSettings::textAreasAreResizable): (KHTMLSettings::setStdFontName): (KHTMLSettings::setFixedFontName): (KHTMLSettings::setSerifFontName): (KHTMLSettings::setSansSerifFontName): (KHTMLSettings::setCursiveFontName): (KHTMLSettings::setFantasyFontName): (KHTMLSettings::setMinFontSize): (KHTMLSettings::setMinLogicalFontSize): (KHTMLSettings::setMediumFontSize): (KHTMLSettings::setMediumFixedFontSize): (KHTMLSettings::setAutoLoadImages): (KHTMLSettings::setIsJavaScriptEnabled): (KHTMLSettings::setIsJavaEnabled): (KHTMLSettings::setArePluginsEnabled): (KHTMLSettings::setJavaScriptCanOpenWindowsAutomatically): (KHTMLSettings::setEncoding): (KHTMLSettings::setUserStyleSheet): (KHTMLSettings::setShouldPrintBackgrounds): (KHTMLSettings::setTextAreasAreResizable):
kwq/KWQLoader.mm: (KWQServeSynchronousRequest):
kwq/KWQTextStream.cpp: (QTextStream::QTextStream): (QTextStream::operator<<): (QTextStream::precision):
kwq/KWQTextStream.h:
kwq/RenderTreeAsText.cpp: (operator<<): (quoteAndEscapeNonPrintables): (writeTextRun): (write): (writeSelection):
loader/Cache.cpp: (WebCore::Cache::init): (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::preloadStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::preloadScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::error):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::error):
loader/CachedImage.h:
loader/CachedObject.h:
loader/CachedScript.cpp: (WebCore::CachedScript::checkNotify): (WebCore::CachedScript::error):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::error):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::error):
loader/CachedXSLStyleSheet.h:
loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::needReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::setAutoloadImages): (WebCore::DocLoader::setShowAnimations): (WebCore::DocLoader::removeCachedObject):
loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::didOpenURL): (WebCore::Frame::setMetaRefreshEnabled): (WebCore::Frame::setAutoloadImages): (WebCore::Frame::autoloadImages): (WebCore::Frame::clear): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::write): (WebCore::Frame::baseTarget): (WebCore::Frame::completeURL): (WebCore::Frame::scheduleRedirection): (WebCore::Frame::scheduleLocationChange): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::changeLocation): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::encoding): (WebCore::Frame::gotoAnchor): (WebCore::Frame::setStandardFont): (WebCore::Frame::setFixedFont): (WebCore::Frame::selectedText): (WebCore::Frame::selection): (WebCore::Frame::dragCaret): (WebCore::Frame::setSelection): (WebCore::Frame::setDragCaret): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::shouldUsePlugin): (WebCore::Frame::loadPlugin): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitForm): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): (WebCore::Frame::executeScript): (WebCore::updateState): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::openURL): (WebCore::Frame::didNotOpenURL): (WebCore::Frame::setEncoding): (WebCore::Frame::saveInterpreterBuiltins): (WebCore::Frame::restoreInterpreterBuiltins): (WebCore::Frame::mutableInstances): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::addMetaData): (WebCore::Frame::scrollToAnchor): (WebCore::Frame::setMediaType): (WebCore::Frame::highlightAllMatchesForString): (WebCore::Frame::tree):
page/Frame.h: (WebCore::Frame::instances):
page/FramePrivate.h:
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::init): (WebCore::FrameView::setMarginWidth): (WebCore::FrameView::setMarginHeight): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::layout): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::scrollTo): (WebCore::FrameView::setMediaType): (WebCore::FrameView::mediaType): (WebCore::FrameView::setResizingFrameSet): (WebCore::FrameView::setIgnoreWheelEvents):
page/FrameView.h: (WebCore::FrameView::frameWidth): (WebCore::FrameView::marginWidth): (WebCore::FrameView::marginHeight): (WebCore::FrameView::ref): (WebCore::FrameView::deref):
page/ResourceRequest.h: (WebCore::ResourceRequest::contentType): (WebCore::ResourceRequest::setContentType):
platform/FontFamily.h:
platform/Image.h:
platform/KURL.cpp: (KURL::KURL): (KURL::parse): (urlcmp): (KURL::encode_string): (encodeHostname):
platform/KURL.h:
platform/PlatformString.h: (WebCore::String::left): (WebCore::String::right):
platform/String.cpp: (WebCore::String::toInt):
platform/StringImpl.cpp: (WebCore::StringImpl::toInt):
platform/TransferJob.cpp: (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
platform/TransferJob.h:
platform/mac/ImageMac.mm: (WebCore::Image::supportsType):
platform/mac/TransferJobMac.mm: (WebCore::TransferJob::start):
rendering/RenderObject.cpp: (WebCore::RenderObject::information):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement):
xml/xmlhttprequest.cpp: (WebCore::getMIMEType): (WebCore::getCharset): (WebCore::XMLHttpRequest::getReadyState): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::changeState): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
xml/xmlhttprequest.h:

1:27 PM Changeset in webkit [13403] by bdakin

5 edits in trunk/LayoutTests

Reviewed by Adele

I added a close comment tag to this layout test so that the layout
would not longer be affected by the unclosed <style> tag bug since
that is not the original aim of this test anyway.

12:46 PM Changeset in webkit [13402] by ap

7 edits
4 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3439 mouseover effects can get stuck sometimes due to missing events
http://bugzilla.opendarwin.org/show_bug.cgi?id=7701 mouseout sent to the wrong element when layout changes simultaneously

Implemented saving the previous node under the mouse, so that we don't need to
recalculate it, which is slow and even not really possible. This has fixed a number
of issues with mouse event dispatching when the content changes.
The code still needs refactoring and cleanup, see bug 3439 for comments.

Tests (both files perform multiple checks):

fast/events/mouseover-mouseout.html
fast/events/mouseover-mouseout2.html

page/Frame.h: Added a Frame parameter to passSubframeEventToSubframe(), used for mouseMoved events.
bridge/mac/FrameMac.h: Ditto.
bridge/mac/FrameMac.mm: (WebCore::FrameMac::passSubframeEventToSubframe): Use the passed subframe to target NSMouseMoved events.
page/FrameView.h: Added a prepareMouseEvent() helper that does viewportToContents translation.
page/FrameView.cpp: Added data members for storing the previous node and subframe under the mouse to FrameViewPrivate. Removed the now unused prevMouseX/prevMouseY. (WebCore::FrameViewPrivate::reset): Reset the new data members. (WebCore::subframeForEvent): A temporary place for the code that extracts a subframe pointer from MouseEventWithHitTestResults, moved from FrameMac::passSubframeEventToSubframe(). (WebCore::FrameView::prepareMouseEvent): The new helper. (WebCore::FrameView::handleMousePressEvent): Use the new helper. (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto. (WebCore::FrameView::handleMouseReleaseEvent): Ditto. (WebCore::FrameView::updateDragAndDrop): Ditto. (WebCore::FrameView::hoverTimerFired): Ditto. (WebCore::FrameView::dispatchMouseEvent): Store and use the oldUnder node, don't store or use prevMouseX/Y. (WebCore::FrameView::handleMouseMoveEvent): Rewrote dispatching events to subframes using a stored oldSubframe reference. Protect "this" from being removed while in this function.

11:58 AM Changeset in webkit [13401] by bdakin

5 edits
8 moves in trunk/LayoutTests

Reviewed by Adele

Updating pixel results for a few tables tests that have changed
with Hyatt's recent table work. Moving two of said tests into the
expected successes folder because they now completely pass. Yay!

9:04 AM Changeset in webkit [13400] by darin

25 edits
1 add
2 deletes in trunk/WebCore

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7875 autogenerate bindings for Range

dom/Range.idl: Added.
khtml/ecma/kjs_range.cpp: Removed.
khtml/ecma/kjs_range.h: Removed.

WebCore.vcproj/WebCore/build-generated-files.sh: Removed code to generate kjs_range.lut.h.

WebCore.xcodeproj/project.pbxproj: Added Range.idl source file. Removed kjs_range.h and kjs_range.cpp source files. Sorted the "dom" group. Removed rule to generate kjs_range.lut.h.

bindings/js/JSDOMCore.cpp: Added include of JSRange.cpp.

bindings/scripts/CodeGeneratorJS.pm: Added DocumentFragment, Range, CompareHow, and short to the types this script can handle. Added code to generate toRange functions and the like. Added separate code to handle exceptions for getters vs. setters for attributes. Changed return values for the "bad ID" case to 0 -- there's no need to generate the extra code to return jsUndefined() in such cases, which should be unreachable. Changed exception handling to use setDOMException directly instead of DOMExceptionTranslator; DOMExceptionTranslator was a trick to make it easier to convert existing bindings and shouldn't be used going forward. Fixed names of constructors to use the JavaScript class name (the interface name), not the name of the C++ implementation class. Fixed generation of code for functions that have no parameters but do raise exceptions.

bindings/scripts/IDLParser.pm: Added parsing for separate getter and setter exceptions in attributes. The syntax is not real IDL, but real IDL doesn't support declaring exceptions on attributes at all. We'll probably want to revisit our syntax for this some day.

bindings/scripts/IDLStructure.pm: Removed unused exceptionName field from domAttribute, and replaced raisesExceptions field with getterExceptions and setterExceptions. Added regular expressions for parsing getter/setter syntax. We'll probably have to redo this whole thing parse in a better way at some point -- the regular expressions allow any invalid syntax in between them.

dom/Attr.idl: Change exception declaration for setting the value attribute to use setter-specific exception syntax.
dom/CharacterData.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.
dom/ProcessingInstruction.idl: Change exception declaration for setting the data attribute to use setter-specific exception syntax.

khtml/ecma/kjs_dom.cpp: Include JSRange.h instead of kjs_range.h.
khtml/ecma/kjs_window.cpp: Include JSRange.h instead of kjs_range.h. (KJS::Window::getValueProperty): Use JSRange::getConstructor instead of getRangeConstructor.

1:00 AM Changeset in webkit [13399] by eseidel

4 edits in trunk/WebKitTools

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix win32 build.

Spinneret/Spinneret/Spinneret.vcproj:
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):

1:00 AM Changeset in webkit [13398] by eseidel

5 edits in trunk/WebCore

2006-03-20 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix win32 compile.

Viewer/ImageView.cpp:
platform/GraphicsContext.cpp: (WebCore::WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::WebCore::GraphicsContext::destroyGraphicsContextPrivate):
platform/cairo/GraphicsContextCairo.cpp: (WebCore::fillRectSourceOver): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawFocusRing):
platform/win/FontWin.cpp: (WebCore::Font::drawHighlightForText):

12:03 AM Changeset in webkit [13397] by darin

62 edits
72 copies
1 delete in trunk/WebCore

Rubber stamped by Eric.

moved khtml/html files all into html directory

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new paths.
WebCore.vcproj/WebCore/build-generated-files.sh: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

khtml/html: Removed.

html/DocTypeStrings.gperf: Moved.
html/FormDataList.cpp: Ditto.
html/FormDataList.h: Ditto.
html/HTMLBaseFontElement.cpp: Ditto.
html/HTMLBaseFontElement.h: Ditto.
html/HTMLButtonElement.cpp: Ditto.
html/HTMLButtonElement.h: Ditto.
html/HTMLCanvasElement.cpp: Ditto.
html/HTMLCanvasElement.h: Ditto.
html/HTMLCollection.cpp: Ditto.
html/HTMLCollection.h: Ditto.
html/HTMLDocument.cpp: Ditto.
html/HTMLDocument.h: Ditto.
html/HTMLElement.cpp: Ditto.
html/HTMLElement.h: Ditto.
html/HTMLElementFactory.cpp: Ditto.
html/HTMLElementFactory.h: Ditto.
html/HTMLEntityNames.gperf: Ditto.
html/HTMLFieldSetElement.cpp: Ditto.
html/HTMLFieldSetElement.h: Ditto.
html/HTMLFormCollection.cpp: Ditto.
html/HTMLFormCollection.h: Ditto.
html/HTMLFormElement.cpp: Ditto.
html/HTMLFormElement.h: Ditto.
html/HTMLGenericFormElement.cpp: Ditto.
html/HTMLGenericFormElement.h: Ditto.
html/HTMLInputElement.cpp: Ditto.
html/HTMLInputElement.h: Ditto.
html/HTMLIsIndexElement.cpp: Ditto.
html/HTMLIsIndexElement.h: Ditto.
html/HTMLKeygenElement.cpp: Ditto.
html/HTMLKeygenElement.h: Ditto.
html/HTMLLabelElement.cpp: Ditto.
html/HTMLLabelElement.h: Ditto.
html/HTMLLegendElement.cpp: Ditto.
html/HTMLLegendElement.h: Ditto.
html/HTMLNameCollection.cpp: Ditto.
html/HTMLNameCollection.h: Ditto.
html/HTMLNames.cpp: Ditto.
html/HTMLNames.h: Ditto.
html/HTMLOptGroupElement.cpp: Ditto.
html/HTMLOptGroupElement.h: Ditto.
html/HTMLOptionElement.cpp: Ditto.
html/HTMLOptionElement.h: Ditto.
html/HTMLOptionsCollection.cpp: Ditto.
html/HTMLOptionsCollection.h: Ditto.
html/HTMLParser.cpp: Ditto.
html/HTMLParser.h: Ditto.
html/HTMLSelectElement.cpp: Ditto.
html/HTMLSelectElement.h: Ditto.
html/HTMLTextAreaElement.cpp: Ditto.
html/HTMLTextAreaElement.h: Ditto.
html/HTMLTextFieldInnerElement.cpp: Ditto.
html/HTMLTextFieldInnerElement.h: Ditto.
html/HTMLTokenizer.cpp: Ditto.
html/HTMLTokenizer.h: Ditto.
html/html_baseimpl.cpp: Ditto.
html/html_baseimpl.h: Ditto.
html/html_blockimpl.cpp: Ditto.
html/html_blockimpl.h: Ditto.
html/html_headimpl.cpp: Ditto.
html/html_headimpl.h: Ditto.
html/html_imageimpl.cpp: Ditto.
html/html_imageimpl.h: Ditto.
html/html_inlineimpl.cpp: Ditto.
html/html_inlineimpl.h: Ditto.
html/html_listimpl.cpp: Ditto.
html/html_listimpl.h: Ditto.
html/html_objectimpl.cpp: Ditto.
html/html_objectimpl.h: Ditto.
html/html_tableimpl.cpp: Ditto.
html/html_tableimpl.h: Ditto.

bindings/objc/DOM.mm:
bridge/mac/WebCoreEncodings.mm:
bridge/mac/WebCoreFrameBridge.mm:
css/CSSGrammar.y:
css/cssstyleselector.cpp:
dom/Document.cpp:
dom/EventTargetNode.cpp:
dom/NameNodeList.cpp:
dom/Node.cpp:
dom/Position.cpp:
dom/dom_elementimpl.cpp:
dom/xml_tokenizer.cpp:
editing/ApplyStyleCommand.cpp:
editing/BreakBlockquoteCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteSelectionCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/TextIterator.cpp:
editing/VisiblePosition.cpp:
editing/htmlediting.cpp:
editing/markup.cpp:
editing/visible_units.cpp:
html/CanvasRenderingContext2D.cpp:
kcanvas/KCanvasTreeDebug.cpp:
khtml/ecma/JSDOMParser.cpp:
khtml/ecma/kjs_css.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_events.cpp:
khtml/misc/decoder.cpp:
khtml/xsl/XSLStyleSheet.cpp:
khtml/xsl/XSLTProcessor.cpp:
ksvg2/misc/SVGImageLoader.h:
ksvg2/svg/SVGElement.cpp:
ksvg2/svg/SVGSVGElement.cpp:
kwq/WebCoreAXObject.mm:
page/Frame.cpp:
page/FrameView.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBox.cpp:
rendering/RenderFlow.cpp:
rendering/RenderHTMLCanvas.cpp:
rendering/RenderImage.cpp:
rendering/RenderLayer.cpp:
rendering/RenderObject.cpp:
rendering/RenderTable.cpp:
rendering/RenderTableCell.cpp:
rendering/RenderTableCol.cpp:
rendering/RenderTableRow.cpp:
rendering/RenderTableSection.cpp:
rendering/RenderTextField.cpp:
rendering/RenderTheme.cpp:
rendering/render_applet.cpp:
rendering/render_button.cpp:
rendering/render_frames.cpp:
rendering/render_list.cpp: Updated includes.

Mar 19, 2006:

11:30 PM Changeset in webkit [13396] by eseidel

18 edits in trunk/WebCore

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Move Form code from MacFrame to Frame.
Move GraphicsContext code from GraphicsContextMac to GraphicsContext.
Use IntRect, FloatRect in more places throughout the code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7824

bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::searchForLabelsAboveCell): (WebCore::MacFrame::searchForLabelsBeforeElement): (WebCore::dictionaryFromHashMap): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::setView): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::currentEventIsKeyboardOptionTab): (WebCore::MacFrame::handleKeyboardOptionTabInView): (WebCore::MacFrame::tabsToAllControls): (WebCore::MacFrame::shouldDragAutoNode): (WebCore::MacFrame::selectionImage): (WebCore::MacFrame::snapshotDragImage):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::clearRecordedFormValues): (WebCore::Frame::recordFormValue): (WebCore::Frame::didNotOpenURL): (WebCore::scanForForm): (WebCore::Frame::paint): (WebCore::Frame::prepareForUserAction):
page/Frame.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::setUsesInactiveTextBackgroundColor): (WebCore::GraphicsContext::usesInactiveTextBackgroundColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::printing): (WebCore::GraphicsContext::drawImageAtPoint): (WebCore::GraphicsContext::drawImageInRect): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects):
platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm: (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::selectedTextBackgroundColor): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::drawFocusRing):
rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
rendering/render_image.cpp: (WebCore::RenderImage::paint):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage):

11:25 PM Changeset in webkit [13395] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7854 CanvasGradient leaks

html/CanvasGradient.cpp: (WebCore::CanvasGradient::platformShading): Don't make the CG shading object keep a reference to the DOM gradient object. I got confused because in the case of a CanvasPattern, the pattern does need to keep a reference to the DOM pattern object, but the object lifetime is handled differently here. The CG shading object is used right away, not set in a graphics context.

11:20 PM Changeset in webkit [13394] by darin

4 edits
2 adds in trunk/WebCore

Reviewed by Eric.

attempt to fix the buildbot by handling DOMImplementation another way

WebCore.xcodeproj/project.pbxproj: Added DOMImplementationFront.h/cpp.

bindings/objc/DOMImplementationFront.cpp: Added.
bindings/objc/DOMImplementationFront.h: Added.

bindings/objc/DOMInternal.h: Use DOMImplementationFront, not DOMImplementation.
bindings/objc/DOM.mm: (-[DOMImplementation dealloc]): Ditto. (-[DOMImplementation finalize]): Ditto. (-[DOMImplementation _initWithDOMImplementation:]): Ditto. (+[DOMImplementation _DOMImplementationWith:]): Ditto. (-[DOMImplementation _DOMImplementation]): Ditto. (-[DOMDocument implementation]): Call implementationFront from the DOMImplementationFront header instead of using the real implementation function on the Document.

6:57 PM Changeset in webkit [13393] by darin

453 edits
446 moves in trunk/WebCore

global rename, done by script

<lots of files>: Renamed XXXImpl to XXX, and a number of other renames. See WebKitTools/Scripts/do-webcore-rename version 13392 for details.

5:01 PM Changeset in webkit [13392] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of refinement. Ready to go now, but looks like I'm going to have to wait and do this next week.

10:55 AM Changeset in webkit [13391] by darin

3 edits in trunk/WebKitTools

Reviewed by Anders.

DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that we can test it in layout tests. We don't really need tests that run with pop-up blocking off at the moment. If we do some day, we can add some API for turning it off in the layout test controller.

Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more, don't ignore the leak; it should no longer show up.

10:40 AM Changeset in webkit [13390] by darin

11 edits
8 adds in trunk

LayoutTests:

changed these tests to be expected failures because I had to roll out the fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

fast/js/exception-linenums-in-html-3-expected.txt:
fast/js/exception-linenums-in-html-3-expected.png: Added.
fast/js/exception-linenums-in-html-3-expected.checksum: Added.

fast/js/missing-style-end-tag-js-expected.txt:
fast/js/missing-style-end-tag-js-expected.png: Added.
fast/js/missing-style-end-tag-js-expected.checksum: Added.

fast/tokenizer/missing-style-end-tag-1-expected.checksum:
fast/tokenizer/missing-style-end-tag-1-expected.png:
fast/tokenizer/missing-style-end-tag-1-expected.txt:
fast/tokenizer/missing-style-end-tag-2-expected.checksum:
fast/tokenizer/missing-style-end-tag-2-expected.png:
fast/tokenizer/missing-style-end-tag-2-expected.txt:

added some missing pixel-test results

tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
fast/dom/Element/class-attribute-whitespace-expected.png: Added.
fast/canvas/patternfill-repeat-expected.png: Added.

WebCore:

roll out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

This fix was breaking major sites -- details in the bug report.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Removed the bug fix, added a FIXME about the <title> code that has the same problem.

10:13 AM Changeset in webkit [13389] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round, believe it or not. About ready to go.

8:56 AM Changeset in webkit [13388] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of tweaks after another dry run.

Mar 18, 2006:

10:51 PM Changeset in webkit [13387] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

One more time.

10:48 PM Changeset in webkit [13386] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more fixes for things found during dry runs.

10:31 PM Changeset in webkit [13385] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Did another dry run of the renaming and had to fix a couple of things.

10:05 PM Changeset in webkit [13384] by darin

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7830 <canvas> createPattern 'repeat' options fail

fast/canvas/patternfill-repeat-expected.checksum: Added.
fast/canvas/patternfill-repeat-expected.png: Added.
fast/canvas/patternfill-repeat-expected.txt: Added.
fast/canvas/patternfill-repeat.html: Added.

WebCore:

Test: fast/canvas/patternfill-repeat.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7830 <canvas> createPattern 'repeat' options fail

CanvasPattern.cpp (CanvasPattern::createPattern) Change stepping so that repeat-x, repeat-y, and no-repeat repeat outside the view area by using large values for repeat interval.

10:00 PM Changeset in webkit [13383] by darin

3 edits
3 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7761 Tabs in class attribute not treated as whitespace

fast/dom/Element/class-attribute-whitespace-expected.checksum: Added.
fast/dom/Element/class-attribute-whitespace-expected.png: Added.
fast/dom/Element/class-attribute-whitespace-expected.txt: Added.
fast/dom/Element/class-attribute-whitespace.html: Added. NOTE: This test will get broken if "eol-style" processing is done on it.

WebCore:

Test: fast/dom/Element/class-attribute-whitespace.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7761 Tabs in class attribute not treated as whitespace

dom/dom_elementimpl.cpp: (WebCore::isClassWhitespace): Helper function to check if a character in the class attribute should be treated as whitespace. Added \r and \t. (WebCore::NamedMappedAttrMapImpl::parseClassAttribute): Instead of creating a QStringList and iterating it, do everything in one pass over the string.

9:49 PM Changeset in webkit [13382] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6795 Slow image load causes render problem

fast/block/float/vertical-move-relayout-expected.checksum: Added.
fast/block/float/vertical-move-relayout-expected.png: Added.
fast/block/float/vertical-move-relayout-expected.txt: Added.
fast/block/float/vertical-move-relayout.html: Added.

WebCore:

Test: fast/block/float/vertical-move-relayout.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6795 Slow image load causes render problem

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Call markAllDescendantsWithFloatsForLayout when the child's vertical position changes.

9:47 PM Changeset in webkit [13381] by darin

4 edits
12 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

fast/js/exception-linenums-in-html-3-expected.txt: Added.
fast/js/exception-linenums-in-html-3.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <style> tag, which causes the code path for Bug 6314 to be tested.

fast/js/missing-style-end-tag-js-expected.txt: Added.
fast/js/missing-style-end-tag-js.html: Added.

While developing a fix for Bug 6314, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

fast/tokenizer/missing-style-end-tag-1-expected.checksum: Added.
fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
fast/tokenizer/missing-style-end-tag-1-expected.txt: Added.
fast/tokenizer/missing-style-end-tag-1.html: Added.
fast/tokenizer/missing-style-end-tag-2-expected.checksum: Added.
fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
fast/tokenizer/missing-style-end-tag-2-expected.txt: Added.
fast/tokenizer/missing-style-end-tag-2.html: Added.

The first test case contains an unclosed <style> tag in <head>, while the
second test case contains an unclosed <style> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6314 Unclosed <style> element in <head> makes page completely blank

Test: fast/js/exception-linenums-in-html-3.html
Test: fast/js/missing-style-end-tag-js.html
Test: fast/tokenizer/missing-style-end-tag-1.html
Test: fast/tokenizer/missing-style-end-tag-2.html

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </style> tag and handle this condition if identified.
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </style> tag, reset the state of the tokenizer and retokenize with no special handling for <style>. The parser will handle the missing </style> tag in HTMLParser::handleError().

9:36 PM Changeset in webkit [13380] by darin

3 edits in trunk/WebCore

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5351:
SVG: Safari ignores <title> elements

Make SVGTitleElementImpl act the same as HTMLTitleElementImpl,
in the process setting the title on the right triggers.

ksvg2/svg/SVGTitleElementImpl.cpp: (SVGTitleElementImpl::SVGTitleElementImpl): (SVGTitleElementImpl::title): (SVGTitleElementImpl::closeRenderer): (SVGTitleElementImpl::insertedIntoDocument): (SVGTitleElementImpl::removedFromDocument): (SVGTitleElementImpl::childrenChanged):
ksvg2/svg/SVGTitleElementImpl.h:

9:28 PM Changeset in webkit [13379] by darin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3438

fast/replaced/img-1x1-expected.checksum: Added.
fast/replaced/img-1x1-expected.txt: Added.
fast/replaced/img-1x1.html: Added.
fast/replaced/img-1x1-expected.png: Added.

9:25 PM Changeset in webkit [13378] by darin

17 edits in trunk/LayoutTests

updated test results for tests affected by Hyatt's latest table fix

tables/mozilla/bugs/bug44505-expected.txt:
tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
tables/mozilla_expected_failures/bugs/bug106966-expected.png:
tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:

8:49 PM Changeset in webkit [13377] by darin

2 edits in trunk/WebCore

another try at fixing Windows build

WebCore.vcproj/WebCore/WebCore.vcproj: Added EventTargetNodeImpl.h and .cpp.

8:34 PM Changeset in webkit [13376] by darin

2 edits in trunk/WebCore

another try at fixing Windows build

bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Added EventTargetNodeCast.

8:21 PM Changeset in webkit [13375] by darin

4 edits in trunk/WebCore

try to fix Windows build

bridge/win/FrameWin.h: Remove KURL parameter.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Ditto.
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::canRunModal): Ditto.

8:19 PM Changeset in webkit [13374] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

fix leaks caused by the fix for Bugzilla bug 3560

rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with first-letter pseudo style are children of an existing first-letter inline that has been updated, and should be destroyed.

8:12 PM Changeset in webkit [13373] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more renaming refinements.

1:39 AM Changeset in webkit [13372] by hyatt

8 edits in trunk/WebCore

Fix for bug 7841, tables, table rows, and table row groups should
all support overflow:hidden.

Reviewed by eric

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getOverflowClipRect):
rendering/RenderTable.h:
rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/render_box.cpp: (WebCore::RenderBox::setStyle):
rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer):

Mar 17, 2006:

7:22 PM Changeset in webkit [13371] by aliceli1

2 edits in trunk/WebCore

Reviewed by Hyatt.

fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6999 "Dynamically added link-tag disables the use of change styles

dynamically"

khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
dynamically added link-tags for stylesheets were messing up the counting of pending stylesheets. If a head link element specifies a new stylesheet but the previously specified stylesheet is still loading, tell the document that stylesheets are loaded so that there are no remaining requests for it to be loaded.

7:19 PM Changeset in webkit [13370] by aliceli1

1 edit
4 adds in trunk/LayoutTests

Reviewed by Justin.

fast/dom/HTMLHeadElement/head-link-style-href-check-expected.checksum: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check-expected.txt: Added.
fast/dom/HTMLHeadElement/head-link-style-href-check.html: Added.

6:04 PM Changeset in webkit [13369] by ggaren

62 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

fast/dom/prototype-chain-expected.txt: Updated to reflect new prototype chain.

WebCore:

Reviewed by Darin.

Fixed some crashes in event dispatch and settled the question of when getDocument() can return NULL, removing superfluous NULL checks.

I promise to check in a test case soon, but I need to land this before
the global rename happens, and I left the test file on my other machine.

Here's what I did:

(1) Removed NULL checks for getDocument() in cases where we know it
should not return NULL (which turned out to be all but one). Replaced
with ASSERT inside getDocument(). Tested to ensure there was no
regression @ albertsons.com.

(2) Added the EventTargetNode class, which represents Nodes that
implement the DOM EventTarget interface. Discussed this design with
Maciej and Hyatt. The previous dsign -- assuming that all Nodes were
EventTargets -- made it possible to crash WebKit by, for example,
dispatching a mouse event to a documentType node that was not
associated with a document.

(3) Reflected (2) into the JS bindings and touched JSDOMCore.cpp to
force a re-build.

(4) Using classInfo checking, strengthened type constraints on
JavaScript method dispatch so that you can't finagle JavaScript into,
for example, invoking a document-dependent method belonging to a
node type that's guaranteed to have a document on a node type that may
not have one.

(5) Pushed some IE-specific JS bindings that depend on a node having a
document down from DOMNode to DOMElement. (An element always has a
document.) Tested that Firefox's behavior matched. Confirmed with MSDN.

(6) Updated Objc bindigns to throw an exception if you try to use
the event interface on a node that doesn't support it. Discussed this
design with Maciej and TimH.

(7) Consolidated repeated documentElement-finding code in the Position
class into the Position::documentElement() method. Did the same for
repeated top-level document finding and DocumentImpl::topDocument().

WebCore+SVG/KDOMHeaders.h:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMCore.cpp:
bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMNode KJS::Bindings::]):
bridge/mac/MacFrame.mm: (WebCore::MacFrame::keyEvent): (WebCore::MacFrame::dispatchCPPEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
css/css_base.cpp: (WebCore::StyleBaseImpl::baseURL):
css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclarationImpl::removeProperty): (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
dom/Attr.idl:
dom/CharacterData.idl:
dom/CharacterDataImpl.cpp: (WebCore::CharacterDataImpl::CharacterDataImpl): (WebCore::CharacterDataImpl::rendererIsNeeded): (WebCore::CharacterDataImpl::dump):
dom/CharacterDataImpl.h:
dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::attach): (WebCore::ContainerNodeImpl::detach): (WebCore::ContainerNodeImpl::insertedIntoDocument): (WebCore::ContainerNodeImpl::removedFromDocument): (WebCore::ContainerNodeImpl::insertedIntoTree): (WebCore::ContainerNodeImpl::removedFromTree): (WebCore::ContainerNodeImpl::setFocus): (WebCore::ContainerNodeImpl::setActive): (WebCore::ContainerNodeImpl::setHovered): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
dom/ContainerNodeImpl.h:
dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::removeAllEventListenersFromAllNodes): (WebCore::DocumentImpl::removeAllDisconnectedNodeEventListeners): (WebCore::DocumentImpl::getAccObjectCache): (WebCore::DocumentImpl::setFocusNode): (WebCore::DocumentImpl::topDocument):
dom/Element.idl:
dom/EventTargetNodeImpl.cpp: Added. (WebCore::EventTargetNodeImpl::EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::~EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::insertedIntoDocument): (WebCore::EventTargetNodeImpl::removedFromDocument): (WebCore::EventTargetNodeImpl::addEventListener): (WebCore::EventTargetNodeImpl::removeEventListener): (WebCore::EventTargetNodeImpl::removeAllEventListeners): (WebCore::EventTargetNodeImpl::handleLocalEvents): (WebCore::EventTargetNodeImpl::dispatchGenericEvent): (WebCore::EventTargetNodeImpl::dispatchEvent): (WebCore::EventTargetNodeImpl::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNodeImpl::dispatchWindowEvent): (WebCore::EventTargetNodeImpl::dispatchUIEvent): (WebCore::EventTargetNodeImpl::dispatchKeyEvent): (WebCore::EventTargetNodeImpl::dispatchMouseEvent): (WebCore::EventTargetNodeImpl::dispatchSimulatedMouseEvent): (WebCore::EventTargetNodeImpl::dispatchWheelEvent): (WebCore::EventTargetNodeImpl::dispatchHTMLEvent): (WebCore::EventTargetNodeImpl::removeHTMLEventListener): (WebCore::EventTargetNodeImpl::setHTMLEventListener): (WebCore::EventTargetNodeImpl::getHTMLEventListener): (WebCore::EventTargetNodeImpl::disabled): (WebCore::EventTargetNodeImpl::defaultEventHandler): (WebCore::EventTargetNodeImpl::dump):
dom/EventTargetNodeImpl.h: Added. (WebCore::EventTargetNodeImpl::isEventTargetNode): (WebCore::EventTargetNodeImpl::preDispatchEventHandler): (WebCore::EventTargetNodeImpl::postDispatchEventHandler): (WebCore::EventTarget): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
dom/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): (WebCore::NodeImpl::~NodeImpl): (WebCore::NodeImpl::dump): (WebCore::NodeImpl::detach): (WebCore::NodeImpl::insertedIntoDocument): (WebCore::NodeImpl::removedFromDocument):
dom/NodeImpl.h: (WebCore::NodeImpl::isEventTargetNode): (WebCore::NodeImpl::isLink): (WebCore::NodeImpl::getDocument): (WebCore::NodeImpl::inDocument):
dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEventImpl::receivedTarget):
dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::commonAncestorContainer):
dom/dom_elementimpl.cpp: (WebCore::inHTMLDocument): (WebCore::ElementImpl::focus): (WebCore::ElementImpl::blur): (WebCore::StyledElementImpl::parseMappedAttribute):
dom/dom_position.cpp: (WebCore::Position::documentElement):
dom/dom_position.h:
editing/ReplaceSelectionCommand.cpp: (WebCore::computeAndStoreNodeDesiredStyle):
editing/SelectionController.cpp: (WebCore::SelectionController::needsCaretRepaint):
editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfDocument): (WebCore::endOfDocument):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::): (KJS::DOMDocument::DOMDocument): (KJS::DOMDocument::getOwnPropertySlot): (KJS::DOMDocument::put): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::DOMElement): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::put): (KJS::DOMElement::putValueProperty): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity):
khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMEventTargetNode::): (KJS::DOMElement::):
khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::getNodeEventListener):
khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::bodySetter):
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::registerFormElement): (WebCore::HTMLFormElementImpl::removeFormElement):
khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::insertedIntoTree):
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::~HTMLInputElementImpl): (WebCore::HTMLInputElementImpl::focus):
khtml/html/HTMLOptionElementImpl.cpp: (WebCore::HTMLOptionElementImpl::text):
khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl):
khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::~HTMLTextAreaElementImpl):
khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::insertedIntoDocument): (WebCore::HTMLFrameElementImpl::isURLAllowed): (WebCore::HTMLFrameElementImpl::openURL): (WebCore::HTMLFrameElementImpl::frameWidth): (WebCore::HTMLFrameElementImpl::frameHeight):
khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): (WebCore::HTMLMapElementImpl::~HTMLMapElementImpl):
khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchRecursiveEvent):
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGImageElementImpl.cpp:
ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent):
kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]): (-[KWQAccObject accessibilityPerformAction:]):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]):
page/Frame.cpp: (WebCore::dispatchKHTMLEditableContentChanged):
page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::viewportWheelEvent):
rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset):
rendering/render_object.cpp: (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::backslashAsCurrencySymbol):
rendering/render_replaced.cpp: (WebCore::RenderWidget::sendConsumedMouseUp):

5:24 PM Changeset in webkit [13368] by bdakin

1 edit
4 moves in trunk/LayoutTests

Reviewed by hyatt

This test should actually be in the failures folder. Moving.

5:05 PM Changeset in webkit [13367] by hyatt

1 edit in trunk/LayoutTests/tables/mozilla/marvin/backgr_layers-opacity-expected.txt

Update the table opacity test case to reflect the now-correct results.

5:01 PM Changeset in webkit [13366] by hyatt

9 edits in trunk/WebCore

Fix for 7837, make opacity work with table rows. Make transparent backgrounds
stack properly in cells (so that the layers behind can show through like they
should).

Reviewed by beth

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
rendering/RenderTableCell.h:
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::transparentAncestor): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::absoluteBoundingBox):
rendering/render_object.cpp: (WebCore::RenderObject::requiresLayer):
rendering/render_object.h: (WebCore::RenderObject::isTransparent): (WebCore::RenderObject::opacity):

2:03 PM Changeset in webkit [13365] by mjs

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

fixed "charAt layout test fails on intel macs; some NaNs are printed as -NaN" http://bugzilla.opendarwin.org/show_bug.cgi?id=7745

kjs/ustring.cpp: (KJS::UString::from): Use "NaN" for all NaN values, regardless of sign.

1:58 PM Changeset in webkit [13364] by mjs

13 edits in trunk/WebCore

Reviewed by Adele.

clean up ResourceRequest to be closer to a proper request interface

page/ResourceRequest.h: folded URL into ResourceRequest, other cleanup (WebCore::ResourceRequest::ResourceRequest): Add new explicit constructor that takes a KURL. (WebCore::ResourceRequest::url): getter for KURL (WebCore::ResourceRequest::setURL): corresponding setter (WebCore::ResourceRequest::referrer): new getter for referrer, instead of storing it in m_metaData (it was the only remaining real use of it) (WebCore::ResourceRequest::setReferrer): corresponding setter
bridge/BrowserExtension.h:
removed unused openURLRequest and openURLNotify methods
folded KURL parameter into ResourceRequest
bridge/mac/BrowserExtensionMac.h: remove KURL args from methods that also take a ResourceRequest
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): adjust for ResourceRequest changes.
bridge/mac/MacFrame.h: remove KURL args from methods that also take a ResourceRequest
bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLRequest): adjust for ResourceRequest changes (WebCore::MacFrame::submitForm): ditto (WebCore::MacFrame::urlSelected): ditto
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): adjust for ResourceRequest changes
bridge/win/BrowserExtensionWin.h:
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): adjust for ResourceRequest changes (KJS::WindowFunc::callAsFunction): ditto
page/Frame.cpp: (WebCore::Frame::didOpenURL): adjust for ResourceRequest changes (WebCore::Frame::receivedFirstData): ditto (WebCore::Frame::begin): ditto (WebCore::Frame::completeURL): ditto (WebCore::Frame::changeLocation): ditto (WebCore::Frame::urlSelected): ditto (WebCore::Frame::requestFrame): ditto (WebCore::Frame::submitForm): ditto
page/Frame.h:
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): ditto

12:32 PM Changeset in webkit [13363] by bdakin

5 edits
2 adds in trunk

Reviewed by Darin, landed by Beth.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7693 WebKit relies on unpredictable timing for onload events

12:11 PM Changeset in webkit [13362] by sullivan

2 edits in trunk/WebKit

Reviewed by Beth Dakin

fixed <rdar://problem/4239051> Sometimes "Copy Link" in Safari results in a URL on the pasteboard with no usable "title"

History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): trim whitespace from titles that are put on pasteboard. This leaves an empty string for the title in cases where there's no displayed text, like an image in an <a> element that happens to have whitespace in the source, e.g. <a href="foo"> <img whatever></a>

12:02 PM Changeset in webkit [13361] by adele

7 edits in trunk/LayoutTests

Updated results for background color change.

fast/forms/input-appearance-focus-expected.txt:
fast/forms/input-appearance-minWidth-expected.txt:
fast/forms/input-appearance-selection-expected.txt:
fast/forms/input-appearance-visibility-expected.txt:
fast/forms/input-appearance-width-expected.txt:
fast/forms/input-baseline-expected.txt:

11:42 AM Changeset in webkit [13360] by bdakin

1 edit
62 adds in trunk/LayoutTests

Reviewed by Geoff

A few more mozilla table tests.

11:20 AM Changeset in webkit [13359] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
fast/forms/input-appearance-default-bkcolor-expected.png: Added.
fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
fast/forms/input-appearance-default-bkcolor.html: Added.

WebCore:

Reviewed by Tim H.

Make default backgrounds for new text fields white
instead of transparent. This will move to html4.css
when we flip the switch.

Test added:

fast/forms/input-appearance-default-bkcolor.html

rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustTextFieldStyle):

11:06 AM Changeset in webkit [13358] by hyatt

2 edits in trunk/WebCore

Make table sections and table captions support opacity.

Reviewed by darin

Covered by some of the new Mozilla table tests.

rendering/RenderTable.cpp: (WebCore::RenderTable::paint):

10:39 AM Changeset in webkit [13357] by hyatt

2 adds
4 deletes in trunk/LayoutTests/tables

Fix table test that now passes.

9:47 AM Changeset in webkit [13356] by bdakin

6 edits
4 adds in trunk

Reviewed by Maciej, landed by Beth.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3560
page with use of first-letter crashes reproducibly in
RenderObject::renderArena()

9:42 AM Changeset in webkit [13355] by darin

2 edits in trunk/WebKit

missing bit of my check-in yesterday

Maciej moved setWindowFrame for me, but I also had removed
setWindowContentRect.

WebCoreSupport/WebFrameBridge.m: Removed unused setWindowContextRect and windowContentRect methods.

6:06 AM Changeset in webkit [13354] by eseidel

2 edits in trunk/WebKitLibraries

2006-03-17 Eric Seidel <eseidel@apple.com>

libWebKitSystemInterface.a: commit a universal binary.

4:36 AM Changeset in webkit [13353] by andersca

2 edits in trunk/WebKitTools

2006-03-17 Anders Carlsson <andersca@mac.com>

Reviewed by Eric.

Scripts/install-win-extras: Fetch "Program Files" location from the environment.

3:06 AM Changeset in webkit [13352] by adele

24 edits in trunk

LayoutTests:

Reviewed by Eric.

Updating test results for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7798
New text fields are much wider than they should be for a specified size

fast/forms/input-appearance-bkcolor-expected.checksum:
fast/forms/input-appearance-bkcolor-expected.png:
fast/forms/input-appearance-bkcolor-expected.txt:
fast/forms/input-appearance-focus-expected.checksum:
fast/forms/input-appearance-focus-expected.png:
fast/forms/input-appearance-focus-expected.txt:
fast/forms/input-appearance-minWidth-expected.checksum:
fast/forms/input-appearance-minWidth-expected.png:
fast/forms/input-appearance-minWidth-expected.txt:
fast/forms/input-appearance-selection-expected.checksum:
fast/forms/input-appearance-selection-expected.png:
fast/forms/input-appearance-selection-expected.txt:
fast/forms/input-appearance-visibility-expected.checksum:
fast/forms/input-appearance-visibility-expected.png:
fast/forms/input-appearance-visibility-expected.txt:
fast/forms/input-appearance-width-expected.checksum:
fast/forms/input-appearance-width-expected.png:
fast/forms/input-appearance-width-expected.txt:
fast/forms/input-baseline-expected.checksum:
fast/forms/input-baseline-expected.png:
fast/forms/input-baseline-expected.txt:

WebCore:

Reviewed by Eric.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7798 New text fields are much wider than they should be for a specified size

I changed the character we use to calculate the width from "w" back to "0",
which matches our old behavior. The original change was intentional, to try
to better match other browsers, but "w" is a little too wide. For now, lets
go back to the old behavior.

I also set the minWidth = maxWidth. We were trying to match a WinIE quirk,
but that caused some odd behavior with growth of the text field in table cells.

rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):

3:00 AM Changeset in webkit [13351] by eseidel

2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Fix Spinneret to pass Events as const & not as pointers.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress):

2:47 AM Changeset in webkit [13350] by eseidel

8 edits
2 adds in trunk/WebCore

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by adele.

Fix win32 build.
Add PageWin class.
Add previously forgotten KeyEventWin class.
Pass MouseEvent() instead of 0 in a couple places to make compiler happy.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::keyPress):
bridge/win/FrameWin.h:
bridge/win/PageWin.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::hoverTimerFired):
page/Page.h: (WebCore::Page::mainFrame):
platform/win/KeyEventWin.cpp: Added. (WebCore::KeyEvent::KeyEvent):
platform/win/TemporaryLinkStubs.cpp: (WebCore::findNextWordFromIndex): (FrameWin::passMouseDownEventToWidget): (FrameWin::scheduleClose): (BrowserExtensionWin::createNewWindow): (WebCore::findWordBoundary): (FrameWin::registerCommandForUndo): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::respondToChangedContents):

2:40 AM Changeset in webkit [13349] by eseidel

2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Add support for basic HTML editing.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::keyPress):

2:28 AM Changeset in webkit [13348] by adele

3 edits in trunk/WebKitLibraries

WebKitSystemInterface.h: Added WKDrawBezeledTextFieldCell()
libWebKitSystemInterface.a: ditto

2:16 AM Changeset in webkit [13347] by hyatt

2 edits in trunk/WebCore

Fix pixel test regression in fast/table/overflowHidden.html. There was
a borderTopExtra error made in the new boundingBox code for layers that
caused the bottom half of cells with opacity set to be clipped out.

Reviewed by andersca

rendering/render_layer.cpp: (WebCore::RenderLayer::absoluteBoundingBox):

1:50 AM Changeset in webkit [13346] by hyatt

25 edits in trunk/WebCore

Give table rows and sections accurate dimensions. Fix absolutePosition
to work for table cells properly. Add an absolutePositionForContent method
to make sure callers that want to deal with the content of a cell handle
the cell's extra space correctly.

Reviewed by darin

Existing layout tests cover this change.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): (WebCore::ContainerNodeImpl::getLowerRightCorner):
dom/NodeImpl.cpp: (WebCore::NodeImpl::getRect):
editing/SelectionController.cpp: (WebCore::SelectionController::layout): (WebCore::SelectionController::caretRect):
editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::defaultEventHandler):
kwq/KWQRenderTreeDebug.cpp: (operator<<):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): (WebCore::RenderBlock::positionForCoordinates):
rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition):
rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::nodeAtPoint):
rendering/RenderTableRow.h:
rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
rendering/RenderTableSection.h:
rendering/RenderText.cpp: (WebCore::RenderText::lineBoxRects): (WebCore::RenderText::positionForCoordinates): (WebCore::RenderText::caretRect): (WebCore::RenderText::posOfChar): (WebCore::RenderText::selectionRect):
rendering/render_box.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::caretRect):
rendering/render_br.cpp: (WebCore::RenderBR::caretRect):
rendering/render_canvas.h:
rendering/render_flow.cpp: (WebCore::RenderFlow::caretRect):
rendering/render_frames.cpp: (WebCore::RenderPart::updateWidgetPosition):
rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition):
rendering/render_object.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::absolutePosition):
rendering/render_object.h: (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::offsetHeight):
rendering/render_replaced.cpp: (WebCore::RenderWidget::updateWidgetPosition):

1:13 AM Changeset in webkit [13345] by eseidel

5 edits
6 copies
1 add in trunk/WebKitTools

2006-03-17 Eric Seidel <eseidel@apple.com>

Rubber-stamped by ggaren.

Break DumpRenderTree.m up into several files to make the code more readable.

DumpRenderTree/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.m: (doneLoading): new accessor function for "done" global.
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTreeDraggingInfo.h: Added.
DumpRenderTree/DumpRenderTreeDraggingInfo.m: Added.
DumpRenderTree/EditingDelegate.h: Added.
DumpRenderTree/EditingDelegate.m: Added. (-[EditingDelegate webViewDidChangeSelection:]):
DumpRenderTree/EventSendingController.h: Added.
DumpRenderTree/EventSendingController.m: Added.

1:10 AM Changeset in webkit [13344] by adele

10 edits
6 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

fast/forms/input-appearance-bkcolor-expected.checksum: Added.
fast/forms/input-appearance-bkcolor-expected.png: Added.
fast/forms/input-appearance-bkcolor-expected.txt: Added.
fast/forms/input-appearance-bkcolor.html: Added.
fast/forms/resources
fast/forms/resources/apple.gif

WebCore:

Reviewed by Hyatt.

WebCore part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Bezeled NSTextFieldCells always draw a background, so instead we'll use a new
WebKitSystemInterface function to just draw the border of the cell.

Since the theme is drawing the border and the engine is drawing the background
(which is different from the other form controls), we have to make sure we let the
theme paint the border after the engine paints the background.

platform/mac/WebCoreGraphicsBridge.h:
platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawBezeledTextFieldCell:enabled:]):
rendering/render_box.cpp: (WebCore::RenderBox::paintBoxDecorations):
rendering/render_theme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorder): (WebCore::RenderTheme::shouldPaintBorder):
rendering/render_theme.h:
rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::setTextFieldCellState):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Added function to draw bezeled text field without drawing background.

WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawBezeledTextFieldCell:enabled:]): Added.

Mar 16, 2006:

11:45 PM Changeset in webkit [13343] by mjs

3 edits in trunk/WebKit

Reviewed by Eric.

move setWindowFrame / windowFrame to WebPageBridge to fix build

WebCoreSupport/WebFrameBridge.m:
WebCoreSupport/WebPageBridge.m: (-[WebPageBridge setWindowFrame:]): (-[WebPageBridge windowFrame]):

4:19 PM Changeset in webkit [13342] by darin

33 edits
1 add
3 deletes in trunk/WebCore

Reviewed by Eric.

removed KWQWindowWidget
changed most event handling to use references instead of pointers
chagned PageMac to no longer be a subclass of Page

Yes, I know there's no detail in this ChangeLog entry.
No, I don't plan to make a habit of doing things this way.
Yes, this will probably break the Windows build again.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameViewMac.mm:
bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::~MacFrame): (WebCore::MacFrame::wheelEvent): (WebCore::MacFrame::keyEvent): (WebCore::MacFrame::khtmlMousePressEvent): (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::khtmlMouseReleaseEvent): (WebCore::MacFrame::mouseDown): (WebCore::MacFrame::mouseDragged): (WebCore::MacFrame::mouseUp): (WebCore::MacFrame::mouseMoved): (WebCore::MacFrame::sendContextMenuEvent): (WebCore::MacFrame::setBridge): (WebCore::MacFrame::dragSourceMovedTo): (WebCore::MacFrame::dragSourceEndedAt): (WebCore::MacFrame::dispatchDragSrcEvent):
bridge/mac/PageMac.h: Removed.
bridge/mac/PageMac.mm: Added. (WebCore::Page::Page): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge page]): (-[WebCoreFrameBridge initializeSettings:]): (globalPoint): (createMouseEventFromDraggingInfo): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
bridge/mac/WebCoreFrameNamespaces.mm: (WebCore::):
bridge/mac/WebCorePageBridge.h:
bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge init]):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::defaultEventHandler):
dom/DocumentImpl.h:
dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): (WebCore::NodeImpl::dispatchKeyEvent): (WebCore::NodeImpl::dispatchWheelEvent):
dom/NodeImpl.h:
dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEventImpl::KeyboardEventImpl):
dom/dom2_eventsimpl.h: (WebCore::KeyboardEventImpl::keyEvent):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::WindowFunc::callAsFunction):
khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: Removed.
page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::khtmlMousePressEvent): (WebCore::Frame::handleMouseMoveEventSelection): (WebCore::Frame::khtmlMouseMoveEvent): (WebCore::Frame::khtmlMouseReleaseEvent): (WebCore::Frame::khtmlMouseDoubleClickEvent): (WebCore::Frame::passWidgetMouseDownEventToWidget):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::viewportMousePressEvent): (WebCore::FrameView::viewportMouseDoubleClickEvent): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::viewportWheelEvent):
page/FrameView.h:
page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults): (WebCore::MouseEventWithHitTestResults::event):
page/Page.cpp: (WebCore::Page::init):
page/Page.h: (WebCore::Page::bridge):
platform/KeyEvent.h: (WebCore::KeyEvent::isAutoRepeat):
platform/MouseEvent.h: (WebCore::MouseEvent::MouseEvent):
platform/mac/KeyEventMac.mm: (WebCore::KeyEvent::KeyEvent):
platform/win/TemporaryLinkStubs.cpp: (FrameView::isFrameView):
rendering/render_form.cpp: (WebCore::RenderFormElement::clicked):

4:13 PM Changeset in webkit [13341] by bdakin

1 edit
848 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Another round of Mozilla table tests.

3:08 PM Changeset in webkit [13340] by eseidel

14 edits
1 add in trunk/WebCore

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add additional hackish Font, focusring and caret code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7803

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
bindings/js/JSCanvasRenderingContext2DBase.cpp:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
bridge/win/FrameWin.h:
html/CanvasRenderingContext2D.h:
platform/IntSize.h:
platform/KeyEvent.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawFocusRing):
platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::convertRange): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint): (WebCore::Font::drawLineForText): (WebCore::Font::misspellingLineThickness):
platform/win/IntSizeWin.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator SIZE):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRect):
platform/win/TemporaryLinkStubs.cpp: (Widget::disableFlushDrawing): (GraphicsContext::GraphicsContext): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (FrameWin::locationbarVisible): (FrameWin::canUndo): (FrameWin::mimeTypeForFileName): (FrameWin::issueTransposeCommand): (RenderCanvasImage::setNeedsImageUpdate): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::clearRecordedFormValues): (FrameWin::recordFormValue): (BrowserExtensionWin::getHistoryLength): (Widget::setIsSelected): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::addRoundedRectClip): (QScrollBar::QScrollBar): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setFont):
rendering/render_canvasimage.h:

3:06 PM Changeset in webkit [13339] by mjs

3 edits in trunk/JavaScriptCore

Reviewed by Darin.

tweaks to my change to redo KJS::Node refcounting

kjs/nodes.cpp: (Node::ref): (Node::deref): (Node::refcount): (Node::clearNewNodes):
kjs/nodes.h:

3:05 PM Changeset in webkit [13338] by eseidel

3 edits in trunk/WebKitTools

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add resize, scroll event support.

Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

3:00 PM Changeset in webkit [13337] by mjs

12 edits
1 copy in trunk/WebCore

Reviewed by Eric.

renamed URLArgs to ResourceRequest, split it into its own header
moved methods to get and set ResourceRequest to Frame

WebCore.xcodeproj/project.pbxproj:
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::openURLRequest): (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLRequest): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::urlSelected):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::receivedFirstData): (WebCore::Frame::setResourceRequest): (WebCore::Frame::resourceRequest): (WebCore::Frame::begin): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
page/Frame.h:
page/FramePrivate.h:
page/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::contentType): (WebCore::ResourceRequest::setContentType): (WebCore::ResourceRequest::doPost): (WebCore::ResourceRequest::setDoPost): (WebCore::ResourceRequest::lockHistory): (WebCore::ResourceRequest::setLockHistory): (WebCore::ResourceRequest::metaData):

1:24 PM Changeset in webkit [13336] by bdakin

1 edit
680 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Still adding more mozilla table tests.

10:54 AM Changeset in webkit [13335] by bdakin

1 edit
143 adds in trunk/LayoutTests

Rubber stamped by Geoff.

Adding more mozilla table tests.

1:28 AM Changeset in webkit [13334] by darin

2 edits in trunk/WebCore

need to touch one more file to fix the build (Darn the lack of dependencies for autogenerated bindings!)

dom/Element.idl: Touch. (Really this time.)

1:21 AM Changeset in webkit [13333] by eseidel

2 edits in trunk/WebKitTools

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Make build-webkit print correctly to stdout on windows.

Scripts/webkitdirs.pm: Fix to use devenv.com instead of devenv.exe

1:11 AM Changeset in webkit [13332] by darin

1 edit in trunk/WebCore/ChangeLog

need to touch one more file to fix the build (Darn the lack of dependencies for autogenerated bindings!)

dom/Element.idl: Touch.

12:59 AM Changeset in webkit [13331] by eseidel

7 edits in trunk/WebCore

2006-03-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Pushed focus ring handling down into GraphicsContext.cpp

bridge/mac/MacFrame.mm: (WebCore::MacFrame::mouseDown):
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect):
platform/GraphicsContext.h:
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::drawFocusRing):
rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects):
rendering/render_object.cpp: (WebCore::RenderObject::addFocusRingRects):

12:54 AM Changeset in webkit [13330] by darin

12 adds in trunk/WebCore/html

Oops, these files were supposed to go in.

12:41 AM Changeset in webkit [13329] by darin

43 edits
3 adds in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7749 canvas should be in DOM, not implemented in the JS bindings

WebCore.xcodeproj/project.pbxproj: Added new files. Changed bindings-generation code to work on the new html directory as well as the dom one.

bindings/js/JSCanvasRenderingContext2DBase.cpp: Added.
bindings/js/JSCanvasRenderingContext2DBase.h: Added.
bindings/js/JSDOMHTML.cpp: Added.
html: Added.
html/CanvasGradient.cpp: Added.
html/CanvasGradient.h: Added.
html/CanvasGradient.idl: Added.
html/CanvasPattern.cpp: Added.
html/CanvasPattern.h: Added.
html/CanvasPattern.idl: Added.
html/CanvasRenderingContext2D.cpp: Added.
html/CanvasRenderingContext2D.h: Added.
html/CanvasRenderingContext2D.idl: Added.
html/CanvasStyle.cpp: Added.
html/CanvasStyle.h: Added.

bindings/js/JSDOMCore.cpp: Touched so that it will recompile.
bindings/js/JSDOMEvents.cpp: Ditto.
dom/Attr.idl: Ditto.
dom/DOMImplementation.idl: Ditto.
dom/DocumentType.idl: Ditto.
dom/MutationEvent.idl: Ditto.
dom/ProcessingInstruction.idl: Ditto.
dom/Text.idl: Ditto.

khtml/ecma/kjs_binding.h: (KJS::toJS): Added. Template so that you can call toJS on a PassRefPtr as well as on a raw pointer.

bindings/scripts/CodeGeneratorJS.pm: Fixed handling of a class that has only a legacy parent, no conventional parents. Added JSCanvasRenderingContext2DBase as a legacy parent, and html as a legacy module. Added CanvasRenderingContext2D, CanvasGradient, and CanvasPattern to the "waht to include". Added a special case for strings beginning with Canvas to not add an "Impl" suffix. Made the generated impl() function be a const member function. Made m_mimpl be private instead of protected. Generate a toJS function for each class. Added flaot as a type. Generate String, not DOMString. Made the HashTable const.

bindings/scripts/IDLParser.pm: Fix a couple small things. I had started to try to make a missing semicolon trigger an error, but ended up giving up on that for now.

khtml/html/html_canvasimpl.h:
khtml/html/html_canvasimpl.cpp: (WebCore::HTMLCanvasElementImpl::HTMLCanvasElementImpl): Set m_2DContext to 0. (WebCore::HTMLCanvasElementImpl::~HTMLCanvasElementImpl): Call detachCanvas on m_2DContext, if any. (WebCore::HTMLCanvasElementImpl::detach): Call reset on m_2DContext, if any. (WebCore::HTMLCanvasElementImpl::getContext): Added. (WebCore::HTMLCanvasElementImpl::size): Added. (WebCore::HTMLCanvasElementImpl::createPlatformImage): Added.

platform/Image.h:
platform/Image.cpp: (WebCore::Image::compositeOperatorFromString): Changed to take a String instead of a const char*.

khtml/html/html_imageimpl.h:
khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::areas): Tweaked formatting. Changed to use PassRefPtr.

bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::getValueProperty): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMStyleSheet::getValueProperty): (KJS::DOMStyleSheetList::indexGetter): (KJS::DOMStyleSheetList::nameGetter): (KJS::DOMStyleSheetListFunc::callAsFunction): (KJS::DOMCSSStyleSheet::getValueProperty): (KJS::DOMCSSRuleList::indexGetter): (KJS::DOMCSSRuleListFunc::callAsFunction): (KJS::DOMCSSRule::getValueProperty): (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction): (KJS::DOMCSSValueList::indexGetter): (KJS::DOMCSSValueListFunc::callAsFunction): (KJS::DOMRect::getValueProperty):
khtml/ecma/kjs_css.h:
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMNodeList::indexGetter): (KJS::DOMNodeList::nameGetter): (KJS::DOMNodeList::callAsFunction): (KJS::DOMNodeListFunc::callAsFunction): (KJS::DOMDocument::getValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMNamedNodesCollection::indexGetter):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode): (KJS::DOMEvent::getValueProperty): (KJS::toJS): (KJS::DOMUIEvent::getValueProperty): (KJS::DOMMouseEvent::getValueProperty):
khtml/ecma/kjs_events.h:
khtml/ecma/kjs_html.cpp: (KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLDocument::getValueProperty): (KJS::HTMLDocument::put): (KJS::HTMLDocument::putValueProperty): (KJS::HTMLElement::classInfo): (KJS::HTMLElement::formIndexGetter): (KJS::HTMLElement::selectIndexGetter): (KJS::HTMLElement::implementsCall): (KJS::HTMLElement::callAsFunction): (KJS::HTMLElement::linkGetter): (KJS::HTMLElement::isIndexGetter): (KJS::HTMLElement::styleGetter): (KJS::HTMLElement::selectGetter): (KJS::HTMLElement::optionGetter): (KJS::HTMLElement::inputGetter): (KJS::HTMLElement::textAreaGetter): (KJS::HTMLElement::buttonGetter): (KJS::HTMLElement::labelGetter): (KJS::HTMLElement::fieldSetGetter): (KJS::HTMLElement::legendGetter): (KJS::HTMLElement::objectGetter): (KJS::HTMLElement::tableGetter): (KJS::HTMLElement::frameGetter): (KJS::HTMLElement::iFrameGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::toString): (KJS::HTMLElement::pushEventHandlerScope): (KJS::toJS): (KJS::HTMLElementFunction::callAsFunction): (KJS::HTMLElement::put): (KJS::HTMLCollection::indexGetter): (KJS::HTMLCollection::callAsFunction): (KJS::HTMLCollection::getNamedItems): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::HTMLSelectCollection::put): (KJS::OptionConstructorImp::construct): (KJS::ImageConstructorImp::construct):
khtml/ecma/kjs_html.h:
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction): (KJS::toJS):
khtml/ecma/kjs_range.h:
khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::getValueProperty): (KJS::DOMNodeIteratorProtoFunc::callAsFunction): (KJS::toJS): (KJS::DOMTreeWalker::getValueProperty): (KJS::DOMTreeWalkerProtoFunc::callAsFunction): (KJS::JSNodeFilterCondition::acceptNode):
khtml/ecma/kjs_traversal.h:
khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractView::getValueProperty): (KJS::DOMAbstractViewProtoFunc::callAsFunction): (KJS::toJS):
khtml/ecma/kjs_views.h:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Selection::getValueProperty): (KJS::SelectionFunc::callAsFunction): Rename uses and definitions of all the various converstions to JavaScript wrappers to the new common overloaded name: "toJS".

12:40 AM Changeset in webkit [13328] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fixed Vector so that you can pass a reference to something in the vector to the append or insert functions

kxmlcore/Vector.h: (KXMLCore::Vector::expandCapacity): Added new overloads that take a pointer to adjust and return the adjusted value of the pointer. (KXMLCore::Vector::append): Pass a pointer when expanding the vector, and use it when adding the new element. Makes the case where the element moves when the vector is expanded work. (KXMLCore::Vector::insert): Ditto.

12:10 AM Changeset in webkit [13327] by eseidel

8 edits in trunk/WebCore

2006-03-15 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Push more of MacFrame down into Frame.
Add visibleContentRect method to ScrollView.

bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::imageFromRect): (WebCore::MacFrame::setDisplaysWithFocusAttributes): (WebCore::MacFrame::bodyBackgroundColor):
bridge/mac/WebCoreFrameBridge.mm:
page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setDisplaysWithFocusAttributes):
page/Frame.h:
platform/ScrollView.h:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::inWindow):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed