Context Navigation

← Previous Period
Next Period →

Timeline

Mar 26, 2006:

7:29 PM Changeset in webkit [13485] by eseidel

5 edits in trunk/WebCore

2006-03-26 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.

WebCore.vcproj/WebCore/WebCore.vcproj:
editing/CompositeEditCommand.cpp:
editing/InsertTextCommand.cpp:
generate-derived-sources:

5:30 PM Changeset in webkit [13484] by eseidel

2 edits in trunk/WebCore

2006-03-26 Eric Seidel <eseidel@apple.com>

dom/Element.cpp: fix include case, fixing build.

2:58 PM Changeset in webkit [13483] by eseidel

9 edits
1 add in trunk/WebCore

2006-03-25 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7916 Box repaint rect does not include the left overflow

manual-tests/left-overflow-repaint.html: Added.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
rendering/RenderBox.cpp: (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
rendering/RenderTableCell.cpp: Removed subclass implementation of getAbsoluteRepaintRect().
rendering/RenderTableCell.h:
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

Mar 25, 2006:

3:52 PM Changeset in webkit [13482] by eseidel

2 edits in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Build fix.

bindings/scripts/CodeGeneratorJS.pm: include Element.h

2:24 PM Changeset in webkit [13481] by eseidel

3 edits in trunk/WebKitTools

2006-03-24 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7947 Add repaint testing support to run-webkit-tests

DumpRenderTree/DumpRenderTree.m: (main): Added --repaint and --horizontal-sweep options. (dump): Repaint line-by-line or column-by-column when the appropriate option is selected. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint() and repaintSweepHorizontally() methods to layoutTestController. (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (dumpRenderTree):
Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options to force these settings on tests that do not ask for them.

2:20 PM Changeset in webkit [13480] by eseidel

111 edits
15 copies
2 moves
3 deletes in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Split dom_elementimpl.* into multiple files (one per class).
http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

ForwardingHeaders/kdom/core/Attr.h: Removed.
ForwardingHeaders/kdom/core/Element.h: Removed.
ForwardingHeaders/kdom/core/XMLElement.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMHTML.mm:
bindings/scripts/CodeGeneratorJS.pm:
dom/AbstractView.cpp:
dom/Attr.cpp: Added.
dom/Attr.h: Added.
dom/Attribute.cpp: Added.
dom/Attribute.h: Added.
dom/CSSMappedAttributeDeclaration.cpp: Added.
dom/CSSMappedAttributeDeclaration.h: Added.
dom/DOMImplementation.cpp:
dom/Document.h:
dom/DocumentType.cpp:
dom/Element.cpp: Added. (WebCore::Element::Element): (WebCore::Element::~Element):
dom/Element.h: Added.
dom/EventNames.cpp:
dom/EventTargetNode.cpp:
dom/MappedAttribute.cpp: Added.
dom/MappedAttribute.h: Added.
dom/MappedAttributeEntry.h: Added. (WebCore::):
dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
dom/NamedAttrMap.cpp: Added.
dom/NamedAttrMap.h: Added.
dom/NamedMappedAttrMap.cpp: Added. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
dom/NamedMappedAttrMap.h: Added.
dom/Node.cpp:
dom/NodeList.cpp:
dom/Position.cpp:
dom/StyledElement.cpp: Added.
dom/StyledElement.h: Added.
dom/dom_elementimpl.cpp: Removed.
dom/dom_elementimpl.h: Removed.
editing/BreakBlockquoteCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/DeleteSelectionCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/InsertTextCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/ModifySelectionListLevelCommand.cpp:
editing/MoveSelectionCommand.cpp:
editing/RemoveCSSPropertyCommand.cpp:
editing/RemoveNodeAttributeCommand.cpp:
editing/Selection.cpp:
editing/SelectionController.cpp:
editing/SetNodeAttributeCommand.cpp:
editing/SplitElementCommand.cpp:
editing/SplitTextNodeContainingElementCommand.cpp:
editing/TextIterator.cpp:
editing/TypingCommand.cpp:
editing/VisiblePosition.cpp:
editing/visible_units.cpp:
html/HTMLElement.h:
html/HTMLTokenizer.h:
html/html_baseimpl.cpp:
kcanvas/RenderSVGImage.cpp:
khtml/ecma/kjs_views.cpp:
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
khtml/xbl/xbl_binding_manager.cpp:
khtml/xbl/xbl_tokenizer.cpp:
ksvg2/misc/SVGImageLoader.cpp:
ksvg2/svg/SVGAElement.cpp:
ksvg2/svg/SVGAnimateTransformElement.cpp:
ksvg2/svg/SVGAnimationElement.cpp:
ksvg2/svg/SVGCircleElement.cpp:
ksvg2/svg/SVGClipPathElement.cpp:
ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
ksvg2/svg/SVGCursorElement.cpp:
ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement):
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGEllipseElement.cpp:
ksvg2/svg/SVGExternalResourcesRequired.cpp:
ksvg2/svg/SVGFEBlendElement.cpp:
ksvg2/svg/SVGFEColorMatrixElement.cpp:
ksvg2/svg/SVGFEComponentTransferElement.cpp:
ksvg2/svg/SVGFECompositeElement.cpp:
ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
ksvg2/svg/SVGFEDisplacementMapElement.cpp:
ksvg2/svg/SVGFEFloodElement.cpp:
ksvg2/svg/SVGFEGaussianBlurElement.cpp:
ksvg2/svg/SVGFEImageElement.cpp:
ksvg2/svg/SVGFELightElement.cpp:
ksvg2/svg/SVGFEMergeElement.cpp:
ksvg2/svg/SVGFEMergeNodeElement.cpp:
ksvg2/svg/SVGFEOffsetElement.cpp:
ksvg2/svg/SVGFESpecularLightingElement.cpp:
ksvg2/svg/SVGFETileElement.cpp:
ksvg2/svg/SVGFETurbulenceElement.cpp:
ksvg2/svg/SVGFilterElement.cpp:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
ksvg2/svg/SVGFitToViewBox.cpp:
ksvg2/svg/SVGGradientElement.cpp:
ksvg2/svg/SVGImageElement.cpp:
ksvg2/svg/SVGLangSpace.cpp:
ksvg2/svg/SVGLineElement.cpp:
ksvg2/svg/SVGLinearGradientElement.cpp:
ksvg2/svg/SVGMarkerElement.cpp:
ksvg2/svg/SVGMaskElement.cpp:
ksvg2/svg/SVGPathElement.cpp:
ksvg2/svg/SVGPatternElement.cpp:
ksvg2/svg/SVGPolyElement.cpp:
ksvg2/svg/SVGRadialGradientElement.cpp:
ksvg2/svg/SVGRectElement.cpp:
ksvg2/svg/SVGSVGElement.cpp:
ksvg2/svg/SVGScriptElement.cpp:
ksvg2/svg/SVGStopElement.cpp:
ksvg2/svg/SVGStyledElement.cpp:
ksvg2/svg/SVGStyledTransformableElement.cpp:
ksvg2/svg/SVGSwitchElement.cpp:
ksvg2/svg/SVGTests.cpp:
ksvg2/svg/SVGTextContentElement.cpp:
ksvg2/svg/SVGTextPositioningElement.cpp:
ksvg2/svg/SVGTransformable.cpp:
ksvg2/svg/SVGURIReference.cpp:
ksvg2/svg/SVGUseElement.cpp:
ksvg2/svg/SVGViewElement.cpp:
ksvg2/svg/SVGZoomAndPan.cpp:
kwq/WebCoreTextArea.mm:
platform/Widget.h:
rendering/RenderBlock.cpp:
rendering/RenderCanvas.cpp:
rendering/RenderContainer.cpp:
rendering/RenderObject.cpp:
rendering/RenderTextField.cpp:
rendering/RenderThemeMac.mm:
rendering/bidi.cpp:
rendering/render_replaced.cpp:

3:22 AM Changeset in webkit [13479] by eseidel

11 edits in trunk/WebCore

2006-03-25 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix RenderStyle creation to avoid floating RenderStyle objects.
This also fixes a bug, were SVG to ever start sharing RenderStyles
between elements, code would have crashed as there were improperly
paired style->deref() statements in SVG code.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

No test possible (no functionality change).

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
css/cssstyleselector.h:
dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::createStyleForRenderer):
dom/Node.h:
dom/dom_elementimpl.cpp: (WebCore::Element::createStyleForRenderer): (WebCore::Element::recalcStyle):
dom/dom_elementimpl.h:
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::selectStartNode): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::getPseudoStyle):

2:46 AM Changeset in webkit [13478] by eseidel

3 edits
2 adds in trunk

2006-03-23 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Shave .2% on PLT by removing bogus strcmp.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

Test: fast/parser/tag-with-exclamation-point.html

html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp

2:17 AM Changeset in webkit [13477] by justing

16 edits
4 adds
2 deletes in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

editing/editing.js:
editing/execCommand/createLink-expected.checksum: Removed.
editing/execCommand/createLink-expected.png: Removed.
editing/execCommand/createLink-expected.txt:
editing/execCommand/createLink.html:
editing/execCommand/unlink-expected.txt: Added.
editing/execCommand/unlink.html: Added.

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

Added code to push partially selected anchor elements down before
creating or removing links to create fully selected chunks that can be removed.
Changed create_link_command_h to CreateLinkCommand_h
Gave styled element application/removal its own ApplyStyleCommand constructor.
Still need to add new EditActions (7974).

WebCore.xcodeproj/project.pbxproj:
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
editing/ApplyStyleCommand.h:
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::enclosingAnchorElement): (WebCore::CompositeEditCommand::pushAnchorElementDown): (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
editing/CompositeEditCommand.h:
editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
editing/CreateLinkCommand.h:
editing/JSEditor.cpp:
editing/Selection.cpp: (WebCore::Selection::selectionFromContentsOfNode):
editing/Selection.h:
editing/UnlinkCommand.cpp: Added. (WebCore::UnlinkCommand::UnlinkCommand): (WebCore::UnlinkCommand::doApply):
editing/UnlinkCommand.h: Added.
page/Frame.cpp: (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):

Mar 24, 2006:

7:34 PM Changeset in webkit [13476] by justing

1 edit in trunk/WebCore/ChangeLog

7:28 PM Changeset in webkit [13475] by justing

4 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document

editing/pasteboard/7955-expected.checksum: Added.
editing/pasteboard/7955-expected.png: Added.
editing/pasteboard/7955-expected.txt: Added.
editing/pasteboard/7955.html: Added.

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document

There's no safe place in the document to keep the fragment while pasting, so I avoid
isProbablyBlock by saving whether or not something was blockFlow during the test
insertion.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): (WebCore::ReplacementFragment::isBlockFlow): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::isBlockFlow): (WebCore::ReplacementFragment::renderingInfo): (WebCore::ReplacementFragment::nodes):

7:11 PM Changeset in webkit [13474] by eseidel

3 edits in trunk/WebCore

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

generate-derived-sources: fix clean builds on mac.

5:47 PM Changeset in webkit [13473] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Dave Harrison.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7942 nightlies after r13387 break js createcontextualfragment

fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
fast/dom/Range/create-contextual-fragment-expected.png: Added.
fast/dom/Range/create-contextual-fragment-expected.txt: Added.
fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

Reviewed by Dave Harrison.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7942 nightlies after r13387 break js createcontextualfragment

Test: fast/dom/Range/create-contextual-fragment.html

dom/Range.idl: Add createContextualFragment.

2:42 AM Changeset in webkit [13472] by eseidel

1 edit in trunk/WebCore/ChangeLog

Fix typo

2:41 AM Changeset in webkit [13471] by eseidel

2 edits in trunk/WebKitTools

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Build fix.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::openURL): replace QString with DeprecatedString

2:40 AM Changeset in webkit [13470] by eseidel

13 edits in trunk/WebCore

2006-03-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.
Uninify mac/win dependency handling.
Fix class vs. struct linker problem for win32.

WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
WebCore.vcproj/WebCore/build-generated-files.sh:
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.h:
generate-derived-sources:
kwq/AccessibilityObjectCache.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp:
platform/mac/GraphicsContextMac.mm:
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectedText): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

Mar 23, 2006:

11:17 PM Changeset in webkit [13469] by darin

2 edits in trunk/WebKitSite

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7918 Coding style doc uses illegal entity

coding/coding-style.html: Changed &emdash; to —.

11:15 PM Changeset in webkit [13468] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

JSObject in LiveConnect not working. http://bugzilla.opendarwin.org/show_bug.cgi?id=7917

bindings/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base class, and the GetFieldID was using the wrong signature.

11:07 PM Changeset in webkit [13467] by darin

10 edits in trunk/WebCore

Reviewed by Adele.

fix <rdar://problem/4484787> KWQAccObject dangles under GC

kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change from CF dictionaries to HashMap and HashSet.
kwq/AccessibilityObjectCache.mm: (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects and call CFRelease on all of them. (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting them in the HashMap, rather than assuming that retain == CFRetain. This is what fixes the GC issue. (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing. (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before. (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet. (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes. (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto. (WebCore::AccessibilityObjectCache::childrenChanged): Ditto. (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto. (WebCore::AccessibilityObjectCache::postNotification): Ditto.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]): Change to use functions by new names.

dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace. getAccObjectCache and ownerElement are const member functions, and m_accCache is a mutable data member.
dom/Document.cpp: (WebCore::Document::getAccObjectCache): Make const. (WebCore::Document::ownerElement): Make const.

kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject anchorElement]): Update for function name change. (-[WebCoreAXObject firstChild]): Ditto. (-[WebCoreAXObject lastChild]): Ditto. (-[WebCoreAXObject previousSibling]): Ditto. (-[WebCoreAXObject nextSibling]): Ditto. (-[WebCoreAXObject parentObject]): Ditto. (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto. (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto. (AXLinkElementForNode): Ditto. (AXAttributedStringAppendReplaced): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto. (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto. (-[WebCoreAXObject axObjectID]): Change field name to m_id. (-[WebCoreAXObject setAXObjectID:]): Ditto. (-[WebCoreAXObject removeAXObjectID]): Ditto.

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Remove ifdefs. (WebCore::RenderContainer::appendChildNode): Ditto. (WebCore::RenderContainer::insertChildNode): Ditto.
rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.

11:05 PM Changeset in webkit [13466] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix buildbot

JavaScriptCore.xcodeproj/project.pbxproj: Change target name to JavaScriptCore (it was "include"!?). Also add -Y 3 option for linker.

10:28 PM Changeset in webkit [13465] by darin

23 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

kjs/object.h: Take function name, as well as source URL and line number, when using the special overloaded construct for making functions.
kjs/object.cpp: (KJS::JSObject::construct): Ditto.
kjs/function_object.h: Ditto.
kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when constructing the function rather than null. Use "anonymous" when making a function using the default function constructor.

kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before a function declaration.

unrelated fix

kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

fast/js/resources/function-names.js: Added.
fast/js/function-names.html: Generated.
fast/js/function-names-expected.txt: Generated.

WebCore:

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726 REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

Test: fast/js/function-names.html

dom/Document.h: Add function name parameter to createHTMLEventListener.
dom/Document.cpp: (WebCore::Document::createHTMLEventListener): Pass function name when calling createHTMLEventHandler. (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name when calling createHTMLEventListener.

html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute name as function name when calling createHTMLEventListener.

khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name. (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.

khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and createSVGEventHandler.
khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating a JSLazyEventListener. (WebCore::KJSProxy::createSVGEventHandler): Ditto.

ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to JSSVGLazyEventListener.
ksvg2/events/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name on to the base class constructor.

ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when calling createSVGEventHandler.

ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner): Pass attribute name as function name when calling createSVGEventListener.

WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.

5:51 PM Changeset in webkit [13464] by tomernic

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Layout test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

fast/forms/button-default-title-expected.checksum: Added.
fast/forms/button-default-title-expected.png: Added.
fast/forms/button-default-title-expected.txt: Added.
fast/forms/button-default-title.html: Added.

WebCore:

Reviewed by Darin.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueWithDefault): Only use the default button title if no title was specified; previously we'd use the default button title if the specified title was empty, which is not what Firefox does.

5:20 PM Changeset in webkit [13463] by darin

14 edits in trunk/LayoutTests

removed merge artifacts from .checksum files

fast/block/float/vertical-move-relayout-expected.checksum:
fast/css/first-letter-detach-expected.checksum:
fast/css/hover-subselector-expected.checksum:
fast/dom/Element/class-attribute-whitespace-expected.checksum:
fast/events/event-sender-mouse-moved-expected.checksum:
fast/forms/form-hides-table-expected.checksum:
fast/invalid/missing-address-end-tag-expected.checksum:
fast/invalid/missing-dl-end-tag-expected.checksum:
fast/invalid/missing-dt-end-tag-expected.checksum:
fast/invalid/missing-font-end-tag-expected.checksum:
fast/text/in-rendered-text-rtl-expected.checksum:
fast/tokenizer/missing-title-end-tag-1-expected.checksum:
fast/tokenizer/missing-title-end-tag-2-expected.checksum:

5:08 PM Changeset in webkit [13462] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Beth.

test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

fast/css/max-height-none-expected.checksum: Added.
fast/css/max-height-none-expected.txt: Added.
fast/css/max-height-none.html: Added.
fast/css/max-height-none-expected.png: Added.

WebCore:

Reviewed by Beth.

fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.

2:44 PM Changeset in webkit [13461] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed, tweaked, and landed by Beth.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

2:27 PM Changeset in webkit [13460] by bdakin

2 edits in trunk/WebCore

Reviewed by Darin

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
REGRESSION: style change where :hover changes only an :after style
doesn't work

dom/Node.cpp: (WebCore::Node::diff): Need to call diff() on the before and after styles if we have them.

2:07 PM Changeset in webkit [13459] by tomernic

4 edits in trunk/WebKit

Reviewed by John Sullivan.

At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

WebView/WebFramePrivate.h: Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is cancelled and when a redirect is successfully committed.
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge reportClientRedirectCancelled:]): Call renamed WebFrame method.
WebView/WebFrame.m: Added sentRedirectNotification flag to WebFramePrivate. This flag is set when we notify the frame load delegate that a redirect will occur. We check this flag when committing a provisional load to ensure that the frame load delegate is notified that the redirect finished. (-[WebFrame _commitProvisionalLoad:]): After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending redirect. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Set the new sentRedirectNotification flag. (-[WebFrame _clientRedirectCancelledOrFinished:]): Renamed method. Clear the sentRedirectNotification flag. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Call renamed method.

1:58 PM Changeset in webkit [13458] by adele

3 edits
4 adds in trunk

LayoutTests:

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935 <rdar://problem/4489010> Infinite recursion in table code when button or new text fields get display:table-row

Added:

fast/forms/button-table-styles.txt: Added.
fast/forms/button-table-styles.png: Added.
fast/forms/button-table-styles.checksum: Added.
fast/forms/button-table-styles.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935 <rdar://problem/4489010> Infinite recursion in table code when button or new text fields get display:table-row

Test:
fast/forms/button-table-styles.html

rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): The theme should disallow table display styles form elements.

1:28 PM Changeset in webkit [13457] by tomernic

1 edit in trunk/WebKit/ChangeLog

Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

1:17 PM Changeset in webkit [13456] by tomernic

2 edits in trunk/WebKit

Reviewed by Eric.

fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

8:31 AM Changeset in webkit [13455] by darin

12 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7805 LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod

bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT, BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in one case and remove a _NPN_ReleaseObject in another because this should return a retained value. (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN, NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.

bindings/c/c_runtime.h: Removed implementations of CMethod::name and CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
bindings/c/c_runtime.cpp: (KJS::Bindings::CMethod::name): Added. Returns the string from inside the method object. (KJS::Bindings::CField::name): Added. Returns the string from inside the field object. (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue on the result of getProperty after using it to fix a storage leak. (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue after pasing a value to setProperty now that the conversion function does a retain.

bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local stack buffer. Removed special case for NPVARIANT_IS_VOID because the convertNPVariantToValue function handles that properly. (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.

bindings/NP_jsobject.h: Formatting changes only.
bindings/NP_jsobject.cpp: (jsDeallocate): Changed parameter type so we don't need a function cast. (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT. (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT. (_NPN_Evaluate): Use VOID_TO_NPVARIANT. (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.

bindings/c/c_class.cpp: Formatting changes only.
bindings/c/c_class.h: Formatting changes only.

bindings/npruntime_priv.h: Removed obsolete and now-unused functions: NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined, NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble, NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool, NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString, NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid, NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined, NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32, NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString, NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
bindings/npruntime.cpp: (getIntIdentifierDictionary): Don't bother creating custom callbacks for the integer dictionary since the default behavior is fine for integers.

8:08 AM Changeset in webkit [13454] by darin

2 edits in trunk/WebCore

generate-derived-sources: Tweaked formatting a tiny bit and removed a stray touch that was left in here.

7:36 AM Changeset in webkit [13453] by darin

2 edits in trunk/WebKit

Reviewed by Eric.

fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

12:21 AM Changeset in webkit [13452] by eseidel

3 edits in trunk/WebCore

2006-03-23 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

REGRESSION: Dashed borders paint with the wrong phase
http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

Test: Already covered by css1/box_properties/border_style.html

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):

Mar 22, 2006:

10:30 PM Changeset in webkit [13451] by mjs

2 edits in trunk/WebCore

Reviewed by Eric.

generate-derived-sources: Suppress warning.

10:13 PM Changeset in webkit [13450] by mjs

2 edits in trunk/WebCore

generate-derived-sources: Added.

10:03 PM Changeset in webkit [13449] by mjs

9 edits
1 add
4 deletes in trunk/WebCore

Reviewed by Eric.

Handle dependencies for derived sources properly.

Made a new generate-derived-sources script that does all the depedency checking and source generation.
Put this script in a subtarget instead of a phase.
Made derived sources go in the build root, not a source root.
Added derived sources to the project.
Removed files whose sole purpose was to include and compile derived sources, just compile those directly for now.
Tweaked the IDL code generator so it can handle one IDL at a time, to make it easier to get the dependencies right.

generate-derived-sources: Added.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMCore.cpp: Removed.
bindings/js/JSDOMEvents.cpp: Removed.
bindings/js/JSDOMHTML.cpp: Removed.
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/generate-bindings.pl:
css/UserAgentStyleSheets.cpp: Removed.
dom/Range.cpp: (WebCore::Range::~Range):
dom/Range.h:
khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRuleList::DOMCSSRuleList): (KJS::DOMCSSRule::DOMCSSRule):
khtml/ecma/kjs_css.h:

9:46 PM Changeset in webkit [13448] by mjs

2 edits in trunk/JavaScriptCore

Reviewed and landed by Maciej.

WebKit no longer builds with bison 2.1 http://bugzilla.opendarwin.org/show_bug.cgi?id=7923

generate-derived-sources: Handle generated header named either grammar.cpp.h or grammar.hpp.

5:37 PM Changeset in webkit [13447] by justing

4 edits
5 adds
1 delete in trunk

LayoutTests:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

Added:

editing/pasteboard/display-block-on-spans-expected.txt: Added.
editing/pasteboard/display-block-on-spans-expected.png: Added.
editing/pasteboard/display-block-on-spans-expected.checksum: Added.
editing/pasteboard/display-block-on-spans.html: Added.

I'm disabling this layout test because of 7899:

editing/pasteboard/paste-empty-startcontainer.html

WebCore:

Reviewed by harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::computeAndStoreNodeStyles): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
editing/ReplaceSelectionCommand.h: (WebCore::ReplacementFragment::root):

5:31 PM Changeset in webkit [13446] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Even better fix for <rdar://problem/4432562>. We need to notify the frame delegate of a finished redirect for both
"fast" and "slow" redirects, after committing the load. My previous change only notified for "fast", history-locking
redirects. Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
a fast redirect.

WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]):

5:21 PM Changeset in webkit [13445] by eseidel

3 edits
2 adds in trunk

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix attribute mutation events to not fire for "style" attributes.
We lazily update style attributes, so sending mutation events for them makes no sense anymore.
<rdar://problem/4474910> repro assertion failure @ apple.com/store: !eventDispatchForbidden()

Test: fast/events/delayed-style-mutation-event-crash.html

dom/dom_elementimpl.cpp: (WebCore::Element::dispatchAttrRemovalEvent): add assert (WebCore::Element::dispatchAttrAdditionEvent): add assert (WebCore::NamedAttrMap::addAttribute):

3:37 PM Changeset in webkit [13444] by eseidel

18 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove more DeprecatedString usage.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): (WebCore::FrameMac::fontForSelection): (WebCore::FrameMac::tokenizerProcessedData): (WebCore::FrameMac::registerCommandForUndoOrRedo): (WebCore::FrameMac::markMisspellings): (WebCore::FrameMac::respondToChangedSelection): (WebCore::FrameMac::dashboardRegionsDictionary): (WebCore::FrameMac::dragSourceMovedTo):
css/CSSGrammar.y:
css/css_valueimpl.h:
css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseColorFromValue): (WebCore::yyerror): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
css/cssparser.h: (WebCore::deprecatedString):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty):
ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine):
rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::absolutePosition): (WebCore::RenderCanvas::paint):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
rendering/RenderObject.h:
rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
rendering/render_form.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
rendering/table_layout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):

3:33 PM Changeset in webkit [13443] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout text for <rdar://problem/4471984> repro crash CSS position
for html/table=relative causes crash when hiding table

2:42 PM Changeset in webkit [13442] by mjs

2 edits in trunk/JavaScriptCore

fix the build

JavaScriptCore.xcodeproj/project.pbxproj:

2:30 PM Changeset in webkit [13441] by tomernic

5 edits
4 adds in trunk

WebCore:

Reviewed by Kevin Decker.

Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: Removed redirectionTimerFired(). This was added as attempt to fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>. The aim was to cause Safari and WebKit to update their loading status after a redirect. Unfortunately, the fix had a bad side effect. Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed to lock history (i.e. reuse the current back/forward entry for the new page). The end result was that intermediate "quick" redirects were creating back/forward entries when they should not have been. See 4351664. That fix was almost correct, in that we do need to notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled. However, this is the wrong place to do it. WebCore's redirect notification logic did not need to change to fix 7058. The never-ending spinning indicators problem was actually caused by a bug at the WebKit level.

manual-tests/redirectHistory: Added.
manual-tests/redirectHistory/redir-1.html: Added.
manual-tests/redirectHistory/redir-2.html: Added.
manual-tests/redirectHistory/redir-3.html: Added. Manual test case. I couldn't figure out how to create a layout test for this, because it involves navigation through history and it was unclear how/when to tell DumpRenderTree to dump its output.

WebKit:

Reviewed by Kevin Decker.

Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]

WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect. This is a better fix for 7058 (<rdar://problem/4432562>). The original fix for 7058 changed the timing of the redirect cancel in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects. Clearing the redirect state here actually makes logical sense, as the redirect's target page is being committed at this point.

2:27 PM Changeset in webkit [13440] by eseidel

57 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7907

WebCore+SVG/kdom.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::setTypedIconURL):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::nsArray): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::bindingRootObject): (WebCore::FrameMac::windowScriptObject): (WebCore::FrameMac::windowScriptNPObject): (WebCore::FrameMac::partClearedInBegin): (WebCore::FrameMac::openURLFromPageCache):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreFrameBridge scrollToAnchor:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setMinimumLogicalFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setUserStyleSheetLocation:]):
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSGrammar.y:
css/css_stylesheetimpl.cpp: (WebCore::MediaList::setMediaText):
css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
css/cssparser.cpp: (WebCore::CSSParser::parseColor):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
css/cssstyleselector.h:
dom/Document.cpp: (WebCore::Document::resetActiveLinkColor): (WebCore::Document::nextState): (WebCore::Document::setUserStyleSheet): (WebCore::Document::processHttpEquiv): (WebCore::Document::recalcStyleSelector):
dom/Document.h: (WebCore::Document::userStyleSheet): (WebCore::Document::setPrintStyleSheet): (WebCore::Document::printStyleSheet):
editing/markup.cpp: (WebCore::createMarkup): (WebCore::createFragmentFromMarkup): (WebCore::createFragmentFromText):
editing/markup.h:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
html/html_baseimpl.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach):
html/html_headimpl.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
html/html_headimpl.h:
html/html_imageimpl.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
html/html_imageimpl.h: (WebCore::HTMLImageElement::compositeOperator):
html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::createRenderer):
ksvg2/svg/SVGStringList.cpp: (SVGStringList::reset):
kwq/AccessibilityObjectCache.h:
kwq/AccessibilityObjectCache.mm: (AccessibilityObjectCache::textMarkerForVisiblePosition): (AccessibilityObjectCache::postNotificationToTopWebArea): (AccessibilityObjectCache::postNotification):
kwq/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
kwq/KWQKHTMLSettings.h: (KHTMLSettings::userStyleSheetLocation): (KHTMLSettings::setUserStyleSheetLocation):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::selectedText):
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref):
page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::jScriptEnabled): (WebCore::Frame::javaEnabled): (WebCore::Frame::pluginsEnabled): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheet): (WebCore::Frame::requestObject): (WebCore::Frame::loadPlugin): (WebCore::Frame::referrer): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
platform/DeprecatedString.cpp: (DeprecatedString::replace):
platform/GraphicsContext.h:
platform/Image.h:
platform/KURL.cpp:
platform/KURL.h:
platform/PlatformString.h: (WebCore::String::String): (WebCore::String::replace):
platform/String.cpp: (WebCore::operator+):
platform/StringImpl.cpp: (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::replace):
platform/StringImpl.h:
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
rendering/render_frames.cpp: (WebCore::isURLAllowed): (WebCore::mapClassIdToServiceType): (WebCore::RenderPartObject::updateWidget):
rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
xml/xmlhttprequest.cpp: (WebCore::getCharset): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::overrideMIMEType):

2:21 PM Changeset in webkit [13439] by bdakin

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4471984> repro crash CSS position for html/
table=relative causes crash when hiding table

2:10 PM Changeset in webkit [13438] by mjs

2 edits in trunk/JavaScriptCore

kjs/generate-derived-sources: Set executable property.

2:10 PM Changeset in webkit [13437] by hyatt

5 edits in trunk/WebCore

Fix for residual style problem where form elements lose their connection
to a degenerate table form because of a residual style fixup. This is
Radar bug #4330765.

Reviewed by eric

khtml/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
khtml/html/HTMLFormElement.h: (WebCore::HTMLFormElement::setPreserveFormConnectionAcrossRemove): (WebCore::HTMLFormElement::preserveFormConnectionAcrossRemove):
khtml/html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):

2:09 PM Changeset in webkit [13436] by adele

2 edits
4 adds in trunk/WebCore

Reviewed by Adele.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7747 REGRESSION: Background tab/window auto-refresh in GMail will take focus.

manual-tests/named-window-blank-target.html: Added.
manual-tests/resources/named-window-blank-target-step2.html: Added.
manual-tests/resources/named-window-blank-target-step3.html: Added.
manual-tests/resources/named-window-blank-target-step4.html: Added.
page/FrameTree.cpp: (WebCore::FrameTree::find): If the given name is empty, just return our frame, even if it has a name.

1:31 PM Changeset in webkit [13435] by mjs

2 edits
1 add in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that generated source dependencies are handled properly, as follows:

Made an external script that generates the sources into a DerivedSources dir in the build products directory.
Added a new build target that builds all the generated sources if needed. Sadly it has to be a target, not a phase for Xcode to notice changes.
Added the DerivedSources dir in question to the include path.
Added the new DerivedSources dir and its contents to the project as build-relative.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/generate-derived-sources: Added. Based on the windows version - maybe someday they can share more.

12:18 PM Changeset in webkit [13434] by darin

1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number.

12:16 PM Changeset in webkit [13433] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

test for <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

fast/dom/Element/onclick-case-expected.txt: Added.
fast/dom/Element/onclick-case.html: Added.

WebCore:

Reviewed by Adele.

fix <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

Test: fast/dom/Element/onclick-case.html

We discussed this with Maciej. In the long run we may need to remove the "all attributes
show up as properties in JavaScript" feature entirely. Gecko does not do it, and it's
not really the same thing IE does either.

khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::attributeGetter): Use getAttributeNS so we're case sensitive. (KJS::DOMElement::getOwnPropertySlot): Ditto.

12:02 PM Changeset in webkit [13432] by eseidel

2 edits in trunk/WebCore

2006-03-22 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

<rdar://problem/4486417> REGRESSION: Mail linked against TOT WebKit crashes when composing a message

No test possible.

bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings init]): call AtomicString::init()

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed