Timeline


and

05/08/06:

23:52 Changeset [14250] by andersca

2006-05-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.


  • Scripts/check-dom-results: Add XPath to the list of results.
18:27 Changeset [14249] by lweintraub

Reviewed by justin.


REGRESSION: two editing layout tests show incorrect spell checking in pixel test mode
http://bugzilla.opendarwin.org/show_bug.cgi?id=8350
Forgot to update expected results.

  • fast/dom/inner-text-001-expected.txt
17:53 Changeset [14248] by lweintraub

LayoutTests:

Reviewed by justin.


REGRESSION: two editing layout tests show incorrect spell checking in pixel test mode
http://bugzilla.opendarwin.org/show_bug.cgi?id=8350

  • editing/pasteboard/innerText-inline-table-expected.checksum: Added.
  • editing/pasteboard/innerText-inline-table-expected.png: Added.
  • editing/pasteboard/innerText-inline-table-expected.txt: Added.
  • editing/pasteboard/innerText-inline-table.html: Added.

WebCore:

Reviewed by justin.

  • editing/TextIterator.cpp: (WebCore::shouldEmitSpaceBeforeAndAfterNode): Returns true when the node should have a leading and trailing space. Currently only used for inline tables. The function shouldEmitNewlinesBeforeAndAfterNode has a fallback for nodes with no RenderObject, but the inline property doesn't really have a meaning without one. (WebCore::TextIterator::handleNonTextNode): Checks shouldEmitSpaceBeforeAndAfterNode and inserts a space if necessary. (WebCore::TextIterator::exitNode): Checks shouldEmitSpaceBeforeAndAfterNode and inserts a space if necessary.
17:49 Changeset [14247] by darin
  • Scripts/do-webcore-rename: Add another rename.
17:36 Changeset [14246] by thatcher

Reviewed by Tim O.

  • bindings/npapi.h: do not define #pragma options align=mac68k if we are 64-bit
17:13 Changeset [14245] by thatcher

Adding a ARGS variable that can be used to pass arguments to xcodebuild. This is handy when you want to temporary overide a build setting, like ARCHS. Use: make r ARGS='ARCHS=ppc64'

15:20 Changeset [14244] by andersca

Remove \impl from files who aren't actually in the \impl directory...let's hope this does it

15:11 Changeset [14243] by andersca

Add xpath\impl to include path as well.

15:06 Changeset [14242] by andersca

Add XPATH_SUPPORT define. This is getting old...

15:01 Changeset [14241] by andersca

Add xpath in _both_ places

14:56 Changeset [14240] by andersca

Another try, now add xpath to the include path

14:50 Changeset [14239] by andersca

2006-05-08 Anders Carlsson <acarlsson@apple.com>

Try fixing the Win32 build


  • WebCore.vcproj/WebCore/WebCore.vcproj: Add XPath files to project.
14:34 Changeset [14238] by thatcher

Tag for WebCore 418.2 (part 2 of 2.)

14:34 Changeset [14237] by thatcher

Tag for WebCore 418.2 (part 1 of 2.)

14:31 Changeset [14236] by thatcher

Versioning

14:30 Changeset [14235] by andersca

2006-05-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Add DOM3 xpath tests as self-contained SVG files.


  • dom/svg: Added.
  • dom/svg/level3: Added.
  • dom/svg/level3/xpath: Added.
  • dom/svg/level3/xpath/Attribute_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Attribute_Nodes.js: Added.
  • dom/svg/level3/xpath/Attribute_Nodes.svg: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns-expected.txt: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.js: Added.
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.svg: Added.
  • dom/svg/level3/xpath/Comment_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Comment_Nodes.js: Added.
  • dom/svg/level3/xpath/Comment_Nodes.svg: Added.
  • dom/svg/level3/xpath/Conformance_Expressions-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_Expressions.js: Added.
  • dom/svg/level3/xpath/Conformance_Expressions.svg: Added.
  • dom/svg/level3/xpath/Conformance_ID-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_ID.js: Added.
  • dom/svg/level3/xpath/Conformance_ID.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_3.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.svg: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null.js: Added.
  • dom/svg/level3/xpath/Conformance_hasFeature_null.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_3.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_empty.svg: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null.js: Added.
  • dom/svg/level3/xpath/Conformance_isSupported_null.svg: Added.
  • dom/svg/level3/xpath/Element_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Element_Nodes.js: Added.
  • dom/svg/level3/xpath/Element_Nodes.svg: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.js: Added.
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.svg: Added.
  • dom/svg/level3/xpath/Text_Nodes-expected.txt: Added.
  • dom/svg/level3/xpath/Text_Nodes.js: Added.
  • dom/svg/level3/xpath/Text_Nodes.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01.js: Added.
  • dom/svg/level3/xpath/XPathEvaluatorCast01.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.svg: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.svg: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement-expected.txt: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.js: Added.
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.svg: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml-expected.txt: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.js: Added.
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.svg: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.js: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.svg: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.js: Added.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.js: Added.
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_iteratorNext_UNORDERED_NODE_ITERATOR_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue.js: Added.
  • dom/svg/level3/xpath/XPathResult_numberValue.svg: Added.
  • dom/svg/level3/xpath/XPathResult_resultType-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_resultType.js: Added.
  • dom/svg/level3/xpath/XPathResult_resultType.svg: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.js: Added.
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.svg: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue.js: Added.
  • dom/svg/level3/xpath/XPathResult_stringValue.svg: Added.
  • dom/svg/level3/xpath/svgunit.js: Added.
14:27 Changeset [14234] by andersca

2006-05-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin, Eric and Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6638
Support Mozilla's XPathEvaluator object.


  • DerivedSources.make: Generate XPath grammar, and JavaScript wrappers.


  • WebCore.xcodeproj/project.pbxproj: Add new files to project


  • bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException): Handle setting XPath exceptions.


  • bindings/objc/DOM.mm: Just return nil for now when trying to create a wrapper for XPath namespace nodes.
  • bindings/scripts/CodeGeneratorJS.pm: Add XPath types. Also add a "CanBeConstructed" extended attribute for interfaces that can be constructed directly.


  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize LogXPath channel.


  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): Support "xpath" version "3.0".


  • dom/Document.cpp: (WebCore::Document::Document):


(WebCore::Document::importNode):
Ignore XPath namespace nodes.


(WebCore::Document::createExpression):
(WebCore::Document::createNSResolver):
(WebCore::Document::evaluate):
New functions which call down to a lazily created XPathEvaluator.

  • dom/Document.h: Add function declarations.


  • dom/Document.idl: Add XPath methods.


  • dom/Node.h: (WebCore::Node::): Add XPATH_NAMESPACE_NODE type.


  • editing/markup.cpp: (WebCore::startMarkup): Ignore XPath namespace nodes.


  • page/DOMWindow.idl: Add constructors for XPathEvaluator and XPathResult.


  • platform/Logging.cpp:
  • platform/Logging.h: Add XPath log channel
  • xpath: Added.
  • xpath/XPathEvaluator.cpp: Added. (WebCore::XPathEvaluator::createExpression): (WebCore::XPathEvaluator::createNSResolver): (WebCore::XPathEvaluator::evaluate):
  • xpath/XPathEvaluator.h: Added. (WebCore::):
  • xpath/XPathEvaluator.idl: Added.
  • xpath/XPathExpression.cpp: Added. (WebCore::XPathExpression::createExpression): (WebCore::XPathExpression::~XPathExpression): (WebCore::XPathExpression::evaluate):
  • xpath/XPathExpression.h: Added.
  • xpath/XPathExpression.idl: Added.
  • xpath/XPathNSResolver.cpp: Added. (WebCore::XPathNSResolver::XPathNSResolver): (WebCore::XPathNSResolver::lookupNamespaceURI):
  • xpath/XPathNSResolver.h: Added.
  • xpath/XPathNSResolver.idl: Added.
  • xpath/XPathNamespace.cpp: Added. (WebCore::XPathNamespace::XPathNamespace): (WebCore::XPathNamespace::~XPathNamespace): (WebCore::XPathNamespace::ownerDocument): (WebCore::XPathNamespace::ownerElement): (WebCore::XPathNamespace::prefix): (WebCore::XPathNamespace::nodeName): (WebCore::XPathNamespace::nodeValue): (WebCore::XPathNamespace::namespaceURI): (WebCore::XPathNamespace::nodeType):
  • xpath/XPathNamespace.h: Added.
  • xpath/XPathResult.cpp: Added. (WebCore::InvalidatingEventListener::InvalidatingEventListener): (WebCore::InvalidatingEventListener::handleEvent): (WebCore::XPathResult::XPathResult): (WebCore::XPathResult::~XPathResult): (WebCore::XPathResult::convertTo): (WebCore::XPathResult::resultType): (WebCore::XPathResult::numberValue): (WebCore::XPathResult::stringValue): (WebCore::XPathResult::booleanValue): (WebCore::XPathResult::singleNodeValue): (WebCore::XPathResult::invalidateIteratorState): (WebCore::XPathResult::invalidIteratorState): (WebCore::XPathResult::snapshotLength): (WebCore::XPathResult::iterateNext): (WebCore::XPathResult::snapshotItem):
  • xpath/XPathResult.h: Added. (WebCore::XPathResult::):
  • xpath/XPathResult.idl: Added.
  • xpath/impl: Added.
  • xpath/impl/XPathExpressionNode.cpp: Added. (WebCore::XPath::Expression::evaluationContext): (WebCore::XPath::Expression::Expression): (WebCore::XPath::Expression::~Expression): (WebCore::XPath::Expression::evaluate): (WebCore::XPath::Expression::addSubExpression): (WebCore::XPath::Expression::optimize): (WebCore::XPath::Expression::subExprCount): (WebCore::XPath::Expression::subExpr): (WebCore::XPath::Expression::isConstant):
  • xpath/impl/XPathExpressionNode.h: Added. (WebCore::XPath::EvaluationContext::EvaluationContext):
  • xpath/impl/XPathFunctions.cpp: Added. (WebCore::XPath::Interval::Interval): (WebCore::XPath::Interval::contains): (WebCore::XPath::Interval::asString): (WebCore::XPath::Function::setArguments): (WebCore::XPath::Function::setName): (WebCore::XPath::Function::arg): (WebCore::XPath::Function::argCount): (WebCore::XPath::Function::name): (WebCore::XPath::FunLast::doEvaluate): (WebCore::XPath::FunLast::isConstant): (WebCore::XPath::FunPosition::doEvaluate): (WebCore::XPath::FunPosition::isConstant): (WebCore::XPath::FunLocalName::isConstant): (WebCore::XPath::FunLocalName::doEvaluate): (WebCore::XPath::FunNamespaceURI::isConstant): (WebCore::XPath::FunNamespaceURI::doEvaluate): (WebCore::XPath::FunName::isConstant): (WebCore::XPath::FunName::doEvaluate): (WebCore::XPath::FunCount::doEvaluate): (WebCore::XPath::FunCount::isConstant): (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunConcat::doEvaluate): (WebCore::XPath::FunStartsWith::doEvaluate): (WebCore::XPath::FunContains::doEvaluate): (WebCore::XPath::FunSubstringBefore::doEvaluate): (WebCore::XPath::FunSubstringAfter::doEvaluate): (WebCore::XPath::FunSubstring::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): (WebCore::XPath::FunTranslate::doEvaluate): (WebCore::XPath::FunBoolean::doEvaluate): (WebCore::XPath::FunNot::doEvaluate): (WebCore::XPath::FunTrue::doEvaluate): (WebCore::XPath::FunTrue::isConstant): (WebCore::XPath::FunLang::doEvaluate): (WebCore::XPath::FunLang::isConstant): (WebCore::XPath::FunFalse::doEvaluate): (WebCore::XPath::FunFalse::isConstant): (WebCore::XPath::FunNumber::doEvaluate): (WebCore::XPath::FunSum::doEvaluate): (WebCore::XPath::FunFloor::doEvaluate): (WebCore::XPath::FunCeiling::doEvaluate): (WebCore::XPath::FunRound::doEvaluate): (WebCore::XPath::FunctionLibrary::self): (WebCore::XPath::FunctionLibrary::FunctionLibrary): (WebCore::XPath::FunctionLibrary::createFunction):
  • xpath/impl/XPathFunctions.h: Added.
  • xpath/impl/XPathGrammar.y: Added.
  • xpath/impl/XPathParser.cpp: Added. (WebCore::XPath::): (WebCore::XPath::Parser::charCat): (WebCore::XPath::Parser::isAxisName): (WebCore::XPath::Parser::isNodeTypeName): (WebCore::XPath::Parser::isOperatorContext): (WebCore::XPath::Parser::skipWS): (WebCore::XPath::Parser::makeTokenAndAdvance): (WebCore::XPath::Parser::makeIntTokenAndAdvance): (WebCore::XPath::Parser::peekAheadHelper): (WebCore::XPath::Parser::peekCurHelper): (WebCore::XPath::Parser::lexString): (WebCore::XPath::Parser::lexNumber): (WebCore::XPath::Parser::lexNCName): (WebCore::XPath::Parser::lexQName): (WebCore::XPath::Parser::nextTokenInternal): (WebCore::XPath::Parser::nextToken): (WebCore::XPath::Parser::Parser): (WebCore::XPath::Parser::reset): (WebCore::XPath::Parser::lex): (WebCore::XPath::Parser::parseStatement): (WebCore::XPath::Parser::registerParseNode): (WebCore::XPath::Parser::unregisterParseNode): (WebCore::XPath::Parser::registerPredicateVector): (WebCore::XPath::Parser::unregisterPredicateVector): (WebCore::XPath::Parser::registerExpressionVector): (WebCore::XPath::Parser::unregisterExpressionVector): (WebCore::XPath::Parser::registerString): (WebCore::XPath::Parser::unregisterString):
  • xpath/impl/XPathParser.h: Added. (WebCore::XPath::Token::Token): (WebCore::XPath::Parser::): (WebCore::XPath::Parser::current):
  • xpath/impl/XPathPath.cpp: Added. (WebCore::XPath::Filter::Filter): (WebCore::XPath::Filter::~Filter): (WebCore::XPath::Filter::doEvaluate): (WebCore::XPath::LocationPath::LocationPath): (WebCore::XPath::LocationPath::~LocationPath): (WebCore::XPath::LocationPath::optimize): (WebCore::XPath::LocationPath::doEvaluate): (WebCore::XPath::Path::Path): (WebCore::XPath::Path::~Path): (WebCore::XPath::Path::doEvaluate):
  • xpath/impl/XPathPath.h: Added.
  • xpath/impl/XPathPredicate.cpp: Added. (WebCore::XPath::Number::Number): (WebCore::XPath::Number::isConstant): (WebCore::XPath::Number::doEvaluate): (WebCore::XPath::StringExpression::StringExpression): (WebCore::XPath::StringExpression::isConstant): (WebCore::XPath::StringExpression::doEvaluate): (WebCore::XPath::Negative::doEvaluate): (WebCore::XPath::NumericOp::NumericOp): (WebCore::XPath::NumericOp::doEvaluate): (WebCore::XPath::EqTestOp::EqTestOp): (WebCore::XPath::EqTestOp::doEvaluate): (WebCore::XPath::LogicalOp::LogicalOp): (WebCore::XPath::LogicalOp::shortCircuitOn): (WebCore::XPath::LogicalOp::isConstant): (WebCore::XPath::LogicalOp::doEvaluate): (WebCore::XPath::Union::doEvaluate): (WebCore::XPath::Predicate::Predicate): (WebCore::XPath::Predicate::~Predicate): (WebCore::XPath::Predicate::evaluate): (WebCore::XPath::Predicate::optimize):
  • xpath/impl/XPathPredicate.h: Added. (WebCore::XPath::NumericOp::): (WebCore::XPath::EqTestOp::): (WebCore::XPath::LogicalOp::):
  • xpath/impl/XPathStep.cpp: Added. (WebCore::XPath::Step::axisAsString): (WebCore::XPath::Step::Step): (WebCore::XPath::Step::~Step): (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeTestMatches): (WebCore::XPath::Step::optimize): (WebCore::XPath::Step::namespaceFromNodetest): (WebCore::XPath::Step::primaryNodeType):
  • xpath/impl/XPathStep.h: Added. (WebCore::XPath::Step::):
  • xpath/impl/XPathUtil.cpp: Added. (WebCore::XPath::isRootDomNode): (WebCore::XPath::stringValue): (WebCore::XPath::isValidContextNode):
  • xpath/impl/XPathUtil.h: Added.
  • xpath/impl/XPathValue.cpp: Added. (WebCore::XPath::Value::Value): (WebCore::XPath::Value::type): (WebCore::XPath::Value::isNodeVector): (WebCore::XPath::Value::isBoolean): (WebCore::XPath::Value::isNumber): (WebCore::XPath::Value::isString): (WebCore::XPath::Value::toNodeVector): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xpath/impl/XPathValue.h: Added. (WebCore::XPath::Value::):
  • xpath/impl/XPathVariableReference.cpp: Added. (WebCore::XPath::VariableReference::VariableReference): (WebCore::XPath::VariableReference::isConstant): (WebCore::XPath::VariableReference::doEvaluate):
  • xpath/impl/XPathVariableReference.h: Added.
11:46 Changeset [14233] by thatcher

Reviewed by Timothy.

<rdar://problem/4538833> 10.4.7 regression: Mail crashing frequently since updating to SUTiLondon 8J110

  • khtml/editing/markup.cpp: (khtml::createMarkup): add an early return if the range is collapsed
11:01 Changeset [14232] by hyatt

Remove an outdated comment from RenderBox.

10:49 Changeset [14231] by hyatt

Update layout test results.

10:31 Changeset [14230] by hyatt

Fix typo in variable name.

05:55 Changeset [14229] by jdevalk

changed checkout guide to point to universal binary.

01:19 Changeset [14228] by hyatt

Backing out caption box-sizing change. I want to do table stuff separately.

01:17 Changeset [14227] by hyatt

Comprehensive box-sizing fix. This patch changes all form controls to
have the right box-sizing values (text fields and text areas actually only
use border-box in quirks mode now, and image buttons never use border-box).

Tables are supposed to use border-box box-sizing as well, but that's a scary
enough change that I'm saving it for a separate patch.

Reviewed by mjs

  • css/html4.css:
  • css/quirks.css:
00:11 Changeset [14226] by ap

Reviewed by Darin.

Updated a test case affected by the previous checkin. &rang; and &lang; are
replaced with their canonical equivalents during normalization.

  • fast/parser/entities-in-xhtml-expected.checksum:
  • fast/parser/entities-in-xhtml-expected.txt:

05/07/06:

23:00 Changeset [14225] by darin

Tweak change log.

22:31 Changeset [14224] by hyatt

Land changes to mozilla table tests for bug 8060.

22:24 Changeset [14223] by hyatt

Land changes to mozilla table tests for bug 8060.

22:21 Changeset [14222] by hyatt

Land changes to mozilla table tests for bug 8060.

21:59 Changeset [14221] by mjs

JavaScriptCore:

Reviewed and landed by Maciej.


I haven't figured out how to construct a test for this, but this does seem to fix the
problem; Mitz mentioned that a double-destroy was occurring in these functions.


  • kxmlcore/HashMap.h: (KXMLCore::HashMap::remove): Use RefCounter::deref instead of calling ~ValueType, because ~ValueType often results in a double-destroy, since the HashTable also destroys the element based on the storage type. The RefCounter template correctly does work only in cases where ValueType and ValueStorageType differe and this class is what's used elsewhere for the same purpose; I somehow missed this case when optimizing HashMap.
  • kxmlcore/HashSet.h: (KXMLCore::HashSet::remove): Ditto.

WebCore:

Suggested by Mitz. Reviewed and landed by Maciej.


  • dom/Document.cpp: (WebCore::Document::formElementsState): Fixed mistake where the vector has an initial size and instead should have an initial capacity. Harmless in a way, but hurts performance.
21:18 Changeset [14220] by hyatt

Land new results for fast/table to account for bug 8060.

21:14 Changeset [14219] by hyatt

Fix for bugzilla bug 8060.

Fixed width table cells weren't having their border widths
included in the effective width of the column (and thus could end up being
too small).

Reviewed by darin

Added fast/tables/fixed-cell-growth.html

  • rendering/table_layout.cpp: (WebCore::AutoTableLayout::recalcColumn):
11:07 Changeset [14218] by ap

Fix a typo in te ChangeLog.

11:01 Changeset [14217] by ap

Reviewed by Darin.

Tests:

  • fast/forms/form-data-encoding.html
  • fast/forms/form-data-encoding-2.html
  • platform/mac/TextEncodingMac.cpp: (WebCore::TextEncoding::fromUnicode): Normalize the string; handle surrogate pairs.

05/06/06:

01:40 Changeset [14216] by hyatt

Rename WebCoreFont to FontPlatformData and WebTextRenderer to FontData. Merge them into the
headers (uncleanly with ifdefs at the moment, so I can see what I'm working towards).

Reviewed by mjs

  • ChangeLog:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontData.h: (WebCore::FontData::ascent): (WebCore::FontData::descent): (WebCore::FontData::lineSpacing): (WebCore::FontData::lineGap): (WebCore::FontData::misspellingLineThickness): (WebCore::FontData::misspellingLinePatternWidth): (WebCore::FontData::misspellingLinePatternGapWidth):
  • platform/FontDataSet.h: Removed.
  • platform/FontFallbackList.h: Added.
  • platform/FontPlatformData.h:
  • platform/mac/FontData.mm: Added. (WebCore::WebCoreInitializeFont): (WebCore::WebCoreInitializeEmptyTextGeometry): (WebCore::widthForGlyph): (WebCore::overrideLayoutOperation): (WebCore::FontData::~FontData): (WebCore::FontData::xHeight): (WebCore::FontData::drawRun): (WebCore::FontData::floatWidthForRun): (WebCore::FontData::drawLineForCharacters): (WebCore::FontData::selectionRectForRun): (WebCore::FontData::drawHighlightForRun): (WebCore::FontData::drawLineForMisspelling): (WebCore::FontData::pointToOffset): (WebCore::FontData::setAlwaysUseATSU): (WebCore::getSmallCapsRenderer): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::computeWidthForSpace): (WebCore::setUpFont): (WebCore::CG_drawHighlight): (WebCore::CG_selectionRect): (WebCore::CG_draw): (WebCore::CG_floatWidthForRun): (WebCore::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::initializeATSUStyle): (WebCore::createATSULayoutParameters): (WebCore::getTextBounds): (WebCore::ATSU_floatWidthForRun): (WebCore::ATSU_drawHighlight): (WebCore::ATSU_selectionRect): (WebCore::ATSU_draw): (WebCore::ATSU_pointToOffset): (WebCore::advanceWidthIteratorOneCharacter): (WebCore::CG_pointToOffset): (WebCore::glyphForCharacter): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::m_font): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::platformFont): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::Font::platformFont): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth): (WebCoreSetAlwaysUseATSU):
  • platform/mac/WebTextRenderer.h: Removed.
  • platform/mac/WebTextRenderer.mm: Removed.
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory isFontFixedPitch:]): (-[WebTextRendererFactory init]): (-[WebTextRendererFactory rendererWithFont:]): (-[WebTextRendererFactory fontWithFamilies:traits:size:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):

05/05/06:

16:48 Changeset [14215] by darin
  • fix the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData):
16:17 Changeset [14214] by adele

Reviewed by

Merged this fix for:
<rdar://problem/4537287> REGRESSION: All text links are broken at yahoo.com

A recent change to dispatching click events exposed this bug in a new way.

2005-10-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5180
event.stopPropagation() prevents the default action - it shouldn't

  • khtml/ecma/kjs_events.cpp: (KJS::DOMEventProtoFunc::callAsFunction): Don't let stopPropagation fall through to preventDefault.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchGenericEvent): Don't let stopPropagation prevent calling default event handlers; only preventDefault does that.
15:56 Changeset [14213] by darin
  • platform/SegmentedString.h: (WebCore::SegmentedString::advance): Oops! Removed an extra ! that was causing everything to fail.
15:50 Changeset [14212] by darin

Reviewed by Tim Hatcher.

  • remove a few of the stranger features of QChar on the road to eventually replacing it with an integer type (probably ICU's UChar)
  • platform/DeprecatedString.h: Remove SpecialCharacter, byteOrderMark, null, cell, row, isNull, mirrored, mirroredChar, operator char, >, >=, <, and <= from QChar. Also removed the many unneeded friend declarations. Remove findArg and arg from DeprecatedString.
  • dom/Document.cpp: (WebCore::Document::parseQualifiedName): Cast the type of the buffer before invoking the U16_NEXT function. Turns out this was converting each QChar to a char and back to a UChar, which means it caused a bug with characters that are U+0100 or greater.
  • css/csshelper.cpp: (WebCore::parseURL):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::constrainValue):
  • platform/StringImpl.cpp: (WebCore::StringImpl::toCoordsArray):
  • xml/xmlhttprequest.cpp: (WebCore::getCharset): Add some calls to unicode() since we don't have comparison operators any more.
  • dom/StyledElement.cpp: (WebCore::toHex): Rewrote to just take a UChar parameter. (WebCore::StyledElement::addCSSColor): Call toHex on the character code.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextBox):
  • platform/SegmentedString.h: (WebCore::SegmentedString::push): (WebCore::SegmentedString::advance): (WebCore::SegmentedString::escaped):
  • platform/SegmentedString.cpp: (WebCore::SegmentedString::length): (WebCore::SegmentedString::append): (WebCore::SegmentedString::prepend): (WebCore::SegmentedString::toString): Changed calls to isNull() to instead just use unicode() and check for 0.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseEntity): Change callers that used cell and row to just use unicode() instead. (WebCore::HTMLTokenizer::parseTag): Ditto.
  • loader/Decoder.cpp: (Decoder::decode): Changed code that did a type cast to unsigned char to instead call unicode().
  • platform/DeprecatedString.cpp: (KWQStringData::makeAscii): Call latin1() instead of relying on the conversion operator. (DeprecatedString::DeprecatedString): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::at): Use 0 instead of QChar::null. (DeprecatedString::compare): Use unicode() so we can do comparison since we don't have comparison operators any more. (DeprecatedString::find): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::findRev): Ditto. (DeprecatedString::copyLatin1): Call latin1() instead of relying on the conversion operator. (DeprecatedString::lower): Call unicode() instead of relying on the conversion operator (the character has been tested and is known to be ASCII). (DeprecatedString::insert): Ditto. (DeprecatedString::replace): Ditto. (DeprecatedString::fill): Ditto. (DeprecatedString::append): Ditto.
  • html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Eliminate the one use of DeprecatedString::arg.
  • other cleanup
  • kwq/KWQCString.cpp: Remove unneeded "using" directive.
  • html/HTMLElementFactory.cpp: (WebCore::htmlConstructor): (WebCore::headConstructor): (WebCore::bodyConstructor): (WebCore::baseConstructor): (WebCore::linkConstructor): (WebCore::metaConstructor): (WebCore::styleConstructor): (WebCore::titleConstructor): (WebCore::frameConstructor): (WebCore::framesetConstructor): (WebCore::iframeConstructor): (WebCore::formConstructor): (WebCore::buttonConstructor): (WebCore::inputConstructor): (WebCore::isindexConstructor): (WebCore::fieldsetConstructor): (WebCore::labelConstructor): (WebCore::legendConstructor): (WebCore::optgroupConstructor): (WebCore::optionConstructor): (WebCore::selectConstructor): (WebCore::textareaConstructor): (WebCore::dlConstructor): (WebCore::ulConstructor): (WebCore::olConstructor): (WebCore::dirConstructor): (WebCore::menuConstructor): (WebCore::liConstructor): (WebCore::blockquoteConstructor): (WebCore::divConstructor): (WebCore::headingConstructor): (WebCore::hrConstructor): (WebCore::paragraphConstructor): (WebCore::preConstructor): (WebCore::basefontConstructor): (WebCore::fontConstructor): (WebCore::modConstructor): (WebCore::anchorConstructor): (WebCore::imageConstructor): (WebCore::mapConstructor): (WebCore::areaConstructor): (WebCore::canvasConstructor): (WebCore::appletConstructor): (WebCore::embedConstructor): (WebCore::objectConstructor): (WebCore::paramConstructor): (WebCore::scriptConstructor): (WebCore::tableConstructor): (WebCore::tableCaptionConstructor): (WebCore::tableColConstructor): (WebCore::tableRowConstructor): (WebCore::tableCellConstructor): (WebCore::tableSectionConstructor): (WebCore::brConstructor): (WebCore::quoteConstructor): (WebCore::marqueeConstructor): Mark functions static, remove unused parameters, change from docPtr to doc.
13:35 Changeset [14211] by ap

Reviewed by Maciej.

Test: fast/parser/broken-comments-vs-parsing-mode.html

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Call determineParseMode() if needed.
13:30 Changeset [14210] by darin
  • fix the Windows build (this time for sure)
  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::translate): Added. (GraphicsContext::rotate): Ditto. (GraphicsContext::scale): Ditto.
09:53 Changeset [14209] by darin
  • fix the Windows build
  • bridge/win/FrameWin.h: Add Element* parameter to createPlugin.
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): Ditto.
09:37 Changeset [14208] by darin
  • get the Window build a little closer to building again
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawRect): Call alpha to check if the color is transparent. Call setColor directly instead of setColorFromPen. (WebCore::GraphicsContext::drawLine): Ditto. (WebCore::GraphicsContext::drawEllipse): Ditto. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: (JavaAppletWidget::JavaAppletWidget): Updated parameter types.
08:22 Changeset [14207] by darin

Reviewed by Adele.

  • manual-tests/form-value-restore.html: Added.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Rewrote to call the new formElementsState function on the document and also to convert null strings to NSNull instead of empty NSString objects. (-[WebCoreFrameBridge restoreDocumentState]): Ditto, with the setStateForNewFormElements function.
  • dom/Document.h: Added FormElementKey, FormElementKeyHash, and FormElementKeyHashTraits for use in the hash map. Made readyState, inputEncoding, defaultCharset, charset, characterSet, getElementByAccessKey, haveStylesheetsLoaded, usesDescendantRules, usesSiblingRules, inCompatMode, inAlmostStrictMode, inStrictMode, preferredStylesheetSet, selectedStylesheetSet, and getCSSTarget all const member functions. Removed the unused nextState function. Renamed registerMaintainsState and deregisterMaintainsState to registerFormElementWithState and HTMLGenericFormElement and changed them to use form elements rather than arbitrary DOM nodes. Replaced docState with formElementsState and setRestoreState and restoreState with setStateForNewFormElements, hasStateForNewFormElements, and takeStateForFormElement. Replaced m_maintainsState with m_formElementsWithState, m_state with m_stateForNewFormElements. Made m_elementsByAccessKey and m_accessKeyMapValid mutable. Removed unused m_elementNames, m_elementNameAlloc, m_elementNameCount, m_attrNames, m_attrNameAlloc, m_attrNameCount, m_namespaceURIs, m_namespaceURIAlloc, m_namespaceURICount.
  • dom/Document.cpp: (WebCore::Document::Document): Remove initialization of long-obsolete m_elementNames and m_attrNames. (WebCore::Document::~Document): Remove destruction of same. (WebCore::Document::readyState): Made const. (WebCore::Document::inputEncoding): Ditto. (WebCore::Document::defaultCharset): Ditto. (WebCore::Document::getElementByAccessKey): Ditto. (WebCore::Document::preferredStylesheetSet): Ditto. (WebCore::Document::selectedStylesheetSet): Ditto. (WebCore::Document::getCSSTarget): Ditto. (WebCore::Document::formElementsState): Added. Replaces the old docState function. Builds a vector of strings, with 3 strings for each form element containing the name, type, and state value. (WebCore::Document::setStateForNewFormElements): Added. Converts the state vector into a hash map, considering the scheme with 3 strings for form element used above. (WebCore::Document::hasStateForNewFormElements): Added. (WebCore::Document::takeStateForFormElement): Added. Given a name and type, looks up the values in the hash map and "peels off" the last one. (WebCore::FormElementKey::FormElementKey): Added. (WebCore::FormElementKey::~FormElementKey): Added. (WebCore::FormElementKey::operator=): Added. (WebCore::FormElementKey::ref): Added. (WebCore::FormElementKey::deref): Added. (WebCore::FormElementKeyHash::hash): Added. (WebCore::FormElementKeyHashTraits::deletedValue): Added.
  • dom/Element.h: Removed state function.
  • dom/Node.h: Removed maintainsState, state, and restoreState functions.
  • dom/Node.cpp: Ditto.
  • dom/QualifiedName.cpp: Reformatted. (WebCore::hashComponents): Removed code to handle buffers that are not multiples of 4 bytes, since a QualifiedName is guaranteed to be; also asserted that fact.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::insertNode): Remove code to restore state; that's now handled by closeRenderer. (WebCore::HTMLParser::popOneBlock): Ditto.
  • html/HTMLFormElement.cpp: Added include of HTMLInputElement.h.
  • html/HTMLGenericFormElement.h: Changed form to be a const member function. Changed type function to return a const AtomicString& instead of a String. Added an override of closeRenderer. Removed state and findMatchingState functions. Added stateValue and restoreState functions. Made m_form, m_disabled, and m_readOnly be private instead of protected. Removed m_inited. Changed booleans to not use bit fields since there are only two of them.
  • html/HTMLGenericFormElement.cpp: Removed encodedElementName, state, and findMatchingState functions. (WebCore::HTMLGenericFormElement::stateValue): Added. No implementation. This will only be called for subclasses that call registerFormElementWithState, and those will override and implement it. (WebCore::HTMLGenericFormElement::restoreState): Ditto. (WebCore::HTMLGenericFormElement::closeRenderer): Added. Replaces code that was in the HTML parser. Calls takeStateForFormElement, passing in the name and type, and if a state is found, calls restoreState.
  • html/HTMLButtonElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::type): Return a const AtomicString& instead of a String. (WebCore::HTMLButtonElement::defaultEventHandler): Use form() instead of m_form. (WebCore::HTMLButtonElement::isSuccessfulSubmitButton): Use disabled() instead of m_disabled.
  • html/HTMLInputElement.h: Changed type to return a const AtomicString& instead of a String. Removed maintainsState, state, and restoreState functions, and added new stateValue and restoreState functions. Added m_inited (moved here from the generic form element base class).
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Call registerFormElementWithState. This was formerly done by the HTML parser. (WebCore::HTMLInputElement::~HTMLInputElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLInputElement::isKeyboardFocusable): Use form() instead of m_form. (WebCore::HTMLInputElement::setType): Ditto. (WebCore::HTMLInputElement::setInputType): Ditto. Also call inputType() != PASSWORD instead of maintainsState(), since this is the only function that needs to know the rule and it's no longer a function in the base class. Also call register and deregister functions by their new names. (WebCore::HTMLInputElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLInputElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to no longer modify the value() string by adding a ".", which gets in the way of distinguishing null and empty values and is slower and unnecessary. (WebCore::HTMLInputElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState, and also to no longer remove the last character from the value when restoring state. (WebCore::HTMLInputElement::parseMappedAttribute): Use form() instead of m_form. (WebCore::HTMLInputElement::isSuccessfulSubmitButton): Use disabled() instead of m_disabled. (WebCore::HTMLInputElement::setChecked): Use form() instead of m_form. (WebCore::HTMLInputElement::preDispatchEventHandler): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
  • html/HTMLSelectElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Call registerFormElementWithState. This was formerly done by the HTML parser. (WebCore::HTMLSelectElement::~HTMLSelectElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLSelectElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLSelectElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to build the string in a Vector<char> instead of appending characters one at a time to a string. (WebCore::HTMLSelectElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState. (WebCore::HTMLSelectElement::defaultEventHandler): Use form() instead of m_form.
  • html/HTMLTextAreaElement.h: Changed type to return a const AtomicString& instead of a String. Removed maintainsState, state, and restoreState functions, and added new stateValue and restoreState functions.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Call registerFormElementWithState. This was formerly done by the HTML parser. Also use member initialization instead of assignment. (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): Call deregisterFormElementWithState by its new name. (WebCore::HTMLTextAreaElement::type): Changed to return const AtomicString& instead of String. (WebCore::HTMLTextAreaElement::stateValue): Renamed from state and changed to no longer include the name and type, formerly obtained by calling the base class's HTMLGenericFormElement::state, and to no longer modify the value() string by adding a ".", which is unnecessary. (WebCore::HTMLTextAreaElement::restoreState): Changed because it takes a single state and doesn't need to call findMatchingState, and also to no longer remove the last character from the value when restoring state. (WebCore::HTMLTextAreaElement::updateValue): Changed to const. (WebCore::HTMLTextAreaElement::value): Ditto. (WebCore::HTMLTextAreaElement::defaultValue): Ditto.
  • html/HTMLFieldSetElement.h: Changed type to return a const AtomicString& instead of a String.
  • html/HTMLFieldSetElement.cpp: (WebCore::HTMLFieldSetElement::type): Ditto.
  • html/HTMLKeygenElement.h: Ditto.
  • html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::type): Ditto.
  • html/HTMLLegendElement.h: Ditto.
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::type):
  • html/HTMLOptGroupElement.h: Ditto.
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::type): Ditto.
  • html/HTMLOptionElement.h: Ditto.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::type): Ditto.
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer): Added missing call to base class.
  • rendering/render_form.h: Removed element() functions that cast to the appropriate derived element class. They do make some bits of code slightly more readable, but they also require including too many headers. Removed the includes of HTMLInputElement.h, HTMLSelectElement.h, HTMLTextAreaElement.h, and KWQLineEdit.h, and added an include of GraphicsTypes.h.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::updateFromElement): Changed use of element() to instead use node() and cast. (WebCore::RenderFormElement::clicked): Ditto. (WebCore::RenderLineEdit::selectionChanged): Ditto. (WebCore::RenderLineEdit::returnPressed): Ditto. (WebCore::RenderLineEdit::performSearch): Ditto. (WebCore::RenderLineEdit::addSearchResult): Ditto. (WebCore::RenderLineEdit::calcMinMaxWidth): Ditto. (WebCore::RenderLineEdit::setStyle): Ditto. (WebCore::RenderLineEdit::updateFromElement): Ditto. (WebCore::RenderLineEdit::valueChanged): Ditto. (WebCore::RenderFileButton::calcMinMaxWidth): Ditto. (WebCore::RenderFileButton::updateFromElement): Ditto. (WebCore::RenderFileButton::returnPressed): Ditto. (WebCore::RenderFileButton::valueChanged): Ditto. (WebCore::RenderSelect::updateFromElement): Ditto. (WebCore::RenderSelect::layout): Ditto. (WebCore::RenderSelect::valueChanged): Ditto. (WebCore::RenderSelect::selectionChanged): Ditto. (WebCore::RenderSelect::updateSelection): Ditto. (WebCore::RenderTextArea::destroy): Ditto. (WebCore::RenderTextArea::calcMinMaxWidth): Ditto. (WebCore::RenderTextArea::setStyle): Ditto. (WebCore::RenderTextArea::updateFromElement): Ditto. (WebCore::RenderTextArea::valueChanged): Ditto. (WebCore::RenderTextArea::selectionChanged): Ditto. (WebCore::RenderSlider::updateFromElement): Ditto. (WebCore::RenderSlider::valueChanged): Ditto.
08:09 Changeset [14206] by darin

JavaScriptCore:

  • kjs/date_object.cpp: (KJS::parseDate): Merged change that George Staikos provided from KDE 3.4.3 branch that allows day values of 0 and values that are > 1000.

LayoutTests:

  • fast/js/kde/resources/Date.js: Added test cases that George Staikos provided that test dates with day values of 0, 55, and 452.
08:08 Changeset [14205] by darin

Added name of test.

07:59 Changeset [14204] by darin

LayoutTests:

Reviewed by Darin.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=8563>

Tests that the name, publicID and systemID are all read correctly
and that the doctype object preserves the case of the
components from the source html:

  • fast/doctypes/005-case-preserving.html: Added.
  • fast/doctypes/005-case-preserving-expected.txt: Added.

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8563

The doctype object in the DOM is now usable by client code
as opposed to always being exposed as nil. Now also ensures that
the 'name' of the component preserves the case of the original html source.
(i.e HtMl -> HtMl not HTML)

  • dom/Document.h: Changes comment by docType() to say it may return 0 for html
  • html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration): (WebCore::HTMLDocument::determineParseMode): Preserves the case of the name component (WebCore::HTMLDocument::doctype):removed
  • html/HTMLDocument.h: (WebCore::HTMLDocument::doctype):removed
07:49 Changeset [14203] by darin

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8651:
[DOMHTMLSelectElement multiple] returns no when the select element is multiple

Correct the logic errors, which are clearly indicated by the changeset given
in the bug report.

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLLinkElement disabled]): (-[DOMHTMLSelectElement disabled]): (-[DOMHTMLSelectElement multiple]): (-[DOMHTMLOptGroupElement disabled]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement disabled]):

05/04/06:

21:30 Changeset [14202] by darin

Reviewed by Tim Omernick.

  • fix storage leak I introduced yesterday
  • platform/cg/GraphicsContextCG.cpp: (WebCore::setCGFillColor): Added. (WebCore::setCGStrokeColor): Added. (WebCore::GraphicsContext::drawRect): Use setCGFillColor to avoid allocating a CGColorRef object. (WebCore::GraphicsContext::drawLine): Use setCGStrokeColor and setCGFillColor to avoid allocating a CGColorRef object. (WebCore::GraphicsContext::drawEllipse): Ditto. (WebCore::GraphicsContext::drawArc): Ditto. (WebCore::GraphicsContext::drawConvexPolygon): Ditto. (WebCore::GraphicsContext::fillRect): Ditto.
21:29 Changeset [14201] by darin

LayoutTests:

Reviewed by Darin.

  • plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Added.
  • plugins/pluginDocumentView-deallocated-dataSource.html: Added.
  • plugins/resources: Added.
  • plugins/resources/orange.mov: Added.

WebKit:

Reviewed by Darin.

Test: plugins/pluginDocumentView-deallocated-dataSource.html

  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView dealloc]): Release the dataSource. (-[WebPluginDocumentView setDataSource:]): Retain the dataSource.
21:25 Changeset [14200] by thatcher

Tag for WebKit 418.3 (part 2 of 2.)

21:25 Changeset [14199] by thatcher

Tag for WebKit 418.3 (part 1 of 2.)

21:22 Changeset [14198] by thatcher

Versioning

21:20 Changeset [14197] by thatcher

GCC 3 Build fix for warning: 'return' with a value, in function returning void.

21:19 Changeset [14196] by thatcher

Build fix, warning: 'return' with a value, in function returning void.

18:43 Changeset [14195] by justing

LayoutTests:

Reviewed by harrison

Pasted content would end up inside the block that contained the end of
the selection that was pasted into and not the block that contained
the start of the selection that was pasted into:

  • editing/pasteboard/merge-end-5-expected.checksum: Added.
  • editing/pasteboard/merge-end-5-expected.png: Added.
  • editing/pasteboard/merge-end-5-expected.txt: Added.
  • editing/pasteboard/merge-end-5.html: Added.


Inserting a paragraph separator was splitting and cloning the body element
if the html element was editable:

  • editing/inserting/editable-html-element-expected.checksum: Added.
  • editing/inserting/editable-html-element-expected.png: Added.
  • editing/inserting/editable-html-element-expected.txt: Added.
  • editing/inserting/editable-html-element.html: Added.


Since we now sometimes merge backward (from content already in the
document to just inserted content) during the end merge, the node that
contains the old caret is removed more often during paste. The editing
delegate notifications in these tests reflect this:

  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:


Now demonstrates a bug where the html element is focused, but its contents
aren't selected:

  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:
  • editing/selection/focus_editable_html.html:

WebCore:

Reviewed by harrison

  • dom/Node.cpp: (WebCore::Node::rootEditableElement): Restored code to stop at the body tag. Editing shouldn't be allowed to happen outside the body, so it needs to be the editable root even if the html element is contentEditable.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Now takes in more information so it can be "the decider". (WebCore::ReplaceSelectionCommand::doApply): Merging two paragraphs will destroy the moved one's block styles. Perform the end merge backward (from content already in the document to just inserted content) if moving forward would move the paragraph that contained the start of the selection being pasted into, since we always want to preserve that paragraph's block style. Moving backward in this case is also helpful because otherwise it would be difficult to remember the position where inserted content began (since merging would remove m_firstNodeInserted). That position is needed in order to select the replacement and to add smart replace whitespace. (WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded): If [br, 0] is at the end of a block, the br is not necessarily collapsed in quirks mode. [br, 0] needs to also not be at the start of a block.


  • editing/ReplaceSelectionCommand.h:
17:58 Changeset [14194] by tomernic

WebCore:

Reviewed by Darin.

<rdar://problem/4537606> Give Java WebKit plugin access to its own DOM element

  • bridge/mac/WebCoreFrameBridge.h: Added DOMElement parameter to -viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:.
  • bridge/JavaAppletWidget.h: Constructor now takes the applet's element instead of its containing frame.
  • bridge/mac/JavaAppletWidget.mm: (JavaAppletWidget::JavaAppletWidget): Pass the applet's element to viewForJavaAppletWithFrame:.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary): Pass the element along to JavaAppletWidget.

WebKit:

Reviewed by Darin.

<rdar://problem/4537606> Give Java WebKit plugin access to its own DOM element

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): Pass the DOMElement to the plugin if it's a WebKit plugin (we need to handle Netscape plugins differently).
17:35 Changeset [14193] by thatcher

Tag for WebKit 418.2 (part 2 of 2.)

17:33 Changeset [14192] by thatcher

Tag for WebKit 418.2 (part 1 of 2.)

17:33 Changeset [14191] by thatcher

Tag for WebCore 418.1 (part 2 of 2.)

17:33 Changeset [14190] by thatcher

Tag for WebCore 418.1 (part 1 of 2.)

17:32 Changeset [14189] by thatcher

Tag for JavaScriptCore 418.1 (part 2 of 2.)

17:32 Changeset [14188] by thatcher

Tag for JavaScriptCore 418.1 (part 1 of 2.)

17:02 Changeset [14187] by thatcher

Versioning

16:54 Changeset [14186] by thatcher

WebCore:

Reviewed by Harrison.

<rdar://problem/4523536> SUTiLondon: Dashcode removes commented code from HTML files

  • khtml/editing/markup.cpp: (khtml::endMarkup):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createTokenizer):
  • khtml/html/html_documentimpl.h: (DOM::HTMLDocumentImpl::isHTMLDocument):
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::HTMLTokenizer): (khtml::HTMLTokenizer::setIncludesComments): (khtml::HTMLTokenizer::includesComments):
  • khtml/html/htmltokenizer.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::removedLastRef): (DocumentImpl::documentElement):
  • khtml/xml/dom_docimpl.h:
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (+[WebCoreBridge includesCommentsInDOM]): (+[WebCoreBridge setIncludesCommentsInDOM:]):

WebKit:

Reviewed by Harrison.

<rdar://problem/4523536> SUTiLondon: Dashcode removes commented code from HTML files

  • WebView.subproj/WebView.m: (+[WebView _includesCommentsInDOM]): (+[WebView _setIncludesCommentsInDOM:]):
  • WebView.subproj/WebViewPrivate.h:
16:03 Changeset [14185] by tomernic

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4480186> Give WebKit plugins access to their own DOM element

  • bridge/mac/WebCoreFrameBridge.h: Added DOMElement: parameter to -viewForPluginWithURL:attributeNames:attributueValues:MIMEType:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createPlugin): Added "element" parameter; wrap element in DOMElement and pass up to the bridge.
  • page/Frame.h: Added "element" parameter to createPlugin().
  • page/Frame.cpp: (WebCore::Frame::loadPlugin): Get the plugin's DOM element and pass to createPlugin().

WebKit:

Reviewed by John Sullivan.

<rdar://problem/4480186> Give WebKit plugins access to their own DOM element

This does not fix <rdar://problem/4480187> Give Netscape plugins access to their own DOM element --
we're not going to use the ObjC DOM API for that, but rather the NP bindings API.

  • Plugins/WebPluginPackage.m: Declared WebPlugInContainingElementKey. This is not a new plugin argument -- it's been in our public headers since all along, but has never been concretely declared -- plugins that referenced it would not link.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:]): Added DOMElement parameter, which is now included in the plugin arguments dictionary. (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:]): ditto
  • WebKit.exp: Export WebPlugInContainingElementKey.
13:37 Changeset [14184] by andersca

2006-05-04 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=8734
Would like a Vector::append that takes another Vector


  • kxmlcore/Vector.h: (KXMLCore::::append): New function that takes another array.
13:08 Changeset [14183] by justing

Reviewed by thatcher


Used the StayInBlock variant of upstream/downstream since they behave that way in
tip of tree (where there is no StayInBlock parameter).

11:26 Changeset [14182] by eseidel

2006-05-04 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Add drag & drop support to <input type="file">
http://bugzilla.opendarwin.org/show_bug.cgi?id=8733

Test: manual/input-type-file-drag-drop.html

  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton changeFilename:]): (-[WebCoreFileButton chooseFilename:]): (validFilenameFromPasteboard): (-[WebCoreFileButton draggingEntered:]): (-[WebCoreFileButton draggingExited:]): (-[WebCoreFileButton performDragOperation:]):
11:20 Changeset [14181] by bdakin

--This

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8732
Backgrounds with background-size and background-origin do not
always lay out correctly

  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawTiled): We no longer need to scale the source point since it will now come in with the scale already taken into account.
  • platform/mac/ImageMac.mm: (WebCore::Image::drawTiled): Same as above.
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): Now calculate the background size in a helper method. (WebCore::RenderBox::paintBackgroundExtended): Calculate the background size before calculating cx, cy, cw, ch, sx, and sy so that they can all be calculated with the scaled image size taken into account.

M LayoutTests/ChangeLog
M LayoutTests/fast/backgrounds/size/backgroundSize18-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize12-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize19-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize10-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize18-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize19-expected.png
M LayoutTests/fast/backgrounds/size/backgroundSize10-expected.checksum
M LayoutTests/fast/backgrounds/size/backgroundSize12-expected.checksum
M WebCore/platform/mac/ImageMac.mm
M WebCore/platform/cairo/ImageCairo.cpp
M WebCore/rendering/RenderBox.cpp
M WebCore/ChangeLog

11:10 Changeset [14180] by thatcher

Speculative build fix for B&I.

11:04 Changeset [14179] by hyatt

Fix for 8693, crash when reloading PDF. Make sure to clear the truncator's
cached renderer.

Reviewed by beth

  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm: (+[WebCoreStringTruncator clear]):
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory clearCaches]):
10:42 Changeset [14178] by thatcher

Merged fix from TOT to Safari-2-0-branch


This fixes: <rdar://problem/4211296> right side of page is clipped when printing to PDF

2005-12-08 John Sullivan <sullivan@apple.com>

Reviewed by Tim O.


  • Added WebKit mechanism to help correctly pass the first responder into the PDF view hierarchy, in order to start addressing keyboard focus and selection highlight issues. Unfortunately this doesn't actually have any user effect yet due to problems that must be fixed in PDFKit.
  • WebView.subproj/WebPDFView.m: (-[WebPDFView acceptsFirstResponder]): Overridden to returns YES. Needed so NSClipView knows it's OK to pass focus down to this level. (-[WebPDFView becomeFirstResponder]): With setNextKeyView:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView setNextKeyView:]): With becomeFirstResponder:, splices the PDF view into the focus-passing mechanism in much the same way as NSScrollView and NSClipView. (-[WebPDFView resignFirstResponder]): Removed this method because the WebPDFView itself is never first responder except transiently.
Note: See TracTimeline for information about the timeline view.