Timeline



May 14, 2006:

11:59 PM Changeset in webkit [14374] by andersca
  • 2 edits in trunk/WebCore

2006-05-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

9:57 PM Changeset in webkit [14373] by hyatt
  • 246 edits in trunk/LayoutTests/svg/W3C-SVG-1.1

Update svg layout tests.

9:42 PM Changeset in webkit [14372] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/repaint/table-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-collapsed-border-expected.png: Added.
  • fast/repaint/table-collapsed-border-expected.txt: Added.
  • fast/repaint/table-collapsed-border.html: Added.

WebCore:

Reviewed by Hyatt.


This patch updates the implementation of collapsing borders to match
the current spec.

Test: fast/repaint/table-collapsed-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::layout): Calculate horizontal overflows. (WebCore::RenderTable::calcMinMaxWidth): Added call to recalcHorizontalBorders. (WebCore::RenderTable::colElement): Made const. (WebCore::RenderTable::calcBorderLeft): Calculates the left border. In the collapsing borders model, this is the left border of the leftmost cell of the first row. (WebCore::RenderTable::calcBorderRight): Ditto for the right border. (WebCore::RenderTable::recalcHorizontalBorders): Added. (WebCore::RenderTable::borderTop): Changed to return outerBorderTop in the collapsing case. (WebCore::RenderTable::borderBottom): Changed to return outerBorderBottom in the collapsing case. (WebCore::RenderTable::outerBorderTop): Added. Returns the table half of the top border, which is half the widest top border on the first row. (WebCore::RenderTable::outerBorderBottom): Added. Returns the table half of the bottom border, which is half the widest bottom border on the last row. (WebCore::RenderTable::outerBorderLeft): Added. Returns the table half of the left border, which is half the widest left border on the leftmost column. (WebCore::RenderTable::outerBorderRight): Added. Returns the table half of the right border, which is half the widest right border on the rightmost column. (WebCore::RenderTable::cellAbove): Return 0 if the cell is in the first row of the header. (WebCore::RenderTable::cellBelow): Return 0 if the cell is in the last row of the footer.
  • rendering/RenderTable.h: (WebCore::RenderTable::borderLeft): (WebCore::RenderTable::borderRight): (WebCore::RenderTable::overflowHeight):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::borderLeft): Removed unnecessary use of floats. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::paint): Account for the table half of the vertical borders. (WebCore::RenderTableCell::paintCollapsedBorder): Removed unnecessary use of floats.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Added call to recalcOuterBorder. (WebCore::RenderTableSection::calcOuterBorderTop): Added. Calculates the outer half of the section's top border, which is half the widest top border on the first row. (WebCore::RenderTableSection::calcOuterBorderBottom): Ditto for the bottom border. (WebCore::RenderTableSection::calcOuterBorderLeft): Ditto for the left border. (WebCore::RenderTableSection::calcOuterBorderRight): Ditto for the right border. (WebCore::RenderTableSection::recalcOuterBorder): Added. (WebCore::RenderTableSection::paint): Account for the table half of the borders.
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::outerBorderTop): (WebCore::RenderTableSection::outerBorderBottom): (WebCore::RenderTableSection::outerBorderLeft): (WebCore::RenderTableSection::outerBorderRight):
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout if a border style changed from 'hidden' to 'none' or vice versa in the collapsing borders model, since 'hidden' suppresses other borders.
9:37 PM Changeset in webkit [14371] by darin
  • 5 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/dom-manipulation-on-resize.html: Added.

WebKit:

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
9:33 PM Changeset in webkit [14370] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

  • fast/forms/file-input-disabled.html: Added.
  • fast/forms/file-input-disabled-expected.txt: Added.
  • fast/forms/file-input-disabled-expected.png: Added.
  • fast/forms/file-input-disabled-expected.checksum: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5882:
disabled type="file" element doesn't appear disabled

Be sure to call setDisabled on the file button when in
RenderFileButton::updateFromElement.

  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton setEnabled:]): (KWQFileButton::setDisabled):
  • rendering/render_form.cpp: (WebCore::RenderFileButton::updateFromElement):
3:12 PM Changeset in webkit [14369] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix Windows build.

  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::fontDataAt): (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::selectionRectForText): (WebCore::Font::offsetForPosition):
2:26 PM Changeset in webkit [14368] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

2:25 PM Changeset in webkit [14367] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

Fix Win32 build bustage.

1:38 PM Changeset in webkit [14366] by hyatt
  • 100 edits
    8 adds in trunk

Bug 8895. Rework font substitution and fallback. Lift the concept of
substitution and fallback out of FontData and up into the FontFallbackList.
See the bug for details of issues fixed in the fallback code.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::primaryFont): (WebCore::Font::fontDataAt): (WebCore::Font::fontDataForCharacters): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch):
  • platform/Font.h: (WebCore::Font::getNSFont):
  • platform/FontCache.h: Added.
  • platform/FontData.h: (WebCore::FontData::pitch): (WebCore::FontData::getNSFont): (WebCore::):
  • platform/FontFallbackList.cpp: Added. (WebCore::m_pitch): (WebCore::FontFallbackList::~FontFallbackList): (WebCore::FontFallbackList::invalidate): (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
  • platform/FontFallbackList.h: (WebCore::FontFallbackList::isFixedPitch): (WebCore::FontFallbackList::primaryFont):
  • platform/FontFamily.h:
  • platform/mac/FontCacheMac.mm: Added. (WebCore::FontCache::getFontData): (WebCore::FontCache::getFontDataForCharacters):
  • platform/mac/FontData.mm: (WebCore::FontData::containsCharacters):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::initialize):
  • platform/mac/WebTextRendererFactory.h:
  • platform/mac/WebTextRendererFactory.mm: (-[WebTextRendererFactory fallbackFontWithTraits:size:]): (-[WebTextRendererFactory fontWithDescription:WebCore::familyIndex:]):
  • platform/win/FontWin.cpp: (WebCore::FontFallbackList::determinePitch): (WebCore::FontFallbackList::primaryFont): (WebCore::FontFallbackList::fontDataAt): (WebCore::FontFallbackList::fontDataForCharacters):
9:39 AM Changeset in webkit [14365] by ap
  • 3 edits
    4 adds in trunk

2006-05-14 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

Fix for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8387>
"border-left/padding-Left do not show up on multiline rtl inline boxes"

Test: fast/inline/inline-borders-with-bidi-override.html: added

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
12:12 AM Changeset in webkit [14364] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Fix the Windows build the rest of the way

  • WebCore.vcproj/WebCore/WebCore.vcproj:

May 13, 2006:

9:52 PM Changeset in webkit [14363] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Update to new file paths

  • WebFramePrivate.cpp:
9:42 PM Changeset in webkit [14362] by sfalken
  • 2 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Get FontWin.cpp compiling.
WebCore and JSCore now build, but Spinneret still gets link errors.

  • platform/win/FontWin.cpp: (WebCore::Font::offsetForPosition):
8:58 PM Changeset in webkit [14361] by sfalken
  • 4 edits in trunk/WebCore

2006-05-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by maciej.

Fix Windows build except for fontwin.cpp.

  • WebCore/platform/win/FontWin.cpp:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
9:58 AM Changeset in webkit [14360] by ap
  • 3 edits in trunk/LayoutTests/fast/block/positioning/auto

Commit the remaining updated results for bug 7604.

9:47 AM Changeset in webkit [14359] by ap
  • 3 edits
    22 adds in trunk

2006-05-13 Kevin M. Ollivier <​kevino@theolliviers.com>

Reviewed by Darin, landed by ap.

JavaScriptCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • JavaScriptCoreSources.bkl: Added JavaScriptCore sources list for Bakefile.


  • jscore.bkl: Bakefile used to generate JavaScriptCore project files (currently only used by wx and gdk ports)

WebCore:

  • make-generated-sources.sh: Added script to configure environment to run DerivedSources.make


  • move-js-headers.sh: Added script to copy JavaScriptCore includes into one dir so that Framework-style includes will work on all OSes. (written by Mike Emmel)


  • platform/wx: New dir, home for the wxWidgets port
  • platform/wx/wx-encodings.txt: Added temp. stub for wx encodings file.


  • Projects: New dir, for various project files for ports.


  • Projects/gdk: New dir, GDK port files.
  • Projects/webcore-gdk.bkl: Bakefile to generate GDK port project files


  • Projects/wx: New dir, wxWidgets port files.
  • Projects/webcore-wx.bkl: Bakefile to generate wxWidgets port project files

WebKitTools:

  • Scripts/install-unix-extras: Added.
  • Scripts/regenerate-makefiles: Added.
9:28 AM Changeset in webkit [14358] by ap
  • 3 edits
    4 adds in trunk

2006-05-13 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin, landed by ap.

Test: fast/text/midword-break-hang.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): If this is a mid-word break, ignore breakOnlyAfterWhiteSpace.
9:19 AM Changeset in webkit [14357] by ap
  • 2 edits in trunk/WebCore

Ok, now RenderBox.cpp actually compiles for me.

8:57 AM Changeset in webkit [14356] by ap
  • 2 edits in trunk/WebCore

Same fix for calcAbsoluteVerticalValues().

8:50 AM Changeset in webkit [14355] by ap
  • 2 edits in trunk/WebCore

Try to fix release build.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontalValues): Initialize leftValue. This value will never be used, because 'left' and 'right' cannot both be 'auto'.
8:28 AM Changeset in webkit [14354] by ap
  • 1 edit
    1 delete in trunk/WebCore/rendering

Re-applied the fix for bug 8835 (REGRESSION: Line moves but selection
highlight stays behind) to a correct file; removed the stale one.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
  • rendering/render_line.cpp: Removed.
8:12 AM Changeset in webkit [14353] by ap
  • 1 edit in trunk/WebCore/ChangeLog

Corrected a path in ChangeLog.

8:11 AM Changeset in webkit [14352] by ap
  • 6 edits
    4 adds in trunk

2006-05-13 Rob Buis <​buis@kde.org>

Reviewed by Darin, landed by ap.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8132
CSS parser sometimes accepts real number as integer

Add a boolean variable per css value to catch whether values
are specified as floats or integers.

Test: fast/css/rgb-float.html

  • css/CSSGrammar.y:
  • css/cssparser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::lex):
  • css/cssparser.h:
  • css/tokenizer.flex:
7:58 AM Changeset in webkit [14351] by ap
  • 7 edits
    8 adds in trunk

2006-05-13 Sam Weinig <​sam.weinig@gmail.com>

Reviewed by Hyatt, landed by ap.

WebCore:

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7604
calcAbsoluteHorizontalValues() is being getting passed arguments
in the wrong order in calcAbsoluteHorizontal()

Cleans up the RenderBox code for absolutely positioned elements
and adds new functions for replaced absolutely positioned
elements. Now uses Length so that magic number -666666 for
auto lengths is no longer used.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Handle replaced case separately. (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto.
  • rendering/RenderBox.h:

LayoutTests:

  • fast/block/positioning/absolute-length-of-neg-666666.html: Added.
  • fast/block/positioning/absolute-positioned-overconstrained.html: Added.
  • fast/block/positioning/auto/006.html: Updated to reflect that the containing block's direction, not the parent's is used.
  • fast/css/absolute-poition-in-rtl-parent.html: Updated and cleaned up.

May 12, 2006:

11:41 PM Changeset in webkit [14350] by hyatt
  • 7 edits in trunk/WebCore

Bug 8880, remove the remaining drawing/hit testing code from
FontData.

Reviewed by tim h

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advanceOneCharacter): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPosition): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::makeComplete):
  • platform/FontData.h:
  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForComplexText): (WebCore::Font::offsetForPositionForComplexText):
8:26 PM Changeset in webkit [14349] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by Maciej.

8:26 PM Changeset in webkit [14348] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Add missing include.


  • dom/Node.h: Add missing include for DeprecatedString.
8:24 PM Changeset in webkit [14347] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/selection-highlight-adjust-expected.checksum: Added.
  • fast/dynamic/selection-highlight-adjust-expected.png: Added.
  • fast/dynamic/selection-highlight-adjust-expected.txt: Added.
  • fast/dynamic/selection-highlight-adjust.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dynamic/selection-highlight-adjust.html

  • rendering/render_line.cpp: (WebCore::RootInlineBox::adjustPosition): Adjust m_selectionTop and m_selectionBottom.
7:44 PM Changeset in webkit [14346] by thatcher
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7156
Bug 7156: TinyMCE: Links are actually activated in editable area, not editable.


Links in editable areas will not activate or perform a navigation
change (on par with WinIE and Firefox.) To visit the link
you can shift-click. Manual test added.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
  • html/HTMLAnchorElement.h:
  • manual-tests/contenteditable-link.html: Added.
  • page/FrameView.cpp: (WebCore::selectCursor):
6:36 PM Changeset in webkit [14345] by eseidel
  • 10 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Split out html_inlineimpl.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp:
  • bindings/objc/DOMHTML.mm:
  • editing/CreateLinkCommand.cpp:
  • editing/UnlinkCommand.cpp:
  • html/HTMLAnchorElement.cpp: Added. (WebCore::HTMLAnchorElement::HTMLAnchorElement):
  • html/HTMLAnchorElement.h: Added.
  • html/HTMLBRElement.cpp: Added.
  • html/HTMLBRElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLFontElement.cpp: Added. (WebCore::HTMLFontElement::HTMLFontElement): (WebCore::HTMLFontElement::setColor): (WebCore::HTMLFontElement::setFace): (WebCore::HTMLFontElement::setSize):
  • html/HTMLFontElement.h: Added.
  • html/HTMLModElement.cpp: Added. (WebCore::HTMLModElement::setCite): (WebCore::HTMLModElement::setDateTime):
  • html/HTMLModElement.h: Added.
  • html/HTMLQuoteElement.cpp: Added.
  • html/HTMLQuoteElement.h: Added.
  • html/html_imageimpl.h:
  • html/html_inlineimpl.cpp: Removed.
  • html/html_inlineimpl.h: Removed.
  • page/FrameView.cpp:
5:57 PM Changeset in webkit [14344] by eseidel
  • 3 edits in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Fix build error.

  • rendering/InlineFlowBox.cpp:
  • rendering/RootInlineBox.cpp:
5:54 PM Changeset in webkit [14343] by eseidel
  • 7 edits
    8 copies
    1 move in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split out render_line.* into separate files (one per class).

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp:
  • rendering/EllipsisBox.cpp: Added.
  • rendering/EllipsisBox.h: Added. (WebCore::EllipsisBox::EllipsisBox):
  • rendering/InlineBox.cpp: Added.
  • rendering/InlineBox.h: Added. (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::~InlineBox): (WebCore::InlineBox::bottomOverflow): (WebCore::InlineBox::rightOverflow):
  • rendering/InlineFlowBox.cpp: Added. (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/InlineFlowBox.h: Added.
  • rendering/InlineRunBox.h: Added. (WebCore::InlineRunBox::InlineRunBox): (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderFlow.h:
  • rendering/RenderReplaced.cpp:
  • rendering/RootInlineBox.cpp: Added.
  • rendering/RootInlineBox.h: Added. (WebCore::RootInlineBox::RootInlineBox):
  • rendering/render_line.h: Removed.
4:50 PM Changeset in webkit [14342] by eseidel
  • 1 edit
    1 delete in trunk/WebCore

spelling fix

4:44 PM Changeset in webkit [14341] by eseidel
  • 3 edits
    4 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Split out table_layout.* into separate files (one per class).
Search replace instnace variables "foo" with "m_foo" to comply with modern style.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/AutoTableLayout.cpp: Added. (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
  • rendering/AutoTableLayout.h: Added. (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
  • rendering/FixedTableLayout.cpp: Added. (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout):
  • rendering/FixedTableLayout.h: Added.
  • rendering/RenderTable.cpp:
  • rendering/TableLayout.h: Added. (WebCore::TableLayout::TableLayout):
  • rendering/table_layout.cpp: Removed.
  • rendering/table_layout.h: Removed.
4:39 PM Changeset in webkit [14340] by thatcher
  • 1 copy in tags/WebCore-418.5/WebCore

Tag for WebCore 418.5 (part 2 of 2.)

4:39 PM Changeset in webkit [14339] by thatcher
  • 1 add in tags/WebCore-418.5

Tag for WebCore 418.5 (part 1 of 2.)

4:39 PM Changeset in webkit [14338] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

4:28 PM Changeset in webkit [14337] by hyatt
  • 15 edits in trunk/WebCore

Bug 8877. Change form controls and the bridge entry points from the
Safari UI to use Font instead of FontData.

Reviewed by mjs

  • bridge/mac/WebCoreStringTruncator.mm: (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]): (+[WebCoreStringTruncator clear]):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
  • kwq/KWQListBox.mm: (itemTextRenderer): (groupLabelTextRenderer): (QListBox::sizeForNumberOfLines): (QListBox::clearCachedTextRenderers): (-[KWQTableView drawRow:clipRect:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h: (WebCore::TextStyle::disableRoundingHacks): (WebCore::TextStyle::setRTL):
  • platform/FontData.h:
  • platform/FontFallbackList.h:
  • platform/FontPlatformData.h: (WebCore::FontPlatformData::syntheticOblique):
  • platform/Pen.h:
  • platform/mac/FontData.mm: (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteRenderer):
  • platform/mac/FontMac.mm: (WebCore::FontFallbackList::setPlatformFont): (WebCore::m_wordSpacing): (WebCore::Font::drawComplexText):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • platform/win/FontWin.cpp: (WebCore::Font::drawText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset):
4:14 PM Changeset in webkit [14336] by eseidel
  • 14 edits
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by kevin.

Move render_button to RenderButton.
Various small style cleanup.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLButtonElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLInputElement.cpp:
  • platform/mac/WebCoreTextArea.mm:
  • rendering/RenderApplet.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderButton.cpp: Added. (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::addChild): (WebCore::RenderButton::removeChild):
  • rendering/RenderButton.h: Added.
  • rendering/RenderEmptyApplet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/render_button.cpp: Removed.
  • rendering/render_button.h: Removed.
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::FixedTableLayout): (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::AutoTableLayout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout):
  • rendering/table_layout.h: (WebCore::TableLayout::TableLayout): (WebCore::AutoTableLayout::totalPercent): (WebCore::AutoTableLayout::Layout::Layout):
4:08 PM Changeset in webkit [14335] by bdakin
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0 branch. Fixes <rdar://problem/
4536941> Branch regression: : Random crash occurs when navigating
site at ​http://abcnews.go.com/ (KHTMLParser::popOneBlock(bool) +
56)

2006-01-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
3:56 PM Changeset in webkit [14334] by eseidel
  • 17 edits
    18 copies
    6 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Split render_frames.* render_replaced.* and html_baseimpl.* into separate files (one class per file).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8878

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLDocument::getValueProperty): (KJS::JSHTMLDocument::getOwnPropertySlot): (KJS::JSHTMLDocument::putValueProperty): (KJS::JSHTMLElement::formIndexGetter): (KJS::JSHTMLElement::formNameGetter): (KJS::JSHTMLElement::selectIndexGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::runtimeObjectGetter): (KJS::JSHTMLElement::runtimeObjectPropertyGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::implementsCall): (KJS::JSHTMLElement::callAsFunction): (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::toString): (KJS::getForm): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLElement::putValueProperty): (KJS::toHTMLElement): (KJS::toHTMLTableCaptionElement): (KJS::toHTMLTableSectionElement): (KJS::JSHTMLCollection::lengthGetter): (KJS::JSHTMLCollection::indexGetter): (KJS::JSHTMLCollection::nameGetter): (KJS::JSHTMLCollection::getOwnPropertySlot): (KJS::HTMLCollectionProtoFunc::callAsFunction): (KJS::JSHTMLSelectCollection::selectedIndexGetter): (KJS::JSHTMLSelectCollection::put): (KJS::OptionConstructorImp::construct): (KJS::getSelectHTMLCollection):
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
  • dom/Document.cpp: (WebCore::widgetForNode):
  • html/HTMLBodyElement.cpp: Added. (WebCore::HTMLBodyElement::HTMLBodyElement): (WebCore::HTMLBodyElement::parseMappedAttribute):
  • html/HTMLBodyElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElement.cpp: Added. (WebCore::HTMLFrameElement::isURLAllowed): (WebCore::HTMLFrameElement::parseMappedAttribute): (WebCore::HTMLFrameElement::setLocation):
  • html/HTMLFrameElement.h: Added.
  • html/HTMLFrameSetElement.cpp: Added. (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach): (WebCore::HTMLFrameSetElement::defaultEventHandler): (WebCore::HTMLFrameSetElement::recalcStyle):
  • html/HTMLFrameSetElement.h: Added.
  • html/HTMLHeadElement.cpp: Added. (WebCore::HTMLHeadElement::HTMLHeadElement):
  • html/HTMLHeadElement.h: Added.
  • html/HTMLHtmlElement.cpp: Added. (WebCore::HTMLHtmlElement::HTMLHtmlElement):
  • html/HTMLHtmlElement.h: Added.
  • html/HTMLIFrameElement.cpp: Added. (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • html/HTMLIFrameElement.h: Added.
  • html/HTMLObjectElement.cpp:
  • html/HTMLParser.cpp:
  • html/html_baseimpl.cpp: Removed.
  • html/html_baseimpl.h: Removed.
  • kwq/WebCoreAXObject.mm:
  • page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::applyEditingStyleToBodyElement): (WebCore::Frame::removeEditingStyleFromBodyElement): (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement): (WebCore::Frame::selectionRect): (WebCore::Frame::isFrameSet): (WebCore::scanForForm): (WebCore::Frame::currentForm): (WebCore::Frame::nodeInfoAtPoint): (WebCore::Frame::adjustPageHeight): (WebCore::Frame::frameForWidget): (WebCore::Frame::forceLayoutWithPageWidthRange): (WebCore::Frame::passWidgetMouseDownEventToWidget):
  • page/FrameView.cpp:
  • rendering/RenderFrame.cpp: Added. (WebCore::RenderFrame::viewCleared):
  • rendering/RenderFrame.h: Added.
  • rendering/RenderFrameSet.cpp: Added. (WebCore::RenderFrameSet::RenderFrameSet): (WebCore::RenderFrameSet::~RenderFrameSet): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::positionFrames): (WebCore::RenderFrameSet::userResize): (WebCore::RenderFrameSet::canResize): (WebCore::RenderFrameSet::dump):
  • rendering/RenderFrameSet.h: Added.
  • rendering/RenderImage.h:
  • rendering/RenderPart.cpp: Added. (WebCore::RenderPart::RenderPart):
  • rendering/RenderPart.h: Added.
  • rendering/RenderPartObject.cpp: Added. (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget): (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderPartObject.h: Added.
  • rendering/RenderReplaced.cpp: Added. (WebCore::RenderReplaced::selectionColor):
  • rendering/RenderReplaced.h: Added.
  • rendering/RenderWidget.cpp: Added. (WebCore::RenderWidget::deleteWidget):
  • rendering/RenderWidget.h: Added.
  • rendering/render_form.h:
  • rendering/render_frames.cpp: Removed.
  • rendering/render_frames.h: Removed.
  • rendering/render_replaced.cpp: Removed.
  • rendering/render_replaced.h: Removed.
3:21 PM Changeset in webkit [14333] by mjs
  • 19 edits
    1 add in trunk/WebKit

Reviewed by Brady.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=8876

  • move most private WebDataSource methods to uninstalled header


I put the declarations for the ones only used in WebKit in WebDataSourceInternal.h
and removed two entirey unused ones.

  • Plugins/WebNetscapePluginRepresentation.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebPluginController.m:
  • Plugins/WebPluginDocumentView.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge dataSource]):
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _loadIcon]): (-[WebDataSource _clearErrors]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]):
  • WebView/WebDataSourceInternal.h: Added.
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebRenderNode.m:
  • WebView/WebView.m:
1:44 PM Changeset in webkit [14332] by eseidel
  • 15 edits
    10 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split html_headimpl.* into separate files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8875

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::headGetter): (KJS::JSHTMLElement::linkGetter):
  • bindings/objc/DOMCSS.mm: (+[DOMCounter _counterWith:]): (-[DOMCounter finalize]): (-[DOMCounter _DOMStyleSheet]): (-[DOMStyleSheet _initWithStyleSheet:]): (-[DOMStyleSheetList dealloc]): (-[DOMStyleSheetList finalize]): (-[DOMStyleSheetList _styleSheetList]): (-[DOMStyleSheetList _initWithStyleSheetList:]): (-[DOMCSSStyleSheet _CSSStyleSheet]): (-[DOMMediaList dealloc]): (-[DOMMediaList finalize]): (-[DOMMediaList _mediaList]): (-[DOMMediaList _initWithMediaList:]): (-[DOMCSSRuleList dealloc]): (-[DOMCSSRuleList finalize]): (-[DOMCSSRuleList _ruleList]): (-[DOMCSSRuleList _initWithRuleList:]): (-[DOMCSSRule dealloc]): (-[DOMCSSRule finalize]): (-[DOMCSSRule _rule]): (-[DOMCSSRule _initWithRule:]): (-[DOMCSSStyleRule _styleRule]): (-[DOMCSSMediaRule _mediaRule]): (-[DOMCSSFontFaceRule _fontFaceRule]): (-[DOMCSSPageRule _pageRule]): (-[DOMCSSImportRule _importRule]): (-[DOMCSSCharsetRule _importRule]): (-[DOMCSSStyleDeclaration dealloc]): (-[DOMCSSStyleDeclaration finalize]): (-[DOMCSSStyleDeclaration _initWithStyleDeclaration:]): (-[DOMCSSStyleDeclaration _styleDeclaration]): (-[DOMCSSValue dealloc]): (-[DOMCSSValue finalize]): (-[DOMCSSValue _value]): (-[DOMCSSValue _initWithValue:]): (-[DOMCSSPrimitiveValue _primitiveValue]): (-[DOMCSSValueList _valueList]): (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor _initWithRGB:]): (-[DOMRect dealloc]): (-[DOMRect finalize]): (-[DOMRect _rect]): (-[DOMRect _initWithRect:]): (-[DOMCounter dealloc]): (-[DOMCounter _counter]): (-[DOMCounter _initWithCounter:]): (-[DOMObject sheet]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLCollection dealloc]): (-[DOMHTMLCollection finalize]): (-[DOMHTMLCollection _collection]): (-[DOMHTMLCollection _initWithCollection:]): (-[DOMHTMLOptionsCollection dealloc]): (-[DOMHTMLOptionsCollection finalize]): (-[DOMHTMLOptionsCollection _initWithOptionsCollection:]): (-[DOMHTMLOptionsCollection _optionsCollection]): (+[DOMHTMLElement _elementWith:]): (-[DOMHTMLElement _HTMLElement]): (-[DOMHTMLDocument _HTMLDocument]): (-[DOMHTMLHtmlElement _HTMLHtmlElement]): (-[DOMHTMLHeadElement _headElement]): (-[DOMHTMLLinkElement _linkElement]): (-[DOMHTMLTitleElement _titleElement]): (-[DOMHTMLMetaElement _metaElement]): (-[DOMHTMLBaseElement _baseElement]): (-[DOMHTMLStyleElement _styleElement]): (-[DOMHTMLBodyElement _bodyElement]): (-[DOMHTMLFormElement _formElement]): (+[DOMHTMLFormElement _formElementWith:]): (-[DOMHTMLIsIndexElement _isIndexElement]): (-[DOMHTMLSelectElement _selectElement]): (-[DOMHTMLOptGroupElement _optGroupElement]): (-[DOMHTMLOptionElement _optionElement]): (-[DOMHTMLInputElement _inputElement]): (-[DOMHTMLTextAreaElement _textAreaElement]): (-[DOMHTMLButtonElement _buttonElement]): (-[DOMHTMLLabelElement _labelElement]): (-[DOMHTMLLabelElement form]): (-[DOMHTMLFieldSetElement _fieldSetElement]): (-[DOMHTMLLegendElement _legendElement]): (-[DOMHTMLUListElement _uListElement]): (-[DOMHTMLOListElement _oListElement]): (-[DOMHTMLDListElement _dListElement]): (-[DOMHTMLDirectoryElement _directoryListElement]): (-[DOMHTMLMenuElement _menuListElement]): (-[DOMHTMLLIElement _liElement]): (-[DOMHTMLQuoteElement _quoteElement]): (-[DOMHTMLDivElement _divElement]): (-[DOMHTMLParagraphElement _paragraphElement]): (-[DOMHTMLHeadingElement _headingElement]): (-[DOMHTMLPreElement _preElement]): (-[DOMHTMLBRElement _BRElement]): (-[DOMHTMLBaseFontElement _baseFontElement]): (-[DOMHTMLFontElement _fontElement]): (-[DOMHTMLHRElement _HRElement]): (-[DOMHTMLModElement _modElement]): (-[DOMHTMLAnchorElement _anchorElement]): (-[DOMHTMLImageElement _imageElement]): (-[DOMHTMLObjectElement _objectElement]): (-[DOMHTMLParamElement _paramElement]): (-[DOMHTMLMapElement _mapElement]): (-[DOMHTMLAreaElement _areaElement]): (-[DOMHTMLScriptElement _scriptElement]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (-[DOMHTMLTableElement createTHead]): (-[DOMHTMLTableElement createTFoot]): (-[DOMHTMLTableElement createCaption]): (-[DOMHTMLTableElement insertRow:]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (-[DOMHTMLTableColElement _tableColElement]): (-[DOMHTMLTableRowElement _tableRowElement]): (-[DOMHTMLTableRowElement insertCell:]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]): (-[DOMHTMLFrameSetElement _frameSetElement]): (-[DOMHTMLFrameElement _frameElement]): (-[DOMHTMLIFrameElement _IFrameElement]): (-[DOMHTMLEmbedElement _embedElement]): (viewForElement):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsAboveCell): (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::FrameMac::createFrame): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::passWheelEventToChildWidget): (WebCore::FrameMac::fileWrapperForElement): (WebCore::listParent): (WebCore::FrameMac::attributedString): (WebCore::FrameMac::shouldBeginEditing): (WebCore::FrameMac::shouldEndEditing): (WebCore::FrameMac::setMarkedTextRange):
  • dom/Document.cpp:
  • dom/xml_tokenizer.cpp:
  • html/HTMLBaseElement.cpp: Added. (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process):
  • html/HTMLBaseElement.h: Added.
  • html/HTMLDocument.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLLinkElement.cpp: Added. (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::process):
  • html/HTMLLinkElement.h: Added.
  • html/HTMLMetaElement.cpp: Added. (WebCore::HTMLMetaElement::HTMLMetaElement): (WebCore::HTMLMetaElement::parseMappedAttribute): (WebCore::HTMLMetaElement::process): (WebCore::HTMLMetaElement::setContent): (WebCore::HTMLMetaElement::setHttpEquiv): (WebCore::HTMLMetaElement::setName):
  • html/HTMLMetaElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLScriptElement.cpp: Added. (WebCore::HTMLScriptElement::HTMLScriptElement): (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::evaluateScript):
  • html/HTMLScriptElement.h: Added.
  • html/HTMLStyleElement.cpp: Added. (WebCore::HTMLStyleElement::HTMLStyleElement):
  • html/HTMLStyleElement.h: Added.
  • html/HTMLTitleElement.cpp: Added. (WebCore::HTMLTitleElement::HTMLTitleElement): (WebCore::HTMLTitleElement::text): (WebCore::HTMLTitleElement::setText):
  • html/HTMLTitleElement.h: Added.
  • html/html_headimpl.cpp: Removed.
  • html/html_headimpl.h: Removed.
  • loader/CachedCSSStyleSheet.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCol.cpp: (WebCore::RenderTableCol::updateFromElement):
12:44 PM Changeset in webkit [14331] by eseidel
  • 2 edits
    12 copies
    2 moves in trunk/WebCore

2006-05-12 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Split out html_tableimpl.* into multiple files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8873

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTableCaptionElement.cpp: Added. (WebCore::HTMLTableCaptionElement::HTMLTableCaptionElement):
  • html/HTMLTableCaptionElement.h: Added.
  • html/HTMLTableCellElement.cpp: Added. (WebCore::HTMLTableCellElement::HTMLTableCellElement):
  • html/HTMLTableCellElement.h: Added.
  • html/HTMLTableColElement.cpp: Added. (WebCore::HTMLTableColElement::HTMLTableColElement): (WebCore::HTMLTableColElement::endTagRequirement): (WebCore::HTMLTableColElement::tagPriority): (WebCore::HTMLTableColElement::checkDTD):
  • html/HTMLTableColElement.h: Added.
  • html/HTMLTableElement.cpp: Added. (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: Added.
  • html/HTMLTablePartElement.cpp: Added. (WebCore::HTMLTablePartElement::parseMappedAttribute):
  • html/HTMLTablePartElement.h: Added.
  • html/HTMLTableRowElement.cpp: Added. (WebCore::HTMLTableRowElement::HTMLTableRowElement): (WebCore::HTMLTableRowElement::rowIndex):
  • html/HTMLTableRowElement.h: Added.
  • html/HTMLTableSectionElement.cpp: Added. (WebCore::HTMLTableSectionElement::insertRow):
  • html/HTMLTableSectionElement.h: Added.
  • html/html_tableimpl.cpp: Removed.
  • html/html_tableimpl.h: Removed.
11:51 AM Changeset in webkit [14330] by thatcher
  • 1 copy in tags/WebCore-418.4/WebCore

Tag for WebCore 418.4 (part 2 of 2.)

11:51 AM Changeset in webkit [14329] by thatcher
  • 1 add in tags/WebCore-418.4

Tag for WebCore 418.4 (part 1 of 2.)

11:51 AM Changeset in webkit [14328] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:14 AM Changeset in webkit [14327] by eseidel
  • 11 edits
    8 copies
    2 moves in trunk/WebCore

2006-05-10 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs & adele.

Split html_objectimpl.* into multiple files (one per class)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8836

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::lengthGetter): (KJS::DOMNamedNodeMap::indexGetter): (KJS::DOMNamedNodeMap::nameGetter): (KJS::DOMNamedNodeMapProtoFunc::callAsFunction): (KJS::getRuntimeObject):
  • bindings/js/kjs_html.cpp:
  • html/HTMLAppletElement.cpp: Added.
  • html/HTMLAppletElement.h: Added.
  • html/HTMLElementFactory.cpp:
  • html/HTMLEmbedElement.cpp: Added. (WebCore::HTMLEmbedElement::HTMLEmbedElement): (WebCore::HTMLEmbedElement::getInstance): (WebCore::HTMLEmbedElement::parseMappedAttribute):
  • html/HTMLEmbedElement.h: Added.
  • html/HTMLNameCollection.cpp: (WebCore::HTMLNameCollection::traverseNextItem):
  • html/HTMLObjectElement.cpp: Added. (WebCore::HTMLObjectElement::getInstance): (WebCore::HTMLObjectElement::form): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::updateDocNamedItem):
  • html/HTMLObjectElement.h: Added.
  • html/HTMLParamElement.cpp: Added.
  • html/HTMLParamElement.h: Added.
  • html/HTMLParser.cpp:
  • html/HTMLPlugInElement.cpp: Added.
  • html/HTMLPlugInElement.h: Added.
  • html/html_objectimpl.cpp: Removed.
  • html/html_objectimpl.h: Removed.
  • page/Frame.cpp: (WebCore::Frame::handleFallbackContent):
  • rendering/RenderApplet.cpp:
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
10:53 AM Changeset in webkit [14326] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-12 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
10:40 AM Changeset in webkit [14325] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

Improvement to my NSWindow display throttle hack. Remember the last flush time instead of the last display time.
Our goal is to never draw less than 1/60th of a second after the window is flushed in order to avoid blocking on
a CG coalesced update. Using the last display time is close, but this is much more accurate. I have verified that
this further improves our score on BenchJS Test 1 (by 9.8% with the status bar shown compared to the previous build),
as well as on our internal PLT scores by a smaller percentage.

  • Misc/WebNSWindowExtras.m: Renamed lastDisplayTime to lastFlushTime. (+[NSWindow _webkit_enableWindowDisplayThrottle]): Replace -[NSWindow flushWindow] with our own implementation. (+[NSWindow _webkit_disableWindowDisplayThrottle]): Restore -[NSWindow flushWindow]. (replacementFlushWindow): Use the last flush time instead of the last display time. (getWindowDisplayInfo): Renamed lastDisplayTime to lastFlushTime. (requestWindowDisplay): Moved some code to replacementFlushWindow().
9:49 AM Changeset in webkit [14324] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Added a null check.
  • manual-tests/context-click-generated-content.html: Added.
9:45 AM Changeset in webkit [14323] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Move caret to the right side of the rect when the offset is non-zero, rather than expanding it.
  • manual-tests/caret-image.html: Added.
5:35 AM Changeset in webkit [14322] by andersca
  • 3 edits
    4 adds in trunk

WebCore:

2006-05-12 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Test: fast/text/international/rtl-caret.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::positionForOffset): Added missing m_toAdd argument.

LayoutTests:

2006-05-12 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


  • fast/text/international/rtl-caret-expected.checksum: Added.
  • fast/text/international/rtl-caret-expected.png: Added.
  • fast/text/international/rtl-caret-expected.txt: Added.
  • fast/text/international/rtl-caret.html: Added.
2:22 AM Changeset in webkit [14321] by hyatt
  • 10 edits in trunk/WebCore

Bug 8864. Lift WebCoreTextStyle up into the API (as TextStyle).

Reviewed by mjs

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::Font::width): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextStyle::m_attemptFontSubstitution): (WebCore::TextStyle::tabWidth): (WebCore::TextStyle::xPos): (WebCore::TextStyle::padding): (WebCore::TextStyle::rtl): (WebCore::TextStyle::ltr): (WebCore::TextStyle::directionalOverride): (WebCore::TextStyle::applyRunRounding): (WebCore::TextStyle::applyWordRounding): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::Font::operator==):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPosition):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):

May 11, 2006:

9:51 PM Changeset in webkit [14320] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/loader/url-strip-cr-lf-tab.html

  • platform/KURL.cpp: (appendEscapingBadChars): Strip CR, LF and TAB, as Firefox and IE do.
9:43 PM Changeset in webkit [14319] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 8856: Web Inspector should show the Xpath for the selected node
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8856


Adds an Xpath area to the Node panel.

5:23 PM Changeset in webkit [14318] by hyatt
  • 10 edits in trunk/WebCore

Remove the misspelling drawing code from Font and FontData. Implement it
natively in GraphicContext instead.

Reviewed by maciej

  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/win/FontWin.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingMarker):
5:04 PM Changeset in webkit [14317] by hyatt
  • 12 edits in trunk/WebCore

Remove drawLineForText from the Font API. Implement it natively in
the two GraphicsContexts (CG and Cairo) instead.

Reviewed by maciej

  • platform/Font.h:
  • platform/FontData.h:
  • platform/GraphicsContext.cpp:
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/FontData.mm:
  • platform/mac/FontMac.mm:
  • platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations):
4:57 PM Changeset in webkit [14316] by bdakin
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4539954> 10.4.7 regression:DHTML menu
closes prematurely when hovering over it at ​http://
www.shopping.hp.com/

This fix already exists on TOT, though I am not sure when it was
checked in, nor am I aure what in particular caused this regression
on the branch. Whatever the cause of the badness, though, we need
to take borderTopExtra() and borderBottomExtra() into consideration
when hitTesting the background of a RenderBlock.

  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::nodeAtPoint):
4:55 PM Changeset in webkit [14315] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix last fix.

  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName):
4:31 PM Changeset in webkit [14314] by sfalken
  • 2 edits in trunk/WebCore

2006-05-11 Steve Falkenburg <​sfalken@apple.com>

Reviewed by eric.

Fix crash on static constructors builds at exit due to qualified name default constructor not
initializing m_impl.

  • dom/QualifiedName.cpp: (WebCore::QualifiedName::deref):
4:24 PM Changeset in webkit [14313] by hyatt
  • 4 edits in trunk/WebCore

Reviewed by hyatt

Already covered by several tests in fast/text

  • platform/Font.h: (WebCore::TextRun::TextRun): Added length parameter.
  • rendering/InlineTextBox.cpp: Pass the length to the TextRun constructor. (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): Pass length and from instead of from and to to the TextRun constructor. (WebCore::RenderText::width): Ditto.
3:45 PM Changeset in webkit [14312] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Justin.


<rdar://problem/4543847> 10.4.7 regression: Mail: selecting the bottom of a message and deleting it leaves a stray newline


Merged most of the DeleteSelectionCommand parts of r14143.

  • khtml/editing/htmlediting.cpp: (DeleteSelectionCommand::initializePositionData): Removed erroneous check that disabled merging based on paragraph boundaries.


(DeleteSelectionCommand::mergeParagraphs):
Return early if upstreamStart and downstreamEnd are flipped, or startblock == endblock.

3:31 PM Changeset in webkit [14311] by hyatt
  • 2 edits in trunk/WebCore

Fix a regression from the TextRun landing. Delete the characters in
the adjustedRun, not the ones in the original run!

Reviewed by beth

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText):
3:21 PM Changeset in webkit [14310] by justing
  • 18 edits in trunk

LayoutTests:

Reviewed by thatcher, levi


Inserting an <hr> into <div>foobar</div> now produces
<div>foo</div><hr><div>bar</div>, instead of <div>foo<hr>bar</div>,
which means that removing an inserted <hr> programmatically from
javascript produces a different visual result than before (the
new result is arguably more correct):

  • editing/execCommand/insertHorizontalRule.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:


Equivalent render trees or changes in the editing delegate
notifications that reflect the fact that we are doing an end
merge more often:

  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher, levi

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed a use fragment.hasMoreThanOneBlock to decide if the paragraph containing the position pasted into must be split to avoid block nesting. We now split unnecessarily some times, but the end merge cleans up for us.
3:20 PM Changeset in webkit [14309] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

More 8060 layout test fun.

3:18 PM Changeset in webkit [14308] by hyatt
  • 3 edits in trunk/LayoutTests/tables/mozilla/bugs

More 8060 layout test fun.

3:03 PM Changeset in webkit [14307] by hyatt
  • 3 edits in trunk/LayoutTests/fast/text/international

Fix bidi line break layout test to account for bug 8060.

3:02 PM Changeset in webkit [14306] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/margin-collapse

Fix margin-collapsing layout test to account for bug 8060.

3:01 PM Changeset in webkit [14305] by hyatt
  • 3 edits in trunk/LayoutTests/fast/block/float

Fix float layout test to account for bug 8060.

2:56 PM Changeset in webkit [14304] by hyatt
  • 11 edits in trunk/WebCore

This patch makes drawHighlightForText a completely cross-platform method
implemented by the GraphicsContext. The platform-specific implementations
of the method in the Font class have been eliminated.

Reviewed by andersca

  • platform/Font.h:
  • platform/FontData.h: Remove the drawHighlight methods. Change the selectionRect method in Font to return a FloatRect so that the GraphicsContext can do an accurate fill.
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawHighlightForText): Implement the drawHighlightFunction in terms of the cross-platform Font selectionRect functions and a new float-based fillRect graphics context function.
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::fillRect):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): Add the new float-based fillRect function for Cairo and CG.
  • platform/mac/FontData.mm: (WebCore::CG_draw): (WebCore::ATSU_draw): Removed the CG and ATSU drawHighlight methods. Remove the drawing of the background from the deprecated draw methods (they'll be removed soon).
  • platform/mac/FontMac.mm: (WebCore::Font::selectionRectForText):
  • platform/win/FontWin.cpp: (WebCore::Font::selectionRectForText): Change selectionRectForText to return a FloatRect instead of an IntRect, so that the GraphicsContext can do a precise fill.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::positionForOffset): Modify the callers who expect an int-based selection rect so that they call enclosingIntRect.
12:05 PM Changeset in webkit [14303] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Anders.

Fixes <rdar://problem/4411845> lots of SPOD trying to scroll through
Markup & Content inspecting body at apple.com (6614)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6614

Removed the Markup & Content pane when viewing a element.
This pane was not that useful and made the inspector really slow
when the markup was large. Only show this pane for text nodes.

11:34 AM Changeset in webkit [14302] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

Patch for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=8810>
Bug 8810: Scrollbars in WebInspector rendered incorrectly

  • WebInspector/webInspector/inspector.css: Make scroll bars absolutely positioned.
10:47 AM Changeset in webkit [14301] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/double-focus-expected.txt: Added.
  • fast/forms/double-focus.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/double-focus.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Changed to only call setFocusNode, select, and revealSelection if the element is not already focused. Also changed to use return a bit more rather than else.
10:44 AM Changeset in webkit [14300] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebKit/Misc.subproj/WebNSWindowExtras.m

Build fix.

10:23 AM Changeset in webkit [14299] by darin
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher (earlier version).

  • bindings/scripts/IDLParser.pm: Invoke the preprocessor via the "gcc" driver script, passing "-E" so we only preprocess, "-P" so we don't get "#line" directives, and "-x c++" so we handle both C and C++ comments. Removed the code to eliminate comments since the preprocessor handles that.
  • css/make-css-file-arrays.pl: This already invoked the preprocessor, but updated it to do the same way as above.
4:38 AM Changeset in webkit [14298] by andersca
  • 14 edits
    3 adds in trunk

WebCore:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new generated files.


  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSWrapper): Specify the KJS namespace for JSHTMLElmement.


  • bindings/js/kjs_dom.cpp: (KJS::toJS): Create a WebCore::JSHTMLDocument for document nodes. Also, create JSDocumentFragments for document fragments (instead of plain node objects).


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentProtoFunc::callAsFunction): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLDocument::getOwnPropertySlot): Add a prototype for JSHTMLDocument and move all functions there.


(KJS::JSHTMLElement::JSHTMLElement):
(KJS::JSHTMLElement::getOwnPropertySlot):
Update since JSHTMLElement now inherits from WebCore::JSHTMLElement.


(KJS::JSHTMLElement::getValueProperty):
(KJS::JSHTMLElement::putValueProperty):
Remove title setter and getter. Those are autogenerated now.


  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Inherit from WebCore::JSHTMLElement. Clarify the inheritance chain.


  • bindings/scripts/CodeGeneratorJS.pm: Always generate a prototype object, regardless of whether the object has any functions or constants.


Use the type of generator attributes to determine what constructor to use. This is useful for
the XMLDocument property in DOMWindow.idl, since that's just an alias for the Document constructor.


  • dom/DocumentFragment.idl: Added.
  • html/HTMLDocument.idl: Added.
  • html/HTMLElement.idl: Added.


  • page/DOMWindow.idl: Add constructors for DocumentFragment, HTMLElement, HTMLDocument and XMLDocument. XMLDocument is just an alias for the Document constructor.


LayoutTests:

2006-05-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7838
Add support for mozilla-style node constructors as properties of the window object

  • fast/dom/prototype-chain-expected.txt: Update prototype chains.
  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html: Test new constructor objects.
3:19 AM Changeset in webkit [14297] by hyatt
  • 16 edits in trunk/WebCore

Bug 8845. Define a TextRun (similar to the old WebCoreTextRun) and
make it the new API for Font and GraphicsContext when drawing/measuring
text.

Reviewed by andersca

  • platform/Font.cpp: (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::width): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_to): (WebCore::TextRun::operator[]): (WebCore::TextRun::data): (WebCore::TextRun::adjustFrom): (WebCore::TextRun::adjustTo): (WebCore::TextRun::characters): (WebCore::TextRun::length): (WebCore::TextRun::from): (WebCore::TextRun::to):
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForText): (WebCore::Font::drawComplexText): (WebCore::Font::drawHighlightForText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::hackishExtentForString): (WebCore::Font::floatWidth): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::selectionRectForText): (WebCore::Font::checkSelectionPoint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (WebCore::RenderBlock::tabWidth): (WebCore::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):

May 10, 2006:

10:32 PM Changeset in webkit [14296] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-10 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc.subproj/WebNSWindowExtras.h:
  • Misc.subproj/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView.subproj/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
7:52 PM Changeset in webkit [14295] by justing
  • 1 edit in trunk/WebCore/ChangeLog

Fixed my incorrect wording.

6:26 PM Changeset in webkit [14294] by justing
  • 16 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin

Fixed a select-after-replacement problem:

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum:
  • editing/pasteboard/drag-drop-modifies-page-expected.png:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:


The trailing interchange newline used to be lost:

  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-016-expected.checksum:
  • editing/pasteboard/paste-text-016-expected.png:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-017-expected.txt:


Illustrates the bug fixed in smart replace whitespace handling:

  • editing/pasteboard/smart-paste-008.html
  • editing/pasteboard/smart-paste-008-expected.txt
  • editing/pasteboard/smart-paste-008-expected.png
  • editing/pasteboard/smart-paste-008-expected.checksum

WebCore:

Reviewed by darin

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Removed the code to find out if we must later add smart replace whitespace. We can wait until we've done the insertion to figure it out, and the position sampled (startPos) to make the decision about trailing whitespace was wrong. Changed the order that work is done during a paste: 1) Insert everything 2) Do one of the following: a) handle a trailing interchange newline, b) uncollapse the last incoming br if it has been collapsed because of quirks mode, c) do an end merge 3) Add smart replace whitespace (2 and 3 were reversed because the end merge must happen before we can know whether or not we need to add a trailing space). Don't do an end merge if the last node inserted was a br because the end merge will clobber it.


(WebCore::ReplaceSelectionCommand::removeEndBRIfNeeded):
brs that are at the end of a block and not at the start of a block are not the one brs
that are collapsed because of quirks mode.

6:04 PM Changeset in webkit [14293] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4542808> REGRESSION: benchjs test 1 has slowed by over 150% (8740)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8740>

  • Misc/WebNSWindowExtras.h:
  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_enableWindowDisplayThrottle]): Overrides certain NSWindow methods so that window autodisplay can be throttled to 60Hz.

(disableWindowDisplayThrottleApplierFunction):
CFDictionary applier function for when the throttle is disabled. Cancels all pending window displays,
and calls -displayIfNeeded on each window with a pending display.

(+[NSWindow _webkit_disableWindowDisplayThrottle]):
Restores default NSWindow method implementations and clears pending window displays.

(swizzleInstanceMethod):
Helper function to swizzle ObjC method implementations.

(replacementPostWindowNeedsDisplay):
Don't call into -[NSWindow _postWindowNeedsDisplay] if requestWindowDisplay() returns NO (this is the
function that throttles display).

(replacementClose):
Clean up the WindowDisplayInfo struct for the window, since it's about to go away.

(getWindowDisplayInfo):
Gets the WindowDisplayInfo struct for the window, or creates it if absent.

(requestWindowDisplay):
Returns YES if a display is allowed right now. Returns NO otherwise, and schedules a timer to try the
display again.

(cancelPendingWindowDisplay):
Cancels the pending display for the window, if any.

(-[NSWindow _webkit_doPendingPostWindowNeedsDisplay:]):
Try to call _postWindowNeedsDisplay again.

  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]): If the secret "WebKitThrottleWindowDisplay" default is set, then enable the NSWindow throttle.
2:08 PM Changeset in webkit [14292] by hyatt
  • 5 edits in trunk/WebCore

Rename isSpace to treatAsSpace. Move it and the rounding hack function into
Font and make them static methods (inlined in the header). Make the rounding
hack character table a static member as well. Remove the redundant space/rounding
functions from FontData.mm.

Reviewed by darin

  • platform/Font.cpp: (WebCore::): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance):
  • platform/Font.h: (WebCore::Font::treatAsSpace): (WebCore::Font::isRoundingHackCharacter):
  • platform/mac/FontData.mm: (WebCore::overrideLayoutOperation): (WebCore::createATSULayoutParameters): (WebCore::initializeWidthIterator): (WebCore::advanceWidthIterator):
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
1:49 PM Changeset in webkit [14291] by darin
  • 1 edit
    1 delete in trunk/WebCore
  • WebCore: Removed an extra WebCore subtree that somehow got checked in.
1:27 PM Changeset in webkit [14290] by hyatt
  • 1 edit in trunk/WebCore/platform/Font.cpp

Fix typo from the removal of the inline keyword from some functions.

11:59 AM Changeset in webkit [14289] by thatcher
  • 1 copy in tags/WebCore-418.3/WebCore

Tag for WebCore 418.3 (part 2 of 2.)

11:59 AM Changeset in webkit [14288] by thatcher
  • 1 add in tags/WebCore-418.3

Tag for WebCore 418.3 (part 1 of 2.)

11:55 AM Changeset in webkit [14287] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

11:09 AM Changeset in webkit [14286] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Darin, landed by Timothy.

  • platform/Font.cpp: (WebCore::isSpace):
  • platform/mac/FontData.mm: (WebCore::widthForGlyph): (WebCore::isRoundingHackCharacter): (WebCore::glyphForCharacter):
10:28 AM Changeset in webkit [14285] by ap
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by Anders.

The problem itself was fixed by Anders in bug 8808 (WebCore should handle text files).

  • http/tests/misc/resources: Added.
  • http/tests/misc/resources/200.html: Added.
  • http/tests/misc/resources/text-refresh.pl: Added.
  • http/tests/misc/text-refresh-expected.txt: Added.
  • http/tests/misc/text-refresh.html: Added.
8:11 AM Changeset in webkit [14284] by andersca
  • 2 edits in trunk/WebCore

2006-05-10 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.

Already covered by several pixel tests in fast/text

  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
1:49 AM Changeset in webkit [14283] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Fix for bug 8809, lift the Mac-specific WebTextRenderer code for
drawing and measuring of runs up into the Font class. The fast code
path is in Font.cpp and is designed to be mostly cross-platform. The
slow code path is in FontMac.cpp and is Mac-specific.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::isSpace): (WebCore::): (WebCore::isRoundingHackCharacter): (WebCore::m_finalRoundingWidth): (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks): (WebCore::Font::primaryFont): (WebCore::Font::setAlwaysUseComplexPath): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText):
  • platform/Font.h:
  • platform/FontData.h: (WebCore::FontData::platformData):
  • platform/GlyphBuffer.h: Added. (WebCore::GlyphBuffer::GlyphBuffer): (WebCore::GlyphBuffer::isEmpty): (WebCore::GlyphBuffer::size): (WebCore::GlyphBuffer::glyphs): (WebCore::GlyphBuffer::advances): (WebCore::GlyphBuffer::fontDataAt): (WebCore::GlyphBuffer::swap): (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
  • platform/mac/FontData.mm: (WebCore::isSpace): (WebCore::isRoundingHackCharacter): (WebCore::FontData::widthForGlyph): (WebCore::m_ATSUMirrors): (WebCore::FontData::xHeight): (WebCore::FontData::smallCapsFontData): (WebCore::findSubstituteFont): (WebCore::rendererForAlternateFont): (WebCore::findSubstituteRenderer): (WebCore::FontData::findSubstituteFontData): (WebCore::computeWidthForSpace): (WebCore::FontData::updateGlyphMapEntry): (WebCore::extendGlyphMap): (WebCore::extendWidthMap): (WebCore::createATSULayoutParameters): (WebCore::FontData::glyphForCharacter): (WebCore::advanceWidthIterator): (WebCore::shouldUseATSU):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::m_padPerSpace): (WebCore::addDirectionalOverride): (WebCore::initializeATSUStyle): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::disposeATSULayoutParameters): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU):
1:18 AM Changeset in webkit [14282] by andersca
  • 2 edits in trunk/WebKit

2006-05-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • WebView/WebHTMLView.m: (+[WebHTMLView unsupportedTextMIMETypes]): Add text/rtf
12:20 AM Changeset in webkit [14281] by darin
  • 1 edit
    1 add in trunk/WebCore
  • another try at fixing the Windows build
  • platform/win/FontWin.cpp: (WebCore::getFontData): Use characters() instead of unicode().
12:19 AM Changeset in webkit [14280] by darin
  • 2 edits
    1 move in trunk/WebCore

Cut change log.

12:12 AM Changeset in webkit [14279] by darin
  • 2 edits in trunk/WebCore

Reviewed, tweaked, and landed by Darin.

Optimization of [DOMNode _nodeWith:] to look up the obj-c wrapperClass
for each HTMLElement using a HashMap instead of by repeated calls to
htmlElt->hasLocalName(someTag).

  • bindings/objc/DOM.mm: (addElementClass): Added. (createHTMLElementClassMap): (elementClass): (+[DOMNode _nodeWith:]): Added code to call elementClass.
Note: See TracTimeline for information about the timeline view.