Timeline


and .

05/25/06:

17:36 Changeset [14606] by sfalken

2006-05-26 Steve Falkenburg < sfalken@apple.com>

Reviewed by adele.

Fix build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
17:28 Changeset [14605] by hyatt

Set the fixed pitch hardcoded default to 13 on windows.

17:24 Changeset [14604] by hyatt

Make sure Spinneret inits and shuts down COM like a good boy.

17:19 Changeset [14603] by aliceli1
17:15 Changeset [14602] by aliceli1

Reviewed by Adele.

  • bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
  • bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
  • html/HTMLSelectElement.h: added prototype for namedItem method
16:45 Changeset [14601] by hyatt

Add soft hyphen support for Win32.

16:18 Changeset [14600] by hyatt

Implement containsCharacters method on Win32 for determining if a fallback font has the necessary glyphs to be used.

15:42 Changeset [14599] by hyatt

Remove the logical scale factor from Cairo Win32 fonts.

15:17 Changeset [14598] by eseidel

2006-05-25 Mitz Pettel < opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

Test: fast/table/border-collapsing/border-collapsing-head-foot.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::sectionAbove): Added. (WebCore::RenderTable::sectionBelow): Added. (WebCore::RenderTable::cellAbove): Changed to call sectionAbove. (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove. (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.
15:11 Changeset [14597] by eseidel

2006-05-25 Mitz Pettel < opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Assign the row renderer to the grid row. (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug and add vertical spacing only for grid rows that have a renderer. (WebCore::RenderTableSection::recalcCells): Assign row renderers to grid rows.
15:05 Changeset [14596] by eseidel

Remove bogus directory

15:00 Changeset [14595] by eseidel

2006-05-19 Rob Buis < buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for  http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

Make sure SVGDocument is created for standalone svg
documents.

  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::instance): (SVGDOMImplementation::createDocument):
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::~SVGDocument):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • page/Frame.cpp: (WebCore::Frame::begin):
14:55 Changeset [14594] by eseidel

2006-05-17 Rob Buis < buis@kde.org>

Reviewed by darin. Landed by eseidel.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=5889
HTMLNames.* should be generated using make_names.pl

Use a patched make_names.pl to autogenerate HTMLNames.*

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLNames.cpp: Removed.
  • html/HTMLNames.h: Removed.
  • html/HTMLTagNames.in: Added.
  • html/HTMLAttributeNames.in: Added.
  • ksvg2/scripts/make_names.pl:
14:41 Changeset [14593] by eseidel

2006-05-23 Eric Seidel < eric@eseidel.com>

Reviewed by andersca.

Add "HasIndexGetter" support to bindings autogen system.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=9057

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLInputElementBase.cpp:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValueList.idl: Added.
13:15 Changeset [14592] by thatcher

Build fix

12:10 Changeset [14591] by thatcher

Tag for WebKit 521.11.1 (part 2 of 2.)

12:09 Changeset [14590] by thatcher

Bad tag.

12:09 Changeset [14589] by thatcher

Tag for WebKit 521.11.1 (part 2 of 2.)

12:07 Changeset [14588] by thatcher

Tag for WebKit 521.11.1 (part 1 of 2.)

12:06 Changeset [14587] by thatcher

Versioning

12:00 Changeset [14586] by thatcher

Reviewed by Tim O.

< rdar://problem/4559808> WebKit fails to compile for ppc64
< rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
< rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

  • Carbon/CarbonUtils.m: disabled this file in 64-bit < rdar://problem/4561772>
  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
  • Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
  • Carbon/HIViewAdapter.m: disabled this file in 64-bit < rdar://problem/4561772>
  • Carbon/HIWebView.m: disabled this file in 64-bit < rdar://problem/4561772> (HIWebViewEventHandler):
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
  • History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]):
  • Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]):
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
  • Misc/WebSearchableTextView.m: (-[NSString selectionRect]):
  • Misc/WebTypesInternal.h: Added.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath):
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]):
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector):
  • WebInspector/WebInspector.m: (-_updateSystemColors):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]):
  • WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
  • WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]):
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
10:57 Changeset [14585] by brmorris

S60Webkit:

2006-05-25 Bradley < bradley.morrison@nokia.com>

Reviewed by Franklin.

runATF.bat sets compile environment
(fix for  http://bugzilla.opendarwin.org/show_bug.cgi?id=9106)

01:08 Changeset [14584] by hyatt

Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

00:35 Changeset [14583] by hyatt

Fix DumpRenderTree so that it works again.

05/24/06:

22:52 Changeset [14582] by hyatt

Implement font aliasing of family names for Courier/Courier New,
Arial/Helvetica, and Times/Times New Roman. This behavior matches
WinIE and Firefox.

Reviewed by maciej

Test cases not really possible, since they would have to rely on people
not having the fonts installed (so not having installed Office).

  • platform/FontCache.cpp: (WebCore::alternateFamilyName): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontCache.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeLeftoverAnonymousBoxes):
17:43 Changeset [14581] by bdakin

Reviewed by Geoff.

This layout test is now correct, so I moved it into the expected
successes directory and generated new results.

  • tables/mozilla/bugs/bug222846-expected.checksum: Added.
  • tables/mozilla/bugs/bug222846-expected.png: Added.
  • tables/mozilla/bugs/bug222846-expected.txt: Added.
  • tables/mozilla/bugs/bug222846.html: Added.
  • tables/mozilla_expected_failures/bugs/bug222846- expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846.html: Removed.
17:40 Changeset [14580] by thatcher

Tag

17:34 Changeset [14579] by thatcher

Versioning

16:49 Changeset [14578] by justing

LayoutTests:

Reviewed by levi

  • editing/selection/designmode-no-caret-expected.checksum: Added.
  • editing/selection/designmode-no-caret-expected.png: Added.
  • editing/selection/designmode-no-caret-expected.txt: Added.
  • editing/selection/designmode-no-caret.html: Added.

WebCore:

Reviewed by levi


< rdar://problem/4549610> REGRESSION: No initial cursor in Mail reply or Blot document
< rdar://problem/4560698> Mail is very crashy in Leopard9A182, WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)

  • page/Frame.cpp: (WebCore::Frame::setSelectionFromNone): Find the body and stick a caret in it.
16:41 Changeset [14577] by sullivan

Reviewed by John Sullivan.

  • quality/lifecycle.html: mentions case of PlatformOnly bugs

and 'other' bug databases.

16:33 Changeset [14576] by hyatt

Add support for IMLangFontLink2 to map to a similar font that has missing characters on Win32.

16:18 Changeset [14575] by ggaren

Rubber stamped by Anders.


Removed meaningless 'dom::' prefix in IDL files.

  • dom/Range.idl:
  • html/CanvasRenderingContext2D.idl:
  • html/HTMLOptionElement.idl:
16:13 Changeset [14574] by ggaren

LayoutTests:

  • fast/dom/option-properties-expected.txt: Added.
  • fast/dom/option-properties.html: Added.

WebCore:

Reviewed by andersca.



'text' and 'selected' were erroneously marked read-only for option elements.


  • html/HTMLOptionElement.idl:
16:02 Changeset [14573] by brmorris

S60Webkit:

2006-05-25 Mario Borges

Reviewed by bradleym.

  • better support for SISX using ARMV5
  • updated def files
15:57 Changeset [14572] by thatcher

Tag for WebCore 418.9 (part 2 of 2.)

15:56 Changeset [14571] by thatcher

Tag for WebCore 418.9 (part 1 of 2.)

15:56 Changeset [14570] by thatcher

Versioning

15:42 Changeset [14569] by ggaren

JavaScriptCore:

Reviewed by mjs.


On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed < rdar://problem/4561439> about that, and I'm moving on
with my life.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::mark):
  • kjs/interpreter.h:

LayoutTests:

Layout tests for DOM object cache and garbage collection,
< rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting
to view image in slideshow mode at  http://d.smugmug.com/gallery/581716
( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file

  • fast/dom/gc-8-expected.txt: Added.
  • fast/dom/gc-8.html: Added.
  • fast/dom/gc-9-expected.txt: Added.
  • fast/dom/gc-9.html: Added.

WebCore:

Reviewed by mjs.

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed < rdar://problem/4561439> about that, and I'm moving
on with my life.

Also added functionality for testing garbage collection from inside
DumpRenderTree.


Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
objects aren't accessed through the DOM.


Also added JS locking around access to some shared data structures in
WebCoreJavaScript, even though it probably doesn't matter in practice.

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCoreJavaScript.mm: (collect): (+[WebCoreJavaScript objectCount]): (+[WebCoreJavaScript interpreterCount]): (+[WebCoreJavaScript protectedObjectCount]): (+[WebCoreJavaScript garbageCollect]): (+[WebCoreJavaScript garbageCollectOnAlternateThread:]): (+[WebCoreJavaScript shouldPrintExceptions]): (+[WebCoreJavaScript setShouldPrintExceptions:]):

WebKitTools:

Reviewed by mjs.


Added 'GCController' to DRT to support garbage collection layout tests.


GCController.collect() and GCController.collectOnAlternateThread() do
what you would expect. The latter takes a boolean argument sepcifying
whether to wait for garbage collection to finish before continuing to
execute script.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/GCController.mm: Added. (+[GCController isSelectorExcludedFromWebScript:]): (+[GCController webScriptNameForSelector:]): (-[GCController collect]): (-[GCController collectOnAlternateThread:]):
15:39 Changeset [14568] by kdecker
15:32 Changeset [14567] by jdevalk

Adding Google Analytics code, to create visitor stats of our site.

14:54 Changeset [14566] by hyatt

Move font destruction for HFONTs and cairo objects into FontData.

13:48 Changeset [14565] by brmorris

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • Removing JRE dependency in Plugin/inc/jri.h
12:26 Changeset [14564] by andersca

WebCore:

2006-05-24 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return document.scripts() instead of a placeholder object.


  • dom/Document.cpp: (WebCore::Document::scripts):
  • dom/Document.h: Add Document::scripts.


  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::): Add scripts collection type which traverses all script elements.


LayoutTests:

2006-05-24 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

Add tests for  http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • fast/dom/document-scripts-expected.txt: Added.
  • fast/dom/document-scripts.html: Added.
12:02 Changeset [14563] by brmorris

S60WebKit:

Reviewed by mario

2006-05-24 brmorris < bradley.morrison@nokia.com>

  • Purged unneeded source
  • Updated README.txt
11:57 Changeset [14562] by brmorris

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • More lawyer-speak:

MPL 1.1 license on the Netscape Plugins.

11:51 Changeset [14561] by andersca

WebCore:

2006-05-24 Anders Carlsson < acarlsson@apple.com>

Reviewed by Geoff.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers

  • dom/Node.cpp: (WebCore::Node::textContent):
  • dom/Node.h: Add optional convertBRsToNewlines argument for textContent.


  • html/HTMLElement.cpp: (WebCore::HTMLElement::innerText): If the element doesn't have a renderer, return textContent.

LayoutTests:

2006-05-24 Anders Carlsson < acarlsson@apple.com>

Reviewed by Geoff.

Add test for  http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers.


  • fast/dom/inner-text-with-no-renderer-expected.txt: Added.
  • fast/dom/inner-text-with-no-renderer.html: Added.
02:25 Changeset [14560] by hyatt

Fix the Win32 themed controls so that they honor Cairo transforms.

01:33 Changeset [14559] by hyatt

Fix a minor bug with the computation of glyph offsets in Cairo/Win32.

01:28 Changeset [14558] by hyatt

Switch the cairo win32 create similar call over to createdib instead. Avoids wasted fills.

01:23 Changeset [14557] by hyatt

Check in some temporary hacks to Cairo for speed.

00:15 Changeset [14556] by hyatt

Make sure the font options set on the context match what we draw.

05/23/06:

18:21 Changeset [14555] by brmorris

S60WebKit:

  • Corrected build.bat usage statement
  • Removed some irrelevant config files
18:08 Changeset [14554] by mjs

Correct reviewer from me to Tim.

17:59 Changeset [14553] by mjs

Reviewed by Maciej.


  • more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _startLoading]):
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithDataSource:]): (-[WebMainResourceLoader didReceiveResponse:]):
17:24 Changeset [14552] by thatcher

Reviewed by Timothy.

  • index.html: Link to Nokia's S60 WebKit.
16:32 Changeset [14551] by thatcher

Reviewed by Eric.

Remove the recent idl files from the WebCore target to prevent them
from being copied into the framework resources.

  • WebCore.xcodeproj/project.pbxproj:
16:31 Changeset [14550] by sullivan

Reviewed by Justin Garcia and Levi Weintraub.


  • fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html
  • dom/Document.cpp: (WebCore::Document::removeMarkers): One more time to get this right, ugh. There is still one case where we don't want to advance the iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now the layout tests pass even with the pixel tests enabled.
15:48 Changeset [14549] by brmorris

S60WebKit ... migrated!

15:11 Changeset [14548] by hyatt

Implement CookieJar on Win32.

14:37 Changeset [14547] by thatcher

Tag for WebKit 418.8 (part 2 of 2.)

14:37 Changeset [14546] by thatcher

Tag for WebKit 418.8 (part 1 of 2.)

14:36 Changeset [14545] by thatcher

Versioning

14:36 Changeset [14544] by thatcher

Merged fix from TOT to Safari-2-0-branch

2006-05-23 Tim Omernick < timo@apple.com>

Reviewed by John Sullivan.

< rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
14:21 Changeset [14543] by hyatt

Fix post form submission on Win32.

13:45 Changeset [14542] by sullivan

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Newer Xcode removed some obsolete cruft


  • DumpRenderTree/TextInputController.m: (-[TextInputController textInput]): added (id) cast to make newer compiler happy
13:31 Changeset [14541] by hyatt

Fix glyph width access on win32 to not depend on the UChar.

12:27 Changeset [14540] by tomernic

Reviewed by John Sullivan.

< rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
12:18 Changeset [14539] by brmorris

S60WebKit: adding patentlicense.txt

12:15 Changeset [14538] by thatcher

Versioning

10:51 Changeset [14537] by lweintraub

Reviewed by Hyatt.

Cleaned up changes to markup by adding the non-virtual
nodeNamePreservingCase accessor function.

  • dom/Element.cpp: (WebCore::Element::nodeNamePreservingCase):
  • dom/Element.h:
  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
10:47 Changeset [14536] by thatcher

New tag.

10:35 Changeset [14535] by sullivan

Reviewed by Anders Carlsson.

  • dom/Document.cpp: (WebCore::Document::removeMarkers): Fix to my previous checkin (which broke a layout test). Advance the iterator position every time through the loop; formerly it was not advanced in the case where a marker was actually removed, causing an infinite loop in certain cases. Also modified a comment that was confusing the situation by falsely claiming that iterating over a just-inserted node would always be OK.
09:27 Changeset [14534] by andersca

WebCore:

2006-05-23 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/Element.cpp: (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute): Use new getAttributeItem method.


  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem): Use new getAttributeItem method.


(WebCore::NamedAttrMap::getAttributeItem):

  • dom/NamedAttrMap.h: New method which returns the attribute based on the nodeName.

LayoutTests:

2006-05-23 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

Update tests for  http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: This fails in a different way now.


  • dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
  • dom/xhtml/level3/core/noderemovechild28-expected.txt:
  • dom/xhtml/level3/core/noderemovechild29-expected.txt: These now pass.


  • fast/dom/attribute-namespaces-get-set-expected.txt: Added.
  • fast/dom/attribute-namespaces-get-set.html: Added. Add new tests.
08:40 Changeset [14533] by mjs

Reviewed by Eric.


  • remove knowledge of WebView from WebLoader in preparation for moving the code down
  • WebView/WebDataSource.m: (-[WebDataSource _defersCallbacks]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _privateBrowsingEnabled]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[WebLoader releaseResources]): (-[WebLoader setDataSource:]): (-[WebLoader willSendRequest:redirectResponse:]): (-[WebLoader didReceiveAuthenticationChallenge:]): (-[WebLoader didCancelAuthenticationChallenge:]): (-[WebLoader didReceiveResponse:]): (-[WebLoader didReceiveData:lengthReceived:]): (-[WebLoader signalFinish]): (-[WebLoader didFinishLoading]): (-[WebLoader didFailWithError:]): (-[WebLoader willCacheResponse:]): (-[WebLoader cancelWithError:]):
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
  • WebView/WebView.m: (-[WebView _incrementProgressForIdentifier:response:]): (-[WebView _incrementProgressForIdentifier:data:]): (-[WebView _completeProgressForIdentifier:]):
  • WebView/WebViewInternal.h:

05/22/06:

18:36 Changeset [14532] by eseidel

2006-05-22 Eric Seidel < eric@eseidel.com>

Rubber-stamped by adele.

  • bindings/js/kjs_html.h: simple style cleanup.
16:55 Changeset [14531] by thatcher

Tag for 521.10

16:46 Changeset [14530] by thatcher

Versioning.

16:30 Changeset [14529] by thatcher

Build fix when doing 'xcodebuild install'.

15:18 Changeset [14528] by thatcher

Build fix.

15:10 Changeset [14527] by justing

Reviewed by levi


Fixed and reenabled this test.

  • editing/selection/drag-to-contenteditable-iframe-expected.checksum:
  • editing/selection/drag-to-contenteditable-iframe-expected.png:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe.html: Added.
  • editing/selection/drag-to-contenteditable-iframe.html-disabled: Removed.
14:51 Changeset [14526] by thatcher

Tag for WebKit 418.7 (part 2 of 2.)

14:51 Changeset [14525] by thatcher

Tag for WebKit 418.7 (part 1 of 2.)

14:51 Changeset [14524] by thatcher

Versioning

14:41 Changeset [14523] by thatcher

Merged fix from TOT to Safari-2-0-branch

2006-05-22 Tim Omernick < timo@apple.com>

Reviewed by Geoff.

< rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
14:39 Changeset [14522] by thatcher

Removes svn:executable from MathExtras.h. Caused a build verification failure.

14:20 Changeset [14521] by sullivan

Reviewed by Anders Carlsson.


  • fixed Bug 9038: Rework Document::TextMarker mechanism to not use deprecated data structures

Changed Document::markersForNode and Document::MarkerMap to use Vector rather than
DeprecatedValueList and DeprecatedValueListIterator.


  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::markersForNode): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):


  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintAllMarkersOfType):
14:00 Changeset [14520] by thatcher

64-bit build fix, and removes the workaround for < rdar://problem/4294625>.

13:55 Changeset [14519] by tomernic

Reviewed by Geoff.

< rdar://problem/4557117> TOT REGRESSION: Repro crash in cancelPendingWindowDisplay --> _timerRelease when
opening file from file open dialog

Note that I could not reproduce this situation at all on any of my machines; I had to debug this on Geoff's
machine.

  • Misc/WebNSWindowExtras.m: (replacementDealloc): Cancel display timer before dealloc, not after. Cancelling the timer can cause a message to be sent to the window; best to do that before the window deallocates. (replacementFinalize): ditto
13:21 Changeset [14518] by sfalken

2006-05-22 Steve Falkenburg < sfalken@apple.com>

Reviewed by adele.


Fix build.

  • Spinneret/Spinneret.sln:
13:16 Changeset [14517] by sfalken

2006-05-22 Steve Falkenburg < sfalken@apple.com>

Reviewed by adele.


Fix build.

  • WebKitWin.vcproj/WebKitWin.sln:
11:34 Changeset [14516] by lweintraub

LayoutTests:

Reviewed by eric.


  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/unlink-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • fast/dom/Range/range-exceptions-expected.txt:
  • fast/dom/Range/resources/range-exceptions.js:
  • fast/innerHTML/005-expected.txt:
  • fast/innerHTML/innerHTML-custom-tag-expected.txt:
  • fast/innerHTML/innerHTML-cast.html: Added.
  • fast/innerHTML/innerHTML-cast-expected.txt: Added.
  • fast/xsl/xslt-processer-expected.txt:

WebCore:

Reviewed by Eric.


  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
11:20 Changeset [14515] by thatcher

Reviewed by Eric, Kevin and Geoff.

Merge open source build fixes. < rdar://problem/4555500>

  • kjs/collector.cpp: look at the rsp register in x86_64 (KJS::Collector::markOtherThreadConservatively):
  • wtf/Platform.h: add x86_64 to the platform list
01:04 Changeset [14514] by hyatt

Fix Mac bustage.

05/21/06:

23:19 Changeset [14513] by hyatt

Fix win32 bustage.

23:18 Changeset [14512] by hyatt

Fix win32 bustage.

16:42 Changeset [14511] by adele

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::text): Reverting recent change to user innerText instead of textContent. For textareas, we need a better solution than textContent that also takes newlines into account, but this should fix this crasher.
00:51 Changeset [14510] by andersca

2006-05-21 Anders Carlsson < acarlsson@apple.com>

Fix build.


  • ForwardingHeaders/wtf/MathExtras.h: Added.
00:18 Changeset [14509] by hyatt

Add mathextras to javascrtipcore project.

00:05 Changeset [14508] by hyatt

Fix mac bustage. Minor snafu in constructor.

Note: See TracTimeline for information about the timeline view.