Timeline



Jul 13, 2006:

11:48 PM Changeset in webkit [15419] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Maciej.

  • Fix for <rdar://problem/4604703> REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Test:

  • manual-tests/password-ctrl-click-lose-focus.html: Added.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): If we're about to set a selection in the current view, make sure its the first responder. In this case, this will cause the password field to resign first responder at the right time.
9:42 PM Changeset in webkit [15418] by ddkilzer
  • 20 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/selection/after-line-wrap-expected.txt:
  • editing/selection/mixed-editability-1-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.txt: Added.
  • fast/text/international/rtl-white-space-pre-wrap.html: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/text/international/rtl-white-space-pre-wrap.html

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed LTR case and added the RTL case of clipping the caret position to the text box when the caret is after the trailing space of an autowrapped line.
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to truncate- to-fit the logically last text box if it contains the trailing spaces of an autowrapped line. (WebCore::RenderBlock::bidiReorderLine): Remember the logically last text run. In the case of autowrapped text with white space that overflows beyond the line, the last text run is the one containing the overflowing white space. (WebCore::RenderBlock::findNextLineBreak): Split overflowing white space on a line that autowraps only after white space into a separate text run.
8:29 PM Changeset in webkit [15417] by ddkilzer
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

  • kjs/value.h: (KJS::JSValue::getUInt32): Only types tagged as numeric can be converted to UInt32.

LayoutTests:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

This includes tests for indexing an array with immediate types, and for
setting selectField.options.length to immediate types.

  • fast/dom/select-selectedIndex-expected.txt:
  • fast/dom/select-selectedIndex-multiple-expected.txt:
  • fast/dom/select-selectedIndex-multiple.html: Update to test setting length to true and false.
  • fast/dom/select-selectedIndex.html: Ditto.
  • fast/js/array-index-immediate-types-expected.txt: Added.
  • fast/js/array-index-immediate-types.html: Added.
  • fast/js/resources/array-index-immediate-types.js: Added.
7:37 PM Changeset in webkit [15416] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if the view has already been closed.
4:17 PM Changeset in webkit [15415] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4624203> -webkit-highlight should be behind images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Call custom highlighter before painting the image, marker, or widget.
2:08 PM Changeset in webkit [15414] by harrison
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • editing/deleting/delete-by-word-001-expected.checksum: Added.
  • editing/deleting/delete-by-word-001-expected.png: Added.
  • editing/deleting/delete-by-word-001-expected.txt: Added.
  • editing/deleting/delete-by-word-001.html: Added.
  • editing/deleting/delete-by-word-002-expected.checksum: Added.
  • editing/deleting/delete-by-word-002-expected.png: Added.
  • editing/deleting/delete-by-word-002-expected.txt: Added.
  • editing/deleting/delete-by-word-002.html: Added.

WebCore:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::doApply):
  • editing/TypingCommand.h: Delete and forward delete to use specified granularity. Undo of delete and forward delete to select what had been deleted (non-char granularity only).


  • page/Frame.cpp: (WebCore::Frame::setSelection): Close typing and end style even if selection is not changing.
  • page/Frame.h: Remove unused setSelection parameter keepTypingStyle.

WebKit:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
11:45 AM Changeset in webkit [15413] by thatcher
  • 3 edits in tags/WebKit-521.16.4/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
11:44 AM Changeset in webkit [15412] by thatcher
  • 3 edits in tags/WebCore-521.16.1/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
  • dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
11:34 AM Changeset in webkit [15411] by thatcher
  • 1 copy in tags/WebKit-521.16.4

New tag.

11:33 AM Changeset in webkit [15410] by thatcher
  • 1 copy in tags/WebCore-521.16.1/WebCore

New tag (part 2)

11:32 AM Changeset in webkit [15409] by thatcher
  • 1 add in tags/WebCore-521.16.1

New tag.

11:28 AM Changeset in webkit [15408] by lweintraub
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/deleting/delete-block-table-expected.checksum: Added.
  • editing/deleting/delete-block-table-expected.png: Added.
  • editing/deleting/delete-block-table-expected.txt: Added.
  • editing/deleting/delete-block-table.html: Added.
  • editing/deleting/delete-hr-expected.checksum: Added.
  • editing/deleting/delete-hr-expected.png: Added.
  • editing/deleting/delete-hr-expected.txt: Added.
  • editing/deleting/delete-hr.html: Added.
  • editing/deleting/delete-to-select-table-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • fast/lists/markers-in-selection-expected.txt:

WebCore:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Added selection expansion for HRs. (WebCore::DeleteSelectionCommand::initializePositionData): Now uses enclosingBlockFlowOrTableElement instead of enclosingBlockFlowElement. (WebCore::DeleteSelectionCommand::removeNode): Use to identify that we need a placeholder when the start or end block is removed. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Added check for canHaveChildrenForEditing to keep things like HRs from being given children. (WebCore::DeleteSelectionCommand::doApply): Switched to use member variable for needPlaceholder.
  • editing/DeleteSelectionCommand.h: Made needPlaceholder a member variable.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Fixed selection bug for tables and open typing commands. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added check for HRs, since it's not considered a widget.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Fix for HRs and tables. (WebCore::endOfParagraph): Ditto.
11:27 AM Changeset in webkit [15407] by thatcher
  • 3 edits in trunk/WebKit

Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit

<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m:
11:06 AM Changeset in webkit [15406] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
8:54 AM Changeset in webkit [15405] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No change in behavior, thus no test included.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries - the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.
1:56 AM Changeset in webkit [15404] by ggaren
  • 14 edits in trunk/JavaScriptCore

Pleasing to Maciej.


  • Renamed JSEvaluate -> JSEvaluateScript, JSCheckSyntax -> JSCheckScriptSyntax
  • Added exception out parameters to JSValueTo* and JSValueIsEqual because they can throw
  • Removed JSObjectGetDescription because it's useless and vague, and JSValueToString/JSValueIsObjectOfClass do a better job, anyway
  • Clarified comments about "IsFunction/Constructor" to indicate that they are true of all functions/constructors, not just those created by JSObjectMake*
12:11 AM Changeset in webkit [15403] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Timothy.

Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9889

  • Drosera/debugger.js: Track whether we paused during the execution of willLeaveFrame. If so, have stepOut pause on the next call to willExecuteStatement rather than second.

Jul 12, 2006:

9:52 PM Changeset in webkit [15402] by ddkilzer
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Adele. Patch by Mitz.

Test: fast/frames/repaint-display-none-crash.html

  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Added null checking of the owner element's renderer, which can be null if the iframe is set to display:none.

LayoutTests:

Reviewed by Adele. Patch by Mitz.

  • fast/frames/repaint-display-none-crash-expected.txt: Added.
  • fast/frames/repaint-display-none-crash.html: Added.
7:31 PM Changeset in webkit [15401] by justing
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>

  • editing/selection/legal-positions-expected.txt: Added.
  • editing/selection/legal-positions.html: Added.
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Don't pull content out of a table cell.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added <select> nodes. (WebCore::rangeCompliantEquivalent): Convert [node, 0] positions to positionBeforeNode(node) for more types of nodes.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Fix a crasher when right clicking on an anonymous table.
7:15 PM Changeset in webkit [15400] by ggaren
  • 4 edits
    2 moves in trunk/JavaScriptCore

RS by Beth.


Finished previously approved JSInternalString -> JSString conversion
by renaming the files.

  • API/JSCallbackObject.cpp:
  • API/JSInternalStringRef.cpp: Removed.
  • API/JSInternalStringRef.h: Removed.
  • API/JSStringRef.cpp: Added.
  • API/JSStringRef.h: Added.
  • API/JavaScriptCore.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
5:36 PM Changeset in webkit [15399] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Brady Eidson (and written by Justin Garcia)


  • layout test corresponding to <rdar://problem/4611164>
  • editing/undo/undo-misspellings-expected.checksum: Added.
  • editing/undo/undo-misspellings-expected.png: Added.
  • editing/undo/undo-misspellings-expected.txt: Added.
  • editing/undo/undo-misspellings.html: Added.
5:29 PM Changeset in webkit [15398] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
  • dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
5:20 PM Changeset in webkit [15397] by andersca
  • 3 edits
    4 adds in trunk

WebCore:

2006-07-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus


  • dom/Document.cpp: (WebCore::Document::updateSelection): Don't return early if the selection is empty.

LayoutTests:

2006-07-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus

  • editing/selection/clear-selection-expected.checksum: Added.
  • editing/selection/clear-selection-expected.png: Added.
  • editing/selection/clear-selection-expected.txt: Added.
  • editing/selection/clear-selection.html: Added.
2:47 PM Changeset in webkit [15396] by andersca
  • 2 edits in trunk/WebKit

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items


  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Don't create Dictionary, Spotlight or Google lookup items if there's no selection.
10:31 AM Changeset in webkit [15395] by andersca
  • 2 edits
    1 add in trunk/WebCore

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4614656> REGRESSION: onpaste() handlers don't run for textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::dispatchCPPEvent): If the element is a shadow node, dispatch the event to its real parent.
  • manual-tests/textarea-onpaste.html: Added.
10:00 AM Changeset in webkit [15394] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fix for layout test regressions after my check-in last night. Just
a silly mistake where I should have asked if we were NOT printing
instead of if we were in the listbox code.

  • WebCore.xcodeproj/project.pbxproj: Project file wars. Back to XCode 2.3
  • platform/mac/ListBoxMac.mm: (itemTextRenderer): Inverted check. (groupLabelTextRenderer): Inverted check.
9:15 AM Changeset in webkit [15393] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Added fixChangeLogPatch() and invoked it in the proper place.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
9:09 AM Changeset in webkit [15392] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (layout test fix).

Remove property information left in files from svn-apply.

  • fast/table/large-rowspan-crash-expected.txt:
  • fast/table/large-rowspan-crash.html:
8:52 AM Changeset in webkit [15391] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date.

8:30 AM Changeset in webkit [15390] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • another large rowspan test case
  • fast/table/large-rowspan-crash-expected.txt: Added.
  • fast/table/large-rowspan-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/table/large-rowspan-crash.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use sizeof(RowStruct) instead of sizeof(int). Clearly we'll need something better to solve this completely. I expect another smaller, but still huge, value will still cause a problem.
6:32 AM Changeset in webkit [15389] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by ggaren.

Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9869

  • Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): Include the global frame in the stack.
4:28 AM Changeset in webkit [15388] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by ggaren.

Bug 9863: Drosera needs to show something at launch
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9863

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication applicationDidFinishLaunching:]): Show the attach window on launch.
3:33 AM Changeset in webkit [15387] by andersca
  • 5 edits
    4 adds in trunk

WebCore:

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

  • bridge/mac/FrameMac.h: Add focusCallResultedInViewBeingCreated argument.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): If the call to focus() caused the node to get a native widget, set focusCallResultedInViewBeingCreated to true.


(WebCore::FrameMac::nextKeyViewInFrameHierarchy):
Don't reset the focus node if focusCallResultedInViewBeingCreated is true. Also, add magic to prevent setting
a text field as the first responder if its field editor already is the current first responder.


  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): In some cases, get the event target node again after dispatching the mouse event.

LayoutTests:

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

  • fast/forms/input-type-change-in-onfocus-keyboard-expected.txt: Added.
  • fast/forms/input-type-change-in-onfocus-keyboard.html: Added.
  • fast/forms/input-type-change-in-onfocus-mouse-expected.txt: Added.
  • fast/forms/input-type-change-in-onfocus-mouse.html: Added.
3:18 AM Changeset in webkit [15386] by andersca
  • 4 edits in trunk/JavaScriptGlue

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Build fix


  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
  • UserObjectImp.cpp: (UserObjectImp::getPropertyList):
3:01 AM Changeset in webkit [15385] by ggaren
  • 16 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Removed context and exception parameters from JSObjectGetPropertyEnumerator, removing the spurious use of ExecState inside JavaScriptCore that made us think this was necessary in the first place.

(StringInstance::getPropertyList): Use getString instead of toString because
we know we're dealing with a string -- we put it there in the first place.
While we're at it, store the string's size instead of retrieving it each time
through the loop, to avoid the unnecessary killing of puppies.

  • kjs/string_object.h:
2:55 AM Changeset in webkit [15384] by mjs
  • 7 edits in trunk/JavaScriptCore

4eviewed by Geoff.


  • add handling of hasInstance callback for API objects
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::implementsHasInstance): Check if callback is present. (KJS::JSCallbackObject::hasInstance): Invoke appropriate callback.
  • API/JSCallbackObject.h:
  • API/JSClassRef.cpp:
  • API/JSObjectRef.h:
  • API/testapi.c: (MyObject_hasInstance): Test case; should match what construct would do.
  • API/testapi.js:
2:52 AM Changeset in webkit [15383] by bdakin
  • 6 edits in trunk/WebCore

--This Reviewed by Adele.

Fix for <rdar://problem/4615765> Input[type='search' fields
initially render too large in Widgets

Fundamentally, the problem here is that we were miscalculating
things because [NSGraphicsContext currentContextDrawingToScreen]
was evaluating to false when widgets first load. We only ever used
this check, however, to determine if we were printing or not, so it
should not have evaluated to false for loading in Dashbaord.
Instead, if we query the RenderView about whether or not we are
printing, we will get the right answer.

No test case added since this appears only to affect Dashboard.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): Ask the RenderView if we are printing instead. This is not part of the actual bug fix, but it seems wise to get rid of all calls to [NSGraphicsContext currentContextDrawingToScreen] when we are just trying to determine if we are printing or not.
  • platform/mac/ListBoxMac.mm: (itemTextRenderer):This function now takes a boolean, isPrinting. (groupLabelTextRenderer): Same as above. (ListBox::sizeForNumberOfLines): Ask the RenderView if we are printing. (-[WebCoreTableView drawRow:clipRect:]): Same as above.
  • platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint): Same as above.
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
  • rendering/RenderLineEdit.cpp: Same as above.

M WebCore/platform/mac/TextFieldMac.mm
M WebCore/platform/mac/PopUpButtonMac.mm
M WebCore/platform/mac/ListBoxMac.mm
M WebCore/rendering/RenderLineEdit.cpp
M WebCore/ChangeLog
M WebCore/bridge/mac/WebCoreFrameBridge.mm

2:32 AM Changeset in webkit [15382] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
Applications shown in Drosera's "Attach" window remain after exit

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will know when the application is being exited. (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated. (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.
1:55 AM Changeset in webkit [15381] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Timothy.


Lets Drosera build universal for the nightlies. Right now it is not
possible to build a universal binary on a PPC machine because of a
conflict with the universal SDK.

  • BuildSlaveSupport/build-launcher-app:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1:31 AM Changeset in webkit [15380] by thatcher
  • 3 edits in tags/WebKit-521.16.3/WebKit

Build fix for AGL. Versioning.

1:26 AM Changeset in webkit [15379] by thatcher
  • 1 copy in tags/WebKit-521.16.3

new tag.

1:25 AM Changeset in webkit [15378] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
from earlier.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m:
1:17 AM Changeset in webkit [15377] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar

  • fast/forms/option-text-clip-expected.checksum: Added.
  • fast/forms/option-text-clip-expected.png: Added.
  • fast/forms/option-text-clip-expected.txt: Added.
  • fast/forms/option-text-clip.html: Added.

WebCore:

Reviewed by Maciej.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar

Test: fast/forms/option-text-clip.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject): When calculating the clip to apply to the button text, also consider padding. In the future, we may have separate renderers for the text part, and the arrow part of the control, and then the separation should be natural. For now, we use padding.
1:12 AM Changeset in webkit [15376] by ggaren
  • 23 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Implemented a vast number of renames and comment clarifications suggested during API review.


JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->

JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.


  • Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.


  • Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.


  • Moved standard library includes into the headers that actually require them.


  • Standardized use of the phrase "Create Rule."


  • Removed JSLock from make functions that don't allocate.


  • Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.


  • Renamed JSGCCollect to JSGarbageCollect.

Jul 11, 2006:

11:04 PM Changeset in webkit [15375] by thatcher
  • 2 edits in tags/WebKit-521.16.2/WebKit

Build fix and versioning.

11:02 PM Changeset in webkit [15374] by thatcher
  • 1 copy in tags/WebKit-521.16.2

New good tag.

11:02 PM Changeset in webkit [15373] by thatcher
  • 1 delete in tags/WebKit-521.16.2

Bad tag.

11:01 PM Changeset in webkit [15372] by thatcher
  • 1 copy in tags/WebKit-521.16.2/WebKit-521.16.1

new tag (part 2)

11:01 PM Changeset in webkit [15371] by thatcher
  • 1 add in tags/WebKit-521.16.2

New tag.

11:00 PM Changeset in webkit [15370] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.m

More build fixes for the deprecated AGL functions.

9:26 PM Changeset in webkit [15369] by thatcher
  • 1 edit in trunk/WebKitTools/Drosera/debugger.js

Forgot to commit a file this morning that actually makes the Drosera console open. Thanks bdash!

8:31 PM Changeset in webkit [15368] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Windows build fix. Reviewed by NOBODY.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added JSHTMLOptionsCollection.cpp/h and JSHTMLOptionsCollectionCuston.cpp. VC++ Express realphabetized the file list.
7:55 PM Changeset in webkit [15367] by darin
  • 10 edits in trunk/WebCore

Reviewed by Adele.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const reference for the list items, so we don't have to copy a vector.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): Ditto. (WebCore::HTMLSelectElement::setSelectedIndex): Ditto. (WebCore::HTMLSelectElement::length): Ditto. (WebCore::HTMLSelectElement::remove): Ditto. (WebCore::HTMLSelectElement::value): Ditto. (WebCore::HTMLSelectElement::setValue): Ditto. (WebCore::HTMLSelectElement::stateValue): Ditto. (WebCore::HTMLSelectElement::restoreState): Ditto. (WebCore::HTMLSelectElement::appendFormData): Ditto. (WebCore::HTMLSelectElement::optionToListIndex): Ditto. (WebCore::HTMLSelectElement::listToOptionIndex): Ditto. (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate fields mutable. (WebCore::HTMLSelectElement::reset): Use a const reference for the list items, so we don't have to copy the vector. Remove the call to setSelectionChanged for the RenderMenuList case. (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts. (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing the pop-up.
  • html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend. Changed the listItems function to return a const reference to the vector so it no longer copies the vector. Removed the const_cast to the call to recalcListItems and changed it to a const member function. Made m_recalcListItems mutable.
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call to recalcListItems, which is called automatically. Use a const reference for the list items so we don't have to copy a vector. (WebCore::DeprecatedRenderSelect::layout): Ditto. (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto. (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members. (WebCore::RenderMenuList::createInnerBlock): Ditto. (WebCore::RenderMenuList::addChild): Ditto. (WebCore::RenderMenuList::removeChild): Ditto. (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style on the pop-up menu, because it's created with the correct style and destroyed before it a style change could occur. (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the maximum width in a simpler fashion, and to not bother trying to maintain the "selected" flags on the elements, since the HTMLSelectElement class takes care of that. Store the width as an int. Call setText to set the text based on the selected element's option text. (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting up the clip -- always set up the clip. (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly instead of calling ceilf on m_longestWidth. (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the menu -- instead keep the pointer in a local variable. Get the selected index from the HTMLSelectElement. (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex to do most of the work.
  • rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed m_longestWidth to m_optionsWidth and changed it to be an int. Removed unneeded override of removeLeftoverAnonymousBoxes function. Removed unneeded selectionChanged, setSelectionChanged, updateSelection, and hasPopupMenu functions. Removed extra includes.
  • rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Change to iterate the list items instead of iterating all children of the select node.
  • rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
  • rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create the pop-up here from the caller. Removed an extra retain that would cause the NSPopUpButtonCell to leak. (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to create the pop-up, which is now in populate, and also the call to the clear function, for the same reason. Reorganized code to make it a bit more readable. Removed an unnecessary if to check if frame is nil. Used a RefPtr to make sure we don't make a call on a frame after it's deleted. As part of the reorganization fixed a problem where we'd retain the event and then return early without releasing it in one case. (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little. (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to manage the NSMenu at the bottom of the function. (WebCore::RenderPopupMenuMac::addOption): Ditto.
7:21 PM Changeset in webkit [15366] by justing
  • 14 edits in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/merge-unrendered-space-expected.checksum:
  • editing/deleting/merge-unrendered-space-expected.png:

WebCore:

Reviewed by levi


<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.
5:45 PM Changeset in webkit [15365] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.

5:40 PM Changeset in webkit [15364] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (build fix)

  • bindings/objc/DOMPrivate.h: Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject there is of a different type. Also clarified a highly misleading comment from my last commit. I meant to clarify the comment before landing.
5:27 PM Changeset in webkit [15363] by andersca
  • 2 edits
    3 adds in trunk/WebCore

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9635
REGRESSION: Crash when adding to cart at <​http://www.yemeksepeti.com/>


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Don't load external scripts if the parser is stopped.


  • manual-tests/open-close-tokenizer-crash.html: Added.
  • manual-tests/resources/empty-file.js: Added.
  • manual-tests/resources/open-close-tokenizer-crash.html: Added. Add manual test.
5:00 PM Changeset in webkit [15362] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Kevin and Tim O

  • added support for creating a selection image with white text
  • WebView/WebDocumentPrivate.h: added -selectionImageForcingWhiteText: and -selectionImageRect to the private <WebDocumentSelection> protocol
  • Misc/WebSearchableTextView.m: (-[NSString selectionImageForcingWhiteText:]): added stub for this new method to this obsolete class to satisfy the compiler (-[NSString selectionImageRect]): ditto


  • WebView/WebHTMLView.m: (-[WebHTMLView _selectionDraggingImage]): now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage (-[WebHTMLView _selectionDraggingRect]): now calls selectionImageRect, to which the implementation moved (-[WebHTMLView selectionImageForcingWhiteText:]): implemented this new method by calling through to new bridge method selectionImageForcingWhiteText: (-[WebHTMLView selectionImageRect]): implemented this new method by using existing _selectionDraggingRect implementation


  • WebView/WebPDFView.m: (-[WebPDFView selectionImageForcingWhiteText:]): implemented by using code that was formerly in Safari (-[WebPDFView selectionImageRect]): implemented by returning selectionRect
4:59 PM Changeset in webkit [15361] by sullivan
  • 15 edits in trunk/WebCore

Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)

  • added support for creating a selection image with white text
  • rendering/RenderObject.h: (WebCore::): add PaintRestriction enum (WebCore::RenderObject::PaintInfo::PaintInfo): add forceWhiteText boolean to PaintInfo struct
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the text to white
  • page/Frame.cpp: (WebCore::Frame::paint): updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::selectionImage): now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionImageForcingWhiteText:]): renamed from selectionImage, now takes forceWhiteText parameter, which is passed down into Frame
  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): use a PaintRestriction value where we used to use a selectionOnly bool (WebCore::RenderLayer::paintLayer): ditto; also stores forceWhiteText in PaintInfo struct
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): updated for changed signature of PaintInfo constructor
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): ditto
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): ditto
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): paint with white text color if forceWhiteText is set in PaintInfo struct
4:58 PM Changeset in webkit [15360] by tomernic
  • 18 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test case for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • plugins/netscape-dom-access-expected.checksum: Added.
  • plugins/netscape-dom-access-expected.png: Added.
  • plugins/netscape-dom-access-expected.txt: Added.
  • plugins/netscape-dom-access.html: Added.

WebCore:

Reviewed by Anders.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • html/HTMLPlugInElement.h: Just import JSC headers on Mac. The NPObject and Bindings::Instance stuff is only used on Mac anyway. Changed APPLE to PLATFORM(MAC). Added m_NPObject ivar.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize the NPObject. (WebCore::HTMLPlugInElement::~HTMLPlugInElement): Release the NPObject when the element is destroyed. (WebCore::HTMLPlugInElement::createNPObject): Creates an NPObject for the element. (WebCore::HTMLPlugInElement::getNPObject): Returns the NPObject for the element, creating and caching it if necessary.
  • html/HTMLAppletElement.h: Changed APPLE to PLATFORM(MAC).
  • html/HTMLAppletElement.cpp: ditto
  • html/HTMLEmbedElement.h: ditto
  • html/HTMLEmbedElement.cpp: ditto
  • html/HTMLObjectElement.h: ditto
  • html/HTMLObjectElement.cpp: ditto
  • bindings/objc/DOMPrivate.h: Added -[DOMElement _NPObject].
  • bindings/objc/DOM.mm: (-[DOMElement _NPObject]): Returns the NPObject for the element. Since this is only needed by the Netscape plug-in API, you can only get the NPObject for applet, embed, and object elements.

WebKit:

Reviewed by Geoff.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Release DOM element. (-[WebBaseNetscapePluginView getVariable:value:]): Return NPObject for plugin DOM element.
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Pass DOMElement to Netscape plug-ins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto
4:32 PM Changeset in webkit [15359] by adele
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
REGRESSION: Can't dynamically change list box to popup

  • fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • fast/forms/select-change-listbox-to-popup.html: Added.
  • fast/forms/select-change-popup-to-listbox.html:

WebCore:

Reviewed by Hyatt.


and updated fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

The original fix for 9859 was in the renderer, and I think we can catch the change
earlier in the element to detach and reattach.

I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect

Test: fast/forms/select-change-listbox-to-popup.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa, and we're already attached, then detach and reattach to create the correct renderer. If we're not attached, then we'll create the correct renderer when we attach. (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle. (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto. (WebCore::HTMLSelectElement::isMouseFocusable): ditto. (WebCore::HTMLSelectElement::createRenderer): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::notifyOptionSelected): ditto. (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): This method no longer takes a RenderStyle. That was leftover from when we used to use the appearance to determine whether or not to use the new menu list implementation.
  • rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::updateSelection):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Backed out previous fix since this is now done in HTMLSelectElement.
3:35 PM Changeset in webkit [15358] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi & thatcher


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Reviewed by levi & thatcher


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection


  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
3:13 PM Changeset in webkit [15357] by thatcher
  • 1 copy in tags/WebCore-315.14.5/WebCore

Tag for WebCore 315.14.5 (part 2 of 2.)

3:13 PM Changeset in webkit [15356] by thatcher
  • 1 add in tags/WebCore-315.14.5

Tag for WebCore 315.14.5 (part 1 of 2.)

3:13 PM Changeset in webkit [15355] by thatcher
  • 1 delete in tags/WebCore-===

bad tag.

3:13 PM Changeset in webkit [15354] by thatcher
  • 1 delete in tags/WebCore-315.14.4/WebCore/WebCore

bad tag.

3:12 PM Changeset in webkit [15353] by thatcher
  • 1 copy in tags/WebCore-315.14.4/WebCore/WebCore

Tag for WebCore 315.14.4 (part 2 of 2.)

3:11 PM Changeset in webkit [15352] by thatcher
  • 1 add in tags/WebCore-===

Tag for WebCore === (part 1 of 2.)

3:10 PM Changeset in webkit [15351] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:08 PM Changeset in webkit [15350] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-07-06 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

  • Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with $
  • khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to $ If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exi$
  • khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.
2:42 PM Changeset in webkit [15349] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

  • fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
  • fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • fast/forms/select-change-popup-to-listbox.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

Test: fast/forms/select-change-popup-to-listbox.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): If the select element has the multiple property set, or has a size > 1, then it really should be a list box, so we detach and attach the element so it creates the correct type of renderer.
2:31 PM Changeset in webkit [15348] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin and Tim Omernick

  • fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks at non-integral scale factors
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::imageFromRect): round image rect in window coordinate space
2:30 PM Changeset in webkit [15347] by thatcher
  • 1 copy in tags/WebCore-418.20.1/WebCore

New tag (part 2).

2:28 PM Changeset in webkit [15346] by thatcher
  • 1 add in tags/WebCore-418.20.1

Tag for WebCore 418.20.1 (part 1 of 2.)

2:23 PM Changeset in webkit [15345] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:08 PM Changeset in webkit [15344] by thatcher
  • 2 edits in tags/WebKit-521.16.1/WebKit

Build fix.

2:06 PM Changeset in webkit [15343] by thatcher
  • 1 copy in tags/WebKit-521.16.1/WebKit

New tag (part 2)

2:05 PM Changeset in webkit [15342] by thatcher
  • 1 add in tags/WebKit-521.16.1

New tag.

1:58 PM Changeset in webkit [15341] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4622748> WebKit now uses deprecated AGL functions

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _createWindowedAGLContext]): aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.
12:07 PM Changeset in webkit [15340] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

The fix itself was landed on 2006-07-09, but I forgot about the test.

  • http/tests/misc/xhtml-expected.txt: Added.
  • http/tests/misc/xhtml.php: Added.
11:54 AM Changeset in webkit [15339] by bdakin
  • 4 edits in trunk/LayoutTests

Reviewed by Adele.

Adele checked in new results for this test when you could style
selects, but the styling of selects is turned off for now, so back
to the original results.

  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/001-expected.txt:
11:40 AM Changeset in webkit [15338] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Adding the radar to a change.

11:21 AM Changeset in webkit [15337] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Tim O.

WebKit:

  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Remove the early return when requesting an invalid (unsupported) URL.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL - should open a new stream and deliver the data to the current instance.

LayoutTests:

  • plugins/get-empty-url-expected.txt: Added.
  • plugins/get-empty-url.html: Added.
11:13 AM Changeset in webkit [15336] by thatcher
  • 6 edits
    4 adds in trunk/WebKitTools

Reviewed by Darin.

Bug 9598: [Drosera] add a JavaScript evaluator console
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9598

  • Drosera/DebuggerApplication.h:
  • Drosera/DebuggerApplication.m: (-[DebuggerApplication knownServers]):
  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[WebScriptObject evaluateScript:inCallFrame:]): (-[WebScriptObject showConsole:]): (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[WebScriptObject toolbarDefaultItemIdentifiers:]): (-[WebScriptObject toolbarAllowedItemIdentifiers:]): (-[WebScriptObject webView:createWebViewWithRequest:]): (-[WebScriptObject webViewShow:]): (-[WebScriptObject webViewAreToolbarsVisible:]): (-[WebScriptObject webView:setToolbarsVisible:]): (-[WebScriptObject webView:setResizable:]): (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]): (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject webView:windowScriptObjectAvailable:]): (-[WebScriptObject webView:didFinishLoadForFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Images/console.png: Added.
  • Drosera/console.css: Added.
  • Drosera/console.html: Added.
  • Drosera/console.js: Added.
11:02 AM Changeset in webkit [15335] by spadma
  • 2 edits
    1 add in S60/trunk/WebKit

2006-07-11 zalan <​zbujtas@gmail.com>

Reviewed by Sachin/David. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9401

Fix resource file directories. Missing #include <data_caging_paths.hrh>


8:00 AM Changeset in webkit [15334] by zbujtas
  • 2 edits in S60/trunk

2006-07-07 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.

  • S60Internals/S60Headers.zip: data_caging_paths to \epoc32\include


Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9776

7:21 AM Changeset in webkit [15333] by zbujtas
  • 2 edits in S60/trunk

2006-07-07 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com

12:51 AM Changeset in webkit [15332] by thatcher
  • 5 edits in trunk/WebKitTools

Reviewed by a tired Geoff.

Bug 9597: [Drosera] hook up the variables table to show stack variables
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9597

  • Drosera/DebuggerDocument.m: (-[WebScriptObject isSelectorExcludedFromWebScript:]): (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): (-[WebScriptObject localScopeVariableNamesForCallFrame:]): (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]): (-[WebScriptObject webView:didLoadMainResourceForDataSource:]): (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
12:30 AM Changeset in webkit [15331] by tomernic
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9844>:
Add DOM access test to DumpRenderTree's Netscape plug-in

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (testDOMAccess): (pluginInvoke):

Jul 10, 2006:

11:04 PM Changeset in webkit [15330] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • dom/Node.h:
  • dom/Node.cpp: (WebCore::Node::renderStyle): Made a const member function. The derived classes were overriding with const member functions, and I could change either this or the derived -- decided to do this.
10:48 PM Changeset in webkit [15329] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Code wants the family name, but was calling fontName, which is not the same thing. Also removed the unneeded conversion to DeprecatedString.
10:37 PM Changeset in webkit [15328] by ggaren
  • 10 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • Changed public header includes to the <JavaScriptCore/ style.
  • Changed instances of 'buffer' to 'string' since we decided on JSInternalString instead of JSStringBuffer.
  • API/JSContextRef.h:
  • API/JSInternalStringRef.cpp: (JSStringMake): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (CFStringCreateWithJSInternalString):
  • API/JSInternalStringRef.h:
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType):
  • API/JSObjectRef.cpp: (JSObjectCallAsConstructor):
  • API/JSValueRef.h:
  • API/JavaScriptCore.h:
  • API/minidom.c: (main): (print):
  • API/testapi.c: (MyObject_getPropertyList): (myConstructor_callAsConstructor): (main): I noticed that we were prematurely releasing some string buffers, so I moved their release calls to the end of main(). I got rid of 'Buf' in *Buf (sometimes changing to 'IString', when necessary to differentiate a variable) to match the buffer->string change.
9:36 PM Changeset in webkit [15327] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Now track three states: initializing, running, and closed. If we are launched and the previous
state was initializing then we likely just experienced a crash on launch.

  • WebKitLauncher/WebKitNightlyEnabler.m: (myApplicationWillFinishLaunching): Improve wording of dialog. Update to set new running state. (myApplicationWillTerminate): Update to use new states. (cleanUpAfterOurselves): Display alert if previous state was initializing. Set state as initializing as early as practical. (symbol_lookup): Bring code up to speed with formatting guidelines. (GDSymbolLookup): Ditto.
8:40 PM Changeset in webkit [15326] by thatcher
  • 5 copies in tags/Safari-521.16

New tag.

8:37 PM Changeset in webkit [15325] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/value.cpp: (KJS::JSValue::toInt32Inline): Added inline keyword one more place. Just in case.
8:36 PM Changeset in webkit [15324] by thatcher
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Move the release tag.

8:34 PM Changeset in webkit [15323] by darin
  • 3 edits in trunk/JavaScriptCore
  • fix the release build
  • kjs/value.h:
  • kjs/value.cpp: (KJS::JSValue::toInt32Inline): Move the code here to an inline. (KJS::JSValue::toInt32): Call the inline from both overloaded toInt32 functions.
8:33 PM Changeset in webkit [15322] by thatcher
  • 6 edits in /

Versioning

8:16 PM Changeset in webkit [15321] by ddkilzer
  • 20 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
  • JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for kjs/value.h to make it available as a forwarded header.
  • kjs/lookup.h: (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method. The new method returns a boolean value if no entry is found in the lookup table.
  • kjs/value.cpp: (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
  • kjs/value.h: Ditto.

LayoutTests:

Reviewed by Darin.

  • fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
  • fast/dom/select-selectedIndex-multiple.html: Updated to print comments between tests to make failures easier to track down.
  • fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
  • fast/dom/select-selectedIndex.html: Ditto.
  • fast/js/resources/select-options-add.js: Added.
  • fast/js/select-options-add-expected.txt: Added.
  • fast/js/select-options-add.html: Added.

WebCore:

Reviewed by Darin.

Tests:

  • fast/dom/select-selectedIndex-multiple.html
  • fast/dom/select-selectedIndex.html
  • fast/js/select-options-add.html
  • DerivedSources.make: Added JSHTMLOptionsCollection.h.
  • ForwardingHeaders/kjs/operations.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Added new source files.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added. (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter):
  • bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation. Renamed classes and methods for consistency. (KJS::JSHTMLElement::selectGetter): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionProtoFunc::callAsFunction): (KJS::getHTMLOptionsCollection):
  • bindings/js/kjs_html.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute. Added support for Optional parameter attribute, which makes generated code assume overloaded implementation methods are available for a JavaScript function with optional arguments. Changed local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
  • html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
  • html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class. (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): (WebCore::HTMLOptionsCollection::add): (WebCore::HTMLOptionsCollection::selectedIndex): (WebCore::HTMLOptionsCollection::setSelectedIndex): (WebCore::HTMLOptionsCollection::setLength):
  • html/HTMLOptionsCollection.h: Ditto.
  • html/HTMLOptionsCollection.idl: Added.
7:02 PM Changeset in webkit [15320] by harrison
  • 6 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4602408> -webkit-highlight needs to support images and elements other than text

  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RenderBox.h: Utility for subclasses.


  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint): Custom highlight in front of images.


  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): Custom highlight in front of list markers.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Custom highlight in front of objects.
6:22 PM Changeset in webkit [15319] by hyatt
  • 6 edits in trunk/WebCore

Better fix for repainting issue with positioned objects when height
changes. Optimize when only a positioned child changes so that we don't
incorrectly do normal flow layout.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderView.cpp: (WebCore::RenderView::layout):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
5:27 PM Changeset in webkit [15318] by ggaren
  • 1 edit
    1 delete in trunk/JavaScriptCore

No review necessary. Removed bogus file I accidentally checked in before.

  • API/JSInternalSringRef.h: Removed.
5:26 PM Changeset in webkit [15317] by ggaren
  • 15 edits in trunk/JavaScriptCore

Reviewed by Darin.


Added exception out parameter to API object callbacks, removed semi-bogus
JSContext(.*)Exception functions.


To make these calls syntactically simple, I added an exceptionSlot()
method to the ExecState class, which provides a JSValue slot in which to
store a JSValue* exception.

  • API/APICast.h: (toRef):
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::getPropertyList): (KJS::JSCallbackObject::toBoolean): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSContextRef.cpp: (JSCheckSyntax):
  • API/JSContextRef.h:
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild): (JSNode_construct):
  • API/JSNode.h:
  • API/JSNodeList.c: (JSNodeListPrototype_item): (JSNodeList_length): (JSNodeList_getProperty):
  • API/JSObjectRef.h:
  • API/minidom.c: (print):
  • API/testapi.c: (MyObject_initialize): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
  • JavaScriptCore.exp:
  • kjs/ExecState.h: (KJS::ExecState::exceptionHandle):
4:52 PM Changeset in webkit [15316] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth.

Test for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

  • fast/forms/select-style-expected.checksum: Added.
  • fast/forms/select-style-expected.png: Added.
  • fast/forms/select-style-expected.txt: Added.
  • fast/forms/select-style.html: Added.

WebCore:

Reviewed by Beth.

  • Fix for <rdar://problem/4621442> REGRESSION (NativePopup) : Popup menus aren't drawn correctly on page at orbitz.com; cheaptickets.com

Test: fast/forms/select-style.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Don't let popups be style-able for now. We'll allow it later, when we have a good way to handle border & backgrounds and still having it look like a control.
4:50 PM Changeset in webkit [15315] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • WebView/WebDataSource.m: (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is has just loaded it (when coming from the back/forward cache, it hasn't).
3:29 PM Changeset in webkit [15314] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison


<rdar://problem/4619260>
9A213 + Safari 521.15.1 Crash with To Do's alarm icon (WebCore::maxDeepOffset(WebCore::Node const*) )
<rdar://problem/4619841>
REGRESSION: Dragging selection over input field results in a crash (WebCore::maxDeepOffset(WebCore::Node const*)

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Iterate using next/previousVisuallyDistinctCandidate instead of traverseNext/Previous node because we were skipping positions. Jump out of shadow trees. Migrate to isEditablePosition instead of isContentEditable.
3:25 PM Changeset in webkit [15313] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Shuffling comments around from my last check-in to make things read
more clearly.

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
3:05 PM Changeset in webkit [15312] by bdakin
  • 5 edits
    4 adds in trunk

Reviewed by Darin.

Fix for <rdar://problem/4621095> The should be a way to
access the user interface scale factor through the DOM

window.devicePixelRatio returns the user interface scale factor.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::devicePixelRatio):
  • page/DOMWindow.h:
  • page/DOMWindow.idl:
2:39 PM Changeset in webkit [15311] by spadma
  • 8 edits in S60/trunk

2006-07-10 David Carson <​david.carson@nokia.com>

Reviewed by Sachin/Zalan.

Fix for network connection, remove use of InternetConnectionManager
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9451


  • WebKit\BrowserView\src\HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequest) Added check fo NULL pointer as aConnectionPtr could be null after the cb
  • S60WebUi\WebUi\src\WebUiSessionAndSecurity.cpp
  • S60WebUi\WebUi\inc\WebUiSessionAndSecurity.h Removed dependancy on InternetConnectionManager, and removed ShowSessionInfo as the information is available from the Connection Manager application. Constructor no longer takes a InternetConnectionManager reference.


  • S60WebUi\WebUi\data\WebUi.rss
  • S60WebUi\WebUi\inc\WebUi.hrh Removed ShowSessionInfo menu option


  • S60WebUi\WebUi\src\WebUiWindowContainer.cpp
    • S60WebUi\WebUi\inc\WebUiWindowContainer.h (CWebUiWindowContainer::HandleCommandL): Removed ShowSessionInfo option (CWebUiWindowContainer::NetworkConnectionNeededL): Made function empty as Symbian default handler does the work.
2:17 PM Changeset in webkit [15310] by ggaren
  • 13 edits in trunk/JavaScriptCore

Reviewed by Darin.

Improved type safety by implementing opaque JSValue/JSObject typing through
abuse of 'const', not void*. Also fixed an alarming number of bugs
exposed by this new type safety.


I made one design change in JavaScriptCore, which is that the JSObject
constructor should take a JSValue* as its prototype argument, not a JSObject*,
since we allow the prototype to be any JSValue*, including jsNull(), for
example.


  • API/APICast.h: (toJS):
  • API/JSBase.h:
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSCallbackObject.h:
  • API/JSContextRef.cpp: (JSEvaluate):
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild):
  • API/JSObjectRef.cpp: (JSObjectMake): (JSFunctionMakeWithBody): (JSObjectGetProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
  • API/JSObjectRef.h:
  • API/testapi.c: (main):
  • ChangeLog:
  • kjs/object.h: (KJS::JSObject::JSObject):
1:53 PM Changeset in webkit [15309] by adele
  • 37 edits in trunk/LayoutTests

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9830
More pixel test results need updating since switching to native popup

  • editing/selection/replaced-boundaries-3-expected.checksum:
  • editing/selection/replaced-boundaries-3-expected.png:
  • fast/block/margin-collapse/103-expected.checksum:
  • fast/block/margin-collapse/103-expected.png:
  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/HTMLOptionElement_label01-expected.checksum:
  • fast/forms/HTMLOptionElement_label01-expected.png:
  • fast/forms/HTMLOptionElement_label02-expected.checksum:
  • fast/forms/HTMLOptionElement_label02-expected.png:
  • fast/forms/HTMLOptionElement_label03-expected.checksum:
  • fast/forms/HTMLOptionElement_label03-expected.png:
  • fast/forms/HTMLOptionElement_label04-expected.checksum:
  • fast/forms/HTMLOptionElement_label04-expected.png:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/option-script-expected.checksum:
  • fast/forms/option-script-expected.png:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/invalid/014-expected.checksum:
  • fast/invalid/014-expected.png:
  • fast/parser/document-write-option-expected.checksum:
  • fast/parser/document-write-option-expected.png:
  • tables/mozilla/bugs/bug2479-3-expected.checksum:
  • tables/mozilla/bugs/bug2479-3-expected.png:
  • tables/mozilla/bugs/bug29326-expected.checksum:
  • tables/mozilla/bugs/bug29326-expected.png:
  • tables/mozilla/bugs/bug33855-expected.checksum:
  • tables/mozilla/bugs/bug33855-expected.png:
  • tables/mozilla/bugs/bug96334-expected.checksum:
  • tables/mozilla/bugs/bug96334-expected.png:
  • tables/mozilla/core/margins-expected.checksum:
  • tables/mozilla/core/margins-expected.png:
  • tables/mozilla/dom/tableDom-expected.checksum:
  • tables/mozilla/dom/tableDom-expected.png:
10:47 AM Changeset in webkit [15308] by beidson
  • 4 edits in trunk

WebCore:

Reviewed by Alexey

Resolved the console error messages people got from the new DB even if they didn't have it enabled

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnreferencedIcons): (WebCore::IconDatabase::pruneUnretainedIcons): Added quick check to bail if the DB isn't open

WebKit:

Reviewed by Alexey

Resolved the console error messages people got from the new DB even if they didn't have it enabled

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Disabled initializing the IconDatabaseBridge if user is living on the old DB
10:41 AM Changeset in webkit [15307] by ggaren
  • 16 edits
    1 copy
    2 moves in trunk/JavaScriptCore

Approved by Maciej, Darin.


Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
JavaScript engine's internal string representation, which is the most
low-level and efficient representation to use when interfacing with JavaScript.

  • API/APICast.h: (toJS): (toRef):
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
  • API/JSContextRef.h:
  • API/JSInternalStringRef.cpp: Added. (JSStringMake): (JSInternalStringCreate): (JSInternalStringCreateUTF8): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (JSInternalStringIsEqual): (JSInternalStringIsEqualUTF8): (JSInternalStringCreateCF): (CFStringCreateWithJSInternalString):
  • API/JSInternalStringRef.h: Added.
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
  • API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
  • API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
  • API/JSObjectRef.h:
  • API/JSStringBufferRef.cpp: Removed.
  • API/JSStringBufferRef.h: Removed.
  • API/JSValueRef.h:
  • API/JavaScriptCore.h:
  • API/minidom.c: (main): (print):
  • API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
9:48 AM Changeset in webkit [15306] by harrison
  • 2 edits in trunk/WebCore
9:18 AM Changeset in webkit [15305] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • manual-tests/ATSU-bad-layout.html: Added.
  • platform/mac/FontMac.mm: (WebCore::Font::floatWidthForComplexText): Return 0 immediately for empty runs.
8:54 AM Changeset in webkit [15304] by darin
  • 2 edits in trunk/WebCore
  • try to fix the no-SVG build
  • ksvg2/misc/SVGImageLoader.cpp: Move namespace brace inside the #if.
8:53 AM Changeset in webkit [15303] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Anders.

  • manual-tests/empty-title-popup.html: Added.
  • rendering/RenderMenuList.h: Add createInnerBlock.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::createInnerBlock): Factored out of addChild. (WebCore::RenderMenuList::addChild): Call createInnerBlock. (WebCore::RenderMenuList::setText): Changed parameter type. (WebCore::RenderMenuList::showPopup): Call createInnerBlock before calling the parent class's addChild.
8:34 AM Changeset in webkit [15302] by darin
  • 2 edits in trunk/WebKitTools
  • try to fix Windows build
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove include paths with "khtml" in them. Add one for "html" subdir or WebCore.
8:00 AM Changeset in webkit [15301] by darin
  • 2 edits in trunk/LayoutTests
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Updated one more result for Adele's 4463835 change last night.
5:57 AM Changeset in webkit [15300] by ddkilzer
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by Maciej via IRC. Patch by Rob Buis.

Make sure the attributes are calculated against viewport width value,
as defined in the spec. ​http://paste.lisp.org/display/22342

  • ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::rx): Changed LM_HEIGHT to LM_WIDTH.
  • ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::x2): Ditto.
4:39 AM Changeset in webkit [15299] by bdakin
  • 10 edits
    13 adds in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4610314> Support the CSS3 content property
for images

This patch provides initial support for the CSS3 content property.
It lacks support for any content other than images, and only allows
content for elements that seemed safe for now.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove restrictions for just :before and :after
  • html/HTMLBRElement.cpp: (WebCore::HTMLBRElement::createRenderer):
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::createRenderer):
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::createRenderer):
  • html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::createRenderer):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setCachedImage): Don't allow the image to be set this way if it was already set with the content property.
  • rendering/RenderImage.h: (WebCore::RenderImage::setIsAnonymousImage): Anonymous images are those set through the content property. (WebCore::RenderImage::isAnonymousImage):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): If there is content specified, create a RenderImage with the content and initialize the cached image to whatever was specified in the CSS.
3:31 AM Changeset in webkit [15298] by beidson
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (Build Fix!)

  • icon/SiteIcon.cpp: (SiteIcon::getImage): Release build made an "unused variable" warning, which is, of course, an error. fixed that.
2:57 AM Changeset in webkit [15297] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Maciej

SQLite Icon DB now fully replicates functionality of the old DB, including pruning to keep unused
information out to keep down disk usage. For now, it is still off by default, as the critical
feature of importing old icons into the new DB is still unrealized.
If you'd like to test, add #define ICONDEBUG to your WebKitPrefix.h

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): -Sets up a timer for initial pruning (WebCore::IconDatabase::iconForPageURL): -Switched away from "dirty blob hack" as the problem is provisionally solved (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): -Same as found in WebKit (WebCore::IconDatabase::totalRetainCountForIconURL): -Adds up all retainers of icon (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): -Wipes an Icon table entry out (WebCore::IconDatabase::establishTemporaryIconIDForIconURL): (WebCore::IconDatabase::establishTemporaryIconIDForEscapedIconURL): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::IconDatabase::establishIconIDForEscapedIconURL): -Added ability to get an iconID without creating a new one if a lookup is all

that is genuinely wanted

(WebCore::IconDatabase::pruneUnreferencedIcons):
(WebCore::IconDatabase::pruneUnretainedIcons):

-Called on a timer on DB startup to clean it out

  • icon/IconDatabase.h:
  • icon/SiteIcon.cpp: (SiteIcon::SiteIcon): (SiteIcon::~SiteIcon): -Deletes the image on deletion (SiteIcon::getImage): -Cut down on no-longer-necessary debug info
2:02 AM Changeset in webkit [15296] by andersca
  • 4 edits
    2 adds in trunk

WebCore:

2006-07-10 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Don't call prepareSubmit if the element is disabled.

LayoutTest:

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9245
Quirksmode: Incorrect handling of disabled BUTTON elements


  • fast/forms/activate-and-disabled-elements-expected.txt: Added.
  • fast/forms/activate-and-disabled-elements.html: Added.
1:01 AM Changeset in webkit [15295] by darin
  • 3 edits in trunk/WebCore
  • try to fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Put a few functions in the WebCore namespace.
  • platform/gdk/TemporaryLinkStubs.cpp: Ditto.
12:59 AM Changeset in webkit [15294] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix failures seen in layout tests
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Restore one of the few WebCore:: prefixes that really needed to be there -- because we have two classes named JSHTMLDocument at the moment! (One in KJS and one in WebCore namespace.)
12:40 AM Changeset in webkit [15293] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • rendering/RenderLayer.h: Correct a forward declaration of ScrollBar.
12:33 AM Changeset in webkit [15292] by darin
  • 2 edits in trunk/WebKit
  • try to fix Windows build
  • COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.
12:19 AM Changeset in webkit [15291] by adele
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Maciej.

Updated results for:
<rdar://problem/4463835> Switch to use new popup menu implementation for <select>

  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/dom/option-properties-expected.txt:
  • fast/forms/003-expected.txt:
  • fast/forms/004-expected.txt:
  • fast/forms/HTMLOptionElement_label01-expected.txt:
  • fast/forms/HTMLOptionElement_label02-expected.txt:
  • fast/forms/HTMLOptionElement_label03-expected.txt:
  • fast/forms/HTMLOptionElement_label04-expected.txt:
  • fast/forms/HTMLOptionElement_label06-expected.txt:
  • fast/forms/HTMLOptionElement_label07-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/option-script-expected.txt:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/select-remove-option-expected.txt:
  • fast/forms/select-replace-option-expected.txt:
  • fast/forms/select-reset-expected.txt:
  • fast/invalid/014-expected.txt:
  • fast/parser/document-write-option-expected.txt:
  • fast/replaced/width100percent-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug2479-3-expected.txt:
  • tables/mozilla/bugs/bug2479-4-expected.txt:
  • tables/mozilla/bugs/bug29326-expected.txt:
  • tables/mozilla/bugs/bug33855-expected.txt:
  • tables/mozilla/bugs/bug4382-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/core/margins-expected.txt:
  • tables/mozilla/dom/tableDom-expected.txt:
12:19 AM Changeset in webkit [15290] by adele
  • 41 edits in trunk

Reviewed by Maciej.

Fix for <rdar://problem/4463835> Switch to use new popup menu implementation for <select>

  • css/html4.css: Added style for new selects, and for list boxes.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): Removed check for appearance so new popups can be styled.


  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Removed padding. This is now set by the theme. (WebCore::RenderMenuList::calcMinMaxWidth): Now takes minimum text size into account.
  • rendering/RenderMenuList.h: Removed baselinePosition since we're letting the theme calculate that.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlContainer): Added menuList as a ControlContainer, so RenderThemeMac will compute its baseline.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::minimumTextSize): Added.
  • rendering/RenderThemeMac.h: Added minimumTextSize, setPopupPaddingFromControlSize, popupButtonSizes, popupButtonMargins, popupButtonPadding. Removed sizeOfArrowControl.
  • rendering/RenderThemeMac.mm: (WebCore::): Added enum for padding. (WebCore::RenderThemeMac::adjustRepaintRect): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::baselinePosition): Now calculates baseline for menulist. (WebCore::RenderThemeMac::popupButtonMargins): Tweaked values. (WebCore::RenderThemeMac::popupButtonSizes): Added. (WebCore::RenderThemeMac::popupButtonPadding): Added, so different padding can be set for different control sizes. (WebCore::RenderThemeMac::setPopupPaddingFromControlSize): Added. (WebCore::RenderThemeMac::paintMenuList): Now inflates rect to account for control shadow. (WebCore::RenderThemeMac::adjustMenuListStyle): Resets border, sets padding, sets control size. (WebCore::RenderThemeMac::setPopupButtonCellState): Removed unnecessary class name. (WebCore::RenderThemeMac::minimumTextSize): Added.

Jul 9, 2006:

11:16 PM Changeset in webkit [15289] by darin
  • 6 edits in trunk/WebCore
  • add back "unused code" for plain text fields, still used by <isindex>!
  • platform/TextField.h:
  • platform/mac/TextFieldMac.mm:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderLineEdit.cpp:
11:15 PM Changeset in webkit [15288] by darin
  • 2 edits in trunk/WebKit
  • try to fix Windows build
  • COM/WebFrame.cpp: Rename QChar to DeprecatedChar.
11:05 PM Changeset in webkit [15287] by darin
  • 51 edits in trunk/WebKit
  • fix newlines to be consistent for all files in the COM directory (many had mixed style) and set the EOL style to "native" on them.
  • COM/*: Set properties and changed files.
10:20 PM Changeset in webkit [15286] by darin
  • 219 edits in trunk/WebCore

Reviewed by Tim Hatcher.

  • put more into the WebCore namespace
  • removed unused code for plain text fields

Put more classes, class templates, enums, functions, and constants into
the WebCore namespace, including all the headers in the platform directory.

Removed lots of unneeded "WebCore::" qualifiers and "using" directives.

Added some "WebCore::" qualifiers in a few places.

Removed "uses WebCore::" in headers that we said we'd remove "when
everything is in the WebCore namespace".

  • bindings/js/JSDOMParser.cpp:
  • bindings/js/JSHTMLElementWrapperFactory.cpp:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOM.mm:
  • bridge/History.h:
  • bridge/JavaAppletWidget.h:
  • bridge/mac/FormDataMac.h:
  • bridge/mac/FormDataMac.mm:
  • bridge/mac/WebCoreAXObject.mm:
  • bridge/mac/WebCoreEncodings.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm:
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCoreScriptDebugger.mm:
  • bridge/mac/WebCoreSettings.h:
  • css/CSSGrammar.y:
  • css/CSSPageRule.cpp:
  • css/CSSPageRule.h:
  • css/MediaList.cpp:
  • css/cssstyleselector.h:
  • dom/Clipboard.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/EventTargetNode.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Position.h:
  • dom/Range.cpp:
  • dom/XMLTokenizer.cpp:
  • editing/AppendNodeCommand.h:
  • editing/ApplyStyleCommand.cpp:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/BreakBlockquoteCommand.h:
  • editing/CompositeEditCommand.cpp:
  • editing/CompositeEditCommand.h:
  • editing/CreateLinkCommand.h:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/DeleteSelectionCommand.h:
  • editing/FormatBlockCommand.h:
  • editing/HTMLInterchange.cpp:
  • editing/HTMLInterchange.h:
  • editing/IndentOutdentCommand.h:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertLineBreakCommand.h:
  • editing/InsertListCommand.h:
  • editing/InsertNodeBeforeCommand.h:
  • editing/InsertTextCommand.cpp:
  • editing/InsertTextCommand.h:
  • editing/JSEditor.cpp:
  • editing/JSEditor.h:
  • editing/JoinTextNodesCommand.h:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/MergeIdenticalElementsCommand.h:
  • editing/ModifySelectionListLevel.h:
  • editing/MoveSelectionCommand.h:
  • editing/RebalanceWhitespaceCommand.h:
  • editing/RemoveNodeAttributeCommand.h:
  • editing/RemoveNodeCommand.h:
  • editing/RemoveNodePreservingChildrenCommand.h:
  • editing/ReplaceSelectionCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • editing/SplitElementCommand.cpp:
  • editing/SplitElementCommand.h:
  • editing/SplitTextNodeCommand.cpp:
  • editing/SplitTextNodeCommand.h:
  • editing/SplitTextNodeContainingElementCommand.h:
  • editing/TypingCommand.cpp:
  • editing/TypingCommand.h:
  • editing/UnlinkCommand.h:
  • editing/VisiblePosition.cpp:
  • editing/WrapContentsInDummySpanCommand.cpp:
  • editing/WrapContentsInDummySpanCommand.h:
  • editing/markup.cpp:
  • editing/markup.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLButtonElement.h:
  • html/HTMLCollection.h:
  • html/HTMLDocument.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLLabelElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • icon/IconDatabase.h:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderSVGContainer.cpp:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGElement.cpp:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGPoint.h:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGTRefElement.cpp:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.cpp:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/svgpathparser.cpp:
  • ksvg2/svg/svgpathparser.h:
  • loader/Cache.h:
  • loader/DocLoader.h:
  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm:
  • page/Frame.h:
  • page/FrameView.h:
  • page/Page.h:
  • page/Settings.h:
  • platform/AffineTransform.cpp:
  • platform/AffineTransform.h:
  • platform/Arena.cpp:
  • platform/Arena.h:
  • platform/CookieJar.h:
  • platform/DeprecatedCString.cpp:
  • platform/DeprecatedCString.h:
  • platform/DeprecatedPtrList.h:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedPtrListImpl.h:
  • platform/DeprecatedPtrQueue.h:
  • platform/DeprecatedString.cpp:
  • platform/DeprecatedString.h:
  • platform/DeprecatedStringList.cpp:
  • platform/DeprecatedStringList.h:
  • platform/DeprecatedValueList.h:
  • platform/DeprecatedValueListImpl.cpp:
  • platform/DeprecatedValueListImpl.h:
  • platform/FileButton.h:
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/FloatSize.h:
  • platform/FontData.h:
  • platform/FontFallbackList.h:
  • platform/GraphicsContext.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/ListBox.h:
  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/Pen.h:
  • platform/PopUpButton.h:
  • platform/RegularExpression.cpp:
  • platform/RegularExpression.h:
  • platform/SSLKeyGenerator.h:
  • platform/ScrollBar.h:
  • platform/SegmentedString.h:
  • platform/Shared.h:
  • platform/Slider.h:
  • platform/StringImpl.h:
  • platform/TextBox.h:
  • platform/TextField.h:
  • platform/TextStream.cpp:
  • platform/TextStream.h:
  • platform/TransferJob.h:
  • platform/TransferJobClient.h:
  • platform/Widget.h:
  • platform/cg/AffineTransformCG.cpp:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/DeprecatedStringListMac.mm:
  • platform/mac/FontCacheMac.mm:
  • platform/mac/KURLMac.mm:
  • platform/mac/ListBoxMac.mm:
  • platform/mac/PopUpButtonMac.mm:
  • platform/mac/SSLKeyGeneratorMac.mm:
  • platform/mac/TextBoxMac.mm:
  • platform/mac/TextFieldMac.mm:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextArea.mm:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextField.mm:
  • rendering/DeprecatedRenderSelect.h:
  • rendering/RenderArena.cpp:
  • rendering/RenderArena.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlow.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLineEdit.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp:
  • rendering/RenderStyle.h:
  • rendering/RenderText.cpp:
  • rendering/RenderTextFragment.cpp:
  • rendering/RenderTheme.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/RenderView.h:
  • rendering/bidi.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLTProcessor.cpp:
10:18 PM Changeset in webkit [15285] by ggaren
  • 5 edits in trunk

LayoutTests:

Reviewed by Beth.


Now that we garbage collect after reinitalizing the global object, not
before, we have more free memory, so a custom property that used to
get collected during the initialization phase of this test now avoids
getting collected until the collection phase.

  • fast/dom/gc-9-expected.txt:
  • fast/dom/gc-9.html:

WebCore:

Reviewed by Beth.

  • bindings/js/kjs_window.cpp: (KJS::Window::clear): Garbage collect after reinitalizing the global object, not before, since the reinitialization tends to create garbage.
9:45 PM Changeset in webkit [15284] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Build fix. Reviewed by NOBODY.

  • Scripts/webkitdirs.pm: Backed out previous change.
9:25 PM Changeset in webkit [15283] by thatcher
  • 3 edits in trunk/WebKit/WebView

Adding 2006 to the copyright years for headers I changed earlier.

9:18 PM Changeset in webkit [15282] by thatcher
  • 3 edits in trunk/WebCore/bindings/objc

FIx the copyright dates to include all years published.

9:05 PM Changeset in webkit [15281] by thatcher
  • 3 edits in trunk/WebCore/bindings/objc

Build fix for DumpRenderTree and other clients that don't use AppKit. Update the copyright date on headers I changed earlier.

9:00 PM Changeset in webkit [15280] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

  • svg/custom/foreign-object-skew-expected.checksum: Updated.
  • svg/custom/foreign-object-skew-expected.png: Updated.
8:46 PM Changeset in webkit [15279] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Set the ChangeLog entry date using a configurable timezone before applying the patch.
  • Scripts/svn-unapply: Reset the ChangeLog entry date before unapplying the patch.
8:26 PM Changeset in webkit [15278] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI

Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
This fixes many bugs involving plug-in mouse event handling in HiDPI. Most notably, the Flash player will now
correctly respond to clicks.

  • Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
8:13 PM Changeset in webkit [15277] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • fix assertion firing in plug-in layout tests
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Don't start null events if the plug-in is not in the started state. This happens when the plug-in moves within its view hierarchy after it has been stopped.
8:02 PM Changeset in webkit [15276] by thatcher
  • 14 edits in trunk

WebCore:

Reviewed by Darin.

Bug 9820: Move new DOM API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9820

  • bindings/objc/DOM.mm: (-[DOMElement focus]): (-[DOMElement blur]): (-[DOMRange text]): (-[DOMRange _text]):
  • bindings/objc/DOMCSS.mm: (-[DOMRGBColor color]): (-[DOMRGBColor _color]):
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]): (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPath.mm:

WebKit:

Reviewed by Darin.

Bug 9820: Move new DOM API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9820

  • Misc/WebElementDictionary.m: include DOMExtensions.h
  • Misc/WebNSViewExtras.m: include DOMExtensions.h
  • WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public
7:49 PM Changeset in webkit [15275] by thatcher
  • 8 edits in trunk/WebKit

Reviewed by Kevin.

Bug 9818: move new UIDelegate API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9818

<rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.

Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.

  • DefaultDelegates/WebDefaultUIDelegate.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge print]):
  • WebView/WebFrameView.h:
  • WebView/WebFrameView.m:
  • WebView/WebFrameViewPrivate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebUIDelegatePrivate.h:
7:43 PM Changeset in webkit [15274] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/delete-contents-expected.txt: Updated results that changed because we now keep comment nodes in the DOM.
7:31 PM Changeset in webkit [15273] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9749 A
nested content editable div causes unnecessary screen redraws.


We were repainting too much because we were deciding that we needed
a full layout because we didn't have a first line box. Our code
used to hold a lot of assumptions that positioned elements would
always have line boxes, but I fixed a few bugs a while back that
appeared because this assumption isn't true. This assumption was
also causing the extra redraws because the check meant that we
would decide to do a full layout for any positioned element that
did not have any line boxes in the first place. Maciej and I talked
about this, and we couldn't figure out why the check for line boxes
was part of determining if we need a full layout in the first
place. After hunting around the code, we decided to assume that
this check is antiquated. Removing it fixes the bug and doesn't
seem to break any layout tests. So, fingers crossed!

Will add layout test so soon.

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Remove firstLineBox check.
5:57 PM Changeset in webkit [15272] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Bug 9814: Move new WebView API that has been through API review to public headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9814

  • WebView/WebView.h:
  • WebView/WebView.m: (-[WebView close]): (-[WebView setShouldCloseWithWindow:]): (-[WebView shouldCloseWithWindow]): (-[WebView selectedFrame]): (-[WebView setMainFrameURL:]): (-[WebView mainFrameURL]): (-[WebView isLoading]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView mainFrameDocument]): (-[WebView setDrawsBackground:]): (-[WebView drawsBackground]): (-[WebView toggleSmartInsertDelete:]): (-[WebView toggleContinuousSpellChecking:]): (-[WebView canMakeTextStandardSize]): (-[WebView makeTextStandardSize:]): (-[WebView maintainsInactiveSelection]):
  • WebView/WebViewPrivate.h:
5:11 PM Changeset in webkit [15271] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

Bug 9487: The XPath section should be removed and/or moved.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9487

4:18 PM Changeset in webkit [15270] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

  • fast/dom/delete-contents-expected.checksum: Added.
  • fast/dom/delete-contents-expected.png: Added.
  • fast/dom/delete-contents-expected.txt: Added.
  • fast/dom/delete-contents.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4598149> Deleting the contents of a DOMRange and then inserting a node into it crashes in WebCore::Font::canUseGlyphCache

Test: fast/dom/delete-contents.html


  • dom/Range.cpp: (WebCore::Range::processContents):
3:48 PM Changeset in webkit [15269] by darin
  • 64 edits
    12 copies
    5 moves
    2 deletes in trunk/WebCore
  • another round of renaming; and KWQ is dead
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove paths for kwq and khtml directories. Move files to their new locations. Did rename.
  • WebCore.xcodeproj/project.pbxproj: Move files to their new locations. Did rename.
  • WebCoreSources.bkl: Did rename.
  • webcore-base.bkl: Removed kwq.
  • kwq/AccessibilityObjectCache.h: Removed.
  • kwq/AccessibilityObjectCache.mm: Removed.
  • kwq/FormDataMac.h: Removed.
  • kwq/FormDataMac.mm: Removed.
  • kwq/WebCoreAXObject.h: Removed.
  • kwq/WebCoreAXObject.mm: Removed.
  • kwq/WebCoreEditCommand.h: Removed.
  • kwq/WebCoreEditCommand.mm: Removed.
  • kwq/WebCorePageState.h: Removed.
  • kwq/WebCorePageState.mm: Removed.
  • kwq/WebCoreResourceLoaderImp.h: Removed.
  • kwq/WebCoreResourceLoaderImp.mm: Removed.
  • bridge/AXObjectCache.h: Added.
  • bridge/mac/AXObjectCacheMac.mm: Added.
  • bridge/mac/WebCoreAXObject.h: Added.
  • bridge/mac/WebCoreAXObject.mm: Added.
  • loader/CachedObject.cpp: Removed.
  • loader/CachedObject.h: Removed.
  • loader/CachedObjectClient.h: Removed.
  • loader/CachedObjectClientWalker.cpp: Removed.
  • loader/CachedObjectClientWalker.h: Removed.
  • loader/CachedResource.cpp: Added.
  • loader/CachedResource.h: Added.
  • loader/CachedResourceClient.h: Added.
  • loader/CachedResourceClientWalker.cpp: Added.
  • loader/CachedResourceClientWalker.h: Added.
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/CSSImageValue.h:
  • css/CSSImportRule.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Notation.h:
  • dom/ProcessingInstruction.h:
  • dom/XMLTokenizer.cpp:
  • html/CanvasPattern.h:
  • html/HTMLDocument.h:
  • html/HTMLImageLoader.cpp:
  • html/HTMLImageLoader.h:
  • html/HTMLLinkElement.h:
  • html/HTMLScriptElement.cpp:
  • html/HTMLScriptElement.h:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • kcanvas/KCanvasFilters.h:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFEImageElement.h:
  • loader/Cache.cpp:
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp:
  • loader/CachedImage.h:
  • loader/CachedScript.cpp:
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • loader/LoaderFunctions.h:
  • loader/Request.cpp:
  • loader/Request.h:
  • loader/loader.cpp:
  • loader/loader.h:
  • loader/mac/LoaderFunctionsMac.mm:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/ClipboardMac.h:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImage.h:
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderStyle.cpp:
  • rendering/RenderStyle.h:
  • xml/XSLImportRule.h: Did renaming.
  • platform/mac/can-convert.mm: Removed.
3:39 PM Changeset in webkit [15268] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Final version of this round of renaming for posterity.
3:35 PM Changeset in webkit [15267] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Remove conflict marker.

2:42 PM Changeset in webkit [15266] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Remove conflict marker. Thanks Mitz!

2:39 PM Changeset in webkit [15265] by andersca
  • 7 edits in trunk

WebCore:

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

  • WebCore.exp: Add wkPathFromFont.


  • platform/mac/FontDataMac.mm: (-[NSFont WebCore]): Use wkPathFromFont.


  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Declare wkPathFromFont.

WebKit:

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim O.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize wkPathFromFont.
2:31 PM Changeset in webkit [15264] by andersca
  • 3 edits in trunk/WebKitLibraries

2006-07-09 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a: Add WKPathFromFont.
2:11 PM Changeset in webkit [15263] by darin
  • 2 edits in trunk/WebKit
  • fix release build
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so that we don't have an unused variable in versions with assertions disabled. The alternative would be to wrap the whole thing in an #if statement.
1:37 PM Changeset in webkit [15262] by tomernic
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Added an OpenGL drawing model to the Netscape Plug-in API.

  • bindings/npapi.h:

WebKit:

Reviewed by John Sullivan.

  • Plugins/WebBaseNetscapePluginView.h:
  • Added ivars for OpenGL support. Someday it would be nice to refactor this class so that each drawing model is encapsulated in a class; this would allow WebBaseNetscapePluginView to make more efficient use of space, for example by not keeping OpenGL-related ivars for Quickdraw plug-ins.


  • Plugins/WebBaseNetscapePluginView.m:
  • Declared a bunch of internal methods for OpenGL support (see below).
  • Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES", so I just cleaned up the silly code that used it.
  • Declared OpenGL port state struct. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
  • Moved a CoreGraphics-related assertion down to the big "switch" statement.
  • Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to request that the browser use a "windowless" (offscreen) context instead.
  • Moved the assertion from the top of this method here; removed a less restrictive assertion that is now obsolete.
  • Removed "forUpdate" flag from CoreGraphics port state struct.
  • Fill in OpenGL port state struct. Set up the viewport appropriately for both windowed and windowless OpenGL plug-ins. Windowed plug-ins need to have their GL viewport transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen into a surface whose geometry is never changed or clipped, so they may always draw with a viewport origin of (0, 0). (-[WebBaseNetscapePluginView restorePortState:]):
  • Removed "forUpdate" flag from CoreGraphics port state struct.
  • Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:. (-[WebBaseNetscapePluginView sendEvent:]):
  • Updated an assertion to also include OpenGL. To ensure that attached plug-in window movements happen atomically with web page redisplays, we assert that the plug-in's window is set only while the plug-in view is redrawing.
  • Same deal as with the assertion; only save/set port state when redrawing the plug-in view. Plug-ins that use the new drawing models are only allowed to draw when the web page draws. I might consider changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
  • Compare new NP_GLContext structs. (-[WebBaseNetscapePluginView updateAndSetWindow]):
  • In OpenGL mode, can only set window when updating plug-in view. (-[WebBaseNetscapePluginView setWindowIfNecessary]):
  • ditto
  • Updated logging for OpenGL drawing mode. (-[WebBaseNetscapePluginView addWindowObservers]):
  • No need to observe frame/bounds change notifications for this and all parent views. See -renewGState comments below. (-[WebBaseNetscapePluginView removeWindowObservers]):
  • Don't need to remove frame/bounds observers anymore. (-[WebBaseNetscapePluginView start]):
  • Plug-ins are "windowed" by default. This is not a change from our previous behavior, but this is a better place to set the default value as it allows the plug-in to override it later. (-[WebBaseNetscapePluginView stop]):
  • Destroy AGL context when the plug-in stops. (-[WebBaseNetscapePluginView dealloc]):
  • Assert that the AGL stuff has been cleaned up. (-[WebBaseNetscapePluginView drawRect:]):
  • If this is a windowless OpenGL plugin, blit its contents back into this view. (-[WebBaseNetscapePluginView renewGState]):
  • This method is called when the view or one of its parents is moved or resized (see comments). (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
  • Hide the AGL window if the plug-in view is about to be removed from its window. (-[WebBaseNetscapePluginView viewHasMoved:]):
  • Renamed and moved to the "Internal" category. (-[WebBaseNetscapePluginView invalidateRegion:]):
  • Style changes.
  • Add support for OpenGL (uses the same region type as CoreGraphics). (-[WebBaseNetscapePluginView getVariable:value:]):
  • Style changes.
  • Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model. (-[WebBaseNetscapePluginView setVariable:value:]):
  • Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in "windowed" or "windowless" mode. This is an older part of the Netscape Plug-in API that was never implemented in WebKit. "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on other platforms. However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so that they have some way of specifying whether they should be rendered on an accelerated overlay surface, composited into the browser window.
  • Support for setting the drawing model to OpenGL. (-[WebBaseNetscapePluginView _viewHasMoved]):
  • Renamed from -viewHasMoved:, and moved down in the file.
  • None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly restored when it is moved back into a window.
  • Reshape OpenGL surface window here. (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
  • Creates the AGL context of the appropriate type (windowed/windowless). (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
  • Creates a windowed AGL context, which is an AGL context attached to a child window. This is the only way to get true hardware acceleration. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
  • Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer. This buffer can then be blitted back into the browser window with a different alpha, or scaled, or whatever. (-[WebBaseNetscapePluginView _cglContext]):
  • Returns the underlying CGL context from the AGL context. We give the plug-in access to the CGL context because CGL is the more primitive of the GL drawable APIs and allows for finer control over the context. (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
  • Returns the buffer allocated for the offscreen AGL context, if there is one. (-[WebBaseNetscapePluginView _destroyAGLContext]):
  • Destroys the AGL context, as well as the associated offscreen buffer or child window. (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
  • Positions the AGL window over the browser window. (-[WebBaseNetscapePluginView _hideAGLWindow]):
  • Hides the AGL window. (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
  • Returns an NSImage representation of the offscreen AGL context's framebuffer. This is used to draw the offscreen bits back into the plug-in view. This is kind of tricky because it has to convert the offscreen buffer in-place from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep. See comments.
  • WebKit.xcodeproj/project.pbxproj: Link OpenGL and AGL.
11:10 AM Changeset in webkit [15261] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

Fixed a nearly unparsable ChangeLog entry

10:52 AM Changeset in webkit [15260] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Maciej

Set the stage to remove the workaround for the SQLite BLOB corruption. A few other small cleanups, and
preparation for pruning unreferenced and unretained icons.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::recreateDatabase): Added another trigger to assist in icon removal (WebCore::IconDatabase::deletePrivateTables): Cleaned up logging messages (WebCore::IconDatabase::imageDataForIconID): #ifdefed the blobbing hack for impending removal, use the real blob by default (WebCore::IconDatabase::imageDataForIconURL): same (WebCore::IconDatabase::imageDataForPageURL): same (WebCore::IconDatabase::pruneUnreferencedIcons): Will delete any icons and their data that are not referenced by any PageURL
  • icon/IconDatabase.h:
  • icon/SQLDatabase.h: Changed BlobAsVector to be unsigned char as thats the most reasonable type for a byte-buffer, and is what CFData expects
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::getColumnBlobAsVector):
10:38 AM Changeset in webkit [15259] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Maciej

The ICONDEBUG flag no choose either/or the new icon database and the old one
No longer any need to live side by side to compare results

  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
10:03 AM Changeset in webkit [15258] by darin
  • 29 edits
    1 copy
    23 moves
    5 deletes in trunk/WebCore
  • move all but the last 12 files out of kwq directory
  • removed a few unused source files I discovered
  • WebCore.vcproj/WebCore/WebCore.vcproj: Update for new file locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bridge/mac/FrameMac.mm:
  • dom/Element.h:
  • html/HTMLImageLoader.cpp:
  • loader/Cache.cpp:
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp:
  • loader/CachedImage.h:
  • loader/CachedObject.h:
  • loader/CachedScript.cpp:
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/DeprecatedSlider.cpp:
  • rendering/RenderObject.h:
  • xml/xmlhttprequest.cpp: Updated includes as needed for file location changes. Changed CachePolicy uses to match new filename and enum names.
  • loader/CachedResource.cpp: Removed.
  • loader/CachedResource.h: Removed.
  • loader/CachedResourceClient.h: Removed.
  • loader/CachedResourceClientWalker.cpp: Removed.
  • loader/CachedResourceClientWalker.h: Removed. The above files were checked in by accident a while back. The rename of CachedObject to CachedResource is now reflected in do-webcore-rename, and will be done soon.
  • kwq/AffineTransform.cpp: Removed.
  • kwq/AffineTransform.h: Removed.
  • kwq/CacheControl.h: Removed.
  • kwq/DeprecatedPtrQueue.h: Removed.
  • kwq/FileButton.h: Removed.
  • kwq/FileButton.mm: Removed.
  • kwq/ListBox.h: Removed.
  • kwq/ListBox.mm: Removed.
  • kwq/LoaderFunctions.h: Removed.
  • kwq/LoaderFunctions.mm: Removed.
  • kwq/PopUpButton.h: Removed.
  • kwq/PopUpButton.mm: Removed.
  • kwq/SSLKeyGenerator.h: Removed.
  • kwq/SSLKeyGenerator.mm: Removed.
  • kwq/Settings.h: Removed.
  • kwq/TextBox.h: Removed.
  • kwq/TextBox.mm: Removed.
  • kwq/TextField.h: Removed.
  • kwq/TextField.mm: Removed.
  • kwq/WebCoreScrollBar.h: Removed.
  • kwq/WebCoreScrollBar.mm: Removed.
  • kwq/WebCoreSlider.h: Removed.
  • kwq/WebCoreSlider.mm: Removed.
  • loader/CachePolicy.h: Added.
  • loader/LoaderFunctions.h: Added.
  • loader/mac/LoaderFunctionsMac.mm: Added.
  • page/Settings.h: Added.
  • platform/AffineTransform.cpp: Added.
  • platform/AffineTransform.h: Added.
  • platform/DeprecatedPtrQueue.h: Added.
  • platform/FileButton.h: Added.
  • platform/ListBox.h: Added.
  • platform/PopUpButton.h: Added.
  • platform/SSLKeyGenerator.h: Added.
  • platform/ScrollBar.h: Added.
  • platform/Slider.h: Added.
  • platform/TextBox.h: Added.
  • platform/TextField.h: Added.
  • platform/cg/AffineTransformCG.cpp: Added.
  • platform/mac/FileButtonMac.mm: Added.
  • platform/mac/ListBoxMac.mm: Added.
  • platform/mac/PopUpButtonMac.mm: Added.
  • platform/mac/SSLKeyGeneratorMac.mm: Added.
  • platform/mac/ScrollBarMac.mm: Added.
  • platform/mac/ScrollBarMac.mm: Added.
  • platform/mac/SliderMac.mm: Added.
  • platform/mac/SliderMac.mm: Added.
  • platform/mac/TextBoxMac.mm: Added.
  • platform/mac/TextFieldMac.mm: Added.
9:36 AM Changeset in webkit [15257] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Next round of renaming. (Last round was done.)
8:53 AM Changeset in webkit [15256] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

  • fast/js/resources/js-test-pre.js: Change description() to work with MSIE 6.
8:42 AM Changeset in webkit [15255] by darin
  • 4 edits
    4 moves in trunk/WebCore
  • move 4 files out of kwq directory
  • make some minor project adjustments for the WebCore project
  • WebCore.xcodeproj/project.pbxproj: Link libsqlite3 the same way we do other libraries, rather than using a custom linker option. Moved the files from their old locations to the new ones. Removed "khtml" from the list of header search paths since that directory doesn't exist any more. Eliminated STYLE_LDFLAGS and just put -umbrella WebKit in OTHER_LDFLAGS in the Production configuration (was a leftover from "build styles" in Xcode 1). Changed to use EXPORTED_SYMBOLS_FILE instead of using -exported_symbols_list directly again now that Xcode has fixed the "strip twice" bug. Removed unneeded explicit SECTORDER_FLAGS = "" settings. Removed the explicit -Y,3 option now that Xcode does that by default.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed some obsolete uneeded files, many of which didn't exist any more. Moved the files from their old locations to the new ones.
  • WebCoreSources.bkl: Moved the files from their old locations to the new ones.
  • kwq/DeprecatedCString.cpp: Removed.
  • kwq/DeprecatedCString.h: Removed.
  • kwq/TextStream.cpp: Removed.
  • kwq/TextStream.h: Removed.
  • platform/DeprecatedCString.cpp: Added.
  • platform/DeprecatedCString.h: Added.
  • platform/TextStream.cpp: Added.
  • platform/TextStream.h: Added.
8:23 AM Changeset in webkit [15254] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by NOBODY (build fix).

  • Scripts/webkitdirs.pm: Restore Hyatt's original logic to make buildbot work again. Add VC++ Express check as the fallback.
8:10 AM Changeset in webkit [15253] by darin
  • 226 edits
    46 moves in trunk/WebCore

Rubber stamped by Maciej (kinda).

  • did the next pass of renaming (used do-webcore-rename script) this takes care of most of the remaining KWQ names (almost all)
  • WebCore+SVG/DOMList.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_window.cpp:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm:
  • bridge/win/FrameWin.cpp:
  • css/CSSPrimitiveValue.cpp:
  • css/CSSValueKeywords.in:
  • css/MediaQueryEvaluator.cpp:
  • css/cssparser.cpp:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • dom/CharacterData.cpp:
  • dom/CharacterData.h:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/Element.h:
  • dom/EventTargetNode.cpp:
  • dom/EventTargetNode.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • dom/Position.cpp:
  • dom/ProcessingInstruction.cpp:
  • dom/QualifiedName.cpp:
  • dom/QualifiedName.h:
  • dom/XMLTokenizer.cpp: Added.
  • dom/xml_tokenizer.cpp: Removed.
  • dom/xml_tokenizer.h: Removed.
  • editing/EditAction.h:
  • editing/HTMLInterchange.cpp:
  • editing/HTMLInterchange.h:
  • editing/Selection.h:
  • editing/SelectionController.h:
  • editing/TextAffinity.h:
  • editing/TextIterator.cpp:
  • editing/TextIterator.h:
  • editing/VisiblePosition.h:
  • editing/htmlediting.cpp:
  • editing/markup.cpp:
  • editing/markup.h:
  • editing/visible_units.cpp:
  • editing/visible_units.h:
  • html/HTMLDocument.cpp:
  • html/HTMLFontElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextFieldInnerElement.cpp:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • kcanvas/KCanvasContainer.cpp: Removed.
  • kcanvas/KCanvasContainer.h: Removed.
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderForeignObject.cpp:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGContainer.cpp: Added.
  • kcanvas/RenderSVGContainer.h: Added.
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • ksvg2/css/CSSValueKeywords.in:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGGElement.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGMatrix.cpp:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGTextElement.cpp:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGUseElement.cpp:
  • kwq/AffineTransform.cpp: Added.
  • kwq/AffineTransform.h: Added.
  • kwq/DeprecatedCString.cpp: Added.
  • kwq/DeprecatedCString.h: Added.
  • kwq/DeprecatedPtrQueue.h: Added.
  • kwq/FileButton.h: Added.
  • kwq/FileButton.mm: Added.
  • kwq/FormDataMac.mm: Added.
  • kwq/KWQCString.cpp: Removed.
  • kwq/KWQCString.h: Removed.
  • kwq/KWQComboBox.h: Removed.
  • kwq/KWQComboBox.mm: Removed.
  • kwq/KWQEditCommand.h: Removed.
  • kwq/KWQEditCommand.mm: Removed.
  • kwq/KWQFileButton.h: Removed.
  • kwq/KWQFileButton.mm: Removed.
  • kwq/KWQFormData.h: Removed.
  • kwq/KWQFormData.mm: Removed.
  • kwq/KWQKHTMLSettings.h: Removed.
  • kwq/KWQKIOGlobal.h: Removed.
  • kwq/KWQKSSLKeyGen.h: Removed.
  • kwq/KWQKSSLKeyGen.mm: Removed.
  • kwq/KWQLineEdit.h: Removed.
  • kwq/KWQLineEdit.mm: Removed.
  • kwq/KWQListBox.h: Removed.
  • kwq/KWQListBox.mm: Removed.
  • kwq/KWQLoader.h: Removed.
  • kwq/KWQLoader.mm: Removed.
  • kwq/KWQPageState.h: Removed.
  • kwq/KWQPageState.mm: Removed.
  • kwq/KWQPtrQueue.h: Removed.
  • kwq/KWQResourceLoader.h: Removed.
  • kwq/KWQResourceLoader.mm: Removed.
  • kwq/KWQScrollBar.h: Removed.
  • kwq/KWQScrollBar.mm: Removed.
  • kwq/KWQSlider.h: Removed.
  • kwq/KWQSlider.mm: Removed.
  • kwq/KWQTextEdit.h: Removed.
  • kwq/KWQTextEdit.mm: Removed.
  • kwq/KWQTextStream.cpp: Removed.
  • kwq/KWQTextStream.h: Removed.
  • kwq/KWQWMatrix.cpp: Removed.
  • kwq/KWQWMatrix.h: Removed.
  • kwq/ListBox.h: Added.
  • kwq/ListBox.mm: Added.
  • kwq/LoaderFunctions.h: Added.
  • kwq/LoaderFunctions.mm: Added.
  • kwq/PopUpButton.h: Added.
  • kwq/PopUpButton.mm: Added.
  • kwq/SSLKeyGenerator.h: Added.
  • kwq/SSLKeyGenerator.mm: Added.
  • kwq/Settings.h: Added.
  • kwq/TextBox.h: Added.
  • kwq/TextBox.mm: Added.
  • kwq/TextField.h: Added.
  • kwq/TextField.mm: Added.
  • kwq/TextStream.cpp: Added.
  • kwq/TextStream.h: Added.
  • kwq/WebCoreEditCommand.h: Added.
  • kwq/WebCoreEditCommand.mm: Added.
  • kwq/WebCorePageState.h: Added.
  • kwq/WebCorePageState.mm: Added.
  • kwq/WebCoreResourceLoaderImp.h: Added.
  • kwq/WebCoreResourceLoaderImp.mm: Added.
  • kwq/WebCoreScrollBar.h: Added.
  • kwq/WebCoreScrollBar.mm: Added.
  • kwq/WebCoreSlider.h: Added.
  • kwq/WebCoreSlider.mm: Added.
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedImage.cpp:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/CachedResource.h:
  • loader/CachedResourceClientWalker.h:
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.h:
  • loader/Decoder.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • loader/FormData.h:
  • loader/ImageDocument.cpp:
  • loader/PluginDocument.cpp:
  • loader/TextDocument.cpp:
  • loader/loader.cpp:
  • loader/loader.h:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/Page.cpp:
  • page/Page.h:
  • platform/DeprecatedPtrList.h:
  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedPtrListImpl.h:
  • platform/DeprecatedString.cpp:
  • platform/DeprecatedString.h:
  • platform/DeprecatedStringList.cpp:
  • platform/DeprecatedStringList.h:
  • platform/DeprecatedValueList.h:
  • platform/DeprecatedValueListImpl.cpp:
  • platform/DeprecatedValueListImpl.h:
  • platform/FloatSize.h:
  • platform/Font.cpp:
  • platform/KURL.cpp:
  • platform/RegularExpression.cpp:
  • platform/RegularExpression.h:
  • platform/SegmentedString.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/String.cpp:
  • platform/StringImpl.cpp:
  • platform/TextEncoding.cpp:
  • platform/TransferJob.cpp:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/CursorMac.mm:
  • platform/mac/DeprecatedStringMac.mm: Added.
  • platform/mac/FontCacheMac.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/FoundationExtras.h:
  • platform/mac/ImageMac.mm:
  • platform/mac/KURLMac.mm:
  • platform/mac/MouseEventMac.mm: Removed.
  • platform/mac/QStringListMac.mm: Removed.
  • platform/mac/QStringMac.mm: Removed.
  • platform/mac/TransferJobMac.mm:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextArea.mm:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextField.mm:
  • platform/mac/WidgetMac.mm:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/DataRef.h:
  • rendering/DeprecatedRenderSelect.cpp:
  • rendering/DeprecatedRenderSelect.h:
  • rendering/DeprecatedSlider.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderFileButton.cpp:
  • rendering/RenderFlexibleBox.cpp:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFormElement.cpp:
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderLineEdit.cpp:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderReplaced.cpp:
  • rendering/RenderStyle.cpp: Added.
  • rendering/RenderStyle.h: Added.
  • rendering/RenderTable.cpp:
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTextArea.cpp:
  • rendering/RenderTextControl.cpp: Added.
  • rendering/RenderTextControl.h: Added.
  • rendering/RenderTextField.cpp: Removed.
  • rendering/RenderTextField.h: Removed.
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/RenderView.cpp:
  • rendering/RenderWidget.cpp:
  • rendering/bidi.cpp:
  • rendering/render_style.cpp: Removed.
  • rendering/render_style.h: Removed.
  • xml/XSLStyleSheet.cpp:
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp:
  • xpath/impl/XPathParser.cpp:
7:53 AM Changeset in webkit [15252] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy Hatcher.

  • Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
5:05 AM Changeset in webkit [15251] by jdevalk
  • 2 edits in trunk/WebKitTools

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9804

In the congratulations message, "capatibilies" should be "capabilities".

4:29 AM Changeset in webkit [15250] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Tweaked bug title in last comment to be correct.

4:09 AM Changeset in webkit [15249] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8251
navigator.product incorrect in WebKit.app on Intel Macs

For navigator.platform return "MacIntel" for Intel processors, "MacPPC"
otherwise.

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
3:46 AM Changeset in webkit [15248] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Timothy Hatcher.

  • Scripts/run-webkit-tests: Speed up test list generation, implement --ignore-tests feature, and minor clean up.
12:56 AM Changeset in webkit [15247] by thatcher
  • 23 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

New tests for DOM comment nodes. Updated results to account for new
nodes in the DOM (editing offsets changed.)

  • editing/deleting/delete-line-013-expected.txt:
  • editing/deleting/delete-line-014-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-009-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/selection/extend-by-character-006-expected.txt:
  • editing/selection/move-between-blocks-no-001-expected.txt:
  • editing/selection/move-between-blocks-yes-001-expected.txt:
  • fast/dom/HTMLDocument/object-by-name-or-id-expected.txt:
  • fast/dom/HTMLDocument/object-by-name-or-id.html:
  • fast/dom/comment-document-fragment-expected.txt: Added.
  • fast/dom/comment-document-fragment.html: Added.
  • fast/dom/comment-dom-node-expected.txt: Added.
  • fast/dom/comment-dom-node.html: Added.
  • fast/dom/comment-not-documentElement-expected.checksum: Added.
  • fast/dom/comment-not-documentElement-expected.png: Added.
  • fast/dom/comment-not-documentElement-expected.txt: Added.
  • fast/dom/comment-not-documentElement.html: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt:
  • fast/text/atsui-rtl-override-selection-expected.txt:

WebCore:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

<rdar://problem/4564414> getting comments via DOM isn't working (5312)
<rdar://problem/4545691> DOM_COMMENT node masking out real DOM elements

  • dom/Document.cpp: (WebCore::Document::removedLastRef): set m_documentElement to 0 (WebCore::Document::childrenChanged): invalidate the document element we have cached in case it was replaced (WebCore::Document::documentElement): cache the first element as the document node if m_documentElement is 0
  • dom/Document.h: added m_documentElement
  • html/HTMLDocument.cpp: removed documentElement(), HTML documents just use Document's documentElement()
  • html/HTMLDocument.h: ditto
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): make a new HTML node is the document's firstChild is NULL or the firstChild is not a HTML element (like a comment)
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): removed the #ifdef to include comment nodes

WebKit:

Reviewed by Maciej.

Bug 5312: comments aren't available via DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5312

Makes the Web Inspector show comment node contents.

  • WebInspector/WebInspector.m: (-[DOMNode _displayName]): return the contents of the comment
  • WebInspector/webInspector/inspector.js: check for comment nodes
12:04 AM Changeset in webkit [15246] by ap
  • 3 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header to main resource requests.
  • English.lproj/StringsNotToBeLocalized.txt: Added new strings.
Note: See TracTimeline for information about the timeline view.