Timeline


and

07/18/06:

22:38 Changeset [15521] by thatcher

Adding versioning and markers from earlier.

21:39 Changeset [15520] by thatcher

Fix hard wrap issue that I forogt to check in before submitting.

21:37 Changeset [15519] by thatcher

New tag (part 2)

21:36 Changeset [15518] by thatcher

new tag.

21:05 Changeset [15517] by hyatt

Remove the font property compatibility test, since we no longer want to be compatible.

19:44 Changeset [15516] by ddkilzer

WebKitTools:

Reviewed by Timothy.

  • Scripts/prepare-ChangeLog: Added --[no-]update switch.
17:32 Changeset [15515] by hyatt

Tweak a comment in cssparser.

17:16 Changeset [15514] by hyatt

Fix for radar 4611287, make resizable text fields opt-in rather than
opt-out. Open source users will need to write the pref into their defaults
to see the resizers on textareas now.

Reviewed by mjs and adele

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setTextAreasAreResizable:]):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/html4.css:
16:03 Changeset [15513] by thatcher

Merging important fixes.

15:56 Changeset [15512] by tomernic

Reviewed by Tim Hatcher.

Removed a misleading comment; we recently added support for the NPNVPluginElementNPObject
variable.

  • bindings/npapi.h:
15:09 Changeset [15511] by thatcher

Merged urgent fixes to a new tag.

13:43 Changeset [15510] by brmorris

2006-07-18 Bradley <bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 4 of 4.

13:38 Changeset [15509] by brmorris

2006-07-17 Bradley <bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 3 of 4.

13:31 Changeset [15508] by brmorris

2006-07-17 Bradley <bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.


Various fixes - see ChangeLogs for details.
Part 2 of 4.

13:22 Changeset [15507] by brmorris

2006-07-17 Bradley <bradley.morrison@nokia.com>

Reviewed by Sachin/Zalan.

Various fixes - see ChangeLogs for details.
Part 1 of 4.

13:22 Changeset [15506] by andersca

WebCore:

2006-07-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads


  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::close):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::willRemove): Remove calls to incrementFrameCount and decrementFrameCount.


  • page/Frame.cpp: (WebCore::Frame::Frame): Call incrementFrameCount here.


(WebCore::Frame::~Frame):
Call disconnectOwnerElement.


(WebCore::Frame::disconnectOwnerElement):
Call decrementFrameCount here.


LayoutTests:

2006-07-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9959
REGRESSION: iframes stop rendering after 200th one on successive reloads

  • fast/frames/frame-limit-expected.txt: Added.
  • fast/frames/frame-limit.html: Added.
12:56 Changeset [15505] by ap

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9013
Let correct CSS custom cursor declarations parse

  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ignore any values following a custom CSS cursor URI, instead of requiring that it is the only one in the list (which is actually illegal, according to the spec). This is only a temporary hack, with a real implementation to follow in bug 6001/6002.
  • manual-tests/custom-cursors.html: Added a test for this issue.
  • manual-tests/resources/helpCursor.tiff: A cursor image used in the test.
12:28 Changeset [15504] by thatcher

Reviewed by Anders.


<rdar://problem/4636216> NetNewsWire fails to launch on 9A224 - missing symbols


WebCore needs to add -sub_library libobjc to maintain
backwards compatibility with binaries linked with WebKit
before JavaScriptCore moved out of WebKit.

  • WebCore.xcodeproj/project.pbxproj:
10:56 Changeset [15503] by thatcher

New tag.

10:03 Changeset [15502] by darin

Reviewed by Alice.

  • convert a couple of tests to "dump as text" tests
  • fast/dom/css-selectorText-expected.checksum: Removed.
  • fast/dom/css-selectorText-expected.png: Removed.
  • fast/dom/css-selectorText-expected.txt: Replaced render tree results with text results.
  • fast/dom/css-selectorText.html: Added a call to layoutTestController.dumpAsText.
  • fast/dom/css-shortHands-expected.checksum: Removed.
  • fast/dom/css-shortHands-expected.png: Removed.
  • fast/dom/css-shortHands-expected.txt: Replaced render tree results with text results.
  • fast/dom/css-shortHands.html: Added a call to layoutTestController.dumpAsText.
09:01 Changeset [15501] by thatcher

Made the following headers public:

  • JavaScriptCore.h
  • JSBase.h
  • JSContextRef.h
  • JSObjectRef.h
  • JSStringRef.h
  • JSValueRef.h
03:55 Changeset [15500] by ddkilzer

LayoutTests:

Reviewed by Justin. Patch by Mitz.

  • editing/selection/click-start-of-line-expected.checksum: Added.
  • editing/selection/click-start-of-line-expected.png: Added.
  • editing/selection/click-start-of-line-expected.txt: Added.
  • editing/selection/click-start-of-line.html: Added.

WebCore:

Reviewed by Justin. Patch by Mitz.

Test: editing/selection/click-start-of-line.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): Changed to return downstream affinity if the x coordinate is to the left of the middle of the first character in the text box.
02:24 Changeset [15499] by andersca

WebCore:

2006-07-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)


  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): If the caret is inside an editable region, the beginning/end of the document should actually be the beginning/end of the editable region.

LayoutTests:

2006-07-18 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9695
<rdar://problem/4614085>
TOT REGRESSION: NativeTextArea: Text area does not respond to Cmd-UpArrow/Cmd-DownArrow (9695)


  • editing/selection/move-begin-end-expected.txt: Added.
  • editing/selection/move-begin-end.html: Added.

07/17/06:

21:55 Changeset [15498] by tomernic

WebCore:

Reviewed by Maciej.

<rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
by script

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setProhibitsScrolling:]):
  • page/Frame.cpp: (WebCore::Frame::prohibitsScrolling): (WebCore::Frame::setProhibitsScrolling):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • page/FrameView.cpp: (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos):
  • page/FrameView.h:
  • platform/ScrollView.h:

WebKit:

Reviewed by Maciej.

<rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
by script

  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView setProhibitsMainFrameScrolling:]): New method. Prohibits scrolling in the WebView's main frame. Used to "lock" a WebView to a specific scroll position.
21:33 Changeset [15497] by ggaren

Reviewed by Maciej.


  • Added automatic prototype creation for classes.


A class stores a weak reference to a prototype, which is cleared when
the prototype is garbage collected, to avoid a reference cycle.


We now have an attributes field in JSClassDefinition, that currently is
used only to override automatic prototype creation when you want to manage your
own prototypes, but can be extended in the future for other nefarious purposes.


Similarly, we have JSObjectMake and JSObjectMakeWithPrototype, the latter
allowing you to manage your own prototypes.


JSObjectMakeConstructor is more interesting now, able to make a constructor
on your behalf if you just give it a class.


  • Removed bogus old code from minidom.js.


  • Tweaked the headerdocs.


  • Added more GC testing, which caught some leaks, and tested more funny edge cases in lookup, which caught a lookup bug. Removed some testing we used to do with MyObject because it was redundant with the new, cool stuff.


While fixing the lookup bug I retracted this change:


"If a static setProperty callback returns 'false', to indicate that the
property was not set, we no longer forward the set request up the class
chain, because that's almost certainly not what the programmer expected."

Returning false when setting a static property is a little silly, but you can see
it being useful when shadowing a base class's static properties, and, regardless
of usefullness, this is the defined behavior of the setProperty callback.


  • Plus a little ASCII art, for the kids.
21:32 Changeset [15496] by mjs

LayoutTests:

Test cases not reviewed but the corresponding fix was.


  • editing/pasteboard/nested-blocks-with-text-area-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-area.html: Added.
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt: Added.
  • editing/pasteboard/nested-blocks-with-text-field.html: Added.

WebCore:

Reviewed by Dave Harrison.


  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent):
18:18 Changeset [15495] by justing

Reviewed by levi


<rdar://problem/4621728>
REGRESSION: Selecting by dragging down creates selection in wrong direction, with certain steps
<rdar://problem/4604932>
REGRESSION: Dragging too far left on a line will select all lines above it.


No layout test because of 9980.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Don't return positions inside editable roots for coordinates outside those roots, except for coordinates outside a document that is entirely editable.
17:55 Changeset [15494] by thatcher

Reviewed by Darin.


<rdar://problem/4635311> REGRESSION: WebKit should call windowScriptObjectAvailable before attaching the script debugger

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
17:48 Changeset [15493] by thatcher

Reviewed by Darin.

<rdar://problem/4635281> JSCanvasRenderingContext2D::drawImage needs to initialize the exception code to zero

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): initialize ec to zero
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): initialize ec before earlier return
17:27 Changeset [15492] by thatcher

JavaScriptCore:

Reviewed by Maciej.

<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit

Moves WebScriptObject and WebUndefined up to WebCore.
This change does create an upwards-dependancy on WebScriptObject existing
in the loaded process, but this code path in JavaScriptCore does not get used
unless it is through WebKit/WebCore. Moving all of the binding code out of
JavaScriptCore might make sense in the future.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.h: Replaced.
  • bindings/objc/WebScriptObject.mm: Removed.
  • bindings/objc/WebScriptObjectPrivate.h: Removed.
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::~ObjcInstance):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::createObjcInstanceForValue):

WebCore:

Reviewed by Maciej.

<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit

Moves WebScriptObject and WebUndefined to WebCore.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/WebScriptObject.mm: Added. (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
  • bindings/objc/WebScriptObjectPrivate.h: Added.
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreScriptDebugger.mm:

WebKit:

Reviewed by Maciej.

<rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit

Copy WebScriptObject.h from WebCore's private headers, not JavaScriptCore.

  • WebKit.xcodeproj/project.pbxproj:
15:29 Changeset [15491] by andersca

2006-07-17 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Add Apache 2 config file.


  • http/conf/apache2-httpd.conf: Added.
15:18 Changeset [15490] by hyatt

Back out the fix for 5564, since it turns out font:x-small; is a pretty
prominent IE-specific CSS hack. Because Web sites rely on IE's incorrect
font parsing as a means of also correcting IE's incorrect font size rules.

This fixes Yahoo.com.

Reviewed by darin

  • css/cssparser.cpp: (WebCore::CSSParser::parseFont):
15:05 Changeset [15489] by sullivan

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4604366> Orange Find highlight displays text in wrong size on PDF pages if they're not at "actual size"


To match WebHTMLView, I made the methods that return attributed strings take the view's scale
factor into account.

  • WebView/WebPDFView.m: (-[WebPDFView _scaledAttributedString:]): new helper method, takes an attributed string and returns one that's scaled by the view's current scale factor (-[WebPDFView attributedString]): pass result through _scaledAttributedString: (-[WebPDFView selectedAttributedString]): ditto
14:54 Changeset [15488] by justing

LayoutTests:

Reviewed by levi


<rdar://problem/4618389> REGRESSION: After applying a link to the last word of a sentence, a new selection is created at the start of the sentence

  • editing/selection/replace-selection-1-expected.checksum: Added.
  • editing/selection/replace-selection-1-expected.png: Added.
  • editing/selection/replace-selection-1-expected.txt: Added.
  • editing/selection/replace-selection-1.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4618389> REGRESSION: After applying a link to the last word of a sentence, a new selection is created at the start of the sentence


  • dom/Document.cpp: (WebCore::Document::updateSelection):
12:38 Changeset [15487] by justing

LayoutTests:

Reviewed by levi

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.txt:

WebKit:

Reviewed by levi


Rolled the first fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection
back in and removed the call to _clearSelectionInOtherFrames from
-[WebHTMLView becomeFirstResponder] to fix the bug.

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): (-[NSArray becomeFirstResponder]):
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]):
08:19 Changeset [15486] by darin
  • API/JSBase.h: Fix comment formatting where things used to be lined up but are now ragged. Got rid of spaces that attempted to line things up.
  • API/JSObjectRef.h: Ditto. Also add missing periods for a couple of comments.
04:50 Changeset [15485] by mjs

LayoutTests:

Reviewed by Beth.


<rdar://problem/4604946> REGRESSION: 'checkboxRef.checked = true' fires onchange event in Leopard

  • fast/events/programmatic-check-no-change-event-expected.txt: Added.
  • fast/events/programmatic-check-no-change-event.html: Added.

WebCore:

Reviewed by Beth.


<rdar://problem/4604946> REGRESSION: 'checkboxRef.checked = true' fires onchange event in Leopard

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler):
  • html/HTMLInputElement.h:
03:49 Changeset [15484] by ggaren

Reviewed by Maciej.


  • Removed the exception parameter from the initialize callback and, by extension, JSObjectMake. We have never had a need for exceptions when iniitializing, so the parameter seemed likely to "get in the way."


Also, an exception in JavaScript is thrown in response to input --
"invalid URL", "index not a number", etc., so it's the job of the
constructor function, not the initialize method, to throw.


If initialize *really* wants to throw, it can communicate the throw to
the constructor through the constructed object's private data (e.g., set
it to NULL, signaling to the consntructor that initialization failed.)


  • Added JSObjectMakeWithData, which enables a constructor to set private data on an object *before* it has been initialized. That way, the initialize methods can properly operate on the data.
  • API/JSNode.c: Moved ref into the initialize method, for better encapsulation, now that it's possible.
  • API/JSNodeList.c: ditto
  • API/minidom.c: (main): Do more aggressive garbage collection to test ref/deref and initialize/finalize.
  • API/minidom.js: store childNodes in a temporary so it doesn't get re-created like a thousand times. This makes debugging ref/deref easier
02:06 Changeset [15483] by ggaren

Reviewed by Maciej.


  • Changed the initialize callback to run from least derived class (parent class) to most derived class. This enables C++ style initialization, and derived class overriding of member data.


  • Added excpetion propopgation to JSObjectMake, to support initialize exceptions, and generally round out our policy of making function signatures as long as possible.
  • API/JSCallbackObject.h: Use ExecState instead of ContextRef, cuz we're in C++ land now.
01:20 Changeset [15482] by ggaren

Reviewed by Maciej.


  • Changed JSObjectMakeConstructor to JSObjectMakeConstructorWithCallback, to match JSObjectMakeFunctionWithCallback.


  • Added prototype parameter, so the generated constructor automatically works with hasInstance / instanceof


  • Moved hasInstance implementation from InternalFunctionImp to JSObject so that subclasses can inherit it without inheriting function-related baggage. More refactoring here would be good, but this seems like a good short-term solution.

(KJS::JSCallbackFunction::implementsHasInstance): override and return false,
because callback functions aren't constructors.

01:14 Changeset [15481] by mjs

Reviewed by Geoff.


  • add a JSContextRef parameter to all JSValueRef, JSObjectRef, and JSContextRef operations; except JSObject{Get,Set}PrivateData which can be assumed to be simple pure accessors.


Also renamed the parameter "context" to "ctx" because it makes the code read better with this pervasive
but usually uninteresting parameter.

  • API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax): (JSGarbageCollect):
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::toNumber): (KJS::JSCallbackObject::toString):
  • API/JSContextRef.cpp: (JSGlobalContextCreate): (JSGlobalContextRetain): (JSGlobalContextRelease): (JSContextGetGlobalObject):
  • API/JSContextRef.h:
  • API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild): (JSNode_getNodeType): (JSNode_getFirstChild): (JSNode_prototype):
  • API/JSNodeList.c: (JSNodeListPrototype_item): (JSNodeList_length): (JSNodeList_getProperty): (JSNodeList_prototype):
  • API/JSObjectRef.cpp: (JSObjectMake): (JSObjectMakeFunctionWithCallback): (JSObjectMakeConstructor): (JSObjectMakeFunction): (JSObjectGetPrototype): (JSObjectSetPrototype): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex): (JSObjectDeleteProperty): (JSObjectIsFunction): (JSObjectCallAsFunction): (JSObjectIsConstructor): (JSObjectCallAsConstructor): (JSObjectCopyPropertyNames):
  • API/JSObjectRef.h:
  • API/JSStringRef.cpp:
  • API/JSValueRef.cpp: (JSValueGetType): (JSValueIsUndefined): (JSValueIsNull): (JSValueIsBoolean): (JSValueIsNumber): (JSValueIsString): (JSValueIsObject): (JSValueIsObjectOfClass): (JSValueIsEqual): (JSValueIsStrictEqual): (JSValueIsInstanceOfConstructor): (JSValueMakeUndefined): (JSValueMakeNull): (JSValueMakeBoolean): (JSValueMakeNumber): (JSValueMakeString): (JSValueToBoolean): (JSValueToNumber): (JSValueToStringCopy): (JSValueToObject): (JSValueProtect): (JSValueUnprotect):
  • API/JSValueRef.h:
  • API/minidom.c: (print):
  • API/testapi.c: (MyObject_getProperty): (MyObject_deleteProperty): (MyObject_callAsFunction): (MyObject_callAsConstructor): (MyObject_convertToType): (print_callAsFunction): (main):

07/16/06:

21:41 Changeset [15480] by ggaren

Approved by Maciej, RS by Beth.


JSObjectMakeFunction -> JSObjectMakeFunctionWithCallback
JSObjectMakeFunctionWithBody -> JSObjectMakeFunction


because the latter is more common, and more fundamental, than the former.

  • API/APICast.h: (toJS):
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::getPropertyNames): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): (OpaqueJSClass::~OpaqueJSClass):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMakeFunctionWithCallback): (JSObjectMakeFunction): (OpaqueJSPropertyNameArray::OpaqueJSPropertyNameArray): (JSObjectCopyPropertyNames):
  • API/JSObjectRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
  • ChangeLog:
  • JavaScriptCore.exp:
21:21 Changeset [15479] by ddkilzer

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-dir-property-expected.txt: Added.
  • fast/dom/document-dir-property.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-dir-property.html

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return an empty string instead of an undefined value for an unset document.dir property.
21:15 Changeset [15478] by ddkilzer

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/move-node-with-selection-expected.checksum: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.

WebCore:

Reviewed by Darin.

  • dom/NodeFilter.idl: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
  • manual-tests/input-empty-on-focus.html: Removed "Property changes" that snuck in as part of the "apply patch" process.

WebKitTools:

Reviewed by Darin.

  • BuildSlaveSupport/build.webkit.org-config/buildbot.css: Removed "No newline at end of file" that snuck in as part of the "apply patch" process.
  • GdkLauncher/mk: Removed "Property changes" that snuck in as part of the "apply patch" process.
20:59 Changeset [15477] by ddkilzer

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: (addDirectoriesIfNeeded): Don't try to add a directory that's already in svn. (checksum): Added. (patch): Use patch(1) for non-binary additions and deletions.
  • Scripts/svn-unapply: (checksum): Added. (patch): Use patch(1) for reverting non-binary additions and deletions. (revertDirectories): Don't try to revert a directory that hasn't changed in svn.
20:59 Changeset [15476] by darin
  • try to fix Windows build
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Added some recently added files, removed some recently removed.
19:51 Changeset [15475] by darin
  • fixed a couple of files I checked in wrong
  • fast/html/body-offset-properties-expected.txt: Removed property cruft.
  • fast/html/body-offset-properties.html: Ditto.
19:00 Changeset [15474] by ggaren

Reviewed by Maciej.


  • Change getProperty* to return undefined, rather than NULL, for missing properties, since that's what the spec says. Also added exception out parameters to the *Index functions, because they can call through to the regular functions, which can throw for custom objects.
  • API/JSObjectRef.cpp: (JSObjectGetProperty): (JSObjectGetPropertyAtIndex): (JSObjectSetPropertyAtIndex):
  • API/JSObjectRef.h:
  • API/testapi.c: (main):
18:48 Changeset [15473] by ggaren

Reviewed by Maciej.


  • Properly document and handle NULL callbacks for static properties. We throw an exception in any case other than a ReadOnly property with a NULL setProperty callback, because a NULL callback almost certainly indicates a programming error. Also throw an exception if hasProperty returns true for a property that getProperty can't get.


  • If a static setProperty callback returns 'false', to indicate that the property was not set, we no longer forward the set request up the class chain, because that's almost certainly not what the programmer expected.
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::staticFunctionGetter): (KJS::JSCallbackObject::callbackGetter):
  • API/JSObjectRef.h:
  • API/minidom.js:
  • API/testapi.c: (MyObject_hasProperty):
  • API/testapi.js:
18:47 Changeset [15472] by mjs
  • fixed typo in expected results
  • fast/js/for-in-avoid-duplicates-expected.txt:
17:37 Changeset [15471] by darin

LayoutTests:

Reviewed by John Sullivan (new test, not the changes to existing ones).

  • fast/html/body-offset-properties-expected.txt: Added.
  • fast/html/body-offset-properties.html: Added.
  • editing/execCommand/findString-2.html: Update to not depend on the buggy body.offseLeft/Top. Instead hardcode the default body margin of 8.
  • editing/pasteboard/drop-text-without-selection.html: Ditto.
  • editing/selection/click-before-and-after-table.html: Ditto.
  • editing/selection/mixed-editability-1.html: Ditto.
  • fast/table/click-near-anonymous-table.html: Ditto.
  • editing/selection/drag-to-contenteditable-iframe.html: Remove unnecessary use of body.offsetLeft/Top that are always 0.

WebCore:

Reviewed by John Sullivan.

The problem turns out to be the fact that body.offsetLeft is returning a non-zero value.
I have no idea why the menus worked in Tiger Safari, because body.offsetLeft behavior has not changed.
Presumably some other bug that we fixed had been compensating.

Test: fast/html/body-offset-properties.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): Always return 0 for any object without an offsetParent. (WebCore::RenderObject::offsetTop): Ditto. (WebCore::RenderObject::offsetParent): Return 0 for the body (treat as a special case).
17:25 Changeset [15470] by bdakin

Reviewed by Maciej.

Fix for <rdar://problem/4616595> REGRESSION: Problems with world
clock widget clock hand motion on 9A211 + 4604574

The second hand on the widget was jiggling because the rotation was
messing up the use of the affine transformation matrix while
rounding to pixel boundaries in device space. We are mainly
concerned with rounding to pixel boundaries with the scale in mind,
so this patch extracts the scale to device space from the matrix,
and rounds to pixel boundaries using only the scale. This doesn't
seem like it is a perfect solution, but it definitely solves the
immediate problem. We will probably need to re-address what should
happen to avoid pixel cracks with rotations at non-integral scale
factors.

  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels):
15:17 Changeset [15469] by ggaren

Reviewed by Maciej.


  • Added names to functions.


  • Removed GetPrivate/SetPrivate from callbackFunctions and callbackConstructors. The private data idiom is that a JS object stores its native implementation as private data. For functions and constructors, the native implementation is nothing more than the callback they already store, so supporting private data, too, confuses the idiom. If you *really* want, you can still create a custom function with private data.
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackConstructor.h:
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::JSCallbackFunction):
  • API/JSCallbackFunction.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::staticFunctionGetter):
  • API/JSObjectRef.cpp: (JSObjectMakeFunction): (JSObjectMakeFunctionWithBody): (JSObjectGetPrivate): (JSObjectSetPrivate):
  • API/JSObjectRef.h:
  • API/minidom.c: (main):
  • API/testapi.c: (main):
14:06 Changeset [15468] by mjs

JavaScriptCore:

Reviewed by Darin.


  • switch property lists to be vector+set of Identifiers instead of list of References


This has the following benefits:


  • no duplicates in property lists
  • simplifies API calls
  • probably more efficient, since linked list is gone
  • entirely removed Reference, ReferenceList and ProtectedReference types from the API
  • kjs/PropertyNameArray.cpp: Added. (KJS::PropertyNameArray::add): Check set, if not already there, add to vector.
  • kjs/PropertyNameArray.h: Added. (KJS::PropertyNameArray::PropertyNameArray): Newly added type, combines a set and a vector to make a unique but ordered list of identifiers. (KJS::PropertyNameArray::begin): ditto (KJS::PropertyNameArray::end): ditto (KJS::PropertyNameArray::size): ditto (KJS::PropertyNameArray::operator[]): ditto
  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstance::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray (ArrayInstance::setLength): updated for PropertyNameArray (ArrayInstance::pushUndefinedObjectsToEnd): ditto
  • kjs/nodes.cpp: (ForInNode::execute): updated for PropertyNameArray
  • kjs/nodes.h:
  • kjs/object.cpp: (KJS::JSObject::getPropertyNames): renamed from getPropertyList, updated for PropertyNameArray
  • kjs/object.h:
  • kjs/property_map.cpp: (KJS::PropertyMap::getEnumerablePropertyNames): updated for PropertyNameArray (KJS::PropertyMap::getSparseArrayPropertyNames): ditto
  • kjs/property_map.h:
  • kjs/protected_reference.h: Removed.
  • kjs/reference.cpp: Removed.
  • kjs/reference.h: Removed.
  • kjs/reference_list.cpp: Removed.
  • kjs/reference_list.h: Removed.
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print): Use PropertyNamesArray instead of ReferenceList.
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Updated for new approach.
  • kjs/string_object.h:
  • kjs/ustring.h:
  • API/APICast.h: (toJS): Added overload for PropertyNameAccumulatorRef / PropertyNameArray* (toRef): ditto
  • API/JSBase.h:
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getPropertyNames): Fixed for new API.
  • API/JSCallbackObject.h:
  • API/JSObjectRef.cpp: (JSPropertyNameArray::JSPropertyNameArray): Type used for a publicly vended JSPropertyNameArrayRef. (JSObjectCopyPropertyNames): New API call - renamed / refactored from JSObjectCreatePropertyList (JSPropertyNameArrayRetain): new retain call for JSPropertyNameArray. (JSPropertyNameArrayRelease): new release call for - " -. (JSPropertyNameArrayGetCount): Instead of having to use a stateful enumerator you can now get the count and items in any order. (JSPropertyNameArrayGetNameAtIndex): See above. (JSPropertyNameAccumulatorAddName): What you add properties to is now an opaque accumulator object.
  • API/JSObjectRef.h: Prototyped new functions, removed old ones
  • JavaScriptCore.exp: Updated exported symbols.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files, removed old.
  • API/testapi.c: (MyObject_getPropertyNames): Renamed / fixed callback to fit new paradigm. (main): Updated for new API.

JavaScriptGlue:

Reviewed by Darin.

  • switch property lists to be vector+set of Identifiers instead of list of References


  • JSUtils.cpp: (KJSValueToCFTypeInternal): updated for JSC SPI changes
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames): ditto
  • UserObjectImp.cpp: (UserObjectImp::getPropertyNames): ditto
  • UserObjectImp.h:

LayoutTests:

Reviewed by Darin.


  • new test case and updated results for property list changes
  • fast/js/for-in-avoid-duplicates-expected.txt: Added.
  • fast/js/for-in-avoid-duplicates.html: Added.
  • fast/js/kde/Array-expected.txt:
  • fast/js/resources/for-in-avoid-duplicates.js: Added.

07/15/06:

22:45 Changeset [15467] by thatcher

JavaScriptGlue has no need to look for frameworks in WebKit's umbrella framework path anymore.

22:22 Changeset [15466] by thatcher

WebCore has no need to look for frameworks in WebKit's umbrella framework path anymore.

19:26 Changeset [15465] by darin
  • oops, missed a few more arrays that had to be const
  • API/JSNode.c: (JSNodePrototype_appendChild): Added const. (JSNodePrototype_removeChild): Ditto. (JSNodePrototype_replaceChild): Ditto. (JSNode_construct): Ditto.
  • API/JSNodeList.c: (JSNodeListPrototype_item): Ditto.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto.
  • API/minidom.c: (print): Ditto.
  • API/testapi.c: (MyObject_callAsFunction): Ditto. (MyObject_callAsConstructor): Ditto. (print_callAsFunction): Ditto. (myConstructor_callAsConstructor): Ditto.
19:18 Changeset [15464] by darin

Reviewed by Maciej.

  • API/JSNode.h: Made an array parameter const.
  • API/JSObjectRef.h: Made array parameters const. Fixed a comment.
18:40 Changeset [15463] by ggaren

Reviewed by Maciej.


  • JSObjectMakeFunctionWithBody includes a function name and named parameters now.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody):
  • API/JSObjectRef.h:
  • API/testapi.c: (assertEqualsAsUTF8String): More informative failure reporting. (main): Test more function cases.
18:28 Changeset [15462] by ggaren

Reviewed by Maciej.

  • Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.


  • Added support for class names.


  • kJSClassDefinitionNull replaces kJSObjectCallbacksNone.


  • JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.


  • Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h


  • Also added some more informative explanation to the class structure doc.
14:03 Changeset [15461] by darin
  • fix mistake from fix for 8952 that was breaking layout tests
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Justin was right! I changed the behavior of the function by accident. Changed it back so that it doesn't blow away the selection on the DOM side in the case where it didn't before.

I will write 100 times on the blackboard: "When Justin says something about editing,
assume he is right."

13:00 Changeset [15460] by darin
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added StreamingTextDecoderICU.cpp/h.
12:41 Changeset [15459] by darin

LayoutTests:

Reviewed by John Sullivan.

  • fast/dynamic/move-node-with-selection-expected.checksum: Added.
  • fast/dynamic/move-node-with-selection-expected.png: Added.
  • fast/dynamic/move-node-with-selection-expected.txt: Added.
  • fast/dynamic/move-node-with-selection.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/dynamic/move-node-with-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Call updateRendering before calling clearSelection(), since it's important to do any work beforehand, and there are calls inside clearSelection that will indirectly do an updateRendering. Also change code to make fewer assumptions about object lifetime.
12:27 Changeset [15458] by darin

LayoutTests:

Reviewed by John Sullivan.

  • fast/lists/numeric-markers-outside-list-expected.checksum: Added.
  • fast/lists/numeric-markers-outside-list-expected.png: Added.
  • fast/lists/numeric-markers-outside-list-expected.txt: Added.
  • fast/lists/numeric-markers-outside-list.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/lists/numeric-markers-outside-list.html

  • rendering/RenderListItem.cpp: (WebCore::previousListItem): Look for list items, even when we're outside any list.
10:22 Changeset [15457] by adele

Reviewed by John.

  • Fix for <rdar://problem/4593970> REGRESSION (NativeTextField): autofill menu disappears after typing a 2nd character

This was caused by composite editing commands, (like typing or pasting) that include a DeleteCommand, being
interpreted by the form delegate as an actual delete. This fix doesn't notify the form delegate if the deletion is
part of an editing command to replace the selected text.

  • editing/DeleteSelectionCommand.h: Added m_replace to keep track of whether this deletion is part of a composite command to replace the text being deleted.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_replace. (WebCore::DeleteSelectionCommand::doApply): Only notify the form delegate of the deletion if the text is not being replaced.
  • editing/CompositeEditCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Added replace argument to construct DeleteSelectionCommand.


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call deleteSelection with replace argument.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): ditto.
09:31 Changeset [15456] by ggaren

LayoutTests:

Reviewed by Maciej.


Layout test for crash when setting the dir property on a document with no body.

  • fast/dom/dir-no-body-expected.txt: Added.
  • fast/dom/dir-no-body.html: Added.

WebCore:

Reviewed by Maciej, tweaked to match Darin's patch.


  • Fixed <rdar://problem/4631837> REGRESSION: Reproducible crash on FCKeditor demo (9911)


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Check for a null body element before forwarding the put request to it. I confirmed that no other parts of the file use 'body' or 'bodyElement' without checking for null.


Also, use 'body' rather than 'bodyElement' because dir can bet set on
any element, not just HTMLBodyElement.

08:30 Changeset [15455] by darin

JavaScriptCore:

Reviewed by Geoff.

Test: fast/js/regexp-extended-characters-more.html

  • pcre/pcre_exec.c: (match): Got rid of utf16Length local variable to guarantee there's no extra stack usage in recursive calls. Fixed two places in the PCRE_UTF16 code that were using the length variable, which is the UTF-8 length of a character in the pattern, to move in the UTF-16 subject string. Instead they hardcode lengths of 1 and 2 since the code already handles BMP characters and surrogate pairs separately. Also fixed some DPRINTF so I could compile with DEBUG on. (pcre_exec): Changed a place that was checking for multibyte characters in the subject string to use ISMIDCHAR. Instead it was using hardcoded logic that was right for UTF-8 but wrong for UTF-16.
  • pcre/pcre_compile.c: (pcre_compile2): Fixed a DPRINTF so I could compile with DEBUG on.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-extended-characters-more-expected.txt: Added.
  • fast/js/regexp-extended-characters-more.html: Added.
  • fast/js/resources/regexp-extended-characters-more.js: Added.
08:21 Changeset [15454] by darin

LayoutTests:

Reviewed by Adele.

  • fast/forms/input-text-enter-expected.txt: Added.
  • fast/forms/input-text-enter.html: Added.

WebCore:

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Add a null check to fix the crash, and a FIXME explaining why this is not necessarily enough for the future.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Consume Enter key keypress events even if the element is not in a form.
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): Added \n to the characters that turn into "Enter". Actual keyboard events always are \r or \003 on the Macintosh, but in layout tests we can use \n, and everything other than the code path here works, so worth fixing.
08:14 Changeset [15453] by darin

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/select-selected-expected.checksum: Added.
  • fast/forms/select-selected-expected.png: Added.
  • fast/forms/select-selected-expected.txt: Added.
  • fast/forms/select-selected.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/select-selected.html

  • rendering/RenderMenuList.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Added code to map the selected option index to a list index before using it to index into the list. (WebCore::RenderMenuList::showPopup): Added code to map the selection option index to a list index before passing it to the menu renderer. (WebCore::RenderMenuList::valueChanged): Added code to map the list index back to a option index before calling setSelectedIndex (that function takes an option index).
08:09 Changeset [15452] by darin

WebCore:

Reviewed by John Sullivan.

  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): Moved into DOMEventTarget category. (-[DOMNode removeEventListener:::]): Ditto. (-[DOMNode dispatchEvent:]): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Allow Xcode to do its thing.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category. (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category. (-[WebHTMLView selectionView]): Ditto. (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto. (-[WebHTMLView selectionImageRect]): Ditto. (-[WebHTMLView pasteboardTypesForSelection]): Ditto. (-[WebHTMLView selectAll]): Ditto. (-[WebHTMLView deselectAll]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto. (-[WebHTMLView attributedString]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView selectedAttributedString]): Ditto. (-[WebHTMLView supportsTextEncoding]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols. (-[WebHTMLView _isMoveDrag]): Ditto. (-[WebHTMLView _isNSColorDrag:]): Ditto. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView elementAtPoint:]): Ditto. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
02:36 Changeset [15451] by mjs

Reviewed by Anders.

<rdar://problem/4632144> REGRESSION: table column tests failing as a result of very recent fix

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): columns and colgroups are valid children of a table too, not just table sections!
02:04 Changeset [15450] by andersca

WebCore:

2006-07-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Add null check for contentFrame() since content frames won't be created for invalid URLs.

LayoutTests:

2006-07-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.

  • http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
  • http/tests/misc/iframe-invalid-source-crash.html: Added.

07/14/06:

23:53 Changeset [15449] by ap

Reviewed by Darin.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4195
REGRESSION: KOI8-U encoding no longer supported.

Tests:

  • http/tests/misc/BOM-override.pl
  • http/tests/misc/BOM-override-script.html
  • fast/encoding/charset-koi8-u.html
  • fast/encoding/charset-x-nextstep.html

Restored a TEC code path for encodings that are not supported by ICU (but which currently
passes all layout tests even by itself with ICU disabled). A lot of refactoring is
still needed - most importantly, round-tripping encoding names via CFStringEncoding
makes little sense now.

  • WebCore.exp:
  • bridge/mac/WebCoreTextDecoder.h: Removed.
  • bridge/mac/WebCoreTextDecoder.mm: Removed. WebCoreTextDecoder was not used anywhere since WebTextView was moved into WebCore.
  • loader/Decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::decode): Use StreamingTextDecoder::create().
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::create): (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
  • platform/StreamingTextDecoder.h: StreamingTextDecoder is just an abstract interface to implementations now.
  • platform/StreamingTextDecoderICU.cpp: Added. (WebCore::StreamingTextDecoderICU::StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::~StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::releaseICUConverter): (WebCore::StreamingTextDecoderICU::textEncodingSupported): (WebCore::StreamingTextDecoderICU::convertUTF16): (WebCore::StreamingTextDecoderICU::convertIfASCII): (WebCore::StreamingTextDecoderICU::createICUConverter): (WebCore::StreamingTextDecoderICU::appendOmittingBOM): (WebCore::StreamingTextDecoderICU::convertUsingICU): (WebCore::StreamingTextDecoderICU::convert): (WebCore::StreamingTextDecoderICU::toUnicode): (WebCore::StreamingTextDecoderICU::fromUnicode):
  • platform/StreamingTextDecoderICU.h: Added. Renamed from StreamingTextDecoder; added a way to tell whether the encoding is actually supported by the decoder; minor cleanup.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::effectiveEncoding): Moved from StreamingTextDecoder. (WebCore::TextEncoding::toUnicode): Use StreamingTextDecoder::create(). (WebCore::TextEncoding::fromUnicode): Moved to StreamingTextDecoderICU.


  • platform/TextEncoding.h: Changed APPLE to PLATFORM(MAC); added effectiveEncoding().
  • platform/mac/StreamingTextDecoderMac.cpp: Added. (WebCore::StreamingTextDecoderMac::StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::~StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::releaseTECConverter): (WebCore::StreamingTextDecoderMac::textEncodingSupported): (WebCore::StreamingTextDecoderMac::convertUTF16): (WebCore::StreamingTextDecoderMac::convertIfASCII): (WebCore::StreamingTextDecoderMac::createTECConverter): (WebCore::StreamingTextDecoderMac::appendOmittingBOM): (WebCore::StreamingTextDecoderMac::convertOneChunkUsingTEC): (WebCore::StreamingTextDecoderMac::convertUsingTEC): (WebCore::StreamingTextDecoderMac::convert): (WebCore::StreamingTextDecoderMac::toUnicode): (WebCore::StreamingTextDecoderMac::fromUnicode):
  • platform/mac/StreamingTextDecoderMac.h: Added. (WebCore::StreamingTextDecoderMac::convert): This is a TEC+CFString code path for decoding, basically restored from a year-old revision.
  • platform/mac/TextEncodingMac.cpp: Removed. Code moved to StreamingTextDecoderMac.
  • WebCore.xcodeproj/project.pbxproj:
23:37 Changeset [15448] by thatcher

Build fix and versioning.

23:36 Changeset [15447] by thatcher

New tag (part 2)

23:35 Changeset [15446] by thatcher

new tag.

23:32 Changeset [15445] by thatcher

Build fix for case-sensitive file systems.

21:16 Changeset [15444] by ggaren

RS by Maciej.


Global replace in the API of argc/argv with argumentCount/arguments.

21:10 Changeset [15443] by ggaren

Reviewed by Maciej.


  • Finalized exception handling in the API.


setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.


toBoolean can't throw because it's defined that way in the spec.


  • Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.
19:32 Changeset [15442] by thatcher

New tag.

19:25 Changeset [15441] by thatcher

LayoutTests:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <justin.garcia@apple.com>

Reviewed by levi & thatcher

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <justin.garcia@apple.com>

Reviewed by levi & thatcher

<http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
19:14 Changeset [15440] by thatcher

Versioning

17:53 Changeset [15439] by thatcher

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Build fix with the new GCC. Removes forward declarations of protocols.

  • Misc/WebSearchableTextView.h:
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h:
  • WebView/WebDocumentPrivate.h:
  • WebView/WebHTMLView.h:
  • WebView/WebPDFView.h:
  • WebView/WebScriptDebugDelegatePrivate.h:
17:24 Changeset [15438] by thatcher

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Made a DOMNode category in DOMEvents.h that lets DOMNode conform to the
DOMEventTarget protocol that works with GCC 5412.

Removed forward declarations of WebCoreWidgetHolder and imported WebCoreWidgetHolder.h.

Removed all <Cocoa/Cocoa.h> and <Foundation/Foundation.h> imports in other headers,
we import <Cocoa/Cocoa.h> in the prefix header for ObjC.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bridge/mac/FormDataMac.h:
  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreCache.h:
  • bridge/mac/WebCoreEncodings.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameNamespaces.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCoreResourceLoader.h:
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreTextDecoder.h:
  • bridge/mac/WebDashboardRegion.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • platform/mac/CookieJar.mm:
  • platform/mac/DeprecatedStringMac.mm:
  • platform/mac/FontDataMac.mm:
  • platform/mac/FoundationExtras.h:
  • platform/mac/TextBoundaries.mm:
  • platform/mac/WebCoreHistory.h:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreKeyGenerator.h:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreView.h:
  • platform/mac/WebCoreWidgetHolder.h:
15:39 Changeset [15437] by ggaren

JavaScriptCore:

Reviewed by Maciej.


  • Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.


Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.


  • Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)
  • API/APICast.h: (toJS): Added cast for new JSGlobalContext
  • API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
  • kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
  • kjs/testkjs.cpp: (doIt): Ref-count the interpreter.

JavaScriptGlue:

Reviewed by Maciej.


  • Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.

WebCore:

Reviewed by Maciej.

  • Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.

14:21 Changeset [15436] by brmorris

2006-07-14 brmorris <bradley.morrison@nokia.com>

Reviewed by zbujtas@gmail.com. Fix for:


http://bugzilla.opendarwin.org/show_bug.cgi?id=9919


  • prepare-ChangeLog.bat: Match Changelog subdir location on '/'
  • refresh_zips.bat: Added.
13:54 Changeset [15435] by andersca

2006-07-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adele and Justin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
<rdar://problem/4613948>
REGRESSION: Check Spelling does not work in textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end indices respectively.


  • dom/Range.cpp: (WebCore::Range::checkNodeBA): Allow range operations on shadow trees.
  • manual-tests/form-element-spelling.html: Added.
13:53 Changeset [15434] by mjs

Reviewed by Geoff.


  • removed bool return value from JSObjectSetProperty, since it is inefficient and also doesn't work quite right
  • added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Removed return value and canPut stuff. (JSObjectGetPropertyAtIndex): Added. (JSObjectSetPropertyAtIndex): Added.
  • API/JSObjectRef.h: Prototyped and documented new functions.
13:35 Changeset [15433] by bdakin

Reviewed by Hyatt.

Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
WebCore::FrameView::updateOverflowStatus

m_viewportRenderer is never initialized for framesets, and it
shouldn't be. So we just need to nil-check for it in
updateOverflowStatus() and return early.

  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus): Nil check.
13:29 Changeset [15432] by brmorris

2006-07-11 brmorris <bradley.morrison@nokia.com>

Reviewed by dacarson.


Fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=9755


  • ChangeLog: Re-arranged all ChangeLog entry locations.
  • JavaScriptCore/ChangeLog: Stripped to S60WebKit only.
  • MemoryManager/ChangeLog: Added.
  • S60Internals/ChangeLog: Added.
  • S60Tools/ChangeLog: Added.
  • S60WebUi/ChangeLog: Added.
  • WebCore/ChangeLog: Added.
  • WebKit/ChangeLog: Re-arranged.
13:07 Changeset [15431] by brmorris

2006-07-11 brmorris <bradley.morrison@nokia.com>

Reviewed by zbujtas@gmail.com.


Fix for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=9852


  • runATF.bat: Now supports SDK 3rd ed maintenance release.

Calls Epoc.exe directly

  • emu.bat: Calls Epoc.exe directly
12:09 Changeset [15430] by adele

WebCore:

RS by Darin.

Backing out fix for <rdar://problem/4604703>
REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Darin had a better fix in WebKit for this.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):

WebKit:

Reviewed by Adele.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to YES while calling sendContextMenuEvent: on the bridge.
11:53 Changeset [15429] by adele

Reviewed by Darin.

  • Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
  • page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
  • bridge/mac/FrameMac.h: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter if the input manager says there's marked text. I added this code for all text field paths. For widgets, WebCoreTextField.mm has code to deal with this case. But as we convert search, password, and isindex, they will need to do this check too.
10:41 Changeset [15428] by ggaren

Reviewed by Beth.


Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
JSBase.h/.cpp. They don't belong in the value-specific or context-specific
files because they're not part of the value or context implementations.

  • API/JSBase.h:
  • API/JSContextRef.cpp: (JSContextGetGlobalObject):
  • API/JSContextRef.h:
  • API/JSValueRef.cpp: (JSValueUnprotect):
  • API/JSValueRef.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
06:18 Changeset [15427] by ddkilzer

WebCore:

Reviewed by Darin. Patch by Mitz.

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret position.
06:14 Changeset [15426] by ddkilzer

LayoutTests:

Reviewed by Darin.

  • editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • editing/deleting/delete-at-start-or-end-expected.png: Added.
  • editing/deleting/delete-at-start-or-end-expected.txt: Added.
  • editing/deleting/delete-at-start-or-end.html: Added.

WebCore:

Reviewed by Darin.

Test: editing/deleting/delete-at-start-or-end.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Added null check. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
05:33 Changeset [15425] by ddkilzer

LayoutTests:

Reviewed by Darin.

NOTE: Only the layout test part of this patch was landed since an alternate
fix was committed in r15401: <rdar://problem/4509393> selected DOM range
starts with <object>, 0 offset but selection should include the <object>

  • fast/table/click-near-anonymous-table-expected.checksum: Added.
  • fast/table/click-near-anonymous-table-expected.png: Added.
  • fast/table/click-near-anonymous-table-expected.txt: Added.
  • fast/table/click-near-anonymous-table.html: Added.
05:05 Changeset [15424] by ddkilzer

WebCore:

Reviewed by Geoffrey.

No test cases since there is no change in functionality.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Simplified logic by using the no-argument getNumber() method.
01:07 Changeset [15423] by ggaren

Reviewed by Adele.

  • Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have one surrounding this function, and the nested one makes the compiler think our local variable is volatile (seems like a compiler bug to me).


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
00:46 Changeset [15422] by thatcher

Reviewed by Maciej.

Make JavaScriptCore a public framework. Adjusted the paths.

  • WebCore.xcodeproj/project.pbxproj:
00:45 Changeset [15421] by mjs

LayoutTests:

Reviewed by Hyatt.


Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I included the test case from the bug plus variants for other broken cases that
were similar but needed separate fixes.

  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

  • fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I also fixed all the similar crash / assertion failure cases I could think of.

  • dom/Node.cpp: (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
  • dom/Node.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Don't allow inserting forms when not in an HTML document, since we don't need that quirk and because parsing won't do certain render tree fixups. Also watch out for case when inserting before the renderer of a misnested child.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): ditto
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): ditto
00:15 Changeset [15420] by thatcher

JavaScriptCore:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

WebKit:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

  • WebKit.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.