Timeline



Aug 20, 2006:

5:01 PM Changeset in webkit [15947] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • pull a bit of WebDataSource code into WebFrameLoader
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader webFrame]): (-[WebFrameLoader _handleFallbackContent]): (+[WebFrameLoader _canShowMIMEType:]): (+[WebFrameLoader _representationExistsForURLScheme:]): (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
  • WebView/WebDataSource.m:
  • WebView/WebDataSourceInternal.h:
3:27 PM Changeset in webkit [15946] by rwlbuis
  • 17 edits in trunk

JavaScriptCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing obsolete QConstString/QString constructors in kjs code.

WebCore:

Reviewed by Maciej. Landed by rwlbuis.

Fixes parts of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WebKit should have Qt platform support

Removing HelperQt.h usage by creating appropriate operators
constructor in some of the platform classes, as suggested by Darin.

Aug 18, 2006:

10:35 PM Changeset in webkit [15945] by sfalken
  • 2 edits in trunk/WebCore

2006-08-18 Steve Falkenburg <​sfalken@apple.com>

Rubber stamped by adele.


Fix call to WebFormDelegate's textFieldDidBeginEditing.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged):


4:26 PM Changeset in webkit [15944] by rwlbuis
  • 1 edit
    3 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

WebKit should have Qt platform support

4:20 PM Changeset in webkit [15943] by rwlbuis
  • 1 edit
    7 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Next chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:47 PM Changeset in webkit [15942] by rwlbuis
  • 1 edit
    6 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:34 PM Changeset in webkit [22113] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): Another attempt at fixing the build. Make these two functions into instance methods of PluginViewWin.
3:27 PM Changeset in webkit [22112] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

  • plugins/win/PluginViewWin.cpp: (WebCore::write): (WebCore::destroyStream):
  • plugins/win/PluginViewWin.h: Fix build by removing unneeded parameters.
3:16 PM Changeset in webkit [15941] by rwlbuis
  • 7 adds in trunk/WebCore/platform/qt

Reviewed by Eric. Landed by rwlbuis.

First chunk of the implementation for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10467

3:08 PM Changeset in webkit [22111] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-08-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

Have the NPN functions call into the plugin view. Implement some of the plugin view methods.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::setCurrentPluginView): (WebCore::PluginViewWin::currentPluginView): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL): (WebCore::PluginViewWin::newStream): (WebCore::write): (WebCore::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::status): (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::setValue): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp: (pluginViewForInstance): (NPN_ReloadPlugins): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_GetValue): (NPN_SetValue):
12:33 PM Changeset in webkit [15940] by rwlbuis
  • 1 edit in trunk/JavaScriptCore/wtf/unicode/UnicodeDirection.h

I hope I got this finally right, learning all the time :|

12:26 PM Changeset in webkit [15939] by rwlbuis
  • 3 edits in trunk/JavaScriptCore/wtf/unicode

Accidently doubly applied patch for:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
Sorry for any inconvenience!

12:11 PM Changeset in webkit [15938] by rwlbuis
  • 1 edit
    17 adds in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10470
The Qt platform needs a KCanvas device.

11:53 AM Changeset in webkit [15937] by rwlbuis
  • 3 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10463
WTF Changes needed for Qt platform code.

11:27 AM Changeset in webkit [22110] by andersca
  • 7 edits
    4 adds in branches/WindowsMerge/WebCore

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Steve and Maciej.

Add initial implementation of plugin view.

  • WebCore.vcproj/WebCore.vcproj: Add files.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::objectContentType): (WebCore::FrameWin::createPlugin): Implement these functions.


  • platform/win/TemporaryLinkStubs.cpp: Remove implemented functions.


  • platform/win/WidgetWin.cpp: Add this file from the open source repo (WebCore::Widget::~Widget): Call DestroyWindow on the hWnd.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): New function which creates a plugin view.


  • plugins/win/PluginDatabaseWin.h:


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Assign the browser functions. They are just stubs for now.


  • plugins/win/PluginViewWin.cpp: Added. (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::invokeSetWindow): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::createUTF8StringArray): (WebCore::freeStringArray): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h: Added. (WebCore::PluginViewWin::plugin): (WebCore::PluginViewWin::instance):
  • plugins/win/npapi.cpp: Added. (NPN_MemAlloc): (NPN_MemFree): (NPN_MemFlush): (NPN_ReloadPlugins): (NPN_RequestRead): (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_UserAgent): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): (NPN_GetValue): (NPN_SetValue): (NPN_GetJavaEnv): (NPN_GetJavaPeer):
9:23 AM Changeset in webkit [15936] by brmorris
  • 2 edits in S60/trunk/group

2006-08-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by me.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10484

  • Distribution.Policy.S60: Set to 0
6:03 AM Changeset in webkit [15935] by rwlbuis
  • 3 edits
    1 add in trunk

Fixing my mistakes with landing of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466

4:58 AM Changeset in webkit [15934] by rwlbuis
  • 1 add in trunk/CMakeLists.txt

I forgot to commit this as part of:
Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464

4:45 AM Changeset in webkit [15933] by rwlbuis
  • 20 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10466
WebKit should have Qt platform support.

4:21 AM Changeset in webkit [15932] by rwlbuis
  • 10 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10465
General WebKit Linux build fixes.

4:04 AM Changeset in webkit [15931] by rwlbuis
  • 2 edits
    2 adds in trunk

Reviewed by Eric. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10464
Offer a cmake build system for Qt platform.

Aug 17, 2006:

4:05 PM Changeset in webkit [15930] by harrison
  • 6 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4671069> REGRESSION: Popup buttons in web pages aren't exposed as AXPopupButtons

Accessorized RenderMenuList objects.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject mouseButtonListener]): Trivial formatting.


(-[WebCoreAXObject actionElement]):
Return the HTMLSelectElement.


(-[WebCoreAXObject firstChild]):
(-[WebCoreAXObject lastChild]):
(-[WebCoreAXObject previousSibling]):
(-[WebCoreAXObject nextSibling]):
(-[WebCoreAXObject parentObject]):
(-[WebCoreAXObject parentObjectUnignored]):
(-[WebCoreAXObject isAttachment]):
(-[WebCoreAXObject attachmentView]):
Trivial formatting.

(-[WebCoreAXObject role]):
Return NSAccessibilityPopUpButtonRole.

(-[WebCoreAXObject subrole]):
Trivial formatting.


(-[WebCoreAXObject roleDescription]):
Return NSAccessibilityPopUpButtonRole.


(-[WebCoreAXObject textUnderElement]):
Trivial formatting.

(-[WebCoreAXObject value]):
Return the RenderMenuList::text().


(-[WebCoreAXObject position]):

Trivial formatting.

(-[WebCoreAXObject accessibilityIsIgnored]):

  • Ignore popup menu items because AppKit does.
  • Remove redundant check for buttonTag (earlier isControl() check suffices).


(-[WebCoreAXObject accessibilityAttributeNames]):
(-[WebCoreAXObject accessibilityActionNames]):
(-[WebCoreAXObject accessibilityAttributeValue:]):
Trivial formatting.


(-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
Removed old debugging code that is no longer needed.
Trivial formatting.


(-[WebCoreAXObject doAXSentenceTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject doAXParagraphTextMarkerRangeForTextMarker:]):
(-[WebCoreAXObject removeAXObjectID]):
Trivial formatting.


  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Call click() instead of focus().


  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text): Added for easy access to popup's current text.


  • rendering/RenderMenuList.h: (WebCore::RenderMenuList::isMenuList):
  • rendering/RenderObject.h: (WebCore::RenderObject::isMenuList): Added so popups can be identified.
3:23 PM Changeset in webkit [15929] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit

  • WebKit.LP64.exp:
2:13 PM Changeset in webkit [22109] by andersca
  • 5 edits
    8 adds in branches/WindowsMerge

WebCoreWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

Add initial implementation of plugin database.


  • WebCore.vcproj/WebCore.vcproj: Add new files.


  • platform/win/TemporaryLinkStubs.cpp: Get rid of the PlugInInfoStore stubs.
  • plugins/win/PlugInInfoStoreWin.cpp: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins):
  • plugins/win/PluginDatabaseWin.cpp: Added. (WebCore::PluginDatabaseWin::installedPlugins): (WebCore::PluginDatabaseWin::refresh): (WebCore::PluginDatabaseWin::plugins): (WebCore::PluginDatabaseWin::getPluginsInPaths): (WebCore::PluginDatabaseWin::defaultPluginPaths): (WebCore::PluginDatabaseWin::isMIMETypeRegistered): (WebCore::PluginDatabaseWin::pluginForMIMEType): (WebCore::PluginDatabaseWin::pluginForExtension):
  • plugins/win/PluginDatabaseWin.h: Added. (WebCore::PluginDatabaseWin::setPluginPaths):
  • plugins/win/PluginPackageWin.cpp: Added. (WebCore::PluginPackageWin::~PluginPackageWin): (WebCore::getVersionInfo): (WebCore::splitString): (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::fetchInfo): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown): (WebCore::PluginPackageWin::createPackage): (WebCore::PluginPackageWin::hash): (WebCore::PluginPackageWin::equal):
  • plugins/win/PluginPackageWin.h: Added. (WebCore::PluginPackageWin::name): (WebCore::PluginPackageWin::description): (WebCore::PluginPackageWin::fileName): (WebCore::PluginPackageWin::mimeToDescriptions): (WebCore::PluginPackageWin::mimeToExtensions): (WebCore::PluginPackageWin::pluginFuncs): (WebCore::PluginPackageWinHash::hash): (WebCore::PluginPackageWinHash::equal): (WTF::):
  • plugins/win/npfunctions.h: Added.

WebKitWin:

2006-08-17 Anders Carlsson <​andersca@apple.com>

Reviewed by Maciej.

  • WebKit.vcproj/WebKit.vcproj: Add version.lib
1:37 PM Changeset in webkit [15928] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-08-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

  • bindings/npapi.h: Fix ifdef.
1:06 PM Changeset in webkit [15927] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4527201> REGRESSION: AXTextMarkerRangeForUnorderedTextMarkers returns out of order range

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::visiblePositionForTextMarker): Validate the marker by comparing the node and offset to those of the resulting VisiblePosition.
12:58 PM Changeset in webkit [15926] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
<rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])

Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
Set the _private->closed flag at the beginning of _close to prevent reentry.
Set the host window and all the delegates to nil in _close.

  • WebView/WebView.m: (-[WebView _close]):
7:55 AM Changeset in webkit [15925] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-16 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10325
There is no data supplier provided for external links in LoadPage, so the data is not
loaded. Also, client "leaves" are not handled from ResolveLinkL in the BufferTransaction's
DoSubmit.function. Cleaned up the indentation

  • BrowserView/src/WebKitLoader.cpp: (CWebKitOOMStopper::Priority): (CWebKitLoader::ConstructL): (CWebKitLoader::NewL): (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::CancelTransactionCB): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleResolveComplete): (CBufferTransaction::HandleNextDataChunk): (CBufferTransaction::HandleNextDataChunkL): (CBufferTransaction::HandleClientDataChunkL):

Aug 16, 2006:

11:37 PM Changeset in webkit [22108] by aroben
  • 1 edit
    1 delete in branches/WindowsMerge/WebCore

Removing this unintentionally added file.

11:33 PM Changeset in webkit [22107] by aroben
  • 2 edits
    3 adds in branches/WindowsMerge/WebCore

Reviewed by Steve.

Branching files from OpenSource tree r15924 to prepare for <select>
element implementation.

  • WebCore.vcproj/WebCore.vcproj:
  • rendering/RenderPopupMenuWin.h: Added. (WebCore::RenderPopupMenuWin::RenderPopupMenuWin):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme): (WebCore::m_textFieldTheme): (WebCore::RenderThemeWin::~RenderThemeWin): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeWin::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeWin::platformActiveSelectionForegroundColor): (WebCore::RenderThemeWin::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeWin::addIntrinsicMargins): (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::prepareForDrawing): (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::setCheckboxSize): (WebCore::RenderThemeWin::setRadioSize): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::paintTextArea): (WebCore::RenderThemeWin::createPopupMenu):
  • rendering/RenderThemeWin.h: Added. (WebCore::ThemeData::m_state): (WebCore::RenderThemeWin::supportsHover): (WebCore::RenderThemeWin::paintCheckbox): (WebCore::RenderThemeWin::paintRadio):
3:59 PM Changeset in webkit [15924] by justing
  • 3 edits
    1 add
    1 delete in trunk/LayoutTests

Reviewed by thatcher

Equivalent render tree:

  • fast/events/ondragenter-expected.checksum:
  • fast/events/ondragenter-expected.txt:


Patch exposed a bug (10449):

  • fast/lists/drag-into-marker.html: Removed.
  • fast/lists/drag-into-marker.html-disabled: Added.
3:34 PM Changeset in webkit [15923] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Anders. Landed by rwlbuis.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10447
AffineTransform should be multi-platform compatible

3:07 PM Changeset in webkit [15922] by hyatt
  • 2 edits in trunk/WebCore

Fix an issue with CSS2 system fonts where they did not respect text
zoom. This was most visible with the new control fonts used for form
controls (they stopped swapping between small/mini/regular as you zoomed).

Reviewed by beth

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
2:58 PM Changeset in webkit [15921] by thatcher
  • 1 copy in tags/WebKit-418.9/WebKit

Tag for WebKit 418.9 (part 2 of 2.)

2:58 PM Changeset in webkit [15920] by thatcher
  • 1 add in tags/WebKit-418.9

Tag for WebKit 418.9 (part 1 of 2.)

2:57 PM Changeset in webkit [15919] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:17 PM Changeset in webkit [15918] by justing
  • 114 edits
    8 adds in trunk

LayoutTests:

Reviewed by thatcher


Added:

  • editing/pasteboard/interchange-newline-4-expected.checksum: Added.
  • editing/pasteboard/interchange-newline-4-expected.png: Added.
  • editing/pasteboard/interchange-newline-4-expected.txt: Added.
  • editing/pasteboard/interchange-newline-4.html: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
  • editing/deleting/paragraph-in-preserveNewline-expected.txt: Added.
  • editing/deleting/paragraph-in-preserveNewline.html: Added.


Equivalent render trees, fixes, or bugs exposed (10427, 10428):

  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/execCommand/insertHTML.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum:
  • editing/execCommand/insertHorizontalRule-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • editing/inserting/insert-3786362-fix-expected.checksum:
  • editing/inserting/insert-3786362-fix-expected.png:
  • editing/inserting/insert-3786362-fix-expected.txt:
  • editing/inserting/insert-3786362-fix.html:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/3976872-expected.checksum:
  • editing/pasteboard/3976872-expected.png:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-3-expected.checksum:
  • editing/pasteboard/4076267-3-expected.png:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-3.html:
  • editing/pasteboard/4076267-expected.checksum:
  • editing/pasteboard/4076267-expected.png:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/4076267.html:
  • editing/pasteboard/4242293-1-expected.txt:
  • editing/pasteboard/4242293-expected.checksum:
  • editing/pasteboard/4242293-expected.png:
  • editing/pasteboard/4242293-expected.txt:
  • editing/pasteboard/4631972-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/copy-paste-bidi-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.checksum:
  • editing/pasteboard/display-block-on-spans-expected.png:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/merge-end-1-expected.checksum:
  • editing/pasteboard/merge-end-1-expected.png:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-1.html:
  • editing/pasteboard/merge-end-2-expected.checksum:
  • editing/pasteboard/merge-end-2-expected.png:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-2.html:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.checksum:
  • editing/pasteboard/merge-end-table-expected.png:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-002-expected.txt:
  • editing/pasteboard/paste-line-endings-004-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-003-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-007-expected.checksum:
  • editing/pasteboard/paste-text-007-expected.png:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-012.html:
  • editing/pasteboard/paste-text-013-expected.checksum:
  • editing/pasteboard/paste-text-013-expected.png:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/paste-text-019.html:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • editing/pasteboard/pasting-object-expected.txt:
  • editing/pasteboard/prevent-block-nesting-01-expected.txt:
  • editing/pasteboard/quirks-mode-br-1-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/pasteboard/undoable-fragment-removes-expected.checksum:
  • editing/pasteboard/undoable-fragment-removes-expected.png:
  • editing/pasteboard/undoable-fragment-removes-expected.txt:
  • editing/pasteboard/undoable-fragment-removes.html:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:

WebCore:

Reviewed by thatcher


First part of fix for:
<rdar://problem/4384589>
Mail hung on paste text


Fixes:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8592>
Extra line left after deleting whitespace:pre text
<rdar://problem/4128080> Paste as HTML does not yield equivalent style
<rdar://problem/4046469> Box styles on first element aren't copied/pasted
Copy/paste of arstechnica.com


Here's how we avoid adding redundant style information on paste: insert
the fragment and do a test rendering, save away style information for
every node in the fragment, remove all style information from the fragment,
remove the fragment, insert it into the appropriate place in the document,
then restore only those styles gathered during the test insertion that aren't
redundant. Restoring the styles in this way results in an ApplyStyleCommand
and a layout for nearly every inserted node.
Instead we want to insert the fragment into the document without removing the
style information, then mark style nodes and inline style declarations for
removal if they are redundant, and sweep to remove them. This means that we
can't rely on ReplacementFragment::wasBlock anymore, because blocks will now
have style spans around them. This patch removes the use of wasBlock in
ReplaceSelectionCommand.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Added code to remove the line placeholder left after a move from preserveNewline text.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Don't add a placeholder if we're deleting a paragraph in preserveNewline text.
  • editing/JSEditor.cpp: Pass true to prevent nesting.
  • editing/ReplaceSelectionCommand.cpp: Removed wasBlock and friends. (WebCore::ReplacementFragment::ReplacementFragment): Ditto. (WebCore::ReplacementFragment::saveRenderingInfo): Ditto. (WebCore::RenderingInfo::RenderingInfo): Ditto. (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::shouldMergeStart): Combined the to/from merging rules into one method. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): (WebCore::ReplaceSelectionCommand::shouldMerge): (WebCore::ReplaceSelectionCommand::doApply): Don't do nesting prevention when pasting into an empty paragraph, this fixes 4046469, the common cause of paste fidelity bugs, but needs to be tweaked a little because this can lead to margin/border build-up on repeated copy/pastes. Don't track startPos in addition to insertionPos. It was never used. Fixed a bug where a fragment starting with an interchange newline would cause content to be put outside of an editable region when pasting at the very end of it. Adjust insertionPos before insertion (not during) and do not consult wasBlock to decide whether or not to do so. Changed the way we do the start merge: insert the fragment, then stich paragraphs together, in the same way that we do the end merge. This doesn't require wasBlock and fixes bugs. Replaced some uses of insertionPos with endOfInsertedContent. Fixed a bug in the expansion of the last incoming br (a "collapsed" br is one where !isStartOfParagraph([br,0])). Removed the special case code that did the end merge for the preserveNewline case, since this patch fixes the moveParagraph bug in the preserveNewline case. Removed some unused variables. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): An endBR that was holding a line open should always be displaced by inserted content, unless the inserted content ends with a br. (WebCore::ReplaceSelectionCommand::updateNodesInserted):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::style):
  • editing/markup.cpp: (WebCore::createMarkup): Only add mail blockquotes and list/table/pre when annotate is true (when we're creating markup for the pasteboard).
12:31 PM Changeset in webkit [15917] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk31

Branching for release S60 RnD release 2006 w33

12:08 PM Changeset in webkit [15916] by brmorris
  • 2 edits in S60/trunk

2006-08-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10330


  • build.bat: Remove support for SDK MR until binary

compatability in S60Internals reached.

12:06 PM Changeset in webkit [15915] by brmorris
  • 2 edits in S60/trunk

2006-08-15 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10421

  • runATF.bat: prettify layout test results.
11:56 AM Changeset in webkit [15914] by hyatt
  • 2 edits in trunk/WebCore

Fix Win32 build bustage.

11:31 AM Changeset in webkit [15913] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-16 sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10433

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::ConstructSecretEditorL):
11:31 AM Changeset in webkit [15912] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4637156> underlines appearing in white selection text
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations): bail out if phase is PaintPhaseSelection and forceWhiteText is true
11:08 AM Changeset in webkit [15911] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-16 spaltis <​Stanislav.Paltis@nokia.com>

Reviewed by Sachin
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10434
Req. Dedicated folder for downloaded content

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL): (CHttpDownloadObserver::HandleDMgrCompletedEventL):
11:03 AM Changeset in webkit [15910] by beidson
  • 2 edits in trunk/WebCore

Reviewed by John

Updated the DB version number and added a helpful comment explaining its meaning

  • loader/icon/IconDatabase.cpp:
10:43 AM Changeset in webkit [15909] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-16 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10432
Rearrange the initialization list, and remove unnecessary #includes
so PC-Lint will compile without errors.

  • BrowserView/inc/SmartLinkMap.h:
  • BrowserView/src/SmartLinkHandler.cpp: (CSmartLinkHandler::CSmartLinkHandler):
1:16 AM Changeset in webkit [15908] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Maciej

  • Misc/WebIconDatabase.m: Pruned unused method
  • Misc/WebIconDatabasePrivate.h: Ditto
1:16 AM Changeset in webkit [15907] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Maciej

Major refactoring of new iconDB:
-Instead of private browsing being handled by in-memory tables, it's now handled

by a separate in-memory database with the same table names. This allows us to
re-use the same SQL on either the main or private-browsing database

-So it follows, I broke out much of the SQL queries into seperate methods suffixed with

"Query" that take a database as the method's argument so the same language can run on
both private and main tables

-Now that we have two DBs, moved the retain/release count to the m_mainDB
-While I was at it, updated the schema to combine the Icon and IconResource table - cuts

down on some high-usage, low value queries which were too expensive

-Ditched the _url -> url convention for escaping urls for SQL. Now its url and escapedURL
-Pruned tons of unused methods from previous revisions

  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed isIconExpiredForPageURL as it was never used
    • bridge/mac/WebCoreIconDatabaseBridge.mm: Ditto
    • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Updated initializer list (WebCore::IconDatabase::open): Sets up both databases (WebCore::IconDatabase::close): Closes both databases (WebCore::IconDatabase::isEmpty): Queries both databases for at least 1 record (WebCore::IconDatabase::isValidDatabase): Reflect the updated schema (WebCore::IconDatabase::clearDatabaseTables): Ditto - and takes DB as a parameter (WebCore::IconDatabase::createDatabaseTables): Ditto (WebCore::IconDatabase::imageDataForIconURL): style cleanup, and using a query-function (WebCore::IconDatabase::setPrivateBrowsingEnabled): Resets private DB instead of private tables (WebCore::IconDatabase::isIconExpiredForIconURL): Uses a query-function on each DB (WebCore::IconDatabase::iconURLForPageURL): Uses a query-function on each DB (WebCore::IconDatabase::retainIconForPageURL): Retain count DB changes (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::isIconURLRetained): Determine if it's time to prune a released icon yet (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): Alot simpler (WebCore::IconDatabase::setIconDataForIconURL): Style cleanup (WebCore::IconDatabase::setHaveNoIconForIconURL): Ditto (WebCore::IconDatabase::setIconURLForPageURL): Ditto - and using a query-function (WebCore::IconDatabase::establishIconIDForIconURL): Style cleanup (WebCore::IconDatabase::pruneUnreferencedIcons): DB name change (WebCore::IconDatabase::pruneUnretainedIcons): Ditto (WebCore::IconDatabase::hasIconForIconURL): Simpler, using a query-function (WebCore::IconDatabase::~IconDatabase): (WebCore::pageURLTableIsEmptyQuery): Self-explanatory SQL query (WebCore::imageDataForIconURLQuery): Self-explanatory SQL query (WebCore::timeStampForIconURLQuery): Self-explanatory SQL query (WebCore::iconURLForPageURLQuery): Self-explanatory SQL query (WebCore::forgetPageURLQuery): Self-explanatory SQL query (WebCore::setIconIDForPageURLQuery): Self-explanatory SQL query (WebCore::getIconIDForIconURLQuery): Self-explanatory SQL query (WebCore::addIconForIconURLQuery): Self-explanatory SQL query (WebCore::hasIconForIconURLQuery): Self-explanatory SQL query
  • loader/icon/IconDatabase.h: Some new/changed methods, pruned methods, and new comments

(WebCore::IconDatabase::isOpen): Changed our meaning of "isOpen" to reflect the 2 databases

Note: See TracTimeline for information about the timeline view.