Timeline

View changes from
and days back.

Repository checkins Wiki changes

09/29/06:

22:42 Changeset [16682] by adele

Reviewed by Adele.

Fixes windows bustage:
 http://bugs.webkit.org/show_bug.cgi?id=11093

• platform/win/PlatformScrollBar.h:
• platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar): (ScrollBar::ScrollBar):

21:41 Changeset [22275] by hyatt

Change minimum font size value to 0 on win32 as well.

20:25 Changeset [16681] by thatcher

Bug 11041: fast/dom/isindex-001 needs new results
 http://bugs.webkit.org/show_bug.cgi?id=11041

• fast/dom/isindex-001-expected.txt:

20:15 Changeset [22274] by sfalken

2006-09-29 Steve Falkenburg < sfalken@apple.com>

Fix the build.

• platform/win/PlatformScrollBarWin.cpp:

19:08 Changeset [16680] by thatcher

Versioning

18:57 Changeset [16679] by hyatt

Change the default minimum font size pref to 0 in order to allow
font-size:0 to work.

• WebView/WebPreferences.m: (+[WebPreferences initialize]):

18:55 Changeset [16678] by hyatt

Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
in RenderObject::NodeInfo (and then propagating that Widget to
MouseEventWithHitTestResults).

This allows RenderListBox and RenderBlock to do the same thing when the
mouse is over the scrollbar.

Also land fix to support font-size: 0.

Reviewed by mjs (scrollbar), eric (font-size)

• dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
• page/Frame.cpp: (WebCore::Frame::passWidgetMouseDownEventToWidget):
• page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::dispatchMouseEvent):
• page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
• page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): (WebCore::RenderBlock::nodeAtPoint):
• rendering/RenderBlock.h:
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest):
• rendering/RenderLayer.h: (WebCore::RenderLayer::getHiddenBehavior):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::isPointInScrollbar):
• rendering/RenderListBox.h:
• rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::NodeInfo): (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):

18:50 Changeset [16677] by adele

Reviewed by Adele.

Fixes:  http://bugs.webkit.org/show_bug.cgi?id=11092

• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::convertToContainingWindow): (WebCore::ScrollView::convertFromContainingWindow):
• platform/win/WidgetWin.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):

18:44 Changeset [16676] by adele

Updated with new argument for PlatformScrollBar.

• platform/win/TemporaryLinkStubs.cpp: (PlatformScrollBar::PlatformScrollBar):

18:03 Changeset [16675] by thatcher

Merging a fix to the tag.

18:00 Changeset [16674] by thatcher

Merging a fix to the tag.

17:44 Changeset [16673] by thatcher

Merging fix to tag.

17:42 Changeset [16672] by thatcher

LayoutTests:

Reviewed by John Sullivan.

< rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
< rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

• fast/text/attributed-substring-from-range-001-expected.txt: Added.
• fast/text/attributed-substring-from-range-001.html: Added.

Check attributed string results when starting or ending at a br element.

WebCore:

Reviewed by John Sullivan.

< rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
< rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

Test added

• fast/text/attributed-substring-from-range-001.html

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case. Also, add validation of the range.

17:39 Changeset [16671] by thatcher

New tag.

17:34 Changeset [16670] by thatcher

Bad tag.

17:29 Changeset [16669] by thatcher

New tag.

17:11 Changeset [22273] by sfalken

2006-09-29 Steve Falkenburg < sfalken@apple.com>

Reviewed by Geoff.

Allow WebKit to query for the rect
of the resizer rather than just its size.

Fix < rdar://4753220>
Correct more/fewer button toggling in bug report sheet.

2006-09-29 Steve Falkenburg < sfalken@apple.com>

Reviewed by Geoff.

Allow WebKit to query for the rect
of the resizer rather than just its size.

• Interfaces/IWebUIDelegatePrivate.idl:

17:06 Changeset [16668] by thatcher

Build fix.

16:59 Changeset [16667] by adele

Reviewed by Hyatt.

Fixing build bustage with cast to int.

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):

16:45 Changeset [16666] by adele

Fixing accidental include.

• rendering/RenderListBox.cpp:

16:41 Changeset [16665] by adele

Adding RenderListBox files.

16:40 Changeset [22272] by adele

Adding RenderListBox files

16:15 Changeset [16664] by bdakin

Fixing typo. No problem in the ned. Just the end.

16:15 Changeset [22271] by adele

Adding reviewer to ChangeLog

16:15 Changeset [22270] by adele

Reviewed by NOBODY (OOPS!).

Updated constructor for PlatformScrollBar to include controlSize argument.

• platform/win/PlatformScrollBar.h:
• platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollBar::PlatformScrollBar):

16:14 Changeset [22269] by sfalken

2006-09-29 Steve Falkenburg < sfalken@apple.com>

Reviewed by Adam, Geoff.

Fix < rdar://4757392>
Plug-ins flash to white while scrolling.

Set WS_CLIPCHILDREN on browser windows to clip out plug-in HWNDs
when drawing.

• WebView.cpp: (WebView::initWithFrame):

16:13 Changeset [16663] by adele

Reviewed by Adam.

Initial implementation of engine-based list box control.

• WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp

• bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
• bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):

• page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select. (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto. (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
• page/Frame.h:
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.

• page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::currentMousePosition): (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
• page/FrameView.h:

• platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument. The list box will use a smaller scroll bar size.
• platform/ScrollBar.h: (WebCore::): (WebCore::ScrollBar::controlSize):
• platform/mac/PlatformScrollBar.h:
• platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollBar:]): (WebCore::PlatformScrollBar::PlatformScrollBar):

• rendering/RenderBlock.h:
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
• rendering/RenderLayer.h:
• rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): (WebCore::RenderObject::autoscroll):
• rendering/RenderObject.h: (WebCore::RenderObject::isListBox):

• css/html4.css: Added properties for new list boxes.

• html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled. (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
• html/HTMLOptionElement.h: Added disabled method.

• html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation. (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::lastSelectedListIndex): (WebCore::HTMLSelectElement::deselectItems): (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::recalcListItems): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys. (WebCore::HTMLSelectElement::nextSelectableListIndex): (WebCore::HTMLSelectElement::previousSelectableListIndex):
• html/HTMLSelectElement.h:

• rendering/RenderTheme.cpp: Added support for ListBoxAppearance (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::supportsFocusRing):
• rendering/RenderTheme.h:
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

• rendering/RenderListBox.cpp: Added. (WebCore::RenderListBox::RenderListBox): (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::setStyle): (WebCore::RenderListBox::updateFromElement): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::size): (WebCore::RenderListBox::numItems): (WebCore::RenderListBox::calcHeight): (WebCore::RenderListBox::baselinePosition): (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground): (WebCore::RenderListBox::scrollBarTarget): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::autoscroll): (WebCore::RenderListBox::scrollToRevealElementAtListIndex): (WebCore::RenderListBox::scroll): (WebCore::RenderListBox::valueChanged):
• rendering/RenderListBox.h: Added. (WebCore::RenderListBox::isListBox): (WebCore::RenderListBox::selectionChanged): (WebCore::RenderListBox::setSelectionChanged): (WebCore::RenderListBox::canHaveChildren): (WebCore::RenderListBox::renderName): (WebCore::RenderListBox::setOptionsChanged): (WebCore::RenderListBox::shouldAutoscroll): (WebCore::RenderListBox::listIndexIsVisible):

16:10 Changeset [16662] by bdakin

Reviewed by Darin.

We had a bug where html4.css was ignoring Media Queries. In the ned
the problem was that we were trying to send a char* to the
MediaQueryEvaluator constructor that expects a String, but the
char* got interpreted as a bool, the wrong constructor was called,
and the media type was never set.

No test case possible since this only affects html4.css

• css/MediaQueryEvaluator.cpp: New constructor that expects takes a char* (WebCore::MediaQueryEvaluator):
• css/MediaQueryEvaluator.h: Same.

15:57 Changeset [16661] by ggaren

LayoutTests:

Reviewed by John, Maciej.

Added test for whether a frame element reports its src attribute as a
complete, rather than relative, URL.

• fast/frames/frame-src-attribute-expected.txt: Added.
• fast/frames/frame-src-attribute.html: Added.
• fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

Reviewed by John, Maciej.

Integrated some frame and iframe code. I'm trying to fix up frame ownership
and loading. Reducing the number of different code paths involved
seemed like a good first step.

As a side effect, I fixed a bug where FRAME elements would report their
src attributes as relative, rather than compelete, URLs. (IFRAME elements
had the correct complete URL behavior.)

• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo (WebCore::HTMLFrameElement::openURL):

(1) Removed checks that requestFrame does for us
(2) Added isURLAllowed check, to have one clear bottleneck for it
(3) Added viewsource check, to have one clear bottleneck for it

(WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
method, instead of finding our content frame in our own unique way.
(WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
since openURL does this for us now.
(WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
This is what FF does, and it made no sense to have different behaviors
for FRAME and IFRAME elements.

• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init code.
• html/HTMLIFrameElement.h: Removed src() and openURL() methods, since HTMLFrameElement now does everything we need.

15:33 Changeset [16660] by rwlbuis

Reviewed by Hyatt.

Fix Qt/Linux build.

15:28 Changeset [16659] by brmorris

Reviewed by Brad.
DESC: Update bugzilla url

• prepare-ChangeLog.bat:

15:24 Changeset [16658] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:24 Changeset [16657] by brmorris

Update Bugzilla url to bugs.webkit.org in ChangeLogs

15:22 Changeset [16656] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:21 Changeset [16655] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:21 Changeset [16654] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:20 Changeset [16653] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:17 Changeset [16652] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:16 Changeset [16651] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:14 Changeset [16650] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:12 Changeset [16649] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

15:08 Changeset [16648] by thatcher

Replace bugzilla.opendarwin.org with bugs.webkit.org.

14:56 Changeset [16647] by spadma

2006-09-29 spadma < Sachin.Padma@nokia.com>

Reviewed by Joseph Ligman.
DESC: Fix resolvecomplete issues with BufferTransaction
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10497

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/BufferTransaction.h:
• ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::SendDataCB): (CBufferTransaction::ConstructL): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::HandleResolveComplete):

14:49 Changeset [16646] by spadma

2006-09-29 spadma < Sachin.Padma@nokia.com>

Reviewed by Joseph Ligman.
DESC: Fix resolvecomplete issues with BufferTransaction
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10497

• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
• ResourceLoader/inc/BufferTransaction.h:
• ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::SendDataCB): (CBufferTransaction::ConstructL): (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::HandleResolveComplete):

13:29 Changeset [16645] by weinig

Reviewed by Tim H.

Patch for  http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
Simplify Internal methods for the auto-generated Objective-C DOM code

• Auto-generate the internal methods for more Objective-C classes.

• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm:
• bindings/objc/DOMCSS.mm: (-[DOMStyleSheet WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
• bindings/objc/DOMHTMLAppletElement.mm: (-[DOMHTMLAppletElement WebCore::]): (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
• bindings/objc/DOMHTMLEmbedElement.mm: (-[DOMHTMLEmbedElement WebCore::]): (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMInternal.mm:
• bindings/scripts/CodeGeneratorObjC.pm:
• css/CSSCharsetRule.idl:
• css/CSSFontFaceRule.idl:
• css/CSSImportRule.idl:
• css/CSSMediaRule.idl:
• css/CSSPageRule.idl:
• css/CSSPrimitiveValue.idl:
• css/CSSStyleRule.idl:
• css/CSSStyleSheet.idl:
• css/CSSUnknownRule.idl:
• css/CSSValueList.idl:
• dom/KeyboardEvent.idl:
• dom/MouseEvent.idl:
• dom/MutationEvent.idl:
• dom/NodeIterator.idl:
• dom/OverflowEvent.idl:
• dom/UIEvent.idl:
• dom/WheelEvent.idl:

10:58 Changeset [16644] by spadma

2006-09-29 bujtas < zbujtas@gmail.com>

Reviewed by Sachin Padma.
DESC: fix intrapage navigation vs. load issue
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10974

• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LoadUrlL):
• ResourceLoader/inc/LoaderUtils.h:
• ResourceLoader/src/LoaderUtils.cpp: (TLoaderUtils::IsIntraPageNavigation):

2006-09-29 sareen < shyam.sareen@nokia.com>

Reviewed by spadma < Sachin.Padma@nokia.com>.
DESC: Avoid passing NULL URL to webcore.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11056

• ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::CreateHeaderResponseLC):

2006-09-29 zhalu < zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC:If the web page is loaded from cache, favicon is only loaded from cache,
not trying to load it from network even if cache does not have it.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=10355

• BrowserView/inc/WebKitLoader.h:
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):

2006-09-29 spadma < Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Cancel the active object before deleting it.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11087

• Src/StopScheduler.cpp: (CStopScheduler::~CStopScheduler):

10:40 Changeset [16643] by spadma

2006-09-29 spadma < Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Cancel the active object before deleting it.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11087

• Src/StopScheduler.cpp: (CStopScheduler::~CStopScheduler):

09:57 Changeset [16642] by harrison

LayoutTests:

Reviewed by John Sullivan.

< rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
< rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

• fast/text/attributed-substring-from-range-001-expected.txt: Added.
• fast/text/attributed-substring-from-range-001.html: Added.

Check attributed string results when starting or ending at a br element.

WebCore:

Reviewed by John Sullivan.

< rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
< rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

Test added

• fast/text/attributed-substring-from-range-001.html

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case. Also, add validation of the range.

09:10 Changeset [16641] by thatcher

Reviewed by Maciej.

Switch the inspector over to use border-image with styled buttons and selects.

• WebInspector/WebInspector.m: (-[NSWindow window]): (-[NSWindow setWebFrame:]): (-_updateRoot):
• WebInspector/webInspector/Images/button.png: Added.
• WebInspector/webInspector/Images/buttonDivider.png: Added.
• WebInspector/webInspector/Images/buttonPressed.png: Added.
• WebInspector/webInspector/Images/popup.png: Added.
• WebInspector/webInspector/Images/popupFill.png: Removed.
• WebInspector/webInspector/Images/popupFillPressed.png: Removed.
• WebInspector/webInspector/Images/popupLeft.png: Removed.
• WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
• WebInspector/webInspector/Images/popupPressed.png: Added.
• WebInspector/webInspector/Images/popupRight.png: Removed.
• WebInspector/webInspector/Images/popupRightPressed.png: Removed.
• WebInspector/webInspector/Images/squareButtonRight.png: Removed.
• WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
• WebInspector/webInspector/inspector.css:
• WebInspector/webInspector/inspector.html:
• WebInspector/webInspector/inspector.js:

09:08 Changeset [16640] by zbujtas

2006-09-25 zhalu < zhaosong.lu@nokia.com>

Reviewed by Zalan Bujtas.
DESC: For QColor object, there is a 'valid' flag indicating if the color is valid. The information for the valid flag is lost during the convertion of KWQPalette to WebCorePalette because the WebCorePalette uses only RGB values of color. This causes problem such as described in the bug report. The changes add the valid flag to the WebCorePalette class.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10174

Merged from \s60\branches\3.1m r16635
WARNING: NO TEST CASES ADDED OR CHANGED

• bridge/WebCorePalette.h: (TWebCorePalette::TWebCorePalette): (TWebCorePalette::SetBackGroundValid): (TWebCorePalette::SetForeGroundValid): (TWebCorePalette::IsBackGroundValid): (TWebCorePalette::IsForeGroundValid):
• kwq/KWQWidget.cpp: (QWidget::setPalette):

09:03 Changeset [16639] by spadma

2006-09-29 bujtas < zbujtas@gmail.com>

Reviewed by Sachin Padma.
DESC: fix intrapage navigation vs. load issue
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10974

• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LoadUrlL):
• ResourceLoader/inc/LoaderUtils.h:
• ResourceLoader/src/LoaderUtils.cpp: (TLoaderUtils::IsIntraPageNavigation):

08:59 Changeset [16638] by spadma

2006-09-29 sareen < shyam.sareen@nokia.com>

Reviewed by spadma < Sachin.Padma@nokia.com>.
DESC: Avoid passing NULL URL to webcore.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11056

• ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::CreateHeaderResponseLC):

2006-09-29 zhalu < zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC:If the web page is loaded from cache, favicon is only loaded from cache,
not trying to load it from network even if cache does not have it.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=10355

• BrowserView/inc/WebKitLoader.h:
• BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadFavicon):

08:27 Changeset [16637] by rwlbuis

I commited old expected results, this one is correct.

08:23 Changeset [16636] by brmorris

Reviewed by Alan.
DESC: Add mk to list of makefile extenstions.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10918

• svn-create-patch.bat: *.mk permitted to have tabs

08:18 Changeset [16635] by zbujtas

2006-09-25 zhalu < zhaosong.lu@nokia.com>

Reviewed by Zalan Bujtas.
DESC: For QColor object, there is a 'valid' flag indicating if the color is valid. The information for the valid flag is lost during the convertion of KWQPalette to WebCorePalette because the WebCorePalette uses only RGB values of color. This causes problem such as described in the bug report. The changes add the valid flag to the WebCorePalette class.
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10174

WARNING: NO TEST CASES ADDED OR CHANGED

• bridge/WebCorePalette.h: (TWebCorePalette::TWebCorePalette): (TWebCorePalette::SetBackGroundValid): (TWebCorePalette::SetForeGroundValid): (TWebCorePalette::IsBackGroundValid): (TWebCorePalette::IsForeGroundValid):
• kwq/KWQWidget.cpp: (QWidget::setPalette):

02:52 Changeset [22268] by hyatt

Fix mouse event propagation from WebKit to WebCore on Win32.

02:39 Changeset [22267] by aroben

Reviewed by hyatt.

Add error logging to plugin code.

• WebCore.vcproj/WebCore.vcproj: Added PluginDebug.h
• platform/win/NotImplemented.h: Add surrounding #ifndef/#endif
• plugins/win/PluginDebug.h: Added.
• plugins/win/PluginPackageWin.cpp: Add error logging (WebCore::PluginPackageWin::load):
• plugins/win/PluginStreamWin.cpp: Ditto. (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedAllData):
• plugins/win/PluginViewWin.cpp: Ditto. (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream):

01:40 Changeset [16634] by hyatt

Add the ability to set the click count after the fact on a mouse event.

01:39 Changeset [22266] by hyatt

Fork mouse event.cpp

01:30 Changeset [16633] by rwlbuis

Reviewed by Maciej.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

09/28/06:

23:30 Changeset [22265] by hyatt

Make setValue work on win32 scrollbars. Fix buggy math.

23:16 Changeset [22264] by hyatt

Make scrollbars on win32 give proper hover feedback.

19:10 Changeset [22263] by sfalken

2006-09-28 Steve Falkenburg < sfalken@apple.com>

Reviewed by Maciej.

Use $(ConfigSuffix) set via vsprops files to add _debug
to end of debug filenames.

19:07 Changeset [16632] by sfalken

2006-09-28 Steve Falkenburg < sfalken@apple.com>

Reviewed by Maciej.

Use $(ConfigSuffix) set via vsprops files to add _debug
to end of debug filenames.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/debug.vsprops: Added.
• JavaScriptCore.vcproj/dftables/dftables.vcproj:
• JavaScriptCore.vcproj/release.vsprops: Added.
• JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

17:56 Changeset [22262] by aroben

Forgot these in the last checkin (d'oh!)

17:55 Changeset [22261] by aroben

Reviewed by Hyatt.

Avoid creating LOGFONTs for bitmap fonts under CG, since we don't
support them anyway.

• platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData): Set lfOutPrecision to OUT_TT_ONLY_PRECIS to avoid bitmap fonts.
• platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Change the LOG_ERROR back to an ASSERT since we should never reach this condition now.

17:39 Changeset [16631] by hyatt

Switch over the Mac-specific uses of viewportToContents/contentsToViewport.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent):
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _visiblePositionForPoint:]):

17:21 Changeset [22260] by hyatt

Eliminate viewportToContents and contentsToViewport

17:17 Changeset [16630] by hyatt

Eliminate viewportToContents and contentsToViewport

16:32 Changeset [16629] by aliceli1

Build fix by adding missing files for CommandByName

• WebCore.xcodeproj/project.pbxproj:

15:47 Changeset [16628] by aliceli1

Adding CommandByName files to the vcproj

• WebCore.vcproj/WebCore/WebCore.vcproj:

15:23 Changeset [16627] by aliceli1

fixing the windows build

• COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):

15:06 Changeset [22259] by aroben

Reviewed by Anders.

Fail without crashing and log an error when CG encounters a bitmap
font.

• platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Trade LOG_ERROR for ASSERT_WITH_MESSAGE

14:41 Changeset [22258] by aliceli1

14:39 Changeset [16626] by aliceli1

14:38 Changeset [16625] by brmorris

2006-09-28 brmorris < bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: Include color attribute value in stringified info
 http://bugzilla.opendarwin.org/show_bug.cgi?id=EBUGZILLADOWN

• khtml/rendering/render_object.cpp: (RenderObject::information): Now includes Style()->color

14:33 Changeset [16624] by aroben

Reviewed by Adele.

Remove no-longer-used PopUpButton.

• WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
• WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h, PopUpButtonMac.mm
• platform/PopUpButton.h: Removed.
• platform/mac/PopUpButtonMac.mm: Removed.
• platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
• rendering/DeprecatedRenderSelect.cpp: Change #include of PopUpButton.h to ListBox.h

14:31 Changeset [22257] by aroben

Reviewed by Adele.

Remove never-to-be-used PopUpButton

• WebCore.vcproj/WebCore.vcproj: Remove PopUpButton.h
• platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods

14:28 Changeset [16623] by harrison

Suggested by Darin.

Moved an extern declaration from inside a method to the top of the file.

• DumpRenderTree/EventSendingController.m: (-[EventSendingController clearKillRing]):

14:07 Changeset [16622] by darin

JavaScriptCore:

Reviewed by Alice.

• support for change that should fix < rdar://problem/4733044> REGRESSION: XML iBench shows 10% perf. regression (copying strings while decoding)

• wtf/Vector.h: Changed VectorBuffer so that the general case contains an instance of the 0 case, since deriving from it was violating the Liskov Substitution Principle. (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can be adopted by another data structure that uses the FastMalloc.h allocator. Returns 0 if the internal buffer was being used. (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates a new one in the case where the internal buffer was being used.

WebCore:

Reviewed by Alice.

• change that should fix < rdar://problem/4733044> REGRESSION: XML iBench shows 10% perf. regression (copying strings while decoding)

Use Vector<UChar> instead of String when building up the decoded string in
the ICU and Mac decoders. Using String leads to O(n^{2) behavior because
String grows the buffer every single time that append is called. Using
Vector::append instead of String::append also avoids constructing a string
each time just to append and a questionable copy that is done inside the
String::append function which also contributed to the slowness.}

• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a Vector<UChar>, adopting the buffer from the vector to avoid copying and memory allocation.
• platform/StringImpl.h:
• platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.

• platform/StreamingTextDecoder.h:
• platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM): Change to use a Vector<UChar> instead of a String, since vectors have better resizing performance (they store a separate capacity).

• platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
• platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode): Change to use Vector<UChar> instead of String and then create a string at the end of the process using the new adopt function.

14:05 Changeset [16621] by thatcher

Explicitly specify stabs for Debug and Production.

13:25 Changeset [16620] by harrison

LayoutTests:

Reviewed by Justin.

Call clearKillRing() so we are guaranteed to start with empty kill ring.

• editing/pasteboard/emacs-cntl-y-001.html:

WebKitTools:

Reviewed by Justin.

Add clearKillRing so we can test emacs support with empty kill ring.

• DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController clearKillRing]):

13:12 Changeset [16619] by brmorris

2006-09-28 brmorris < bradley.morrison@nokia.com>

Reviewed by myself :)
DESC: Added tests for tabbed navigation via:

<meta name="navigation" content="tabbed"/>

 http://bugzilla.opendarwin.org/show_bug.cgi?id=10222

• manual/10222_tabbed_navigation-mobile-expected.txt: Added.
• manual/10222_tabbed_navigation.html: Added.

13:07 Changeset [22256] by aroben

Reviewed by Alice.

Replace notImplemented() with LOG_NOIMPL() and STOP_NOIMPL() macros
which generate debug output. STOP_NOIMPL() also generates a debug
break. Replace calls to notImplemented() with
LOG_NOIMPL()/STOP_NOIMPL() as appropriate. This should stop some unnecessary
crashes where notImplemented() was called from a method that can fail
safely.

• WebCore.vcproj/WebCore.vcproj: Added NotImplemented.h
• platform/win/FontWin.cpp: Use LOG_NOIMPL() instead of notImplemented(). (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
• platform/win/NotImplemented.h: Added. Contains new LOG_NOIMPL() and STOP_NOIMPL() macros.
• platform/win/TemporaryLinkStubs.cpp: Use LOG_NOIMPL() and STOP_NOIMPL() instead of notImplemented() or nothing. (PopUpButton::focusPolicy): (PopUpButton::populate): (Widget::enableFlushDrawing): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::lockDrawingFocus): (Widget::unlockDrawingFocus): (JavaAppletWidget::JavaAppletWidget): (TextField::selectAll): (TextField::addSearchResult): (TextField::selectionStart): (TextField::hasSelectedText): (TextField::selectedText): (TextField::setAutoSaveName): (TextField::checksDescendantsForFocus): (TextField::setSelection): (TextField::setMaxResults): (TextField::edited): (Slider::Slider): (Slider::sizeHint): (Slider::setValue): (Slider::setMaxValue): (Slider::setMinValue): (Slider::~Slider): (Slider::setFont): (Slider::value): (ListBox::sizeForNumberOfLines): (ListBox::isSelected): (ListBox::checksDescendantsForFocus): (Slider::focusPolicy): (ListBox::focusPolicy): (TextField::focusPolicy): (Cursor::Cursor): (PlatformMouseEvent::PlatformMouseEvent): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::ServeSynchronousRequest): (FrameWin::focusWindow): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::registerCommandForRedo): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::shouldInterruptJavaScript): (FrameWin::openURL): (FrameWin::print): (FrameWin::passMouseDownEventToWidget): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issuePasteCommand): (FrameWin::issueUndoCommand): (FrameWin::issueRedoCommand): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::issueTransposeCommand): (FrameWin::passWheelEventToChildWidget): (FrameWin::mimeTypeForFileName): (FrameWin::scheduleClose): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::originalRequestURL): (FrameWin::isLoadTypeReload): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL): (GraphicsContext::addRoundedRectClip): (GraphicsContext::addInnerRoundedRectClip): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::moveCursor): (WebCore::inputElementAltText): (WebCore::findWordBoundary): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (FrameView::updateBorder): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::markedTextRange): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::saveDocumentState): (FrameWin::registerCommandForUndo): (FrameWin::clearUndoRedoOperations): (FrameWin::incomingReferrer): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::respondToChangedContents): (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (Widget::setIsSelected): (ScrollView::inWindow): (ScrollView::scrollPointRecursively): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (GraphicsContext::clearRect): (GraphicsContext::strokeRect): (GraphicsContext::setLineWidth): (GraphicsContext::setLineCap): (GraphicsContext::setLineJoin): (GraphicsContext::setMiterLimit): (GraphicsContext::setAlpha): (GraphicsContext::clip): (GraphicsContext::rotate): (GraphicsContext::scale): (Path::Path): (Path::~Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=): (Path::clear): (Path::moveTo): (Path::addLineTo): (Path::addQuadCurveTo): (Path::addBezierCurveTo): (Path::addArcTo): (Path::closeSubpath): (Path::addArc): (Path::addRect): (Path::addEllipse): (GraphicsContext::drawFocusRing): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::setCompositeOperation): (TextField::TextField): (TextField::~TextField): (TextField::setFont): (TextField::setAlignment): (TextField::setWritingDirection): (TextField::maxLength): (TextField::setMaxLength): (TextField::text): (TextField::setText): (TextField::cursorPosition): (TextField::setCursorPosition): (TextField::setEdited): (TextField::setReadOnly): (TextField::setPlaceholderString): (TextField::setColors): (TextField::sizeForCharacterWidth): (TextField::baselinePosition): (TextField::setLiveSearch): (PopUpButton::PopUpButton): (PopUpButton::~PopUpButton): (PopUpButton::setFont): (PopUpButton::baselinePosition): (PopUpButton::setWritingDirection): (PopUpButton::clear): (PopUpButton::appendItem): (PopUpButton::setCurrentItem): (PopUpButton::sizeHint): (PopUpButton::frameGeometry): (PopUpButton::setFrameGeometry): (ListBox::ListBox): (ListBox::~ListBox): (ListBox::setSelectionMode): (ListBox::setFont): (ListBox::setWritingDirection): (ListBox::clear): (ListBox::doneAppendingItems): (ListBox::setEnabled): (ListBox::appendItem): (ListBox::setSelected): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles): (Image::drawTiled): (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel): (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setValue):

12:39 Changeset [16618] by brmorris

New branch.

11:44 Changeset [16617] by brmorris

2006-09-28 brmorris < bradley.morrison@nokia.com>

Reviewed by Alan.
DESC: parse the description from the commit message
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11050

• svn2ccm.pl: Smarter task synopsis.

11:33 Changeset [16616] by weinig

Reviewed by Tim H.

Patch for  http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
Auto-generate more SVG Objective-C bindings

• Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength, DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString, DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired, DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement, DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, and DOMSVGTransformable.

• Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple parent interfaces and the SVG animated classes.

• Corrects CodeGenerator.pm to only skip the first parent for the main interface.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMSVG.h:
• bindings/scripts/CodeGenerator.pm:
• bindings/scripts/CodeGeneratorObjC.pm:
• ksvg2/svg/SVGAnimatedAngle.idl:
• ksvg2/svg/SVGAnimatedBoolean.idl:
• ksvg2/svg/SVGAnimatedEnumeration.idl:
• ksvg2/svg/SVGAnimatedInteger.idl:
• ksvg2/svg/SVGAnimatedLength.idl:
• ksvg2/svg/SVGAnimatedLengthList.idl:
• ksvg2/svg/SVGAnimatedNumber.idl:
• ksvg2/svg/SVGAnimatedPathData.idl:
• ksvg2/svg/SVGAnimatedString.idl:
• ksvg2/svg/SVGAnimatedTransformList.idl:
• ksvg2/svg/SVGExternalResourcesRequired.idl:
• ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
• ksvg2/svg/SVGFitToViewBox.idl:
• ksvg2/svg/SVGLangSpace.idl:
• ksvg2/svg/SVGLocatable.idl:
• ksvg2/svg/SVGMetadataElement.idl:
• ksvg2/svg/SVGStringList.idl:
• ksvg2/svg/SVGStylable.idl:
• ksvg2/svg/SVGStyleElement.idl:
• ksvg2/svg/SVGTests.idl:
• ksvg2/svg/SVGTransformable.idl:
• ksvg2/svg/SVGURIReference.idl:
• ksvg2/svg/SVGUnitTypes.idl:
• ksvg2/svg/SVGZoomAndPan.idl:

11:24 Changeset [16615] by beidson

Reviewed by Mitz Pettel!!!

Change the error code check for common functions from SQLResultOk to SQLResultDone

• loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetPageURLQuery): (WebCore::IconDatabase::setIconIDForPageURLQuery): (WebCore::IconDatabase::addIconForIconURLQuery):

09:56 Changeset [22255] by aroben

Rubberstamped by sfalken.

Remove calls to DebugBreak() from plugin code.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): (WebCore::PluginViewWin::setValue):

02:13 Changeset [16614] by mjs

Reviewed by Geoff.

• change garbage collection to happen at increments proportional to number of live objects, not always every 1000 allocations

• kjs/collector.cpp: (KJS::Collector::allocate):

02:11 Changeset [16613] by mjs

Reviewed by Mitz.

• fixed REGRESSION (r16606): javascriptCore Crash on website load

Plus style fixes.

• fixed some possible off-by-one bugs
• use indexing, not iterators, for Vectors
• store Vector by pointer instead of by value to avoid blowing out FunctionImp size

• kjs/function.cpp: (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:

01:53 Changeset [22254] by hyatt

Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.

01:49 Changeset [16612] by hyatt

Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.

09/27/06:

23:46 Changeset [16611] by hyatt

Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas. Make sure
selectCursor checks for whether or not a scrollbar was hit. Also stub out a mouseMoved method for
scrollbars to provide hover feedback if needed.

Reviewed by Eric

• page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
• platform/ScrollBar.h: (WebCore::ScrollBar::mouseMoved):

23:32 Changeset [16610] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

Reviewed by Maciej.

More build tweaks

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Removed.

23:29 Changeset [22253] by sfalken

21:56 Changeset [16609] by aroben

2006-09-27 MorganL < morganl.webkit@yahoo.com>

Reviewed by Maciej and Adam, landed by Adam

Fixes:  http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
Windows build is busted

• platform/win/TemporaryLinkStubs.cpp: (ScrollView::paint): (ScrollView::themeChanged):

21:35 Changeset [16608] by sullivan

• kjs/function.cpp: (KJS::FunctionImp::getParameterName): removed assertion that displeased gcc 4.0.1 (build 5420): ASSERT(static_cast<size_t>(index) == index);

19:00 Changeset [16607] by kmccullo

Reviewed by GGaren.

Cleanup of previous fix which was to address Radar: 4752492

• kjs/function.cpp: (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:

17:58 Changeset [16606] by kmccullo

Reviewed by Adele.

Fixes a GC stack overflow crash.
The change is to move from a linked list implementation of Parameters to a Vector.
The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.

• kjs/function.cpp: (KJS::Parameter::Parameter): (KJS::FunctionImp::addParameter): (KJS::FunctionImp::parameterString): (KJS::FunctionImp::processParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
• kjs/function.h:

17:54 Changeset [16605] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

Fix last path fix.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

17:50 Changeset [22252] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

B&I build fixes

• WebCore.vcproj/WebCore.make:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcproj/build-generated-files.sh:

16:55 Changeset [22251] by aroben

Reviewed by sfalken.

Don't die when plugins try to open a new window.

• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Remove call to DebugBreak()

16:48 Changeset [16604] by eseidel

2006-09-27 Eric Seidel < eric@eseidel.com>

Reviewed by mitz.

paths with no fill specified default to black but do not recieve paint-related mouse events
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
The default fill was being applied at the wrong place in the rendering chain, causing this problem.

Test: svg/custom/hover-default-fill.svg

• kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
• ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
• ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): remove null check (WebCore::KSVGPainterFactory::fillPaintServer): remove null check (WebCore::KSVGPainterFactory::isStroked): remove null check (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
• ksvg2/svg/SVGPaint.cpp: (WebCore::SVGPaint::defaultFill): added. (WebCore::SVGPaint::defaultStroke): added.
• ksvg2/svg/SVGPaint.h:

15:57 Changeset [22250] by sfalken

Add missing change log

15:56 Changeset [22249] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

B&I build script tweaks.

15:54 Changeset [16603] by justing

Reviewed by thatcher

< rdar://problem/4044271>
Writing Direction menu doesn't reflect the current writing direction (9773)

• English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
• WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform toggleBaseWritingDirection and changeBaseWritingDirection. Disable the menu item that changes the writing direction to NSWritingDirectionNautral because NSWritingDirectionNatural's behavior can't be implemented with CSS. Take control of the title of the menu item that performs toggleBaseWritingDirection: instead of checking/unchecking it, otherwise we wouldn't know what a check means. (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing direction is not NSWritingDirectionNatural, since we've disabled the menu item that performs it.

15:03 Changeset [22248] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

Reviewed by Hyatt.

Turn on CG

• config.h:

15:02 Changeset [22247] by aroben

Reviewed by Lou.

Fix crash in plugins due to Flash on nytimes.com

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): memset m_stream to 0

15:00 Changeset [16602] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

Set path before build.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

14:53 Changeset [22246] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

B&I build script.

• JavaScriptCore.vcproj/JavaScriptCore.make: Added.

13:29 Changeset [16601] by rwlbuis

Reviewed by eseidel.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
SVG handles em units incorrectly

Calculate viewport coordinates at layout time, since
at this point the font size is known and lengths depending
on font sizes can be calculated correctly.

12:51 Changeset [16600] by seangies

Debug configs should link to debug runtime.

12:29 Changeset [16599] by eseidel

2006-09-27 Eric Seidel < eric@eseidel.com>

Reviewed by darin.

Change our invalid-fill error behavior to match Opera (and soon Firefox)
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11017

• ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::isFilled): (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::isStroked): (WebCore::KSVGPainterFactory::strokePaintServer):

12:07 Changeset [16598] by beidson

Build fix

• loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement):

11:59 Changeset [22245] by aroben

Reviewed by sfalken.

Scroll plugins (at least in some cases).

• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollBy): Pass SW_SCROLLCHILDREN to ScrollWindowEx()

11:47 Changeset [22244] by beidson

11:46 Changeset [16597] by gramps

Reviewed by Adam Roben.

Changed line ending from DOS to UNIX format so it doesn't die running
on my machine. ;)

• JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:

11:20 Changeset [16596] by beidson

WebKit:

Reviewed by Maciej, landed by Brady

Update URL request associated with provisional data source on redirect.
Notify IWebFrameLoadDelegate of redirects for the provisional load.
Notify IWebFrameLoadDelegate of a provisional load being commited.

• COM/WebDataSource.cpp: (WebDataSource::replaceRequest):
• COM/WebDataSource.h:
• COM/WebFrame.cpp: (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData):

WebKitTools:

Reviewed by Maciej, landed by Brady

Fix URL bar updating.

• Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didFinishLoadForFrame):

11:03 Changeset [22243] by sfalken

2006-09-27 Steve Falkenburg < sfalken@apple.com>

Reviewed by Adam.

Fix < rdar://problem/4753220>.
Hang using bugreporter in Boomer.

Force text into simple code path in all cases.

• WebFrame.cpp: (FormValuesPropertyBag::GetPropertyInfo):
• WebPreferences.cpp: (WebPreferences::initialize):

10:59 Changeset [16595] by beidson

WebCore:

Reviewed by Adam

In very specific circumstances, prepared SQLStatements can become invalid without
any warning. This checks for that state and re-prepares the statement and also
adds more aggressive error-checking everywhere these statements are used.

• loader/icon/IconDatabase.cpp: (WebCore::readySQLStatement): Check if the statement is expired - reprepare it (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto (WebCore::IconDatabase::forgetPageURLQuery): Ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto (WebCore::IconDatabase::addIconForIconURLQuery): Ditto (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
• loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
• loader/icon/SQLStatement.h:

08:58 Changeset [22242] by seangies

Add WebCoreSystemInterface.h/cpp to platform/win

09/26/06:

23:55 Changeset [22241] by sfalken

2006-09-26 Steve Falkenburg < sfalken@apple.com>

Build fix for clean release build.

• WebKit.vcproj/WebKitGUID.vcproj:

22:27 Changeset [22240] by aroben

Reviewed by sfalken.

Fixes < rdar://problem/4751600>
Hang on Amazon.com involving Flash

• plugins/win/PluginStreamWin.cpp: Rename m_streamStarted to m_isTerminated to match Mac code (m_isTerminated is the negation of m_streamStarted) (WebCore::PluginStreamWin::PluginStreamWin): Initialize m_isTerminated to false to match Mac code. (WebCore::PluginStreamWin::~PluginStreamWin): Rename and negate. (WebCore::PluginStreamWin::stop): Remove assignment of m_streamStarted to match Mac code. (WebCore::PluginStreamWin::startStream): Rename and negate. Remove now-unnecessary assignment of m_streamStarted to true because we set m_isTerminated to false in the constructor. (WebCore::PluginStreamWin::destroyStream): Rename and negate.
• plugins/win/PluginStreamWin.h: Rename m_streamStarted to m_isTerminated.
• plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): Send the correct response URL to the plugin.

17:56 Changeset [16594] by darin

Reviewed by Steve.

• clean up options for font code path

• platform/Font.h:
• platform/Font.cpp: (WebCore::Font::setCodePath): Added. Replaces boolean version. (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.

• platform/mac/WebCoreTextRenderer.mm: (WebCoreSetAlwaysUseATSU): Change to call setCodePath.

17:47 Changeset [22239] by beidson

Disabled icondatabase for now

17:45 Changeset [22238] by sfalken

Build tweaks

16:44 Changeset [16593] by sullivan

WebCore:

Reviewed by Darin

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed down to Frame

• page/Frame.h:
• page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Added limit parameter. Stop the search if it hits limit.

WebKit:

Reviewed by Darin

• WebView/WebHTMLViewPrivate.h:
• WebView/WebHTMLView.m: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Added limit parameter, passed over the bridge. Stop the search if it hits limit.

• WebView/WebViewPrivate.h:
• WebView/WebView.m: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): Added limit parameter, passed to WebHTMLView.

16:28 Changeset [22237] by seangies

Handle tiled images correctly.

16:26 Changeset [16592] by seangies

Removed #if's.

15:15 Changeset [22236] by sfalken

2006-09-26 Steve Falkenburg < sfalken@apple.com>

Reviewed by Adam Roben.

Fixed encoding menu.
Set mime type in request.

• WebFrame.cpp: (WebFrame::receivedResponse):
• WebView.cpp: (WebView::setCustomTextEncodingName):

14:54 Changeset [16591] by yongjzha

2006-09-26 yongjzha < yongjun.zhang@nokia.com>

Reviewed by Sachin
DESC:
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11048

• BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
• BrowserView/inc/WebKitControl.h:
• BrowserView/inc/WebKitSurface.h: (CWebKitSurface::OffscreenBitmap): (CWebKitSurface::CurrentView): (CWebKitSurface::SetCurrentView): (CWebKitSurface::DisplayMode):
• BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL):
• BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
• BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::AutoScroll):
• BrowserView/src/WebKitControl.cpp: (CStaticObjectContainer::SurfaceL): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::OpenPageViewL): (CWebKitControl::ClosePageView): (CWebKitControl::CancelPageView):
• BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ScrollTo):
• BrowserView/src/WebKitSurface.cpp: (CWebKitSurface::NewL): (CWebKitSurface::~CWebKitSurface): (CWebKitSurface::CWebKitSurface): (CWebKitSurface::ConstructL): (CWebKitSurface::Flip):
• BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::SetViewVisible): (CWebKitView::SizeChanged): (CWebKitView::ImageDecodeEvent): (CWebKitView::ProgressAndImageDecodeComplete):
• BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged):

14:44 Changeset [22235] by beidson

Nuked another NotImplemented()

14:04 Changeset [22234] by seangies

Link to debug libraries & C-runtime in debug config.

14:01 Changeset [22233] by lamadio

2006-09-26 Lou Amadio < lamadio@apple.com>

Reviewed by ggaren
Uninitialized variable caused a memory corruption on cnn.com

12:58 Changeset [16590] by thatcher

Removing bad tag.

12:58 Changeset [16589] by thatcher

Build fix and versioning.

12:56 Changeset [16588] by thatcher

New tag part 2.

12:56 Changeset [16587] by justing

LayoutTests:

Reviewed by john

< rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

• editing/deleting/list-item-1-expected.checksum: Added.
• editing/deleting/list-item-1-expected.png: Added.
• editing/deleting/list-item-1-expected.txt: Added.
• editing/deleting/list-item-1.html: Added.
• editing/execCommand/remove-list-item-1-expected.checksum: Added.
• editing/execCommand/remove-list-item-1-expected.png: Added.
• editing/execCommand/remove-list-item-1-expected.txt: Added.
• editing/execCommand/remove-list-item-1.html: Added.

WebCore:

Reviewed by john

< rdar://problem/4747695>
Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent

• editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding to select special elements that are fully selected after expansion moves to positions that are visually distinct from the originals.
• editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): If the content of the list item will be moved into another list, put it in a list item.

12:19 Changeset [16586] by harrison

LayoutTests:

Reviewed by John and TimH.

< rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

• editing/pasteboard/emacs-cntl-y-001-expected.checksum: Added.
• editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
• editing/pasteboard/emacs-cntl-y-001-expected.txt: Added.
• editing/pasteboard/emacs-cntl-y-001.html: Added.

WebKit:

Reviewed by John and TimH.

< rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty

Use deleteBackward: when the killring string is empty. Was always using insertText:,
but that ends up early-returning if the string to insert is empty.

• WebView/WebHTMLView.m: (-[NSArray yank:]): (-[NSArray yankAndSelect:]):

12:14 Changeset [22232] by sfalken

2006-09-26 Steve Falkenburg < sfalken@apple.com>

Reviewed by Geoff.

Don't add subframes to global history or back/forward.

• WebFrame.cpp: (WebFrame::receivedAllData): (WebFrame::createFrame):

10:12 Changeset [16585] by ggaren

Reviewed by Darin.

Temporary work-around for frame lifetime issue.

• page/Frame.cpp: (WebCore::Frame::clear): (WebCore::Frame::disconnectOwnerElement):

09:58 Changeset [16584] by thatcher

Versioning

09:57 Changeset [16583] by thatcher

Build fix.

09:56 Changeset [16582] by thatcher

New tag part 2.

09:55 Changeset [16581] by thatcher

New tag part 1.

09:54 Changeset [16580] by thatcher

New tag part 2.

09:54 Changeset [16579] by thatcher

New tag part 1.

06:44 Changeset [16578] by weinig

Reviewed by Tim H.

Patch for  http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
Auto-generate DOMSVGElement for the Objective-C bindings

• Auto-generates DOMSVGElement.

• Make SVGExceptions work like all the other ExceptionCode extensions (Range, XPath, etc.) by adding SVGExceptionOffset and SVGExceptionMax.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException):
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMInternal.mm: (raiseDOMException):
• bindings/objc/DOMSVG.h:
• bindings/objc/DOMSVGExecption.h: Added.
• ksvg2/ksvg.h:
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::setId): (WebCore::SVGElement::setXmlbase):
• ksvg2/svg/SVGElement.h:
• ksvg2/svg/SVGElement.idl:
• ksvg2/svg/SVGException.h: Added. (WebCore::):

06:26 Changeset [16577] by eseidel

2006-09-26 Eric Seidel < eric@eseidel.com>

Reviewed by anders.

• projects/svg/status.xml: update status to reflect current state of SVG development

06:08 Changeset [16576] by eseidel

2006-09-26 Eric Seidel < eric@eseidel.com>

Reviewed by Tim H.

viewbox parser does not allow <tab> as a delimiter
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11014

Test: svg/hixie/viewbox/003.xml

• ksvg2/svg/svgpathparser.cpp: (WebCore::isWhitespace): new function (WebCore::skipOptionalSpaces): (WebCore::skipOptionalSpacesOrComma):

05:56 Changeset [16575] by eseidel

2006-09-26 Eric Seidel < eric@eseidel.com>

Reviewed by Tim H.

SVGDocument::createElement does not create elements in the SVG namespace
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10932

Test: svg/custom/createelement.svg

• ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::createElement):
• ksvg2/svg/SVGDocument.h:

05:50 Changeset [16574] by eseidel

2006-09-26 Eric Seidel < eric@eseidel.com>

Reviewed by Tim H.

RenderPath::nodeAtPoint does not respect stroke width
 http://bugzilla.opendarwin.org/show_bug.cgi?id=10829

Test: svg/custom/stroke-width-click.svg

• kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeContains):
• kcanvas/device/quartz/QuartzSupport.h:
• kcanvas/device/quartz/QuartzSupport.mm:

05:41 Changeset [16573] by eseidel

Remove stray LayoutTests directory.

05:33 Changeset [16572] by eseidel

2006-09-26 Eric Seidel < eric@eseidel.com>

Reviewed by mitz.

Bring animation back to life
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11021

Register/unregister SVGSVGElements as time containers on insertion/removal.
Replace uses of DeprecatedString with String in SVGAnimationElement
Various whitespace clean-up.

• ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
• ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::startAnimations): (WebCore::SVGDocumentExtensions::pauseAnimations): (WebCore::SVGDocumentExtensions::unpauseAnimations):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue):
• ksvg2/svg/SVGAnimateTransformElement.h:
• ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::targetAttribute): (WebCore::SVGAnimationElement::setTargetAttribute): (WebCore::SVGAnimationElement::attributeName):
• ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::rendererIsNeeded):
• ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer): (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this) (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
• ksvg2/svg/SVGSVGElement.h:
• ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
• ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
• ksvg2/svg/SVGURIReference.h:

04:27 Changeset [16571] by bdash

2006-09-26 Graham Dennis < graham.dennis@gmail.com>

Reviewed by mitzpettel.

• fix  http://bugzilla.opendarwin.org/show_bug.cgi?id=11020 No-SVG build broken since r16549

Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT

• css/cssparser.cpp: (WebCore::CSSParser::parseValue):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• page/FrameView.cpp: (WebCore::selectCursor):
• platform/qt/GraphicsContextQt.cpp:

04:11 Changeset [16570] by hyatt

Fix win32 build bustage with StringImpl's toDouble method.

04:09 Changeset [22231] by hyatt

Scrollbar cleanup. Fix up invalidation and rect handling.

01:51 Changeset [22230] by hyatt

Implement scrollbar painting and theme changing support.

01:30 Changeset [16569] by hyatt

Land groundwork for handling theme changes.

00:36 Changeset [16568] by andersca

2006-09-26 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

 http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()

(Originally written by Eric Seidel).

• bindings/js/kjs_window.cpp: (KJS::floatFeature):
• ksvg2/svg/SVGAngle.cpp: (SVGAngle::setValueAsString):
• ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
• ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::parseMappedAttribute):
• ksvg2/svg/SVGFECompositeElement.cpp: (WebCore::SVGFECompositeElement::parseMappedAttribute):
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
• ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::parseMappedAttribute):
• ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::parseMappedAttribute):
• ksvg2/svg/SVGFEOffsetElement.cpp: (WebCore::SVGFEOffsetElement::parseMappedAttribute):
• ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::parseMappedAttribute):
• ksvg2/svg/SVGFETurbulenceElement.cpp: (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
• ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
• platform/AtomicString.h: (WebCore::AtomicString::toDouble):
• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::toDouble):
• platform/StringImpl.cpp: (WebCore::StringImpl::toDouble):
• platform/StringImpl.h:
• rendering/DeprecatedSlider.cpp: (WebCore::DeprecatedSlider::updateFromElement):
• xml/XPathGrammar.y:

09/25/06:

18:14 Changeset [16567] by harrison

Reviewed by Tim Omernick and Tim Hatcher.

< rdar://problem/4717965> Text Field text parameterized attributes should work
< rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements

• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.

(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Cleaned up. Added text field and text area parameterzed attributes.

(-[WebCoreAXObject doAXLineForTextMarker:]):
Fixed to be zero-based and to deal with the first position properly.

(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Minor formatting.

(-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
(-[WebCoreAXObject indexForTextMarker:]):
(-[WebCoreAXObject textMarkerRangeForRange:]):
(-[WebCoreAXObject rangeForTextMarkerRange:]):
New utility methods.

(-[WebCoreAXObject doAXLineForIndex:]):
(-[WebCoreAXObject doAXRangeForLine:]):
(-[WebCoreAXObject doAXStringForRange:]):
(-[WebCoreAXObject doAXRangeForPosition:]):
(-[WebCoreAXObject doAXRangeForIndex:]):
(-[WebCoreAXObject doAXBoundsForRange:]):
(-[WebCoreAXObject doAXAttributedStringForRange:]):
(-[WebCoreAXObject doAXRTFForRange:]):
(-[WebCoreAXObject doAXStyleRangeForIndex:]):
Implement text field and text area parameterized attributes.

(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Added text field and text area parameterzed attributes.

• rendering/RenderTextControl.h: Made indexForVisiblePosition() and visiblePositionForIndex() public.

18:10 Changeset [22229] by aroben

Setting svn:eol-style to native on all Windows-only files.

18:05 Changeset [22228] by aroben

Rubberstamped by sfalken.

Set svn:eol-style to native and cleanup line endings on plugins files.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):

17:58 Changeset [22227] by aroben

Reviewed by Brady.

Fixes < rdar://problem/4749494>
Crash/ASSERT in plugins at Fark.com

• platform/win/ResourceLoaderWin.cpp: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job. (WebCore::ResourceLoaderWndProc): Ask the job whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.

17:57 Changeset [16566] by aroben

Reviewed by Brady.

Build fixes.

• WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
• platform/ResourceLoader.h: Store whether a particular job has received a response within the ResourceLoader object itself, since it's possible that we will enter the InternetReadFileExA while loop twice for the same job.
• platform/ResourceLoaderInternal.h: Add private instance variable to store whether we've received a response. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
• platform/win/GraphicsContextWin.cpp: Fix order of preprocessor directives.
• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader whether it has received a response instead of assuming it hasn't. (WebCore::ResourceLoader::setHasReceivedResponse): Added. (WebCore::ResourceLoader::hasReceivedResponse): Added.
• platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to setProportion (ScrollBar::setProportion):

17:42 Changeset [22226] by aroben

Rubberstamped by sfalken.

Continuing the removal of unnecessary notImplemented() calls.

• platform/win/TemporaryLinkStubs.cpp: (PlatformMouseEvent::PlatformMouseEvent): (FrameWin::passWheelEventToChildWidget):

17:33 Changeset [16565] by beidson

Requested by ggaren

Disabled IconDatabase logging by default

• platform/Logging.cpp: (WebCore::):

16:43 Changeset [16564] by sfalken

2006-09-25 Steve Falkenburg < sfalken@apple.com>

Reviewed by Jeff Jenkins.

Tweak CF types.

• platform/cf/ResourceLoaderCFNet.cpp: (WebCore::willCacheResponse):

15:30 Changeset [22225] by sfalken

2006-09-25 Steve Falkenburg < sfalken@apple.com>

Add missing parameters to CG paint case.

• WebFrame.cpp: (WebFrame::paint):

14:59 Changeset [16563] by justing

LayoutTests:

Reviewed by john

• editing/execCommand/indent-empty-root-expected.checksum: Added.
• editing/execCommand/indent-empty-root-expected.png: Added.
• editing/execCommand/indent-empty-root-expected.txt: Added.
• editing/execCommand/indent-empty-root.html: Added.

WebCore:

Reviewed by john

< http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message

• editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::indentRegion): Special case an empty root editable element.

14:57 Changeset [22224] by aroben

Rubberstamped by sfalken.

More notImplemented()-ectomy.

• platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addSeparator): (RenderPopupMenuWin::addGroupLabel):

14:45 Changeset [22223] by aroben

Rubberstamped by sfalken.

Remove calls to notImplemented() from functions that can fail safely.

• platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): (FrameWin::isLoadTypeReload): (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):

14:40 Changeset [16562] by beidson

Math error in SystemTimeWin

14:31 Changeset [16561] by thatcher

Build fix to avoid property name conflict warning.

14:30 Changeset [22222] by aroben

Rubberstamped by sfalken.

Make notImplemented() crash even when not linked against the debug CRT.

• platform/win/TemporaryLinkStubs.cpp: (notImplemented): Change _CrtDbgBreak() to ASSERT(0)

13:41 Changeset [16560] by ap

Reviewed by Eric.

Whitespace cleanup; rename *job variables to *loader.

• bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct): (KJS::JSXMLHttpRequestConstructorImp::construct): (KJS::JSXMLHttpRequest::getOwnPropertySlot): (KJS::JSXMLHttpRequest::getValueProperty): (KJS::JSXMLHttpRequest::put): (KJS::JSXMLHttpRequest::putValueProperty): (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
• bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::toBoolean):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedData):
• xml/xmlhttprequest.h: (WebCore::):

12:04 Changeset [16559] by thatcher

WebCore:

Reviewed by Brady.

• Deprecate the rest of the old-style methods that are not generated.
• Add @property syntax to DOMRange.

• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm: (-[DOMRange setStart:offset:]): (-[DOMRange setEnd:offset:]): (-[DOMRange compareBoundaryPoints:sourceRange:]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange compareBoundaryPoints::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]):
• bindings/objc/DOMCSS.h:
• bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle:pseudoElement:]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
• bindings/objc/DOMExtensions.h:
• bindings/objc/DOMHTML.h:
• bindings/objc/DOMRange.h:
• bindings/objc/DOMTraversal.h:

WebKit:

Reviewed by Brady.

Use the non-deprecated method names for getComputedStyle, setEnd and setStart.

• WebInspector/WebInspector.m: (-_highlightNode:):
• WebView/WebHTMLView.m: (unionDOMRanges): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]):
• WebView/WebView.m: (-[WebView computedStyleForElement:pseudoElement:]):

10:37 Changeset [16558] by thatcher

Build fix.

02:52 Changeset [16557] by eseidel

2006-09-25 Eric Seidel < eric@eseidel.com>

Reviewed by mjs.

Outermost <svg> element should clip to viewport
 http://bugzilla.opendarwin.org/show_bug.cgi?id=11007

Test: svg/custom/viewport-clip.svg

• css/svg.css: change svg:root overflow: from 'visible' to 'hidden'

01:08 Changeset [16556] by andersca

2006-09-25 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

• css/MediaList.cpp: Remove unused header.

• dom/Document.cpp: (WebCore::Document::clear): Use clear instead of iterating through the list of event listeners, removing each one. (Doing that causes a crash when running the layout tests with GuardMalloc turned on)

• html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::HTMLKeygenElement): (WebCore::HTMLKeygenElement::appendFormData): Update due to changes in the SSL key generator.

• ksvg2/svg/SVGAngle.cpp: Remove unused header.

• ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute): Rename methods and pass Strings instead of DeprecatedStrings to parseSeparatedList.

• ksvg2/svg/SVGFEColorMatrixElement.cpp:
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
• ksvg2/svg/SVGFEDisplacementMapElement.cpp:
• ksvg2/svg/SVGFEMergeElement.cpp:
• ksvg2/svg/SVGFEOffsetElement.cpp: Remove unused headers.

• ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::parseSeparatedList):
• ksvg2/svg/SVGHelper.h: Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.

• ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::parse):
• ksvg2/svg/SVGLengthList.h: Use Vector<String> instead of DeprecatedStringList.

• loader/Cache.cpp: (WebCore::Cache::requestImage): (WebCore::Cache::requestStyleSheet): (WebCore::Cache::requestScript): (WebCore::Cache::requestXSLStyleSheet): (WebCore::Cache::requestXBLDocument): (WebCore::Cache::remove): (WebCore::Cache::get): Use a String as the key in the cache set instead of a RefPtr<StringImpl>.

• loader/DocLoader.cpp: (WebCore::DocLoader::needReload):
• loader/DocLoader.h: Use a HashSet instead of DeprecatedStringList.

• page/FrameView.h: Remove declarations that have no functions.

• platform/SSLKeyGenerator.h:
• platform/mac/SSLKeyGeneratorMac.mm: (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString): Convert to use Vector<String> instead of DeprecatedStringList, and String instead of DeprecatedString.

01:07 Changeset [22221] by hyatt

Fix win32 cursor build bustage. Fix my own build bustage from the shifting around of the cairo/win get/ReleaseWindowsContext calls.

01:06 Changeset [16555] by hyatt

Fix win32 cursor build bustage.

00:39 Changeset [16554] by hyatt

Cleanup in RenderThemeWin and GraphicsContextCairo/Win