Context Navigation

← Previous Period
Next Period →

Timeline

Oct 9, 2006:

11:51 PM Changeset in webkit [16961] by mjs

4 edits in trunk/WebKit

Reviewed by Anders.

sever final WebFrame dependencies

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader checkLoadComplete]):

11:12 PM Changeset in webkit [16960] by mjs

6 edits in trunk/WebKit

Reviewed by Brady.

convert more WebFrameLoader stuff to be independent of WebFrame

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader client]):
Loader/WebFrameLoaderClient.h:
WebView/WebDataSource.m: (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
WebView/WebFrame.m: (-[WebFrame _dispatchCreateWebViewWithRequest:]):

10:14 PM Changeset in webkit [16959] by mjs

6 edits in trunk/WebKit

Reviewed by Anders and Oliver.

move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadRequest:]): (-[WebFrameLoader loadRequest:inFrameNamed:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _hasFrameView]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _didFinishLoad]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _provisionalLoadStarted]):
WebView/WebFrameInternal.h:

9:04 PM Changeset in webkit [22345] by beidson

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve

<rdar://4721579> - WebPreferences for IconDatabase hooked up
This completes the above task by implementing the icon database location preference

WebIconDatabase.cpp: (WebIconDatabase::init): Get the location from the prefs, fallback to the default via shell call
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::iconDatabaseLocation): (WebPreferences::setIconDatabaseLocation):

8:16 PM Changeset in webkit [16958] by mjs

1 edit
2 adds in trunk/WebKit

Not reviewed, build fix.

added forgotten files

Loader/WebPolicyDecider.h: Added.
Loader/WebPolicyDecider.m: Added. (-[WebPolicyDecider invalidate]):

7:41 PM Changeset in webkit [16957] by mjs

6 edits
2 adds in trunk/WebKit

Reviewed by Brady.

add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
Loader/WebFrameLoaderClient.h:
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m: (-[WebFrame _createPolicyDeciderWithTarget:action:]): (decisionListener): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
WebView/WebPolicyDeciderMac.h: Added.
WebView/WebPolicyDeciderMac.m: Added. (-[WebPolicyDeciderMac initWithTarget:action:]): (-[WebPolicyDeciderMac dealloc]): (-[WebPolicyDeciderMac decisionListener]): (-[WebPolicyDeciderMac invalidate]):

7:10 PM Changeset in webkit [16956] by beidson

5 edits
1 add in trunk/WebKit

Reviewed by John

http://bugs.webkit.org/show_bug.cgi?id=11195
Added the WebIconDatabaseDelegate. This allows the ability to allow customization of
IconDatabase behavior in the future, starting now with the ability to override the
default icon fairly flexibly

Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase delegate]):
Misc/WebIconDatabaseDelegate.h: Added.
Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
WebKit.xcodeproj/project.pbxproj:

6:52 PM Changeset in webkit [16955] by aroben

2 edits in trunk/WebCore

Backing out accidental commit.

page/Frame.cpp: (WebCore::Frame::finishedParsing):

6:49 PM Changeset in webkit [16954] by aroben

11 edits in trunk/WebCore

Reviewed by Darin.

Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
this could cause recursive calls to the destructor. RefPtr now also
inherits from Noncopyable.

dom/NodeFilter.h:
dom/Traversal.h:
page/DOMWindow.h:
page/Frame.cpp: (WebCore::Frame::finishedParsing):
page/Frame.h:
page/Plugin.h:
platform/FontFallbackList.h:
platform/Icon.h:
platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount):
platform/StringImpl.h:

6:30 PM Changeset in webkit [16953] by darin

7 edits in trunk/WebKit

Reviewed by Maciej.

eliminated uses of WebResource and WebView from WebFrameLoader

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): (-[WebFrameLoader _canShowMIMEType:]): (-[WebFrameLoader _representationExistsForURLScheme:]): (-[WebFrameLoader _generatedMIMETypeForURLScheme:]): (-[WebFrameLoader loadDocumentLoader:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
Loader/WebFrameLoaderClient.h:
Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader loadWithRequestNow:]):
WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame _canUseResourceForRequest:]): (-[WebFrame _canUseResourceWithResponse:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _setDefersCallbacks:]): (-[WebFrame _canHandleRequest:]): (-[WebFrame _canShowMIMEType:]): (-[WebFrame _representationExistsForURLScheme:]): (-[WebFrame _generatedMIMETypeForURLScheme:]): (-[WebFrame _elementForEvent:]):

6:09 PM Changeset in webkit [16952] by oliver

10 edits in trunk/WebCore

2006-10-09 Oliver Hunt <ohunt@apple.com>

Reviewed by Anders.

Correcting ifdef's

html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop):
html/CanvasGradient.h:
html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern):
html/CanvasPattern.h:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
html/CanvasRenderingContext2D.h:
html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext):
html/HTMLCanvasElement.h:

6:04 PM Changeset in webkit [16951] by mjs

3 edits in trunk/WebKit

Reviewed by Darin.

do all the stuff that setting the referrer should

Loader/WebFrameLoader.m: (setHTTPReferrer): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebKit.xcodeproj/project.pbxproj:

5:53 PM Changeset in webkit [16950] by mjs

1 edit
3 adds in trunk/LayoutTests

Reviewed by Darin.

test case that ensures Referer[sic] header is sent

http/tests/misc/referrer-expected.txt: Added.
http/tests/misc/referrer.html: Added.
http/tests/misc/resources/referrer-result.php: Added.

5:38 PM Changeset in webkit [22344] by andersca

8 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Fix <rdar://problem/4756255>
PDF/Acrobat Reader plugin don't work

bridge/win/FrameWin.cpp: (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): Implement these, getting the instance from the plugin view.

platform/win/TemporaryLinkStubs.cpp: Remove functions that are now implemented.

plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): Implement this, returning whether we a plugin exists for a given mime type.

plugins/win/PluginDatabaseWin.cpp: (WebCore::parseVersionString): (WebCore::compareVersions): New functions for handling versions.

(WebCore::addMozillaPluginPaths):
(WebCore::addWindowsMediaPlayerPluginPath):
(WebCore::addQuickTimePluginPath):
(WebCore::addJavaPluginPath):
(WebCore::addAdobeAcrobatPluginPath):
(WebCore::PluginDatabaseWin::defaultPluginPaths):
Factor out checks into separate functions, add checks for Java and Adobe Acrobat.

(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
Handle null MIME types.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Add some missing functions. Unload the library if the load failed.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): Uncomment code for getting the element object.

(WebCore::PluginViewWin::bindingInstance):

plugins/win/PluginViewWin.h: New function which fetches the plugin NPObject and wraps it in an instance.

5:05 PM Changeset in webkit [16949] by aroben

2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merge r16948 to tag.

4:57 PM Changeset in webkit [16948] by aroben

2 edits in trunk/WebCore

Reviewed by Maciej.

Fix a possible recursive destructor call.

page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed.

4:49 PM Changeset in webkit [16947] by weinig

42 edits
2 adds in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
Assorted Objective-C bindings changes

Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.

Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement.

Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker)

Put more methods in the WebCore namespace and factor out the displayString method into DOMInternal.h as done by Darin in his patch for http://bugs.webkit.org/show_bug.cgi?id=11219.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]):
bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString):
bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]):
bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
bindings/objc/DOMSVG.h:
bindings/objc/DOMSVGPathSegInternal.h: Added.
bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/NodeIterator.idl:
dom/TreeWalker.idl:
html/HTMLInputElement.idl:
html/HTMLObjectElement.idl:
ksvg2/svg/SVGDocument.idl:
ksvg2/svg/SVGElement.idl:
ksvg2/svg/SVGPathSeg.idl:
ksvg2/svg/SVGPathSegArcAbs.idl:
ksvg2/svg/SVGPathSegArcRel.idl:
ksvg2/svg/SVGPathSegClosePath.idl:
ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
ksvg2/svg/SVGPathSegLinetoAbs.idl:
ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
ksvg2/svg/SVGPathSegLinetoRel.idl:
ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
ksvg2/svg/SVGPathSegMovetoAbs.idl:
ksvg2/svg/SVGPathSegMovetoRel.idl:

4:28 PM Changeset in webkit [16946] by bdash

2 edits in trunk/WebCore

2006-10-09 Don Gibson <dgibson77@gmail.com>

Unreviewed build fix.

Fix windows build bustage.

platform/win/TemporaryLinkStubs.cpp:

4:08 PM Changeset in webkit [16945] by bdash

15 edits in trunk

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler flags (show warning, no rtti and exceptions).

jscore.bkl:

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler options.

Bakefiles.bkgen:
presets.bkl:

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Fix memory leaks discovered via valgrind. Gdk build fixes.

Projects/gdk/webcore-gdk.bkl:
make-generated-sources.sh:
platform/cairo/ImageCairo.cpp: (WebCore::Image::draw):
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
platform/gdk/FrameGdk.h:
platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):

2006-10-09 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Geoff.

Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
a page. This allows automatic testing via e.g. valgrind.

GdkLauncher/gdklauncher.bkl:
GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (LauncherFrameGdk::setExitAfterLoading): (LauncherFrameGdk::handledOnloadEvents): (handle_event): (main):

3:36 PM Changeset in webkit [16944] by bdash

2 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Beth.

Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.

platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage):

3:34 PM Changeset in webkit [16943] by bdash

2 edits in trunk/LayoutTests

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Use log() instead of alert() just like in all other tests.

editing/selection/move-begin-end.html:

3:30 PM Changeset in webkit [16942] by bdash

4 edits in trunk/WebCore

2006-10-09 Nikolas Zimmermann <zimmermann@kde.org>

Unreviewed build fix.

Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.

platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget):
platform/qt/FrameQt.h:
platform/qt/TemporaryLinkStubs.cpp:

3:24 PM Changeset in webkit [16941] by beidson

6 edits in trunk

WebCore:

Reviewed by Maciej

Tiny changes to help reorganize WebFrameLoader code in WebKit

bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side

WebKit:

Reviewed by Maciej

Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader

Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge createInstance]):

2:44 PM Changeset in webkit [16940] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

(Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)

avoid a needless use of WebFrame

Loader/WebFrameLoader.m: (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):

2:36 PM Changeset in webkit [16939] by yongjzha

3 edits in S60/trunk/WebKit

2006-10-09 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Fix issues with touch support

Activate an element only if it received both down and up pointer events
Fix coordinates calculation in frames while zooming
Update cursor in each touch event, to give user the correct feedback

http://bugs.webkit.org/show_bug.cgi?id=11229

BrowserView/inc/PointerEventHandler.h:
BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL):

1:27 PM Changeset in webkit [16938] by beidson

2 edits in trunk/WebKit

A *real* fake fix for the layouttest problem until the real fix

Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):

1:15 PM Changeset in webkit [16937] by beidson

2 edits in trunk/WebKit

Quick layouttest fix until I make the real fix

Loader/WebFrameLoader.m:

1:06 PM Changeset in webkit [16936] by mjs

7 edits in trunk/WebKit

Reviewed by Darin.

wean WebFrameLoader from WebDataSource private stuff

(actually just tweaks tot he above to make merging my future
patches easier since Darin did a lot of the same stuff)

Loader/WebDocumentLoader.h:
Loader/WebDocumentLoader.m: (-[WebDocumentLoader URLForHistory]):
Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
Loader/WebFrameLoaderClient.h:
WebView/WebDataSource.m: (-[WebDataSource _URLForHistory]):
WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]):

12:31 PM Changeset in webkit [16935] by darin

7 edits in trunk/WebKit

Reviewed by Brady.

eliminated WebFrameLoader dependency on WebDataSourceInternal.h, WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with most but not all references to WebView

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader handleUnimplementablePolicyWithError:]): (-[WebFrameLoader cannotShowMIMETypeWithResponse:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader checkLoadComplete]):
Loader/WebFrameLoaderClient.h:
Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _formDelegate]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _revertToProvisionalWithDocumentLoader:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _URLForHistoryForDocumentLoader:]): (-[WebFrame _cancelledErrorWithRequest:]): (-[WebFrame _cannotShowURLErrorWithRequest:]): (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]): (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]): (-[WebFrame _fileDoesNotExistErrorWithResponse:]): (-[WebFrame _shouldFallBackForError:]): (-[WebFrame _hasWebView]): (-[WebFrame _mainFrameURL]):
WebView/WebFrameInternal.h:

11:50 AM Changeset in webkit [22343] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Steve.

Fix <rdar://problem/4773320>
Safari didn't pick up quicktime that was already installed

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths):

11:43 AM Changeset in webkit [16934] by aroben

2 edits in tags/Safari-521.28b/WebCore

Reviewed by Steve.

Merging r16932 to tag.

11:41 AM Changeset in webkit [16933] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix.

11:30 AM Changeset in webkit [22342] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fixes <rdar://problem/4773142>
Crash in Settings::mediumFontSize() on ebay.com

Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
end up calling the Frame::saveDocumentState, which is pure virtual.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):

11:29 AM Changeset in webkit [16932] by aroben

2 edits in trunk/WebCore

Reviewed by Adele.

Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
already called frome ~FrameMac.

page/Frame.cpp: (WebCore::Frame::~Frame):

11:29 AM Changeset in webkit [16931] by darin

7 edits in trunk/WebKit

Reviewed, landed, tweaked a bit by Darin.

removed most uses of WebFrameBridge from WebFrameLoader (WebCoreFrameBridge use is OK)

Loader/WebDocumentLoader.m: (-[WebDocumentLoader bridge]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
WebView/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]):
WebView/WebFrameInternal.h:

11:28 AM Changeset in webkit [22341] by andersca

3 edits in branches/WindowsMerge/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Fix build.

11:04 AM Changeset in webkit [16930] by darin

6 edits in trunk/WebKit

Reviewed by Brady.

removed almost all direct use of WebView from WebFrameLoader

Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
Loader/WebFrameLoaderClient.h:
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m: (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _hasBackForwardList]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]): (-[WebFrame _progressStarted]): (-[WebFrame _progressCompleted]): (-[WebFrame _incrementProgressForIdentifier:response:]): (-[WebFrame _incrementProgressForIdentifier:data:]): (-[WebFrame _completeProgressForIdentifier:]): (-[WebFrame _setMainFrameDocumentReady:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _startDownloadWithRequest:]):

10:47 AM Changeset in webkit [16929] by andersca

2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

bridge/win/FrameWin.h: Add function declaration.

10:35 AM Changeset in webkit [16928] by andersca

2 edits in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build.

10:21 AM Changeset in webkit [16927] by andersca

6 edits
2 deletes in trunk/WebCore

2006-10-09 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Move applet widget creation to Frame and get rid of JavaAppletWidget.

WebCore.xcodeproj/project.pbxproj:
bridge/JavaAppletWidget.h: Removed.
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget):
bridge/mac/JavaAppletWidget.mm: Removed.
page/Frame.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):

2:53 AM Changeset in webkit [16926] by mjs

7 edits
2 adds in trunk/WebKit

Reviewed by Alice.

moved WebFormState into Loader directory and tweaked to void WebKit dependencies

Loader/WebDocumentLoader.h:
Loader/WebFormState.h: Added.
Loader/WebFormState.m: Added. (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState dealloc]): (-[WebFormState form]): (-[WebFormState values]): (-[WebFormState sourceFrame]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m:
WebView/WebFrameInternal.h:

2:29 AM Changeset in webkit [16925] by bdash

2 edits
1 add
1 delete in trunk/WebCore

2006-10-09 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11220 Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276

Subversion does not support resource forks and HFS metadata, so
the resources for this test need to be on a disk image.

manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
manual-tests/resources/plain-text-paste.dmg: Added.
manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
manual-tests/resources/plain-text-paste/._4.txt: Removed.
manual-tests/resources/plain-text-paste/._5.webloc: Removed.
manual-tests/resources/plain-text-paste/1.textClipping: Removed.
manual-tests/resources/plain-text-paste/2.textClipping: Removed.
manual-tests/resources/plain-text-paste/3.gif: Removed.
manual-tests/resources/plain-text-paste/4.txt: Removed.
manual-tests/resources/plain-text-paste/5.webloc: Removed.

2:09 AM Changeset in webkit [16924] by mjs

3 edits in trunk/WebKit

Reviewed by Oliver.

remove dependency on WebNSURLRequestExtras.h

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):

1:59 AM Changeset in webkit [16923] by mjs

2 edits in trunk/WebKit

Reviewed by Oliver.

removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency

Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):

1:44 AM Changeset in webkit [16922] by mjs

10 edits in trunk/WebKit

Reviewed by Oliver.

remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)

Loader/WebDocumentLoader.h:
Loader/WebDocumentLoader.m: (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader initialRequest]): (-[WebDocumentLoader URL]): (-[WebDocumentLoader unreachableURL]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _URL]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader safeLoadURL:]):
Loader/WebFrameLoaderClient.h:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge originalRequestURL]):
WebView/WebDataSource.m: (-[WebDataSource _URL]): (-[WebDataSource dealloc]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _forceLayoutForNonHTML]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]): (-[WebFrame _makeRepresentationForDocumentLoader:]):

12:40 AM Changeset in webkit [16921] by rwlbuis

31 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in filter classes.

12:36 AM Changeset in webkit [16920] by rwlbuis

24 edits in trunk/WebCore

Reviewed by olliej.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in SVGPath* classes.

12:32 AM Changeset in webkit [16919] by mjs

4 edits in trunk/WebKit

Reviewed by Darin.

removed need for WebFrameLoader to now about WebDocumentLoaderMac

Loader/WebFrameLoader.m: (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac setFrameLoader:]): (-[WebDocumentLoaderMac detachFromFrameLoader]):

12:27 AM Changeset in webkit [16918] by rwlbuis

15 edits in trunk/WebCore

Reviewed by aroben.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg shape classes.

12:23 AM Changeset in webkit [16917] by darin

4 edits in trunk/WebKit

Reviewed by Maciej.

passed calls that require WebScriptDebugServer across the client interface

Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):

12:03 AM Changeset in webkit [16916] by darin

5 edits in trunk/WebKit

Reviewed by Maciej.

passed calls that require WebHTMLView or WebFrameView calls across the client interface

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader opened]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader reload]): (-[WebFrameLoader transitionToCommitted:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _forceLayout]): (-[WebFrame _setDocumentViewFromPageCache:]): (-[WebFrame _setCopiesOnScroll]):

Oct 8, 2006:

11:46 PM Changeset in webkit [16915] by mjs

4 edits in trunk/WebKit

Reviewed by Darin.

pass remaining delegate methods across client interface

Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _dispatchDidFirstLayoutInFrame]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchShow]): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]): (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):

11:30 PM Changeset in webkit [16914] by darin

16 edits in trunk

WebCore:

Reviewed by Maciej.

added a bit more WebCoreSystemInterface

wkGetNSURLResponseCalculatedExpiration
wkGetNSURLResponseLastModifiedDate
wkGetNSURLResponseMustRevalidate

WebCore.exp: Added the new symbols.
platform/mac/WebCoreSystemInterface.h: Ditto.
platform/mac/WebCoreSystemInterface.mm: Ditto.

quiet down the code generation script

bindings/scripts/CodeGenerator.pm:

WebKit:

Reviewed by Maciej.

use WebCoreSystemInterface instead of WebSystemInterface in Loader directory

Loader/WebFrameLoader.m: Update includes. (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK. (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Added the three new symbols, and resorted the list.

Loader/WebDataProtocol.m:
Loader/WebLoader.m:
Loader/WebMainResourceLoader.h:
Loader/WebMainResourceLoader.m:
Loader/WebNetscapePlugInStreamLoader.h:
Loader/WebNetscapePlugInStreamLoader.m:
Loader/WebSubresourceLoader.h:
Loader/WebSubresourceLoader.m: Changed import statements to consistently use the "" format.

11:19 PM Changeset in webkit [16913] by mjs

2 edits in trunk/WebKit

Not reviewed.

fix accidental build break due to editing while committing

Loader/WebFrameLoader.m:

11:17 PM Changeset in webkit [16912] by mjs

4 edits in trunk/WebKit

Reviewed by Darin.

move all WebFrameLoadDelegate methods across client interface

Loader/WebFrameLoader.m: (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _dispatchDidCancelClientRedirectForFrame]): (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]): (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]): (-[WebFrame _dispatchWillCloseFrame]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidReceiveTitle:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]):

10:44 PM Changeset in webkit [16911] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

removed some of the WebKit dependencies in WebFrameLoader

Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader reload]): (-[WebFrameLoader didChangeTitleForDocument:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
WebView/WebFrameInternal.h:

some other tweaks

Misc/WebNSURLRequestExtras.m: (-[NSMutableURLRequest _web_setHTTPReferrer:]): (-[NSMutableURLRequest _web_setHTTPUserAgent:]):

10:42 PM Changeset in webkit [16910] by mjs

4 edits in trunk/WebKit

Reviewed by Darin.

pass all WebResourceLoadDelegate methods across client, removing need to include related headers

Loader/WebFrameLoader.m: (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):

10:23 PM Changeset in webkit [16909] by mjs

6 edits in trunk/WebKit

Reviewed by Darin.

started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch

Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
Loader/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge handledOnloadEvents]):
WebView/WebFrame.m: (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]): (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
WebView/WebFrameInternal.h:

9:30 PM Changeset in webkit [16908] by darin

11 edits in trunk/WebKit

Reviewed by Maciej.

moved more methods to WebFrameLoader from WebFrame

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _finishedLoadingResource]): (-[WebFrameLoader _receivedError:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader reload]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader checkLoadComplete]):
Loader/WebFrameLoaderClient.h:
Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge close]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]):
WebView/WebDataSourceInternal.h:
WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _detachedFromParent1]): (-[WebFrame _detachedFromParent2]): (-[WebFrame _detachedFromParent3]): (-[WebFrame _detachedFromParent4]): (-[WebFrame _updateHistoryAfterClientRedirect]): (-[WebFrame _loadedFromPageCache]):
WebView/WebFrameInternal.h:
WebView/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
WebView/WebView.m: (-[WebView _close]): (-[WebView setDefersCallbacks:]):

8:56 PM Changeset in webkit [16907] by mjs

10 edits in trunk

WebCore:

Reviewed by Darin.

more code laundering - add wkSupportsMultipartXMixedReplace

WebCore.exp:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.

avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace

Loader/WebDocumentLoader.m: (-[WebDocumentLoader initWithRequest:]):
Loader/WebMainResourceLoader.m:
Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebView/WebDataSource.m: (-[WebDataSource _initWithDocumentLoader:]):

8:23 PM Changeset in webkit [16906] by bdash

1 edit in trunk/WebKit/WebView/WebFrame.m

Release build fix: silence warning about unused variable.

7:43 PM Changeset in webkit [16905] by darin

2 edits in trunk/WebKit

build fix (also a fix for a crasher I forgot to commit before)

Loader/WebFrameLoader.m: Added some missing includes. (-[WebFrameLoader checkLoadCompleteForThisFrame]): Added a needed retain/release.

7:35 PM Changeset in webkit [16904] by darin

2 edits in trunk/WebKit

Reviewed by Anders.

quick fix to loader problem causing layout test failures

Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge that we retain/release. (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Same here.

7:17 PM Changeset in webkit [22340] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Port of OpenSource r16526, r16528

Break up ResourceLoaderWndProc into callback functions.

platform/win/ResourceLoaderWin.cpp: Fix up #includes (WebCore::): Remove loadStatusMessage, struct JobLoadStatus, add messageHandlers array. (WebCore::ResourceLoaderWndProc): Split handling of different messages into callbacks. (WebCore::ResourceLoader::onHandleCreated): New callback. (WebCore::ResourceLoader::onRequestRedirected): New callback. (WebCore::ResourceLoader::onRequestComplete): New callback. (WebCore::initializeOffScreenResourceLoaderWindow): No need to register loadStatusMessage anymore. (WebCore::transferJobStatusCallback): Change how information is passed into ResourceLoaderWndProc.

7:09 PM Changeset in webkit [16903] by mjs

4 edits in trunk/WebKit

Reviewed by Adam.

removed a few includes from WebFrameLoader, fixed up as appropriate
segregated header includes into ones that need to go away to move the code and ones that don't

Loader/WebFrameLoader.m: (-[WebFrameLoader _privateBrowsingEnabled]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _privateBrowsingEnabled]):

6:48 PM Changeset in webkit [16902] by darin

9 edits in trunk/WebKit

Reviewed by Maciej.

moved a few methods from WebFrame to WebFrameLoader

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _finishedLoading]): (isBackForwardLoadType): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
Loader/WebFrameLoaderClient.h:
Plugins/WebPluginController.m: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
WebCoreSupport/WebFrameBridge.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkLoadComplete]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _updateBackground]): (-[WebFrame _frameLoader]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForBackForwardNavigation]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _tokenForLoadErrorReset]): (-[WebFrame _resetAfterLoadError:]): (-[WebFrame _doNotResetAfterLoadError:]):
WebView/WebFrameInternal.h:

5:44 PM Changeset in webkit [16901] by bdash

2 edits in trunk/WebKit

2006-10-09 Mark Rowe <bdash@webkit.org>

Rubber-stamped by Darin.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that is triggering an assertion failure.

5:33 PM Changeset in webkit [16900] by bdash

2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Darin and Oliver.

Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.

platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage. (WebCore::GraphicsContext::drawConvexPolygon):

4:52 PM Changeset in webkit [16899] by mjs

8 edits in trunk/WebKit

Reviewed by Darin.

remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into two coincidentally matching enums)

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader commitProvisionalLoad:]): (isBackForwardLoadType): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader didFirstLayout]):
WebCoreSupport/WebFrameBridge.m:
WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _loadType]): (-[WebFrame loadRequest:]):
WebView/WebFrameInternal.h:
WebView/WebView.m:

4:33 PM Changeset in webkit [16898] by andersca

2 edits in trunk/WebCore

2006-10-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

page/Frame.cpp: (WebCore::Frame::submitForm): No need to use latin1() here.

3:47 PM Changeset in webkit [16897] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge

Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader closeOldDataSources]):
WebCoreSupport/WebFrameBridge.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge loader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge imageTitleForFilename:size:]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):
WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFramePrivate setWebFrameView:]): (-[WebFramePrivate setProvisionalItem:]): (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame _createItem:]): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _setTitle:]): (-[WebFrame _defersCallbacksChanged]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForSavingDocState]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _frameLoader]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame frameView]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
WebView/WebFrameInternal.h:

3:45 PM Changeset in webkit [16896] by bdash

2 edits in trunk/WebCore

2006-10-08 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Darin.

Kill warnings when generating IDL files on Qt/Linux, as the
SOURCE_ROOT environment variable is not defined (and not needed) for us.

bindings/scripts/CodeGenerator.pm:

3:24 PM Changeset in webkit [16895] by mjs

3 edits in trunk/WebCore

Reviewed by Darin.

split didNotOpenURL: into general and page-cache-specific parts

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge didNotOpenURL:]): (-[WebCoreFrameBridge invalidatePageCache:]):

3:10 PM Changeset in webkit [16894] by mjs

10 edits in trunk/WebKit

Reviewed by Darin.

move remaining movable data fields from WebFrameLoader to WebFrame

Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitIfReady]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader isQuickRedirectComing]):
Loader/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameBridge.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge frameLoader]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
WebView/WebDataSource.m: (-[WebDataSource _loadFromPageCache:]):
WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _didFinishLoad]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame stopLoading]): (-[WebFrame _invalidateCurrentItemPageCache]):
WebView/WebFrameInternal.h:

2:40 PM Changeset in webkit [16893] by andersca

3 edits in trunk/WebCore

2006-10-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

loader/loader.cpp: Remove DeprecatedStringList.h include.

page/Frame.cpp: (WebCore::Frame::submitForm): Don't remove "attach" from mailto URLs, we don't do it anywhere else.

2:28 PM Changeset in webkit [16892] by darin

12 edits
4 moves in trunk/WebKit

Rubber stamped by Maciej.

changed "document load state" to "document loader"

Loader/WebDocumentLoadState.h: Removed.
Loader/WebDocumentLoadState.m: Removed.
Loader/WebDocumentLoader.h: Added.
Loader/WebDocumentLoader.m: Added. (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setTitle:]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader activeDocumentLoader]): (-[WebFrameLoader activeDataSource]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader setDocumentLoader:]): (-[WebFrameLoader documentLoader]): (-[WebFrameLoader policyDataSource]): (-[WebFrameLoader setPolicyDocumentLoader:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader provisionalDocumentLoader]): (-[WebFrameLoader setProvisionalDocumentLoader:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _originalRequest]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _receivedData:]): (-[WebFrameLoader _setRequest:]): (-[WebFrameLoader _isStopping]): (-[WebFrameLoader _setupForReplaceByMIMEType:]): (-[WebFrameLoader _setResponse:]): (-[WebFrameLoader _mainReceivedError:complete:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
Plugins/WebPluginController.m: (-[WebPluginController pluginView:receivedResponse:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource dealloc]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
WebView/WebDataSourceInternal.h:
WebView/WebDocumentLoadStateMac.h: Removed.
WebView/WebDocumentLoadStateMac.m: Removed.
WebView/WebDocumentLoaderMac.h: Added.
WebView/WebDocumentLoaderMac.m: Added.
WebView/WebFrame.m: (-[WebFrame _createItem:]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]):
WebView/WebFrameInternal.h:
WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):

1:44 PM Changeset in webkit [16891] by darin

1 edit in trunk/WebKit/ChangeLog

More change log tweaking -- it's well worth it!

1:42 PM Changeset in webkit [16890] by darin

1 edit in trunk/WebKit/ChangeLog

Fixed grammar mistake in change log entry.

1:42 PM Changeset in webkit [16889] by darin

2 edits in trunk/WebKit

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=11218 REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL

Also added a helper function in WebFrameLoader so code that checks for back/forward load types
is easier to read.

Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load state to nil instead of the passed-in object. (isBackForwardLoadType): Added. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType. (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): Ditto. (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.

12:19 PM Changeset in webkit [16888] by weinig

27 edits
2 deletes in trunk/WebCore

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
Yet another round of Objective-C SVG DOM bindings auto-generation

Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent, DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, DOMSVGZoomAndPan and DOMSVGZoomEvent.

Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement using the new [ConvertFromString] property.

Add forward declarations for NS* types to auto-generated classes.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMHTMLAppletElement.mm: Removed.
bindings/objc/DOMHTMLEmbedElement.mm: Removed.
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVG.h:
bindings/scripts/CodeGeneratorObjC.pm:
html/HTMLAppletElement.idl:
html/HTMLEmbedElement.idl:
ksvg2/svg/SVGPatternElement.idl:
ksvg2/svg/SVGPolygonElement.idl:
ksvg2/svg/SVGPolylineElement.idl:
ksvg2/svg/SVGRadialGradientElement.idl:
ksvg2/svg/SVGRenderingIntent.idl:
ksvg2/svg/SVGScriptElement.idl:
ksvg2/svg/SVGSetElement.idl:
ksvg2/svg/SVGStopElement.idl:
ksvg2/svg/SVGSwitchElement.idl:
ksvg2/svg/SVGSymbolElement.idl:
ksvg2/svg/SVGTRefElement.idl:
ksvg2/svg/SVGTSpanElement.idl:
ksvg2/svg/SVGTextContentElement.idl:
ksvg2/svg/SVGTextElement.idl:
ksvg2/svg/SVGTextPositioningElement.idl:
ksvg2/svg/SVGTitleElement.idl:
ksvg2/svg/SVGUseElement.idl:
ksvg2/svg/SVGViewElement.idl:
ksvg2/svg/SVGZoomEvent.idl:

6:53 AM Changeset in webkit [16887] by darin

4 edits in trunk/WebKit

Reviewed by Maciej.

fix two recently introduced leaks: one of an NSString, the other of a WebDataSource

Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Rearranged code to avoid storage leak in case of identical title.

Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method from the header.
Loader/WebFrameLoader.m: (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader as needed if this load state is going away rather than moving on to become the provisional load state. (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting. (-[WebFrameLoader _loadRequest:archive:]): Added an assertion. (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion. (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion. (-[WebFrameLoader reload]): Added an assertion. (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid calling _documentLoadState over and over again.

1:02 AM Changeset in webkit [22339] by hyatt

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add win2k/classic support for all controls.

12:47 AM Changeset in webkit [22338] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-10-07 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Fix <rdar://4772205> Regression (r10623): WinInet loader doesn't ever write to the cache.

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): Apply POST related flags only for posts. (WebCore::ResourceLoader::startHTTPRequest): Don't add no-cache-write flag to non-post transactions.

Oct 7, 2006:

11:15 PM Changeset in webkit [22337] by hyatt

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add code to paint the Windows Classic/2000 look for scrollbars.

6:08 PM Changeset in webkit [16886] by andersca

2 edits in trunk/WebCore

2006-10-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.

loader/loader.cpp: (WebCore::Loader::servePendingRequests):

5:44 PM Changeset in webkit [16885] by andersca

18 edits in trunk/WebCore

2006-10-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Convert a bunch of RefPtr<StringImpl> to String.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::didTellBridgeAboutLoad): (WebCore::FrameMac::haveToldBridgeAboutLoad):
dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::storeResult):
dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::result):
dom/Document.cpp: (WebCore::Document::createEntityReference):
dom/Entity.cpp: (WebCore::Entity::Entity): (WebCore::Entity::nodeName): (WebCore::Entity::toString):
dom/Entity.h: (WebCore::Entity::publicId): (WebCore::Entity::systemId): (WebCore::Entity::notationName):
dom/EntityReference.cpp: (WebCore::EntityReference::EntityReference): (WebCore::EntityReference::nodeName): (WebCore::EntityReference::cloneNode): (WebCore::EntityReference::toString):
dom/EntityReference.h:
dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent): (WebCore::KeyboardEvent::initKeyboardEvent):
dom/KeyboardEvent.h: (WebCore::KeyboardEvent::keyIdentifier):
dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
dom/MutationEvent.h: (WebCore::MutationEvent::prevValue): (WebCore::MutationEvent::newValue): (WebCore::MutationEvent::attrName):
dom/Notation.cpp: (WebCore::Notation::Notation): (WebCore::Notation::nodeName):
dom/Notation.h: (WebCore::Notation::publicId): (WebCore::Notation::systemId):
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::setData): (WebCore::ProcessingInstruction::nodeName): (WebCore::ProcessingInstruction::nodeValue): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::toString):
dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::target): (WebCore::ProcessingInstruction::data): (WebCore::ProcessingInstruction::localHref):

3:49 PM Changeset in webkit [22336] by hyatt

2 edits in branches/WindowsMerge/WebCore

Make sure frames honor scrolling modes and margins.

12:22 PM Changeset in webkit [22335] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Merge of OpenSource r16884
http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):

11:53 AM Changeset in webkit [16884] by aroben

2 edits in trunk/WebKit

Reviewed/landed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

COM/WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):

11:42 AM Changeset in webkit [22334] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix for failed ASSERT on iBench.

WebFrame.cpp: (WebFrame::receivedAllData): Be a bit more lenient about what ResourceLoader has called WebFrame::receivedAllData

10:24 AM Changeset in webkit [16883] by weinig

24 edits in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
10 more SVG Objective-C auto-generated bindings

Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement, DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.

Auto-generate the text method for DOMRange.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/DOMRGBColor.mm:
bindings/objc/DOMSVG.h:
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/Range.idl:
ksvg2/svg/SVGFilterElement.cpp:
ksvg2/svg/SVGFilterElement.h:
ksvg2/svg/SVGFilterElement.idl:
ksvg2/svg/SVGForeignObjectElement.idl:
ksvg2/svg/SVGGElement.idl:
ksvg2/svg/SVGGradientElement.idl:
ksvg2/svg/SVGImageElement.idl:
ksvg2/svg/SVGLineElement.idl:
ksvg2/svg/SVGLinearGradientElement.idl:
ksvg2/svg/SVGMarkerElement.idl:
ksvg2/svg/SVGMaskElement.idl:
ksvg2/svg/SVGPaint.idl:

5:58 AM Changeset in webkit [16882] by weinig

14 edits
1 move
1 add
3 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

Fully auto-generate DOMAbstractView and DOMRange.

Auto-generate just the interface for DOMRGBColor.

Add DOMRanges.h as the new top level file for Ranges module.

Add DOMRanges.h and DOMXPath.h to DOM.mm

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.h:
bindings/objc/DOM.mm:
bindings/objc/DOMAbstractView.h: Removed.
bindings/objc/DOMAbstractView.mm: Removed.
bindings/objc/DOMInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/DOMRGBColor.h: Removed.
bindings/objc/DOMRGBColor.mm:
bindings/objc/DOMRange.h: Removed.
bindings/objc/DOMRanges.h: Added.
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
css/RGBColor.idl:
dom/Range.idl:
page/AbstractView.idl: Added.

WebKit:

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

MigrateHeaders.make:

5:39 AM Changeset in webkit [16881] by bdash

3 edits
4 adds in trunk

2006-10-07 Andrew Wellington <proton@wiretapped.net>

Reviewed by Eric.

Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
http://bugzilla.opendarwin.org/show_bug.cgi?id=10837

Return null when there is no frame. This matches Firefox.

bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty):

2006-10-07 Andrew Wellington <proton@wiretapped.net>

Reviewed by Eric.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit

fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.

5:04 AM Changeset in webkit [16880] by hyatt

2 edits in trunk/WebCore/platform

Fix win32 and qt bustage.

4:41 AM Changeset in webkit [16879] by hyatt

5 edits in trunk/WebCore

Implement scroll corner painting (a white rect fill) for overflow areas to cover up
scrollbar joins properly.

Refactor painting of scrollbars and resizers into common functions. Eliminate the
extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.

Reviewed by mitz

page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer):
rendering/RenderLayer.h:

3:42 AM Changeset in webkit [16878] by bdash

2 edits in trunk/WebKit

2006-10-07 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Fix memory leak from -[WebDocumentLoadState setTitle:].

Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is zero, and untangle the confusing logic around this case.

2:32 AM Changeset in webkit [16877] by bdash

6 edits in trunk/WebCore

2006-10-07 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
matching recent ResourceLoader changes.

platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected):
platform/gdk/PlatformScrollBar.h:
platform/gdk/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::start):
platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode):
platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::addChild): (ScrollView::updateScrollbars): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):

1:20 AM Changeset in webkit [22333] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix build bustage from earlier checkin.

1:18 AM Changeset in webkit [22332] by hyatt

2 edits in branches/WindowsMerge/WebCore

Fix resizer coordinate space error.

Oct 6, 2006:

11:57 PM Changeset in webkit [22331] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Better fix for scrollbars coming and going affecting plugin clip.

11:32 PM Changeset in webkit [22330] by hyatt

2 edits in branches/WindowsMerge/WebCore

Update plugin clipping when scrollbars come/go.

11:06 PM Changeset in webkit [16876] by hyatt

1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

11:04 PM Changeset in webkit [16875] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

11:03 PM Changeset in webkit [16874] by hyatt

1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm

Remove x/y from the log message on debug Mac builds.

10:56 PM Changeset in webkit [22329] by hyatt

2 edits in branches/WindowsMerge/WebCore

Improve performance of plugin clipping when scrolling.

10:55 PM Changeset in webkit [16873] by beidson

16 edits in trunk/WebKit

Reviewed by Darin

Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal

DefaultDelegates/WebDefaultContextMenuDelegate.m:
History/WebHistoryItem.m:
Loader/WebFrameLoader.h:
Misc/WebCoreStatistics.m:
Misc/WebElementDictionary.m:
Plugins/WebNetscapePluginEmbeddedView.m:
Plugins/WebPluginController.m:
WebCoreSupport/WebViewFactory.m:
WebView/WebArchiver.m:
WebView/WebDataSource.m:
WebView/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame _isFrameSet]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]):
WebView/WebFrameInternal.h:
WebView/WebFramePrivate.h:
WebView/WebHTMLRepresentation.m:
WebView/WebScriptDebugDelegate.m:

10:43 PM Changeset in webkit [22328] by hyatt

4 edits in branches/WindowsMerge/WebCore

Implement clipping of plugins on Win32.

10:32 PM Changeset in webkit [16872] by hyatt

10 edits in trunk/WebCore

Add a new method for obtaining accurate window-level clip rectangles. Can be used even by windowed plugins to clip properly.

8:31 PM Changeset in webkit [16871] by bdash

3 edits
3 adds in trunk/WebKitTools

2006-10-06 David Smith <catfish.man@gmail.com>

Reviewed by Timothy.

Bug 9665: [Drosera] Conditional breakpoints. http://bugs.webkit.org/show_bug.cgi?id=9665

Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
Drosera/breakpointEditor.css: Added.
Drosera/breakpointEditor.html: Added.
Drosera/breakpointEditor.js: Added.
Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.

6:57 PM Changeset in webkit [22327] by ggaren

6 edits in branches/WindowsMerge

WebCoreWin:

Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL

The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.

The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

ChangeLog:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Adam Roben, esq.

Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL

The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.

The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::stopMainResourceLoad): (WebFrame::receivedAllData):
WebFrame.h:

5:42 PM Changeset in webkit [16870] by mjs

6 edits in trunk/WebKit

Reviewed by Darin.

Move all delegate dispatching code out of WebDataSource.

Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
WebView/WebDataSource.m: (-[WebDataSource _setLoadingFromPageCache:]): (-[WebDataSource _stopLoadingWithError:]):
WebView/WebDataSourceInternal.h:

5:36 PM Changeset in webkit [16869] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

moved firstLayoutDone BOOL from WebFrame to WebFrameLoader

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader firstLayoutDone]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
WebView/WebFrame.m: (-[WebFrame _firstLayoutDone]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]):
WebView/WebFrameInternal.h:

5:19 PM Changeset in webkit [16868] by darin

8 edits in trunk/WebKit

Reviewed by Maciej.

moved more data and the corresponding code from WebFrame to WebFrameLoader

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader cannotShowMIMETypeForURL:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader _continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]): (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame stopLoading]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _quickRedirectComing]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
WebView/WebFrameInternal.h:
WebView/WebFramePrivate.h:

WebKit.xcodeproj/project.pbxproj:

4:00 PM Changeset in webkit [22326] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Use a better versioning scheme.

Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".

This first versioned submission is 521.28b

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Use a better versioning scheme.

Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".

This first versioned submission is 521.28b

WebKit.vcproj/WebKit.rc:

3:49 PM Changeset in webkit [16867] by mjs

2 edits in trunk/WebKit

Rubber stamped by Darin.

removed includes of unused headers.

WebView/WebDataSource.m:

3:42 PM Changeset in webkit [16866] by mjs

3 edits in trunk/WebKit

Not reviewed.

fix build breakage

Loader/WebFrameLoader.m: (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):

3:38 PM Changeset in webkit [16865] by mjs

11 edits in trunk/WebKit

Reviewed by Darin.

move remaining movable WebDataSource fields to WebDocumentLoadState

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState isLoadingInAPISense]): (-[WebDocumentLoadState addResponse:]): (-[WebDocumentLoadState stopRecordingResponses]): (-[WebDocumentLoadState title]): (-[WebDocumentLoadState setLastCheckedRequest:]): (-[WebDocumentLoadState lastCheckedRequest]): (-[WebDocumentLoadState triggeringAction]): (-[WebDocumentLoadState setTriggeringAction:]): (-[WebDocumentLoadState responses]): (-[WebDocumentLoadState setOverrideEncoding:]): (-[WebDocumentLoadState overrideEncoding]): (-[WebDocumentLoadState setTitle:]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource textEncodingName]):
WebView/WebDataSourceInternal.h:
WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):

3:32 PM Changeset in webkit [16864] by thatcher

1 copy in tags/Safari-521.28b

New tag.

3:20 PM Changeset in webkit [22325] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Bump version number.

WebKit.vcproj/WebKit.rc:

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Bump version number.

2:52 PM Changeset in webkit [16863] by darin

6 edits in trunk/WebKit

Reviewed by Maciej.

moved loadType into WebFrameLoader

WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's currently used by Safari.

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
WebView/WebFrame.m: (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _didFirstLayout]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame loadRequest:]):

2:34 PM Changeset in webkit [22324] by sfalken

7 edits in branches/WindowsMerge

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam, Lou.

<rdar://4754295> Corrupt history.plist = crash on startup

Fix improper CF usage that likely led to retain/release imbalances.

Resizer fixes.
We now properly invalidate and draw overlapping contents or opaque.
Fix capture state after resize by posting a mouse up to balance the one that gets eaten (Thanks, Lou!)

2:25 PM Changeset in webkit [16862] by sfalken

3 edits in trunk/WebCore

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Add another method we'll need for scrollbar dodging

platform/ScrollView.h:
platform/win/TemporaryLinkStubs.cpp: (ScrollView::resizerOverlapsContent):

2:25 PM Changeset in webkit [16861] by darin

6 edits
1 add in trunk/WebKit

Reviewed by Maciej.

added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame

Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol. Eventually we'll be removing the dependency on WebFrame entirely.
WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method by its new name.

Loader/WebFrameLoaderClient.h: Added.
WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.

2:13 PM Changeset in webkit [16860] by weinig

14 edits
9 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
Auto-generate the interfaces even for Objective-C DOM
bindings that need custom implementations

Fully auto-generate DOMEventTarget, DOMNodeFilter and DOMHTMLOptionElement.

Auto-generate just the interface for DOMHTMLAppletElement, DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect using the new IDL property ObjCCustomImplementation.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMEventTarget.h: Removed.
bindings/objc/DOMHTMLAppletElement.h: Removed.
bindings/objc/DOMHTMLEmbedElement.h: Removed.
bindings/objc/DOMHTMLOptionElement.h: Removed.
bindings/objc/DOMHTMLOptionElement.mm: Removed.
bindings/objc/DOMInternal.h:
bindings/objc/DOMNodeFilter.h: Removed.
bindings/objc/DOMSVGNumber.h: Removed.
bindings/objc/DOMSVGPoint.h: Removed.
bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint matrixTransform:]):
bindings/objc/DOMSVGRect.h: Removed.
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/EventTarget.idl:
html/HTMLAppletElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLOptionElement.idl:
ksvg2/svg/SVGNumber.idl:
ksvg2/svg/SVGPoint.idl:
ksvg2/svg/SVGRect.idl:

2:11 PM Changeset in webkit [16859] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to

Also removed useless WebFrameLoader part

WebView/WebFrame.m: (-[WebFramePrivate dealloc]):

2:04 PM Changeset in webkit [22323] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add (commented out) WMP plugin check.

1:53 PM Changeset in webkit [22322] by andersca

2 edits
5 adds in branches/WindowsMerge/WebKitTools

2006-10-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Land new version of DumpRenderTree that uses the WebKit APIs.

1:48 PM Changeset in webkit [16858] by thatcher

4 edits in trunk

WebCore:

Reviewed by Tim H.

Make Qt/Linux compile again completly.

platform/qt/WidgetQt.cpp: (WebCore::Widget::removeFromParent):

WebKitTools:

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.

DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

1:42 PM Changeset in webkit [16857] by mjs

8 edits in trunk/WebKit

Reviewed by Anders.

moved more data from WebDataSource to WebDocumentLoadState

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState prepareForLoadStart]): (-[WebDocumentLoadState loadingStartedTime]): (-[WebDocumentLoadState setIsClientRedirect:]): (-[WebDocumentLoadState isClientRedirect]): (-[WebDocumentLoadState setPrimaryLoadComplete:]): (-[WebDocumentLoadState isLoadingInAPISense]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader subframeIsLoading]):
WebView/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource isLoading]):
WebView/WebDataSourceInternal.h:
WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

1:36 PM Changeset in webkit [16856] by thatcher

4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.

platform/qt/PlatformScrollBar.h:
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::scrollbarUnderMouse):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (FrameView::passMousePressEventToScrollbar):

11:26 AM Changeset in webkit [22321] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady and Geoff.

<rdar://problems/4769023>
Crash on cnettv.com - PluginStreamWin::receivedResponse

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): If the Content-Type header is missing, try to figure o ut the content type from the file extension. Failing that, just use "application/octet-stream".

11:16 AM Changeset in webkit [16855] by kmccullo

4 edits in trunk/JavaScriptCore

Reviewed by Brady.

DST and TimeZones were wrong in some cases, specifically on some of the dates where DST changes.

kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::dateToMseconds): (KJS::msToTM):
kjs/DateMath.h:
kjs/date_object.cpp: (KJS::gmtoffset):

11:03 AM Changeset in webkit [16854] by brmorris

4 deletes in S60/branches/scriptable_plugins/WebCore

Remove some tmp files from revision control.

10:55 AM Changeset in webkit [16853] by ap

2 edits in trunk/WebKit

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled

WebView/WebFrame.m: (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Use utf-8 encoding instead of the string's "fastest" encoding.

7:52 AM Changeset in webkit [16852] by yongjzha

3 edits in S60/trunk/WebKit

2006-10-06 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Match page overview touch behavior to UI spec
http://bugs.webkit.org/show_bug.cgi?id=11179

BrowserView/inc/PointerEventHandler.h:
BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL): (CPointerEventHandler::AutoScroll):

5:28 AM Changeset in webkit [16851] by zbujtas

3 edits in S60/branches/3.1m/WebCore

2006-10-05 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
http://bugs.webkit.org/show_bug.cgi?id=11170

merged from trunk r16849

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
kwq/KWQKHTMLPart.h:

5:25 AM Changeset in webkit [16850] by weinig

36 edits
6 adds in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation

Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement, DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, DOMSVGFETileElement, DOMSVGFETurbulenceElement, DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.

Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint and DOMSVGRect.

IDL clean up.

Make numOctaves in SVGFETurbulenceElement use a long instead of an int in it's macro declaration and definition.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMSVG.h:
bindings/objc/DOMSVGNumber.h: Added.
bindings/objc/DOMSVGNumber.mm: Added. (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
bindings/objc/DOMSVGPoint.h: Added.
bindings/objc/DOMSVGPoint.mm: Added. (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
bindings/objc/DOMSVGRect.h: Added.
bindings/objc/DOMSVGRect.mm: Added. (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
bindings/scripts/CodeGeneratorObjC.pm:
ksvg2/svg/SVGAnimatedNumberList.idl:
ksvg2/svg/SVGAnimatedRect.idl:
ksvg2/svg/SVGComponentTransferFunctionElement.idl:
ksvg2/svg/SVGCursorElement.idl:
ksvg2/svg/SVGFEBlendElement.idl:
ksvg2/svg/SVGFEColorMatrixElement.idl:
ksvg2/svg/SVGFEComponentTransferElement.idl:
ksvg2/svg/SVGFECompositeElement.idl:
ksvg2/svg/SVGFEDiffuseLightingElement.idl:
ksvg2/svg/SVGFEDisplacementMapElement.idl:
ksvg2/svg/SVGFEDistantLightElement.idl:
ksvg2/svg/SVGFEFloodElement.idl:
ksvg2/svg/SVGFEFuncAElement.idl:
ksvg2/svg/SVGFEFuncBElement.idl:
ksvg2/svg/SVGFEFuncGElement.idl:
ksvg2/svg/SVGFEFuncRElement.idl:
ksvg2/svg/SVGFEGaussianBlurElement.idl:
ksvg2/svg/SVGFEImageElement.idl:
ksvg2/svg/SVGFEMergeElement.idl:
ksvg2/svg/SVGFEMergeNodeElement.idl:
ksvg2/svg/SVGFEOffsetElement.idl:
ksvg2/svg/SVGFEPointLightElement.idl:
ksvg2/svg/SVGFESpecularLightingElement.idl:
ksvg2/svg/SVGFESpotLightElement.idl:
ksvg2/svg/SVGFETileElement.idl:
ksvg2/svg/SVGFETurbulenceElement.cpp:
ksvg2/svg/SVGFETurbulenceElement.h:
ksvg2/svg/SVGFETurbulenceElement.idl:
ksvg2/svg/SVGNumberList.idl:

5:21 AM Changeset in webkit [16849] by zbujtas

3 edits in S60/trunk/WebCore

2006-10-05 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
http://bugs.webkit.org/show_bug.cgi?id=11170

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
kwq/KWQKHTMLPart.h:

4:18 AM Changeset in webkit [16848] by mjs

4 edits in trunk/WebKit

Reviewed by Adam.

fixed the following bugs:

http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"

Possibly more.

Loader/WebDocumentLoadState.h:
Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState actualRequest]): New method.
WebView/WebDataSource.m: (-[WebDataSource _startLoading]): We need to make sure not to start loading the main resource with the fake external request for an applewebdata: request.

3:30 AM Changeset in webkit [16847] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:28 AM Changeset in webkit [16846] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:22 AM Changeset in webkit [16845] by hyatt

5 edits in trunk/WebCore

Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.

3:18 AM Changeset in webkit [16844] by aroben

3 edits in trunk/WebCore

Backing out my previous change.

WebCore.xcodeproj/project.pbxproj:
page/FrameView.cpp: (WebCore::FrameView::adjustViewSize):

3:18 AM Changeset in webkit [22320] by hyatt

2 edits in branches/WindowsMerge/WebCore

Fix open source build bustage by moving windowResizerRect into ScrollViewWin.

3:17 AM Changeset in webkit [16843] by hyatt

3 edits in trunk/WebCore

Fix build bustage like... everywhere.

3:06 AM Changeset in webkit [16842] by aroben

3 edits in trunk/WebCore

Build fix.

WebCore.xcodeproj/project.pbxproj:
page/FrameView.cpp: (WebCore::FrameView::windowResizerRect):

3:01 AM Changeset in webkit [16841] by hyatt

1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

2:48 AM Changeset in webkit [22319] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Some loader improvements, courtesy of Steve.

Functionally, the improvements are these:

Support HTTP Authentication
Respect WinInet errors better

There are also some general code cleanups, like extracting the creation
of an HTTP request into its own method.

platform/win/ResourceLoaderWin.cpp: Add dwError field to JobLoadStatus to store WinInet error codes. Also removed the globalInternetHandle() function as the global HINTERNET is now only needed within startHTTPRequest. (WebCore::ResourceLoaderWndProc): Respect error codes and add HTTP Authentication support. Also, process HTTP status codes as ints instead of strings. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): Cleanup m_formData (WebCore::transferJobStatusCallback): Cleanup the code, and set dwError. (WebCore::ResourceLoader::startHTTPRequest): New method to start a new HTTP request. (WebCore::ResourceLoader::start): Restructure code.

2:43 AM Changeset in webkit [16840] by aroben

4 edits in trunk/WebCore

Reviewed by Maciej.

More loader tweaks.

platform/ResourceLoader.h:
platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::newHTTPRequest):

2:16 AM Changeset in webkit [22318] by hyatt

2 edits in branches/WindowsMerge/WebCore

Fix cnn.com plugins. Fix a crash from not unparenting scrollbars of a scrollview in its destructor.

1:23 AM Changeset in webkit [22317] by hyatt

2 edits in branches/WindowsMerge/WebCore

Fix plugins being mispositioned on osnews.com

12:50 AM Changeset in webkit [22316] by sfalken

12 edits in branches/WindowsMerge

2006-10-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Allow window to be resized via the gripper (bottom right rect adjacent to scrollbars).
Add a method to reset the candidate URLs when a page load completes.
Add implementations for resizer related UI delegate callbacks.
Move gripper drawing into DrawingUtilities.

2006-10-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.
Resizing gripper now paints via web ui delegate.
Debug vcproj fixes.
Fix redirects to search.com.
Add support for painting and cursor tracking of resizer.

Interfaces/IWebUIDelegatePrivate.idl: added webViewDrawResizer.
WebFrame.cpp: (WebFrame::paint): added gripper drawing code. (WebFrame::receivedResponse): tell the app when we commit a page load. (WebFrame::windowResizerRect): added. (WebFrame::paintGripper): added.
WebFrame.h: added windowResizerRect, paintGripper.
WebKit.vcproj/WebKit.vcproj: Link against debug libs, debug MSVC library in debug build.
WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::inResizer): (WebViewWndProc): (WebView::setUIDelegate):
WebView.h:

2006-10-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.

bridge/win/FrameViewWin.cpp: (WebCore::FrameView::windowResizerRect): added.
bridge/win/FrameWin.cpp: (WebCore::FrameWin::windowResizerRect): added.
bridge/win/FrameWin.h:
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Scrollbars now dodge resizing gripper.

12:44 AM Changeset in webkit [16839] by sfalken

7 edits in trunk/WebCore

2006-10-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Stub out some methods that we'll be able to use to dodge a window resizer.

bridge/win/FrameWin.h:
page/Frame.h: (WebCore::Frame::windowResizerRect):
page/FrameView.h:
platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect):
platform/Widget.h:
platform/win/TemporaryLinkStubs.cpp: (FrameView::windowResizerRect): (Widget::setParent): (Widget::parent): (FrameWin::windowResizerRect):

Oct 5, 2006:

11:19 PM Changeset in webkit [22315] by hyatt

2 edits in branches/WindowsMerge/WebCore

Fix scrollview resizing to do updatescrollbars even for iframes. Matches Mac better and makes iframes stop showing scrollbars when they shouldn't.

11:14 PM Changeset in webkit [16838] by hyatt

2 edits in trunk/WebCore

Stub out setFrameGeometry.

10:53 PM Changeset in webkit [22314] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/GraphicsContextWin.cpp

Implement proper clipping and transforms for themed form controls.

10:45 PM Changeset in webkit [22313] by hyatt

6 edits in branches/WindowsMerge

Implement proper clipping and transforms for themed form controls.

10:30 PM Changeset in webkit [16837] by hyatt

1 edit in trunk/WebCore/platform/cg/GraphicsContextCG.cpp

Temporary hack.

10:18 PM Changeset in webkit [16836] by adele

5 edits in trunk/WebCore

Reverting autoscroll fix. I need to rework this a little.

page/Frame.cpp: (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::stopAutoscrollTimer):
page/Frame.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox):

9:48 PM Changeset in webkit [16835] by andersca

2 edits in trunk/WebKitTools

2006-10-05 Oliver Hunt <ohunt@apple.com>

Reviewed by Anders.

Scripts/run-webkit-tests: Fix pixel tests.

8:57 PM Changeset in webkit [16834] by aliceli1

2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/4731778>

editing/CommandByName.cpp: (WebCore::Frame::Command::): was calling the wrong enabledFn for arrow selection and navigation

8:34 PM Changeset in webkit [16833] by adele

5 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text"> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.

page/Frame.cpp: Added getter and setter for the renderer being autoscrolled. (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::autoscrollRenderer): (WebCore::Frame::setAutoscrollRenderer): (WebCore::Frame::stopAutoscrollTimer):
page/Frame.h:

7:48 PM Changeset in webkit [16832] by bdash

7 edits in trunk/WebCore

2006-10-05 Don Gibson <dgibson77@gmail.com>

Reviewed by Eric.

Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/Widget.h:
platform/win/PlatformScrollBar.h:
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
platform/win/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
platform/win/WidgetWin.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setContainingWindow): (WebCore::Widget::containingWindow):

6:23 PM Changeset in webkit [16831] by adele

5 edits in trunk/WebKit

Reviewed by the letter 'B'.

More build fixes.

WebKit.xcodeproj/project.pbxproj:
WebView/WebDynamicScrollBarsView.h:
WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):
WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):

6:03 PM Changeset in webkit [22312] by ggaren

2 edits in branches/WindowsMerge/WebCore

build fix.

platform/win/WidgetWin.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::removeFromParent):

6:01 PM Changeset in webkit [16830] by ggaren

14 edits in trunk/WebCore

build fix.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge installInFrame:]):
bridge/mac/WebCoreFrameView.h:
platform/ScrollBar.cpp:
platform/Widget.h:
platform/mac/PlatformScrollBar.h:
platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollbar:]): (-[WebCoreScrollBar detachPlatformScrollbar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::scrollbarHit): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint):
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::scrollbarUnderMouse):
platform/mac/WidgetMac.mm: (WebCore::Widget::removeFromParent):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar):

5:02 PM Changeset in webkit [16829] by eseidel

2 edits in trunk/WebKitSite

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by Tim H.

coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors

4:16 PM Changeset in webkit [22311] by lamadio

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKitGUID.vcproj

Correct a build break when the build directory is outside the source tree.

3:58 PM Changeset in webkit [16828] by brmorris

1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

Fix runtime break introduced in r16809: added RecentUrlStore.dll

3:38 PM Changeset in webkit [22310] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix addClip->clip renaming bustage.

3:26 PM Changeset in webkit [16827] by bdash

1 edit
4 adds in trunk/WebCore

2006-10-06 Mitz Pettel <mitz@webkit.org>

http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.

Add resource forks for test resources.

manual-tests/resources/plain-text-paste/._1.textClipping: Added.
manual-tests/resources/plain-text-paste/._2.textClipping: Added.
manual-tests/resources/plain-text-paste/._4.txt: Added.
manual-tests/resources/plain-text-paste/._5.webloc: Added.

3:21 PM Changeset in webkit [22309] by hyatt

2 edits in branches/WindowsMerge/WebCore

Stub out GraphicsContextPlatformPrivate methods so that the HDC can
be updated when clips/transforms are applied.

Reviewed by darin

platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):

3:19 PM Changeset in webkit [22308] by aroben

1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Build fix.

WebKit.vcproj/WebKitGUID.vcproj: Fix patch to IWebFramePrivate_i.c

3:16 PM Changeset in webkit [22307] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::BrowserExtensionWin): Change Frame* to FrameWin*

3:14 PM Changeset in webkit [16826] by hyatt

18 edits in trunk/WebCore

Rename addClip to clip.

Reviewed by darin

kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM):
platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addRoundedRectClip):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintTextMatchMarker):
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::setClip):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):

3:11 PM Changeset in webkit [22306] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix. Remove RenderImageButton.{h,cpp}.

WebCore.vcproj/WebCore.vcproj:

3:03 PM Changeset in webkit [16825] by bdash

4 edits
2 deletes in trunk/WebCore

2006-10-05 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=10386 Delete RenderImageButton.* and remove references from .vcproj and .bkl files

CMakeLists.txt:
WebCore.vcproj/WebCore/WebCore.vcproj:
WebCoreSources.bkl:
rendering/RenderImageButton.cpp: Removed.
rendering/RenderImageButton.h: Removed.

2:56 PM Changeset in webkit [16824] by bdash

2 edits in trunk/WebCore

2006-10-05 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11067 manual-tests/scrollbar-hittest2.html is invalid

manual-tests/scrollbar-hittest2.html:

2:53 PM Changeset in webkit [16823] by bdash

3 edits in trunk/WebKit

2006-10-05 Vladimir Olexa <vladimir.olexa@gmail.com>

Reviewed by Timothy.

Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.

WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
WebView/WebView.m: (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults (-[WebView setContinuousSpellCheckingEnabled:]): (-[WebView isContinuousSpellCheckingEnabled]):

2:43 PM Changeset in webkit [16822] by bdash

2 edits in trunk/WebKit

2006-10-05 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11162

COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedResponse):

2:40 PM Changeset in webkit [16821] by bdash

3 edits in trunk/WebCore

2006-10-05 David Carson <dacarson@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.

html/HTMLTokenizer.cpp:
config.h:

2:38 PM Changeset in webkit [16820] by aroben

2 edits in trunk/WebCore

Removing accidentally-checked-in do-nothing code.

html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

2:35 PM Changeset in webkit [16819] by bdash

2 edits in trunk/WebCore

2006-10-05 David Carson <dacarson@gmail.com>

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables

rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):

2:33 PM Changeset in webkit [22305] by andersca

9 edits
1 add in branches/WindowsMerge/WebKitWin

2006-10-05 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

A couple of changes needed for the new DumpRenderTree.

DOMCoreClasses.cpp: (DOMDocument::documentElement): Implement.

DOMHTMLClasses.cpp: (DOMHTMLElement::innerHTML): (DOMHTMLElement::setInnerHTML): (DOMHTMLElement::innerText): (DOMHTMLElement::setInnerText):
DOMHTMLClasses.h: (DOMHTMLFormElement::innerHTML): (DOMHTMLFormElement::setInnerHTML): (DOMHTMLFormElement::innerText): (DOMHTMLFormElement::setInnerText): (DOMHTMLSelectElement::innerHTML): (DOMHTMLSelectElement::setInnerHTML): (DOMHTMLSelectElement::innerText): (DOMHTMLSelectElement::setInnerText): (DOMHTMLOptionElement::innerHTML): (DOMHTMLOptionElement::setInnerHTML): (DOMHTMLOptionElement::innerText): (DOMHTMLOptionElement::setInnerText): (DOMHTMLInputElement::innerHTML): (DOMHTMLInputElement::setInnerHTML): (DOMHTMLInputElement::innerText): (DOMHTMLInputElement::setInnerText): (DOMHTMLTextAreaElement::innerHTML): (DOMHTMLTextAreaElement::setInnerHTML): (DOMHTMLTextAreaElement::innerText): (DOMHTMLTextAreaElement::setInnerText):
Interfaces/DOMHTML.idl: Implement innerText and add stubs for innerHTML, setInnerHTML and setInnerText.

Interfaces/IWebFramePrivate.idl: Added.
WebFrame.cpp: (WebFrame::QueryInterface): (WebFrame::renderTreeAsExternalRepresentation): (WebFrame::receivedAllData): Call Frame::end() before calling the frame load delegate methods. This matches the mac behavior.

(WebFrame::didFirstLayout):
(WebFrame::handledOnloadEvents):
Add null checks for frameLoadDelegatePriv, all clients might not use it.

WebFrame.h:
WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/WebKitGUID.vcproj: Add new interface, IWebFramePrivate, which supports getting the render tree as text.

1:27 PM Changeset in webkit [16818] by aroben

7 edits in trunk

2006-10-05 Don Gibson <dgibson77@gmail.com>

WebCore:

Reviewed by Darin, landed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Darin, landed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

COM/WebFrame.cpp: (WebFrame::loadDataSource):

1:22 PM Changeset in webkit [16817] by ap

10 edits
1 add in trunk

2006-10-05 Marvin Decker <marv.decker@gmail.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=10989
Provide a way for embedders to implement BrowserExtensionWin

WebCore:

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/BrowserExtensionWin.cpp: Added. (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL):
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp:

WebKit:

COM/Interfaces/IWebUIDelegate.idl:
COM/WebFrame.cpp: (WebFrame::createNewWindow):
COM/WebFrame.h:

1:17 PM Changeset in webkit [16816] by brmorris

1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

More break fixes: updating Toolbar.* in S60/S60Internals/S60DynamicLibs.zip

1:01 PM Changeset in webkit [22304] by ggaren

4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4766987>

renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.

fixed RenderLayer to properly tear down scrollbars, removing them from their parents.

bridge/win/FrameViewWin.cpp: (WebCore::FrameView::passMousePressEventToScrollbar):
platform/win/PlatformScrollBar.h: (WebCore::):
platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::invalidateTrack): (WebCore::PlatformScrollbar::invalidatePart): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::backButtonRect): (WebCore::PlatformScrollbar::forwardButtonRect): (WebCore::PlatformScrollbar::trackRect): (WebCore::PlatformScrollbar::thumbRect): (WebCore::PlatformScrollbar::gripperRect): (WebCore::PlatformScrollbar::splitTrack): (WebCore::PlatformScrollbar::thumbPosition): (WebCore::PlatformScrollbar::thumbLength): (WebCore::PlatformScrollbar::trackLength): (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb): (WebCore::PlatformScrollbar::paintGripper): (WebCore::PlatformScrollbar::hitTest): (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent): (WebCore::PlatformScrollbar::startTimerIfNeeded): (WebCore::PlatformScrollbar::stopTimerIfNeeded): (WebCore::PlatformScrollbar::autoscrollPressedPart): (WebCore::PlatformScrollbar::autoscrollTimerFired): (WebCore::PlatformScrollbar::pressedPartScrollDirection): (WebCore::PlatformScrollbar::pressedPartScrollGranularity): (WebCore::PlatformScrollbar::thumbUnderMouse): (WebCore::PlatformScrollbar::themeChanged): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::themeChanged):

12:59 PM Changeset in webkit [16815] by ggaren

21 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4766987>

renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.

fixed RenderLayer to properly tear down scrollbars, removing them from their parents.

bindings/js/kjs_window.cpp: (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures):
bridge/BrowserExtension.h:
dom/Document.cpp: (WebCore::Document::setInPageCache):
html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute):
html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::scrollingMode):
page/Frame.cpp: (WebCore::Frame::finishedParsing): (WebCore::Frame::scrollbarsVisible):
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): (WebCore::FrameView::handleMousePressEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::scrollbarMoved):
page/FrameView.h:
page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
platform/ScrollBar.h: (WebCore::): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::Scrollbar::~Scrollbar): (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::controlSize): (WebCore::Scrollbar::hasPlatformScrollbars): (WebCore::Scrollbar::client):
platform/ScrollBarMode.h: (WebCore::):
platform/ScrollView.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::horizontaScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::verticalScrollbarWidth): (WebCore::RenderLayer::horizontalScrollbarHeight): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::valueChanged):
rendering/RenderListBox.h:
rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):

12:58 PM Changeset in webkit [16814] by andersca

2 edits in trunk/WebKitTools

2006-10-04 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Scripts/run-webkit-tests: Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test results should be.

12:38 PM Changeset in webkit [16813] by ap

2 edits in trunk/WebKitTools

2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Cmake: make it possible to install the libraries after having built using 'build-webkit'.
Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.

Scripts/webkitdirs.pm:

11:27 AM Changeset in webkit [16812] by brmorris

2 edits in S60/trunk/S60Internals

Fix build break introduced in r16809 by updating toolbar.h in S60Headers.zip

10:57 AM Changeset in webkit [16811] by ap

2 edits in trunk/WebCore

2006-10-05 Don Gibson <dgibson77@gmail.com>

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11138
Incorrect mouse event generation on Windows

platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): (1) Set mouse button even for non-click-related messages. (2) Track clicks correctly for all buttons, not just the left button.

10:48 AM Changeset in webkit [16810] by ap

8 edits in trunk/WebCore

2006-10-05 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Fix Qt/Linux build, adapt to Eric's Quartz changes and to Maciej's ResourceLoader changes.

kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::renderPath): (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: (WebCore::KRenderingPaintServerPatternQt::renderPath):
kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup): (WebCore::KRenderingPaintServerSolidQt::renderPath):
kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke):

10:37 AM Changeset in webkit [16809] by yongjzha

5 edits in S60/trunk/WebKit

2006-10-05 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Zhang Yongjun.
DESC: Enable touch ui on browser toolbar
http://bugs.webkit.org/show_bug.cgi?id=11156

BrowserView/inc/PointerEventHandler.h:
BrowserView/inc/WebKitView.h:
BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL):
BrowserView/src/WebKitView.cpp: (CWebKitView::LaunchToolBarL): (CWebKitView::NodeUnderPointer):

10:20 AM Changeset in webkit [16808] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

wtf/Assertions.cpp: Fix build when _DEBUG is not defined.

9:44 AM Changeset in webkit [16807] by ap

3 edits
23 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11054
REGRESSION: Traditional Chinese encoding in login authentication

Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding for encoding GB_2312-80 and several others. So, we need to override this behavior, too.

WebCore:

platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):

LayoutTests:

Each of these tests is passed by Firefox 1.5 and/or WinIE 6.

fast/encoding/GBK/EUC-CN-expected.txt: Added.
fast/encoding/GBK/EUC-CN.html: Added.
fast/encoding/GBK/chinese-expected.txt: Added.
fast/encoding/GBK/chinese.html: Added.
fast/encoding/GBK/cn-gb-expected.txt: Added.
fast/encoding/GBK/cn-gb.html: Added.
fast/encoding/GBK/csgb2312-expected.txt: Added.
fast/encoding/GBK/csgb2312.html: Added.
fast/encoding/GBK/csgb231280-expected.txt: Added.
fast/encoding/GBK/csgb231280.html: Added.
fast/encoding/GBK/gb2312-expected.txt: Added.
fast/encoding/GBK/gb2312.html: Added.
fast/encoding/GBK/gb_2312-80-expected.txt: Added.
fast/encoding/GBK/gb_2312-80.html: Added.
fast/encoding/GBK/gbk-expected.txt: Added.
fast/encoding/GBK/gbk.html: Added.
fast/encoding/GBK/iso-ir-58-expected.txt: Added.
fast/encoding/GBK/iso-ir-58.html: Added.
fast/encoding/GBK/x-euc-cn-expected.txt: Added.
fast/encoding/GBK/x-euc-cn.html: Added.
fast/encoding/GBK/x-gbk-expected.txt: Added.
fast/encoding/GBK/x-gbk.html: Added.

6:59 AM Changeset in webkit [16806] by eseidel

2 edits
1 delete in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

Removed dead code.
Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs

WebCore.xcodeproj/project.pbxproj:
ksvg2/ecma/GlobalObject.cpp: Removed.
ksvg2/ecma/GlobalObject.h: Removed.

6:56 AM Changeset in webkit [22303] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fixes <rdar://problem/4757387>
Unable to sign on to my.yahoo.com

This patch fixes a number of bugs that all resulted in not being able
to log on to many websites. The problems were that we weren't allowing
redirects between HTTP and HTTPS sites and weren't correctly handling
redirects from POST requests to GET requests.

platform/win/ResourceLoaderWin.cpp: (WebCore::globalInternetHandle): Move internetHandle and callbackHandle into file scope, and add this function to initialize them. (WebCore::logLastError): Add this debug logging function to give more readable WinInet error messages. (WebCore::ResourceLoaderWndProc): The most substantial change here is to allow redirects from POST to GET to function correctly. To do this we have to create a new HINTERNET for the GET. We also have to be sure not to try to read from our now-invalid handles after the redirect. (WebCore::transferJobStatusCallback): Rename timerId to jobId, since that's what it is. (WebCore::ResourceLoader::start): Call new static initializer, and pass flags to allow HTTP<->HTTPS redirects. Also change a few delete calls to kill().

6:54 AM Changeset in webkit [16805] by aroben

2 edits in trunk/WebCore

Reviewed by Maciej.

Small ResourceLoaderInternal tweak.

platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):

6:52 AM Changeset in webkit [16804] by eseidel

26 edits in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

More incremental KCanvas cleanup and optimization.
Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
Optimized dash array usage to not malloc.
Also removed un-needed KSVGRenderingStyle includes.

kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
ksvg2/misc/KCanvasRenderingStyle.h:

6:15 AM Changeset in webkit [16803] by mjs

13 edits in trunk/WebCore

Reviewed by Adam.

changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
dom/XMLTokenizer.cpp: (WebCore::openFunc):
loader/icon/IconLoader.cpp: (IconLoader::IconLoader): (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
loader/icon/IconLoader.h:
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
platform/ResourceLoader.cpp: (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::kill):
platform/ResourceLoader.h:
platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
xml/xmlhttprequest.h:

5:59 AM Changeset in webkit [16802] by eseidel

5 edits in trunk/WebCore

2006-10-05 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
http://bugs.webkit.org/show_bug.cgi?id=11163

No SVG performance tests yet.

kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

5:51 AM Changeset in webkit [22302] by mjs

6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Adam.

changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

WebFrame.cpp: (WebFrame::loadDataSource):

2:03 AM Changeset in webkit [22301] by hyatt

7 edits in branches/WindowsMerge

Make key events get delivered properly to iframes and frames.

1:58 AM Changeset in webkit [16801] by hyatt

4 edits in trunk/WebCore

Widget focusability work.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed