Context Navigation

← Previous Period
Next Period →

Timeline

10/13/06:

Reviewed by Geoff.

Build fix from my last check-in. Make hasOutlineAnnotation() non-
inline so that we don't have to include Document.h in
RenderObject.h
Doing so causes a build failure in WebKit, and it probably isn't a
good idea anyway.

rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation):
rendering/RenderObject.h: (WebCore::RenderObject::hasOutline):

18:37 Changeset [17053] by ggaren

Reviewed by Beth.

Split build, run, and debug steps into separate pages. Darin recommended
this a while back.

building/build.html:
building/checkout.html:
building/debug.html: Added.
building/run.html: Added.
nav.inc:

18:12 Changeset [17052] by bdakin

Patch written mostly by Ken Kraisler, but also by me.

Reviewed by Hyatt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and < rdar://
problem/3391162> PDF created by printing should have live
hyperlinks

platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect):
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect):
platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document.
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting.
rendering/RenderFlow.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting.
rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true.
rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN.

16:58 Changeset [17051] by justing

LayoutTests:

Reviewed by ggaren and harrison

< rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

editing/pasteboard/4744008-expected.txt: Added.
editing/pasteboard/4744008.html: Added.

WebCore:

Reviewed by ggaren and harrison

< rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix.

16:56 Changeset [22364] by mjs

Reviewed by Darin.

split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): (IconLoader::notifyIconChanged):

16:54 Changeset [17050] by mjs

Reviewed by Darin.

split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
bridge/win/BrowserExtensionWin.h:
page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
page/Frame.h:
page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory):
page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):

16:50 Changeset [17049] by sullivan

Reviewed by Maciej

loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback.

16:45 Changeset [17048] by mjs

Not reviewed, build fix.

icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.

16:16 Changeset [17047] by mjs

Not reviewed, build fix.

icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.

15:14 Changeset [22363] by hyatt

Make form controls work in transparency layers.

15:12 Changeset [22362] by hyatt

Make sure the backing store flushes properly when the theme changes.

15:09 Changeset [17046] by hyatt

Transparency layer work.

14:45 Changeset [17045] by spadma

2006-10-13 zhalu < zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is enabled,
the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed.
The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in
CAknFepManager. If users press the key in a normal speed, there is no problem because there is nothing
for committing. But if users press two keys(not two letters on the same key) very quickly, the second key
will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third
key position. The result is that it seems not letting you insert some key in the second position.

http://bugs.webkit.org/show_bug.cgi?id=11192

BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):

14:42 Changeset [17044] by mjs

Reviewed by Anders.

add a bunch of casts to get this compiling with older Xcode versions

(I used static_cast so it will be easier to find and remove these once we have completely moved
on to a new enough compiler version.)

Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): (-[WebBaseNetscapePluginView _reshapeAGLWindow]): (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
WebKit.xcodeproj/project.pbxproj:

14:35 Changeset [17043] by brmorris

2006-10-13 brmorris < thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Updates to reindeer sisx installation.
http://bugs.webkit.org/show_bug.cgi?id=9435

WebUi/install/Reindeer.pkg: Added.
WebUi/install/WebUi.pkg: Removed.
WebUi/install/buildsis.bat:

14:18 Changeset [17042] by spadma

2006-10-13 sareen < shyam.sareen@nokia.com>

Reviewed by ( Sachin.padma@nokia.com).
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

http://bugs.webkit.org/show_bug.cgi?id=11281.

Plugin/inc/PluginAdapterInterface.h: (MPluginAdapter::SetOptionMenuHandler):
Plugin/inc/PluginSkin.h:
Plugin/inc/PluginWin.h:
Plugin/inc/npapi.h:
Plugin/src/PluginSkin.cpp:
Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::IsContentInteractive):

14:04 Changeset [17041] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg paint server classes.

13:22 Changeset [17040] by ggaren

LayoutTests:

Tests for accessing renderer-dependent properties from a javascript: URL.

fast/frames/frame-js-url-clientWidth-expected.txt: Added.
fast/frames/frame-js-url-clientWidth.html: Added.
fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
fast/frames/iframe-js-url-clientWidth.html: Added.

WebCore:

Reviewed by Darin, John.

Merged more frame and iframe code
Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time

PLT insists this is a small performance win. Don't believe its lies.

bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM.
dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach):
dom/ContainerNode.h:
html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height):
html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies.
html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach):
page/FrameView.h: Removed unused method.

12:21 Changeset [17039] by rwlbuis

Reviewed by Eric.

Force --no-http on Qt/Linux.

12:10 Changeset [17038] by rwlbuis

Add PopupMenuQt.cpp, remove RenderPopupMenuQt.*, as per WildFox' request.

11:56 Changeset [17037] by kmccullo

Reviewed by Kevin McCullough.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11283
Fixes Qt/Linux and Windows build

kjs/DateMath.cpp:
kjs/DateMath.h:
kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):

11:17 Changeset [17036] by harrison

LayoutTests:

Reviewed by Justin.

< rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

editing/style/style-boundary-005.html: Added. Matches steps from bug.
editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

WebCore:

Reviewed by Justin.

< rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

Tests added or changed:

editing/style/style-boundary-005.html: Added. Matches steps from bug.
editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

dom/Text.cpp: (WebCore::Text::splitText): Comment changes.

editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan.

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
Rename emptySpans local to unstyledSpans.

(WebCore::dummySpanAncestorForNode):
New. To locate Apple style span created when splitting a text node.

(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
of dummy span's parents, rather than traversing up from start and
end locations. Old algorithm would miss empty spans in the bug case.

(WebCore::ApplyStyleCommand::applyInlineStyle):
Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().

(WebCore::ApplyStyleCommand::removeCSSStyle):
Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().

(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Comment changes.

editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild().

editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes.

rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM

11:14 Changeset [17035] by rwlbuis

Adding a file that should have gone in in r17021, as requested by WildFox.

11:08 Changeset [17034] by adele

Reviewed by Eric.

Fix Qt/Linux build after Adele's popup menu changes.

CMakeLists.txt:
platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl):
platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
platform/qt/RenderPopupMenuQt.cpp: Removed.
platform/qt/RenderPopupMenuQt.h: Removed.
platform/qt/RenderThemeQt.cpp:

10:57 Changeset [17033] by kmccullo

Reviewed by Adam.

Gets JavaScripCore tests running on windows.

Scripts/run-javascriptcore-tests:
Scripts/webkitdirs.pm:

10:48 Changeset [17032] by kmccullo

Reviewed by Darin.

fixed build failure

WebCore.xcodeproj/project.pbxproj:
loader/mac/WebFrameLoader.mm:

10:31 Changeset [17031] by kmccullo

Reviewed by Adam, Geoff, Darin.

Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up.

ChangeLog:
kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): (KJS::GregorianDateTime::~GregorianDateTime): (KJS::GregorianDateTime::toTM):
kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
kjs/date_object.h:

10:22 Changeset [17030] by kmccullo

Changed by Darin, reviewed by me.

Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on case-sensitive file system.

10:07 Changeset [17029] by darin

WebCore:

Reviewed by Adele.

converted WebFormState from Objective-C to C++

WebCore.exp: Added a new symbol, changed one symbol from C to C++.

WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h.

loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.

loader/mac/WebFormState.h: Converted class to C++.
loader/mac/WebFormState.mm: Ditto.

loader/mac/WebFrameLoader.h:
loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState.

WebKit:

Reviewed by Adele.

converted WebFormState from Objective-C to C++

ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here. We should eventually come up with a more-elegant solution.

WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths. Converted many files from Objective-C to Objective-C++. In a later check-in, I'll rename them to .mm instead of .m. Removed C-only warning options for now. In a later check-in I will add these back in a way that omits them for C++.

Plugins/WebPluginContainerCheck.m: Updated for header changes.

WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category so this file can still be used by Objective-C code (not just Objective-C++).

WebView/WebFrame.m: Put WebFrameLoaderClient category in here. (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed enum code for C++ compatibility. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here. (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility. (-[WebFrame _updateHistoryForReload]): Ditto.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto. (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility. (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.

WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.

07:36 Changeset [17028] by adele

Reviewed by Maciej.

Fix for < rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color

rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):

05:56 Changeset [17027] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg structure classes.

10/12/06:

23:33 Changeset [17026] by adele

LayoutTests:

Reviewed by Anders.

Test for http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/

fast/forms/listbox-width-change-expected.txt: Added.
fast/forms/listbox-width-change-expected.png: Added.
fast/forms/listbox-width-change-expected.checksum: Added.
fast/forms/listbox-width-change.html: Added.

WebCore:

Reviewed by Anders.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11172 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/

Test: fast/forms/listbox-width-change.html

rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.

22:52 Changeset [22361] by hyatt

Vote Cairo off the island.

22:49 Changeset [22360] by hyatt

Remove Cairo files from WebFrame.cpp now that the Cairo paint method is gone.

22:22 Changeset [17025] by mjs

WebCore:

Reviewed by Oliver.

moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies

WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
loader/mac/LoaderNSURLExtras.h:
loader/mac/LoaderNSURLRequestExtras.h: Added.
loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer):
loader/mac/WebFrameLoader.mm:
loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Oliver.

liberate more WebKit code down to WebCore

WebCoreSupport/WebFrameBridge.h:
WebCoreSupport/WebFrameBridge.m:

20:53 Changeset [22359] by hyatt

Add code that will delete the backing store if our window gets hidden. (We are dependent on the app to make sure we get the message.)

19:29 Changeset [22358] by adele

RS by Geoff.

Renamed uploadControlDetaching to disconnectUploadControl.

platform/win/FileChooserWin.cpp: (WebCore::FileChooser::disconnectUploadControl):

19:28 Changeset [17024] by adele

RS by Geoff.

Renamed menuListIsDetaching to disconnectMenuList,
uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
These names match similar methods in WebCore a little better.

platform/FileChooser.h:
platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl):
platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):

19:13 Changeset [17023] by adele

WebCore:

Reviewed by Maciej.

WebCore part of fix for < rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
bridge/mac/WebCoreFrameBridge.h:

platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.

WebKit:

Reviewed by Maciej.

WebKit part of fix for < rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
WebView/WebUIDelegatePrivate.h:

18:39 Changeset [17022] by adele

Reviewed by Alice.

Fix for < rdar://problem/4707372> After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu

platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards.

18:33 Changeset [17021] by bdash

2006-10-12 Nikolas Zimmermann < zimmermann@kde.org>

Reviewed by Maciej.

Exclude some tests which crash or hang from Qt/Linux DRT.
These are known to fail, and will be fixed at some point :-)

DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::readSkipFile): (WebCore::DumpRenderTree::checkLoaded):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.

18:31 Changeset [17020] by bdash

2006-10-12 Nikolas Zimmermann < zimmermann@kde.org>

Reviewed by Maciej.

Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
document.open(); document.write(..); and NO document.close(). On the Qt platform this
leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.

Hmpf, this took me nine hours to debug today.
Result: Couldn't find the real fix, going for a workaround for now.

540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.

platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().

18:27 Changeset [22357] by adele

Reviewed by Alice.

Fixed a small oversight from the last checkin. The populate method was calling itself,
instead of the newly renamed addItems method.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::populate):

16:04 Changeset [22356] by aroben

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

WebCore.vcproj/WebCore.vcproj: Move files within project.
platform/win/PopupMenuWin.cpp: Moved from rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to PopupMenu. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::setPositionAndSize): (WebCore::PopupMenu::addOption): (WebCore::PopupMenu::focusedIndex): New method to get the index of the element that is currently highlighted. This won't always be the same as the selectedIndex because of mouse hot-tracking. (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::registerPopup): (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages to the popup window.
platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu. (PopupMenu::addSeparator): (PopupMenu::addGroupLabel):
rendering/RenderPopupMenuWin.cpp: Removed.
rendering/RenderPopupMenuWin.h: Removed.
rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
rendering/RenderThemeWin.h: Ditto.

16:02 Changeset [17019] by aroben

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
WebCore.xcodeproj/project.pbxproj: Ditto.
html/HTMLSelectElement.cpp: Remove unnecessary #include.
platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr<PopupMenu>. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it.
platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle):
platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto.
platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup):
rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup):
rendering/RenderPopupMenu.cpp: Removed.
rendering/RenderPopupMenu.h: Removed.
rendering/RenderPopupMenuMac.h: Removed.
rendering/RenderPopupMenuMac.mm: Removed.
rendering/RenderPopupMenuWin.h: Removed.
rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
rendering/RenderTheme.h: Ditto.
rendering/RenderThemeMac.h: Ditto.
rendering/RenderThemeMac.mm: Ditto.
rendering/RenderThemeWin.cpp: Ditto.
rendering/RenderThemeWin.h: Ditto.

14:44 Changeset [17018] by adele

Reviewed by Dave Harrison.

Fixed < rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)

rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.

13:42 Changeset [17017] by ggaren

Reviewed by Maciej.

Removed JSObjectMakeWithPrototype, clarified some comments. We really
don't want people to manage their own prototypes, so we don't want an
extra function in the API devoted to just that. People can still manage
their own prototypes if they really want by using JSObjectSetPrototype.

API/JSClassRef.cpp: (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
API/JSClassRef.h:
API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMake):
API/JSObjectRef.h:
API/testapi.c: (main):
JavaScriptCore.exp:

13:29 Changeset [17016] by rwlbuis

Reviewed by MacDome.

Finally found a way to remove our begin() trickery in FrameQt.
The (probably misnamed) Frame::setEncoding() function automatically
calls Frame::receivedFirstData() which calls being on the working
url, which has been passed to didOpenUrl(). Took me some hours
to figure out that the missing charset logic, forced us to do hacks.

13:19 Changeset [17015] by kmccullo

Reviewed by Adam.

Build breakage fix

kjs/DateMath.cpp: (KJS::msToTM):
kjs/date_object.cpp: (KJS::gmtoffset):

12:49 Changeset [17014] by brmorris

2006-10-12 brmorris < thisisbradley@gmail.com>

Reviewed by Bradley.
DESC: Replace winscw MemMan.dll with MemMan_sdk.dll if ! -e MemMan.dll

12:22 Changeset [17013] by aroben

Reviewed by Hyatt.

Bandaid-ing a null-dereference crash until a real fix is made.

page/FrameView.cpp: (WebCore::FrameView::windowClipRect):

11:46 Changeset [17012] by brmorris

2006-10-12 brmorris < thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Generate/check only the correct WebKit icons depending on build flavour
http://bugs.webkit.org/show_bug.cgi?id=11266

group/icons.mk: Work off BROWSER_SDK evar to check/create correct icons.

11:34 Changeset [17011] by aroben

2006-10-12 MorganL < morganl.webkit@yahoo.com>

Reviewed/landed by Adam.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
Windows build busted

COM/WebFrame.cpp: (WebFrame::receivedResponse):

10:58 Changeset [17010] by kmccullo

Reviewed by Geoff.

Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly. Also there is some code cleanup.

kjs/DateMath.cpp: (KJS::timeToMS): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::dateToMS): (KJS::msToTM): (KJS::tmToKJStm): (KJS::KJStmToTm):
kjs/DateMath.h:
kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
kjs/date_object.h:

10:10 Changeset [22355] by aroben

Build fix (broken by OpenSource r17006)

WebFrame.cpp: (WebFrame::receivedResponse):

10:04 Changeset [17009] by brmorris

2006-10-12 brmorris < thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fixes for GCCE compilation.
http://bugs.webkit.org/show_bug.cgi?id=9435

08:07 Changeset [17008] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg text classes.

05:44 Changeset [17007] by rwlbuis

WebCore:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

WebKitTools:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

04:50 Changeset [17006] by mjs

Reviewed by Eric.

move m_responseMIMEType out of ResourceRequest, where it doesn't belong

page/FramePrivate.h: Add m_responseMIMEType
page/ResourceRequest.h: Remove m_responseMIMEType
page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto
page/Frame.h:
bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto

03:36 Changeset [17005] by mjs

Reviewed by Eric.

< rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image

We really need some way to test loadHTMLString since it keeps breaking!

loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.

03:22 Changeset [17004] by rwlbuis

Reviewed by Eric.

Fix Qt/Linux build.

02:36 Changeset [17003] by bdash

2006-10-12 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Maciej.

Update Gdk\Linux build for recent changes, based on Qt code

platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
platform/gdk/FrameGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create):

2006-10-12 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Maciej.

Also regenerate GdkLauncher makefiles, since not doing that might
lead to mismatch between WebCore and GdkLauncher compiler settings.

Scripts/regenerate-makefiles:

02:03 Changeset [22354] by hyatt

Implement full-blown double buffering.

02:01 Changeset [17002] by hyatt

Add more clipping retrieval functionality for widgets.

10/11/06:

18:44 Changeset [17001] by zbujtas

2006-10-11 brmorris < thisisbradley@gmail.com>

Reviewed by zalan
DESC: send reindeer UA String
http://bugs.webkit.org/show_bug.cgi?id=9189

BrowserView/inc/WebKitLoader.h: Update static ua string to 3.1
ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL): Return static ua string if BROWSER_SDK

17:54 Changeset [17000] by darin

Reviewed by Adele.

preparations for making more code C++

WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff that non-C++ files get.

Misc/WebKitLogging.h:
Misc/WebKitSystemBits.h:
Misc/WebLocalizableStrings.h:
WebCoreSupport/WebSystemInterface.h: Added extern "C".

Misc/WebNSViewExtras.h:
WebView/WebDataSource.m: (addTypesFromClass):
WebView/WebFrameView.m: (addTypesFromClass): Eliminated use of the identifier "class".

WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.

Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.

17:40 Changeset [16999] by darin

Reviewed by John.

some changes to prepare for converting more code to C++

bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is self-sufficient.

bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class. Needed since the class is used in this header (for some work I have not landed yet).

loader/mac/LoaderNSURLExtras.h:
loader/mac/WebFormDataStream.h: Added extern "C" so this code can be used from C++.

loader/mac/LoaderNSURLExtras.m:
loader/mac/WebDataProtocol.mm:
loader/mac/WebDocumentLoader.mm:
loader/mac/WebFormDataStream.m:
loader/mac/WebLoader.mm:
loader/mac/WebMainResourceLoader.mm:
loader/mac/WebNetscapePlugInStreamLoader.mm:
loader/mac/WebPolicyDecider.mm:
loader/mac/WebSubresourceLoader.mm: Added missing includes of config.h.

16:18 Changeset [16998] by darin

Reviewed by John Sullivan.

WebKitSystemInterface.h: Updated to a C++-compatible version.

16:15 Changeset [16997] by sullivan

Darin wrote this code; we tested it; I give it the thumbs up.

fixed regression from svn revision 16982 that was generating the wrong Obj-C classes

The hash table to look up an element class given a QualifiedName was
not working at all.

dom/QualifiedName.h: (WebCore::QualifiedName::impl): Added. This new accessor method for impl is needed if we want to use a QualifiedName as a hash table key without doing the kind of specialization we do for String. Maybe later we can do the String thing.

bindings/objc/DOM.mm: (WebCore::addElementClass): Use QualifiedName.impl instead of the QualifiedName pointer itself. The QualifiedName pointer is *not* unique so almost nothing would be found in this hash table! (WebCore::elementClass): ditto

14:09 Changeset [16996] by aroben

Rubberstamped by Anders.

Clean up FileChooser::create and Icon::newIconForFile.

WebCore.xcodeproj/project.pbxproj:
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile):

13:39 Changeset [16995] by kmccullo

Reviewed by Darin.

These test DST behavior on the cusp of a change (i.e. spring forward, fall back)

fast/js/date-DST-time-cusps-expected.txt: Added.
fast/js/date-DST-time-cusps.html: Added.
fast/js/resources/date-DST-time-cusps.js: Added.

11:45 Changeset [16994] by oliver

2006-10-11 Oliver Hunt < oliver@apple.com>

Reviewed by Brady.

Fix svg text related layout tests

svg/custom/getsvgdocument-expected.txt:
svg/hixie/viewbox/003-expected.txt:

11:27 Changeset [16993] by oliver

2006-10-11 Oliver Hunt < oliver@apple.com>

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
Corrects canvas tag to not throw JS exception when drawing
zero sized rects, arcs, etc

html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::arcTo): (WebCore::CanvasRenderingContext2D::arc): (WebCore::CanvasRenderingContext2D::rect): (WebCore::CanvasRenderingContext2D::clearRect): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::strokeRect):

Reviewed by Geoff.

Test case for http://bugs.webkit.org/show_bug.cgi?id=11251

fast/canvas/zero-size-fill-rect-expected.checksum: Added.
fast/canvas/zero-size-fill-rect-expected.png: Added.
fast/canvas/zero-size-fill-rect-expected.txt: Added.
fast/canvas/zero-size-fill-rect.html: Added.

11:26 Changeset [16992] by brmorris

Reviewed by Bradley Morrison.
DESC: some support files for GCCE and RVCT compilations
http://bugs.webkit.org/show_bug.cgi?id=9435

target/GCCE/SDKGCCEPatch.zip: Added.
target/RVCT/S60LibsRVCT.zip: Added.
target/RVCT/S60RVCTPatch.zip: Added.
target/RVCT/rvct2_2.h: Added. (std::):

11:19 Changeset [16991] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11221
REGRESSION: iExploder crash due to style="cursor: url()"

Take better care of empty cursor lists.

Test: fast/css/invalid-cursor-property-crash.html

10:56 Changeset [16990] by aroben

Fixing Windows for real this time.

platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):

10:30 Changeset [16989] by aroben

Fix Windows build.

platform/win/TemporaryLinkStubs.cpp: (FileChooser::create):

10:14 Changeset [22353] by aroben

Rubberstamped by Brady.

Clean up logic in Icon::newIconForFile.

platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Error case should return early.

10:08 Changeset [22352] by aroben

Reviewed by Steve.

Fixes < rdar://problem/4777719>
Icons don't paint with CG

platform/win/IconWin.cpp: (WebCore::Icon::paint): Remove Cairo-specific code now that we have GraphicsContextWin.

09:54 Changeset [22351] by aroben

Rubberstamped by Anders.

Clean up FileChooser::create, Icon::create.

platform/win/FileChooserWin.cpp: (WebCore::FileChooser::create): Just return a FileChooser* and let the implicit cast happen.
platform/win/IconWin.cpp: (WebCore::Icon::newIconForFile): Ditto for Icon*.

08:04 Changeset [16988] by antti

LayoutTests:

Reviewed by Hyatt.

Test for http://bugs.webkit.org/show_bug.cgi?id=4377

fast/layers/layer-visibility-expected.checksum: Added.
fast/layers/layer-visibility-expected.png: Added.
fast/layers/layer-visibility-expected.txt: Added.
fast/layers/layer-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=4377

Respect css visibility semantics for layers too

rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): (WebCore::RenderContainer::appendChildNode): (WebCore::RenderContainer::insertChildNode):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::setHasVisibleContent): (WebCore::RenderLayer::dirtyVisibleContentStatus): (WebCore::RenderLayer::childVisibilityChanged): (WebCore::RenderLayer::dirtyVisibleDescendantStatus): (WebCore::RenderLayer::updateVisibilityStatus): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
rendering/RenderLayer.h: (WebCore::RenderLayer::hasVisibleContent):
rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):

00:15 Changeset [16987] by mjs

Reviewed by Oliver.

added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes

WebCore.xcodeproj/project.pbxproj:
platform/cf/RetainPtr.h: Added. (WTF::): (WTF::RetainPtr::RetainPtr): (WTF::RetainPtr::~RetainPtr): (WTF::RetainPtr::get): (WTF::RetainPtr::operator*): (WTF::RetainPtr::operator->): (WTF::RetainPtr::operator!): (WTF::RetainPtr::operator UnspecifiedBoolType): (WTF::::operator): (WTF::::swap): (WTF::swap): (WTF::operator==): (WTF::operator!=): (WTF::static_pointer_cast): (WTF::const_pointer_cast): (WTF::getPtr):

use it in WidgetMac so it gets tested in at least one place

platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::setCursor): (WebCore::Widget::getView): (WebCore::Widget::setView): (WebCore::Widget::getOuterView):

10/10/06:

23:35 Changeset [16986] by beidson

WebCore:

Reviewed by Maciej.

Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]):
loader/mac/WebFrameLoader.h:
loader/mac/WebFrameLoader.mm: (-[WebFrameLoader initWithFrameBridge:]): (-[WebFrameLoader setFrameLoaderClient:]):

WebKit:

Reviewed by Maciej.

Moved WebFrameLoader into WebCoreFrameBridge

WebCoreSupport/WebFrameBridge.h:
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): (-[WebFrameBridge dealloc]): (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameBridge reportClientRedirectCancelled:]): (-[WebFrameBridge close]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge tokenizerProcessedData]): (-[WebFrameBridge frameDetached]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]): (-[WebFrameBridge isLoadTypeReload]):

21:39 Changeset [16985] by thatcher

Reviewed by Tim H.

Bug 11246: Minor Drosera code cleanup
http://bugs.webkit.org/show_bug.cgi?id=11246

Drosera/debugger.js: Change [has, add, remove]StyleClass to be a function on Element rather than taking an Element as an argument.

21:35 Changeset [16984] by thatcher

Reviewed by Tim H.

Bug 9778: http://bugs.webkit.org/show_bug.cgi?id=9778

ChangeLog:
Drosera/Drosera.xcodeproj/project.pbxproj: Added files
Drosera/English.lproj/Debugger.nib/info.nib: Resized the main window and WebView
Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Resized the main window and WebView
Drosera/Images/SourceArrowOpen.png: Added.
Drosera/Images/fileIcon.jpg: Added.
Drosera/Images/siteCollapsed.tif: Added.
Drosera/Images/siteExpanded.tif: Added.
Drosera/Images/siteIcon.tif: Added.
Drosera/debugger.css: Added File Browser styles
Drosera/debugger.html: Added File Browser UI
Drosera/debugger.js: Added File Browser functionality

21:35 Changeset [22350] by aroben

Reviewed by Oliver.

Fixes < rdar://problem/4731316>
Crash when <input type="file"> element removed while file chooser is open

platform/win/FileChooserWin.cpp: Make FileChooser ref-counted. (WebCore::FileChooser::create): (WebCore::FileChooser::openFileChooser): Add a protector RefPtr around the call to GetOpenFileName so we don't get deleted while the file chooser window is open.

21:33 Changeset [16983] by aroben

Reviewed by Oliver.

Make FileChooser ref-counted.

platform/FileChooser.h:
platform/mac/FileChooserMac.mm: (WebCore::FileChooser::create):
rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
rendering/RenderFileUploadControl.h:

20:46 Changeset [16982] by weinig

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
Even More auto-generated Objective-C DOM bindings changes

Auto-generate DOMSVGPathElement.

Auto-generate the internal interfaces even for classes that have custom internal implementations. Change IDL property from ObjCNoInternal to ObjCCustomInternalImpl to indicate the change.

Add SVG classes to DOMNode and DOMEvent internal interfaces.

Add isSVGZoomEvent() method to Event class to match other Event subclasses and make DOM binding possible.

Assorted cleanups.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (WebCore::addElementClass): (WebCore::createElementClassMap): (WebCore::elementClass): (-[DOMNode description]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMElement _NPObject]): (WebCore::ObjCEventListener::handleEvent):
bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor WebCore::]):
bindings/objc/DOMSVGPathSegInternal.h: Removed.
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSRule.idl:
css/CSSValue.idl:
css/StyleSheet.idl:
dom/Event.cpp: (WebCore::Event::isSVGZoomEvent):
dom/Event.h:
dom/Event.idl:
dom/Node.idl:
ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::isSVGZoomEvent):
ksvg2/events/SVGZoomEvent.h:
ksvg2/svg/SVGAnimatedAngle.idl:
ksvg2/svg/SVGCircleElement.idl:
ksvg2/svg/SVGClipPathElement.idl:
ksvg2/svg/SVGPathElement.idl:
ksvg2/svg/SVGPathSeg.idl:

20:41 Changeset [22349] by aroben

Reviewed by Anders.

Fixes < rdar://problem/4772428>
<select> popup menus positioned incorrectly within frames

rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::setPositionAndSize): Use contentsToWindow() instead of scrollOffset() to correct menu location.

19:29 Changeset [22348] by sfalken

2006-10-10 Steve Falkenburg < sfalken@apple.com>

Reviewed by Adam.

< rdar://4775676>
Crash in CoreFoundation parsing a "corrupt" plist

Prevent crash when we encounter a corrupt history plist by using
structured exception handling to catch the crash and return
an empty history list.

WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL):

19:22 Changeset [16981] by oliver

2006-10-10 Oliver Hunt < oliver@apple.com>

rubber stamped by Anders.

More buildbot bustage

kcanvas/SVGInlineFlowBox.cpp: (WebCore::placeBoxesVerticallyWithAbsBaseline):

19:12 Changeset [16980] by oliver

2006-10-10 Oliver Hunt < oliver@apple.com>

Reviewed by Anders

Unbreak build bots

dom/Text.cpp:
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
kcanvas/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline):

18:28 Changeset [16979] by oliver

2006-10-10 Oliver Hunt <set EMAIL_ADDRESS environment variable>

Reviewed by hyatt.

Fixes bugs #6423, #6559, #10380 and #10839

WebCore.xcodeproj/project.pbxproj:
css/svg.css:
dom/Text.cpp: (WebCore::Text::createRenderer):
kcanvas/RenderSVGInline.cpp: Added. (WebCore::RenderSVGInline::RenderSVGInline): (WebCore::RenderSVGInline::createInlineBox):
kcanvas/RenderSVGInline.h: Added. (WebCore::RenderSVGInline::renderName): (WebCore::RenderSVGInline::requiresLayer):
kcanvas/RenderSVGInlineText.cpp: Added. (WebCore::RenderSVGInlineText::RenderSVGInlineText): (WebCore::RenderSVGInlineText::absoluteRects): (WebCore::RenderSVGInlineText::selectionRect):
kcanvas/RenderSVGInlineText.h: Added. (WebCore::RenderSVGInlineText::renderName): (WebCore::RenderSVGInlineText::requiresLayer):
kcanvas/RenderSVGTSpan.cpp: Added. (WebCore::RenderSVGTSpan::RenderSVGTSpan): (WebCore::RenderSVGTSpan::absoluteRects):
kcanvas/RenderSVGTSpan.h: Added. (WebCore::RenderSVGTSpan::renderName):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::RenderSVGText): (WebCore::RenderSVGText::computeAbsoluteRepaintRect): (WebCore::RenderSVGText::layout): (WebCore::RenderSVGText::createInlineBox): (WebCore::RenderSVGText::nodeAtPoint): (WebCore::RenderSVGText::absoluteRects): (WebCore::RenderSVGText::paint): (WebCore::RenderSVGText::relativeBBox):
kcanvas/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
kcanvas/SVGInlineFlowBox.cpp: Added. (WebCore::SVGInlineFlowBox::paint): (WebCore::SVGInlineFlowBox::placeBoxesHorizontally): (WebCore::SVGInlineFlowBox::verticallyAlignBoxes): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeSVGFlowHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
kcanvas/SVGInlineFlowBox.h: Added. (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
kcanvas/SVGRootInlineBox.cpp: Added. (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally): (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
kcanvas/SVGRootInlineBox.h: Added. (WebCore::SVGRootInlineBox::SVGRootInlineBox):
ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::createRenderer):
ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::createRenderer):
rendering/InlineFlowBox.h:

18:26 Changeset [16978] by oliver

2006-10-10 Oliver Hunt < ohunt@apple.com>

Rubber stamped by Anders.

Updated to deal with new svg text renderers, and
updated result.

custom/text-clip testcase was incorrect, and has been fixed

svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-01-b-expected.png:
svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-02-b-expected.png:
svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-03-b-expected.png:
svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-04-b-expected.png:
svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-05-b-expected.png:
svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
svg/W3C-SVG-1.1/text-align-06-b-expected.png:
svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
svg/custom/baseval-animval-equality-expected.checksum:
svg/custom/baseval-animval-equality-expected.png:
svg/custom/coords-relative-units-transforms-expected.checksum:
svg/custom/coords-relative-units-transforms-expected.png:
svg/custom/coords-relative-units-transforms-expected.txt:
svg/custom/createelement-expected.txt:
svg/custom/feComponentTransfer-Discrete-expected.txt:
svg/custom/feComponentTransfer-Gamma-expected.txt:
svg/custom/feComponentTransfer-Linear-expected.txt:
svg/custom/feComponentTransfer-Table-expected.txt:
svg/custom/foreign-object-skew-expected.txt:
svg/custom/gradient-stroke-width-expected.txt:
svg/custom/image-with-transform-clip-filter-expected.txt:
svg/custom/invalid-css-expected.txt:
svg/custom/invalid-fill-expected.txt:
svg/custom/invalid-viewbox1-expected.txt:
svg/custom/invalid-viewbox2-expected.txt:
svg/custom/junk-data-expected.txt:
svg/custom/marker-overflow-clip-expected.txt:
svg/custom/missing-xlink-expected.txt:
svg/custom/non-opaque-filters-expected.txt:
svg/custom/pointer-events-path-expected.txt:
svg/custom/svg-overflow-types-expected.txt:

text-clip was an incorrect test, rather than an incorrect result

svg/custom/text-clip-expected.txt:
svg/custom/text-clip.svg:
svg/custom/text-filter-expected.txt:
svg/custom/text-gradient-no-content-expected.txt:
svg/custom/text-hit-test-expected.txt:
svg/custom/text-image-opacity-expected.txt:
svg/custom/tref-update-expected.txt:

15:04 Changeset [22347] by aroben

Reviewed by Adele.

Fixes < rdar://problem/4763246>
Using arrow keys in <select> popup fires onChange event

Also updates text shown in <select> element on page when using arrow
keys to change selection within the popup menu, and makes onChange fire
in the same cases as Firefox/IE.

rendering/RenderPopupMenuWin.cpp: (WebCore::RenderPopupMenuWin::down): Update text of the <select> control. Change call to valueChanged() so that onChange doesn't fire. (WebCore::RenderPopupMenuWin::up): Ditto. (WebCore::PopupWndProc): Don't fire onChange anytime selection changes. Fire onChange when pressing Enter

14:57 Changeset [16977] by aroben

Reviewed by Adele.

Improve popup menu behavior.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Cache m_lastOnChangeIndex so we know when to fire onChange. (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to specify whether we should fire onChange. (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire onChange when using the Enter key to change the selection.
html/HTMLSelectElement.h:
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Extract setText logic into its own method. (WebCore::RenderMenuList::setTextFromOption): New method. (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call onChange instead of calling it directly here.
rendering/RenderMenuList.h:

14:28 Changeset [16976] by zbujtas

2006-10-10 rathnasa < sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: On ActivateEvent, clear the "don't submit form twice" data member.
http://bugs.webkit.org/show_bug.cgi?id=11242

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

14:18 Changeset [16975] by adele

WebCore:

Reviewed by Beth.

Fix for < rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text> and < rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

Moved autoscroll code to the Frame class

bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags. Moved autoscroll code to Frame::handleMouseMoveEvent. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::handleMousePressEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown):

bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us. Now we scroll our views in WebCore.

page/Frame.cpp: (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag. (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate. Moved from FrameMac. (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too. (WebCore::Frame::mouseDownMayStartAutoscroll): Added. (WebCore::Frame::setMouseDownMayStartAutoscroll): Added. (WebCore::Frame::mouseDownMayStartDrag): Added. (WebCore::Frame::setMouseDownMayStartDrag): Added. (WebCore::Frame::autoscrollRenderer): Added (WebCore::Frame::setAutoscrollRenderer): Added. (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter. (WebCore::Frame::autoscrollTimerFired): ditto. (WebCore::Frame::stopAutoscrollTimer): ditto.
page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.

page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags. Moved from FrameMac.

page/FrameView.cpp: Store the current mouse position in window coordinates. The callers can convert to their own coordinate space. (WebCore::FrameView::handleMousePressEvent): (WebCore::FrameView::handleMouseDoubleClickEvent): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):

rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection). We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.

rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.

rendering/RenderObject.cpp: (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too) (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.

WebKit:

Reviewed by Beth.

Removed handleAutoscrollForMouseDragged. Except for autoscroll caused by drag and drop, all other
autoscrolling should be done in WebCore instead of in AppKit.

WebCoreSupport/WebFrameBridge.m:
WebView/WebHTMLView.m:
WebView/WebHTMLViewPrivate.h:

14:02 Changeset [16974] by zbujtas

2006-10-10 bujtas < zbujtas@gmail.com>

Reviewed by NOBODY.
DESC: changing capital includes to non-capital
http://bugs.webkit.org/show_bug.cgi?id=11247

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/xml/xml_tokenizer.cpp: (khtml::XMLNamespace::m_ref): (khtml::): (khtml::XMLTokenizer::XMLTokenizer): (khtml::XMLTokenizer::startElement): (khtml::XMLTokenizer::endElement): (khtml::XMLTokenizer::characters): (khtml::XMLTokenizer::exitText): (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::comment): (khtml::XMLTokenizer::insertErrorMessageBlock): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::setTransformSource): (khtml::attributesStartElementHandler): (khtml::XMLAttributes::operator=): (khtml::XMLAttributes::split):

14:00 Changeset [16973] by darin

Rubber stamped by Maciej.

convert many of the loader source files to Objective-C++ to prepare to convert some of them to C++

WebCore.xcodeproj/project.pbxproj:
loader/mac/WebDataProtocol.m: Removed.
loader/mac/WebDocumentLoader.m: Removed.
loader/mac/WebFormState.m: Removed.
loader/mac/WebFrameLoader.m: Removed.
loader/mac/WebLoader.m: Removed.
loader/mac/WebMainResourceLoader.m: Removed.
loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
loader/mac/WebPolicyDecider.m: Removed.
loader/mac/WebSubresourceLoader.m: Removed.
loader/mac/WebDataProtocol.mm: Added.
loader/mac/WebDocumentLoader.mm: Added.
loader/mac/WebFormState.mm: Added.
loader/mac/WebFrameLoader.mm: Added.
loader/mac/WebLoader.mm: Added.
loader/mac/WebMainResourceLoader.mm: Added.
loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
loader/mac/WebPolicyDecider.mm: Added.
loader/mac/WebSubresourceLoader.mm: Added.

14:00 Changeset [16972] by darin

Scripts/do-file-rename: Added.

13:10 Changeset [16971] by mjs

Reviewed by Mitz.

fixed REGRESSION (r16960): crash on navigating to site http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE

loader/mac/WebFrameLoader.m: (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Add back a mistakenly removed retain.

12:17 Changeset [22346] by darin

Reviewed by Beth.

fix problem where you can't type in subframes

WebView.cpp: (WebViewWndProc): Use WebView's focusedTargetFrame() function instead of sending everything to the main frame.

10:01 Changeset [16970] by darin

corrected an archive regression caused by loader refactoring (pointed out by Graham Dennis)

WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]): Fix selector name.

09:19 Changeset [16969] by brmorris

2006-10-04 sareen < shyam.sareen@nokia.com>

Reviewed by Zalan, yongjun.
DESC: Change the dll names BROWSER_SDK and add stub for HistoryProvider
http://bugzilla.opendarwin.org/show_bug.cgi?id=11148
http://bugzilla.opendarwin.org/show_bug.cgi?id=11149
http://bugzilla.opendarwin.org/show_bug.cgi?id=11150

04:03 Changeset [16968] by mjs

Not reviewed, build fix.

fixed release build

WebCore.xcodeproj/project.pbxproj:

03:48 Changeset [16967] by mjs

WebCore:

Rubber stamped by Eric.

moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
loader/mac/LoaderNSURLExtras.m: Added.
loader/mac/WebDataProtocol.m: Added.
loader/mac/WebDocumentLoader.m: Added.
loader/mac/WebFormDataStream.m: Added.
loader/mac/WebFrameLoader.m: Added.
loader/mac/WebLoader.m: Added. (-[NSURLProtocol didReceiveResponse:]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
loader/mac/WebMainResourceLoader.m: Added. (-[WebMainResourceLoader didReceiveResponse:]):
loader/mac/WebPolicyDecider.m: Added.
loader/mac/WebSubresourceLoader.h: Added.
loader/mac/WebSubresourceLoader.m: Added.

WebKit:

Rubber stamped by Eric.

moved a whole bunch of stuff over to WebCore - updated includes appropriately

Loader/LoaderNSURLExtras.h: Removed.
Loader/LoaderNSURLExtras.m: Removed.
Loader/WebDataProtocol.h: Removed.
Loader/WebDataProtocol.m: Removed.
Loader/WebDocumentLoader.h: Removed.
Loader/WebDocumentLoader.m: Removed.
Loader/WebFormDataStream.h: Removed.
Loader/WebFormDataStream.m: Removed.
Loader/WebFormState.h: Removed.
Loader/WebFormState.m: Removed.
Loader/WebFrameLoader.h: Removed.
Loader/WebFrameLoader.m: Removed.
Loader/WebFrameLoaderClient.h: Removed.
Loader/WebLoader.h: Removed.
Loader/WebLoader.m: Removed.
Loader/WebMainResourceLoader.h: Removed.
Loader/WebMainResourceLoader.m: Removed.
Loader/WebNetscapePlugInStreamLoader.h: Removed.
Loader/WebNetscapePlugInStreamLoader.m: Removed.
Loader/WebPlugInStreamLoaderDelegate.h: Removed.
Loader/WebPolicyDecider.h: Removed.
Loader/WebPolicyDecider.m: Removed.
Loader/WebSubresourceLoader.h: Removed.
Loader/WebSubresourceLoader.m: Removed.
Misc/WebNSURLExtras.m:
Plugins/WebBaseNetscapePluginStream.h:
Plugins/WebBaseNetscapePluginView.m:
Plugins/WebNetscapePluginStream.m:
Plugins/WebPluginContainerCheck.m:
Plugins/WebPluginController.m:
WebCoreSupport/WebFrameBridge.m:
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m:
WebView/WebDocumentLoaderMac.h:
WebView/WebFrame.m:
WebView/WebFrameInternal.h:
WebView/WebHTMLView.m:
WebView/WebPolicyDeciderMac.h:
WebView/WebPolicyDelegate.m:
WebView/WebView.m:

03:38 Changeset [16966] by bdash

2006-10-10 Mark Rowe < bdash@webkit.org>

Reviewed by Maciej.

Fix crash on launch in nightly builds after r16965.

Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView. If this happens,
InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
pointer.

Misc/WebNSURLExtras.m: (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.

02:49 Changeset [16965] by mjs

Reviewed by Oliver (sort of?)

WebCore part of moving down NSURL extras

WebCore.exp:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

02:44 Changeset [16964] by mjs

Reviewed by Oliver.

split out some NSURL extras to be moved to WebCore

Loader/LoaderNSURLExtras.h: Added.
Loader/LoaderNSURLExtras.m: Added. (urlByRemovingComponent): (urlByRemovingFragment): (urlOriginalDataAsString): (urlOriginalData): (urlWithData): (WebCFAutorelease): (urlWithDataRelativeToURL): (urlByRemovingResourceSpecifier): (urlIsFileURL): (stringIsFileURL): (urlIsEmpty): (canonicalURL):
Loader/WebFrameLoader.m: (-[WebFrameLoader shouldReloadForCurrent:andDestination:]): (setHTTPReferrer): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader safeLoadURL:]):
Misc/WebNSURLExtras.m: (+[NSURL _web_URLWithData:]): (+[NSURL _web_URLWithData:relativeToURL:]): (-[NSURL _web_originalData]): (-[NSURL _web_originalDataAsString]): (-[NSURL _web_isEmpty]): (-[NSURL _webkit_canonicalize]): (-[NSURL _webkit_URLByRemovingComponent:]): (-[NSURL _webkit_URLByRemovingFragment]): (-[NSURL _webkit_URLByRemovingResourceSpecifier]): (-[NSURL _webkit_isFileURL]): (-[NSString _webkit_isFileURL]):
WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
WebKit.xcodeproj/project.pbxproj:

01:42 Changeset [16963] by rwlbuis

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg animation classes.

01:06 Changeset [16962] by mjs

Reviewed by Oliver.

added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isMainFrame]):

10/09/06:

23:51 Changeset [16961] by mjs

Reviewed by Anders.

sever final WebFrame dependencies

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader subframeIsLoading]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader detachChildren]): (-[WebFrameLoader checkLoadComplete]):

23:12 Changeset [16960] by mjs

Reviewed by Brady.

convert more WebFrameLoader stuff to be independent of WebFrame

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader isHostedByObjectElement]): (-[WebFrameLoader isLoadingMainFrame]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]): (-[WebFrameLoader client]):
Loader/WebFrameLoaderClient.h:
WebView/WebDataSource.m: (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
WebView/WebFrame.m: (-[WebFrame _dispatchCreateWebViewWithRequest:]):

22:14 Changeset [16959] by mjs

Reviewed by Anders and Oliver.

move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadRequest:]): (-[WebFrameLoader loadRequest:inFrameNamed:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame loadRequest:]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _hasFrameView]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]): (-[WebFrame _setTitle:forURL:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _didFinishLoad]): (-[WebFrame _addHistoryItemForFragmentScroll]): (-[WebFrame _shouldTreatURLAsSameAsCurrent:]): (-[WebFrame _provisionalLoadStarted]):
WebView/WebFrameInternal.h:

21:04 Changeset [22345] by beidson

Reviewed by Steve

< rdar://4721579> - WebPreferences for IconDatabase hooked up
This completes the above task by implementing the icon database location preference

WebIconDatabase.cpp: (WebIconDatabase::init): Get the location from the prefs, fallback to the default via shell call
WebPreferenceKeysPrivate.h:
WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::iconDatabaseLocation): (WebPreferences::setIconDatabaseLocation):

20:16 Changeset [16958] by mjs

Not reviewed, build fix.

added forgotten files

Loader/WebPolicyDecider.h: Added.
Loader/WebPolicyDecider.m: Added. (-[WebPolicyDecider invalidate]):

19:41 Changeset [16957] by mjs

Reviewed by Brady.

add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]): (-[WebFrameLoader cancelContentPolicy]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
Loader/WebFrameLoaderClient.h:
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m: (-[WebFrame _createPolicyDeciderWithTarget:action:]): (decisionListener): (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]): (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]): (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
WebView/WebPolicyDeciderMac.h: Added.
WebView/WebPolicyDeciderMac.m: Added. (-[WebPolicyDeciderMac initWithTarget:action:]): (-[WebPolicyDeciderMac dealloc]): (-[WebPolicyDeciderMac decisionListener]): (-[WebPolicyDeciderMac invalidate]):

19:10 Changeset [16956] by beidson

Reviewed by John

http://bugs.webkit.org/show_bug.cgi?id=11195
Added the WebIconDatabaseDelegate. This allows the ability to allow customization of
IconDatabase behavior in the future, starting now with the ability to override the
default icon fairly flexibly

Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
Misc/WebIconDatabase.m: (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase delegate]):
Misc/WebIconDatabaseDelegate.h: Added.
Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
WebKit.xcodeproj/project.pbxproj:

18:52 Changeset [16955] by aroben

Backing out accidental commit.

page/Frame.cpp: (WebCore::Frame::finishedParsing):

18:49 Changeset [16954] by aroben

Reviewed by Darin.

Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
this could cause recursive calls to the destructor. RefPtr now also
inherits from Noncopyable.

dom/NodeFilter.h:
dom/Traversal.h:
page/DOMWindow.h:
page/Frame.cpp: (WebCore::Frame::finishedParsing):
page/Frame.h:
page/Plugin.h:
platform/FontFallbackList.h:
platform/Icon.h:
platform/Shared.h: (WebCore::Shared::Shared): (WebCore::Shared::ref): (WebCore::Shared::deref): (WebCore::Shared::hasOneRef): (WebCore::Shared::refCount):
platform/StringImpl.h:

18:30 Changeset [16953] by darin

Reviewed by Maciej.

eliminated uses of WebResource and WebView from WebFrameLoader

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]): (-[WebFrameLoader _canShowMIMEType:]): (-[WebFrameLoader _representationExistsForURLScheme:]): (-[WebFrameLoader _generatedMIMETypeForURLScheme:]): (-[WebFrameLoader loadDocumentLoader:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]): (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
Loader/WebFrameLoaderClient.h:
Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader loadWithRequestNow:]):
WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame _canUseResourceForRequest:]): (-[WebFrame _canUseResourceWithResponse:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _setDefersCallbacks:]): (-[WebFrame _canHandleRequest:]): (-[WebFrame _canShowMIMEType:]): (-[WebFrame _representationExistsForURLScheme:]): (-[WebFrame _generatedMIMETypeForURLScheme:]): (-[WebFrame _elementForEvent:]):

18:09 Changeset [16952] by oliver

2006-10-09 Oliver Hunt < ohunt@apple.com>

Reviewed by Anders.

Correcting ifdef's

html/CanvasGradient.cpp: (WebCore::CanvasGradient::CanvasGradient): (WebCore::CanvasGradient::~CanvasGradient): (WebCore::CanvasGradient::addColorStop):
html/CanvasGradient.h:
html/CanvasPattern.cpp: (WebCore::CanvasPattern::CanvasPattern): (WebCore::CanvasPattern::~CanvasPattern):
html/CanvasPattern.h:
html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::fill): (WebCore::CanvasRenderingContext2D::stroke): (WebCore::CanvasRenderingContext2D::fillRect): (WebCore::CanvasRenderingContext2D::setShadow): (WebCore::CanvasRenderingContext2D::applyShadow): (WebCore::CanvasRenderingContext2D::drawImage): (WebCore::CanvasRenderingContext2D::createPattern): (WebCore::CanvasRenderingContext2D::applyStrokePattern): (WebCore::CanvasRenderingContext2D::applyFillPattern):
html/CanvasRenderingContext2D.h:
html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor): (WebCore::CanvasStyle::applyFillColor):
html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext):
html/HTMLCanvasElement.h:

18:04 Changeset [16951] by mjs

Reviewed by Darin.

do all the stuff that setting the referrer should

Loader/WebFrameLoader.m: (setHTTPReferrer): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebKit.xcodeproj/project.pbxproj:

17:53 Changeset [16950] by mjs

Reviewed by Darin.

test case that ensures Referer[sic] header is sent

http/tests/misc/referrer-expected.txt: Added.
http/tests/misc/referrer.html: Added.
http/tests/misc/resources/referrer-result.php: Added.

17:38 Changeset [22344] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

Reviewed by Maciej.

Fix < rdar://problem/4756255>
PDF/Acrobat Reader plugin don't work

bridge/win/FrameWin.cpp: (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): Implement these, getting the instance from the plugin view.

platform/win/TemporaryLinkStubs.cpp: Remove functions that are now implemented.

plugins/win/PlugInInfoStoreWin.cpp: (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): Implement this, returning whether we a plugin exists for a given mime type.

plugins/win/PluginDatabaseWin.cpp: (WebCore::parseVersionString): (WebCore::compareVersions): New functions for handling versions.

(WebCore::addMozillaPluginPaths):
(WebCore::addWindowsMediaPlayerPluginPath):
(WebCore::addQuickTimePluginPath):
(WebCore::addJavaPluginPath):
(WebCore::addAdobeAcrobatPluginPath):
(WebCore::PluginDatabaseWin::defaultPluginPaths):
Factor out checks into separate functions, add checks for Java and Adobe Acrobat.

(WebCore::PluginDatabaseWin::isMIMETypeRegistered):
Handle null MIME types.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Add some missing functions. Unload the library if the load failed.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue): Uncomment code for getting the element object.

(WebCore::PluginViewWin::bindingInstance):

plugins/win/PluginViewWin.h: New function which fetches the plugin NPObject and wraps it in an instance.

17:05 Changeset [16949] by aroben

Reviewed by Steve.

Merge r16948 to tag.

16:57 Changeset [16948] by aroben

Reviewed by Maciej.

Fix a possible recursive destructor call.

page/Frame.cpp: (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor. (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if we're already being destroyed.

16:49 Changeset [16947] by weinig

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
Assorted Objective-C bindings changes

Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.

Auto-generate absoluteImageURL method for DOMHTMLInputElement and DOMHTMLObjectElement.

Auto-generate the internal methods for classes with ivars (notably DOMNodeIterator and DOMTreeWalker)

Put more methods in the WebCore namespace and factor out the displayString method into DOMInternal.h as done by Darin in his patch for http://bugs.webkit.org/show_bug.cgi?id=11219.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode addEventListener:listener:useCapture:]): (-[DOMNode removeEventListener:listener:useCapture:]): (-[DOMNode dispatchEvent:]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (-[DOMCSSRule _initWithCSSRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithCSSValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]):
bindings/objc/DOMEvents.mm: (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
bindings/objc/DOMInternal.h: (-[DOMNodeFilter WebCore::]):
bindings/objc/DOMInternal.mm: (-[WebScriptObject _init]): (-[WebScriptObject _initializeScriptDOMNodeImp]): (WebCore::displayString):
bindings/objc/DOMObject.mm: (-[DOMObject dealloc]): (-[DOMObject finalize]):
bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
bindings/objc/DOMSVG.h:
bindings/objc/DOMSVGPathSegInternal.h: Added.
bindings/objc/DOMSVGPathSegInternal.mm: Added. (-[DOMSVGPathSeg WebCore::]): (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]): (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/NodeIterator.idl:
dom/TreeWalker.idl:
html/HTMLInputElement.idl:
html/HTMLObjectElement.idl:
ksvg2/svg/SVGDocument.idl:
ksvg2/svg/SVGElement.idl:
ksvg2/svg/SVGPathSeg.idl:
ksvg2/svg/SVGPathSegArcAbs.idl:
ksvg2/svg/SVGPathSegArcRel.idl:
ksvg2/svg/SVGPathSegClosePath.idl:
ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
ksvg2/svg/SVGPathSegLinetoAbs.idl:
ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
ksvg2/svg/SVGPathSegLinetoRel.idl:
ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
ksvg2/svg/SVGPathSegMovetoAbs.idl:
ksvg2/svg/SVGPathSegMovetoRel.idl:

16:28 Changeset [16946] by bdash

2006-10-09 Don Gibson < dgibson77@gmail.com>

Unreviewed build fix.

Fix windows build bustage.

platform/win/TemporaryLinkStubs.cpp:

16:08 Changeset [16945] by bdash

2006-10-09 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler flags (show warning, no rtti and exceptions).

jscore.bkl:

2006-10-09 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Geoff.

Improve gdk build compiler options.

Bakefiles.bkgen:
presets.bkl:

2006-10-09 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Geoff.

Fix memory leaks discovered via valgrind. Gdk build fixes.

Projects/gdk/webcore-gdk.bkl:
make-generated-sources.sh:
platform/cairo/ImageCairo.cpp: (WebCore::Image::draw):
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
platform/gdk/FrameGdk.h:
platform/gdk/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):

2006-10-09 Krzysztof Kowalczyk < kkowalczyk@gmail.com>

Reviewed by Geoff.

Add -exit-after-loading option to make gdklauncher quit after fully loading and rendering
a page. This allows automatic testing via e.g. valgrind.

GdkLauncher/gdklauncher.bkl:
GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (LauncherFrameGdk::setExitAfterLoading): (LauncherFrameGdk::handledOnloadEvents): (handle_event): (main):

15:36 Changeset [16944] by bdash

2006-10-09 Nikolas Zimmermann < zimmermann@kde.org>

Reviewed by Beth.

Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.

platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly (WebCore::GlyphMap::fillPage):

15:34 Changeset [16943] by bdash

2006-10-09 Nikolas Zimmermann < zimmermann@kde.org>

Reviewed by Oliver.

Use log() instead of alert() just like in all other tests.

editing/selection/move-begin-end.html:

15:30 Changeset [16942] by bdash

2006-10-09 Nikolas Zimmermann < zimmermann@kde.org>

Unreviewed build fix.

Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.

platform/qt/FrameQt.cpp: (WebCore::FrameQt::createJavaAppletWidget):
platform/qt/FrameQt.h:
platform/qt/TemporaryLinkStubs.cpp:

15:24 Changeset [16941] by beidson

WebCore:

Reviewed by Maciej

Tiny changes to help reorganize WebFrameLoader code in WebKit

bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side

WebKit:

Reviewed by Maciej

Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader

Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):
WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge createInstance]):

14:44 Changeset [16940] by mjs

Reviewed by Darin.

(Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)

avoid a needless use of WebFrame

Loader/WebFrameLoader.m: (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):

14:36 Changeset [16939] by yongjzha

2006-10-09 yaharon < yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Fix issues with touch support

Activate an element only if it received both down and up pointer events
Fix coordinates calculation in frames while zooming
Update cursor in each touch event, to give user the correct feedback

http://bugs.webkit.org/show_bug.cgi?id=11229

BrowserView/inc/PointerEventHandler.h:
BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::CPointerEventHandler): (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL):

13:27 Changeset [16938] by beidson

A *real* fake fix for the layouttest problem until the real fix

Loader/WebFrameLoader.m: (-[WebFrameLoader _notifyIconChanged:]):

13:15 Changeset [16937] by beidson

Quick layouttest fix until I make the real fix

Loader/WebFrameLoader.m:

13:06 Changeset [16936] by mjs

Reviewed by Darin.

wean WebFrameLoader from WebDataSource private stuff

(actually just tweaks tot he above to make merging my future
patches easier since Darin did a lot of the same stuff)

Loader/WebDocumentLoader.h:
Loader/WebDocumentLoader.m: (-[WebDocumentLoader URLForHistory]):
Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
Loader/WebFrameLoaderClient.h:
WebView/WebDataSource.m: (-[WebDataSource _URLForHistory]):
WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]):

12:31 Changeset [16935] by darin

Reviewed by Brady.

eliminated WebFrameLoader dependency on WebDataSourceInternal.h, WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with most but not all references to WebView

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader handleUnimplementablePolicyWithError:]): (-[WebFrameLoader cannotShowMIMETypeWithResponse:]): (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader finishedLoadingDocument:]): (-[WebFrameLoader committedLoadWithDocumentLoader:data:]): (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]): (-[WebFrameLoader documentLoader:setMainDocumentError:]): (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader checkLoadComplete]):
Loader/WebFrameLoaderClient.h:
Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
WebView/WebFrame.m: (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame _formDelegate]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _revertToProvisionalWithDocumentLoader:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _URLForHistoryForDocumentLoader:]): (-[WebFrame _cancelledErrorWithRequest:]): (-[WebFrame _cannotShowURLErrorWithRequest:]): (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]): (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]): (-[WebFrame _fileDoesNotExistErrorWithResponse:]): (-[WebFrame _shouldFallBackForError:]): (-[WebFrame _hasWebView]): (-[WebFrame _mainFrameURL]):
WebView/WebFrameInternal.h:

11:50 Changeset [22343] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

Reviewed by Steve.

Fix < rdar://problem/4773320>
Safari didn't pick up quicktime that was already installed

plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths):

11:43 Changeset [16934] by aroben

Reviewed by Steve.

Merging r16932 to tag.

11:41 Changeset [16933] by thatcher

Build fix.

11:30 Changeset [22342] by aroben

Reviewed by Adele.

Fixes < rdar://problem/4773142>
Crash in Settings::mediumFontSize() on ebay.com

Call cancelAndClear() from ~FrameWin (just like Mac does) so we don't
end up calling the Frame::saveDocumentState, which is pure virtual.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):

11:29 Changeset [16932] by aroben

Reviewed by Adele.

Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
already called frome ~FrameMac.

page/Frame.cpp: (WebCore::Frame::~Frame):

11:29 Changeset [16931] by darin

Reviewed, landed, tweaked a bit by Darin.

removed most uses of WebFrameBridge from WebFrameLoader (WebCoreFrameBridge use is OK)

Loader/WebDocumentLoader.m: (-[WebDocumentLoader bridge]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader initWithFrame:client:]): (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader stopLoadingSubframes]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader bridge]): (-[WebFrameLoader _handleFallbackContent]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader loadRequest:inFrameNamed:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader detachFromParent]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrameLoader safeLoadURL:]): (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
WebView/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]):
WebView/WebFrameInternal.h:

11:28 Changeset [22341] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Fix build.

11:04 Changeset [16930] by darin

Reviewed by Brady.

removed almost all direct use of WebView from WebFrameLoader

Loader/WebFrameLoader.m: (-[WebFrameLoader defersCallbacksChanged]): (-[WebFrameLoader defersCallbacks]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader closeOldDataSources]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader willChangeTitleForDocument:]): (-[WebFrameLoader didChangeTitleForDocument:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
Loader/WebFrameLoaderClient.h:
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m: (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _hasBackForwardList]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _dispatchDidReceiveIcon:]): (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]): (-[WebFrame _dispatchDidCommitLoadForFrame]): (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]): (-[WebFrame _dispatchDidFailLoadWithError:]): (-[WebFrame _dispatchDidFinishLoadForFrame]): (-[WebFrame _progressStarted]): (-[WebFrame _progressCompleted]): (-[WebFrame _incrementProgressForIdentifier:response:]): (-[WebFrame _incrementProgressForIdentifier:data:]): (-[WebFrame _completeProgressForIdentifier:]): (-[WebFrame _setMainFrameDocumentReady:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _startDownloadWithRequest:]):

10:47 Changeset [16929] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

bridge/win/FrameWin.h: Add function declaration.

10:35 Changeset [16928] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

platform/win/TemporaryLinkStubs.cpp: (FrameWin::createJavaAppletWidget): Try fixing the Win32 build.

10:21 Changeset [16927] by andersca

2006-10-09 Anders Carlsson < acarlsson@apple.com>

Reviewed by Adam.

Move applet widget creation to Frame and get rid of JavaAppletWidget.

WebCore.xcodeproj/project.pbxproj:
bridge/JavaAppletWidget.h: Removed.
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::createJavaAppletWidget):
bridge/mac/JavaAppletWidget.mm: Removed.
page/Frame.h:
rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):

02:53 Changeset [16926] by mjs

Reviewed by Alice.

moved WebFormState into Loader directory and tweaked to void WebKit dependencies

Loader/WebDocumentLoader.h:
Loader/WebFormState.h: Added.
Loader/WebFormState.m: Added. (-[WebFormState initWithForm:values:sourceFrame:]): (-[WebFormState dealloc]): (-[WebFormState form]): (-[WebFormState values]): (-[WebFormState sourceFrame]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebFrame.m:
WebView/WebFrameInternal.h:

02:29 Changeset [16925] by bdash

2006-10-09 Mitz Pettel < mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11220 Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276

Subversion does not support resource forks and HFS metadata, so
the resources for this test need to be on a disk image.

manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
manual-tests/resources/plain-text-paste.dmg: Added.
manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
manual-tests/resources/plain-text-paste/._4.txt: Removed.
manual-tests/resources/plain-text-paste/._5.webloc: Removed.
manual-tests/resources/plain-text-paste/1.textClipping: Removed.
manual-tests/resources/plain-text-paste/2.textClipping: Removed.
manual-tests/resources/plain-text-paste/3.gif: Removed.
manual-tests/resources/plain-text-paste/4.txt: Removed.
manual-tests/resources/plain-text-paste/5.webloc: Removed.

02:09 Changeset [16924] by mjs

Reviewed by Oliver.

remove dependency on WebNSURLRequestExtras.h

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):

01:59 Changeset [16923] by mjs

Reviewed by Oliver.

removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency

Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader clientRedirectCancelledOrFinished:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]):

01:44 Changeset [16922] by mjs

Reviewed by Oliver.

remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)

Loader/WebDocumentLoader.h:
Loader/WebDocumentLoader.m: (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader initialRequest]): (-[WebDocumentLoader URL]): (-[WebDocumentLoader unreachableURL]):
Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader setState:]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader opened]): (-[WebFrameLoader commitProvisionalLoad:]): (-[WebFrameLoader initialRequest]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader _notifyIconChanged:]): (-[WebFrameLoader _URL]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader transitionToCommitted:]): (-[WebFrameLoader checkLoadCompleteForThisFrame]): (-[WebFrameLoader safeLoadURL:]):
Loader/WebFrameLoaderClient.h:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge originalRequestURL]):
WebView/WebDataSource.m: (-[WebDataSource _URL]): (-[WebDataSource dealloc]): (-[WebDataSource initialRequest]): (-[WebDataSource unreachableURL]):
WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame _makeDocumentView]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _forceLayoutForNonHTML]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]): (-[WebFrame _makeRepresentationForDocumentLoader:]):

00:40 Changeset [16921] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in filter classes.

00:36 Changeset [16920] by rwlbuis

Reviewed by olliej.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in SVGPath* classes.

00:32 Changeset [16919] by mjs

Reviewed by Darin.

removed need for WebFrameLoader to now about WebDocumentLoaderMac

Loader/WebFrameLoader.m: (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
WebView/WebDocumentLoaderMac.h:
WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac setFrameLoader:]): (-[WebDocumentLoaderMac detachFromFrameLoader]):

00:27 Changeset [16918] by rwlbuis

Reviewed by aroben.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg shape classes.

00:23 Changeset [16917] by darin

Reviewed by Maciej.

passed calls that require WebScriptDebugServer across the client interface

Loader/WebFrameLoader.m: (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):

00:03 Changeset [16916] by darin

Reviewed by Maciej.

passed calls that require WebHTMLView or WebFrameView calls across the client interface

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader opened]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]): (-[WebFrameLoader reload]): (-[WebFrameLoader transitionToCommitted:]):
Loader/WebFrameLoaderClient.h:
WebView/WebFrame.m: (-[WebFrame _forceLayout]): (-[WebFrame _setDocumentViewFromPageCache:]): (-[WebFrame _setCopiesOnScroll]):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed