Timeline



Oct 23, 2006:

11:19 PM Changeset in webkit [17245] by darin
  • 19 edits in trunk

WebCore:

Reviewed by Geoff.

  • converted WebDocumentLoader to C++
  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge mainResourceURLResponse]):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::setMainResourceData): (WebCore::DocumentLoader::mainResourceData): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::bridge): (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::addResponse): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::responses): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::detachFromParent):
  • loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by Geoff.

  • converted WebDocumentLoader to C++
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _bridge]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _documentLoader]): (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource webFrame]): (-[WebDataSource initialRequest]): (-[WebDataSource request]): (-[WebDataSource response]): (-[WebDataSource textEncodingName]): (-[WebDataSource isLoading]): (-[WebDataSource unreachableURL]): (-[WebDataSource webArchive]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac): (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::dataSource): (WebDocumentLoaderMac::attachToFrame): (WebDocumentLoaderMac::detachFromFrame):
  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _addChild:]): (dataSource): (-[WebFrame _dataSourceForDocumentLoader:]): (-[WebFrame _addDocumentLoader:toUnarchiveState:]): (-[WebFrame loadArchive:]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForStandardLoad]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]): (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]): (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]): (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]): (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]): (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]): (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]): (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]): (-[WebFrame _makeRepresentationForDocumentLoader:]): (-[WebFrame _revertToProvisionalStateForDocumentLoader:]): (-[WebFrame _setMainDocumentError:forDocumentLoader:]): (-[WebFrame _clearUnarchivingStateForLoader:]): (-[WebFrame _willChangeTitleForDocument:]): (-[WebFrame _didChangeTitleForDocument:]): (-[WebFrame _finishedLoadingDocument:]): (-[WebFrame _committedLoadWithDocumentLoader:data:]): (-[WebFrame _documentLoader:setMainDocumentError:]): (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]): (-[WebFrame _createDocumentLoaderWithRequest:]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
  • WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]):
11:18 PM Changeset in webkit [22415] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Ada Chan <​adachan@apple.com>

Reviewed by sfalken.


We forgot to add a reference in WebNotificationCenter::addObserver.

10:13 PM Changeset in webkit [17244] by ggaren
  • 2 edits
    2 moves in trunk/WebKit

RS by Maciej.


Gave ObjC++ files .mm extension instead of .m.

  • WebCoreSupport/WebPageBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentLoaderMac.m: Removed.
9:59 PM Changeset in webkit [17243] by beidson
  • 6 edits in trunk/WebCore

Lovingly reviewed by Maciej

Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself

  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
  • bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
  • bridge/mac/WebCoreFrameBridge.mm: Ditto
  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
9:45 PM Changeset in webkit [17242] by ggaren
  • 5 edits in trunk/WebCore

RS by Maciej.

Inside Frame, moved the plethora of load() and stopLoading() functions next
to each other to facilitate merging and crying.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::openURLFromPageCache): (WebCore::FrameMac::createFrame):
  • page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::loadSubframe): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::stop): (WebCore::Frame::closeURL): (WebCore::Frame::cancelRedirection): (WebCore::Frame::iconURL): (WebCore::Frame::didOpenURL): (WebCore::Frame::didExplicitOpen):
  • page/Frame.h:
9:12 PM Changeset in webkit [17241] by ggaren
  • 3 edits in trunk/WebCore

RS by Maciej.

Moved our plethora of load() and stopLoading() functions next to each other
to facilitate merging and laughter.

  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (WebCore::cancelAll): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader):
8:55 PM Changeset in webkit [17240] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by

  • Build fix
8:44 PM Changeset in webkit [17239] by kmccullo
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • Makes the toTM function an operator. Was going to piggy back on a patch but the patch needs more work.
  • kjs/DateMath.cpp: (KJS::equivalentYearForDST):
  • kjs/DateMath.h: (KJS::GregorianDateTime::operator tm):
  • kjs/date_object.cpp: (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction):
8:28 PM Changeset in webkit [17238] by darin
  • 32 edits in trunk

WebCore:

Reviewed by Maciej.

  • converted WebFrameLoader to C++
  • WebCore.exp: Added many new entry points for WebKit.
  • WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge clearFrame]): (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (-[WebDocumentLoader frameLoader]): (-[WebDocumentLoader dealloc]): (-[WebDocumentLoader mainResourceData]): (-[WebDocumentLoader setRequest:]): (-[WebDocumentLoader bridge]): (-[WebDocumentLoader setMainDocumentError:]): (-[WebDocumentLoader mainReceivedError:complete:]): (-[WebDocumentLoader stopLoading]): (-[WebDocumentLoader setupForReplace]): (-[WebDocumentLoader commitIfReady]): (-[WebDocumentLoader finishedLoading]): (-[WebDocumentLoader commitLoadWithData:]): (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]): (-[WebDocumentLoader setupForReplaceByMIMEType:]): (-[WebDocumentLoader updateLoading]): (-[WebDocumentLoader setFrame:]): (-[WebDocumentLoader attachToFrame]): (-[WebDocumentLoader detachFromFrame]): (-[WebDocumentLoader prepareForLoadStart]): (-[WebDocumentLoader setPrimaryLoadComplete:]): (-[WebDocumentLoader isLoadingInAPISense]): (-[WebDocumentLoader setTitle:]):
  • loader/mac/WebFrameLoader.h: (WebCore::FrameLoader::frame):
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::defersCallbacks): (WebCore::setAllDefersCallbacks): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::cancelAll): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::load): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::download): (WebCore::FrameLoader::bridge): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::setResponse): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setFrameLoaderClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::asDelegate): (-[WebCoreFrameLoaderAsDelegate initWithLoader:]): (-[WebCoreFrameLoaderAsDelegate detachFromLoader]): (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
  • loader/mac/WebLoader.h: (WebCore::WebResourceLoader::identifier): (WebCore::WebResourceLoader::reachedTerminalState): (WebCore::WebResourceLoader::cancelled):
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::releaseResources): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::frameLoader): (WebCore::WebResourceLoader::willSendRequest): (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge): (WebCore::WebResourceLoader::didCancelAuthenticationChallenge): (WebCore::WebResourceLoader::didReceiveResponse): (WebCore::WebResourceLoader::didReceiveData): (WebCore::WebResourceLoader::didFinishLoading): (WebCore::WebResourceLoader::didFinishLoadingOnePart): (WebCore::WebResourceLoader::didFail): (WebCore::WebResourceLoader::willCacheResponse): (WebCore::WebResourceLoader::didCancel): (WebCore::WebResourceLoader::cancel): (WebCore::WebResourceLoader::cancelledError): (WebCore::WebResourceLoader::delegate):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::create): (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost): (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::policyDelegate):
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm: (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader): (WebCore::NetscapePlugInStreamLoader::create): (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): (WebCore::NetscapePlugInStreamLoader::didFinishLoading): (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):

WebKit:

Reviewed by Maciej.

  • converted WebFrameLoader to C++
  • History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]):
  • Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.mm: (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _webView]): (-[WebDataSource webFrame]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.m: (-[WebDocumentLoaderMac dealloc]): (-[WebDocumentLoaderMac attachToFrame]): (-[WebDocumentLoaderMac detachFromFrame]):
  • WebView/WebFrame.mm: (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _frameLoader]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame stopLoading]): (-[WebFrame reload]): (-[WebFrame _updateHistoryForCommit]): (-[WebFrame _updateHistoryForReload]): (-[WebFrame _updateHistoryForInternalLoad]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _deliverArchivedResources]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _clearLastHitViewIfSelf]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray removeMouseMovedObserverUnconditionally]): (-[NSArray removeMouseMovedObserver]): (-[NSArray viewWillMoveToWindow:]): (-[NSArray viewDidMoveToWindow]): (-[WebHTMLView _canMakeTextSmaller]): (-[WebHTMLView _canMakeTextLarger]): (-[WebHTMLView _canMakeTextStandardSize]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
  • WebView/WebView.mm: (-[WebView _close]): (-[WebView setDefersCallbacks:]): (-[WebView setCustomTextEncodingName:]):
8:23 PM Changeset in webkit [22414] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Bradee.

Removed methods from BrowserExtension.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::canPaste): (FrameWin::canGoBackOrForward): (FrameWin::goBackOrForward): (FrameWin::getHistoryLength): (FrameWin::historyURL): (Page::canRunModal): (Page::canRunModalNow): (Page::runModal): (BrowserExtensionWin::BrowserExtensionWin):
8:18 PM Changeset in webkit [17237] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • Fixes two regressions on win. Both are stack overflows. For one the number of regressions is capped at 100, and for the other, nested parenthesis pairs are not evaluated (since they would evaluate to whatever is in them anyway).
  • kjs/grammar.y:
  • kjs/object.cpp:
8:18 PM Changeset in webkit [17236] by ggaren
  • 17 edits in trunk

WebCore:

Reviewed by Bradee.

Shrunk BrowserExtension in preparation for its imminent death, moving page-
level operations to Page and frame-level operations to Frame.


Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
because 'this' is guaranteed by the compiler to be a FrameMac*.


  • bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places where it can be NULL.
  • bindings/js/kjs_window.cpp: (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::unfocusWindow): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::documentViewForNode): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameMac::customHighlightLineRect): (WebCore::FrameMac::paintCustomHighlight): (WebCore::FrameMac::getHistoryLength): (WebCore::FrameMac::goBackOrForward): (WebCore::FrameMac::historyURL):
  • bridge/mac/PageMac.mm: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/win/BrowserExtensionWin.h:
  • page/Frame.cpp: (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • page/Page.h:

WebKit:

Reviewed by Bradee.

Moved some page-level operations from WebFrameBridge to WebPageBridge.

  • WebCoreSupport/WebFrameBridge.m:
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge createModalDialogWithURL:referrer:]): (-[WebPageBridge canRunModal]): (-[WebPageBridge canRunModalNow]): (-[WebPageBridge runModal]):
  • WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support WebCore #includes.
7:36 PM Changeset in webkit [17235] by justing
  • 2 adds in trunk/LayoutTests/editing/execCommand
7:35 PM Changeset in webkit [17234] by justing
  • 7 edits in trunk

LayoutTests:

Reviewed by mjs


<​http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

  • editing/execCommand/queryCommandState-01-expected.txt: Added.
  • editing/execCommand/queryCommandState-01.html: Added.

WebCore:

Reviewed by mjs

<​http://bugs.webkit.org/show_bug.cgi?id=11334>
Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons

  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): Added. (WebCore::Editor::selectionOrderedListState): Added.
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
4:57 PM Changeset in webkit [17233] by sullivan
  • 2 edits in trunk/WebKit
  • WebKitPrefix.h: Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had already been added between the last time I updated in this tree and when I needed it locally.
4:10 PM Changeset in webkit [17232] by sullivan
  • 1 edit in trunk/WebKit/WebKitPrefix.h

Checked in this file that I mentioned in the previous ChangeLog entry but forgot to check in.

4:03 PM Changeset in webkit [17231] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Ander

  • WebKit.xcodeproj/project.pbxproj: Move WebKitPrefix.h from Misc group to top level, to match WebCore


  • WebKitPrefix.h: defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
3:56 PM Changeset in webkit [17230] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim H

  • WebCore.xcodeproj/project.pbxproj: Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
3:40 PM Changeset in webkit [17229] by thatcher
  • 4 edits
    10 moves in trunk/WebKit

Reviewed by Darin.

Rename the now ObjC++ files to be .mm and remove the explicit file types.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
  • English.lproj/StringsNotToBeLocalized.txt:
  • Plugins/WebBaseNetscapePluginView.m: Removed.
  • Plugins/WebNetscapePluginStream.m: Removed.
  • Plugins/WebPluginController.m: Removed.
  • WebCoreSupport/WebFrameBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: Removed.
  • WebView/WebFrame.m: Removed.
  • WebView/WebFrameView.m: Removed.
  • WebView/WebPDFView.m: Removed.
  • WebView/WebPolicyDelegate.m: Removed.
  • WebView/WebView.m: Removed.
3:27 PM Changeset in webkit [17228] by thatcher
  • 5 edits
    2 adds in trunk/WebKit

Reviewed by Darin.

Move the undef try/catch to WebKitPrfix.h and include algorithm so we get
exception_defines.h and so the undef of try/catch works.

Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
framework to complain about C++ exceptions being disabled.

  • Misc/WebGraphicsExtras.c: Added. (WebConvertBGRAToARGB):
  • Misc/WebGraphicsExtras.h: Added.
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView/WebView.m:
3:22 PM Changeset in webkit [17227] by weinig
  • 3 edits
    16 adds
    16 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11291
PNG as cursor image format instead of TIFF

Original patch by Lars Naesbye Christensen (​larsnaesbye@stud.ku.dk)

  • Convert cursor images from TIFF to PNG.
  • Resources/eastResizeCursor.png: Added.
  • Resources/eastResizeCursor.tiff: Removed.
  • Resources/eastWestResizeCursor.png: Added.
  • Resources/eastWestResizeCursor.tiff: Removed.
  • Resources/helpCursor.png: Added.
  • Resources/helpCursor.tiff: Removed.
  • Resources/linkCursor.png: Added.
  • Resources/linkCursor.tiff: Removed.
  • Resources/moveCursor.png: Added.
  • Resources/moveCursor.tiff: Removed.
  • Resources/northEastResizeCursor.png: Added.
  • Resources/northEastResizeCursor.tiff: Removed.
  • Resources/northEastSouthWestResizeCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.tiff: Removed.
  • Resources/northResizeCursor.png: Added.
  • Resources/northResizeCursor.tiff: Removed.
  • Resources/northSouthResizeCursor.png: Added.
  • Resources/northSouthResizeCursor.tiff: Removed.
  • Resources/northWestResizeCursor.png: Added.
  • Resources/northWestResizeCursor.tiff: Removed.
  • Resources/northWestSouthEastResizeCursor.png: Added.
  • Resources/northWestSouthEastResizeCursor.tiff: Removed.
  • Resources/southEastResizeCursor.png: Added.
  • Resources/southEastResizeCursor.tiff: Removed.
  • Resources/southResizeCursor.png: Added.
  • Resources/southResizeCursor.tiff: Removed.
  • Resources/southWestResizeCursor.png: Added.
  • Resources/southWestResizeCursor.tiff: Removed.
  • Resources/waitCursor.png: Added.
  • Resources/waitCursor.tiff: Removed.
  • Resources/westResizeCursor.png: Added.
  • Resources/westResizeCursor.tiff: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor):
3:15 PM Changeset in webkit [17226] by mjs
  • 3 edits in trunk/WebCore

Not reviewed.

  • fixed build from last change.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::openURL):
3:03 PM Changeset in webkit [22413] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adele.

Fix: <rdar://problem/4796994> Styled <select>s should still use Windows
theme

The fix is to do most of our drawing for menulists in
RenderThemeWin::paintMenuListButton (which is called for styled
<select>s), and then do any extra drawing for unstyled <select>s in
RenderThemeWin::paintMenuList.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::getThemeData): Case for MenulistButtonAppearance should be the same as MenulistAppearance. (WebCore::RenderThemeWin::paintMenuList): Draw the border, then defer to paintMenuListButton to handle the rest of painting. (WebCore::RenderThemeWin::adjustMenuListStyle): Reset the border so we can draw our own, then defer to adjustMenuListStyle. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Code moved from adjustMenuListStyle, less the call to resetBorder(). (WebCore::RenderThemeWin::paintMenuListButton): Code moved from paintMenuList, less the border-drawing code.
  • rendering/RenderThemeWin.h:
3:00 PM Changeset in webkit [17225] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Adele.

Move border-radius rule for <select>s into RenderThemeMac, as this is
really a platform-specific look.

  • css/html4.css:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
2:53 PM Changeset in webkit [22412] by sfalken
  • 8 edits in branches/WindowsMerge/WebKitWin

2006-10-23 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou.

  • MarshallingHelpers.cpp: (MarshallingHelpers::BSTRToCFStringRef): Fix leak in BSTRToCFStringRef
  • WebEditorClient.cpp: (WebEditorClient::WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView (WebEditorClient::~WebEditorClient): Break dependency cycle by not holding a COM ref to the WebView
  • WebFrame.cpp: (WebFrame::initWithWebFrameView): (WebFrame::windowResizerRect): Fix reference leaks
  • WebHistory.cpp: (createUserInfoFromArray): Fixed leak of key CFStringRef. (WebHistory::setOptionalSharedHistory): Made this callable with a 0 to release shared history (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Don't hold a ref to the WebHistory (_WebCoreHistoryProvider::containsItemForURLLatin1): Don't hold a ref to the WebHistoryPrivate
  • WebHistoryItem.cpp: (WebHistoryItem::WebHistoryItem): Don't hold a reference to the WebIconDatabase
  • WebIconDatabase.cpp: (WebIconDatabase::~WebIconDatabase): Delete core icon db on delete
  • WebNotificationCenter.cpp: (ObserverKey::ObserverKey): Init data to 0 before calling assignment op (ObserverKey::operator=): Free old string, release old ref if needed before copy
2:44 PM Changeset in webkit [17224] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Brady.

  • moved things around so loadURL:... is only called from one place
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::frameDetached): (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
2:29 PM Changeset in webkit [17223] by justing
  • 7 edits
    20 adds in trunk

LayoutTests:

Reviewed by john

<​http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document

  • editing/inserting/insert-br-009-expected.checksum: Added.
  • editing/inserting/insert-br-009-expected.png: Added.
  • editing/inserting/insert-br-009-expected.txt: Added.
  • editing/inserting/insert-br-009.html: Added.
  • editing/inserting/insert-paragraph-01-expected.checksum: Added.
  • editing/inserting/insert-paragraph-01-expected.png: Added.
  • editing/inserting/insert-paragraph-01-expected.txt: Added.
  • editing/inserting/insert-paragraph-01.html: Added.
  • editing/inserting/insert-paragraph-02-expected.checksum: Added.
  • editing/inserting/insert-paragraph-02-expected.png: Added.
  • editing/inserting/insert-paragraph-02-expected.txt: Added.
  • editing/inserting/insert-paragraph-02.html: Added.
  • editing/inserting/insert-paragraph-03-expected.checksum: Added.
  • editing/inserting/insert-paragraph-03-expected.png: Added.
  • editing/inserting/insert-paragraph-03-expected.txt: Added.
  • editing/inserting/insert-paragraph-03.html: Added.
  • editing/inserting/insert-paragraph-04-expected.checksum: Added.
  • editing/inserting/insert-paragraph-04-expected.png: Added.
  • editing/inserting/insert-paragraph-04-expected.txt: Added.
  • editing/inserting/insert-paragraph-04.html: Added.

WebCore:

Reviewed by john


<​http://bugs.webkit.org/show_bug.cgi?id=11333>
Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document


Added special cases in InsertLineBreakCommand for inserting before
and after tables and horizontal rules. Also, perform InsertLineBreak
instead of InsertParagraphSeparator at these positions.

  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Use the canonical form of the caret position when we check for the new special cases because we know that we canonicalize VisiblePositions to those positions. Added code to handle inserting before/after tables and horizontal rules. Fixed a bug when inserting at the end of a block (it checked for a collapse of the inserted br by looking for the absence of a br, but the line break might have been a '\n' in white-space:pre text). Removed unused LOGs.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an InsertLineBreakCommand when before/after a table or a horizontal rule so that we don't have to maintain two pieces of special case code. Migrated to enclosingBlock.
  • editing/htmlediting.cpp: Added a FIXME.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Added a workaround for 8622.
1:59 PM Changeset in webkit [17222] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-10-21 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Add minimal compatibility with MSVCRT leak checker

  • wtf/FastMalloc.h:
1:37 PM Changeset in webkit [22411] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4786759> PageUp/PageDown/Home/End don't work in
<select> menus

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): Only call ::UpdateWindow if we didn't scroll, because scrolling will do the update for us. (WebCore::PopupMenu::focusFirst): New method. (WebCore::PopupMenu::focusLast): New method. (WebCore::PopupMenu::down): Add a parameter to specify how far we should try to move the selection. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): Cleanup code by using IntRect instead of RECT. (WebCore::PopupMenu::scrollTo): Return a boolean to say whether scrolling actually happened. (WebCore::PopupMenu::scrollToRevealSelection): Ditto. (WebCore::PopupWndProc): Handle PageUp/PageDown/Home/End.
1:34 PM Changeset in webkit [17221] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Make popups a little more flexible.

  • platform/PopupMenu.h:
12:45 PM Changeset in webkit [17220] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup CodeGeneratorJS.pm

  • bindings/scripts/CodeGeneratorJS.pm:
12:21 PM Changeset in webkit [17219] by thatcher
  • 2 edits in trunk/WebCore/Resources

Reverting two images that got commited as empty files after being compressed.

12:03 PM Changeset in webkit [17218] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

  • Sets the lowercase range correctly in the test and consolidates a variable to make the test more readable.
  • tests/mozilla/ecma/String/15.5.4.11-2.js:
11:58 AM Changeset in webkit [17217] by thatcher
  • 2 edits in trunk/WebKit

Build fix.

11:35 AM Changeset in webkit [17216] by thatcher
  • 2 edits in trunk

Build fix. We can't make the internal DOM headers private since they are not generated at the time installhdrs is called, this break B&I builds.

11:24 AM Changeset in webkit [22410] by aroben
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Copy headers from new platform/network directory and subdirectories.

WebKitWin:

Build fix.

  • WebFrame.cpp: Change header paths to point to new platform/network directory and subdirectories.
  • WebFrame.h: Ditto.
  • WebURLResponse.cpp: Ditto.
  • WebURLResponse.h: Ditto.
  • WebView.cpp: Ditto.
  • WebKit.vcproj/WebKit.vcproj: Add platform/network and subdirectories to AdditionalIncludeDirectories.
11:23 AM Changeset in webkit [17215] by thatcher
  • 4 edits in trunk/WebCore/Resources

Compressing TIFFs to fix verification error.

10:02 AM Changeset in webkit [22409] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • plugins/win/PluginStreamWin.h: Rename methods to match Maciej's changes.
9:50 AM Changeset in webkit [17214] by aroben
  • 2 edits in trunk/WebCore

Rubberstamped by Brady.

  • loader/icon/IconLoader.h: Changed angle-brackets to quotes for #include of ResourceLoader.h, since it's a WebCore header.
9:50 AM Changeset in webkit [22408] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Copied AdditionalIncludeDirectories from Release to All Configurations.
8:47 AM Changeset in webkit [17213] by darin
  • 2 edits in trunk/WebCore
  • fixed mistake that was preventing any loading from happening
  • platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): Changed parameter back to int. Perhaps we want to move to "long long" consistently, but I'll leave that up to Maciej.
3:01 AM Changeset in webkit [22407] by mjs
  • 7 edits in branches/WindowsMerge

WebCoreWin:

Rubber-stamped by Anders.

  • fixed for ResourceLoader refactoring.
  • platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):

WebKitWin:

Rubber-stamped by Anders.

  • fixed for ResourceLoader refactoring.
  • WebFrame.cpp: (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
  • WebFrame.h:
2:07 AM Changeset in webkit [17212] by mjs
  • 17 edits in trunk/WebCore

Reviewed by Anders.

  • start converting ResourceLoaderClient to new API

Did the bits I could do without introducing new types:


  • renamed receivedData to didReceiveData
  • renamed version of receivedAllData that doesn't pass any data to didFinishLoading
  • bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
  • loader/icon/IconLoader.cpp: (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::didReceiveData):
  • loader/loader.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::didReceiveData):
  • platform/gdk/FrameGdk.h:
  • platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData): (WebCore::ResourceLoaderClient::didFinishLoading): (WebCore::ResourceLoaderClient::receivedResponse):
  • platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceLoader::cancel):
  • platform/network/gdk/ResourceLoaderManager.cpp: (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove):
  • platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::remove):
  • platform/network/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onRequestComplete): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::didReceiveData):
  • platform/qt/FrameQtClient.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
1:00 AM Changeset in webkit [17211] by mjs
  • 1 edit in trunk/WebCore/ChangeLog

Rubber stamped by Anders.

  • marked files executable


  • ksvg2/scripts/csscssmakeprops:
  • ksvg2/scripts/csscssmakevalues:

Oct 22, 2006:

5:44 PM Changeset in webkit [22406] by mjs
  • 2 edits
    2 moves
    2 adds in branches/WindowsMerge/WebCore

Reviewed by Anders.

  • updated for new ResourceLoader file locations.
  • WebCore.vcproj/WebCore.vcproj: Updated file paths.
  • platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win
  • platform/win/ResourceLoaderWin.h: ditto
5:20 PM Changeset in webkit [17210] by mjs
  • 6 edits
    15 moves
    6 adds in trunk/WebCore

Reviewed by Anders.

  • moved ResourceLoader and related files to platform/network in preparation for building out this API.

I tried to update all the build systems but I'm not sure they are
all fixed properly

  • page/ResourceRequest.h: Moved to platform/network.
  • platform/ResourceLoader.cpp: Moved to platform/network.
  • platform/ResourceLoader.h: Moved to platform/network.
  • platform/ResourceLoaderClient.h: Moved to platform/network.
  • platform/ResourceLoaderInternal.h: Moved to platform/network.
  • platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
  • platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
  • platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
  • platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
  • platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
  • platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
  • platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
  • platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
  • platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
  • platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
  • webcore-base.bkl: Updated for new paths.
  • CMakeLists.txt: ditto
  • Projects/gdk/webcore-gdk.bkl: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • WebCoreSources.bkl: ditto
12:59 PM Changeset in webkit [22405] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Fix some crashes caused by the <select> element being detached while
the popup is open.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc):
11:01 AM Changeset in webkit [17209] by weinig
  • 5 edits in trunk

WebCore:

Reviewed by Tim H.

  • Add DOMHTMLFormElementPrivate.h to the project.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:

WebKit:

Reviewed by Tim H.

  • Add DOMHTMLFormElementPrivate.h to the project.
  • MigrateHeaders.make:
12:31 AM Changeset in webkit [17208] by darin
  • 4 edits in trunk/WebCore
  • another try at fixing Qt
  • CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
  • and fix a couple warnings while I'm at it
  • platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA): Don't do unsigned *= float.
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable inside #if so it's consistent.

Oct 21, 2006:

11:51 PM Changeset in webkit [17207] by darin
  • 4 edits in trunk/WebCore
  • fix the Qt build
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldShowDeleteInterface):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp:
11:39 PM Changeset in webkit [17206] by darin
  • 21 edits in trunk

WebCore:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

  • WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
  • WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
  • platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
  • loader/mac/WebLoader.h:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: Translate to C++.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
8:22 PM Changeset in webkit [22404] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fix: <rdar://problem/4794151> Popup should scroll to reveal selected
item, not just one line at a time
Fix: <rdar://problem/4794229> Popup hot-tracking should not change text
in <select> control

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Cleaned up code by translating into screen coordinates right away. (WebCore::PopupMenu::setFocusedIndex): Added parameter to specify whether the text in the <select> control should be updated. (WebCore::PopupMenu::scrollTo): Extracted scrolling code from PopupWndProc to here. (WebCore::PopupMenu::scrollToRevealSelection): New method. (WebCore::PopupWndProc): Use scrollToRevealSelection() instead of manually scrolling one line at a time. Fixed a bug in detecting a mouse drag. Pass in HDC from ::BeginPaint to PopupMenu::paint.
8:19 PM Changeset in webkit [17205] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Popup tweaks.

  • platform/PopupMenu.h:
8:10 PM Changeset in webkit [17204] by darin
  • 2 edits in trunk/WebCore
  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable): Oops, edited this before landing it and introduced a null-deref! This fixes it.
7:59 PM Changeset in webkit [17203] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/commit-log-editor: Use baseProductDir() to find the base product directory. This was still using "symroots" so it almost never worked!
7:58 PM Changeset in webkit [17202] by darin
  • 12 edits in trunk/WebCore

Reviewed by Anders.

I cleaned up the relationship between the Frame, Editor, EditorClient, and
DeleteButtonController a bit while also making the simple change to fix the
assertion failure.

  • bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
  • page/Frame.cpp: (WebCore::Frame::Frame): Ditto. (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents function, and moved it to Editor rather than right on the DeleteButtonController. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
  • editing/DeleteButtonController.h:
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*. The general pattern is that we always use the Frame* as the frame identifier. See FrameTree, for example. (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection function. Includes an additional check for whether the container is contentEditable, which was missing from the old version. This prevents the assertion failure. Also added a check that the table itself is editable. (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper. (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary selection parameter. No need to pass in the state of the frame since we can get it if we need it. (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
  • editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be formatted on multiple lines as usual. (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller. (WebCore::Editor::respondToChangedContents): Ditto. (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
  • editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being defined inline to decouple so that we don't have to include DeleteButtonController.h. That way changes to DeleteButtonController.h cause very little to recompile.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Updated to call the editor instead of the delete button controller for the selection change.
7:38 PM Changeset in webkit [17201] by andersca
  • 3 edits in trunk/WebCore

2006-10-21 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't leak the header dictionary.
7:09 PM Changeset in webkit [22403] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add new DeleteButton* files to project.
6:55 PM Changeset in webkit [17200] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/Vector.h: (WTF::VectorBuffer::swap): Added. (WTF::Vector::swap): Added. (WTF::swap): Added overload that takes two Vector objects.
6:52 PM Changeset in webkit [17199] by darin
  • 3 edits in trunk/WebKit

Reviewed by Anders.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): Don't retain the web view. (WebEditorClient::~WebEditorClient): Don't release the web view. (WebEditorClient::setWebView): Ditto.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both init methods below. (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method. Also added comment pointing out design flaw -- we attach the client to the web view here, but we need to be sure to detach in case the web view is deallocated first. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
6:24 PM Changeset in webkit [17198] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

  • JavaScriptCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebCore:

Reviewed by Adam.

  • WebCore.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.

WebKit:

Reviewed by Adam.

  • WebKit.xcodeproj/project.pbxproj: Pass -j sysctl -n hw.ncpu to make.
6:15 PM Changeset in webkit [17197] by darin
  • 3 edits
    1 copy in trunk/WebKitTools
  • Makefile: Build DumpRenderTree too.
  • Scripts/do-webcore-rename: Removed bogus comment.
11:46 AM Changeset in webkit [22402] by thatcher
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Stub out the new shouldShowDeleteInterface method.

  • WebEditorClient.cpp: (WebEditorClient::shouldShowDeleteInterface):
  • WebEditorClient.h:
11:40 AM Changeset in webkit [17196] by thatcher
  • 18 edits
    7 adds in trunk

WebCore:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Interface shows up on the nearest table containing the entire selection.
  • Shows a Dashboard style close button in the top left corner.
  • Shows a 60% opaque black outline around the table.
  • Adds a new EditorClient function shouldShowDeleteInterface.

Also adds a new constructor CachedImage and setter functions on
HTMLImageElement and HTMLImageLoader allowing an Image object to be set
and image element in the page. This change also paves the way to allow an
NSImage setter on DOMHTMLImageElement.

  • Resources/deleteButton.tiff: Added.
  • Resources/deleteButtonPressed.tiff: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • editing/DeleteButton.cpp: Added. (WebCore::DeleteButton::DeleteButton): (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
  • editing/DeleteButton.h: Added.
  • editing/DeleteButtonController.cpp: Added. (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size (WebCore::DeleteButtonController::show): shows the interface on a new element (WebCore::DeleteButtonController::hide): hides the existing interface (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
  • editing/DeleteButtonController.h: Added. (WebCore::DeleteButtonController::target): getter for the current target
  • editing/Editor.cpp: (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
  • editing/Editor.h: (WebCore::Editor::frame): new getter (WebCore::Editor::deleteButtonController): ditto
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
  • html/HTMLImageElement.h: (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): ditto
  • html/HTMLImageLoader.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): new constructor that takes an Image
  • loader/CachedImage.h: ditto
  • page/Frame.cpp: (WebCore::Frame::selectionController): cleanup coding style (WebCore::Frame::editor): ditto (WebCore::Frame::command): ditto (WebCore::Frame::appliedEditing): tell the delete button outline to update (WebCore::Frame::unappliedEditing): ditto (WebCore::Frame::reappliedEditing): ditto
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed

WebKit:

Reviewed by Geoff.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Initial implementaltion of table deletion user interface:

  • Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
  • The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
  • DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebEditingDelegatePrivate.h: Added.
11:37 AM Changeset in webkit [17195] by weinig
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Cleanup bindings generation a little through re-factoring
and general style cleanup.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
8:41 AM Changeset in webkit [17194] by weinig
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Mitz.

Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.

  • CMakeLists.txt:
  • platform/qt/EditorClientQt.cpp: Added. (WebCore::EditorClientQt::shouldDeleteRange):
  • platform/qt/EditorClientQt.h: Added. (WebCore::EditorClientQt::~EditorClientQt):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/FrameQt.h:
6:34 AM Changeset in webkit [17193] by weinig
  • 8 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11372
Auto-generate a few more Objective-C DOM methods.

  • Auto-generate getMatchedCSSRules and getComputedStyle methods.
  • bindings/objc/DOMCSS.h:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Document.idl:
  • page/DOMWindow.idl:
3:15 AM Changeset in webkit [17192] by aliceli1
  • 3 edits
    1 add in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by aliu, landed by aliu.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt):
  • platform/qt/SoundQt.cpp: Added. (WebCore::systemBeep):
3:01 AM Changeset in webkit [17191] by aliceli1
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

fix leaks.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView): only change webview if its different
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): actually use the client allocated in the line above instead of allocation again, duh.
2:12 AM Changeset in webkit [17190] by ap
  • 2 edits in trunk/WebCore

2006-10-21 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz, landed by ap.

Fix obscure crashes in RenderTableSection on Rob's musicdb file.
The problem was a missing layout() call on the frame view.
Thanks go to Mitz Pettel for the initial hint!

  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::paintEvent):
1:45 AM Changeset in webkit [17189] by aliceli1
  • 3 edits in trunk/WebKit

Build fix.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::setWebView):

Oct 20, 2006:

11:43 PM Changeset in webkit [17188] by aliceli1
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Fixed a problem where the webview passed to the EditorClient wasn't valid yet.

  • WebCoreSupport/WebEditorClient.h: (WebEditorClient::setWebView): added webview setter
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): add default constructor
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): use [page webView] since _webview isn't valid yet (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): use webview setter on editorclient
11:37 PM Changeset in webkit [22401] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix build bustage and horrible memory leak.

11:20 PM Changeset in webkit [17187] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.

Send User-Agent on requests.
Send custom request headers properly.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
11:05 PM Changeset in webkit [22400] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Hyatt.


Make the auto-version script work with paths that contain spaces

9:57 PM Changeset in webkit [17186] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix some bad formatting.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
9:48 PM Changeset in webkit [22399] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Match the change I made on Mac in the public tree.

9:45 PM Changeset in webkit [22398] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • WebView.cpp: (webKitVersion):
9:45 PM Changeset in webkit [17185] by hyatt
  • 2 edits in trunk/WebKit

Tweak cache sizes so that they are back to the way they were,
except for < 512, which will stay doubled.

Reviewed by Tim H.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
9:42 PM Changeset in webkit [17184] by thatcher
  • 7 edits
    4 adds in trunk/WebKitTools

Reviewed by Tim H.

Bug 11367: Inline Breakpoint Editor Improvements: Act III
​http://bugs.webkit.org/show_bug.cgi?id=11367

Major breakpoint editor changes:

  • Breakpoints can now either pause or log to console
  • Code cleanup through use of XPath and converting breakpoints to objects
  • Breakpoints now track how many times they've been reached
  • UI tweaks
  • The breakpoint editor now saves changes as they're entered
  • Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
  • If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.
  • Drosera/DebuggerDocument.m: (-[WebScriptObject breakpointEditorHTML]): A way of loading this from an external file, as it was getting too complex to include inline.
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Images/close.tif: Added.
  • Drosera/Images/close_active.tif: Added.
  • Drosera/Images/close_hover.tif: Added.
  • Drosera/breakpointEditor.html: Added.
  • Drosera/console.js: Added a way to append messages from outside the console window.
  • Drosera/debugger.js:
  • Drosera/viewer.css:
  • Drosera/viewer.html:
8:57 PM Changeset in webkit [22397] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.

Turn on CFNetwork

  • config.h:
8:55 PM Changeset in webkit [22396] by sfalken
  • 12 edits
    3 adds
    1 delete in branches/WindowsMerge

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


<rdar://4778502> Boomer userAgent string needs to support pulling in proper build #, plus customization


Useragent/versioning changes


Stamp auto-generated version number into DLL and into user agent.
Generate a real user agent string instead of hardcoding one.
Support client supplying an application name for the user agent.
Support client overriding the useragent (for debug menu).
Support per-URL user agents (not used at least for now).

Also fixed a bug I recently introduced that broke form submit.

7:02 PM Changeset in webkit [17183] by ggaren
  • 1 edit
    13 adds
    15 deletes in trunk/LayoutTests

RS by Beth "pants on fire" Dakin.


Put some layout tests in their place.

  • fast/dom/Window/window-object-cross-frame-calls-expected.txt: Added.
  • fast/dom/Window/window-object-cross-frame-calls.html: Added.
  • fast/dom/Window/window-onFocus-expected.checksum: Added.
  • fast/dom/Window/window-onFocus-expected.png: Added.
  • fast/dom/Window/window-onFocus-expected.txt: Added.
  • fast/dom/Window/window-onFocus.html: Added.
  • fast/dom/Window/window-xy-properties-expected.txt: Added.
  • fast/dom/Window/window-xy-properties.html: Added.
  • fast/dom/window-object-cross-frame-calls-expected.txt: Removed.
  • fast/dom/window-object-cross-frame-calls.html: Removed.
  • fast/dom/window-onFocus-expected.checksum: Removed.
  • fast/dom/window-onFocus-expected.png: Removed.
  • fast/dom/window-onFocus-expected.txt: Removed.
  • fast/dom/window-onFocus.html: Removed.
  • fast/dom/window-xy-properties-expected.txt: Removed.
  • fast/dom/window-xy-properties.html: Removed.
  • fast/html/xhtml-serialize-expected.txt: Added.
  • fast/html/xhtml-serialize.html: Added.
  • fast/js/resources/xhtml-serialize.js: Removed.
  • fast/js/resources/xslt-fragment-in-empty-doc.js: Removed.
  • fast/js/xhtml-serialize-expected.txt: Removed.
  • fast/js/xhtml-serialize.html: Removed.
  • fast/js/xslt-fragment-in-empty-doc-expected.txt: Removed.
  • fast/js/xslt-fragment-in-empty-doc.html: Removed.
  • fast/xsl/xslt-fragment-in-empty-doc-expected.txt: Added.
  • fast/xsl/xslt-fragment-in-empty-doc.html: Added.
  • fast/dom/resources/child.html: Removed.
  • fast/dom/Window/resources/child.html: Added.
6:34 PM Changeset in webkit [17182] by bdakin
  • 9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these counters tests because they fail on some people's
machines. They fail for people who have the Armenian glyphs the
tests were looking for in the "expected" line. There is no point in
testing that anyway, since we do not currently support Armenian in
counters or in list markers.

  • fast/css/counters/counter10-expected.checksum:
  • fast/css/counters/counter10-expected.png:
  • fast/css/counters/counter10-expected.txt:
  • fast/css/counters/counter10.html:
  • fast/css/counters/counters10-expected.checksum:
  • fast/css/counters/counters10-expected.png:
  • fast/css/counters/counters10-expected.txt:
  • fast/css/counters/counters10.html:
6:07 PM Changeset in webkit [17181] by ggaren
  • 1 edit
    2 adds
    4 deletes in trunk/LayoutTests

Reviewed by Anders.


Removed old window property tests because they didn't quite work and they
were looking at me funny. Replaced with new, comprehensive test.

  • fast/dom/Window/window-properties-expected.txt: Added.
  • fast/dom/Window/window-properties.html: Added.
  • fast/js/window-properties-expected.txt: Removed.
  • fast/js/window-properties.html: Removed.
  • fast/js/window-properties2-expected.txt: Removed.
  • fast/js/window-properties2.html: Removed.
5:43 PM Changeset in webkit [17180] by darin
  • 3 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
  • loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key" as the key, not the dictionary itself.
4:57 PM Changeset in webkit [17179] by aliceli1
  • 13 edits
    7 adds in trunk

WebCore:

Reviewed by Maciej.

This is the initial foundation for the EditingController class and
everything else it needs to work. The idea is that the Frame has an
EditingController object that it calls to handle editing commands, the
most simple examples being copy/paste. This controller will handle
these editing commands in WebCore, and only hand off to WebKit to call
editing delegates (to the let the app intercept editing actions if it
wants to). Thus we need a platform-specific client to which the
EditingController hands off the delegate calls,
WebCoreEditingControllerClient. On the WebCore side this is an
abstract base class, and on the WebKit(Mac) side this is an ObjC++
subclass, WebEditingControllerClient. How does the EditingController
get a handle to its platform-specific client? In WebKit, the creator
of a platform-specific Frame creates the client (which is ref-counted)
and passes it down the chain of constructors until it gets back to the
EditingController, which then refs it in its constructor and derefs in
its destructor.


No Layout tests needed.


  • WebCore.xcodeproj/project.pbxproj: Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
  • bridge/EditorClient.h: Added. (WebCore::EditorClient::~EditorClient):
  • bridge/mac/FrameMac.h: Added an EditingClient to the constructor, to pass down to Frame constructor
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Passed client down to Frame constructor


  • bridge/mac/WebCoreFrameBridge.h: Added an EditingClient to the constructor, to pass down to FrameMac constructor


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Passed client down to FrameMac constructor


  • editing/Editor.cpp: Added. Mostly stuf implementations of the following functions, except for a couple. These are all needed by cut, copy, paste, delete. (WebCore::generalPasteboard): (WebCore::Editor::canCopy): (WebCore::Editor::canCut): (WebCore::Editor::canDelete): (WebCore::Editor::canDeleteRange): (WebCore::Editor::canPaste): (WebCore::Editor::canSmartCopyOrDelete): (WebCore::Editor::deleteSelection): (WebCore::Editor::deleteSelectionWithSmartDelete): (WebCore::Editor::isSelectionRichlyEditable): (WebCore::Editor::pasteAsPlainTextWithPasteboard): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::selectedRange): (WebCore::Editor::shouldDeleteRange): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): (WebCore::Editor::tryDHTMLPaste): (WebCore::Editor::writeSelectionToPasteboard): (WebCore::Editor::Editor): (WebCore::Editor::~Editor): (WebCore::Editor::cut): (WebCore::Editor::copy): (WebCore::Editor::paste): (WebCore::Editor::performDelete):


  • editing/Editor.h: Added.


  • page/Frame.h: Added an EditingClient to the constructor, to pass down to Editor constructor
  • page/Frame.cpp: (WebCore::Frame::Frame): Passed down to Editor constructor (WebCore::Frame::editor): Accessfor for Editor stored in FramePrivate


  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added an Editor object to the FramePrivate data


  • platform/Sound.h: Added. Made a platform-independent accessor to a beep function


  • platform/mac/SoundMac.mm: Added. (WebCore::systemBeep): calls mac system beep

WebKit:

Reviewed by Maciej.

Adding knowledge of EditorClient to WebKit

  • WebCoreSupport/WebEditorClient.h: Added.
  • WebCoreSupport/WebEditorClient.mm: Added. (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): Implementation of mac EditorClient
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): create an editor client to pass down the chain of constructors
  • WebKit.xcodeproj/project.pbxproj: Added related EditorClient files
  • WebKitPrefix.h: Added tiger build flag in order to make certain private headers from webcore compile successfully
4:56 PM Changeset in webkit [22395] by aliceli1
  • 8 edits
    3 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Steve.

Adding knowledge of the Editor and EditorClient to Windows WebCore

No layout tests needed


  • WebCore.vcproj/WebCore.vcproj: added Sound.h, SoundWin.cpp, EditorClient.h, Editor.h&.cpp
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): added client to constructor params
  • bridge/win/FrameWin.h: added client to constructor params
  • platform/win/SoundWin.cpp: Added. (WebCore::systemBeep): Calls windows system beep

WebKitWin:

Reviewed by Steve and Maciej.

Adding knowledge of the Editor and EditorClient to Windows WebKit

  • Interfaces/IWebEditingDelegate.idl: needs IWebView.idl


  • WebEditorClient.cpp: Added (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldBeginEditingInRange): (WebEditorClient::shouldEndEditingInRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidBeginEditing): (WebEditorClient::webViewDidChange): (WebEditorClient::webViewDidEndEditing): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection):


  • WebEditorClient.h: Added.


  • WebFrame.cpp: (WebFrame::initWithWebFrameView): created an editor client


  • WebKit.vcproj/WebKit.vcproj: added WebEditorClient files
4:32 PM Changeset in webkit [17178] by hyatt
  • 2 adds in trunk/LayoutTests/fast/forms

Add encoding layout test for forms.

4:13 PM Changeset in webkit [17177] by hyatt
  • 3 edits in trunk/WebCore

Make sure to support the "encoding" property on form elements for
legacy compatibility.

Reviewed by darin/john

No test cases added. Not sure how to do a form submission of
various encodings as a layout test.

  • html/HTMLFormElement.h: (WebCore::HTMLFormElement::encoding): (WebCore::HTMLFormElement::setEncoding):
  • html/HTMLFormElement.idl:
3:55 PM Changeset in webkit [17176] by andersca
  • 3 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and by Anders.

Fix warnings in JS generation by killing the whole isRefPtr logic,
and just using WTF::getPtr as Sam Weinig suggested. Also kill some
places using get() where getPtr() is cleaner - not for m_impl.get().

  • CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
  • bindings/scripts/CodeGeneratorJS.pm:
3:21 PM Changeset in webkit [17175] by darin
  • 21 edits in trunk

WebCore:

  • rolled out my loader change; caused world leak and possibly a plug-in crash

WebKit:

  • rolled out my loader change; caused world leak and possibly a plug-in crash
3:21 PM Changeset in webkit [17174] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H

  • loader/mac/LoaderFunctionsMac.mm: Autorelease the header NSDictionary.
2:53 PM Changeset in webkit [17173] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bindings/js/kjs_window.cpp: (KJS::Window::timerFired): Check if the timeout id is still in the table before trying to access it. If it isn't in the table it has been deleted inside of the execute method.

LayoutTests:

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Goeff.

Add test case for timer crash.

  • fast/dom/timer-clear-interval-in-handler-expected.txt: Added.
  • fast/dom/timer-clear-interval-in-handler.html: Added.
2:05 PM Changeset in webkit [17172] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin and Geoff.

Remove debugging output.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
1:55 PM Changeset in webkit [17171] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4792755> REGRESSON: Drag selecting is erratic

No test because it would require autoscrolling, which is not available to layout tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use hitTest() to find the correct node.


(WebCore::RenderLayer::hitTest):
Trivial source formatting.

1:07 PM Changeset in webkit [17170] by andersca
  • 2 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).

  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::add):
1:05 PM Changeset in webkit [17169] by darin
  • 21 edits in trunk

WebCore:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++

Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
there's currently another class with that name).
Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

Converted the classes to C++ and added Objective-C delegates to forward from
API that still requires Objective-C.

Did not yet rename the source files.

  • WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader classes.
  • WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
  • platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
  • loader/mac/WebLoader.h:
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.h:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: Translate to C++.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (isCaseInsensitiveEqual): (isBackForwardLoadType): (-[WebFrameLoader dealloc]): (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoadingPlugIns]): (-[WebFrameLoader isLoadingMainResource]): (-[WebFrameLoader isLoadingSubresources]): (-[WebFrameLoader isLoadingPlugIns]): (-[WebFrameLoader stopLoadingSubresources]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]): (-[WebFrameLoader mainResourceData]): (-[WebFrameLoader releaseMainResourceLoader]): (-[WebFrameLoader cancelMainResourceLoad]): (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]): (-[WebFrameLoader stopLoadingWithError:]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • loader/mac/WebFrameLoaderClient.h: Call the new C++ API.

WebKit:

Reviewed by Adele.

  • convert WebLoader and its 3 subclasses to C++
  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream finalize]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream cancelLoadWithError:]): (-[WebNetscapePluginStream stop]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge canRunModalNow]):
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFramePrivate finalize]): (frame): Changed from uppercase to lowercase so that it won't conflict with the WebCore class named Frame. (-[WebFrame _firstChildFrame]): (-[WebFrame _lastChildFrame]): (-[WebFrame _previousSiblingFrame]): (-[WebFrame _nextSiblingFrame]): (-[WebFrame _traverseNextFrameStayWithin:]): (-[WebFrame _immediateChildFrameNamed:]): (-[WebFrame _nextFrameWithWrap:]): (-[WebFrame _previousFrameWithWrap:]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _deliverArchivedResourcesAfterDelay]): (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]): (-[WebFrame _archiveLoadPendingForLoader:]): (-[WebFrame _cancelPendingArchiveLoadForLoader:]): (-[WebFrame _clearArchivedResources]): (-[WebFrame _deliverArchivedResources]):
1:03 PM Changeset in webkit [17168] by andersca
  • 2 adds in trunk/WebKitQt/WebKitPart

Forgot to add these.

12:14 PM Changeset in webkit [17167] by andersca
  • 7 edits in trunk/WebKitQt

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Adapt to FrameQtClient changes, and provide some kind of status
information to the KPart wheter we're loading or not (started/completed signaling).

  • WebKitPart/CMakeLists.txt:
  • WebKitPart/WebKitPart.cpp: (WebKitPart::WebKitPart): (WebKitPart::~WebKitPart): (WebKitPart::openUrl): (WebKitPart::initView):
  • WebKitPart/WebKitPart.h:
  • WebKitPart/WebKitPartBrowserExtension.cpp: Added. (WebKitPartBrowserExtension::WebKitPartBrowserExtension): (WebKitPartBrowserExtension::~WebKitPartBrowserExtension):
  • WebKitPart/WebKitPartBrowserExtension.h: Added.
  • WebKitPart/WebKitPartClient.cpp: (WebKitPartClient::WebKitPartClient): (WebKitPartClient::loadFinished):
  • WebKitPart/WebKitPartClient.h:
  • WebKitPart/WebKitPartInterface.h:
12:14 PM Changeset in webkit [17166] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by Beth, approved in principle by Adele, who couldn't be troubled
for an actual review.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=11345
1 fewer shouldChangeSelection delegate call for fast/forms/focus-control-to-page


I updated this test to use <input type="search"> because that's the only
remaining AppKit control, and the test's intention is verify tabbing
between AppKit and non-AppKit controls.


I updated the results because the behavior change is good.


Here's why the test regressed:


Our editing code is cra-zay. When AppKit calls nextKeyView, we not only
calculate the next key element in the page, we also focus it as a side-effect.
As a result, we used to fire a focus delegate twice, because AppKit happened
to call nextKeyView twice.


This test first regressed when Adele changed listboxes to be non-AppKit
controls (r16718). That change took AppKit out of test.


The regression redoubled itself when Adam moved TAB handling into the DOM
(r16741), taking AppKit out of TABing completely.

  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/focus-control-to-page.html:
12:14 PM Changeset in webkit [17165] by andersca
  • 11 edits in trunk/WebCore

2006-10-20 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Offer a way for WebKitPart to be able to detect when
the webpage has been completly loaded (including subresources).

Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::client):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::checkLoaded): (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::CheckCacheObjectStatus):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ResourceLoaderManager.h:
  • platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::start):
12:04 PM Changeset in webkit [17164] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.

Fix compiler warnings

  • platform/ResourceLoaderClient.h:
11:27 AM Changeset in webkit [17163] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Changed test to make us pass Georgian case changing for Unicode 4.0 and 5.0. This incorporates changes from the 1.4 revision of the same mozilla test.
On Tiger we are still using Unicode 4.0 but on win and Leopard we are using Unicode 5.0, so this test currently allows for either answer.

  • tests/mozilla/ecma/String/15.5.4.11-2.js:
10:58 AM Changeset in webkit [17162] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, taking ~1% on the PLT test
  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here because this is called too often.


  • WebView/WebView.m: (-[WebView viewWillMoveToWindow:]): Do call them here, because this is guaranteed to be called at least once for each window containing a webview, but isn't called too often. Also restructured this method a little.
10:44 AM Changeset in webkit [17161] by yongjzha
  • 2 edits in S60/trunk/MemoryManager

2006-10-20 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Sachin
DESC: WebKit Lite edition memory saving adjustment
​http://bugs.webkit.org/show_bug.cgi?id=11369

  • Src/fast_malloc.cpp:
9:51 AM Changeset in webkit [22394] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Implement (barely) more of DOMWindow.idl.

  • Interfaces/DOMWindow.idl:
9:42 AM Changeset in webkit [22393] by aroben
  • 1 edit
    1 add in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Build fix.
Stubbing out DOMWindow.idl, which was forgotten in the last checkin.

  • Interfaces/DOMWindow.idl: Added.
8:48 AM Changeset in webkit [17160] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Mitz.

Win32 build fix and cleanup.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::submitForm):
  • page/ResourceRequest.h: (WebCore::ResourceRequest::addHTTPHeaderField):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Slider::~Slider): (WebCore::Slider::setMinValue): (WebCore::searchableIndexIntroduction): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::FrameWin::getObjectInstanceForWidget): (WebCore::FrameWin::getEmbedInstanceForWidget): (WebCore::FrameWin::runJavaScriptPrompt): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::createFrame): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::createPlugin): (WebCore::FrameWin::objectContentType): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::historyContains): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::defaultLanguage): (WebCore::findWordBoundary): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::refreshPlugins): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::startHTTPRequest): (WebCore::TextField::TextField): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::hide):
8:44 AM Changeset in webkit [17159] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11303
Path::transform() should be implemented on Qt build

Use QPainterPath API to implement Path::transform.
This fixes svg/custom/clip-path-with-transform.svg on
the qt build.

3:29 AM Changeset in webkit [17158] by rwlbuis
  • 9 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg clipping and painting classes.

2:48 AM Changeset in webkit [17157] by hyatt
  • 3 edits in trunk/WebCore

Make sure to do the code that checks the repeatInterval before the timer has been
deleted. (Duh.)

Reviewed by andersca

  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::setNestingLevel): (KJS::Window::timerFired): (KJS::DOMWindowTimer::fired):
  • platform/Timer.h:
12:32 AM Changeset in webkit [22392] by sfalken
  • 11 edits
    3 adds in branches/WindowsMerge

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

<rdar://4771958> Holding down Ctrl when a redirect happens opens the redirected page in a new tab


Send triggering event to url selection.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.h: Add triggeringEvent parameter
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Call GetKeyState instead of GetAsyncKeyState
  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Call GetKeyState instead of GetAsyncKeyState

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

<rdar://4771958>
Holding down Ctrl when a redirect happens opens the redirected page in a new tab

Also added a bunch of DOM bindings for events.

  • DOMEventsClasses.cpp: Added.
  • DOMEventsClasses.h: Added.
  • Interfaces/DOMEvents.idl: Added.
  • WebFrame.cpp: (WebFrame::loadData): Implemented (WebFrame::openURL): Added triggeringEvent parameter
  • WebFrame.h: Added triggeringEvent parameter
  • WebKit.vcproj/Interfaces.vcproj: Added DOMEvents.idl, DOMWindow.idl
  • WebKit.vcproj/WebKit.vcproj: Added DOMEventsClasses.cpp, DOMEventsClasses.h
  • WebKit.vcproj/WebKitGUID.vcproj: Added DOMEvents_i.c
12:25 AM Changeset in webkit [17156] by hyatt
  • 3 edits in trunk/WebCore

Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
At that point clamp to 10ms to prevent excessive CPU usage.

Reviewed by anders

  • bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::nestingLevel): (KJS::Window::installTimeout): (KJS::Window::pauseTimeouts): (KJS::Window::resumeTimeouts): (KJS::DOMWindowTimer::fired):
  • platform/Timer.h: (WebCore::TimerBase::startRepeating): (WebCore::TimerBase::startOneShot): (WebCore::TimerBase::repeatInterval): (WebCore::TimerBase::augmentRepeatInterval): (WebCore::TimerBase::inHeap): (WebCore::Timer::Timer): (WebCore::Timer::fired):
12:10 AM Changeset in webkit [17155] by sfalken
  • 2 edits in trunk/WebCore

2006-10-20 Steve Falkenburg <​sfalken@apple.com>

Build fix

  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
12:01 AM Changeset in webkit [17154] by sfalken
  • 10 edits in trunk/WebCore

2006-10-19 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Use GetKeyState rather than GetAsyncKeyState since we're
calling in these cases in direct response to an event, and want the
key state associated with that event.


Pass triggering event to url selection method.


  • bridge/mac/FrameMac.h: Add triggeringEvent parameter
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
  • bridge/win/FrameWin.h: Add triggeringEvent parameter
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
  • page/Frame.cpp: (WebCore::Frame::changeLocation): Add 0 as triggeringEvent (WebCore::Frame::urlSelected): Pass through triggeringEvent
  • page/Frame.h: Add triggeringEvent parameter to urlSelected methods
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
  • platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState (WebCore::PlatformMouseEvent::PlatformMouseEvent):

Oct 19, 2006:

10:21 PM Changeset in webkit [22391] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Put in a missing else.

10:14 PM Changeset in webkit [17153] by hyatt
  • 3 edits in trunk/WebCore

Correct typos from changing "flush" to "prune" using automated search/replace.

Change the cache heuristic for flushing to allow a higher watermark before initiating an
aggressive prune. This ensures that small cache sizes are no worse in terms of performance
than the old buggy cache.

Make sizes unsigned instead of ints in the cache's APIs and member variables.

  • loader/Cache.cpp: (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize):
  • loader/Cache.h: (WebCore::Cache::maximumSize):
9:24 PM Changeset in webkit [17152] by andersca
  • 9 edits in trunk/WebCore

2006-10-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Daddy Hyatt.

Use a real hash map for the headers.

  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/ResourceLoader.cpp: (WebCore::ResourceLoader::setRequestHeaders): (WebCore::ResourceLoader::requestHeaders):
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderInternal.h:
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader):
  • xml/xmlhttprequest.h:
8:23 PM Changeset in webkit [22390] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add a forgotten Radar reference <rdar://problem/4786763>

8:05 PM Changeset in webkit [22389] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

This is a partial reimplementation of PopupMenu for Windows. The old
implementation used the Win32 ListBox control, but as we needed to
customize the behavior more and more it began to make sense to roll our
own popup from scratch. That is what this patch accomplishes. And...

Fix: <rdar://problem/4709416>
Implement mouse hot-tracking for <select> menus
(It was easier to implement this than to leave it broken.)

  • WebCore.vcproj/WebCore.vcproj: Removed PopupMenu.cpp from project.
  • platform/win/PopupMenuWin.cpp: Carnage. PopupMenu has gained a slew of new private instance variables to maintain the window state. m_container has been removed as it is no longer needed. (WebCore::PopupMenu::PopupMenu): Initialize new variables. (WebCore::PopupMenu::~PopupMenu): Clean up new variables. (WebCore::PopupMenu::show): Now that we don't have m_container, m_popup gets the WS_BORDER and WS_POPUP styles. Also moved code to animate the window out of the old PopupMenu::setPositionAndSize() into this method since it fits the purpose of this method better. (WebCore::PopupMenu::hide): (WebCore::PopupMenu::calculatePositionAndSize): Renamed from setPositionAndSize(), as this method no longer actually sets the window position and size, just calculates it. It also now makes sure the window is sized to never show partial items, and takes into account the window's border when calculating the size. (WebCore::PopupMenu::setFocusedIndex): New method to handle setting the selected index of the <select> and highlighting the item in the popup menu. (WebCore::PopupMenu::down): Use setSelectedIndex() to do the dirty work. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::invalidateItem): New method to invalidate the rectangle in the popup menu for this item. (WebCore::PopupMenu::clientRect): New method to calculate an IntRect for the client area of the window. (WebCore::PopupMenu::incrementWheelDelta): New method to add the wheel delta obtained from a WM_MOUSEWHEEL message to any pre-existing delta. (WebCore::PopupMenu::reduceWheelDelta): New method to reduce the pre-existing wheel delta by a given amount towards 0. (WebCore::PopupMenu::paint): Does the work that PopupMenu::drawItem did, but for every item contained within the damageRect. Can also paint into a passed-in HDC (needed for window animations and smooth-scrolling). (WebCore::registerPopup): Changed a void* to a PopupMenu*, since that's what it really is. (WebCore::PopupWndProc): Added code to handle all the messages any self-respecting window would handle, and removed messages only relevant to the ListBox control.
  • platform/win/TemporaryLinkStubs.cpp: Removed unneeded #include.
8:02 PM Changeset in webkit [17151] by aroben
  • 7 edits
    1 delete in trunk/WebCore

Reviewed by Ada.

Pippity-poppity popup tweaks.

  • WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if requested and the new index is actually different than the old one.
  • platform/IntPoint.h: Added another casting operator.
  • platform/PopupMenu.cpp: Removed. The code in here, while platform-independent, was only useful for the NSPopUpButtonCell implementation of popup menus, so I've moved it to PopupMenuMac.mm.
  • platform/PopupMenu.h: Moved the definition of PopupMenu::create into the header since it's fairly simple. Made some more methods private now that we don't have subclasses and virtual methods anymore. (WebCore::PopupMenu::create): (WebCore::PopupMenu::menuList): (WebCore::PopupMenu::itemHeight): (WebCore::PopupMenu::windowRect): (WebCore::PopupMenu::listIndexAtPoint): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setScrollOffset): (WebCore::PopupMenu::scrollOffset): (WebCore::PopupMenu::wheelDelta):
  • platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp. (WebCore::PopupMenu::populate): Call our own clear() method to clear the menu.
  • platform/win/IntPointWin.cpp: New casting operator. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINTS):
8:01 PM Changeset in webkit [22388] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Rubberstamped by Maciej.

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
8:00 PM Changeset in webkit [17150] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Anders.

Bug 11366: Web Inspector should show user agent style rules
​http://bugs.webkit.org/show_bug.cgi?id=11366

6:57 PM Changeset in webkit [17149] by beidson
  • 2 edits in trunk/WebKit

Build fix - 2gig is on that pesky signed/unsigned limit...

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
5:48 PM Changeset in webkit [22387] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

  • speculative build fix for Windows for my recent changes.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
5:26 PM Changeset in webkit [17148] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

Death to 16777216. Long live 33554432.
(Cache size changed needs to be reflected in localization file)

  • English.lproj/StringsNotToBeLocalized.txt:
5:16 PM Changeset in webkit [17147] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Hyatt

Added an larger in-memory level of cache for machines with 2+gb ram

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge getObjectCacheSize]):
5:16 PM Changeset in webkit [22386] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Add a new 8x multiplier on the memory cache for >2gb machines

5:08 PM Changeset in webkit [17146] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Cleaning up Document::nextFocusNode and Document::previousFocusNode.

  • dom/Document.cpp: (WebCore::Document::nextFocusNode): (WebCore::Document::previousFocusNode):
5:07 PM Changeset in webkit [22385] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebPreferences.cpp

Double the WebCore cache size.

5:06 PM Changeset in webkit [17145] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Hyatt

Double the default memory cache size

  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
5:00 PM Changeset in webkit [17144] by mjs
  • 17 edits in trunk/WebCore

Reviewed by Geoff.

  • implement new ResourceRequest API and fix up code as appropriate


  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
  • dom/DOMImplementation.cpp: (WebCore::addString): (WebCore::isSVG10Feature): (WebCore::isSVG11Feature):
  • dom/Document.h:
  • editing/CommandByName.cpp:
  • editing/JSEditor.cpp:
  • page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/ResourceRequest.h: (WebCore::): (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::cachePolicy): (WebCore::ResourceRequest::setCachePolicy): (WebCore::ResourceRequest::timeoutInterval): (WebCore::ResourceRequest::setTimeoutInterval): (WebCore::ResourceRequest::mainDocumentURL): (WebCore::ResourceRequest::setMainDocumentURL): (WebCore::ResourceRequest::httpMethod): (WebCore::ResourceRequest::setHTTPMethod): (WebCore::ResourceRequest::httpHeaderField): (WebCore::ResourceRequest::setHTTPHeaderField): (WebCore::ResourceRequest::httpContentType): (WebCore::ResourceRequest::setHTTPContentType): (WebCore::ResourceRequest::httpReferrer): (WebCore::ResourceRequest::setHTTPReferrer): (WebCore::ResourceRequest::httpUserAgent): (WebCore::ResourceRequest::setHTTPUserAgent): (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody): (WebCore::ResourceRequest::addHTTPHeaderField):
  • platform/FontCache.cpp: (WebCore::computeHash):
  • platform/StringHash.h: (WTF::):
  • platform/StringImpl.cpp: (WebCore::equalIgnoringCase):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
4:21 PM Changeset in webkit [17143] by justing
  • 17 edits in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4447885>
API: WebView should have a method something like incrementLeftMarginBy: or indentBy:

Changed blockquotes in these tests to blockquote class="webkit-indent-blockquote".

  • editing/execCommand/indent-empty-root-expected.txt:
  • editing/execCommand/indent-selection-expected.checksum:
  • editing/execCommand/indent-selection-expected.png:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/indent-selection.html:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/nsresponder-outdent.html:
  • editing/execCommand/outdent-selection-expected.checksum:
  • editing/execCommand/outdent-selection-expected.png:
  • editing/execCommand/outdent-selection-expected.txt:


Ditto. Added a FIXME:

  • editing/execCommand/outdent-selection.html:

WebCore:

Reviewed by levi


<rdar://problem/4447885>
API: WebView should have a method something like incrementLeftMarginBy: or indentBy:


Fixed indent/outdent to only increment the left margin, to match other browsers.
Used blockquote class="webkit-indent-blockquote" to do this. Mail can now
implement indent/outdent by customizing the appearance of these blockquotes,
instead of using a new API.


  • css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
  • editing/IndentOutdentCommand.cpp: (WebCore::indentBlockquoteString): Added. (WebCore::createIndentBlockquoteElement): Added. (WebCore::isIndentBlockquote): Added. (WebCore::isListOrBlockquote): Added. (WebCore::IndentOutdentCommand::IndentOutdentCommand): (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed a bug in the code that added an extra br if the placeholder collapsed upon insertion. Used the new indentBlockquote checks and enclosing element getters. (WebCore::IndentOutdentCommand::indentRegion): Ditto. (WebCore::IndentOutdentCommand::outdentParagraph): Ditto. Cleaned up the logic to pull the selection out of a list a bit.
  • editing/htmlediting.cpp: (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
  • editing/htmlediting.h:
2:57 PM Changeset in webkit [17142] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Kevin D and Geoff

  • WebKit.xcodeproj/project.pbxproj: version wars


Cleaned up this file, as follows:

  • renamed all file-internal methods to start with underscores
  • moved all file-internal methods into a FileInternal category block, and alphabetized them
  • grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
  • removed unstylish braces around one-line clauses


  • WebView/WebPDFView.m: (_applicationInfoForMIMEType): (_PDFSelectionsAreEqual): (+[WebPDFView supportedMIMETypes]): (-[WebPDFView setPDFDocument:]): (-[WebPDFView dealloc]): (-[WebPDFView centerSelectionInVisibleArea:]): (-[WebPDFView scrollPageDown:]): (-[WebPDFView scrollPageUp:]): (-[WebPDFView scrollLineDown:]): (-[WebPDFView scrollLineUp:]): (-[WebPDFView scrollToBeginningOfDocument:]): (-[WebPDFView scrollToEndOfDocument:]): (-[WebPDFView jumpToSelection:]): (-[WebPDFView acceptsFirstResponder]): (-[WebPDFView becomeFirstResponder]): (-[WebPDFView hitTest:]): (-[WebPDFView initWithFrame:]): (-[WebPDFView menuForEvent:]): (-[WebPDFView setNextKeyView:]): (-[WebPDFView viewDidMoveToWindow]): (-[WebPDFView viewWillMoveToWindow:]): (-[WebPDFView validateUserInterfaceItem:]): (-[WebPDFView copy:]): (-[WebPDFView takeFindStringFromSelection:]): (-[WebPDFView canPrintHeadersAndFooters]): (-[WebPDFView printOperationWithPrintInfo:]): (-[WebPDFView viewWillMoveToHostWindow:]): (-[WebPDFView viewDidMoveToHostWindow]): (-[WebPDFView elementAtPoint:]): (-[WebPDFView elementAtPoint:allowShadowContent:]): (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): (-[WebPDFView viewState]): (-[WebPDFView setViewState:]): (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (+[WebPDFView _PDFPreviewViewClass]): (+[WebPDFView _PDFViewClass]): (-[WebPDFView _anyPDFTagsFoundInMenu:]): (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _fakeKeyEventWithFunctionKey:]): (-[WebPDFView _menuItemsFromPDFKitForEvent:]): (-[WebPDFView _openWithFinder:]): (-[WebPDFView _path]): (-[WebPDFView _PDFSubview]): (-[WebPDFView _pointIsInSelection:]): (-[WebPDFView _receivedPDFKitLaunchNotification:]): (-[WebPDFView _scaledAttributedString:]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]): (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
1:42 PM Changeset in webkit [17141] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by ap.


Added a delay before printing the last line of text to ensure that the two
lines consistently decode as separate chunks.

  • http/tests/incremental/slow-utf8-css.pl:
  • http/tests/incremental/slow-utf8-css-expected.txt:
1:13 PM Changeset in webkit [17140] by thatcher
  • 2 edits in trunk/WebCore

Rolling out the this change since it caused a bad regression:
<rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)

2006-10-12 Adele Peterson <​adele@apple.com>


Reviewed by Dave Harrison.


  • Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)


  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.
11:44 AM Changeset in webkit [22384] by andersca
  • 4 edits in branches/WindowsMerge

WebCoreWin:

2006-10-19 Anders Carlsson <​acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): Build fix.

WebKitWin:

2006-10-19 Anders Carlsson <​acarlsson@apple.com>

  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Build fix.
11:43 AM Changeset in webkit [17139] by sullivan
  • 9 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
  • WebKit.xcodeproj/project.pbxproj: version wars


  • WebView/WebFrameView.m: (-[WebFrameView _makeDocumentViewForDataSource:]): initialize document view with frame view's rect instead of empty rect. This avoids some problems when constructing view hierarchies from nibs


  • WebView/WebPreferencesPrivate.h: declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
  • WebView/WebPreferenceKeysPrivate.h: declare new preference key string
  • WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize new preference to true (we will by default use the new view if it's available) (-[WebPreferences _usePDFPreviewView]): new accessor for new pref (-[WebPreferences _setUsePDFPreviewView:]): ditto
  • WebView/WebPDFView.h: new previewView ivar


  • WebView/WebPDFView.m: (+[WebPDFView PDFPreviewViewClass]): new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available (-[WebPDFView initWithFrame:]): now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back to old behavior otherwise (-[WebPDFView dealloc]): release new previewView ivar (retained in initWithFrame:) (-[WebPDFView viewWillMoveToWindow:]): stop observing PDFKit notification when we're removed from window (-[WebPDFView viewDidMoveToWindow]): start observing PDFKit notification when we're added to window (-[WebPDFView _receivedPDFKitLaunchNotification:]): respond to this new PDFKit notification by opening the document via NSWorkspace


  • English.lproj/StringsNotToBeLocalized.txt: updated for lots of recent changes
11:07 AM Changeset in webkit [17138] by andersca
  • 8 edits in trunk/WebCore

2006-10-19 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • loader/Cache.h:
  • platform/qt/BrowserExtensionQt.cpp:
  • platform/qt/BrowserExtensionQt.h:
  • platform/qt/CursorQt.cpp: (WebCore::pointerCursor):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus):
  • platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse):
10:09 AM Changeset in webkit [17137] by weinig
  • 6 edits in trunk

WebCore:

Reviewed by ap.

Win32 build fix.

  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):

WebKit:

Reviewed by ap.

Win32 build fix.

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::createNewWindow):
9:41 AM Changeset in webkit [17136] by ap
  • 4 edits
    9 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11141
REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element

Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
to document URL. This matches WinIE and partially matches Firefox - although the latter
reports the href as if it were inherited, it still doesn't use it when resolving URIs in
@import rules.

Test: http/tests/uri/css-href.php

  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
9:37 AM Changeset in webkit [17135] by ap
  • 2 edits in trunk/WebKit

2006-10-19 Mitz Pettel <​mitz@webkit.org>

Reviewed and landed by ap.

  • fixed the inspector's tree popup
9:15 AM Changeset in webkit [17134] by andersca
  • 2 edits in trunk/WebCore

2006-10-19 Anders Carlsson <​acarlsson@apple.com>

  • loader/Cache.cpp: Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems with case-sensitive file systems.
9:09 AM Changeset in webkit [17133] by andersca
  • 16 edits in trunk/WebCore

2006-10-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej, Brady.

Remove "charset" from the ResourceLoader metadata map and use
a getter function instead. Also, rename charset to encoding in a couple of places.


  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::setEncoding):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedResource.h: (WebCore::CachedResource::setEncoding):
  • loader/CachedScript.cpp: (WebCore::CachedScript::setEncoding):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::setEncoding):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setEncoding):
  • loader/CachedXSLStyleSheet.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/ResourceLoader.cpp: (WebCore::ResourceLoader::responseEncoding): (WebCore::ResourceLoader::queryMetaData):
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::retrieveResponseEncoding): (WebCore::ResourceLoader::receivedResponse):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData):
7:58 AM Changeset in webkit [17132] by ggaren
  • 3 edits in trunk/LayoutTests

Updated this test to avoid machine-specific results.

  • fast/js/window-properties2-expected.txt:
  • fast/js/window-properties2.html:
2:21 AM Changeset in webkit [17131] by hyatt
  • 29 edits in trunk/WebCore

Rewrite of the WebCore memory cache. The following changes have been made (along with many more):

(1) Referenced objects are now also cached.

(2) Pruning of the cache will occur once the cache is both full and in addition
more than half full with unreferenced objects.

(3) The prune is much more aggressive now, since referenced objects are counted when
pruning. The cache will therefore often prune out every unreferenced object if lots of
windows/tabs are open.

(4) Consolidated the request methods for various types of resources to go through a single
requestResource bottleneck function.

(5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
identical.

(6) Changed "object" to "resource" everywhere.

(7) The Cache is now an actual object, obtained via cache().

(8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
and enabled.

(9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.

(10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
in the LRU lists). Also fixed a bug with the "-SP" part of the algorithm where the access count was
being incorrectly weighted too much due to a math error.

(11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
the size of referenced resources.

Reviewed by Maciej, bradee-oh

  • bridge/mac/WebCoreCache.mm: (+[WebCoreCache statistics]): (+[WebCoreCache empty]): (+[WebCoreCache setDisabled:]):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::image):
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::resourceForURL): (WebCore::Cache::prune): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::addDocLoader): (WebCore::Cache::removeDocLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled):
  • loader/Cache.h: (WebCore::LRUList::LRUList): (WebCore::Cache::loader): (WebCore::Cache::maximumSize): (WebCore::Cache::disabled): (WebCore::Cache::addToLiveObjectSize): (WebCore::Cache::removeFromLiveObjectSize): (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::~CachedImage): (WebCore::brokenImage): (WebCore::nullImage): (WebCore::CachedImage::image): (WebCore::CachedImage::data):
  • loader/CachedImage.h: (WebCore::CachedImage::stillNeedsLoad):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::finish): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired): (WebCore::CachedResource::setRequest): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setSize):
  • loader/CachedResource.h: (WebCore::CachedResource::): (WebCore::CachedResource::setCharset): (WebCore::CachedResource::url): (WebCore::CachedResource::type): (WebCore::CachedResource::referenced): (WebCore::CachedResource::count): (WebCore::CachedResource::status): (WebCore::CachedResource::size): (WebCore::CachedResource::isLoaded): (WebCore::CachedResource::setLoading): (WebCore::CachedResource::isImage): (WebCore::CachedResource::accessCount): (WebCore::CachedResource::increaseAccessCount): (WebCore::CachedResource::setInCache): (WebCore::CachedResource::inCache): (WebCore::CachedResource::cachePolicy): (WebCore::CachedResource::response): (WebCore::CachedResource::allData): (WebCore::CachedResource::canDelete): (WebCore::CachedResource::schedule): (WebCore::CachedResource::accept): (WebCore::CachedResource::setAccept):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader): (WebCore::DocLoader::checkForReload): (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setAutoLoadImages): (WebCore::DocLoader::removeCachedResource):
  • loader/DocLoader.h: (WebCore::DocLoader::cachedResource): (WebCore::DocLoader::allCachedResources): (WebCore::DocLoader::autoLoadImages): (WebCore::DocLoader::cachePolicy): (WebCore::DocLoader::expireDate): (WebCore::DocLoader::frame): (WebCore::DocLoader::doc): (WebCore::DocLoader::loadInProgress):
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::cancelRequests):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckCacheObjectStatus):
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::setAutoLoadImages): (WebCore::Frame::autoLoadImages): (WebCore::Frame::begin): (WebCore::Frame::checkCompleted): (WebCore::Frame::reparseConfiguration):
  • page/Frame.h:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
Note: See TracTimeline for information about the timeline view.