Timeline


and

10/28/06:

23:48 Changeset [17405] by darin

JavaScriptCore:

Reviewed by Maciej.

  • renamed PassRefPtr::release to releaseRef to make it clearer that it's the counterpart of adoptRef, and to make it harder to confuse it with the safer-to-use RefPtr::release
  • kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::translate):
  • kjs/ustring.cpp: (KJS::UString::Rep::create):
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::PassRefPtr): (WTF::PassRefPtr::~PassRefPtr): (WTF::PassRefPtr::get): (WTF::PassRefPtr::releaseRef): (WTF::PassRefPtr::operator->): (WTF::PassRefPtr::operator=): (WTF::adoptRef): (WTF::static_pointer_cast): (WTF::const_pointer_cast):
  • wtf/RefPtr.h: (WTF::RefPtr::RefPtr): (WTF::RefPtr::operator=):

WebCore:

Reviewed by Maciej.

  • eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDecider, WebCoreFrameLoaderAsDelegate, and WebCoreMainResourceLoaderAsPolicyDelegate
  • grouped the state related to policy decisions into a PolicyCheck class to simplify the FrameLoader logic
  • removed six methods from the bridge, reducing FrameLoader's use of the bridge to a single method
  • changed form state to always use HashMap instead of NSDictionary
  • moved the defersLoading flag from WebView to WebCore::Page and changed code to consistently call it defersLoading rather than defersCallbacks
  • updated for rename of PassRefPtr::release to releaseRef
  • replaced all uses of APPLE with appropriate PLATFORM defines
  • cleaned up kjs_binding.h a bit
  • cleaned up FrameMac.h a bit
  • loader/mac/WebPolicyDecider.h: Removed.
  • loader/mac/WebPolicyDecider.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for removal.
  • WebCore.exp:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::wasRunByUserGesture):
  • bindings/js/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::setInlineCode): (KJS::ScriptInterpreter::setProcessingTimerCallback): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
  • bridge/AXObjectCache.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::handleMouseMoveEvent):
  • bridge/mac/PageMac.mm: (WebCore::Page::Page):
  • bridge/mac/WebCoreEditCommand.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
  • css/CSSValueList.cpp: (WebCore::CSSValueList::append):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateSelection): (WebCore::Document::implicitClose): (WebCore::Document::setFocusNode):
  • dom/Document.h:
  • editing/ReplaceSelectionCommand.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • loader/mac/FrameLoader.h: (WebCore::PolicyCheck::request):
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): (WebCore::FrameLoader::stopLoading): (WebCore::setAllDefersLoading): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::dropRequest): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/mac/WebFormState.h:
  • loader/mac/WebFormState.mm:
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebLoader.h: (WebCore::WebResourceLoader::defersLoading):
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::setDefersLoading):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/FrameView.h:
  • page/Page.cpp: (WebCore::Page::setDefersLoading):
  • page/Page.h: (WebCore::Page::defersLoading):
  • platform/DeprecatedString.h:
  • platform/DeprecatedStringList.h:
  • platform/FontFallbackList.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::dragNSImage): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition):

WebKit:

Reviewed by Maciej.

  • eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDeciderMac
  • moved the defersLoading flag from WebView to WebCore::Page
  • removed unused copies of four methods that in the frame bridge; the actually-used copies are in the page bridge
  • updated for rename of PassRefPtr::release to releaseRef
  • WebView/WebPolicyDeciderMac.h: Removed.
  • WebView/WebPolicyDeciderMac.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Updated for removal.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]):
  • Plugins/WebNetscapePluginStream.mm:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::setUpPolicyListener): (WebFrameLoaderClient::receivedPolicyDecison): (WebFrameLoaderClient::userAgent): (-[WebFramePolicyListener initWithWebCoreFrame:]): (-[WebFramePolicyListener invalidate]): (-[WebFramePolicyListener dealloc]): (-[WebFramePolicyListener finalize]): (-[WebFramePolicyListener receivedPolicyDecision:]): (-[WebFramePolicyListener ignore]): (-[WebFramePolicyListener download]): (-[WebFramePolicyListener use]): (-[WebFramePolicyListener continue]):
  • WebCoreSupport/WebPageBridge.mm: (-[WebPageBridge runModal]):
  • WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebFormDelegate.h:
  • WebView/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]): (-[WebFormDelegate textFieldDidEndEditing:inFrame:]): (-[WebFormDelegate textDidChangeInTextField:inFrame:]): (-[WebFormDelegate textDidChangeInTextArea:inFrame:]): (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _isFrameSet]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView _shouldDrawBorder]):
  • WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]):
  • WebView/WebView.mm: (-[WebView _formDelegate]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
16:44 Changeset [17404] by aroben

Adding forgotten Bugzilla reference.

16:41 Changeset [17403] by aroben

Fixing ChangeLog entries: r17933 => r17399.

16:39 Changeset [17402] by aroben

WebCore:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
point instead of being passed one explicitly.

  • WebCore.exp: Change constructor symbol.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and hitTest(). (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
  • dom/Document.cpp: (WebCore::Document::elementFromPoint): Ditto. (WebCore::Document::prepareMouseEvent): Ditto.
  • page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Ditto. (WebCore::Frame::hitTestResultAtPoint): Ditto.
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Initalize m_point with the passed point.
  • rendering/HitTestResult.h: Update constructor declaration.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Update to new constructor and hitTest(). (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the HitTestResult instead of being passed one. (WebCore::RenderLayer::hitTestLayer): Ditto.
  • rendering/RenderLayer.h: Update declarations.

WebKit:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point.

  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to HitTestResult constructor.
14:43 Changeset [22439] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Adding new HitTestResult.{cpp,h} files.
14:33 Changeset [17401] by weinig

Reviewed by Anders.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • platform/qt/FrameQtClient.cpp: (WebCore::numRequests): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::updateFromElement):
11:56 Changeset [17400] by weinig

Tweaked by Sam. Reviewed by Brady.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
Initialize m_modifyBiasSet to false, as it sometimes gets
used before it has been initalized.

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
11:28 Changeset [17399] by bdakin

WebCore:

Reviewed by Darin.

This is the WebCore half of pushing elementAtPoint and the backend
of WebElementDictionary into WebCore. Most of the changes below are
to accommodate one of the following:


-NodeInfo is now a stand-alone class called HitTestResult.

Previously it was defined in RenderObject.h, but not for
any particular reason. The WebElementDictionary
functionality that was pushed into WebCore has been pushed
specifically into the this class. In fact,
WebElementDictionary now keeps a HitTestResult as a member
varibale.


-The enumeration AccessPolicy is now called

ClipboardAccessPolicy and is defined in its own header. It
was previously defined in ClipboardMac.h, but is now
defined independently to avoid including ClipboardMac.h
from within FrameMac.h since FrameMac.h is now included in
WebElementDictionary.m in WebKit.


-Element now has a virtual target() for the sake of

NodeInfo::targetFrame()

  • WebCore.exp: Several WebCore functions are newly called from WebKit, so they have been added here.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: Must include Image.h because of adjustments to ClipboardMac.
  • bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy and HitTestResult changes. (WebCore::FrameMac::eventMayStartDrag): Same. (WebCore::FrameMac::handleMouseMoveEvent): Same. (WebCore::FrameMac::dispatchCPPEvent): Same. (WebCore::FrameMac::mayDHTMLCut): Same. (WebCore::FrameMac::mayDHTMLCopy): Same. (WebCore::FrameMac::mayDHTMLPaste): Same. (WebCore::FrameMac::tryDHTMLCut): Same (WebCore::FrameMac::tryDHTMLCopy): Same. (WebCore::FrameMac::tryDHTMLPaste): Same.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to HitTestResult changes. (-[WebCoreAXObject accessibilityHitTest:]): Same.
  • bridge/mac/WebCoreFrameBridge.h: Same.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for ClipboardAccessPolicy changes. (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same. (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
  • dom/Document.cpp: (WebCore::Document::elementFromPoint): Adjust for HitTestResult changes. (WebCore::Document::prepareMouseEvent): Same.
  • dom/Element.h: (WebCore::Element::target): Now has a virtual target()
  • html/HTMLAnchorElement.h: Same.
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult changes.
  • html/HTMLAreaElement.h: Virtual target()
  • html/HTMLBaseElement.h: (WebCore::HTMLBaseElement::target): Same.
  • html/HTMLFormElement.h: Same.
  • html/HTMLLinkElement.h: Same.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult changes.
  • html/HTMLMapElement.h: Same.
  • page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Same. (WebCore::Frame::hitTestResultAtPoint): Same.
  • page/Frame.h: Same.
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Same.
  • platform/mac/ClipboardAccessPolicy.h: Added. (WebCore::):
  • platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, include ClipboardAccessPolicy.h, and rename AccessPolicy to ClipboardAccessPolicy.
  • platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy. (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::setAccessPolicy): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::setDropEffect): (WebCore::ClipboardMac::setEffectAllowed):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult changes.
  • rendering/EllipsisBox.h:
  • rendering/HitTestResult.cpp: Added. (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::~HitTestResult): (WebCore::HitTestResult::operator=): (WebCore::HitTestResult::setInnerNode): (WebCore::HitTestResult::setInnerNonSharedNode): (WebCore::HitTestResult::setURLElement): (WebCore::HitTestResult::setScrollbar): (WebCore::HitTestResult::targetFrame): (WebCore::HitTestResult::boundingBox): (WebCore::HitTestResult::isSelected): (WebCore::HitTestResult::title):
  • rendering/HitTestResult.h: Added. (WebCore::HitTestResult::readonly): (WebCore::HitTestResult::active): (WebCore::HitTestResult::mouseMove): (WebCore::HitTestResult::innerNode): (WebCore::HitTestResult::innerNonSharedNode): (WebCore::HitTestResult::point): (WebCore::HitTestResult::URLElement): (WebCore::HitTestResult::scrollbar): (WebCore::HitTestResult::setPoint): (WebCore::HitTestResult::setReadonly): (WebCore::HitTestResult::setActive): (WebCore::HitTestResult::setMouseMove):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
  • rendering/InlineBox.h: Same.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): Same.
  • rendering/InlineFlowBox.h: Same.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): Same.
  • rendering/InlineTextBox.h: Same.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Same. (WebCore::RenderBlock::nodeAtPoint): Same.
  • rendering/RenderBlock.h: Same.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Same.
  • rendering/RenderBox.h: Same.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): Same.
  • rendering/RenderFlow.h: Same.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): Same.
  • rendering/RenderForeignObject.h: Same.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): Same.
  • rendering/RenderFrameSet.h: Same.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Same.
  • rendering/RenderImage.h: Same.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): Same.
  • rendering/RenderInline.h: Same.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Same. (WebCore::RenderLayer::hitTest): Same. (WebCore::RenderLayer::hitTestLayer): Same. (WebCore::RenderLayer::updateHoverActiveState): Same.
  • rendering/RenderLayer.h: Same.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): Same.
  • rendering/RenderListBox.h: Same.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): Same. (WebCore::RenderObject::setInnerNode): Same. (WebCore::RenderObject::nodeAtPoint): Same.
  • rendering/RenderObject.h: Remove NodeInfo class and forward declare HitTestResult.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult changes.
  • rendering/RenderPath.h: Same.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Same.
  • rendering/RenderSVGImage.h: Same
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): Same.
  • rendering/RenderSVGText.h: Same.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): Same.
  • rendering/RenderTableRow.h: Same.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): Same.
  • rendering/RenderTableSection.h: Same.
  • rendering/RenderText.h: Same. (WebCore::RenderText::nodeAtPoint): Same.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): Same.
  • rendering/RenderTextControl.h: Same.
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): Same.
  • rendering/RootInlineBox.h: Same.

WebKit:

Reviewed by Darin.

This is the WebKit half of pushing the guts of elementAtPoint and
WebElementDictionary into WebCore. Among other things, this patch
makes WebElementDictionary.m and WebHTMLView.m Objective-C++

  • MigrateHeaders.make: Add DOMElementInternal.h to the list of headers to migrate.
  • Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and NSPoint member variables with a HitTestResult member variable.
  • Misc/WebElementDictionary.m: (addLookupKey): Formatting. (-[WebElementDictionary initWithHitTestResult:]): Constructor just takes a HitTestResult now and sets the member variable. (-[WebElementDictionary dealloc]): delete HitTestResult. (-[WebElementDictionary finalize]): Address HitTestResult. (-[WebElementDictionary _domNode]): Use HitTestResult and call into WebCore. (-[WebElementDictionary objectForKey:]): Same. (-[WebElementDictionary _webFrame]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _imageRect]): Same. (-[WebElementDictionary _isSelected]): Same.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: (core): Convert from DOMNode* to Node* (kit): Convert from Node* to DOMNode*
  • WebView/WebFrameInternal.h: Support for the above.
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly into Frame.cpp to get HitTestResult.
01:19 Changeset [17398] by mjs

WebCore:

Removed accidentally committed duplicate ChangeLog entries.

WebKit:

Removed accidentally committed duplicate ChangeLog entries.

10/27/06:

23:18 Changeset [17397] by mjs

Reviewed by Anders.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear):
22:08 Changeset [17396] by mjs

WebCore:

Reviewed by John & Adam.

  • assorted speedups to fix perf regression from fixing correctness regression
  • WebCore.exp: exported new methods.
  • WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/CachedResource.cpp: Removed now obsolete getCFURL.
  • loader/CachedResource.h:
  • loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject.
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache.
  • loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by John & Adam.


  • various performance improvements for resource delegate dispatch.


  • avoid any ObjC messaging when fetching the WebView
  • avoid ObjC calls to WebView to get resource load delegate and impl cache
  • cache actual method pointers, not just the fact that the method is present
  • added a new SPI resource load delegate method which allows clients to get just one message in case of synchronously loading from memory cache; if this is implemented you don't get the normal delegate calls in that case.
  • various other minor tweaks
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::frameLoadCompleted):
  • WebCoreSupport/WebPageBridge.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: (frame): (core): (kit): (getWebView): (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _updateBackground]): (-[WebFrame _clearSelectionInOtherFrames]): (-[WebFrame _isMainFrame]): (-[WebFrame webView]):
  • WebView/WebResourceLoadDelegatePrivate.h: Added.
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): (WebViewGetResourceLoadDelegate): (WebViewGetResourceLoadDelegateImplementations):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
21:14 Changeset [17395] by oliver

2006-10-27 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

build fix

  • dom/Document.cpp: (WebCore::Document::referrer):
19:08 Changeset [17394] by beidson

top level:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:

WebKitTools:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:
18:22 Changeset [17393] by ggaren

WebCore:

Reviewed by Maciej.

Moved some WebCoreFrameBridge functions into FrameLoader.


I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and OBJC #ifdefs.

  • WebCore.exp:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer):
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading):
  • page/Frame.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext):
  • page/FrameTree.h:
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Maciej.


Moved some WebCoreFrameBridge functions into FrameLoader.

  • WebView/WebFrame.mm: (-[WebFrame _numPendingOrLoadingRequests:]):
17:41 Changeset [17392] by thatcher

Reviewed by Darin.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Expanded the Deletion UI to lists, positioned block element and block elementss with borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection):
16:43 Changeset [17391] by sullivan

Reviewed by Kevin Decker


Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.

  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers.
16:37 Changeset [22438] by sfalken

2006-10-27 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej.


Tighten up warning levels by removing #pragma warning(push, 0), pop

  • WebBackForwardList.h:
  • WebFrame.h:
  • WebIconDatabase.h:
15:31 Changeset [17390] by thatcher

WebCore:

Reviewed by Beth.

Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Beth.

Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
15:07 Changeset [17389] by justing

Fixed the revision number in my ChangeLog entry.

14:28 Changeset [17388] by sullivan

Reviewed by Anders


  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): Handle nil documentLoader the way we did before ObjC->C++ changes
14:22 Changeset [22437] by andersca

2006-10-27 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

<rdar://problem/4730678> Plug-ins should be able to open URLs

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
13:50 Changeset [17387] by sullivan

WebCore:

Reviewed by Anders

  • WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling()


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.

WebKit:

Reviewed by Anders

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): call advanceToNextMisspelling directly on FrameMac, bypassing bridge (-[NSArray showGuessPanel:]): ditto
13:42 Changeset [17386] by justing

LayoutTests:

Reviewed by harrison


<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value

Changes reflect the removal of more brs that were about
to collapse:

  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:

Added to demonstrate fix:

  • fast/forms/11423-expected.txt: Added.
  • fast/forms/11423.html: Added.

WebCore:

Reviewed by harrison


<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value


The regression is that foo, return, bar in a textarea serializes as 'foobar'.


Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.


We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse.
  • editing/CompositeEditCommand.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function.
12:50 Changeset [17385] by spadma

2006-10-27 sareen <shyam.sareen@nokia.com>

Reviewed by sachin.padma@nokia.com.
DESC: Change the cenrep value in the HTTPLoaderAcceptHeader.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11434

  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
11:54 Changeset [17384] by thatcher

Versioning

11:54 Changeset [17383] by thatcher

Build fix.

11:53 Changeset [17382] by thatcher

New tag (part 2).

11:52 Changeset [17381] by thatcher

New tag.

11:51 Changeset [17380] by brmorris

2006-10-16 brmorris <thisisbradley@gmail.com>

Reviewed by Sachin.
DESC: Update svg icons in CannedImages.cpp
http://bugs.webkit.org/show_bug.cgi?id=9435

  • BrowserCore/Misc/src/CannedImages.cpp: Update mbg includes (CCannedImages::GetImage): Update BROWSERSDK bitmap IDs (CCannedImages::LoadSvg): Update BROWSERSDK bitmap IDs
  • data/Webkit_gcce.loc: Removed.
  • data/Webkit_gcce.rss: Removed.
11:47 Changeset [17379] by thatcher

Build fix.

11:29 Changeset [17378] by ggaren

Reviewed by Brady.

Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.


Added work-around for AppKit crash that semantic accuracy revealed.


No testcase because I don't think there's a way to reflect this change
in a webpage yet.

  • platform/PlatformString.h: (WebCore::String::operator NSString*):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
10:50 Changeset [17377] by darin

Reviewed by Steve.

  • kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix a warning some people see (not sure why others don't see it).
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch this file to force it to re-build grammar.cpp.
10:19 Changeset [17376] by thatcher

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
10:15 Changeset [17375] by thatcher

New tag.

09:49 Changeset [17374] by darin

Oops, forgot to save one file.

09:49 Changeset [17373] by harrison

Reviewed by Maciej,

<rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange

  • bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element.


(AXAttributeStringSetBlockquoteLevel):
Add, if non-zero, or clear the block quote level attribute.


(AXAttributedStringAppendText):
Send AXAttributeStringSetBlockquoteLevel.

09:48 Changeset [17372] by darin

Reviewed by Geoff.

  • made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
  • kjs/ExecState.h: (KJS::ExecState::hadException):
  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/Parser.h:
  • kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
  • kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
  • kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
  • kjs/completion.h: (KJS::Completion::isValueCompletion):
  • kjs/date_object.cpp: (KJS::findMonth):
  • kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
  • kjs/dtoa.cpp:
  • kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
  • kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
  • kjs/grammar.y:
  • kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
  • kjs/internal.h:
  • kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
  • kjs/lexer.h:
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
  • kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
  • kjs/object.h: (KJS::JSObject::getPropertySlot):
  • kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
  • kjs/property_slot.h:
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
  • kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
  • kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
  • kjs/value.cpp: (KJS::JSValue::toUInt16):
  • kjs/value.h:
  • pcre/pcre_compile.c: (get_othercase_range):
  • pcre/pcre_exec.c: (match):
  • pcre/pcre_internal.h:
  • wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
  • wtf/MathExtras.h: (isnan): (lround): (lroundf):
  • wtf/StringExtras.h: (strncasecmp):
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):
07:41 Changeset [17371] by darin
  • fix one error in the Qt build
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated.
07:39 Changeset [17370] by spadma

2006-10-27 yongjzha yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):


Merge from r17367 from main branch

07:33 Changeset [17369] by darin

Moved the layout test part of the change log to the layout tests directory.

07:31 Changeset [17368] by darin
  • new test results for a couple of tests
  • fast/js/kde/RegExp-expected.txt: Affected by the change to decode \u sequences in JavaScript regular expression at the lexer level.
  • http/tests/navigation/success200-reload-expected.txt: For some reason, this is consistently not dumping the "scrolled" line any more -- since the purpose of the test has nothing to do with that, landing new results.
07:28 Changeset [17367] by yongjzha

2006-10-27 yongjzha yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):
01:08 Changeset [17366] by darin
  • build fix
  • WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
00:09 Changeset [17365] by darin

Reviewed by Maciej.

  • moved methods that are there just to be called by the frame loader client into the client in an attempt to get back some of the speed we lost yesterday
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (dataSource): (decisionListener): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::canUseArchivedResource): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::createPageCache):
  • WebView/WebFrame.mm: (-[NSView setWebFrame:]): (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _saveScrollPositionAndViewStateToItem:]): (-[WebFrame _hasSelection]): (-[WebFrame _clearSelection]): (-[WebFrame _setProvisionalItem:]): (-[WebFrame _setPreviousItem:]): (-[WebFrame _setCurrentItem:]): (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]):
  • WebView/WebHTMLViewPrivate.h:
00:08 Changeset [17364] by darin

Reviewed by Maciej.

  • WebCore.exp: Export more symbols needed by WebKit.

10/26/06:

23:29 Changeset [17363] by ggaren

Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.

Fixed layout test crash. Oops.


  • loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle):
23:08 Changeset [17362] by thatcher

Versioning

23:06 Changeset [17361] by thatcher

Build fix for 64-bit.

23:04 Changeset [17360] by thatcher

new tag (part 2).

23:01 Changeset [17359] by thatcher

new tag.

23:01 Changeset [17358] by thatcher

Bad tag.

22:59 Changeset [17357] by thatcher

new tag (part 2).

22:58 Changeset [17356] by thatcher

new tag.

22:54 Changeset [17355] by thatcher

Build fix for 64-bit.

22:30 Changeset [17354] by bdash

2006-10-26 W. Andy Carrel <wac@google.com>

Reviewed by Maciej.

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): Looking ahead one additional character for the benefit of scanRegExp (Lexer::scanRegExp): Change code to support unicode escapes in inline regexps.
  • kjs/lexer.h: Extra lookahead added.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Changed test to look for Unicode character rather than the '\u' escaped equivalent for .source and .toString().
20:46 Changeset [17353] by sullivan

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
19:55 Changeset [17352] by ggaren

WebCore:

Reviewed by Darin, Maciej.

Removed many uses of NSString *.
Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
stringByCollapsingNonPrintingCharacters with a c++ equivalent.


PLT says no performance regression.


  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy):

WebKit:

Reviewed by Darin, Maciej.

Removed many uses of NSString * from WebCore.


Changed a few files to ObjC++ for compatiblity with new WebCore methods
taking WebCore::Strings as arguments.


Added a static_cast to make the c++ compiler happy.

19:55 Changeset [22436] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4764502> PluginStreams should cancel their loader jobs on error

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData): Modify assertions. None of the above functions should be run after aborting the load.
18:00 Changeset [22435] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths): Look for plugins in a plugins directory which is relative to the executable directory.


(WebCore::PluginDatabaseWin::createPluginView):
Use reverseFind instead of findRev here.

17:25 Changeset [17351] by thatcher

Reviewed by Adam.

<rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com

The main table at nytimes.com has a fixed width of 874px, but the table ends
up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
this. The other bug was a missing top and left of 0px on the container element,
causing the deletion UI to sometimes be offset below the table.

Now check for the element's renderer at the beginning of show() and
return early if it is null.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show):
17:20 Changeset [22434] by aroben

Reviewed by Beth.

Fix: <rdar://problem/4799084> Text and dropdown button too close
together in <select>s
Fix: <rdar://problem/4800493> Popup menus should be positioned so that
their text is horizontally aligned with the <select> control's text

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR vs. RTL popups, and add padding to align the text. (WebCore::PopupMenu::paint): Add padding from the <select> control to align the text with the <select> control's text.
  • rendering/RenderThemeWin.cpp: Set svn:eol-style native. (WebCore::RenderThemeWin::systemFont): Clean up line endings. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra padding between the dropdown button and text. (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
16:34 Changeset [22433] by aroben

Forgot to make the change to Release as well in my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
16:25 Changeset [22432] by aroben

Rubberstamped by Steve.

Add some missing '/d' flags to xcopy calls to only copy headers if
they've been modified.

  • WebCore.vcproj/WebCore.vcproj:
16:12 Changeset [17350] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Build fix.

  • html/CanvasRenderingContext2D.cpp: Include MathExtras.h
16:02 Changeset [22431] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspellingOrBadGrammar): Build fix from Oliver.
15:57 Changeset [17349] by sullivan

WebCore:

Reviewed by Anders.

Some changes to support new grammar checking code in WebKit.

  • WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit


  • WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly

WebKit:

Reviewed by Anders

  • WebView/WebFrame.mm: now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h> (-[WebFrame _unmarkAllBadGrammar]): filled in guts (-[WebFrame _unmarkAllMisspellings]): rewrote to call Document directly, bypassing bridge
15:30 Changeset [17348] by sullivan
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib:


Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.

15:27 Changeset [17347] by ggaren

Reviewed by Geoff.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11419
REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
([view isKindOfClass:[WebHTMLView class]]) when running the layout tests

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseMoveToX:Y:]):
15:22 Changeset [17346] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady.

Add reverseFind to String and use it instead of findRev.
Use CString instead of DeprecatedCString in one place.


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset):
  • platform/PlatformString.h: (WebCore::String::reverseFind):
  • platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind):
  • platform/StringImpl.h:
14:27 Changeset [17345] by sullivan

Reviewed by Darin


More plumbing for grammar checking. Still no grammars is checked.

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"


  • platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling


  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT".


  • rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar
14:19 Changeset [17344] by darin

Added bug number to change log entry.

14:17 Changeset [17343] by darin

Reviewed by Adam.

  • editing/execCommand/remove-formatting-expected.txt: Roll back results. The ones just checked in showed the same kind of intermittent failure that copy-paste-bidi.html used to show -- now we consistently get these results.
13:52 Changeset [17342] by thatcher

New tag.

13:42 Changeset [17341] by thatcher

Re-versioning

13:32 Changeset [17340] by thatcher

Versioning

13:29 Changeset [17339] by spadma

2006-10-25 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly. Merge from CCB
http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
13:23 Changeset [17338] by weinig

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
Cleanup rendering code

  • Assorted code cleanup.
  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent):
  • rendering/CounterListItem.h:
  • rendering/CounterNode.cpp:
  • rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset):
  • rendering/CounterResetNode.cpp:
  • rendering/CounterResetNode.h:
  • rendering/DataRef.h: (WebCore::DataRef::DataRef):
  • rendering/DeprecatedRenderSelect.h:
  • rendering/DeprecatedSlider.cpp:
  • rendering/DeprecatedSlider.h:
  • rendering/EllipsisBox.cpp:
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
  • rendering/FixedTableLayout.cpp:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty):
  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions):
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject):
  • rendering/Length.h: (WebCore::Length::Length):
  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderPartObject.h:
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:
12:44 Changeset [17337] by justing

LayoutTests:

Reviewed by john


<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

  • editing/execCommand/remove-formatting-2-expected.checksum: Added.
  • editing/execCommand/remove-formatting-2-expected.png: Added.
  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html: Added.
  • editing/execCommand/remove-formatting-expected.txt:

WebCore:

Reviewed by john

<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.


  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner.
  • editing/Editor.h:
  • editing/JSEditor.cpp:
12:24 Changeset [17336] by zbujtas

2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414
merged from 3.1m r17335


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
12:06 Changeset [17335] by zbujtas

2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
11:54 Changeset [17334] by oliver

2006-10-26 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.
Fixes <rdar://problem/4800518> -- needed to update existing
canvas path elements when transforms are performed on the
context.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate):
11:51 Changeset [22430] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Use FrameLoadRequest and ResourceRequest instead of passing around
the individual components.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::frameLoadRequest): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
11:27 Changeset [17333] by weinig

Reviewed by Darin.

Fix build with older gcc 3.3.4.

  • kjs/DateMath.cpp: Remove inline prefix. (KJS::equivalentYearForDST):
11:25 Changeset [17332] by weinig

WebCore:

Reviewed by Darin.

Fix Qt/Linux build.

  • platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest):

WebKitQt:

Reviewed by Darin.

Fix Qt/Linux build.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::openUrl):

WebKitTools:

Reviewed by Darin.

Fix Qt/Linux build.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
11:23 Changeset [22429] by aroben

Reviewed by Adele.

Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
should close the popup and move selection in the page

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Don't cache the focused index. (WebCore::PopupMenu::focusedIndex): Always get the focused index from the HTMLSelectElement. (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling valueChanged(), as this will change the result of focusedIndex(). (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll the popup. (WebCore::PopupWndProc): Send TAB keypresses and printable characters back to the WebView for handling. Also omove handling of Return/Escape into the WM_CHAR event, as this is recommended by MSDN.
11:19 Changeset [17331] by aroben

Reviewed by Adele.

Fix: <rdar://problem/3951815> add "type-to-select" feature for list
boxes (<select> elements)

This also adds type-ahead find for closed menulists (popups).

  • WebCore.xcodeproj/project.pbxproj: Version wars.
  • html/HTMLSelectElement.h: Add new instance variables for type-ahead find.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new instance variables. (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead find on printable character presses. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove redundant check that the listIndex has changed (setSelectedIndex does this for us), and fix indentation. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if to an else-if. (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind() to strip leading whitespace (including non-breaking spaces) from a string. (WebCore::HTMLSelectElement::typeAheadFind): New method to perform type-ahead find.
  • platform/PopupMenu.h: Added new updateFromElement() method to be called from RenderMenuList::updateFromElement().
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::updateFromElement): While we are using NSPopUpButtonCell for our popups, this method can stay empty.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first selected element.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Tell the popup to update if it's visible.
11:05 Changeset [17330] by thatcher

Tag for WebKit for 10.4.1 (unchanged from 10.4).

11:04 Changeset [17329] by thatcher

Tag for JavaScriptCore for 10.4.1 (unchanged from 10.4).

11:02 Changeset [17328] by thatcher

Tag for JavaScriptCore for 10.4 (JavaScriptCore 412).

11:01 Changeset [17327] by thatcher

Tag for WebKit for 10.4 (WebKit 412).

11:00 Changeset [17326] by thatcher

Tag for WebCore for 10.4 (WebCore 413).

10:59 Changeset [17325] by thatcher

New release tag for 10.4.

10:57 Changeset [17324] by thatcher

Tag for JavaScriptCore for 10.4.2 (JavaScriptCore 412.3).

10:56 Changeset [17323] by thatcher

Tag for WebKit for 10.4.2 (WebKit 412.6).

10:55 Changeset [17322] by thatcher

Tag for WebCore for 10.4.2 (WebCore 415.11).

10:54 Changeset [17321] by thatcher

New release tag for 10.4.2.

10:53 Changeset [17320] by thatcher

Tag for WebCore for 10.4.1 (WebCore 415.5).

10:48 Changeset [17319] by thatcher

New release tag for 10.4.1.

10:44 Changeset [17318] by thatcher

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:44 Changeset [17317] by thatcher

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:44 Changeset [17316] by thatcher

bad tag.

10:43 Changeset [17315] by thatcher

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:42 Changeset [17314] by thatcher

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:40 Changeset [17313] by darin

"causing give inconsistent results" -> "causing inconsistent results"

10:40 Changeset [17312] by thatcher

Tag for JavaScriptGlue for 10.4.8 (unchanged from 10.4.7).

10:39 Changeset [17311] by darin

LayoutTests:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the anonymous block that sometimes appeared and sometimes did not.

WebCore:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Use two vectors instead of a map: more efficient, deterministic. There was no reason to use a hash table.
10:39 Changeset [17310] by thatcher

Tag for JavaScriptCore for 10.4.8 (unchanged from 10.4.7).

10:38 Changeset [17309] by thatcher

New release tag.

09:59 Changeset [17308] by darin
  • oops, checked in failure results, not success
  • fast/js/string-property-iteration-expected.txt: Successful results.
09:46 Changeset [17307] by darin
  • checked in some missing results (if these are wrong we could remove or disable the test)
  • svg/hixie/cascade/002-expected.checksum: Added.
  • svg/hixie/cascade/002-expected.png: Added.
  • svg/hixie/cascade/002-expected.txt: Added.
09:39 Changeset [17306] by darin

JavaScriptCore:

Reviewed by John.

  • fix iteration of properties of string objects (found because of a warning emitted by the MSVC compiler)
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that wants to format a number as a string to use UString::from. Before it was using the UString constructor that makes a string from a character!
  • kjs/ustring.h:
  • kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char) constructor.
  • kjs/grammar.y: Change code to not depend on the UString(char) constructor. This is potentially more efficient anyway because we could overload the + operator some day to handle char* directly instead of creating a UString.
  • kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on the UString(char) constructor.

LayoutTests:

Reviewed by John.

  • add a test for iteration of properties of string objects
  • fast/js/resources/string-property-iteration.js: Added.
  • fast/js/string-property-iteration-expected.txt: Added.
  • fast/js/string-property-iteration.html: Added.
09:06 Changeset [17305] by sullivan
09:05 Changeset [17304] by brmorris

2006-10-25 yadavall <sriram.yadavalli@nokia.com>

Merge of r17301 to s60-RnD-06wk43 release branch.

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407

09:05 Changeset [17303] by sullivan

No review, just two localized string changes.


  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
  • English.lproj/Localizable.strings: updated for these changes
08:23 Changeset [17302] by spadma

2006-10-25 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly
http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
06:26 Changeset [17301] by spadma

2006-10-25 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::UpdateDefaultSoftkeysL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
  • BrowserView/inc/webkitbridge.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged): (CWebKitBridge::createWidgetObject):
  • Plugin/inc/PluginHandler.h:
  • Plugin/inc/PluginSkin.h: (CPluginSkin::WebKitControl): (CPluginSkin::Frame):
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue):
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginHandler::LoadPluginsSyncL): (CPluginHandler::LoadPluginsL): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::ReloadPluginsL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::CreatePluginWinL): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::PluginScriptableObject):
  • Plugin/src/PluginWin.cpp: (CPluginWin::WindowScriptNPObject): (CPluginWin::PluginScriptableObject):
  • group/BrowserView.mmp:
  • group/Plugin.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
03:34 Changeset [17300] by mjs

Reviewed by Anders.

  • .5% speed improvement by avoiding excess CFURLRef allocation
  • loader/CachedResource.cpp: (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL here for later reuse.
  • loader/CachedResource.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.

10/25/06:

22:04 Changeset [17299] by darin

WebCore:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::startRedirectionTimer): (WebCore::FrameMac::stopRedirectionTimer): (WebCore::FrameMac::passSubframeEventToSubframe): (WebCore::FrameMac::handledOnloadEvents): (WebCore::FrameMac::isLoadTypeReload):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge executionContextForView:]): (updateRenderingForBindings): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreFrameBridge installInFrame:]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • loader/FrameLoaderTypes.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]): (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy): (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView keyDown:]): (-[WebCoreTableView keyUp:]):
  • platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]):

WebKit:

Reviewed by Anders.

  • removed 55 methods from WebCoreFrameBridge
  • changed callers to use Frame directly instead
  • put FrameLoaderTypes.h types into the WebCore namespace
  • first steps to get FrameLoader.h ready for cross-platform duty
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.m: (-[WebPluginContainerCheck _continueWithPolicy:]): (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge webView]): (-[WebFrameBridge finishInitializingWithFrameName:view:]): (-[WebFrameBridge createWindowWithURL:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge createModalDialogWithURL:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchWillSubmitForm):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]):
  • WebView/WebEditingDelegatePrivate.h:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _childFramesMatchItem:]): (-[WebFrame _URLsMatchItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _viewWillMoveToHostWindow:]): (-[WebFrame _viewDidMoveToHostWindow]): (-[WebFrame _addChild:]): (-[WebFrame _saveDocumentAndScrollState]): (-[WebFrame _numPendingOrLoadingRequests:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]): (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]): (-[WebFrame _initWithWebFrameView:webView:coreFrame:]): (-[WebFrame _documentViews]): (-[WebFrame _updateBackground]): (-[WebFrame _unmarkAllMisspellings]): (-[WebFrame _hasSelection]): (-[WebFrame _atMostOneFrameHasSelection]): (-[WebFrame _findFrameWithSelection]): (-[WebFrame _frameLoader]): (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame init]): (-[WebFrame initWithName:webFrameView:webView:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame name]): (-[WebFrame webView]): (-[WebFrame DOMDocument]): (-[WebFrame frameElement]): (-[WebFrame findFrameNamed:]): (-[WebFrame parentFrame]): (-[WebFrame childFrames]): (-[WebFrame _invalidateCurrentItemPageCache]): (-[WebFrame _dispatchCreateWebViewWithRequest:]): (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation DOMDocument]): (-[WebHTMLRepresentation attributedText]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): (-[WebHTMLView _documentFragmentWithPaths:]): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): (-[WebHTMLView _selectedRange]): (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _hasSelection]): (-[WebHTMLView _hasSelectionOrInsertionPoint]): (-[WebHTMLView _hasInsertionPoint]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[WebHTMLView _selectionDraggingImage]): (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _updateActiveState]): (-[NSArray readSelectionFromPasteboard:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray maintainsInactiveSelection]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray centerSelectionInVisibleArea:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray _emptyStyle]): (-[NSArray performKeyEquivalent:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView _selectRangeInMarkedText:]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView selectionRect]): (-[WebHTMLView selectionImageForcingWhiteText:]): (-[WebHTMLView selectionImageRect]): (-[WebHTMLView attributedString]): (-[WebHTMLView _isMoveDrag]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebPolicyDelegate.mm: (-[WebPolicyDecisionListener _usePolicy:]): (-[WebPolicyDecisionListener use]): (-[WebPolicyDecisionListener ignore]): (-[WebPolicyDecisionListener download]): (-[WebPolicyDecisionListener continue]):
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]): (-[WebScriptCallFrame globalObject]):
  • WebView/WebView.mm: (-[WebView _attachScriptDebuggerToAllFrames]): (-[WebView _detachScriptDebuggerFromAllFrames]): (-[WebView windowScriptObject]): (incrementFrame): (-[WebView searchFor:direction:caseSensitive:wrap:]): (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]): (-[WebView removeDragCaret]): (-[WebView setScriptDebugDelegate:]): (-[WebView scriptDebugDelegate]): (-[WebView shouldClose]): (-[WebView selectedDOMRange]): (-[WebView styleDeclarationWithText:]):
19:43 Changeset [17298] by bdash

2006-10-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Adele.

  • coding/coding-style.html:
17:48 Changeset [22428] by sfalken

2006-10-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.


Checked in Luke's CG printing code

  • WebView.cpp: (WebView::print): added (WebViewWndProc): call print from WM_PRINTCLIENT
  • WebView.h: added print, m_pages, rearranged includes
17:48 Changeset [22427] by sfalken

2006-10-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Checked in Luke's CG printing code

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::setupRootForPrinting): Added (WebCore::FrameWin::computePageRects): Added
  • bridge/win/FrameWin.h: Added setupRootForPrinting, computePageRects
17:43 Changeset [17297] by sfalken

2006-10-25 Steve Falkenburg <sfalken@apple.com>

Reviewed by Darin.

Printing fixes

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight):
  • page/Frame.h: (WebCore::Frame::setupRootForPrinting): (WebCore::Frame::computePageRects):
17:29 Changeset [17296] by kmccullo

Reviewed by Steve (rubber stamp).

  • Link against your local build of JavaScriptCore.lib first, this fixes some errors on release builds of testkjs.
17:27 Changeset [17295] by thatcher

Reverting my change, broke the Tiger build.

17:12 Changeset [17294] by andersca

2006-10-25 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

<rdar://problem/4799088>
REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.

  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]): Set the HTTP method before the HTTP body.
16:42 Changeset [17293] by thatcher

Reviewed by Kevin Decker.

  • libWebKitSystemInterface.a: updated to be 64-bit universal
14:15 Changeset [17292] by brmorris

New release branch.

13:51 Changeset [17291] by ggaren

Reviewed by Lou.


Removed duplicate symbol declaration.

13:49 Changeset [17290] by ggaren

WebCore:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/mac/FrameLoader.mm: Added.
  • loader/mac/IconLoaderMac.mm:
  • loader/mac/WebDocumentLoader.mm:
  • loader/mac/WebFrameLoader.h: Removed.
  • loader/mac/WebFrameLoader.mm: Removed.
  • loader/mac/WebLoader.mm:
  • loader/mac/WebMainResourceLoader.mm:
  • loader/mac/WebNetscapePlugInStreamLoader.mm:
  • loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Adam.

Renamed WebFrameLoader to FrameLoader, to match class name.

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebFrame.mm:
  • WebView/WebPDFView.mm:
  • WebView/WebPolicyDelegate.mm:
  • WebView/WebView.mm:
12:29 Changeset [17289] by darin
  • fix full builds
  • WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
05:12 Changeset [17288] by bdash

2006-10-25 David Smith <catfish.man@gmail.com>

Reviewed by Mitz.

Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
http://bugs.webkit.org/show_bug.cgi?id=11411

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
02:57 Changeset [17287] by mjs

Rubber stamped by Mitz.

  • moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
  • bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
02:55 Changeset [17286] by mjs

Rubber stamped by Mark.

  • remove no longer existing symbol that was breaking linking
  • WebCore.exp:
01:52 Changeset [17285] by mjs

Reviewed by Mitz.


I couldn't figure out how to write a test case.

  • bindings/js/kjs_window.cpp: (KJS::Window::clear): Avoid crashing if already detached.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear): Change prototype to make this a proper overload for Frame::clear once again(!).
01:22 Changeset [17284] by bdash

2006-10-25 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

Fix some HTML bugs in the coding style guidelines.

  • coding/coding-style.html:
00:52 Changeset [17283] by bdash

2006-10-25 Mark Rowe <bdash@webkit.org>

Reviewed by Anders.

Build fix for the Buildbot.

  • WebView/WebHTMLView.m: (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
00:30 Changeset [17282] by mjs

Reviewed by Anders.


<rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
<rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet

  • WebView/WebPolicyDeciderMac.m: (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it

10/24/06:

22:38 Changeset [17281] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

  • WebKitPrefix.h: Include FastMalloc.h from C++ code.
22:35 Changeset [17280] by darin

WebCore:

Reviewed by Anders.

  • converted WebFrameLoaderClient to C++
  • renamed frame->frameLoader() function to frame->loader()
  • renamed [bridge impl] to [bridge _frame]
  • removed some bridge methods
  • WebCore.exp: Added more exports.
  • WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal so it can be used in WebKit.
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame): (WebCore::FrameMac::didFirstLayout):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge setOpener:]): (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]): (-[WebCoreFrameBridge _frame]): (-[WebCoreFrameBridge executionContextForView:]):
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setMainFrame:]):
  • dom/Position.cpp: (WebCore::Position::upstream):
  • loader/mac/IconLoaderMac.mm: (IconLoader::notifyIconChanged):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/mac/WebFormState.mm: (WebCore::FormState::FormState):
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setDefersCallbacks): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::identifierForInitialRequest): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::download): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::willUseArchive): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::committedLoad): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::actionInformation): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • page/Frame.cpp: (WebCore::Frame::loader):
  • page/Frame.h:
  • platform/mac/SliderMac.mm: (Slider::focusPolicy):

WebKit:

Reviewed by Anders.

  • converted WebFrameLoaderClient to C++
  • renamed frame->frameLoader() function to frame->loader()
  • renamed [bridge impl] to [bridge _frame]
  • removed some bridge methods
  • Plugins/WebNetscapePluginStream.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebFrameLoaderClient.h: Added. (WebFrameLoaderClient::webFrame):
  • WebCoreSupport/WebFrameLoaderClient.mm: Added. (WebFrameLoaderClient::detachFrameLoader): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.mm: (-[WebDataSource webFrame]):
  • WebView/WebFrame.mm: (frame): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame parentFrame]): (-[WebFrame _provisionalLoadStarted]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray _selectionStartFontAttributesAsRTF]): (-[NSArray changeBaseWritingDirection:]): (-[NSArray indent:]): (-[NSArray outdent:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView setEditable:]):
22:30 Changeset [17279] by darin

Rubber stamped by Anders.

  • get rid of the assertion firing while running the layout tests

This does not fix the real problem, which is that we need to map offsets within
possibly-text-transformed text in the render tree to DOM tree offsets and vice
versa -- but it gets the tests running again.

  • dom/Position.cpp: (WebCore::Position::upstream): Commented out the assertion.
21:25 Changeset [17278] by mjs

LayoutTests:

Reviewed by Oliver.

  • re-enable testing of HEAD methods, now that bugs relating to these are fixed
  • http/tests/xmlhttprequest/methods-async-expected.txt:
  • http/tests/xmlhttprequest/methods-async.html:
  • http/tests/xmlhttprequest/methods-expected.txt:
  • http/tests/xmlhttprequest/methods.html:

WebCore:

Reviewed by Oliver.

  • more ResourceLoader cleanup
    • moved HTTPHeaderMap out of ResourceRequest class, so ResourceResponse will be able to use it too
    • took out attempts to suppress setting of "HEAD" and "GET" methods, since underlying bugs are now fixed


  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • platform/network/HTTPHeaderMap.h: Added.
  • platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::requestHeaders):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceRequest.h:
  • platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
  • xml/xmlhttprequest.h:
21:23 Changeset [17277] by slewis

2006-10-24 Stephanie Lewis <slewis@apple.com>

Reviewed by Maciej.

  • Changed run-javascriptcore tests to build testkjs before running.
  • Scripts/run-javascriptcore-tests:
21:22 Changeset [22426] by mjs

Reviewed by Oliver.

  • updated for ResourceRequest changes.
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
18:37 Changeset [17276] by justing

LayoutTests:

Reviewed by darin

<http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker

  • editing/execCommand/create-list-1-expected.checksum: Added.
  • editing/execCommand/create-list-1-expected.png: Added.
  • editing/execCommand/create-list-1-expected.txt: Added.
  • editing/execCommand/create-list-1.html: Added.


Fixed:

  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:
  • fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

Reviewed by darin

<http://bugs.webkit.org/show_bug.cgi?id=10993>
GMail Editor: Caret doesn't always position itself after list marker


List creation uses moveParagraphs to push content into list items.
moveParagraphs uses a TextIterator to restore selections after moves.
Some characters emitted by the TextIterator had bad ranges associated
with them. rangeFromLocationAndLength would skip past the range it
should have used when asked for ranges of length 0.

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): No longer need to initialize a removed member variable. (WebCore::TextIterator::advance): An extra newline is emitted when leaving some blocks. Use the same range for this newline as for the first newline. We should remove this code and just emit two '\n's. (WebCore::TextIterator::handleTextNode): Setup m_range. (WebCore::TextIterator::handleTextBox): Ditto. (WebCore::TextIterator::handleReplacedElement): Ditto. (WebCore::TextIterator::handleNonTextNode): Ditto. (WebCore::TextIterator::exitNode): Use an m_range from the last VisiblePosition in the block we're leaving to that VP after that one. (WebCore::TextIterator::emitCharacter): This function now takes in the start and the end of the range associated with the emited character, and sets up m_range. (WebCore::TextIterator::range): Return m_range. If it is null (we are atEnd), return the end of the range used to create the iterator, as a convenience to callers that use call range() on an iterator that is atEnd. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Same as the changes made to TextIterator's constructor. (WebCore::SimplifiedBackwardsTextIterator::advance): Use a null m_range instead of a null m_positionNode to signal that we're finished. (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Similar to changes made to TextIterator. (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): Ditto. (WebCore::SimplifiedBackwardsTextIterator::emitNewline): Simplified. (WebCore::SimplifiedBackwardsTextIterator::range): Similar to the changes made to TextIterator::range. (WebCore::CharacterIterator::range): This function assumed that an iterator's range() was safe to modify. (WebCore::TextIterator::rangeFromLocationAndLength): If the range we're looking for starts in the current chunk, this function assumed that if the chunk started in a text node, it would end in the same text node. This is no longer the case. If the range we're looking for starts in the middle of the current chunk, I assume that the chunk is inside a text node, because those are the only chunks with length greater than one at the moment. If the range we're looking for is a zero length range that starts/ends at the end of the current chunk, we used to return the start of the next chunk, but that's wrong and is what caused this bug.
  • editing/TextIterator.h: (WebCore::TextIterator::atEnd): The iterator is atEnd when m_range is null. (WebCore::SimplifiedBackwardsTextIterator::atEnd):
  • editing/visible_units.cpp: (WebCore::previousBoundary): Cleaned up by using a convenience function. (WebCore::nextBoundary): Ditto.
18:05 Changeset [22425] by sfalken

2006-10-24 Steve Falkenburg <sfalken@apple.com>

Build fix for official builds

17:31 Changeset [17275] by sfalken

2006-10-24 Steve Falkenburg <sfalken@apple.com>

Build config change

17:11 Changeset [17274] by sullivan

Reviewed by Kevin Decker


  • fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether the spelling panel is already showing. Also, removed else's after returns, and removed braces around one-line if clauses. (-[NSArray showGuessPanel:]): post-Tiger, make this item hide the spelling panel if it's already showing
  • English.lproj/Localizable.strings: updated for this change
16:49 Changeset [17273] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Don't retain the header dictionary.
16:11 Changeset [17272] by ggaren

Reviewed by Anders.

Fixed http://bugs.webkit.org/show_bug.cgi?id=11404
REGRESSION: Reproducible assertion failure in Shared<WebCore::StringImpl>::ref()
running svg/custom/svg/custom/gradient-attr-update.svg


SVGRenderStyle wasn't ref-ing the shared objects it held onto. Oops.

  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
15:59 Changeset [22424] by sfalken

2006-10-24 Steve Falkenburg <sfalken@apple.com>

Bump version to 521.28.6

  • WebKit.vcproj/VERSION:
15:57 Changeset [22423] by sfalken

2006-10-24 Steve Falkenburg <sfalken@apple.com>

Fix build so it can be submitted.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/merge-opensource.sh:
  • rendering/RenderThemeWin.cpp:
15:56 Changeset [17271] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Mitz.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): Set the http method to "GET" in the constructor that takes a String.
15:48 Changeset [17270] by weinig

Reviewed by Tim H.

Move kcanvas/Render* and kcanvas/SVG* to rendering/Render*
and rendering/SVG* respectively. Fix Xcode project and
CMakeLists.txt to account for the moves.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/RenderForeignObject.cpp: Removed.
  • kcanvas/RenderForeignObject.h: Removed.
  • kcanvas/RenderPath.cpp: Removed.
  • kcanvas/RenderPath.h: Removed.
  • kcanvas/RenderSVGContainer.cpp: Removed.
  • kcanvas/RenderSVGContainer.h: Removed.
  • kcanvas/RenderSVGImage.cpp: Removed.
  • kcanvas/RenderSVGImage.h: Removed.
  • kcanvas/RenderSVGInline.cpp: Removed.
  • kcanvas/RenderSVGInline.h: Removed.
  • kcanvas/RenderSVGInlineText.cpp: Removed.
  • kcanvas/RenderSVGInlineText.h: Removed.
  • kcanvas/RenderSVGTSpan.cpp: Removed.
  • kcanvas/RenderSVGTSpan.h: Removed.
  • kcanvas/RenderSVGText.cpp: Removed.
  • kcanvas/RenderSVGText.h: Removed.
  • kcanvas/SVGInlineFlowBox.cpp: Removed.
  • kcanvas/SVGInlineFlowBox.h: Removed.
  • kcanvas/SVGRootInlineBox.cpp: Removed.
  • kcanvas/SVGRootInlineBox.h: Removed.
15:37 Changeset [17269] by thatcher

Build fix.

15:34 Changeset [17268] by thatcher

Reviewed by Anders.

<rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'

  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _webView]):
15:28 Changeset [22422] by ggaren

Rolling back in, now fixed:


Nixed a few more redundant loading functions in Frame.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
15:24 Changeset [17267] by ggaren

Rolling back in, now fixed:


Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Kept always 'true' argument for userGesture always 'true', because changing it broke the world, and testing seems to indicate that the one caller that might have passed 'false' didn't need to.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
15:21 Changeset [22421] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

  • WebFrame.cpp: (WebFrame::loadDataSource): Forgot to save before committing. Call begin before trying to access the document.
15:15 Changeset [22420] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Fix build. (Update for changes to ResourceLoader)


  • WebFrame.cpp: (WebFrame::loadDataSource):
  • WebURLResponse.cpp: (WebURLResponse::createInstance):
15:06 Changeset [17266] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Fix the build (Update for changes to ResourceLoader)


  • platform/network/cf/ResourceLoaderCFNet.cpp: (WebCore::addHeadersFromHashMap): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
14:58 Changeset [22419] by mjs

Reviewed by Geoff.

  • update for ResourceLoader API changes
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
14:57 Changeset [17265] by weinig

Reviewed by Mitz.

Change #includes using <kcanvas/*.h> to use "*.h" instead
to prepare for moving the kcanvas files.

  • kcanvas/RenderSVGContainer.h:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
14:53 Changeset [17264] by mjs

Reviewed by Darin.

  • More movement towards the final network API.


Changed ResourceLoader::create to take a ResurceRequest and start
the load. Removed methods relating to setting request
headers. Removed methods relating to metaData. Added some more
convenience methods to ResourceRequest.

  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm):
  • platform/network/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::responseHTTPHeadersAsString): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::httpAccept): (WebCore::ResourceRequest::setHTTPAccept): (WebCore::ResourceRequest::addHTTPHeaderFields):
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::retrieveResponseEncoding):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
14:26 Changeset [17263] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

  • loader/FormData.cpp: (WebCore::FormData::FormData):
  • loader/FormData.h: (WebCore::FormData::FormData): Add new constructor that takes a void* and a size.
14:25 Changeset [17262] by thatcher

Build fix for un-initialized var.

14:24 Changeset [17261] by beidson

Reviewed by Anders

http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
to prevent null dereferencing.

  • WebView/WebFrame.mm: (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]):
14:17 Changeset [22418] by ggaren

Rolling out my last change because it broke the world.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURL):
14:14 Changeset [17260] by ggaren

Rolling out my last change because it broke the world.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::openURL): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
  • page/Frame.cpp: (WebCore::Frame::openURL): (WebCore::Frame::frameLoader): (WebCore::Frame::requestFrame): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::openURLRequest):
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::openURL): (WebCore::FrameWin::openURLRequest):
13:50 Changeset [17259] by thatcher

Build fixes for 64-bit.

13:46 Changeset [17258] by kmccullo

Reviewed by Brady.

  • Fixes a date formatting issue on win. Specifically strftime cannot handle some ranges of time so we shift time call strftime and then manipulate the returned string, if needed.
  • kjs/date_object.cpp: (KJS::): (KJS::formatLocaleDate): (KJS::DateProtoFunc::callAsFunction):
13:03 Changeset [17257] by bdash

2006-10-24 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Adam.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11396

Kill KRenderingFillPainter/KRenderingStrokePainter. Those are not needed
anymore, since kcanvas/ksvg2 are tightly integrated. No LayoutTests fixed
or broken.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<): (WebCore::writeStyle):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::fillContains):
  • kcanvas/device/KRenderingFillPainter.cpp:
  • kcanvas/device/KRenderingFillPainter.h:
  • kcanvas/device/KRenderingStrokePainter.cpp:
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
  • kcanvas/device/qt/KRenderingPaintServerQt.h:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup):
  • kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke): (WebCore::RenderPath::strokeBBox):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerQuartzHelper::fillPath): (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
  • kcanvas/device/quartz/QuartzSupport.h: (WebCore::CGLineCapFromKC): (WebCore::CGLineJoinFromKC):
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext): (WebCore::strokeBoundingBox):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::):
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::dashArrayFromRenderingStyle):
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
12:54 Changeset [22417] by andersca

2006-10-24 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

<rdar://problem/4760429> Crash in PluginStreamWin::~PluginStreamWin when
navigating away from mcdonalds.com


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::fetchInfo): Use fastFree instead of free when memory is allocated by fastMalloc. If the plugin name or description is null, don't try to fetch info about the plugin.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
  • plugins/win/PluginStreamWin.h: Change type of header map to ResourceRequest::HTTPHeaderMap. When a plugin is stopped, set its state to StreamStopped.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::loadURL): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h: Update for type changes to the header map.
12:20 Changeset [22416] by ggaren

Reviewed by Anders.


Nixed a few more redundant loading functions in Frame.

  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::shouldInterruptJavaScript): (FrameWin::lastEventIsMouseUp):
12:17 Changeset [17256] by ggaren

Reviewed by Anders.

Nixed a few more redundant loading functions in Frame. Did my best to update
the non-Mac builds.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): Changed always 'true' argument for userGesture to actually check for a user gesture. New callers rely on this behavior, and it seems like the previous behavior must have been a bug.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): (WebCore::Frame::frameLoader): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • platform/gdk/FrameGdk.cpp:
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::issueCopyCommand):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::shouldInterruptJavaScript): (WebCore::FrameWin::issueCopyCommand):
12:14 Changeset [17255] by sullivan

Reviewed by Darin


Initial plumbing for grammar checking. No actual grammar are checked at this time.

  • English.lproj/WebViewEditingContextMenu.nib/classes.nib:
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Added grammar-checking item, reworded to match changes in framework. This will be used post-Tiger.
  • English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
  • English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
  • English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added. Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Choose the right context menu based on BUILDING_ON_TIGER.


  • WebView/WebPreferenceKeysPrivate.h: declare grammar-related NSUserDefault value
  • WebView/WebViewPrivate.h: declare grammar-related methods
  • WebView/WebView.mm: declare static BOOL grammarCheckingEnabled (-[WebViewPrivate init]): initialize grammarCheckingEnabled to NSUserDefaults value (-[WebView validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebView isGrammarCheckingEnabled]): return value of grammarCheckingEnabled (-[WebView setGrammarCheckingEnabled:]): set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers (-[WebView toggleGrammarChecking:]): flip the value


  • WebView/WebFrameInternal.h:
  • WebView/WebFrame.mm: (-[WebFrame _unmarkAllBadGrammar]): new placeholder method, does nothing yet


  • WebView/WebHTMLViewInternal.h: declare grammar-related methods
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): validate toggleGrammarChecking: menu item (-[WebHTMLView isGrammarCheckingEnabled]): new method, calls through to WebView (-[WebHTMLView setGrammarCheckingEnabled:]): ditto (-[WebHTMLView toggleGrammarChecking:]): ditto


  • English.lproj/StringsNotToBeLocalized.txt: Updated for these changes


  • WebKit.xcodeproj/project.pbxproj: updated for new files
08:14 Changeset [17254] by brmorris

Reviewed by Sachin.
DESC: Automatically open download file progressively settings. If yes,

then download file will be open progressively. If no, then the user
need to open the file manually.

http://bugs.webkit.org/show_bug.cgi?id=11392

06:10 Changeset [17253] by weinig

WebCore:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • CMakeLists.txt:
  • platform/qt/BrowserExtensionQt.cpp: Removed.
  • platform/qt/BrowserExtensionQt.h: Removed.
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::createNewWindow): (WebCore::FrameQt::goBackOrForward): (WebCore::FrameQt::historyURL): (WebCore::FrameQt::getHistoryLength):
  • platform/qt/FrameQt.h:
  • platform/qt/PageQt.cpp: (WebCore::Page::canRunModal): (WebCore::Page::canRunModalNow): (WebCore::Page::runModal):

WebKitQt:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • QtLauncher/CMakeLists.txt:
  • WebKitPart/CMakeLists.txt:

WebKitTools:

Reviewed by Maciej.

Fix Qt/Linux build.

  • Remove BrowserExtensionQt, move it's methods to Page/FrameQt.
  • Fix CMakeLists.txt to include platform/network.
  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
06:06 Changeset [17252] by weinig

Reviewed by Tim H.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11314
Fix build when XSLT_SUPPORT is not defined

Fix unconditional use of XSLT support.

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end):
04:26 Changeset [17251] by bdash

2006-10-24 Simon Hausmann <hausmann@kde.org>

Reviewed by Darin.

  • CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.

2006-10-24 Simon Hausmann <hausmann@kde.org>

Reviewed by Darin.

  • QtLauncher/CMakeLists.txt, WebKitPart/CMakeLists.txt: Added project name to kde4_automoc macro, as required by the latest KDE4 cmake module.
04:19 Changeset [17250] by bdash

2006-10-24 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Bug 11382: [Drosera] Dragging breakpoints onto each other can mess up inline editor
http://bugs.webkit.org/show_bug.cgi?id=11382

  • Drosera/debugger.js: Breakpoint dragging now ensures that editors aren't orphaned.
04:15 Changeset [17249] by bdash

2006-10-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Tim H.

  • html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid ref cycle.
01:49 Changeset [17248] by ggaren

Reviewed by Darin.

Removed one of Frame's redundant urlSelected methods.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::urlSelected): since it's unused.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString to String because the former is deprecated and its performance is irrelevant here. Added call to completeURL because Frame no longer does it for us. Having the call here also improves clarity about the element's behavior.
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre irrelevent NULL checks on ownerDocument() because I couldn't help myself.
  • page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected):
  • page/Frame.h:
  • platform/network/ResourceRequest.h: Removed explicit keyword on constructor because we want to be able to use these constructors instead of helper functions mimicking their behavior sprinkled across different classes. (WebCore::ResourceRequest::ResourceRequest):
00:59 Changeset [17247] by beidson

Reviewed by Maciej

Moved FrameLoader from WebCoreFrameBridge to Frame. Frame.h/cpp have generic accessors to the FrameLoader itself
and creation/deletion is currently managed in FrameMac.mm

Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
frame instead of the bridge.

The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
use of it as its days are numbered!

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Create the FrameLoader (WebCore::FrameMac::~FrameMac): Nuke it (WebCore::FrameMac::loadRequest):
  • bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader (-[WebCoreFrameBridge setFrameLoaderClient:]): (-[WebCoreFrameBridge frameLoader]): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::frameLoader):
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::defersCallbacksChanged): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete):
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::frameLoader):
  • loader/mac/WebSubresourceLoader.mm: (-[WebCoreSubresourceHandle initWithLoader:]):
  • page/Frame.cpp: (WebCore::Frame::frameLoader):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
00:33 Changeset [17246] by darin

Reviewed by Maciej.

  • fixed two crashes in layout tests I just introduced
  • loader/mac/WebFrameLoader.mm: (WebCore::FrameLoader::load): Add null check. (WebCore::FrameLoader::setState): Ditto.
Note: See TracTimeline for information about the timeline view.