Timeline


and

10/30/06:

21:50 Changeset [17472] by darin
  • fixed build
  • DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]): Don't use CFPasteboard.
21:49 Changeset [22446] by darin

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/win/TemporaryLinkStubs.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
21:46 Changeset [17471] by darin

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h: Removed.
  • bridge/mac/BrowserExtensionMac.h: Removed.
  • bridge/mac/BrowserExtensionMac.mm: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected):
  • bridge/win/BrowserExtensionWin.cpp: Removed.
  • bridge/win/BrowserExtensionWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • loader/FrameLoader.h:
  • loader/icon/IconLoader.cpp:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createWindow):
  • page/Frame.cpp: (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isEmpty): (WebCore::FrameLoadRequest::resourceRequest): (WebCore::FrameLoadRequest::frameName): (WebCore::FrameLoadRequest::setFrameName):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • platform/gdk/BrowserExtensionGdk.h: Removed.
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::isEmpty):
21:45 Changeset [17470] by darin
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Fix comment.
21:29 Changeset [17469] by thatcher

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11353

  • Drosera/debugger.js: ParsedURL() object now recognizes local files
20:48 Changeset [17468] by darin

Reviewed by Tim Hatcher.

  • DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard. This should make our buildbot tests no longer need a pasteboard server.
20:17 Changeset [17467] by oliver

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Modified from original due to earlier reversion

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp: Removed.
  • graphics/svg/SVGResourceClipper.cpp: Removed.
  • graphics/svg/SVGResourceClipper.h: Removed.
  • graphics/svg/SVGResourceImage.h: Removed.
  • graphics/svg/SVGResourceListener.h: Removed.
  • graphics/svg/SVGResourceMarker.cpp: Removed.
  • graphics/svg/SVGResourceMarker.h: Removed.
  • graphics/svg/SVGResourceMasker.cpp: Removed.
  • graphics/svg/SVGResourceMasker.h: Removed.
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h:
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp: (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
19:53 Changeset [17466] by sullivan

Reviewed by Brady


  • minor cleanup to make future patches clearer
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test with "continue" to better match structure of similar code in markMisspellings; a few other style tweaks.


(WebCore::FrameMac::markMisspellings):
renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
a block just after a break and outdented accordingly.

19:23 Changeset [17465] by ggaren

Reviewed by Beth.


Reorganized project file into Delegates and Controllers groups, and split
UIDelegate stuff into a UIDelegate class.


A little birdy told me that I might end up adding some UIDelegate methods
to DRT soon.

  • DumpRenderTree/DumpRenderTree.m: (main): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
18:54 Changeset [17464] by sullivan

WebCore:

Reviewed by Geoff Garen


WebCore part of change to push the code that updates the spelling panel
into WebCore, in preparation for some grammar-checking stuff.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): no more return value for this method, and update the spelling panel with the misspelled word here rather than in the WebKit callers.

WebKit:

Reviewed by Geoff Garen

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): removed code to update spelling panel; WebCore handles that now (-[NSArray showGuessPanel:]): ditto
18:36 Changeset [17463] by sullivan
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Another wording change to match framework, post-Tiger: "Check Spelling" -> "Check Document Now"
18:33 Changeset [17462] by oliver

liver Hunt <oliver@apple.com>

Reviewed by Anders.

Roll out last patch

  • CMakeLists.txt:
  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp:
  • graphics/svg/SVGResourceClipper.cpp:
  • graphics/svg/SVGResourceClipper.h:
  • graphics/svg/SVGResourceImage.h:
  • graphics/svg/SVGResourceListener.h:
  • graphics/svg/SVGResourceMarker.cpp:
  • graphics/svg/SVGResourceMarker.h:
  • graphics/svg/SVGResourceMasker.cpp:
  • graphics/svg/SVGResourceMasker.h:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasClipper::KCanvasClipper): (WebCore::KCanvasClipper::~KCanvasClipper): (WebCore::KCanvasClipper::resetClipData): (WebCore::KCanvasClipper::addClipData): (WebCore::KCanvasClipper::clipData): (WebCore::KCanvasClipper::externalRepresentation): (WebCore::getClipperById):
  • kcanvas/KCanvasClipper.h: Added. (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::KCClipDataList): (WebCore::KCClipDataList::addPath): (WebCore::KCanvasClipper::isClipper):
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Added. (WebCore::KCanvasImage::KCanvasImage): (WebCore::KCanvasImage::~KCanvasImage):
  • kcanvas/KCanvasMarker.cpp: Added. (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::~KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::setRef): (WebCore::KCanvasMarker::refX): (WebCore::KCanvasMarker::refY): (WebCore::KCanvasMarker::setAngle): (WebCore::KCanvasMarker::angle): (WebCore::KCanvasMarker::setAutoAngle): (WebCore::KCanvasMarker::setUseStrokeWidth): (WebCore::KCanvasMarker::useStrokeWidth): (WebCore::KCanvasMarker::draw): (WebCore::KCanvasMarker::externalRepresentation): (WebCore::getMarkerById):
  • kcanvas/KCanvasMarker.h: Added. (WebCore::KCanvasMarker::isMarker):
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::~KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added. (WebCore::KCanvasMasker::isMasker): (WebCore::KCanvasMasker::mask):
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasResource::KCanvasResource): (WebCore::KCanvasResource::~KCanvasResource): (WebCore::KCanvasResource::addClient): (WebCore::KCanvasResource::clients): (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: (WebCore::): (WebCore::KCanvasResource::isPaintServer): (WebCore::KCanvasResource::isFilter): (WebCore::KCanvasResource::isClipper): (WebCore::KCanvasResource::isMarker): (WebCore::KCanvasResource::isMasker):
  • kcanvas/KCanvasResourceListener.h: Added. (KCanvasResourceListener::KCanvasResourceListener): (KCanvasResourceListener::~KCanvasResourceListener):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: (WebCore::KCanvasClipperQt::applyClip):
  • kcanvas/device/qt/KCanvasClipperQt.h: (WebCore::KCanvasClipperQt::KCanvasClipperQt):
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz): (WebCore::KCanvasImageQuartz::KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::init): (WebCore::KCanvasImageQuartz::size):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip): (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::cgLayer): (WebCore::KCanvasImageQuartz::setCGLayer):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/GraphicsContext.h: Added.
  • platform/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
17:46 Changeset [17461] by oliver

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h: Removed.
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added.
  • platform/graphics/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
17:44 Changeset [17460] by oliver

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Add new platform/graphics include directory.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
17:35 Changeset [17459] by thatcher

Reviewed by Brady.

Make the universal build return non-zero when module make fails.

  • Makefile:
17:33 Changeset [17458] by thatcher

Reviewed by Stephanie.

Add a special case for the Internal makefiles, so it can find the OepnSource.

  • Scripts/webkitdirs.pm:
17:25 Changeset [17457] by sullivan

WebCore:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • bridge/EditorClient.h: declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()


  • bridge/mac/WebCoreFrameBridge.h: removed bridge equivalents
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): convert bridge-using code to editor()->client()-using code (WebCore::FrameMac::markMisspellingsInAdjacentWords): ditto (WebCore::FrameMac::markMisspellings): ditto (WebCore::FrameMac::respondToChangedSelection): ditto


  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::client): new method, returns EditorClient pointer. In an ideal world all the code that needed to access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor. But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.

WebKit:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • WebCoreSupport/WebEditorClient.h: declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::isContinuousSpellCheckingEnabled): implement by calling through to WebView (WebEditorClient::isGrammarCheckingEnabled): ditto (WebEditorClient::spellCheckerDocumentTag): ditto


  • WebCoreSupport/WebFrameBridge.mm: removed bridge equivalents of these methods
17:21 Changeset [17456] by ggaren

Reviewed by Beth.


Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
but the debugger confirmed the cause).

  • WebView/WebFrame.mm: (core): Added check for NULL bridge.
17:01 Changeset [17455] by ggaren

WebCore:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into Editor and
SelectionController, respecitvely.

I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
everything + the kitchen sink.


Specific comments below for interesting things.


  • bindings/objc/DOMInternal.h: Moved exception handling helper methods into a new file so that WebKit can use them, too. Added a helper method for handling exceptions when selecting a Range.
  • bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into WebKit, since they have to do with creating an NSAttributedString for API consumption, and not much to do with general Frame functionality.
  • editing/Editor.h: Moved lastEditCommand tracking (at least the data, for now) into the Editor. Eventually, the Frame will not have to notify the Editor of what the lastEditCommand was, since the Editor will perform all EditCommands.
  • editing/SelectionController.h: The code here is just stuff moved from the bridge.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions and return them. The bridge method to select a DOM range did this implicitly, since all ObjC DOM operations handle DOM exceptions by throwing them as ObjC exceptions.
  • editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity. The two enumerations are numerically identical, but that's an implementation detail of TextAffinity that clients shouldn't be required to know about.

WebKit:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into WebCore::Editor and
WebCore::SelectionController, respecitvely.


All of the seemingly new code here is just code grabbed from WebCore or
merged from WebCoreFrameBridge.


I changed one piece of internal API: we now pass around Ranges in places
where we used to pass around broken out components of Ranges.


I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
Since we now include WebCore headers that depend on these #defines, we need
to keep in sync with them, to avoid binary incompatibility.

16:56 Changeset [17454] by thatcher

Versioning

16:55 Changeset [17453] by thatcher

Merging fix.

16:55 Changeset [17452] by thatcher

Merging fix.

16:52 Changeset [17451] by thatcher

new tag.

16:49 Changeset [17450] by thatcher

Rolling out the following change because this crash:
<rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)

And this regression:
<rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/

2006-09-06 David Harrison <harrison@apple.com>

Reviewed and tweaked by Tim H.

<rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation

If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
16:48 Changeset [22445] by sfalken

2006-10-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam, Ada.

Expose printing methods in IWebViewPrivate and removed LPARAM-based dispatching.
Call StretchDIBits instead of BitBlt.
Add a maximum DPI (currently set at 300) to speed up printing.
Add support needed for print preview.

  • Interfaces/IWebViewPrivate.idl: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
  • WebView.cpp: Added MAXIMUM_DPI setting to limit the size of print jobs for performance reasons (getPrintRects): Added. Factored out of print, added maximum DPI handling. (WebView::startPrintJob): Factored out of print (WebView::endPrintJob): Factored out of print (WebView::getPrintedPageCount): Factored out of print (WebView::printPage): Factored out of print. Replaced call to BitBlt with StretchDIBits (WebViewWndProc): Re-add support for printing a window (used by bug reporter code)
  • WebView.h: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
15:25 Changeset [17449] by justing

Reviewed by harrison

<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Only create VisiblePositions when we're going to use them to create a range for an emitted character. We should further speed TextIterators up by avoiding creating VisiblePositions for TIs that are only used for the characters they emit (like the one that plainText uses).
14:41 Changeset [17448] by weinig

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
More rendering code cleaning

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::RenderApplet): (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderApplet.h:
  • rendering/RenderArena.cpp: (WebCore::): (WebCore::RenderArena::RenderArena): (WebCore::RenderArena::allocate): (WebCore::RenderArena::free):
  • rendering/RenderArena.h:
  • rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): (WebCore::RenderBR::baselinePosition): (WebCore::RenderBR::lineHeight): (WebCore::RenderBR::setStyle): (WebCore::RenderBR::caretMinOffset): (WebCore::RenderBR::positionForCoordinates): (WebCore::RenderBR::inlineBox):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::setHasMarkupTruncation): (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo): (WebCore::RenderBlock::BlockSelectionInfo::block): (WebCore::RenderBlock::BlockSelectionInfo::state): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::CompactInfo::clear):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::removeChild): (WebCore::RenderButton::paintObject):
  • rendering/RenderButton.h: (WebCore::RenderButton::renderName): (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::calcMinMaxWidth):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): (WebCore::toRoman): (WebCore::toHebrew): (WebCore::RenderCounter::calcMinMaxWidth):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcMinMaxWidth):
  • rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtPoint):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::renderName):
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::layout): (WebCore::RenderFormElement::textAlignment):
  • rendering/RenderFormElement.h:
  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h: (WebCore::RenderFrame::element):
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::element):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setStyle): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText):
  • rendering/RenderImage.h: (WebCore::RenderImage::element):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::~RenderInline): (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::paint): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::calcMinMaxWidth): (WebCore::RenderInline::requiresLayer): (WebCore::RenderInline::width): (WebCore::RenderInline::height): (WebCore::RenderInline::renderName): (WebCore::RenderInline::nodeAtPoint): (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::root): (WebCore::RenderLayer::setPos): (WebCore::RenderLayer::height): (WebCore::RenderLayer::relativePositionOffset):
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderLineEdit::selectionStart): (WebCore::RenderLineEdit::selectionEnd): (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange):
  • rendering/RenderLineEdit.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::renderName):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle): (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderListMarker.h: (WebCore::RenderListMarker::renderName): (WebCore::RenderListMarker::isListMarker):
14:35 Changeset [17447] by slewis

Reviewed by Darin.

Change Makefiles to return non-zero when module make fails.

  • Makefile:

WebKitTools:

Change Makefiles to return non-zero when module make fails.
Fix bug where if xcode options are not set, modules can build in the
wrong directory.

  • Makefile:
  • Scripts/webkitdirs.pm:
14:29 Changeset [22444] by andersca

WebCoreWin:

2006-10-30 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

If there's no plug-in for a given mime type, or if the plug-in fails
to initialize, draw the "missing plug-in" icon.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): If no plug-in can be found, create a null plugin view.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): If the plugin hasn't been started, paint the missing plugin image.


(WebCore::PluginViewWin::setNPWindowSize):
Return early if the plugin hasn't been started.


(WebCore::PluginViewWin::start):
Return if the plugin couldn't be created.


(WebCore::PluginViewWin::createNullPluginView):
New function which just creates a plugin view and doesn't try to start its plugin
(because there is none).


(WebCore::PluginViewWin::PluginViewWin):
New constructor for the null plugin view.


WebKitWin:

2006-10-30 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Add "null plugin" image resource.


14:25 Changeset [17446] by thatcher

Build fix.

14:19 Changeset [17445] by thatcher

Reviewed by Hyatt.

<rdar://problem/4478625> Basic table editing and culling

Refined the criteria for deletable elements, rely on the renderer more.
Corrected the interface positioning for elements that have borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::DeleteButtonController::show):
13:34 Changeset [17444] by kmccullo

Reviewed by Adam.

  • Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
12:48 Changeset [17443] by darin
  • fix build
  • loader/ResourceLoader.h: Added header guard.
12:08 Changeset [22443] by darin

Reviewed by Adam.

  • WebCore.vcproj/WebCore.vcproj: Added new source files from the loader directory.
12:05 Changeset [17442] by darin

Reviewed by Adam.

  • fix FrameLoader files so they can be built on non-Mac platforms
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader. (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
  • page/Page.h:
  • page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong the other day.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Removed code to create the frame loader. (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
  • loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC) around the PolicyCheck definition.
  • loader/FormState.cpp: Changed import to include.
  • loader/FrameLoader.cpp: Ditto.
  • loader/MainResourceLoader.h: Ditto.
  • loader/FrameLoaderTypes.h: Added a header guard.
  • loader/NetscapePlugInStreamLoader.h: Changed import to include. Added #if PLATFORM(MAC) around Mac-specific details.
  • loader/SubresourceLoader.h: Ditto.
  • page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to m_loader from m_frameLoader.
  • CMakeLists.txt: Updated.
  • WebCoreSources.bkl: Updated.
11:53 Changeset [17441] by andersca

2006-10-30 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by Anders.

Patch by Zack rusin to fix:
http://bugs.webkit.org/show_bug.cgi?id=11429

Fix startup crash.

  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
11:38 Changeset [17440] by andersca

2006-10-30 Zach Rusin <zack@kde.org>

Reviewed and landed by Anders.

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): More build fixes.

2006-10-30 Simon Hausmann <hausmann@kde.org>

Reviewed and landed by Anders.


  • fix Qt build
  • platform/qt/FrameQtClient.cpp: ResourceLoaderClient -> ResourceHandleClient
11:32 Changeset [17439] by darin

Requested by Maciej.

  • fast/dom/xmlhttprequest-get-expected.txt: Generated a new result. Maciej says that the new behavior of returning empty string instead of undefined is correct and matches Firefox, so the new result is better than the old.
09:20 Changeset [17438] by darin

WebCore:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function from Frame to WebFrame in WebKit
  • page/PageState.h:
  • page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
  • bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a double for the date instead of an NSDate.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and saveDocumentToPageCache methods.
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into an Objective-C wrapper for PageState.
  • loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of NSDate and WebCorePageState.
  • loader/FrameLoaderClient.h: Changed NSDate to double.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache here that used to be in invalidateCurrentItemPageCache on the WebKit side. (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date. (WebCore::FrameLoader::open): Moved one of the open functions that was part of commitProvisionalLoad inside the commitProvisionalLoad function, so that it can extract the parameters from the response. Changed the open function that takes a PageState to use the new C++ PageState. (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open function; tightened up logic, removing a few cases that could never happen, as well as the unused reload boolean.
  • ForwardingHeaders/kjs/property_map.h: Added.
  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.

WebKit:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function here from Frame
  • History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]): Updated for change in WebCorePageState.
  • WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
  • WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was formerly in invalidatePageCache: on the bridge here. (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the NSDate here. (WebFrameLoaderClient::createPageCache): Restructured code to create the WebCorePageState object directly instead of calling saveDocumentToPageCache on the bridge.
  • WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work directly with the DOM and renderers rather than using a function on Frame.
09:18 Changeset [17437] by darin

Reviewed by John Sullivan.

  • kjs/SavedBuiltins.h: Added needed include.
  • wtf/OwnPtr.h: (WTF::OwnPtr::set): Fixed mistake in assertion.
08:27 Changeset [17436] by thatcher

Reviewed by Tim H.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10468
[Drosera] The Console toolbar button should bring the console window to the front.

The console now gets focus when its activated but already open. Command + L also
now activates/focuses the console.

  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.js:
03:12 Changeset [22442] by mjs

WebCoreWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): Changed prototype to match new version.

WebKitWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebFrame.cpp: (WebFrame::didReceiveResponse): Updated from receivedResponse.
  • WebFrame.h:
  • WebURLResponse.cpp: (WebURLResponse::WebURLResponse): Reimplemented to work in terms of WebCore::ResourceResponse (ditto for below). Uses BString to convert strings as needed. (WebURLResponse::~WebURLResponse): (WebURLResponse::createInstance): (WebURLResponse::expectedContentLength): (WebURLResponse::initWithURL): (WebURLResponse::MIMEType): (WebURLResponse::suggestedFilename): (WebURLResponse::textEncodingName): (WebURLResponse::URL): (WebURLResponse::suggestedFileExtension):
  • WebURLResponse.h:
03:08 Changeset [17435] by mjs

WebCore:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call


  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bridge/mac/WebCoreFrameBridge.h: Removed no longer needed expiresTimeForResponse: method.
  • dom/XMLTokenizer.cpp: (WebCore::openFunc): Updated to use ResourceResponse.
  • loader/FrameLoader.h: Update loadResourceSynchronously to use ResourceResponse.
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::didReceiveResponse): Updated from receivedResponse and made cross-platform.
  • loader/icon/IconLoader.h: updated for above change
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): reduced to just saving the PlatformResponse (ideally we'd phase out use of this). (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse logic.
  • loader/loader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously): Return results as ResourceResponse.
  • loader/mac/IconLoaderMac.mm: remove receivedResponse.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): take ResourceResponse as argument.
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h: Remove calls for broken out response pieces.
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveResponse): New delegate method.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove storage of response bits, we're not gonna return them seprately any more.
  • platform/network/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): Freshly implemented. Same for below. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::isMultipart): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Send didReceiveResponse client method.
  • platform/network/cf/ResourceResponseCFNet.h: Added.
  • platform/network/cf/ResourceResponseCFNet.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from CFURLResponseRef.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Don't bother cleaning up fields we no longer have. (WebCore::ResourceHandle::receivedResponse): Send didReceiveResponse client method.
  • platform/network/mac/ResourceResponseMac.h: Added.
  • platform/network/mac/ResourceResponseMac.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from an NSURLResponse*.
  • rendering/HitTestResult.cpp:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseText): Store http response info in the form of a ResourceResponse, change all methods to account for this. (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:

WebKit:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCoreSupport/WebFrameBridge.mm: Removed no longer needed expiresTimeForResponse: method.

10/29/06:

17:31 Changeset [17434] by darin
  • fix build
  • loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
  • loader/NetscapePlugInStreamLoader.h: Ditto.
  • loader/ResourceLoader.h: Ditto.
17:16 Changeset [17433] by darin

WebCore:

  • one last name change -- WebFormState.h to FormState.h
  • added more empty placeholder platform-independent files for currently-Mac-specific loader classes
  • loader/FormState.cpp: Updated include.
  • loader/FrameLoader.cpp: Updated include.
  • loader/mac/FrameLoaderMac.mm: Updated include.
  • loader/WebFormState.h: Removed.
  • loader/FormState.h: Added.
  • loader/DocumentLoader.cpp: Added.
  • loader/MainResourceLoader.cpp: Added.
  • loader/NetscapePlugInStreamLoader.cpp: Added.
  • loader/ResourceLoader.cpp: Added.
  • loader/SubresourceLoader.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for changes above.

WebKit:

  • update for the WebCore rename
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebFrame.mm:
17:01 Changeset [17432] by darin
  • Scripts/do-file-rename: Renames done, ready for the next round.
  • Scripts/do-webcore-rename: Ditto.
17:00 Changeset [22441] by darin
  • update for the WebCore renames
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::bindingInstance):
16:57 Changeset [17431] by darin

WebCore:

  • did the do-webcore-rename renames, including a number of changes to the names of loader files (and WebResourceLoader -> ResourceLoader), jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(), and improvements to the names of decoder classes and their source files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)

WebKit:

  • update for the WebCore renames
16:43 Changeset [17430] by darin

Rubber stamped by Adam (kinda).

  • add Mac suffixes and correct filenames inside loader/mac
  • WebCore.xcodeproj/project.pbxproj: Updated for changes below.
  • loader/mac/FrameLoader.mm: Removed.
  • loader/mac/WebDocumentLoader.mm: Removed.
  • loader/mac/WebLoader.mm: Removed.
  • loader/mac/WebMainResourceLoader.mm: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
  • loader/mac/WebSubresourceLoader.mm: Removed.
  • loader/mac/FrameLoaderMac.mm: Added.
  • loader/mac/DocumentLoaderMac.mm: Added.
  • loader/mac/ResourceLoaderMac.mm: Added.
  • loader/mac/MainResourceLoaderMac.mm: Added.
  • loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
  • loader/mac/SubresourceLoaderMac.mm: Removed.
16:37 Changeset [17429] by darin

Reviewed by Adam.

  • moving towards use of FrameLoader cross-platform; get FrameLoader.h and FrameLoader.cpp mostly ready
  • WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and FormState.cpp. Removed WebFormState.mm.
  • loader/FrameLoader.h: Put in lots of #if statements to see if we can get this header compiling on non-Mac.
  • loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
  • loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
  • loader/FrameLoaderClient.h: Added some ifdefs.
  • loader/WebDocumentLoader.h: Ditto.
  • loader/WebLoader.h: Ditto.
  • loader/WebMainResourceLoader.h: Ditto.
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::isLoadingInAPISense): Rewrote to work without bridge, partly to remove the need for ObjC bridge type in the header, and also because we're tearing down the bridge.
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): Removed unused m_contentLength and m_bytesReceived. (WebCore::MainResourceLoader::didReceiveResponse): Ditto. (WebCore::MainResourceLoader::didReceiveData): Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • loader/mac/FormState.mm: Removed.
  • loader/FormState.cpp: Added.
15:38 Changeset [17428] by darin

Rubber stamped by Adam.

  • moving towards use of FrameLoader cross-platform; move the headers for the Mac loader from loader/mac into loader, in preparation for making them useful on non-Mac
  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoader.h: Removed.
  • loader/mac/WebDocumentLoader.h: Removed.
  • loader/mac/WebFormState.h: Removed.
  • loader/mac/WebLoader.h: Removed.
  • loader/mac/WebMainResourceLoader.h: Removed.
  • loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
  • loader/mac/WebSubresourceLoader.h: Removed.
  • loader/FrameLoader.h: Added.
  • loader/WebDocumentLoader.h: Added.
  • loader/WebFormState.h: Added.
  • loader/WebLoader.h: Added.
  • loader/WebMainResourceLoader.h: Added.
  • loader/WebNetscapePlugInStreamLoader.h: Added.
  • loader/WebSubresourceLoader.h: Added.
15:01 Changeset [17427] by aroben

Reviewed by Geoff.

Finish Darin's clean up of the use of APPLE in WebCore, begun in
r17405.

  • platform/DeprecatedString.h:
14:07 Changeset [17426] by bdakin

Rubber stamped by Geoff.

This is a followup to my HitTestResult checkin. Most of the
HitTestResult local variables in the code were named i or info for
when the class was named NodeInfo. This patch renames all of these
local variables to result.

12:48 Changeset [17425] by aroben

More semi-fixes.

  • page/Page.cpp: Forgot to wrap the actual definition of setDefersLoading() in PLATFORM(MAC).
  • platform/PlatformWheelEvent.h: Fix up preprocessor directives.
12:32 Changeset [17424] by aroben

Build semi-fix.

Move all FrameLoader-related code in Page.{cpp,h} within #if
PLATFORM(MAC), since this class currently only exists on Mac.

  • page/Page.cpp:
  • page/Page.h:
11:15 Changeset [17423] by darin
  • Scripts/do-file-rename: And again.
11:06 Changeset [17422] by ggaren

build fix.


  • platform/PlatformString.h: (WebCore::String::operator NSString*):
11:03 Changeset [17421] by ggaren

Rolled out accidental commit.


  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator NSString*):
10:58 Changeset [17420] by ggaren

Reviewed by Geoff.

Test for http://bugs.webkit.org/show_bug.cgi?id=11444
REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]: attempt to insert nil value)
when submitting a form with an empty uninitialized field

  • fast/forms/submit-nil-value-field-assert-expected.txt: Added.
  • fast/forms/submit-nil-value-field-assert.html: Added.
10:54 Changeset [17419] by ggaren

RS by Darin.

Rolled out change to map NULL Strings to nil NSStrings because it caused
even more AppKit crashes. Maybe we should remove the NSString * operator
entirely, since its use is not straight-forward, and require callers to
specify explicitly whether they tolerate NULL.


  • platform/AtomicString.h:
  • platform/PlatformString.h: (WebCore::String::operator NSString*):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
10:28 Changeset [17418] by darin
  • Scripts/do-webcore-rename: Tweaked plans for renaming again.
10:03 Changeset [17417] by darin

Added a bug number to change log.

09:44 Changeset [17416] by darin

Reviewed by Geoff.

  • fixed storage leak showing up on the buildbot
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create): Release the NSURLRequest after passing it to load. Also clean up logic a bit.
09:12 Changeset [17415] by darin

WebCore:

Rubber stamped by Adam Roben.

  • renamed WebFrameLoaderClient to match the class name inside it
  • loader/mac/WebFrameLoaderClient.h: Removed.
  • loader/FrameLoaderClient.h: Moved it here.
  • WebCore.xcodeproj/project.pbxproj: Updated project.
  • bridge/mac/FrameMac.mm: Updated includes.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • loader/mac/FrameLoader.mm: Ditto.
  • loader/mac/WebLoader.h: Ditto.

WebKit:

Rubber stamped by Adam Roben.

  • renamed WebCore's WebFrameLoaderClient to match the class name inside it
  • WebCoreSupport/WebFrameBridge.mm: Update include.
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto.
08:50 Changeset [17414] by darin

Reviewed by Mitz.

  • fix crash visible on buildbot and also when running the test anchor-image-scrolled-x-y.html under libgmalloc
  • loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle now that the class is named ResourceHandle.
  • loader/mac/WebSubresourceLoader.mm: Renaming, plus: (WebCore::SubresourceLoader::didFinishLoading): Get the handle into a local RefPtr before calling finishJobAndHandle, since we might get cancelled inside that function, so we should not rely on m_handle to keep the ResourceHandle alive. (WebCore::SubresourceLoader::didFail): Ditto. (WebCore::SubresourceLoader::didCancel): Ditto.
04:21 Changeset [17413] by bdash

2006-10-30 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

Fix fast/block/basic/014.html to pass when Microsoft Office fonts are present.

  • fast/block/basic/014-expected.checksum:
  • fast/block/basic/014-expected.png:
  • fast/block/basic/014-expected.txt:
  • fast/block/basic/014.html: Always use default sans-serif font rather than preferring Microsoft Office fonts.
03:15 Changeset [17412] by bdash

2006-10-29 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Fix failure in editing/inserting/insert-3851164-fix if Gill Sans font is present.

  • editing/inserting/insert-3851164-fix.html: Specify sans-serif to match expected results generated without Gill Sans present.
02:00 Changeset [17411] by mjs

Not reviewed.

  • build fix
  • platform/network/mac/ResourceHandleMac.mm:
01:50 Changeset [22440] by mjs

WebCoreWin:

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::startHTTPRequest): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/network/win/ResourceHandleWin.h: Added.
  • platform/network/win/ResourceLoaderWin.cpp: Removed.
  • platform/network/win/ResourceLoaderWin.h: Removed.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (IconLoader::receivedResponse):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h:

WebKitWin:

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading):
  • WebFrame.h:
  • WebURLResponse.cpp: (WebURLResponse::createInstance):
  • WebURLResponse.h:
  • WebView.cpp:
01:44 Changeset [17410] by mjs

Rubber stamped by Darin.

  • renamed ResourceLoader to ResourceHandle (and same for related classes)
  • CMakeLists.txt:
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bridge/mac/FrameMac.mm:
  • bridge/win/FrameWin.cpp:
  • dom/XMLTokenizer.cpp:
  • loader/Cache.cpp:
  • loader/CachedResource.h:
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): (IconLoader::didReceiveData): (IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • loader/mac/IconLoaderMac.mm: (IconLoader::receivedResponse):
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/WebLoader.h:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveCharset):
  • platform/network/ResourceHandle.cpp: Added. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create): (WebCore::ResourceHandle::isErrorPage): (WebCore::ResourceHandle::error): (WebCore::ResourceHandle::setError): (WebCore::ResourceHandle::responseEncoding): (WebCore::ResourceHandle::responseHTTPHeadersAsString): (WebCore::ResourceHandle::kill): (WebCore::ResourceHandle::requestHeaders): (WebCore::ResourceHandle::url): (WebCore::ResourceHandle::postData): (WebCore::ResourceHandle::method): (WebCore::ResourceHandle::client):
  • platform/network/ResourceHandle.h: Added. (WebCore::ResourceHandle::getInternal):
  • platform/network/ResourceHandleClient.h: Added. (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFinishLoading): (WebCore::ResourceHandleClient::receivedRedirect): (WebCore::ResourceHandleClient::receivedResponse): (WebCore::ResourceHandleClient::receivedAllData):
  • platform/network/ResourceHandleInternal.h: Added. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/ResourceLoader.cpp: Removed.
  • platform/network/ResourceLoader.h: Removed.
  • platform/network/ResourceLoaderClient.h: Removed.
  • platform/network/ResourceLoaderInternal.h: Removed.
  • platform/network/cf/ResourceHandleCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::didReceiveChallenge): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
  • platform/network/gdk/ResourceHandleCurl.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/network/gdk/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::get): (WebCore::ResourceHandleManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h: Added.
  • platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
  • platform/network/gdk/ResourceLoaderManager.cpp: Removed.
  • platform/network/gdk/ResourceLoaderManager.h: Removed.
  • platform/network/mac/ResourceHandleMac.mm: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::redirectedToURL): (WebCore::ResourceHandle::addData): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
  • platform/network/mac/ResourceLoaderMac.mm: Removed.
  • platform/network/qt/ResourceHandleManager.cpp: Added. (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::slotData): (WebCore::ResourceHandleManager::slotMimetype): (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/qt/ResourceHandleManager.h: Added.
  • platform/network/qt/ResourceHandleQt.cpp: Added. (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::extractCharsetFromHeaders):
  • platform/network/qt/ResourceLoaderManager.cpp: Removed.
  • platform/network/qt/ResourceLoaderManager.h: Removed.
  • platform/network/qt/ResourceLoaderQt.cpp: Removed.
  • platform/network/win/ResourceHandleWin.cpp: Added. (WebCore::): (WebCore::addToOutstandingJobs): (WebCore::lookupResourceHandle): (WebCore::ResourceHandleWndProc): (WebCore::initializeOffScreenResourceHandleWindow): (WebCore::ResourceHandleInternal::~ResourceHandleInternal): (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setHasReceivedResponse): (WebCore::ResourceHandle::hasReceivedResponse):
  • platform/network/win/ResourceHandleWin.h: Added.
  • platform/network/win/ResourceLoaderWin.cpp: Removed.
  • platform/network/win/ResourceLoaderWin.h: Removed.
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceHandle::assembleResponseHeaders): (WebCore::ResourceHandle::retrieveResponseEncoding): (WebCore::ServeSynchronousRequest):
  • xml/XSLTProcessor.cpp:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
01:36 Changeset [17409] by darin

LayoutTests:

  • fast/events/js-keyboard-event-creation-expected.txt: Update test that is affected in a minor way by the change to DumpRenderTree.

WebKitTools:

Reviewed by Mitz.

  • DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreeWindow keyDown:]): Added. Does nothing, which prevents a beep.
  • Scripts/do-webcore-rename: Tweaked plans for renaming a bit.
01:47 Changeset [17408] by darin

WebCore:

Reviewed by Maciej.

  • eliminate use of NSArray to carry form data around
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FormDataMac.h: Removed.
  • bridge/mac/FormDataMac.mm: Removed.
  • bridge/mac/FrameMac.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • loader/FormData.h: (WebCore::FormData::isEmpty):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • loader/mac/WebFormDataStream.h:
  • loader/mac/WebFormDataStream.m: (WebCore::pairRetain): (WebCore::pairRelease): (WebCore::pairEqual): (WebCore::pairHash): (WebCore::closeCurrentStream): (WebCore::scheduleWithPair): (WebCore::advanceCurrentStream): (WebCore::openNextStream): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::formOpen): (WebCore::formRead): (WebCore::formCanRead): (WebCore::formClose): (WebCore::formSchedule): (WebCore::formUnschedule): (WebCore::formEventCallback): (WebCore::setHTTPBody):
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
  • platform/network/mac/ResourceLoaderMac.mm:

WebKit:

Reviewed by Maciej.

  • eliminate use of NSArray to carry form data around (the code in this framework was actually using the NSArray to hold a single

NSData anyway, so I just went back to an NSData for now)

  • History/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): (-[WebHistoryItem formData]):
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm):
  • WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]):
01:36 Changeset [17407] by mjs

Reviewed by Darin.

  • create SubresourceLoader with a ResourceRequest, not broken out request bits
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
00:30 Changeset [17406] by mjs

Reviewed by Darin.

  • removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly

Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm:
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/WebLoader.h:
  • loader/mac/WebSubresourceLoader.h:
  • loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceLoader.h:
  • platform/network/ResourceLoaderInternal.h:
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::redirectedToURL): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::finishJobAndHandle): (WebCore::ResourceLoader::reportError):
  • platform/network/mac/WebCoreResourceLoader.h: Removed.
  • platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
  • platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.

10/28/06:

23:48 Changeset [17405] by darin

JavaScriptCore:

Reviewed by Maciej.

  • renamed PassRefPtr::release to releaseRef to make it clearer that it's the counterpart of adoptRef, and to make it harder to confuse it with the safer-to-use RefPtr::release
  • kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::UCharBufferTranslator::translate):
  • kjs/ustring.cpp: (KJS::UString::Rep::create):
  • wtf/PassRefPtr.h: (WTF::PassRefPtr::PassRefPtr): (WTF::PassRefPtr::~PassRefPtr): (WTF::PassRefPtr::get): (WTF::PassRefPtr::releaseRef): (WTF::PassRefPtr::operator->): (WTF::PassRefPtr::operator=): (WTF::adoptRef): (WTF::static_pointer_cast): (WTF::const_pointer_cast):
  • wtf/RefPtr.h: (WTF::RefPtr::RefPtr): (WTF::RefPtr::operator=):

WebCore:

Reviewed by Maciej.

  • eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDecider, WebCoreFrameLoaderAsDelegate, and WebCoreMainResourceLoaderAsPolicyDelegate
  • grouped the state related to policy decisions into a PolicyCheck class to simplify the FrameLoader logic
  • removed six methods from the bridge, reducing FrameLoader's use of the bridge to a single method
  • changed form state to always use HashMap instead of NSDictionary
  • moved the defersLoading flag from WebView to WebCore::Page and changed code to consistently call it defersLoading rather than defersCallbacks
  • updated for rename of PassRefPtr::release to releaseRef
  • replaced all uses of APPLE with appropriate PLATFORM defines
  • cleaned up kjs_binding.h a bit
  • cleaned up FrameMac.h a bit
  • loader/mac/WebPolicyDecider.h: Removed.
  • loader/mac/WebPolicyDecider.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for removal.
  • WebCore.exp:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::wasRunByUserGesture):
  • bindings/js/kjs_binding.h: (KJS::ScriptInterpreter::setCurrentEvent): (KJS::ScriptInterpreter::setInlineCode): (KJS::ScriptInterpreter::setProcessingTimerCallback): (KJS::ScriptInterpreter::getCurrentEvent): (KJS::cacheDOMObject): (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
  • bridge/AXObjectCache.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent): (WebCore::FrameMac::passMouseDownEventToWidget): (WebCore::FrameMac::handleMouseMoveEvent):
  • bridge/mac/PageMac.mm: (WebCore::Page::Page):
  • bridge/mac/WebCoreEditCommand.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::cssText):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::):
  • css/CSSValueList.cpp: (WebCore::CSSValueList::append):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateSelection): (WebCore::Document::implicitClose): (WebCore::Document::setFocusNode):
  • dom/Document.h:
  • editing/ReplaceSelectionCommand.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • loader/mac/FrameLoader.h: (WebCore::PolicyCheck::request):
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): (WebCore::FrameLoader::stopLoading): (WebCore::setAllDefersLoading): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::dropRequest): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/mac/WebFormState.h:
  • loader/mac/WebFormState.mm:
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebLoader.h: (WebCore::WebResourceLoader::defersLoading):
  • loader/mac/WebLoader.mm: (WebCore::WebResourceLoader::WebResourceLoader): (WebCore::WebResourceLoader::load): (WebCore::WebResourceLoader::setDefersLoading):
  • loader/mac/WebMainResourceLoader.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::releaseDelegate): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::callContinueAfterContentPolicy): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::didReceiveResponse): (WebCore::MainResourceLoader::didReceiveData): (WebCore::MainResourceLoader::didFinishLoading): (WebCore::MainResourceLoader::didFail): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): (WebCore::MainResourceLoader::setDefersLoading):
  • page/Frame.cpp: (WebCore::Frame::paint):
  • page/FrameView.cpp: (WebCore::FrameView::layout):
  • page/FrameView.h:
  • page/Page.cpp: (WebCore::Page::setDefersLoading):
  • page/Page.h: (WebCore::Page::defersLoading):
  • platform/DeprecatedString.h:
  • platform/DeprecatedStringList.h:
  • platform/FontFallbackList.h:
  • platform/PlatformKeyboardEvent.h:
  • platform/PlatformMouseEvent.h:
  • platform/PlatformWheelEvent.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::dragNSImage): (WebCore::ClipboardMac::sourceOperation): (WebCore::ClipboardMac::destinationOperation):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/break_lines.cpp: (WebCore::nextBreakablePosition):

WebKit:

Reviewed by Maciej.

  • eliminated the use of Objective-C for the policy decider machinery, obviating the need for WebPolicyDeciderMac
  • moved the defersLoading flag from WebView to WebCore::Page
  • removed unused copies of four methods that in the frame bridge; the actually-used copies are in the page bridge
  • updated for rename of PassRefPtr::release to releaseRef
  • WebView/WebPolicyDeciderMac.h: Removed.
  • WebView/WebPolicyDeciderMac.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Updated for removal.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:]):
  • Plugins/WebNetscapePluginStream.mm:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::setUpPolicyListener): (WebFrameLoaderClient::receivedPolicyDecison): (WebFrameLoaderClient::userAgent): (-[WebFramePolicyListener initWithWebCoreFrame:]): (-[WebFramePolicyListener invalidate]): (-[WebFramePolicyListener dealloc]): (-[WebFramePolicyListener finalize]): (-[WebFramePolicyListener receivedPolicyDecision:]): (-[WebFramePolicyListener ignore]): (-[WebFramePolicyListener download]): (-[WebFramePolicyListener use]): (-[WebFramePolicyListener continue]):
  • WebCoreSupport/WebPageBridge.mm: (-[WebPageBridge runModal]):
  • WebView/WebArchiver.m: (+[WebArchiver archiveSelectionInFrame:]):
  • WebView/WebFormDelegate.h:
  • WebView/WebFormDelegate.m: (+[WebFormDelegate _sharedWebFormDelegate]): (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]): (-[WebFormDelegate textFieldDidEndEditing:inFrame:]): (-[WebFormDelegate textDidChangeInTextField:inFrame:]): (-[WebFormDelegate textDidChangeInTextArea:inFrame:]): (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _isFrameSet]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView _shouldDrawBorder]):
  • WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]):
  • WebView/WebView.mm: (-[WebView _formDelegate]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
16:44 Changeset [17404] by aroben

Adding forgotten Bugzilla reference.

16:41 Changeset [17403] by aroben

Fixing ChangeLog entries: r17933 => r17399.

16:39 Changeset [17402] by aroben

WebCore:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
point instead of being passed one explicitly.

  • WebCore.exp: Change constructor symbol.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and hitTest(). (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
  • dom/Document.cpp: (WebCore::Document::elementFromPoint): Ditto. (WebCore::Document::prepareMouseEvent): Ditto.
  • page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Ditto. (WebCore::Frame::hitTestResultAtPoint): Ditto.
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Ditto.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Initalize m_point with the passed point.
  • rendering/HitTestResult.h: Update constructor declaration.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Update to new constructor and hitTest(). (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the HitTestResult instead of being passed one. (WebCore::RenderLayer::hitTestLayer): Ditto.
  • rendering/RenderLayer.h: Update declarations.

WebKit:

Reviewed by Maciej.

Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point.

  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to HitTestResult constructor.
14:43 Changeset [22439] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Adding new HitTestResult.{cpp,h} files.
14:33 Changeset [17401] by weinig

Reviewed by Anders.

Fix Qt/Linux build.

  • CMakeLists.txt:
  • platform/qt/FrameQtClient.cpp: (WebCore::numRequests): (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::updateFromElement):
11:56 Changeset [17400] by weinig

Tweaked by Sam. Reviewed by Brady.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
Initialize m_modifyBiasSet to false, as it sometimes gets
used before it has been initalized.

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
11:28 Changeset [17399] by bdakin

WebCore:

Reviewed by Darin.

This is the WebCore half of pushing elementAtPoint and the backend
of WebElementDictionary into WebCore. Most of the changes below are
to accommodate one of the following:


-NodeInfo is now a stand-alone class called HitTestResult.

Previously it was defined in RenderObject.h, but not for
any particular reason. The WebElementDictionary
functionality that was pushed into WebCore has been pushed
specifically into the this class. In fact,
WebElementDictionary now keeps a HitTestResult as a member
varibale.


-The enumeration AccessPolicy is now called

ClipboardAccessPolicy and is defined in its own header. It
was previously defined in ClipboardMac.h, but is now
defined independently to avoid including ClipboardMac.h
from within FrameMac.h since FrameMac.h is now included in
WebElementDictionary.m in WebKit.


-Element now has a virtual target() for the sake of

NodeInfo::targetFrame()

  • WebCore.exp: Several WebCore functions are newly called from WebKit, so they have been added here.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: Must include Image.h because of adjustments to ClipboardMac.
  • bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy and HitTestResult changes. (WebCore::FrameMac::eventMayStartDrag): Same. (WebCore::FrameMac::handleMouseMoveEvent): Same. (WebCore::FrameMac::dispatchCPPEvent): Same. (WebCore::FrameMac::mayDHTMLCut): Same. (WebCore::FrameMac::mayDHTMLCopy): Same. (WebCore::FrameMac::mayDHTMLPaste): Same. (WebCore::FrameMac::tryDHTMLCut): Same (WebCore::FrameMac::tryDHTMLCopy): Same. (WebCore::FrameMac::tryDHTMLPaste): Same.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to HitTestResult changes. (-[WebCoreAXObject accessibilityHitTest:]): Same.
  • bridge/mac/WebCoreFrameBridge.h: Same.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for ClipboardAccessPolicy changes. (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same. (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
  • dom/Document.cpp: (WebCore::Document::elementFromPoint): Adjust for HitTestResult changes. (WebCore::Document::prepareMouseEvent): Same.
  • dom/Element.h: (WebCore::Element::target): Now has a virtual target()
  • html/HTMLAnchorElement.h: Same.
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult changes.
  • html/HTMLAreaElement.h: Virtual target()
  • html/HTMLBaseElement.h: (WebCore::HTMLBaseElement::target): Same.
  • html/HTMLFormElement.h: Same.
  • html/HTMLLinkElement.h: Same.
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult changes.
  • html/HTMLMapElement.h: Same.
  • page/Frame.cpp: (WebCore::Frame::isPointInsideSelection): Same. (WebCore::Frame::hitTestResultAtPoint): Same.
  • page/Frame.h: Same.
  • page/FrameView.cpp: (WebCore::FrameView::handleWheelEvent): Same.
  • platform/mac/ClipboardAccessPolicy.h: Added. (WebCore::):
  • platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, include ClipboardAccessPolicy.h, and rename AccessPolicy to ClipboardAccessPolicy.
  • platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy. (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::setAccessPolicy): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): (WebCore::ClipboardMac::setDropEffect): (WebCore::ClipboardMac::setEffectAllowed):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult changes.
  • rendering/EllipsisBox.h:
  • rendering/HitTestResult.cpp: Added. (WebCore::HitTestResult::HitTestResult): (WebCore::HitTestResult::~HitTestResult): (WebCore::HitTestResult::operator=): (WebCore::HitTestResult::setInnerNode): (WebCore::HitTestResult::setInnerNonSharedNode): (WebCore::HitTestResult::setURLElement): (WebCore::HitTestResult::setScrollbar): (WebCore::HitTestResult::targetFrame): (WebCore::HitTestResult::boundingBox): (WebCore::HitTestResult::isSelected): (WebCore::HitTestResult::title):
  • rendering/HitTestResult.h: Added. (WebCore::HitTestResult::readonly): (WebCore::HitTestResult::active): (WebCore::HitTestResult::mouseMove): (WebCore::HitTestResult::innerNode): (WebCore::HitTestResult::innerNonSharedNode): (WebCore::HitTestResult::point): (WebCore::HitTestResult::URLElement): (WebCore::HitTestResult::scrollbar): (WebCore::HitTestResult::setPoint): (WebCore::HitTestResult::setReadonly): (WebCore::HitTestResult::setActive): (WebCore::HitTestResult::setMouseMove):
  • rendering/InlineBox.cpp: (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
  • rendering/InlineBox.h: Same.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::nodeAtPoint): Same.
  • rendering/InlineFlowBox.h: Same.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::nodeAtPoint): Same.
  • rendering/InlineTextBox.h: Same.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar): Same. (WebCore::RenderBlock::nodeAtPoint): Same.
  • rendering/RenderBlock.h: Same.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::nodeAtPoint): Same.
  • rendering/RenderBox.h: Same.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::hitTestLines): Same.
  • rendering/RenderFlow.h: Same.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::nodeAtPoint): Same.
  • rendering/RenderForeignObject.h: Same.
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::nodeAtPoint): Same.
  • rendering/RenderFrameSet.h: Same.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::nodeAtPoint): Same.
  • rendering/RenderImage.h: Same.
  • rendering/RenderInline.cpp: (WebCore::RenderInline::nodeAtPoint): Same.
  • rendering/RenderInline.h: Same.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Same. (WebCore::RenderLayer::hitTest): Same. (WebCore::RenderLayer::hitTestLayer): Same. (WebCore::RenderLayer::updateHoverActiveState): Same.
  • rendering/RenderLayer.h: Same.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInScrollbar): Same.
  • rendering/RenderListBox.h: Same.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::hitTest): Same. (WebCore::RenderObject::setInnerNode): Same. (WebCore::RenderObject::nodeAtPoint): Same.
  • rendering/RenderObject.h: Remove NodeInfo class and forward declare HitTestResult.
  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult changes.
  • rendering/RenderPath.h: Same.
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Same.
  • rendering/RenderSVGImage.h: Same
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::nodeAtPoint): Same.
  • rendering/RenderSVGText.h: Same.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::nodeAtPoint): Same.
  • rendering/RenderTableRow.h: Same.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::nodeAtPoint): Same.
  • rendering/RenderTableSection.h: Same.
  • rendering/RenderText.h: Same. (WebCore::RenderText::nodeAtPoint): Same.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint): Same.
  • rendering/RenderTextControl.h: Same.
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::nodeAtPoint): Same.
  • rendering/RootInlineBox.h: Same.

WebKit:

Reviewed by Darin.

This is the WebKit half of pushing the guts of elementAtPoint and
WebElementDictionary into WebCore. Among other things, this patch
makes WebElementDictionary.m and WebHTMLView.m Objective-C++

  • MigrateHeaders.make: Add DOMElementInternal.h to the list of headers to migrate.
  • Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and NSPoint member variables with a HitTestResult member variable.
  • Misc/WebElementDictionary.m: (addLookupKey): Formatting. (-[WebElementDictionary initWithHitTestResult:]): Constructor just takes a HitTestResult now and sets the member variable. (-[WebElementDictionary dealloc]): delete HitTestResult. (-[WebElementDictionary finalize]): Address HitTestResult. (-[WebElementDictionary _domNode]): Use HitTestResult and call into WebCore. (-[WebElementDictionary objectForKey:]): Same. (-[WebElementDictionary _webFrame]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _imageRect]): Same. (-[WebElementDictionary _isSelected]): Same.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: (core): Convert from DOMNode* to Node* (kit): Convert from Node* to DOMNode*
  • WebView/WebFrameInternal.h: Support for the above.
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly into Frame.cpp to get HitTestResult.
01:19 Changeset [17398] by mjs

WebCore:

Removed accidentally committed duplicate ChangeLog entries.

WebKit:

Removed accidentally committed duplicate ChangeLog entries.

10/27/06:

23:18 Changeset [17397] by mjs

Reviewed by Anders.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::clear):
22:08 Changeset [17396] by mjs

WebCore:

Reviewed by John & Adam.

  • assorted speedups to fix perf regression from fixing correctness regression
  • WebCore.exp: exported new methods.
  • WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/CachedResource.cpp: Removed now obsolete getCFURL.
  • loader/CachedResource.h:
  • loader/mac/CachedResourceMac.mm: Added. (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is now cached in the CachedObject.
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets the WebKit side do faster dispatch for clients that implement the fast path delegate.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods, just call loadedResourceFromMemoryCache.
  • loader/mac/WebFrameLoaderClient.h:

WebKit:

Reviewed by John & Adam.


  • various performance improvements for resource delegate dispatch.


  • avoid any ObjC messaging when fetching the WebView
  • avoid ObjC calls to WebView to get resource load delegate and impl cache
  • cache actual method pointers, not just the fact that the method is present
  • added a new SPI resource load delegate method which allows clients to get just one message in case of synchronously loading from memory cache; if this is implemented you don't get the normal delegate calls in that case.
  • various other minor tweaks
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (getWebView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::frameLoadCompleted):
  • WebCoreSupport/WebPageBridge.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: (frame): (core): (kit): (getWebView): (-[WebFrame _addBackForwardItemClippedAtTarget:]): (-[WebFrame _canCachePage]): (-[WebFrame _purgePageCache]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _updateBackground]): (-[WebFrame _clearSelectionInOtherFrames]): (-[WebFrame _isMainFrame]): (-[WebFrame webView]):
  • WebView/WebResourceLoadDelegatePrivate.h: Added.
  • WebView/WebView.mm: (-[WebView _cacheResourceLoadDelegateImplementations]): (WebViewGetResourceLoadDelegate): (WebViewGetResourceLoadDelegateImplementations):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
21:14 Changeset [17395] by oliver

2006-10-27 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

build fix

  • dom/Document.cpp: (WebCore::Document::referrer):
19:08 Changeset [17394] by beidson

top level:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:

WebKitTools:

Rubber stamped by Tim Hatcher

Added "make universal" to build universal binaries

  • Makefile:
  • Makefile.shared:
18:22 Changeset [17393] by ggaren

WebCore:

Reviewed by Maciej.

Moved some WebCoreFrameBridge functions into FrameLoader.


I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and OBJC #ifdefs.

  • WebCore.exp:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::createEmptyDocument): (WebCore::FrameMac::tokenizerProcessedData):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer):
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::numRequests): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::startLoadingResource):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckIfReloading):
  • page/Frame.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::isDescendantOf): (WebCore::FrameTree::traverseNext):
  • page/FrameTree.h:
  • platform/network/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Maciej.


Moved some WebCoreFrameBridge functions into FrameLoader.

  • WebView/WebFrame.mm: (-[WebFrame _numPendingOrLoadingRequests:]):
17:41 Changeset [17392] by thatcher

Reviewed by Darin.

<rdar://problem/4478625> HTML Editing: Basic table editing and culling

Expanded the Deletion UI to lists, positioned block element and block elementss with borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::enclosingDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection):
16:43 Changeset [17391] by sullivan

Reviewed by Kevin Decker


Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.

  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be considered also. (WebCore::InlineTextBox::paintDocumentMarkers): Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground markers should be painted, instead of a marker type. This avoids walking the collection of markers multiple times back to back. Now handles grammar markers.
16:37 Changeset [22438] by sfalken

2006-10-27 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej.


Tighten up warning levels by removing #pragma warning(push, 0), pop

  • WebBackForwardList.h:
  • WebFrame.h:
  • WebIconDatabase.h:
15:31 Changeset [17390] by thatcher

WebCore:

Reviewed by Beth.

Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Beth.

Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
15:07 Changeset [17389] by justing

Fixed the revision number in my ChangeLog entry.

14:28 Changeset [17388] by sullivan

Reviewed by Anders


  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): Handle nil documentLoader the way we did before ObjC->C++ changes
14:22 Changeset [22437] by andersca

2006-10-27 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

<rdar://problem/4730678> Plug-ins should be able to open URLs

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
13:50 Changeset [17387] by sullivan

WebCore:

Reviewed by Anders

  • WebCore.exp: exported symbol for FrameMac->advanceToNextSpelling()


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.

WebKit:

Reviewed by Anders

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): call advanceToNextMisspelling directly on FrameMac, bypassing bridge (-[NSArray showGuessPanel:]): ditto
13:42 Changeset [17386] by justing

LayoutTests:

Reviewed by harrison


<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value

Changes reflect the removal of more brs that were about
to collapse:

  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:

Added to demonstrate fix:

  • fast/forms/11423-expected.txt: Added.
  • fast/forms/11423.html: Added.

WebCore:

Reviewed by harrison


<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value


The regression is that foo, return, bar in a textarea serializes as 'foobar'.


Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.


We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove a br or '\n' if content inserted just before it will cause it to collapse.
  • editing/CompositeEditCommand.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node to prevent a collapse as was used for the line break. Fixed comments.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call the renamed function.
12:50 Changeset [17385] by spadma

2006-10-27 sareen <shyam.sareen@nokia.com>

Reviewed by sachin.padma@nokia.com.
DESC: Change the cenrep value in the HTTPLoaderAcceptHeader.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11434

  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
11:54 Changeset [17384] by thatcher

Versioning

11:54 Changeset [17383] by thatcher

Build fix.

11:53 Changeset [17382] by thatcher

New tag (part 2).

11:52 Changeset [17381] by thatcher

New tag.

11:51 Changeset [17380] by brmorris

2006-10-16 brmorris <thisisbradley@gmail.com>

Reviewed by Sachin.
DESC: Update svg icons in CannedImages.cpp
http://bugs.webkit.org/show_bug.cgi?id=9435

  • BrowserCore/Misc/src/CannedImages.cpp: Update mbg includes (CCannedImages::GetImage): Update BROWSERSDK bitmap IDs (CCannedImages::LoadSvg): Update BROWSERSDK bitmap IDs
  • data/Webkit_gcce.loc: Removed.
  • data/Webkit_gcce.rss: Removed.
11:47 Changeset [17379] by thatcher

Build fix.

11:29 Changeset [17378] by ggaren

Reviewed by Brady.

Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.


Added work-around for AppKit crash that semantic accuracy revealed.


No testcase because I don't think there's a way to reflect this change
in a webpage yet.

  • platform/PlatformString.h: (WebCore::String::operator NSString*):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
10:50 Changeset [17377] by darin

Reviewed by Steve.

  • kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix a warning some people see (not sure why others don't see it).
  • JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch this file to force it to re-build grammar.cpp.
10:19 Changeset [17376] by thatcher

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
10:15 Changeset [17375] by thatcher

New tag.

09:49 Changeset [17374] by darin

Oops, forgot to save one file.

09:49 Changeset [17373] by harrison

Reviewed by Maciej,

<rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange

  • bridge/mac/WebCoreAXObject.mm: (blockquoteLevel): Calculate and return the blockquote level of the element.


(AXAttributeStringSetBlockquoteLevel):
Add, if non-zero, or clear the block quote level attribute.


(AXAttributedStringAppendText):
Send AXAttributeStringSetBlockquoteLevel.

09:48 Changeset [17372] by darin

Reviewed by Geoff.

  • made changes so the code compiles with the highest warning level under MSVC (disabling some warnings, making some code fixes)
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::init): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • API/JSObjectRef.cpp: (JSPropertyNameArrayGetNameAtIndex):
  • API/JSStringRef.cpp: (JSStringCreateWithCharacters):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): (KJS::Bindings::coerceValueToNPVariantStringType): (KJS::Bindings::convertValueToNPVariant):
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime):
  • kjs/ExecState.h: (KJS::ExecState::hadException):
  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/Parser.h:
  • kjs/PropertyNameArray.h: (KJS::PropertyNameArray::size):
  • kjs/array_object.cpp: (ArrayObjectImp::callAsFunction):
  • kjs/bool_object.cpp: (BooleanObjectImp::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::collect):
  • kjs/completion.h: (KJS::Completion::isValueCompletion):
  • kjs/date_object.cpp: (KJS::findMonth):
  • kjs/debugger.cpp: (Debugger::sourceParsed): (Debugger::sourceUnused): (Debugger::exception): (Debugger::atStatement): (Debugger::callEvent): (Debugger::returnEvent):
  • kjs/dtoa.cpp:
  • kjs/error_object.cpp: (ErrorObjectImp::callAsFunction): (NativeErrorImp::callAsFunction):
  • kjs/function.cpp: (KJS::FunctionImp::processVarDecls): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionPrototype::callAsFunction):
  • kjs/grammar.y:
  • kjs/identifier.cpp: (KJS::CStringTranslator::translate): (KJS::Identifier::add):
  • kjs/internal.h:
  • kjs/lexer.cpp: (Lexer::lex): (Lexer::isIdentStart): (Lexer::isIdentPart): (isDecimalDigit): (Lexer::isHexDigit): (Lexer::isOctalDigit): (Lexer::matchPunctuator): (Lexer::singleEscape): (Lexer::convertOctal): (Lexer::convertHex): (Lexer::convertUnicode): (Lexer::record8):
  • kjs/lexer.h:
  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
  • kjs/number_object.cpp: (integer_part_noexp): (intPow10): (NumberProtoFunc::callAsFunction): (NumberObjectImp::callAsFunction):
  • kjs/object.cpp: (KJS::JSObject::deleteProperty): (KJS::JSObject::callAsFunction): (KJS::JSObject::toBoolean): (KJS::JSObject::toObject):
  • kjs/object.h: (KJS::JSObject::getPropertySlot):
  • kjs/property_map.cpp: (KJS::isValid): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::containsGettersOrSetters):
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties):
  • kjs/property_slot.h:
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): (StringObjectImp::callAsFunction): (StringObjectFuncImp::callAsFunction):
  • kjs/ustring.cpp: (KJS::UString::Rep::computeHash): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::operator=): (KJS::UString::find): (KJS::UString::rfind):
  • kjs/ustring.h: (KJS::UChar::high): (KJS::UChar::low): (KJS::UCharReference::low): (KJS::UCharReference::high):
  • kjs/value.cpp: (KJS::JSValue::toUInt16):
  • kjs/value.h:
  • pcre/pcre_compile.c: (get_othercase_range):
  • pcre/pcre_exec.c: (match):
  • pcre/pcre_internal.h:
  • wtf/HashFunctions.h: (WTF::intHash): (WTF::PtrHash::hash):
  • wtf/MathExtras.h: (isnan): (lround): (lroundf):
  • wtf/StringExtras.h: (strncasecmp):
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::isPrintableChar):
07:41 Changeset [17371] by darin
  • fix one error in the Qt build
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Updated.
07:39 Changeset [17370] by spadma

2006-10-27 yongjzha yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):


Merge from r17367 from main branch

07:33 Changeset [17369] by darin

Moved the layout test part of the change log to the layout tests directory.

07:31 Changeset [17368] by darin
  • new test results for a couple of tests
  • fast/js/kde/RegExp-expected.txt: Affected by the change to decode \u sequences in JavaScript regular expression at the lexer level.
  • http/tests/navigation/success200-reload-expected.txt: For some reason, this is consistently not dumping the "scrolled" line any more -- since the purpose of the test has nothing to do with that, landing new results.
07:28 Changeset [17367] by yongjzha

2006-10-27 yongjzha yongjun.zhang@nokia.com

Reviewed by Sachin.
DESC: Cancel the background image decoder when StaticImageDecoder
active object is cancelled. Clear the decoding queue before kicking
off memory collection for images.


http://bugs.webkit.org/show_bug.cgi?id=11432

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/ImageRendererFactory.cpp: (COOMImageCollector::Collect):
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CStaticImageDecoder::DoCancel): (CStaticImageDecoder::CheckBitmapMemoryConsumption): (CStaticImageDecoder::StopAllDecoding):
01:08 Changeset [17366] by darin
  • build fix
  • WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
00:09 Changeset [17365] by darin

Reviewed by Maciej.

  • moved methods that are there just to be called by the frame loader client into the client in an attempt to get back some of the speed we lost yesterday
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]): (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (dataSource): (decisionListener): (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::download): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchCreatePage): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack): (WebFrameLoaderClient::mainFrameURL): (WebFrameLoaderClient::setDefersCallbacks): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::elementForEvent): (WebFrameLoaderClient::createPolicyDecider): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::createDocumentLoader): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::canUseArchivedResource): (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay): (WebFrameLoaderClient::deliverArchivedResources): (WebFrameLoaderClient::createPageCache):
  • WebView/WebFrame.mm: (-[NSView setWebFrame:]): (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _saveScrollPositionAndViewStateToItem:]): (-[WebFrame _hasSelection]): (-[WebFrame _clearSelection]): (-[WebFrame _setProvisionalItem:]): (-[WebFrame _setPreviousItem:]): (-[WebFrame _setCurrentItem:]): (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView _topHTMLView]):
  • WebView/WebHTMLViewPrivate.h:
00:08 Changeset [17364] by darin

Reviewed by Maciej.

  • WebCore.exp: Export more symbols needed by WebKit.

10/26/06:

23:29 Changeset [17363] by ggaren

Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.

Fixed layout test crash. Oops.


  • loader/mac/WebDocumentLoader.mm: (WebCore::canonicalizedTitle):
23:08 Changeset [17362] by thatcher

Versioning

23:06 Changeset [17361] by thatcher

Build fix for 64-bit.

23:04 Changeset [17360] by thatcher

new tag (part 2).

23:01 Changeset [17359] by thatcher

new tag.

23:01 Changeset [17358] by thatcher

Bad tag.

22:59 Changeset [17357] by thatcher

new tag (part 2).

22:58 Changeset [17356] by thatcher

new tag.

22:54 Changeset [17355] by thatcher

Build fix for 64-bit.

22:30 Changeset [17354] by bdash

2006-10-26 W. Andy Carrel <wac@google.com>

Reviewed by Maciej.

  • kjs/lexer.cpp: (Lexer::Lexer): (Lexer::setCode): (Lexer::shift): Looking ahead one additional character for the benefit of scanRegExp (Lexer::scanRegExp): Change code to support unicode escapes in inline regexps.
  • kjs/lexer.h: Extra lookahead added.
  • tests/mozilla/ecma_2/RegExp/properties-001.js: Changed test to look for Unicode character rather than the '\u' escaped equivalent for .source and .toString().
20:46 Changeset [17353] by sullivan

Reviewed by Brady


  • fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com


This restores some of the nil-handling that was implicit before some of the code was converted from
Objective-C to C++.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::loadRequest): handle nil FrameMac


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canTargetLoadInFrame:]): handle nil Frame
19:55 Changeset [17352] by ggaren

WebCore:

Reviewed by Darin, Maciej.

Removed many uses of NSString *.
Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing
stringByCollapsingNonPrintingCharacters with a c++ equivalent.


PLT says no performance regression.


  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • loader/mac/FrameLoader.h:
  • loader/mac/FrameLoader.mm: (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::checkContentPolicy): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::invalidatePendingPolicyDecision): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy): (WebCore::FrameLoader::post):
  • loader/mac/WebDocumentLoader.h:
  • loader/mac/WebDocumentLoader.mm: (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle):
  • loader/mac/WebFrameLoaderClient.h:
  • loader/mac/WebMainResourceLoader.mm: (WebCore::MainResourceLoader::continueAfterContentPolicy):

WebKit:

Reviewed by Darin, Maciej.

Removed many uses of NSString * from WebCore.


Changed a few files to ObjC++ for compatiblity with new WebCore methods
taking WebCore::Strings as arguments.


Added a static_cast to make the c++ compiler happy.

19:55 Changeset [22436] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4764502> PluginStreams should cancel their loader jobs on error

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::receivedAllData): Modify assertions. None of the above functions should be run after aborting the load.
18:00 Changeset [22435] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths): Look for plugins in a plugins directory which is relative to the executable directory.


(WebCore::PluginDatabaseWin::createPluginView):
Use reverseFind instead of findRev here.

17:25 Changeset [17351] by thatcher

Reviewed by Adam.

<rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com

The main table at nytimes.com has a fixed width of 874px, but the table ends
up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
this. The other bug was a missing top and left of 0px on the container element,
causing the deletion UI to sometimes be offset below the table.

Now check for the element's renderer at the beginning of show() and
return early if it is null.

  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::updateOutlineStyle): (WebCore::DeleteButtonController::show):
17:20 Changeset [22434] by aroben

Reviewed by Beth.

Fix: <rdar://problem/4799084> Text and dropdown button too close
together in <select>s
Fix: <rdar://problem/4800493> Popup menus should be positioned so that
their text is horizontally aligned with the <select> control's text

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize): Switch alignment of LTR vs. RTL popups, and add padding to align the text. (WebCore::PopupMenu::paint): Add padding from the <select> control to align the text with the <select> control's text.
  • rendering/RenderThemeWin.cpp: Set svn:eol-style native. (WebCore::RenderThemeWin::systemFont): Clean up line endings. (WebCore::RenderThemeWin::adjustMenuListButtonStyle): Add some extra padding between the dropdown button and text. (WebCore::RenderThemeWin::paintMenuListButton): Clean up code a bit.
16:34 Changeset [22433] by aroben

Forgot to make the change to Release as well in my last checkin.

  • WebCore.vcproj/WebCore.vcproj:
16:25 Changeset [22432] by aroben

Rubberstamped by Steve.

Add some missing '/d' flags to xcopy calls to only copy headers if
they've been modified.

  • WebCore.vcproj/WebCore.vcproj:
16:12 Changeset [17350] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Build fix.

  • html/CanvasRenderingContext2D.cpp: Include MathExtras.h
16:02 Changeset [22431] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspellingOrBadGrammar): Build fix from Oliver.
15:57 Changeset [17349] by sullivan

WebCore:

Reviewed by Anders.

Some changes to support new grammar checking code in WebKit.

  • WebCore.exp: added mangled symbol for Document->removeMarkers() so I can call it from WebKit


  • WebCore.xcodeproj/project.pbxproj: Made Document.h and DocumentMarker.h private so I can include them from WebKit. Made HTMLCollection.h private because Document.h uses it.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: removed unmarkAllMisspellings(); WebKit now calls through to the Document directly

WebKit:

Reviewed by Anders

  • WebView/WebFrame.mm: now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h> (-[WebFrame _unmarkAllBadGrammar]): filled in guts (-[WebFrame _unmarkAllMisspellings]): rewrote to call Document directly, bypassing bridge
15:30 Changeset [17348] by sullivan
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib:


Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.

15:27 Changeset [17347] by ggaren

Reviewed by Geoff.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11419
REGRESSION (r17299): Assertion failure in -[WebHTMLView(WebPrivate) _topHTMLView]
([view isKindOfClass:[WebHTMLView class]]) when running the layout tests

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseMoveToX:Y:]):
15:22 Changeset [17346] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Brady.

Add reverseFind to String and use it instead of findRev.
Use CString instead of DeprecatedCString in one place.


  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • ksvg2/svg/SVGURIReference.cpp: (WebCore::SVGURIReference::getTarget):
  • loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset):
  • platform/PlatformString.h: (WebCore::String::reverseFind):
  • platform/StringImpl.cpp: (WebCore::StringImpl::reverseFind):
  • platform/StringImpl.h:
14:27 Changeset [17345] by sullivan

Reviewed by Darin


More plumbing for grammar checking. Still no grammars is checked.

  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"


  • platform/GraphicsContext.h: renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar; now takes a bool parameter for whether it represents bad grammar or a misspelling


  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed an existing "assert" to "ASSERT".


  • rendering/InlineTextBox.h: renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents bad grammar or a misspelling (WebCore::InlineTextBox::paintAllMarkersOfType): now handles markers of type Grammar
14:19 Changeset [17344] by darin

Added bug number to change log entry.

14:17 Changeset [17343] by darin

Reviewed by Adam.

  • editing/execCommand/remove-formatting-expected.txt: Roll back results. The ones just checked in showed the same kind of intermittent failure that copy-paste-bidi.html used to show -- now we consistently get these results.
13:52 Changeset [17342] by thatcher

New tag.

13:42 Changeset [17341] by thatcher

Re-versioning

13:32 Changeset [17340] by thatcher

Versioning

13:29 Changeset [17339] by spadma

2006-10-25 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly. Merge from CCB
http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
13:23 Changeset [17338] by weinig

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
Cleanup rendering code

  • Assorted code cleanup.
  • rendering/AutoTableLayout.cpp:
  • rendering/AutoTableLayout.h: (WebCore::AutoTableLayout::totalPercent):
  • rendering/CounterListItem.h:
  • rendering/CounterNode.cpp:
  • rendering/CounterNode.h: (WebCore::CounterNode::~CounterNode): (WebCore::CounterNode::isReset):
  • rendering/CounterResetNode.cpp:
  • rendering/CounterResetNode.h:
  • rendering/DataRef.h: (WebCore::DataRef::DataRef):
  • rendering/DeprecatedRenderSelect.h:
  • rendering/DeprecatedSlider.cpp:
  • rendering/DeprecatedSlider.h:
  • rendering/EllipsisBox.cpp:
  • rendering/EllipsisBox.h: (WebCore::EllipsisBox::EllipsisBox):
  • rendering/FixedTableLayout.cpp:
  • rendering/FixedTableLayout.h:
  • rendering/GapRects.h:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h: (WebCore::InlineBox::InlineBox): (WebCore::InlineBox::setConstructed): (WebCore::InlineBox::clearTruncation): (WebCore::InlineBox::markDirty):
  • rendering/InlineFlowBox.cpp:
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::setConstructed): (WebCore::InlineFlowBox::setEdges): (WebCore::InlineFlowBox::setVerticalOverflowPositions): (WebCore::InlineFlowBox::setVerticalSelectionPositions):
  • rendering/InlineRunBox.h: (WebCore::InlineRunBox::paintBackgroundAndBorder): (WebCore::InlineRunBox::paintDecorations):
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h: (WebCore::InlineTextBox::InlineTextBox): (WebCore::InlineTextBox::end): (WebCore::InlineTextBox::textObject):
  • rendering/Length.h: (WebCore::Length::Length):
  • rendering/ListMarkerBox.cpp:
  • rendering/ListMarkerBox.h:
  • rendering/RenderPartObject.h:
  • rendering/RootInlineBox.cpp:
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h: (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h: (WebCore::SVGRootInlineBox::SVGRootInlineBox):
  • rendering/TableLayout.h: (WebCore::TableLayout::TableLayout): (WebCore::TableLayout::~TableLayout):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:
12:44 Changeset [17337] by justing

LayoutTests:

Reviewed by john


<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.

  • editing/execCommand/remove-formatting-2-expected.checksum: Added.
  • editing/execCommand/remove-formatting-2-expected.png: Added.
  • editing/execCommand/remove-formatting-2-expected.txt: Added.
  • editing/execCommand/remove-formatting-2.html: Added.
  • editing/execCommand/remove-formatting-expected.txt:

WebCore:

Reviewed by john

<http://bugs.webkit.org/show_bug.cgi?id=11329>
Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.


  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor. Wrapped the plain text fragment in a style span with the document default style so that it will appear unstyled regardless of where it is inserted. Could have also inserted the plain text fragment and then applied the document default style to it, but there is not yet any redundant style prevention in ApplyStyleCommand, so this is cleaner.
  • editing/Editor.h:
  • editing/JSEditor.cpp:
12:24 Changeset [17336] by zbujtas

2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414
merged from 3.1m r17335


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
12:06 Changeset [17335] by zbujtas

2006-10-25 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414


  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode):
11:54 Changeset [17334] by oliver

2006-10-26 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.
Fixes <rdar://problem/4800518> -- needed to update existing
canvas path elements when transforms are performed on the
context.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::scale): (WebCore::CanvasRenderingContext2D::rotate): (WebCore::CanvasRenderingContext2D::translate):
11:51 Changeset [22430] by andersca

2006-10-26 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Use FrameLoadRequest and ResourceRequest instead of passing around
the individual components.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::destroyStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::frameLoadRequest): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h:
11:27 Changeset [17333] by weinig

Reviewed by Darin.

Fix build with older gcc 3.3.4.

  • kjs/DateMath.cpp: Remove inline prefix. (KJS::equivalentYearForDST):
11:25 Changeset [17332] by weinig

WebCore:

Reviewed by Darin.

Fix Qt/Linux build.

  • platform/network/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/network/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest):

WebKitQt:

Reviewed by Darin.

Fix Qt/Linux build.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::openUrl):

WebKitTools:

Reviewed by Darin.

Fix Qt/Linux build.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::open):
11:23 Changeset [22429] by aroben

Reviewed by Adele.

Fix: <rdar://problem/4794162> Implement type-ahead find for popup menus
Fix: <rdar://problem/4800486> Pressing TAB while a popup is focused
should close the popup and move selection in the page

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Don't cache the focused index. (WebCore::PopupMenu::focusedIndex): Always get the focused index from the HTMLSelectElement. (WebCore::PopupMenu::setFocusedIndex): Invalidate before calling valueChanged(), as this will change the result of focusedIndex(). (WebCore::PopupMenu::scrollToRevealSelection): (WebCore::PopupMenu::updateFromElement): New method to repaint/rescroll the popup. (WebCore::PopupWndProc): Send TAB keypresses and printable characters back to the WebView for handling. Also omove handling of Return/Escape into the WM_CHAR event, as this is recommended by MSDN.
11:19 Changeset [17331] by aroben

Reviewed by Adele.

Fix: <rdar://problem/3951815> add "type-to-select" feature for list
boxes (<select> elements)

This also adds type-ahead find for closed menulists (popups).

  • WebCore.xcodeproj/project.pbxproj: Version wars.
  • html/HTMLSelectElement.h: Add new instance variables for type-ahead find.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new instance variables. (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead find on printable character presses. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove redundant check that the listIndex has changed (setSelectedIndex does this for us), and fix indentation. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if to an else-if. (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind() to strip leading whitespace (including non-breaking spaces) from a string. (WebCore::HTMLSelectElement::typeAheadFind): New method to perform type-ahead find.
  • platform/PopupMenu.h: Added new updateFromElement() method to be called from RenderMenuList::updateFromElement().
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::updateFromElement): While we are using NSPopUpButtonCell for our popups, this method can stay empty.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first selected element.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Tell the popup to update if it's visible.
11:05 Changeset [17330] by thatcher

Tag for WebKit for 10.4.1 (unchanged from 10.4).

11:04 Changeset [17329] by thatcher

Tag for JavaScriptCore for 10.4.1 (unchanged from 10.4).

11:02 Changeset [17328] by thatcher

Tag for JavaScriptCore for 10.4 (JavaScriptCore 412).

11:01 Changeset [17327] by thatcher

Tag for WebKit for 10.4 (WebKit 412).

11:00 Changeset [17326] by thatcher

Tag for WebCore for 10.4 (WebCore 413).

10:59 Changeset [17325] by thatcher

New release tag for 10.4.

10:57 Changeset [17324] by thatcher

Tag for JavaScriptCore for 10.4.2 (JavaScriptCore 412.3).

10:56 Changeset [17323] by thatcher

Tag for WebKit for 10.4.2 (WebKit 412.6).

10:55 Changeset [17322] by thatcher

Tag for WebCore for 10.4.2 (WebCore 415.11).

10:54 Changeset [17321] by thatcher

New release tag for 10.4.2.

10:53 Changeset [17320] by thatcher

Tag for WebCore for 10.4.1 (WebCore 415.5).

10:48 Changeset [17319] by thatcher

New release tag for 10.4.1.

10:44 Changeset [17318] by thatcher

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:44 Changeset [17317] by thatcher

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:44 Changeset [17316] by thatcher

bad tag.

10:43 Changeset [17315] by thatcher

Tag for WebCore for 10.4.8 (WebCore 418.21).

10:42 Changeset [17314] by thatcher

Tag for WebKit for 10.4.8 (WebKit 418.9).

10:40 Changeset [17313] by darin

"causing give inconsistent results" -> "causing inconsistent results"

10:40 Changeset [17312] by thatcher

Tag for JavaScriptGlue for 10.4.8 (unchanged from 10.4.7).

10:39 Changeset [17311] by darin

LayoutTests:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/pasteboard/copy-paste-bidi-expected.txt: New results, without the anonymous block that sometimes appeared and sometimes did not.

WebCore:

Reviewed by Anders.

  • removed non-deterministic behavior in editing that was causing give inconsistent results for editing/pasteboard/copy-paste-bidi.html
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Use two vectors instead of a map: more efficient, deterministic. There was no reason to use a hash table.
10:39 Changeset [17310] by thatcher

Tag for JavaScriptCore for 10.4.8 (unchanged from 10.4.7).

10:38 Changeset [17309] by thatcher

New release tag.

09:59 Changeset [17308] by darin
  • oops, checked in failure results, not success
  • fast/js/string-property-iteration-expected.txt: Successful results.
09:46 Changeset [17307] by darin
  • checked in some missing results (if these are wrong we could remove or disable the test)
  • svg/hixie/cascade/002-expected.checksum: Added.
  • svg/hixie/cascade/002-expected.png: Added.
  • svg/hixie/cascade/002-expected.txt: Added.
09:39 Changeset [17306] by darin

JavaScriptCore:

Reviewed by John.

  • fix iteration of properties of string objects (found because of a warning emitted by the MSVC compiler)
  • kjs/string_object.cpp: (StringInstance::getPropertyNames): Change code that wants to format a number as a string to use UString::from. Before it was using the UString constructor that makes a string from a character!
  • kjs/ustring.h:
  • kjs/ustring.cpp: Remove the dangerous and not all that helpful UString(char) constructor.
  • kjs/grammar.y: Change code to not depend on the UString(char) constructor. This is potentially more efficient anyway because we could overload the + operator some day to handle char* directly instead of creating a UString.
  • kjs/nodes2string.cpp: (SourceStream::operator<<): Change code to not depend on the UString(char) constructor.

LayoutTests:

Reviewed by John.

  • add a test for iteration of properties of string objects
  • fast/js/resources/string-property-iteration.js: Added.
  • fast/js/string-property-iteration-expected.txt: Added.
  • fast/js/string-property-iteration.html: Added.
09:06 Changeset [17305] by sullivan
09:05 Changeset [17304] by brmorris

2006-10-25 yadavall <sriram.yadavalli@nokia.com>

Merge of r17301 to s60-RnD-06wk43 release branch.

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407

09:05 Changeset [17303] by sullivan

No review, just two localized string changes.


  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
  • English.lproj/Localizable.strings: updated for these changes
08:23 Changeset [17302] by spadma

2006-10-25 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Do not push multipart parts to memory cache when parsing. If multipart resource is being
requested, cache mode needs to be CacheOnly
http://bugs.webkit.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadResourceL): (CWebKitLoader::LoadWmlResourceL):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::ProcessHeadersL): (CMultipartContentHandler::HandleMultipartMixedL):
06:26 Changeset [17301] by spadma

2006-10-25 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Scriptable plugin & widget object implementation
http://bugs.webkit.org/show_bug.cgi?id=11407

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserControl/inc/BrCtlInterface.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL): (CBrCtl::UpdateDefaultSoftkeysL): (CBrCtl::CreateWidgetExtensionL):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::WidgetExtension):
  • BrowserView/inc/webkitbridge.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl): (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::MakeVisible): (CWebKitView::Draw):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LayoutChanged): (CWebKitBridge::createWidgetObject):
  • Plugin/inc/PluginHandler.h:
  • Plugin/inc/PluginSkin.h: (CPluginSkin::WebKitControl): (CPluginSkin::Frame):
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/NpnImplementation.cpp: (NpnGetValue):
  • Plugin/src/PluginHandler.cpp: (CPluginInfo::ParseDefaultDataL): (CPluginHandler::LoadPluginsSyncL): (CPluginHandler::LoadPluginsL): (CPluginHandler::ReloadPlugins): (CPluginHandler::GetPluginName): (CPluginHandler::GetPluginFileName): (CPluginHandler::GetPluginDescription): (CPluginHandler::GetPluginCount): (CPluginHandler::ReloadPluginsL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL): (CPluginSkin::CreatePluginWinL): (CPluginSkin::SelectViewerAndDownloadL): (CPluginSkin::PluginScriptableObject):
  • Plugin/src/PluginWin.cpp: (CPluginWin::WindowScriptNPObject): (CPluginWin::PluginScriptableObject):
  • group/BrowserView.mmp:
  • group/Plugin.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
03:34 Changeset [17300] by mjs

Reviewed by Anders.

  • .5% speed improvement by avoiding excess CFURLRef allocation
  • loader/CachedResource.cpp: (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL here for later reuse.
  • loader/CachedResource.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
Note: See TracTimeline for information about the timeline view.