Timeline


and

11/03/06:

23:53 Changeset [17591] by ap
  • 5 edits
    2 adds
    2 deletes in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11448
⟨ and ⟩ entities are mapped to the incorrect Unicode codepoint

WebCore:

  • html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.

LayoutTests:

  • fast/parser/entities-in-xhtml-expected.checksum: Removed.
  • fast/parser/entities-in-xhtml-expected.png: Removed. Converted to plain text, the large table in the test didn't nearly fit anyway.
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/parser/entities-in-xhtml.xhtml: Made the test self-consistent again by using actual numeric values for ⟨ and ⟩.
  • fast/parser/entities-in-html-expected.txt: Added.
  • fast/parser/entities-in-html.html: Added. An HTML copy of the same test.
22:14 Changeset [17590] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-03 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
22:03 Changeset [22467] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-03 Steve Falkenburg <sfalken@apple.com>

Fix build

  • config.h: Touched to cause re-build w/ SVG_SUPPORT enabled
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): Added
21:33 Changeset [17589] by bdash
  • 3 edits in trunk/WebCore

2006-11-03 Mark Rowe <bdash@webkit.org>

Reviewed by Oliver.

Update Windows and Qt project files for file removals in r17585.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
21:10 Changeset [17588] by bdash
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Maciej.

The patch fixes text field drawing on the Qt platform.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField): Use the style to correctly render the text field
20:56 Applications using WebKit edited by bdash@webkit.org
Cleanup of formatting (diff)
20:39 WikiStart edited by bdash@webkit.org
A more useful start page, copied from the wiki:WebKit? page (diff)
20:38 WebKit plus SVG edited by bdash@webkit.org
Remove the majority of the page content as it is out of date (diff)
20:20 Changeset [17587] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-11-03 Steve Falkenburg <sfalken@apple.com>

Fix build

  • kjs/JSImmediate.h:
16:41 Changeset [17586] by oliver
  • 2 edits in trunk/WebCore

2006-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Tim.

Correct incorrect call to SetCursor

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
16:37 Changeset [22466] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
16:35 Changeset [17585] by adele
  • 8 edits
    4 deletes in trunk/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.xcodeproj/project.pbxproj:
  • css/html4.css:
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::updateListBoxSelection):
  • html/HTMLSelectElement.h:
  • platform/ListBox.h: Removed.
  • platform/mac/FontCacheMac.mm:
  • platform/mac/ListBoxMac.mm: Removed.
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/DeprecatedRenderSelect.cpp: Removed.
  • rendering/DeprecatedRenderSelect.h: Removed.
16:20 Changeset [17584] by mjs
  • 1 edit
    2 deletes in trunk/WebCore

Not reviewed, fix for accidental commit.

  • rolled back more of the accidentall commit that I forgot.
  • platform/network/mac/ResourceRequestMac.h: Removed.
  • platform/network/mac/ResourceRequestMac.mm: Removed.
16:09 Changeset [17583] by thatcher
  • 4 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
Bug 9596: [Drosera] add a function popup to the source pane

  • Drosera/debugger.css: Added styles for function popup
  • Drosera/debugger.html: Added function popup button and select
  • Drosera/debugger.js: Added function popup functionality
14:28 Changeset [17582] by mjs
  • 22 edits in trunk/WebCore

Not reviewed, fix for accidental commit.

  • roll back some network changes accidentally committed with a previous patch.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceivedResponse):
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::formCreate): (WebCore::formFinalize):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setResponse):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedRedirect):
  • platform/network/ResourceRequest.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::redirectedToURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedRedirect):
  • xml/xmlhttprequest.h:
14:20 Changeset [22465] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Remove SVGRenderAsText files from the project.


  • WebCore.vcproj/WebCore.vcproj:
14:15 Changeset [17581] by andersca
  • 1 edit
    2 deletes in trunk/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Rubber-stamped by Oliver.

Remove these, they have been merged with SVGRenderTreeAsText.


  • rendering/SVGRenderAsText.cpp: Removed.
  • rendering/SVGRenderAsText.h: Removed.
14:12 Changeset [17580] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11504
Fix warnings on non 32 bit platforms

  • kjs/JSImmediate.h: (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits): Rewrite in a way that moves runtime checks to compile-time.

(KJS::):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):

13:55 Changeset [22464] by andersca
  • 4 edits in branches/WindowsMerge

WebCoreWin:

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setPlatformResponse):

WebKitWin:

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • WebChromeClient.cpp:


13:53 Changeset [17579] by andersca
  • 2 edits in trunk/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
13:05 Changeset [17578] by ggaren
  • 1 edit
    2 adds in trunk/WebKit

Forgot to add these two files. Oops.

  • WebCoreSupport/WebChromeClient.h: Added.
  • WebCoreSupport/WebChromeClient.mm: Added.
12:59 Changeset [22463] by ggaren
  • 7 edits
    5 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp:
  • loader/win/ResourceLoaderWin.cpp: Added. (WebCore::ResourceLoader::loadsBlocked):
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebChromeClient.cpp: Added. (WebChromeClient::create): (WebChromeClient::WebChromeClient): (WebChromeClient::canRunModal): (WebChromeClient::runModal):
  • WebChromeClient.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
12:56 Changeset [17577] by ggaren
  • 15 edits
    3 adds in trunk

WebCore:

Reviewed by Darin, Beth.


First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • bridge/mac/PageMac.mm: Removed platform-specific constructor, added setBridge method to replace it. (WebCore::Page::setBridge):
  • bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact that WebCorePageBridge.h doesn't need to be included by ObjC-only files, and, now that it uses PassRefPtr, can't be.


  • page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
  • page/Page.h: (WebCore::Page::dragCaretController): Made this function non-const so that m_dragCaretController doesn't have to be mutable.

WebKit:

Reviewed by Darin, Beth.

First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebPageBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:02 Changeset [17576] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-01 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Use the EscapeUtils::EscapeDecodeL to remove escaped characters in the path.
http://bugs.webkit.org/show_bug.cgi?id=11348


  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):
10:58 Changeset [17575] by ap
  • 1 edit
    1 add in trunk/WebKitTools

2006-11-03 Michael Emmel <mike.emmel@gmail.com>

Reviewed by Maciej.


http://bugs.webkit.org/show_bug.cgi?id=9671

  • Scripts/wkstyle: Adds astyle sed script formats according to most of the style guidelines.
10:36 Changeset [17574] by ap
  • 19 edits
    5 adds in trunk

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=7323
REGRESSION (10.4.4): ondrag* events don't fire on page in a frame

WebCore:

  • bridge/mac/FrameMac.h: Moved drag source information to a static variable in FrameMac.mm. There can be only one drag active at any moment, and having this information here was making sharing this information between subframes hard.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo. (WebCore::FrameMac::freeClipboard): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::dragSourceMovedTo): (WebCore::FrameMac::dragSourceEndedAt): (WebCore::FrameMac::dispatchDragSrcEvent): Access drag source info via sharedDragInfo - this fixes drag source even dispatching. Also removed some old code that was forwarding mouse events to subviews to make HTML editing work in subframes.
  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): Forward events to subframes for dispatching - this fixes drag target events.

WebKitTools:

When dragging, do not send EventSendingController's events immediately. Dragging
is supposed to be modal, so we need to perform it from within the delegate, without
returning to JS to make the next mouse movement.

When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.

  • DumpRenderTree/EventSendingController.h:
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (+[EventSendingController saveEvent:]): (+[EventSendingController replaySavedEvents]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

LayoutTests:

  • fast/events/drag-in-frames-expected.txt: Added.
  • fast/events/drag-in-frames.html: Added.
  • fast/events/resources/drag-in-frames-console.html: Added.
  • fast/events/resources/drag-in-frames-left.html: Added.
  • fast/events/resources/drag-in-frames-right.html: Added.
  • editing/selection/expanding-selections.html:
  • editing/selection/expanding-selections2.html:
  • fast/dynamic/layer-hit-test-crash.html:
  • fast/events/event-view-toString.html:
  • fast/events/resources/drag-outside-window-frame.html:
  • svg/custom/hover-default-fill.svg: Added missing calls to mouseUp().
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg: Don't attempt to click outside the page, this was confusing DRT.
  • editing/selection/select-from-textfield-outwards-expected.txt:
  • editing/selection/select-from-textfield-outwards.html: Removed alerts between dragging steps - they are now useless, as the dragging events are stored and executed at once.
08:52 Changeset [17573] by staikos
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Tim, landed by George.

Fixing compile.

  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
08:51 Changeset [17572] by ggaren
  • 12 edits in trunk/LayoutTests

Missed a few tests in my last check-in, and checked in old results for
others. Oops.


  • editing/inserting/before-after-input-element-expected.txt:
  • editing/inserting/before-after-input-element.html:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/input-field-1.html:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/pasteboard/select-element-1.html:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • editing/selection/select-element-paragraph-boundary.html:
  • fast/forms/textarea-no-scroll-on-blur-expected.txt:
  • fast/forms/textarea-scrollbar-expected.txt:
08:20 Changeset [17571] by staikos
  • 3 edits
    1 add in trunk/WebCore

2006-11-01 Zack Rusin <zack@kde.org>

Reviewed by Maciej, landed by George.

Moving the word/sentence seperators into a file of their own
and implementing findWordBoundary.

  • CMakeLists.txt:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/qt/TextBoundaries.cpp: Added. (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
07:34 Changeset [17570] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):


Merge from ccb r17569

07:29 Changeset [17569] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):
07:24 Changeset [17568] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: TSW bug# VKRR-6PH9VQ : ResolveLink function is called with wrong parameters.
Set the current url on UrlRequest when user clicks on a link.
http://bugs.webkit.org/show_bug.cgi?id=11499

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
02:48 Changeset [17567] by staikos
  • 7 edits in trunk

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Maciej, landed by George.

Compile on both KDE and Qt platforms

  • CMakeLists.txt: add zlib explicitly
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::self): (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): Integrate both implementations

so that moc can parse it

(WebCore::ResourceHandleManager::deliverJobData):
(WebCore::ResourceHandleManager::remove):

  • platform/network/qt/ResourceHandleManager.h:
02:01 Changeset [17566] by staikos
  • 2 edits in trunk/JavaScriptCore

2006-11-02 George Staikos <staikos@kde.org>

Reviewed by Maciej.

  • collector.cpp: Remove a deprecated pthreads call.
01:40 Changeset [17565] by mjs
  • 2 edits in trunk/WebCore

No review, suggested by Mitz.

  • fix a #if to be #ifdef
  • platform/graphics/svg/cg/SVGResourceImageCg.cpp:
01:33 Changeset [17564] by mjs
  • 3 edits in trunk/WebCore

Reviewed and landed by Maciej.


Compile on the Qt platform.

  • ksvg2/misc/KCanvasRenderingStyle.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
01:28 Changeset [17563] by mjs
  • 27 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt. Landed by Maciej.

Adding setPlatformPen/setPlatformFont/setPlatformFillColor
to graphics context to be able to set consistant state
on the platform specific painter without having to change
fill/stroke/font on every operation. This fixes color/stroke/fill
and font handling in the Qt port.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformFont):
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::penToQPen): (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
  • platform/qt/ScrollViewCanvasQt.h:

11/02/06:

22:41 Changeset [17562] by ggaren
  • 418 edits in trunk

LayoutTests:

Reviewed by Justin Garcia.


Used a PERL script to add calls to opt into dumping of editing callbacks
in all editing tests that didn't do so already. This is required now that
dumping of editing callbacks is opt-in.


Updated editing.js so that any test that calls runEditingTest() opt into
dumping of editing callbacks.


Updated results in all non-editing tests to remove dumping of editing callbacks.


Updated results in all editing tests to reflect minor DOM changes due to new
<script> elements.


[ many tests and results modified ]

WebKitTools:

Reviewed by Justin Garcia.


Made dumping of editing callbacks opt-in, so that editing spew doesn't
cloud non-editing tests.

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController shouldDumpEditingCallbacks]): (runTest):
  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
22:02 Changeset [17561] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results because they were incorrect when checked in. (We never
passed this test.)


  • fast/js/regexp-unicode-handling-expected.txt:
21:07 Nice Bugzilla queries edited by anonymous
(diff)
21:05 WebKit plus SVG edited by trac
(diff)
21:03 WebKit plus SVG edited by trac
(diff)
21:02 WebKit plus SVG edited by trac
(diff)
20:54 WebKit plus SVG edited by trac
(diff)
20:54 WebKit Team edited by trac
(diff)
20:48 Nice Bugzilla queries edited by trac
(diff)
20:42 WebKit plus SVG edited by trac
(diff)
20:39 WebKit plus SVG edited by trac
(diff)
20:39 Applications using WebKit edited by trac
(diff)
20:39 Known incompatibilities between open-source WebKit and Safari edited by trac
(diff)
20:39 WebKit Team edited by trac
(diff)
20:35 WebKit plus SVG created by trac
20:35 WebKit Team created by trac
20:34 Known incompatibilities between open-source WebKit and Safari created by trac
20:34 Nice Bugzilla queries created by trac
20:34 Nightly Builds created by trac
20:34 Applications using WebKit created by trac
20:29 Changeset [17560] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

Test for http://bugs.webkit.org/show_bug.cgi?id=9581
REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.

  • fast/forms/textarea-no-scroll-on-blur-expected.txt: Added.
  • fast/forms/textarea-no-scroll-on-blur.html: Added.

WebCore:

Reviewed by Anders.

Test: fast/forms/textarea-no-scroll-on-blur.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent): On blur, only scroll back to the start for text fields.
19:37 Changeset [17559] by andersca
  • 2 edits in trunk/WebCore

Another build fix.


  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
19:33 Changeset [17558] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
19:27 Changeset [17557] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff, landed by Anders.


Fix dependency problems caused when running move-js-headers.sh


  • move-js-headers.sh: Use cp -p instead of just cp so that the modification time of the original files are used.
19:23 Changeset [17556] by andersca
  • 1 edit
    6 adds in trunk/LayoutTests

2006-11-02 W. Andy Carrel <wac@google.com>

Reviewed by Maciej, landed by Anders.


Adding tests for Unicode RegExp behavior to match IE and Firefox.

  • fast/js/regexp-unicode-handling-expected.txt: Added.
  • fast/js/regexp-unicode-handling.html: Added.
  • fast/js/resources/regexp-unicode-handling.js: Added.

2006-11-02 Alexey Proskuryakov <ap@nypop.com>

Reviewed by Maciej, landed by Anders.

Test for bugs 7253 and 7445, based on reductions made by Parag Shah and W. Andy Carrel.

  • fast/js/gmail-re-re-expected.txt: Added.
  • fast/js/gmail-re-re.html: Added.
  • fast/js/resources/gmail-re-re.js: Added.
19:17 Changeset [17555] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim H, landed by Anders.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
REGRESSION: Shadow of file upload button is clipped

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip height to keep from clipping in the shadow
19:16 Changeset [17554] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej, landed by Anders.

  • platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between content and window. ScrollViewQt already receives correct content coordinates from QScrollArea. (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
19:14 Changeset [17553] by andersca
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Maciej, landed by Anders.

  • CMakeLists.txt: Make KDE support optional.

WebKitQt:

Reviewed by Maciej, landed by Anders.

  • QtLauncher/CMakeLists.txt: Make linkage against kde libraries optional
  • QtLauncher/main.cpp: Make it compile without KDE. (main):
19:11 Changeset [17552] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Maciej, landed by Anders

  • CMakeLists.txt: Make linkage against KDE libraries conditional
  • platform/network/qt/ResourceHandleManager.cpp: Added a simple Qt base resource handler that supports only requests to the local filesystem. Used when compiling without KDE support. ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h. (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::~ResourceHandleManager): (WebCore::ResourceHandleManager::self): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel): (WebCore::ResourceHandleManager::deliverJobData):
  • platform/network/qt/ResourceHandleManager.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
  • platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and input dialog functions when compiling without KDE support (WebCore::ServeSynchronousRequest):
19:09 Changeset [17551] by andersca
  • 3 edits in trunk/WebKitTools

2006-11-02 Alexey Proskuryakov <ap@nypop.com>

Reviewed by Maciej, landed by Anders.

  • Scripts/webkitdirs.pm: Make Windows build work with Visual C++ Express.
  • Scripts/install-win-extras: Make setx.exe actually run.
19:06 Changeset [17550] by andersca
  • 2 edits in trunk/WebCore

2006-11-02 David Carson <dacarson@gmail.com>

Reviewed by Geoff, landed by Anders.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
Initializing variable in constructor.

  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
17:30 Changeset [17549] by andersca
  • 2 edits in trunk/WebCore

2006-11-02 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::addHeadersFromHashMap): Don't set all headers at once since that clears any previous headers set.


(WebCore::ResourceHandle::start):

16:27 Changeset [17548] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebViewPrivate.h

Build fix.

16:12 Changeset [17547] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Brady.

Adding outdent to the WebView responder forwarding list.
Also add outdent to WebHTMLView.h and WebViewPrivate.h.

  • WebView/WebHTMLView.h:
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm:
15:00 Changeset [22462] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-02 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

  • WebCore.vcproj/WebCore.vcproj: Use the forked CursorWin.cpp


  • platform/win/CursorWin.cpp: (WebCore::moveCursor): Implement this.


  • platform/win/TemporaryLinkStubs.cpp: Get rid of it here.
14:24 Changeset [22461] by lamadio
  • 1 add in branches/WindowsMerge/WebCore/platform/network/win/CookieJarWin.cpp

mirroring CookieJar - porting to CF in next change.

14:12 Changeset [17546] by spadma
  • 3 edits in S60/branches/3.1m/WebKit

2006-11-02 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC:
http://bugzilla.opendarwin.org/show_bug.cgi?id=11473

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp: (CHttpLoaderAcceptHeader::ReadMimeTypesL):
14:08 Changeset [17545] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results to fix failure seen when running layout tests. Justin
Garcia says the new results look more correct.


  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
13:47 Changeset [17544] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-10-31 zhalu <zhaosong.lu@nokia.com>

Reviewed by Yongjun.
DESC: Browser defaults font family to "Nokia Sans S60" which is not supported under variant 7 build. The system has to default to another font family. If the phone language is English, the system defaults the font family to "Series 60 Hindi" which contains fonts for Greek. If the phone language is set to Greek, the system default the font to "Series 60 ZDigi" which does not contains fonts for Greek. That is why the same variant 7 build supports Greek under English and Automatic Language settings while it does not under Greek language setting. My fix is setting the font family to "Series 60 Hindi" if the phone language is set to Geek language.


http://bugzilla.opendarwin.org/show_bug.cgi?id=11469

  • BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):


Merge from ccb revision 17537

13:37 Changeset [17543] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz and Geoff.

Test for <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)

  • fast/forms/textarea-scrollbar-expected.checksum: Added.
  • fast/forms/textarea-scrollbar-expected.png: Added.
  • fast/forms/textarea-scrollbar-expected.txt: Added.
  • fast/forms/textarea-scrollbar.html: Added.

WebCore:

Reviewed by Mitz and Geoff.

  • Fix for: <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105) <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing) <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages

Test: fast/forms/textarea-scrollbar.html

To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock. This should make them
a lot more stable. In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.

  • rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): (WebCore::RenderTextControl::setStyle): (WebCore::RenderTextControl::createDivStyle): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::baselinePosition): (WebCore::RenderTextControl::nodeAtPoint): (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout. (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
13:36 Changeset [22460] by andersca
  • 1 edit
    1 add in branches/WindowsMerge/WebCore

2006-11-02 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Add forked copy of CursorWin.cpp


  • platform/win/CursorWin.cpp: Added.
10:50 Changeset [17542] by thatcher
  • 2 edits in tags/WebKit-521.29.2/WebKit

Versioning

10:48 Changeset [17541] by thatcher
  • 2 edits in tags/WebKit-521.29.2/WebKit

merging fix for <rdar://problem/4801351>

10:43 Changeset [17540] by thatcher
  • 1 copy in tags/WebKit-521.29.2

New tag.

10:12 Changeset [17539] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen

  • editing/Selection.cpp: (WebCore::Selection::showTreeForThis): this debugging method now displays start offset and end offset, at Darin's suggestion
09:44 Changeset [17538] by kmccullo
  • 3 edits in trunk/LayoutTests

Reviewed by Maciej.

  • Changed the test to take into account the JavaScript standard's interesting take on DST. According to the standard DST should not reflect historically accurate information but should rather interpolate from a comparable year. This test used to show historically accurate information but now reflects the results of interpolating.
  • fast/js/date-big-setdate-expected.txt:
  • fast/js/resources/date-big-setdate.js:
08:38 Changeset [17537] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-10-31 zhalu <zhaosong.lu@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: Browser defaults font family changes for Greek build


http://bugzilla.opendarwin.org/show_bug.cgi?id=11469

  • BrowserCore/Renderers/src/TextRendererFactory.cpp: (CTextRendererFactory::DeviceDefaultFontFamilies):
08:13 Changeset [17536] by spadma
  • 3 edits in S60/branches/3.1m/WebCore

2006-11-01 w3liu <wei.liu@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: Thai text rendering fails when using HTTPS.
http://bugs.webkit.org/show_bug.cgi?id=11486
WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (KWQTextDecoder::~KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode): (QTextCodec::PrepareForExit):
  • kwq/KWQTextCodec.h:


Merge from r17535 from main branch

08:04 Changeset [17535] by yongjzha
  • 3 edits in S60/trunk/WebCore

2006-11-01 w3liu <wei.liu@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: handle truncated text fragments as input string
http://bugs.webkit.org/show_bug.cgi?id=11486
Thai text rendering fails when using HTTPS

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::KWQTextDecoder): (QTextCodec::~QTextCodec): (QTextCodec::makeDecoder): (QTextCodec::toUnicode): (KWQTextDecoder::toUnicode):
  • kwq/KWQTextCodec.h:

11/01/06:

19:59 Changeset [17534] by slewis
  • 3 edits in trunk/WebKitTools

2006-11-01 Stephanie Lewis <slewis@apple.com>

Reviewed by Kevin.


Fixed bug where additional arguments got fed to xcode and jsdriver.pl
Since testkjs is being built before the tests are run, we don't need
to build it with webkit.


Fixes bugs
http://bugs.webkit.org/show_bug.cgi?id=11462
http://bugs.webkit.org/show_bug.cgi?id=6168

  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
19:56 Changeset [17533] by thatcher
  • 2 edits in tags/WebCore-521.29.4/WebCore

Versioning

19:52 Changeset [17532] by justing
  • 10 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4062865>
Copy/paste of a select element fails to include the options

Updated to reflect fix:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/4641033.html:


Added:

  • editing/inserting/before-after-input-element-expected.checksum: Added.
  • editing/inserting/before-after-input-element-expected.png: Added.
  • editing/inserting/before-after-input-element-expected.txt: Added.
  • editing/inserting/before-after-input-element.html: Added.
  • editing/pasteboard/input-field-1-expected.checksum: Added.
  • editing/pasteboard/input-field-1-expected.png: Added.
  • editing/pasteboard/input-field-1-expected.txt: Added.
  • editing/pasteboard/input-field-1.html: Added.
  • editing/pasteboard/select-element-1-expected.checksum: Added.
  • editing/pasteboard/select-element-1-expected.png: Added.
  • editing/pasteboard/select-element-1-expected.txt: Added.
  • editing/pasteboard/select-element-1.html: Added.
  • editing/selection/select-element-paragraph-boundary-expected.checksum: Added.
  • editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • editing/selection/select-element-paragraph-boundary.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/4062865>
Copy/paste of a select element fails to include the options


  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added paragraphBoundary.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added checks for input elements and textareas. Insertion operations would fail when performed just before/after one of these elements b/c the content would be put inside the element. (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non editable content, and made the code to stop at an root faster (don't check isDescendantOf on every iteration). (WebCore::enclosingNodeOfType): Ditto. (WebCore::enclosingList): Ditto. (WebCore::enclosingListChild): Ditto. Added a FIXME, this function seems inappropriately named.
  • editing/markup.cpp: (WebCore::startMarkup): Use the text node's value instead of its rendered content for text nodes inside select elements. One might also turn off annotation when createMarkup enters a select element, but createMarkup is iterative, not recursive, so doing so would be complicated. (WebCore::createMarkup): Add markup for unrendered nodes if they are descendants of a select element.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock. Fixes bug where various replaced elements can't be copied when they are the only thing selected. (WebCore::endOfParagraph): Ditto.
19:36 Changeset [17531] by thatcher
  • 3 edits in tags/WebCore-521.29.4/WebCore

Merging change.

19:26 Changeset [17530] by thatcher
  • 1 copy in tags/WebCore-521.29.4

new tag.

18:07 Changeset [22459] by adachan
  • 6 edits in branches/WindowsMerge/WebKitWin
17:46 Changeset [22458] by oliver
  • 3 edits
    8 adds in branches/WindowsMerge/WebCore

2006-11-01 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Adding SVG_SUPPORT to Boomer.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/build-generated-files.sh:
  • kcanvas/device/quartz/KCanvasFilterQuartz.cpp: Added. (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter): (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFilterQuartz::setOutputImage): (WebCore::KCanvasFilterQuartz::inputImage):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
17:41 Changeset [17529] by oliver
  • 19 edits
    2 moves in trunk/WebCore

2006-11-01 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Converting more or kcanvas/quartz from Obj-C to C++
Minor SVG updates
compatibility fixes

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added. (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
  • kcanvas/device/quartz/QuartzSupport.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/scripts/cssmakeprops:
  • ksvg2/scripts/cssmakevalues:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/svgpathparser.cpp:
  • platform/Path.cpp:
  • platform/graphics/svg/SVGResourceImage.h:
  • rendering/RenderPath.cpp:
  • rendering/SVGRenderAsText.cpp:
17:02 Changeset [17528] by kmccullo
  • 2 edits in trunk/LayoutTests
  • temporarily passing a test so that it does not interfere with others testing.
  • fast/js/date-big-setdate-expected.txt:
16:56 Changeset [17527] by beidson
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher

Added accessor to get the source directory for use in client scripts

  • Scripts/webkitdirs.pm:
16:43 Changeset [17526] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • Fix a regression from r17521: painting of and crash caused by tables with collapsed borders
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to r17521, 'paintInfo' was the local variable. Now 'info' is the local variable and 'paintInfo' is the parameter, which we were accidently modifying.
15:34 Changeset [17525] by adele
  • 4 edits in trunk/LayoutTests

Fixing typo. Changed repaintTest to runRepaintTest.

  • fast/repaint/overflow-outline-repaint-expected.checksum:
  • fast/repaint/overflow-outline-repaint-expected.png:
  • fast/repaint/overflow-outline-repaint.html:
15:28 Changeset [17524] by adele
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by Mitz.

Tests for http://bugs.webkit.org/show_bug.cgi?id=11277
REGRESSION: Incomplete repaint of overflow areas when deleting

  • fast/repaint/overflow-delete-line-expected.checksum: Added.
  • fast/repaint/overflow-delete-line-expected.png: Added.
  • fast/repaint/overflow-delete-line-expected.txt: Added.
  • fast/repaint/overflow-delete-line.html: Added.
  • fast/repaint/overflow-scroll-delete-expected.checksum: Added.
  • fast/repaint/overflow-scroll-delete-expected.png: Added.
  • fast/repaint/overflow-scroll-delete-expected.txt: Added.
  • fast/repaint/overflow-scroll-delete.html: Added.
  • fast/repaint/overflow-outline-repaint-expected.checksum: Added.
  • fast/repaint/overflow-outline-repaint-expected.png: Added.
  • fast/repaint/overflow-outline-repaint-expected.txt: Added.
  • fast/repaint/overflow-outline-repaint.html: Added.

WebCore:

Reviewed by Mitz.

Restrict the repaint rect for overflow blocks after the height has been fully computed.
Also, adjust the repaint rect coordinates for the scroll offset.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
15:26 Changeset [22457] by bdakin
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by Adam.

Build fix from Sam Weinig's check-in. i.p in the PaintInfo is now
i.context

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::paintMenuListButton):
15:22 Changeset [17523] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adam Roben


  • fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
  • WebView/WebPDFView.mm: (-[WebPDFView initWithFrame:]): Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
14:42 Changeset [17522] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-01 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Cenrep UID define change in HttpDownloadObserver.cpp.
http://bugs.webkit.org/show_bug.cgi?id=11488

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::InitDownloadMgrL):
13:49 Changeset [17521] by weinig
  • 51 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
Rename the "p" member variable of the PaintInfo struct to "context"

  • Renames the 'p' and 'r' member variables of the PaintInfo struct to 'context' and 'rect' respectively.
  • Assorted surrounding cleanups.
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/EllipsisBox.h:
  • rendering/InlineBox.cpp: (WebCore::InlineBox::paint):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineFlowBox.h:
  • rendering/InlineRunBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintCaret): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::paintFloats): (WebCore::RenderBlock::paintEllipsisBoxes): (WebCore::RenderBlock::paintSelection): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::fillInlineSelectionGaps): (WebCore::RenderBlock::fillBlockSelectionGaps): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h:
  • rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::continuationBefore): (WebCore::RenderFlow::addChildWithContinuation): (WebCore::RenderFlow::addChild): (WebCore::RenderFlow::attachLineBox): (WebCore::RenderFlow::destroy): (WebCore::RenderFlow::dirtyLinesFromChangedChild): (WebCore::RenderFlow::dirtyLineBoxes): (WebCore::RenderFlow::createInlineBox): (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::getAbsoluteRepaintRect): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::caretRect): (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintOutline): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::paintScrollbar): (WebCore::RenderListBox::paintItemForeground): (WebCore::RenderListBox::paintItemBackground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paint):
  • rendering/RenderObject.h: (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintingRootForChildren): (WebCore::RenderObject::shouldPaintWithinRoot): (WebCore::RenderObject::printBoxDecorations):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint):
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::shouldPaint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • rendering/RenderSVGText.h: (WebCore::RenderSVGText::renderName):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::getBaseline): (WebCore::RenderTableSection::setNeedCellRecalc):
  • rendering/RenderText.h: (WebCore::RenderText::renderName): (WebCore::RenderText::paint): (WebCore::RenderText::element):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::RenderTheme): (WebCore::RenderTheme::~RenderTheme): (WebCore::RenderTheme::controlSupportsTints): (WebCore::RenderTheme::adjustRepaintRect): (WebCore::RenderTheme::themeChanged): (WebCore::RenderTheme::supportsHover): (WebCore::RenderTheme::paintCheckbox): (WebCore::RenderTheme::setCheckboxSize): (WebCore::RenderTheme::paintRadio): (WebCore::RenderTheme::setRadioSize): (WebCore::RenderTheme::paintButton): (WebCore::RenderTheme::setButtonSize): (WebCore::RenderTheme::paintTextField): (WebCore::RenderTheme::paintTextArea): (WebCore::RenderTheme::paintMenuList): (WebCore::RenderTheme::paintMenuListButton):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintMenuList): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint): (WebCore::RenderView::paintBoxDecorations):
  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
  • rendering/RenderWidget.h: (WebCore::RenderWidget::isWidget):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::paintEllipsisBox): (WebCore::RootInlineBox::paintCustomHighlight): (WebCore::RootInlineBox::paint): (WebCore::RootInlineBox::fillLineSelectionGap):
  • rendering/RootInlineBox.h:
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
13:31 Changeset [22456] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createJavaAppletWidget): Ask the plugin database to create a java applet plugin.
  • platform/win/TemporaryLinkStubs.cpp: Remove FrameWin::createJavaAppletWidget.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Don't look for the Sun Java plugin anymore.
12:34 Changeset [17520] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Brady.

  • Fixes many JavaScriptCore tests in other timezones. The root problem is that on mac localtime() returns historically accurate information for DST, but the JavaScript spec explicitly states to not take into account historical information but rather to interpolate from valid years.
  • kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset):
12:07 Changeset [22455] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Build fix.
12:03 Changeset [22454] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Convert plugin code over to using ResourceResponse.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
11:43 Changeset [17519] by andersca
  • 3 edits in trunk/WebCore

2006-11-01 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver, Brady.

  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): Add getters and setters for last modified dadte.


  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Fetch the last modified date. Add correct offset to expired date.
11:25 Changeset [17518] by thatcher
  • 2 edits in trunk/WebCore

Build fix for 64-bit.

08:35 Changeset [17517] by yongjzha
  • 5 edits in S60/trunk/WebKit

2006-11-01 sareen <shyam.sareen@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: add an UI option to disable flash content
http://bugs.webkit.org/show_bug.cgi?id=11473

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::DisableFlashSetting):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::HandleDisableFlashSetting): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL):
03:47 Changeset [17516] by ddkilzer
  • 2 edits in trunk/WebCore

2006-11-01 David Kilzer <ddkilzer@kilzer.net>

Reviewed by Mitz.

Added missing "break;" statement in switch statement from r17493.

Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

10/31/06:

23:53 Changeset [17515] by bdash
  • 2 edits in trunk/WebCore

2006-10-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

  • fix image dragging

This is covered by editing/selection/drag-to-contenteditable-iframe.html

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for HTML IMG elements. (WebCore::HitTestResult::absoluteImageURL): Ditto.
23:15 Changeset [17514] by bdash
  • 2 edits in trunk/WebKit

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html

  • Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): Add null check.
22:13 Changeset [17513] by bdash
  • 2 edits in trunk/WebKitSite

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Update WebKit blog link to prevent pointless redirects.

  • nav.inc:
21:45 Changeset [17512] by bdash
  • 3 edits in trunk/WebKitTools

2006-11-01 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Update references to webkit.opendarwin.org to webkit.org in Spinneret and WebKit.app.

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • WebKitLauncher/WebKitNightlyEnabler.m: (cleanUpAfterOurselves):
19:22 Changeset [17511] by bdakin
  • 6 edits in trunk

WebCore:

Reviewed by Maciej.

This adds the back-end of the remaining WebElementDictionary
functions into HitTestResult.

  • WebCore.exp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::displayString): This is nearly identical to the displayString() defined in DOMInternal.mm except that it returns a String instead of an NSString. The old code path used the DOMInternal method, so I made a new one here for the new code path. (WebCore::HitTestResult::altDisplayString): (WebCore::HitTestResult::image): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::titleDisplayString): (WebCore::HitTestResult::textContent):
  • rendering/HitTestResult.h:

WebKit:

Reviewed by Maciej.

This creates local functions for the remaining WebElementDictionary
members that calls into HitTestResult instead of doing magical
things with the Objective-C DOM classes.

  • ChangeLog:
  • Misc/WebElementDictionary.m: (addLookupKey): The values of the dictionary are now just selectors. They used to be WebElementMethods which were WebElementTargetObjects associated with selectors, but none of that is needed any more. (+[WebElementDictionary initializeLookupTable]): All selectors are now local functions, no more WebElementTargetObjects. (-[WebElementDictionary objectForKey:]): No more target objects! (-[WebElementDictionary _domNode]): Call into HitTestResult member variable. (-[WebElementDictionary _altDisplayString]): Same. (-[WebElementDictionary _image]): Same. (-[WebElementDictionary _absoluteImageURL]): Same. (-[WebElementDictionary _title]): Same. (-[WebElementDictionary _absoluteLinkURL]): Same. (-[WebElementDictionary _targetWebFrame]): Same. (-[WebElementDictionary _titleDisplayString]): Same. (-[WebElementDictionary _textContent]): Same.
19:11 Changeset [17510] by bdash
  • 3 edits in trunk/WebKitTools

2006-10-31 Mark Rowe <bdash@webkit.org>

Reviewed by Stephanie.

Limit build slaves to a single build to prevent concurrent builds on a single slave from significantly increasing build time.

  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Adjust slave distribution, and make use of a SlaveLock.
  • BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Remove unused Qt build factory.
18:59 Changeset [17509] by sullivan
  • 2 edits in trunk/WebCore
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::markMisspellings): Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
18:49 Changeset [17508] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Maciej


  • fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions


The foundation of this was in my last checkin. This checkin is all about displaying
the correct string in the toolTip.

  • dom/DocumentMarker.h: New description field in this struct.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): When adding a grammar marker, supply the appropriate description. Also, added a comment about the remaining work to make grammar checking return sensible answers. (WebCore::FrameMac::markMisspellings): ditto (yes, still needs some refactoring to minimize duplicated code)


  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::addMarker): Now takes an optional description string (WebCore::Document::markerContainingPoint): New function, returns a pointer to the (first) marker of the specified type whose rect contains the specified point, or 0 if none.


  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Replaced hardwired string placeholder implementation with code that uses markerContainingPoint and gets the description from the marker.
18:33 Changeset [22453] by mjs
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.


  • merged changes for:



Most of htis was already in this tree.

  • WebFrame.cpp: (WebFrame::stopLoading): Implement. Added FIXME.
18:14 Changeset [17507] by ggaren
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Beth.


Fixed http://bugs.webkit.org/show_bug.cgi?id=11477
REGRESSION: GMail crashes in KJS::FunctionImp::callerGetter

  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): Removed unnecessary braces. (KJS::FunctionImp::callerGetter): More logical NULL checking.

LayoutTests:

Added test for accessing the 'caller' property from inside an event
listener.

  • fast/events/caller-access-from-event-listener-expected.txt: Added.
  • fast/events/caller-access-from-event-listener.html: Added.
17:35 Changeset [17506] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Maciej.


Fixed crash resulting from Darin's last patch to remove BrowserExtension.

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createWindow):
  • manual-tests/window-open-features-parsing.html: Updated for clarity.
16:56 Changeset [17505] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebView.mm

Build fix for Leopard.

16:33 Changeset [22452] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Yet more B&I build fixes
Another missing .h file from the vcproj

  • WebCore.vcproj/WebCore.vcproj:
15:56 Changeset [17504] by ggaren
  • 20 edits
    2 adds in trunk

LayoutTests:

Added layout test for copying password field.

  • editing/pasteboard/copy-in-password-field-expected.txt: Added.
  • editing/pasteboard/copy-in-password-field.html: Added.

WebCore:

Reviewed by Alice.

Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.


Layout tests pass.


Renamed "may*" to "can*" because "can" is more accurate (these functions
aren't just about permission) and it matches WebKit.

(WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a
password field. Now that WebCore fully implements canCopy(), it doesn't just
mean "the selection is not in a password field" anymore.
(-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code.
The fact that it's not called anymore may represent a security issue, but I
don't see how commented-out code will help reveal the issue, and the
bridge is going away, anyway.

  • editing/SelectionController.h: Changed selection() calls to references to m_sel, to match the rest of the file.

WebKit:

Reviewed by Alice.


Moved some Editing code from WebKit, the bridge, and WebCore::Frame down
to WebCore::Editor.

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.m: (-[WebHTMLView _shouldDeleteRange:]): (-[WebHTMLView _canCopy]): (-[WebHTMLView _canCut]): (-[WebHTMLView _canDelete]): (-[WebHTMLView _canPaste]): (-[WebHTMLView _canEdit]): (-[WebHTMLView _canEditRichly]): (-[WebHTMLView _isEditable]): (-[WebHTMLView _isSelectionInPasswordField]): (-[NSArray validateUserInterfaceItem:]): (-[NSArray _expandSelectionToGranularity:]):
15:37 Changeset [17503] by justing
  • 13 edits in trunk

LayoutTests:

Reviewed by harrison

Updated these tests to mention the bug that they demonstrate:

  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area.html:
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field.html:

WebCore:

Reviewed by harrison


<rdar://problem/4711063>
Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test insertion and plain text string creation unless we need the string for a BeforeTextInserted event handler or for a plain text only region. (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved code here from ReplacementFragment's constructor. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a FIXME.
  • editing/ReplaceSelectionCommand.h:
15:10 Changeset [17502] by adachan
  • 6 edits in trunk/WebCore

2006-10-31 Ada Chan <adachan@apple.com>

Reviewed by Adam

Correct forward declarations of the HitTestRequest struct.

15:03 Changeset [17501] by sullivan
  • 11 edits in trunk

WebCore:

Reviewed by Beth and Adam

Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip;
next I'll make it use a string that's relevant for a specific grammar error.

  • WebCore.exp: export symbol for spellingToolTip function


  • rendering/HitTestResult.h:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): new function, returns the string to be used in a tool tip that describes the questionable grammar


  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): now takes a style and font, needed to compute the rect representing the range containing questionable grammar. Computes the rect and associates it with the marker. (WebCore::InlineTextBox::paintDocumentMarkers): Pass in the style and font now needed by paintSpellingOrGrammarMarker

WebKit:

Reviewed by Beth and Adam


Display a tooltip when hovering over marked bad grammar.

  • Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): support spelling tool tip (-[WebElementDictionary _spellingToolTip]): new method, calls through to HitTestResult


  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Check for a spelling tool tip; if found, prefer it over the other possible tool tips. Check for empty strings instead of just nil strings being, since values from WebElementDictionary are empty strings.


  • WebView/WebViewPrivate.h: declare new string constant WebElementSpellingToolTipKey
  • WebView/WebView.mm: define new string constant WebElementSpellingToolTipKey
15:01 Changeset [17500] by adele
  • 2 edits in trunk/WebCore

Removed commented out variable from last checkin.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
14:51 Changeset [17499] by beidson
  • 2 edits in trunk/WebCore

Build fix

14:15 Changeset [22451] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
14:10 Changeset [17498] by adele
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adam.

Tests for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements

  • fast/forms/listbox-onchange-expected.txt: Added.
  • fast/forms/listbox-onchange.html: Added.
  • fast/forms/listbox-selection-expected.txt: Added.
  • fast/forms/listbox-selection.html: Added.

WebCore:

Reviewed by Adam.

Tests:

  • LayoutTests/fast/forms/listbox-selection.html
  • LayoutTests/fast/forms/listbox-onchange.html
  • html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress. Added 2 vectors to cache selection state. One is kept so that the previous selection state can be restored as the active selection grows and shrinks. And one for onChange, that is updated after onChange is fired. Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.


  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables. (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent. (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events. (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state. (WebCore::HTMLSelectElement::setExtent): Added. (WebCore::HTMLSelectElement::updateListBoxSelection): Added. (WebCore::HTMLSelectElement::listBoxOnChange): Added.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible. (WebCore::RenderListBox::listIndexAtOffset): Added. Replaces optionAtPoint, which is no longer used. (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent. (WebCore::RenderListBox::stopAutoscroll): Added. Tells the select element to fire onChange. This is needed because the autoscroll can end from a mouseUp outside of the list box, and the select element won't get a mouseUp event directly. But the frame will stop the autoscroll at that point, and now we can notify the select element from here. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method. (WebCore::RenderListBox::listIndexIsVisible): Added. (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
  • page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, we don't try to use the pointer to that renderer to call stopAutoscroll. This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
  • rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
  • rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
14:04 Changeset [17497] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-10-31 sareen <shyam.sareen@nokia.com>

Reviewed by <zbujtas@gmail.com>.
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11473

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQObjectWidget.cpp: (QObjectWidget::hasResized): (QObjectWidget::focusable):
13:55 Changeset [17496] by bdakin
  • 1 edit in trunk/WebCore/ChangeLog

Fixing typo in ChangeLog. This is the last one, I swear.

13:53 Changeset [17495] by bdakin
  • 1 edit
    1 add in trunk/WebCore

Forgot to check this in a minute ago. Oops!! Thanks Mitz!

  • rendering/HitTestRequest.h: Added. (WebCore::HitTestRequest::HitTestRequest):
13:48 Changeset [17494] by bdakin
  • 55 edits in trunk

WebCore:

Reviewed by Maciej.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult
should be split into HitTestRequest and HitTestResult

This patch creates a new struct called HitTestRequest that holds
the three boolean values (readonly, active, and mouseMove) that
were formerly a part of HitTestRequest. all hitTest() and
nodeAtPoint() functions now take a HitTestRequest in addition to
the HitTestResult.

WebKit:

Reviewed by Maciej.

Small tweaks to WebKit because of http://bugs.webkit.org/
show_bug.cgi?id=11461 HitTestResult should be split into
HitTestRequest and HitTestResult

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]): The HitTestResult initializer now just takes a point.
13:32 Changeset [22450] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Remove extra files I accidently added

  • WebCore.vcproj/WebCore.vcproj:
13:03 Changeset [17493] by thatcher
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

Bug 11442: [CSS 3] support for cursor: all-scroll
http://bugs.webkit.org/show_bug.cgi?id=11442

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • page/FrameView.cpp: (WebCore::selectCursor):
  • rendering/RenderStyle.h:
12:56 Changeset [17492] by oliver
  • 8 edits
    5 moves in trunk/WebCore

2006-10-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Converting Obj-C++ to C++ in kcanvas

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/QuartzSupport.cpp: Added.
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: Removed.
  • platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
  • platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
12:52 Changeset [17491] by oliver
  • 2 edits in trunk/JavaScriptCore

2006-10-31 Oliver Hunt <oliver@apple.com>

Reviewed by Geoff.

Adding definition for PLATFORM(CI)

  • wtf/Platform.h:
12:34 Changeset [17490] by justing
  • 11 edits
    1 add
    1 delete in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/create-list-1.html: Removed.
  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/remove-list-1-expected.checksum:
  • editing/execCommand/remove-list-1-expected.png:
  • editing/execCommand/remove-list-1-expected.txt:
  • fast/text/attributed-substring-from-range-001-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}


Completely back out r17276 because of performance issues.

  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::advance): (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::TextIterator::handleReplacedElement): (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::TextIterator::emitCharacter): (WebCore::TextIterator::range): (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): (WebCore::SimplifiedBackwardsTextIterator::emitCharacter): (WebCore::SimplifiedBackwardsTextIterator::emitNewline): (WebCore::SimplifiedBackwardsTextIterator::range): (WebCore::CharacterIterator::range): (WebCore::TextIterator::rangeFromLocationAndLength):
  • editing/TextIterator.h: (WebCore::TextIterator::atEnd): (WebCore::SimplifiedBackwardsTextIterator::atEnd):
12:01 Changeset [17489] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix. Generated headers need to be added to 'Copy Generated Headers' and not 'Copy Headers'.

11:34 Changeset [22449] by sfalken
  • 4 edits in branches/WindowsMerge

Fixes for Boomer submission, bumped version number.

11:31 Changeset [17488] by darin
  • 14 edits
    3 adds in trunk

WebCore:

Reviewed by Brady.

  • got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction
  • loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::triggeringAction): Ditto. (WebCore::DocumentLoader::setTriggeringAction): Ditto.
  • loader/FrameLoader.h: Changed action parameters to NavigationAction.
  • loader/FrameLoaderClient.h: Changed action parameters to NavigationAction. Removed elementForEvent.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::reload): Ditto. (WebCore::FrameLoader::checkNewWindowPolicy): Ditto. (WebCore::FrameLoader::checkNavigationPolicy): Ditto. (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto. (WebCore::FrameLoader::post): Ditto.
  • loader/NavigationAction.h: Added.
  • loader/NavigationAction.cpp: Added.
  • loader/mac/NavigationActionMac.mm: Added.
  • loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
  • WebCore.xcodeproj/project.pbxproj: Updated for new files.
  • WebCore.exp: Updated.

WebKit:

Reviewed by Brady.

  • got "action dictionary" code out of FrameLoader, replacing with a class called NavigationAction
  • WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction. Made elementForEvent non-virtual. Added actionDictionary function.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type, and used actionDictionary to make the action dictionary. (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto. (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore that creates the action dictionary (from a NavigationAction).
  • WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction instead of a dictionary for the action parameters.
11:19 Changeset [17487] by sfalken
  • 2 edits in trunk/WebCore

2006-10-31 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Build fix

  • platform/win/CookieJarWin.cpp: (WebCore::cookies):
11:03 Changeset [17486] by aroben
  • 9 edits
    2 moves
    2 adds
    1 delete in trunk/WebCore

Reviewed by Maciej. Landed by Adam.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463

Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
as dicussed with Dave. Also kill the outdated DESIGN document.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/DESIGN: Removed.
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
  • kcanvas/KCanvasTreeDebug.h: Ditto.
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • rendering/RenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.cpp: Added.
  • rendering/SVGRenderTreeAsText.h: Added. (WebCore::operator<<):
10:43 Changeset [17485] by ap
  • 2 edits in trunk/WebCore

2006-10-31 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
Includes some CRLF -> LF fixups.

  • platform/win/CookieJarWin.cpp: (WebCore::cookies):
10:39 Changeset [22448] by kmccullo
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

  • Added basic functionality for running javascript from the address bar. Currently no return results are evaluated so use alert messages to see the results.
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
10:23 Changeset [22447] by aroben
  • 11 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.

  • WebCore.vcproj/WebCore.vcproj: Add new platform/graphics directory to our include path, and copy headers from there for WebKit's benefit.
  • bridge/win/FrameWin.cpp: Update accessors of FrameLoadRequest. (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
  • plugins/win/PluginViewWin.cpp: Ditto. (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost):
  • plugins/win/PluginViewWin.h: Correct forward declaration of FrameLoadRequest.

WebKitWin:

Build fixes.

  • WebEditorClient.cpp: Add stubs for new methods. (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::isGrammarCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag):
  • WebEditorClient.h: Add declarations for new methods.
  • WebFrame.cpp: Fix #includes to use new platform/graphics directory.
  • WebView.cpp: Ditto.
  • WebKit.vcproj/WebKit.vcproj: Add platform/graphics to include path.
10:19 Changeset [17484] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Steve.

Fix some incorrect forward declarations.

  • loader/FrameLoader.h:
  • page/Frame.h:
10:16 Changeset [17483] by ap
  • 6 edits
    3 adds in trunk

2006-10-31 Vladimir Olexa <vladimir.olexa@gmail.com>

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=4166
Function object does not support caller property

Test: fast/js/caller-property.html

  • kjs/function.cpp: (KJS::FunctionImp::callerGetter): added (KJS::FunctionImp::getOwnPropertySlot): added if statement to handle callerGetter()
  • kjs/function.h: added callerGetter() declaration
  • kjs/identifier.h: added caller property macro
  • tests/mozilla/expected.html:
09:45 Changeset [17482] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Maciej.


  • COM/WebFrame.cpp: (WebFrame::stopLoading): Implement.
  • COM/WebView.cpp: (WebView::stopLoading): ditto (WebView::reload): ditto
09:20 Changeset [17481] by ap
  • 2 edits in trunk/WebKitQt

2006-10-31 Simon Hausmann <hausmann@kde.org>

Reviewed by Maciej.

  • QtLauncher/main.cpp: (main): Declare our frame as main frame to the Page object. Fixes crashes on various web sites
08:49 Changeset [17480] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: Instead of allocating a single local pasteboard, allocate any number of local pasteboards. (main): Allocate the dictionary of pasteboards. (+[DumpRenderTreePasteboard _pasteboardWithName:]): Allocate a pasteboard, given a name. (+[LocalPasteboard alloc]): Added, so we don't have to call NSAllocateObject explicitly elsewhere. (-[LocalPasteboard addTypes:owner:]): Added a check that the owner responds to the selector rather than calling unconditionally.
08:40 Changeset [17479] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to try to fix the build on the buildbot.
08:16 Changeset [17478] by darin
  • 2 edits in trunk/WebCore
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds. (WebCore::FrameMac::markMisspellings): Ditto.
06:26 Changeset [17477] by sullivan
  • 2 edits in trunk/WebCore
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): build fix: needed #ifndef BUILDING_ON_TIGER in one more place
06:18 Changeset [17476] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben


  • fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked


This patch introduces much of the guts of grammar checking, though still not enough to actually
check grammar sensibly, due to:


<rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient
context passed to grammar checker

  • platform/Logging.h:
  • platform/Logging.cpp: new log channel SpellingAndGrammar
  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): initialize new log channel
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest in the event of a tie), and do further processing with that one (select range; create marker that causes range to be visibly marked with a funky underline; update spelling panel appropriately). (WebCore::FrameMac::markMisspellings): More or less the same types of changes as in advanceToNextMisspelling The loops are structured just differently enough to make sharing code between these two functions a little tricky, so I decided to save that for a later patch.


(WebCore::FrameMac::respondToChangedSelection):
remove grammar markers when we remove spelling markers

04:36 Changeset [17475] by bdash
  • 2 edits in trunk/WebCore

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Mitz.

Fix Qt/Linux build with older gcc3.3.4.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
04:24 Changeset [17474] by bdash
  • 1 delete in trunk/WebCore/kcanvas/device/qt/KCanvasClipperQt.h

Remove obsolete KCanvasClipperQt.h which should have been removed in r17467.

03:47 Changeset [17473] by bdash
  • 11 edits in trunk

2006-10-31 Zack Rusin <zack@kde.org>

Reviewed by Mitz.

Fix the Qt build after last nights changes.

  • platform/qt/FrameQt.cpp:
  • platform/qt/EditorClientQt.h:
  • platform/qt/EditorClientQt.cpp:
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • CMakeLists.txt:
  • kcanvas/device/qt/KRenderingDeviceQt.cpp:

2006-10-31 Zack Rusin <zack@kde.org>

Reviewed by Mitz.

Fix the Qt build after last nights changes.

  • QtLauncher/CMakeLists.txt:
  • WebKitPart/CMakeLists.txt:

10/30/06:

21:50 Changeset [17472] by darin
  • 2 edits in trunk/WebKitTools
  • fixed build
  • DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]): Don't use CFPasteboard.
21:49 Changeset [22446] by darin
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/win/TemporaryLinkStubs.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest):
21:46 Changeset [17471] by darin
  • 17 edits
    6 deletes in trunk/WebCore

Reviewed by Anders.

  • remove BrowserExtension
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h: Removed.
  • bridge/mac/BrowserExtensionMac.h: Removed.
  • bridge/mac/BrowserExtensionMac.mm: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected):
  • bridge/win/BrowserExtensionWin.cpp: Removed.
  • bridge/win/BrowserExtensionWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • loader/FrameLoader.h:
  • loader/icon/IconLoader.cpp:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::safeLoad): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createWindow):
  • page/Frame.cpp: (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm): (WebCore::Frame::scheduleHistoryNavigation): (WebCore::Frame::redirectionTimerFired):
  • page/Frame.h:
  • page/FrameLoadRequest.h: (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::isEmpty): (WebCore::FrameLoadRequest::resourceRequest): (WebCore::FrameLoadRequest::frameName): (WebCore::FrameLoadRequest::setFrameName):
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • platform/gdk/BrowserExtensionGdk.h: Removed.
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::isEmpty):
21:45 Changeset [17470] by darin
  • 2 edits in trunk/WebKit
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Fix comment.
21:29 Changeset [17469] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11353

  • Drosera/debugger.js: ParsedURL() object now recognizes local files
20:48 Changeset [17468] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard. This should make our buildbot tests no longer need a pasteboard server.
20:17 Changeset [17467] by oliver
  • 57 edits
    13 moves
    7 adds
    10 deletes in trunk/WebCore

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Modified from original due to earlier reversion

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp: Removed.
  • graphics/svg/SVGResourceClipper.cpp: Removed.
  • graphics/svg/SVGResourceClipper.h: Removed.
  • graphics/svg/SVGResourceImage.h: Removed.
  • graphics/svg/SVGResourceListener.h: Removed.
  • graphics/svg/SVGResourceMarker.cpp: Removed.
  • graphics/svg/SVGResourceMarker.h: Removed.
  • graphics/svg/SVGResourceMasker.cpp: Removed.
  • graphics/svg/SVGResourceMasker.h: Removed.
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h:
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp: (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
19:53 Changeset [17466] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady


  • minor cleanup to make future patches clearer
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test with "continue" to better match structure of similar code in markMisspellings; a few other style tweaks.


(WebCore::FrameMac::markMisspellings):
renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
a block just after a break and outdented accordingly.

19:23 Changeset [17465] by ggaren
  • 3 edits
    2 adds in trunk/WebKitTools

Reviewed by Beth.


Reorganized project file into Delegates and Controllers groups, and split
UIDelegate stuff into a UIDelegate class.


A little birdy told me that I might end up adding some UIDelegate methods
to DRT soon.

  • DumpRenderTree/DumpRenderTree.m: (main): (runTest):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
18:54 Changeset [17464] by sullivan
  • 5 edits in trunk

WebCore:

Reviewed by Geoff Garen


WebCore part of change to push the code that updates the spelling panel
into WebCore, in preparation for some grammar-checking stuff.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): no more return value for this method, and update the spelling panel with the misspelled word here rather than in the WebKit callers.

WebKit:

Reviewed by Geoff Garen

  • WebView/WebHTMLView.m: (-[NSArray checkSpelling:]): removed code to update spelling panel; WebCore handles that now (-[NSArray showGuessPanel:]): ditto
18:36 Changeset [17463] by sullivan
  • 3 edits in trunk/WebKit
  • English.lproj/WebViewEditingContextMenu.nib/info.nib:
  • English.lproj/WebViewEditingContextMenu.nib/objects.nib: Another wording change to match framework, post-Tiger: "Check Spelling" -> "Check Document Now"
18:33 Changeset [17462] by oliver
  • 72 edits
    2 copies
    13 adds in trunk/WebCore

liver Hunt <oliver@apple.com>

Reviewed by Anders.

Roll out last patch

  • CMakeLists.txt:
  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • graphics/svg/SVGResource.cpp:
  • graphics/svg/SVGResourceClipper.cpp:
  • graphics/svg/SVGResourceClipper.h:
  • graphics/svg/SVGResourceImage.h:
  • graphics/svg/SVGResourceListener.h:
  • graphics/svg/SVGResourceMarker.cpp:
  • graphics/svg/SVGResourceMarker.h:
  • graphics/svg/SVGResourceMasker.cpp:
  • graphics/svg/SVGResourceMasker.h:
  • kcanvas/KCanvasClipper.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasClipper::KCanvasClipper): (WebCore::KCanvasClipper::~KCanvasClipper): (WebCore::KCanvasClipper::resetClipData): (WebCore::KCanvasClipper::addClipData): (WebCore::KCanvasClipper::clipData): (WebCore::KCanvasClipper::externalRepresentation): (WebCore::getClipperById):
  • kcanvas/KCanvasClipper.h: Added. (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::KCClipDataList): (WebCore::KCClipDataList::addPath): (WebCore::KCanvasClipper::isClipper):
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Added. (WebCore::KCanvasImage::KCanvasImage): (WebCore::KCanvasImage::~KCanvasImage):
  • kcanvas/KCanvasMarker.cpp: Added. (WebCore::KCanvasMarker::KCanvasMarker): (WebCore::KCanvasMarker::~KCanvasMarker): (WebCore::KCanvasMarker::setMarker): (WebCore::KCanvasMarker::setRef): (WebCore::KCanvasMarker::refX): (WebCore::KCanvasMarker::refY): (WebCore::KCanvasMarker::setAngle): (WebCore::KCanvasMarker::angle): (WebCore::KCanvasMarker::setAutoAngle): (WebCore::KCanvasMarker::setUseStrokeWidth): (WebCore::KCanvasMarker::useStrokeWidth): (WebCore::KCanvasMarker::draw): (WebCore::KCanvasMarker::externalRepresentation): (WebCore::getMarkerById):
  • kcanvas/KCanvasMarker.h: Added. (WebCore::KCanvasMarker::isMarker):
  • kcanvas/KCanvasMasker.cpp: Added. (WebCore::KCanvasMasker::KCanvasMasker): (WebCore::KCanvasMasker::~KCanvasMasker): (WebCore::KCanvasMasker::setMask): (WebCore::KCanvasMasker::externalRepresentation): (WebCore::getMaskerById):
  • kcanvas/KCanvasMasker.h: Added. (WebCore::KCanvasMasker::isMasker): (WebCore::KCanvasMasker::mask):
  • kcanvas/KCanvasResource.cpp: Added. (WebCore::operator<<): (WebCore::KCanvasResource::KCanvasResource): (WebCore::KCanvasResource::~KCanvasResource): (WebCore::KCanvasResource::addClient): (WebCore::KCanvasResource::clients): (WebCore::KCanvasResource::invalidate): (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::KCanvasResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById):
  • kcanvas/KCanvasResource.h: (WebCore::): (WebCore::KCanvasResource::isPaintServer): (WebCore::KCanvasResource::isFilter): (WebCore::KCanvasResource::isClipper): (WebCore::KCanvasResource::isMarker): (WebCore::KCanvasResource::isMasker):
  • kcanvas/KCanvasResourceListener.h: Added. (KCanvasResourceListener::KCanvasResourceListener): (KCanvasResourceListener::~KCanvasResourceListener):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer): (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: (WebCore::KCanvasClipperQt::applyClip):
  • kcanvas/device/qt/KCanvasClipperQt.h: (WebCore::KCanvasClipperQt::KCanvasClipperQt):
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz): (WebCore::KCanvasImageQuartz::KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::init): (WebCore::KCanvasImageQuartz::size):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip): (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz): (WebCore::KCanvasImageQuartz::cgLayer): (WebCore::KCanvasImageQuartz::setCGLayer):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/GraphicsContext.h: Added.
  • platform/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
17:46 Changeset [17461] by oliver
  • 59 edits
    13 moves
    3 adds
    2 deletes in trunk/WebCore

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436

Better SVG integration in WebKit, Part I.

The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).

KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasClipper.cpp: Removed.
  • kcanvas/KCanvasClipper.h: Removed.
  • kcanvas/KCanvasCreator.cpp: Removed.
  • kcanvas/KCanvasCreator.h: Removed.
  • kcanvas/KCanvasFilters.cpp: (WebCore::getFilterById):
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasImage.h: Removed.
  • kcanvas/KCanvasMarker.cpp: Removed.
  • kcanvas/KCanvasMarker.h: Removed.
  • kcanvas/KCanvasMasker.cpp: Removed.
  • kcanvas/KCanvasMasker.h: Removed.
  • kcanvas/KCanvasResource.cpp: Removed.
  • kcanvas/KCanvasResource.h: Removed.
  • kcanvas/KCanvasResourceListener.h: Removed.
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::writeRenderResources):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::KRenderingPaintServer):
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (WebCore::KRenderingPaintServerGradient::listener): (WebCore::KRenderingPaintServerGradient::setListener):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.cpp: (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern): (WebCore::KRenderingPaintServerPattern::tile): (WebCore::KRenderingPaintServerPattern::setTile): (WebCore::KRenderingPaintServerPattern::listener): (WebCore::KRenderingPaintServerPattern::setListener):
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
  • kcanvas/device/qt/KCanvasClipperQt.h: Removed.
  • kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceQt::contextForImage): (WebCore::KRenderingDeviceQt::createResource): (WebCore::KRenderingDeviceQt::createPaintServer):
  • kcanvas/device/qt/KRenderingDeviceQt.h:
  • kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  • kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  • kcanvas/device/qt/RenderPathQt.h: Removed.
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::contextForImage): (WebCore::KRenderingDeviceQuartz::createPaintServer): (WebCore::KRenderingDeviceQuartz::createResource):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::patternCallback): (WebCore::KRenderingPaintServerPatternQuartz::setup):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::SVGClipPathElement): (WebCore::SVGClipPathElement::~SVGClipPathElement): (WebCore::SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::~SVGFilterElement): (WebCore::SVGFilterElement::canvasResource):
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::~SVGGradientElement): (WebCore::SVGGradientElement::canvasResource): (WebCore::SVGGradientElement::resourceNotification):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::~SVGMarkerElement): (WebCore::SVGMarkerElement::canvasResource):
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::~SVGMaskElement): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::~SVGPatternElement): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::canvasResource):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::canvasResource):
  • platform/GraphicsContext.cpp: Removed.
  • platform/GraphicsContext.h: Removed.
  • platform/GraphicsTypes.cpp: Removed.
  • platform/GraphicsTypes.h: Removed.
  • platform/graphics/GraphicsContext.cpp: Added. (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::fillColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::focusRingBoundingRect): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects): (WebCore::GraphicsContext::drawTiledImage):
  • platform/graphics/GraphicsContext.h: Added.
  • platform/graphics/GraphicsTypes.cpp: Added. (WebCore::): (WebCore::parseCompositeOperator): (WebCore::compositeOperatorName): (WebCore::parseLineCap): (WebCore::lineCapName): (WebCore::parseLineJoin): (WebCore::lineJoinName):
  • platform/graphics/GraphicsTypes.h: Added. (WebCore::):
  • platform/graphics/svg/SVGResource.cpp: Added. (WebCore::SVGResource::SVGResource): (WebCore::SVGResource::~SVGResource): (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient): (WebCore::SVGResource::clients): (WebCore::SVGResource::idInRegistry): (WebCore::SVGResource::setIdInRegistry): (WebCore::SVGResource::externalRepresentation): (WebCore::getResourceById): (WebCore::getPaintServerById): (WebCore::operator<<):
  • platform/graphics/svg/SVGResource.h: Added. (WebCore::): (WebCore::SVGResource::isPaintServer): (WebCore::SVGResource::isFilter): (WebCore::SVGResource::isClipper): (WebCore::SVGResource::isMarker): (WebCore::SVGResource::isMasker): (WebCore::SVGResourceListener::~SVGResourceListener):
  • platform/graphics/svg/SVGResourceClipper.cpp: Added. (WebCore::SVGResourceClipper::SVGResourceClipper): (WebCore::SVGResourceClipper::~SVGResourceClipper): (WebCore::SVGResourceClipper::resetClipData): (WebCore::SVGResourceClipper::addClipData): (WebCore::SVGResourceClipper::clipData): (WebCore::SVGResourceClipper::externalRepresentation): (WebCore::operator<<): (WebCore::getClipperById):
  • platform/graphics/svg/SVGResourceClipper.h: Added. (WebCore::ClipDataList::addPath): (WebCore::SVGResourceClipper::isClipper):
  • platform/graphics/svg/SVGResourceImage.h: Added.
  • platform/graphics/svg/SVGResourceMarker.cpp: Added. (WebCore::SVGResourceMarker::SVGResourceMarker): (WebCore::SVGResourceMarker::~SVGResourceMarker): (WebCore::SVGResourceMarker::setMarker): (WebCore::SVGResourceMarker::setRef): (WebCore::SVGResourceMarker::draw): (WebCore::SVGResourceMarker::externalRepresentation): (WebCore::getMarkerById):
  • platform/graphics/svg/SVGResourceMarker.h: Added. (WebCore::SVGResourceMarker::refX): (WebCore::SVGResourceMarker::refY): (WebCore::SVGResourceMarker::setAngle): (WebCore::SVGResourceMarker::setAutoAngle): (WebCore::SVGResourceMarker::angle): (WebCore::SVGResourceMarker::setUseStrokeWidth): (WebCore::SVGResourceMarker::useStrokeWidth): (WebCore::SVGResourceMarker::isMarker):
  • platform/graphics/svg/SVGResourceMasker.cpp: Added. (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::~SVGResourceMasker): (WebCore::SVGResourceMasker::setMask): (WebCore::SVGResourceMasker::mask): (WebCore::SVGResourceMasker::externalRepresentation): (WebCore::getMaskerById):
  • platform/graphics/svg/SVGResourceMasker.h: Added. (WebCore::SVGResourceMasker::isMasker):
  • platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/cg/SVGResourceImageCg.mm: Added. (WebCore::SVGResourceImage::SVGResourceImage): (WebCore::SVGResourceImage::~SVGResourceImage): (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size): (WebCore::SVGResourceImage::cgLayer): (WebCore::SVGResourceImage::setCGLayer):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added. (WebCore::applyLuminanceToAlphaFilter): (WebCore::applyExpandAlphatoGrayscaleFilter): (WebCore::transformImageIntoGrayscaleMask): (WebCore::SVGResourceMasker::applyMask):
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added. (WebCore::SVGResourceClipper::applyClip):
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added. (WebCore::SVGResourceImage::init): (WebCore::SVGResourceImage::size):
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added. (WebCore::SVGResourceMasker::applyMask):
  • platform/qt/GraphicsContextQt.cpp:
  • rendering/RenderPath.cpp: (WebCore::RenderPath::paint): (WebCore::DrawMarkersData::DrawMarkersData): (WebCore::RenderPath::drawMarkersIfNeeded):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::paintSVGInlineFlow):
17:44 Changeset [17460] by oliver
  • 2 edits in trunk/WebKitTools

2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Add new platform/graphics include directory.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
17:35 Changeset [17459] by thatcher
  • 2 edits in trunk

Reviewed by Brady.

Make the universal build return non-zero when module make fails.

  • Makefile:
17:33 Changeset [17458] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Stephanie.

Add a special case for the Internal makefiles, so it can find the OepnSource.

  • Scripts/webkitdirs.pm:
17:25 Changeset [17457] by sullivan
  • 10 edits in trunk

WebCore:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • bridge/EditorClient.h: declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()


  • bridge/mac/WebCoreFrameBridge.h: removed bridge equivalents
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): convert bridge-using code to editor()->client()-using code (WebCore::FrameMac::markMisspellingsInAdjacentWords): ditto (WebCore::FrameMac::markMisspellings): ditto (WebCore::FrameMac::respondToChangedSelection): ditto


  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::client): new method, returns EditorClient pointer. In an ideal world all the code that needed to access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor. But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.

WebKit:

Reviewed by Geoff Garen.


Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.

  • WebCoreSupport/WebEditorClient.h: declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new isGrammarCheckingEnabled()
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::isContinuousSpellCheckingEnabled): implement by calling through to WebView (WebEditorClient::isGrammarCheckingEnabled): ditto (WebEditorClient::spellCheckerDocumentTag): ditto


  • WebCoreSupport/WebFrameBridge.mm: removed bridge equivalents of these methods
17:21 Changeset [17456] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Beth.


Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
but the debugger confirmed the cause).

  • WebView/WebFrame.mm: (core): Added check for NULL bridge.
17:01 Changeset [17455] by ggaren
  • 32 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into Editor and
SelectionController, respecitvely.

I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
everything + the kitchen sink.


Specific comments below for interesting things.


  • bindings/objc/DOMInternal.h: Moved exception handling helper methods into a new file so that WebKit can use them, too. Added a helper method for handling exceptions when selecting a Range.
  • bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into WebKit, since they have to do with creating an NSAttributedString for API consumption, and not much to do with general Frame functionality.
  • editing/Editor.h: Moved lastEditCommand tracking (at least the data, for now) into the Editor. Eventually, the Frame will not have to notify the Editor of what the lastEditCommand was, since the Editor will perform all EditCommands.
  • editing/SelectionController.h: The code here is just stuff moved from the bridge.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions and return them. The bridge method to select a DOM range did this implicitly, since all ObjC DOM operations handle DOM exceptions by throwing them as ObjC exceptions.
  • editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity. The two enumerations are numerically identical, but that's an implementation detail of TextAffinity that clients shouldn't be required to know about.

WebKit:

Reviewed by Darin.

Removed a number of editing and selection methods from the bridge.


I moved cross-platform editing and selection code into WebCore::Editor and
WebCore::SelectionController, respecitvely.


All of the seemingly new code here is just code grabbed from WebCore or
merged from WebCoreFrameBridge.


I changed one piece of internal API: we now pass around Ranges in places
where we used to pass around broken out components of Ranges.


I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
Since we now include WebCore headers that depend on these #defines, we need
to keep in sync with them, to avoid binary incompatibility.

16:56 Changeset [17454] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Versioning

16:55 Changeset [17453] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Merging fix.

16:55 Changeset [17452] by thatcher
  • 2 edits in tags/WebCore-521.29.3/WebCore

Merging fix.

16:52 Changeset [17451] by thatcher
  • 1 copy in tags/WebCore-521.29.3

new tag.

16:49 Changeset [17450] by thatcher
  • 2 edits in trunk/WebCore

Rolling out the following change because this crash:
<rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)

And this regression:
<rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/

2006-09-06 David Harrison <harrison@apple.com>

Reviewed and tweaked by Tim H.

<rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation

If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
16:48 Changeset [22445] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-10-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam, Ada.

Expose printing methods in IWebViewPrivate and removed LPARAM-based dispatching.
Call StretchDIBits instead of BitBlt.
Add a maximum DPI (currently set at 300) to speed up printing.
Add support needed for print preview.

  • Interfaces/IWebViewPrivate.idl: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
  • WebView.cpp: Added MAXIMUM_DPI setting to limit the size of print jobs for performance reasons (getPrintRects): Added. Factored out of print, added maximum DPI handling. (WebView::startPrintJob): Factored out of print (WebView::endPrintJob): Factored out of print (WebView::getPrintedPageCount): Factored out of print (WebView::printPage): Factored out of print. Replaced call to BitBlt with StretchDIBits (WebViewWndProc): Re-add support for printing a window (used by bug reporter code)
  • WebView.h: added startPrintJob, endPrintJob, getPrintedPageCount, printPage
15:25 Changeset [17449] by justing
  • 2 edits in trunk/WebCore

Reviewed by harrison

<rdar://problem/4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): Only create VisiblePositions when we're going to use them to create a range for an emitted character. We should further speed TextIterators up by avoiding creating VisiblePositions for TIs that are only used for the characters they emit (like the one that plainText uses).
14:41 Changeset [17448] by weinig
  • 46 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
More rendering code cleaning

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::RenderApplet): (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderApplet.h:
  • rendering/RenderArena.cpp: (WebCore::): (WebCore::RenderArena::RenderArena): (WebCore::RenderArena::allocate): (WebCore::RenderArena::free):
  • rendering/RenderArena.h:
  • rendering/RenderBR.cpp: (WebCore::RenderBR::RenderBR): (WebCore::RenderBR::baselinePosition): (WebCore::RenderBR::lineHeight): (WebCore::RenderBR::setStyle): (WebCore::RenderBR::caretMinOffset): (WebCore::RenderBR::positionForCoordinates): (WebCore::RenderBR::inlineBox):
  • rendering/RenderBR.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::containsFloats): (WebCore::RenderBlock::setHasMarkupTruncation): (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo): (WebCore::RenderBlock::BlockSelectionInfo::block): (WebCore::RenderBlock::BlockSelectionInfo::state): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::CompactInfo::clear):
  • rendering/RenderButton.cpp: (WebCore::RenderButton::removeChild): (WebCore::RenderButton::paintObject):
  • rendering/RenderButton.h: (WebCore::RenderButton::renderName): (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::RenderContainer):
  • rendering/RenderContainer.h: (WebCore::RenderContainer::firstChild): (WebCore::RenderContainer::lastChild): (WebCore::RenderContainer::calcMinMaxWidth):
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::RenderCounter): (WebCore::toRoman): (WebCore::toHebrew): (WebCore::RenderCounter::calcMinMaxWidth):
  • rendering/RenderCounter.h:
  • rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderFieldset::setStyle):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadControl::calcMinMaxWidth):
  • rendering/RenderFileUploadControl.h: (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::RenderForeignObject): (WebCore::RenderForeignObject::paint): (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): (WebCore::RenderForeignObject::layout): (WebCore::RenderForeignObject::nodeAtPoint):
  • rendering/RenderForeignObject.h: (WebCore::RenderForeignObject::renderName):
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::layout): (WebCore::RenderFormElement::textAlignment):
  • rendering/RenderFormElement.h:
  • rendering/RenderFrame.cpp:
  • rendering/RenderFrame.h: (WebCore::RenderFrame::element):
  • rendering/RenderFrameSet.cpp:
  • rendering/RenderFrameSet.h: (WebCore::RenderFrameSet::element):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): (WebCore::RenderHTMLCanvas::paint):
  • rendering/RenderHTMLCanvas.h: (WebCore::RenderHTMLCanvas::renderName):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::setStyle): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText):
  • rendering/RenderImage.h: (WebCore::RenderImage::element):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline): (WebCore::RenderInline::~RenderInline): (WebCore::RenderInline::setStyle): (WebCore::RenderInline::addChildToFlow): (WebCore::RenderInline::cloneInline): (WebCore::RenderInline::splitInlines): (WebCore::RenderInline::splitFlow): (WebCore::RenderInline::paint): (WebCore::RenderInline::absoluteRects): (WebCore::RenderInline::calcMinMaxWidth): (WebCore::RenderInline::requiresLayer): (WebCore::RenderInline::width): (WebCore::RenderInline::height): (WebCore::RenderInline::renderName): (WebCore::RenderInline::nodeAtPoint): (WebCore::RenderInline::positionForCoordinates):
  • rendering/RenderInline.h: (WebCore::RenderInline::layout):
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::root): (WebCore::RenderLayer::setPos): (WebCore::RenderLayer::height): (WebCore::RenderLayer::relativePositionOffset):
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderLineEdit::updateFromElement): (WebCore::RenderLineEdit::selectionStart): (WebCore::RenderLineEdit::selectionEnd): (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange):
  • rendering/RenderLineEdit.h:
  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h: (WebCore::RenderListBox::renderName):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle): (WebCore::getParentOfFirstLineBox): (WebCore::RenderListItem::updateMarkerLocation): (WebCore::RenderListItem::positionListMarker): (WebCore::RenderListItem::paint):
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderListMarker.h: (WebCore::RenderListMarker::renderName): (WebCore::RenderListMarker::isListMarker):
14:35 Changeset [17447] by slewis
  • 5 edits in trunk

Reviewed by Darin.

Change Makefiles to return non-zero when module make fails.

  • Makefile:

WebKitTools:

Change Makefiles to return non-zero when module make fails.
Fix bug where if xcode options are not set, modules can build in the
wrong directory.

  • Makefile:
  • Scripts/webkitdirs.pm:
14:29 Changeset [22444] by andersca
  • 9 edits
    1 add in branches/WindowsMerge

WebCoreWin:

2006-10-30 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

If there's no plug-in for a given mime type, or if the plug-in fails
to initialize, draw the "missing plug-in" icon.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): If no plug-in can be found, create a null plugin view.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paint): If the plugin hasn't been started, paint the missing plugin image.


(WebCore::PluginViewWin::setNPWindowSize):
Return early if the plugin hasn't been started.


(WebCore::PluginViewWin::start):
Return if the plugin couldn't be created.


(WebCore::PluginViewWin::createNullPluginView):
New function which just creates a plugin view and doesn't try to start its plugin
(because there is none).


(WebCore::PluginViewWin::PluginViewWin):
New constructor for the null plugin view.


WebKitWin:

2006-10-30 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Add "null plugin" image resource.


14:25 Changeset [17446] by thatcher
  • 1 edit in trunk/WebCore/editing/DeleteButtonController.cpp

Build fix.

14:19 Changeset [17445] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4478625> Basic table editing and culling

Refined the criteria for deletable elements, rely on the renderer more.
Corrected the interface positioning for elements that have borders.

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): (WebCore::DeleteButtonController::show):
13:34 Changeset [17444] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
12:48 Changeset [17443] by darin
  • 2 edits in trunk/WebCore
  • fix build
  • loader/ResourceLoader.h: Added header guard.
12:08 Changeset [22443] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • WebCore.vcproj/WebCore.vcproj: Added new source files from the loader directory.
12:05 Changeset [17442] by darin
  • 15 edits in trunk/WebCore

Reviewed by Adam.

  • fix FrameLoader files so they can be built on non-Mac platforms
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader. (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
  • page/Page.h:
  • page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong the other day.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Removed code to create the frame loader. (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
  • loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC) around the PolicyCheck definition.
  • loader/FormState.cpp: Changed import to include.
  • loader/FrameLoader.cpp: Ditto.
  • loader/MainResourceLoader.h: Ditto.
  • loader/FrameLoaderTypes.h: Added a header guard.
  • loader/NetscapePlugInStreamLoader.h: Changed import to include. Added #if PLATFORM(MAC) around Mac-specific details.
  • loader/SubresourceLoader.h: Ditto.
  • page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to m_loader from m_frameLoader.
  • CMakeLists.txt: Updated.
  • WebCoreSources.bkl: Updated.
11:53 Changeset [17441] by andersca
  • 2 edits in trunk/WebCore

2006-10-30 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by Anders.

Patch by Zack rusin to fix:
http://bugs.webkit.org/show_bug.cgi?id=11429

Fix startup crash.

  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL):
11:38 Changeset [17440] by andersca
  • 4 edits in trunk/WebCore

2006-10-30 Zach Rusin <zack@kde.org>

Reviewed and landed by Anders.

  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::receivedResponse):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::FrameQtClientDefault):
  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::ServeSynchronousRequest): More build fixes.

2006-10-30 Simon Hausmann <hausmann@kde.org>

Reviewed and landed by Anders.


  • fix Qt build
  • platform/qt/FrameQtClient.cpp: ResourceLoaderClient -> ResourceHandleClient
11:32 Changeset [17439] by darin
  • 2 edits in trunk/LayoutTests

Requested by Maciej.

  • fast/dom/xmlhttprequest-get-expected.txt: Generated a new result. Maciej says that the new behavior of returning empty string instead of undefined is correct and matches Firefox, so the new result is better than the old.
09:20 Changeset [17438] by darin
  • 25 edits
    3 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function from Frame to WebFrame in WebKit
  • page/PageState.h:
  • page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
  • bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a double for the date instead of an NSDate.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and saveDocumentToPageCache methods.
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into an Objective-C wrapper for PageState.
  • loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of NSDate and WebCorePageState.
  • loader/FrameLoaderClient.h: Changed NSDate to double.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache here that used to be in invalidateCurrentItemPageCache on the WebKit side. (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date. (WebCore::FrameLoader::open): Moved one of the open functions that was part of commitProvisionalLoad inside the commitProvisionalLoad function, so that it can extract the parameters from the response. Changed the open function that takes a PageState to use the new C++ PageState. (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open function; tightened up logic, removing a few cases that could never happen, as well as the unused reload boolean.
  • ForwardingHeaders/kjs/property_map.h: Added.
  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.

WebKit:

Reviewed by John Sullivan.

  • work toward removing Objective-C data types from FrameLoader.h: removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader, and WebCoreResourceHandle
  • moved bodyBackgroundColor function here from Frame
  • History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]): Updated for change in WebCorePageState.
  • WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
  • WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was formerly in invalidatePageCache: on the bridge here. (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the NSDate here. (WebFrameLoaderClient::createPageCache): Restructured code to create the WebCorePageState object directly instead of calling saveDocumentToPageCache on the bridge.
  • WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work directly with the DOM and renderers rather than using a function on Frame.
09:18 Changeset [17437] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kjs/SavedBuiltins.h: Added needed include.
  • wtf/OwnPtr.h: (WTF::OwnPtr::set): Fixed mistake in assertion.
08:27 Changeset [17436] by thatcher
  • 5 edits in trunk/WebKitTools

Reviewed by Tim H.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10468
[Drosera] The Console toolbar button should bring the console window to the front.

The console now gets focus when its activated but already open. Command + L also
now activates/focuses the console.

  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
  • Drosera/debugger.js:
03:12 Changeset [22442] by mjs
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): Changed prototype to match new version.

WebKitWin:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebFrame.cpp: (WebFrame::didReceiveResponse): Updated from receivedResponse.
  • WebFrame.h:
  • WebURLResponse.cpp: (WebURLResponse::WebURLResponse): Reimplemented to work in terms of WebCore::ResourceResponse (ditto for below). Uses BString to convert strings as needed. (WebURLResponse::~WebURLResponse): (WebURLResponse::createInstance): (WebURLResponse::expectedContentLength): (WebURLResponse::initWithURL): (WebURLResponse::MIMEType): (WebURLResponse::suggestedFilename): (WebURLResponse::textEncodingName): (WebURLResponse::URL): (WebURLResponse::suggestedFileExtension):
  • WebURLResponse.h:
03:08 Changeset [17435] by mjs
  • 25 edits
    5 adds in trunk

WebCore:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call


  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bridge/mac/WebCoreFrameBridge.h: Removed no longer needed expiresTimeForResponse: method.
  • dom/XMLTokenizer.cpp: (WebCore::openFunc): Updated to use ResourceResponse.
  • loader/FrameLoader.h: Update loadResourceSynchronously to use ResourceResponse.
  • loader/LoaderFunctions.h:
  • loader/icon/IconLoader.cpp: (IconLoader::didReceiveResponse): Updated from receivedResponse and made cross-platform.
  • loader/icon/IconLoader.h: updated for above change
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): reduced to just saving the PlatformResponse (ideally we'd phase out use of this). (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse logic.
  • loader/loader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously): Return results as ResourceResponse.
  • loader/mac/IconLoaderMac.mm: remove receivedResponse.
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): take ResourceResponse as argument.
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h: Remove calls for broken out response pieces.
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveResponse): New delegate method.
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove storage of response bits, we're not gonna return them seprately any more.
  • platform/network/ResourceResponse.h: Added. (WebCore::ResourceResponse::ResourceResponse): Freshly implemented. Same for below. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::isMultipart): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Send didReceiveResponse client method.
  • platform/network/cf/ResourceResponseCFNet.h: Added.
  • platform/network/cf/ResourceResponseCFNet.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from CFURLResponseRef.
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandleInternal::~ResourceHandleInternal): Don't bother cleaning up fields we no longer have. (WebCore::ResourceHandle::receivedResponse): Send didReceiveResponse client method.
  • platform/network/mac/ResourceResponseMac.h: Added.
  • platform/network/mac/ResourceResponseMac.mm: Added. (getResourceResponse): Helper function to get a ResourceResponse from an NSURLResponse*.
  • rendering/HitTestResult.cpp:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseText): Store http response info in the form of a ResourceResponse, change all methods to account for this. (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::processSyncLoadResults): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:

WebKit:

Reviewed by Anders.

  • added ResourceResponse class and didReceiveResponse delegate call
  • WebCoreSupport/WebFrameBridge.mm: Removed no longer needed expiresTimeForResponse: method.
Note: See TracTimeline for information about the timeline view.