Timeline


and

11/07/06:

23:48 Changeset [17656] by bdakin
  • 10 edits
    25 adds in trunk

WebCore:

Reviewed by Hyatt.

Another go at fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The fix from yesterday caused a layout test regression which
exposed an existing bug. The existing bug was that we allowed text
nodes to stay in the head tag, but other browsers move them to the
body. The previous fix also caused a performance regression, which
was seemingly easy to fix by moving the new clause in
HTMLParser::handleError() to be below the HTMLElement case.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to be the child of the document.
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::childAllowed): Do not allow non- whitespace text nodes to be children of the head.
  • html/HTMLHeadElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Error case for comment nodes.
  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safety-net null check for the original crash.

Layout Tests:

Reviewed by Hyatt.

Test cases for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

And for the found-bug of moving text nodes within the head to the
body.

23:24 Changeset [17655] by darin
  • 2 edits in trunk/WebCore
  • another attempt to fix Qt build
  • loader/icon/IconLoader.h: Added missing include.
23:09 Changeset [22489] by ggaren
  • 5 edits
    1 add
    2 deletes in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.


Moved Screen back from page/ to platform/ because it's a platform
abstraction again.


Fixed bug where Screen would query the default screen instead of the screen
on which the active window was located. (The code is written in Klingon,
but that's cool.)


Implemented some missing screen functionality on Win.


I can't fully verify this code because I can't load files without crashing
in CFNetwork, but I exercised most of it with javascript: URLs and the
debugger reported reasonable values.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ScreenWin.cpp: Added. Merged over from opensource tree. (WebCore::getWindow): (WebCore::getMonitorInfo): (WebCore::getDeviceInfo): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect):

WebKitWin:

Reviewed by Anders.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

23:04 Changeset [17654] by ggaren
  • 11 edits
    1 add
    5 deletes in trunk

WebCore:

Reviewed by Tim Hatcher.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.


Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
since the two were always used together.


Changed pixel depth queries to query the deepest screen. Darin mentioned
that it might have been a feature, not a bug, to use the main/menubar screen
regardless of the screen you were on. For scaling and flipping that's not
the case, but for querying pixel depth I think it is. You want to know
about the highest pixel depth your content may display on.


Tests still pass.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • page/Screen.cpp: Removed.
  • page/Screen.h: Removed.
  • page/ScreenClient.h: Removed.
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint):
  • platform/mac/ScreenMac.mm: (WebCore::window): (WebCore::bestScreen): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect): (WebCore::toUserSpace): (WebCore::toDeviceSpace):

WebKit:

Reviewed by Geoff.

  • udpated for changes to move from Frame/FrameMac to FrameLoader
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
  • WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):
21:58 Changeset [17653] by darin
  • 3 edits in trunk/WebCore
  • try to fix Qt build
  • CMakeLists.txt: Updated for some file changes.
  • WebCoreSources.bkl: Ditto.
21:57 Changeset [22488] by darin
  • 10 edits
    1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::setTitle):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::markMisspellings): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (IconLoader::notifyIconChanged): (PolicyCheck::PolicyCheck): (PolicyCheck::clear): (PolicyCheck::call): (PolicyCheck::clearRequest): (FrameLoader::saveDocumentState): (FrameLoader::restoreDocumentState): (FrameLoader::partClearedInBegin): (FrameLoader::goBackOrForward): (FrameLoader::historyURL): (FrameLoader::canGoBackOrForward): (FrameLoader::getHistoryLength): (DocumentLoader::setupForReplaceByMIMEType): (ResourceLoader::cancel): (DocumentLoader::stopLoading): (DocumentLoader::setLoading): (DocumentLoader::updateLoading): (DocumentLoader::setFrame): (DocumentLoader::stopRecordingResponses): (DocumentLoader::isStopping): (DocumentLoader::setPrimaryLoadComplete): (DocumentLoader::finishedLoading): (DocumentLoader::URL): (DocumentLoader::isLoadingInAPISense): (DocumentLoader::frameLoader): (FrameLoader::overrideMediaType): (FrameLoader::redirectDataToPlugin): (FrameLoader::checkLoadCompleteForThisFrame): (FrameLoader::loadEmptyDocumentSynchronously): (FrameLoader::startLoading): (FrameLoader::referrer):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::userAgent):

WebKitWin:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebFrame.cpp: (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::initWithWebFrameView): (WebFrame::loadDataSource): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading): (WebFrame::setTitle): (WebFrame::dispatchDidHandleOnloadEvents): (WebFrame::detachFrameLoader): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::hasBackForwardList): (WebFrame::resetBackForwardList): (WebFrame::provisionalItemIsTarget): (WebFrame::loadProvisionalItemFromPageCache): (WebFrame::invalidateCurrentItemPageCache): (WebFrame::privateBrowsingEnabled): (WebFrame::makeDocumentView): (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::updateHistoryForCommit): (WebFrame::updateHistoryForBackForwardNavigation): (WebFrame::updateHistoryForReload): (WebFrame::updateHistoryForStandardLoad): (WebFrame::updateHistoryForInternalLoad): (WebFrame::updateHistoryAfterClientRedirect): (WebFrame::setCopiesOnScroll): (WebFrame::tokenForLoadErrorReset): (WebFrame::resetAfterLoadError): (WebFrame::doNotResetAfterLoadError): (WebFrame::willCloseDocument): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromPageCache): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::dispatchDidLoadMainResource): (WebFrame::clearLoadingFromPageCache): (WebFrame::isLoadingFromPageCache): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::progressStarted): (WebFrame::progressCompleted): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finishedLoading): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::frameLoadCompleted): (WebFrame::restoreScrollPositionAndViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::userAgent):
  • WebFrame.h:
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
21:52 Changeset [17652] by darin
  • 79 edits
    1 copy
    1 add in trunk

WebCore:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty):
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • bindings/js/kjs_window.cpp: (KJS::Screen::Screen): (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Location::getValueProperty): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • bindings/objc/DOM.mm: (+[DOMNode _nodeWith:WebCore::]):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::setView): (WebCore::FrameMac::setStatusBarText):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • css/cssparser.cpp: (WebCore::CSSParser::parseContent):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::readyState): (WebCore::Document::updateTitle): (WebCore::Document::open): (WebCore::Document::close): (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer): (WebCore::Document::finishedParsing):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::notifyFinished):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::lastModified):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::willRemove):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • html/HTMLPreElement.idl:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  • loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::cancelAll): (WebCore::getString): (WebCore::isBackForwardLoadType): (WebCore::numRequests): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::cancelRedirection): (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::gotoAnchor): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadDone): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::checkEmitLoadEvent): (WebCore::FrameLoader::baseURL): (WebCore::FrameLoader::baseTarget): (WebCore::FrameLoader::completeURL): (WebCore::FrameLoader::scheduleRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldUsePlugin): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::clearRecordedFormValues): (WebCore::FrameLoader::recordFormValue): (WebCore::FrameLoader::parentCompleted): (WebCore::FrameLoader::outgoingReferrer): (WebCore::FrameLoader::lastModified): (WebCore::FrameLoader::opener): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::openedByJavaScript): (WebCore::FrameLoader::setOpenedByJavaScript): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::setPolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::isComplete): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::url): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::stopRedirectionTimer): (WebCore::FrameLoader::updateBaseURLForEmptyDocument): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::started): (WebCore::FrameLoader::containsPlugins): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canTarget): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::hasMainResourceLoader): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::open): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::handledOnloadEvents): (WebCore::FrameLoader::frameDetached): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/FrameLoader.h: (WebCore::):
  • loader/FrameLoaderClient.h:
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData):
  • loader/ResourceLoader.h:
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse):
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setPrimaryLoadComplete):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::nsArray): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFinishLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): (WebCore::CheckCacheObjectStatus):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::cancel):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • loader/qt/FrameLoaderQt.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::originalRequestURL):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::document):
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::prepareForUserAction): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::mediaType):
  • page/FrameView.h:
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restoreJavaScriptState):
  • platform/mac/CookieJar.mm: (WebCore::setCookies):
  • platform/mac/TextCodecMac.cpp:
  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderBlock.h:
  • rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget):
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):

WebKit:

Reviewed by Geoff.

  • udpated for changes to move from Frame/FrameMac to FrameLoader
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
  • WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):
19:36 Coding Style Guidelines edited by aroben@apple.com
(diff)
19:05 Changeset [17651] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]): (-[WebCoreFrameBridge selectionGranularity]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]): (-[WebCoreFrameBridge applyStyle:withUndoAction:]): (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setModifyBias): (WebCore::SelectionController::modify):
  • editing/SelectionController.h: (WebCore::SelectionController::):
  • editing/TextGranularity.h:

WebKit:

Reviewed by Geoff.

Use the WebCore editing enums.


  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge undoNameForEditAction:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[WebHTMLView moveBackward:]): (-[WebHTMLView moveBackwardAndModifySelection:]): (-[WebHTMLView moveDown:]): (-[WebHTMLView moveDownAndModifySelection:]): (-[WebHTMLView moveForward:]): (-[WebHTMLView moveForwardAndModifySelection:]): (-[WebHTMLView moveLeft:]): (-[WebHTMLView moveLeftAndModifySelection:]): (-[WebHTMLView moveRight:]): (-[WebHTMLView moveRightAndModifySelection:]): (-[WebHTMLView moveToBeginningOfDocument:]): (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): (-[WebHTMLView moveToBeginningOfSentence:]): (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]): (-[WebHTMLView moveToBeginningOfLine:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToBeginningOfParagraph:]): (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): (-[WebHTMLView moveToEndOfDocument:]): (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): (-[WebHTMLView moveToEndOfSentence:]): (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]): (-[WebHTMLView moveToEndOfLine:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfParagraph:]): (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): (-[WebHTMLView moveParagraphForwardAndModifySelection:]): (-[WebHTMLView moveUp:]): (-[WebHTMLView moveUpAndModifySelection:]): (-[WebHTMLView moveWordBackward:]): (-[WebHTMLView moveWordBackwardAndModifySelection:]): (-[WebHTMLView moveWordForward:]): (-[WebHTMLView moveWordForwardAndModifySelection:]): (-[WebHTMLView moveWordLeft:]): (-[WebHTMLView moveWordLeftAndModifySelection:]): (-[WebHTMLView moveWordRight:]): (-[WebHTMLView moveWordRightAndModifySelection:]): (-[WebHTMLView pageUp:]): (-[WebHTMLView pageDown:]): (-[WebHTMLView pageUpAndModifySelection:]): (-[WebHTMLView pageDownAndModifySelection:]): (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectParagraph:]): (-[WebHTMLView selectLine:]): (-[WebHTMLView selectSentence:]): (-[WebHTMLView selectWord:]): (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): (-[WebHTMLView _toggleBold]): (-[WebHTMLView _toggleItalic]): (-[WebHTMLView pasteFont:]): (-[WebHTMLView changeFont:]): (-[WebHTMLView changeAttributes:]): (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): (-[WebHTMLView changeColor:]): (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): (-[WebHTMLView alignCenter:]): (-[WebHTMLView alignJustified:]): (-[WebHTMLView alignLeft:]): (-[WebHTMLView alignRight:]): (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]): (-[WebHTMLView deleteForward:]): (-[WebHTMLView deleteBackward:]): (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]): (-[WebHTMLView deleteToBeginningOfLine:]): (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToBeginningOfParagraph:]): (-[WebHTMLView deleteToEndOfParagraph:]): (-[WebHTMLView subscript:]): (-[WebHTMLView superscript:]): (-[WebHTMLView unscript:]): (-[WebHTMLView underline:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: (-[WebView setTypingStyle:]): (-[WebView applyStyle:]):
17:34 WikiStart edited by pewtermoose@gmail.com
Add link to Web Inspector (diff)
17:33 Web Inspector created by pewtermoose@gmail.com
17:18 Coding Style Guidelines edited by bdash@webkit.org
(diff)
17:13 Coding Style Guidelines edited by sam@webkit.org
Add ToC (diff)
17:12 Coding Style Guidelines edited by sam@webkit.org
(diff)
17:02 Nightly Builds edited by bdash@webkit.org
(diff)
17:01 WikiStart edited by bdash@webkit.org
Remove outdated link (diff)
16:52 Coding Style Guidelines edited by sam@webkit.org
Finish port of Coding Style Guidelines (diff)
16:52 Changeset [17650] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Changed the check for "top level frame" to something much more valid

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
16:25 Coding Style Guidelines edited by sam@webkit.org
More Code Style Guidlines porting (diff)
16:21 Changeset [22487] by andersca
  • 8 edits in branches/WindowsMerge

WebCoreWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Let the Frame client know when the window object is available.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::partClearedInBegin):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::markMisspellings): (FrameWin::restoreDocumentState):

WebKitWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Call IWebFrameLoadDelegate::windowScriptObject available when the
window script object is available.


  • Interfaces/IWebFrameLoadDelegate.idl: Get MIDL to understand the JSC API types.


  • WebFrame.cpp: (WebFrame::windowScriptObjectAvailable): Call into the delegate.


  • WebFrame.h:
16:06 Coding Style Guidelines created by sam@webkit.org
First wack at transfering Style Guildlines to the Wiki
15:52 Changeset [17649] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Initialize cachedPrototype to 0.
15:42 Changeset [22486] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Remove no-longer-needed stub.
15:39 WikiStart edited by sam@webkit.org
(diff)
15:05 Applications using WebKit edited by bradley.morrison@nokia.com
added web browser for s60 (diff)
14:44 Changeset [17648] by harrison
  • 4 edits in trunk/LayoutTests

Updated.


  • editing/pasteboard/4076267-2-expected.checksum:
  • editing/pasteboard/4076267-2-expected.png:
  • editing/pasteboard/4076267-2-expected.txt:
14:24 Changeset [17647] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt (yesterday).

Here is part of my patch from yesterday that is safe to roll back
in. It will make the BuildBot happy.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.
13:07 Changeset [17646] by darin
  • 2 edits in trunk/WebCore
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Comment grammar fix.
13:05 Changeset [17645] by darin
  • 6 edits
    6 deletes in trunk

LayoutTests:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

WebCore:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

12:41 Changeset [17644] by darin
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Brady.

  • fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher crashes on launch in WebCore::ResourceLoader::start

No layout test, because this depends on cached icons, although there's
perhaps a way to write a test for it with some further ingenuity.

  • loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable to make explicit the fact that it can't be successfully copied. Remove notifyIconChanged function and put the contents in the caller. This eliminates the need for IconLoaderMac.mm. Added finishedLoading and clearLoadingState functions to share code. Removed m_url, since the resource handle already stores the URL. Renamed m_resourceLoader to m_handle to reflect the class's name change. Removed the 4096-byte inline buffer from m_data, since the malloc savings is not sufficient to offset the additional memory use. Removed m_httpStatusCode because we can instead cancel the load when we get a status code that reflects failure. Added m_loadIsInProgress boolean because we need to detect loads that complete during the ResourceHandle::create function call.
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress. Don't initialize m_httpStatusCode. (WebCore::IconLoader::~IconLoader): Updated for name change. (WebCore::IconLoader::startLoading): Added code to use the m_loadIsInProgress flag to detect if the load completed while inside the ResourceHandle::create function. Removed code to set m_url. (WebCore::IconLoader::stopLoading): Call clearLoadingState to share more code. (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle and finish loading if the HTTP status code indicates failure. (WebCore::IconLoader::didReceiveData): Removed assertion that checks the ResourceHandle, since we can't do that any more. (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading so we can share code with the new didReceiveResponse code path. (WebCore::IconLoader::finishLoading): Moved code here from the didFinishLoading callback. Pass a URL when calling commitIconURLToIconDatabase. Call notifyIconChanged directly here instead of using a separate function. Call clearLoadingState to share more code with stopLoading. (WebCore::IconLoader::clearLoadingState): Added.
  • loader/mac/IconLoaderMac.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
11:32 Changeset [17643] by harrison
  • 12 edits
    1 delete in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt:

WebCore:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt: Updated because pasting text with no newlines does not use intermediate div.


  • editing/markup.cpp: (WebCore::fillContainerFromString): First parameter is now a Container so a fragment can be passed.


(WebCore::createFragmentFromText):
A string with no newlines gets added inline, rather than being put into a paragraph.

10:39 Changeset [17642] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

2006-11-07 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

Test for http://bugs.webkit.org/show_bug.cgi?id=11505
REGRESSION: Null pointer deref in HitTestResult::spellingToolTip() (assertion failure in Node::document)

The null check was added as part for the fix for <rdar://problem/4820814>,
however the test that was committed with the fix avoids the case of a null
m_innerNonSharedNode, which this test covers.

  • fast/css-generated-content/spellingToolTip-assert-expected.checksum: Added.
  • fast/css-generated-content/spellingToolTip-assert-expected.png: Added.
  • fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
  • fast/css-generated-content/spellingToolTip-assert.html: Added.
02:47 Changeset [17641] by bdash
  • 2 edits in trunk/WebKitSite

2006-11-07 Mark Rowe <bdash@webkit.org>

Reviewed by Dave Hyatt.

  • projects/javascript/index.html: Update link to non-existent JavaScript Bugzilla component to the correct JavaScriptCore.
00:36 Changeset [22485] by sfalken
  • 4 edits in branches/WindowsMerge

11/06/06:

23:40 Changeset [22484] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Geoff.


Export JavaScriptCore C API via WebKit.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
23:15 Changeset [17640] by bdakin
  • 6 edits
    6 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The bug here is that the source of the iframe is only a comment,
and we were not properly constructing the frame because it was
sort-of empty but not.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if it is a comment node.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): if n is a comment node and there is no head, we create a head, insert in the document, and add the comment node as a child. This is what Firefox does too.
  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safe-guard for the fix. It is possible to get a mouse event without a target node, so we null check it. (Of course, in the case of this bug, it should not have been null, but it is a good thing to check for anyway.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.

Layout Tests:

Reviewed by Hyatt.

Test for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

  • fast/frames/onlyCommentInIFrame-expected.checksum: Added.
  • fast/frames/onlyCommentInIFrame-expected.png: Added.
  • fast/frames/onlyCommentInIFrame-expected.txt: Added.
  • fast/frames/onlyCommentInIFrame.html: Added.
  • fast/frames/resources/comment.html: Added.
  • fast/frames/resources/commentX.xhtml: Added.
21:42 Changeset [17639] by ggaren
  • 13 edits in trunk/LayoutTests

New results. The originals were incorrect.

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
21:27 Changeset [22483] by kmccullo
  • 4 edits in branches/WindowsMerge

WebCoreWin:

-Fix test fields accepting text.

  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

-Fix test fields accepting text.

  • WebKit.vcproj/WebKit.vcproj:
19:32 Changeset [17638] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/4641880-1-expected.checksum: Added.
  • editing/execCommand/4641880-1-expected.png: Added.
  • editing/execCommand/4641880-1-expected.txt: Added.
  • editing/execCommand/4641880-1.html: Added.
  • editing/execCommand/4641880-2-expected.checksum: Added.
  • editing/execCommand/4641880-2-expected.png: Added.
  • editing/execCommand/4641880-2-expected.txt: Added.
  • editing/execCommand/4641880-2.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4641880>
Setting bullets to existing text grabs subsequent paragraph


When a selection ends at the start of a paragraph, we rarely paint
the selection gap before that paragraph, because there often is no gap.
In a case like this, it's not obvious to the user that the selection
ends "inside" that paragraph, so it would be confusing if
InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.


  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Moved the check for editability of the selection to a more appropriate place. Change the endingSelection if it ends at the start of a paragraph.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::doApply): Ditto.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Ditto.
19:25 Changeset [17637] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sarge

<rdar://problem/4822911> - ASSERTION was a little overzealous.
Toned it down a bit.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading): Toned down assertion
18:34 Changeset [22482] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/4778180>
wikipedia.org crashes when loading


  • platform/win/GlyphMapWin.cpp: (WebCore::GlyphMap::fillPage): Don't call GetGlyphIndices on buffers larger than the page size. GetGlyphIndicies doesn't know anything about Unicode supplementary characters and will overwrite the local buffer if the passed-in buffer is bigger than the page size.
18:33 Changeset [22481] by andersca
  • 1 edit
    1 add in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <acarlsson@apple.com>

Fork GlyphMapWin.cpp


  • platform/win/GlyphMapWin.cpp: Added. (WebCore::GlyphMap::fillPage):
17:48 Changeset [22480] by ggaren
  • 2 edits
    2 adds in branches/WindowsMerge/WebKitWin

Oops. Forgot to add these files.


Changed comment that Darin mentioned, too.

  • WebChromeClient.cpp:
  • WebScreenClient.cpp: Added. (WebScreenClient::create): (WebScreenClient::WebScreenClient): (WebScreenClient::depth): (WebScreenClient::depthPerComponent): (WebScreenClient::isMonochrome): (WebScreenClient::rect): (WebScreenClient::usableRect):
  • WebScreenClient.h: Added.
17:09 Changeset [17636] by bdash
  • 14 edits
    1 add in trunk

2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Remove warning about garbage after #else. #else clause applies for all
non-mac platforms, not only win.

  • kjs/date_object.cpp:

2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk build fixes.

  • loader/icon/IconDatabase.cpp:
  • loader/icon/SQLStatement.h:
  • platform/gdk/ChromeClientGdk.h: Added. (WebCore::ChromeClientGdk::~ChromeClientGdk):
  • platform/gdk/CursorGdk.cpp: (WebCore::pointerCursor):
  • platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/FrameGdk.h: (WebCore::FrameGdk::client):
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/ScreenGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp: (Slider::focusPolicy): (WebCore::ServeSynchronousRequest): (FrameGdk::goBackOrForward): (FrameGdk::getHistoryLength): (FrameGdk::historyURL): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (WebCore::systemBeep): (WebCore::CachedResource::setPlatformResponse): (Path::transform): (ResourceLoader::loadsBlocked): (IconLoader::notifyIconChanged):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add):

2006-11-06 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\gdk build fixes.

  • GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (main):
17:08 Changeset [17635] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

64-bit build fix, take two.

17:04 Changeset [17634] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

Build fix for 64-bit.

16:56 Changeset [17633] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Darin.


Accidentally rolled out this change when removing the WebPageBridge. Now
putting it back.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):
16:47 S60Buzilla created by bradley.morrison@nokia.com
initial revision
16:30 Changeset [17632] by ggaren
  • 2 edits in trunk/WebCore

build fix.


  • WebCore.xcodeproj/project.pbxproj:
16:29 S60Webkit edited by bradley.morrison@nokia.com
minor type fixed (diff)
16:26 S60Reindeer created by bradley.morrison@nokia.com
16:01 Changeset [22479] by ggaren
  • 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Hooked up the Chrome and Screen clients on Windows.


  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin.


Stubbed out the Chrome and Screen clients.

  • WebChromeClient.cpp: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): (WebChromeClient::pageRect): (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createWindow): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
  • WebChromeClient.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
15:56 Changeset [17631] by ggaren
  • 38 edits
    6 adds
    8 deletes in trunk

WebCore:

Reviewed by Maciej, Anders, Darin.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
Fixed a minor where WebCore would always assume it was displayed on the
monitor containing the menubar. window.open and window.showModalDialog
are now cross-platform.


Layout tests, manual-tests/show-modal-dialog, and manual-tests/
window-open-features-parsing all pass. I verified the new screen functionality
by running in DRT, and checking whether WebCore knew it was off-screen.


Some refactoring remains, as all were not pleased by this design. I see
in my future another patch.

  • bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a client, to encapsulate asking the platform questions about the screen occupied by the page. (Previously, we always assumed we were on screen 0, which was a bug.)
  • bridge/mac/WebCoreFrameBridge.mm: (createMouseEventFromDraggingInfo): Reversed argument order, to match other functions. (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
  • bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
  • bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
  • bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
  • bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
  • manual-tests/window-open-features-parsing.html: Updated for accuracy. (In this case, neither size nor position is specified, so you should get the default window size and position.)
  • page/Screen.cpp: Added. Includes screen-related helper functions used in WebCore and WebKit.
  • platform/PlatformMouseEvent.h: Exported common code so it doesn't have to be duplicated. Renamed "position" to "point" since both were used, and "point" seemed clearer.
  • platform/Screen.h: Removed. Dead Code.
  • platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge initialization.

WebKit:

Reviewed by Maciej, Darin, Anders.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.


(WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
about its own dimensions. The idea here is that we're asking the Chrome how
much space it has devoted to the page. We have API for this (-webViewContentRect), but
it was documented incorrectly (even Safari used it wrong), so we don't use
it anymore. Once we fix our API/documentation, we can return to making a
delegate callback to ask for the page's size.
(WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of making up its own.
(WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of broken out parcels.

  • WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
  • WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
  • WebCoreSupport/WebScreenClient.h: Added.
  • WebCoreSupport/WebScreenClient.mm: Added.
  • WebView/WebView.mm: Added NULL checks for new _private->page, since it's not NULL-safe like the bridge was, and it gets cleared before dealloc.
15:36 S60CheckoutAndBuild created by bradley.morrison@nokia.com
15:09 S60ConfigureComputer created by bradley.morrison@nokia.com
14:44 Changeset [17630] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-06 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Enable toolbar capability support
http://bugs.webkit.org/show_bug.cgi?id=11528

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
14:44 Changeset [17629] by gdennis
  • 13 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref


No layout tests added as this must be tested manually by the test
WebCore/manual-tests/contenteditable-link.html

  • WebCore.exp: Exported HitTestResult::isLiveLink().
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::isLiveLink):
  • html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable to track shift key status.
  • manual-tests/contenteditable-link.html: Added description about link dragging behaviour.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isLiveLink): Added.
  • rendering/HitTestResult.h:

WebKit:

Reviewed by Tim Hatcher.

Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to WebHTMLView's _mayStartDragAtEventLocation
  • Misc/WebElementDictionary.m: added isLiveLink (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isLiveLink]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should only be followed if isLiveLink is true (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not a move (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: added WebElementLinkIsLiveKey
  • WebView/WebViewPrivate.h: ditto
14:43 BuildBot edited by bdash@webkit.org
Update some links and stuff (diff)
14:43 Changeset [17628] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-06 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (Sachin.Padma@nokia.com).
DESC: Enable toolbar capability
http://bugs.webkit.org/show_bug.cgi?id=11528

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
14:42 BuildBot edited by bdash@webkit.org
Update Twisted download instructions (diff)
14:39 BuildBot edited by bdash@webkit.org
Import of BuildBot instrutions (diff)
14:37 BuildBot created by bdash@webkit.org
Import of BuildBot instrutions
14:36 S60Webkit edited by bradley.morrison@nokia.com
(diff)
14:30 S60Webkit edited by bradley.morrison@nokia.com
(diff)
14:30 S60Webkit edited by bradley.morrison@nokia.com
(diff)
14:05 S60Webkit created by bradley.morrison@nokia.com
13:23 Changeset [17627] by thatcher
  • 6 edits in trunk/WebKitSite

Reviewed by Anders.

Update the site with new wiki and Trac links.

  • blog/wp-content/themes/webkit/sidebar.php:
  • building/build.html:
  • index.html:
  • nav.inc:
  • projects/svg/index.html:
13:03 Changeset [17626] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Oliver

Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
For now, we have to not load favicons when we have no Document - linking directly
to PDFs being the common case

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): Check for the document and return if none
13:00 Changeset [22478] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Oops! Silly mistake!

  • WebElementPropertyBag.cpp: (convertStringToVariant):
12:56 Changeset [22477] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <sfalken@apple.com>

Fix build

  • WebMutableURLRequest.cpp:
12:20 Changeset [17625] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-06 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: Place curet under the cursor position when activating an input box
http://bugs.webkit.org/show_bug.cgi?id=11533

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):
12:14 Changeset [17624] by spadma
  • 4 edits in S60/trunk/WebKit

2006-11-06 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] Remove toolbar in touch environment
http://bugs.webkit.org/show_bug.cgi?id=11527

  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
11:27 Changeset [17623] by oliver
  • 1 edit
    4 moves
    12 adds in trunk/LayoutTests

2006-11-06 Oliver Hunt <oliver@apple.com>

Reviewed by Mitz.

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
11:05 Changeset [17622] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/4801066>
Added a critical null frameLoader() check

  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow):
10:26 Changeset [22476] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Copy npfunctions.h to WebKitOutputDir.


  • WebCore.vcproj/WebCore.vcproj:
10:08 Changeset [17621] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

  • editing/deleting/delete-br-012-expected.checksum: Added.
  • editing/deleting/delete-br-012-expected.png: Added.
  • editing/deleting/delete-br-012-expected.txt: Added.
  • editing/deleting/delete-br-012.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

Test:

  • editing/deleting/delete-br-012.html


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Update m_endingPosition when preventing merge. Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
09:47 Changeset [17620] by ap
  • 2 edits in trunk/WebKitTools

Build fix, approved in principle by Tim H.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Disable deprecated warnings for main.c (TestNetscapePlugin), as it now uses QuickDraw to convert mouse event coordinates.
09:08 Changeset [17619] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
http://bugs.webkit.org/show_bug.cgi?id=11525

  • Drosera/debugger.js: imporved the function name code
07:55 Changeset [22475] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Steve Falkenburg <sfalken@apple.com>

Fix double-include of FormData.cpp/.h.

  • WebCore.vcproj/WebCore.vcproj:
06:19 Changeset [17618] by ap
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.

  • css2.1/t0905-c414-flt-00-d-expected.checksum:
  • css2.1/t0905-c414-flt-00-d-expected.png:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-00-d.html:
05:08 Changeset [17617] by ap
  • 5 edits in trunk

Reviewed by Maciej.

Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
being attributed to the next test.

WebKitTools:

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):

LayoutTests:

Removed leftover results from the previous test.

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
05:03 Changeset [17616] by bdash
  • 3 edits in trunk/LayoutTests

2006-11-07 Mark Rowe <bdash@webkit.org>

http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Correctly updated tests results.

  • fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
  • fast/dom/HTMLMetaElement/meta-attributes.html:
04:54 Changeset [17615] by bdash
  • 17 edits in trunk

2006-11-06 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Update DOMNode::toString to always use className rather than preferring nodeName.

  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::toString): Match the format returned by valueOf.

2006-11-06 Mark Rowe <bdash@webkit.org>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Updated test results for change from nodeName to className in DOMNode::toString.

  • fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/replace-first-child-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/input-appearance-preventDefault-expected.checksum:
  • fast/forms/input-appearance-preventDefault-expected.png:
  • fast/forms/input-appearance-preventDefault-expected.txt:
  • fast/loader/loadInProgress-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.checksum:
  • fast/tokenizer/external-script-document-write-expected.png:
  • fast/tokenizer/external-script-document-write-expected.txt:
  • traversal/stay-within-root-expected.checksum:
  • traversal/stay-within-root-expected.png:
  • traversal/stay-within-root-expected.txt:
04:36 Changeset [22474] by mjs
  • 2 edits in branches/WindowsMerge/WebCore
  • build fixes, adjusted for file move
  • WebCore.vcproj/WebCore.vcproj:
03:08 Changeset [17614] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-06 Mark Rowe <bdash@webkit.org>

Reviewed by Alexey.

Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.

  • Scripts/run-webkit-tests: import the POSIX module.
02:57 Changeset [17613] by bdash
  • 1 edit in trunk/WebKit/WebCoreSupport/WebFrameBridge.mm

Clean build fix after r17607: removed obselete header include.

01:16 Changeset [17612] by oliver
  • 2 edits in trunk/WebCore

2006-11-06 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

Fix RTL text in SVG to have correct positioning

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
00:43 Changeset [17611] by ap
  • 7 edits
    2 adds in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11517
REGRESSION: Flash clicks/interactivity not working properly

WebCore:

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): Restore parts of event dispatching that were removed when fixing bug 7323 - just bypass those for subframes.

WebKitTools:

Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:

<embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
<script>

plg.eventLoggingEnabled = true;
use eventSender to simulate events...

</script>

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginSetProperty): (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_HandleEvent):

LayoutTests:

  • plugins/mouse-events-expected.txt: Added.
  • plugins/mouse-events.html: Added.
00:30 Changeset [17610] by bdash
  • 3 edits
    3 adds in trunk

2006-11-06 Mark Rowe <bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Use ToString operator on each element rather than calling their toString method.

2006-11-06 Mark Rowe <bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

Test for http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

  • fast/js/array-join-bug-11524-expected.txt: Added.
  • fast/js/array-join-bug-11524.html: Added.
  • fast/js/resources/array-join-bug-11524.js: Added.

11/05/06:

23:03 Changeset [22473] by bdakin
  • 8 edits
    2 adds in branches/WindowsMerge

WebKit:

Reviewed by Steve and Anders. And sort of Maciej.

Here is a basic implementation of elementAtPoint for Boomer.

  • Interfaces/IWebView.idl: The definitions of the WebElementPropertyBag keys.
  • MarshallingHelpers.cpp: (MarshallingHelpers::intRectToSafeArray): New safe array creation function that creates a safe array out of an IntRect.
  • MarshallingHelpers.h:
  • WebElementPropertyBag.cpp: Added. This is the equivalent of WebElementDictionary on the Mac. (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::QueryInterface): (WebElementPropertyBag::AddRef): (WebElementPropertyBag::Release): (isEqual): (convertStringToVariant): (WebElementPropertyBag::Read): This is the bulk of the class. It compares the input key to all of the possible keys and calls the appropriate function for each. (WebElementPropertyBag::Write): Writing is not actually allowed.
  • WebElementPropertyBag.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::elementAtPoint): Call into frame to get the HitTestResult for the point and set elementDictionary to the WebElementPropertyBag for the result.

WebCore:

Reviewed by Steve and Anders.

Add client() fucntion to FrameWin to return the FrameClient.

  • bridge/win/FrameWin.h: (WebCore::FrameWin::client):
22:05 Changeset [17609] by darin
  • 14 edits in trunk/WebCore
  • quick attempt to fix the no-SVG build
  • platform/graphics/svg/SVGResource.cpp:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceImage.h:
  • platform/graphics/svg/SVGResourceMarker.cpp:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.cpp:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.h:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added #ifdef SVG_SUPPORT to these files.
19:38 Changeset [22472] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <sfalken@apple.com>

Fix build

  • WebCore.vcproj/WebCore.vcproj:
19:15 Changeset [17608] by mjs
  • 2 edits in trunk/WebCore

Reviewed & landed by Maciej.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11265

  • platform/win/ResourceLoaderWin.cpp: (WebCore::transferJobStatusCallback): (WebCore::ResourceLoader::start):
18:55 Changeset [17607] by mjs
  • 8 edits
    4 moves in trunk

WebCore:

Reviewed by Oliver.

  • moved FormData and FormDataStream to platform/network directory
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/FormData.cpp: Removed.
  • loader/FormData.h: Removed.
  • loader/mac/FormDataStream.h: Removed.
  • loader/mac/FormDataStream.m: Removed.
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • platform/network/mac/FormDataStreamMac.h: Added.
  • platform/network/mac/FormDataStreamMac.mm: Added.
  • platform/network/mac/ResourceRequestMac.mm:

WebKit:

Reviewed by Oliver.


  • removed unneeded (and obsolete) header includes
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebFrame.mm:
16:04 Changeset [22471] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-05 Steve Falkenburg <sfalken@apple.com>

Fix build breaks

  • WebFrame.cpp:
  • WebFrame.h:
15:54 Changeset [22470] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <sfalken@apple.com>

Fix build breaks

  • bridge/win/FrameWin.cpp:
  • bridge/win/PageWin.cpp:
15:52 Changeset [17606] by sfalken
  • 3 edits in trunk/WebCore

2006-11-05 Steve Falkenburg <sfalken@apple.com>

Fix build breaks

  • loader/DocumentLoader.h:
  • platform/win/ScreenWin.cpp:
15:14 Changeset [17605] by darin
  • 3 edits in trunk/WebKit
  • WebKit part of Frame.h check-in (forgot to land it)
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]): (-[WebFrameBridge shouldInterruptJavaScript]): (-[WebFrameBridge saveDocumentState:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge getObjectCacheSize]): (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebFrameBridge mayStartDragAtEventLocation:]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge getAppletInView:]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge setIsSelected:forView:]):
14:02 Changeset [17604] by darin
  • 37 edits in trunk/WebCore

Reviewed by Geoff.

  • more preparation for splitting up Frame into sub-pieces
  • removed unnecessary includes from Frame.h
  • page/Frame.h: Removed unneeded includes and forward declarations. Added additional forward declarations. Removed the constant NoXPosForVerticalArrowNavigation, now moved inside SelectionController. Created sections of functions to be moved into Chrome, Editor, EventHandler, FrameLoader, SelectionController, and the Platform directory, as well as marking one function for deletion.
  • page/FramePrivate.h: Removed the definition of the constructor and destructor and removed unnecessary includes.
  • page/FrameView.h: Removed unneeded forward declarations and friend declarations. Created a section of functions and data to be moved into EventHandler.
  • bridge/mac/FrameMac.h: Removed unneeded forward declarations. Created sections of functions and data to be moved into Chrome, Editor, EventHandler, FrameLoader, and the Platform directory.
  • bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment. Removed unused methods areScrollbarsVisible, nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
  • page/Frame.cpp: (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have to include KURL.h just for the KURL default constructor. (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h. (WebCore::FramePrivate::~FramePrivate): Ditto.
  • page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf booleans, scrollbarMoved and cleared funcitons. (WebCore::FrameView::clear): Moved the code from the cleared function in here. (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated for changes to header.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): Moved NoXPosForVerticalArrowNavigation into this file.
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/WebCoreAXObject.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssstyleselector.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/EventTargetNode.cpp:
  • dom/MouseRelatedEvent.cpp:
  • dom/XMLTokenizer.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLTokenizer.cpp:
  • loader/mac/FrameLoaderMac.mm:
  • page/PageState.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderTreeAsText.cpp:
  • xml/XSLTProcessor.cpp: Added includes as needed to keep compiling, since there are fewer includes in Frame.h.
00:36 Changeset [17603] by ap
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

http://bugs.webkit.org/show_bug.cgi?id=11402
REGRESSION: onChange does not work anymore for 1st item in popup

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::reset): Set m_lastOnChangeIndex to -1.

11/04/06:

22:16 Changeset [17602] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11521
Bug 11521: [Drosera] Breakpoint editor UI behaves incorrectly when multiple editors are open

  • Drosera/debugger.js: Use . instead of so that it doesn't root the search at the document.
22:14 Changeset [17601] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11513
Bug 11513: [Drosera] Function popup fails to appear when clicking supposedly valid areas.

  • Drosera/debugger.css: Stick a min-width on the menu to keep it from becoming smaller than the control.
22:12 Changeset [17600] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11512
Bug 11512: [Drosera] Scrolling via keyboard breaks after clicking in function popup.

  • Drosera/debugger.js: blur() the function popup when we're done with it.
17:24 Changeset [22469] by darin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Updated for change of const Event* to Event*. (WebCore::FrameWin::submitForm): Added Event* parameter.

WebKitWin:

  • WebView.cpp: (WebView::initWithFrame): Removed setMainFrame call and deref of Frame, now handled by Frame's constructor.
17:16 Changeset [17599] by darin
  • 1 edit in trunk/WebCore/ChangeLog

s

17:16 Changeset [17598] by darin
  • 2 edits in trunk/WebCore

Reviewed by Ander.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): Removed call to cancel. Since the subresource owns the resource handle, there's no need to cancel. This arrangement is only temporary, anyway, since Maciej will soon change things so that the subresource loader uses the resource handle and the resource handle doesn't know anything about the subresource loader.
17:06 Changeset [17597] by darin
  • 84 edits
    1 delete in trunk

WebCore:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

converted most uses of NSURL to KURL and NSEvent to DOM Event in
loader classes

moved download function out of FrameLoader.h to avoid reference to
NSURLConnection

added DOM Event parameters to various functions so that the handlers
can use the DOM Event instead of the global "current NSEvent";
includes Frame::submitForm, HTMLFormElement::prepareSubmit,
HTMLFormElement::submit, FrameLoader::load

moved the setMainFrame call that hands ownership to the Page
into one of the Frame constructors, and removed it from all
the clients

removed const from Event parameter to the urlSelected function
(we rarely use const with DOM elements)

removed some redundant includes and declarations from various
header files

removed NSURL parameter from userAgent function -- if we need it we
can add it back, but converting from NSURL to KURL and back is
inefficient enough that it's best to have it out for now (since it's
been unused for years) -- if we add it back, we can choose an
appropriate parameter type that's always inexpensive to pass

did some basic cleanup in the IconLoader class, including removing
an unnecessary loop that added icon data a byte at a time

renamed safeLoad to load, since it's no different from the other
FrameLoader load functions, safety-wise

fixed some code that was trying to distinguish null frame name from
empty string frame name -- both should be handled the same, but callers
were doing it by checking for empty and turning it into null (in a way
that was causing extra round trips between NSString and WebCore::String)

corrected all uses of "get" and "post" to be uppercase "GET" and "POST"
and got rid of case-insensitive compares of methods

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::urlSelected): (WebCore::FrameMac::userAgent):
  • bridge/mac/FrameViewMac.mm:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • bridge/mac/WebCoreSettings.mm:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
  • bridge/win/FrameWin.h:
  • dom/MouseRelatedEvent.cpp:
  • dom/MouseRelatedEvent.h:
  • dom/UIEvent.cpp: (WebCore::UIEvent::~UIEvent):
  • dom/UIEvent.h:
  • dom/UIEventWithKeyState.h:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/NavigationAction.h: (WebCore::NavigationAction::event):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::create): (WebCore::IconLoader::startLoading): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::notifyIconChanged): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/IconLoaderMac.mm: (WebCore::IconLoader::notifyIconChanged):
  • loader/mac/LoaderFunctionsMac.mm:
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::shouldLoadAsEmptyDocument): (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/mac/NavigationActionMac.mm: (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/mac/ResourceLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::urlSelected): (WebCore::Frame::submitFormAgain): (WebCore::Frame::submitForm): (WebCore::Frame::endIfNotLoading): (WebCore::Frame::hitTestResultAtPoint):
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/mac/TextFieldMac.mm:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/mac/ResourceResponseMac.h:
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
  • platform/network/win/ResourceHandleWin.cpp:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
  • platform/qt/FrameQt.h:
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::returnPressed):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp:

WebKit:

Reviewed by Maciej.

  • converted more of the loader machinery to work with cross-platform data structures instead of Macintosh-specific ones

store the computed user agent string as a WebCore::String instead
of an NSString to avoid overhead converting it every time we get it

  • COM/WebFrame.cpp: (WebFrame::initWithName):
  • ChangeLog:
  • Misc/WebElementDictionary.m: (-[WebElementDictionary _image]): (-[WebElementDictionary _targetWebFrame]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent): (WebFrameLoaderClient::actionDictionary):
  • WebCoreSupport/WebPageBridge.mm: (WebCore::if):
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]): (-[WebDataSource _URLForHistory]): (-[WebDataSource unreachableURL]):
  • WebView/WebHTMLView.m: (-[WebHTMLView elementAtPoint:allowShadowContent:]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): (-[WebPDFView _path]):
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebViewPrivate finalize]): (-[WebView _preferencesChangedNotification:]): (-[WebView _cachedResponseForURL:]): (-[WebView setApplicationNameForUserAgent:]): (-[WebView setCustomUserAgent:]): (-[WebView customUserAgent]): (-[WebView userAgentForURL:]): (-[WebView _computeUserAgent]): (-[WebView WebCore::]):
  • WebView/WebViewInternal.h:
17:02 Changeset [17596] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-04 Mark Rowe <bdash@webkit.org>

Reviewed by Darin.

Fix use of uninitialized value in pattern match.

  • Scripts/webkitdirs.pm:
16:23 Changeset [22468] by mjs
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.vcproj/WebCore.vcproj: Added new files
  • platform/win/TemporaryLinkStubs.cpp: Removed unneeded link stubs

WebKitWin:

Reviewed by Adele.


  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebFrame.cpp: (WebFrame::willSendRequest): Rearranged from former receivedRedirect.
  • WebFrame.h:
16:15 Changeset [17595] by mjs
  • 24 edits
    2 copies
    4 adds in trunk/WebCore

Reviewed by Adele.

  • replaced receivedRedirect with new willSendRequest delegate
  • removed most mac-specific loader functions
  • use ResourceResponse more in loader code
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): Adapted for CachedResource method renames. (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]): Ditto.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify): simplified based on ResourceResponse
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): adapt for ResourceResponse
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): store a ResourceResponse; platform response is now called platformResponse and expiration date is removed. (WebCore::CachedResource::~CachedResource): ditto (WebCore::CachedResource::isExpired): ditto
  • loader/CachedResource.h: (WebCore::CachedResource::platformResponse): ditto (WebCore::CachedResource::setResponse): ditto (WebCore::CachedResource::canDelete): ditto
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): Adjusted for renames. (WebCore::Loader::didReceiveResponse): Store whole ResourceResponse in the CachedResource.
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::getStreamFormDatas): Rearranged things so it's possible to get a FormData back out of a form data stream. (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::httpBodyFromStream): ditto
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad): s/response/platformResponse/
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): ditto (WebCore::CachedResource::setPlatformResponse): ditto
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): send redirect to client appropriately
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): new entry point for SubresourceLoader, dispatch to client.
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::allowHTTPCookies): implemented (WebCore::ResourceRequest::setAllowHTTPCookies): ditto
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): initialize expiration date(!)
  • platform/network/cf/FormDataStreamCFNet.cpp: Added. (WebCore::getStreamFormDatas): Added this, ported from NSURL version. (WebCore::openNextStream): ditto (WebCore::formCreate): ditto (WebCore::formFinalize): ditto (WebCore::formCanRead): ditto (WebCore::formEventCallback): ditto (WebCore::setHTTPBody): ditto (WebCore::httpBodyFromStream): ditto
  • platform/network/cf/FormDataStreamCFNet.h: Added.
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): implemented (WebCore::ResourceHandle::start): use new ResourceRequest stuff
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): do nothing for a null response
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): Implemented; dispatch to client.
  • platform/network/mac/ResourceRequestMac.h: Added.
  • platform/network/mac/ResourceRequestMac.mm: Added. (WebCore::getResourceRequest): Added way to convert an NSURLRequest to a ResourceRequest. (WebCore::nsURLRequest): Opposite of the above.
  • platform/network/cf/ResourceRequestCFNet.h: Added.
  • platform/network/cf/ResourceRequestCFNet.cpp: Added. (WebCore::getResourceRequest): Added way to convert an CFURLRequest to a ResourceRequest. (WebCore::cfURLRequest): Opposite of the above.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::willSendRequest): Renamed from receivedRedirect, adjusted.
  • xml/xmlhttprequest.h:
09:54 Changeset [17594] by darin
  • 2 edits in trunk/WebCore

Change suggested by Mitz.

  • bridge/mac/WebCorePageState.mm: (-[WebCorePageState dealloc]): Add null check. (-[WebCorePageState finalize]): Ditto.
09:53 Changeset [17593] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/webkitdirs.pm: Don't try to use the Xcode build setting if it's project-relative.
07:51 Changeset [17592] by ap
  • 16 edits
    3 adds in trunk

2006-11-04 Bertrand Guiheneuf <guiheneuf@gmail.com>

Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).

http://bugs.webkit.org/show_bug.cgi?id=11433
Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths Created platform/graphics and platform/network filters in hierarchy Moved GraphicsContext and GraphicsTypes to their respective filters Added EditorClient.h Added FrameLoader* files in loader/ Added HitTest* files in rendering/ Added Editor.* files in editing/ Added DeleteButton.* and DeleteButtonController.* in editing/
  • bridge/win/ChromeClientWin.h: Added. (WebCore::ChromeClientWin::~ChromeClientWin):
  • bridge/win/EditorClientWin.h: Added. (WebCore::EditorClientWin::~EditorClientWin):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h: Added EditorClient parameter to constructor Replace usage of FrameLoadRequest::m_request with FrameLoadRequest::resourceRequest() Removed openURL() and openURLRequest from class definition
  • bridge/win/PageWin.cpp:
  • platform/AffineTransform.h:
  • platform/cairo/AffineTransformCairo.cpp: Added. (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix): (WebCore::AffineTransform::map): (WebCore::AffineTransform::mapRect): (WebCore::AffineTransform::isIdentity): (WebCore::AffineTransform::m11): (WebCore::AffineTransform::m12): (WebCore::AffineTransform::m21): (WebCore::AffineTransform::m22): (WebCore::AffineTransform::dx): (WebCore::AffineTransform::dy): (WebCore::AffineTransform::reset): (WebCore::AffineTransform::scale): (WebCore::AffineTransform::rotate): (WebCore::AffineTransform::translate): (WebCore::AffineTransform::shear): (WebCore::AffineTransform::det): (WebCore::AffineTransform::invert): (WebCore::AffineTransform::operator cairo_matrix_t): (WebCore::AffineTransform::operator== ): (WebCore::AffineTransform::operator*= ): (WebCore::AffineTransform::operator* ):
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::goBackOrForward): (WebCore::FrameWin::getHistoryLength): (WebCore::FrameWin::historyURL): (WebCore::ServeSynchronousRequest): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::Path::transform): (WebCore::PopupMenu::updateFromElement): (WebCore::ResourceLoader::loadsBlocked): (WebCore::systemBeep):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::didReceiveData): (WebFrame::receivedAllData): Use resource handles now. Do not start doc loader by hand anymore. Handle didReceiveData() callback instead of receivedData() which is deprecated in implementation of ResourceHandleClient
  • COM/WebFrame.h:
  • COM/WebView.cpp: Applied ResourceLoader --> ResourceHandle renaming
  • WebKit.vcproj/WebKit.rc: Got rid of MFC dependencies (build fix for VCExpress).
  • WebKit.vcproj/WebKit.vcproj: Added platform/graphics platform/network and platform/network/win to headers search paths

11/03/06:

23:53 Changeset [17591] by ap
  • 5 edits
    2 adds
    2 deletes in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11448
&lang; and &rang; entities are mapped to the incorrect Unicode codepoint

WebCore:

  • html/HTMLEntityNames.gperf: Use canonical Unicode equivalents for these characters.

LayoutTests:

  • fast/parser/entities-in-xhtml-expected.checksum: Removed.
  • fast/parser/entities-in-xhtml-expected.png: Removed. Converted to plain text, the large table in the test didn't nearly fit anyway.
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/parser/entities-in-xhtml.xhtml: Made the test self-consistent again by using actual numeric values for &lang; and &rang;.
  • fast/parser/entities-in-html-expected.txt: Added.
  • fast/parser/entities-in-html.html: Added. An HTML copy of the same test.
22:14 Changeset [17590] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-03 David Smith <catfish.man@gmail.com>

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11510
Bug 11510: [Drosera] Doubleclicking the attach table should attach to the clicked item.

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication showAttachPanel:]): Set the doubleAction for the table view
22:03 Changeset [22467] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-03 Steve Falkenburg <sfalken@apple.com>

Fix build

  • config.h: Touched to cause re-build w/ SVG_SUPPORT enabled
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): Added
21:33 Changeset [17589] by bdash
  • 3 edits in trunk/WebCore

2006-11-03 Mark Rowe <bdash@webkit.org>

Reviewed by Oliver.

Update Windows and Qt project files for file removals in r17585.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
21:10 Changeset [17588] by bdash
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Maciej.

The patch fixes text field drawing on the Qt platform.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::paintTextField): Use the style to correctly render the text field
20:56 Applications using WebKit edited by bdash@webkit.org
Cleanup of formatting (diff)
20:39 WikiStart edited by bdash@webkit.org
A more useful start page, copied from the wiki:WebKit? page (diff)
20:38 WebKit plus SVG edited by bdash@webkit.org
Remove the majority of the page content as it is out of date (diff)
20:20 Changeset [17587] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-11-03 Steve Falkenburg <sfalken@apple.com>

Fix build

  • kjs/JSImmediate.h:
16:41 Changeset [17586] by oliver
  • 2 edits in trunk/WebCore

2006-11-03 Oliver Hunt <oliver@apple.com>

Reviewed by Tim.

Correct incorrect call to SetCursor

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
16:37 Changeset [22466] by adele
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
16:35 Changeset [17585] by adele
  • 8 edits
    4 deletes in trunk/WebCore

Reviewed by Oliver.

Removed DeprecatedRenderSelect and ListBox classes.

  • WebCore.xcodeproj/project.pbxproj:
  • css/html4.css:
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler): (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): (WebCore::HTMLSelectElement::updateListBoxSelection):
  • html/HTMLSelectElement.h:
  • platform/ListBox.h: Removed.
  • platform/mac/FontCacheMac.mm:
  • platform/mac/ListBoxMac.mm: Removed.
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/DeprecatedRenderSelect.cpp: Removed.
  • rendering/DeprecatedRenderSelect.h: Removed.
16:20 Changeset [17584] by mjs
  • 1 edit
    2 deletes in trunk/WebCore

Not reviewed, fix for accidental commit.

  • rolled back more of the accidentall commit that I forgot.
  • platform/network/mac/ResourceRequestMac.h: Removed.
  • platform/network/mac/ResourceRequestMac.mm: Removed.
16:09 Changeset [17583] by thatcher
  • 4 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=9596
Bug 9596: [Drosera] add a function popup to the source pane

  • Drosera/debugger.css: Added styles for function popup
  • Drosera/debugger.html: Added function popup button and select
  • Drosera/debugger.js: Added function popup functionality
14:28 Changeset [17582] by mjs
  • 22 edits in trunk/WebCore

Not reviewed, fix for accidental commit.

  • roll back some network changes accidentally committed with a previous patch.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::setExpireDate): (WebCore::CachedResource::isExpired):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse): (WebCore::Loader::didReceivedResponse):
  • loader/loader.h:
  • loader/mac/FormDataStream.h:
  • loader/mac/FormDataStream.m: (WebCore::formCreate): (WebCore::formFinalize):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): (WebCore::CachedResource::setResponse):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::receivedRedirect):
  • platform/network/ResourceRequest.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::redirectedToURL):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedRedirect):
  • xml/xmlhttprequest.h:
14:20 Changeset [22465] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Remove SVGRenderAsText files from the project.


  • WebCore.vcproj/WebCore.vcproj:
14:15 Changeset [17581] by andersca
  • 1 edit
    2 deletes in trunk/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Rubber-stamped by Oliver.

Remove these, they have been merged with SVGRenderTreeAsText.


  • rendering/SVGRenderAsText.cpp: Removed.
  • rendering/SVGRenderAsText.h: Removed.
14:12 Changeset [17580] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11504
Fix warnings on non 32 bit platforms

  • kjs/JSImmediate.h: (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::oneAsBits): Rewrite in a way that moves runtime checks to compile-time.

(KJS::):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):

13:55 Changeset [22464] by andersca
  • 4 edits in branches/WindowsMerge

WebCoreWin:

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setPlatformResponse):

WebKitWin:

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • WebChromeClient.cpp:


13:53 Changeset [17579] by andersca
  • 2 edits in trunk/WebCore

2006-11-03 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest):
13:05 Changeset [17578] by ggaren
  • 1 edit
    2 adds in trunk/WebKit

Forgot to add these two files. Oops.

  • WebCoreSupport/WebChromeClient.h: Added.
  • WebCoreSupport/WebChromeClient.mm: Added.
12:59 Changeset [22463] by ggaren
  • 7 edits
    5 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp:
  • loader/win/ResourceLoaderWin.cpp: Added. (WebCore::ResourceLoader::loadsBlocked):
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin, Beth.

Updated to use ChromeClient.


  • WebChromeClient.cpp: Added. (WebChromeClient::create): (WebChromeClient::WebChromeClient): (WebChromeClient::canRunModal): (WebChromeClient::runModal):
  • WebChromeClient.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
12:56 Changeset [17577] by ggaren
  • 15 edits
    3 adds in trunk

WebCore:

Reviewed by Darin, Beth.


First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • bridge/mac/PageMac.mm: Removed platform-specific constructor, added setBridge method to replace it. (WebCore::Page::setBridge):
  • bridge/mac/WebCorePageBridge.h: Simplified some things based on the fact that WebCorePageBridge.h doesn't need to be included by ObjC-only files, and, now that it uses PassRefPtr, can't be.


  • page/Chrome.cpp: Added. Code copied and converted to c++ from WebCorePageBridge.mm.
  • page/Page.h: (WebCore::Page::dragCaretController): Made this function non-const so that m_dragCaretController doesn't have to be mutable.

WebKit:

Reviewed by Darin, Beth.

First cut at factoring Page's UIDelegate-related functions into Chrome
and ChromeClient.

Layout tests pass.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebPageBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:02 Changeset [17576] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-01 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Use the EscapeUtils::EscapeDecodeL to remove escaped characters in the path.
http://bugs.webkit.org/show_bug.cgi?id=11348


  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::ParseFileNameLC):
10:58 Changeset [17575] by ap
  • 1 edit
    1 add in trunk/WebKitTools

2006-11-03 Michael Emmel <mike.emmel@gmail.com>

Reviewed by Maciej.


http://bugs.webkit.org/show_bug.cgi?id=9671

  • Scripts/wkstyle: Adds astyle sed script formats according to most of the style guidelines.
10:36 Changeset [17574] by ap
  • 19 edits
    5 adds in trunk

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=7323
REGRESSION (10.4.4): ondrag* events don't fire on page in a frame

WebCore:

  • bridge/mac/FrameMac.h: Moved drag source information to a static variable in FrameMac.mm. There can be only one drag active at any moment, and having this information here was making sharing this information between subframes hard.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Initialize sharedDragInfo. (WebCore::FrameMac::freeClipboard): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::dragSourceMovedTo): (WebCore::FrameMac::dragSourceEndedAt): (WebCore::FrameMac::dispatchDragSrcEvent): Access drag source info via sharedDragInfo - this fixes drag source even dispatching. Also removed some old code that was forwarding mouse events to subviews to make HTML editing work in subframes.
  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::cancelDragAndDrop): (WebCore::FrameView::performDragAndDrop): Forward events to subframes for dispatching - this fixes drag target events.

WebKitTools:

When dragging, do not send EventSendingController's events immediately. Dragging
is supposed to be modal, so we need to perform it from within the delegate, without
returning to JS to make the next mouse movement.

When the mouse is down, mouse events are now recorded, and executed when mouseUp is sent.

  • DumpRenderTree/EventSendingController.h:
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]): (+[EventSendingController saveEvent:]): (+[EventSendingController replaySavedEvents]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):

LayoutTests:

  • fast/events/drag-in-frames-expected.txt: Added.
  • fast/events/drag-in-frames.html: Added.
  • fast/events/resources/drag-in-frames-console.html: Added.
  • fast/events/resources/drag-in-frames-left.html: Added.
  • fast/events/resources/drag-in-frames-right.html: Added.
  • editing/selection/expanding-selections.html:
  • editing/selection/expanding-selections2.html:
  • fast/dynamic/layer-hit-test-crash.html:
  • fast/events/event-view-toString.html:
  • fast/events/resources/drag-outside-window-frame.html:
  • svg/custom/hover-default-fill.svg: Added missing calls to mouseUp().
  • svg/custom/stroke-width-click-expected.txt:
  • svg/custom/stroke-width-click.svg: Don't attempt to click outside the page, this was confusing DRT.
  • editing/selection/select-from-textfield-outwards-expected.txt:
  • editing/selection/select-from-textfield-outwards.html: Removed alerts between dragging steps - they are now useless, as the dragging events are stored and executed at once.
08:52 Changeset [17573] by staikos
  • 2 edits in trunk/WebCore

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Tim, landed by George.

Fixing compile.

  • platform/qt/LoaderFunctionsQt.cpp: (WebCore::CachedResource::setPlatformResponse): Renamed from setResponse
08:51 Changeset [17572] by ggaren
  • 12 edits in trunk/LayoutTests

Missed a few tests in my last check-in, and checked in old results for
others. Oops.


  • editing/inserting/before-after-input-element-expected.txt:
  • editing/inserting/before-after-input-element.html:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/input-field-1.html:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/pasteboard/select-element-1.html:
  • editing/selection/select-element-paragraph-boundary-expected.txt:
  • editing/selection/select-element-paragraph-boundary.html:
  • fast/forms/textarea-no-scroll-on-blur-expected.txt:
  • fast/forms/textarea-scrollbar-expected.txt:
08:20 Changeset [17571] by staikos
  • 3 edits
    1 add in trunk/WebCore

2006-11-01 Zack Rusin <zack@kde.org>

Reviewed by Maciej, landed by George.

Moving the word/sentence seperators into a file of their own
and implementing findWordBoundary.

  • CMakeLists.txt:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/qt/TextBoundaries.cpp: Added. (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):
07:34 Changeset [17570] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):


Merge from ccb r17569

07:29 Changeset [17569] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Gif image was not displayed on the page when it in body of multipart/mixed msg with wml file.
http://bugs.webkit.org/show_bug.cgi?id=11496

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::ResponseL):
07:24 Changeset [17568] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-02 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: TSW bug# VKRR-6PH9VQ : ResolveLink function is called with wrong parameters.
Set the current url on UrlRequest when user clicks on a link.
http://bugs.webkit.org/show_bug.cgi?id=11499

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
02:48 Changeset [17567] by staikos
  • 7 edits in trunk

2006-11-03 Zack Rusin <zack@kde.org>

Reviewed by Maciej, landed by George.

Compile on both KDE and Qt platforms

  • CMakeLists.txt: add zlib explicitly
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::self): (WebCore::QtJob::QtJob): (WebCore::QtJob::timerEvent): Integrate both implementations

so that moc can parse it

(WebCore::ResourceHandleManager::deliverJobData):
(WebCore::ResourceHandleManager::remove):

  • platform/network/qt/ResourceHandleManager.h:
02:01 Changeset [17566] by staikos
  • 2 edits in trunk/JavaScriptCore

2006-11-02 George Staikos <staikos@kde.org>

Reviewed by Maciej.

  • collector.cpp: Remove a deprecated pthreads call.
01:40 Changeset [17565] by mjs
  • 2 edits in trunk/WebCore

No review, suggested by Mitz.

  • fix a #if to be #ifdef
  • platform/graphics/svg/cg/SVGResourceImageCg.cpp:
01:33 Changeset [17564] by mjs
  • 3 edits in trunk/WebCore

Reviewed and landed by Maciej.


Compile on the Qt platform.

  • ksvg2/misc/KCanvasRenderingStyle.h:
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::getStylePainterAndWidgetFromPaintInfo):
01:28 Changeset [17563] by mjs
  • 27 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt. Landed by Maciej.

Adding setPlatformPen/setPlatformFont/setPlatformFillColor
to graphics context to be able to set consistant state
on the platform specific painter without having to change
fill/stroke/font on every operation. This fixes color/stroke/fill
and font handling in the Qt port.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setFillColor): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformFont):
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::toQPenStyle): (WebCore::penToQPen): (WebCore::TransparencyLayer::TransparencyLayer): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setPlatformFont): (WebCore::GraphicsContext::setPlatformPen): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
  • platform/qt/ScrollViewCanvasQt.h:
Note: See TracTimeline for information about the timeline view.