Timeline


and

11/11/06:

20:59 Changeset [22526] by ggaren

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/4831461> Crash in FrameLoader::~FrameLoader when navigating away from ebay.com
  • Changed WebKit clients to match new virtual ref/deref scheme in WebCore.
  • Removed WebEditorClient from the WebCore namespace because it's a WebKit class, not a WebCore class.
  • Standardized some header #includes to match Mac:
    • alphabetical
    • config.h, WebKitDLL.h, and class headers go together at the top
    • everything else comes after a line break
20:53 Changeset [17740] by ggaren

WebCore:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Fixed up function prototypes for style.
  • loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose was to implement an alternative ownership model. (WebCore::FrameLoader::~FrameLoader): Removed empty destructor. (WebCore::FrameLoader::setClient): This function now takes ownership (WebCore::FrameLoader::client):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/ChromeClient.h:
  • platform/AbstractShared.h: Added. This is the virtual function-based refcounting complement to Shared. (WebCore::AbstractShared::~AbstractShared):

WebKit:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::ref): (WebChromeClient::deref): (WebChromeClient::refCount):
  • WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes. The ones in WebCore make clear what remains to be implemented. Replaced constructor with factory function to avoid leaks.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::create): (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
  • WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory function to avoid leaks. (WebFrameLoaderClient::ref): (WebFrameLoaderClient::deref): (WebFrameLoaderClient::refCount):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::create):
  • WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
16:13 Changeset [17739] by staikos

Reviewed by Maciej.

Fix uninitialized variable.

  • rendering/RenderStyle.h:
14:54 Changeset [22525] by andersca

Remove conflict markers

14:50 Changeset [22524] by andersca

WebCoreWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Rename keyPress to keyEvent, it's used for both key presses
and releases.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • bridge/win/FrameWin.h:

WebKitWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Clean up the event handling code.


  • WebEditorClient.cpp: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::shouldApplyStyle): Change these to return true. Eventually they will call the editing delegate.


  • WebView.cpp: (WebView::execCommand): Update to call the editor's execCommand.


(WebView::keyUp):
New function that forwards the event to FrameWin.


(editCommandForKey):
New function that given a key returns an edit command from a table. Eventually this table
should be moved into WebCore.


(WebView::handleEditingKeyboardEvent):
New function that handles editing events.


(WebView::keyDown):
If the frame is editable, call handleEditingKeyboardEvent.


(WebViewWndProc):

  • WebView.h:
13:34 Changeset [17738] by aroben

Grammar fix.

13:32 Changeset [17737] by aroben

Reviewed/landed by Adam.

Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.

General style cleanup, remove all tabs etc.

  • CMakeLists.txt:
13:32 Changeset [17736] by ddkilzer

Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.

13:28 Changeset [17735] by ddkilzer

Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.

13:17 Changeset [22523] by aroben

WebCoreWin:

Reviewed by Geoff.

Move graphics-related files to platform/graphics to stay in sync with
changes from OpenSource r17727.

Also, as discussed with Darin and Steve, we now copy all our headers to
a flat include/WebCore directory instead of copying the directory
structure of WebCore. This mirrors how Mac builds.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/cg/ColorCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/win/IconWin.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.

WebKitWin:

Reviewed by Geoff.

Update WebCore #includes to use a flat directory structure.

  • DOMCSSClasses.cpp:
  • DOMCSSClasses.h:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebDataSource.cpp:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebHTMLRepresentation.cpp:
  • WebHistory.cpp:
  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
11:10 Changeset [17734] by andersca

Reviewed and landed by Anders.

Make DRT work again on Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
10:36 Changeset [17733] by ggaren

Reviewed by Maciej Stachowiak.


Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
10:08 Changeset [17732] by beidson

Reviewed by Maciej

Fixed header guard

  • loader/FrameLoaderClient.h:
08:52 Changeset [22522] by darin
  • blind attempt to fix the build
  • platform/win/CursorWin.cpp: (WebCore::verticalTextCursor): Added. Just returns the pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
08:48 Changeset [17731] by darin
  • attempt to fix Qt build
  • platform/qt/CursorQt.cpp: (WebCore::verticalTextCursor): Added. Just returns pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
07:49 Changeset [17730] by rwlbuis

Reviewed by hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

07:31 Changeset [17729] by ap

Attempt to fix Qt build.

  • CMakeLists.txt: PathQt.cpp is in graphics/qt now.
07:15 Changeset [17728] by ap

2006-11-11 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)

[CSS 3] support for vertical-text, cell and context-menu cursors
http://bugs.webkit.org/show_bug.cgi?id=11494

  • Resources/cellCursor.png: Added.
  • Resources/contextMenuCursor.png: Added.
  • Resources/verticalTextCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor):
  • rendering/RenderStyle.h: (WebCore::):
06:31 Changeset [17727] by ap

2006-11-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by aroben and ap, landed by ap.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468

Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.cpp: Removed.
  • platform/AffineTransform.h: Removed.
  • platform/Color.cpp: Removed.
  • platform/Color.h: Removed.
  • platform/FloatPoint.cpp: Removed.
  • platform/FloatPoint.h: Removed.
  • platform/FloatRect.cpp: Removed.
  • platform/FloatRect.h: Removed.
  • platform/FloatSize.cpp: Removed.
  • platform/FloatSize.h: Removed.
  • platform/Icon.h: Removed.
  • platform/Image.cpp: Removed.
  • platform/Image.h: Removed.
  • platform/ImageSource.h: Removed.
  • platform/IntPoint.h: Removed.
  • platform/IntRect.cpp: Removed.
  • platform/IntRect.h: Removed.
  • platform/IntSize.h: Removed.
  • platform/IntSizeHash.h: Removed.
  • platform/Path.cpp: Removed.
  • platform/Path.h: Removed.
  • platform/Pen.cpp: Removed.
  • platform/Pen.h: Removed.
  • platform/cairo/AffineTransformCairo.cpp: Removed.
  • platform/cairo/GraphicsContextCairo.cpp: Removed.
  • platform/cairo/ImageCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Removed.
  • platform/cairo/cairo/AUTHORS: Removed.
  • platform/cairo/cairo/COPYING: Removed.
  • platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
  • platform/cairo/cairo/COPYING-MPL-1.1: Removed.
  • platform/cairo/cairo/INSTALL: Removed.
  • platform/cairo/cairo/NEWS: Removed.
  • platform/cairo/cairo/README: Removed.
  • platform/cairo/cairo/TODO: Removed.
  • platform/cairo/cairo/src/Makefile.in: Removed.
  • platform/cairo/cairo/src/cairo-arc-private.h: Removed.
  • platform/cairo/cairo/src/cairo-arc.c: Removed.
  • platform/cairo/cairo/src/cairo-array.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui.h: Removed.
  • platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
  • platform/cairo/cairo/src/cairo-beos.h: Removed.
  • platform/cairo/cairo/src/cairo-cache-private.h: Removed.
  • platform/cairo/cairo/src/cairo-cache.c: Removed.
  • platform/cairo/cairo/src/cairo-clip-private.h: Removed.
  • platform/cairo/cairo/src/cairo-clip.c: Removed.
  • platform/cairo/cairo/src/cairo-color.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.h: Removed.
  • platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-directfb.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h.in: Removed.
  • platform/cairo/cairo/src/cairo-fixed.c: Removed.
  • platform/cairo/cairo/src/cairo-font-options.c: Removed.
  • platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
  • platform/cairo/cairo/src/cairo-font-subset.c: Removed.
  • platform/cairo/cairo/src/cairo-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ft.h: Removed.
  • platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-glitz.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate.c: Removed.
  • platform/cairo/cairo/src/cairo-hash-private.h: Removed.
  • platform/cairo/cairo/src/cairo-hash.c: Removed.
  • platform/cairo/cairo/src/cairo-hull.c: Removed.
  • platform/cairo/cairo/src/cairo-image-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-matrix.c: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-output-stream.c: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
  • platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-data.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fill.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
  • platform/cairo/cairo/src/cairo-path.c: Removed.
  • platform/cairo/cairo/src/cairo-pattern.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf.h: Removed.
  • platform/cairo/cairo/src/cairo-pen.c: Removed.
  • platform/cairo/cairo/src/cairo-platform.h: Removed.
  • platform/cairo/cairo/src/cairo-png.c: Removed.
  • platform/cairo/cairo/src/cairo-polygon.c: Removed.
  • platform/cairo/cairo/src/cairo-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-ps.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz2.h: Removed.
  • platform/cairo/cairo/src/cairo-region.c: Removed.
  • platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
  • platform/cairo/cairo/src/cairo-slope.c: Removed.
  • platform/cairo/cairo/src/cairo-spline.c: Removed.
  • platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
  • platform/cairo/cairo/src/cairo-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg.h: Removed.
  • platform/cairo/cairo/src/cairo-traps.c: Removed.
  • platform/cairo/cairo/src/cairo-unicode.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-font.c: Removed.
  • platform/cairo/cairo/src/cairo-win32-private.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-win32.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib.h: Removed.
  • platform/cairo/cairo/src/cairo.c: Removed.
  • platform/cairo/cairo/src/cairo.h: Removed.
  • platform/cairo/cairo/src/cairoint.h: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.c: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.h: Removed.
  • platform/cairo/cairo/src/test-meta-surface.c: Removed.
  • platform/cairo/cairo/src/test-meta-surface.h: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.h: Removed.
  • platform/cairo/pixman/AUTHORS: Removed.
  • platform/cairo/pixman/COPYING: Removed.
  • platform/cairo/pixman/README: Removed.
  • platform/cairo/pixman/src/Makefile.in: Removed.
  • platform/cairo/pixman/src/fbcompose.c: Removed.
  • platform/cairo/pixman/src/fbedge.c: Removed.
  • platform/cairo/pixman/src/fbedgeimp.h: Removed.
  • platform/cairo/pixman/src/fbmmx.c: Removed.
  • platform/cairo/pixman/src/fbmmx.h: Removed.
  • platform/cairo/pixman/src/fbpict.c: Removed.
  • platform/cairo/pixman/src/fbpict.h: Removed.
  • platform/cairo/pixman/src/fbtrap.c: Removed.
  • platform/cairo/pixman/src/icblt.c: Removed.
  • platform/cairo/pixman/src/icbltone.c: Removed.
  • platform/cairo/pixman/src/iccolor.c: Removed.
  • platform/cairo/pixman/src/icformat.c: Removed.
  • platform/cairo/pixman/src/icimage.c: Removed.
  • platform/cairo/pixman/src/icimage.h: Removed.
  • platform/cairo/pixman/src/icint.h: Removed.
  • platform/cairo/pixman/src/icpixels.c: Removed.
  • platform/cairo/pixman/src/icrect.c: Removed.
  • platform/cairo/pixman/src/icrop.h: Removed.
  • platform/cairo/pixman/src/icstipple.c: Removed.
  • platform/cairo/pixman/src/ictransform.c: Removed.
  • platform/cairo/pixman/src/ictrap.c: Removed.
  • platform/cairo/pixman/src/ictri.c: Removed.
  • platform/cairo/pixman/src/icutil.c: Removed.
  • platform/cairo/pixman/src/pixman-remap.h: Removed.
  • platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
  • platform/cairo/pixman/src/pixman.h: Removed.
  • platform/cairo/pixman/src/pixregion.c: Removed.
  • platform/cairo/pixman/src/pixregionint.h: Removed.
  • platform/cairo/pixman/src/renderedge.c: Removed.
  • platform/cairo/pixman/src/renderedge.h: Removed.
  • platform/cairo/pixman/src/slim_internal.h: Removed.
  • platform/cairo/rgb24-hacks.txt: Removed.
  • platform/cairo/scale-removal.txt: Removed.
  • platform/cg/AffineTransformCG.cpp: Removed.
  • platform/cg/FloatPointCG.cpp: Removed.
  • platform/cg/FloatRectCG.cpp: Removed.
  • platform/cg/FloatSizeCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/cg/ImageCG.cpp: Removed.
  • platform/cg/ImageSourceCG.cpp: Removed.
  • platform/cg/IntPointCG.cpp: Removed.
  • platform/cg/IntRectCG.cpp: Removed.
  • platform/cg/IntSizeCG.cpp: Removed.
  • platform/cg/PDFDocumentImage.cpp: Removed.
  • platform/cg/PDFDocumentImage.h: Removed.
  • platform/cg/PathCG.cpp: Removed.
  • platform/gdk/ImageGdk.cpp: Removed.
  • platform/mac/ColorMac.mm: Removed.
  • platform/mac/FloatPointMac.mm: Removed.
  • platform/mac/FloatRectMac.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Removed.
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/IconMac.mm: Removed.
  • platform/mac/ImageMac.mm: Removed.
  • platform/mac/IntPointMac.mm: Removed.
  • platform/mac/IntRectMac.mm: Removed.
  • platform/mac/IntSizeMac.mm: Removed.
  • platform/qt/AffineTransformQt.cpp: Removed.
  • platform/qt/ColorQt.cpp: Removed.
  • platform/qt/FloatPointQt.cpp: Removed.
  • platform/qt/FloatRectQt.cpp: Removed.
  • platform/qt/IconQt.cpp: Removed.
  • platform/qt/ImageQt.cpp: Removed.
  • platform/qt/ImageSourceQt.cpp: Removed.
  • platform/qt/IntPointQt.cpp: Removed.
  • platform/qt/IntRectQt.cpp: Removed.
  • platform/qt/IntSizeQt.cpp: Removed.
  • platform/qt/PathQt.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.
  • platform/win/IntPointWin.cpp: Removed.
  • platform/win/IntRectWin.cpp: Removed.
  • platform/win/IntSizeWin.cpp: Removed.
05:10 Changeset [17726] by gdennis

Build fix.

04:34 Changeset [17725] by gdennis

WebCore:

Reviewed by hyatt.

A layout test was added when this bug was fixed, so none needed now.


Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570


  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Removed.
  • rendering/RenderText.cpp: (WebCore::isSpace): Added. (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
04:04 Changeset [17724] by gdennis

WebCore:

Reviewed by mitz.


REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Added.
  • rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'

LayoutTests:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
00:50 Changeset [17723] by ap

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h

Fix suggested by Don Gibson.

  • kjs/JSImmediate.h: Re-enable all MSVC warnings, move the remaining runtime checks to compile-time.

11/10/06:

19:11 Changeset [22521] by sfalken
18:55 Changeset [17722] by bdash

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • wtf/Platform.h:

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • config.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
  • platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
  • platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
  • platform/StringImpl.h:
  • platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
  • platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
  • platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
  • platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
  • platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
  • platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
  • platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
  • platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):
18:33 Changeset [17721] by bdash

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
  • loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
17:56 Changeset [17720] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

  • editing/deleting/delete-link-1-expected.checksum: Added.
  • editing/deleting/delete-link-1-expected.png: Added.
  • editing/deleting/delete-link-1-expected.txt: Added.
  • editing/deleting/delete-link-1.html: Added.
  • editing/inserting/insert-before-link-1-expected.checksum: Added.
  • editing/inserting/insert-before-link-1-expected.png: Added.
  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself


The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
  • editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.
17:33 Changeset [22520] by aroben
17:19 Changeset [17719] by thatcher

New tag.

17:18 Changeset [17718] by thatcher

Versioning.

17:15 Changeset [17717] by thatcher

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:51 Changeset [17716] by thatcher

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:20 Changeset [17715] by thatcher

Build fix.

16:11 Changeset [22519] by beidson

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
  • WebIconDatabase.h:
16:10 Changeset [17714] by thatcher

64-bit build fix. Generates a derived export file for 64-bit architectures.

16:01 Changeset [22518] by andersca

2006-11-10 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
  • platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):
15:45 Changeset [17713] by aroben

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

  • page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
15:36 Changeset [17712] by mjs

Reviewed by Anders.


  • remove some unnecessary uses of WebDataProtocol
  • WebView/WebDataSource.mm: Remove the unneeded include.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.
15:20 Changeset [17711] by andersca

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
  • editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):
14:29 Changeset [17710] by spadma

2006-11-10 spaltis <Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
http://bugs.webkit.org/show_bug.cgi?id=11568

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):
13:53 Changeset [17709] by sfalken

New tag.

13:51 Changeset [22517] by sfalken

2006-11-10 Steve Falkenburg <sfalken@apple.com>

Bump version number for submission

  • VERSION:
  • WebKit.vcproj/VERSION:
13:35 Changeset [22516] by ggaren

Oops. Checked in too much. Rolling out the extra.

13:33 Changeset [22515] by ggaren

Fixed build -- you can't delete the shared icon database -- it's a singleton

13:12 Changeset [17708] by ggaren

Fixed platform #ifs

13:07 Changeset [17707] by spadma

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
13:00 Changeset [17706] by spadma

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
11:45 Changeset [17705] by andersca

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
  • editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.


  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):
11:31 Changeset [22514] by beidson

Reviewed by Darin

Keep windows build from breaking

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
  • WebFrame.h:
11:24 Changeset [17704] by beidson

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
  • loader/FrameLoaderClient.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
  • loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin


Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
  • Misc/WebIconDatabaseInternal.h: Added.
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed.
  • WebCoreSupport/WebIconDatabaseBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
11:16 Changeset [17703] by andersca

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

  • CMakeLists.txt:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
  • loader/qt/FrameLoaderClientQt.h: Added.
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
  • platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
  • platform/qt/ChromeClientQt.h: Added.
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/ImageQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
  • platform/qt/PageQt.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
  • platform/qt/ScreenQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):
00:42 Changeset [17702] by beidson

Reviewed by Mitz

http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.
00:22 Changeset [22513] by oliver

2006-11-10 Oliver Hunt <oliver@apple.com>

Build fix


sprintf -> format (from Maciej's earlier change to WebCore)

  • WebView.cpp: (osVersion): (WebView::userAgentForKURL):

11/09/06:

23:33 Changeset [22512] by oliver

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Added Windows side of MIME Type registry, and updated
objectContentType and ImageWin to make use of it


This fixes <rdar://problem/4791483>

  • WebCore.vcproj/WebCore.vcproj:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::objectContentType):
  • platform/win/ImageWin.cpp:
  • platform/win/MimeTypeRegistryWin.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::mimeTypeForExtension): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


23:31 Changeset [17701] by oliver

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebMimeTypeRegistryBridge.h: Added.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Added. (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
  • platform/Image.cpp: (WebCore::Image::supportsType):
  • platform/Image.h:
  • platform/MimeTypeRegistry.cpp: Added. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes): (WebCore::initialiseMimeTypeRegistry): (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes): (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
  • platform/MimeTypeRegistry.h: Added.
  • platform/mac/ImageMac.mm:
  • platform/mac/MimeTypeRegistryMac.mm: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


Updated to make use of MimeTypeRegistry/bridge

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
  • WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]):


21:17 Changeset [17700] by mjs

Reviewed by Oliver.

  • rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size for you and use vsnprintf.
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • css/cssparser.cpp: (WebCore::CSSParser::parseColorFromValue):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::handleError):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
  • ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::toString):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
  • ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::toString):
  • ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::toString):
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setSynchronous):
  • platform/Color.cpp: (WebCore::Color::name):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::setNum): (WebCore::DeprecatedString::format):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::format): (WebCore::String::number):
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::calcMinMaxWidth):
20:14 Changeset [22511] by sfalken
18:27 Changeset [22510] by oliver

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.


Fix crash on unknown protocol


  • WebFrame.cpp: (WebFrame::didFailWithError):
18:03 Changeset [22509] by lamadio

2006-11-09 Lou Amadio <lamadio@apple.com>

Reviewed by mjs
Correct the broken search implementations based on original webkit
<rdar://4827714>

16:30 Changeset [17699] by mjs

Reviewed by Anders.

  • fixed "Regression: Can't log into gmail.com"
  • fixed "iBench doesn't report results - tests run but no number is recorded"


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): Removed extra ! character.
15:21 Changeset [17698] by beidson

Reviewed by Darin

<rdar://problem/4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released

  • WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto (WebFrameLoaderClient::setUpPolicyListener): Ditto (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto
14:58 Changeset [17697] by bdakin

Reviewed by Hyatt.

Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace

Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): It is possible for a prevRootBox and its prevRootBox to share a lineBreakObj. So instead of just clearing the lineBreakObj of the prevRootBox, cycle through all prevRootBoxs with the same lineBreakObj.
14:30 Changeset [22508] by aroben

WebKitWin:

Reviewed by Steve.

Put the OpenSource revision in the WebKit.dll version info.

14:06 Changeset [17696] by spadma

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
14:05 Changeset [17695] by spadma

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
13:48 Changeset [17694] by thatcher

Build fix.

13:40 Changeset [17693] by zbujtas

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
13:37 Changeset [17692] by zbujtas

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
13:11 Changeset [22507] by aroben

Fix line-endings.

  • WebEditorClient.cpp:
12:54 Changeset [22506] by oliver

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.

Build fixes

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedContents):
  • WebEditorClient.h:
12:51 Changeset [17691] by aroben

LayoutTests:

Reviewed by Geoff.

New test to keep the mistake I made in r17680 from happening again.

  • fast/block/margin-collapse/negative-margins-expected.checksum: Added.
  • fast/block/margin-collapse/negative-margins-expected.png: Added.
  • fast/block/margin-collapse/negative-margins-expected.txt: Added.
  • fast/block/margin-collapse/negative-margins.html: Added.

WebCore:

Reviewed by Geoff.

Fix the change in behavior I caused in r17680 with my build fix.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
11:48 Changeset [17690] by andersca

WebCore:

Reviewed by Adam, Oliver.

Move more functions to Editor.

  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::dispatchEditableContentChangedEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Adam, Oliver.

Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame): (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::didEndEditing):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
11:00 Changeset [22505] by lamadio

2006-11-08 Lou Amadio <lamadio@apple.com>

Reviewed by ggaren

Moved CookieJar to OpenSourceWin
Ported CookieJar to CFNetwork
Corrected an uninitialized variable which crashed on Vista in the Wininet code

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/win/CookieJarWin.cpp:
08:31 Changeset [17689] by darin
  • rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
08:17 Changeset [17688] by aliceli1

Reviewed by Beth Dakin.

Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): check lastSection before deleting row
07:41 Changeset [17687] by darin
  • improved version of last night's build fix (should not do using namespace in a header)
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
07:38 Changeset [17686] by spadma

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
07:34 Changeset [17685] by spadma

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
07:27 Changeset [17684] by spadma

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugzilla.opendarwin.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
07:24 Changeset [17683] by spadma

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugs.webkit.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

11/08/06:

23:31 Changeset [22504] by aroben

Reviewed by Steve.

Make the same change here as made in r11013.

23:13 Changeset [22503] by mjs

WebCoreWin:

Reviewed by Geoff.

  • added ResourceError class and didFailWithError client method


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFailLoadingWithError): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Geoff.

  • added ResourceError class and didFailWithError client method


  • WebFrame.cpp: (WebFrame::didFinishLoading): (WebFrame::didFailWithError):
  • WebFrame.h:
22:49 Changeset [17682] by mjs

Reviewed by Geoff.


  • added ResourceError class and didFailWithError client method
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError):
  • loader/loader.h:
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptCFReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adopt):
  • platform/network/ResourceError.cpp: Added.
  • platform/network/ResourceError.h: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFailWithError):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::cancel):
  • platform/network/mac/ResourceErrorMac.mm: Added. (-[NSError WebCore]):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::reportError):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/xmlhttprequest.h:
22:39 Changeset [17681] by bdash

2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk fixes.

  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::~ChromeClientGdk):
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor): (WebCore::moveCursor):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/PageGdk.cpp:
  • platform/gdk/ScreenClientGdk.h: Added. (WebCore::ScreenClientGdk::~ScreenClientGdk):
  • platform/gdk/ScreenGdk.cpp: (WebCore::ScreenClientGdk::depth): (WebCore::ScreenClientGdk::depthPerComponent): (WebCore::ScreenClientGdk::isMonochrome): (WebCore::ScreenClientGdk::rect): (WebCore::ScreenClientGdk::usableRect):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::historyURL): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::client):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):
21:58 Changeset [17680] by aroben

Build fix.

  • rendering/RenderObject.h: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
21:22 Changeset [22502] by ggaren

Reviewed by Anders Carlsson.

Updated Windows to use the new platform abstraction for Screen.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
  • platform/win/ScreenWin.cpp: (WebCore::monitorInfoForWidget): (WebCore::deviceInfoForWidget): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
21:18 Changeset [17679] by brmorris

Updating README.txt to point to new wiki location.

21:18 Changeset [17678] by ggaren

Reviewed by Anders Carlsson.

Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.

  • bindings/js/kjs_window.cpp: Removed unnecessary subtractions when computing the screen's available dimensions.
19:55 Changeset [17677] by weinig

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject

  • rendering/RenderObject.cpp: (WebCore::RenderObject::operator delete): (WebCore::RenderObject::createObject): (WebCore::RenderObjectCounter::~RenderObjectCounter): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isDescendantOf): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::removeChild): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): (WebCore::RenderObject::previousInPreOrder): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::nextEditable): (WebCore::RenderObject::previousEditable): (WebCore::RenderObject::firstLeafChild): (WebCore::RenderObject::lastLeafChild): (WebCore::RenderObject::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::updateFirstLetter): (WebCore::RenderObject::offsetParent): (WebCore::RenderObject::scroll): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::containingBlockHeight): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintObjectsBeforeLayout): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::information): (WebCore::RenderObject::dump): (WebCore::selectStartNode): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::createAnonymousBlock): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::setStyleInternal): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::absolutePosition): (WebCore::RenderObject::caretRect): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::tabWidth): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::arenaDelete): (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::invalidateVerticalPositions): (WebCore::RenderObject::recalcMinMaxWidths): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::setInlineBoxWrapper): (WebCore::RenderObject::firstLineStyle): (WebCore::RenderObject::getPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::collectDashboardRegions): (WebCore::RenderObject::avoidsFloats): (WebCore::RenderObject::findCounter): (WebCore::RenderObject::backslashAsCurrencySymbol): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::previousOffset): (WebCore::RenderObject::nextOffset): (WebCore::RenderObject::inlineBox):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::renderName): (WebCore::RenderObject::parent): (WebCore::RenderObject::previousSibling): (WebCore::RenderObject::nextSibling): (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::getOverflowClipRect): (WebCore::RenderObject::getClipRect): (WebCore::RenderObject::getBaselineOfFirstLineBox): (WebCore::RenderObject::setEdited): (WebCore::RenderObject::setStaticX): (WebCore::RenderObject::setStaticY): (WebCore::RenderObject::setPreviousSibling): (WebCore::RenderObject::setNextSibling): (WebCore::RenderObject::setParent): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymousBlock): (WebCore::RenderObject::isDragging): (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::setMinMaxKnown): (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc): (WebCore::RenderObject::setPositioned): (WebCore::RenderObject::setRelPositioned): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setShouldPaintBackgroundOrBorder): (WebCore::RenderObject::setReplaced): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::calcWidth): (WebCore::RenderObject::updateFromElement): (WebCore::RenderObject::RepaintInfo::RepaintInfo): (WebCore::RenderObject::setOverrideSize): (WebCore::RenderObject::setPos): (WebCore::RenderObject::setWidth): (WebCore::RenderObject::setHeight): (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::overflowHeight): (WebCore::RenderObject::overflowWidth): (WebCore::RenderObject::setOverflowHeight): (WebCore::RenderObject::setOverflowWidth): (WebCore::RenderObject::overflowLeft): (WebCore::RenderObject::overflowTop): (WebCore::RenderObject::overflowRect): (WebCore::RenderObject::stopAutoscroll): (WebCore::RenderObject::collapsedMarginTop): (WebCore::RenderObject::collapsedMarginBottom): (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin): (WebCore::RenderObject::): (WebCore::RenderObject::setTable): (WebCore::RenderObject::isFloatingOrPositioned): (WebCore::RenderObject::containsFloat): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::SelectionInfo::SelectionInfo): (WebCore::RenderObject::lowestPosition): (WebCore::RenderObject::rightmostPosition): (WebCore::RenderObject::leftmostPosition): (WebCore::RenderObject::calcVerticalMargins): (WebCore::RenderObject::font):
18:21 Changeset [22501] by darin
  • fix the build
  • bridge/win/FrameWin.h: Add a forward declaration of FormData.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.
  • platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the TextField constructor.
18:18 Changeset [17676] by zbujtas

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
merged from 3.1m 17675
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugs.webkit.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
18:07 Changeset [17675] by zbujtas

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugzilla.opendarwin.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
18:00 Changeset [22500] by aroben

Build fix.

  • WebEditorClient.cpp: Added stubs for new methods from EditorClient.h. (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
  • WebEditorClient.h: Added new methods from EditorClient.h and cleaned up placement of *s.
18:00 Changeset [17674] by darin

LayoutTests:

Reviewed by Anders.

  • added test for option-tab
  • fast/events/option-tab.html: Added.
  • fast/events/option-tab-expected.txt: Added.

WebCore:

Reviewed by Anders.

  • added event parameters to focus-related functions so we can implement the "option-tab to all links" behavior without relying on a global "current event" -- also makes it work with DOM events
  • page/Frame.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
  • page/Frame.cpp: (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from PlatformKeyboardEvent to the DOM keyboard event class. (WebCore::Frame::tabsToLinks): Added event parameter. (WebCore::Frame::tabsToAllControls): Ditto. (WebCore::scanForForm): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (WebCore::Frame::hitTestResultAtPoint): Ditto.
  • bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
  • bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of a PlatformKeyboardEvent. (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent() and pass event into next/previousFocusNode. (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from the AppKit current event, if it's a keyboard event. Really just a hack that's needed to preserve some code we can remove once we deal with the last NSView- based form control. (WebCore::isKeyboardOptionTab): Added. (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the option (alt) key is down. (WebCore::FrameMac::tabsToAllControls): Ditto. (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just call resetMultipleFormSubmissionProtection() explicitly instead. (WebCore::FrameMac::mouseDown): Ditto.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to prepareForUserAction() to call resetMultipleFormSubmissionProtection() explicitly instead.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Changed function to take an event parameter, and decide the direction based on the shift key modifier instead of a passed-in boolean.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::nextFocusNode): Added event parameter. (WebCore::Document::previousFocusNode): Ditto.
  • dom/Node.h:
  • dom/Node.cpp: (WebCore::Node::isKeyboardFocusable): Ditto.
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
  • html/HTMLGenericFormElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Pass event to the advanceFocus function.
  • platform/TextField.h:
  • platform/mac/TextFieldMac.mm: Removed the non-search field code.
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextField.mm: Removed the non-search field code. (-[WebCoreTextFieldController controlTextDidChange:]): Removed the call to FrameMac::handleKeyboardOptionTabInView, which is no longer needed since the default handler in HTMLInputElement takes care of option-tab.
  • platform/mac/SliderMac.mm: (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent() and pass event into tabsToAllControls. (Slider::focusPolicy): Ditto.
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code. (WebCore::RenderLineEdit::updateFromElement): Ditto.
17:41 Changeset [22499] by sfalken
17:33 Changeset [17673] by darin

Reviewed by Anders.

  • same change as below, only tested this time
  • DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links" mode off. I think we need to do this because WebPreferences saves things for us automatically. It would be good to turn that off for DumpRenderTree, but for now lets handle this like the other preferences (set it explicitly each time).
17:21 Changeset [17672] by darin

Reviewed by Anders.

  • DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on "tab to links" mode. No current tests depend on this, and there's a new test I want to land that depends on the default setting.
17:16 Changeset [17671] by beidson

Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)

<rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)

More "free nil checking" we lost in the transition from ObjC to C++

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
16:51 Changeset [17670] by andersca

WebCore:

Reviewed by Adam.

Move more code into editor.


  • WebCore.exp:
  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • dom/Document.cpp: (WebCore::Document::relinquishesEditingFocus): (WebCore::Document::acceptsEditingFocus): (WebCore::Document::didBeginEditing): (WebCore::Document::didEndEditing):
  • editing/Editor.cpp: (WebCore::Editor::indent): (WebCore::Editor::outdent):
  • editing/Editor.h:
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Adam.

Move more code into editor.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.m: (-[NSArray indent:]): (-[NSArray outdent:]):
  • WebView/WebView.mm:
  • WebView/WebViewInternal.h:
16:41 Changeset [22498] by bdakin

Reviewed by Adam.

Add clause for new WebElementIsContentEditableKey to the Read
fucntion.

  • Interfaces/IWebView.idl:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
14:58 Changeset [17669] by bdakin

WebCore:

Reviewed by Adam.

Add ability to HitTestResult to ask if the inner non-shared node is
content editable.

  • WebCore.exp: Export HitTestResult::isContentEditable()
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
  • rendering/HitTestResult.h:

WebKit:

Reviewed by Adam.

Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Use new WebElementIsContentEditableKey.
  • Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isContentEditable]): Call into HitTestResult::isContentEditable()
  • WebView/WebView.mm: Add new key.
  • WebView/WebViewPrivate.h: Add new key.
14:50 Changeset [17668] by andersca

Build fix.


  • WebCore.xcodeproj/project.pbxproj: Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
14:32 Coding Style Guidelines edited by sam@webkit.org
(diff)
14:24 Changeset [17667] by thatcher

Reviewed by Darin.

<rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection

Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.

  • bindings/objc/DOM.mm: (WebCore::kit): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
  • bindings/objc/DOMPrivate.h:
  • dom/Range.cpp: (WebCore::Range::boundingBox): (WebCore::Range::addLineBoxRects):
  • dom/Range.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects):
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
  • rendering/RenderText.h:
13:57 Changeset [22497] by adachan
13:57 Changeset [17666] by andersca

WebCore:

Reviewed by Oliver.


Move methods from the bridge and frame into editor.


  • WebCore.exp:
  • bridge/EditorClient.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::toggleBold): (WebCore::Editor::toggleItalic): (WebCore::Editor::selectionStartHasStyle):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Oliver.

Call into the WebCore editor object directly.


  • MigrateHeaders.make:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle):
  • WebView/WebFrame.mm: (core): (kit):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]): (-[NSArray _changeCSSColorUsingSelector:inRange:]): (-[NSArray underline:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: (-[WebView applyStyle:]):
13:30 Changeset [17665] by andersca

Reviewed by Oliver.

<rdar://problem/4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app


  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Initialize the framework pointer to 0.
13:26 Changeset [22496] by lamadio
13:20 Changeset [17664] by adachan

2006-11-08 Ada Chan <adachan@apple.com>

Reviewed by darin.


Added a method to delete all the keys in a HashMap.

12:14 Changeset [17663] by ggaren

Reviewed by Beth.


Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.

  • platform/Screen.h:
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint): Grab the best screen instead of the screen you're on, since you might be off-screen.
  • platform/mac/ScreenMac.mm: (WebCore::screenForWindow):
11:47 Changeset [22495] by andersca

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.


Fix the build. Hook up a layoutTestController and implement dumpAsText, waitUntilDone and notifyDone.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Added. (dumpAsTextCallback): (waitUntilDoneCallback): (notifyDoneCallback): (getClass): (createLayoutTestController):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didFinishLoadForFrame): (WaitUntilDoneDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction):
11:13 Changeset [22494] by andersca

WebCoreWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Build fixes.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

More fiddling with midl to get our JSC API types recognized.


  • Interfaces/IWebFrameLoadDelegate.idl:
09:32 Changeset [17662] by darin
  • fix bug caused by last-minute change to my check-in last night that is causing layout tests to hang
  • dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn a null string into an empty string before calling completeURL.
02:02 Changeset [17661] by beidson

LayoutTests:

Reviewed by Maciej

Added test to cover bug http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched

  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
  • http/tests/xmlhttprequest/resources/endlessxml.php: Added.
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.

WebCore:

Reviewed by Maciej

If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
01:55 Changeset [22493] by andersca

2006-11-08 Anders Carlsson <acarlsson@apple.com>

  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Use m_frame instead of this, include the correct files.
01:51 Changeset [17660] by darin
  • another attempt to fix Qt build
  • loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
01:48 Changeset [17659] by darin

Reviewed by Geoff.

  • stray bits of my FrameLoader patch that I left out by accident
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class. (WebCore::FrameLoader::requestFrame): Use less DeprecatedString. (WebCore::FrameLoader::clear): Stop the redirection timer. (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the entire function in an if statement. Use less DeprecatedString. (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator. (WebCore::FrameLoader::scheduleRefresh): Ditto. (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
01:47 Changeset [22492] by andersca

2006-11-08 Anders Carlsson <acarlsson@apple.com>

(I'm not doing this to get commit 11000)


  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): It's m_frame, not frame.
01:45 Changeset [17658] by darin

Reviewed by Geoff.

  • fast/forms/submit-nil-value-field-assert.html: Update test so it no longer relies on incorrect "submit form right away during JavaScript execution" behavior.
01:43 Changeset [22491] by andersca

2006-11-08 Anders Carlsson <acarlsson@apple.com>

It's FrameLoader, not FrameWin.


  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin):
01:40 Changeset [22490] by andersca

2006-11-08 Anders Carlsson <acarlsson@apple.com>

A blind attempt at fixing the build.


  • bridge/win/FrameWin.cpp:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameWin::partClearedInBegin):
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::restoreDocumentState):
00:19 Changeset [17657] by bdakin

Reviewed by Geoff.

This test needs new results from my last check-in. I thought this
change was already in my tree, but I guess not. Whoops!

  • fast/dom/delete-contents-expected.txt:

11/07/06:

23:48 Changeset [17656] by bdakin

WebCore:

Reviewed by Hyatt.

Another go at fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The fix from yesterday caused a layout test regression which
exposed an existing bug. The existing bug was that we allowed text
nodes to stay in the head tag, but other browsers move them to the
body. The previous fix also caused a performance regression, which
was seemingly easy to fix by moving the new clause in
HTMLParser::handleError() to be below the HTMLElement case.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): Don't allow comment nodes to be the child of the document.
  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::childAllowed): Do not allow non- whitespace text nodes to be children of the head.
  • html/HTMLHeadElement.h:
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Error case for comment nodes.
  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safety-net null check for the original crash.

Layout Tests:

Reviewed by Hyatt.

Test cases for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

And for the found-bug of moving text nodes within the head to the
body.

23:24 Changeset [17655] by darin
  • another attempt to fix Qt build
  • loader/icon/IconLoader.h: Added missing include.
23:09 Changeset [22489] by ggaren

WebCoreWin:

Reviewed by Anders.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.


Moved Screen back from page/ to platform/ because it's a platform
abstraction again.


Fixed bug where Screen would query the default screen instead of the screen
on which the active window was located. (The code is written in Klingon,
but that's cool.)


Implemented some missing screen functionality on Win.


I can't fully verify this code because I can't load files without crashing
in CFNetwork, but I exercised most of it with javascript: URLs and the
debugger reported reasonable values.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ScreenWin.cpp: Added. Merged over from opensource tree. (WebCore::getWindow): (WebCore::getMonitorInfo): (WebCore::getDeviceInfo): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect):

WebKitWin:

Reviewed by Anders.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.

23:04 Changeset [17654] by ggaren

WebCore:

Reviewed by Tim Hatcher.


Removed ScreenClient. It was highly unpopular, risking my midterm re-election.


None of Screen's responsibilities require up-calls to WebKit or delegates,
so WebCore can handle it all.


Moved Screen back from page/ to platform/ because it's a platform
abstraction again.

Merged scaling and flipping functions into 'toUserSpace' and 'toDeviceSpace',
since the two were always used together.


Changed pixel depth queries to query the deepest screen. Darin mentioned
that it might have been a feature, not a bug, to use the main/menubar screen
regardless of the screen you were on. For scaling and flipping that's not
the case, but for querying pixel depth I think it is. You want to know
about the highest pixel depth your content may display on.


Tests still pass.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h:
  • page/Screen.cpp: Removed.
  • page/Screen.h: Removed.
  • page/ScreenClient.h: Removed.
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint):
  • platform/mac/ScreenMac.mm: (WebCore::window): (WebCore::bestScreen): (WebCore::Screen::depth): (WebCore::Screen::depthPerComponent): (WebCore::Screen::isMonochrome): (WebCore::Screen::rect): (WebCore::Screen::usableRect): (WebCore::toUserSpace): (WebCore::toDeviceSpace):

WebKit:

Reviewed by Geoff.

  • udpated for changes to move from Frame/FrameMac to FrameLoader
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
  • WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):
21:58 Changeset [17653] by darin
  • try to fix Qt build
  • CMakeLists.txt: Updated for some file changes.
  • WebCoreSources.bkl: Ditto.
21:57 Changeset [22488] by darin

WebCoreWin:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::setTitle):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::markMisspellings): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (IconLoader::notifyIconChanged): (PolicyCheck::PolicyCheck): (PolicyCheck::clear): (PolicyCheck::call): (PolicyCheck::clearRequest): (FrameLoader::saveDocumentState): (FrameLoader::restoreDocumentState): (FrameLoader::partClearedInBegin): (FrameLoader::goBackOrForward): (FrameLoader::historyURL): (FrameLoader::canGoBackOrForward): (FrameLoader::getHistoryLength): (DocumentLoader::setupForReplaceByMIMEType): (ResourceLoader::cancel): (DocumentLoader::stopLoading): (DocumentLoader::setLoading): (DocumentLoader::updateLoading): (DocumentLoader::setFrame): (DocumentLoader::stopRecordingResponses): (DocumentLoader::isStopping): (DocumentLoader::setPrimaryLoadComplete): (DocumentLoader::finishedLoading): (DocumentLoader::URL): (DocumentLoader::isLoadingInAPISense): (DocumentLoader::frameLoader): (FrameLoader::overrideMediaType): (FrameLoader::redirectDataToPlugin): (FrameLoader::checkLoadCompleteForThisFrame): (FrameLoader::loadEmptyDocumentSynchronously): (FrameLoader::startLoading): (FrameLoader::referrer):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::userAgent):

WebKitWin:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebFrame.cpp: (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::initWithWebFrameView): (WebFrame::loadDataSource): (WebFrame::didReceiveResponse): (WebFrame::didReceiveData): (WebFrame::didFinishLoading): (WebFrame::setTitle): (WebFrame::dispatchDidHandleOnloadEvents): (WebFrame::detachFrameLoader): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::hasBackForwardList): (WebFrame::resetBackForwardList): (WebFrame::provisionalItemIsTarget): (WebFrame::loadProvisionalItemFromPageCache): (WebFrame::invalidateCurrentItemPageCache): (WebFrame::privateBrowsingEnabled): (WebFrame::makeDocumentView): (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::updateHistoryForCommit): (WebFrame::updateHistoryForBackForwardNavigation): (WebFrame::updateHistoryForReload): (WebFrame::updateHistoryForStandardLoad): (WebFrame::updateHistoryForInternalLoad): (WebFrame::updateHistoryAfterClientRedirect): (WebFrame::setCopiesOnScroll): (WebFrame::tokenForLoadErrorReset): (WebFrame::resetAfterLoadError): (WebFrame::doNotResetAfterLoadError): (WebFrame::willCloseDocument): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromPageCache): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidChangeLocationWithinPage): (WebFrame::dispatchWillClose): (WebFrame::dispatchDidStartProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidCommitLoad): (WebFrame::dispatchDidFinishLoad): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::dispatchDidLoadMainResource): (WebFrame::clearLoadingFromPageCache): (WebFrame::isLoadingFromPageCache): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::progressStarted): (WebFrame::progressCompleted): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finishedLoading): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::frameLoadCompleted): (WebFrame::restoreScrollPositionAndViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::userAgent):
  • WebFrame.h:
  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString):
21:52 Changeset [17652] by darin

WebCore:

Reviewed by Geoff.

  • moved loader code from Frame/FrameMac to FrameLoader
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty):
  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • bindings/js/kjs_window.cpp: (KJS::Screen::Screen): (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute): (KJS::Location::getValueProperty): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • bindings/objc/DOM.mm: (+[DOMNode _nodeWith:WebCore::]):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::setView): (WebCore::FrameMac::setStatusBarText):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge close]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge canProvideDocumentSource]): (-[WebCoreFrameBridge receivedData:textEncodingName:]):
  • css/cssparser.cpp: (WebCore::CSSParser::parseContent):
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
  • dom/DOMImplementation.h:
  • dom/Document.cpp: (WebCore::Document::readyState): (WebCore::Document::updateTitle): (WebCore::Document::open): (WebCore::Document::close): (WebCore::Document::implicitClose): (WebCore::Document::processHttpEquiv): (WebCore::Document::referrer): (WebCore::Document::finishedParsing):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::endElementNs): (WebCore::ignorableWhitespaceHandler): (WebCore::XMLTokenizer::notifyFinished):
  • editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLBaseElement.cpp: (WebCore::HTMLBaseElement::process):
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::lastModified):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::isURLAllowed): (WebCore::HTMLFrameElementBase::openURL): (WebCore::HTMLFrameElementBase::willRemove):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValueFromRenderer):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • html/HTMLPreElement.idl:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible):
  • loader/DocLoader.cpp: (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::ScheduledRedirection::): (WebCore::ScheduledRedirection::ScheduledRedirection): (WebCore::cancelAll): (WebCore::getString): (WebCore::isBackForwardLoadType): (WebCore::numRequests): (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::~FrameLoader): (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::changeLocation): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::loadSubframe): (WebCore::FrameLoader::submitFormAgain): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::stopLoading): (WebCore::FrameLoader::stop): (WebCore::FrameLoader::closeURL): (WebCore::FrameLoader::cancelRedirection): (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::didOpenURL): (WebCore::FrameLoader::didExplicitOpen): (WebCore::FrameLoader::replaceContentsWithScriptResult): (WebCore::FrameLoader::executeScript): (WebCore::FrameLoader::cancelAndClear): (WebCore::FrameLoader::clear): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::responseMIMEType): (WebCore::FrameLoader::setResponseMIMEType): (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::end): (WebCore::FrameLoader::endIfNotLoading): (WebCore::FrameLoader::startIconLoader): (WebCore::FrameLoader::commitIconURLToIconDatabase): (WebCore::FrameLoader::gotoAnchor): (WebCore::FrameLoader::finishedParsing): (WebCore::FrameLoader::loadDone): (WebCore::FrameLoader::checkCompleted): (WebCore::FrameLoader::checkEmitLoadEvent): (WebCore::FrameLoader::baseURL): (WebCore::FrameLoader::baseTarget): (WebCore::FrameLoader::completeURL): (WebCore::FrameLoader::scheduleRedirection): (WebCore::FrameLoader::scheduleLocationChange): (WebCore::FrameLoader::scheduleRefresh): (WebCore::FrameLoader::isScheduledLocationChangePending): (WebCore::FrameLoader::scheduleHistoryNavigation): (WebCore::FrameLoader::redirectionTimerFired): (WebCore::FrameLoader::encoding): (WebCore::FrameLoader::requestObject): (WebCore::FrameLoader::shouldUsePlugin): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::clearRecordedFormValues): (WebCore::FrameLoader::recordFormValue): (WebCore::FrameLoader::parentCompleted): (WebCore::FrameLoader::outgoingReferrer): (WebCore::FrameLoader::lastModified): (WebCore::FrameLoader::opener): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::openedByJavaScript): (WebCore::FrameLoader::setOpenedByJavaScript): (WebCore::FrameLoader::handleFallbackContent): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::userGestureHint): (WebCore::FrameLoader::didNotOpenURL): (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::setEncoding): (WebCore::FrameLoader::addData): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::updatePolicyBaseURL): (WebCore::FrameLoader::setPolicyBaseURL): (WebCore::FrameLoader::scrollToAnchor): (WebCore::FrameLoader::isComplete): (WebCore::FrameLoader::isLoadingMainResource): (WebCore::FrameLoader::url): (WebCore::FrameLoader::startRedirectionTimer): (WebCore::FrameLoader::stopRedirectionTimer): (WebCore::FrameLoader::updateBaseURLForEmptyDocument): (WebCore::FrameLoader::completed): (WebCore::FrameLoader::started): (WebCore::FrameLoader::containsPlugins): (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::setupForReplace): (WebCore::FrameLoader::setupForReplaceByMIMEType): (WebCore::FrameLoader::finalSetupForReplace): (WebCore::FrameLoader::load): (WebCore::FrameLoader::canTarget): (WebCore::FrameLoader::stopLoadingPlugIns): (WebCore::FrameLoader::stopLoadingSubresources): (WebCore::FrameLoader::stopLoadingSubframes): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::activeDocumentLoader): (WebCore::FrameLoader::addPlugInStreamLoader): (WebCore::FrameLoader::removePlugInStreamLoader): (WebCore::FrameLoader::hasMainResourceLoader): (WebCore::FrameLoader::isLoadingSubresources): (WebCore::FrameLoader::isLoadingPlugIns): (WebCore::FrameLoader::isLoading): (WebCore::FrameLoader::addSubresourceLoader): (WebCore::FrameLoader::removeSubresourceLoader): (WebCore::FrameLoader::releaseMainResourceLoader): (WebCore::FrameLoader::setDocumentLoader): (WebCore::FrameLoader::documentLoader): (WebCore::FrameLoader::setPolicyDocumentLoader): (WebCore::FrameLoader::provisionalDocumentLoader): (WebCore::FrameLoader::setProvisionalDocumentLoader): (WebCore::FrameLoader::state): (WebCore::FrameLoader::timeOfLastCompletedLoad): (WebCore::FrameLoader::setState): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::markLoadComplete): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::privateBrowsingEnabled): (WebCore::FrameLoader::clientRedirectCancelledOrFinished): (WebCore::FrameLoader::clientRedirected): (WebCore::FrameLoader::shouldReload): (WebCore::FrameLoader::closeOldDataSources): (WebCore::FrameLoader::open): (WebCore::FrameLoader::isStopping): (WebCore::FrameLoader::finishedLoading): (WebCore::FrameLoader::URL): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::isHostedByObjectElement): (WebCore::FrameLoader::isLoadingMainFrame): (WebCore::FrameLoader::canShowMIMEType): (WebCore::FrameLoader::representationExistsForURLScheme): (WebCore::FrameLoader::generatedMIMETypeForURLScheme): (WebCore::FrameLoader::cancelContentPolicyCheck): (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame): (WebCore::FrameLoader::finishedLoadingDocument): (WebCore::FrameLoader::isReplacing): (WebCore::FrameLoader::setReplacing): (WebCore::FrameLoader::revertToProvisional): (WebCore::FrameLoader::subframeIsLoading): (WebCore::FrameLoader::willChangeTitle): (WebCore::FrameLoader::loadType): (WebCore::FrameLoader::stopPolicyCheck): (WebCore::FrameLoader::continueAfterContentPolicy): (WebCore::FrameLoader::continueAfterWillSubmitForm): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::frameLoadCompleted): (WebCore::FrameLoader::firstLayoutDone): (WebCore::FrameLoader::isQuickRedirectComing): (WebCore::FrameLoader::closeDocument): (WebCore::FrameLoader::detachChildren): (WebCore::FrameLoader::checkLoadComplete): (WebCore::FrameLoader::numPendingOrLoadingRequests): (WebCore::FrameLoader::setClient): (WebCore::FrameLoader::client): (WebCore::FrameLoader::userAgent): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::tokenizerProcessedData): (WebCore::FrameLoader::didTellBridgeAboutLoad): (WebCore::FrameLoader::haveToldBridgeAboutLoad): (WebCore::FrameLoader::handledOnloadEvents): (WebCore::FrameLoader::frameDetached): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoaderClient::~FrameLoaderClient):
  • loader/FrameLoader.h: (WebCore::):
  • loader/FrameLoaderClient.h:
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): (WebCore::PluginTokenizer::writeRawData):
  • loader/ResourceLoader.h:
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::finishLoading):
  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse):
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::setPrimaryLoadComplete):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::nsArray): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::mainResourceData): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFinishLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): (WebCore::CheckCacheObjectStatus):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::cancel):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • loader/qt/FrameLoaderQt.cpp: Added. (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::originalRequestURL):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::document):
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::prepareForUserAction): (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::layout): (WebCore::FrameView::mediaType):
  • page/FrameView.h:
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restoreJavaScriptState):
  • platform/mac/CookieJar.mm: (WebCore::setCookies):
  • platform/mac/TextCodecMac.cpp:
  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start):
  • platform/qt/FrameQt.cpp:
  • platform/qt/FrameQt.h:
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/RenderBlock.h:
  • rendering/RenderPartObject.cpp: (WebCore::isURLAllowed): (WebCore::RenderPartObject::updateWidget):
  • xml/DOMParser.cpp: (WebCore::DOMParser::parseFromString):
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML):

WebKit:

Reviewed by Geoff.

  • udpated for changes to move from Frame/FrameMac to FrameLoader
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView requestWithURLCString:]):
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView didStart]):
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::provisionalLoadStarted):
  • WebView/WebFrame.mm: (-[WebFrame _canCachePage]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _reloadForPluginChanges]): (-[WebFrame stopLoading]):
19:36 Coding Style Guidelines edited by aroben@apple.com
(diff)
19:05 Changeset [17651] by andersca

WebCore:

Reviewed by Geoff.

Get rid of some duplicate editing enums. Also rename EAlter to EAlteration.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::direction:SelectionController::granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:SelectionController::verticalDistance:]): (-[WebCoreFrameBridge selectionGranularity]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]): (-[WebCoreFrameBridge applyStyle:withUndoAction:]): (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]):
  • editing/SelectionController.cpp: (WebCore::SelectionController::setModifyBias): (WebCore::SelectionController::modify):
  • editing/SelectionController.h: (WebCore::SelectionController::):
  • editing/TextGranularity.h:

WebKit:

Reviewed by Geoff.

Use the WebCore editing enums.


  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge undoNameForEditAction:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]): (-[WebHTMLView _deleteSelection]): (-[WebHTMLView moveBackward:]): (-[WebHTMLView moveBackwardAndModifySelection:]): (-[WebHTMLView moveDown:]): (-[WebHTMLView moveDownAndModifySelection:]): (-[WebHTMLView moveForward:]): (-[WebHTMLView moveForwardAndModifySelection:]): (-[WebHTMLView moveLeft:]): (-[WebHTMLView moveLeftAndModifySelection:]): (-[WebHTMLView moveRight:]): (-[WebHTMLView moveRightAndModifySelection:]): (-[WebHTMLView moveToBeginningOfDocument:]): (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]): (-[WebHTMLView moveToBeginningOfSentence:]): (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]): (-[WebHTMLView moveToBeginningOfLine:]): (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]): (-[WebHTMLView moveToBeginningOfParagraph:]): (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]): (-[WebHTMLView moveToEndOfDocument:]): (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]): (-[WebHTMLView moveToEndOfSentence:]): (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]): (-[WebHTMLView moveToEndOfLine:]): (-[WebHTMLView moveToEndOfLineAndModifySelection:]): (-[WebHTMLView moveToEndOfParagraph:]): (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]): (-[WebHTMLView moveParagraphBackwardAndModifySelection:]): (-[WebHTMLView moveParagraphForwardAndModifySelection:]): (-[WebHTMLView moveUp:]): (-[WebHTMLView moveUpAndModifySelection:]): (-[WebHTMLView moveWordBackward:]): (-[WebHTMLView moveWordBackwardAndModifySelection:]): (-[WebHTMLView moveWordForward:]): (-[WebHTMLView moveWordForwardAndModifySelection:]): (-[WebHTMLView moveWordLeft:]): (-[WebHTMLView moveWordLeftAndModifySelection:]): (-[WebHTMLView moveWordRight:]): (-[WebHTMLView moveWordRightAndModifySelection:]): (-[WebHTMLView pageUp:]): (-[WebHTMLView pageDown:]): (-[WebHTMLView pageUpAndModifySelection:]): (-[WebHTMLView pageDownAndModifySelection:]): (-[WebHTMLView _expandSelectionToGranularity:]): (-[WebHTMLView selectParagraph:]): (-[WebHTMLView selectLine:]): (-[WebHTMLView selectSentence:]): (-[WebHTMLView selectWord:]): (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]): (-[WebHTMLView _toggleBold]): (-[WebHTMLView _toggleItalic]): (-[WebHTMLView pasteFont:]): (-[WebHTMLView changeFont:]): (-[WebHTMLView changeAttributes:]): (-[WebHTMLView _undoActionFromColorPanelWithSelector:]): (-[WebHTMLView changeColor:]): (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]): (-[WebHTMLView alignCenter:]): (-[WebHTMLView alignJustified:]): (-[WebHTMLView alignLeft:]): (-[WebHTMLView alignRight:]): (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]): (-[WebHTMLView deleteForward:]): (-[WebHTMLView deleteBackward:]): (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]): (-[WebHTMLView deleteToBeginningOfLine:]): (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToBeginningOfParagraph:]): (-[WebHTMLView deleteToEndOfParagraph:]): (-[WebHTMLView subscript:]): (-[WebHTMLView superscript:]): (-[WebHTMLView unscript:]): (-[WebHTMLView underline:]): (-[WebHTMLView deleteToMark:]): (-[WebHTMLView toggleBaseWritingDirection:]): (-[WebHTMLView changeBaseWritingDirection:]): (-[WebHTMLView _canSmartCopyOrDelete]): (-[WebTextCompleteController doCompletion]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: (-[WebView setTypingStyle:]): (-[WebView applyStyle:]):
17:34 WikiStart edited by pewtermoose@gmail.com
Add link to Web Inspector (diff)
17:33 Web Inspector created by pewtermoose@gmail.com
17:18 Coding Style Guidelines edited by bdash@webkit.org
(diff)
17:13 Coding Style Guidelines edited by sam@webkit.org
Add ToC (diff)
17:12 Coding Style Guidelines edited by sam@webkit.org
(diff)
17:02 Nightly Builds edited by bdash@webkit.org
(diff)
17:01 WikiStart edited by bdash@webkit.org
Remove outdated link (diff)
16:52 Coding Style Guidelines edited by sam@webkit.org
Finish port of Coding Style Guidelines (diff)
16:52 Changeset [17650] by beidson

Reviewed by Maciej

Changed the check for "top level frame" to something much more valid

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
16:25 Coding Style Guidelines edited by sam@webkit.org
More Code Style Guidlines porting (diff)
16:21 Changeset [22487] by andersca

WebCoreWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Let the Frame client know when the window object is available.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::partClearedInBegin):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::markMisspellings): (FrameWin::restoreDocumentState):

WebKitWin:

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Call IWebFrameLoadDelegate::windowScriptObject available when the
window script object is available.


  • Interfaces/IWebFrameLoadDelegate.idl: Get MIDL to understand the JSC API types.


  • WebFrame.cpp: (WebFrame::windowScriptObjectAvailable): Call into the delegate.


  • WebFrame.h:
16:06 Coding Style Guidelines created by sam@webkit.org
First wack at transfering Style Guildlines to the Wiki
15:52 Changeset [17649] by andersca

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Initialize cachedPrototype to 0.
15:42 Changeset [22486] by aroben

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Remove no-longer-needed stub.
15:39 WikiStart edited by sam@webkit.org
(diff)
15:05 Applications using WebKit edited by bradley.morrison@nokia.com
added web browser for s60 (diff)
14:44 Changeset [17648] by harrison

Updated.


  • editing/pasteboard/4076267-2-expected.checksum:
  • editing/pasteboard/4076267-2-expected.png:
  • editing/pasteboard/4076267-2-expected.txt:
14:24 Changeset [17647] by bdakin

Reviewed by Hyatt (yesterday).

Here is part of my patch from yesterday that is safe to roll back
in. It will make the BuildBot happy.

  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.
13:07 Changeset [17646] by darin
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): Comment grammar fix.
13:05 Changeset [17645] by darin

LayoutTests:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

WebCore:

Rolled out change for <rdar://problem/4820814>.

Beth's planning on landing a new change for it soon, but in the mean time
we need layout tests succeeding again.

12:41 Changeset [17644] by darin

Reviewed by Brady.

  • fix <rdar://problem/4752069> 9A274: World of Warcraft Launcher crashes on launch in WebCore::ResourceLoader::start

No layout test, because this depends on cached icons, although there's
perhaps a way to write a test for it with some further ingenuity.

  • loader/icon/IconLoader.h: Make IconLoader inherit from Noncopyable to make explicit the fact that it can't be successfully copied. Remove notifyIconChanged function and put the contents in the caller. This eliminates the need for IconLoaderMac.mm. Added finishedLoading and clearLoadingState functions to share code. Removed m_url, since the resource handle already stores the URL. Renamed m_resourceLoader to m_handle to reflect the class's name change. Removed the 4096-byte inline buffer from m_data, since the malloc savings is not sufficient to offset the additional memory use. Removed m_httpStatusCode because we can instead cancel the load when we get a status code that reflects failure. Added m_loadIsInProgress boolean because we need to detect loads that complete during the ResourceHandle::create function call.
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::IconLoader): Initialize m_loadIsInProgress. Don't initialize m_httpStatusCode. (WebCore::IconLoader::~IconLoader): Updated for name change. (WebCore::IconLoader::startLoading): Added code to use the m_loadIsInProgress flag to detect if the load completed while inside the ResourceHandle::create function. Removed code to set m_url. (WebCore::IconLoader::stopLoading): Call clearLoadingState to share more code. (WebCore::IconLoader::didReceiveResponse): Kill the ResourceHandle and finish loading if the HTTP status code indicates failure. (WebCore::IconLoader::didReceiveData): Removed assertion that checks the ResourceHandle, since we can't do that any more. (WebCore::IconLoader::didFinishLoading): Changed to call finishLoading so we can share code with the new didReceiveResponse code path. (WebCore::IconLoader::finishLoading): Moved code here from the didFinishLoading callback. Pass a URL when calling commitIconURLToIconDatabase. Call notifyIconChanged directly here instead of using a separate function. Call clearLoadingState to share more code with stopLoading. (WebCore::IconLoader::clearLoadingState): Added.
  • loader/mac/IconLoaderMac.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed IconLoaderMac.mm.
11:32 Changeset [17643] by harrison

LayoutTests:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt:

WebCore:

Reviewed by Darin.

<rdar://problem/4714993> REGRESSION: After replacing a misspelled word in a sentence, the selected word wraps down to next line (10428)

  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/8145-1-expected.txt:
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Removed.
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt: Updated because pasting text with no newlines does not use intermediate div.


  • editing/markup.cpp: (WebCore::fillContainerFromString): First parameter is now a Container so a fragment can be passed.


(WebCore::createFragmentFromText):
A string with no newlines gets added inline, rather than being put into a paragraph.

10:39 Changeset [17642] by ap

2006-11-07 Mitz Pettel <mitz@webkit.org>

Reviewed by Beth.

Test for http://bugs.webkit.org/show_bug.cgi?id=11505
REGRESSION: Null pointer deref in HitTestResult::spellingToolTip() (assertion failure in Node::document)

The null check was added as part for the fix for <rdar://problem/4820814>,
however the test that was committed with the fix avoids the case of a null
m_innerNonSharedNode, which this test covers.

  • fast/css-generated-content/spellingToolTip-assert-expected.checksum: Added.
  • fast/css-generated-content/spellingToolTip-assert-expected.png: Added.
  • fast/css-generated-content/spellingToolTip-assert-expected.txt: Added.
  • fast/css-generated-content/spellingToolTip-assert.html: Added.
02:47 Changeset [17641] by bdash

2006-11-07 Mark Rowe <bdash@webkit.org>

Reviewed by Dave Hyatt.

  • projects/javascript/index.html: Update link to non-existent JavaScript Bugzilla component to the correct JavaScriptCore.
00:36 Changeset [22485] by sfalken
Note: See TracTimeline for information about the timeline view.