Timeline


and

11/12/06:

23:13 Changeset [17746] by beidson
  • 3 edits in trunk/WebKit

Rubberstamped by Anders

Changed some #includes from <WebKit/foo.h> to "foo.h"

  • History/WebBackForwardList.m:
  • History/WebHistory.m:
18:57 Changeset [22529] by ggaren
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebChromeClient.cpp: Fixed up #include.
18:54 Changeset [22528] by ggaren
  • 12 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve Falkenberg.

Implemented window.open. Rough around the edges right now.

  • Converted WebMutableURLRequest to use a ResourceRequest as its backing store, to avoid yet another way of representing this data.
  • Changed WebMutableURLRequests's timeoutInterval to double, to match ResourceRequest and NSURLRequest.
  • Added BSTRToKURL and KURLToBSTR helper functions.
  • Added page accessor on WebView, and core(), for converting from WebView to page.
  • MarshallingHelpers.h: Removed unnecessary variable names from declarations.
15:49 Changeset [22527] by ggaren
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

Reviewed by Steven Falkenberg.


Fixed up work-arounds to MSVC warning silliness.


Replaced in-place disabling of "conditional expression is constant" warning
with project-wide setting. (We use do { } while(0); for macro scoping.)


Replaced in-place and project-wide disabling of "xxx was declared deprecated"
warning with project-wide setting only to disable Microsoft's made-up deprecation

warnings related to std
functions.
  • WebChromeClient.cpp: (WebChromeClient::setResizable):
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.h:
15:44 Changeset [17745] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
08:47 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added bug number for navigationController issue (diff)
08:45 Writing Layout Tests for DumpRenderTree created by mitz@webkit.org
Copied from Google cache of wiki.opendarwin.org with minimal modifications …
07:18 Changeset [17744] by bdash
  • 7 edits in trunk/WebCore

2006-11-12 Simon Hausmann <hausmann@kde.org>

Reviewed by Sam Weinig.

Fix Qt build. Missing AbstractShared implementation.
http://bugs.webkit.org/show_bug.cgi?id=11581

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::ref): (WebCore::FrameLoaderClientQt::deref):
  • loader/qt/FrameLoaderClientQt.h:
  • platform/qt/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ref): (WebCore::ChromeClientQt::deref):
  • platform/qt/ChromeClientQt.h:
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::ref): (WebCore::EditorClientQt::deref):
  • platform/qt/EditorClientQt.h:
04:39 BuildingOnWindows edited by ap@webkit.org
added a few more needed cygwin packages (diff)
04:29 Changeset [17743] by bdash
  • 4 edits in trunk/WebCore

2006-11-13 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Fix some Linux/Gdk build issues noted by Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
04:19 BuildingOnWindows created by bdash@webkit.org
Rescue Building on Windows page from the old wiki
01:31 Changeset [17742] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Anders

Logging channel plumbing for future work

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
00:47 Changeset [17741] by bdash
  • 16 edits
    1 delete in trunk

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/PageState.cpp:
  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::ref): (WebCore::ChromeClientGdk::deref):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::~FrameGdk):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
  • platform/gdk/ScreenClientGdk.h: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::canPaste): (FrameGdk::originalRequestURL): (TextField::TextField):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • webcore-base.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of JavaScriptCore bakefiles.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of GdkLauncher bakefile.

  • GdkLauncher/gdklauncher.bkl:

11/11/06:

20:59 Changeset [22526] by ggaren
  • 29 edits in branches/WindowsMerge

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/4831461> Crash in FrameLoader::~FrameLoader when navigating away from ebay.com
  • Changed WebKit clients to match new virtual ref/deref scheme in WebCore.
  • Removed WebEditorClient from the WebCore namespace because it's a WebKit class, not a WebCore class.
  • Standardized some header #includes to match Mac:
    • alphabetical
    • config.h, WebKitDLL.h, and class headers go together at the top
    • everything else comes after a line break
20:53 Changeset [17740] by ggaren
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Fixed up function prototypes for style.
  • loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose was to implement an alternative ownership model. (WebCore::FrameLoader::~FrameLoader): Removed empty destructor. (WebCore::FrameLoader::setClient): This function now takes ownership (WebCore::FrameLoader::client):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/ChromeClient.h:
  • platform/AbstractShared.h: Added. This is the virtual function-based refcounting complement to Shared. (WebCore::AbstractShared::~AbstractShared):

WebKit:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::ref): (WebChromeClient::deref): (WebChromeClient::refCount):
  • WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes. The ones in WebCore make clear what remains to be implemented. Replaced constructor with factory function to avoid leaks.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::create): (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
  • WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory function to avoid leaks. (WebFrameLoaderClient::ref): (WebFrameLoaderClient::deref): (WebFrameLoaderClient::refCount):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::create):
  • WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
16:13 Changeset [17739] by staikos
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix uninitialized variable.

  • rendering/RenderStyle.h:
14:54 Changeset [22525] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Remove conflict markers

14:50 Changeset [22524] by andersca
  • 7 edits in branches/WindowsMerge

WebCoreWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Rename keyPress to keyEvent, it's used for both key presses
and releases.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • bridge/win/FrameWin.h:

WebKitWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Clean up the event handling code.


  • WebEditorClient.cpp: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::shouldApplyStyle): Change these to return true. Eventually they will call the editing delegate.


  • WebView.cpp: (WebView::execCommand): Update to call the editor's execCommand.


(WebView::keyUp):
New function that forwards the event to FrameWin.


(editCommandForKey):
New function that given a key returns an edit command from a table. Eventually this table
should be moved into WebCore.


(WebView::handleEditingKeyboardEvent):
New function that handles editing events.


(WebView::keyDown):
If the frame is editable, call handleEditingKeyboardEvent.


(WebViewWndProc):

  • WebView.h:
13:34 Changeset [17738] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Grammar fix.

13:32 Changeset [17737] by aroben
  • 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.

General style cleanup, remove all tabs etc.

  • CMakeLists.txt:
13:32 Changeset [17736] by ddkilzer
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.

13:28 Changeset [17735] by ddkilzer
  • 4 edits in trunk

Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.

13:17 Changeset [22523] by aroben
  • 30 edits
    3 moves
    1 add in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

Move graphics-related files to platform/graphics to stay in sync with
changes from OpenSource r17727.

Also, as discussed with Darin and Steve, we now copy all our headers to
a flat include/WebCore directory instead of copying the directory
structure of WebCore. This mirrors how Mac builds.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/cg/ColorCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/win/IconWin.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.

WebKitWin:

Reviewed by Geoff.

Update WebCore #includes to use a flat directory structure.

  • DOMCSSClasses.cpp:
  • DOMCSSClasses.h:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebDataSource.cpp:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebHTMLRepresentation.cpp:
  • WebHistory.cpp:
  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
11:10 Changeset [17734] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed and landed by Anders.

Make DRT work again on Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
10:36 Changeset [17733] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.


Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
10:08 Changeset [17732] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed header guard

  • loader/FrameLoaderClient.h:
08:52 Changeset [22522] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • blind attempt to fix the build
  • platform/win/CursorWin.cpp: (WebCore::verticalTextCursor): Added. Just returns the pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
08:48 Changeset [17731] by darin
  • 2 edits in trunk/WebCore
  • attempt to fix Qt build
  • platform/qt/CursorQt.cpp: (WebCore::verticalTextCursor): Added. Just returns pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
07:49 Changeset [17730] by rwlbuis
  • 6 edits
    3 adds in trunk

Reviewed by hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

07:31 Changeset [17729] by ap
  • 2 edits in trunk/WebCore

Attempt to fix Qt build.

  • CMakeLists.txt: PathQt.cpp is in graphics/qt now.
07:15 Changeset [17728] by ap
  • 9 edits
    3 adds in trunk/WebCore

2006-11-11 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)

[CSS 3] support for vertical-text, cell and context-menu cursors
http://bugs.webkit.org/show_bug.cgi?id=11494

  • Resources/cellCursor.png: Added.
  • Resources/contextMenuCursor.png: Added.
  • Resources/verticalTextCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor):
  • rendering/RenderStyle.h: (WebCore::):
06:31 Changeset [17727] by ap
  • 4 edits
    50 moves
    4 adds in trunk/WebCore

2006-11-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by aroben and ap, landed by ap.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468

Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.cpp: Removed.
  • platform/AffineTransform.h: Removed.
  • platform/Color.cpp: Removed.
  • platform/Color.h: Removed.
  • platform/FloatPoint.cpp: Removed.
  • platform/FloatPoint.h: Removed.
  • platform/FloatRect.cpp: Removed.
  • platform/FloatRect.h: Removed.
  • platform/FloatSize.cpp: Removed.
  • platform/FloatSize.h: Removed.
  • platform/Icon.h: Removed.
  • platform/Image.cpp: Removed.
  • platform/Image.h: Removed.
  • platform/ImageSource.h: Removed.
  • platform/IntPoint.h: Removed.
  • platform/IntRect.cpp: Removed.
  • platform/IntRect.h: Removed.
  • platform/IntSize.h: Removed.
  • platform/IntSizeHash.h: Removed.
  • platform/Path.cpp: Removed.
  • platform/Path.h: Removed.
  • platform/Pen.cpp: Removed.
  • platform/Pen.h: Removed.
  • platform/cairo/AffineTransformCairo.cpp: Removed.
  • platform/cairo/GraphicsContextCairo.cpp: Removed.
  • platform/cairo/ImageCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Removed.
  • platform/cairo/cairo/AUTHORS: Removed.
  • platform/cairo/cairo/COPYING: Removed.
  • platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
  • platform/cairo/cairo/COPYING-MPL-1.1: Removed.
  • platform/cairo/cairo/INSTALL: Removed.
  • platform/cairo/cairo/NEWS: Removed.
  • platform/cairo/cairo/README: Removed.
  • platform/cairo/cairo/TODO: Removed.
  • platform/cairo/cairo/src/Makefile.in: Removed.
  • platform/cairo/cairo/src/cairo-arc-private.h: Removed.
  • platform/cairo/cairo/src/cairo-arc.c: Removed.
  • platform/cairo/cairo/src/cairo-array.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui.h: Removed.
  • platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
  • platform/cairo/cairo/src/cairo-beos.h: Removed.
  • platform/cairo/cairo/src/cairo-cache-private.h: Removed.
  • platform/cairo/cairo/src/cairo-cache.c: Removed.
  • platform/cairo/cairo/src/cairo-clip-private.h: Removed.
  • platform/cairo/cairo/src/cairo-clip.c: Removed.
  • platform/cairo/cairo/src/cairo-color.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.h: Removed.
  • platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-directfb.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h.in: Removed.
  • platform/cairo/cairo/src/cairo-fixed.c: Removed.
  • platform/cairo/cairo/src/cairo-font-options.c: Removed.
  • platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
  • platform/cairo/cairo/src/cairo-font-subset.c: Removed.
  • platform/cairo/cairo/src/cairo-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ft.h: Removed.
  • platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-glitz.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate.c: Removed.
  • platform/cairo/cairo/src/cairo-hash-private.h: Removed.
  • platform/cairo/cairo/src/cairo-hash.c: Removed.
  • platform/cairo/cairo/src/cairo-hull.c: Removed.
  • platform/cairo/cairo/src/cairo-image-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-matrix.c: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-output-stream.c: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
  • platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-data.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fill.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
  • platform/cairo/cairo/src/cairo-path.c: Removed.
  • platform/cairo/cairo/src/cairo-pattern.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf.h: Removed.
  • platform/cairo/cairo/src/cairo-pen.c: Removed.
  • platform/cairo/cairo/src/cairo-platform.h: Removed.
  • platform/cairo/cairo/src/cairo-png.c: Removed.
  • platform/cairo/cairo/src/cairo-polygon.c: Removed.
  • platform/cairo/cairo/src/cairo-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-ps.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz2.h: Removed.
  • platform/cairo/cairo/src/cairo-region.c: Removed.
  • platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
  • platform/cairo/cairo/src/cairo-slope.c: Removed.
  • platform/cairo/cairo/src/cairo-spline.c: Removed.
  • platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
  • platform/cairo/cairo/src/cairo-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg.h: Removed.
  • platform/cairo/cairo/src/cairo-traps.c: Removed.
  • platform/cairo/cairo/src/cairo-unicode.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-font.c: Removed.
  • platform/cairo/cairo/src/cairo-win32-private.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-win32.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib.h: Removed.
  • platform/cairo/cairo/src/cairo.c: Removed.
  • platform/cairo/cairo/src/cairo.h: Removed.
  • platform/cairo/cairo/src/cairoint.h: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.c: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.h: Removed.
  • platform/cairo/cairo/src/test-meta-surface.c: Removed.
  • platform/cairo/cairo/src/test-meta-surface.h: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.h: Removed.
  • platform/cairo/pixman/AUTHORS: Removed.
  • platform/cairo/pixman/COPYING: Removed.
  • platform/cairo/pixman/README: Removed.
  • platform/cairo/pixman/src/Makefile.in: Removed.
  • platform/cairo/pixman/src/fbcompose.c: Removed.
  • platform/cairo/pixman/src/fbedge.c: Removed.
  • platform/cairo/pixman/src/fbedgeimp.h: Removed.
  • platform/cairo/pixman/src/fbmmx.c: Removed.
  • platform/cairo/pixman/src/fbmmx.h: Removed.
  • platform/cairo/pixman/src/fbpict.c: Removed.
  • platform/cairo/pixman/src/fbpict.h: Removed.
  • platform/cairo/pixman/src/fbtrap.c: Removed.
  • platform/cairo/pixman/src/icblt.c: Removed.
  • platform/cairo/pixman/src/icbltone.c: Removed.
  • platform/cairo/pixman/src/iccolor.c: Removed.
  • platform/cairo/pixman/src/icformat.c: Removed.
  • platform/cairo/pixman/src/icimage.c: Removed.
  • platform/cairo/pixman/src/icimage.h: Removed.
  • platform/cairo/pixman/src/icint.h: Removed.
  • platform/cairo/pixman/src/icpixels.c: Removed.
  • platform/cairo/pixman/src/icrect.c: Removed.
  • platform/cairo/pixman/src/icrop.h: Removed.
  • platform/cairo/pixman/src/icstipple.c: Removed.
  • platform/cairo/pixman/src/ictransform.c: Removed.
  • platform/cairo/pixman/src/ictrap.c: Removed.
  • platform/cairo/pixman/src/ictri.c: Removed.
  • platform/cairo/pixman/src/icutil.c: Removed.
  • platform/cairo/pixman/src/pixman-remap.h: Removed.
  • platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
  • platform/cairo/pixman/src/pixman.h: Removed.
  • platform/cairo/pixman/src/pixregion.c: Removed.
  • platform/cairo/pixman/src/pixregionint.h: Removed.
  • platform/cairo/pixman/src/renderedge.c: Removed.
  • platform/cairo/pixman/src/renderedge.h: Removed.
  • platform/cairo/pixman/src/slim_internal.h: Removed.
  • platform/cairo/rgb24-hacks.txt: Removed.
  • platform/cairo/scale-removal.txt: Removed.
  • platform/cg/AffineTransformCG.cpp: Removed.
  • platform/cg/FloatPointCG.cpp: Removed.
  • platform/cg/FloatRectCG.cpp: Removed.
  • platform/cg/FloatSizeCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/cg/ImageCG.cpp: Removed.
  • platform/cg/ImageSourceCG.cpp: Removed.
  • platform/cg/IntPointCG.cpp: Removed.
  • platform/cg/IntRectCG.cpp: Removed.
  • platform/cg/IntSizeCG.cpp: Removed.
  • platform/cg/PDFDocumentImage.cpp: Removed.
  • platform/cg/PDFDocumentImage.h: Removed.
  • platform/cg/PathCG.cpp: Removed.
  • platform/gdk/ImageGdk.cpp: Removed.
  • platform/mac/ColorMac.mm: Removed.
  • platform/mac/FloatPointMac.mm: Removed.
  • platform/mac/FloatRectMac.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Removed.
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/IconMac.mm: Removed.
  • platform/mac/ImageMac.mm: Removed.
  • platform/mac/IntPointMac.mm: Removed.
  • platform/mac/IntRectMac.mm: Removed.
  • platform/mac/IntSizeMac.mm: Removed.
  • platform/qt/AffineTransformQt.cpp: Removed.
  • platform/qt/ColorQt.cpp: Removed.
  • platform/qt/FloatPointQt.cpp: Removed.
  • platform/qt/FloatRectQt.cpp: Removed.
  • platform/qt/IconQt.cpp: Removed.
  • platform/qt/ImageQt.cpp: Removed.
  • platform/qt/ImageSourceQt.cpp: Removed.
  • platform/qt/IntPointQt.cpp: Removed.
  • platform/qt/IntRectQt.cpp: Removed.
  • platform/qt/IntSizeQt.cpp: Removed.
  • platform/qt/PathQt.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.
  • platform/win/IntPointWin.cpp: Removed.
  • platform/win/IntRectWin.cpp: Removed.
  • platform/win/IntSizeWin.cpp: Removed.
05:10 Changeset [17726] by gdennis
  • 1 edit in trunk/WebCore/rendering/RenderText.cpp

Build fix.

04:34 Changeset [17725] by gdennis
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by hyatt.

A layout test was added when this bug was fixed, so none needed now.


Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570


  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Removed.
  • rendering/RenderText.cpp: (WebCore::isSpace): Added. (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
04:04 Changeset [17724] by gdennis
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by mitz.


REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Added.
  • rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'

LayoutTests:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
00:50 Changeset [17723] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h

Fix suggested by Don Gibson.

  • kjs/JSImmediate.h: Re-enable all MSVC warnings, move the remaining runtime checks to compile-time.

11/10/06:

19:11 Changeset [22521] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
18:55 Changeset [17722] by bdash
  • 14 edits
    9 adds in trunk

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • wtf/Platform.h:

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • config.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
  • platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
  • platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
  • platform/StringImpl.h:
  • platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
  • platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
  • platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
  • platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
  • platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
  • platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
  • platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
  • platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):
18:33 Changeset [17721] by bdash
  • 6 edits in trunk

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
  • loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
17:56 Changeset [17720] by justing
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

  • editing/deleting/delete-link-1-expected.checksum: Added.
  • editing/deleting/delete-link-1-expected.png: Added.
  • editing/deleting/delete-link-1-expected.txt: Added.
  • editing/deleting/delete-link-1.html: Added.
  • editing/inserting/insert-before-link-1-expected.checksum: Added.
  • editing/inserting/insert-before-link-1-expected.png: Added.
  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself


The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
  • editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.
17:33 Changeset [22520] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
17:19 Changeset [17719] by thatcher
  • 1 edit
    9 copies in tags/Safari-521.30

New tag.

17:18 Changeset [17718] by thatcher
  • 6 edits in /

Versioning.

17:15 Changeset [17717] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:51 Changeset [17716] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:20 Changeset [17715] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

16:11 Changeset [22519] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
  • WebIconDatabase.h:
16:10 Changeset [17714] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

64-bit build fix. Generates a derived export file for 64-bit architectures.

16:01 Changeset [22518] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-10 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
  • platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):
15:45 Changeset [17713] by aroben
  • 4 edits in trunk/WebCore

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

  • page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
15:36 Changeset [17712] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Anders.


  • remove some unnecessary uses of WebDataProtocol
  • WebView/WebDataSource.mm: Remove the unneeded include.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.
15:20 Changeset [17711] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
  • editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):
14:29 Changeset [17710] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-10 spaltis <Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
http://bugs.webkit.org/show_bug.cgi?id=11568

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):
13:53 Changeset [17709] by sfalken
  • 1 copy in tags/Safari-521.30b

New tag.

13:51 Changeset [22517] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Steve Falkenburg <sfalken@apple.com>

Bump version number for submission

  • VERSION:
  • WebKit.vcproj/VERSION:
13:35 Changeset [22516] by ggaren
  • 14 edits in branches/WindowsMerge/WebKitWin

Oops. Checked in too much. Rolling out the extra.

13:33 Changeset [22515] by ggaren
  • 15 edits in branches/WindowsMerge/WebKitWin

Fixed build -- you can't delete the shared icon database -- it's a singleton

13:12 Changeset [17708] by ggaren
  • 1 edit in trunk/WebCore/platform/MimeTypeRegistry.cpp

Fixed platform #ifs

13:07 Changeset [17707] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
13:00 Changeset [17706] by spadma
  • 4 edits in S60/trunk/WebKit

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
11:45 Changeset [17705] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
  • editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.


  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):
11:31 Changeset [22514] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin

Keep windows build from breaking

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
  • WebFrame.h:
11:24 Changeset [17704] by beidson
  • 14 edits
    1 add
    4 deletes in trunk

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
  • loader/FrameLoaderClient.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
  • loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin


Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
  • Misc/WebIconDatabaseInternal.h: Added.
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed.
  • WebCoreSupport/WebIconDatabaseBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
11:16 Changeset [17703] by andersca
  • 22 edits
    8 adds in trunk

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

  • CMakeLists.txt:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
  • loader/qt/FrameLoaderClientQt.h: Added.
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
  • platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
  • platform/qt/ChromeClientQt.h: Added.
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/ImageQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
  • platform/qt/PageQt.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
  • platform/qt/ScreenQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):
00:42 Changeset [17702] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mitz

http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.
00:22 Changeset [22513] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-10 Oliver Hunt <oliver@apple.com>

Build fix


sprintf -> format (from Maciej's earlier change to WebCore)

  • WebView.cpp: (osVersion): (WebView::userAgentForKURL):

11/09/06:

23:33 Changeset [22512] by oliver
  • 4 edits
    1 add in branches/WindowsMerge/WebCore

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Added Windows side of MIME Type registry, and updated
objectContentType and ImageWin to make use of it


This fixes <rdar://problem/4791483>

  • WebCore.vcproj/WebCore.vcproj:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::objectContentType):
  • platform/win/ImageWin.cpp:
  • platform/win/MimeTypeRegistryWin.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::mimeTypeForExtension): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


23:31 Changeset [17701] by oliver
  • 14 edits
    5 adds in trunk

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Pulled MIME type handling out of WebFrameBridge and added
a general C++ class to store/query MIME info
Added an Obj-C bridge to provide WebKit with access to the
MimeTypeRegistry for non-Obj-C++ classes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebMimeTypeRegistryBridge.h: Added.
  • bridge/mac/WebMimeTypeRegistryBridge.mm: Added. (+[WebMimeTypeRegistryBridge supportsImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportsNonImageWithMIMEType:]): (+[WebMimeTypeRegistryBridge supportedNonImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageMIMETypes]): (+[WebMimeTypeRegistryBridge supportedImageResourceMIMETypes]):
  • platform/Image.cpp: (WebCore::Image::supportsType):
  • platform/Image.h:
  • platform/MimeTypeRegistry.cpp: Added. (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes): (WebCore::initialiseMimeTypeRegistry): (WebCore::MimeTypeRegistry::isSupportedImageMIMEType): (WebCore::MimeTypeRegistry::isSupportedImageResourceMIMEType): (WebCore::MimeTypeRegistry::isSupportedNonImageMIMEType): (WebCore::MimeTypeRegistry::getSupportedImageMIMETypes): (WebCore::MimeTypeRegistry::getSupportedImageResourceMIMETypes): (WebCore::MimeTypeRegistry::getSupportedNonImageMIMETypes):
  • platform/MimeTypeRegistry.h: Added.
  • platform/mac/ImageMac.mm:
  • platform/mac/MimeTypeRegistryMac.mm: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):


Updated to make use of MimeTypeRegistry/bridge

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
  • WebView/WebDataSource.mm: (-[WebDataSource _documentFragmentWithArchive:]):
  • WebView/WebHTMLRepresentation.m: (+[WebHTMLRepresentation supportedNonImageMIMETypes]): (+[WebHTMLRepresentation supportedImageMIMETypes]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _imageExistsAtPaths:]): (-[WebHTMLView _documentFragmentWithPaths:]):


21:17 Changeset [17700] by mjs
  • 28 edits in trunk/WebCore

Reviewed by Oliver.

  • rename String::sprintf and DeprecatedString::sprintf to ...::format to avoid needlessly tweaking a search for insecure functions. Neither of these has risk of buffer overruns since they calculate the buffer size for you and use vsnprintf.
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • css/cssparser.cpp: (WebCore::CSSParser::parseColorFromValue):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::handleError):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
  • ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::toString):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
  • ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::toString):
  • ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::toString):
  • ksvg2/svg/SVGPolyElement.cpp: (WebCore::SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::closeRenderer):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::forgetIconForIconURLFromDatabase):
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setSynchronous):
  • platform/Color.cpp: (WebCore::Color::name):
  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::setNum): (WebCore::DeprecatedString::format):
  • platform/DeprecatedString.h:
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::format): (WebCore::String::number):
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
  • platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::calcMinMaxWidth):
20:14 Changeset [22511] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
18:27 Changeset [22510] by oliver
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.


Fix crash on unknown protocol


  • WebFrame.cpp: (WebFrame::didFailWithError):
18:03 Changeset [22509] by lamadio
  • 4 edits in branches/WindowsMerge

2006-11-09 Lou Amadio <lamadio@apple.com>

Reviewed by mjs
Correct the broken search implementations based on original webkit
<rdar://4827714>

16:30 Changeset [17699] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • fixed "Regression: Can't log into gmail.com"
  • fixed "iBench doesn't report results - tests run but no number is recorded"


  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody): Removed extra ! character.
15:21 Changeset [17698] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Darin

<rdar://problem/4829080>
More loader re-factoring cleanup - WebFramePolicyListener was over-released

  • WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<>
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto (WebFrameLoaderClient::setUpPolicyListener): Ditto (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto
14:58 Changeset [17697] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4805409> REGRESSION: Reproducible crash in
WebCore::RenderBlock::skipWhitespace

Note that this will still crash on Debug builds because it will hit
an assertion failure in editing. (One of the reasons there is no
layout test along with this fix.) There is definitely some editing
wackiness happening. See http://bugs.webkit.org/show_bug.cgi?
id=10144 for updates on the assertion failure bug.

  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::childRemoved): It is possible for a prevRootBox and its prevRootBox to share a lineBreakObj. So instead of just clearing the lineBreakObj of the prevRootBox, cycle through all prevRootBoxs with the same lineBreakObj.
14:30 Changeset [22508] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Put the OpenSource revision in the WebKit.dll version info.

14:06 Changeset [17696] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
14:05 Changeset [17695] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-09 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:The error note ‘Program closed: BrowserNG’ pops up when close BrowserNG from Fast Application Swapping window.
http://bugs.webkit.org/show_bug.cgi?id=11556

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::~CWebKitControl):
13:48 Changeset [17694] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebEditorClient.mm

Build fix.

13:40 Changeset [17693] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
13:37 Changeset [17692] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-09 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by zalan.
DESC: fix brake in chineese variant for google search
http://bugs.webkit.org/show_bug.cgi?id=11414

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
13:11 Changeset [22507] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix line-endings.

  • WebEditorClient.cpp:
12:54 Changeset [22506] by oliver
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-09 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.

Build fixes

  • WebEditorClient.cpp: (WebEditorClient::respondToChangedContents):
  • WebEditorClient.h:
12:51 Changeset [17691] by aroben
  • 3 edits
    1 copy
    3 adds in trunk

LayoutTests:

Reviewed by Geoff.

New test to keep the mistake I made in r17680 from happening again.

  • fast/block/margin-collapse/negative-margins-expected.checksum: Added.
  • fast/block/margin-collapse/negative-margins-expected.png: Added.
  • fast/block/margin-collapse/negative-margins-expected.txt: Added.
  • fast/block/margin-collapse/negative-margins.html: Added.

WebCore:

Reviewed by Geoff.

Fix the change in behavior I caused in r17680 with my build fix.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
11:48 Changeset [17690] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam, Oliver.

Move more functions to Editor.

  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply):
  • editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): (WebCore::dispatchEditableContentChangedEvents): (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
  • editing/Editor.h:
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::typingAddedToOpenCommand):
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Adam, Oliver.

Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
instead of just passing the WebView.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame): (WebEditorClient::isContinuousSpellCheckingEnabled): (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::didEndEditing):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
11:00 Changeset [22505] by lamadio
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-08 Lou Amadio <lamadio@apple.com>

Reviewed by ggaren

Moved CookieJar to OpenSourceWin
Ported CookieJar to CFNetwork
Corrected an uninitialized variable which crashed on Vista in the Wininet code

  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/win/CookieJarWin.cpp:
08:31 Changeset [17689] by darin
  • 2 edits in trunk/WebCore
  • rendering/RenderObject.h: Oops! Fixed accidentally checked-in ifdef.
08:17 Changeset [17688] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/4808720> Hamachi test tool crashes Safari in WebCore::HTMLTableSectionElement::deleteRow
All existing layout tests pass

  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::deleteRow): check lastSection before deleting row
07:41 Changeset [17687] by darin
  • 3 edits in trunk/WebCore
  • improved version of last night's build fix (should not do using namespace in a header)
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
07:38 Changeset [17686] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC:PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
07:34 Changeset [17685] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: PNIO-6T5GMC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=11552

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
07:27 Changeset [17684] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugzilla.opendarwin.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
07:24 Changeset [17683] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] PPEN-6V3BDS: BrowserNG: Pressing selection key while scrolling
http://bugs.webkit.org/show_bug.cgi?id=11539

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):

11/08/06:

23:31 Changeset [22504] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Make the same change here as made in r11013.

23:13 Changeset [22503] by mjs
  • 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

  • added ResourceError class and didFailWithError client method


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFailLoadingWithError): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Geoff.

  • added ResourceError class and didFailWithError client method


  • WebFrame.cpp: (WebFrame::didFinishLoading): (WebFrame::didFailWithError):
  • WebFrame.h:
22:49 Changeset [17682] by mjs
  • 16 edits
    3 adds in trunk

Reviewed by Geoff.


  • added ResourceError class and didFailWithError client method
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError):
  • loader/loader.h:
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptCFReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adopt):
  • platform/network/ResourceError.cpp: Added.
  • platform/network/ResourceError.h: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didFailWithError):
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::cancel):
  • platform/network/mac/ResourceErrorMac.mm: Added. (-[NSError WebCore]):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::reportError):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/xmlhttprequest.h:
22:39 Changeset [17681] by bdash
  • 9 edits
    1 add in trunk/WebCore

2006-11-08 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk fixes.

  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::~ChromeClientGdk):
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor): (WebCore::moveCursor):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/PageGdk.cpp:
  • platform/gdk/ScreenClientGdk.h: Added. (WebCore::ScreenClientGdk::~ScreenClientGdk):
  • platform/gdk/ScreenGdk.cpp: (WebCore::ScreenClientGdk::depth): (WebCore::ScreenClientGdk::depthPerComponent): (WebCore::ScreenClientGdk::isMonochrome): (WebCore::ScreenClientGdk::rect): (WebCore::ScreenClientGdk::usableRect):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::historyURL): (ChromeClientGdk::windowRect): (ChromeClientGdk::setWindowRect): (ChromeClientGdk::pageRect): (ChromeClientGdk::scaleFactor): (ChromeClientGdk::focus): (ChromeClientGdk::unfocus): (ChromeClientGdk::createWindow): (ChromeClientGdk::createModalDialog): (ChromeClientGdk::show): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (ChromeClientGdk::setToolbarsVisible): (ChromeClientGdk::toolbarsVisible): (ChromeClientGdk::setStatusbarVisible): (ChromeClientGdk::statusbarVisible): (ChromeClientGdk::setScrollbarsVisible): (ChromeClientGdk::scrollbarsVisible): (ChromeClientGdk::setMenubarVisible): (ChromeClientGdk::menubarVisible): (ChromeClientGdk::setResizable):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::client):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove):
21:58 Changeset [17680] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • rendering/RenderObject.h: (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin):
21:22 Changeset [22502] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Updated Windows to use the new platform abstraction for Screen.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
  • platform/win/ScreenWin.cpp: (WebCore::monitorInfoForWidget): (WebCore::deviceInfoForWidget): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
21:18 Changeset [17679] by brmorris
  • 1 edit in S60/trunk/README.txt

Updating README.txt to point to new wiki location.

21:18 Changeset [17678] by ggaren
  • 7 edits in trunk/WebCore

Reviewed by Anders Carlsson.

Made Screen a good platform citizen by removing its reference to Page. This
made a class unnecessary, so all screen fuctions are stand-alone now.

  • bindings/js/kjs_window.cpp: Removed unnecessary subtractions when computing the screen's available dimensions.
19:55 Changeset [17677] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11506
Cleanup RenderObject

  • rendering/RenderObject.cpp: (WebCore::RenderObject::operator delete): (WebCore::RenderObject::createObject): (WebCore::RenderObjectCounter::~RenderObjectCounter): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isDescendantOf): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::addChild): (WebCore::RenderObject::removeChildNode): (WebCore::RenderObject::removeChild): (WebCore::RenderObject::appendChildNode): (WebCore::RenderObject::insertChildNode): (WebCore::RenderObject::nextInPreOrder): (WebCore::RenderObject::nextInPreOrderAfterChildren): (WebCore::RenderObject::previousInPreOrder): (WebCore::RenderObject::isEditable): (WebCore::RenderObject::nextEditable): (WebCore::RenderObject::previousEditable): (WebCore::RenderObject::firstLeafChild): (WebCore::RenderObject::lastLeafChild): (WebCore::RenderObject::addLayers): (WebCore::RenderObject::removeLayers): (WebCore::RenderObject::moveLayers): (WebCore::RenderObject::findNextLayer): (WebCore::RenderObject::enclosingLayer): (WebCore::RenderObject::updateFirstLetter): (WebCore::RenderObject::offsetParent): (WebCore::RenderObject::scroll): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::setNeedsLayout): (WebCore::RenderObject::setChildNeedsLayout): (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::containingBlockWidth): (WebCore::RenderObject::containingBlockHeight): (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::addPDFURLRect): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::repaint): (WebCore::RenderObject::repaintRectangle): (WebCore::RenderObject::repaintAfterLayoutIfNeeded): (WebCore::RenderObject::repaintObjectsBeforeLayout): (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline): (WebCore::RenderObject::information): (WebCore::RenderObject::dump): (WebCore::selectStartNode): (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::createAnonymousBlock): (WebCore::RenderObject::handleDynamicFloatPositionChange): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::setStyleInternal): (WebCore::RenderObject::updateBackgroundImages): (WebCore::RenderObject::absolutePosition): (WebCore::RenderObject::caretRect): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::tabWidth): (WebCore::RenderObject::container): (WebCore::RenderObject::removeFromObjectLists): (WebCore::RenderObject::destroy): (WebCore::RenderObject::arenaDelete): (WebCore::RenderObject::hitTest): (WebCore::RenderObject::setInnerNode): (WebCore::RenderObject::nodeAtPoint): (WebCore::RenderObject::verticalPositionHint): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::invalidateVerticalPositions): (WebCore::RenderObject::recalcMinMaxWidths): (WebCore::RenderObject::scheduleRelayout): (WebCore::RenderObject::setInlineBoxWrapper): (WebCore::RenderObject::firstLineStyle): (WebCore::RenderObject::getPseudoStyle): (WebCore::RenderObject::getTextDecorationColors): (WebCore::RenderObject::addDashboardRegions): (WebCore::RenderObject::collectDashboardRegions): (WebCore::RenderObject::avoidsFloats): (WebCore::RenderObject::findCounter): (WebCore::RenderObject::backslashAsCurrencySymbol): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::previousOffset): (WebCore::RenderObject::nextOffset): (WebCore::RenderObject::inlineBox):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::renderName): (WebCore::RenderObject::parent): (WebCore::RenderObject::previousSibling): (WebCore::RenderObject::nextSibling): (WebCore::RenderObject::firstChild): (WebCore::RenderObject::lastChild): (WebCore::RenderObject::getOverflowClipRect): (WebCore::RenderObject::getClipRect): (WebCore::RenderObject::getBaselineOfFirstLineBox): (WebCore::RenderObject::setEdited): (WebCore::RenderObject::setStaticX): (WebCore::RenderObject::setStaticY): (WebCore::RenderObject::setPreviousSibling): (WebCore::RenderObject::setNextSibling): (WebCore::RenderObject::setParent): (WebCore::RenderObject::isInlineBlockOrInlineTable): (WebCore::RenderObject::isRenderView): (WebCore::RenderObject::childrenInline): (WebCore::RenderObject::setChildrenInline): (WebCore::RenderObject::isAnonymousBlock): (WebCore::RenderObject::isDragging): (WebCore::RenderObject::needsLayout): (WebCore::RenderObject::setMinMaxKnown): (WebCore::RenderObject::setNeedsLayoutAndMinMaxRecalc): (WebCore::RenderObject::setPositioned): (WebCore::RenderObject::setRelPositioned): (WebCore::RenderObject::setFloating): (WebCore::RenderObject::setInline): (WebCore::RenderObject::setShouldPaintBackgroundOrBorder): (WebCore::RenderObject::setReplaced): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::calcWidth): (WebCore::RenderObject::updateFromElement): (WebCore::RenderObject::RepaintInfo::RepaintInfo): (WebCore::RenderObject::setOverrideSize): (WebCore::RenderObject::setPos): (WebCore::RenderObject::setWidth): (WebCore::RenderObject::setHeight): (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::overflowHeight): (WebCore::RenderObject::overflowWidth): (WebCore::RenderObject::setOverflowHeight): (WebCore::RenderObject::setOverflowWidth): (WebCore::RenderObject::overflowLeft): (WebCore::RenderObject::overflowTop): (WebCore::RenderObject::overflowRect): (WebCore::RenderObject::stopAutoscroll): (WebCore::RenderObject::collapsedMarginTop): (WebCore::RenderObject::collapsedMarginBottom): (WebCore::RenderObject::maxTopMargin): (WebCore::RenderObject::maxBottomMargin): (WebCore::RenderObject::): (WebCore::RenderObject::setTable): (WebCore::RenderObject::isFloatingOrPositioned): (WebCore::RenderObject::containsFloat): (WebCore::RenderObject::setSelectionState): (WebCore::RenderObject::SelectionInfo::SelectionInfo): (WebCore::RenderObject::lowestPosition): (WebCore::RenderObject::rightmostPosition): (WebCore::RenderObject::leftmostPosition): (WebCore::RenderObject::calcVerticalMargins): (WebCore::RenderObject::font):
18:21 Changeset [22501] by darin
  • 4 edits in branches/WindowsMerge/WebCore
  • fix the build
  • bridge/win/FrameWin.h: Add a forward declaration of FormData.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Call resetMultipleFormSubmissionProtection instead of prepareForUserAction.
  • platform/win/TemporaryLinkStubs.cpp: Remove the parameter from the TextField constructor.
18:18 Changeset [17676] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
merged from 3.1m 17675
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugs.webkit.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
18:07 Changeset [17675] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2006-11-08 yaharon <yael.aharon@nokia.com>

Reviewed by zalan.
DESC: [S60] MHAE-6VALC7: BrowserNG crashes when form is submitted (www.dpd.net)
http://bugzilla.opendarwin.org/show_bug.cgi?id=11549

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm):
18:00 Changeset [22500] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebEditorClient.cpp: Added stubs for new methods from EditorClient.h. (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
  • WebEditorClient.h: Added new methods from EditorClient.h and cleaned up placement of *s.
18:00 Changeset [17674] by darin
  • 30 edits
    2 adds in trunk

LayoutTests:

Reviewed by Anders.

  • added test for option-tab
  • fast/events/option-tab.html: Added.
  • fast/events/option-tab-expected.txt: Added.

WebCore:

Reviewed by Anders.

  • added event parameters to focus-related functions so we can implement the "option-tab to all links" behavior without relying on a global "current event" -- also makes it work with DOM events
  • page/Frame.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
  • page/Frame.cpp: (WebCore::Frame::doTextFieldCommandFromEvent): Changed parameter from PlatformKeyboardEvent to the DOM keyboard event class. (WebCore::Frame::tabsToLinks): Added event parameter. (WebCore::Frame::tabsToAllControls): Ditto. (WebCore::scanForForm): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (WebCore::Frame::hitTestResultAtPoint): Ditto.
  • bridge/mac/FrameMac.h: Removed unneeded includes. Moved some functions that were misplaced into the appropriate sections.
  • bridge/mac/FrameMac.mm: (WebCore::selectorForKeyEvent): Changed to use a DOM event instead of a PlatformKeyboardEvent. (WebCore::FrameMac::nextKeyViewInFrame): Changed to use currentKeyboardEvent() and pass event into next/previousFocusNode. (WebCore::FrameMac::currentKeyboardEvent): Added. Creates a DOM event from the AppKit current event, if it's a keyboard event. Really just a hack that's needed to preserve some code we can remove once we deal with the last NSView- based form control. (WebCore::isKeyboardOptionTab): Added. (WebCore::FrameMac::tabsToLinks): Added event parameter, used to check if the option (alt) key is down. (WebCore::FrameMac::tabsToAllControls): Ditto. (WebCore::FrameMac::keyEvent): Changed call to prepareForUserAction() to just call resetMultipleFormSubmissionProtection() explicitly instead. (WebCore::FrameMac::mouseDown): Ditto.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): Fixed code that incorrectly assumes that an iframe is an HTMLFrameElement (no longer true since Geoff changed the class hierarchy a bit). (-[WebCoreAXObject accessibilityPerformAction:]): Changed call to prepareForUserAction() to call resetMultipleFormSubmissionProtection() explicitly instead.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Changed function to take an event parameter, and decide the direction based on the shift key modifier instead of a passed-in boolean.
  • dom/Document.h:
  • dom/Document.cpp: (WebCore::Document::nextFocusNode): Added event parameter. (WebCore::Document::previousFocusNode): Ditto.
  • dom/Node.h:
  • dom/Node.cpp: (WebCore::Node::isKeyboardFocusable): Ditto.
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.
  • html/HTMLGenericFormElement.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable): Ditto.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): Ditto. (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
  • html/HTMLSelectElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::isKeyboardFocusable): Ditto.
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::isKeyboardFocusable): Ditto.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Pass event to the advanceFocus function.
  • platform/TextField.h:
  • platform/mac/TextFieldMac.mm: Removed the non-search field code.
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextField.mm: Removed the non-search field code. (-[WebCoreTextFieldController controlTextDidChange:]): Removed the call to FrameMac::handleKeyboardOptionTabInView, which is no longer needed since the default handler in HTMLInputElement takes care of option-tab.
  • platform/mac/SliderMac.mm: (-[WebCoreSlider canBecomeKeyView]): Changed to use currentKeyboardEvent() and pass event into tabsToAllControls. (Slider::focusPolicy): Ditto.
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): Removed the non-search field code. (WebCore::RenderLineEdit::updateFromElement): Ditto.
17:41 Changeset [22499] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
17:33 Changeset [17673] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • same change as below, only tested this time
  • DumpRenderTree/DumpRenderTree.m: (main): Explicitly turn "tab to links" mode off. I think we need to do this because WebPreferences saves things for us automatically. It would be good to turn that off for DumpRenderTree, but for now lets handle this like the other preferences (set it explicitly each time).
17:21 Changeset [17672] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Anders.

  • DumpRenderTree/DumpRenderTree.m: (main): Get rid of code to turn on "tab to links" mode. No current tests depend on this, and there's a new test I want to land that depends on the default setting.
17:16 Changeset [17671] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison, Oliver, and Darin
(oh my! where was superkevin on this one?)

<rdar://problem/4816196> "Xcode Help" crashes in WebCore::DocumentLoader::setPrimaryLoadComplete(bool)

More "free nil checking" we lost in the transition from ObjC to C++

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::startLoading): Null check m_provisionalDocumentLoader and bail early. (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Ditto
16:51 Changeset [17670] by andersca
  • 19 edits in trunk

WebCore:

Reviewed by Adam.

Move more code into editor.


  • WebCore.exp:
  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.h:
  • dom/Document.cpp: (WebCore::Document::relinquishesEditingFocus): (WebCore::Document::acceptsEditingFocus): (WebCore::Document::didBeginEditing): (WebCore::Document::didEndEditing):
  • editing/Editor.cpp: (WebCore::Editor::indent): (WebCore::Editor::outdent):
  • editing/Editor.h:
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Adam.

Move more code into editor.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::didEndEditing):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.m: (-[NSArray indent:]): (-[NSArray outdent:]):
  • WebView/WebView.mm:
  • WebView/WebViewInternal.h:
16:41 Changeset [22498] by bdakin
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Add clause for new WebElementIsContentEditableKey to the Read
fucntion.

  • Interfaces/IWebView.idl:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
14:58 Changeset [17669] by bdakin
  • 9 edits in trunk

WebCore:

Reviewed by Adam.

Add ability to HitTestResult to ask if the inner non-shared node is
content editable.

  • WebCore.exp: Export HitTestResult::isContentEditable()
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isContentEditable):
  • rendering/HitTestResult.h:

WebKit:

Reviewed by Adam.

Add WebElementIsContentEditableKey to the WebElementDictionary, and
use it!

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): Use new WebElementIsContentEditableKey.
  • Misc/WebElementDictionary.m: (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isContentEditable]): Call into HitTestResult::isContentEditable()
  • WebView/WebView.mm: Add new key.
  • WebView/WebViewPrivate.h: Add new key.
14:50 Changeset [17668] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • WebCore.xcodeproj/project.pbxproj: Add DOMCSSStyleDeclarationInternal.h to the "Copy Generated Headers" build phase.
14:32 Coding Style Guidelines edited by sam@webkit.org
(diff)
14:24 Changeset [17667] by thatcher
  • 12 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4713280> Would like to get an array of bounding rects rather than just the union of them for a DOMRange
<rdar://problem/4804317> Would like SPI to get bounding box for a DOM range without having to change the selection

Added lineBoxRects and boundingBox to Range and DOMRange. These methods correspond to the DOMNode methods.

  • bindings/objc/DOM.mm: (WebCore::kit): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):
  • bindings/objc/DOMPrivate.h:
  • dom/Range.cpp: (WebCore::Range::boundingBox): (WebCore::Range::addLineBoxRects):
  • dom/Range.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addLineBoxRects):
  • rendering/RenderContainer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addLineBoxRects):
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
  • rendering/RenderText.h:
13:57 Changeset [22497] by adachan
  • 6 edits in branches/WindowsMerge
13:57 Changeset [17666] by andersca
  • 18 edits in trunk

WebCore:

Reviewed by Oliver.


Move methods from the bridge and frame into editor.


  • WebCore.exp:
  • bridge/EditorClient.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): (WebCore::Editor::applyStyle): (WebCore::Editor::applyParagraphStyle): (WebCore::Editor::applyStyleToSelection): (WebCore::Editor::applyParagraphStyleToSelection): (WebCore::Editor::toggleBold): (WebCore::Editor::toggleItalic): (WebCore::Editor::selectionStartHasStyle):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • page/Frame.cpp:
  • page/Frame.h:

WebKit:

Reviewed by Oliver.

Call into the WebCore editor object directly.


  • MigrateHeaders.make:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldApplyStyle):
  • WebView/WebFrame.mm: (core): (kit):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]): (-[NSArray _changeCSSColorUsingSelector:inRange:]): (-[NSArray underline:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: (-[WebView applyStyle:]):
13:30 Changeset [17665] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

<rdar://problem/4825370>
REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app


  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Initialize the framework pointer to 0.
13:26 Changeset [22496] by lamadio
  • 10 edits in branches/WindowsMerge
13:20 Changeset [17664] by adachan
  • 2 edits in trunk/JavaScriptCore

2006-11-08 Ada Chan <adachan@apple.com>

Reviewed by darin.


Added a method to delete all the keys in a HashMap.

12:14 Changeset [17663] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Beth.


Fixed regression in fast/events/objc-event-api. DumpRenderTree expects to
be able to dispatch user events even when off-screen, so we have to support
off-screen windows when handling mouse events.

  • platform/Screen.h:
  • platform/mac/PlatformMouseEventMac.mm: (WebCore::globalPoint): Grab the best screen instead of the screen you're on, since you might be off-screen.
  • platform/mac/ScreenMac.mm: (WebCore::screenForWindow):
11:47 Changeset [22495] by andersca
  • 5 edits
    3 adds in branches/WindowsMerge/WebKitTools

2006-11-07 Anders Carlsson <acarlsson@apple.com>

Reviewed by Geoff.


Fix the build. Hook up a layoutTestController and implement dumpAsText, waitUntilDone and notifyDone.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Added. (dumpAsTextCallback): (waitUntilDoneCallback): (notifyDoneCallback): (getClass): (createLayoutTestController):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didFinishLoadForFrame): (WaitUntilDoneDelegate::windowScriptObjectAvailable):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): (WaitUntilDoneDelegate::didFailProvisionalLoadWithError): (WaitUntilDoneDelegate::didCommitLoadForFrame): (WaitUntilDoneDelegate::didReceiveIcon): (WaitUntilDoneDelegate::didFailLoadWithError): (WaitUntilDoneDelegate::didChangeLocationWithinPageForFrame): (WaitUntilDoneDelegate::willPerformClientRedirectToURL): (WaitUntilDoneDelegate::didCancelClientRedirectForFrame): (WaitUntilDoneDelegate::willCloseFrame): (WaitUntilDoneDelegate::createWebViewWithRequest): (WaitUntilDoneDelegate::webViewShow): (WaitUntilDoneDelegate::webViewClose): (WaitUntilDoneDelegate::webViewFocus): (WaitUntilDoneDelegate::webViewUnfocus): (WaitUntilDoneDelegate::webViewFirstResponder): (WaitUntilDoneDelegate::makeFirstResponder): (WaitUntilDoneDelegate::setStatusText): (WaitUntilDoneDelegate::webViewStatusText): (WaitUntilDoneDelegate::webViewAreToolbarsVisible): (WaitUntilDoneDelegate::setToolbarsVisible): (WaitUntilDoneDelegate::webViewIsStatusBarVisible): (WaitUntilDoneDelegate::setStatusBarVisible): (WaitUntilDoneDelegate::webViewIsResizable): (WaitUntilDoneDelegate::setResizable): (WaitUntilDoneDelegate::setFrame): (WaitUntilDoneDelegate::webViewFrame): (WaitUntilDoneDelegate::setContentRect): (WaitUntilDoneDelegate::webViewContentRect): (WaitUntilDoneDelegate::runJavaScriptConfirmPanelWithMessage): (WaitUntilDoneDelegate::runJavaScriptTextInputPanelWithPrompt): (WaitUntilDoneDelegate::runOpenPanelForFileButtonWithResultListener): (WaitUntilDoneDelegate::mouseDidMoveOverElement): (WaitUntilDoneDelegate::contextMenuItemsForElement): (WaitUntilDoneDelegate::validateUserInterfaceItem): (WaitUntilDoneDelegate::shouldPerformAction): (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction): (WaitUntilDoneDelegate::dragSourceActionMaskForPoint): (WaitUntilDoneDelegate::willPerformDragSourceAction):
11:13 Changeset [22494] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Build fixes.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

2006-11-08 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

More fiddling with midl to get our JSC API types recognized.


  • Interfaces/IWebFrameLoadDelegate.idl:
09:32 Changeset [17662] by darin
  • 3 edits in trunk/WebCore
  • fix bug caused by last-minute change to my check-in last night that is causing layout tests to hang
  • dom/Document.cpp: (WebCore::Document::completeURL): Added comments.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): Turn a null string into an empty string before calling completeURL.
02:02 Changeset [17661] by beidson
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej

Added test to cover bug http://bugs.webkit.org/show_bug.cgi?id=11450
-Confirm there is no assert when nuking a frame with an active XMLHttpRequest load
-Confirm the correct state-change notifications for the request are dispatched

  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt: Added.
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html: Added.
  • http/tests/xmlhttprequest/resources/endlessxml.php: Added.
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added.

WebCore:

Reviewed by Maciej

If the request has already been aborted, bail out of didFinishLoading()
immediately. This prevents state change notifications that aren't
needed.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading):
01:55 Changeset [22493] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): Use m_frame instead of this, include the correct files.
01:51 Changeset [17660] by darin
  • 2 edits in trunk/WebCore
  • another attempt to fix Qt build
  • loader/qt/FrameLoaderQt.cpp: Added missing include of FrameLoader.h.
01:48 Changeset [17659] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • stray bits of my FrameLoader patch that I left out by accident
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class. (WebCore::FrameLoader::requestFrame): Use less DeprecatedString. (WebCore::FrameLoader::clear): Stop the redirection timer. (WebCore::FrameLoader::receivedFirstData): Added an early return instead of nesting the entire function in an if statement. Use less DeprecatedString. (WebCore::FrameLoader::scheduleLocationChange): Fix backwards ? : operator. (WebCore::FrameLoader::scheduleRefresh): Ditto. (WebCore::FrameLoader::urlSelected): Use m_outgoingReferrer instead of outgoingReferrer() inside the FrameLoader class.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Ditto. (WebCore::FrameLoader::loadResourceSynchronously): Ditto.
01:47 Changeset [22492] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

(I'm not doing this to get commit 11000)


  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin): It's m_frame, not frame.
01:45 Changeset [17658] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

  • fast/forms/submit-nil-value-field-assert.html: Update test so it no longer relies on incorrect "submit form right away during JavaScript execution" behavior.
01:43 Changeset [22491] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

It's FrameLoader, not FrameWin.


  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::partClearedInBegin):
01:40 Changeset [22490] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-11-08 Anders Carlsson <acarlsson@apple.com>

A blind attempt at fixing the build.


  • bridge/win/FrameWin.cpp:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameWin::partClearedInBegin):
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::restoreDocumentState):
00:19 Changeset [17657] by bdakin
  • 2 edits in trunk/LayoutTests

Reviewed by Geoff.

This test needs new results from my last check-in. I thought this
change was already in my tree, but I guess not. Whoops!

  • fast/dom/delete-contents-expected.txt:
Note: See TracTimeline for information about the timeline view.