Timeline


and

11/14/06:

22:57 Changeset [17778] by bdash

2006-11-14 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Tim Hatcher.

Moved the web developer page to the wiki, adding link to the Drosera page.

  • .htaccess: Add permanent redirect to the new page on the wiki.
  • contact.html: Trac numbers are no longer one off.
  • nav.inc:
  • webdevelopers/index.html: Removed.
  • webdevelopers/webkit_version.html: Removed.
  • webdevelopers/webkit_version.js: Removed.
  • webdevelopers/webkit_version_xl.html: Removed.
  • webdevelopers/webkit_version_xl.js: Removed.
22:09 Changeset [17777] by bdakin

WebCore:

Reviewed by Geoff.

Moving things off the bridge and onto clients.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff.

Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • editing/Editor.cpp: (WebCore::Editor::selectWordBeforeMenuEvent): (WebCore::Editor::clientIsEditable):
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:
21:42 Changeset [17776] by thatcher

WebCore:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.

  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
  • page/FrameView.cpp: (WebCore::selectCursor):
  • page/Settings.h: (WebCore::Settings::):

WebKit:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]): (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): (-[WebDefaultUIDelegate openLink:]):
  • English.lproj/Localizable.strings:
  • WebKit.exp:
  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebUIDelegatePrivate.h:
21:28 WebKit Team edited by timothy@apple.com
(diff)
21:17 Changeset [17775] by oliver

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Oliver.

Build fix

  • bindings/scripts/CodeGenerator.pm:
21:06 Changeset [17774] by andersca

WebCore:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

  • WebKit.xcodeproj/project.pbxproj:
21:01 Changeset [17773] by andersca

WebCore:

I must stop trying to force DWARF on the world.


  • WebCore.xcodeproj/project.pbxproj:

WebKit:

I must stop trying to force DWARF on the world.

  • WebKit.xcodeproj/project.pbxproj:
19:52 Changeset [17772] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4806874>
Missing background image after paste

Checking in new expected results for fixes:

  • editing/inserting/insert-3851164-fix-expected.checksum:
  • editing/inserting/insert-3851164-fix-expected.png:
  • editing/selection/drag-in-iframe-expected.checksum:
  • editing/selection/drag-in-iframe-expected.png:

Same, but also removing an outdated comment about a bug:

  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/paste-text-019.html:


Added:

  • editing/pasteboard/4806874-expected.checksum: Added.
  • editing/pasteboard/4806874-expected.png: Added.
  • editing/pasteboard/4806874-expected.txt: Added.
  • editing/pasteboard/4806874.html: Added.


Equivalent render trees:

  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4806874>
Missing background image after paste


  • editing/markup.cpp: (WebCore::createMarkup): If the body is fully selected, add a div with its CSS properties to the markup. Migrated a use of enclosingBlockFlowElement to enclosingBlock to fix an infinite loop when pasting <div><input></div>.
19:20 Changeset [17771] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Add Undo/Redo to execCommand.


  • editing/Editor.cpp: (WebCore::execRedo): (WebCore::execUndo): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::):
19:16 WikiStart edited by pewtermoose@gmail.com
forgot a page (diff)
19:15 WikiStart edited by pewtermoose@gmail.com
linking to the pages I added (diff)
19:12 WebDevelopers created by pewtermoose@gmail.com
Web developer oriented resources
19:12 DetectingWebKit created by pewtermoose@gmail.com
Moved this from the website
19:12 Drosera created by pewtermoose@gmail.com
Some rough Drosera documentation
19:00 WebKit Team edited by bdash@webkit.org
(diff)
18:59 WebKit Team edited by bdash@webkit.org
(diff)
18:52 WebKit Team edited by pewtermoose@gmail.com
(diff)
18:45 WebKit Team edited by pewtermoose@gmail.com
Clean up a few cobwebs (diff)
17:40 Changeset [22542] by darin

Fixed reviewer name (Anders).

17:34 Changeset [22541] by darin

WebCoreWin:

Reviewed by NOBODY (OOPS!).

  • update for creation of EventHandler
  • WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.
  • bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp, tabsToLinks, and tabsToAllControls to EventHandler.
  • bridge/win/FrameWin.cpp: Ditto.
  • bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar functions to EventHandler.
  • page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.
  • platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed function in its new home in EventHandler.
  • platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.

WebKitWin:

Reviewed by Anders.

  • update for creation of EventHandler
  • WebView.cpp: (WebView::handleMouseEvent): Call methods now moved to EventHandler. (WebView::mouseWheel): Ditto. (WebView::elementAtPoint): Ditto.
17:29 Changeset [17770] by darin

WebCore:

Reviewed by Anders.

  • created EventHandler class, moved event handling code from both Frame and FrameView in there
  • added ScrollTypes.h header so you can include the scroller-related enums without all of Scrollbar.h
  • page/EventHandler.cpp: Added.
  • page/EventHandler.h: Added.
  • page/mac/EventHandlerMac.mm: Added.
  • platform/ScrollBarMode.h: Removed.
  • platform/ScrollTypes.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::imageFromRect):
  • bridge/mac/FrameViewMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge _visiblePositionForPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
  • dom/Document.cpp: (WebCore::Document::hoveredNodeDetached):
  • dom/Element.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
  • editing/SelectionController.h: (WebCore::SelectionController::setCaretBlinkingSuspended): (WebCore::SelectionController::isCaretBlinkingSuspended):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus):
  • html/HTMLFrameElementBase.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::open):
  • page/Frame.cpp: (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::frameForWidget): (WebCore::Frame::eventHandler): (WebCore::Frame::setProhibitsScrolling): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::addRepaintInfo): (WebCore::FrameView::layout): (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::windowClipRectForLayer): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • page/FrameView.h:
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
  • page/PageState.h:
  • platform/ScrollBar.h:
  • platform/ScrollView.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/SliderMac.mm: (-[WebCoreSlider becomeFirstResponder]): (-[WebCoreSlider nextKeyView]): (-[WebCoreSlider previousKeyView]): (-[WebCoreSlider canBecomeKeyView]): (Slider::focusPolicy):
  • platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]): (-[WebCoreTextFieldController setHasFocus:]): (-[WebCoreSearchField nextKeyView]): (-[WebCoreSearchField previousKeyView]): (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::hasFocus): (WebCore::Widget::clearFocus):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::setResizing):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::updateOverflowStatus):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h: (WebCore::RenderObject::RepaintInfo::RepaintInfo):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):

WebKit:

Reviewed by Anders.

  • update for creation of EventHandler
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]): (-[WebHTMLView elementAtPoint:allowShadowContent:]):
17:21 Changeset [17769] by andersca

Fix build for real this time.


  • WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]):
17:07 Changeset [17768] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Try fixing the build.


  • WebCoreSupport/WebEditorClient.mm: (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]):
17:07 Changeset [22540] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • WebEditorClient.cpp: (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
  • WebEditorClient.h:
16:36 Changeset [17767] by andersca

WebCore:

Reviewed by Darin.

Let the editor client handle undo/redo.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::canUndo): (WebCore::FrameMac::canRedo):
  • bridge/mac/WebCoreEditCommand.h: Removed.
  • bridge/mac/WebCoreEditCommand.mm: Removed.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
  • editing/JSEditor.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::closeURL):
  • page/Frame.cpp:
  • page/Frame.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement):

WebKit:

Reviewed by Darin.

Move undo/redo handling into WebEditorClient.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (undoNameForEditAction): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
15:02 Web Inspector edited by pewtermoose@gmail.com
Add how to use with OmniWeb (diff)
14:33 Changeset [17766] by beidson

Reviewed and landed by Brady

Fix Qt/Linux build.

  • ChangeLog:
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::add):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::submitForm):
  • platform/qt/FrameQtClient.h:
13:51 Changeset [17765] by thatcher

Fixing the site.

13:45 Changeset [17764] by sfalken

New tag.

13:44 Changeset [17763] by bdash

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site

  • blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
  • nav.inc: Generate WordPress archive list if included from within WordPress.
11:56 Changeset [22539] by beidson

Reviewed by Anders

Additional tweek to the FormData change

  • WebFrame.cpp: (WebFrame::loadDataSource):
11:52 Changeset [17762] by beidson

Reviewed by Anders

Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest):
11:44 Changeset [22538] by aroben

WebKitWin:

Reviewed by Steve.

Replace all instances of DebugBreak() with ASSERT_NOT_REACHED() so that
it will be compiled out for Release builds.

  • DOMCSSClasses.cpp:
  • DOMCoreClasses.cpp:
  • DOMHTMLClasses.cpp:
  • WebBackForwardList.cpp:
  • WebDataSource.cpp:
  • WebFrame.cpp:
  • WebHTMLRepresentation.cpp:
  • WebHistoryItem.cpp:
  • WebIconDatabase.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotification.cpp:
  • WebPreferences.cpp:
  • WebScriptObject.cpp:
  • WebView.cpp:
10:57 Changeset [17761] by ap

2006-11-14 Rob Buis <buis@kde.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer

Test: fast/css/css-imports.html

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Fix the crash by testing for null pointer.
10:11 Changeset [17760] by ap

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

  1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
  1. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

  • WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
  • WebView/WebHTMLViewInternal.h:
10:06 Changeset [17759] by aroben

2006-11-14 Darin Adler <darin@apple.com>

Reviewed by Adam.

Fix up usages of FormData within CFNet loader code.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody):
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the streamFormDatas HashMap. (WebCore::formCreate): (WebCore::formFinalize): Removed delete because the remove() will deref and delete if necessary. (WebCore::setHTTPBody): Changed parameter to PassRefPtr. (WebCore::httpBodyFromStream):
  • platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::getResourceRequest):
07:39 Changeset [17758] by spadma

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

  • BrowserCore/Renderers/src/TextRendererFactory.cpp:
07:25 Changeset [17757] by spadma

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

  • BrowserCore/Renderers/src/TextRendererFactory.cpp:
03:55 Changeset [17756] by bdash

2006-11-14 Greg Jackson <gjspanner@gmail.com>

Reviewed by Darin.

Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.

  • bindings/js/kjs_navigator.cpp:
02:13 BuildingGdk edited by alp@atoker.com
(diff)
02:11 BuildingGdk created by alp@atoker.com

11/13/06:

23:59 Changeset [22537] by beidson

WebCoreWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared


  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::submitForm):
  • WebFrame.h:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • WebMutableURLRequest.h:
19:54 Changeset [17755] by beidson

Reviewed by Maciej

Made FormData Shared, and pass it around as such.

  • WebCore.xcodeproj/project.pbxproj: Reordered some items
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • platform/network/FormData.h: Made FormData shared
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest): (WebCore::nsURLRequest):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
19:01 Changeset [22536] by andersca

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Make sure to call valueChanged after hiding the popup so that change events will be delivered correctly.
18:45 Changeset [17754] by justing

I accidently checked in old expected results in my previous checkin.

18:37 Changeset [17753] by justing

LayoutTests:

Reviewed by harrison

  • editing/selection/drag-select-1-expected.checksum: Added.
  • editing/selection/drag-select-1-expected.png: Added.
  • editing/selection/drag-select-1-expected.txt: Added.
  • editing/selection/drag-select-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)


The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.


  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup to prevent crashes like this in future Release builds.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Let this function escape shadow nodes. We might eventually push this code down into next/previous{VisuallyDistinct}Canditate. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
18:09 Changeset [22535] by andersca

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Various editing fixes.


  • WebView.cpp: (WebView::execCommand): Use the focused frame, not the main frame.


(WebView::focusedTarget):
Add FIXME comment.


(WebView::keyDown):
Return false for unknown keydown messages when not in editing mode.

17:27 Changeset [22534] by aroben

Fix line endings.

17:21 Changeset [22533] by sfalken

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.

Fix merge script

  • WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.


Bump version for submit
Copy CharacterSets directory for CF

  • WebKit.vcproj/VERSION: Bump version
  • WebKit.vcproj/WebKit.vcproj: Copy CharacterSets
15:56 Changeset [17752] by justing

Reviewed by darin


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • editing/Editor.h: (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
15:37 Changeset [17751] by justing

LayoutTests:

Reviewed by Oliver

  • editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
  • editing/pasteboard/paste-unrendered-select-expected.png: Added.
  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html: Added.

WebCore:

Reviewed by Oliver


<rdar://problem/4820026>
copy/paste of news.google.com yields text from hidden select element options

We were adding descendants of unrendered select elements.

  • editing/markup.cpp: (WebCore::createMarkup): Don't traverse into nodes without renderers, unless they are grandfathered in by a rendered select element.
15:27 Changeset [22532] by ggaren

WebKitWin:

Reviewed by Darin Adler, Anders Carlsson.


More window.open work.


  • Hooked up all of WebChromeClient that the App currently supports.
  • WebChromeClient.cpp: (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
14:59 Changeset [17750] by thatcher

Versioning

14:40 Changeset [17749] by thatcher

New tag.

13:46 Changeset [17748] by thatcher

Explicitly set Dwarf for projects that didn't specify the debugging format.

13:38 Changeset [17747] by thatcher

Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.

09:42 Changeset [22531] by aroben

Fix line-endings and svn properties.

  • WebChromeClient.cpp:
  • WebChromeClient.h:
09:35 Changeset [22530] by aroben

Build fix.

  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebEditorClient.h:
  • WebMutableURLRequest.h:

11/12/06:

23:13 Changeset [17746] by beidson

Rubberstamped by Anders

Changed some #includes from <WebKit/foo.h> to "foo.h"

  • History/WebBackForwardList.m:
  • History/WebHistory.m:
18:57 Changeset [22529] by ggaren
  • WebChromeClient.cpp: Fixed up #include.
18:54 Changeset [22528] by ggaren

Reviewed by Steve Falkenberg.

Implemented window.open. Rough around the edges right now.

  • Converted WebMutableURLRequest to use a ResourceRequest as its backing store, to avoid yet another way of representing this data.
  • Changed WebMutableURLRequests's timeoutInterval to double, to match ResourceRequest and NSURLRequest.
  • Added BSTRToKURL and KURLToBSTR helper functions.
  • Added page accessor on WebView, and core(), for converting from WebView to page.
  • MarshallingHelpers.h: Removed unnecessary variable names from declarations.
15:49 Changeset [22527] by ggaren

WebCoreWin:

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

Reviewed by Steven Falkenberg.


Fixed up work-arounds to MSVC warning silliness.


Replaced in-place disabling of "conditional expression is constant" warning
with project-wide setting. (We use do { } while(0); for macro scoping.)


Replaced in-place and project-wide disabling of "xxx was declared deprecated"
warning with project-wide setting only to disable Microsoft's made-up deprecation

warnings related to std
functions.
  • WebChromeClient.cpp: (WebChromeClient::setResizable):
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.h:
15:44 Changeset [17745] by ggaren

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
08:47 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added bug number for navigationController issue (diff)
08:45 Writing Layout Tests for DumpRenderTree created by mitz@webkit.org
Copied from Google cache of wiki.opendarwin.org with minimal modifications …
07:18 Changeset [17744] by bdash

2006-11-12 Simon Hausmann <hausmann@kde.org>

Reviewed by Sam Weinig.

Fix Qt build. Missing AbstractShared implementation.
http://bugs.webkit.org/show_bug.cgi?id=11581

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::ref): (WebCore::FrameLoaderClientQt::deref):
  • loader/qt/FrameLoaderClientQt.h:
  • platform/qt/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ref): (WebCore::ChromeClientQt::deref):
  • platform/qt/ChromeClientQt.h:
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::ref): (WebCore::EditorClientQt::deref):
  • platform/qt/EditorClientQt.h:
04:39 BuildingOnWindows edited by ap@webkit.org
added a few more needed cygwin packages (diff)
04:29 Changeset [17743] by bdash

2006-11-13 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Fix some Linux/Gdk build issues noted by Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
04:19 BuildingOnWindows created by bdash@webkit.org
Rescue Building on Windows page from the old wiki
01:31 Changeset [17742] by beidson

Reviewed by Anders

Logging channel plumbing for future work

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
00:47 Changeset [17741] by bdash

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/PageState.cpp:
  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::ref): (WebCore::ChromeClientGdk::deref):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::~FrameGdk):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
  • platform/gdk/ScreenClientGdk.h: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::canPaste): (FrameGdk::originalRequestURL): (TextField::TextField):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • webcore-base.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of JavaScriptCore bakefiles.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of GdkLauncher bakefile.

  • GdkLauncher/gdklauncher.bkl:

11/11/06:

20:59 Changeset [22526] by ggaren

Reviewed by Maciej Stachowiak.

  • Fixed <rdar://problem/4831461> Crash in FrameLoader::~FrameLoader when navigating away from ebay.com
  • Changed WebKit clients to match new virtual ref/deref scheme in WebCore.
  • Removed WebEditorClient from the WebCore namespace because it's a WebKit class, not a WebCore class.
  • Standardized some header #includes to match Mac:
    • alphabetical
    • config.h, WebKitDLL.h, and class headers go together at the top
    • everything else comes after a line break
20:53 Changeset [17740] by ggaren

WebCore:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h: Fixed up function prototypes for style.
  • loader/FrameLoader.cpp: Removed detachFrameLoader, since its real purpose was to implement an alternative ownership model. (WebCore::FrameLoader::~FrameLoader): Removed empty destructor. (WebCore::FrameLoader::setClient): This function now takes ownership (WebCore::FrameLoader::client):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/ChromeClient.h:
  • platform/AbstractShared.h: Added. This is the virtual function-based refcounting complement to Shared. (WebCore::AbstractShared::~AbstractShared):

WebKit:

Reviewed by Maciej Stachowiak.


  • Fixed loader crash by clarifying ownership of WebKit client objects. WebCore objects own their WebKit clients, and ref and deref through virtual methods, leaving WebKit free to use whatever client / reference-counting implementation it likes.


WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
but other platforms may choose to do other things.

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::ref): (WebChromeClient::deref): (WebChromeClient::refCount):
  • WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes. The ones in WebCore make clear what remains to be implemented. Replaced constructor with factory function to avoid leaks.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::create): (WebEditorClient::WebEditorClient): (WebEditorClient::setWebFrame):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
  • WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory function to avoid leaks. (WebFrameLoaderClient::ref): (WebFrameLoaderClient::deref): (WebFrameLoaderClient::refCount):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::create):
  • WebView/WebFrame.mm: (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
16:13 Changeset [17739] by staikos

Reviewed by Maciej.

Fix uninitialized variable.

  • rendering/RenderStyle.h:
14:54 Changeset [22525] by andersca

Remove conflict markers

14:50 Changeset [22524] by andersca

WebCoreWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Rename keyPress to keyEvent, it's used for both key presses
and releases.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • bridge/win/FrameWin.h:

WebKitWin:

2006-11-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Clean up the event handling code.


  • WebEditorClient.cpp: (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::shouldApplyStyle): Change these to return true. Eventually they will call the editing delegate.


  • WebView.cpp: (WebView::execCommand): Update to call the editor's execCommand.


(WebView::keyUp):
New function that forwards the event to FrameWin.


(editCommandForKey):
New function that given a key returns an edit command from a table. Eventually this table
should be moved into WebCore.


(WebView::handleEditingKeyboardEvent):
New function that handles editing events.


(WebView::keyDown):
If the frame is editable, call handleEditingKeyboardEvent.


(WebViewWndProc):

  • WebView.h:
13:34 Changeset [17738] by aroben

Grammar fix.

13:32 Changeset [17737] by aroben

Reviewed/landed by Adam.

Complete cleanup of the CMakeLists.txt.
Now all files to be build are sorted in alphabetic order.

General style cleanup, remove all tabs etc.

  • CMakeLists.txt:
13:32 Changeset [17736] by ddkilzer

Changed one last bugzilla.opendarwin.org URL to bugs.webkit.org.

13:28 Changeset [17735] by ddkilzer

Changed bugzilla.opendarwin.org URLs to bugs.webkit.org in ChangeLog files.

13:17 Changeset [22523] by aroben

WebCoreWin:

Reviewed by Geoff.

Move graphics-related files to platform/graphics to stay in sync with
changes from OpenSource r17727.

Also, as discussed with Darin and Steve, we now copy all our headers to
a flat include/WebCore directory instead of copying the directory
structure of WebCore. This mirrors how Mac builds.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/cg/ColorCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/win/IconWin.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.

WebKitWin:

Reviewed by Geoff.

Update WebCore #includes to use a flat directory structure.

  • DOMCSSClasses.cpp:
  • DOMCSSClasses.h:
  • DOMCoreClasses.cpp:
  • DOMEventsClasses.cpp:
  • DOMHTMLClasses.cpp:
  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebDataSource.cpp:
  • WebEditorClient.cpp:
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebHTMLRepresentation.cpp:
  • WebHistory.cpp:
  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotificationCenter.cpp:
  • WebPreferences.cpp:
  • WebURLResponse.cpp:
  • WebURLResponse.h:
  • WebView.cpp:
  • WebView.h:
11:10 Changeset [17734] by andersca

Reviewed and landed by Anders.

Make DRT work again on Qt/Linux.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):
10:36 Changeset [17733] by ggaren

Reviewed by Maciej Stachowiak.


Added missing initializer to ResourceRequest -- fixes some loader crashes
due to assuming a request always has a non-null httpMethod.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
10:08 Changeset [17732] by beidson

Reviewed by Maciej

Fixed header guard

  • loader/FrameLoaderClient.h:
08:52 Changeset [22522] by darin
  • blind attempt to fix the build
  • platform/win/CursorWin.cpp: (WebCore::verticalTextCursor): Added. Just returns the pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
08:48 Changeset [17731] by darin
  • attempt to fix Qt build
  • platform/qt/CursorQt.cpp: (WebCore::verticalTextCursor): Added. Just returns pointer cursor. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto.
07:49 Changeset [17730] by rwlbuis

Reviewed by hyatt.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
InsertRule can not handle @import statements

Allow @import as part of a css rule.

07:31 Changeset [17729] by ap

Attempt to fix Qt build.

  • CMakeLists.txt: PathQt.cpp is in graphics/qt now.
07:15 Changeset [17728] by ap

2006-11-11 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>

Tortured by Sam Weinig, Tim H., Maciej, Mitz and Alexey :-)

[CSS 3] support for vertical-text, cell and context-menu cursors
http://bugs.webkit.org/show_bug.cgi?id=11494

  • Resources/cellCursor.png: Added.
  • Resources/contextMenuCursor.png: Added.
  • Resources/verticalTextCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor):
  • rendering/RenderStyle.h: (WebCore::):
06:31 Changeset [17727] by ap

2006-11-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by aroben and ap, landed by ap.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11468

Group graphics related files in platform/graphics.
Move certain files from certain subdirectories
into platform/graphics/{win,mac,cg,gdk,qt}

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/AffineTransform.cpp: Removed.
  • platform/AffineTransform.h: Removed.
  • platform/Color.cpp: Removed.
  • platform/Color.h: Removed.
  • platform/FloatPoint.cpp: Removed.
  • platform/FloatPoint.h: Removed.
  • platform/FloatRect.cpp: Removed.
  • platform/FloatRect.h: Removed.
  • platform/FloatSize.cpp: Removed.
  • platform/FloatSize.h: Removed.
  • platform/Icon.h: Removed.
  • platform/Image.cpp: Removed.
  • platform/Image.h: Removed.
  • platform/ImageSource.h: Removed.
  • platform/IntPoint.h: Removed.
  • platform/IntRect.cpp: Removed.
  • platform/IntRect.h: Removed.
  • platform/IntSize.h: Removed.
  • platform/IntSizeHash.h: Removed.
  • platform/Path.cpp: Removed.
  • platform/Path.h: Removed.
  • platform/Pen.cpp: Removed.
  • platform/Pen.h: Removed.
  • platform/cairo/AffineTransformCairo.cpp: Removed.
  • platform/cairo/GraphicsContextCairo.cpp: Removed.
  • platform/cairo/ImageCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Removed.
  • platform/cairo/cairo/AUTHORS: Removed.
  • platform/cairo/cairo/COPYING: Removed.
  • platform/cairo/cairo/COPYING-LGPL-2.1: Removed.
  • platform/cairo/cairo/COPYING-MPL-1.1: Removed.
  • platform/cairo/cairo/INSTALL: Removed.
  • platform/cairo/cairo/NEWS: Removed.
  • platform/cairo/cairo/README: Removed.
  • platform/cairo/cairo/TODO: Removed.
  • platform/cairo/cairo/src/Makefile.in: Removed.
  • platform/cairo/cairo/src/cairo-arc-private.h: Removed.
  • platform/cairo/cairo/src/cairo-arc.c: Removed.
  • platform/cairo/cairo/src/cairo-array.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui-font.c: Removed.
  • platform/cairo/cairo/src/cairo-atsui.h: Removed.
  • platform/cairo/cairo/src/cairo-beos-surface.cpp: Removed.
  • platform/cairo/cairo/src/cairo-beos.h: Removed.
  • platform/cairo/cairo/src/cairo-cache-private.h: Removed.
  • platform/cairo/cairo/src/cairo-cache.c: Removed.
  • platform/cairo/cairo/src/cairo-clip-private.h: Removed.
  • platform/cairo/cairo/src/cairo-clip.c: Removed.
  • platform/cairo/cairo/src/cairo-color.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.c: Removed.
  • platform/cairo/cairo/src/cairo-debug.h: Removed.
  • platform/cairo/cairo/src/cairo-directfb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-directfb.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h: Removed.
  • platform/cairo/cairo/src/cairo-features.h.in: Removed.
  • platform/cairo/cairo/src/cairo-fixed.c: Removed.
  • platform/cairo/cairo/src/cairo-font-options.c: Removed.
  • platform/cairo/cairo/src/cairo-font-subset-private.h: Removed.
  • platform/cairo/cairo/src/cairo-font-subset.c: Removed.
  • platform/cairo/cairo/src/cairo-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-font.c: Removed.
  • platform/cairo/cairo/src/cairo-ft-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ft.h: Removed.
  • platform/cairo/cairo/src/cairo-glitz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-glitz.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate-private.h: Removed.
  • platform/cairo/cairo/src/cairo-gstate.c: Removed.
  • platform/cairo/cairo/src/cairo-hash-private.h: Removed.
  • platform/cairo/cairo/src/cairo-hash.c: Removed.
  • platform/cairo/cairo/src/cairo-hull.c: Removed.
  • platform/cairo/cairo/src/cairo-image-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-matrix.c: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-meta-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-output-stream.c: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface-private.h: Removed.
  • platform/cairo/cairo/src/cairo-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-path-bounds.c: Removed.
  • platform/cairo/cairo/src/cairo-path-data-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-data.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fill.c: Removed.
  • platform/cairo/cairo/src/cairo-path-fixed-private.h: Removed.
  • platform/cairo/cairo/src/cairo-path-stroke.c: Removed.
  • platform/cairo/cairo/src/cairo-path.c: Removed.
  • platform/cairo/cairo/src/cairo-pattern.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-pdf.h: Removed.
  • platform/cairo/cairo/src/cairo-pen.c: Removed.
  • platform/cairo/cairo/src/cairo-platform.h: Removed.
  • platform/cairo/cairo/src/cairo-png.c: Removed.
  • platform/cairo/cairo/src/cairo-polygon.c: Removed.
  • platform/cairo/cairo/src/cairo-private.h: Removed.
  • platform/cairo/cairo/src/cairo-ps-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-ps.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-private.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz.h: Removed.
  • platform/cairo/cairo/src/cairo-quartz2-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-quartz2.h: Removed.
  • platform/cairo/cairo/src/cairo-region.c: Removed.
  • platform/cairo/cairo/src/cairo-scaled-font.c: Removed.
  • platform/cairo/cairo/src/cairo-slope.c: Removed.
  • platform/cairo/cairo/src/cairo-spline.c: Removed.
  • platform/cairo/cairo/src/cairo-stroke-style.c: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback-private.h: Removed.
  • platform/cairo/cairo/src/cairo-surface-fallback.c: Removed.
  • platform/cairo/cairo/src/cairo-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-svg.h: Removed.
  • platform/cairo/cairo/src/cairo-traps.c: Removed.
  • platform/cairo/cairo/src/cairo-unicode.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.c: Removed.
  • platform/cairo/cairo/src/cairo-wideint.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-font.c: Removed.
  • platform/cairo/cairo/src/cairo-win32-private.h: Removed.
  • platform/cairo/cairo/src/cairo-win32-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-win32.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xcb-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xcb.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-private.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-screen.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-surface.c: Removed.
  • platform/cairo/cairo/src/cairo-xlib-test.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib-xrender.h: Removed.
  • platform/cairo/cairo/src/cairo-xlib.h: Removed.
  • platform/cairo/cairo/src/cairo.c: Removed.
  • platform/cairo/cairo/src/cairo.h: Removed.
  • platform/cairo/cairo/src/cairoint.h: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.c: Removed.
  • platform/cairo/cairo/src/test-fallback-surface.h: Removed.
  • platform/cairo/cairo/src/test-meta-surface.c: Removed.
  • platform/cairo/cairo/src/test-meta-surface.h: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.c: Removed.
  • platform/cairo/cairo/src/test-paginated-surface.h: Removed.
  • platform/cairo/pixman/AUTHORS: Removed.
  • platform/cairo/pixman/COPYING: Removed.
  • platform/cairo/pixman/README: Removed.
  • platform/cairo/pixman/src/Makefile.in: Removed.
  • platform/cairo/pixman/src/fbcompose.c: Removed.
  • platform/cairo/pixman/src/fbedge.c: Removed.
  • platform/cairo/pixman/src/fbedgeimp.h: Removed.
  • platform/cairo/pixman/src/fbmmx.c: Removed.
  • platform/cairo/pixman/src/fbmmx.h: Removed.
  • platform/cairo/pixman/src/fbpict.c: Removed.
  • platform/cairo/pixman/src/fbpict.h: Removed.
  • platform/cairo/pixman/src/fbtrap.c: Removed.
  • platform/cairo/pixman/src/icblt.c: Removed.
  • platform/cairo/pixman/src/icbltone.c: Removed.
  • platform/cairo/pixman/src/iccolor.c: Removed.
  • platform/cairo/pixman/src/icformat.c: Removed.
  • platform/cairo/pixman/src/icimage.c: Removed.
  • platform/cairo/pixman/src/icimage.h: Removed.
  • platform/cairo/pixman/src/icint.h: Removed.
  • platform/cairo/pixman/src/icpixels.c: Removed.
  • platform/cairo/pixman/src/icrect.c: Removed.
  • platform/cairo/pixman/src/icrop.h: Removed.
  • platform/cairo/pixman/src/icstipple.c: Removed.
  • platform/cairo/pixman/src/ictransform.c: Removed.
  • platform/cairo/pixman/src/ictrap.c: Removed.
  • platform/cairo/pixman/src/ictri.c: Removed.
  • platform/cairo/pixman/src/icutil.c: Removed.
  • platform/cairo/pixman/src/pixman-remap.h: Removed.
  • platform/cairo/pixman/src/pixman-xserver-compat.h: Removed.
  • platform/cairo/pixman/src/pixman.h: Removed.
  • platform/cairo/pixman/src/pixregion.c: Removed.
  • platform/cairo/pixman/src/pixregionint.h: Removed.
  • platform/cairo/pixman/src/renderedge.c: Removed.
  • platform/cairo/pixman/src/renderedge.h: Removed.
  • platform/cairo/pixman/src/slim_internal.h: Removed.
  • platform/cairo/rgb24-hacks.txt: Removed.
  • platform/cairo/scale-removal.txt: Removed.
  • platform/cg/AffineTransformCG.cpp: Removed.
  • platform/cg/FloatPointCG.cpp: Removed.
  • platform/cg/FloatRectCG.cpp: Removed.
  • platform/cg/FloatSizeCG.cpp: Removed.
  • platform/cg/GraphicsContextCG.cpp: Removed.
  • platform/cg/GraphicsContextPlatformPrivate.h: Removed.
  • platform/cg/ImageCG.cpp: Removed.
  • platform/cg/ImageSourceCG.cpp: Removed.
  • platform/cg/IntPointCG.cpp: Removed.
  • platform/cg/IntRectCG.cpp: Removed.
  • platform/cg/IntSizeCG.cpp: Removed.
  • platform/cg/PDFDocumentImage.cpp: Removed.
  • platform/cg/PDFDocumentImage.h: Removed.
  • platform/cg/PathCG.cpp: Removed.
  • platform/gdk/ImageGdk.cpp: Removed.
  • platform/mac/ColorMac.mm: Removed.
  • platform/mac/FloatPointMac.mm: Removed.
  • platform/mac/FloatRectMac.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Removed.
  • platform/mac/GraphicsContextMac.mm:
  • platform/mac/IconMac.mm: Removed.
  • platform/mac/ImageMac.mm: Removed.
  • platform/mac/IntPointMac.mm: Removed.
  • platform/mac/IntRectMac.mm: Removed.
  • platform/mac/IntSizeMac.mm: Removed.
  • platform/qt/AffineTransformQt.cpp: Removed.
  • platform/qt/ColorQt.cpp: Removed.
  • platform/qt/FloatPointQt.cpp: Removed.
  • platform/qt/FloatRectQt.cpp: Removed.
  • platform/qt/IconQt.cpp: Removed.
  • platform/qt/ImageQt.cpp: Removed.
  • platform/qt/ImageSourceQt.cpp: Removed.
  • platform/qt/IntPointQt.cpp: Removed.
  • platform/qt/IntRectQt.cpp: Removed.
  • platform/qt/IntSizeQt.cpp: Removed.
  • platform/qt/PathQt.cpp: Removed.
  • platform/win/ImageWin.cpp: Removed.
  • platform/win/IntPointWin.cpp: Removed.
  • platform/win/IntRectWin.cpp: Removed.
  • platform/win/IntSizeWin.cpp: Removed.
05:10 Changeset [17726] by gdennis

Build fix.

04:34 Changeset [17725] by gdennis

WebCore:

Reviewed by hyatt.

A layout test was added when this bug was fixed, so none needed now.


Cleanup after:
REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570


  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Removed.
  • rendering/RenderText.cpp: (WebCore::isSpace): Added. (WebCore::RenderText::calcMinMaxWidth): Use inline function instead of polluting RenderStyle.
04:04 Changeset [17724] by gdennis

WebCore:

Reviewed by mitz.


REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • rendering/RenderStyle.h: (WebCore::RenderStyle::isSpace): Added.
  • rendering/RenderText.cpp: (WebCore::RenderText::calcMinMaxWidth): For the purposes of calculating the line widths, treat non-breaking spaces the same as normal spaces if -webkit-nbsp-mode is 'space'

LayoutTests:

Reviewed by mitz.

REGRESSION (r16122): min/max widths incorrectly calculated for contentEditable text
http://bugs.webkit.org/show_bug.cgi?id=11570

  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.checksum: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.png: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps-expected.txt: Added.
  • fast/text/whitespace/nbsp-mode-and-linewraps.html: Added.
00:50 Changeset [17723] by ap

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11508
Undisable some warnings for JSImmediate.h

Fix suggested by Don Gibson.

  • kjs/JSImmediate.h: Re-enable all MSVC warnings, move the remaining runtime checks to compile-time.

11/10/06:

19:11 Changeset [22521] by sfalken
18:55 Changeset [17722] by bdash

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added s60/symbian platform defines.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • wtf/Platform.h:

2006-11-10 Zalan Bujtas <zalan.bujtas@nokia.com>

Reviewed by Maciej.

Added basic types for symbian platform.
http://bugs.webkit.org/show_bug.cgi?id=11540

  • config.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): (WebCore::AtomicString::operator TPtrC):
  • platform/DeprecatedString.cpp: (WebCore::initializeHandleNodeBlock):
  • platform/DeprecatedString.h: char _internalBuffer has to be in front of the bitfields as Codewarrior (3.2.5 build 461) compiler cannot cope with bitfields and breaks byte aligment
  • platform/FloatPoint.h:
  • platform/FloatRect.h:
  • platform/IntPoint.h:
  • platform/IntRect.h:
  • platform/IntSize.h:
  • platform/PlatformString.h: (WebCore::String::operator TPtrC): (WebCore::String::des):
  • platform/StringImpl.h:
  • platform/symbian/DeprecatedStringSymbian.cpp: Added. (WebCore::DeprecatedString::setBufferFromDes): (WebCore::DeprecatedString::fromDes): (WebCore::DeprecatedString::des): (WebCore::DeprecatedString::des8):
  • platform/symbian/FloatPointSymbian.cpp: Added. (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::operator TPoint):
  • platform/symbian/FloatRectSymbian.cpp: Added. (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::operator TRect): (WebCore::FloatRect::rect):
  • platform/symbian/IntPointSymbian.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator TPoint):
  • platform/symbian/IntRectSymbian.cpp: Added. (WebCore::IntRect::IntRect): (WebCore::IntRect::operator TRect): (WebCore::IntRect::Rect):
  • platform/symbian/IntSizeSymbian.cpp: Added. (WebCore::IntSize::IntSize): (WebCore::IntSize::operator TSize):
  • platform/symbian/StringImplSymbian.cpp: Added. (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::des):
  • platform/symbian/StringSymbian.cpp: Added. (WebCore::String::String):
18:33 Changeset [17721] by bdash

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Adjust to the changes Brady made in the Qt code.

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
  • loader/qt/FrameLoaderClientQt.h:

2006-11-10 Zack Rusin <zack@kde.org>

Reviewed by Anders.

Making the Qt code work after refactorings in WebCore.

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
17:56 Changeset [17720] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself

  • editing/deleting/delete-link-1-expected.checksum: Added.
  • editing/deleting/delete-link-1-expected.png: Added.
  • editing/deleting/delete-link-1-expected.txt: Added.
  • editing/deleting/delete-link-1.html: Added.
  • editing/inserting/insert-before-link-1-expected.checksum: Added.
  • editing/inserting/insert-before-link-1-expected.png: Added.
  • editing/inserting/insert-before-link-1-expected.txt: Added.
  • editing/inserting/insert-before-link-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4069359>
Deleting hyperlink text, then typing uses link typing style but loses the link itself


The removed anchor element needs to stick around temporarily, in the same way
that the typing style hangs off the caret until the user moves it. Also text
insertion around anchors didn't match TextEdit.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Added. (WebCore::DeleteSelectionCommand::doApply): Call saveFullySelectedAnchor.
  • editing/DeleteSelectionCommand.h:
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): Clear the removed anchor after any top level editing command that doesn't preserve the typing style (matches TextEdit).
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Added a fixme: we shouldn't call setSelection with a message telling it to clear the typing style (and the saved anchor) here. Save/restore the saved anchor because of this.
  • editing/Editor.h: (WebCore::Editor::removedAnchor): Getter. (WebCore::Editor::setRemovedAnchor): Setter.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::prepareForTextInsertion): Insert the saved anchor if one exists.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Clear the removed anchor whenever we make a selection change that clears the typing style. (WebCore::SelectionController::nodeWillBeRemoved): Removed an old outdated FIXME.
  • editing/htmlediting.cpp: (WebCore::positionAvoidingSpecialElementBoundary): Cleaned up and made some changes to match TextEdit's behavior. First, insert content inside the anchor when the caret is after it, unless the caret is at the end of the document, or if the caret is before it and at the start of a paragraph.
17:33 Changeset [22520] by aroben
17:19 Changeset [17719] by thatcher

New tag.

17:18 Changeset [17718] by thatcher

Versioning.

17:15 Changeset [17717] by thatcher

Reviewed by Hyatt.

Check for BHIDDEN in isVisible() also.

  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:51 Changeset [17716] by thatcher

Reviewed by Adam.

<rdar://problem/4821423> element deletion UI appears for Mail blockquote and others with less than three visible borders

Added a new function to BorderValue called isVisible(). This checks nonZero() and !isTransparent().

  • editing/DeleteButtonController.cpp: (WebCore::isDeletableElement):
  • rendering/RenderStyle.h: (WebCore::BorderValue::isVisible):
16:20 Changeset [17715] by thatcher

Build fix.

16:11 Changeset [22519] by beidson

Enthousiastically review by Beth (with exclamation marks and everything!!!1!!one!)

No need for WebIconDatabase to keep its own reference to the
WebCore::IconDatabase


  • WebIconDatabase.cpp: (WebIconDatabase::WebIconDatabase): (WebIconDatabase::init): (WebIconDatabase::iconForURL): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL):
  • WebIconDatabase.h:
16:10 Changeset [17714] by thatcher

64-bit build fix. Generates a derived export file for 64-bit architectures.

16:01 Changeset [22518] by andersca

2006-11-10 Anders Carlsson <acarlsson@apple.com>

Reviewed by Oliver.

Implement findNextWordFromIndex using ICU.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findSentenceBoundary):
  • platform/win/TextBoundariesWin.cpp: (WebCore::findNextWordFromIndex):
15:45 Changeset [17713] by aroben

Rubberstamped by Anders.

Back out some accidentally-committed changes from r17711.

  • page/Frame.cpp: (WebCore::Frame::command): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
15:36 Changeset [17712] by mjs

Reviewed by Anders.


  • remove some unnecessary uses of WebDataProtocol
  • WebView/WebDataSource.mm: Remove the unneeded include.
  • WebView/WebView.mm: (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here. Any request that has one will be an applewebdata: request, which will pass the check anyway.
15:20 Changeset [17711] by andersca

WebCore:

Reviewed by Geoff.

Add more commands, make toggleBold and toggleItalic executable commands.

  • WebCore.exp:
  • editing/Editor.cpp: (WebCore::execCopy): (WebCore::execCut): (WebCore::execDelete): (WebCore::execForwardDelete): (WebCore::execPaste): (WebCore::execSelectAll): (WebCore::execToggleBold): (WebCore::execToggleItalic): (WebCore::enabled): (WebCore::canPaste): (WebCore::hasEditableSelection): (WebCore::hasEditableRangeSelection): (WebCore::hasRangeSelection): (WebCore::hasRichlyEditableSelection): (WebCore::CommandEntry::):
  • editing/Editor.h:

WebKit:

Reviewed by Geoff.

Update for changes to WebCore

  • WebView/WebHTMLView.m: (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _toggleBold]): (-[NSArray _toggleItalic]):
14:29 Changeset [17710] by spadma

2006-11-10 spaltis <Stanislav.Paltis@nokia.com>

Reviewed by Sachin.
DESC: For the progressive download,if it's already set by music player, we should not set it here.
http://bugs.webkit.org/show_bug.cgi?id=11568

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::HandleDMgrEventL):
13:53 Changeset [17709] by sfalken

New tag.

13:51 Changeset [22517] by sfalken

2006-11-10 Steve Falkenburg <sfalken@apple.com>

Bump version number for submission

  • VERSION:
  • WebKit.vcproj/VERSION:
13:35 Changeset [22516] by ggaren

Oops. Checked in too much. Rolling out the extra.

13:33 Changeset [22515] by ggaren

Fixed build -- you can't delete the shared icon database -- it's a singleton

13:12 Changeset [17708] by ggaren

Fixed platform #ifs

13:07 Changeset [17707] by spadma

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
13:00 Changeset [17706] by spadma

2006-11-10 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: OSS Browser: Crash when getting the currently in-use Access Point Id via the BrCtl Interface
http://bugs.webkit.org/show_bug.cgi?id=11566

  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
11:45 Changeset [17705] by andersca

WebCore:

Reviewed by Maciej, Geoff.

Added an execCommand method to Editor. The idea is that this should replace the CommandByName object. Get rid of
the alterCurrentSelection method in the bridge. WebKit can just call execCommand directly.

  • WebCore.exp:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::execMoveBackward): (WebCore::execMoveBackwardAndModifySelection): (WebCore::execMoveDown): (WebCore::execMoveDownAndModifySelection): (WebCore::execMoveForward): (WebCore::execMoveForwardAndModifySelection): (WebCore::execMoveLeft): (WebCore::execMoveLeftAndModifySelection): (WebCore::execMoveRight): (WebCore::execMoveRightAndModifySelection): (WebCore::execMoveToBeginningOfDocument): (WebCore::execMoveToBeginningOfDocumentAndModifySelection): (WebCore::execMoveToBeginningOfSentence): (WebCore::execMoveToBeginningOfSentenceAndModifySelection): (WebCore::execMoveToBeginningOfLine): (WebCore::execMoveToBeginningOfLineAndModifySelection): (WebCore::execMoveToBeginningOfParagraph): (WebCore::execMoveToBeginningOfParagraphAndModifySelection): (WebCore::execMoveToEndOfDocument): (WebCore::execMoveToEndOfDocumentAndModifySelection): (WebCore::execMoveToEndOfSentence): (WebCore::execMoveToEndOfSentenceAndModifySelection): (WebCore::execMoveToEndOfLine): (WebCore::execMoveToEndOfLineAndModifySelection): (WebCore::execMoveToEndOfParagraph): (WebCore::execMoveToEndOfParagraphAndModifySelection): (WebCore::execMoveParagraphBackwardAndModifySelection): (WebCore::execMoveParagraphForwardAndModifySelection): (WebCore::execMoveUp): (WebCore::execMoveUpAndModifySelection): (WebCore::execMoveWordBackward): (WebCore::execMoveWordBackwardAndModifySelection): (WebCore::execMoveWordForward): (WebCore::execMoveWordForwardAndModifySelection): (WebCore::execMoveWordLeft): (WebCore::execMoveWordLeftAndModifySelection): (WebCore::execMoveWordRight): (WebCore::execMoveWordRightAndModifySelection): (WebCore::enabledAnySelection): (WebCore::createCommandMap): (WebCore::CommandEntry::): (WebCore::Editor::execCommand):
  • editing/Editor.h:

WebKit:

Reviewed by Maciej, Geoff.

Call execCommand directly here instead of going through the bridge.


  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]):
11:31 Changeset [22514] by beidson

Reviewed by Darin

Keep windows build from breaking

  • WebFrame.cpp: (WebFrame::dispatchDidReceiveIcon):
  • WebFrame.h:
11:24 Changeset [17704] by beidson

WebCore:

Reviewed by Darin

Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed.
  • loader/FrameLoaderClient.h:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::~IconDatabase):
  • loader/icon/IconDatabase.h: (WebCore::IconDatabase::isPrivateBrowsingEnabled): (WebCore::IconDatabase::enabled):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::finishLoading):
  • loader/mac/FrameLoaderMac.mm:

WebKit:

Reviewed by Darin


Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase defaultIconForURL:withSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase setDelegate:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase isIconExpiredForIconURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (-[WebIconDatabase _convertToWebCoreFormat]): (webGetNSImage):
  • Misc/WebIconDatabaseInternal.h: Added.
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveIcon):
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed.
  • WebCoreSupport/WebIconDatabaseBridge.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
11:16 Changeset [17703] by andersca

WebCore:

Reviewed and landed by Anders.

Adjust platform Qt/KDE code to the recent loader
changes.

  • CMakeLists.txt:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createEmptyDocument):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/qt/DocumentLoaderQt.cpp: Added. (WebCore::canonicalizedTitle): (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::~DocumentLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setupForReplace): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::finishedLoading): (WebCore::DocumentLoader::setCommitted): (WebCore::DocumentLoader::isCommitted): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::isLoading): (WebCore::DocumentLoader::doesProgressiveLoad): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::attachToFrame): (WebCore::DocumentLoader::detachFromFrame): (WebCore::DocumentLoader::prepareForLoadStart): (WebCore::DocumentLoader::loadingStartedTime): (WebCore::DocumentLoader::setIsClientRedirect): (WebCore::DocumentLoader::isClientRedirect): (WebCore::DocumentLoader::setPrimaryLoadComplete): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::DocumentLoader::title): (WebCore::DocumentLoader::triggeringAction): (WebCore::DocumentLoader::setTriggeringAction): (WebCore::DocumentLoader::setOverrideEncoding): (WebCore::DocumentLoader::overrideEncoding): (WebCore::DocumentLoader::setTitle): (WebCore::DocumentLoader::URLForHistory):
  • loader/qt/FrameLoaderClientQt.cpp: Added. (WebCore::FrameLoaderClientQt::FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::~FrameLoaderClientQt): (WebCore::FrameLoaderClientQt::detachFrameLoader): (WebCore::FrameLoaderClientQt::hasWebView): (WebCore::FrameLoaderClientQt::hasFrameView): (WebCore::FrameLoaderClientQt::hasBackForwardList): (WebCore::FrameLoaderClientQt::resetBackForwardList): (WebCore::FrameLoaderClientQt::provisionalItemIsTarget): (WebCore::FrameLoaderClientQt::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientQt::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientQt::privateBrowsingEnabled): (WebCore::FrameLoaderClientQt::makeDocumentView): (WebCore::FrameLoaderClientQt::makeRepresentation): (WebCore::FrameLoaderClientQt::forceLayout): (WebCore::FrameLoaderClientQt::forceLayoutForNonHTML): (WebCore::FrameLoaderClientQt::updateHistoryForCommit): (WebCore::FrameLoaderClientQt::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientQt::updateHistoryForReload): (WebCore::FrameLoaderClientQt::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientQt::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientQt::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientQt::setCopiesOnScroll): (WebCore::FrameLoaderClientQt::tokenForLoadErrorReset): (WebCore::FrameLoaderClientQt::resetAfterLoadError): (WebCore::FrameLoaderClientQt::doNotResetAfterLoadError): (WebCore::FrameLoaderClientQt::willCloseDocument): (WebCore::FrameLoaderClientQt::detachedFromParent1): (WebCore::FrameLoaderClientQt::detachedFromParent2): (WebCore::FrameLoaderClientQt::detachedFromParent3): (WebCore::FrameLoaderClientQt::detachedFromParent4): (WebCore::FrameLoaderClientQt::loadedFromPageCache): (WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientQt::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchWillClose): (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): (WebCore::FrameLoaderClientQt::dispatchDidFirstLayout): (WebCore::FrameLoaderClientQt::dispatchShow): (WebCore::FrameLoaderClientQt::cancelPolicyCheck): (WebCore::FrameLoaderClientQt::dispatchWillSubmitForm): (WebCore::FrameLoaderClientQt::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientQt::clearLoadingFromPageCache): (WebCore::FrameLoaderClientQt::isLoadingFromPageCache): (WebCore::FrameLoaderClientQt::revertToProvisionalState): (WebCore::FrameLoaderClientQt::clearUnarchivingState): (WebCore::FrameLoaderClientQt::progressStarted): (WebCore::FrameLoaderClientQt::progressCompleted): (WebCore::FrameLoaderClientQt::setMainFrameDocumentReady): (WebCore::FrameLoaderClientQt::willChangeTitle): (WebCore::FrameLoaderClientQt::didChangeTitle): (WebCore::FrameLoaderClientQt::finishedLoading): (WebCore::FrameLoaderClientQt::finalSetupForReplace): (WebCore::FrameLoaderClientQt::setDefersLoading): (WebCore::FrameLoaderClientQt::isArchiveLoadPending): (WebCore::FrameLoaderClientQt::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientQt::clearArchivedResources): (WebCore::FrameLoaderClientQt::canShowMIMEType): (WebCore::FrameLoaderClientQt::representationExistsForURLScheme): (WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientQt::frameLoadCompleted): (WebCore::FrameLoaderClientQt::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientQt::provisionalLoadStarted): (WebCore::FrameLoaderClientQt::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientQt::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientQt::didFinishLoad): (WebCore::FrameLoaderClientQt::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientQt::setTitle): (WebCore::FrameLoaderClientQt::userAgent):
  • loader/qt/FrameLoaderClientQt.h: Added.
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/qt/NavigationActionQt.cpp: Added. (WebCore::navigationType): (WebCore::NavigationAction::NavigationAction):
  • loader/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::loadsBlocked):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::slotResult): (WebCore::ResourceHandleManager::cancel):
  • platform/qt/ChromeClientQt.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::ChromeClientQt::ChromeClientQt): (WebCore::ChromeClientQt::~ChromeClientQt): (WebCore::ChromeClientQt::setWindowRect): (WebCore::ChromeClientQt::windowRect): (WebCore::ChromeClientQt::pageRect): (WebCore::ChromeClientQt::scaleFactor): (WebCore::ChromeClientQt::focus): (WebCore::ChromeClientQt::unfocus): (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog): (WebCore::ChromeClientQt::show): (WebCore::ChromeClientQt::canRunModal): (WebCore::ChromeClientQt::runModal): (WebCore::ChromeClientQt::setToolbarsVisible): (WebCore::ChromeClientQt::toolbarsVisible): (WebCore::ChromeClientQt::setStatusbarVisible): (WebCore::ChromeClientQt::statusbarVisible): (WebCore::ChromeClientQt::setScrollbarsVisible): (WebCore::ChromeClientQt::scrollbarsVisible): (WebCore::ChromeClientQt::setMenubarVisible): (WebCore::ChromeClientQt::menubarVisible): (WebCore::ChromeClientQt::setResizable):
  • platform/qt/ChromeClientQt.h: Added.
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldBeginEditing): (WebCore::EditorClientQt::shouldEndEditing): (WebCore::EditorClientQt::shouldApplyStyle): (WebCore::EditorClientQt::didBeginEditing): (WebCore::EditorClientQt::respondToChangedContents): (WebCore::EditorClientQt::didEndEditing):
  • platform/qt/EditorClientQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::keyEvent):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::didReceiveData): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/ImageQt.cpp:
  • platform/qt/MimeTypeRegistryQt.cpp: Added. (WebCore::getMIMETypeForUTI): (WebCore::MimeTypeRegistry::getMIMETypeForExtension):
  • platform/qt/PageQt.cpp:
  • platform/qt/PlatformKeyboardEventQt.cpp: (WebCore::keyIdentifierForQtKeyCode):
  • platform/qt/ScreenQt.cpp:
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::TextField::TextField): (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):

WebKitQt:

Reviewed and landed by Anders.

Adjusting to the recent loader changes, making it compile
and work.

  • QtLauncher/main.cpp: (main):
  • WebKitPart/WebKitPart.cpp: (WebKitPart::closeUrl): (WebKitPart::initView):
00:42 Changeset [17702] by beidson

Reviewed by Mitz

http://bugs.webkit.org/show_bug.cgi?id=11554
Fix the above bug (in didFinishLoading) and also another potential bug in didFailWithError
in case the icon load fails after some data has been received.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFailWithError): Clear the buffer so half-an-image isn't commited to the DB on error. Also, as a loader re-factoring sanity check, added an assertion (WebCore::IconLoader::didFinishLoading): If an icon loader resulted in an error-response, the icon is already committed to the DB. Skip doing that step twice.
00:22 Changeset [22513] by oliver

2006-11-10 Oliver Hunt <oliver@apple.com>

Build fix


sprintf -> format (from Maciej's earlier change to WebCore)

  • WebView.cpp: (osVersion): (WebView::userAgentForKURL):
Note: See TracTimeline for information about the timeline view.