Timeline


and

11/16/06:

19:04 Changeset [22557] by aroben

WebKitWin:

Reviewed by Steve, Ada.

Added new WebMenuItemBaseApplicationTag to the WebMenuItemTag enum to
keep WebKit apps from conflicting with WebKit context menu identifiers.

  • Interfaces/IWebUIDelegate.idl:
18:11 Changeset [17825] by beidson

LayoutTests:

Reviewed and landed by Brady

Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render

  • fast/css/import-rule-regression-11590-expected.txt: Added.
  • fast/css/import-rule-regression-11590.html: Added.
  • fast/css/resources/imports.css: Added.
  • fast/css/resources/style.css: Added.

WebCore:

Reviewed and landed by Brady

Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.

  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
  • dom/Node.h: (WebCore::Node::sheetLoaded):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
  • dom/ProcessingInstruction.h:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded):
  • html/HTMLLinkElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded):
  • html/HTMLStyleElement.h:
17:06 Changeset [17824] by harrison

Reviewed by Beth.

<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message

The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.

Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.

Test added:

  • manual-tests/delete-into-nested-block.html


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
  • rendering/RenderBox.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved):
  • rendering/RenderObject.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
16:07 Changeset [22556] by adele

Reviewed by Adam.

Added theme for sider.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::sliderTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineSliderThumbState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::adjustSliderThumbSize):
  • rendering/RenderThemeWin.h:
16:03 Changeset [17823] by adele

Reviewed by Adam.

Slider cleanup. Let the theme set the size of the slider thumb.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
  • rendering/RenderTheme.h: ditto.
  • rendering/RenderThemeMac.h: ditto.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
15:34 Changeset [17822] by spadma

2006-11-15 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
15:27 Changeset [17821] by spadma

2006-11-15 yaharon <yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
15:24 Changeset [17820] by spadma

2006-11-16 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Fix copyright issues
http://bugs.webkit.org/show_bug.cgi?id=11620

  • BrowserView/inc/WidgetExtension.h:
  • BrowserView/inc/WidgetPreferences.h:
  • BrowserView/inc/WidgetRenderer.h:
  • BrowserView/src/WidgetExtension.cpp:
  • BrowserView/src/WidgetPreferences.cpp:
  • BrowserView/src/WidgetRenderer.cpp: (TWidgetRenderer::TWidgetRenderer): (TWidgetRenderer::PrepareForTransitionL): (TWidgetRenderer::PerformTransitionL): (TWidgetRenderer::TransitionCb): (TWidgetRenderer::DrawFadeMaskL): (TWidgetRenderer::DrawTransition):
14:54 Changeset [17819] by spadma

2006-11-15 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Feeds Engine / Form element in feed article: If input box is selected the browser crashes.
http://bugs.webkit.org/show_bug.cgi?id=11603

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):
13:22 Changeset [17818] by andersca

Reviewed by Darin.

Use Vector instead of DeprecatedValueList in a few places.


  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems):
  • bindings/objc/DOM.mm:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff):
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems):
  • html/HTMLCollection.h:
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
  • platform/network/FormData.h:
  • rendering/RenderPath.h:
  • rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):
13:03 Changeset [17817] by andersca

Reviewed by Tim.

  • editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents.
12:32 Changeset [17816] by ap

2006-11-16 Don Gibson <dgibson77@gmail.com>

Reviewed and landed by ap.

http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.

Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
  • bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress):
  • bridge/win/FrameWin.h:
  • bridge/win/PageWin.cpp: Removed.
  • editing/EditCommand.h:
  • loader/FormState.h:
  • loader/FrameLoader.h:
  • page/EventHandler.cpp:
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
  • platform/graphics/win/ImageWin.cpp:
  • platform/network/ResourceError.cpp:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
  • platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth):
  • platform/win/SoundWin.cpp: Added. (WebCore::systemBeep):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus):

WebKit:

  • COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData):
  • COM/WebFrame.h:
  • COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
  • WebKit.vcproj/WebKit.vcproj:
11:58 Changeset [17815] by thatcher

Reviewed by Adam.

<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made

  • editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup
11:52 Changeset [17814] by staikos

Rubberstamped by Maciej.

Making the code valgrind clean.

11:49 Changeset [17813] by andersca

Reviewed by Tim.

<rdar://problem/4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message


  • Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
10:35 Changeset [17812] by thatcher

Adding back a correct version of this assert.

09:59 Changeset [17811] by harrison

Reviewed by Darin and Tim.

<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page


  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode().
09:52 Changeset [17810] by thatcher

Reviewed by Darin.

<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected

Consider the container of the selection range for deletion before asking enclosingNodeOfType().

  • editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
09:09 Changeset [17809] by spadma

2006-11-16 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
http://bugs.webkit.org/show_bug.cgi?id=11605

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
00:43 Changeset [17808] by rwlbuis

Reviewed by hyatt.

Removal of unused m_styleElement.

11/15/06:

23:14 Changeset [17807] by aroben

Build fix.

Rename the items in the ContextMenuAction enum so that they don't
conflict with WebKit names.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
  • platform/ContextMenu.h: (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem):
22:56 Changeset [17806] by aroben

Reviewed by Anders.

Change m_contextMenu to an OwnPtr.

  • WebCore.xcodeproj/project.pbxproj:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
  • page/ContextMenuController.h:
22:50 Changeset [22555] by aroben

WebCoreWin:

Reviewed by Anders.

Added new ContextMenuClient and ContextMenuController classes.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/ContextMenuWin.cpp: Added method implementations Beth forgot to check in in r11129. (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::appendItem):

WebKitWin:

Reviewed by Anders.

Added new WebContextMenuClient class, and moved context menu-related
code there from WebChromeClient.

  • WebChromeClient.cpp: (WebChromeClient::setResizable):
  • WebChromeClient.h:
  • WebContextMenuClient.cpp: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
  • WebContextMenuClient.h: Added.
  • WebKit.vcproj/WebKit.vcproj: Added new files.
  • WebView.cpp: (WebView::initWithFrame):
22:43 Changeset [17805] by aroben

WebCore:

Reviewed by Anders.

Add new ContextMenuController and ContextMenuClient classes, and move
context menu responsibilities from Chrome and ChromeClient to them.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj: Add new files to project, and alphabetize some others.
  • page/Chrome.cpp: Remove context menu-related code.
  • page/Chrome.h: Ditto.
  • page/ChromeClient.h:
  • page/ContextMenuClient.h: Added.
  • page/ContextMenuController.cpp: Added. (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::~ContextMenuController): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::contextMenuActionSelected):
  • page/ContextMenuController.h: Added. (WebCore::ContextMenuController::client):
  • page/Page.cpp: Every Page now has a ContextMenuController. (WebCore::Page::Page):
  • page/Page.h: Made m_dragCaretController and m_chrome objects instead of pointers to objects. (WebCore::Page::contextMenuController):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the delegate to add its menu items, and moved the code from the static addDefaultItems function into this method.
  • platform/ContextMenu.h: (WebCore::ContextMenu::show): Added an empty method body since this method is now called from ContextMenuController (although no one calls into ContextMenuController yet, so it's OK for this to be empty). (WebCore::ContextMenu::hide): Ditto.

WebKit:

Reviewed by Anders.

Added new WebContextMenuClient class to act as WebCore's ChromeClient,
and moved context menu-related code there from WebChromeClient.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebContextMenuClient.h: Added. (WebContextMenuClient::webView):
  • WebCoreSupport/WebContextMenuClient.mm: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
  • WebKit.xcodeproj/project.pbxproj: Added new files.
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):
21:53 Changeset [17804] by thatcher

Removing this assert until I can look into the problem further.

20:23 Changeset [17803] by andersca

Reviewed by Darin.

Add null checks on the node filter, they can be null if no filter was passed to the respective
create functions.


  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
19:13 Changeset [22554] by ggaren

Reviewed by Anders Carlsson.


Fixed flash of plug-in content outside its containing iframe while
scrolling the iframe.


The problem was that the plug-in would draw between our call to MoveWindow
and our call to SetWindowRgn. The solution here is to lock all updates in
the plug-in's HWND until we've called both MoveWindow and SetWindowRgn.


Tested with Quicktime and Flash.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::geometryChanged):
  • plugins/win/PluginViewWin.h: Removed bogus invalidate parameter to updateHwnd.
19:07 Changeset [17802] by oliver

2006-11-15 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.

Allow <embed> and <object> tags to include non-plugin
content when plugins are disabled

Fixes <rdar://problems/4839488>

  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
18:34 Changeset [17801] by adele

Build fix. Another type problem that I don't see locally.

  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
18:24 Changeset [17800] by adele

Reviewed by Adam.

Adding MathExtras header.

  • rendering/RenderSlider.cpp:
18:00 Changeset [17799] by thatcher

Reviewed by Harrison.

<rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)

  • Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
  • Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
  • Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
  • editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::isDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed (WebCore::DeleteButtonController::deleteTarget): check the enabled state
  • editing/DeleteButtonController.h: (WebCore::DeleteButtonController::disable): (WebCore::DeleteButtonController::enable): (WebCore::DeleteButtonController::enabled):
  • editing/EditCommand.cpp: (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end (WebCore::EditCommand::unapply): ditto (WebCore::EditCommand::reapply): ditto
17:46 Changeset [22553] by adele

Reviewed by Adam.

Adding RenderSlider class, and removing DeprecatedSlider and Slider classes.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
17:42 Changeset [17798] by adele

LayoutTests:

Reviewed by Adam.

Updating results for new slider implementation.

  • fast/forms/input-appearance-height-expected.checksum:
  • fast/forms/input-appearance-height-expected.png:
  • fast/forms/input-appearance-height-expected.txt:

WebCore:

Reviewed by Adam.

New implementation of slider control.

  • WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
  • rendering/DeprecatedSlider.cpp: Removed.
  • rendering/DeprecatedSlider.h: Removed.
  • platform/Slider.h: Removed.
  • platform/mac/SliderMac.mm: Removed.
  • platform/win/TemporaryLinkStubs.cpp:
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
  • rendering/RenderStyle.cpp: (WebCore::): (WebCore::pseudoBit):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::):
  • css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements. (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
  • page/EventHandler.cpp: Added concept of a node that will capture all mouse events. This will be used by the slider thumb, so it can continue to capture mouse move events during the drag, even though those events aren't directly over the slider. (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::setCapturingMouseEventsNode): (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
  • page/EventHandler.h:
  • rendering/RenderSlider.cpp: Added. (WebCore::HTMLSliderThumbElement::isShadowNode): (WebCore::HTMLSliderThumbElement::shadowParentNode): (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode. (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement): (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag. (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::~RenderSlider): (WebCore::RenderSlider::baselinePosition): (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track. (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::valueChanged): (WebCore::RenderSlider::currentPosition): (WebCore::RenderSlider::setCurrentPosition): (WebCore::RenderSlider::trackSize): (WebCore::RenderSlider::forwardEvent): (WebCore::RenderSlider::inDragMode):
  • rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName):
  • rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.

(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):

  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle):
17:36 Changeset [17797] by bdakin

Reviewed by Adam.

Oops! Forgot to add this!

  • platform/mac/ContextMenuMac.mm: Added. (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]): (-[MenuTarget WebCore::]): (-[MenuTarget setMenu:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformMenuDescription):
17:33 Changeset [22552] by bdakin

WebCore:

Reviewed by Adam and Beth.

Internal side of r17796.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ContextMenuWin.cpp: Added. (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformMenuDescription):

WebKit:

Reviewed by Adam and Beth.

Internal side of r17796.

  • WebChromeClient.cpp: (WebChromeClient::addCustomContextMenuItems):
  • WebChromeClient.h:
17:27 Changeset [17796] by bdakin

WebCore:

Reviewed by Adam and Beth.

Initial cut at pushing Context Menus into WebCore. Nobody actually
calls this code just yet.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Chrome.cpp: (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to call into addContextMenuItems on the UIDelegate.
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/ContextMenu.cpp: Added. (WebCore::addDefaultItems): (WebCore::ContextMenu::populate):
  • platform/ContextMenu.h: Added. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformMenuDescription):

WebKit:

Reviewed by Adam & Beth.

WebKit side of first cut at engine context menus. Use the client to
call into the UIDelegate.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addCustomContextMenuItems):
  • WebKit.xcodeproj/project.pbxproj:
16:56 Changeset [17795] by beidson

Reviewed by Maciej

Quick change of files to ObjC++ for BF cache re-write

  • History/WebBackForwardList.m: Removed.
  • History/WebBackForwardList.mm: Added.
  • History/WebHistoryItem.m: Removed.
  • History/WebHistoryItem.mm: Added.
  • WebKit.xcodeproj/project.pbxproj:
15:49 Changeset [17794] by adele

Reviewed by Hyatt.

  • Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
  • css/html4.css: Removed "-webkit-user-select: ignore" for labels.
14:34 Changeset [17793] by spadma

2006-11-08 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
http://bugs.webkit.org/show_bug.cgi?id=11605

  • BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
  • BrowserView/inc/BrowserSettingsContainer.h:
  • BrowserView/inc/WebKitControl.h: (CWebKitControl::PluginHandler): (CWebKitControl::AccessPointId): (CWebKitControl::SetAccessPointId):
  • BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
  • Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL): (CPluginSkin::ConstructL):
14:08 Changeset [22551] by adachan

2006-11-15 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Fixed a bad free in DllRegisterServer.

13:44 Changeset [17792] by beidson

Reviewed by Sarge

SPI addition

  • WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
12:09 Changeset [17791] by spadma

2006-11-15 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
http://bugs.webkit.org/show_bug.cgi?id=11602

  • BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):
12:06 Changeset [17790] by spadma

2006-11-15 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
http://bugs.webkit.org/show_bug.cgi?id=11602

  • BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):
12:04 Changeset [17789] by spadma

2006-11-13 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Valid email address cannot be identified on a page when smart text is on. Remove garbage characters from being appended to descriptor prior to calling the FindItemEngine.
http://bugs.webkit.org/show_bug.cgi?id=11589

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL):
  • bridge/WebCoreBridge.h:
11:46 Changeset [17788] by beidson

Reviewed by Adele

<rdar://problem/4838729> - Replace mistakenly removed SPI

  • WebView/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
  • WebView/WebHTMLViewPrivate.h:
11:41 Changeset [17787] by thatcher

Explicitly set GCC 4 for all of our projects, since the system default can be GCC 3.3.

11:35 Changeset [17786] by harrison

Reviewed by Darin.

<rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)

Test:

  • manual-tests/keep_spelling_markers.html: Updated to include checking for this bug.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): it.advance() even when current string is a single space.
11:25 Changeset [22550] by sfalken

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Take another pass at fixing COM registration

  • WebKitDLL.cpp: (substituteGUID):
11:24 Changeset [17785] by beidson

Reviewed by lamadio

Backing out macro expansion

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
  • ksvg2/scripts/make_names.pl:
10:41 Changeset [17784] by harrison

Reviewed by Darin.

<rdar://problem/4770453> VO not honoring secure edit fields in web pages

The remaining problem was the password fields would return their contents
even though they did not advertise that they could. Apparently, VoiceOver
does not read the ads.

  • bridge/mac/WebCoreAXObject.mm: (isPasswordFieldElement): (-[WebCoreAXObject isPasswordField]): (-[WebCoreAXObject textMarkerForVisiblePosition:]): (-[WebCoreAXObject accessibilityAttributeValue:]): (-[WebCoreAXObject doAXStringForRange:]):
10:21 Changeset [22549] by andersca

WebCoreWin:

2006-11-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.


Remove some (now) obsolete methods.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::getAppletInstanceForWidget): (FrameWin::issuePasteCommand): (FrameWin::respondToChangedSelection):

WebKitWin:

2006-11-15 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Add an undo manager to the editor client. Make it possible for applications to invoke undo/redo.

  • Interfaces/IWebView.idl:
  • WebEditorClient.cpp: (WebUndoManager::WebUndoManager): (WebUndoManager::~WebUndoManager): (WebUndoManager::clearCommands): (WebUndoManager::registerCommand): (WebUndoManager::undo): (WebUndoManager::redo): (WebUndoManager::canUndo): (WebUndoManager::canRedo): (WebUndoManager::undoOrRedo): (WebEditorClient::WebEditorClient): (WebEditorUndoCommand::WebEditorUndoCommand): (WebEditorUndoCommand::execute): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
  • WebEditorClient.h:
  • WebView.cpp: (WebView::execCommand):
10:19 Changeset [17783] by lamadio

2006-11-13 Lou Amadio <lamadio@apple.com>

Reviewed by Darin Adler, Maciej Stachowiak

Cleanup: Expanded macros in generated files

  • html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
  • ksvg2/scripts/make_names.pl:
10:01 Changeset [22548] by sfalken

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Fix bug in my last check-in preventing proper COM registration

  • WebKitDLL.cpp: (DllRegisterServer):
09:34 Changeset [17782] by andersca

Reviewed by Geoff.

Use Vector instead of DeprecatedPtrList.


  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
  • editing/BreakBlockquoteCommand.cpp:
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline):
09:24 Changeset [17781] by andersca

Reviewed by Adele.

isTargetItem is used by DRT, so make it private instead of internal.


  • History/WebHistoryItem.m: (-[WebHistoryItem isTargetItem]):
  • History/WebHistoryItemInternal.h:
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
08:51 Changeset [22547] by sfalken

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Remove header from vcproj that no longer exists

  • WebCore.vcproj/WebCore.vcproj:
08:40 Changeset [22546] by sfalken

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Fix the B&I build

  • WebCore.vcproj/WebCore.vcproj:
07:52 Changeset [22545] by sfalken

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Use separate CLSIDs for buildbot builds.


This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).

  • Interfaces/WebKit.idl: Add a second set of CLSIDs for builbot-based builds.
  • WebKit.vcproj/Interfaces.vcproj: Add a preprocessor define BUILDBOT set to 1 for official builds, 0 otherwise (use #if to check).
  • WebKitDLL.cpp: Convert CLSIDs to strings via code instead of copying string literals from elsewhere. (substituteGUID): Added. (DllUnregisterServer): Substitute CLSIDs into reg keys. (DllRegisterServer): Substitute CLSIDs into reg keys.

2006-11-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Use separate CLSIDs for buildbot builds.


This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).

04:21 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
(diff)
04:15 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added some don'ts (diff)
02:12 Changeset [22544] by aroben

It's too early in the morning to be fixing the build.

  • WebEditorClient.cpp: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
02:05 Changeset [22543] by aroben

Build fix.

  • WebEditorClient.cpp: (selectWordBeforeMenuEvent): (isEditable):
  • WebEditorClient.h:
01:45 Changeset [17780] by aroben

Build fix.

  • page/EventHandler.h:
01:29 Changeset [17779] by beidson

Reviewed by Maciej

Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h

  • History/WebBackForwardList.m:
  • History/WebHistory.m:
  • History/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
  • History/WebHistoryItemInternal.h: Added.
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm:
  • WebView/WebView.mm:

11/14/06:

22:57 Changeset [17778] by bdash

2006-11-14 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Tim Hatcher.

Moved the web developer page to the wiki, adding link to the Drosera page.

  • .htaccess: Add permanent redirect to the new page on the wiki.
  • contact.html: Trac numbers are no longer one off.
  • nav.inc:
  • webdevelopers/index.html: Removed.
  • webdevelopers/webkit_version.html: Removed.
  • webdevelopers/webkit_version.js: Removed.
  • webdevelopers/webkit_version_xl.html: Removed.
  • webdevelopers/webkit_version_xl.js: Removed.
22:09 Changeset [17777] by bdakin

WebCore:

Reviewed by Geoff.

Moving things off the bridge and onto clients.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff.

Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • editing/Editor.cpp: (WebCore::Editor::selectWordBeforeMenuEvent): (WebCore::Editor::clientIsEditable):
  • editing/Editor.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:
21:42 Changeset [17776] by thatcher

WebCore:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.

  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
  • page/FrameView.cpp: (WebCore::selectCursor):
  • page/Settings.h: (WebCore::Settings::):

WebKit:

Reviewed by Harrison.

<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)

Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]): (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): (-[WebDefaultUIDelegate openLink:]):
  • English.lproj/Localizable.strings:
  • WebKit.exp:
  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebUIDelegatePrivate.h:
21:28 WebKit Team edited by timothy@apple.com
(diff)
21:17 Changeset [17775] by oliver

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Oliver.

Build fix

  • bindings/scripts/CodeGenerator.pm:
21:06 Changeset [17774] by andersca

WebCore:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Turns out I wasn't forcing DWARF on the world at all,
it's now the default!

  • WebKit.xcodeproj/project.pbxproj:
21:01 Changeset [17773] by andersca

WebCore:

I must stop trying to force DWARF on the world.


  • WebCore.xcodeproj/project.pbxproj:

WebKit:

I must stop trying to force DWARF on the world.

  • WebKit.xcodeproj/project.pbxproj:
19:52 Changeset [17772] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4806874>
Missing background image after paste

Checking in new expected results for fixes:

  • editing/inserting/insert-3851164-fix-expected.checksum:
  • editing/inserting/insert-3851164-fix-expected.png:
  • editing/selection/drag-in-iframe-expected.checksum:
  • editing/selection/drag-in-iframe-expected.png:

Same, but also removing an outdated comment about a bug:

  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/pasteboard/paste-text-019.html:


Added:

  • editing/pasteboard/4806874-expected.checksum: Added.
  • editing/pasteboard/4806874-expected.png: Added.
  • editing/pasteboard/4806874-expected.txt: Added.
  • editing/pasteboard/4806874.html: Added.


Equivalent render trees:

  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4806874>
Missing background image after paste


  • editing/markup.cpp: (WebCore::createMarkup): If the body is fully selected, add a div with its CSS properties to the markup. Migrated a use of enclosingBlockFlowElement to enclosingBlock to fix an infinite loop when pasting <div><input></div>.
19:20 Changeset [17771] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Add Undo/Redo to execCommand.


  • editing/Editor.cpp: (WebCore::execRedo): (WebCore::execUndo): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::):
19:16 WikiStart edited by pewtermoose@gmail.com
forgot a page (diff)
19:15 WikiStart edited by pewtermoose@gmail.com
linking to the pages I added (diff)
19:12 WebDevelopers created by pewtermoose@gmail.com
Web developer oriented resources
19:12 DetectingWebKit created by pewtermoose@gmail.com
Moved this from the website
19:12 Drosera created by pewtermoose@gmail.com
Some rough Drosera documentation
19:00 WebKit Team edited by bdash@webkit.org
(diff)
18:59 WebKit Team edited by bdash@webkit.org
(diff)
18:52 WebKit Team edited by pewtermoose@gmail.com
(diff)
18:45 WebKit Team edited by pewtermoose@gmail.com
Clean up a few cobwebs (diff)
17:40 Changeset [22542] by darin

Fixed reviewer name (Anders).

17:34 Changeset [22541] by darin

WebCoreWin:

Reviewed by NOBODY (OOPS!).

  • update for creation of EventHandler
  • WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.
  • bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp, tabsToLinks, and tabsToAllControls to EventHandler.
  • bridge/win/FrameWin.cpp: Ditto.
  • bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar functions to EventHandler.
  • page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.
  • platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed function in its new home in EventHandler.
  • platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.

WebKitWin:

Reviewed by Anders.

  • update for creation of EventHandler
  • WebView.cpp: (WebView::handleMouseEvent): Call methods now moved to EventHandler. (WebView::mouseWheel): Ditto. (WebView::elementAtPoint): Ditto.
17:29 Changeset [17770] by darin

WebCore:

Reviewed by Anders.

  • created EventHandler class, moved event handling code from both Frame and FrameView in there
  • added ScrollTypes.h header so you can include the scroller-related enums without all of Scrollbar.h
  • page/EventHandler.cpp: Added.
  • page/EventHandler.h: Added.
  • page/mac/EventHandlerMac.mm: Added.
  • platform/ScrollBarMode.h: Removed.
  • platform/ScrollTypes.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::imageFromRect):
  • bridge/mac/FrameViewMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge _visiblePositionForPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
  • dom/Document.cpp: (WebCore::Document::hoveredNodeDetached):
  • dom/Element.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
  • editing/SelectionController.h: (WebCore::SelectionController::setCaretBlinkingSuspended): (WebCore::SelectionController::isCaretBlinkingSuspended):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus):
  • html/HTMLFrameElementBase.h:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::open):
  • page/Frame.cpp: (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::frameForWidget): (WebCore::Frame::eventHandler): (WebCore::Frame::setProhibitsScrolling): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::addRepaintInfo): (WebCore::FrameView::layout): (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::windowClipRectForLayer): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
  • page/FrameView.h:
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
  • page/PageState.h:
  • platform/ScrollBar.h:
  • platform/ScrollView.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/SliderMac.mm: (-[WebCoreSlider becomeFirstResponder]): (-[WebCoreSlider nextKeyView]): (-[WebCoreSlider previousKeyView]): (-[WebCoreSlider canBecomeKeyView]): (Slider::focusPolicy):
  • platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]): (-[WebCoreTextFieldController setHasFocus:]): (-[WebCoreSearchField nextKeyView]): (-[WebCoreSearchField previousKeyView]): (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::hasFocus): (WebCore::Widget::clearFocus):
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::setResizing):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::updateOverflowStatus):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::destroy):
  • rendering/RenderObject.h: (WebCore::RenderObject::RepaintInfo::RepaintInfo):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):

WebKit:

Reviewed by Anders.

  • update for creation of EventHandler
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]): (-[WebHTMLView elementAtPoint:allowShadowContent:]):
17:21 Changeset [17769] by andersca

Fix build for real this time.


  • WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]):
17:07 Changeset [17768] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Try fixing the build.


  • WebCoreSupport/WebEditorClient.mm: (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]):
17:07 Changeset [22540] by andersca

2006-11-14 Anders Carlsson <acarlsson@apple.com>

Build fix.


  • WebEditorClient.cpp: (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
  • WebEditorClient.h:
16:36 Changeset [17767] by andersca

WebCore:

Reviewed by Darin.

Let the editor client handle undo/redo.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/EditorClient.h:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::canUndo): (WebCore::FrameMac::canRedo):
  • bridge/mac/WebCoreEditCommand.h: Removed.
  • bridge/mac/WebCoreEditCommand.mm: Removed.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
  • editing/JSEditor.cpp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::closeURL):
  • page/Frame.cpp:
  • page/Frame.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement):

WebKit:

Reviewed by Darin.

Move undo/redo handling into WebEditorClient.


  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (undoNameForEditAction): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
15:02 Web Inspector edited by pewtermoose@gmail.com
Add how to use with OmniWeb (diff)
14:33 Changeset [17766] by beidson

Reviewed and landed by Brady

Fix Qt/Linux build.

  • ChangeLog:
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::add):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::submitForm):
  • platform/qt/FrameQtClient.h:
13:51 Changeset [17765] by thatcher

Fixing the site.

13:45 Changeset [17764] by sfalken

New tag.

13:44 Changeset [17763] by bdash

2006-11-14 Mark Rowe <bdash@webkit.org>

Reviewed by Tim Hatcher.

http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site

  • blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
  • nav.inc: Generate WordPress archive list if included from within WordPress.
11:56 Changeset [22539] by beidson

Reviewed by Anders

Additional tweek to the FormData change

  • WebFrame.cpp: (WebFrame::loadDataSource):
11:52 Changeset [17762] by beidson

Reviewed by Anders

Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
  • platform/network/ResourceHandle.h:
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest):
11:44 Changeset [22538] by aroben

WebKitWin:

Reviewed by Steve.

Replace all instances of DebugBreak() with ASSERT_NOT_REACHED() so that
it will be compiled out for Release builds.

  • DOMCSSClasses.cpp:
  • DOMCoreClasses.cpp:
  • DOMHTMLClasses.cpp:
  • WebBackForwardList.cpp:
  • WebDataSource.cpp:
  • WebFrame.cpp:
  • WebHTMLRepresentation.cpp:
  • WebHistoryItem.cpp:
  • WebIconDatabase.cpp:
  • WebMutableURLRequest.cpp:
  • WebNotification.cpp:
  • WebPreferences.cpp:
  • WebScriptObject.cpp:
  • WebView.cpp:
10:57 Changeset [17761] by ap

2006-11-14 Rob Buis <buis@kde.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer

Test: fast/css/css-imports.html

  • css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Fix the crash by testing for null pointer.
10:11 Changeset [17760] by ap

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

  1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
  1. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

  • WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
  • WebView/WebHTMLViewInternal.h:
10:06 Changeset [17759] by aroben

2006-11-14 Darin Adler <darin@apple.com>

Reviewed by Adam.

Fix up usages of FormData within CFNet loader code.

  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody):
  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the streamFormDatas HashMap. (WebCore::formCreate): (WebCore::formFinalize): Removed delete because the remove() will deref and delete if necessary. (WebCore::setHTTPBody): Changed parameter to PassRefPtr. (WebCore::httpBodyFromStream):
  • platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::getResourceRequest):
07:39 Changeset [17758] by spadma

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

  • BrowserCore/Renderers/src/TextRendererFactory.cpp:
07:25 Changeset [17757] by spadma

2006-11-10 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569

  • BrowserCore/Renderers/src/TextRendererFactory.cpp:
03:55 Changeset [17756] by bdash

2006-11-14 Greg Jackson <gjspanner@gmail.com>

Reviewed by Darin.

Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.

  • bindings/js/kjs_navigator.cpp:
02:13 BuildingGdk edited by alp@atoker.com
(diff)
02:11 BuildingGdk created by alp@atoker.com

11/13/06:

23:59 Changeset [22537] by beidson

WebCoreWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared

  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):

WebKitWin:

Rubberstamped by Maciej

Windows half of 17755 - Make FormData shared


  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::submitForm):
  • WebFrame.h:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • WebMutableURLRequest.h:
19:54 Changeset [17755] by beidson

Reviewed by Maciej

Made FormData Shared, and pass it around as such.

  • WebCore.xcodeproj/project.pbxproj: Reordered some items
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::submit):
  • html/HTMLFormElement.h:
  • loader/FrameLoader.cpp: (WebCore::FormSubmission::FormSubmission): (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::post): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • platform/network/FormData.h: Made FormData shared
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
  • platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody): (WebCore::ResourceRequest::setHTTPBody):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest): (WebCore::nsURLRequest):
  • platform/network/mac/FormDataStreamMac.h:
  • platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): Hash Streams to RefPtr<FormData>s (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
19:01 Changeset [22536] by andersca

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Make sure to call valueChanged after hiding the popup so that change events will be delivered correctly.
18:45 Changeset [17754] by justing

I accidently checked in old expected results in my previous checkin.

18:37 Changeset [17753] by justing

LayoutTests:

Reviewed by harrison

  • editing/selection/drag-select-1-expected.checksum: Added.
  • editing/selection/drag-select-1-expected.png: Added.
  • editing/selection/drag-select-1-expected.txt: Added.
  • editing/selection/drag-select-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4828264>
In Mail, a crash occurs at WebCore::Selection::toRange() when selecting this web content (http://www.cnet.com/)


The start of the selection is in an editable area, and the end is in an
input field inside that editable area. The code that should pull the end
of such a selection outside the input field didn't escape shadow nodes,
it would leave a dangling end, causing the crash in toRange.


  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Added an ASSERT and a fixup to prevent crashes like this in future Release builds.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): Let this function escape shadow nodes. We might eventually push this code down into next/previous{VisuallyDistinct}Canditate. (WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
18:09 Changeset [22535] by andersca

2006-11-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Adam.

Various editing fixes.


  • WebView.cpp: (WebView::execCommand): Use the focused frame, not the main frame.


(WebView::focusedTarget):
Add FIXME comment.


(WebView::keyDown):
Return false for unknown keydown messages when not in editing mode.

17:27 Changeset [22534] by aroben

Fix line endings.

17:21 Changeset [22533] by sfalken

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.

Fix merge script

  • WebCore.vcproj/merge-opensource.sh: Don't copy cairo, pixman

2006-11-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders, Lou.


Bump version for submit
Copy CharacterSets directory for CF

  • WebKit.vcproj/VERSION: Bump version
  • WebKit.vcproj/WebKit.vcproj: Copy CharacterSets
15:56 Changeset [17752] by justing

Reviewed by darin


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
  • editing/Editor.cpp: (WebCore::Editor::appliedEditing):
  • editing/Editor.h: (WebCore::Editor::setRemovedAnchor): Pass a PassRefPtr.
15:37 Changeset [17751] by justing

LayoutTests:

Reviewed by Oliver

  • editing/pasteboard/paste-unrendered-select-expected.checksum: Added.
  • editing/pasteboard/paste-unrendered-select-expected.png: Added.
  • editing/pasteboard/paste-unrendered-select-expected.txt: Added.
  • editing/pasteboard/paste-unrendered-select.html: Added.

WebCore:

Reviewed by Oliver


<rdar://problem/4820026>
copy/paste of news.google.com yields text from hidden select element options

We were adding descendants of unrendered select elements.

  • editing/markup.cpp: (WebCore::createMarkup): Don't traverse into nodes without renderers, unless they are grandfathered in by a rendered select element.
15:27 Changeset [22532] by ggaren

WebKitWin:

Reviewed by Darin Adler, Anders Carlsson.


More window.open work.


  • Hooked up all of WebChromeClient that the App currently supports.
  • WebChromeClient.cpp: (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
14:59 Changeset [17750] by thatcher

Versioning

14:40 Changeset [17749] by thatcher

New tag.

13:46 Changeset [17748] by thatcher

Explicitly set Dwarf for projects that didn't specify the debugging format.

13:38 Changeset [17747] by thatcher

Switching to Dwarf for Debug and Production. Debuggign will work best with Xcode 2.4.1 or later.

09:42 Changeset [22531] by aroben

Fix line-endings and svn properties.

  • WebChromeClient.cpp:
  • WebChromeClient.h:
09:35 Changeset [22530] by aroben

Build fix.

  • MarshallingHelpers.cpp:
  • WebChromeClient.cpp:
  • WebChromeClient.h:
  • WebEditorClient.h:
  • WebMutableURLRequest.h:

11/12/06:

23:13 Changeset [17746] by beidson

Rubberstamped by Anders

Changed some #includes from <WebKit/foo.h> to "foo.h"

  • History/WebBackForwardList.m:
  • History/WebHistory.m:
18:57 Changeset [22529] by ggaren
  • WebChromeClient.cpp: Fixed up #include.
18:54 Changeset [22528] by ggaren

Reviewed by Steve Falkenberg.

Implemented window.open. Rough around the edges right now.

  • Converted WebMutableURLRequest to use a ResourceRequest as its backing store, to avoid yet another way of representing this data.
  • Changed WebMutableURLRequests's timeoutInterval to double, to match ResourceRequest and NSURLRequest.
  • Added BSTRToKURL and KURLToBSTR helper functions.
  • Added page accessor on WebView, and core(), for converting from WebView to page.
  • MarshallingHelpers.h: Removed unnecessary variable names from declarations.
15:49 Changeset [22527] by ggaren

WebCoreWin:

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

Reviewed by Steven Falkenberg.


Fixed up work-arounds to MSVC warning silliness.


Replaced in-place disabling of "conditional expression is constant" warning
with project-wide setting. (We use do { } while(0); for macro scoping.)


Replaced in-place and project-wide disabling of "xxx was declared deprecated"
warning with project-wide setting only to disable Microsoft's made-up deprecation

warnings related to std
functions.
  • WebChromeClient.cpp: (WebChromeClient::setResizable):
  • WebKit.vcproj/WebKit.vcproj:
  • WebKitDLL.h:
15:44 Changeset [17745] by ggaren

Reviewed by Beth Dakin.


Added project-wide setting to disable Microsoft's made-up deprecation

warnings related to std
functions. (Doesn't have any affect yet, since we currently disable all deprecation warnings.)
08:47 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Added bug number for navigationController issue (diff)
08:45 Writing Layout Tests for DumpRenderTree created by mitz@webkit.org
Copied from Google cache of wiki.opendarwin.org with minimal modifications …
07:18 Changeset [17744] by bdash

2006-11-12 Simon Hausmann <hausmann@kde.org>

Reviewed by Sam Weinig.

Fix Qt build. Missing AbstractShared implementation.
http://bugs.webkit.org/show_bug.cgi?id=11581

  • loader/qt/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::ref): (WebCore::FrameLoaderClientQt::deref):
  • loader/qt/FrameLoaderClientQt.h:
  • platform/qt/ChromeClientQt.cpp: (WebCore::ChromeClientQt::ref): (WebCore::ChromeClientQt::deref):
  • platform/qt/ChromeClientQt.h:
  • platform/qt/EditorClientQt.cpp: (WebCore::EditorClientQt::ref): (WebCore::EditorClientQt::deref):
  • platform/qt/EditorClientQt.h:
04:39 BuildingOnWindows edited by ap@webkit.org
added a few more needed cygwin packages (diff)
04:29 Changeset [17743] by bdash

2006-11-13 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Fix some Linux/Gdk build issues noted by Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::loadPlatformResource):
04:19 BuildingOnWindows created by bdash@webkit.org
Rescue Building on Windows page from the old wiki
01:31 Changeset [17742] by beidson

Reviewed by Anders

Logging channel plumbing for future work

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
00:47 Changeset [17741] by bdash

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk compilation fixes, and bakefile cleanups. Based on patches by
Alp Toker.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/PageState.cpp:
  • platform/gdk/ChromeClientGdk.h: (WebCore::ChromeClientGdk::ref): (WebCore::ChromeClientGdk::deref):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::didReceiveData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::~FrameGdk):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/KeyEventGdk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
  • platform/gdk/ScreenClientGdk.h: Removed.
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::canPaste): (FrameGdk::originalRequestURL): (TextField::TextField):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • webcore-base.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of JavaScriptCore bakefiles.

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-11-12 Mark Rowe <bdash@webkit.org>

Reviewed by Mitz.

Clean up of GdkLauncher bakefile.

  • GdkLauncher/gdklauncher.bkl:
Note: See TracTimeline for information about the timeline view.