Timeline


and

12/03/06:

16:16 Changeset [17994] by bdash
  • 2 edits in trunk/WebCore

2006-12-03 Mark Rowe <bdash@webkit.org>

Reviewed by Alexey.

http://bugs.webkit.org/show_bug.cgi?id=11730
Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.
08:29 Changeset [22607] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-02 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.


<rdar://4853816> CFNetwork crash on Vista loading any SSL page

Change link order so secur32.dll is initialized prior to its
indirect use in code called by CoreGraphics DllMain.


To help avoid similar problems in the future, I reordered the
imported DLLs by level/dependency so things like CoreFoundation
is listed prior to CFNetwork and CoreGraphics.

  • WebKit.vcproj/WebKit.vcproj:
05:36 Changeset [17993] by zimmermann
  • 13 edits
    16 adds in trunk

Reviewed by Oliver.

Fix following bugs:
http://bugs.webkit.org/show_bug.cgi?id=11734
http://bugs.webkit.org/show_bug.cgi?id=11685

SVGPoint/SVGRect/SVGNumber were missing put() support.
SVGPoint.matrixTransform() was missing.

04:19 Changeset [17992] by zimmermann
  • 2 edits
    1 move in trunk/WebCore

Reviewed by Dave.
Another missing piece in the platform/graphics move.

04:02 Changeset [17991] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=11667
SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

Implement getTransformToElement functionality. Introduce virtual
baseclass SVGLocatable to allow one implementation of the functionality.
Finally cleanup some code.

03:55 Changeset [17990] by zimmermann
  • 3 edits
    2 moves in trunk/WebCore

Reviewed by Rob.
Move some files around, which have been forgotton in the platform/graphics move.

03:39 Changeset [17989] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Mitz.
Fix non-svg build. (At least hope BuildBot doesn't moan anymore :-)

01:07 Changeset [17988] by ap
  • 4 edits in trunk/LayoutTests

Reviewed by Mitz.

This test used to be a pixel one, but without pixel results provided - converted to text.

  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added a parameter to send() to make the test work in Firefox.

12/02/06:

06:48 Changeset [17987] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

  • bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code
06:02 Changeset [17986] by ap
  • 3 edits
    4 adds in trunk

2006-12-02 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/dynamic/containing-block-change.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.
05:41 Changeset [17985] by ap
  • 3 edits in trunk/WebCore

2006-12-02 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
  • platform/String.cpp: (WebCore::String::format):

12/01/06:

18:52 Changeset [22606] by bdakin
  • 7 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. Also some
adjustments to make ContextMenuItem class a wrapper for the
platformDescription. (In this case, a wrapper for LPMENUITEMINFO.)

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::insertItem):

WebKitWin:

Reviewed by Adam.

Changes to support sub-menus for WebCore ContextMenus.

  • Interfaces/IWebUIDelegate.idl: New tags.
  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): ContextMenu::menu () is now called parentMenu()
18:35 Changeset [17984] by bdakin
  • 12 edits
    1 add in trunk

WebCore:

Reviewed by Adam.

Support for sub-menus in WebCore context menus. This also re-
architects the ContextMenuItem class so that it is more like
ContextMenu in that the class is now really just a wrapper for the
platformDescription

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Add place-holders for new tags for the sub-menu items. I will flesh these out in a separate check-in.
  • platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate): Call the above functions to add the appropriate sub-menus to editing context menus.
  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::): New tags in the ContextMenuAction enumeration. (WebCore::ContextMenuItem::parentMenu): (WebCore::ContextMenuItem::setType):
  • platform/PlatformMenuDescription.h: Added. This defines PlatformMenuDesciption. It needs to be its own header because we

have to include it from ContextMenu.h and ContextMenuItem.h

  • platform/mac/ContextMenuItemMac.mm: Lots of adjustments here to make this class basically just be a wrapper for NSMenuItem. (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::~ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setSubMenu):
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::getNSMenuItem): Now we only have to get the platformDescription of the ContextMenuItem and then set its target and action. (WebCore::ContextMenu::itemCount):

WebKit:

Reviewed by Adam.

Changes to support sub-menus in WebCore ContextMenus.

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): ContextMenuItem::menu() is now called parentMenu()
  • WebView/WebUIDelegatePrivate.h: New not-yet-API tags.
16:36 Changeset [17983] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by .

  • accidentally checked in with previous checkin
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
16:23 Changeset [17982] by kmccullo
  • 5 edits in trunk/WebCore

Reviewed by Adam.

  • better solution to the ambiguous reference
  • platform/Widget.h: (WebCore::Widget::handleMouseMoveEvent): (WebCore::Widget::handleMouseReleaseEvent):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
  • platform/win/PlatformScrollBar.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent):
15:40 Changeset [17981] by justing
  • 58 edits in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

Removed unnecessary shouldChangeSelection calls;

  • editing/deleting/delete-at-start-or-end-expected.txt:
  • editing/deleting/delete-br-002-expected.txt:
  • editing/deleting/delete-br-004-expected.txt:
  • editing/deleting/delete-br-005-expected.txt:
  • editing/deleting/delete-br-006-expected.txt:
  • editing/deleting/delete-br-009-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-br-012-expected.txt:
  • editing/deleting/delete-hr-expected.txt:
  • editing/deleting/delete-tab-004-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/deleting/merge-into-empty-block-1-expected.txt:
  • editing/deleting/merge-into-empty-block-2-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/inserting/editing-empty-divs-expected.txt:
  • editing/inserting/insert-3800346-fix-expected.txt:
  • editing/inserting/insert-br-004-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:
  • editing/inserting/insert-br-006-expected.txt:
  • editing/inserting/insert-br-008-expected.txt:
  • editing/inserting/insert-div-006-expected.txt:
  • editing/inserting/insert-div-008-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/inserting/insert-div-011-expected.txt:
  • editing/inserting/insert-div-013-expected.txt:
  • editing/inserting/insert-div-015-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-021-expected.txt:
  • editing/inserting/insert-paragraph-01-expected.txt:
  • editing/inserting/insert-paragraph-03-expected.txt:
  • editing/inserting/insert-tab-004-expected.txt:
  • editing/inserting/insert-text-with-newlines-expected.txt:
  • editing/inserting/line-break-expected.txt:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/quirks-mode-br-2-expected.txt:
  • editing/style/apple-style-editable-mix-expected.txt:
  • editing/style/block-style-001-expected.txt:
  • editing/style/block-style-002-expected.txt:
  • editing/style/block-style-003-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • editing/style/table-selection-expected.txt:

WebCore:

Reviewed by john


<rdar://problem/4826940>
Selection change performed even when delete delegate replies NO (11415)

No layout test for the bug fix, because there's no way to register a custom
editing delegate from a layout test. Layout tests are effected by the change
to avoid sending unnecessary shouldChangeSelections, however.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): Don't bother sending shouldChangeSelection if the editing operation didn't change the selection. Still call setSelection though, because it does work in this case that's necessary, like clearing the typing style. (WebCore::Editor::unappliedEditing): Ditto. (WebCore::Editor::reappliedEditing): Ditto.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Don't set the starting selection if the editing delegate returns NO from shouldDeleteRange. Notice we now call setStartingSelection in the case where the current selection was a range selection. This is fine because it's a no-op (the starting selection is already the current selection). (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
15:32 Changeset [17980] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin


Move subrange helper function from spellchecking code to TextIterator

  • editing/TextIterator.h: added TextIterator::subrange
  • editing/TextIterator.cpp: (WebCore::CharacterIterator::advance): early return if count is <= 0; assert that it's not < 0 (WebCore::TextIterator::subrange): new function, moved from FrameMac.mmm
  • bridge/mac/FrameMac.mm: moved subrange() function to TextIterator (WebCore::FrameMac::advanceToNextMisspelling): use TextIterator::subrange (WebCore::markAllMisspellingsInRange): ditto (WebCore::markAllBadGrammarInRange): ditto
14:53 Changeset [17979] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-004 (unchanged from 10.4.7).

14:52 Changeset [17978] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-004 (unchanged from 10.4.7).

14:51 Changeset [17977] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebKit

Tag for WebKit for Security Update 2006-004 (unchanged from 10.4.7).

14:46 Changeset [17976] by darin
  • 31 edits
    1 delete in trunk

WebCore:

Reviewed by Mitz.

I couldn't think of an easy way to make a regression test for this, but maybe
I'll get an idea later about how to do it.

The main thing I did was add a concept of a DOM event having an "underlying event".
That allows the DOM activate event to contain inside it the original keyboard event
that triggered the form submission, and thus allows WebKit to see the modifier keys
from that original event. The code that uses the underlying event is in WebKit, but
the code to set it up is here in WebCore.

  • also do some clean-up to related event handling code
  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::getValueProperty): Updated for the name change of cancelBubble.
  • dom/Event.h: Removed a useless comment. Fixed some whitespace and formatting. Renamed getCancelBubble to cancelBubble to match the DOM -- I suspect the old name predated the use of the m_ prefix on data members. Added the underlying event, and a getter and setter.
  • dom/Event.cpp: (WebCore::Event::setTarget): Updated to take a PassRefPtr. (WebCore::Event::setUnderlyingEvent): Added.
  • dom/EventTargetNode.h: Added an optional underlyingEvent parameter to dispatchUIEvent, one of the overloads of dispatchMouseEvent, and dispatchSimulatedMouseEvent. Added a new dispatchSimulatedClick function here that mostly replaces the click function in HTMLElement.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Updated for the name change of cancelBubble. (WebCore::EventTargetNode::dispatchUIEvent): Added an underlying event parameter, which gets attached to the UIEvent object after it's created. (WebCore::EventTargetNode::dispatchMouseEvent): Tweaked formatting and parameter name for the version that creates a mouse event for a real platform mouse event. Added an underlying event parameter to the main version, and attached it to all three of the events that can be dispatched. (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Added an underlying event parameter, passed it along to dispatchMouseEvent. (WebCore::EventTargetNode::dispatchSimulatedClick): Moved this here from HTMLElement and renamed it from click. Added an underlyingEvent parameter, and passed that along in all three of the calls to dispatchSimulatedMouseEvent.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldClose): Updated call to setTarget that no longer needs a get().
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::sendSVGLoadEventIfPossible): Ditto.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLAnchorElement::accessKeyAction): Ditto.
  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction): Ditto.
  • html/HTMLElement.h: Removed the parameters to click and made it non-virtual. We could move it down to the input and button elements, now that it's just a single function call, but it's also OK to just leave it here.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::click): Removed the parameters and changed this to just call dispatchSimulatedClick. The real work is now in dispatchSimulatedClick. (WebCore::HTMLElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submitClick): Ditto. But unlike accessKeyAction callers, pass the event along as the underlying event.
  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: Removed override of virtual click function. The special cases for the file control and hidden input elements aren't needed. (WebCore::HTMLInputElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick. (WebCore::HTMLInputElement::defaultEventHandler): Converted calls to click to calls to dispatchSimulatedClick, passing along the event as the underlying event.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Converted a call to click to a call to dispatchSimulatedClick, passing the event along as the underlying event. Also changed the local variable for the element to a RefPtr since the code assumes it's still around after calling arbitrary JavaScript code.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction): Converted a call to click to a call to dispatchSimulatedClick.
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::click): Removed unneeded ignored parameter to the click function, and also made it non-virtual.
  • loader/NavigationAction.h: Removed unneeded includes.
  • loader/NavigationAction.cpp: Moved all the code here from NavigationActionMac.mm, since none of it is Mac-specific any more.
  • loader/mac/NavigationActionMac.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for removed file.
  • ksvg2/svg/SVGAElement.cpp: Removed an unnecessary include.
  • loader/FrameLoader.cpp: Added a newly-needed incluude.
  • loader/mac/DocumentLoaderMac.mm: Ditto.
  • loader/mac/FrameLoaderMac.mm: Ditto.
  • rendering/RenderWidget.cpp: Ditto.

WebKit:

Reviewed by Mitz.

  • WebCoreSupport/WebFrameLoaderClient.mm: (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain of events and their underlying events. (findMouseEvent): Added. Same, but specifically for mouse events. (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we use the modifiers from the underlying events rather than just the one from the event itself. So if the event is a DOM activate event, we can still see the modifiers from the original keyboard event that triggered it. Has no effect if the event is already the right type or if there is no underlying event.
  • WebView/WebFrame.mm: Added a newly-needed include.
  • WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.
14:44 Changeset [17975] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-004/WebCore

Tag for WebCore for Security Update 2006-004.

14:43 Changeset [17974] by thatcher
  • 1 add in releases/Apple/Tiger/Security Update 2006-004

New tag for Security Update 2006-004

14:33 Changeset [17973] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebKit

Tag for WebKit for Security Update 2006-007.

14:31 Changeset [17972] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/WebCore

Tag for WebCore for Security Update 2006-007 (unchanged from 10.4.8).

14:30 Changeset [17971] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptGlue

Tag for JavaScriptGlue for Security Update 2006-007 (unchanged from 10.4.8).

14:29 Changeset [17970] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-007/JavaScriptCore

Tag for JavaScriptCore for Security Update 2006-007 (unchanged from 10.4.8).

14:28 Changeset [17969] by thatcher
  • 1 add in releases/Apple/Tiger/Security Update 2006-007

New tag for Security Update 2006-007

14:12 Changeset [17968] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Darin

  • fixed <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient context passed to grammar checker
  • bridge/mac/FrameMac.mm: (WebCore::markAllMisspellingsInRange): new function, extracted from markMisspellings -- ignores grammar (WebCore::markAllBadGrammarInRange): new function, extracted from markMisspellings -- ignores spelling, and operates on appropriately-sized chunks of text (WebCore::FrameMac::markMisspellings): now calls markAllMisspellingsInRange and (optionally) markAllBadGrammarInRange rather than trying to interweave the spelling and grammar logic
13:31 Changeset [17967] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

13:25 Changeset [17966] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin

With these changes, grammar checking works correctly for the one-by-one case.
It still doesn't work correctly for the check-as-you-type case; I need to make these
same kinds of changes in markMisspellings, and refactor to share more code between
the two cases, but I wanted to get this working code in before modifying it further.

The major change here is that advanceToNextMisspelling used to look at small chunks of
text at a time, checking each one for both misspellings and questionable grammar. But
grammar checking needs at least paragraph-sized chunks of text to have enough context
to work correctly, so the old mechanism was causing many spurious complaints of bad
grammar (e.g., almost every word seemed to be at the start of a sentence so the checker
would complain about missing capitalization). So now the spell checker runs in the
specified range first. Then the grammar checker runs on the same range (stopping at the
next misspelling, if any), but expanded to paragraph-aligned boundaries.

  • bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): new function, extracted from advanceToNextMisspelling, and ignores grammar (WebCore::paragraphAlignedRangeForRange): new function, used by findNextBadGrammarInRange (WebCore::findFirstBadGrammarInRange): new function, extracted from advanceToNextMisspelling, and rewritten to use paragraph-aligned chunks, and ignores spelling (WebCore::subrange): new helper function, used by advanceToNextMisspelling (WebCore::FrameMac::advanceToNextMisspelling): now calls out to both findFirstMisspellingInRange and findFirstBadGrammarInRange separately instead of trying to interweave the spelling and grammar logic
13:21 Changeset [17965] by rwlbuis
  • 14 edits in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11732:
Windows build bustage.

13:11 Changeset [17964] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2006-11-30 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun <yongjun.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
http://bugzilla.opendarwin.org/show_bug.cgi?id=11727

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
  • BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):
13:06 Changeset [17963] by yongjzha
  • 4 edits in S60/trunk/WebKit

2006-11-30 yaharon <yael.aharon@nokia.com>

Reviewed by Yongjun <yongju.zhang@nokia.com>
DESC: [S60] JKRL-6VDTV8: browser crash on empty cache data when loading aborted
http://bugs.webkit.org/show_bug.cgi?id=11727

  • BrowserControl/inc/BrCtl.h: (CBrCtl::HttpLoaderEventToUi):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CBrCtl): (CBrCtl::HandleBrowserLoadEventL): (CBrCtl::HandleCommandL): (CBrCtl::UpdateLoadState): (CBrCtl::UnloadDllWmlEngine):
  • BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::ResponseL): (CWmlResourceLoadListener::Complete):
11:08 Changeset [22605] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-01 Steve Falkenburg <sfalken@apple.com>

Fix post-build step.
Need to copy CoreFoundation resources.
Bundles aren't config specific - removed ConfigSuffix from copy commands for resources.

  • WebKit.vcproj\WebKit.vcproj:
10:44 Changeset [17962] by thatcher
  • 4 edits
    1 add in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit

Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.

  • Misc/OldWebAssertions.c: Added. (WebReportAssertionFailure): (WebReportError):
  • WebKit.LP64.exp: added the new symbols, and sorted the file
  • WebKit.exp: added the new symbols, and sorted the file
  • WebKit.xcodeproj/project.pbxproj:
10:34 Changeset [17961] by thatcher
  • 2 edits in trunk/WebKit/Misc

Correcting the copyright date since these are new files.

11/30/06:

23:28 Changeset [22604] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

23:22 Changeset [17960] by sfalken
  • 1 copy in tags/Safari-521.31.4

New tag.

22:35 Changeset [22603] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <sfalken@apple.com>

Fix build.
Link against new WTF.lib

  • WebKit.vcproj/WebKit.vcproj:
21:42 Changeset [17959] by sfalken
  • 4 edits
    2 adds in trunk/JavaScriptCore

2006-11-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.


Move WTF from JavaScriptCore project into a new WTF project.

20:23 Changeset [22602] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
20:15 Changeset [17958] by ggaren
  • 24 edits in trunk

WebCore:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

WebKit:

Rubber Stamped by Anders Carlsson.

Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
suggested a command, and conflicted with a different meaning for 'focusNode'
in the Mozilla selection API.

  • WebView/WebHTMLView.m: (-[NSArray clearFocus]):
18:16 Changeset [17957] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-30 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Tabbed navigation fixes
http://bugs.webkit.org/show_bug.cgi?id=11725

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition): (KWQKHTMLPart::tabbedNavigation):
17:53 Changeset [22601] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

17:47 Changeset [17956] by sfalken
  • 1 copy in tags/Safari-521.31.3

New tag.

16:57 Changeset [22600] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Lather, rinse, repeat.

  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
16:55 Changeset [17955] by sullivan
  • 15 edits in trunk

LayoutTests:

Reviewed by Justin

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: This test's results were broken by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs(), presumably by revealing a different bug. Justin is going to look into this; for now I've updated the result so that it won't appear to fail for others.


  • editing/execCommand/create-list-with-hr-expected.checksum:
  • editing/execCommand/create-list-with-hr-expected.png:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/create-list-with-hr.html: This test's results were improved by using rangeCompliantEquivalent at appropriate places in CompositeEditCommand.cpp::moveParagraphs() -- it used to create an extra <div>, and now it does not.

WebCore:

Reviewed by Justin

With Darin, fixed a problem in the Range constructors found while implementing grammar checking.
That revealed another problem in the layout tests involving bad parameters passed to the Range
constructors.


With these fixes in place, one layout test (editing/execCommand/create-list-from-range-selection.html)
no longer works as intended. This is apparently due to yet another bug being flushed out somewhere.
I'm going to update the results for that test and file a separate radar about it, which Justin will
investigate.

  • dom/Position.h: removed equivalentRangeCompliantPosition(), which was declared but not implemented or called.


  • dom/Range.cpp: (WebCore::Range::Range): Call setStart and setEnd in the two Range constructors that take parameters, rather than just directly setting the instance variables. This makes Range perform the boundary checks and compensations that the DOM spec requires.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Use rangeCompliantEquivalent() on "editing-style" Positions before creating Ranges from them.


  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): Assert that the boundary points of the range are valid.
16:18 Changeset [22599] by aroben
  • 3 edits
    1 delete in branches/WindowsMerge/WebCore

Build fix.

  • platform/graphics/cg/GraphicsContextCG.cpp: Removed. This file was un-forked a while ago.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::platformDescription):
  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
16:14 Changeset [17954] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Mitz.

Bug 10698: Scroll wheel causes inspector to shift up
http://bugs.webkit.org/show_bug.cgi?id=10698

Remove size attribute from the tree popup as a workaround for
http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options

16:11 Changeset [17953] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Tim H.

Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
Bug 6724: Text copied from Web Inspector is different from actual text

16:03 Changeset [17952] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Removing the conflict marker.

15:50 Changeset [17951] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
15:45 Changeset [17950] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by spadma <Sachin.Padma@nokia.com>
DESC: Browser crashes when loading local page with iFrame.
http://bugs.webkit.org/show_bug.cgi?id=11728

  • ResourceLoader/src/HttpStackConfig.cpp: (THttpStackConfig::AddSessionFiltersL): (THttpStackConfig::InstallAuthenticationFilterL): (THttpStackConfig::InstallCookieFilterL): (THttpStackConfig::InstallUaProfFilterL): (THttpStackConfig::InstallConnHandlerFilterL): (THttpStackConfig::InstallIopFilterL):
14:48 Changeset [22598] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter): (WebCore::SVGResourceFilter::createFilterEffect):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
14:29 Changeset [17949] by lamadio
  • 3 edits in trunk/WebCore

2006-11-30 Lou Amadio <lamadio@apple.com>

Reviewed by Dave Hyatt
Cleaned up generated files.

14:07 Changeset [17948] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by Beth.

Store ContextMenu's NSMutableArray inside a RetainPtr so that we
will retain/release it correctly.

  • WebCore.exp:
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Added a FIXME.
  • platform/ContextMenu.h:
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::~ContextMenu): (WebCore::getNSMenuItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformDescription): (WebCore::ContextMenu::platformDescription):

WebKit:

Reviewed by Beth.

Put code in place to use WebCore context menus when they are turned
on.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
13:47 Changeset [17947] by zimmermann
  • 81 edits
    4 copies
    1 delete in trunk/WebCore

Reviewed by Eric. Rubber stamped by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=10383

This is the final patch after the long "die kcanvas" journey.

All old kcanvas code is gone now, and properly integrated within
WebCore (stuff like GraphicsContext changes etc.). It shares
the platform/ design concept: no subclassing, but instead
implementing parts of the classes/methods per-platform.

This commit removes the last pieces: KRenderingDevice & KRenderingDeviceContext.
This layer was just obsolete, given the powerful GraphicsContext API we have
since quite a while now. All the ugly pushContext/popContext stuff is gone now.

The naming issues Cg vs. CG will be fixed in one shot, when moving the whole
platform/graphics/svg directory down into ksvg2/graphics - as discussed with Darin.

13:13 Changeset [22597] by ggaren
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

  • loader/win/FrameLoaderWin.cpp: Removed custom implementation for detachFromParent, since FrameLoader has a cross-platform version now.

WebKitWin:

Reviewed by Beth Dakin.


Fixed <rdar://problem/4844838> Whole document leak seen
running HTML iBench

Copied *very nice* (NOT!) WebKit Mac idiom of calling
FrameLoader::detachFromParent when closing the WebView.
We need to do this so event listeners that retain the document
get destroyed, and so the unload event gets dispatched.

This is pretty silly. Instead, the document/frame/interpreter should
be responsible for cleaning up after itself.


  • WebView.cpp: (WebView::close):
13:10 Changeset [17946] by yongjzha
  • 2 edits in S60/trunk/WebKit
13:06 Changeset [17945] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter): Garbage collect here, since destroying the interpreter frees the global object and therefore creates a lot of garbage.

WebCore:

Reviewed by Beth Dakin.


Fixed up garbage collection at window close time.

  • bindings/js/kjs_proxy.cpp: Don't garbage collect in the KJSProxy destructor, since the global object hasn't been freed yet.
  • bindings/js/kjs_proxy.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::detachFromParent): Made this function cross- platform.
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::setTitle): Moved this function to FrameLoaderMac, since it's Mac-only. (WebCore::FrameLoader::closeBridge):
  • page/Page.cpp: (WebCore::Page::~Page): Don't garbage collect in the Page destructor, since the Interpreter destructor will do it for us.
12:26 Changeset [17944] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: If values are null in setPreferenceForKey remove them from the map.
http://bugs.webkit.org/show_bug.cgi?id=11438

  • BrowserView/src/WidgetPreferences.cpp: (CWidgetPreferences::SetPreferenceL):
12:23 Changeset [17943] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-30 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: 3.1 & 3.2 Memory handling error in CHttpCacheEntry::Internalize(), BrowserCache.dll
http://bugs.webkit.org/show_bug.cgi?id=11724

  • ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::Internalize):
12:16 Changeset [17942] by spadma
  • 8 edits in S60/trunk

2006-11-30 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma.
DESC: Refresh timer in the browser is not cancelled
http://bugs.webkit.org/show_bug.cgi?id=11722

  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::Complete):


12:06 Changeset [22596] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-30 Steve Falkenburg <sfalken@apple.com>

build WebKit.lib to proper directory

  • WebKit.vcproj/WebKit.vcproj:
11:24 Changeset [17941] by spadma
  • 5 edits in S60/trunk/WebKit

2006-11-30 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: [s60] Saved Pages: Some Images not saved with the page.
http://bugs.webkit.org/show_bug.cgi?id=11721

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
11:23 Changeset [17940] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Tim's rubberstamp

Amazingly, DocumentLoader.h survived all this time without a header guard...

  • loader/DocumentLoader.h: Added header guard
10:48 Changeset [22595] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-30 Steve Falkenburg <sfalken@apple.com>

B&I build fix. Add missing header files to vcproj.

  • WebCore.vcproj/WebCore.vcproj:
09:37 Changeset [17939] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Brady and Eric.

XMLHttpRequest fails in a page loaded with WebFrame's loadHTMLString: or loadData:
http://bugs.webkit.org/show_bug.cgi?id=11723

Allow cross-domain XMLHTTPRequest for applewebdata URLs. No automated way to test,
tested in Safari's debug Snippet Editor.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
07:05 Changeset [17938] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC:
http://bugs.webkit.org/show_bug.cgi?id=11716
[S60] some Chinese characters displays as mess code on www.163.com

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::XMLHttpRequest): (KJS::XMLHttpRequest::~XMLHttpRequest): (KJS::XMLHttpRequest::abort): (KJS::XMLHttpRequest::slotData):

11/29/06:

19:44 Changeset [22594] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: Remove unused function.
19:26 Changeset [17937] by andersca
  • 12 edits in trunk/WebCore

Reviewed by Brady.

Get rid of PlatformResponse, the platform specific response object is stored inside of
the ResourceResponse object now. This also gets rid of receivedResponse in ResourceHandleClient.


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getData:andResponse:forURL:]): (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::response):
  • loader/loader.cpp:
  • loader/loader.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveResponse):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::nsURLResponse): (WebCore::ResourceResponse::cfURLResponse):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveResponse):
18:54 Changeset [17936] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message

  • editing/deleting/4845371-expected.checksum: Added.
  • editing/deleting/4845371-expected.png: Added.
  • editing/deleting/4845371-expected.txt: Added.
  • editing/deleting/4845371.html: Added.

WebCore:

Reviewed by sullivan


<rdar://problem/4845371>
In Mail, a crash occurs at WebCore::Node::traverseNextNode() when cutting selected text from a HTML message


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): The start/end were being inflated even when they were the start/end of a partially selected special element.
18:01 Changeset [17935] by bdash
  • 1 edit in trunk/WebKit/WebCoreSupport/WebChromeClient.mm

Build fix: ResourceRequestMac.h was removed in r17911.

17:55 Changeset [17934] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-11-29 shkeller <shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: QPen emulation in KWQ did not handle special
case for pen width zero.
http://bugs.webkit.org/show_bug.cgi?id=11714

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQPainter.cpp:
16:59 Changeset [17933] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

Keep preferences separate from the rest of the client, making sure we are using expected preference values.
This lets the inspector work when plugins are disabled for the WebView.

  • WebInspector/WebInspector.m: (-[NSWindow window]):
16:10 Changeset [22593] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Initialize the status code to 0 for non-http responses.
15:01 Changeset [22592] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Anders.


Minor fix to my recent COM registration/Vista fix.
Ignore errors during registration. Vista locks off more of
HKCU\Software\Classes than I thought.

  • WebKitDLL.cpp:
14:42 Changeset [17932] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix fast/dom/xmlhttprequest-get layout test failure.


  • platform/network/mac/ResourceResponseMac.mm: Initialize the status code to 0 for non-http responses.
14:14 Changeset [17931] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.


Fixed http://bugs.webkit.org/show_bug.cgi?id=11712
REGRESSION: Crash when clicking JS link on crateandbarrel.com (window.open("http[...]"))


This was an accidental commit by Anders.

Chrome can't use the FrameView at window.open time, because it doesn't
exist yet.


  • page/Chrome.cpp: (WebCore::Chrome::pageRect):
13:58 Changeset [17930] by ggaren
  • 10 edits in trunk/WebCore

Reviewed by Mitz Pettel.


Fixed http://bugs.webkit.org/show_bug.cgi?id=11710
REGRESSION (r17906): Crash in WebCore::FrameMac

Added null checks for EditorClient, since it can be NULL when the page
has been destroyed. Removed external access to EditorClient, since it's
an implementation detail of the Editor.

No test case because this crash depends on window tear-down. Layout tests
pass.

11:31 Changeset [17929] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:30 Changeset [17928] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-28 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Zooming not working for auto-complete
http://bugs.webkit.org/show_bug.cgi?id=11702

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):


11:26 Changeset [17927] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
11:24 Changeset [17926] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Can't upload an image to Blogger.com
http://bugs.webkit.org/show_bug.cgi?id=11715

  • BrowserCore/Misc/src/CookieHandler.cpp: (CCookieHandler::AddCookieL):
10:47 Changeset [17925] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Tim.

Add back methods in WebCoreStatistics that are still used by Tiger Safari.


  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.m: (+[WebCoreStatistics emptyCache]): (+[WebCoreStatistics setCacheDisabled:]):
10:38 Changeset [17924] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:38 Changeset [17923] by andersca
  • 2 edits in trunk/WebCore

Fix build.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): Fix tyop.
10:37 Changeset [17922] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-29 spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan.
DESC: WEB browser crashes when attempting to view a local file
http://bugs.webkit.org/show_bug.cgi?id=11711

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::DownloadManagerContentL):
10:35 Changeset [22591] by andersca
  • 5 edits
    2 deletes in branches/WindowsMerge/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse):
  • platform/network/cf/ResourceRequestCFNet.h: Removed.
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.h: Removed.
  • platform/win/MimeTypeRegistryWin.cpp:
10:29 Changeset [17921] by andersca
  • 8 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Darin.

Have ResourceResponse hold on to the platform object and do lazy
initialization of the data members.


  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::loadResourceSynchronously):
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::updatePlatformRequest): (WebCore::ResourceRequest::updateResourceRequest):
  • platform/network/ResourceResponse.cpp: Added. (WebCore::ResourceResponse::url): (WebCore::ResourceResponse::mimeType): (WebCore::ResourceResponse::expectedContentLength): (WebCore::ResourceResponse::textEncodingName): (WebCore::ResourceResponse::suggestedFilename): (WebCore::ResourceResponse::httpStatusCode): (WebCore::ResourceResponse::setHTTPStatusCode): (WebCore::ResourceResponse::httpStatusText): (WebCore::ResourceResponse::setHTTPStatusText): (WebCore::ResourceResponse::httpHeaderField): (WebCore::ResourceResponse::httpHeaderFields): (WebCore::ResourceResponse::setExpirationDate): (WebCore::ResourceResponse::expirationDate): (WebCore::ResourceResponse::setLastModifiedDate): (WebCore::ResourceResponse::lastModifiedDate): (WebCore::ResourceResponse::updateResourceResponse):
  • platform/network/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse): (WebCore::ResourceResponse::isMultipart):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::receivedResponse): (WebCore::ResourceHandle::willSendRequest):
  • platform/network/mac/ResourceResponseMac.h: Removed.
  • platform/network/mac/ResourceResponseMac.mm: (-[NSURLResponse WebCore]):
09:57 Changeset [22590] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adele.

Give archive builds a separate set of CLSIDs so that they may be
installed/run alongside B&I builds and development builds.

  • Interfaces/WebKit.idl:
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKit.vcproj: Don't register WebKit.dll if ARCHIVE_BUILD or BuildBot is defined.
Note: See TracTimeline for information about the timeline view.