Timeline



Dec 6, 2006:

6:47 PM Changeset in webkit [18054] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
6:47 PM Changeset in webkit [22629] by adachan
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

2006-12-06 Ada Chan <​adachan@apple.com>

Reviewed by Maciej.

Fixed a couple of things while investigating <rdar://4866288> (note this doesn't fix the crash yet):

  • we forgot to initialize m_sliderTheme
  • we did the wrong null check when getting the slider theme.
6:46 PM Changeset in webkit [18053] by justing
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • editing/selection/select-line-expected.txt: Added.
  • editing/selection/select-line.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4818134>
Crash in WebCore::selectRange when invoking WebView:insertNewLine in any empty content editable DIV.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RebalanceWhitespaceCommand.*.
  • editing/visible_units.cpp: (WebCore::startOfLine): There are VisiblePositions at offset 0 in blocks without RootInlineBoxes, like empty editable blocks and bordered blocks. (WebCore::endOfLine): Ditto.
6:40 PM Changeset in webkit [18052] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by.

  • Removed a confilct marker
  • ChangeLog:
6:24 PM Changeset in webkit [18051] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
5:01 PM Changeset in webkit [18050] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/deleting/delete-mixed-editable-content-001-expected.txt:
  • editing/inserting/editable-inline-element-expected.checksum: Added.
  • editing/inserting/editable-inline-element-expected.txt: Added.
  • editing/inserting/editable-inline-element-expected.png: Added.
  • editing/inserting/editable-inline-element.html: Added.

WebCore:

Reviewed by john


<rdar://problem/4854869>
Inserting a new line in a contenteditable=true SPAN whose parent is a DIV asserts

  • editing/htmlediting.cpp: (WebCore::enclosingBlock): Use enclosingNodeWithType to prevent escape from editable content.
  • editing/markup.cpp: (WebCore::createMarkup): A null commonAncestorBlock will happen if commonAncestor is inside an inline editable root that doesn't contain any blocks. Removed an early return for this case: the code below the early return can and must handle it.
4:41 PM Changeset in webkit [18049] by beidson
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11675 and <rdar://4857669>
Now we need to explicitly set the data source when loading from a page cache

  • History/WebHistoryItem.mm: (-[WebHistoryItem _scheduleRelease]): Enhanced a logging message (+[WebHistoryItem _releasePageCache:]): Ditto (+[WebHistoryItem _releaseAllPendingPageCaches]): Ditto
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): Reset the View's DataSource from the cache, effectively reopening it
  • WebView/WebHTMLView.m: (-[NSArray setDataSource:]): Properly Handle resetting the DataSource and "reopening" the view
4:22 PM Changeset in webkit [18048] by thatcher
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4843505> Fix cross-library ivar use for 64-bit Objective-C

Adds a new WebCore.LP64.exp file that gets appended to the normal export file.
This new file will have 64-bit only symbols we need to export.

  • WebCore.LP64.exp: Added.
  • WebCore.xcodeproj/project.pbxproj:
4:15 PM Changeset in webkit [22628] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Fix the build.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveData): (WebCore::didFail): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):

WebKitWin:

Fix the build.

  • WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::didFail):
  • WebFrame.h:
4:08 PM Changeset in webkit [18047] by andersca
  • 18 edits in trunk/WebCore

Reviewed by Maciej.


Change SubresourceLoader to use a ResourceHandle, and change ResourceHandle to use a NSURLConnection.


  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail):
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::didReceiveAuthenticationChallenge): (WebCore::SubresourceLoader::didCancelAuthenticationChallenge): (WebCore::SubresourceLoader::willStopBufferingData): (WebCore::SubresourceLoader::willCacheResponse): (WebCore::SubresourceLoader::receivedCredential): (WebCore::SubresourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::SubresourceLoader::receivedCancellation):
  • loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFail):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::didFail):
  • loader/loader.h:
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::resourceData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::setDefersLoading): (WebCore::SubresourceLoader::resourceData): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::didReceiveData): (WebCore::ResourceHandleClient::didFail): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::willStopBufferingData): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation):
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel): (WebCore::ResourceHandle::setDefersLoading): (WebCore::ResourceHandle::delegate): (WebCore::ResourceHandle::releaseDelegate): (WebCore::ResourceHandle::supportsBufferedData): (WebCore::ResourceHandle::bufferedData): (-[WebCoreResourceHandleAsDelegate initWithHandle:]): (-[WebCoreResourceHandleAsDelegate detachHandle]): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFail):
  • xml/xmlhttprequest.h:
2:41 PM Changeset in webkit [22627] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Modify PluginStreamWin to use a SubresourceLoader instead of a ResourceHandle.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::didReceiveResponse): (WebCore::PluginStreamWin::didReceiveData): (WebCore::PluginStreamWin::didFail): (WebCore::PluginStreamWin::didFinishLoading):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::load):
2:33 PM Changeset in webkit [22626] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Build fixes.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::scheduleClose):
1:55 PM Changeset in webkit [18046] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Adam and Oliver

While working on ​http://bugs.webkit.org/show_bug.cgi?id=11675 I
decided to fix much of the null-deref problems that creeped in via
the loader refactoring. This isn't changing behavior, just reintroducing
the free nil checking we used to have with pure ObjC

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Explicitly check for null frames (-[NSArray mouseDown:]): Ditto (-[NSArray mouseDragged:]): Ditto (-[NSArray mouseUp:]): Ditto (-[NSArray performKeyEquivalent:]): Ditto (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto
1:54 PM Changeset in webkit [18045] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Adam.

There are two bugs with WebCore ContextMenus due to the static
ContextMenuItems. One bug is that we often crashed in
NSAutoreleasePool upon quitting the browser. The other bug is that
we were adding static NSMenuItems to multiple NSMenus, which is
disallowed. To fix these bugs, the MenuItems are no longer static.
This is in line with the current design in WebKit anyway. I made
some re-arrangements in the code because I also removed the macro
that was used to create the menu items since it was a bit
confusing.

  • platform/ContextMenu.cpp: (WebCore::createFontSubMenu): (WebCore::createSpellingAndGrammarSubMenu): (WebCore::createSpellingSubMenu): (WebCore::createSpeechSubMenu): (WebCore::createWritingDirectionSubMenu): (WebCore::ContextMenu::populate):
  • platform/ContextMenuItem.h:
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): Use the NSMenuItem global separator item if we have SeparatorType.
  • platform/mac/ContextMenuMac.mm: (WebCore::setMenuItemTarget): Change name of getNSMenuItem since that is no longer accurate. (WebCore::ContextMenu::appendItem): Above name change. (WebCore::ContextMenu::insertItem): Same.
1:46 PM Changeset in webkit [18044] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Geof.

  • Returned the semantic meaning of the mask to be the actual repeat count, and changed auto_repeat to correctly differnetiate between keypressed and keydown.
  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
1:01 PM Changeset in webkit [18043] by justing
  • 10 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • editing/inserting/edited-whitespace-1-expected.checksum: Added.
  • editing/inserting/edited-whitespace-1-expected.png: Added.
  • editing/inserting/edited-whitespace-1-expected.txt: Added.
  • editing/inserting/edited-whitespace-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4753545>
REGRESSION: Edited whitespace sequences are all nbsps (10636)

  • WebCore.xcodeproj/project.pbxproj: Removed RebalanceWhitespaceCommand.* from the project.
  • editing/CompositeEditCommand.cpp: (WebCore::isWhitespace): Moved from htmlediting. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Moved the work that was once done in its own command here. (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Prevents whitespace around a position from collapsing when it's pushed apart during Paste. This function can eventually be deployed to eliminate the need for leading/trailing whitespace handling in InsertParagraphSeparator, InsertLineBreak, Delete, and BreakBlockquote. (WebCore::CompositeEditCommand::rebalanceWhitespace): Cleaned up.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Do rebalanceWhitespaceAt *before* saving the typing style, because whitespace rebalancing is no longer it's own command that claims to preserve the typing style.
  • editing/RebalanceWhitespaceCommand.cpp: Removed.
  • editing/RebalanceWhitespaceCommand.h: Removed.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Moved the code to prepare whitespace arond a position for being pushed aparat to its own method.
  • editing/htmlediting.cpp: (WebCore::stringWithRebalancedWhitespace): Added. Returns a rebalanced string. Takes in whether or not the beginning of that string will be at the start of a paragraph, because a space at such a position must have be nbsp, even if that doesn't follow the nbsp/space pattern used. Similar stuff for the end of a paragraph.
  • editing/htmlediting.h:
  • editing/markup.cpp: (WebCore::fillContainerFromString): Call stringWithRelabacedWhitespace. Pass it the startOfParagraph/endOfParagraph bools.
12:39 PM Changeset in webkit [18042] by rwlbuis
  • 6 edits in trunk/WebKitSite

Reviewed by Brady.

​http://bugs.webkit.org/show_bug.cgi?id=10254
A few grammar and spelling corrections on the WebKit website

Grammar and spelling corrections by Jonathan Johnsson.

12:01 PM Changeset in webkit [22625] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
10:57 AM Changeset in webkit [22624] by sullivan
  • 3 edits in branches/WindowsMerge/WebCore

Try to keep the windows build happy with Frame -> Editor changes...

  • bridge/win/FrameWin.h: removed declarations of spelling and grammar functions
  • platform/win/TemporaryLinkStubs.cpp:
changed spelling and grammar functions from FrameWin
to Editor:: (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::Editor::advanceToNextMisspelling):
10:50 AM Changeset in webkit [18041] by sullivan
  • 14 edits in trunk

WebCore:

Reviewed by Beth

Moved spelling and grammar code from Frame to Editor

  • WebCore.exp: updated for these changes
  • page/Frame.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.h: removed declarations of spelling and grammar functions
  • bridge/mac/FrameMac.mm: moved implementation of spelling and grammar functions from here (WebCore::FrameMac::respondToChangedSelection): updated for moved functions
  • editing/Editor.h: moved declarations of spelling and grammar functions to here
  • editing/mac/EditorMac.mm: moved implementation of spelling and grammar functions to here; changed only to make it compile (e.g. removing "editor()->" and adding "frame()->" where appropraite. (WebCore::findFirstMisspellingInRange): (WebCore::paragraphAlignedRangeForRange): (WebCore::findFirstGrammarDetailInRange): (WebCore::findFirstBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::Editor::isSelectionMisspelled): (WebCore::isRangeUngrammatical): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::core): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::markAllMisspellingsInRange): (WebCore::markAllBadGrammarInRange): (WebCore::Editor::markMisspellings):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): updated for moved functions
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for moved functions

WebKit:

Reviewed by Beth

Updated to match Frame -> Editor changes in WebCore

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): guessesForUngrammaticalSelection() is now in Editor
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): isSelectionUngrammatical() is now in Editor (-[WebHTMLView _isSelectionMisspelled]): isSelectionMisspelled() is now in Editor

(-[WebHTMLView checkSpelling:]):
advanceToNextMisspelling() is now in Editor
(-[WebHTMLView showGuessPanel:]):
ditto

Dec 5, 2006:

7:49 PM Changeset in webkit [22623] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:42 PM Changeset in webkit [18040] by sfalken
  • 1 copy in tags/Safari-521.31.5b

New tag.

6:16 PM Changeset in webkit [22622] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Don't delete the internal pointer anymore since it's an OwnPtr now.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::~ResourceHandle):
6:09 PM Changeset in webkit [18039] by andersca
  • 7 edits in trunk/WebCore

Reviewed by Maciej.

General cleanup, get rid of PlatformResponse (we have ResourceResponse now)
and remove a couple of functions that were unused.

  • loader/CachedResource.h:
  • loader/LoaderFunctions.h:
  • loader/mac/LoaderFunctionsMac.mm:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle):
6:01 PM Changeset in webkit [18038] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by John.

  • keydown is now a keydown event instead of a keypress event. Fixes some form submission odditties.
  • platform/win/KeyEventWin.cpp:
5:20 PM Changeset in webkit [18037] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-12-05 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Fix for tabbed navigation
​http://bugs.webkit.org/show_bug.cgi?id=11757

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
5:11 PM Changeset in webkit [22621] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

Fix the build

  • platform/win/TemporaryLinkStubs.cpp:
4:18 PM Changeset in webkit [18036] by sullivan
  • 2 edits in trunk/WebCore

Tiger build fix

  • editing/mac/EditorMac.mm: declare -[NSSpellChecker learnWord:], on Tiger only (it's API on Leopard)
4:08 PM Changeset in webkit [22620] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
...and add ImageAnimationObserver.h into its new location.

  • WebCore.vcproj/WebCore.vcproj:
4:03 PM Changeset in webkit [22619] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-05 Steve Falkenburg <​sfalken@apple.com>

B&I build fix.
Remove ImageAnimationObserver.h from vcproj.

  • WebCore.vcproj/WebCore.vcproj:
3:56 PM Changeset in webkit [22618] by sullivan
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff Garen

Changes to keep up with Frame -> Editor changes in WebCore

  • bridge/win/FrameWin.h: remove ignoreSpelling() and learnSpelling()
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::ignoreSpelling): moved from FrameWin to Editor (WebCore::Editor::learnSpelling): ditto
3:48 PM Changeset in webkit [18035] by sullivan
  • 7 edits in trunk/WebCore

Reviewed by Geoff Garen

  • page/Frame.h: remove declarations of ignoreSpelling() and learnSpelling()
  • bridge/mac/FrameMac.h: remove declarations of ignoreSpelling() and learnSpelling()
  • bridge/mac/FrameMac.mm: moved implementations of ignoreSpelling() and learnSpelling() from here
  • editing/Editor.h: added declarations of ignoreSpelling() and learnSpelling()
  • editing/mac/EditorMac.mm: (WebCore::Editor::ignoreSpelling): moved here from FrameMac.mm (WebCore::Editor::learnSpelling): ditto
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): updated callers to use frame()->editor() rather than frame()
3:18 PM Changeset in webkit [22617] by sfalken
  • 4 edits
    5 adds in branches/WindowsMerge/WebKitWin

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.

We're using the WebKit extract-localizable-strings script to generate these files,
and will use a cross-platform merged string file when we ship.

3:15 PM Changeset in webkit [18034] by sfalken
  • 2 edits in trunk/WebKitTools

2006-12-04 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Darin.


Make extract-localizable-strings compatible with cpp file extensions.

  • Scripts/extract-localizable-strings:
2:34 PM Changeset in webkit [18033] by sullivan
  • 5 edits in trunk

WebCore:

Reviewed by Adam

New context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Leave out "No Guesses Found" and separator for grammar-checking case.

WebKit:

Reviewed by Adam


Old context-menu mechanism fix for:
<rdar://problem/4864351> Should leave out "No Guesses Found" from context menu for bad grammar

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Leave out "No Guesses Found" and separator for grammar-checking case.
1:50 PM Changeset in webkit [22616] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/CursorWin.cpp: (WebCore::copyCursor):
1:47 PM Changeset in webkit [18032] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11686
WebKit draws Carto.net tabgroup example completely incorrectly (ff does fine)

Make sure the SVG render objects are laid out before measuring their
dimensions using relativeBBox.

1:24 PM Changeset in webkit [18031] by sullivan
  • 5 edits in trunk/WebCore

Reviewed by Darin

Grammar/Spelling code re-homing, baby step one: put isGrammarCheckingEnabled in Editor
since that's where isContinousSpellCheckingEnabled lives.

  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::isGrammarCheckingEnabled): new method, calls through to client a la isContinuousSpellCheckingEnabled
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): call editor() rather than editor()->client() (WebCore::FrameMac::markMisspellings): ditto
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): ditto
1:22 PM Changeset in webkit [22615] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • bridge/win/FrameWin.h: added missing declarations for the functions in John's checkin, below.
1:08 PM Changeset in webkit [18030] by darin
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • a little cleanup
  • html/HTMLInputElement.h: Removed unneeded includes of RenderObject.h and RenderStyle.h.
  • html/HTMLSelectElement.h: Removed unneeded include of RenderStyle.h.
  • ksvg2/svg/SVGStyledElement.h: Removed unneeded include of RenderStyle.h.
  • ksvg2/svg/SVGSVGElement.h: Remove unneeded parameter to createSVGPoint.
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGPoint): Ditto.
  • ksvg2/scripts/generateJSBindings.pl: Removed unused script.
11:58 AM Changeset in webkit [18029] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Layout messed up when changing zoomlevel while typing text in input box
​http://bugs.webkit.org/show_bug.cgi?id=11708

  • BrowserView/src/WebKitView.cpp: (CWebKitView::ZoomL): (CWebKitView::SetCurrentZoomLevelIndex): (CWebKitView::ZoomLevelChanged):
11:50 AM Changeset in webkit [18028] by spadma
  • 2 edits in S60/trunk/WebKit

2006-12-05 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Not able to select placeholder for audio download
​http://bugs.webkit.org/show_bug.cgi?id=11755

  • Plugin/src/PluginSkin.cpp: (CPluginSkin::IsFocusable):
11:49 AM Changeset in webkit [18027] by darin
  • 1 edit
    1 delete in trunk/WebCore
  • doc: Removed empty directory. It's not clear this is a good place for documentation, so lets add it back later if we actually start using it.
11:17 AM Changeset in webkit [18026] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Browser scrollbar is blinking, then disappears in RTL pages for 3.1 version.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11733

  • BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):
11:08 AM Changeset in webkit [18025] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-04 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: Don't move to the scroll bar rect to right if the page is RTL
​http://bugs.webkit.org/show_bug.cgi?id=11733

  • WebKit/BrowserCore/ScrollBars/src/ScrollBarFrame.cpp: (CScrollBarFrame::SetScrollBar):
11:03 AM Changeset in webkit [18024] by andersca
  • 3 edits in trunk/WebCore

Reviewed by Brady, Darin.

  • loader/loader.cpp: (WebCore::Loader::receivedAllData): Remove ref() call that was left around by mistake.
11:01 AM Changeset in webkit [18023] by sullivan
  • 3 edits in trunk/WebKit

build fix

  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): define isGrammarCheckingEnabled whether on Tiger or not (just return NO on Tiger)
10:43 AM Changeset in webkit [22614] by sullivan
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::isSelectionUngrammatical): (WebCore::FrameWin::guessesForUngrammaticalSelection): added stubs to correspond to new Frame functions
10:40 AM Changeset in webkit [18022] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11758
Don't compile custom SVG and XSLT bindings in non-svg build

  • bindings/js/JSSVGNumber.cpp:
  • bindings/js/JSSVGNumber.h:
  • bindings/js/JSSVGPoint.cpp:
  • bindings/js/JSSVGPoint.h:
  • bindings/js/JSSVGRect.cpp:
  • bindings/js/JSSVGRect.h:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
10:36 AM Changeset in webkit [18021] by sullivan
  • 14 edits in trunk

WebCore:

Reviewed by Darin

WebCore part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Also, some of this code
should move from Frame to Editor, but that will wait for another checkin.

  • page/Frame.h: added pure virtual function declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
  • bridge/mac/FrameMac.h: added virtual functions declarations for isSelectionUngrammatical() and guessesForUngrammaticalSelection()
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isSelectionMisspelled): now updates spelling panel (whether or not it's showing), since this is now needed to make -[NSSSpellChecker ignoreWord:inSpellDocumentWithTag:] work correctly (WebCore::isRangeUngrammatical): new function, helper used by both isSelectionUngrammatical() and guessesForUngrammaticalSelection() (WebCore::FrameMac::isSelectionUngrammatical): new function, calls isRangeUngrammatical (WebCore::FrameMac::guessesForUngrammaticalSelection): ditto
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): now considers bad grammar as well as misspellings


  • platform/ContextMenuItem.h: added ContextMenuItemTagIgnoreGrammar

WebKit:

Reviewed by Darin

WebKit part of fix for:
<rdar://problem/4817188> Context menu for bad grammar should include suggestions and "Ignore Grammar"

The context menu mechanism is currently in flux; the old mechanism is still in place, but an
up-and-coming new mechanism is waiting in the wings. I updated both of them, but couldn't
test the new mechanism because it doesn't work well enough yet. Most of this WebKit code
can be deleted when the new mechanism is in place.

  • WebView/WebUIDelegatePrivate.h: added WebMenuItemTagIgnoreGrammar
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): added case for WebMenuItemTagIgnoreGrammar (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): now considers adding grammar-related items as well as spelling-related items


  • WebView/WebHTMLViewPrivate.h: declared _isSelectionUngrammatical
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionUngrammatical]): new method, calls through to WebCore (-[WebHTMLView _ignoreGrammarFromMenu:]): new method, calls _ignoreSpellingFromMenu: since NSSpellChecker has one method for both
  • English.lproj/Localizable.strings: updated for "Ignore Grammar" menu item title
4:31 AM Changeset in webkit [18020] by ap
  • 3 edits in trunk/WebCore

2006-12-05 Kirby White <​KWhiteRight@gmail.com>

Reviewed, tweaked and landed by Alexey.

<​http://bugs.webkit.org/show_bug.cgi?id=11639> Form buttons don't look different when clicked

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): Moved test for active state before test for hover state, since active should override hover when both are true.
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): Same fix.
2:23 AM Changeset in webkit [18019] by ap
  • 3 edits
    3 adds in trunk

2006-12-05 Kirby White <​KWhiteRight@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11681
Don't select the first option when resetting a listbox-style form
control (i.e., a multi-select control or one with size > 1) that
has no default selection.

Test: fast/dom/HTMLSelectElement/listbox-select-reset.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
12:51 AM Changeset in webkit [18018] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Rob.

Make this test pass on PowerPC, too (the calculation was giving 4.7e-16 instead of zero,
now rounding it to 15 digits).

  • svg/custom/getTransformToElement.svg:
12:26 AM Changeset in webkit [18017] by ap
  • 9 edits
    1 add in trunk/WebCore

2006-12-05 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11752
[CSS 3] missing support for cursor selector 'copy'

  • Resources/copyCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::copyCursor):
  • rendering/RenderStyle.h: (WebCore::):

Dec 4, 2006:

10:50 PM Changeset in webkit [18016] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix from last check-in. This line was badbad.

  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::~ContextMenu):
10:33 PM Changeset in webkit [18015] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

With the new changes to ContextMenuItems, WebCore context menus
stopped appearing at all. And then when I got them to appear, they
crashed. This fixes both of these problems.

  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::ContextMenuItem): keyEquivalent cannot be nil. This was causing Obj-C to throw an exception preventing the menus from popping up at all.
  • platform/mac/ContextMenuMac.mm: (+[WebCoreMenuTarget sharedMenuTarget]): Re-name our static MenuTarget so that it is more clear that it is a static and shared WebCoreMenuTarget. (WebCore::ContextMenu::ContextMenu): Initialize the WebCoreMenuTarget's controller in the ContextMenu constructor instead of in getNSMenuItem since the controller will only possibly change when a new ContextMenu has been created. (WebCore::ContextMenu::~ContextMenu): Set the target's controller to 0. (WebCore::getNSMenuItem): A lot of this work is being done other places now. Call new class method on WebCoreMenuTarget to get the shared target. (WebCore::ContextMenu::appendItem): We should not be releasing the menuItem here! This caused the crashes I saw. (WebCore::ContextMenu::insertItem): Same.
7:37 PM Changeset in webkit [18014] by andersca
  • 2 edits in trunk/WebCore

Fix the build.


  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::~SubresourceLoader): Add back the destructor.
7:17 PM Changeset in webkit [22613] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore.vcproj: Add SubresourceClient.h


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveResponse): Get rid of the receivedResponse call.


(WebCore::didFinishLoading):
Get rid of the receivedAllData call, that's handled by the subresource loader now.

7:07 PM Changeset in webkit [18013] by andersca
  • 17 edits
    1 add in trunk/WebCore

Reviewed by Darin.


Change all ResourceHandleClients to be SubresourceLoaderClients instead. Also,
make SubresourceLoader a ResourceHandleClient. This is a first step towards turning ResourceHandle into a
standalone class which doesn't need to know about SubresourceLoader.

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::setDefersLoading):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFailWithError): (WebCore::SubresourceLoader::receivedAllData):
  • loader/SubresourceLoader.h: (WebCore::SubresourceLoader::loaderAsResourceHandleClient): (WebCore::SubresourceLoader::handle):
  • loader/SubresourceLoaderClient.h: Added. (WebCore::SubresourceLoaderClient::~SubresourceLoaderClient): (WebCore::SubresourceLoaderClient::willSendRequest): (WebCore::SubresourceLoaderClient::didReceiveResponse): (WebCore::SubresourceLoaderClient::didReceiveData): (WebCore::SubresourceLoaderClient::didFinishLoading): (WebCore::SubresourceLoaderClient::didFailWithError): (WebCore::SubresourceLoaderClient::receivedAllData):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFailWithError): (WebCore::IconLoader::didFinishLoading): (WebCore::IconLoader::clearLoadingState):
  • loader/icon/IconLoader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::didFailWithError): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData): (WebCore::Loader::cancelRequests):
  • loader/loader.h:
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleClient.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::loader):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::didFailWithError): (WebCore::XMLHttpRequest::didFinishLoading): (WebCore::XMLHttpRequest::willSendRequest): (WebCore::XMLHttpRequest::didReceiveResponse): (WebCore::XMLHttpRequest::didReceiveData):
  • xml/xmlhttprequest.h:
5:36 PM Changeset in webkit [22612] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • WebCore.vcproj/WebCore.vcproj: Update for new UIEventWithKeyState.cpp file.
5:29 PM Changeset in webkit [18012] by darin
  • 12 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test the part of ​http://bugs.webkit.org/show_bug.cgi?id=11628 REGRESSION (r17597): Command-return in text fields doesn't open a new tab or window that can easily be tested from the DOM -- this only checks that simulated mouse events from clicking on a link have the key state from the Enter key keyboard event, which is one part of the fix for the bug above
  • fast/events/simulated-key-state-expected.txt: Added.
  • fast/events/simulated-key-state.html: Added.

WebCore:

Reviewed by Adele.

This fixes command-return when the focus is on a link.
Despite the title of the bug, Mitz wanted me to fix both, and I will not
say no to him!

Test: fast/events/simulated-key-state.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSimulatedMouseEvent): Instead of always passing false for all the key state in simulated mouse events, pass the state from the first underlying event in the chain that has key state; in the case in the bug, the keyboard event will be the underlying event itself and we'll propagate the alt key modifier to the mouse event, resulting in the effect we want. It's nice that JavaScript also gets to see the proper modifiers in the mouse event.
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Added code to pass in an underlying event to dispatchSimulatedClick. After looking at all the other callers, this seems to be the only one that needs to pass an event that is currently passing 0. Also removed the code that only simulated a click when the event has a PlatformKeyboardEvent -- no reason for that and it prevented me from writing a layout test for the fix.
  • dom/UIEventWithKeyState.h: Added findEventWithKeyState function that walks the underlyingEvent chain to find the first event that has key state. This already existed in WebKit, but I wanted to use it in dispatchSimulatedMouseEvent.
  • dom/UIEventWithKeyState.cpp: Added.
  • CMakeLists.txt: Added UIEventWithKeyState.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added UIEventWithKeyState.cpp.
  • WebCore.xcodeproj/project.pbxproj: Added UIEventWithKeyState.cpp.
  • WebCoreSources.bkl: Added UIEventWithKeyState.cpp.
  • WebCore.exp: Added findEventWithKeyState, used by WebKit.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Changed to use the new findEventWithKeyState function in WebCore instead of a local function in this file.
4:49 PM Changeset in webkit [18011] by kmccullo
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
  • config.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError):
  • loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
  • page/Frame.cpp: (WebCore::Frame::setView):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::mouseDown):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):
4:38 PM Changeset in webkit [22611] by kmccullo
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
  • config.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
4:37 PM Changeset in webkit [18010] by ggaren
  • 2 edits in trunk/WebKit

Rolled out the WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
part of my last checkin.


We have to turn on support for backward compatibility mode to avoid Dashboard
regressions in the short term.

  • WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]):
3:54 PM Changeset in webkit [18009] by ggaren
  • 15 edits in trunk

LayoutTests:

Reviewed by Darin Adler.


Removed Dashboard quirk from expected results. Now that we have a Dashboard
quirks mode, there's no reason to keep the old, bad behavior in the browser.

  • http/tests/xmlhttprequest/exceptions-expected.txt:
  • http/tests/xmlhttprequest/exceptions.html:

WebCore:

Reviewed by Darin Adler.


Added support for Dashboard backward compatibility mode.


  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::stroke): Added support for old behavior of automatically clearing the stroke path buffer after a call to stroke().
  • html/HTMLCanvasElement.cpp: Added supoprt for old behavior of the canvas tag being self-closing. (WebCore::HTMLCanvasElement::endTagRequirement): (WebCore::HTMLCanvasElement::tagPriority):
  • html/HTMLCanvasElement.h:
  • html/HTMLParser.cpp: Ditto. (WebCore::HTMLParser::canvasCreateErrorCheck):
  • xml/xmlhttprequest.cpp: Added support for old behavior of silently ignoring a call to setRequestHeader() if it preceded a call to open() or followed a call to send(). (WebCore::XMLHttpRequest::setRequestHeader):

WebKit:

Reviewed by Darin Adler.


Added SPI for enabling Dashboard backward compatibility mode. For now,
we enable it unconditionally for Dashboard and Dashcode. Once they
implement specific support for the backward compatibility mode behavior,
we can change that.


Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
to YES in order to turn this code on.

  • WebView/WebView.mm: (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]):
  • WebView/WebViewPrivate.h:
3:52 PM Changeset in webkit [22610] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::generalPasteboard): Got rid of s_generalPasteboard. Also removed definition of destructor.
3:43 PM Changeset in webkit [18008] by darin
  • 11 edits in trunk

WebCore:

Reviewed by Alice.

  • bridge/EditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function. Alice will probably change this so it's not on the editor client any more later.
  • editing/Editor.h: Removed "_web_" prefix from C++ userVisibleString member function.
  • editing/Editor.cpp: Tweaked formatting a bit. Removed Mac-specific code from this file.
  • editing/mac/EditorMac.mm: (WebCore::Editor::newGeneralClipboard): Removed unnneded local variable. (WebCore::Editor::userVisibleString): Moved this function here.
  • platform/Pasteboard.h: Added some FIXMEs. Removed unneeded includes. Made Pasteboard noncopyable. Removed use of "protected" where we should be using "private". Removed s_generalPasteboard.
  • platform/mac/PasteboardMac.mm: Added some FIXMEs. Removed the s_generalPasteboard global. Removed the unused destructor. Updated call to userVisibleString for name change. Tweaked formatting.

WebKit:

Reviewed by Alice.

  • WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from C++ userVisibleString member function.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString): Ditto.
  • WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.
3:34 PM Changeset in webkit [22609] by andersca
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin, Geoff.

Get rid of ref() in ResourceHandle::start() and remove all uses of kill().


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::ResourceHandle::start):
  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::stop):

WebKitWin:

Reviewed by Darin, Geoff.

Don't use ResourceHandle::kill().

  • WebFrame.cpp: (WebFrame::stopMainResourceLoad):
3:31 PM Changeset in webkit [22608] by aliceli1
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag. The part of that
function after the drag hysteresis is exceeded remains unimplemented until
drag&drop is implemented.

  • page/win/EventHandlerWin.cpp: (WebCore::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):

WebKitWin:

Reviewed by Oliver.

Fixed <rdar://problem/4822632> clicks don't work if you move mouse immediately
This bug was fixed by implementing EventHandler::handleDrag.

  • WebView.cpp: (WebView::WebView): Added a data member (WebView::handleMouseEvent): Create the mouse event telling it it activated the webview (WebViewWndProc): Call setMouseActivated upon receiving the relevent message
  • WebView.h: (WebView::setMouseActivated): Added this function so that the webview knows if it was brought to the foreground by a mouse event
3:30 PM Changeset in webkit [18007] by aliceli1
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Moved some constants from EventHandlerMac.mm to EventHandler.cpp
Added some platform-specific data members and functions.

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:
  • platform/PlatformMouseEvent.h: (WebCore::): (WebCore::PlatformMouseEvent::timestamp): (WebCore::PlatformMouseEvent::activatedWebView): (WebCore::PlatformMouseEvent::type):
3:26 PM Changeset in webkit [18006] by andersca
  • 8 edits in trunk/WebCore

Reviewed by Darin, Geoff.

Get rid of ResourceHandle::kill(), all it did was to balance out a ref() in ResourceHandle::start().
We use RefPtrs to ResourceHandle instead.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::~IconLoader): (WebCore::IconLoader::stopLoading): (WebCore::IconLoader::didReceiveResponse):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandle.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::finishJobAndHandle): (WebCore::ResourceHandle::reportError):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::didFinishLoading):
3:14 PM Changeset in webkit [18005] by bdash
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix: set private attribute on ImageAnimationObserver.h so it is copied into the framework.

2:32 PM Changeset in webkit [18004] by oliver
  • 2 edits in trunk/WebCore

2006-12-04 Oliver Hunt <​oliver@apple.com>

Build fix for non-SVG builds

  • bindings/js/JSSVGPoint.cpp: (WebCore::JSSVGPointProtoFunc::callAsFunction):
2:31 PM Changeset in webkit [18003] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-28 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: [S60] browser fails to run the script when the page saved
​http://bugs.webkit.org/show_bug.cgi?id=11706

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::LoadSavedPageL):
2:00 PM Changeset in webkit [18002] by yongjzha
  • 7 edits in S60/trunk/WebKit

2006-12-04 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>.
DESC: [S60] PNIO-6TCGX3: document.referrer doesn't seem to have any value
​http://bugs.webkit.org/show_bug.cgi?id=11735

  • BrowserView/inc/WebKitLoader.h: (CWebKitLoader::ReferrerUrl):
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::LoadPageL): (CWebKitLoader::SetPageUrlL): (CWebKitLoader::SetReferrerUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::IncomingReferrer):
  • ChangeLog:
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::RefererUrl):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::ConstructL): (CUrlRequestInfo::SetRefererUrlL):
1:29 PM Changeset in webkit [18001] by darin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

No test case added at the moment, but Beth said she'd investigate
adding one after the fact.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMousePressEventToScrollbar): Fix obvious-in-retrospect copy and paste error -- call passMouseDownEventToWidget instead of passWheelEventToWidget.
11:37 AM Changeset in webkit [18000] by ap
  • 12 edits
    5 adds in trunk

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11738:
Make link clicking work again on Windows.

WebCore:

This re-implements a few functions that used to be part of FrameWin in
their new loader-based locations, and copies a few things from the Mac
and Qt event handling code that aren't strictly necessary but are
pretty simple.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/EditorClientWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::client):
  • bridge/win/FrameWin.h:
  • loader/win/DocumentLoaderWin.cpp: Added. (WebCore::DocumentLoader::setTitle):
  • loader/win/FrameLoaderClientWin.cpp: Added. (WebCore::FrameLoaderClientWin::userAgent):
  • loader/win/FrameLoaderClientWin.h:
  • loader/win/FrameLoaderWin.cpp: Added. (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::setTitle):
  • page/win/EventHandlerWin.cpp: Added. (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passSubframeEventToSubframe): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::passWheelEventToWidget): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoaderClientWin::setTitle):

WebKit:

The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
hasn't actually moved, which were preventing clicks from actually
getting dispatched in many cases. It's a peculiarity of Windows mouse
handling that we receive these at all.

  • COM/WebView.cpp: (WebView::WebView): (WebView::mouseMoved):
  • COM/WebView.h:
10:49 AM Changeset in webkit [17999] by ap
  • 4 edits in trunk/WebCore

2006-12-04 Don Gibson <​dgibson77@gmail.com>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11748:
Windows build bustage.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/ContextMenuItem.h:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformDescription): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
10:24 AM Changeset in webkit [17998] by sullivan
  • 2 edits
    1 move
    1 add in trunk/WebCore

Reviewed by Anders

Moved EditorMac.mm to its appropriate location

  • platform/mac/EditorMac.mm: Removed.
  • editing/mac/EditorMac.mm: Added
  • WebCore.xcodeproj/project.pbxproj: updated for this change
9:07 AM Changeset in webkit [17997] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Anders

  • fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" menu items not displayed in the contextual menu
  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always returning NO. D'oh!
7:14 AM Changeset in webkit [17996] by yongjzha
  • 6 edits in S60/trunk/WebKit

2006-12-01 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: [S60] Add platform scrollbars support, behind feature flag
​http://bugs.webkit.org/show_bug.cgi?id=11736

  • BrowserControl/inc/BrCtl.h: (MBrHistoryInterface::~MBrHistoryInterface): (NONSHARABLE_CLASS): (CBrCtl::WmlEngineInterface):
  • BrowserControl/inc/BrCtlScrollingProvider.h: (NONSHARABLE_CLASS):
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl): (CBrCtl::DrawScrollbarBackground): (CBrCtl::MopSupplyObject): (CBrCtl::Draw): (CBrCtl::HandleResourceChange):
  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::NewL): (CBrCtlScrollingProvider::ConstructL): (CBrCtlScrollingProvider::~CBrCtlScrollingProvider): (CBrCtlScrollingProvider::UpdateVScrollBarL): (CBrCtlScrollingProvider::UpdateHScrollBarL): (CBrCtlScrollingProvider::NotifyLayoutChange): (CBrCtlScrollingProvider::VScrollBarWidth): (CBrCtlScrollingProvider::HScrollBarHeight): (CBrCtlScrollingProvider::VScrollBar): (CBrCtlScrollingProvider::HScrollBar): (CBrCtlScrollingProvider::ScrollBarCornerWindow): (CBrCtlScrollingProvider::SetScrollDisplayRect): (CBrCtlScrollingProvider::ResizeBrCtlView): (CBrCtlScrollingProvider::ShiftBrCtlView): (CBrCtlScrollingProvider::HandleScrollEventL): (CBrCtlScrollingProvider::SkinChangedL): (CBrCtlScrollingProvider::DrawBackground):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
  • ChangeLog:
1:21 AM Changeset in webkit [17995] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by dhyatt.

Patch by pmax.

​http://bugs.webkit.org/show_bug.cgi?id=3280
With LEGEND element, align=right value is not supported
​http://bugs.webkit.org/show_bug.cgi?id=11544
<legend> rendering doesn't take align into account

Allow aligning for legends in both RTL and LTR mode.

Dec 3, 2006:

4:16 PM Changeset in webkit [17994] by bdash
  • 2 edits in trunk/WebCore

2006-12-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11730
Bug 11730: Meta HTTP Refresh that contains a fraction / decimal get ignored.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Parse the refresh interval as a double rather than an integer.
8:29 AM Changeset in webkit [22607] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-12-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Ada.


<rdar://4853816> CFNetwork crash on Vista loading any SSL page

Change link order so secur32.dll is initialized prior to its
indirect use in code called by CoreGraphics DllMain.


To help avoid similar problems in the future, I reordered the
imported DLLs by level/dependency so things like CoreFoundation
is listed prior to CFNetwork and CoreGraphics.

  • WebKit.vcproj/WebKit.vcproj:
5:36 AM Changeset in webkit [17993] by zimmermann
  • 13 edits
    16 adds in trunk

Reviewed by Oliver.

Fix following bugs:
​http://bugs.webkit.org/show_bug.cgi?id=11734
​http://bugs.webkit.org/show_bug.cgi?id=11685

SVGPoint/SVGRect/SVGNumber were missing put() support.
SVGPoint.matrixTransform() was missing.

4:19 AM Changeset in webkit [17992] by zimmermann
  • 2 edits
    1 move in trunk/WebCore

Reviewed by Dave.
Another missing piece in the platform/graphics move.

4:02 AM Changeset in webkit [17991] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11667
SVG: method .getTransformToElement(elt) in SVGLocatable not implemented

Implement getTransformToElement functionality. Introduce virtual
baseclass SVGLocatable to allow one implementation of the functionality.
Finally cleanup some code.

3:55 AM Changeset in webkit [17990] by zimmermann
  • 3 edits
    2 moves in trunk/WebCore

Reviewed by Rob.
Move some files around, which have been forgotton in the platform/graphics move.

3:39 AM Changeset in webkit [17989] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Mitz.
Fix non-svg build. (At least hope BuildBot doesn't moan anymore :-)

1:07 AM Changeset in webkit [17988] by ap
  • 4 edits in trunk/LayoutTests

Reviewed by Mitz.

This test used to be a pixel one, but without pixel results provided - converted to text.

  • http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
  • http/tests/xmlhttprequest/frame-load-cancelled-abort.html:
  • http/tests/xmlhttprequest/resources/frame-load-to-cancel.html: Added a parameter to send() to make the test work in Firefox.

Dec 2, 2006:

6:48 AM Changeset in webkit [17987] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick

Removed a couple of big chunks of duplicated code from the spelling and grammar stuff by merging
the find-next-instance functions with the mark-all-instances functions.

  • bridge/mac/FrameMac.mm: (WebCore::findFirstMisspellingInRange): added markAll parameter, and reworked loop so that if markAll parameter is true, this function loops through the entire range and marks each misspelling (WebCore::findFirstGrammarDetailInRange): extracted from findFirstBadGrammarInRange; loops through the potentially-multiple details in a given ungrammatical phrase (e.g., multiple grammar errors in one sentence). Has a markAll parameter akin to the one in findFirstMisspellingInRange. (WebCore::findFirstBadGrammarInRange): added markAll parameter like the one in findFirstMisspellingInRange, and extracted findFirstGrammarDetailInRange (WebCore::FrameMac::advanceToNextMisspelling): pass "false" for new markAll parameters (WebCore::markAllMisspellingsInRange): now just calls findFirstMisspellingInRange with markAll = true, thus removing a big hunk of duplicated code (WebCore::markAllBadGrammarInRange): now just calls findFirstBadGrammarInRange with markAll = true, thus removing a big hunk of duplicated code
6:02 AM Changeset in webkit [17986] by ap
  • 3 edits
    4 adds in trunk

2006-12-02 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/dynamic/containing-block-change.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Changed the logic used to find absolutely positioned descendant's current containing block to match the changes made to containingBlock() in the fix for bug 9347.
5:41 AM Changeset in webkit [17985] by ap
  • 3 edits in trunk/WebCore

2006-12-02 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11709
DeprecatedString::format is broken on Windows

Use _vscprintf on Windows to compute the length of the buffer that
vsnprintf would need.

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::format):
  • platform/String.cpp: (WebCore::String::format):
Note: See TracTimeline for information about the timeline view.