23:59 Changeset [18172] by ap

Reviewed by Darin.

XMLHttpRequest should be an EventTarget

Test: http/tests/xmlhttprequest/event-target.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  • xml/xmlhttprequest.h: (WebCore::XMLHttpRequest::eventListeners): Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).
23:28 Changeset [22652] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added missing files to project.
23:13 Changeset [22651] by sfalken

B&I build fix

23:13 Changeset [18171] by darin

Reviewed by Geoff.

DocumentType objects were getting filed under the wrong document in the
DOM objects structure.

  • bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
  • bindings/js/kjs_binding.cpp: (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging. (KJS::addWrapper): Added. (KJS::removeWrapper): Added. (KJS::removeWrappers): Added. (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference to this wrapper since it's being destroyed. (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS. (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions we're calling. Another solution would be to reorder the two, but I think that would create a race where another thread could garbage collect after the forget but before the put. (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.
  • dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
  • dom/Node.cpp: (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here. (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
22:47 Changeset [18170] by ap

Add support for window.atob() and window.btoa()

Reviewed by Darin.



  • WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • platform/Base64.cpp: Added. (base64Encode): (base64Decode):
  • platform/Base64.h: Added.
  • ForwardingHeaders/wtf/StringExtras.h: Added.
  • platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.


  • fast/dom/Window/atob-btoa-expected.txt: Added.
  • fast/dom/Window/atob-btoa.html: Added.
  • fast/dom/Window/btoa-pnglet-expected.checksum: Added.
  • fast/dom/Window/btoa-pnglet-expected.png: Added.
  • fast/dom/Window/btoa-pnglet-expected.txt: Added.
  • fast/dom/Window/btoa-pnglet.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
22:34 Changeset [22650] by sfalken

2006-12-11 Steve Falkenburg <sfalken@apple.com>

B&I build fix.
Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.

  • WebCore.vcproj/WebCore.vcproj:
21:56 Changeset [18169] by darin


Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCore.xcodeproj/project.pbxproj: Updated project for file moves.
  • bridge/mac/FrameMac.h: Moved to page/mac.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • bridge/mac/WebCoreFrameView.h: Ditto.
  • bridge/mac/WebCoreViewFactory.h: Ditto.
  • bridge/mac/WebCoreViewFactory.m: Ditto.
  • bridge/mac/WebDashboardRegion.h: Ditto.
  • bridge/mac/WebDashboardRegion.m: Ditto.
  • bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac, renamed WebCoreKeyboardUIMode.h, and made a C++ header.
  • page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): Ditto. (WebCore::EventHandler::tabsToAllControls): Ditto. (WebCore::EventHandler::keyboardUIMode): Ditto.


Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto. (-[WebFrameBridge keyboardUIMode]): Ditto.
21:47 Changeset [18168] by darin

Reviewed by Brady.

  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this (I think Hyatt is using an old Xcode).
21:03 Changeset [18167] by darin
  • fast/frames/iframe-option-crash-expected.txt: Updated results for this test. My recent change to owner element lifetime management changed these results, but since the point of the test is simply to check if the page crashes, the new result is probably OK. Or there could be some problem, but if so we need some other investigation -- I couldn't see anything.
20:44 Changeset [22649] by bdakin

Boomer WebKit support for editing sub-menu actions for WebCore
context menus.

  • Interfaces/IWebUIDelegate.idl: Re-named some of the spelling sub-menu tags.
  • WebContextMenuClient.cpp: New functions for the speech sub-menu. (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: New functions to toggle spelling/grammar checking. (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebEditorClient.h
20:27 Changeset [18166] by bdakin


Reviewed by Adam.

Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:

-Made BUILDING_ON_TIGER ifdef work within C++ as well as


-Fixed bug where we would throw and Obj-C exception and

fail to pop up menus with more than one separator item.

-Re-named some of the spelling/grammar tags since Tiger and

Leopard share more of the actions than initially

  • WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
  • bridge/EditorClient.h: New functions to toggle spelling/grammar checking.
  • editing/Editor.cpp: (WebCore::Editor::toggleContinuousSpellChecking): Call into client. (WebCore::Editor::toggleGrammarChecking): Same. (WebCore::Editor::toggleBold): call execToggleBold() (WebCore::Editor::toggleUnderline): Create appropriate underline style and apply to selection. (WebCore::Editor::setBaseWritingDirection): Create appropriate writing direction and apply to selection.
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: New functions to show spelling guesses, fonts, styles, and color panels.
  • page/ContextMenuClient.h: New functions for the speech sub-menu.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Fill in editing sub-menu actions.
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Helper function to create a separator item. (WebCore::createFontSubMenu): Put very mac-specific things within a platform ifdef. (WebCore::createSpellingAndGrammarSubMenu): Re-named some of the spelling sub-menu tags. (WebCore::createSpellingSubMenu): Same. (WebCore::ContextMenu::populate): We can't share the separator item. When we do, menus with more than one separator throw and obj- c exception and fail to pop-up.
  • platform/ContextMenuItem.h: (WebCore::): Re-named some of the spelling sub-menu tags.


Reviewed by Adam.

WebKit support for editing sub-menu actions.

  • WebCoreSupport/WebContextMenuClient.h: New functions for the speech sub-menu.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebCoreSupport/WebEditorClient.h: New functions to toggle spelling/grammar checking.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebView/WebUIDelegatePrivate.h: Re-named some of the spelling sub-menu tags.
20:20 S60CheckoutAndBuild edited by thisisbradley@gmail.com
s60webkit path changes (diff)
19:26 Changeset [22648] by aliceli1


Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
And some cleanup of PlatformMouseEvent(Win)

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Removed unnecessary check for mouse event type

  • platform/win/PasteboardWin.cpp:

Added more overloaded implemtations and renamed from createHandle

Changed to handle less-specific input and renamed from createCF_HTML

Added these.

Moved out of Pasteboard class

Renamed from clearTypes.

Trivial cleanup of these.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Removed anything having to do with unnecessary m_type


Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work

  • Interfaces/IWebView.idl: Added copyURL.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h: Removed copyLinkToClipboard

  • WebView.cpp: (WebView::copy): (WebView::cut): (WebView::paste): Trivial cleanup of these

Added this.

  • WebView.h: Added copyURL.
19:17 Changeset [18165] by aliceli1


Reviewed by Geoff, Adam.

Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.

All layout tests pass as they would without this patch.

  • WebCore.exp: added Editor::copyURL to be called from WebKit

  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Pasteboard::clearTypes() changed to clear()

Changed signature of writeSelection to take raw pointer instead of PassRefPtr


  • editing/Editor.h: Added copyURL.

  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Removed copyLinkToClipboard

  • platform/KURL.cpp: (WebCore::KURL::lastPathComponent):
  • platform/KURL.h: Added lastPathComponent.

  • platform/Pasteboard.h: Changed some function names. Moved some functions out of class to static.

  • platform/PlatformMouseEvent.h: (WebCore::): Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.

  • platform/mac/PasteboardMac.mm: Added writeURL, and moved some things around

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Add some calls necessary for Pasteboard::writeURL to work


Reviewed by Geoff, Adam.

switch to use the Editor for copying URLs

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): Call down to the editor for this.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add some calls necessary for Pasteboard::writeURL to work
17:26 Changeset [18164] by zimmermann

Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.

15:50 SVG TODO List - Short notes edited by zimmermann@kde.org
15:47 Changeset [22647] by darin


Reviewed by Brady.

  • WebCore.vcproj/WebCore.vcproj: Update for added files.
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame): Changed to use HTMLFrameOwnerElement.
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load): Changed to use HTMLFormElement.


Reviewed by Brady.

  • WebFrame.h:
  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Changed to use HTMLFrameOwnerElement. (WebFrame::createFrame): Ditto.
15:40 Changeset [18163] by darin


Reviewed by Brady.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Updated for new source files.
  • WebCore.exp: Updated for changes to entry point names.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): Updated owner element type to HTMLFrameOwnerElement.
  • bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't use that any more. Updated owner element type to HTMLFrameOwnerElement.
  • dom/Document.cpp: Added include so that the ownerElement function can compile (since it downcasts an HTMLFrameOwnerElement to an Element).
  • html/HTMLFrameElement.cpp: (WebCore::containingFrameSetElement): Moved this function in here; it doesn't need to be a member function. (WebCore::HTMLFrameElement::attach): Updated to call this.
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and containingFrameSetElement. Removed friend classes.
  • html/HTMLFrameOwnerElement.h: Added.
  • html/HTMLFrameOwnerElement.cpp: Added.
  • html/HTMLEmbedElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: Remove now-unneeded contentDocument functions.
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from HTMLFrameOwnerElement.
  • loader/FormState.h:
  • loader/FormState.cpp: Use HTMLFormElement instead of just Element.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use HTMLFormElement. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::requestObject): Don't pass an element parameter to shouldUsePlugin, and remove now-unneeded type casts. (WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter. (WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement. (WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto. (WebCore::FrameLoader::isHostedByObjectElement): Ditto.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Use HTMLFormElement. (WebCore::FrameLoader::post): Ditto. (WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/Frame.cpp: (WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement. (WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::ownerRenderer): Ditto. (WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner element before disconnecting it. (WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.
  • page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that the code here will compile (no code changes needed).
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • rendering/RenderPart.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Use HTMLFrameOwnerElement.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement. (WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • other changes
  • platform/network/ResourceHandleInternal.h: Added Noncopyable and fixed indentation.


Reviewed by Brady.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Use HTMLFrameOwnerElement.
  • WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the HTMLFormElement class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the change in return type of ownerElement.
15:11 Changeset [18162] by hyatt

Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.

Reviewed by darin

  • platform/StringImpl.cpp: (WebCore::isSpace):
15:10 Changeset [18161] by hyatt

Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.

Reviewed by darin

  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
15:00 Changeset [22646] by lamadio

2006-12-08 Lou Amadio <lamadio@apple.com>

Reviewed by aroben,adachan
Implement Status Bar
<rdar://4601297> Status Bar feature
<rdar://4854036> subsequent windows have glass borders on vista
<rdar://4861165> Window cascade is off
<rdar://4804690> Window widgets clip highligh

14:51 Changeset [22645] by hyatt

Fix build bustage.

14:06 Changeset [18160] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: remove the dependency on CAknSettingsCache

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
13:54 Changeset [18159] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: add flag to remove the SDK dependency on AknSettingsCache

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
12:49 Changeset [22644] by bdakin

Reviewed by Adam.

Build fix from Nick Zimmerman's last check-in.

  • WebCore.vcproj/WebCore.vcproj:
12:13 Changeset [18158] by ap

Reviewed by Adam.

Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::autoscrollTimerFired):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::mouseMoved): Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.

12:13 Changeset [18157] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
11:47 Changeset [18156] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
10:52 Changeset [18155] by zimmermann

I forgot to remove these in the previous commit, they were only emptied out.

10:03 Changeset [18154] by harrison

Fix previous checkin where I committed the wrong file.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Add nil check.

  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Reverted to previous.
09:55 Changeset [18153] by zimmermann

Reviewed by Sam Weinig.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11801

Autogenerate POD types for ObjC/JS.

This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)

08:48 Changeset [18152] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link


  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
08:42 Changeset [18151] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301

  • BrowserView/inc/HttpLoaderEventToUiListener.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
  • ChangeLog:
08:24 Changeset [18150] by ap

Reviewed by Mitz.

Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).

  • fast/text/atsui-rtl-override-selection.html:


17:23 Changeset [18149] by zack

add missing receive call for resources

17:23 Changeset [18148] by staikos

Add a default useragent for now.

17:21 Changeset [18147] by zack

Fix a small issue (crash) with resource loading (from lars, r=me)

17:17 Changeset [18146] by staikos

Make the xpath grammar hack more specific (and work on OS X) until
it's cleaned up.

17:12 Changeset [18145] by zack

Set the WidgetClient in WidgetQt correctly. We need to make
this platform independent

16:13 Changeset [18144] by zack

Fixes loading of local files (from Lars)

14:49 Changeset [18143] by zack

Don't use QTransform yet, affine QMatrix is enough for SVG,
plus it makes it work with 4.2.

13:43 Changeset [18142] by zack

Fixes for the layout tests regression testing and removal
of few unimplemented warnings (from lars)

13:37 Changeset [18141] by zack

Enable the SVG build by default and make it build.

12:29 Changeset [18140] by zack

This should go in in 18139, it's WebKitQt not WebKit

12:05 Changeset [18139] by zack

Move the "*Client classes to WebKitQt/WebCoreSupport. Uptil
now they were all scattered around the Qt platform build dirs,
this cleans it up.

11:14 Changeset [18138] by staikos

Add WebKitBuild/Release back to the output dir for external build cases.

11:02 Changeset [18137] by zack

Some more fixes to the dumprendertree application (from lars)

10:57 Changeset [18136] by zack

Add the project file.

10:46 Changeset [18135] by zack

Add back some stubs needed to compile (from lars, r=me)

10:16 Changeset [18134] by rwlbuis

Reviewed by Darin.

WebKit needs (possibly private) XML/SVG innerText support (for DumpRenderTree)

Create an internal method to create innerText functionality for non-HTML
nodes. When called from DRT this omits CDATA nodes.

02:17 Changeset [18133] by ap

2006-12-10 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11790
No way to initialize ResourceResponse::m_httpHeaderFields

  • platform/network/ResourceResponse.cpp: impl setHTTPHeaderField (WebCore::ResourceResponse::setHTTPHeaderField):
  • platform/network/ResourceResponse.h: decl setHTTPHeaderField
01:21 Changeset [18132] by zack

Cleanup more of the FrameQt crack - mainly finally remove
the methods that have been moved to their proper locations.


23:13 Changeset [18131] by zack

Remove unused/pointless code from FrameQtClient.

23:11 Changeset [18130] by aroben

Build fix.

  • xml/XPathParser.cpp: (WebCore::XPath::charCat): Use C++ unsigned instead of uint.
22:54 Changeset [18129] by staikos

Reviewed by Zack.

Make it not crash, and make it set the title on Qt platform.

22:36 Changeset [18128] by zack

Include DumpRenderTree in the Qt build and adjust it to the
recet platform/qt changes (by lars)

22:32 Changeset [22643] by aroben


Reviewed by Hyatt.

Use num-cpus to determine the number of jobs make should run

  • WebCore.vcproj/build-generated-files.sh:
21:54 Changeset [18127] by staikos

Correct the path to the libraries for QMake.

21:44 Changeset [18126] by zack

Cleanup the FrameQtClient mess a little bit.

21:33 Changeset [18125] by zack

Accomodate the file changes in the project files (aka build)

21:12 Changeset [18124] by zack

Implement a decent network loader using QHttp (from Lars)

20:58 Changeset [18123] by staikos

Fix qmake build re: bison issues - unify with Linux build

20:36 Changeset [18122] by staikos

Repair QMake build on OS X.

20:25 Changeset [18121] by zack

Small fixes for qmake shadow builds

19:57 Changeset [18120] by staikos

Remove reference to Unity. Reviewed by Zack.

19:27 Changeset [18119] by zack

Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.

19:07 Changeset [22642] by aroben

Reviewed by Hyatt.

Fix: <rdar://problem/4860184> Can't select context menu items with the
right mouse button

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show):
18:52 Changeset [18118] by zack

Crazy notion: make the font setting on widgets work.

18:36 Changeset [18117] by zack

Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)

18:32 Changeset [18116] by zack

Fix some rounding issues

18:01 Changeset [18115] by zack

Fix build for Qt 4.1 and less (for Qtopia mainly). By George.

16:58 Changeset [18114] by zack

CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.

16:44 Changeset [18113] by zack

This is part of r 18111 commit - Use the Qt image
loading framework.

16:41 Changeset [18112] by zack

Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.

16:37 Changeset [18111] by zack

Use the Qt image loading framework instead of the Mozilla

16:21 Changeset [18110] by zack

Remove an explicit ICU dependency (by lars)

16:19 Changeset [18109] by zack

Fixing the kde build after the icu Qt changes.

16:01 Changeset [22641] by aroben


Reviewed by Darin.

Build fixes after OpenSource r18098 and r18106.

  • WebCore.vcproj/WebCore.vcproj:
    • Changed include paths to reflect the now-flattened JSCore headers.
    • Added missing files to project.
    • Changed post-build step to also copy ForwardingHeaders.
    • Removed unnecessary definition of WTF_PLATFORM_CF from project file (it's already defined in config.h).
  • platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed function calls. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):


Reviewed by Darin.

Build fix.

  • WebKit.vcproj/WebKit.vcproj: Added WebCore/ForwardingHeaders to the include path.
  • WebView.cpp: Updated to reflect the newly-flattend JSCore headers.
15:53 Changeset [18108] by aroben


Reviewed by Darin.

Some updates in reaction to r18098.

  • wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all cases. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::isUpper):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:


Reviewed by Darin.

Changed all ForwardingHeaders to use #include instead of #import.

  • ForwardingHeaders/kjs/JSLock.h:
  • ForwardingHeaders/kjs/SavedBuiltins.h:
  • ForwardingHeaders/kjs/collector.h:
  • ForwardingHeaders/kjs/dtoa.h:
  • ForwardingHeaders/kjs/internal.h:
  • ForwardingHeaders/kjs/interpreter.h:
  • ForwardingHeaders/kjs/lookup.h:
  • ForwardingHeaders/kjs/object.h:
  • ForwardingHeaders/kjs/property_map.h:
  • ForwardingHeaders/kjs/protect.h:
  • ForwardingHeaders/wtf/AlwaysInline.h:
  • ForwardingHeaders/wtf/Assertions.h:
  • ForwardingHeaders/wtf/FastMalloc.h:
  • ForwardingHeaders/wtf/GetPtr.h:
  • ForwardingHeaders/wtf/HashCountedSet.h:
  • ForwardingHeaders/wtf/HashMap.h:
  • ForwardingHeaders/wtf/HashSet.h:
  • ForwardingHeaders/wtf/HashTraits.h:
  • ForwardingHeaders/wtf/MathExtras.h:
  • ForwardingHeaders/wtf/Noncopyable.h:
  • ForwardingHeaders/wtf/OwnArrayPtr.h:
  • ForwardingHeaders/wtf/OwnPtr.h:
  • ForwardingHeaders/wtf/PassRefPtr.h:
  • ForwardingHeaders/wtf/Platform.h:
  • ForwardingHeaders/wtf/RefPtr.h:
  • ForwardingHeaders/wtf/Vector.h:
14:40 Changeset [18107] by staikos

Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).

Reviewed by Darin.

09:22 Changeset [18106] by rwlbuis

Reviewed by Darin.

Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

Add a class shared by both HTMLStyleElement and SVGStyleElement that
encapsulates the common logic.

09:09 SVG TODO List - Short notes edited by zimmermann@kde.org
09:07 SVG TODO List - Short notes created by zimmermann@kde.org
08:15 WikiStart edited by pewtermoose@gmail.com
08:09 WikiStart edited by pewtermoose@gmail.com
05:30 WikiStart edited by zimmermann@kde.org
00:52 Changeset [18105] by hyatt

Fix WebKit forwarding headers for mac.

00:35 Changeset [18104] by hyatt

Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.

00:34 Changeset [18103] by hyatt

Fix mac bustage (more still).

00:33 Changeset [18102] by hyatt

Fix mac bustage (maybe).

00:32 Changeset [18101] by hyatt

Fix mac bustage (maybe).

00:29 Changeset [18100] by hyatt

Fix mac bustage (maybe).


23:54 Changeset [18099] by hyatt

Fix mac bustage.

21:54 Changeset [18098] by hyatt


Land the new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/unicode/UnicodeCategory.h: Removed.
  • wtf/unicode/UnicodeDecomposition.h: Removed.
  • wtf/unicode/UnicodeDirection.h: Removed.
  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::mirroredChar): (WTF::Unicode::category): (WTF::Unicode::direction): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset):
  • wtf/unicode/qt4/UnicodeQt4.cpp: Removed.
  • wtf/unicode/qt4/UnicodeQt4.h: (WTF::Unicode::): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::foldCase): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isLower): (WTF::Unicode::isUpper): (WTF::Unicode::digitValue): (WTF::Unicode::combiningClass): (WTF::Unicode::decompositionType): (WTF::Unicode::strcasecmp): (WTF::Unicode::memset): (WTF::Unicode::direction): (WTF::Unicode::category):


Land the new ICU abstraction layer (WTF::Unicode). Patch
by Lars with a couple of fixes thrown in by me.

Reviewed by hyatt

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::ParseString::lower):
  • dom/Document.cpp: (WebCore::isValidNameStart): (WebCore::isValidNamePart):
  • editing/TextIterator.cpp: (WebCore::CircularSearchBuffer::append):
  • html/HTMLFontElement.cpp: (WebCore::parseFontSizeNumber):
  • html/HTMLInputElement.cpp: (WebCore::numGraphemeClusters): (WebCore::numCharactersInGraphemeClusters):
  • html/HTMLSelectElement.cpp: (WebCore::stripLeadingWhiteSpace):
  • page/Frame.h:
  • platform/DeprecatedString.h: (WebCore::DeprecatedChar::isSpace): (WebCore::DeprecatedChar::lower): (WebCore::DeprecatedChar::upper):
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::WidthIterator::normalizeVoicingMarks):
  • platform/FontCache.h:
  • platform/FontData.h:
  • platform/GlyphMap.cpp:
  • platform/GlyphMap.h:
  • platform/GlyphWidthMap.h:
  • platform/KURL.cpp: (WebCore::encodeHostname):
  • platform/StringHash.h: (WTF::):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::upper): (WebCore::StringImpl::secure): (WebCore::StringImpl::foldCase): (WebCore::StringImpl::capitalize): (WebCore::StringImpl::toInt): (WebCore::equalIgnoringCase): (WebCore::StringImpl::find):
  • platform/StringImpl.h:
  • platform/TextBoundaries.h:
  • platform/TextBreakIterator.h: Added. (WebCore::):
  • platform/TextBreakIteratorICU.cpp: Added. (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/TextCodec.h:
  • platform/TextCodecLatin1.cpp:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::encode):
  • platform/TextEncoding.h:
  • platform/TextEncodingRegistry.cpp: (WebCore::buildTextEncodingNameMap): (WebCore::buildTextCodecMap):
  • platform/TextEncodingRegistry.h:
  • platform/UChar.h: Removed.
  • platform/graphics/GraphicsContext.h:
  • platform/qt/GlyphMapQt.cpp:
  • platform/qt/TextBreakIteratorQt.cpp: Added. (WebCore::TextBreakIterator::following): (WebCore::TextBreakIterator::preceding): (WebCore::WordBreakIteratorQt::first): (WebCore::WordBreakIteratorQt::next): (WebCore::WordBreakIteratorQt::previous): (WebCore::CharBreakIteratorQt::first): (WebCore::CharBreakIteratorQt::next): (WebCore::CharBreakIteratorQt::previous): (WebCore::wordBreakIterator): (WebCore::characterBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakNext): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent):
  • platform/qt/TextCodecQt.cpp: Added. (WebCore::getAtomicName): (WebCore::TextCodecQt::registerEncodingNames): (WebCore::newTextCodecQt): (WebCore::TextCodecQt::registerCodecs): (WebCore::TextCodecQt::TextCodecQt): (WebCore::TextCodecQt::~TextCodecQt): (WebCore::TextCodecQt::decode): (WebCore::TextCodecQt::encode):
  • platform/qt/TextCodecQt.h: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::widthFromCache):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (WebCore::BidiState::BidiState): (WebCore::BidiContext::BidiContext): (WebCore::bidiNext): (WebCore::bidiFirst): (WebCore::BidiIterator::direction): (WebCore::appendRun): (WebCore::embed): (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
  • rendering/bidi.h: (WebCore::BidiStatus::BidiStatus): (WebCore::BidiContext::dir): (WebCore::BidiContext::basicDir): (WebCore::BidiRun::BidiRun):
  • rendering/break_lines.h:


Land new ICU abstraction layer. Patch by Lars.

Reviewed by me

  • ForwardingHeaders/wtf/icu/UnicodeIcu.h: Added.
  • ForwardingHeaders/wtf/unicode/Unicode.h: Added.
  • WebKit.xcodeproj/project.pbxproj:
20:10 Changeset [18097] by aroben

Rolling out r17865 because it caused a performance regression.

  • loader/TextResourceDecoder.cpp: (WebCore::findXMLEncoding):
  • platform/CString.cpp: (WebCore::CString::data):
  • platform/CString.h:
  • platform/TextStream.cpp: (WebCore::TextStream::operator<<):
  • platform/TextStream.h:
18:44 Changeset [22640] by kmccullo


Reviewed by Adam.

  • createWebViewWithRequest now increases the ref count for the new window it returns. This is standard practice for COM, and fixes a crash.
  • WebFrame.cpp: (WebFrame::openURL):
17:27 Changeset [18096] by zack

Reviewed by Maciej.

Patch fixes compile of all Qt/KDE code after
the recent API changes.

17:25 Changeset [18095] by bdash

Remove stray conflict marker

17:13 Changeset [18094] by thatcher

New tag.

17:07 Changeset [18093] by thatcher


16:38 Changeset [18092] by thatcher

Rolling out a change that broke Mail stationary.
<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]):
16:31 Changeset [18091] by staikos

Reviewed by Maciej.

Build Qt webkit on non-linux, and prefer it if $QTDIR is set

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
16:11 Changeset [22639] by aroben

Rubberstamped by Anders.

  • platform/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData): Fix use of min().
15:40 Changeset [18090] by rwlbuis

Reviewed by Maciej.

Form elements added via appendChild() are not accessible via form.element

Make sure looking up form elements works when the form is not appended
to the document.

14:44 Changeset [18089] by rwlbuis

Reviewed by Adele.

REGRESSION: Clicking on a select with size other than 1 and no children results in a crash

Make sure returned value is -1 for selects without children.

14:37 Changeset [22638] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
14:34 Changeset [18088] by aroben

Fixed typo.

14:34 Changeset [18087] by aroben


Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • kjs/config.h:
  • wtf/Vector.h:


Reviewed by Anders.

This is a mo' better fix for ensuring we don't use macro definitiones
of min/max.

  • config.h:
13:21 Changeset [18086] by ap

2006-12-08 Don Gibson <dgibson77@gmail.com>

Reviewed and landed by Alexey.

Windows build bustage


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ContextMenuClientWin.h:
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onRequestComplete): (WebCore::ResourceHandle::fileLoadTimer): (WebCore::ResourceHandle::cancel):
  • platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel): (WebCore::inputElementAltText): (WebCore::copyCursor): (WebCore::resetButtonDefaultLabel): (WebCore::ContextMenuClientWin::contextMenuItemSelected): (WebCore::ContextMenuClientWin::copyLinkToClipboard): (WebCore::ContextMenuClientWin::downloadURL): (WebCore::ContextMenuClientWin::copyImageToClipboard): (WebCore::Editor::ignoreSpelling): (WebCore::Editor::learnSpelling): (WebCore::Editor::isSelectionUngrammatical): (WebCore::Editor::isSelectionMisspelled): (WebCore::Editor::guessesForMisspelledSelection): (WebCore::Editor::guessesForUngrammaticalSelection): (WebCore::Editor::markMisspellingsInAdjacentWords): (WebCore::FrameLoader::load): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::respondToChangedSelection):


  • COM/WebFrame.cpp: (WebFrame::loadDataSource):
  • COM/WebFrame.h:
13:12 Changeset [18085] by weinig


Reviewed by Geoff.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

  • fast/dom/XMLSerializer-doctype-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype.html: Added.
  • fast/dom/XMLSerializer-doctype2-expected.txt: Added.
  • fast/dom/XMLSerializer-doctype2.html: Added.


Reviewed by Geoff.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11777
Crash when using XMLSerializer.serializeToString() on
documentless, DocumentType nodes.

Test: fast/dom/XMLSerializer-doctype.html
Test: fast/dom/XMLSerializer-doctype2.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): set the document of the DocumentType node to the new document.
  • xml/XMLSerializer.cpp: Cleanup. (WebCore::XMLSerializer::serializeToString): now throws an exception for documentless nodes.
  • xml/XMLSerializer.h: cleanup
  • xml/XMLSerializer.idl: add exception
11:29 Changeset [18084] by justing


Reviewed by john

Cannot expand selection out of editable element when containing element is non-editable.

  • editing/selection/mixed-editability-6-expected.checksum: Added.
  • editing/selection/mixed-editability-6-expected.png: Added.
  • editing/selection/mixed-editability-6-expected.txt: Added.
  • editing/selection/mixed-editability-6.html: Added.
  • editing/selection/mixed-editability-7-expected.checksum: Added.
  • editing/selection/mixed-editability-7-expected.png: Added.
  • editing/selection/mixed-editability-7-expected.txt: Added.
  • editing/selection/mixed-editability-7.html: Added.


Reviewed by john

Cannot expand selection out of editable element when containing element is non-editable.

  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): Restrict the selection endpoints to the same *highest* editable root. This bug only happened when creating selections based in an editable region and extending into a higher editable root, so this change doesn't expose any new kinds of deletions, but we should start thinking about how those deletions should behave.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Ditto.
10:53 Changeset [18083] by harrison

Reviewed by Brady.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Add nil check.
10:46 Changeset [22637] by bdakin

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>. Not doing
this breaks sub-menus on Boomer since the menu items are no longer

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::platformSubMenu): (WebCore::ContextMenuItem::setSubMenu):
10:42 Changeset [18082] by bdakin

Typo! Thanks Mitz!

10:37 Changeset [18081] by bdakin

Reviewed by Maciej.

Add a new member variable to ContectMenuItem to hold on to the sub-
menu. The new member variable is an OwnPtr<ContextMenu>

  • platform/ContextMenu.cpp: Because of the OwnPtr in ContextMenuItem, we have to separate the declaration of ContextMenuItems away from the calls to appendItem(). Not doing so causes a build failure because OwnPtr inherits from Noncopyable. (WebCore::createFontSubMenu): Same. (WebCore::createSpellingAndGrammarSubMenu): Same. (WebCore::createSpellingSubMenu): Same. (WebCore::createSpeechSubMenu): Same. (WebCore::createWritingDirectionSubMenu): Same. (WebCore::ContextMenu::populate): Same.
  • platform/ContextMenuItem.h: New member variable m_subMenu.
  • platform/mac/ContextMenuItemMac.mm: Take care of setting m_subMenu in addition to setting the submenu of the NSMenuItem when we have a sub-menu. (WebCore::menuToArray): (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setSubMenu): Same.
10:35 Changeset [18080] by ap

2006-12-08 MorganL <morganl.webkit@yahoo.com>

Reviewed by Darin.

CString::data() should be documented as returning a null terminated char array

  • platform/CString.h: Add some basic documentation to CString.h
10:31 Changeset [18079] by ap

Reviewed by Geoff.

REGRESSION: When I mouse up after dragging a selection outside of a iframe, the iframe
continues to scroll automatically.

Test: manual-tests/autoscroll.html

  • manual-tests/autoscroll.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Assign to m_mousePressNode earlier, so that it is available in the superframe as well. Reset m_mouseDownWasInSubframe to false when starting to handle a mousedown - previously, its value was only defined if the event was passed down to a widget or a subframe.

If the mouse down event was in a subframe, stop the subframe's timer.

10:25 Changeset [18078] by ap

Reviewed by Geoff.

XMLHttpRequest.getResponseHeader should return a null string for non-existent headers


  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Convert null getResponseHeader strings to JS null, rather than undefined.


  • http/tests/xmlhttprequest/methods-async-expected.txt:
  • http/tests/xmlhttprequest/methods-expected.txt:
  • http/tests/xmlhttprequest/methods-lower-case-expected.txt: Updated the results.
  • http/tests/xmlhttprequest/web-apps/008-expected.txt:
  • http/tests/xmlhttprequest/web-apps/008-test.asis:
  • http/tests/xmlhttprequest/web-apps/008.html: Changed to test both missing and empty headers, also test case insensitivity of header names. Please note that neither Firefox nor IE passes this test now - the former returns null in both cases, and the latter returns empty strings.
10:19 Changeset [18077] by ap

Reviewed by Darin.

HTTP Refresh header with quotes is parsed incorrectly

Test: http/tests/misc/redirect-with-quotes.php

  • WebCore.xcodeproj/project.pbxproj: Added HTTPParsers.{h,cpp}. I intend to move Content-Type parsing here, as well.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Use the new implementation in HTTPHeaders.
  • platform/network/HTTPParsers.cpp: Added. (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: Added. Merged and rewrote existing implementations for better Firefox compatibility.
10:03 Changeset [18076] by ap

Reviewed by Tim H.

REGRESSION: XMLSerializer.serializeToString incorrect value for CDATA nodes

Test: fast/dom/serialize-cdata.html

  • editing/markup.cpp: (WebCore::startMarkup): Dump CDATA sections, too.
03:02 Changeset [18075] by rwlbuis

Reviewed by hyatt.

Deleted misplaced comment.

00:02 Changeset [18074] by rwlbuis

Reviewed by Darin.

WebKit+SVG and FireFox disagree on invalid "transform" handling

Test for parsing failure on transform attribute and clear the transform
list upon failure to match FF behaviour.


23:05 Changeset [18073] by ggaren


Reviewed by Beth Dakin.

Tests for the change and blur events in input elements.

  • fast/events/onchange-passwordfield-expected.txt: Added.
  • fast/events/onchange-passwordfield.html: Added.
  • fast/events/onchange-searchfield-expected.txt: Added.
  • fast/events/onchange-searchfield.html: Added.
  • fast/events/onchange-textfield-expected.txt: Added.
  • fast/events/onchange-textfield.html: Added.


Reviewed by Beth Dakin.

Fixed <rdar://problem/4870551> 9A320: <input type="text"> no longer
dispatches onchange event in response to enter key

To match our old behavior and FF, we need to dispatch onchange in response to the
ENTER key. The strategy here is just to dispatch a blur event, since that's how
the search field always worked, and the DOM spec says onchange only fires
as a precursor to blur.

  • ChangeLog:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
19:53 Changeset [18072] by aroben

Reviewed by Oliver.

Some small context menu-related fixes.

  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::defaultEventHandler): Don't try to resize on a contextmenuEvent.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Only pass the event off to HTMLGenericFormElement if we haven't handled it.
19:22 Changeset [18071] by bdash

2006-12-07 Kevin Fyure <digdog@macports.org>

Reviewed by Darin.

Disable the testcases do not follow the ECMA-262v3 specification.

  • tests/mozilla/expected.html: Update Results.
  • tests/mozilla/js1_2/String/concat.js: 4 tests disabled. The result of concat Array object is not followinig ECMA
  • tests/mozilla/js1_2/function/Number.js: 1 test disabled. The result of Array object to Number object conversion is not following ECMA 9.3. And the test was duplicated in ecma/TypeConversion/9.3-1.js
  • tests/mozilla/js1_2/function/String.js: 2 tests disabled. The result of Object/Array object to String object conversion is not following ECMA and ECMA 9.8
17:51 Changeset [18070] by zbujtas

2006-12-03 shkeller <shaun.keller@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: synthesize missing html node when comments start doc


  • khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
16:54 Changeset [18069] by andersca


Reviewed by Darin.

DashboardClient crashing in WebCore::SubresourceLoader::didFail.

  • http/tests/xmlhttprequest/abort-crash-expected.txt: Added.
  • http/tests/xmlhttprequest/abort-crash.html: Added.
  • http/tests/xmlhttprequest/hello-world.cgi: Added.


Reviewed by Darin.

Title: DashboardClient crashing in WebCore::SubresourceLoader::didFail

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::stopLoading):
  • loader/SubresourceLoader.h: Add stopLoading method which currently just clears the client. This isn't the ideal fix, since it doesn't actually stop the load.

  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): Add null-checks.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::abort): Call stopLoading.
16:28 Changeset [22636] by kmccullo

Reviewed by.

Fixed previous comment

  • ChangeLog:
16:26 Changeset [22635] by kmccullo

Reviewed by NOBODY (OOPS!).

  • keyDown events must be followed by keyPressed events and before keyUp events.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyEvent):
16:23 Changeset [18068] by kmccullo

Reviewed by Geof.

  • added the ability to set the auto repeating variable to force a keyPressed event from a keyDown event.
  • platform/PlatformKeyboardEvent.h: (WebCore::PlatformKeyboardEvent::setIsAutoRepeat):
16:14 Changeset [18067] by bdash

2006-12-07 Kirby White <KWhiteRight@gmail.com>

Reviewed by Adele.

Bug 11771: Add a test for resetting a textarea form control

  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Added.
  • fast/dom/HTMLTextAreaElement/reset-textarea.html: Added.
16:10 Changeset [18066] by bdash

2006-12-07 Don Gibson <dgibson77@gmail.com>

Reviewed by Darin.

Don't call updateThumbProportion() unnecessarily.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setProportion):
15:50 Changeset [22634] by sfalken

Bump version for submit

15:44 Changeset [18065] by sfalken

New tag.

15:37 Changeset [18064] by bdash


15:35 Changeset [18063] by bdash

Merge fix from r18048

15:22 Changeset [18062] by bdash

New tag

15:21 Changeset [18061] by brmorris

2006-12-07 Bradley Morrison <bradley.morrison@nokia.com>

Reviewed by Babu.

Updated expected layout test results to include color attribute.

14:10 Changeset [22633] by aroben


Reviewed by Anders.

Two small fixes for bugs discovered while implementing the Snippet

  • WebView.cpp: (registerWebViewWindowClass): Set the WebView's default cursor to be IDC_ARROW. (WebView::uiDelegate): Return E_FAIL if there's no UI delegate.
13:57 Changeset [22632] by sfalken

2006-12-06 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.

Added caching to prevent re-converting strings unnecessarily.

  • WebKit.vcproj/WebKit.def: Export LPCTSTR localization function
  • WebKit.vcproj/WebKit_debug.def: Export LPCTSTR localization function
  • WebLocalizableStrings.cpp: (createWebKitBundle): Added using namespace so we don't need to qualify String (WebLocalizedLPCTSTR): Added
  • WebLocalizableStrings.h: Added LPCTSTR localization support
13:49 Changeset [18060] by sfalken

2006-12-06 Steve Falkenburg <sfalken@apple.com>

Support C strings for localization

  • Scripts/extract-localizable-strings:
12:47 Changeset [18059] by bdakin

Reviewed by Brady.

Build fix for WebCore ContextMenus. It got broken by r18046.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]):
11:57 Changeset [22631] by bdakin


Reviewed by Brady.

New link stub for load() function used by
ContextMenuItemTagOpenLink action.

  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load):


Reviewed by Brady.

Make some parameters const and const references.

  • WebContextMenuClient.cpp: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/TemporaryLinkStubs.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

11:49 Changeset [18058] by yongjzha

2006-12-05 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Toolbar tooltip not OK for RTL tooltip like Hebrew

  • BrowserView/src/WebKitView.cpp: (CWebKitView::DrawToolTip):
11:49 Changeset [18057] by bdakin


Reviewed by Brady.

Fixes "Open in new Window" item in WebCore ContextMenus. It wasn't
doing anything before, and now it works! Also some formatting
changes, etc.

  • page/ContextMenuClient.h: Several of the parameters to several of the functions here should be const or const references. And now they are!
  • page/ContextMenuController.cpp: (WebCore::openNewWindow): Moved the open new window functionality into a helper function since it is used by several menu item tags. Now after calling chrome()->createWindow() we call chrome()->show() on the new window, and so it appears! (WebCore::ContextMenuController::contextMenuItemSelected): Call new openNewWindow function to do the right thing. Shift some formatting, use local variable for HitTestResult. Implement action for ContextMenuItemTagOpenLink.


Reviewed by Brady.

Make some parameters const and const references.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): (WebContextMenuClient::copyLinkToClipboard): (WebContextMenuClient::downloadURL): (WebContextMenuClient::copyImageToClipboard):
11:41 Changeset [18056] by yongjzha

2006-12-07 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link


  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
11:39 Changeset [22630] by adachan

2006-12-07 Ada Chan <adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4866288> Crash on boomer quit

  • don't close the themes on termination, since uxtheme should do that anyway.
01:49 Changeset [18055] by ddkilzer

Fixed typos/misspellings.

Note: See TracTimeline for information about the timeline view.