23:52 Changeset [18208] by hyatt

Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.

Reviewed by olliej

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
23:33 Changeset [18207] by bdash

2006-12-13 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2005-09-06 David Hyatt <hyatt@apple.com>

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):
17:30 Changeset [18206] by andersca
  • loader/FrameLoader.h: id is mac-only.
17:04 Changeset [22663] by andersca

Fix the build.

  • platform/win/TemporaryLinkStubs.cpp: (PolicyCheck::call): (DocumentLoader::URL):
15:34 Changeset [18205] by beidson

Implicitly reviewed by Darin, Hyatt, Maciej, and others!

Fixes a document tear down crash.
Changes a few long standing assertions to our new style

  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::topDocument):
15:22 Changeset [18204] by mjs

Reviewed by Brady and Anders.

  • Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.
15:20 Changeset [18203] by mjs


Reviewed by Anders.

  • added equality and inequality operations for HashMap and Vector, useful for comparing more complex types
  • wtf/HashMap.h: (WTF::operator==): (WTF::operator!=):
  • wtf/Vector.h: (WTF::operator==): (WTF::operator!=):


Reviewed by Anders.

  • converted many places to use ResourceRequest instead of NSURLRequest
  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck):
  • loader/FrameLoader.h: (WebCore::PolicyCheck::request):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::applyUserAgent): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::originalRequestURL): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • loader/mac/WebDataProtocol.h:
  • loader/mac/WebDataProtocol.mm:
  • platform/KURL.cpp: (WebCore::operator!=):
  • platform/KURL.h:
  • platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL):
  • platform/network/FormData.h: (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceRequest.cpp: (WebCore::operator==):
  • platform/network/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):


Reviewed by Anders.

  • adjusted for changes from NSURLRequest to ResourceRequest
  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame loadArchive:]):
15:19 Changeset [22662] by ggaren


Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Minor problems remain with focus in frames, but basic editing / cursor
focus works.

I moved tracking of the focused frame from the Widget hiearchy to Page's
FocusController. Not all widgets are frames, so this change cleaned up a
dubious static cast. Also, the DOM needs to track frame focus because (1)
it needs to respond to focus changes and (2) you can focus an element /
frame even before it has a renderer / widget.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::focusDocumentView): Implemented. This function is poorly named, based on the Mac design. (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really used on Windows, though.


Reviewed by Darin Adler, Dave Hyatt.

Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused

Updated WebKit to use new FocusController tracking of the focused frame.

  • WebView.cpp: (WebViewWndProc): Fixed a minor bug where we wouldn't fire the blur event when changing focus to the location bar.
15:10 Changeset [18202] by ggaren

Reviewed by Darin Adler, Dave Hyatt.

Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.

(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.

  • platform/Widget.h:
13:33 Changeset [18201] by justing

Reviewed by adele

Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides

There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition to fix the table case.
13:08 Changeset [22661] by sfalken

Bump version for submit

13:01 Changeset [18200] by sfalken

New tag.

12:12 Changeset [22660] by sfalken

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Add WebCore forwarding headers to include paths

2006-11-14 Steve Falkenburg <sfalken@apple.com>

B&I build fix

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Add missing ForwardingHeaders to project

  • WebCore.vcproj/WebCore.make: Fixed line endings
  • WebCore.vcproj/WebCore.vcproj: Added missing headers
12:02 Changeset [18199] by sfalken

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Added missing forwarding headers.

  • ForwardingHeaders/kjs/value.h: Added.
  • ForwardingHeaders/wtf/HashTable.h: Added.
09:05 Changeset [18198] by ggaren

Updated results to match Justin Garcia's addition of rangeCount to
the selection object.

  • fast/dom/Window/window-properties-expected.txt:
06:45 Changeset [18197] by zack

Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob

05:16 Changeset [18196] by zack

make it compile after last nights changes from lars (r=maciej,me)


23:02 Changeset [22659] by sfalken

2006-12-12 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

B&I build fix

  • WebCore.vcproj/build-generated-files.sh:
18:48 Changeset [22658] by aliceli1

Reviewed by Geoff.

Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):
18:41 Changeset [22657] by aroben
18:34 Changeset [18195] by aroben

Reviewed by Anders.

Changed #import to #include to match the rest of our ForwardingHeaders.

  • ForwardingHeaders/wtf/StringExtras.h:
17:46 Changeset [18194] by zbujtas

2006-12-11 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
17:41 Changeset [18193] by zbujtas

2006-12-12 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage


  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
17:23 Changeset [22656] by sfalken

Bump version for submit

17:16 Changeset [18192] by sfalken

New tag.

16:48 Changeset [18191] by justing


Reviewed by harrison

GoogleDocs: Style menu does not open

  • editing/selection/rangeCount-expected.txt: Added.
  • editing/selection/rangeCount.html: Added.


Reviewed by harrison

GoogleDocs: Style menu does not open

  • bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): Added rangeCount.
  • bindings/js/kjs_window.h: (KJS::Selection::):
  • editing/SelectionController.h: (WebCore::SelectionController::rangeCount): Added.
15:58 Changeset [18190] by aliceli1

Reviewed by Oliver.

  • bindings/js/JSSVGMatrixCustom.cpp: added #ifdef SVG_SUPPORT
15:45 Changeset [18189] by andersca

Suggested by Darin.

  • loader/ResourceLoader.cpp: Move down include of ResourceHandle.h.
15:30 Changeset [18188] by ggaren

Fixing up svn properties on FocusController.*

14:19 Changeset [22655] by ggaren

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Added FocusController to project.

  • WebCore.vcproj/WebCore.vcproj:
14:11 Changeset [18187] by ggaren

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.

Layout tests pass.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::view): (WebCore::Document::page): New helper function.
  • dom/Document.h: Moved setters before getters. (WebCore::Document::hoverNode): (WebCore::Document::activeNode):
  • dom/Node.cpp: (WebCore::Node::detach): Use the FocusController.
  • page/FocusController.cpp: Added. (WebCore::shouldFocus): renamed and refactored this helper function. (WebCore::shouldUnfocus): ditto.
  • page/FocusController.h: Added.
14:03 Changeset [18186] by andersca

Rubber Stamped by Geoff.

  • platform/Base64.cpp:
  • platform/Base64.h: Put functions inside of the WebCore namespace.
13:50 Changeset [22654] by andersca


  • loader/win/ResourceLoaderWin.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadsBlocked): Update for changes to ResourceHandle.


  • WebFrame.cpp: (WebFrame::loadDataSource): Update for changes to ResourceHandle.
13:42 Changeset [18185] by andersca

Try fixing the non-Mac builds.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
13:14 Changeset [18184] by andersca


Reviewed by Darin.

Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

  • WebCore.exp: Add new methods needed by WebKit.

  • WebCore.xcodeproj/project.pbxproj: Make ResourceHandle.h a private header.

  • loader/FrameLoaderClient.h: Change the download method to take a ResourceHandle instead of an NSURLConnection.

  • loader/MainResourceLoader.h: Get rid of the proxy instance variable, that's handled by ResourceHandlw now.

  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::handle):
  • loader/SubresourceLoader.h: Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.

  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): Use a ResourceHandle instead of an NSURLConnection.

  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail): Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.

  • loader/mac/SubresourceLoaderMac.mm: Remove ResourceHandleClient methods.

  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.

  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseProxy): (WebCore::ResourceHandle::connection): New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing connection.


Reviewed by Darin.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
12:13 Changeset [18183] by yongjzha

2006-12-12 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
12:09 Changeset [18182] by ap

Reviewed by Geoff. Based on a patch by Maks Orlovich.

Throw errors on invalid expressions (KJS merge)


  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.
  • tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.


  • fast/js/kde/RegExp-expected.txt: One more test passes.
11:50 SVG TODO List - Short notes edited by ojh16@student.canterbury.ac.nz
text+filter stuff (diff)
11:42 Changeset [18181] by andersca

Reviewed by Geoff.

  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of the DocLoader parameter to ResourceHandle::create.
11:41 Changeset [22653] by darin
  • fix build
  • WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.
11:32 Changeset [18180] by ggaren

Oops. Forgot to check in this file.

09:52 SVG TODO List - Short notes edited by zimmermann@kde.org
09:01 Changeset [18179] by spadma

2006-12-11 sareen <shyam.sareen@nokia.com>

Reviewed Sachin Padma.
DESC: Saved Pages: Some Images not saved with the page.

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
04:09 Changeset [18178] by staikos

Make the last checkin compile

03:19 Changeset [18177] by zimmermann

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11797

Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

01:55 Changeset [18176] by staikos

Fix the Qt build

01:02 Changeset [18175] by ggaren


Reviewed by Beth Dakin.

Added some focus-related tests.

  • editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect the fact that we now unfocus nodes when they're removed from the document.
  • fast/events/keypress-removed-node-expected.txt: Added.
  • fast/events/keypress-removed-node.html: Added.
  • fast/forms/focus2-expected.txt: Added.
  • fast/forms/focus2.html: Added.


Reviewed by Beth Dakin.

Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.

We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.

  • dom/Document.cpp: Migrated code to Page (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::setFocusedNode): (WebCore::Document::focusedNode):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes the minor bug and was also necessary to prevent regressions caused by hanging on to a focused node after the document was replaced.
  • dom/Node.h: (WebCore::Node::inDetach):
  • page/Page.cpp: Migrated code from Document (WebCore::shouldAcquireEditingFocus): (WebCore::shouldRelinquishEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::widgetForNode): (WebCore::Page::setFocusedNode):
  • page/Page.h: (WebCore::Page::focusedNode):
00:45 Changeset [18174] by ggaren

build fix

00:28 Changeset [18173] by ap

Added the new XHR EventTarget methods to test results.

  • fast/dom/Window/window-properties-expected.txt:


23:59 Changeset [18172] by ap

Reviewed by Darin.

XMLHttpRequest should be an EventTarget

Test: http/tests/xmlhttprequest/event-target.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  • xml/xmlhttprequest.h: (WebCore::XMLHttpRequest::eventListeners): Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).
23:28 Changeset [22652] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added missing files to project.
23:13 Changeset [22651] by sfalken

B&I build fix

23:13 Changeset [18171] by darin

Reviewed by Geoff.

DocumentType objects were getting filed under the wrong document in the
DOM objects structure.

  • bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
  • bindings/js/kjs_binding.cpp: (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging. (KJS::addWrapper): Added. (KJS::removeWrapper): Added. (KJS::removeWrappers): Added. (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference to this wrapper since it's being destroyed. (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS. (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions we're calling. Another solution would be to reorder the two, but I think that would create a race where another thread could garbage collect after the forget but before the put. (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.
  • dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
  • dom/Node.cpp: (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here. (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
22:47 Changeset [18170] by ap

Add support for window.atob() and window.btoa()

Reviewed by Darin.



  • WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • platform/Base64.cpp: Added. (base64Encode): (base64Decode):
  • platform/Base64.h: Added.
  • ForwardingHeaders/wtf/StringExtras.h: Added.
  • platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.


  • fast/dom/Window/atob-btoa-expected.txt: Added.
  • fast/dom/Window/atob-btoa.html: Added.
  • fast/dom/Window/btoa-pnglet-expected.checksum: Added.
  • fast/dom/Window/btoa-pnglet-expected.png: Added.
  • fast/dom/Window/btoa-pnglet-expected.txt: Added.
  • fast/dom/Window/btoa-pnglet.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
22:34 Changeset [22650] by sfalken

2006-12-11 Steve Falkenburg <sfalken@apple.com>

B&I build fix.
Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.

  • WebCore.vcproj/WebCore.vcproj:
21:56 Changeset [18169] by darin


Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCore.xcodeproj/project.pbxproj: Updated project for file moves.
  • bridge/mac/FrameMac.h: Moved to page/mac.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • bridge/mac/WebCoreFrameView.h: Ditto.
  • bridge/mac/WebCoreViewFactory.h: Ditto.
  • bridge/mac/WebCoreViewFactory.m: Ditto.
  • bridge/mac/WebDashboardRegion.h: Ditto.
  • bridge/mac/WebDashboardRegion.m: Ditto.
  • bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac, renamed WebCoreKeyboardUIMode.h, and made a C++ header.
  • page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): Ditto. (WebCore::EventHandler::tabsToAllControls): Ditto. (WebCore::EventHandler::keyboardUIMode): Ditto.


Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto. (-[WebFrameBridge keyboardUIMode]): Ditto.
21:47 Changeset [18168] by darin

Reviewed by Brady.

  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this (I think Hyatt is using an old Xcode).
21:03 Changeset [18167] by darin
  • fast/frames/iframe-option-crash-expected.txt: Updated results for this test. My recent change to owner element lifetime management changed these results, but since the point of the test is simply to check if the page crashes, the new result is probably OK. Or there could be some problem, but if so we need some other investigation -- I couldn't see anything.
20:44 Changeset [22649] by bdakin

Boomer WebKit support for editing sub-menu actions for WebCore
context menus.

  • Interfaces/IWebUIDelegate.idl: Re-named some of the spelling sub-menu tags.
  • WebContextMenuClient.cpp: New functions for the speech sub-menu. (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: New functions to toggle spelling/grammar checking. (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebEditorClient.h
20:27 Changeset [18166] by bdakin


Reviewed by Adam.

Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:

-Made BUILDING_ON_TIGER ifdef work within C++ as well as


-Fixed bug where we would throw and Obj-C exception and

fail to pop up menus with more than one separator item.

-Re-named some of the spelling/grammar tags since Tiger and

Leopard share more of the actions than initially

  • WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
  • bridge/EditorClient.h: New functions to toggle spelling/grammar checking.
  • editing/Editor.cpp: (WebCore::Editor::toggleContinuousSpellChecking): Call into client. (WebCore::Editor::toggleGrammarChecking): Same. (WebCore::Editor::toggleBold): call execToggleBold() (WebCore::Editor::toggleUnderline): Create appropriate underline style and apply to selection. (WebCore::Editor::setBaseWritingDirection): Create appropriate writing direction and apply to selection.
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: New functions to show spelling guesses, fonts, styles, and color panels.
  • page/ContextMenuClient.h: New functions for the speech sub-menu.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Fill in editing sub-menu actions.
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Helper function to create a separator item. (WebCore::createFontSubMenu): Put very mac-specific things within a platform ifdef. (WebCore::createSpellingAndGrammarSubMenu): Re-named some of the spelling sub-menu tags. (WebCore::createSpellingSubMenu): Same. (WebCore::ContextMenu::populate): We can't share the separator item. When we do, menus with more than one separator throw and obj- c exception and fail to pop-up.
  • platform/ContextMenuItem.h: (WebCore::): Re-named some of the spelling sub-menu tags.


Reviewed by Adam.

WebKit support for editing sub-menu actions.

  • WebCoreSupport/WebContextMenuClient.h: New functions for the speech sub-menu.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebCoreSupport/WebEditorClient.h: New functions to toggle spelling/grammar checking.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebView/WebUIDelegatePrivate.h: Re-named some of the spelling sub-menu tags.
20:20 S60CheckoutAndBuild edited by thisisbradley@gmail.com
s60webkit path changes (diff)
19:26 Changeset [22648] by aliceli1


Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
And some cleanup of PlatformMouseEvent(Win)

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Removed unnecessary check for mouse event type

  • platform/win/PasteboardWin.cpp:

Added more overloaded implemtations and renamed from createHandle

Changed to handle less-specific input and renamed from createCF_HTML

Added these.

Moved out of Pasteboard class

Renamed from clearTypes.

Trivial cleanup of these.

  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Removed anything having to do with unnecessary m_type


Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work

  • Interfaces/IWebView.idl: Added copyURL.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h: Removed copyLinkToClipboard

  • WebView.cpp: (WebView::copy): (WebView::cut): (WebView::paste): Trivial cleanup of these

Added this.

  • WebView.h: Added copyURL.
19:17 Changeset [18165] by aliceli1


Reviewed by Geoff, Adam.

Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.

All layout tests pass as they would without this patch.

  • WebCore.exp: added Editor::copyURL to be called from WebKit

  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Pasteboard::clearTypes() changed to clear()

Changed signature of writeSelection to take raw pointer instead of PassRefPtr


  • editing/Editor.h: Added copyURL.

  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Removed copyLinkToClipboard

  • platform/KURL.cpp: (WebCore::KURL::lastPathComponent):
  • platform/KURL.h: Added lastPathComponent.

  • platform/Pasteboard.h: Changed some function names. Moved some functions out of class to static.

  • platform/PlatformMouseEvent.h: (WebCore::): Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.

  • platform/mac/PasteboardMac.mm: Added writeURL, and moved some things around

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Add some calls necessary for Pasteboard::writeURL to work


Reviewed by Geoff, Adam.

switch to use the Editor for copying URLs

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): Call down to the editor for this.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add some calls necessary for Pasteboard::writeURL to work
17:26 Changeset [18164] by zimmermann

Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.

15:50 SVG TODO List - Short notes edited by zimmermann@kde.org
15:47 Changeset [22647] by darin


Reviewed by Brady.

  • WebCore.vcproj/WebCore.vcproj: Update for added files.
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame): Changed to use HTMLFrameOwnerElement.
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load): Changed to use HTMLFormElement.


Reviewed by Brady.

  • WebFrame.h:
  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Changed to use HTMLFrameOwnerElement. (WebFrame::createFrame): Ditto.
15:40 Changeset [18163] by darin


Reviewed by Brady.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Updated for new source files.
  • WebCore.exp: Updated for changes to entry point names.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): Updated owner element type to HTMLFrameOwnerElement.
  • bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't use that any more. Updated owner element type to HTMLFrameOwnerElement.
  • dom/Document.cpp: Added include so that the ownerElement function can compile (since it downcasts an HTMLFrameOwnerElement to an Element).
  • html/HTMLFrameElement.cpp: (WebCore::containingFrameSetElement): Moved this function in here; it doesn't need to be a member function. (WebCore::HTMLFrameElement::attach): Updated to call this.
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and containingFrameSetElement. Removed friend classes.
  • html/HTMLFrameOwnerElement.h: Added.
  • html/HTMLFrameOwnerElement.cpp: Added.
  • html/HTMLEmbedElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: Remove now-unneeded contentDocument functions.
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from HTMLFrameOwnerElement.
  • loader/FormState.h:
  • loader/FormState.cpp: Use HTMLFormElement instead of just Element.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use HTMLFormElement. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::requestObject): Don't pass an element parameter to shouldUsePlugin, and remove now-unneeded type casts. (WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter. (WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement. (WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto. (WebCore::FrameLoader::isHostedByObjectElement): Ditto.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Use HTMLFormElement. (WebCore::FrameLoader::post): Ditto. (WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/Frame.cpp: (WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement. (WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::ownerRenderer): Ditto. (WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner element before disconnecting it. (WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.
  • page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that the code here will compile (no code changes needed).
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • rendering/RenderPart.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Use HTMLFrameOwnerElement.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement. (WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • other changes
  • platform/network/ResourceHandleInternal.h: Added Noncopyable and fixed indentation.


Reviewed by Brady.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Use HTMLFrameOwnerElement.
  • WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the HTMLFormElement class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the change in return type of ownerElement.
15:11 Changeset [18162] by hyatt

Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.

Reviewed by darin

  • platform/StringImpl.cpp: (WebCore::isSpace):
15:10 Changeset [18161] by hyatt

Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.

Reviewed by darin

  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
15:00 Changeset [22646] by lamadio

2006-12-08 Lou Amadio <lamadio@apple.com>

Reviewed by aroben,adachan
Implement Status Bar
<rdar://4601297> Status Bar feature
<rdar://4854036> subsequent windows have glass borders on vista
<rdar://4861165> Window cascade is off
<rdar://4804690> Window widgets clip highligh

14:51 Changeset [22645] by hyatt

Fix build bustage.

14:06 Changeset [18160] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: remove the dependency on CAknSettingsCache

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
13:54 Changeset [18159] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: add flag to remove the SDK dependency on AknSettingsCache

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
12:49 Changeset [22644] by bdakin

Reviewed by Adam.

Build fix from Nick Zimmerman's last check-in.

  • WebCore.vcproj/WebCore.vcproj:
12:13 Changeset [18158] by ap

Reviewed by Adam.

Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::autoscrollTimerFired):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::mouseMoved): Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.

12:13 Changeset [18157] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
11:47 Changeset [18156] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
10:52 Changeset [18155] by zimmermann

I forgot to remove these in the previous commit, they were only emptied out.

10:03 Changeset [18154] by harrison

Fix previous checkin where I committed the wrong file.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Add nil check.

  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Reverted to previous.
09:55 Changeset [18153] by zimmermann

Reviewed by Sam Weinig.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11801

Autogenerate POD types for ObjC/JS.

This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)

08:48 Changeset [18152] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link


  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
08:42 Changeset [18151] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301

  • BrowserView/inc/HttpLoaderEventToUiListener.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
  • ChangeLog:
08:24 Changeset [18150] by ap

Reviewed by Mitz.

Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).

  • fast/text/atsui-rtl-override-selection.html:


17:23 Changeset [18149] by zack

add missing receive call for resources

17:23 Changeset [18148] by staikos

Add a default useragent for now.

17:21 Changeset [18147] by zack

Fix a small issue (crash) with resource loading (from lars, r=me)

17:17 Changeset [18146] by staikos

Make the xpath grammar hack more specific (and work on OS X) until
it's cleaned up.

17:12 Changeset [18145] by zack

Set the WidgetClient in WidgetQt correctly. We need to make
this platform independent

16:13 Changeset [18144] by zack

Fixes loading of local files (from Lars)

14:49 Changeset [18143] by zack

Don't use QTransform yet, affine QMatrix is enough for SVG,
plus it makes it work with 4.2.

13:43 Changeset [18142] by zack

Fixes for the layout tests regression testing and removal
of few unimplemented warnings (from lars)

13:37 Changeset [18141] by zack

Enable the SVG build by default and make it build.

12:29 Changeset [18140] by zack

This should go in in 18139, it's WebKitQt not WebKit

12:05 Changeset [18139] by zack

Move the "*Client classes to WebKitQt/WebCoreSupport. Uptil
now they were all scattered around the Qt platform build dirs,
this cleans it up.

11:14 Changeset [18138] by staikos

Add WebKitBuild/Release back to the output dir for external build cases.

11:02 Changeset [18137] by zack

Some more fixes to the dumprendertree application (from lars)

10:57 Changeset [18136] by zack

Add the project file.

10:46 Changeset [18135] by zack

Add back some stubs needed to compile (from lars, r=me)

10:16 Changeset [18134] by rwlbuis

Reviewed by Darin.

WebKit needs (possibly private) XML/SVG innerText support (for DumpRenderTree)

Create an internal method to create innerText functionality for non-HTML
nodes. When called from DRT this omits CDATA nodes.

02:17 Changeset [18133] by ap

2006-12-10 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11790
No way to initialize ResourceResponse::m_httpHeaderFields

  • platform/network/ResourceResponse.cpp: impl setHTTPHeaderField (WebCore::ResourceResponse::setHTTPHeaderField):
  • platform/network/ResourceResponse.h: decl setHTTPHeaderField
01:21 Changeset [18132] by zack

Cleanup more of the FrameQt crack - mainly finally remove
the methods that have been moved to their proper locations.


23:13 Changeset [18131] by zack

Remove unused/pointless code from FrameQtClient.

23:11 Changeset [18130] by aroben

Build fix.

  • xml/XPathParser.cpp: (WebCore::XPath::charCat): Use C++ unsigned instead of uint.
22:54 Changeset [18129] by staikos

Reviewed by Zack.

Make it not crash, and make it set the title on Qt platform.

22:36 Changeset [18128] by zack

Include DumpRenderTree in the Qt build and adjust it to the
recet platform/qt changes (by lars)

22:32 Changeset [22643] by aroben


Reviewed by Hyatt.

Use num-cpus to determine the number of jobs make should run

  • WebCore.vcproj/build-generated-files.sh:
21:54 Changeset [18127] by staikos

Correct the path to the libraries for QMake.

21:44 Changeset [18126] by zack

Cleanup the FrameQtClient mess a little bit.

21:33 Changeset [18125] by zack

Accomodate the file changes in the project files (aka build)

21:12 Changeset [18124] by zack

Implement a decent network loader using QHttp (from Lars)

20:58 Changeset [18123] by staikos

Fix qmake build re: bison issues - unify with Linux build

20:36 Changeset [18122] by staikos

Repair QMake build on OS X.

20:25 Changeset [18121] by zack

Small fixes for qmake shadow builds

19:57 Changeset [18120] by staikos

Remove reference to Unity. Reviewed by Zack.

19:27 Changeset [18119] by zack

Simon says : work with qmake shadow builds. Patch adds support
for it to the build scripts.

19:07 Changeset [22642] by aroben

Reviewed by Hyatt.

Fix: <rdar://problem/4860184> Can't select context menu items with the
right mouse button

  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::show):
18:52 Changeset [18118] by zack

Crazy notion: make the font setting on widgets work.

18:36 Changeset [18117] by zack

Stop complaining about the nil renderer (granted the whole
scrollcanvas implementation makes the baby jesus cry)

18:32 Changeset [18116] by zack

Fix some rounding issues

18:01 Changeset [18115] by zack

Fix build for Qt 4.1 and less (for Qtopia mainly). By George.

16:58 Changeset [18114] by zack

CMake is too slow to make it the default build for us. This
patch adds QMake build which works, way, way better. Mostly
done by Simon Hausmann.

16:44 Changeset [18113] by zack

This is part of r 18111 commit - Use the Qt image
loading framework.

16:41 Changeset [18112] by zack

Compile after latest WebKit changes and don't depend on
deprecated methods in Qt.

16:37 Changeset [18111] by zack

Use the Qt image loading framework instead of the Mozilla

16:21 Changeset [18110] by zack

Remove an explicit ICU dependency (by lars)

16:19 Changeset [18109] by zack

Fixing the kde build after the icu Qt changes.

16:01 Changeset [22641] by aroben


Reviewed by Darin.

Build fixes after OpenSource r18098 and r18106.

  • WebCore.vcproj/WebCore.vcproj:
    • Changed include paths to reflect the now-flattened JSCore headers.
    • Added missing files to project.
    • Changed post-build step to also copy ForwardingHeaders.
    • Removed unnecessary definition of WTF_PLATFORM_CF from project file (it's already defined in config.h).
  • platform/win/TextBoundariesWin.cpp: Fixed up includes and renamed function calls. (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary):


Reviewed by Darin.

Build fix.

  • WebKit.vcproj/WebKit.vcproj: Added WebCore/ForwardingHeaders to the include path.
  • WebView.cpp: Updated to reflect the newly-flattend JSCore headers.
15:53 Changeset [18108] by aroben


Reviewed by Darin.

Some updates in reaction to r18098.

  • wtf/unicode/icu/UnicodeIcu.h: Use !! to convert UBool to bool in all cases. (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::isDigit): (WTF::Unicode::isSpace): (WTF::Unicode::isPunct): (WTF::Unicode::isLower): (WTF::Unicode::isUpper):
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/WTF/WTF.vcproj:


Reviewed by Darin.

Changed all ForwardingHeaders to use #include instead of #import.

  • ForwardingHeaders/kjs/JSLock.h:
  • ForwardingHeaders/kjs/SavedBuiltins.h:
  • ForwardingHeaders/kjs/collector.h:
  • ForwardingHeaders/kjs/dtoa.h:
  • ForwardingHeaders/kjs/internal.h:
  • ForwardingHeaders/kjs/interpreter.h:
  • ForwardingHeaders/kjs/lookup.h:
  • ForwardingHeaders/kjs/object.h:
  • ForwardingHeaders/kjs/property_map.h:
  • ForwardingHeaders/kjs/protect.h:
  • ForwardingHeaders/wtf/AlwaysInline.h:
  • ForwardingHeaders/wtf/Assertions.h:
  • ForwardingHeaders/wtf/FastMalloc.h:
  • ForwardingHeaders/wtf/GetPtr.h:
  • ForwardingHeaders/wtf/HashCountedSet.h:
  • ForwardingHeaders/wtf/HashMap.h:
  • ForwardingHeaders/wtf/HashSet.h:
  • ForwardingHeaders/wtf/HashTraits.h:
  • ForwardingHeaders/wtf/MathExtras.h:
  • ForwardingHeaders/wtf/Noncopyable.h:
  • ForwardingHeaders/wtf/OwnArrayPtr.h:
  • ForwardingHeaders/wtf/OwnPtr.h:
  • ForwardingHeaders/wtf/PassRefPtr.h:
  • ForwardingHeaders/wtf/Platform.h:
  • ForwardingHeaders/wtf/RefPtr.h:
  • ForwardingHeaders/wtf/Vector.h:
14:40 Changeset [18107] by staikos

Patch by Lars Knoll, comment out ICU dependency on Qt platform (unused code).

Reviewed by Darin.

09:22 Changeset [18106] by rwlbuis

Reviewed by Darin.

Investigate possibility to share code between HTMLStyleElement and SVGStyleElement

Add a class shared by both HTMLStyleElement and SVGStyleElement that
encapsulates the common logic.

09:09 SVG TODO List - Short notes edited by zimmermann@kde.org
09:07 SVG TODO List - Short notes created by zimmermann@kde.org
08:15 WikiStart edited by pewtermoose@gmail.com
08:09 WikiStart edited by pewtermoose@gmail.com
05:30 WikiStart edited by zimmermann@kde.org
00:52 Changeset [18105] by hyatt

Fix WebKit forwarding headers for mac.

00:35 Changeset [18104] by hyatt

Update forwarding headers in WebCore to reflect wtf/unicode/icu dir structure.

00:34 Changeset [18103] by hyatt

Fix mac bustage (more still).

00:33 Changeset [18102] by hyatt

Fix mac bustage (maybe).

00:32 Changeset [18101] by hyatt

Fix mac bustage (maybe).

00:29 Changeset [18100] by hyatt

Fix mac bustage (maybe).

Note: See TracTimeline for information about the timeline view.