Timeline


and

12/15/06:

18:50 Changeset [18244] by bdash

2006-12-15 MorganL <morganl.webkit@yahoo.com>

Reviewed by Oliver.

Allow images to load into frames again. Tidy up code a bit and
add some much needed documentation.

  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes):
  • platform/MimeTypeRegistry.h:
17:50 Changeset [22675] by andersca
  • platform/win/TemporaryLinkStubs.cpp: Remove DocumentLoader::isStopped because it's now in DocumentLoader.cpp.
16:41 Changeset [18243] by andersca

Fix build.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::mainDocumentError):
  • loader/DocumentLoader.h:
16:05 Changeset [18242] by andersca

WebCore:

Reviewed by Geoff.

More loader cleanup.

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::setResponse):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):

WebKit:

Reviewed by Geoff.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
  • WebView/WebDataSource.mm: (-[WebDataSource response]):
14:58 Changeset [18241] by andersca
  • loader/DocumentLoader.h: Whoops, didn't mean to commit this.
14:57 Changeset [18240] by andersca

Reviewed by Darin and Brady (in no particular order).


More loader cleanup.


  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm:
14:24 Changeset [22674] by ggaren

I'm in ur prjct, fxng ur build.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadResourceSynchronously):
14:02 Changeset [18239] by ap

Try to fix Windows build: add EventTarget.{h,cpp}.

13:49 Changeset [18238] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11610
XMLHttpRequest.onreadystatechange doesn't provide access to the request object

Created a separate EventTarget class, now that EventTargetNode isn't the only kind.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Added an EventTarget variant.
  • bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.
  • bindings/objc/DOM.mm: (+[DOMNode _eventTargetWith:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm: Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal). It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest. Corrected spelling of internalHeaderContent.
  • dom/Event.cpp: (WebCore::Event::setTarget):
  • dom/Event.h: (WebCore::Event::target): (WebCore::Event::currentTarget): (WebCore::Event::setCurrentTarget): These methods now work with EventTargets instead of Nodes.
  • dom/EventTarget.cpp: Added. (WebCore::EventTarget::~EventTarget): (WebCore::EventTarget::toNode): (WebCore::EventTarget::toXMLHttpRequest):
  • dom/EventTarget.h: Added. (WebCore::EventTarget::ref): (WebCore::EventTarget::deref): Originally, my intention was to share much of the implementation between EventTargetNode and XHR, but now I don't see anything substantial worth sharing.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.
  • dom/EventTargetNode.h: Made EventTarget methods virtual. (WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget. (WebCore::EventTargetNode::refEventTarget): (WebCore::EventTargetNode::derefEventTarget):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): Cast from EventTarget to Node as appropriate.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener): Set target and currentTarget before dispatching.
  • xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter to match EventTargetNode. (WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget. (WebCore::XMLHttpRequest::refEventTarget): (WebCore::XMLHttpRequest::derefEventTarget):

LayoutTests:

  • fast/dom/xmlhttprequest-get-expected.txt:
  • http/tests/xmlhttprequest/event-target-expected.txt:
  • http/tests/xmlhttprequest/event-target.html:
13:08 Changeset [18237] by andersca

WebCore:

Reviewed by Darin.

More loader cleanup, use KURL instead of NSURL in a couple of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willUseArchive):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):

WebKit:

Reviewed by Darin.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive):
  • WebView/WebDataSource.mm: (-[WebDataSource _URLForHistory]):
12:40 Changeset [18236] by ap

2006-12-15 Marvin Decker <marv.decker@gmail.com>

Reviewed by Darin and Alexey.

Fix the Windows build, move various Client implementations out of
WebCore and into WebKit.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: Removed.
  • bridge/win/ContextMenuClientWin.h: Removed.
  • bridge/win/EditorClientWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderClientWin.cpp: Removed.
  • loader/win/FrameLoaderClientWin.h: Removed.
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::DocumentLoader::URL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::~Pasteboard): (WebCore::PolicyCheck::call): (WebCore::PopupMenu::PopupMenu): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceLoader::cancel):

WebKit:

  • COM/ChromeClientWin.cpp: Added. (ChromeClientWin::~ChromeClientWin): (ChromeClientWin::chromeDestroyed): (ChromeClientWin::setWindowRect): (ChromeClientWin::windowRect): (ChromeClientWin::pageRect): (ChromeClientWin::scaleFactor): (ChromeClientWin::focus): (ChromeClientWin::unfocus): (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog): (ChromeClientWin::show): (ChromeClientWin::canRunModal): (ChromeClientWin::runModal): (ChromeClientWin::setToolbarsVisible): (ChromeClientWin::toolbarsVisible): (ChromeClientWin::setStatusbarVisible): (ChromeClientWin::statusbarVisible): (ChromeClientWin::setScrollbarsVisible): (ChromeClientWin::scrollbarsVisible): (ChromeClientWin::setMenubarVisible): (ChromeClientWin::menubarVisible): (ChromeClientWin::setResizable): (ChromeClientWin::addMessageToConsole):
  • COM/ChromeClientWin.h: Added.
  • COM/ContextMenuClientWin.cpp: Added. (ContextMenuClientWin::~ContextMenuClientWin): (ContextMenuClientWin::contextMenuDestroyed): (ContextMenuClientWin::addCustomContextMenuItems): (ContextMenuClientWin::contextMenuItemSelected): (ContextMenuClientWin::copyLinkToClipboard): (ContextMenuClientWin::downloadURL): (ContextMenuClientWin::copyImageToClipboard): (ContextMenuClientWin::lookUpInDictionary): (ContextMenuClientWin::speak): (ContextMenuClientWin::stopSpeaking):
  • COM/ContextMenuClientWin.h: Added.
  • COM/EditorClientWin.cpp: Added. (EditorClientWin::~EditorClientWin): (EditorClientWin::pageDestroyed): (EditorClientWin::shouldDeleteRange): (EditorClientWin::shouldShowDeleteInterface): (EditorClientWin::smartInsertDeleteEnabled): (EditorClientWin::isContinuousSpellCheckingEnabled): (EditorClientWin::toggleContinuousSpellChecking): (EditorClientWin::isGrammarCheckingEnabled): (EditorClientWin::toggleGrammarChecking): (EditorClientWin::spellCheckerDocumentTag): (EditorClientWin::selectWordBeforeMenuEvent): (EditorClientWin::isEditable): (EditorClientWin::shouldBeginEditing): (EditorClientWin::shouldEndEditing): (EditorClientWin::shouldInsertNode): (EditorClientWin::shouldInsertText): (EditorClientWin::shouldApplyStyle): (EditorClientWin::didBeginEditing): (EditorClientWin::respondToChangedContents): (EditorClientWin::didEndEditing): (EditorClientWin::registerCommandForUndo): (EditorClientWin::registerCommandForRedo): (EditorClientWin::clearUndoRedoOperations): (EditorClientWin::canUndo): (EditorClientWin::canRedo): (EditorClientWin::undo): (EditorClientWin::redo):
  • COM/EditorClientWin.h: Added.
  • COM/WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::initWithName):
  • COM/WebFrame.h:
  • COM/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::frameLoaderDestroyed): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent):
  • COM/WebFrameLoaderClient.h: Added.
  • COM/WebKitDLL.h:
  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

  • Spinneret/Spinneret.sln:
12:11 Changeset [18235] by andersca

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11842
REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history


  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URLForHistory): Don't return appleweburls without an unreachable url.
11:48 Changeset [18234] by andersca

WebCore:

Reviewed by Darin.

Replace more instances of NSError with ResourceError.


Also remove a check for a selector that was added pre-Tiger.


  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::cancelledError):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didCancel):

WebKit:

Reviewed by Darin.

Include ResourceError.h.


  • Plugins/WebNetscapePluginStream.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:31 Changeset [18233] by rwlbuis

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11824
CSSStyleSheet.title property is always null

Set title on the stylesheet just after creating it, for the HTML
elements <link> and <style>.

04:26 Changeset [18232] by zack

Fix compilation (from lars)

12/14/06:

23:50 Changeset [22673] by ggaren

ChangeLog fixup

23:46 Changeset [22672] by ggaren

Reviewed by NOBODY (OOPS!).

WARNING: NO TEST CASES ADDED OR CHANGED

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe):
20:10 Changeset [22671] by adele

Reviewed by Adam.

Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):
20:04 Changeset [18231] by andersca

WebCore:

Reviewed by Maciej.

Use char* pointer + length instead of NSData in a bunch of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData):
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::committedLoad):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::didReceiveData):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveData):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

Reviewed by Maciej.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::deliverArchivedResources):
  • WebView/WebView.mm: (-[WebView _incrementProgressForIdentifier:length:]):
  • WebView/WebViewInternal.h:
20:02 Changeset [18230] by adele

Reviewed by Adam.

Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.

  • platform/PopupMenu.h: (WebCore::PopupMenuClient::~PopupMenuClient): (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed. (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList. (WebCore::PopupMenu::client): Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList. (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer. (WebCore::PopupMenu::show): ditto. (WebCore::PopupMenu::hide): ditto.
  • rendering/RenderMenuList.h: Now also inherits from PopupMenuClient. (WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient(). (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent can add children, and you don't want to do that in the middle of calculating width. (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list. (WebCore::RenderMenuList::itemIsEnabled): ditto. (WebCore::RenderMenuList::itemStyle): ditto. (WebCore::RenderMenuList::clientStyle): ditto. (WebCore::RenderMenuList::clientDocument): ditto. (WebCore::RenderMenuList::clientPaddingLeft): ditto. (WebCore::RenderMenuList::clientPaddingRight): ditto. (WebCore::RenderMenuList::listSize): ditto. (WebCore::RenderMenuList::selectedIndex): ditto. (WebCore::RenderMenuList::itemIsSeparator): ditto. (WebCore::RenderMenuList::itemIsLabel): ditto. (WebCore::RenderMenuList::itemIsSelected): ditto. (WebCore::RenderMenuList::setTextFromItem): ditto.
19:43 Changeset [18229] by ggaren

LayoutTests:

Updated these results now that I've rolled out my change to move focus
to the page level:


  • editing/undo/undo-iframe-location-change-expected.txt:
  • fast/forms/focus2-expected.txt:


Added this test for one of the regressions that moving focus to the page
level caused:


  • editing/selection/inactive-selection-expected.txt: Added.
  • editing/selection/inactive-selection.html: Added.

WebCore:

Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text


Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window


I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).


Hopefully we can revisit this, along with hover and active, in the future.

  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::relinquishesEditingFocus): (WebCore::acceptsEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::focusedNodeDetached): (WebCore::Document::setFocusedNode):
  • dom/Document.h: (WebCore::Document::focusedNode):
  • page/FocusController.cpp:
  • page/FocusController.h:
19:34 Changeset [22670] by sfalken

Bump version for submit

19:27 Changeset [18228] by sfalken

New tag.

19:14 Changeset [18227] by mjs

Reviewed by Geoff.

  • fix failing drag & drop layout tests
  • platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into nil.
18:25 Changeset [18226] by thatcher

Reviewed by Darin.

<rdar://problem/4827549> need NSRange-based selection support exposed.

  • WebView/WebFrame.mm: (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]):
  • WebView/WebFramePrivate.h:
18:18 Changeset [22669] by sfalken

2006-12-14 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (SubresourceLoader::didCancel):
17:30 Changeset [18225] by sfalken

2006-12-14 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • loader/MainResourceLoader.h:
17:24 Changeset [18224] by bdash

2006-12-14 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-11-14 Alexey Proskuryakov <ap@webkit.org>

Reviewed by Tim H.

http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

  1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
  1. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

  • WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
  • WebView/WebHTMLViewInternal.h:
16:58 Changeset [22668] by sfalken

2006-12-14 Steve Falkenburg <sfalken@apple.com>

B&I build fix. Added JSSVGPODTypeWrapper.h to the vcproj.

  • WebCore.vcproj/WebCore.vcproj:
16:41 Changeset [18223] by andersca

WebCore:

Reviewed by John.

Convert a bunch of NSErrors to ResourceError.


Make the ResourceError accessor functions const.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::didFail):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceError.h: (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

Reviewed by John.

Update for WebKit changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack):
16:10 Changeset [18222] by staikos

Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

15:48 Changeset [22667] by adele

Reviewed by Adam.

Build Fix.

  • WebContextMenuClient.h:
15:40 Changeset [22666] by aroben

Reviewed by Adele.

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::URL): (ResourceHandle::loadResourceSynchronously):
15:30 Changeset [18221] by justing

LayoutTests:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

  • editing/deleting/4866671-expected.checksum: Added.
  • editing/deleting/4866671-expected.png: Added.
  • editing/deleting/4866671-expected.txt: Added.
  • editing/deleting/4866671.html: Added.
  • editing/pasteboard/4866671-expected.checksum: Added.
  • editing/pasteboard/4866671-expected.png: Added.
  • editing/pasteboard/4866671-expected.txt: Added.
  • editing/pasteboard/4866671.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()


Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.

  • dom/Document.cpp: (WebCore::Document::updateSelection):
  • dom/Position.cpp: (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::nodeIsUserSelectNone): (WebCore::Position::isCandidate): (WebCore::Position::rendersInDifferentPosition):
  • dom/Position.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousCandidate): (WebCore::previousVisuallyDistinctCandidate):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph):
  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart):
15:16 Changeset [18220] by hyatt

Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.

Reviewed by ggaren

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):
14:13 Changeset [18219] by andersca

Reviewed by John.


General loader cleanup, convert NSURLResponse to ResourceResponse in some places.


  • loader/DocumentLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::addResponse):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::opened):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
13:04 Changeset [22665] by andersca

Fix the build.


  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::loadResourceSynchronously): (ResourceHandle::loadResourceSynchronously):
12:56 Changeset [22664] by adachan

2006-12-14 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Implemented WebChromeClient::pageRect() to return the bounds of the WebView.
Implemented WebFrame::parentFrame().
Added a temporary implementation of WebDataSource::isLoading().

12:50 Changeset [18218] by andersca

Reviewed by Darin.

Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.

Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

Get rid of ServeSynchronousRequest and use the loader instead.


  • WebCore.exp:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/FrameLoader.h:
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm:
  • platform/network/ResourceError.h: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::isNull):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isConditional):
  • platform/network/ResourceRequest.h:
  • platform/network/mac/ResourceErrorMac.mm: (-[NSError WebCore]):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
12:42 Changeset [18217] by zimmermann

Reviewed by Darin.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11830

Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

11:30 Changeset [18216] by thatcher

top level:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
10:05 Changeset [18215] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
09:32 Changeset [18214] by hausmann

2006-12-14 Simon Hausmann <hausmann@kde.org>

Reviewed by Zack.

  • QtLauncher/QtLauncher.pro: Link this little test program with rpath, for convenience. (This is never going to get installed anyway)
08:47 Changeset [18213] by hausmann

2006-12-14 Simon Hausmann <hausmann@kde.org>

Reviewed by Zack Rusin.

  • WebCore.pro: Clean up the xpath grammar generation rule.
06:22 Changeset [18212] by zack

Make it link with temporary stubs (from lars, icefox)

03:40 Changeset [18211] by zack

Compilation fixes for the Qt port after last nights changes

02:36 Changeset [18210] by rwlbuis

Reviewed by Oliver.

http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing

Take into account the overflowRect when hit-testing <svg> container.

00:50 Changeset [18209] by bdash

2006-12-13 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-05-14 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.

12/13/06:

23:52 Changeset [18208] by hyatt

Fix for bug 11825, dragging elements via -khtml-user-drag is broken (affects Dashboard). Make sure
to clear the paintingRoot properly when recurring into children. It would be nice to find a design
that prevented this mistake from being made and didn't require explicit clearing of the root.

Reviewed by olliej

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paint):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
23:33 Changeset [18207] by bdash

2006-12-13 Mark Rowe <mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2005-09-06 David Hyatt <hyatt@apple.com>

Reduce the # of cached pages for a back/forward list. The old cache would cache the
following per tab:

1gb memory = 16 pages per tab/window
512mb memory = 8 pages per tab/window

<= 512mb memory = 4 pages per tab/window

This consumes far too much memory and is way too aggressive. The new cache sizes are
as follows:

1gb memory = 3 pages per tab/window

512mb memory = 2 pages per tab/window

< 512mb memory = 1 page per tab/window

Reviewed by john

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList pageCacheSize]):
  • WebView.subproj/WebPreferences.m: (+[WebPreferences initialize]):
17:30 Changeset [18206] by andersca
  • loader/FrameLoader.h: id is mac-only.
17:04 Changeset [22663] by andersca

Fix the build.


  • platform/win/TemporaryLinkStubs.cpp: (PolicyCheck::call): (DocumentLoader::URL):
15:34 Changeset [18205] by beidson

Implicitly reviewed by Darin, Hyatt, Maciej, and others!

Fixes a document tear down crash.
Changes a few long standing assertions to our new style

  • dom/Document.cpp: (WebCore::Document::~Document): (WebCore::Document::topDocument):
15:22 Changeset [18204] by mjs

Reviewed by Brady and Anders.

  • Makefile.shared: Stop spewing the environment all the time, at least for command-line builds.
15:20 Changeset [18203] by mjs

JavaScriptCore:

Reviewed by Anders.


  • added equality and inequality operations for HashMap and Vector, useful for comparing more complex types
  • wtf/HashMap.h: (WTF::operator==): (WTF::operator!=):
  • wtf/Vector.h: (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Anders.

  • converted many places to use ResourceRequest instead of NSURLRequest
  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck):
  • loader/FrameLoader.h: (WebCore::PolicyCheck::request):
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::originalRequest): (WebCore::DocumentLoader::originalRequestCopy): (WebCore::DocumentLoader::request): (WebCore::DocumentLoader::initialRequest): (WebCore::DocumentLoader::actualRequest): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::unreachableURL): (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLastCheckedRequest): (WebCore::DocumentLoader::lastCheckedRequest): (WebCore::DocumentLoader::URLForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::applyUserAgent): (WebCore::FrameLoader::originalRequest): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::initialRequest): (WebCore::FrameLoader::setRequest): (WebCore::FrameLoader::checkNavigationPolicy): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::checkNewWindowPolicy): (WebCore::FrameLoader::continueAfterNewWindowPolicy): (WebCore::FrameLoader::continueAfterNavigationPolicy): (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::post): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::isReloading): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::loadEmptyDocumentSynchronously): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::originalRequestURL): (WebCore::PolicyCheck::set): (WebCore::PolicyCheck::call): (WebCore::PolicyCheck::clearRequest):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy): (WebCore::MainResourceLoader::continueAfterNavigationPolicy): (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
  • loader/mac/WebDataProtocol.h:
  • loader/mac/WebDataProtocol.mm:
  • platform/KURL.cpp: (WebCore::operator!=):
  • platform/KURL.h:
  • platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL):
  • platform/network/FormData.h: (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceRequest.cpp: (WebCore::operator==):
  • platform/network/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):

WebKit:

Reviewed by Anders.


  • adjusted for changes from NSURLRequest to ResourceRequest
  • Plugins/WebPluginController.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): (WebFrameLoaderClient::startDownload): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDataSource.mm: (-[WebDataSource _initWithDocumentLoader:]): (-[WebDataSource initialRequest]): (-[WebDataSource request]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
  • WebView/WebFrame.mm: (-[WebFrame _createItem:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame loadArchive:]):
15:19 Changeset [22662] by ggaren

WebCoreWin:

Reviewed by Darin Adler, Dave Hyatt.


Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused


Minor problems remain with focus in frames, but basic editing / cursor
focus works.


I moved tracking of the focused frame from the Widget hiearchy to Page's
FocusController. Not all widgets are frames, so this change cleaned up a
dubious static cast. Also, the DOM needs to track frame focus because (1)
it needs to respond to focus changes and (2) you can focus an element /
frame even before it has a renderer / widget.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::focusDocumentView): Implemented. This function is poorly named, based on the Mac design. (WebCore::PluginViewWin::hasFocus): Added for completeness. It's not really used on Windows, though.

WebKitWin:

Reviewed by Darin Adler, Dave Hyatt.


Fixed <rdar://problem/4840261> Frame::setIsActive not called when frames
are focused/unfocused


Updated WebKit to use new FocusController tracking of the focused frame.


  • WebView.cpp: (WebViewWndProc): Fixed a minor bug where we wouldn't fire the blur event when changing focus to the location bar.
15:10 Changeset [18202] by ggaren

Reviewed by Darin Adler, Dave Hyatt.


Beefed up FocusController to handle frame focus. Changed implementors to
use FocusController, rather than the widget hierarchy, to focus frames.

(WebCore::FocusController::focusedNode): Made a minor change to focus a frame
before focusing the element inside of it. This matches FF.
(WebCore::FocusController::focusedFrame):

  • platform/Widget.h:
13:33 Changeset [18201] by justing

Reviewed by adele

<rdar://problem/4818145>
Cannot setSelectedDOMRange to non-editable island unless it has editable content on both sides


There are editable positions before/after a "non-editable island" if its
a table, but the code in canonicalPosition was not using
editableRootForPosition to find root editable elements.


  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Use editableRootForPosition to fix the table case.
13:08 Changeset [22661] by sfalken

Bump version for submit

13:01 Changeset [18200] by sfalken

New tag.

12:12 Changeset [22660] by sfalken

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Add WebCore forwarding headers to include paths

2006-11-14 Steve Falkenburg <sfalken@apple.com>

B&I build fix

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Add missing ForwardingHeaders to project

  • WebCore.vcproj/WebCore.make: Fixed line endings
  • WebCore.vcproj/WebCore.vcproj: Added missing headers
12:02 Changeset [18199] by sfalken

2006-12-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

Added missing forwarding headers.

  • ForwardingHeaders/kjs/value.h: Added.
  • ForwardingHeaders/wtf/HashTable.h: Added.
09:05 Changeset [18198] by ggaren

Updated results to match Justin Garcia's addition of rangeCount to
the selection object.


  • fast/dom/Window/window-properties-expected.txt:
06:45 Changeset [18197] by zack

Make qmake the default build environment for the Qt port.
CMake currently doesn't work and updates to qmake will happen
a lot faster. Review by Rob

05:16 Changeset [18196] by zack

make it compile after last nights changes from lars (r=maciej,me)

12/12/06:

23:02 Changeset [22659] by sfalken

2006-12-12 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

B&I build fix

  • WebCore.vcproj/build-generated-files.sh:
18:48 Changeset [22658] by aliceli1

Reviewed by Geoff.

Fixed <rdar://problem/4853199> extra whitespace at beginning and end of pasted fragment into contenteditable region


  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::documentFragment):
18:41 Changeset [22657] by aroben
18:34 Changeset [18195] by aroben

Reviewed by Anders.

Changed #import to #include to match the rest of our ForwardingHeaders.

  • ForwardingHeaders/wtf/StringExtras.h:
17:46 Changeset [18194] by zbujtas

2006-12-11 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
17:41 Changeset [18193] by zbujtas

2006-12-12 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: TSW Id# EJXO-6UVDF5: The table cells border can't be displayed on the webpage
http://bugs.webkit.org/show_bug.cgi?id=11769

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/html4.css:
  • khtml/css/html4_gcce.css:
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::getSharedCellDecl):
17:23 Changeset [22656] by sfalken

Bump version for submit

17:16 Changeset [18192] by sfalken

New tag.

16:48 Changeset [18191] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4757667>
GoogleDocs: Style menu does not open


  • editing/selection/rangeCount-expected.txt: Added.
  • editing/selection/rangeCount.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4757667>
GoogleDocs: Style menu does not open

  • bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): Added rangeCount.
  • bindings/js/kjs_window.h: (KJS::Selection::):
  • editing/SelectionController.h: (WebCore::SelectionController::rangeCount): Added.
15:58 Changeset [18190] by aliceli1

Reviewed by Oliver.

  • bindings/js/JSSVGMatrixCustom.cpp: added #ifdef SVG_SUPPORT
15:45 Changeset [18189] by andersca

Suggested by Darin.

  • loader/ResourceLoader.cpp: Move down include of ResourceHandle.h.
15:30 Changeset [18188] by ggaren

Fixing up svn properties on FocusController.*

14:19 Changeset [22655] by ggaren

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.

Added FocusController to project.

  • WebCore.vcproj/WebCore.vcproj:
14:11 Changeset [18187] by ggaren

Reviewed by Adam Roben, Dave Hyatt, Darin Adler.


Factored focus control into a FocusController class. I inted to use this
class for handling window active state and the focused frame, as well.

Layout tests pass.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::view): (WebCore::Document::page): New helper function.
  • dom/Document.h: Moved setters before getters. (WebCore::Document::hoverNode): (WebCore::Document::activeNode):
  • dom/Node.cpp: (WebCore::Node::detach): Use the FocusController.
  • page/FocusController.cpp: Added. (WebCore::shouldFocus): renamed and refactored this helper function. (WebCore::shouldUnfocus): ditto.
  • page/FocusController.h: Added.
14:03 Changeset [18186] by andersca

Rubber Stamped by Geoff.

  • platform/Base64.cpp:
  • platform/Base64.h: Put functions inside of the WebCore namespace.
13:50 Changeset [22654] by andersca

WebCoreWin:

  • loader/win/ResourceLoaderWin.cpp:
  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadsBlocked): Update for changes to ResourceHandle.

WebKitWin:

  • WebFrame.cpp: (WebFrame::loadDataSource): Update for changes to ResourceHandle.
13:42 Changeset [18185] by andersca

Try fixing the non-Mac builds.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • loader/SubresourceLoader.h:
13:14 Changeset [18184] by andersca

WebCore:

Reviewed by Darin.

Turn ResourceLoader into a ResourceHandleClient and stop using NSURLConnection in the loader.

  • WebCore.exp: Add new methods needed by WebKit.


  • WebCore.xcodeproj/project.pbxproj: Make ResourceHandle.h a private header.


  • loader/FrameLoaderClient.h: Change the download method to take a ResourceHandle instead of an NSURLConnection.


  • loader/MainResourceLoader.h: Get rid of the proxy instance variable, that's handled by ResourceHandlw now.


  • loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::willCacheResponse): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation): (WebCore::ResourceLoader::handle):
  • loader/SubresourceLoader.h: Make ResourceLoader a ResourceHandleClient, moving the methods from SubresourceLoader.


  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load): Use a ResourceHandle instead of an NSURLConnection.


  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading): (WebCore::ResourceLoader::resourceData): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didReceiveResponse): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::didFinishLoading): (WebCore::ResourceLoader::didFail): Remove the WebCoreResourceLoaderAsDelegate class, use a ResourceHandle instead of an NSURLConnection.


  • loader/mac/SubresourceLoaderMac.mm: Remove ResourceHandleClient methods.


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal): Add an extra argument denoting whether this ResourceHandle can possibly be "converted" into one used for downloads.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::~ResourceHandle): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::releaseProxy): (WebCore::ResourceHandle::connection): New methods for creating a NSURLConnectionDelegateProxy which is used when creating a NSURLDownload from an existing connection.

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::download): Get the handle and proxy from the ResourceHandle now that they aren't passed to us.
12:13 Changeset [18183] by yongjzha

2006-12-12 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
12:09 Changeset [18182] by ap

Reviewed by Geoff. Based on a patch by Maks Orlovich.

http://bugs.webkit.org/show_bug.cgi?id=6257
Throw errors on invalid expressions (KJS merge)

JavaScriptCore:

  • kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
  • kjs/regexp.h: (KJS::RegExp::flags): (KJS::RegExp::isValid): (KJS::RegExp::errorMessage): (KJS::RegExp::subPatterns): Remember and report RegExp construction failures. Renamed data members not to start with underscores.
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Raise an exception if RegExp construction fails. (RegExpObjectImp::callAsFunction): Removed an obsolete comment.
  • tests/mozilla/ecma_3/RegExp/regress-119909.js: Reduced the number of nested parentheses to a value supported by PCRE.

LayoutTests:

  • fast/js/kde/RegExp-expected.txt: One more test passes.
11:50 SVG TODO List - Short notes edited by ojh16@student.canterbury.ac.nz
text+filter stuff (diff)
11:42 Changeset [18181] by andersca

Reviewed by Geoff.

  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::load):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): Move the didTellBridgeAboutLoad call to SubresourceLoader in preparation for getting rid of the DocLoader parameter to ResourceHandle::create.
11:41 Changeset [22653] by darin
  • fix build
  • WebCore.vcproj/WebCore.vcproj: Added missing files, removed obsolete files.
11:32 Changeset [18180] by ggaren

Oops. Forgot to check in this file.

09:52 SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
09:01 Changeset [18179] by spadma

2006-12-11 sareen <shyam.sareen@nokia.com>

Reviewed Sachin Padma.
DESC: Saved Pages: Some Images not saved with the page.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11721

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/UrlRequestInfo.h: (CUrlRequestInfo::IsSavedPageRequest): (CUrlRequestInfo::SetSavedPageRequest):
  • ResourceLoader/src/MultipartContentHandler.cpp: (CMultipartContentHandler::HandleMultipartMixedL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::CUrlRequestInfo): (CUrlRequestInfo::~CUrlRequestInfo): (CUrlRequestInfo::SetPostDataL):
04:09 Changeset [18178] by staikos

Make the last checkin compile

03:19 Changeset [18177] by zimmermann

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11797

Remove SVGMatrix, replace it by AffineTransform usage everywhere.
Changed AffineTransform API to be able to be used within generation
(m11() -> a(), m12() -> b(), ...). Add some methods needed for SVG.

01:55 Changeset [18176] by staikos

Fix the Qt build

01:02 Changeset [18175] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Added some focus-related tests.

  • editing/undo/undo-iframe-location-change-expected.txt: Updated to reflect the fact that we now unfocus nodes when they're removed from the document.
  • fast/events/keypress-removed-node-expected.txt: Added.
  • fast/events/keypress-removed-node.html: Added.
  • fast/forms/focus2-expected.txt: Added.
  • fast/forms/focus2.html: Added.

WebCore:

Reviewed by Beth Dakin.


Moved focus control to the page level. Fixed a minor bug where a node
would retain keyboard focus even when removed from the document.


We should probably move this, along with hover and active, into a separate
FocusController. But I'm too tired right now.

  • dom/Document.cpp: Migrated code to Page (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::setFocusedNode): (WebCore::Document::focusedNode):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::detach): Clear ourselves from keyboard focus. This fixes the minor bug and was also necessary to prevent regressions caused by hanging on to a focused node after the document was replaced.
  • dom/Node.h: (WebCore::Node::inDetach):
  • page/Page.cpp: Migrated code from Document (WebCore::shouldAcquireEditingFocus): (WebCore::shouldRelinquishEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::widgetForNode): (WebCore::Page::setFocusedNode):
  • page/Page.h: (WebCore::Page::focusedNode):
00:45 Changeset [18174] by ggaren

build fix

00:28 Changeset [18173] by ap

Added the new XHR EventTarget methods to test results.

  • fast/dom/Window/window-properties-expected.txt:

12/11/06:

23:59 Changeset [18172] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11053
XMLHttpRequest should be an EventTarget

Test: http/tests/xmlhttprequest/event-target.html

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::mark): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h: (KJS::JSXMLHttpRequest::):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener):
  • xml/xmlhttprequest.h: (WebCore::XMLHttpRequest::eventListeners): Implement EventTarget methods (except for NS variations, which Firefox doesn't have either).
23:28 Changeset [22652] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added missing files to project.
23:13 Changeset [22651] by sfalken

B&I build fix

23:13 Changeset [18171] by darin

Reviewed by Geoff.

DocumentType objects were getting filed under the wrong document in the
DOM objects structure.

  • bindings/js/kjs_binding.h: Added a destructor for debugging purposes only.
  • bindings/js/kjs_binding.cpp: (KJS::wrapperSet): Added. Set of outstanding wrappers for debugging. (KJS::addWrapper): Added. (KJS::removeWrapper): Added. (KJS::removeWrappers): Added. (KJS::DOMObject::~DOMObject): Added. Asserts that there is no outstanding reference to this wrapper since it's being destroyed. (KJS::ScriptInterpreter::putDOMObject): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetDOMObject): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Added a call to REMOVE_WRAPPER. (KJS::ScriptInterpreter::putDOMNodeForDocument): Added a call to ADD_WRAPPER. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Added a call to REMOVE_WRAPPERS. (KJS::ScriptInterpreter::updateDOMNodeDocument): Added calls to REMOVE_WRAPPER and ADD_WRAPPER so the out-of-order transaction doesn't upset the assertions in the functions we're calling. Another solution would be to reorder the two, but I think that would create a race where another thread could garbage collect after the forget but before the put. (KJS::ScriptInterpreter::wasRunByUserGesture): Tweaked formatting.
  • dom/Document.cpp: (WebCore::Document::adoptNode): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
  • dom/Node.cpp: (WebCore::Node::setDocument): Added call to updateDOMNodeDocument here. (WebCore::Node::checkAddChild): Removed call to updateDOMNodeDocument since setDocument now takes care of that.
22:47 Changeset [18170] by ap

http://bugs.webkit.org/show_bug.cgi?id=9673
Add support for window.atob() and window.btoa()

Reviewed by Darin.

JavaScriptCore:

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added Base64.{h,cpp}
  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • platform/Base64.cpp: Added. (base64Encode): (base64Decode):
  • platform/Base64.h: Added.
  • ForwardingHeaders/wtf/StringExtras.h: Added.
  • platform/DeprecatedString.cpp: Use strncasecmp from StringExtras.

LayoutTests:

  • fast/dom/Window/atob-btoa-expected.txt: Added.
  • fast/dom/Window/atob-btoa.html: Added.
  • fast/dom/Window/btoa-pnglet-expected.checksum: Added.
  • fast/dom/Window/btoa-pnglet-expected.png: Added.
  • fast/dom/Window/btoa-pnglet-expected.txt: Added.
  • fast/dom/Window/btoa-pnglet.html: Added.
  • fast/dom/Window/window-properties-expected.txt:
22:34 Changeset [22650] by sfalken

2006-12-11 Steve Falkenburg <sfalken@apple.com>

B&I build fix.
Remove platform/UChar.h from our vcproj, since it doesn't exist anymore.

  • WebCore.vcproj/WebCore.vcproj:
21:56 Changeset [18169] by darin

WebCore:

Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCore.xcodeproj/project.pbxproj: Updated project for file moves.
  • bridge/mac/FrameMac.h: Moved to page/mac.
  • bridge/mac/FrameMac.mm: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Ditto.
  • bridge/mac/WebCoreFrameView.h: Ditto.
  • bridge/mac/WebCoreViewFactory.h: Ditto.
  • bridge/mac/WebCoreViewFactory.m: Ditto.
  • bridge/mac/WebDashboardRegion.h: Ditto.
  • bridge/mac/WebDashboardRegion.m: Ditto.
  • bridge/mac/WebCoreKeyboardAccess.h: Moved to page/mac, renamed WebCoreKeyboardUIMode.h, and made a C++ header.
  • page/EventHandler.h: Updated for change to WebCoreKeyboardAccess.
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): Ditto. (WebCore::EventHandler::tabsToAllControls): Ditto. (WebCore::EventHandler::keyboardUIMode): Ditto.

WebKit:

Reviewed by Brady.

  • did some of the Mac-specific file moves mentioned in my recent mail to the WebKit list
  • WebCoreSupport/WebFrameBridge.h: Updated for change to WebCoreKeyboardAccess.
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Ditto. (-[WebFrameBridge keyboardUIMode]): Ditto.
21:47 Changeset [18168] by darin

Reviewed by Brady.

  • JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode update this (I think Hyatt is using an old Xcode).
21:03 Changeset [18167] by darin
  • fast/frames/iframe-option-crash-expected.txt: Updated results for this test. My recent change to owner element lifetime management changed these results, but since the point of the test is simply to check if the page crashes, the new result is probably OK. Or there could be some problem, but if so we need some other investigation -- I couldn't see anything.
20:44 Changeset [22649] by bdakin

Boomer WebKit support for editing sub-menu actions for WebCore
context menus.

  • Interfaces/IWebUIDelegate.idl: Re-named some of the spelling sub-menu tags.
  • WebContextMenuClient.cpp: New functions for the speech sub-menu. (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebContextMenuClient.h:
  • WebEditorClient.cpp: New functions to toggle spelling/grammar checking. (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebEditorClient.h
20:27 Changeset [18166] by bdakin

WebCore:

Reviewed by Adam.

Primarily, this patch implements/hooks-up actions for the sub-menu
items in WebCore context menus. I fixed a few other things along
the way too:

-Made BUILDING_ON_TIGER ifdef work within C++ as well as

Obj-C

-Fixed bug where we would throw and Obj-C exception and

fail to pop up menus with more than one separator item.

-Re-named some of the spelling/grammar tags since Tiger and

Leopard share more of the actions than initially
anticipated.

  • WebCorePrefix.h: Make BUILDING_ON_TIGER available to C++
  • bridge/EditorClient.h: New functions to toggle spelling/grammar checking.
  • editing/Editor.cpp: (WebCore::Editor::toggleContinuousSpellChecking): Call into client. (WebCore::Editor::toggleGrammarChecking): Same. (WebCore::Editor::toggleBold): call execToggleBold() (WebCore::Editor::toggleUnderline): Create appropriate underline style and apply to selection. (WebCore::Editor::setBaseWritingDirection): Create appropriate writing direction and apply to selection.
  • editing/Editor.h:
  • editing/mac/EditorMac.mm: New functions to show spelling guesses, fonts, styles, and color panels.
  • page/ContextMenuClient.h: New functions for the speech sub-menu.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Fill in editing sub-menu actions.
  • platform/ContextMenu.cpp: (WebCore::separatorItem): Helper function to create a separator item. (WebCore::createFontSubMenu): Put very mac-specific things within a platform ifdef. (WebCore::createSpellingAndGrammarSubMenu): Re-named some of the spelling sub-menu tags. (WebCore::createSpellingSubMenu): Same. (WebCore::ContextMenu::populate): We can't share the separator item. When we do, menus with more than one separator throw and obj- c exception and fail to pop-up.
  • platform/ContextMenuItem.h: (WebCore::): Re-named some of the spelling sub-menu tags.

WebKit:

Reviewed by Adam.

WebKit support for editing sub-menu actions.

  • WebCoreSupport/WebContextMenuClient.h: New functions for the speech sub-menu.
  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebCoreSupport/WebEditorClient.h: New functions to toggle spelling/grammar checking.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::toggleContinuousSpellChecking): (WebEditorClient::toggleGrammarChecking):
  • WebView/WebUIDelegatePrivate.h: Re-named some of the spelling sub-menu tags.
20:20 S60CheckoutAndBuild edited by thisisbradley@gmail.com
s60webkit path changes (diff)
19:26 Changeset [22648] by aliceli1

WebCoreWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work
And some cleanup of PlatformMouseEvent(Win)

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Removed unnecessary check for mouse event type


  • platform/win/PasteboardWin.cpp:


(WebCore::PasteboardOwnerWndProc):
(WebCore::createGlobalData):
Added more overloaded implemtations and renamed from createHandle


(WebCore::markupToCF_HTML):
Changed to handle less-specific input and renamed from createCF_HTML


(WebCore::urlToMarkup):
(WebCore::Pasteboard::writeURL):
Added these.


(WebCore::replaceNBSP):
Moved out of Pasteboard class


(WebCore::Pasteboard::clear):
Renamed from clearTypes.


(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::plainText):
(WebCore::Pasteboard::documentFragment):
Trivial cleanup of these.


  • platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Removed anything having to do with unnecessary m_type

WebKitWin:

Reviewed by ggaren.

Fixed <rdar://problem/4854901> "Copy Link" and "Copy Image Address" context menu items don't work

  • Interfaces/IWebView.idl: Added copyURL.


  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h: Removed copyLinkToClipboard


  • WebView.cpp: (WebView::copy): (WebView::cut): (WebView::paste): Trivial cleanup of these


(WebView::copyURL):
Added this.


  • WebView.h: Added copyURL.
19:17 Changeset [18165] by aliceli1

WebCore:

Reviewed by Geoff, Adam.

Switch to use the Editor for copying URLs. Also some Pasteboard and PlatformMouseEvent cleanup.

All layout tests pass as they would without this patch.

  • WebCore.exp: added Editor::copyURL to be called from WebKit


  • editing/Editor.cpp: (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Pasteboard::clearTypes() changed to clear()

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::cut):
(WebCore::Editor::copy):
Changed signature of writeSelection to take raw pointer instead of PassRefPtr

(WebCore::Editor::copyURL):

  • editing/Editor.h: Added copyURL.


  • page/ContextMenuClient.h:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Removed copyLinkToClipboard


  • platform/KURL.cpp: (WebCore::KURL::lastPathComponent):
  • platform/KURL.h: Added lastPathComponent.


  • platform/Pasteboard.h: Changed some function names. Moved some functions out of class to static.


  • platform/PlatformMouseEvent.h: (WebCore::): Removed MouseEventType enum, added NoButton to MouseButton without disturbing other button values.


  • platform/mac/PasteboardMac.mm: Added writeURL, and moved some things around


  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Add some calls necessary for Pasteboard::writeURL to work

WebKit:

Reviewed by Geoff, Adam.


switch to use the Editor for copying URLs

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate copyLinkToClipboard:]): Call down to the editor for this.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Add some calls necessary for Pasteboard::writeURL to work
17:26 Changeset [18164] by zimmermann

Update SVG pixel tests - hasn't been done for a long time.
Mainly tiny text related positioning changes, all fine.

15:50 SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
15:47 Changeset [22647] by darin

WebCoreWin:

Reviewed by Brady.

  • WebCore.vcproj/WebCore.vcproj: Update for added files.
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::createFrame): Changed to use HTMLFrameOwnerElement.
  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::load): Changed to use HTMLFormElement.

WebKitWin:

Reviewed by Brady.

  • WebFrame.h:
  • WebFrame.cpp: (WebFrame::initWithWebFrameView): Changed to use HTMLFrameOwnerElement. (WebFrame::createFrame): Ditto.
15:40 Changeset [18163] by darin

WebCore:

Reviewed by Brady.

  • CMakeLists.txt:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Updated for new source files.
  • WebCore.exp: Updated for changes to entry point names.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
  • bridge/win/FrameWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): Updated owner element type to HTMLFrameOwnerElement.
  • bridge/mac/WebCoreFrameBridge.h: Removed non-C++ case since we don't use that any more. Updated owner element type to HTMLFrameOwnerElement.
  • dom/Document.cpp: Added include so that the ownerElement function can compile (since it downcasts an HTMLFrameOwnerElement to an Element).
  • html/HTMLFrameElement.cpp: (WebCore::containingFrameSetElement): Moved this function in here; it doesn't need to be a member function. (WebCore::HTMLFrameElement::attach): Updated to call this.
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Inherit from HTMLFrameOwnerElement. Removed contentFrame, contentDocument, and containingFrameSetElement. Removed friend classes.
  • html/HTMLFrameOwnerElement.h: Added.
  • html/HTMLFrameOwnerElement.cpp: Added.
  • html/HTMLEmbedElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: Remove now-unneeded contentDocument functions.
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Inherit from HTMLFrameOwnerElement.
  • loader/FormState.h:
  • loader/FormState.cpp: Use HTMLFormElement instead of just Element.
  • loader/FrameLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): Use HTMLFormElement. (WebCore::FrameLoader::loadSubframe): Ditto. (WebCore::FrameLoader::requestObject): Don't pass an element parameter to shouldUsePlugin, and remove now-unneeded type casts. (WebCore::FrameLoader::shouldUsePlugin): Removed unneeded element parameter. (WebCore::FrameLoader::handleFallbackContent): Use HTMLFrameOwnerElement. (WebCore::FrameLoader::updateBaseURLForEmptyDocument): Ditto. (WebCore::FrameLoader::isHostedByObjectElement): Ditto.
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): Use HTMLFormElement. (WebCore::FrameLoader::post): Ditto. (WebCore::FrameLoader::createFrame): Use HTMLFrameOwnerElement.
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/Frame.cpp: (WebCore::parentFromOwnerElement): Use HTMLFrameOwnerElement. (WebCore::Frame::Frame): Ditto. Also set m_contentFrame on the owner element. (WebCore::Frame::ownerElement): Ditto. (WebCore::Frame::ownerRenderer): Ditto. (WebCore::Frame::disconnectOwnerElement): Clear m_contentFrame on the owner element before disconnecting it. (WebCore::FramePrivate::FramePrivate): Use HTMLFrameOwnerElement.
  • page/mac/EventHandlerMac.mm: Include HTMLFrameOwnerElement.h so that the code here will compile (no code changes needed).
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • rendering/RenderPart.h:
  • rendering/RenderPart.cpp: (WebCore::RenderPart::RenderPart): Use HTMLFrameOwnerElement.
  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::RenderPartObject): Use HTMLFrameOwnerElement. (WebCore::RenderPartObject::viewCleared): Updated so that RenderFrame doesn't need to be a friend of HTMLFrameElementBase.
  • other changes
  • platform/network/ResourceHandleInternal.h: Added Noncopyable and fixed indentation.

WebKit:

Reviewed by Brady.

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:WebCore::frameName:frameView:ownerElement:]): (-[WebFrameBridge initSubframeWithOwnerElement:frameName:frameView:]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]): Use HTMLFrameOwnerElement.
  • WebCoreSupport/WebFrameLoaderClient.mm: Include the relevant headers for the HTMLFormElement class.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode have its way.
  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Update includes and types for the change in return type of ownerElement.
15:11 Changeset [18162] by hyatt

Fix failing layout test. Remove WTF::Unicode::isSpace and just revert
the caller to the old behavior.

Reviewed by darin

  • platform/StringImpl.cpp: (WebCore::isSpace):
15:10 Changeset [18161] by hyatt

Fix the failing layout test. Just remove Unicode::isSpace and
revert StringImpl to do the same thing it was doing before.

Reviewed by darin

  • wtf/unicode/icu/UnicodeIcu.h:
  • wtf/unicode/qt4/UnicodeQt4.h:
15:00 Changeset [22646] by lamadio

2006-12-08 Lou Amadio <lamadio@apple.com>

Reviewed by aroben,adachan
Implement Status Bar
<rdar://4601297> Status Bar feature
<rdar://4854036> subsequent windows have glass borders on vista
<rdar://4861165> Window cascade is off
<rdar://4804690> Window widgets clip highligh

14:51 Changeset [22645] by hyatt

Fix build bustage.

14:06 Changeset [18160] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: remove the dependency on CAknSettingsCache
http://bugs.webkit.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
13:54 Changeset [18159] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: add flag to remove the SDK dependency on AknSettingsCache
http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
12:49 Changeset [22644] by bdakin

Reviewed by Adam.

Build fix from Nick Zimmerman's last check-in.

  • WebCore.vcproj/WebCore.vcproj:
12:13 Changeset [18158] by ap

Reviewed by Adam.

http://bugs.webkit.org/show_bug.cgi?id=11807
Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::autoscrollTimerFired):
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::mouseMoved): Merge EventHandler::m_bMousePressed and EventHandler::m_mousePressed

(WebCore::EventHandler::lastEventIsMouseUp):
Check that the "new" event is newer than the "old" one - that's not always the case
when running in DRT, as [NSApp currentEvent] isn't updated by eventSender.

12:13 Changeset [18157] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
http://bugzilla.opendarwin.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
11:47 Changeset [18156] by yongjzha

2006-12-11 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: Hebrew chracters become mirrored and aligned to the left when search field is not in focus
http://bugs.webkit.org/show_bug.cgi?id=11806

  • BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::Draw): (CFormInputSkin::SetText):
10:52 Changeset [18155] by zimmermann

I forgot to remove these in the previous commit, they were only emptied out.

10:03 Changeset [18154] by harrison

Fix previous checkin where I committed the wrong file.

<rdar://problem/4863611> Xyle Scope crashes at launch due to WebCore-521.29.3

  • WebView/WebFrame.mm: (-[WebFrame frameElement]): Add nil check.


  • WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]): Reverted to previous.
09:55 Changeset [18153] by zimmermann

Reviewed by Sam Weinig.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=11801

Autogenerate POD types for ObjC/JS.

This removes the need for the hand-written JSSVG*, DOMSVG* wrappers
in bindings/js, bindings/objc. Makes it much easier to convert more
SVG types to POD types (ie. SVGMatrix* -> AffineTransform etc.)

08:48 Changeset [18152] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by <yongjun.zhang@nokia.com>
DESC: TSW ID:EYWG-6W7AGP-LSK and RSK are all displayed as YES after accessing the given link
http://bugs.webkit.org/show_bug.cgi?id=11776

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall):
08:42 Changeset [18151] by yongjzha

2006-12-08 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: TSW Id: PNIO-6TF99Y: "system error" is displayed for http status code 301
http://bugs.webkit.org/show_bug.cgi?id=11787

  • BrowserView/inc/HttpLoaderEventToUiListener.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ReportHttpError):
  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::Complete):
  • ChangeLog:
08:24 Changeset [18150] by ap

Reviewed by Mitz.

Make this test faster by eliminating timeouts (which didn't work anyway, now that
mouse dragging events are stored and replayed on mouse-up).

  • fast/text/atsui-rtl-override-selection.html:
Note: See TracTimeline for information about the timeline view.