Timeline


and

01/03/07:

23:48 Changeset [18576] by lars
  • 2 edits in trunk/WebCore

fix the Qt build

22:36 Changeset [18575] by bdash
  • 4 edits in trunk/LayoutTests

2007-01-03 Mitz Pettel <mitz@webkit.org>

Reviewed by Mark Rowe.

  • css1/box_properties/acid_test-expected.checksum:
  • css1/box_properties/acid_test-expected.png:
  • css1/box_properties/acid_test-expected.txt:
21:28 Changeset [18574] by ddkilzer
  • 37 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.checksum:
  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.checksum:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • css2.1/t09-c5526c-display-00-e-expected.checksum:
  • css2.1/t09-c5526c-display-00-e-expected.png:
  • css2.1/t09-c5526c-display-00-e-expected.txt:
  • fast/block/basic/011-expected.checksum:
  • fast/block/basic/011-expected.png:
  • fast/block/basic/011-expected.txt:
  • fast/css/percentage-non-integer-expected.checksum: Added.
  • fast/css/percentage-non-integer-expected.png: Added.
  • fast/css/percentage-non-integer-expected.txt: Added.
  • fast/css/percentage-non-integer.html: Added.
  • tables/mozilla/bugs/bug4385-expected.checksum:
  • tables/mozilla/bugs/bug4385-expected.png:
  • tables/mozilla/bugs/bug4385-expected.txt:
  • tables/mozilla_expected_failures/core/col_span2-expected.checksum:
  • tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Hyatt.

Test: fast/css/percentage-non-integer.html

Added floating point constructor and accessors to Length for use with
Percent lengths only. The raw value of a percent length is the integer
part of a constant multiple of the original double value. The constant
is percentScaleFactor, which is currently 128.


Added assertions that the correct constructors and accessors are used
depending on the type: the double-based percent(), setValue() and Length()
for the Percent type, and the integer-based value(), setValue() and Length()
for all other types.


calcValue() and calcMinValue() work the same as before, regardless of the
type.

Added helpers for testing if the value is 0, positive, negative or undefined
without having to check the type first.


Added raw value accessors. These are useful for doing integer math and
comparisons with scaled percent values or doing Length type-agnostic math.

Changed the rest of the code to use the appropriate accessors and helpers.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundSize): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • platform/StringImpl.cpp: (WebCore::parseLength):
  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):
  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::layout):
  • rendering/Length.h: (WebCore::Length::Length): (WebCore::Length::value): (WebCore::Length::rawValue): (WebCore::Length::percent): (WebCore::Length::setValue): (WebCore::Length::setRawValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::isUndefined): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative):
  • rendering/RenderBR.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelfCollapsingBlock):
  • rendering/RenderBox.cpp: (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/RenderLayer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::lineHeight):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::layout): Added FIXMEs.
  • rendering/RenderStyle.h: (WebCore::LengthBox::nonZero): (WebCore::RenderStyle::initialLineHeight):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows):
21:25 Changeset [18573] by bdash
  • 2 edits in tags/WebKit-521.32.1/WebKit

Versioning.

21:23 Changeset [18572] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css/content-dynamic-expected.checksum: Added.
  • fast/css/content-dynamic-expected.png: Added.
  • fast/css/content-dynamic-expected.txt: Added.
  • fast/css/content-dynamic.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css/content-dynamic.html

  • dom/Node.cpp: (WebCore::Node::diff): Changed to return 'Detach' if the styles' content data are not equivalent.
21:19 Changeset [18571] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/frames/negative-remaining-length-crash-expected.txt: Added.
  • fast/frames/negative-remaining-length-crash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/frames/negative-remaining-length-crash.html

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layOutAxis): Treat negative availableLength as zero.
18:17 Changeset [18570] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-03 Mark Rowe <bdash@webkit.org>

Reviewed by Anders.

  • Scripts/run-webkit-tests: Launch Safari using the same WebKit build configuration as the layout tests used.
18:01 Changeset [18569] by sullivan
  • 2 edits in trunk/WebCore

Written by Darin over my shoulder; reviewed by me

  • fixed <rdar://problem/4907437> Find doesn't work if invoked when a form field is focused
  • page/Frame.cpp: (WebCore::isInShadowTree): new helper function used by findString (WebCore::Frame::findString): when deciding whether to start from the selection, ignore selections that are in a shadow tree (i.e. in a form control)
17:21 Changeset [18568] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe

Fixes http://bugs.webkit.org/show_bug.cgi?id=12089

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit): Null check the documentLoader
17:20 Changeset [18567] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Tiger build fix: use [NSNumber initWithInt:] rather than the new [NSNumber initWithInteger:]
17:07 Changeset [18566] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css-generated-content

Add layout test for inline generated content.

17:07 Changeset [18565] by hyatt
  • 2 edits in trunk/WebCore

Relax the display type restriction a little bit for generated content inside
inlines. We still don't allow block display types like we should (since this
will cause a crash), but we at least handle inline-table and inline-block now.

Reviewed by beth

fast/css-generated-content/inline-display-types.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::updatePseudoChildForObject):
17:05 Changeset [18564] by justing
  • 4 edits in trunk

LayoutTests:

Reviewed by john

  • editing/pasteboard/merge-end-blockquote-expected.txt: A recent change caused an acceptable change in these expected results.

WebCore:

Reviewed by john


<rdar://problem/4663571> Spell checking won't cross boundary of individual To-Do item


No layout tests because advanceToNextMisspelling isn't yet exposed to automated tests.

  • editing/mac/EditorMac.mm: (WebCore::Editor::advanceToNextMisspelling): Confine spell checking to the highest editable root, instead of the lowest. Use firstEditablePosition... to look for an editable position.
16:57 Changeset [18563] by bdakin
  • 2 edits in trunk/WebCore

Fixing silly mistake.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Called wrong string function.
16:55 Changeset [18562] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed <rdar://problem/4145714> WebKit's PDFView's "Open in Preview" puts the PDF in /tmp, both group and world-readable
  • WebView/WebPDFView.mm: (-[WebPDFView _openWithFinder:]): Make the file only readable by the current user
16:53 Changeset [18561] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Anders

http://bugs.webkit.org/show_bug.cgi?id=12093 - Assertion in certain SVG layout tests
I can't really think of a cleaner way to fix this then to help these SVG cases avoid
the ASSERT - hopefully we can clean up the svg-as-image situation as the loader stabilizes
and we find better ways to handle it...

  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::urlForHistory): empty-check the url before passing it to the ASSERTing method
16:49 Changeset [22726] by darin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

  • removed some obsolete source files
  • WebCore.vcproj/WebCore.vcproj: Removed obsolete files.
16:40 Changeset [18560] by darin
  • 7 edits
    8 deletes in trunk/WebCore

Reviewed by Adele.

  • removed some obsolete source files
  • CMakeLists.txt: Removed obsolete files.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLGenericFormElement.h: Removed reference to RenderFormElement.
  • platform/qt/ComboBoxQt.cpp: Removed.
  • platform/qt/LineEditQt.cpp: Removed.
  • platform/qt/ListBoxQt.cpp: Removed.
  • platform/qt/TextEditQt.cpp: Removed.
  • rendering/RenderFormElement.cpp: Removed.
  • rendering/RenderFormElement.h: Removed.
  • rendering/RenderLabel.cpp: Removed.
  • rendering/RenderLabel.h: Removed.
16:27 Changeset [18559] by darin
  • 4 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for bug where :after content appeared in the wrong order
  • fast/css-generated-content/after-order-expected.checksum: Added.
  • fast/css-generated-content/after-order-expected.png: Added.
  • fast/css-generated-content/after-order-expected.txt: Added.
  • fast/css-generated-content/after-order.html: Added.
  • fast/css-generated-content/resources/greenbox.png: Added.

WebCore:

Reviewed by Hyatt.

  • fix bug where :after content appears backwards

Test: fast/css-generated-content/after-order.html

  • rendering/RenderBlock.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderBlock::addChildToFlow): Use isAfterContent.
  • rendering/RenderInline.cpp: (WebCore::isAfterContent): Added. (WebCore::RenderInline::addChildToFlow): Use isAfterContent.
16:15 Changeset [18558] by thatcher
  • 5 edits in tags/WebKit-521.32.1/WebKit

Merging r18381 and r18388.

16:04 Changeset [18557] by hyatt
  • 7 edits in trunk/WebCore

Implement box-shadow parsing... getting it all into the RenderStyle.

Reviewed by beth

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==): (WebCore::StyleCSS3NonInheritedData::shadowDataEquivalent): (WebCore::RenderStyle::diff): (WebCore::RenderStyle::setBoxShadow):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::boxShadow):
15:48 Changeset [22725] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Add stubs for all of the localized context menu item titles. The
stubs just return English Strings until we have a localization
solution in WebKit.

15:47 Changeset [18556] by thatcher
  • 1 copy in tags/WebKit-521.32.1/WebKit

New tag (part 2).

15:46 Changeset [18555] by thatcher
  • 1 add in tags/WebKit-521.32.1

New tag (part 1).

15:38 Changeset [18554] by bdakin
  • 8 edits in trunk

WebCore:

Reviewed by John.

Call into WebKit to get localized strings for all of the context
menu item titles.

WebKit:

Reviewed by John.

Make localized strings for all of the context menu item titles that
are accessible to WebCore.

14:24 Changeset [22724] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

<rdar://problem/4857027>
ragnarok online misrenders (due to lack of support for windowless plugins)

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Rename from updateHwnd since this now handles updating the clip rect for windowless plugins.


(WebCore::PluginViewWin::paintMissingPluginIcon):
New function which paints the missing plugin icon.


(WebCore::PluginViewWin::paint):
Do windowless painting here.


(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
(WebCore::PluginViewWin::handleEvent):
New functions for handling mouse and keyboard events, translating them and handing them to the plugin.


(WebCore::PluginViewWin::setNPWindowRect):
Set correct window rect for windowless plugins.


(WebCore::PluginViewWin::getValue):
Add variable for containing HWND.


(WebCore::PluginViewWin::setValue):
Add windowless and transparent variables.


(WebCore::PluginViewWin::invalidateRect):
(WebCore::PluginViewWin::invalidateRegion):
(WebCore::PluginViewWin::forceRedraw):
Implement these.


(WebCore::PluginViewWin::determineQuirks):
Set quirks now that we support windowless flash.


(WebCore::PluginViewWin::PluginViewWin):
Only create the window if the plugin isn't windowless.


  • plugins/win/PluginViewWin.h: New declarations.


  • plugins/win/npapi.cpp: (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw): Implement these and forward them to the plugin view.
14:19 Changeset [18553] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin and Geoff

http://bugs.webkit.org/show_bug.cgi?id=12105 - Crash visiting Acid2 test page
-Replace lost "free nil checking" in the WebKit->WebCore conversion of the BackForwardList
-Changed ::createItem and ::createItemTree to ::createHistoryItem and ::createHistoryItemTree

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createHistoryItemTree): (WebCore::FrameLoader::updateHistoryForInternalLoad):
  • loader/FrameLoader.h:
13:48 Changeset [18552] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Geoff.


Allow plugin elements to handle off events to their widgets.


  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::defaultEventHandler):
  • html/HTMLPlugInElement.h:
  • platform/Widget.h: (WebCore::Widget::handleEvent):
12:56 Changeset [18551] by beidson
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan

In the Bookmarks View/History View, favicon may be the incorrect size

  • History/WebHistoryItem.mm: (-[WebHistoryItem icon]): Call to the WebIconDatabase until a WebCore issue is resolved
11:35 Changeset [18550] by adele
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • Fix for <rdar://problem/4455147> Safari allows division slash character in URLs, which looks like slash character (not fixed by IDNScriptWhiteList.txt)
  • Misc/WebNSURLExtras.m: (allCharactersInIDNScriptWhiteList): Always disallow the division slash character.
11:16 Changeset [18549] by ap
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=3420
XMLHttpRequest does not handle set-cookie headers

  • http/tests/xmlhttprequest/cookies-expected.txt: Added.
  • http/tests/xmlhttprequest/cookies.html: Added.
  • http/tests/xmlhttprequest/resources/get-set-cookie.cgi: Added.
10:38 Changeset [18548] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-28 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Fix the issue with the SQL query associated with the checkin made for the following bug:
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::ReadLongTextL):
10:25 Changeset [18547] by yongjzha
  • 2 edits in S60/trunk/WebKit

2007-01-03 sareen <shyam.sareen@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Vodafone Specific Storage test failing.
http://bugs.webkit.org/show_bug.cgi?id=12101

  • ResourceLoader/CacheSrc/HttpCacheUtil.cpp: (HttpCacheUtil::VSSCacheContent):
10:17 Changeset [18546] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-28 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Put back the patches r18389, r18183 as well as fix the issue with the SQL query.
Patches r18389, r18183 fix the following two bugs:
TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
http://bugs.webkit.org/show_bug.cgi?id=11927
TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::CFormDataAutoFillStore): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::~CFormDataAutoFillStore): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::ClearData): (CFormDataAutoFillStore::OpenDatabase): (CFormDataAutoFillStore::CloseDatabase): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):
04:04 Changeset [18545] by lars
  • 10 edits
    2 adds in trunk

Fix the Qt build

00:31 Changeset [18544] by beidson
  • 2 edits in trunk/WebKit

Controversially reviewed by Tim H. and Maciej

Fixes http://bugs.webkit.org/show_bug.cgi?id=12086, http://bugs.webkit.org/show_bug.cgi?id=12088,
possibly http://bugs.webkit.org/show_bug.cgi?id=12087, and probably a slew of others

WebHistoryItems returned from the WebBackForwardList accessors were being release/retained out-of-order
by the Safari app. This bug never surfaced before because the WebBackForwardList had a retain on the
item, preventing deallocation. Since the items are now just temporary wrappers, the list
is no longer actually retaining them.

This solution is to simulate the ownership with a [[id retain] autorelease] - gross, but maybe the
only solution for now... =/

We can possibly consider reverting this fix at a later date - that task is marked by
<rdar://problem/4905705>

  • History/WebBackForwardList.mm: (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (-[WebBackForwardList itemAtIndex:]):

01/02/07:

22:59 Changeset [18543] by bdash
  • 4 edits in tags/Safari-421.32

Versioning.

20:16 Changeset [18542] by bdakin
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

Remove un-used function.

  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebContextMenuClient.mm:
19:28 Changeset [22723] by beidson
  • 6 edits in branches/WindowsMerge

Temporary Link Stub fix after landing Back/Forward cache in OpenSource

19:11 Changeset [18541] by beidson
  • 54 edits
    1 move
    13 adds
    2 deletes in trunk

WebCore:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCorePageState.h: Removed.
  • bridge/mac/WebCorePageState.mm: Removed.
  • history/BackForwardList.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::BackForwardList::BackForwardList): (WebCore::BackForwardList::~BackForwardList): (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::goBack): (WebCore::BackForwardList::goForward): (WebCore::BackForwardList::goToItem): (WebCore::BackForwardList::backItem): (WebCore::BackForwardList::currentItem): (WebCore::BackForwardList::forwardItem): (WebCore::BackForwardList::backListWithLimit): (WebCore::BackForwardList::forwardListWithLimit): (WebCore::BackForwardList::capacity): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::pageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::usesPageCache): (WebCore::BackForwardList::backListCount): (WebCore::BackForwardList::forwardListCount): (WebCore::BackForwardList::itemAtIndex): (WebCore::BackForwardList::entries): (WebCore::BackForwardList::close): (WebCore::BackForwardList::closed): (WebCore::BackForwardList::removeItem): (WebCore::BackForwardList::containsItem): (WebCore::BackForwardList::setDefaultPageCacheSize): (WebCore::BackForwardList::defaultPageCacheSize):
  • history/BackForwardList.h: Added.
  • history/HistoryItem.cpp: Added - This largely emulates the design of WebBackForwardList (WebCore::defaultNotifyHistoryItemChanged): (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::~HistoryItem): (WebCore::HistoryItem::copy): (WebCore::HistoryItem::setHasPageCache): (WebCore::HistoryItem::retainIconInDatabase): (WebCore::HistoryItem::urlString): (WebCore::HistoryItem::originalURLString): (WebCore::HistoryItem::title): (WebCore::HistoryItem::alternateTitle): (WebCore::HistoryItem::icon): (WebCore::HistoryItem::lastVisitedTime): (WebCore::HistoryItem::url): (WebCore::HistoryItem::originalURL): (WebCore::HistoryItem::target): (WebCore::HistoryItem::parent): (WebCore::HistoryItem::setAlternateTitle): (WebCore::HistoryItem::setURLString): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::setOriginalURLString): (WebCore::HistoryItem::setTitle): (WebCore::HistoryItem::setTarget): (WebCore::HistoryItem::setParent): (WebCore::HistoryItem::setLastVisitedTime): (WebCore::HistoryItem::visitCount): (WebCore::HistoryItem::setVisitCount): (WebCore::HistoryItem::scrollPoint): (WebCore::HistoryItem::setScrollPoint): (WebCore::HistoryItem::clearScrollPoint): (WebCore::HistoryItem::setDocumentState): (WebCore::HistoryItem::documentState): (WebCore::HistoryItem::clearDocumentState): (WebCore::HistoryItem::isTargetItem): (WebCore::HistoryItem::setIsTargetItem): (WebCore::HistoryItem::alwaysAttemptToUsePageCache): (WebCore::HistoryItem::setAlwaysAttemptToUsePageCache): (WebCore::HistoryItem::addChildItem): (WebCore::HistoryItem::childItemWithName): (WebCore::HistoryItem::recurseToFindTargetItem): (WebCore::HistoryItem::targetItem): (WebCore::HistoryItem::pageCache): (WebCore::HistoryItem::children): (WebCore::HistoryItem::hasChildren): (WebCore::HistoryItem::formContentType): (WebCore::HistoryItem::formReferrer): (WebCore::HistoryItem::rssFeedReferrer): (WebCore::HistoryItem::setRSSFeedReferrer): (WebCore::HistoryItem::setFormInfoFromRequest): (WebCore::HistoryItem::formData): (WebCore::HistoryItem::mergeAutoCompleteHints): (WebCore::HistoryItem::hasPageCache): (WebCore::timer): Function to manage the global release timer (WebCore::pendingPageCacheToRelease): Function to manage the global queue of caches to be released (WebCore::HistoryItem::releasePageCache): (WebCore::closeObjectsInPendingPageCaches): (WebCore::HistoryItem::releaseAllPendingPageCaches): (WebCore::HistoryItem::scheduleRelease): (WebCore::HistoryItem::print):
  • history/HistoryItem.h: Added.
  • history/mac/HistoryItemMac.mm: Added. (WebCore::HistoryItem::viewState): In the future we need a platform agnostic way to manage the view state (WebCore::HistoryItem::setViewState): (WebCore::HistoryItem::getTransientProperty): Transient properties are, for now, only a Mac concept (WebCore::HistoryItem::setTransientProperty):
  • history/HistoryItemTimer.cpp: Added (WebCore::HistoryItemTimer::HistoryItemTimer): We need a specific class to be the history item timer because WebCore::Timers only work when you have an instance of an object, but the caches pending release is a static concept (WebCore::HistoryItemTimer::isActive): (WebCore::HistoryItemTimer::schedule): (WebCore::HistoryItemTimer::invalidate): (WebCore::HistoryItemTimer::callReleasePageCache):
  • history/HistoryItemTimer.h: Added.
  • history/PageCache.cpp Added - This is a class that contains the fields that used to be in an NSDictionary in WebKit (WebCore::PageCache::PageCache): (WebCore::PageCache::setPageState): (WebCore::PageCache::~PageCache): (WebCore::PageCache::pageState): (WebCore::PageCache::setDocumentLoader): (WebCore::PageCache::documentLoader): (WebCore::PageCache::setTimeStamp): (WebCore::PageCache::setTimeStampToNow): (WebCore::PageCache::timeStamp):
  • history/PageCache.h: Added.
  • history/mac/PageCacheMac.mm: Added. (WebCore::PageCache::close): (WebCore::PageCache::setDocumentView): In the future we need a platform agnostic way to manage the documentView (WebCore::PageCache::documentView):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::loadFromPageCache): (WebCore::DocumentLoader::setLoadingFromPageCache): (WebCore::DocumentLoader::isLoadingFromPageCache): (WebCore::DocumentLoader::originalURL): (WebCore::DocumentLoader::requestURL): (WebCore::DocumentLoader::responseURL): (WebCore::DocumentLoader::responseMIMEType):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: Responsibilities previously scattered in WebKit but concentrated in WebView and WebFrame are now here, where they should be. (WebCore::FrameLoader::clear): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::canCachePage): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoader::dispatchDidFinishLoadToClient): (WebCore::FrameLoader::updateGlobalHistoryForStandardLoad): Marked for usage in future GlobalHistory (uses client for now) (WebCore::FrameLoader::updateGlobalHistoryForReload): Ditto (WebCore::FrameLoader::shouldGoToHistoryItem): (WebCore::FrameLoader::addExtraFieldsToRequest): (WebCore::FrameLoader::addHistoryItemForFragmentScroll): (WebCore::FrameLoader::loadProvisionalItemFromPageCache): (WebCore::FrameLoader::createPageCache): (WebCore::FrameLoader::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoader::createItem): (WebCore::FrameLoader::addBackForwardItemClippedAtTarget): (WebCore::FrameLoader::createItemTree): (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): (WebCore::FrameLoader::restoreScrollPositionAndViewState): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemPageCache): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::urlsMatchItem): (WebCore::FrameLoader::goToItem): (WebCore::FrameLoader::recursiveGoToItem): (WebCore::FrameLoader::childFramesMatchItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit): (WebCore::FrameLoader::saveDocumentAndScrollState): (WebCore::FrameLoader::currentHistoryItem): (WebCore::FrameLoader::previousHistoryItem): (WebCore::FrameLoader::provisionalHistoryItem): (WebCore::FrameLoader::setCurrentHistoryItem): (WebCore::FrameLoader::setPreviousHistoryItem): (WebCore::FrameLoader::setProvisionalHistoryItem):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::getResponseRefreshAndModifiedHeaders): (WebCore::DocumentLoader::commitIfReady): (WebCore::DocumentLoader::urlForHistory):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::load): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::dataURLBaseFromRequest): (WebCore::FrameLoader::didChangeTitle): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
  • page/FrameTree.cpp: (WebCore::FrameTree::removeChild):
  • page/Page.cpp: Transfered a handful of concepts from WebView (WebCore::Page::Page): (WebCore::Page::~Page): (WebCore::Page::backForwardList): (WebCore::Page::goBack): (WebCore::Page::goForward): (WebCore::Page::goToItem):
  • page/Page.h:
  • page/PageState.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:
  • platform/KURL.cpp: (WebCore::KURL::print): Added debug only method for debugging convenience
  • platform/KURL.h:
  • platform/Logging.cpp: (WebCore::): Added some logging channels
  • platform/Logging.h:
  • platform/PlatformString.h: (WebCore::nsStringNilIfEmpty): Added for WebKit use
  • platform/SystemTime.h: Added userIdleTime()
  • platform/graphics/svg/SVGImage.cpp:
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for new FrameLoaderClient methods (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromPageCache): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistoryForReload): (WebCore::SVGEmptyFrameLoaderClient::shouldGoToHistoryItem): (WebCore::SVGEmptyFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToPageCache): (WebCore::SVGEmptyFrameLoaderClient::canCachePage): (WebCore::SVGEmptyEditorClient::~SVGEmptyEditorClient):
  • platform/mac/LoggingMac.mm: (WebCore::InitializeLoggingChannelsIfNecessary):
  • platform/mac/SystemTimeMac.cpp: (WebCore::userIdleTime):
  • platform/mac/WebCoreSystemInterface.h: Added wkSecondsSinceLastInput for use in userIdleTime
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/FormData.cpp: (WebCore::FormData::FormData): (WebCore::FormData::copy):
  • platform/network/FormData.h:
  • platform/network/ResourceHandle.h:
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willLoadFromCache): For "are you sure you want to resubmit?" nag
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::userIdleTime):
  • rendering/RenderPart.h:

WebKit:

Reviewed extensively and repeatedly by Darin

<rdar://problem/4887137> - WebCore Back/Forward Cache
Most things not specifically commented on in the ChangeLog can be summed up as
"Do things exactly the same way as we used to, but just stick in WebCore-land as much as possible"

  • History/WebBackForwardList.mm: (kitPrivate): Convenience functions to help with subbing "WebBackForwardListPrivate" for WebCore::BackForwardList (core): (backForwardListWrappers): A HashMap pattern used to map WebCore objects to their WebKit counterpart (kit): (+[WebBackForwardList setDefaultPageCacheSizeIfNecessary]): (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]): (-[WebBackForwardList _close]): (-[WebBackForwardList addItem:]): (-[WebBackForwardList removeItem:]): (-[WebBackForwardList containsItem:]): (-[WebBackForwardList goBack]): (-[WebBackForwardList goForward]): (-[WebBackForwardList goToItem:]): (-[WebBackForwardList backItem]): (-[WebBackForwardList currentItem]): (-[WebBackForwardList forwardItem]): (vectorToNSArray): (-[WebBackForwardList backListWithLimit:]): (-[WebBackForwardList forwardListWithLimit:]): (-[WebBackForwardList capacity]): (-[WebBackForwardList setCapacity:]): (-[WebBackForwardList description]): (-[WebBackForwardList _clearPageCache]): (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]): (-[WebBackForwardList _usesPageCache]): (-[WebBackForwardList backListCount]): (-[WebBackForwardList forwardListCount]): (-[WebBackForwardList itemAtIndex:]):
  • History/WebBackForwardListInternal.h: Added.
  • History/WebHistory.m: Removed.
  • History/WebHistory.mm: Added - Needed to be .mm to accept C++ header style (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):
  • History/WebHistoryItem.mm: (kitPrivate): Same pattern as WebBackForwardList (core): (historyItemWrappers): (WKNotifyHistoryItemChanged): (-[WebHistoryItem init]): (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem setAlternateTitle:]): (-[WebHistoryItem alternateTitle]): (-[WebHistoryItem icon]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem hash]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (kit): (+[WebHistoryItem entryWithURL:]): (+[WebHistoryItem initWindowWatcherIfNecessary]): (-[WebHistoryItem initWithURL:target:parent:title:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem setTitle:]): (-[WebHistoryItem setVisitCount:]): (-[WebHistoryItem setViewState:]): (-[WebHistoryItem _mergeAutoCompleteHints:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem _transientPropertyForKey:]): (-[WebHistoryItem _setTransientProperty:forKey:]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (-[WebHistoryItem URL]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
  • History/WebHistoryItemInternal.h:
  • History/WebHistoryItemPrivate.h:
  • WebCoreSupport/WebFrameBridge.mm:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromPageCache): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): (WebFrameLoaderClient::updateGlobalHistoryForReload): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::saveScrollPositionAndViewStateToItem): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::saveDocumentViewToPageCache): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.mm:
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.mm: (-[WebFramePrivate dealloc]): (-[WebFrame _canCachePage]): (-[WebFrame _loadURL:referrer:intoChild:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm: (-[WebFrameView initWithFrame:]): (-[WebFrameView keyDown:]):
  • WebView/WebHTMLView.m: (-[WebHTMLView closeIfNotCurrentView]): Added for a dirty hack in WebCore that is marked with a FIXME Radar
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _close]): (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView initWithCoder:]): (-[WebView backForwardList]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]):
17:05 Changeset [18540] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker

  • fixed <rdar://problem/4892525> Cannot open PDF in Preview if you attempted to open it in Preview while PDF was loading
  • WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): added comment (-[WebPDFView validateUserInterfaceItem:]): disable this menu item when there's no document yet (-[WebPDFView _openWithFinder:]): If this is invoked when there is no document yet (e.g. via the PDFKit delegate method), just beep and return. I should make a nice error message here, but I'll do that separately.
16:48 Changeset [18539] by bdash
  • 2 edits in tags/Safari-421.32/WebCore

Merge fix r18352.

16:45 Changeset [18538] by bdash
  • 2 edits in tags/Safari-421.32/JavaScriptCore

Merge fix r18349.

16:41 Changeset [18537] by bdash
  • 5 edits in tags/Safari-421.32/WebCore

Merge fix r18328 and r18386.

16:32 Changeset [18536] by zimmermann
  • 2 edits in trunk/WebKit

Reviewed by Timothy.
Fix inspection of RenderSVGInlineText objects (#text nodes in SVG documents).

16:23 Changeset [18535] by bdash
  • 1 copy in tags/Safari-421.32

New tag.

15:40 Changeset [22722] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

15:34 Changeset [18534] by darin
  • 7 edits in trunk/WebCore

Rubber stamped by Mitz.

Rename isRenderSVGContainer to isSVGContainer.

  • platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderObject.h: (WebCore::RenderObject::isSVGContainer):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::viewportTransform):
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::isSVGContainer):
  • rendering/RenderTreeAsText.cpp: (WebCore::write):
15:31 Changeset [18533] by sfalken
  • 1 copy in tags/Safari-521.32.8b

New tag.

15:22 Changeset [18532] by zimmermann
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to commit the ChangeLog changes in last commit (Rename isKCanvasContainer to isRenderSVGContainer)

15:20 Changeset [18531] by zimmermann
  • 6 edits in trunk/WebCore

Reviewed by Mitz.
Rename isKCanvasContainer to isRenderSVGContainer.

15:18 Changeset [18530] by bdakin
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

Fix assertion failure with WebCore context menus by getting "Copy
Image" item added in.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Check if the image url is a local file or if we have an image in the cache.

WebKit:

Reviewed by Darin.

Fix bug with WebCore context menu item "Copy Image."

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::copyImageToClipboard): We must call declareTypes on the pasteboard.
11:31 Changeset [22721] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:58 Changeset [18529] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders.

Testcase for http://bugs.webkit.org/show_bug.cgi?id=12072

  • fast/forms/select-align-expected.checksum: Added.
  • fast/forms/select-align-expected.png: Added.
  • fast/forms/select-align-expected.txt: Added.
  • fast/forms/select-align.html: Added.

WebCore:

Reviewed by Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12072
select with align attribute should not affect contained text

Don't map align for select elements.

Test: fast/forms/select-align.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
10:04 Changeset [18528] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Testcase for http://bugs.webkit.org/show_bug.cgi?id=12071

  • fast/forms/button-align-expected.checksum: Added.
  • fast/forms/button-align-expected.png: Added.
  • fast/forms/button-align-expected.txt: Added.
  • fast/forms/button-align.html: Added.

WebCore:

Reviewed by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12071
button with align attribute should not affect contained text

Don't map align for button elements.

Test: fast/forms/button-align.html

  • html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::parseMappedAttribute):
09:41 Changeset [18527] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=7075

  • fast/forms/textarea-align-expected.checksum: Added.
  • fast/forms/textarea-align-expected.png: Added.
  • fast/forms/textarea-align-expected.txt: Added.
  • fast/forms/textarea-align.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Patch for http://bugs.webkit.org/show_bug.cgi?id=7075
textarea with align=right should not cause contained text to
be right-justified

Don't map align for textarea elements.

Test: fast/forms/textarea-align.html

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::parseMappedAttribute):
09:39 Changeset [18526] by darin
  • 3 edits in trunk/JavaScriptCore
  • minor tweak (hope this doesn't re-break Windows)
  • pcre/pcre_compile.c: Removed use of const pcre_uchar const * -- Mitz probably meant const pcre_uchar *const, but I think we can do without the explicit const here.
  • pcre/pcre_internal.h: Re-enabled warning C4114.
09:22 Changeset [18525] by ddkilzer
  • 3 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by NOBODY (Windows build fix).

The MSVC compiler requires variables to be declared at the top of the enclosing block in C source.

Disable this warning to prevent MSVC from complaining about the 'const pcre_uchar const *' type:
warning C4114: same type qualifier used more than once

  • pcre/pcre_compile.c: (pcre_compile2): Moved variable declarations to top of their respective enclosing blocks.
  • pcre/pcre_internal.h: Added pragma to disable compiler warning.
09:08 Changeset [18524] by eseidel
  • 4 edits in trunk/WebCore

2007-01-02 Eric Seidel <eric@webkit.org>

Reviewed by mitz.

Implement SVGSVGElement::deselectAll()

  • ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): add comment
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll): implement (WebCore::SVGSVGElement::setCurrentTime): add comment about bug
  • ksvg2/svg/SVGSVGElement.idl: remove unnecessary comment
06:12 Changeset [18523] by weinig
  • 4 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

Testcases for http://bugs.webkit.org/show_bug.cgi?id=3360

  • fast/forms/input-align-expected.checksum: Added.
  • fast/forms/input-align-expected.png: Added.
  • fast/forms/input-align-expected.txt: Added.
  • fast/forms/input-align-image-expected.checksum: Added.
  • fast/forms/input-align-image-expected.png: Added.
  • fast/forms/input-align-image-expected.txt: Added.
  • fast/forms/input-align-image.html: Added.
  • fast/forms/input-align.html: Added.

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=3360
align="right" on a text input aligns the input field to the right

Don't map align if input type is not 'image'.

Test: fast/forms/input-align-image.html
Test: fast/forms/input-align.html

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::mapToEntry): (WebCore::HTMLInputElement::parseMappedAttribute):
05:46 Changeset [18522] by zimmermann
  • 1 edit
    66 adds in trunk/LayoutTests

Rubber stamped by Rob.
Adding all carto.net SVG/JS examples. Highlights some nifty bugs.

04:09 Changeset [18521] by zimmermann
  • 79 edits
    32 adds in trunk

Reviewed by Eric.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12013
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11980
Partly fixes: http://bugs.webkit.org/show_bug.cgi?id=6000 (pattern/gradient recursion works now)

Rewrite gradient & pattern code, fixing all known bugs & regressions.

02:13 Changeset [18520] by zack
  • 2 edits in trunk/WebCore

fix compile for svg as well (filenames are case-sensitive)

02:05 Changeset [18519] by zack
  • 7 edits in trunk

compilation fixes for the Qt port

01:03 Changeset [18518] by eseidel
  • 18 edits
    2 adds in trunk/WebCore

2007-01-02 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

Refactor more animation code for better sharing between SVGAnimate*Element classes.

  • replace handleEndCondition with resetValues() and updateLastValueWithCurrent()
  • move initialTransform() function down into SVGTimer (eventually to AnimationCompositor) Add non-functional (only parses) SVGAnimateMotionElement Improve precision of getPointAtLength calculations and add support for "getNormalAtLength" functionality (needed for rotate='auto' support in animateMotion) Move add getSegmentAtLength functionality to SVGPathSegList, move toPathData into SVGPathSegList as well. Add SVGAnimationElement::hasValidTarget() for future better/simpler ASSERT checking change transformMatrix() to currentTransform() to match AffineTransform class name
  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): (WebCore::baseValueTransformList): (WebCore::SVGTimer::applyAnimations):
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateLastValueWithCurrent):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: Added. (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::~SVGAnimateMotionElement): (WebCore::SVGAnimateMotionElement::hasValidTarget): added. (WebCore::SVGAnimateMotionElement::parseMappedAttribute): (WebCore::SVGAnimateMotionElement::animationPath): fetch path from <mpath> or d attribute (WebCore::SVGAnimateMotionElement::updateCurrentValue): (WebCore::SVGAnimateMotionElement::handleStartCondition): (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h: Added. (WebCore::SVGAnimateMotionElement::contextElement): (WebCore::SVGAnimateMotionElement::):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::hasValidTarget): added. (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::updateLastValueWithCurrent): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::currentTransform):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::hasValidTarget): added. (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::isAdditive): (WebCore::SVGAnimationElement::isAccumulated): (WebCore::SVGAnimationElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElement.h: (WebCore::SVGAnimationElement::updateLastValueWithCurrent): (WebCore::SVGAnimationElement::resetValues):
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getPointAtLength): (WebCore::SVGPathElement::getPathSegAtLength): (WebCore::SVGPathElement::parseMappedAttribute): (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): added. (WebCore::SVGPathSegList::toPathData): added.
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/svgtags.in: add animateMotion
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): add support for TraversalNormalAngleAtLength
  • platform/graphics/PathTraversalState.cpp: (WebCore::curveLength): support higher precision pointAtLength calculations, and add normalAtLength support (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
  • platform/graphics/PathTraversalState.h: (WebCore::PathTraversalState::): add TraversalNormalAngleAtLength mode

01/01/07:

21:13 Changeset [18517] by ddkilzer
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Modified pcre_compile() (and the functions that it calls) to work with patterns
containing null characters.

Covered by JavaScriptCore tests ecma_3/RegExp/octal-002.js and ecma_3/RegExp/regress-85721.js

  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
  • pcre/pcre.h:
  • pcre/pcre_compile.c: (check_escape): (get_ucp): (is_counted_repeat): (check_posix_syntax): (compile_branch): (compile_regex): (pcre_compile): Added a parameter specifying the length of the pattern, which is no longer required to be null-terminated and may contain null characters. (pcre_compile2):
  • pcre/pcre_internal.h:
  • tests/mozilla/expected.html: Updated for the two tests that this patch fixes. Also updated failing results for ecma_3/RegExp/regress-100199.js which were not updated after bug 6257 was fixed.

WebCore:

Reviewed by Darin.

  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Changed to not null-terminate the pattern string and instead pass its length to pcre_compile.
20:37 Changeset [18516] by ddkilzer
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/table-cell-collapsed-border-expected.checksum: Added.
  • fast/repaint/table-cell-collapsed-border-expected.png: Added.
  • fast/repaint/table-cell-collapsed-border-expected.txt: Added.
  • fast/repaint/table-cell-collapsed-border.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/repaint/table-cell-collapsed-border.html

  • rendering/RenderTable.h: Added needsSectionRecalc() accessor.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::getAbsoluteRepaintRect): Overloaded to add the outer half of any collapsed borders. This function checks the cell's borders' widths but also the widths of the adjoining cells' borders, since they can contribute to the length of this cell's borders perpendicular to them, making such a border overflow the cell in both dimensions. (WebCore::RenderTableCell::borderLeft): Split the collapsing borders case off to borderHalfLeft(). (WebCore::RenderTableCell::borderRight): Ditto. (WebCore::RenderTableCell::borderTop): Ditto. (WebCore::RenderTableCell::borderBottom): Ditto. (WebCore::RenderTableCell::borderHalfLeft): Added. Takes an 'outer' boolean parameter. When true, this function returns the width of the part of the border that is outside the cell (different from the inner width when the total width is odd). (WebCore::RenderTableCell::borderHalfRight): Ditto. (WebCore::RenderTableCell::borderHalfTop): Ditto. (WebCore::RenderTableCell::borderHalfBottom): Ditto.
  • rendering/RenderTableCell.h:
20:27 Changeset [18515] by ddkilzer
  • 4 edits in trunk/WebCore

WebCore:

WebCore.vcproj change reviewed by Darin. Additional build files updated by ddkilzer.

  • CMakeLists.txt: Removed RenderLineEdit.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderLineEdit.cpp and RenderLineEdit.h.
  • WebCoreSources.bkl: Removed RenderLineEdit.cpp.
20:19 Changeset [18514] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Darin.

Because Mac OS X returns geographically and historically accurate time zone information,
converting Jan 02, 1970 12:00:00 AM to local time then subtracting 24 hours did not work
in GMT (London - England) since it was in BST (+0100) all year in 1970[1]. Instead, the
UTC offset is calculated by converting Jan 01, 2000 12:00:00 AM to local time then
subtracting that from the same date in UTC.

[1] http://en.wikipedia.org/wiki/British_Summer_Time

  • kjs/DateMath.cpp: (KJS::getUTCOffset): Updated UTC offset calculation. (KJS::getDSTOffset): Improved comment.
20:13 Changeset [18513] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12023
svn-create-patch and friends should handle moved/copied files

  • Scripts/svn-apply: Identify copied files and handle those before all other patches.
  • Scripts/svn-create-patch: Generate patches with subtle changes for copied files. (findMimeType($)): Added. (findModificationTime($)): Added. (findSourceFileAndRevision($)): Added. (generateDiff($$$)): Changed to use svn stat instead of svn diff. (isBinaryMimeType($)): Added. (manufacturePatchForAdditionWithHistory($$)): Added.
  • Scripts/svn-unapply: Identify copied files and handle those after unapplying all other patches.
18:27 Changeset [18512] by darin
  • 2 edits in trunk/WebKitSite
  • quality/bugzilla.html: Fix a lingering reference to opendarwin.org.
18:03 Changeset [18511] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mark Rowe.

  • fast/borders/outline-offset-min-assert-expected.checksum: Added.
  • fast/borders/outline-offset-min-assert-expected.png: Added.
  • fast/borders/outline-offset-min-assert-expected.txt: Added.
  • fast/borders/outline-offset-min-assert.html: Added.

WebCore:

Reviewed by Mark Rowe.

Test: fast/borders/outline-offset-min-assert.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline): Bail out if the width or height is smaller than twice the outline inset.
17:42 Changeset [18510] by bdash
  • 3 edits
    2 adds in trunk

2007-01-01 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

  • rendering/RenderStyle.cpp: (WebCore::ContentData::clearContent): Reset _contentType to CONTENT_NONE to ensure repeated calls to clearContent do not result in derefing deallocated members.

2007-01-01 Mark Rowe <bdash@webkit.org>

Reviewed by Eric.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=12061
Bug 12061: Crash in WebCore::Shared<WebCore::StringImpl>::deref

  • fast/css-generated-content/reset-content-to-initial-expected.txt: Added.
  • fast/css-generated-content/reset-content-to-initial.html: Added.
12:48 Changeset [18509] by eseidel
  • 10 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Begin pushing code down into SVGAnimateElement

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleStartCondition):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateCurrentValue): (WebCore::SVGAnimateElement::handleStartCondition): (WebCore::SVGAnimateElement::handleEndCondition):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleStartCondition):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::updateCurrentValue): (WebCore::SVGSetElement::handleStartCondition): (WebCore::SVGSetElement::handleEndCondition):
  • ksvg2/svg/SVGSetElement.h:
11:40 Changeset [18508] by eseidel
  • 4 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Add static function SVGColor::colorFromRGBColorString to allow parsing Colors from SVG color strings w/o creating an SVGColor object.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): use colorFromRGBColorString (WebCore::SVGAnimateColorElement::startIfNecessary): use colorFromRGBColorString
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor): use colorFromRGBColorString (WebCore::parseNumberOrPercent): new color parsing helper (WebCore::SVGColor::colorFromRGBColorString): cleaned up version of setRGBColor parsing logic
  • ksvg2/svg/SVGColor.h:
10:58 Changeset [18507] by eseidel
  • 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by andersca.

Split handleTimerEvent logic into separate functions in preparation for moving down into SVGAnimationElement

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::storeInitialValue): (WebCore::SVGAnimateColorElement::resetValues): (WebCore::SVGAnimateColorElement::updateCurrentValue): (WebCore::SVGAnimateColorElement::startIfNecessary): (WebCore::SVGAnimateColorElement::handleEndCondition): (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::startIfNecessary): (WebCore::SVGAnimateTransformElement::handleEndCondition): (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.h:
10:56 Changeset [18506] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Simple cleanups, removing unused color table, copyright and include guard fixes.

10:20 Changeset [18505] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

correct reviewer, was andersca not mitz

10:19 Changeset [18504] by eseidel
  • 7 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.

More animation code cleanup.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::SVGAnimationElement): (WebCore::SVGAnimationElement::connectedToTimer): (WebCore::SVGAnimationElement::connectTimer): (WebCore::SVGAnimationElement::disconnectTimer): (WebCore::SVGAnimationElement::updateForElapsedSeconds):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGSetElement.cpp: (WebCore::SVGSetElement::handleTimerEvent):
  • ksvg2/svg/SVGSetElement.h:
09:53 Changeset [18503] by eseidel
  • 3 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.

More clean-up to animation code.

  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::parseTransformValue): (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
00:12 Changeset [18502] by eseidel
  • 12 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Begin pushing more animation logic out of SVGTimer and into the SVGAnimate* classes.


  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): add comment (WebCore::SVGTimer::notifyAll): push logic into SVGAnimte* classes
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::applyAnimationToValue): added.
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::applyAnimationToValue): added.
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::calculateTimePercentage): logic moved from SVGTimer (WebCore::SVGAnimationElement::updateForElapsedSeconds): logic moved from SVGTimer
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenate): fixed spacing

12/31/06:

22:47 Changeset [18501] by eseidel
  • 5 edits in trunk/WebCore

2007-01-01 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Split out animationsByElement() logic in preparation for adding AnimationCompositor class
Add addColorsAndClamp helper (since adding and clamping is the common case)

  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::animationsByElement): split out from notifyAll (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGTimer.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::addColorsAndClamp): added.
  • ksvg2/svg/SVGAnimateColorElement.h:
22:03 Changeset [18500] by eseidel
  • 10 edits
    2 copies
    2 moves in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Split KSVGTimeScheduler into SVGTimer and TimeScheduler.
(Basic clean-up before re-working animation system)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/misc/KSVGTimeScheduler.cpp: Removed.
  • ksvg2/misc/KSVGTimeScheduler.h: Removed.
  • ksvg2/misc/SVGTimer.cpp: Added. (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll):
  • ksvg2/misc/SVGTimer.h: Added.
  • ksvg2/misc/TimeScheduler.cpp: Added. (WebCore::TimeScheduler::TimeScheduler):
21:15 Changeset [18499] by eseidel
  • 2 edits in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Re-enable animateTransform (now that SVGList is fixed)
(Things are only "less broken" not totally fixed yet.)

  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
21:07 Changeset [18498] by ddkilzer
  • 23 edits
    1 move
    1 delete in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by Geoff.

Update embedded pcre library from version 6.2 to 6.4. Changes from pcre 6.2 to 6.3
did not include any files in JavaScriptCore/pcre.

All changes include renaming EXPORT to PCRE_EXPORT, renaming of ucp_findchar() to
_pcre_ucp_findchar(), or comment changes. Additional changes noted below.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated source file list.
  • JavaScriptCore.xcodeproj/project.pbxproj: Renamed pcre_printint.c to pcre_printint.src and changed it from a source file to a header file.
  • JavaScriptCoreSources.bkl: Updated source file list.
  • pcre/CMakeLists.txt: Updated source file list.
  • pcre/pcre-config.h:
  • pcre/pcre.h: Updated version.
  • pcre/pcre.pri: Updated source file list.
  • pcre/pcre_compile.c: Include pcre_printint.src #if DEBUG. (pcre_compile2):
  • pcre/pcre_config.c:
  • pcre/pcre_exec.c: (match):
  • pcre/pcre_fullinfo.c:
  • pcre/pcre_info.c:
  • pcre/pcre_internal.h: Added header guard. Removed export of _pcre_printint().
  • pcre/pcre_ord2utf8.c:
  • pcre/pcre_printint.c: Renamed to pcre_printint.src.
  • pcre/pcre_printint.src: Added. Renamed _pcre_printint() to pcre_printint().
  • pcre/pcre_refcount.c:
  • pcre/pcre_study.c:
  • pcre/pcre_tables.c:
  • pcre/pcre_try_flipped.c:
  • pcre/pcre_ucp_findchar.c: Added contents of ucp_findchar.c.
  • pcre/pcre_version.c:
  • pcre/pcre_xclass.c: (_pcre_xclass):
  • pcre/ucp.h: Removed export of ucp_findchar().
  • pcre/ucp_findchar.c: Removed. Contents moved to pcre_ucp_findchar.c.
16:49 Changeset [18497] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Hyatt.

No test possible (no change to functionality).

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): Call calc{Inline,Block}MinMaxWidth() only if their result is needed.
16:37 Changeset [18496] by bdash
  • 1 copy
    1 add in trunk/WebCore

Roll over WebCore ChangeLog

13:45 Changeset [18495] by eseidel
  • 21 edits in trunk/WebCore

2006-12-31 Eric Seidel <eric@webkit.org>

Reviewed by weinig.

Make SVGPathSeg construction take fewer lines of code.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::createSVGPathSegMovetoAbs): (WebCore::SVGPathElement::createSVGPathSegMovetoRel): (WebCore::SVGPathElement::createSVGPathSegLinetoAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): (WebCore::SVGPathElement::createSVGPathSegArcAbs): (WebCore::SVGPathElement::createSVGPathSegArcRel): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
  • ksvg2/svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs): (WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp: (WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs): (WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs): (WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp: (WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs): (WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp: (WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs): (WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp: (WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs): (WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp: (WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs): (WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp: (WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs): (WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
  • ksvg2/svg/SVGPathSegMoveto.h:
12:38 Changeset [18494] by eseidel
  • 3 edits
    2 deletes in trunk/LayoutTests

2006-12-31 Eric Seidel <eric@eseidel.com>

Reviewed by mitz.


Make getTotalLength test case work in Opera and FireFox.

  • svg/custom/path-getTotalLength-expected.checksum: Removed.
  • svg/custom/path-getTotalLength-expected.png: Removed.
  • svg/custom/path-getTotalLength-expected.txt:
  • svg/custom/path-getTotalLength.svg:
11:37 Changeset [18493] by eseidel
  • 6 edits
    6 adds in trunk

2006-12-31 Eric Seidel <eric@eseidel.com>

Reviewed by weinig.

Implement path length measuring for SVGPathElement::getTotalLength and friends.
http://bugs.webkit.org/show_bug.cgi?id=12033

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::getTotalLength): (WebCore::SVGPathElement::getPointAtLength):
  • platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::length): (WebCore::Path::pointAtLength):
  • platform/graphics/Path.h:
  • platform/graphics/PathTraversalState.cpp: Added. (WebCore::midPoint): (WebCore::distanceLine): (WebCore::QuadraticBezier::QuadraticBezier): (WebCore::QuadraticBezier::approximateDistance): (WebCore::QuadraticBezier::split): (WebCore::CubicBezier::CubicBezier): (WebCore::CubicBezier::approximateDistance): (WebCore::CubicBezier::split): (WebCore::curveLength): (WebCore::PathTraversalState::PathTraversalState): (WebCore::PathTraversalState::closeSubpath): (WebCore::PathTraversalState::moveTo): (WebCore::PathTraversalState::lineTo): (WebCore::PathTraversalState::quadraticBezierTo): (WebCore::PathTraversalState::cubicBezierTo):
  • platform/graphics/PathTraversalState.h: Added. (WebCore::PathTraversalState::):
08:08 Changeset [18492] by weinig
  • 5 edits in trunk/WebCore

Reviewed by Mitz.

Move the SVGZoomAndPanType enum out of SVGSVGElement and
SVGViewElement and into SVGZoomAndPan where it belongs.

  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan): (WebCore::SVGZoomAndPan::parseMappedAttribute):
  • ksvg2/svg/SVGZoomAndPan.h: (WebCore::SVGZoomAndPan::):
06:25 Changeset [18491] by ddkilzer
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Tweaked by Mitz.

  • fast/overflow/clip-rects-fixed-ancestor-expected.checksum: Added.
  • fast/overflow/clip-rects-fixed-ancestor-expected.png: Added.
  • fast/overflow/clip-rects-fixed-ancestor-expected.txt: Added.
  • fast/overflow/clip-rects-fixed-ancestor.html: Added.

WebCore:

Reviewed by Hyatt.

Added a 'fixed' flag to ClipRects, indicating that the cached rects are in
viewport coordinates. The flag is set (and scrolling is compensated for) for
fixed objects and their descendants.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
  • rendering/RenderLayer.h: (WebCore::ClipRects::ClipRects): (WebCore::ClipRects::fixed):
06:00 Changeset [18490] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Sam.

  • fast/block/positioning/relative-overconstrained-expected.checksum: Added.
  • fast/block/positioning/relative-overconstrained-expected.png: Added.
  • fast/block/positioning/relative-overconstrained-expected.txt: Added.
  • fast/block/positioning/relative-overconstrained.html: Added.

WebCore:

Reviewed by Sam.

Test: fast/block/positioning/relative-overconstrained.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::relativePositionOffsetX):

12/30/06:

15:02 Changeset [18489] by rwlbuis
  • 15 edits
    2 deletes in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12004
Webkit doesnt handle omitting M at the start of path syntax well

Improve path parsing error handling.

13:54 Changeset [18488] by rwlbuis
  • 6 edits in trunk

Reviewed by Darin.

The marker is used for start, mid and end.

12:53 Changeset [18487] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by weinig.

http://bugs.webkit.org/show_bug.cgi?id=12035
Use SVGParserUtilities in lists of values

Use SVGParserUtilities in some more places.

08:09 Changeset [18486] by rwlbuis
  • 5 edits
    4 adds in trunk

Reviewed by weinig.

http://bugs.webkit.org/show_bug.cgi?id=12034
Adapt preserveAspectRatio parsing to SVGParserUtilities

Use the new SVGParserUtilities methods to parse prserveAspectRatio attribute.

02:12 Changeset [18485] by ap
  • 3 edits in trunk/WebCore

2006-12-30 Mitz Pettel <mitz@webkit.org>

Reviewed by Alexey.

  • remove unused member variables m_loadingSheet and m_bAllDataReceived

No test possible (no change to functionality).

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::setCSSStyleSheet):
  • dom/Document.h:
00:34 Changeset [18484] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11998
Incorrect serialization of quotation marks in XML attributes.

Test: fast/dom/serialize-attribute.xhtml

  • editing/markup.cpp: (WebCore::escapeTextForMarkup): Added an isAttributeValue parameter, as the quotation mark only needs to be encoded in attribute values. (WebCore::startMarkup): Pass appropriate isAttributeValue to escapeTextForMarkup().
Note: See TracTimeline for information about the timeline view.