Timeline


and

01/23/07:

23:43 Changeset [22825] by beidson

Initial checkin of downloads for boomer

23:05 Changeset [19074] by lars

Fix compilation again.

22:26 Changeset [22824] by sfalken
22:16 Changeset [19073] by bdash

2007-01-23 Mark Rowe <mrowe@apple.com>

Reviewed by Brady.

Plug thousands of node leaks seen running layout tests.

  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Disassociate ourselves from our children so they will be destroyed if we were the only thing referencing them.
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument):
  • ksvg2/svg/SVGUseElement.h:
21:43 Changeset [22823] by aliceli1

Reviewed by Brady.

Fixed <rdar://4949278> cut/copy/paste not working in subframes

  • WebView.cpp: (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled): (WebView::deleteSelection): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyURL): (WebView::delete_): get the focusedOrMainFrame() instead of mainFrame()
21:33 Changeset [19072] by aliceli1

Reviewed by Brady.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): minor change. removing unnecessary call to frame to fetch editor
21:08 Changeset [19071] by aliceli1

release build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
19:44 Changeset [19070] by bdash

2007-01-23 Mark Rowe <mrowe@apple.com>

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

Fix regression by making setTitle/updateTitle/removeTitle logic match document.title
specification at http://whatwg.org/specs/web-apps/current-work/#the-title1.

  • dom/Document.cpp: (WebCore::Document::setTitle): Materialize a title element into the head if one doesn't exist when setting document.title. Also update the contents of the title element when the title is set via document.title. (WebCore::Document::removeTitle): Update the title based on first title element in the head, if one exists. (WebCore::Document::head): Convenience method to retrieve the head element in an HTML document.
  • dom/Document.h:

2007-01-23 Mark Rowe <mrowe@apple.com>

Reviewed by Adele.

Layout tests for http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

  • fast/dom/Document/title-property-creates-title-element-expected.txt: Added.
  • fast/dom/Document/title-property-creates-title-element.html: Added.
  • fast/dom/Document/title-property-set-multiple-times-expected.txt: Added.
  • fast/dom/Document/title-property-set-multiple-times.html: Added.
  • fast/dom/title-text-property-2.html: Remove in reverse order to preserve test behaviour when removing title elements.
  • svg/custom/multiple-title-elements.svg: Added.
18:16 Changeset [19069] by adele

Reviewed by Adam.

Fixed 2 layout tests that I broke with my last checkin.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Use the selected frame to get the WebHTMLView.
  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Added global to keep track of NSEvent used here. (-[WebHTMLView _interceptEditingKeyEvent:]): Check NSEvent against the event used in performKeyEquivalent. We don't want to intercept these events.
17:24 Changeset [19068] by ggaren

build fix

16:17 Changeset [19067] by bdash

Fix typo.

16:17 Changeset [19066] by bdash

2007-01-24 Mark Rowe <mrowe@apple.com>

Build fix for DumpRenderTree.

  • JavaScriptCore.xcodeproj/project.pbxproj: Make JSStringRefCF.h public so it's copied into build framework.
15:38 Changeset [19065] by bdakin

WebCore:

Reviewed by Hyatt.

Follow-up to the fix below for 4843226.

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Has to be recursive or we will miss out on grandchildren!

LayoutTests:

Reviewed by Hyatt.

Updated test for 4843226 to include a grandchild.

  • fast/clip/nestedTransparencyClip-expected.checksum:
  • fast/clip/nestedTransparencyClip-expected.png:
  • fast/clip/nestedTransparencyClip-expected.txt:
  • fast/clip/nestedTransparencyClip.html:
15:37 Changeset [22822] by sfalken

Bump version for submit

15:27 Changeset [19064] by sfalken

New tag.

15:23 Changeset [19063] by oliver

2007-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Fixes dropping of files into safari

  • page/DragController.cpp: (WebCore::DragController::performDrag):
15:11 Changeset [22821] by aliceli1

Fix for <rdar://49233536> shift-pageup in textareas
This fix is pretty much identical to the shift-backspace
one I just did, so I'm piggybacking on that review.

15:06 Changeset [22820] by andersca

WebCoreWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • plugins/win/PluginStreamWin.cpp: Change WebReasonNone to -2, some plugins return -1 to indicate error.


(WebCore::PluginStreamWin::stop):
Just don't clear the loader, stop loading as well.


(WebCore::PluginStreamWin::startStream):
Destroy the stream if newstream returns an error.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): If the call to toString throws an exception, clear it.

WebKitWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • Interfaces/IWebError.idl: Add error code.


  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Cancel loading the main resource.


(WebFrame::windowObjectCleared):
Use toRef.

14:47 Changeset [19062] by andersca

Reviewed by Darin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
14:47 Changeset [19061] by justing

Reviewed by john


<rdar://problem/4947130>
REGRESSION: Items duplicated when moved inside contenteditable element (11766)

  • editing/pasteboard/4947130-expected.checksum: Added.
  • editing/pasteboard/4947130-expected.png: Added.
  • editing/pasteboard/4947130-expected.txt: Added.
  • editing/pasteboard/4947130.html: Added.
14:39 Changeset [22819] by aliceli1

Reviewed Maciej.

fixed <rdar://4923536> pressing shift-backspace inserts a bad character

  • WebView.cpp: added to keyEntries an entry for the commands accounting for modifiers
14:36 Changeset [22818] by sfalken

2007-01-23 Steve Falkenburg <sfalken@apple.com>

Fix release build.

  • WebCore.vcproj/WebCore.vcproj:
14:32 Changeset [19060] by beidson

Reviewed by Darin

Added a couple of CF things previously missed

14:23 Changeset [19059] by ggaren

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h


Also removed remaining API FIXMEs and changed them into Radars.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.
  • API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.
  • API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
  • API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.
  • API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
  • API/JSStringRefCF.h: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
14:11 Changeset [19058] by zimmermann

Reviewed by Maciej.

Fix evil genericContext() assertion, which occours sometimes when running DRT.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12379

13:52 Changeset [19057] by brmorris

ssareen <shyam.sareen@nokia.com>

Reviewed by Sachin/Brad.


DESC: Invalid WAP CSS formats not being ignored ( TSW ID: TMCN-6S5K87)
http://bugs.webkit.org/show_bug.cgi?id=12230

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (CInputFormatHandler::ConstructL):
13:50 Changeset [22817] by adele

WebCoreWin:

Reviewed by Adam.

Added call to paintThemeTextArea.

13:45 Changeset [19056] by bdakin

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4843226> REGRESSION: Pull down menu appears
clipped at http://istweb.apple.com/

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Always unite with sibling rects.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4843226> REGRESSION: Pull down menu
appears clipped at http://istweb.apple.com/

  • fast/clip/nestedTransparencyClip-expected.checksum: Added.
  • fast/clip/nestedTransparencyClip-expected.png: Added.
  • fast/clip/nestedTransparencyClip-expected.txt: Added.
  • fast/clip/nestedTransparencyClip.html: Added.
13:10 Changeset [19055] by justing

LayoutTests:

Reviewed by john


<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteEx

WebCore:

Reviewed by john

<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteExtract()

  • dom/Range.cpp: (WebCore::Range::checkDeleteExtract): Return if there is no commonAncestor container or if commonAncestorContainer() throws an exception.
  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Fixed a bug that reversed the order of the selected paragraphs.
12:55 Changeset [19054] by brmorris

sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: WAP CSS specific character format causing phone keypad input error ( TSW ID: TMCN-6S5MSE)
http://bugs.webkit.org/show_bug.cgi?id=12232

12:31 Changeset [19053] by brmorris

raalexan

Reviewed by Sachin
DESC: MLIO-6XLCE4 Returning from page overview shows the toolbar
http://bugs.webkit.org/show_bug.cgi?id=id=12366

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
12:21 Changeset [19052] by brmorris

w3liu <wei.liu@nokia.com>

Reviewed by Zalan, landed by Brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites
http://bugzilla.opendarwin.org/show_bug.cgi?id=12371

12:19 Changeset [19051] by brmorris

w3liu <wei.liu@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites

http://bugs.webkit.org/show_bug.cgi?id=12371

12:04 Changeset [19050] by zimmermann

Reviewed by Sam.

Fix dynamic creation/updates of markers, masks, clipPaths, and several tiny pattern issues.
Added 16 (!) new layout tests covering quite some weird scenerios - Batik & Opera do have problems, we don't.

11:48 Changeset [22816] by adele

Reviewed by Darin.


Reorganized some event handling code for keyPress events to
prepare for another fix.


  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Added.
  • WebEditorClient.h: Removed unnecessary forward declarations.
11:37 Changeset [19049] by adele

WebCore:

Reviewed by Darin.


WebCore part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail

In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix. There's also just a little bit of unrelated cleanup.


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Move tab focus behavior into new defaultKeyboardEventHandler method.


  • bridge/EditorClient.h: Added handleKeyPress.
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Added. Calls over to the client method. (WebCore::Editor::deleteRange): Removed unnecessary propogateDOMException.
  • editing/Editor.h: Added handleKeyPress. (WebCore::Editor::addToKillRing): Formatting cleanup.
  • editing/mac/EditorMac.mm: Removed unnecessary propogateDOMException.


  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added. Checks the tabKeyCyclesThroughElements setting before advancing focus for tab key events. Calls handleKeyPress.
  • page/EventHandler.h: Added defaultKeyboardEventHandler.


  • page/Page.cpp: (WebCore::Page::Page): Initialize m_tabKeyCyclesThroughElements to true.
  • page/Page.h: Added m_tabKeyCyclesThroughElements. (WebCore::Page::setTabKeyCyclesThroughElements): Added. (WebCore::Page::tabKeyCyclesThroughElements): Added.


  • platform/PlatformKeyboardEvent.h: Added ability to get NSEvent from PlatformKeyboardEvent.
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize m_macEvent to the NSEvent.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail


In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix.

  • WebCoreSupport/WebEditorClient.h: Added handleKeyPress method.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Added. Code moved from WebHTMLView keyDown method. This is called from the defaultEventHandler so that in the future, we can make the right decision about which selection the keyPress should apply to.
  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Moved _interceptEditingKeyEvent call to handleKeyPress. (-[WebHTMLView _interceptEditingKeyEvent:]): Prevents intercepting keys for cmd-modified events. Removed tabCycling checks since this is now handled in WebCore.
  • WebView/WebHTMLViewInternal.h: Made _interceptEditingKeyEvent SPI.
  • WebView/WebView.mm: Use new tabKeyCyclesThroughElements methods on the page. (-[WebViewPrivate init]): ditto. (-[WebView setTabKeyCyclesThroughElements:]): ditto. (-[WebView tabKeyCyclesThroughElements]): ditto. (-[WebView setEditable:]): ditto
10:36 Changeset [19048] by staikos

Temporary measure to make it possible to use the Qt port until the official Qt
API is done

10:24 Changeset [22815] by andersca

WebCoreWin:

Build fixes.


  • WebCore.vcproj/WebCore.vcproj: Copy plugin and JS headers.


  • loader/win/FrameLoaderWin.cpp: Move functions to WebKitWin.

WebKitWin:

Build fixes.


  • WebFrame.cpp: (WebFrame::createFrame): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::objectContentType): (WebFrame::overrideMediaType): (WebFrame::windowObjectCleared):
  • WebFrame.h: Move functions here from WebFrameLoaderWin in WebCore.
10:18 Changeset [19047] by staikos

Compile with a released Qt.

08:35 Changeset [19046] by lars

Reviewed by Zack

Widget and ScrollView do not own the Qt widgets
anymore. Make sure they can handle the case of
a null QWidget and never delete them.

Fix refcounting of FrameViews (they get created with a
refcount of 1) and add a few safety checks to the
FrameLoaderClientQt.

06:35 Changeset [19045] by zack

Forgot to add this file to the build (fix the build for real)

05:39 Changeset [19044] by zack

Adjust the DragClient to latest changes.

02:32 Changeset [19043] by zack

Fix the Qt build

02:28 Changeset [19042] by lars

Reviewed by Maciej

Make the last remaining pieces of the FrameLoader platform
independent. Move most of the code over to WebFrameLoaderClient.
Some smaller cleanups in the WebFrameBridge, and moved some
platform independent functionality over to the shared code
in WebCore.

Add support for Frames to the Qt build and fix some issues
in the API classes.

01:33 Changeset [22814] by oliver

2007-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.


WebKitWin:

Attaching the DragController logic to the WebView

  • Interfaces/IWebUIDelegate.idl: Fixed a couple of function definitions to use IDataObject instead of IDropSource
  • WebDragClient.cpp: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction):
  • WebDragClient.h: Added. DragClient implementation.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (dragOperationToDragCursor): (keyStateToDragOperation): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop): Set up and register WebView as an IDropTarget, and pass off drag events to the DragController
  • WebView.h: Ditto


WebCoreWin:

  • WebCore.vcproj/WebCore.vcproj:
  • page/win/DragControllerWin.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): Platform specific implementation
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::isForDragging):
  • platform/win/ClipboardWin.h: Migrated common Clipboard functionality from ClipboardMac/Win -> Clipboard
  • platform/win/DragDataWin.cpp: Added. (WebCore::DragData::createClipboard): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::DragData::containsURL): (WebCore::extractURL): (WebCore::DragData::asURL): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::containsHTML): (WebCore::fragmentFromHTML): (WebCore::containsFilenames): (WebCore::fragmentFromFilenames): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor): Implementation of DragData accesor methods, and helper functions
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
  • platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment): Pulled out CF_HTML parsing to a seperate function so logic can be shared with DragDataWin


01:15 Changeset [19041] by oliver

2007-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Qt build stubs for Drop logic

  • WebCoreSupport/DragClientQt.cpp: Added. (WebCore::DragClientQt::actionMaskForDrag): (WebCore::DragClientQt::willPerformDragDestinationAction):
  • WebCoreSupport/DragClientQt.h: Added.
  • WebKitPart/WebKitPart.cpp: (WebKitPart::initView):
01:14 Changeset [19040] by oliver

2007-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Drop logic bindings for WebKit

  • WebCoreSupport/WebDragClient.h: Added.
  • WebCoreSupport/WebDragClient.mm: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): Standard client impl
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Updated to use DragController to track drag state


  • WebCoreSupport/WebPasteboardHelper.h: Added. (WebPasteboardHelper::WebPasteboardHelper): A *temporary* Helper class to access NSPasteboard access and manipulation functions present in WebKit
  • WebCoreSupport/WebPasteboardHelper.mm: Added. (WebPasteboardHelper::urlFromPasteboard): (WebPasteboardHelper::plainTextFromPasteboard): (WebPasteboardHelper::fragmentFromPasteboard): (WebPasteboardHelper::insertablePasteboardTypes): See header comment
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h: Remove unnecessary protocol
  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): Updating to use DragController to track drag state
  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): ditto (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): ditto (-[WebHTMLView draggingSourceOperationMaskForLocal:]): ditto (-[WebHTMLView draggedImage:endedAt:operation:]): ditto (-[WebHTMLView _documentFragmentForPasteboard:]): Helper method to generate DocumentFragment from NSPasteboard without regressing (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Updating to use DragController to track drag state (-[WebHTMLView _isMoveDrag:]): (-[WebHTMLView _isNSColorDrag:]):
  • WebView/WebHTMLViewInternal.h: Removing unnecessary fields and methods
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Remove obsolete ASSERT (-[WebView _setInitiatedDrag:]): Now passes directly through to DragController (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _loadingDragOperationForDraggingInfo:]): Removed (-[WebView draggingEntered:]): Updated to use DragController (-[WebView draggingUpdated:]): ditto (-[WebView draggingExited:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView _hitTest:dragTypes:]):
  • WebView/WebViewInternal.h: remove unnecessary method def
01:12 Changeset [19039] by oliver

2007-01-23 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Added DragController to handled drag and drop state and control logic.
Currently this only handles logic for Dragging and Dropping, and is
unable to initialise a drag itself.

platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac,
QMimeType in Qt). This provides methods to pull data out the drag data as a String,
a URL, a DocumentFragment (for rich content), or a Colour.

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.cpp: Added. (WebCore::Clipboard::setAccessPolicy): (WebCore::dragOpFromIEOp): (WebCore::IEOpFromDragOp): (WebCore::Clipboard::sourceOperation): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setSourceOperation): (WebCore::Clipboard::setDestinationOperation): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed): move platform independent functions from ClipboardMac to Clipboard
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::effectAllowed): (WebCore::Clipboard::policy): as above -- also removed virtual modifier from now platform independent methods
  • editing/Editor.cpp: (WebCore::Editor::smartInsertDeleteEnabled): (WebCore::Editor::shouldApplyStyle):
  • editing/Editor.h: adding calls through to EditorClient


  • page/DragActions.h: Added. (WebCore::): Replicates a number of NS* enums in the WebCore namespace
  • page/DragClient.h: Added. (WebCore::DragClient::~DragClient): Standard client interface for dragging UIDelegate
  • page/DragController.cpp: Added. (WebCore::createMouseEvent): (WebCore::DragController::DragController): (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::isMoveDrag): (WebCore::visiblePositionForPoint): (WebCore::DragController::cancelDrag): (WebCore::documentAtPoint): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): Class to handle state and logic for dragging and dropping
  • page/DragController.h: Added. (WebCore::DragController::client): (WebCore::DragController::didInitiateDrag): (WebCore::DragController::isHandlingDrag): (WebCore::DragController::dragOperation): (WebCore::DragController::document): (WebCore::DragController::dragInitiator): (WebCore::DragController::dragDestinationAction): (WebCore::DragController::dragSourceAction): (WebCore::DragController::dragEnded): (WebCore::DragController::setIsHandlingDrag): (WebCore::DragController::setDidInitiateDrag): (WebCore::DragController::setDragOperation): (WebCore::DragController::setDragSourceAction): (WebCore::DragController::setDragInitiator): See above
  • page/Page.cpp: (WebCore::Page::Page): Update Page to have DragController
  • page/Page.h: (WebCore::Page::dragController): ditto
  • page/mac/DragControllerMac.mm: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Platform specific portions of the DragController
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::dragSourceEndedAt): Convert from NSDragOperation to WebCore::DragOperation
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Remove obsolete Drag functions
  • page/qt/DragControllerQt.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Basic stubs to maintain Qt build
  • platform/DragData.cpp: Added. (WebCore::DragData::DragData):
  • platform/DragData.h: Added. (WebCore::DragData::clientPosition): (WebCore::DragData::globalPosition): (WebCore::DragData::platformData): (WebCore::DragData::draggingSourceOperationMask): DragData class to encapsulate platform drag data/event
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Addition of dummy DragClient
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::~SVGEmptyDragClient): (WebCore::SVGEmptyDragClient::willPerformDragDestinationAction): (WebCore::SVGEmptyDragClient::actionMaskForDrag): (WebCore::SVGEmptyDragClient::dragControllerDestroyed): ditto
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): Moving platform independent logic to Clipboard, and updating platform specific methods to use appropriate accessors rather than directly manipulating data they no longer own
  • platform/mac/DragDataMac.mm: Added. (WebCore::DragData::DragData): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::imageExistsAtPaths): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Mac implementations of DragData methods. A number of these use a Helper class that accesses WebKit functionality. That functionality should be migrated to WebCore in the future.
  • platform/mac/PasteboardHelper.h: Added. (WebCore::PasteboardHelper::~PasteboardHelper): Temporary, and Mac only, helper class to access WebKit functionality from WebCore
  • platform/qt/DragDataQt.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Basic stubs to maintain Qt build
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Correct HitTestResult copy contructor to copy localPoint

01/22/07:

23:00 Changeset [22813] by aroben

WebCoreWin:

Reviewed by Adele.

Implemented search field painting, and did some cleanup.

20:00 Changeset [19038] by bdash

2007-01-22 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

  • dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.
18:23 Changeset [22812] by andersca

Reviewed by Adam.


<rdar://problem/4771115>
Windows Media Player plugin crashes.

  • WebCore.vcproj/WebCore.vcproj: Formatting changes.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add Windows Media Player path.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream):
  • plugins/win/PluginStreamWin.h: New function which sends a JavaScript result stream and handles any errors that the plug-in returns.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call NPP_SetWindow, some plugins (like WMP) relies on it.


(WebCore::PluginViewWin::performRequest):
If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
The Windows Media Player plugin calls javascript:document.location and expects to get the location back.

17:36 Changeset [19037] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-selection-2-expected.checksum: Added.
  • fast/forms/listbox-selection-2-expected.png: Added.
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-selection-2.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight() since items are visible only in the content box. (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and borders. Changed to return -1 instead of the last item's index if the given offset is below the last item. (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders. (WebCore::RenderListBox::controlClipRect): Changed to return the content box since items should not spill into the padding box. This change is the reason the test generates pixel results.
17:30 Changeset [19036] by justing

LayoutTests:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

The fixes not only make this test pass, but also fix a bug that
was reflected in the results checked in for this test. The caret
was in the wrong position:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt: Added:
  • editing/pasteboard/4944770-1-expected.checksum: Added.
  • editing/pasteboard/4944770-1-expected.png: Added.
  • editing/pasteboard/4944770-1-expected.txt: Added.
  • editing/pasteboard/4944770-1.html: Added.
  • editing/pasteboard/4944770-2-expected.checksum: Added.
  • editing/pasteboard/4944770-2-expected.png: Added.
  • editing/pasteboard/4944770-2-expected.txt: Added.
  • editing/pasteboard/4944770-2.html: Added.
  • editing/pasteboard/4944770-expected.checksum: Added.
  • editing/pasteboard/4944770-expected.png: Added.
  • editing/pasteboard/4944770-expected.txt: Added. Equivalent render trees:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Fixed:
  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)


This layout test failure demonstrates three bugs:
Smart replace shouldn't be turned on, but is because a word
selection granularity from the previous test isn't cleared.
Smart replace shouldn't add any spaces because the paste is performed
in an empty paragraph.
Smart replace spaces are added to the text of options inside
the select element instead of before/after the select element.


This patch fixes the second two problems. During a
ReplaceSelectionCommand, the VisiblePosition for the end of
the inserted content is the last position in the last leaf
inserted. This is a problem when the last leaf is inside a
select element, since VP creation is inconsistent there.
Second, smart spaces were inserted inside the last leaf, not
at the endOfInsertedContent.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed m_lastNodeInserted to m_lastLeafInserted. Use the start/endOfInsertedContent getters. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto. (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added. Special case for when the last leaf inserted is inside a select element: return the VisiblePosition after the select element. (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added. (WebCore::ReplaceSelectionCommand::doApply): Did renaming. Used the start/endOfInsertedContent getters. Insert smart replace spaces into the right nodes. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto. (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
  • editing/ReplaceSelectionCommand.h:
16:51 Changeset [22811] by darin
  • WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.
  • platform/win/FileChooserWin.cpp: Removed many now-unneeded functions. (WebCore::FileChooser::FileChooser): Updated for changed parameters and members. (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and find the FrameView from that instead of the upload control. (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.
16:46 Changeset [22810] by aroben

WebKitWin:

Reviewed by Anders, Brady, and Steve.

WebKit part of <rdar://problem/4601321> HTTP Authentication Alerts

Made WebURLCredential use a registered CLSID so the app can get instantiate it:

  • Interfaces/IWebURLAuthenticationChallenge.idl: Changed method name.
  • Interfaces/WebKit.idl: Added GUIDs for WebURLCredential.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added case for WebURLCredential.
  • WebKitDLL.cpp: Added WebURLCredential and WebError (it was omitted from r11821). (DllGetClassObject):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Changed to use CLSID, and return the failing HRESULT. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Changed to return the failing HRESULT.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: Removed IID definition. (WebURLCredential::QueryInterface): Switched to use CLSID. (WebURLCredential::initWithUser): Updated method name.
  • WebURLCredential.h: Ditto.
16:40 Changeset [19035] by darin

Reviewed by Adam.

  • made more of the file chooser code cross-platform
  • fixed an Objective-C garbage collection problem in FileChooser
  • tried to remove layering violations where FileChooser in the platform directory knows about the rendering and DOM trees (but wasn't able to do it entirely)
  • platform/FileChooser.cpp: Added. (WebCore::FileChooser::create): Changed parameters. (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function. (WebCore::FileChooser::chooseIcon): Added.
  • platform/FileChooser.h: Added FileChooserClient so this file doesn't have to know about RenderFileUploadControl. Used RetainPtr instead of retain/release so this works properly with Objective-C GC. Replaced disconnectUploadControl with disconnectClient, which has a simple inline implementation. Moved the Document parameter from the constructor to openFileChooser, along with a comment about why it should not be there. Added a filename parameter to the constructor for the initial filename. Added a font parameter to basenameForWidth so we don't depend on having a pointer to the renderer. Removed the uploadControl() and document() functions since no one calls either of them.
  • platform/mac/FileChooserMac.mm: Removed code that is now cross-platform. (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead of storing a document pointer in the FileChooser. (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added code to choose the icon based on the initial filename. Pass the adopt parameter to the constructor of the RetainPtr. (WebCore::FileChooser::~FileChooser): Removed the release call, since the RetainPtr will take care of it. Added a call to disconnectFileChooser here. There's no need to disconnect at disconnectClient time, and that lets us have one more cross-platform function. (WebCore::FileChooser::openFileChooser): Added document parameter. Added code to get the frame from the document. And added a nil check since there's no ironclad guarantee the document won't have outlived its frame. (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead of going at the upload control's style. The caller can handle that now.
  • rendering/RenderFileUploadControl.h: Removed unnecessary includes. Made class inherit privately from FileChooserClient. Changed constructor parameter to HTMLInputElement rather than Node. Made protected members be private instead, and made a couple function members const.
  • rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file, but after the "using namespace" (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes to the FileChooser::create function and the parameter types. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded null check -- there's no case where the FileChooser fails to be created. (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser. (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by using updateFromElement and setValue instead of casting the renderer to a RenderButton and calling setText directly. Put setInputType call here. (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line. (WebCore::RenderFileUploadControl::createButtonStyle): Made const. (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant to the top of the file. Call isEmpty instead of checking width and height of IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke long lines. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): Moved the setInputType call to the caller; concept here is that this class is as simple as possible, rather than doing as much of the button job as possible.
  • WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
  • WebCore.pro: Ditto.
  • CMakeLists.txt: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
  • platform/qt/FileChooserQt.cpp: Updated stubs.
15:39 Changeset [22809] by sfalken

2007-01-22 Steve Falkenburg <sfalken@apple.com>

Updated strings not to be localized, added native line endings svn flag.

14:51 Changeset [19034] by bdakin

Reviewed by Darin.

Darin and I looked into these tests that are adding an empty
RenderText, and we think they just need new results. Here they are!

  • editing/execCommand/find-after-replace-expected.txt:
  • fast/css/beforeSelectorOnCodeElement-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/select-size-expected.txt:
13:46 Changeset [22808] by andersca

Reviewed by Adam.

<rdar://problem/4903230>
Boomer crashes at Flickr website when "View as slideshow" is clicked.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): Return null if m_plugin is null (which it can be if the plugin failed to load).
13:37 Changeset [19033] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-item-background-clip-expected.checksum: Added.
  • fast/forms/select-item-background-clip-expected.png: Added.
  • fast/forms/select-item-background-clip-expected.txt: Added.
  • fast/forms/select-item-background-clip.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-item-background-clip.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with the list box's clip rect.
13:28 Changeset [19032] by sullivan
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow
13:15 Changeset [19031] by darin

Reviewed by Beth.

I caused this a few hours ago. Oops!

  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Compute whether the font changed before calling RenderObject::setStyle.
13:09 Changeset [19030] by sullivan

Reviewed by Adam and Darin

  • fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit (need to adopt new API)
  • Misc/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): random typo correction in comment
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes
  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): new function to convert an AppKit screen point to a CG screen point (-[WebHTMLView _lookUpInDictionaryFromMenu:]): on Leopard now uses new API. There's something of an impedance mismatch between this API and WebKit, but that was true for the SPI we were using in Tiger also. Bug 4945808 covers the ways in which this is not perfect.
13:01 Changeset [22807] by andersca

Reviewed by Brady.

  • Interfaces/IWebError.idl: Clean up the IWebError interface.


  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Make it possible for clients to create WebErrors.


  • WebError.cpp: (WebError::QueryInterface): (WebError::init):
  • WebError.h:
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Get rid of IID_WebError and use CLSID_WebError instad.


  • WebView.cpp: (WebView::canHandleRequest): Return true for "about" URLs.


(WebView::canHandleRequest):
Add private COM method.


(WebView::close):
Reset the policy delegate.

12:54 Changeset [19029] by bdakin

Reviewed by Maciej.

Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
WebCore::Frame::eventHandler() after clicking to dismiss a
contextual menu on the page

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.
10:42 Changeset [22806] by andersca

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:10 Changeset [22805] by aroben

Moved ifdefs to match Darin's suggestion.

09:39 Changeset [19028] by darin

Reviewed by Mitz.

  • a couple tiny tweaks to make --reset-results work better
  • Scripts/run-webkit-tests: Always generate results when --reset-results is specified. Don't make a separate "new" entry while generating results when --reset-results is specified since new results are the norm in that case.
09:30 Changeset [22804] by aroben

Build fix.

09:28 Changeset [19027] by darin

LayoutTests:

Test by Andrew Wellington <proton@wiretapped.net>.
Reviewed by Darin.


  • fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
  • fast/css/beforeSelectorOnCodeElement.html: Added.

Test by Mitz.
Reviewed by Darin.

  • test for monospace problem mentioned in the above bug


  • fast/text/monospace-width-cache-expected.checksum: Added.
  • fast/text/monospace-width-cache-expected.png: Added.
  • fast/text/monospace-width-cache-expected.txt: Added.
  • fast/text/monospace-width-cache.html: Added.

WebCore:

Reviewed by Mitz.

Inspired by a much simpler patch by Andrew Wellington <proton@wiretapped.net>.

Test: fast/css/beforeSelectorOnCodeElement.html

  • fix regression I recently introduced where the monospace cache could be used for text that was not ASCII, if text was changed after the style was set

Test: fast/text/monospace-width-cache.html

  • streamline RenderText.h -- remove unneeded functions, make some needlessly virtual functions non-virtual, remove unneeded header includes, replace use of Font* with Font& for consistency with RenderStyle, use "text" consistently instead of "string"
  • rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend declaration for InlineTextBox. Changed constructor to take a PassRefPtr since we do take owership of the passed-in text. Made deleteTextBoxes() private. Removed unneeded data(). Made override of length() private so people will use the faster textLength() instead. Renamed string() to text() so it matches up better with setText(). Same for stringLength(), originalString(), and setInternalString(), which are now textLength(), originalText(), and setTextInternal(). Renamed the old text() function to characters(), since it returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere. Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and made it non-virtual since it's not overriden anywhere. Also made the trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private. Removed both font() functions (one was needlessly virtual) and element(). Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made it an inline function. Removed the m_allAsciiChecked flag and renamed the m_allAscii flag to m_isAllASCII.
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked. Initialize m_isAllASCII. Changed all occurrences of m_str->length() and m_str->characters () to use the stringLength() and characters() inline functions instead. (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths with a conditional call to updateMonospaceCharacterWidth. This speeds up the common case where style is changed without changing the font. (WebCore::RenderText::originalText): Changed code to not depend on overridden element() function with casts to a Text node -- this was one of only two call sites. Also renamed. (WebCore::RenderText::positionForCoordinates): Name change. (WebCore::RenderText::caretRect): Ditto. (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and incorporate the check that was formerly in a separate shouldUseMonospaceCache function. (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*. Changed to take advantage of the fact that the string is known to be all ASCII in the m_monospaceCharacterWidth code path. (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead of font(false). (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead of SOFT_HYPHEN. (WebCore::RenderText::containsOnlyWhitespace): More of the same. (WebCore::RenderText::setSelectionState): Ditto. (WebCore::RenderText::setTextWithOffset): Ditto. (WebCore::isInlineFlowOrEmptyText): Ditto. (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere (or'ing all the characters together), and to call updateMonospaceCharacterWidth if the "all ASCII"-ness of the text changes. (WebCore::RenderText::setText): Updated for name changes. (WebCore::RenderText::width): More like above. (WebCore::RenderText::selectionRect): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.
  • dom/Position.cpp:
  • dom/Range.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/VisiblePosition.cpp:
  • html/HTMLElement.cpp: Added now-needed include of "Text.h" which is no longer included by "RenderText.h".
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Update for name changes of stringLength(), string(), and originalString() to textLength(), text(), and originalText(), and to always use textLength() instead of length() when we have a RenderText* rather than a RenderObject*.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the RenderObject::font() function and replaced it with explicit access to the style. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Ditto. (WebCore::InlineTextBox::isLineBreak): Ditto. (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::selectionStartEnd): Ditto. (WebCore::InlineTextBox::paintSelection): Ditto. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Ditto.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText): Ditto. (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
  • rendering/RenderCounter.h: Ditto.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Ditto.
  • rendering/RenderTextFragment.h: Ditto.
  • rendering/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): Ditto. (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
  • rendering/bidi.cpp: (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiIterator::current): Ditto. (WebCore::BidiIterator::direction): Ditto. (WebCore::addRun): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::skipWhitespace): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  • rendering/RenderBR.h: Updated signature of width function which now takes a Font& instead of a Font*.
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer use the RenderObject::font() function, and added a comment about first-line, which is not handled properly here.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun): Eliminated use of RenderText::data().
  • rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of having everyone pass in a boolean rather than using the cleaner style() and firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font() with direct use of the style instead, which is arguably easier to understand anyway. (WebCore::RenderObject::baselinePosition): Ditto.
06:38 Changeset [19026] by weinig

Reviewed by The Mitz.

Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
where it belongs.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Added.
02:54 Changeset [19025] by zack

Fix Qt build

01/21/07:

22:54 Changeset [22803] by aroben

WebCoreWin:

Reviewed by Maciej.

Implemented drawing button states and control sizes.

21:23 Changeset [19024] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=10934
REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds

Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.

Test: fast/dom/Window/element-constructors-on-window.html

  • DerivedSources.make: Generate JSHTMLSelectElement.
  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code to be happy, and rewrote it using cacheDOMObject.
  • bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl: Generate constructors.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::length):
  • html/HTMLSelectElement.h: Make length() return unsigned for auto-generated code to be happy.
  • html/HTMLSelectElement.idl: Adjusted to be usable for JS.
  • bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().
  • page/DOMWindow.idl: Added properties for most elements' constructors.
20:54 Changeset [22802] by aroben

WebCoreWin:

Reviewed by Maciej.

19:45 Changeset [19023] by bdash

2007-01-21 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12357
Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc

  • page/Frame.cpp: (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to a deleted settings object being used.
18:46 Changeset [19022] by darin

Reviewed by Maciej.

  • fix <rdar://problem/4930503> REGRESSION: Page changes title when command-clicking on named anchor link (12299)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Return if shouldContinue is false. This matches the other similar functions and prevents us from doing extra work in the "ignore" case.
18:16 Changeset [19021] by bdash

2007-01-21 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12355
Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.
17:41 Changeset [22801] by adele

WebCoreWin:

Reviewed by Adam.

Adding RenderThemeSafari.


17:33 Changeset [19020] by darin

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-disabled-appearance-expected.checksum: Added.
  • fast/forms/select-disabled-appearance-expected.png: Added.
  • fast/forms/select-disabled-appearance-expected.txt: Added.
  • fast/forms/select-disabled-appearance.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-disabled-appearance.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle):
17:17 Changeset [19019] by darin
  • fix non-Mac builds
  • CMakeLists.txt: Added JSDocumentCustom.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
17:09 Changeset [19018] by darin

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt: Added.
  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html: Added.

WebCore:

Reviewed by Darin.


Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html

  • bindings/js/kjs_html.cpp: (KJS::ImageConstructorImp::construct): Protect the image element before setting its attributes.
16:54 Changeset [22800] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added JSDocumentCustom.cpp.
16:53 Changeset [19017] by darin

Reviewed by Tim H.

  • WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor instead of move. It's a horizontal splitter resizer.
15:42 Changeset [19016] by weinig

LayoutTests:

Rolling out patch for http://bugs.webkit.org/show_bug.cgi?id=8360.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Removed.
  • fast/layers/removed-by-scroll-handler-expected.png: Removed.
  • fast/layers/removed-by-scroll-handler-expected.txt: Removed.
  • fast/layers/removed-by-scroll-handler.html: Removed.

WebCore:

Rolling out patch for http://bugs.webkit.org/show_bug.cgi?id=8360.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
14:07 Changeset [19015] by ddkilzer

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-all-select-expected.txt: Added.
  • fast/dom/document-all-select.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-all-select.html

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
13:03 Changeset [19014] by weinig

Reviewed by Darin.

  • manual-tests/onblur-remove.html: Changed the test to not require pressing Enter, since the correct behavior for Enter is to send a blur event.
12:51 Changeset [19013] by weinig

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

  • fast/dom/gc-10-expected.txt: Added.
  • fast/dom/gc-10.html: Added.
  • fast/dom/resources/gc-10-frame.html: Added.

WebCore:

Reviewed by Darin.

Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.

Test: fast/dom/gc-10.html

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: Added. (WebCore::JSDocument::mark):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • dom/Document.idl:

WebKitTools:

Reviewed by Darin.

Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/GCController.mm: (+[GCController isSelectorExcludedFromWebScript:]): (-[GCController getJSObjectCount]):
12:29 Changeset [19012] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/overflow/position-relative-expected.checksum: Added.
  • fast/overflow/position-relative-expected.png: Added.
  • fast/overflow/position-relative-expected.txt: Added.
  • fast/overflow/position-relative.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/overflow/position-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Add the relative position offset only if 'includeSelf' is true. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Ditto. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
09:19 Changeset [19011] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-detached.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/HTMLSelectElement/options-collection-detached.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection info if the <select> is not in the document. For in-document <select>s this happens anyway as a result of the DOM tree version increasing.
09:05 Changeset [19010] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/file-input-disabled-expected.png:
  • fast/forms/file-input-disabled-expected.txt:

WebCore:

Reviewed by Darin.

Covered by fast/forms/file-input-disabled.html

  • css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's style with its parent's style. getPseudoStyle() handles inheritance properly.
08:55 Changeset [19009] by weinig

Reviewed by Darin.

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
08:20 Changeset [19008] by darin

Reviewed by Adam and Mitz.

Covered by existing test: fast/forms/listbox-selection.html

  • rendering/RenderListBox.h: Added override of layout(), made selectionChanged() no longer an inline. Added private scrollToRevealSelection(), m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): Initialize new data members. (WebCore::RenderListBox::updateFromElement): Remove scrolling code. (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint and then scrollToRevealSelection, but if we need layout, instead schedules scrollToRevealSelection to be done after layout. (WebCore::RenderListBox::layout): Added. After calling base class, calls scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set. (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally in updateFromElement. (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the selectionChanged function knows not to scroll. Also removed the repaint() here because updateListBoxSelection() takes care of repainting by calling selectionChanged().
05:07 Changeset [19007] by ddkilzer

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

01/20/07:

16:44 Changeset [19006] by weinig

LayoutTests:

Reviewed by Maciej.

  • fast/forms/text-set-value-crash-expected.txt: Added.
  • fast/forms/text-set-value-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/text-set-value-crash.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Ditto.
16:35 Changeset [19005] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/layers/removed-by-scroll-handler.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer fires and dispatches the scroll event to the layer's element. (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll event from this function, which is called during layout, schedule a 0-duration timer to dispatch the event after layout. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
15:45 Changeset [19004] by zimmermann

Forgot to include the new layout tests in the last commit.

15:40 Changeset [19003] by zimmermann

Reviewed by Sam.

Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.

Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
didn't work. Existing gradient updating examples relied on calling setAttribute
after a SVG DOM update - that was the only reason it worked, added a new test
only using SVG DOM updates (js-update-stop.svg).

13:52 Changeset [19002] by rwlbuis

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=12334
Respect <text> boundaries for svg text selecting

Make sure the text selection for svg stays inside
containing blocks.
Added one manual test since html selection does not
seem to work for SVG and selectSubString for SVG
is not implemented yet.

07:03 Changeset [19001] by darin
  • updated results because my recent check-in made list boxes one pixel taller
  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/listbox-width-change-expected.txt:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.txt:
  • fast/replaced/replaced-breaking-expected.checksum:
  • fast/replaced/replaced-breaking-expected.png:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/text/updateNewFont-expected.checksum:
  • fast/text/updateNewFont-expected.png:
  • fast/text/updateNewFont-expected.txt:
  • reset results since the ones I generated before were on Leopard
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • generated some missing pixel results
  • http/tests/navigation/anchor-basic-expected.checksum: Added.
  • http/tests/navigation/anchor-basic-expected.png: Added.
  • http/tests/navigation/anchor-frames-expected.checksum: Added.
  • http/tests/navigation/anchor-frames-expected.png: Added.
  • http/tests/navigation/anchor-goback-expected.checksum: Added.
  • http/tests/navigation/anchor-goback-expected.png: Added.
  • http/tests/navigation/anchor-subframeload-expected.checksum: Added.
  • http/tests/navigation/anchor-subframeload-expected.png: Added.
  • http/tests/navigation/error404-basic-expected.checksum: Added.
  • http/tests/navigation/error404-basic-expected.png: Added.
  • http/tests/navigation/error404-frames-expected.checksum: Added.
  • http/tests/navigation/error404-frames-expected.png: Added.
  • http/tests/navigation/error404-goback-expected.checksum: Added.
  • http/tests/navigation/error404-goback-expected.png: Added.
  • http/tests/navigation/error404-subframeload-expected.checksum: Added.
  • http/tests/navigation/error404-subframeload-expected.png: Added.
  • http/tests/navigation/javascriptlink-basic-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-basic-expected.png: Added.
  • http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • http/tests/navigation/javascriptlink-goback-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-goback-expected.png: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.png: Added.
  • http/tests/navigation/metaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/metaredirect-basic-expected.png: Added.
  • http/tests/navigation/metaredirect-frames-expected.checksum: Added.
  • http/tests/navigation/metaredirect-frames-expected.png: Added.
  • http/tests/navigation/metaredirect-goback-expected.checksum: Added.
  • http/tests/navigation/metaredirect-goback-expected.png: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.png: Added.
  • http/tests/navigation/post-basic-expected.checksum: Added.
  • http/tests/navigation/post-basic-expected.png: Added.
  • http/tests/navigation/post-frames-expected.checksum: Added.
  • http/tests/navigation/post-frames-expected.png: Added.
  • http/tests/navigation/post-goback1-expected.checksum: Added.
  • http/tests/navigation/post-goback1-expected.png: Added.
  • http/tests/navigation/post-goback2-expected.checksum: Added.
  • http/tests/navigation/post-goback2-expected.png: Added.
  • http/tests/navigation/postredirect-basic-expected.checksum: Added.
  • http/tests/navigation/postredirect-basic-expected.png: Added.
  • http/tests/navigation/postredirect-frames-expected.checksum: Added.
  • http/tests/navigation/postredirect-frames-expected.png: Added.
  • http/tests/navigation/postredirect-goback1-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback1-expected.png: Added.
  • http/tests/navigation/postredirect-goback2-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback2-expected.png: Added.
  • http/tests/navigation/redirect302-basic-expected.checksum: Added.
  • http/tests/navigation/redirect302-basic-expected.png: Added.
  • http/tests/navigation/redirect302-frames-expected.checksum: Added.
  • http/tests/navigation/redirect302-frames-expected.png: Added.
  • http/tests/navigation/redirect302-goback-expected.checksum: Added.
  • http/tests/navigation/redirect302-goback-expected.png: Added.
  • http/tests/navigation/redirect302-subframeload-expected.checksum: Added.
  • http/tests/navigation/redirect302-subframeload-expected.png: Added.
  • http/tests/navigation/relativeanchor-basic-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-basic-expected.png: Added.
  • http/tests/navigation/relativeanchor-frames-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-frames-expected.png: Added.
  • http/tests/navigation/relativeanchor-goback-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-goback-expected.png: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.png: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.png: Added.
  • http/tests/navigation/success200-basic-expected.checksum: Added.
  • http/tests/navigation/success200-basic-expected.png: Added.
  • http/tests/navigation/success200-frames-expected.checksum: Added.
  • http/tests/navigation/success200-frames-expected.png: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.png: Added.
  • http/tests/navigation/success200-goback-expected.checksum: Added.
  • http/tests/navigation/success200-goback-expected.png: Added.
  • http/tests/navigation/success200-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-loadsame-expected.png: Added.
  • http/tests/navigation/success200-reload-expected.checksum: Added.
  • http/tests/navigation/success200-reload-expected.png: Added.
  • http/tests/navigation/success200-subframeload-expected.checksum: Added.
  • http/tests/navigation/success200-subframeload-expected.png: Added.
  • http/tests/navigation/timerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/timerredirect-basic-expected.png: Added.
  • http/tests/navigation/timerredirect-frames-expected.checksum: Added.
  • http/tests/navigation/timerredirect-frames-expected.png: Added.
  • http/tests/navigation/timerredirect-goback-expected.checksum: Added.
  • http/tests/navigation/timerredirect-goback-expected.png: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.png: Added.
01:14 Changeset [19000] by bdash

2007-01-20 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests, catch single regressions, and don't generate tests results for new tests.
00:45 Changeset [18999] by aroben

Rubberstamped by Maciej.

  • Scripts/run-webkit-tests: Change the default behavior back to generating results for new tests (this can be disabled with --no-new-test-results)

01/19/07:

23:07 Changeset [18998] by aroben

Fixed ChangeLog.

19:21 Changeset [18997] by kdecker

Reviewed by Adam.


Merged r10259 and r15845 from TOT to Safari-2-0-branch.

2006-08-11 Tim Omernick <timo@apple.com>

Reviewed by Darin.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

2005-09-13 Tim Omernick <tomernick@apple.com>

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h:

Added 'isTransparent' instance variable.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor. This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.

(-[WebBaseNetscapePluginView sendEvent:]):

Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.

(-[WebBaseNetscapePluginView setVariable:value:]):

Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.

  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:

Added SPI for -[WebBaseNetscapePluginView setVariable:value].

  • Plugins.subproj/npapi.m: (NPN_SetValue):

Implemented this function so that plugins may set state (such as window mode).


16:40 Changeset [18996] by adele

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

  • fast/forms/select-size-expected.checksum: Added.
  • fast/forms/select-size-expected.png: Added.
  • fast/forms/select-size-expected.txt: Added.
  • fast/forms/select-size.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

Update the size attribute value for select elements to match the numeric value. This is a special case since this
attribute is used to determine which control to use. We want to make sure that the size attribute is valid when we match
CSS rules.

Test: fast/forms/select-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the same as its integer value, then update the attribute value to match the integer.
  • dom/Attribute.h: Made setValue and setPrefix public.
16:33 Changeset [22799] by adachan

2007-01-19 Ada Chan <adachan@apple.com>

WebKitWin:

Fixed build.

Reviewed by Anders.
Added IWebResourceLoadDelegatePrivate which has one method: didLoadResourceFromMemoryCache.

  • ChangeLog:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:


16:32 Changeset [18995] by aroben

Reviewed by Beth.

Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
"Font", "Speech", and "Writing Direction" are missing from contextual
menu

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusForOldClients): Change our new SPI tags to WebMenuItemTagOther because old clients aren't expecting the new tags. (fixMenusFromOldClients): Use each menu item's title to figure out its correct tag again. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenusForOldClients before calling up to the delegate.
  • WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so that we can use it in WebContextMenuClient.
16:14 Changeset [22798] by sullivan

WebKitWin:

Reviewed by Lou.


Added mechanism for new callbacks, to try to avoid breaking the Windows build.

  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebFrame.h:
16:02 Changeset [18994] by sullivan

WebCore:

Reviewed by Darin

  • WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in
  • loader/FrameLoaderClient.h: new dispatchDidFinishDocumentLoad call
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): call dispatchDidFinishDocumentLoad


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad): empty implementation for dispatchDidFinishDocumentLoad

WebKit:

Reviewed by Darin

  • WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in


Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

  • WebView/WebViewPrivate.h: declare new delegate method
  • WebCoreSupport/WebFrameLoaderClient.h: declare dispatchDidFinishDocumentLoad()
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): new method, calls new delegate method
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): empty default implementation of new delegate method

WebKitQt:

Added stubs for new callbacks, to try to avoid breaking the Qt port.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
15:48 Changeset [18993] by adele

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php

  • fast/forms/control-restrict-line-height-expected.checksum: Added.
  • fast/forms/control-restrict-line-height-expected.png: Added.
  • fast/forms/control-restrict-line-height-expected.txt: Added.
  • fast/forms/control-restrict-line-height.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at http://macreviewzone.com/index.php


Test: fast/forms/control-restrict-line-height.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that have restricted font size.
15:18 Changeset [18992] by andersca

Reviewed by John Sullivan.

http://bugs.webkit.org/show_bug.cgi?id=12308
REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Move code from initWithFrame in here.
15:15 Changeset [18991] by darin

Fix date.

15:15 Changeset [18990] by darin

Fix bug number.

15:12 Changeset [18989] by darin

LayoutTests:

Reviewed by Adele.

  • test for html4.css problem where we had a missing semicolon and thus missed parsing a style rule
  • fast/forms/radio-no-theme-padding-expected.txt: Added.
  • fast/forms/radio-no-theme-padding.html: Added.
  • fast/forms/select-list-box-mouse-focus-expected.txt: Added.
  • fast/forms/select-list-box-mouse-focus.html: Added.

Note: Only the pixel test shows the failure in the old version.

Note: I generated the pixel results on Leopard -- may need to be
regenated on Tiger.

  • fast/forms/select-list-box-with-height-expected.checksum: Added.
  • fast/forms/select-list-box-with-height-expected.png: Added.
  • fast/forms/select-list-box-with-height-expected.txt: Added.
  • fast/forms/select-list-box-with-height.html: Added.

WebCore:

Reviewed by Adele.

  • fix http://bugs.webkit.org/show_bug.cgi?id=11999 <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999) Fix was to use the actual size of the renderer in the RenderListBox case, instead of always using the size specified by the select element.

Test: fast/forms/select-list-box-with-height.html

Test: fast/forms/select-list-box-mouse-focus.html

  • fix bug where auto-scrolling was not working in list box select elements

No test yet.

  • fix a missing semicolon in the radio/checkbox section of html4.css

Test: fast/forms/radio-no-theme-padding.html

  • fix bug where the scroll bars for select elements were pixel-type scroll bars even though the scrolling is line at a time scrolling

No test.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Removed an explicit call to repaint, since the RenderListBox now does that in selectionChanged. (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new selectionChanged instead of the old setSelectionChanged. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call to focus. Removed an explicit call to repaint and added a call to the new setMouseDownMayStartAutoscroll function in EventHandler. Removed an explicit call to repaint as above. (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new selectionChanged instead of the old setSelectionChanged.
  • page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed because the existing code to set that flag won't get triggered when the select element's default event handler handles the event.
  • rendering/RenderListBox.h: Made ScrollbarClient a private base class. Removed setSelectionChanged and m_selectionChanged. Added selectionChanged, which is really just a synonym for repaint for now. Moved valueChanged, the ScrollbarClient function implementations, and itemHeight into the private part of the class. Added numVisibleItems() and listHeight() to the private section. Changed m_vBar to be a RefPtr.
  • rendering/RenderListBox.cpp: Removed unneeded includes. Moved all the constants to the top of the file. (WebCore::RenderListBox::RenderListBox): Removed initialization of m_selectionChanged because it was removed and of m_vBar because it's now a RefPtr which is automaticall initialized. (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of m_vBar because it's a RefPtr. Added null checking for FrameView. (WebCore::RenderListBox::updateFromElement): Use numItems(). (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for FrameView and used RefPtr for the newly-created scroll bar. (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the misleading minDefaultSize to maxDefaultSize, since it's a maximum. (WebCore::RenderListBox::numVisibleItems): Added. Used in many places where size() was used before. This computes the number of rows we have room for. We don't need a row space after the last row, and this takes that into account. (WebCore::RenderListBox::numItems): Tweaked to remove the local variable. (WebCore::RenderListBox::listHeight): Added. Total height of all the rows and spaces between them. (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the row height, and to subtract the last row spacing off since we don't need a space after the last row. Changed the scroll bar setup to make it correspond to row numbers, not pixel numbers. (WebCore::RenderListBox::baselinePosition): Moved the comment to the constant declaration at the top of the file. (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using the itemHeight() function. (WebCore::RenderListBox::paintObject): Changed to use numItems and to use numVisibleItems instead of size. (WebCore::RenderListBox::isPointInScrollbar): Added get() call since m_vBar is now a RefPtr. (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(), itemHeight(), and rearranged a min/max combo so it starts with the low, then the value, then the high value for pinning. (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of size(). (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check of the element. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed to use numItems() and to use numVisibleItems() instead of size(). Also changed scroll bar code to work more simply now that the scroll bar is row-based. (WebCore::RenderListBox::listIndexIsVisible): Changed to use numVisibleItems() instead of size(). (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar is now row-based. Also removed an unnecessary null check. (WebCore::RenderListBox::itemHeight): Updated for name change from optionsSpacingMiddle to rowSpacing. (WebCore::RenderListBox::scrollHeight): Changed to use listHeight(). (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code that does nothing if the computed list index is visible (which did not make sense for this function and seemed a cut and paste error from the scrollToReveal function). The scrollbar part is simpler now that it's row-based. (WebCore::RenderListBox::windowClipRect): Changed to use document()->view() so we don't have to include RenderView.h.
  • css/html4.css: Added a semicolon I noticed was missing.
14:36 Changeset [22797] by beidson

Reviewed by Ada

Much more realistic WebDownload interface that delegates will actually have to implement


  • Interfaces/IWebDownload.idl:

Also updated svn:eol-style on .idls

13:57 Changeset [18988] by bdakin

WebCore:

Reviewed by Maciej and Darin.

Fix for <rdar://problem/4702420> REGRESSION: Null characters need
to be stripped from text nodes (townhall.com)

This was a regression from the fix for <rdar://problem/3727939>
Safari strips \0 characters from HTML tags making them valid, which
was fixed with r12652. We still need to strip null characters in
text nodes.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): No behavior change here, this is just to make Darin happy. (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new createStrippingNull function instead of the normal StringImpl constructor.
  • platform/StringImpl.cpp: (WebCore::StringImpl::createStrippingNull): Strip null.
  • platform/StringImpl.h:

LayoutTests:

Reviewed by Maciej and Darin.

New layout tests and some updates results for the fix for <rdar://
problem/4702420> REGRESSION: Null characters need to be stripped
from text nodes (townhall.com)

  • fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • fast/dom/stripNullFromTextNodes-expected.png: Added.
  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added.
  • fast/js/null-char-in-string-expected.txt: New results.
  • fast/text/stripNullFromText-expected.checksum: Added.
  • fast/text/stripNullFromText-expected.png: Added.
  • fast/text/stripNullFromText-expected.txt: Added.
  • fast/text/stripNullFromText.html: Added.
  • tables/mozilla/images/adforce_imgis_com-expected.txt: New results.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.checksum: Removed. This is the same test as the one above. The same test was in two places.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.png: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.txt: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com.html: Removed.
13:16 Changeset [18987] by ddkilzer

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
12:47 Changeset [22796] by adachan

2007-01-18 Ada Chan <adachan@apple.com>

Reviewed by Steve.


WebKitWin:

<rdar://4601522> Activity Window

  • Added some NSURL equivalent constants in IWebURLResponse.idl and IWebError.idl
  • Added IWebErrorPrivate.idl which contains some private error codes
  • Added IWebHTTPURLResponse interface which extends IWebURLResponse. It has the same API as NSHTTPURLResponse.

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl: Added.
  • Interfaces/IWebHTTPURLResponse.idl: Added.
  • Interfaces/IWebResourceLoadDelegate.idl: fixed a typo in parameter name
  • Interfaces/IWebURLResponse.idl: added WebURLResponseUnknownLength
  • WebKit.vcproj/Interfaces.vcproj: for adding IWebErrorPrivate.idl and IWebHTTPURLResponse.idl
  • WebKit.vcproj/WebKitGUID.vcproj: for the new IID_IWebHTTPURLResponse
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): also returns the new IWebHTTPURLResponse interface (WebURLResponse::allHeaderFields): Added stub for IWebHTTPURLResponse::allHeaderFields. (WebURLResponse::localizedStringForStatusCode): Added stub for IWebHTTPURLResponse::localizedStringforStatusCode (WebURLResponse::statusCode): Implemented IWebHTTPURLResponse::statusCode.
  • WebURLResponse.h:


10:25 Changeset [18986] by andersca

Yet another build fix.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
10:12 Changeset [22795] by andersca

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add SVG files.
09:59 Changeset [18985] by andersca

Try fixing the QT build.


  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::setStatusbarText):
  • WebCoreSupport/ChromeClientQt.h:
09:58 Changeset [22794] by andersca

Build fix.


  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::enabled): Use correct class name.
09:52 Changeset [18984] by andersca

Build fix.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::setStatusbarText):
09:42 Changeset [22793] by andersca

The obligatory build fix.


  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
09:38 Changeset [22792] by andersca

WebCoreWin:

Reviewed by Adam.

Remove some unused FrameWin functions.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusbarText):
  • WebChromeClient.h: Add new ChromeClient methods.


  • WebFrame.cpp: (WebFrame::userAgent): (WebFrame::updateGlobalHistoryForReload):
  • WebFrame.h: Remove unused FrameWinClient functions.
09:28 Changeset [18983] by andersca

WebCore:

Reviewed by Adam.

Move JavaScript alert and status bar functions to the chrome.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Chrome.cpp: (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusBarText):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText):
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::runJavaScriptAlert): (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm): (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt): (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

Reviewed by Adam.

Move functions from the bridge to the chrome client.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusBarText):
  • WebCoreSupport/WebFrameBridge.mm:
08:02 Changeset [18982] by zack

Fix the build

06:27 Changeset [18981] by eseidel

2007-01-19 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

More cleanup to SVGAnimated* classes.

No tests possible (only code cleanup)

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::isIndefinite):
  • ksvg2/svg/SVGAnimationElement.h:
06:09 Changeset [18980] by zimmermann

Not reviewed.
Remove accidently commited debug output. Shame on me :-)

06:03 Changeset [18979] by zimmermann

Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

05:42 Changeset [18978] by eseidel

2007-01-19 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

Add support for SVGMPathElement parsing.

No test cases possible (SVGAnimateMotion doesn't work yet)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • ksvg2/svg/SVGMPathElement.cpp: Added. (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::~SVGMPathElement): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::pathElement):
  • ksvg2/svg/SVGMPathElement.h: Added.
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): fix typo in comment
  • ksvg2/svg/svgtags.in: add back mpath
04:59 Changeset [18977] by eseidel

2007-01-19 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

Implement better parsing for keyTimes, keySplines and keyPoints.

Unfortunately none of this code is used much yet, thus isn't very testable.

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
02:09 Changeset [18976] by lars

Reviewed by Adam Roben.

run-webkit-tests does now not generate new results by default anymore.
You'll have to pass the --new-tests flag to it to force it to do so.

This is required to make it possible to have tests running on multiple
platforms peacefully together.

Note: See TracTimeline for information about the timeline view.