Timeline


and

02/01/07:

23:43 Changeset [19350] by bdash

2007-02-01 Nicholas Shanks <webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontDescription.h: (WebCore::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::stretch): (WebCore::FontDescription::narrowerStretch): (WebCore::FontDescription::widerStretch): (WebCore::FontDescription::setStretch): (WebCore::FontDescription::operator==):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
  • platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-01 Nicholas Shanks <webkit@nickshanks.com>

Reviewed by Mark.

CSS2 font-stretch property; uses American Typewriter and Helvetica Neue fonts,
requiring Regular, Condensed, Bold and Bold Condensed faces.

  • fast/css/computed-style-expected.txt: Updated.
  • fast/css/font-stretch-expected.checksum: Added.
  • fast/css/font-stretch-expected.png: Added.
  • fast/css/font-stretch-expected.txt: Added.
  • fast/css/font-stretch.html: Added.

2007-02-01 Nicholas Shanks <webkit@nickshanks.com>

Reviewed by Mark.

Add support for CSS2 font-stretch property.

  • WebInspector/webInspector/inspector.js:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):
22:57 Changeset [19349] by thatcher

Reviewed by Mark Rowe.

<rdar://problem/4969201> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/

  • platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]): Don't call [NSFont fontWithName:] with the desiredFamily on Tiger.
21:52 Changeset [19348] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

WebCore:

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Advance the pointer when necessary.

LayoutTests:

  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Changing back to success.
21:44 Changeset [19347] by staikos

Add a cookie interface for the Qt build.

19:11 Changeset [19346] by bdakin

un-doing accidental change that made all of the files in tables/mozilla/bugs allow tabs. whoopsie!

18:40 Changeset [19345] by mjs

Reviewed by Adele.


  • fixed <rdar://problem/4922764> ASSERTION: (!m_contentFunction) in PolicyCheck::call trying to visit feed URL (CNN, Apple, etc.)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopPolicyCheck): Call new cancel method instead of call(false) on old check. (WebCore::PolicyCheck::cancel): call any callback function that is set with false or PolicyIgnore as appropriate.
  • loader/FrameLoader.h:
17:55 Changeset [22888] by sfalken

Bump version for submit

17:55 Changeset [19344] by sfalken

New tag.

17:41 Changeset [22887] by adachan

2007-02-01 Ada Chan <adachan@apple.com>

Reviewed by Anders.


Forgot to assign document to 0 in case of failure in WebView::mainFrameDocument().

  • WebView.cpp: (WebView::mainFrameDocument):
17:34 Changeset [19343] by andersca

LayoutTests:

Reviewed by Darin.

Update test results that have console messages.


  • dom/html/level2/html/HTMLFrameElement09-expected.txt:
  • dom/html/level2/html/HTMLIFrameElement11-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement01-expected.txt:
  • dom/xhtml/level2/html/HTMLBaseElement02-expected.txt:
  • dom/xhtml/level2/html/frame-expected.txt:
  • dom/xhtml/level2/html/iframe-expected.txt:
  • editing/execCommand/4920488-expected.txt:
  • editing/selection/contenteditable-click-inside-expected.txt:
  • editing/selection/contenteditable-click-outside-expected.txt:
  • fast/AppleScript/001-expected.txt:
  • fast/dynamic/015-expected.txt:
  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/selected-index-assert-expected.txt:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-some-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/garbage-n-expected.txt:
  • fast/js/kde/string-1-n-expected.txt:
  • fast/js/kde/string-2-n-expected.txt:
  • fast/parser/script-tag-with-trailing-slash-expected.txt:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/tokenizer/002-expected.txt:
  • fast/tokenizer/external-script-document-write_2-expected.txt:
  • fast/tokenizer/script_extra_close-expected.txt:
  • fast/xsl/transform-xhr-doc-expected.txt:
  • http/tests/navigation/error404-goback-expected.txt:
  • http/tests/xmlhttprequest/set-dangerous-headers-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-30-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/custom/dynamic-empty-path-expected.txt:
  • svg/custom/js-update-container-expected.txt:
  • svg/custom/js-update-gradient-expected.txt:
  • svg/custom/js-update-polygon-changes-expected.txt:
  • svg/custom/js-update-polygon-removal-expected.txt:
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/polyline-hittest-expected.txt:
  • svg/custom/polyline-invalid-points-expected.txt:
  • svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/svgpolyparser-extra-space-expected.txt:
  • svg/custom/use-modify-target-symbol-expected.txt:
  • svg/custom/viewbox-syntax-expected.txt:
  • tables/mozilla/bugs/bug53690-1-expected.txt:
  • tables/mozilla/bugs/bug9024-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • tables/mozilla_expected_failures/core/captions1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
  • tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:

WebKitTools:

Reviewed by Darin.

  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:addMessageToConsole:]): Dump console messages.
16:52 Changeset [19342] by bdakin

WebCore:

Reviewed by Hyatt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10517 REGRESSION
(r12065-r12082): Navigation graphic wraps to the next line on
duart.com and <rdar://problem/4960505> REGRESSION: The Awesome
Windows Vista page has a layout error in the header table (10517)

The problem is that we never supported a quirk that other browsers
support where, under very specific circumstances, a table cell will
grow to fit an image inside of it. This is only a regression
because a bug was fixed were we were 1 pixel off in the calculation
of overflow in some cases.

  • rendering/RenderBlock.cpp: (WebCore::shouldGrowTableCellForImage): (WebCore::RenderBlock::calcInlineMinMaxWidth):
16:48 Changeset [22886] by adachan

2007-02-01 Ada Chan <adachan@apple.com>

Reviewed by Steve, Geoff.

WebKitWin:

<rdar://4969341> Regression: crash: when Resetting Safari
<rdar://4953390> Closing my two open boomer windows produced a crash
Fixed crash when closing second window and doing the close
all safari window option in Reset Safari.

  • WebFrame.cpp: WebFramePrivate has a pointer to frameView but does not hold a reference to it. The frame holds a ref to the frameView anyway, so it's safest to get the frameView through the frame. The crash happened because frame already has cleared out its frameView but WebFrame was still accessing the old stale frameView through that data member in WebFramePrivate. (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFramePrivate::frameView): (WebFrame::initWithWebFrameView): (WebFrame::layoutIfNeeded): (WebFrame::hasFrameView):
  • WebView.cpp: (WebView::paintIntoBackingStore): bail if frameView is null. (WebView::setHostWindow): don't set the view window's parent to 0. It'll end up creating a standalone window.


15:35 Changeset [22885] by andersca

Reviewed by Brady.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Make sure to always retain the request we return. (In practice, we were already doing this since client can never be null).


(WebCore::didReceiveResponse):
Remove client null check.

15:06 Changeset [22884] by sfalken

2007-02-01 Steve Falkenburg <sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
11:57 Changeset [22883] by andersca

Reviewed by Adam.

<rdar://problem/4969348>
REGRESSION: Crash loading pdf


  • WebView.cpp: (WebView::canShowMIMEType): Return true if the MIME type can be handled by a plug-in.
11:57 Changeset [19341] by lars

Reviewed by Adam.

Fix form loading for the Qt build.

11:53 Changeset [19340] by brmorris

brmorris, reviewed by zalan

DESC: Updated def file

  • BWINS/WEBCOREU.DEF:
09:34 Changeset [19339] by darin
  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Change test result to reflect failure because bug 12506 isn't fixed yet; we'll change it back once the bug is re-fixed.
04:27 Changeset [19338] by zack

Implement native look for comboboxes
and fix/implement popup menus. Also add the m_timestamp
and m_eventType setting to PlatformMouseEvent
r=Lars

00:56 Changeset [19337] by mjs

Reviewed by Adam.


<rdar://problem/4730469> REGRESSION: Assertion failure in -[WebDataSource(WebInternal) _bridge] when forwarding message

  • WebView/WebDataSource.mm: (-[WebDataSource subresources]): Check for being uncommitted and return emtpy result. (-[WebDataSource subresourceForURL:]): ditto
00:44 Changeset [22882] by aroben

WebKitWin:

Reviewed by Steve.

Fix <rdar://problem/4849601> Implement printing of individual subframes

This just moves some functions from IWebViewPrivate to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added declarations.
  • Interfaces/IWebViewPrivate.idl: Removed declarations.
  • WebFrame.cpp: Added functions from WebView.cpp. (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h: Added declarations.
  • WebView.cpp: Moved functions to WebFrame.cpp.
  • WebView.h: Removed declarations.
00:36 Changeset [19336] by darin

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
  • fast/forms/search-event-delay-expected.txt: Added.
  • fast/forms/search-event-delay.html: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4887428> REGRESSION: Implement slight delay for firing incremental onSearch event
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Set up timer. (WebCore::RenderTextControl::subtreeHasChanged): Start timer here instead of immediately sending event. (WebCore::RenderTextControl::searchEventTimerFired): Added. Sends search event. (WebCore::RenderTextControl::stopSearchEventTimer): Added. (WebCore::RenderTextControl::startSearchEventTimer): Added. Sends search event right away if there is no text. If there is some text, sets the timer using the same delay rule as NSSearchField. If you keep typing, then the timer keeps getting reset 0.2 seconds into the future until you pause.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::onSearch): Tell the renderer to stop the timer, since we're sending a search event. This helps when a caller other than the timer decides to send an explicit search event.
00:23 Changeset [19335] by mjs

Fix by Darin, reviewed by Maciej.

  • fix ~10% performance regression from encoding fix
  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix a logic error which made huge strings accidentally.

01/31/07:

23:53 Changeset [19334] by lars

fix the Qt build

23:18 Changeset [19333] by bdash

Versioning.

23:08 Changeset [19332] by bdash

Merge in r19308.

22:55 Changeset [19331] by darin

LayoutTests:

Reviewed by Adam and Geoff.

  • test for <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text
  • fast/forms/select-width-font-change-expected.txt: Added.
  • fast/forms/select-width-font-change.html: Added.

WebCore:

Reviewed by Adam and Geoff.

  • fix <rdar://problem/4786767> REGRESSION: <select> controls are not resized when zooming text

Test: fast/forms/select-width-font-change.html

  • rendering/RenderMenuList.h: Cleaned up formatting a bit. Removed unneeded include of PopupMenu.h. Made a lot more things private, including the PopupMenuClient base class, all of the virtual functions from PopupMenuClient, and the setTextFromOption function. Added updateOptionsWidth.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Added code to call updateOptionsWidth when the font changes. (WebCore::RenderMenuList::updateOptionsWidth): Added. Factored code out of updateFromElement. Changed to do nothing when m_optionsWidth is already correct. (WebCore::RenderMenuList::updateFromElement): Moved code to recomputed options width to the new updateOptionsWidth function. (WebCore::RenderMenuList::text): Made const.
22:37 Changeset [19330] by bdash

New tag.

22:04 Changeset [19329] by bdash

Versioning.

22:03 Changeset [22881] by oliver

2007-01-31 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

WebCoreWin:

Updating event handler logic to make use of methods migrated from
WebKit to WebCore

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::handleDrag): Updating handleDrag to use methods that we've migrated to WebCore
  • platform/win/PlatformMouseEventWin.cpp: (WebCore::messageToEventType): (WebCore::PlatformMouseEvent::PlatformMouseEvent): provide the type of mouse event
22:02 Changeset [19328] by bdash

Merge in r19308.

22:02 Changeset [19327] by oliver

liver Hunt <oliver@apple.com>

Reviewed by Adam.

WebCore:

Migrate more drag and drop logic to WebCore, start preparing
to move EventHandler::handleDrag from EventHandlerMac to EventHandler

  • WebCore.exp: updating methods


  • dom/Clipboard.cpp:
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::setDragHasStarted): (WebCore::Clipboard::dragStarted): Moving from ClipboardMac to Clipboard
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): PlatformMouseEvent no longer lies about button state, however DOM Events don't allow NoButton, so we need to convert NoButton to LeftButton when we create a DOM Event from PlatformMouseEvent
  • page/DragClient.h: Tidying comment
  • page/DragController.cpp: (WebCore::createMouseEvent): Updated for new PlatformMouseEvent constructors (WebCore::DragController::mayStartDragAtEventLocation): Migrated from WebKit
  • page/DragController.h: Added above function declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::dragState): (WebCore::EventHandler::dragHysteresisExceeded): (WebCore::EventHandler::freeClipboard): (WebCore::EventHandler::shouldDragAutoNode): Moved from EventHandlerMac (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleMousePressEvent): Use DragController
  • page/EventHandler.h: Added DragState struct definition to EventHandler
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventActivatedView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::mouseDown): Update to use DragController and PlatformMouseEvent
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Use DragController for state

WebKit:

Migrating methods to WebCore

  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebHTMLViewPrivate.h:


21:59 Changeset [19326] by bdash

New tag (part 2).

21:58 Changeset [19325] by bdash

New tag.

21:13 Changeset [22880] by adachan

2007-01-31 Ada Chan <adachan@apple.com>

Reviewed by Adam.


Adam and I found a missing retain on WebFrame::setUpPolicyListener(). The mac
code returns a RefPtr which retains it, but we are returning the raw pointer.
Changed the code to return a COMPtr. Without this change, loading bogus urls
will crash.

  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::setUpPolicyListener): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction):
  • WebFrame.h:
20:26 Changeset [19324] by weinig

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • fast/encoding/pseudo-tags-in-attributes-expected.txt: Added.
  • fast/encoding/pseudo-tags-in-attributes.html: Added.

WebCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12506
REGRESSION: Safari doesn't display hebrew text on a web page,
displayed correctly on Tiger

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Skip over quoted attributes.
20:20 Changeset [19323] by weinig

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::Marquee::Marquee):
19:51 Changeset [19322] by andersca

LayoutTests:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • webarchive/loading/resources/helloworld.webarchive: Added.
  • webarchive/loading/test-loading-archive-expected.txt: Added.
  • webarchive/loading/test-loading-archive.html: Added.

WebCore:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file

  • WebCore.exp:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueLoadWithData):
  • loader/FrameLoader.h: New function which continues a load but using a given buffer instead.

WebKit:

Reviewed by Maciej.

<rdar://problem/4886776>
REGRESSION: After opening a web archive, location shows the actual URL, not the webarchive file


"Revert" the change done in 13734.


  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation loadArchive]): Don't do a new load here, as this would cancel the current load and call the resource load delegate's didFailLoadingWithError: method. Instead, call continueLoadWithData.
19:50 Changeset [22879] by adachan

2007-01-31 Ada Chan <adachan@apple.com>

Reviewed by Anders.

WebKitWin:

Implement WebView::mainFrameDocument.

  • WebView.cpp: (WebView::mainFrameDocument):


19:30 Changeset [19321] by andersca
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Use an NSString here so we can guarantee that -description always returns the same value.
18:14 Changeset [19320] by mjs

Reviewed by Adam.


  • fix sporadic crash
  • wtf/ListHashSet.h: (WTF::::remove): remove before deleting
17:55 Changeset [19319] by adele

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12516
REGRESSION (r19313): All keyboard navigation has stopped working

For non-editable selections, handleKeyPress doesn't need to call _interceptEditingKeyEvent.

  • editing/Editor.cpp: (WebCore::selectionForEvent): Moved this to the top of the file. (WebCore::Editor::handleKeyPress): Do the equivalent of the _canEdit check that used to be in WebKit WebEditorClient::handleKeyPress.
17:33 Changeset [19318] by mjs

Reviewed by Maciej.

Fix run-pageloadtest to actually work again.

  • Misc/WebNSWindowExtras.m: (+[NSWindow _webkit_displayThrottledWindows]):
17:03 Changeset [19317] by ggaren

WebCore:

Reviewed by Darin Adler.

Added a Range counter to detect leaks. Tweaked the Node counter.


Also fixed a TextIterator destructive modification bug that I noticed along the
way. No test case for this bug because no clients have been bitten by it
yet.

  • dom/Node.cpp: Renamed NodeImplCounter to NodeCounter, changed counter to unsigned, fixed formatting to match style guidelines. (WebCore::NodeCounter::~NodeCounter): (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::RangeCounter::~RangeCounter): Added. (WebCore::Range::Range): (WebCore::Range::~Range): (WebCore::Range::ownerDocument): New accessor, used by TextIterator to avoid annoying NULL checks.
  • dom/Range.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::subrange): (1) Don't initialize result with entireRange -- doing so would create a PassRefPtr that pointed to entireRange, so this function would destructively modify the Range you passed it. Initialize it with a new Range instead. (2) Don't use a PassRefPtr as a local variable, because they have sneaky semantics. Use a RefPtr instead. (3) Don't call CharacterIterator::range() willy-nilly, since it does non-trivial work. Use a local variable instead.

WebKitTools:

Reviewed by Darin Adler.

Added Selection::toRange to the leaks -exclude list, since it comes up
as a false positive (Radar 4967949).


Also added RangeCounter to the global initializer exclude list. I added
a RangeCounter since leaks won't detect all Range leaks anymore.

  • Scripts/check-for-global-initializers:
  • Scripts/run-webkit-tests:
16:31 Changeset [19316] by andersca
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): Don't try to create an identifier if resource loads shouldn't be dumped.
15:00 Changeset [19315] by andersca

Reviewed by Geoff.

Add dumping of resource loads. This isn't completely tweaked yet since the test results would
rely on resources being delivered in the same order which might not always be true. However, it works good
enough for the simple webarchive tests I want to do right now.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpResourceLoadCallbacks]): (runTest):


  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ResourceLoadDelegate.h: Added.
  • DumpRenderTree/ResourceLoadDelegate.m: Added. Add new resource load delegate.
14:59 Changeset [19314] by zimmermann

Reviewed by Maciej.
Fix run-pageloadtest to actually work again.

14:55 Changeset [19313] by adele

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • fast/events/keypress-focus-change-expected.txt: Added.
  • fast/events/keypress-focus-change.html: Added.
  • fast/events/resources/keypress-frame.html: Added.

WebCore:

Reviewed by Darin.

WebCore part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

Test: fast/events/keypress-focus-change.html

  • editing/Editor.cpp: (WebCore::selectionForEvent): Added. This computes a selection that considers the case where an event handler has moved the selection outside of a text control. In that case, we use the target control's selection. (WebCore::Editor::insertText): This gets the selectionForEvent, checks that the selection is editable, and calls TypingCommand::insertText with the correct selection.
  • editing/TypingCommand.h: Added a version of insertText that takes a selection. The old version of insertText will call this, and pass in the frame's selection.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Added. Uses the passed in selection to set the starting and ending selections correctly so that the editing machinery will insert the text in the correct place.
  • page/Page.h: Added convenience method to get selection from focused or main frame.
  • page/Page.cpp: (WebCore::Page::selection):
  • html/HTMLInputElement.h: Added selection methods to get selection for text controls.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selection):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selection):
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selection):

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4521461> REGRESSION: when keyPress event changes form focus, inserted key goes to wrong control

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Instead of using the selected frame, use the frame for the target of the keyboard event. Also, don't do the canEdit check here, since the target's frame might not have a selection at this point. Do the canEdit check within Editor::insertText, where we determine which selection to use for inserting text.
  • WebView/WebEditingDelegatePrivate.h: Added forward declaration of DOMHTMLElement. This is needed after reordering includes in WebEditorClient.mm.
14:01 Changeset [19312] by ggaren

Backing out the CFRunLoopRunSpecific exclude command because it was overly
broad. We'll either need to work around this leak in DRT, or do some
custom grep-based leak ignoring.

  • Scripts/run-webkit-tests:
13:50 Changeset [19311] by brmorris

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
http://bugs.webkit.org/show_bug.cgi?id=12478

13:49 Changeset [19310] by brmorris

sareen, Reviewed by zalan.

DESC: cache control present in the HTTP header is not properly supported EAMO-6XTJVX
http://bugs.webkit.org/show_bug.cgi?id=12478

13:24 Changeset [19309] by brmorris

sareen, reviewed by zalan

DESC: Browser fails to load page after selection from drop-down list. (MLEN-6XRDHA)
http://bugs.webkit.org/show_bug.cgi?id=12427

13:15 Changeset [19308] by aliceli1

Reviewed by Tim Hatcher.

Turning an accidental API change to an SPI change

  • WebView/WebEditingDelegate.h:
  • WebView/WebEditingDelegatePrivate.h: move some declarations into private header.
13:11 Changeset [22878] by sfalken
13:10 Changeset [22877] by sfalken

2007-01-31 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.

Fix BString bugs.

  • platform/win/BString.cpp: (WebCore::BString::BString): Call SysAllocString instead of SysAllocStringLen (WebCore::BString::operator=): Add proper null checks (WebCore::operator ==): Add proper null checks
13:04 Changeset [19307] by brmorris

sareen, Reviewed by zalan <zbujtas@gmail.com>.

DESC: Browser fails to load page after selection from drop-down list MLEN-6XRDHA
http://bugs.webkit.org/show_bug.cgi?id=12427

08:21 Changeset [19306] by brmorris

brmorris, Reviewed by nobody - build fix.

DESC: add widget registry & engine to rom image.

  • rom/webkit.iby:
07:08 Changeset [19305] by darin

WebCore:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.

WebKit:

  • fix build
  • ForwardingHeaders/wtf/ListHashSet.h: Added.
06:08 Changeset [19304] by zack

Implement native colors for selections.
r=Lars

05:44 Changeset [19303] by zack

Expose the fact that the form has been edited
in the public Qt api.

05:43 Changeset [19302] by mjs

JavaScriptCore:

Reviewed by Mark with help from Lars.


  • added new ListHashSet class, which combines a hashtable and a linked list to provide a set that keeps elements in inserted order


This is to assist in fixing the following:
<rdar://problem/4751164> REGRESSION: Safari places text on incorrect button when returning to a page via back [10541]
http://bugs.webkit.org/show_bug.cgi?id=10541

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/HashTable.h: (WTF::HashTable::find): (WTF::HashTable::contains): (WTF::::find): (WTF::::contains):
  • wtf/ListHashSet.h: Added. (WTF::ListHashSetNode::ListHashSetNode): (WTF::ListHashSetNodeHashFunctions::hash): (WTF::ListHashSetNodeHashFunctions::equal): (WTF::ListHashSetIterator::ListHashSetIterator): (WTF::ListHashSetIterator::get): (WTF::ListHashSetIterator::operator*): (WTF::ListHashSetIterator::operator->): (WTF::ListHashSetIterator::operator++): (WTF::ListHashSetIterator::operator--): (WTF::ListHashSetIterator::operator==): (WTF::ListHashSetIterator::operator!=): (WTF::ListHashSetIterator::operator const_iterator): (WTF::ListHashSetIterator::node): (WTF::ListHashSetConstIterator::ListHashSetConstIterator): (WTF::ListHashSetConstIterator::get): (WTF::ListHashSetConstIterator::operator*): (WTF::ListHashSetConstIterator::operator->): (WTF::ListHashSetConstIterator::operator++): (WTF::ListHashSetConstIterator::operator--): (WTF::ListHashSetConstIterator::operator==): (WTF::ListHashSetConstIterator::operator!=): (WTF::ListHashSetConstIterator::node): (WTF::ListHashSetTranslator::hash): (WTF::ListHashSetTranslator::equal): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::operator): (WTF::::~ListHashSet): (WTF::::size): (WTF::::capacity): (WTF::::isEmpty): (WTF::::begin): (WTF::::end): (WTF::::find): (WTF::::contains): (WTF::::add): (WTF::::remove): (WTF::::clear): (WTF::::unlinkAndDelete): (WTF::::appendNode): (WTF::::deleteAllNodes): (WTF::::makeIterator): (WTF::::makeConstIterator): (WTF::deleteAllValues):

WebCore:

Reviewed by Mark.

  • dom/Document.cpp: (WebCore::Document::formElementsState):
  • dom/Document.h:


I couldn't figure out the back/forward support in the tests enough
to make an automated test, but this maual test reproduces the
problem 100% without this patch:


  • manual-tests/back.html: Added.
  • manual-tests/form-control-madness.html: Added.
04:59 Changeset [19301] by ddkilzer

Added Bugzilla bug number. Thanks Mitz!

04:51 Changeset [19300] by ddkilzer

WebCore:

Reviewed by Mitz.

No test cases since there is no change in functionality.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Simplify canFitOnLine expression.
04:36 Changeset [19299] by zack

Adding comments explaining how the focus ring implementation
works on the Qt platform and just move focus ring rendering
related code to the same spot.

04:20 Changeset [19298] by mjs

Reviewed by Eric.


  • add back no-op version of silly method so that shipping Safari can still run the PLT
  • Misc/WebNSWindowExtras.m: (-[NSWindow _webkit_displayThrottledWindows]):
04:00 Changeset [19297] by zack

Clean up key event handling on Qt.
r=Lars

00:57 Changeset [19296] by staikos

Fix a double delete on cancel as well as a crash with proxy

00:33 Changeset [19295] by bdash

2007-01-31 Mark Rowe <mrowe@apple.com>

More build fixing.

  • Misc/WebKitLogging.h: Use !defined() rather than !.
  • Plugins/WebNetscapePluginStream.h: Remove #if cplusplus as this file is only included from Obj-C++ files.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Use #ifdef rather than #if.
  • WebView/WebView.mm: (-[WebView isGrammarCheckingEnabled]): Ditto.
00:11 Changeset [19294] by bdash

2007-01-31 Mark Rowe <mrowe@apple.com>

Build fix.

  • WebView/WebView.mm: (-[WebView initWithFrame:frameName:groupName:]):
00:10 Changeset [19293] by staikos

fix a crash on exit
remove focusFrame
add childFrames

01/30/07:

23:26 Changeset [19292] by bdash

2007-01-31 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

Enable -Wundef in WebKit, and change misuses of #if to #ifdef or #ifndef as appropriate.

  • Misc/WebKitLogging.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrame.mm:
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView delete:]): (-[WebHTMLView showGuessPanel:]): (-[WebHTMLView copy:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView validateUserInterfaceItem:]):
  • WebView/WebViewPrivate.h:

2007-01-31 Mark Rowe <mrowe@apple.com>

Reviewed by Oliver.

  • dom/Document.h: Change #if XSLT_SUPPORT to #ifdef XSLT_SUPPORT.
23:20 Changeset [19291] by lars

Fix the Qt build.

22:43 Changeset [19290] by zack

Implement SVGImage on the Qt platform.
r=Eric

21:45 Changeset [19289] by mjs

Reviewed by Brady.

  • fixed <rdar://problem/4939366> REGRESSION: Assertion failure and crash when going back in history (12314)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): special case a frame name of "_blank" (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): ditto
21:24 Changeset [19288] by ggaren

Reviewed by Beth Dakin.

Filed some more Radars in other components, added some more leaks to the
exclusion list.

  • Scripts/run-webkit-tests: Ignore leaks in CFNotificationCenterAddObserver, CFRunLoopRunSpecific, and NSSpellChecker.
20:30 Changeset [19287] by bdash

Versioning.

20:08 Changeset [19286] by bdash

New tag.

19:50 Changeset [22876] by sfalken

Bump version for submit

19:39 Changeset [19285] by sfalken

New tag.

19:31 Changeset [19284] by ddkilzer

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Created webarchive tests that exercise various features of the WebArchive format.

  • webarchive/resources/apple.gif: Copied from fast/canvas/resources/apple.gif.
  • webarchive/resources/dump-webarchive.js: Added.
  • webarchive/resources/test-frame.html: Added.
  • webarchive/resources/test-style.css: Added.
  • webarchive/test-body-background-expected.txt: Added.
  • webarchive/test-body-background.html: Added.
  • webarchive/test-duplicate-resources-expected.txt: Added.
  • webarchive/test-duplicate-resources.html: Added.
  • webarchive/test-frameset-expected.txt: Added.
  • webarchive/test-frameset.html: Added.
  • webarchive/test-img-src-expected.txt: Added.
  • webarchive/test-img-src.html: Added.
  • webarchive/test-input-src-expected.txt: Added.
  • webarchive/test-input-src.html: Added.
  • webarchive/test-link-href-expected.txt: Added.
  • webarchive/test-link-href.html: Added.
  • webarchive/test-object-data-expected.txt: Added.
  • webarchive/test-object-data.html: Added.
  • webarchive/test-script-src-expected.txt: Added.
  • webarchive/test-script-src.html: Added.
  • webarchive/test-table-background-expected.txt: Added.
  • webarchive/test-table-background.html: Added.
  • webarchive/test-td-background-expected.txt: Added.
  • webarchive/test-td-background.html: Added.

WebKitTools:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11882
Need a way to regression test .webarchive output files

Implement layoutTestController.dumpAsWebArchive() to test WebArchive format.
Alters WebResourceResponse and WebResourceURL properties within WebArchive format
to normalize URLs to remove path where WebKit was checked out. Also converts
WebDataResource properties from data to string if the corresponding
WebResourceMIMEType property starts with "text/" or equals
"application/x-javascript".

  • DumpRenderTree/DumpRenderTree.m: (convertWebResourceDataToString): Added. (normalizeWebResourceURL): Added. (normalizeWebResourceResponse): Added. (serializeWebArchiveToXML): Added. (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpAsWebArchive]): Added. (runTest):
19:08 Changeset [19283] by brmorris

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
http://bugs.webkit.org/show_bug.cgi?id=12484
merge of r19282 to 3.1

19:03 Changeset [19282] by brmorris

yaharon, reviewed by zalan.

DESC: BrowserNG: Redundant password manager notification on secure pages (MLIO-6XXEVU)
http://bugs.webkit.org/show_bug.cgi?id=12484


18:40 Changeset [19281] by mjs

Reviewed by Anders.

  • fixed <rdar://problem/4963871> REGRESSION: Crash occurs at WebCore::Frame::loader() when attempting to open a saved archive file
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::request): Removed obsolete FIXME. (WebCore::DocumentLoader::initialRequest): Ditto.
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): Handle data loads from a timer, otherwise bad things happen. (WebCore::MainResourceLoader::handleDataLoadNow): (WebCore::MainResourceLoader::handleDataLoadSoon): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::didCancel): cancel data load timer
  • loader/MainResourceLoader.h:
18:31 Changeset [19280] by beidson

Reviewed by Oliver

This is a corollary to <rdar://problem/4944887> where certain things happened on an alternate thread.
To help catch such behavior in the future, add ASSERT_MAIN_THREAD() to key WebKit API points

  • History/WebHistoryItem.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem URLString]): (-[WebHistoryItem originalURLString]): (-[WebHistoryItem title]): (-[WebHistoryItem lastVisitedTimeInterval]): (-[WebHistoryItem isEqual:]): (-[WebHistoryItem description]): (-[WebHistoryItem initWithWebCoreHistoryItem:]): (-[WebHistoryItem initFromDictionaryRepresentation:]): (-[WebHistoryItem scrollPoint]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem target]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem children]): (-[WebHistoryItem URL]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
  • Misc/WebIconDatabase.mm: Added ASSERT_MAIN_THREAD() to suspected API entry points (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _iconForFileURL:withSize:]): (webGetNSImage):
  • Misc/WebKitLogging.h: Added ASSERT_MAIN_THREAD()
  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread): Added
  • WebKit.xcodeproj/project.pbxproj: Define DISABLE_THREAD_CHECK until it is safe to run with ASSERT_MAIN_THREAD() active
16:52 Changeset [22875] by beidson

Fixes <rdar://problem/4889160>
If there's no backing store bitmap, don't try to update it!

16:08 Changeset [22874] by andersca

Build fix.


  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::setDefersLoading):
16:08 Changeset [22873] by sfalken
15:57 Changeset [19279] by hyatt

Add layout test for invalid pseudo-classes.

15:56 Changeset [19278] by thatcher

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • Misc/WebNSImageExtras.m: (-[NSImage _web_saveAndOpen]):
  • WebKit.xcodeproj/project.pbxproj:
15:55 Changeset [19277] by thatcher

Reviewed by Darin.

<rdar://problem/4961953> Stop using NSString deprecated methods like initWithCString:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/svg/filters/cg/WKArithmeticFilter.m: (-[WKArithmeticFilter init]):
  • platform/graphics/svg/filters/cg/WKComponentMergeFilter.m: (-[WKComponentMergeFilter init]):
  • platform/graphics/svg/filters/cg/WKDiffuseLightingFilter.m: (-[WKDiffuseLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKDiscreteTransferFilter.m: (-[WKDiscreteTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKDisplacementMapFilter.m: (-[WKDisplacementMapFilter init]):
  • platform/graphics/svg/filters/cg/WKDistantLightFilter.m: (-[WKDistantLightFilter init]):
  • platform/graphics/svg/filters/cg/WKGammaTransferFilter.m: (-[WKGammaTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKLinearTransferFilter.m: (-[WKLinearTransferFilter init]):
  • platform/graphics/svg/filters/cg/WKNormalMapFilter.m: (-[WKNormalMapFilter init]):
  • platform/graphics/svg/filters/cg/WKPointLightFilter.m: (-[WKPointLightFilter init]):
  • platform/graphics/svg/filters/cg/WKSpecularLightingFilter.m: (-[WKSpecularLightingFilter init]):
  • platform/graphics/svg/filters/cg/WKSpotLightFilter.m: (-[WKSpotLightFilter init]):
  • platform/graphics/svg/filters/cg/WKTableTransferFilter.m: (-[WKTableTransferFilter init]):
15:54 Changeset [19276] by hyatt

Fix for Radar bug #4679426, golden gate bridge Web site layout broken.


This is a regression caused by the addition of :lang support. This
feature caused us to accept any pseudo-class/element with function
arguments, even ones we couldn't handle. The site used such a construct
in conjunction with :not, which turned :not(something-crazy) into not(false).
This ended up being "true", and so we started matching a rule we used to
reject.

The fix is to now aggressively parse pseudo-elements and classes and to
cause the rejection of an entire rule if any pseudoclass or element within
any simple selector of that rule is unrecognized.

Reviewed by darin

fast/css/invalid-pseudo-classes.html

  • css/CSSGrammar.y:
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
15:24 Changeset [19275] by weinig

LayoutTests:

Reviewed by Geoff.

  • plugins/createScriptableObject-before-start-expected.txt: Added.
  • plugins/createScriptableObject-before-start.html: Added.

WebKit:

Reviewed by Geoff.

Test: plugins/createScriptableObject-before-start.html

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Return NULL if the plugin is not started.
15:14 Changeset [19274] by mjs

Reviewed by Anders.


<rdar://problem/4964407> REGRESSION: Mail hangs when replying, forwarding , or creating a new message


  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Set WebDataRequest property on data load requests since Mail specifically checks for this.
15:02 Changeset [19273] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/images/animated-background-image-crash-expected.txt: Added.
  • fast/images/animated-background-image-crash.html: Added.
  • fast/images/resources/animated.gif: Added.
  • fast/images/resources/animated2.gif: Added.

WebCore:

Reviewed by Darin.

Test: fast/images/animated-background-image-crash.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::arenaDelete): Deref() all background images and the border image.
14:57 Changeset [19272] by bdash

2007-01-31 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Re-enable editing/pasteboard/paste-{RTFD,TIFF}.html now that a fix has been landed for:
http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Added.
  • editing/pasteboard/paste-RTFD.html-disabled: Removed.
  • editing/pasteboard/paste-TIFF.html: Added.
  • editing/pasteboard/paste-TIFF.html-disabled: Removed.
14:53 Changeset [19271] by darin

Reviewed by Maciej.

  • dom/EventTarget.h:
  • dom/EventTarget.cpp: (WebCore::EventTarget::toNode): Use EventTargetNode instead of Node. Removed unneeded includes. Make EventTarget's destructor protected to make it clear that you should never delete one.
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::toNode): Tweaked formatting. Updated for change to return value.
  • platform/graphics/BitmapImage.h: Updated comment for clarity. Marked FrameData Noncopyable.
  • platform/graphics/Image.h: Tweaked formatting.
  • platform/graphics/ImageAnimationObserver.h: Make ImageAnimationObserver's destructor protected to make it clear that you should never delete one.
14:36 Changeset [19270] by weinig

LayoutTests:

Reviewed by Darin (by way of Hyatt).

  • fast/table/inline-form-assert-expected.checksum: Added.
  • fast/table/inline-form-assert-expected.png: Added.
  • fast/table/inline-form-assert-expected.txt: Added.
  • fast/table/inline-form-assert.html: Added.

WebCore:

Reviewed by Darin (by way of Hyatt).

Test: fast/table/inline-form-assert.html

  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
14:25 Changeset [19269] by weinig

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null-expected.txt: These tests now pass.

WebCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12486
XPathNSResolver.lookupNamespaceURI should return null if no URI is found

  • xml/XPathNSResolver.idl: added [ConvertNullStringTo=Null].
14:07 Changeset [19268] by darin
  • kjs/DateMath.cpp: Fix license header to reflect LGPL as the first license mentioned. We still mention the option of using under MPL or GPL since some of this code came from the Mozilla project with those license terms.
14:04 Changeset [19267] by andersca

Reviewed by Maciej.

Revert the parts of 19244 that removed deferring NSURLConnections, that was not a correct change.
Remove ASSERTS from loader.cpp that aren't true anymore since the callbacks are invoked without a handle
when loading a subresource from an archive.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::setDefersLoading):
  • loader/loader.cpp: (WebCore::Loader::didFail): (WebCore::Loader::didReceiveResponse): (WebCore::Loader::didReceiveData):
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::setDefersLoading):
13:57 Changeset [19266] by darin

Reviewed by John.

  • fix for <rdar://problem/4911504> REGRESSION: With a image selected, ctrl-clicking on page displays the wrong contextual menu items "Search in Google", "Search in Spotlight" and "Look up in Dictionary"
  • platform/ContextMenu.cpp: (WebCore::selectionContainsPossibleWord): Added. Returns true if there are some non-whitespace characters in the selection. (WebCore::ContextMenu::populate): Don't add SearchSpotlightItem, SearchWebItem, or LookInDictionaryItem if selectionContainsPossibleWord returns false.
12:59 Changeset [19265] by zimmermann

Reviewed by Oliver.

Respect stroke-width in absolute repaint rect calculations for SVG text.
Added test: svg/custom/text-repaint-including-stroke.svg

12:46 Changeset [19264] by sfalken

2007-01-30 Steve Falkenburg <sfalken@apple.com>

Reviewed by Oliver.

Add missing includes.

  • ksvg2/svg/SVGElementInstance.cpp:
11:34 Changeset [22872] by sfalken

2007-01-30 Steve Falkenburg <sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
11:01 Changeset [19263] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12452
XPath id() function is not supported

WebCore:

  • xml/XPathFunctions.cpp: (WebCore::XPath::isWhitespace): A helper to detect XML whitespace.

(WebCore::XPath::FunId::isConstant):
(WebCore::XPath::FunId::doEvaluate):
(WebCore::XPath::FunctionMapping::):
Implemented id().

LayoutTests:

  • dom/svg/level3/xpath/Conformance_ID-expected.txt: This test now passes.
  • fast/xpath/complex-id-expected.txt: Added.
  • fast/xpath/complex-id.html: Added. A test for more advanced id() capabilities.
08:58 Changeset [19262] by brmorris

sareen <shyam.sareen@nokia.com>

Reviewed by yongjun/brad.
DESC: WAP CSS specific character format causing phone keypad input error TMCN-6S5MSE
http://bugs.webkit.org/show_bug.cgi?id=12232

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (TInputFormatChar::SuggestedCase):
07:47 Changeset [19261] by zack

Make the gradients work on the Qt platform.
r=Sam

07:35 Changeset [19260] by brmorris

sareen <shyam.sareen@nokia.com>

Reviewed by yongjun
DESC: Invalid WAP CSS formats not being ignored - TMCN-6S5K87
http://bugs.webkit.org/show_bug.cgi?id=12230

07:25 Changeset [19259] by brmorris

sareen

Reviewed by joseph.ligman@nokia.com
DESC: Crash is detected when activating "Find" for the second time in page view.
http://bugs.webkit.org/show_bug.cgi?id=12477

07:15 Changeset [19258] by brmorris

raalexan, reviewed by Yongjun.

DESC: S60 3.2 Help: When application is launched via hyperlink, the cursor stays as wait cursor
http://bugs.webkit.org/show_bug.cgi?id=12421

07:09 Changeset [19257] by brmorris

sareen <shyam.sareen@nokia.com>

Reviewed yongjun.zhang@nokia.com
DESC: Browser Control: Problem with History Stack when using custom datastore PKAI-6WGSHS
http://bugs.webkit.org/show_bug.cgi?id=10325
(Additional fix then the last one)

06:22 Changeset [19256] by ddkilzer

WebKitTools:

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=12470
svn-create-patch creates duplicate patches for files within an added/modified directory

  • Scripts/svn-create-patch: (sub generateFileList($\%\%)): Ignore directories when generating the file list.
06:04 Changeset [19255] by bdash

2007-01-31 Mark Rowe <mrowe@apple.com>

Disable editing/pasteboard/paste-{RTFD,TIFF}.html so tests run to completion until a fix is landed for:
http://bugs.webkit.org/show_bug.cgi?id=12474
REGRESSION(r19244): Assertion failure in layout tests: ASSERTION FAILED: loader->handle()

  • editing/pasteboard/paste-RTFD.html: Removed.
  • editing/pasteboard/paste-RTFD.html-disabled: Added.
  • editing/pasteboard/paste-TIFF.html: Removed.
  • editing/pasteboard/paste-TIFF.html-disabled: Added.
04:44 Changeset [19254] by zimmermann

Reviewed by Eric & Oliver. Leak related fixes reviewed by Mark.

Finally make the SVG <use> implementation use the proper "shadow tree" concept,
which is also used by the HTML forms implementation. It's the first time in ksvg
history that <use> is not implement as a crude hack, but proper & sane.

04:09 Changeset [19253] by zack

Improve QtLauncher to make it more useful as a testing tool.

03:09 Changeset [19252] by mjs

Reviewed by Eric.

<rdar://problem/4928646> REGRESSION: manual-tests/remove-input-file-onchange.html crashes


  • platform/FileChooser.h: (WebCore::FileChooser::disconnected): New method, so the RenderFileControl can tell when it's gotten disconected.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::valueChanged): Avoid calling repainted() when onChange() handler destroyed us.
02:20 Changeset [19251] by hausmann

For the Qt build combine JavaScriptCore and WebKit into one library, to make it possible to
build it with ELF visibility or on Windows without adding EXPORT macros to kjs all over the place.
r=zack

00:46 Changeset [19250] by zack

Make the Qt platform compile.

00:34 Changeset [19249] by zack

Compile fix
r=aroben

00:13 Changeset [19248] by zack

Propagate the allows-scrolling property on the frames
correctly. If the frame has been constructed as non-
scrolling, respect that and don't show scrollbars.
r=Lars

01/29/07:

23:30 Changeset [22871] by aroben

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: Removed old stub.
23:22 Changeset [22870] by beidson

More engine download tweaks - still relies on a custom ToT CFNetwork until they submit

23:13 Changeset [22869] by mjs

Reviewed by Adam & Steve.


  • hook up new cross-platform data-loading code
  • fixed <rdar://4910106> - Need to support loadData and loadHTMLString
  • WebFrame.cpp: (WebFrame::loadData): add a SharedBuffer overload, and implement IStream* version using that. (WebFrame::loadHTMLString): implement using loadData
  • WebFrame.h: prototype new method
22:09 Changeset [19247] by ggaren

I am the chosen one! I have seen the faces of the final five! I will
save the WebKit build!


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
21:32 Changeset [19246] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12464
Fix XPath test suite conversion problems

  • dom/svg/level3/xpath/svgunit.js: Fixed createXPathEvaluator() to work in Firefox (whose document.getFeature returns null for XPath). Changed load() to use XMLHttpRequest, instead of merely cloning the current document.
  • dom/svg/level3/xpath/resources/internaldtd.xml: Added.
  • dom/svg/level3/xpath/resources/staff.dtd: Added.
  • dom/svg/level3/xpath/resources/staff.xml: Added.
  • dom/svg/level3/xpath/resources/staffNS.dtd: Added.
  • dom/svg/level3/xpath/resources/staffNS.xml: Added. Added external test documents.
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR-expected.txt:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR-expected.txt: These tests now run, but fail. They also fail in Firefox, but pass in Opera.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR-expected.txt: These now fail, because XPathResult relies on DOMSubtreeModified event for invalidation, but event listeners cannot be registered on nodes in documents that aren't attached (such as XHR.responseXML). Not yet sure what exactly the bug is, but I think it's good to have the tests fail, as it appears to be a genuine issue.
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.js:
  • dom/svg/level3/xpath/XPathResult_numberValue.js: Updated these tests to use /staff instead of /svg paths.
  • dom/svg/level3/xpath/XPathResult_booleanValue_true-expected.txt:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.js:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE-expected.txt:
  • dom/svg/level3/xpath/XPathResult_stringValue-expected.txt: These tests now pass.
  • dom/svg/level3/xpath/Attribute_Nodes.svg:
  • dom/svg/level3/xpath/Attribute_Nodes_xmlns.svg:
  • dom/svg/level3/xpath/Comment_Nodes.svg:
  • dom/svg/level3/xpath/Conformance_Expressions.svg:
  • dom/svg/level3/xpath/Conformance_ID.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_3.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_empty.svg:
  • dom/svg/level3/xpath/Conformance_hasFeature_null.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_3.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_empty.svg:
  • dom/svg/level3/xpath/Conformance_isSupported_null.svg:
  • dom/svg/level3/xpath/Element_Nodes.svg:
  • dom/svg/level3/xpath/Processing_Instruction_Nodes.svg:
  • dom/svg/level3/xpath/Text_Nodes.svg:
  • dom/svg/level3/xpath/XPathEvaluatorCast01.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_INVALID_EXPRESSION_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_01.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NAMESPACE_ERR_02.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_NS.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createExpression_no_NS.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_all.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_document.svg:
  • dom/svg/level3/xpath/XPathEvaluator_createNSResolver_documentElement.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_INVALID_EXPRESSION_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NAMESPACE_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_NOT_SUPPORTED_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_WRONG_DOCUMENT_ERR.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_document.svg:
  • dom/svg/level3/xpath/XPathEvaluator_evaluate_documentElement.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_NOT_SUPPORTED_ERR.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_WRONG_DOCUMENT_ERR.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_document.svg:
  • dom/svg/level3/xpath/XPathExpression_evaluate_documentElement.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_null.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_prefix.svg:
  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_xml.svg:
  • dom/svg/level3/xpath/XPathResult_TYPE_ERR.svg:
  • dom/svg/level3/xpath/XPathResult_booleanValue_false.svg:
  • dom/svg/level3/xpath/XPathResult_booleanValue_true.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ANY_UNORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_BOOLEAN_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_FIRST_ORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_NUMBER_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_ORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_STRING_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_invalidIteratorState_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_iterateNext_INVALID_STATE_ERR.svg:
  • dom/svg/level3/xpath/XPathResult_iteratorNext_ORDERED_NODE_ITERATOR_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_numberValue.svg:
  • dom/svg/level3/xpath/XPathResult_resultType.svg:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_ANY_UNORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_singleNodeValue_FIRST_ORDERED_NODE_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_null.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_ORDERED_NODE_SNAPSHOT_TYPE_order.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_count.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotItem_UNORDERED_NODE_SNAPSHOT_TYPE_null.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_ORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_snapshotLength_UNORDERED_NODE_SNAPSHOT_TYPE.svg:
  • dom/svg/level3/xpath/XPathResult_stringValue.svg: Removed unneeded inline test data.
21:07 Changeset [19245] by ggaren

JavaScriptCore:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines


The TCMalloc module now initializes, if needed, inside GetCache() and
fastMallocSetIsMultiThreaded(). We leverage the same synchronization
technique used for enabling / disabling the single-threaded optimization
to synchronize initialization of the library without requiring a lock
for every malloc.


1,251 runs of tcmalloc_unittest, 2 runs of a custom, massively multi-threaded
tcmalloc_unittest, and my custom version of the PLT show no regressions.
Super-accurate JS iBench reports a .24% regression, which is right at the
limit of its error range, so I'm declaring victory.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): Initialize, if needed. (InitModule() checks the "if needed" part.) (WTF::TCMalloc_ThreadCache::GetCache): Restored original TCMalloc code inside #ifdef, for posterity. Added new initialization logic. (WTF::TCMalloc_ThreadCache::InitModule): Call InitTSD(), since we don't have a static initializer to call it for us, now. This means that fastMalloc is not usable as a general libc allocator, but it never was, and if it were the general libc allocator, we wouldn't be here in the first place, so whatever. (WTF::TCMalloc_ThreadCache::InitTSD): Don't try to take the pageheap_lock, since InitModule already has it.

WebKitTools:

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/4485644> REGRESSION: JavaScriptCore has init routines


No more mollycoddling for you, FastMalloc.o!


  • Scripts/check-for-global-initializers:
20:57 Changeset [19244] by gdennis

LayoutTests:

Reviewed by Maciej.


  • editing/pasteboard/paste-RTFD-expected.checksum: Added.
  • editing/pasteboard/paste-RTFD-expected.png: Added.
  • editing/pasteboard/paste-RTFD-expected.txt: Added.
  • editing/pasteboard/paste-RTFD.html: Added.
  • editing/pasteboard/paste-TIFF-expected.checksum: Added.
  • editing/pasteboard/paste-TIFF-expected.png: Added.
  • editing/pasteboard/paste-TIFF-expected.txt: Added.
  • editing/pasteboard/paste-TIFF.html: Added.
  • editing/resources/RTFD-pasteboard-data.dat: Added.
  • editing/resources/TIFF-pasteboard-data.dat: Added.

WebCore:

Reviewed by Maciej.

Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


ResourceHandles no longer need to be able to defer loading as that is
now handled by the ResourceLoader.

  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow): updated to remove defersLoading argument.
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): release the deferred request. (WebCore::ResourceLoader::load): defer creating the ResourceHandle instead of asking the ResourceHandle to defer loading. (WebCore::ResourceLoader::setDefersLoading): create the ResourceHandle if we have deferred creating it.
  • loader/ResourceLoader.h:
  • platform/network/ResourceHandle.cpp: ResourceHandle's don't need to know about deferLoading. (WebCore::ResourceHandle::ResourceHandle): (WebCore::ResourceHandle::create):
  • platform/network/ResourceHandle.h: ditto.
  • platform/network/ResourceHandleInternal.h: ditto. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/mac/ResourceHandleMac.mm: ditto. (WebCore::ResourceHandle::start):

WebKit:

Reviewed by Maciej.

Part of fix for http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


The URLs for images in RTFD data must not be loaded until the resources
have been added to the WebUnarchivingState. This can't happen until
after the RTFD data has been parsed, so we must delay loading while this
RTFD data is being parsed to a document fragment.

  • WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): defer loading the resources while RTFD data is being parsed. (+[NSURL _web_uniqueWebDataURL]): Added this back because AppKit uses it.
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState archivedResourceForURL:]): orkaround for workaround for rdar://problem/4699166 so that other people can use archivedResourceForURL: too.

WebKitTools:

Reviewed by Maciej.


Enables layout test for: http://bugs.webkit.org/show_bug.cgi?id=10725
Image data in from RTFD clipboard data thrown away


  • This method is needed because NSArray's ar bridged to JS Array's, which in turn are bridged back to WebScriptObject's when passed from JS to ObjC. Hence it is not possbile to pass an NSArray from JS.
  • DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreePasteboard declareType:owner:]): Added a convenience method for JS.
20:31 Changeset [22868] by beidson

Emergency build fix + other changes I'll have review after the fact

20:05 Changeset [19243] by bdash

2007-01-29 Jim Correia <jim.correia@pobox.com>

Reviewed by Mark.

Added support for -allowsUndo/-setAllowsUndo: to allow editable WebView
clients to completely disable undo registration. This is functionally
equivalent to the methods with the same names on NSTextView.

  • WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebView initWithCoder:]): (-[WebView encodeWithCoder:]): (-[WebView allowsUndo]): (-[WebView setAllowsUndo:]): (-[WebView undoManager]):
  • WebView/WebViewPrivate.h:
19:19 Changeset [19242] by beidson

Use a RetainPtr instead of a raw pointer

18:21 Changeset [22867] by beidson

Make NotImplemented use a logging channel so you can turn it off independent of other logging

18:11 Changeset [19241] by zbujtas

2007-01-29 bujtas <zbujtas@gmail.com>

Reviewed by zalan bujtas
DESC:
http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
18:08 Changeset [19240] by zbujtas

2007-01-29 bujtas <zbujtas@gmail.com>

Reviewed by zalan bujtas
DESC:
http://bugs.webkit.org/show_bug.cgi?id=12422
jscript->schedule action->turn off jscript->action timeouts->crash. fix: check if the proxy is available in ScheduledAction::execute()

  • khtml/ecma/kjs_window.cpp: (ScheduledAction::execute):
17:13 Changeset [19239] by justing

LayoutTests:

Reviewed by harrison


<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)

  • editing/selection/4960137-expected.checksum: Added.
  • editing/selection/4960137-expected.png: Added.
  • editing/selection/4960137-expected.txt: Added.
  • editing/selection/4960137.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4960137>
ASSERTION FAILURE calling SelectionController::setBaseAndExtent (11833)

  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Hand off the selection to the selectionController responsible for it, instead of asserting. A selection object can't be constructed with endpoints in different documents, so this code is only necessary for one endpoint.
16:40 Changeset [19238] by adachan

2007-01-29 Ada Chan <adachan@apple.com>

Reviewed by Brady.


Moved the update of the title of the current entry in the backforward list to WebCore.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didChangeTitle):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setTitle):
16:26 Changeset [22866] by adele

Reviewed by Darin.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Removed EventTargetNode paramenter.
  • WebEditorClient.h:
16:15 Changeset [19237] by adele

WebCore:

Reviewed by Darin.

More preparation for event handling fixes.

  • bridge/EditorClient.h: Removed EventTargetNode parameter from handleKeyPress since we can just get that from the event.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): ditto.
  • page/EventHandler.h: ditto.
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): ditto.
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed EventTargetNode parameter. (WebCore::Editor::execCommand): Made commandMap use AtomicStringImpls instead of Strings. (WebCore::Editor::insertText): Moved from the bridge.
  • page/mac/WebCoreFrameBridge.h: Moved insertText method to Editor.
  • page/mac/WebCoreFrameBridge.mm:
  • WebCore.exp: Updated exports.

WebKit:

Reviewed by Darin.

More preparation for event handling fixes.

  • WebCoreSupport/WebEditorClient.h: Removed EventTargetNode parameter, since you can just get this from the KeyboardEvent.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): ditto.
  • WebView/WebHTMLViewInternal.h: Added interpretKeyEventsParameters struct.
  • WebView/WebViewInternal.h: Changed parameter from NSEvent to WebCoreKeyboardEvent in _interceptEditingKeyEvent.
  • WebView/WebHTMLView.mm: (-[WebHTMLView yankAndSelect:]): Updated for new triggeringEvent parameter. (-[WebHTMLView _interceptEditingKeyEvent:]): Set the WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView doCommandBySelector:]): Access WebHTMLViewInterpretKeyEventsParameters. (-[WebHTMLView insertText:]): ditto. (-[WebHTMLView _insertText:selectInsertedText:triggeringEvent:]): Added parameter for triggeringEvent.
15:45 Changeset [22865] by andersca

Build fix.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: (WaitUntilDoneDelegate::dragDestinationActionMaskForDraggingInfo): (WaitUntilDoneDelegate::willPerformDragDestinationAction):
14:42 Changeset [19236] by andersca

LayoutTests:

Reviewed by Geoff.

<rdar://problem/4960097>
http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]

  • fast/parser/xhtml-document-with-html-object-expected.txt: Added.
  • fast/parser/xhtml-document-with-html-object.xhtml: Added.

WebCore:

Reviewed by Geoff.

<rdar://problem/4960097>
http://bugs.webkit.org/show_bug.cgi?id=12444
Assertion failure in -[WebCoreFrameBridge installInFrame:]


The problem was that the XML tokenizer didn't create elements with
createdByParser set to true.


  • dom/Document.cpp: (WebCore::Document::createElement): New method which takes a QName. This is used by both the XML tokenizer and createElementNS.


(WebCore::Document::createElementNS):
Call new createElement method.


  • dom/XMLTokenizer.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::~XMLTokenizer): Use an OwnPtr for the pending callbacks object. Also, use String instead of StringImpl in the hash map.


(WebCore::toString):
(WebCore::XMLTokenizer::startElementNs):
Call createElement.

14:00 Changeset [19235] by beidson

Reviewed by Oliver

http://bugs.webkit.org/show_bug.cgi?id=12465
Only set the iconURL port for non-zero ports

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL):
13:58 Changeset [19234] by kmccullo

JavaScriptCore:

Reviewed by Geoff and Oliver.

  • rdar://problem/4955561
  • missusing JavaScript shouldn't crash webkit. Now it doesn't, in this case.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime_method.cpp: (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::callAsFunction):

LayoutTests:

Reviewed by Geoff and Oliver.

  • rdar://problem/4955561
  • missusing JavaScript shouldn't crash webkit. Now it doesn't in this case.
  • plugins/call-as-function-test-expected.txt: Added.
  • plugins/call-as-function-test.html: Added.
11:49 Changeset [19233] by oliver

2007-01-29 Oliver Hunt <oliver@apple.com>

build fix

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
10:47 Changeset [22864] by andersca

WebKitWin:

Reviewed by Oliver.

<rdar://problem/4892067>
DnD a font file in Boomer locks it up.

Create a drop target helper so we get snazzy drag images.

  • WebView.cpp: (WebView::WebView): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop):
  • WebView.h:
10:38 Changeset [22863] by oliver

2007-01-29 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Basic implementation of new dragclient method

  • WebDragClient.cpp: (WebDragClient::dragSourceActionMaskForPoint):
  • WebDragClient.h:
10:36 Changeset [19232] by sullivan
  • platform/network/mac/ResourceRequestMac.mm: Build fix -- removed #import of no-longer-extant WebDataProtocol.h (and also one of the two #imports for WebCoreSystemInterface.h, while I was at it)
10:33 Changeset [19231] by andersca

Reviewed by Oliver.

  • page/DragController.cpp: (WebCore::DragController::dragEnteredOrUpdated): Only try a drag operation if the drag client explicitly specified that it is OK
10:25 Changeset [19230] by oliver

2007-01-25 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

WebKit:

Migrated drag state and logic to WebCore, removed superfluous methods

  • ChangeLog:
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (WebDragClient::dragSourceActionMaskForPoint):
  • WebCoreSupport/WebFrameBridge.mm:

allowDHTMLDrag move to WebCore::EventHandler

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): dragOffset and dragSourecAction is now stored in WebCore::DragController migrated _delegateDragSourceActionMask to WebCore::DragController
  • WebView/WebHTMLViewInternal.h: Removed dragOffset declaration, migrated to WebCore::DragController
  • WebView/WebView.mm: removed unnecessary method, _loadingDragOperationForDraggingInfo

WebKitQt:

Reviewed by Adam.

Stub for new DragClient method

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::dragSourceActionMaskForPoint):
  • WebCoreSupport/DragClientQt.h:

WebCore:

Reviewed by Adam.

Migrated more drag logic and state to WebCore


  • page/DragClient.h:
  • page/DragController.cpp: (WebCore::DragController::delegateDragSourceAction): New forwarding method for the UI delegate
  • page/DragController.h: (WebCore::DragController::dragOffset): Now store the drag offset -- the offset of the cursor relative to the drag image) in DragController
  • page/EventHandler.cpp: (WebCore::EventHandler::allowDHTMLDrag): Moved from WebFrameBridge
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::handleDrag): EventHandlerMac now uses EventHandler::allowDHTMLDrag rather than the implementation in WebFrameBridge
  • page/mac/WebCoreFrameBridge.h: removed definition of allowDHTMLDrag from WebFrameBridge
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::dragSourceActionMaskForPoint): Updated empty DragClient
10:20 Changeset [19229] by brmorris

brmorris <bradley.morrison@nokia.com>

Reviewed by nobody - build fix.
DESC: Fix for build bustage in r19200 - MLIO-6XCCTG

10:18 Changeset [19228] by brmorris

brmorris <bradley.morrison@nokia.com>

Reviewed by nobody - build fix.
DESC: Fix for build bustage caused by r19201 - MLIO-6XCCTG

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:04 Changeset [19227] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12359
XPathEvaluator may return some nodes more than once in a result set

Test: fast/xpath/nodeset-duplicates.html

  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::doEvaluate): Ensure uniqueness of elements in the node-set.
  • xml/XPathPredicate.cpp: (WebCore::XPath::Union::doEvaluate): Fixed a uniqueness algorithm that was already present here. Added a FIXME about incorrect result ordering.
09:55 Changeset [19226] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12340
XPathEvaluator behavior does not match Firefox - name() and attribute nodes

WebCore:

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunName::doEvaluate): Do not try to append a prefix if it doesn't exist.

LayoutTests:

  • fast/xpath/name-null-namespace-expected.txt: Added.
  • fast/xpath/name-null-namespace.html: Added. Test for the bug.
  • fast/dom/xpath-empty-string-expected.txt: Removed.
  • fast/dom/xpath-empty-string.html: Removed. Moved these to fast/xpath.
  • fast/xpath/xpath-namespaces.html: Fixed an inline document to be well-formed, so the test now passes in Firefox. This is really a quirk of our DOMParser that the test passed in WebKit: on error, a descriptive message is appended to the partially parsed document, instead of replacing it.
09:40 Changeset [19225] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11815
XPathEvaluator behavior does not match Firefox - substring() and empty element

Test: fast/xpath/empty-string-substring.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::Value):
  • xml/XPathValue.h: Added a constructor taking const char*, so that string literals and arrays don't get converted to boolean values.
08:11 Changeset [19224] by zack

Cosmetic fixes - don't resize the widget in the constructor
(it was a hack from the initial port) and fix the paint
signature)

07:23 Changeset [22862] by mjs

WebCoreWin:

  • fix build
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

  • fix build
  • WebFrame.h:
07:10 Changeset [19223] by mjs
  • change from struct to class to make picky compilers happy
  • loader/SubstituteData.h:
06:28 Changeset [19222] by bdash

2007-01-30 Mark Rowe <mrowe@apple.com>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12458
Bug 12458: Crash in W3C-SVG-1.1/animate-elem-09-t.svg running layout tests under guard malloc

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::parseValues): ptr either points to a ';' or off the end of the buffer. We're interested in what comes before the ';', so start there instead.
05:37 Changeset [19221] by zack

Take the scrollbars into considation when computing
the contents size of the main frame

05:06 Changeset [19220] by mjs
  • fix includes
  • loader/SubstituteData.h:
05:03 Changeset [22861] by mjs

Reviewed by Mark.


<rdar://problem/4910106> Need to support loadData and loadHTMLString


I added the underlying support, but did not turn on the new cross-platform versions yet as I've
not had sufficient time to test.

  • WebDocumentLoader.cpp: (WebDocumentLoader::WebDocumentLoader):
  • WebDocumentLoader.h:
  • WebFrame.cpp: (WebFrame::createDocumentLoader):
  • WebFrame.h:
05:01 Changeset [19219] by mjs
  • added new file that I forgot in the last commit
  • loader/SubstituteData.h: Added. (WebCore::SubstituteData::SubstituteData): (WebCore::SubstituteData::isValid): (WebCore::SubstituteData::content): (WebCore::SubstituteData::mimeType): (WebCore::SubstituteData::textEncoding): (WebCore::SubstituteData::failingURL):
04:50 Changeset [19218] by mjs

WebCore:

Reviewed by Mark.

  • made data loading cross-platform
  • fixed <rdar://problem/4910106>
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedResource.cpp:
  • loader/CachedResource.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::setRequest): (WebCore::DocumentLoader::urlForHistory): (WebCore::DocumentLoader::unreachableURL):
  • loader/DocumentLoader.h: (WebCore::DocumentLoader::substituteData):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::checkNavigationPolicy):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): (WebCore::MainResourceLoader::continueAfterContentPolicy): (WebCore::MainResourceLoader::handleEmptyLoad): (WebCore::MainResourceLoader::handleDataLoad): (WebCore::MainResourceLoader::loadNow): (WebCore::MainResourceLoader::load):
  • loader/MainResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm:
  • loader/mac/WebDataProtocol.h: Removed.
  • loader/mac/WebDataProtocol.mm: Removed.
  • loader/qt/DocumentLoaderQt.cpp:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createDocumentLoader):

WebKit:

Reviewed by Mark.

  • updated for cross-platform data loading support


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDataSource.mm: (-[WebDataSource initWithRequest:]):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::WebDocumentLoaderMac):
  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm: (uniqueURLWithRelativePart): (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):

WebKitQt:

Reviewed by Mark.

  • updated for cross-platform data loading support
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createDocumentLoader):
  • WebCoreSupport/FrameLoaderClientQt.h:
03:57 Changeset [19217] by zack

Order the build files alphabetically instead of
the random mess we had before

03:30 Changeset [19216] by zack

Use the platform independent scrollbar code.
Remove the redundant empty stubs and forward
few missing platform scrollbar calls
r=Lars

02:37 Changeset [19215] by staikos

Make window resizing work

02:24 Changeset [19214] by staikos

Make popup windows work

01:24 Changeset [19213] by lars

Reviewed by Zack

Fix the way we handle native widgets (QWidget) inside
WebCore. Now WebCore::Widget owns the QWidget in all
cases. This is the only way to get well defined semantics
for all teh native widgets we have (currently ScrollView
and ScrollBar, but plugins will follow).

This has the side effect that one cannot rely on a defined
lifetime of a QWebFrame when using the API.

01:01 Changeset [22860] by sfalken

2007-01-29 Steve Falkenburg <sfalken@apple.com>

Fix build break from RootObject ownership change.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::createRootObject): Added (WebCore::FrameWin::cleanupPluginObjects): change destroy to invalidate (WebCore::FrameWin::bindingRootObject): change new RootObject to RootObject::create
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): change new RootObject to FrameWin::createRootObject.
01:00 Changeset [19212] by staikos

Missed saving this file before the previous checkin.

00:47 Changeset [19211] by staikos

Implement more functions for the Qt build

01/28/07:

22:28 Changeset [19210] by staikos

Fix redirects with the Qt resource implementation.

22:17 Changeset [19209] by ggaren

Reviewed by Maciej Stachowiak.


First step in fixing <rdar://problem/4485644> REGRESSION: JavaScriptCore
has init routines


Don't rely on a static initializer to store the main thread's ID (which
we would use to detect allocations on secondary threads). Instead, require
the caller to notify fastMalloc if it might allocate on a secondary thread.


Also fixed what seemed like a race condition in do_malloc.


tcmalloc_unittest and my custom versions of JS iBench and PLT show no
regressions.

  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded): (1) Renamed from "fastMallocRegisterThread", which was a misleading name because not all threads need to register with fastMalloc -- only secondary threads need to, and only for the purpose of disabling its single-threaded optimization.

(2) Use the pageheap_lock instead of a custom one, since we need to synchronize
with the read of isMultiThreaded inside CreateCacheIfNecessary. This is a new
requirement, now that we can't guarantee that the first call to CreateCacheIfNecessary
will occur on the main thread at init time, before any other threads have been created.

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::do_malloc): Reverted WTF change only to call GetCache() if size <= kMaxSize.
The WTF code would read phinited without holding the pageheap_lock, which
seemed like a race condition. Regardless, calling GetCache reduces the number
of code paths to module initialization, which will help in writing the
final fix for this bug.

22:00 Changeset [19208] by bdash

2007-01-29 Mark Rowe <mrowe@apple.com>

Reviewed by Brady.

http://bugs.webkit.org/show_bug.cgi?id=11085
Bug 11085: REGRESSION: favicon.ico always looked for on port 80

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): Copy the port over to the favicon URL.
19:22 Changeset [19207] by aroben

Reviewed by Adele.

Fix http://bugs.webkit.org/show_bug.cgi?id=12453
REGRESSION(r19197): Tabbing into web page requires two key presses

All layout tests pass.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): If there's no focused frame, actually go ahead and find a focusable node instead of just focusing the main frame and quitting. This behavior was a holdover from a previous desired tabbing behavior with respect to frames.
19:10 Changeset [19206] by ddkilzer

LayoutTests:

Reviewed by Darin and David Hyatt.

  • fast/block/basic/white-space-pre-wraps-expected.checksum: Added.
  • fast/block/basic/white-space-pre-wraps-expected.png: Added.
  • fast/block/basic/white-space-pre-wraps-expected.txt: Added.
  • fast/block/basic/white-space-pre-wraps.html: Added.

WebCore:

Reviewed by Darin and David Hyatt.

Test: fast/block/basic/white-space-pre-wraps.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Wrap a non-wrapping text run if it appears on a line with previous text runs that do wrap.
18:38 Changeset [19205] by ddkilzer

Removed files that were not committed from the ChangeLog entry.

18:36 Changeset [19204] by ddkilzer

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/layers/removed-by-scroll-handler.html

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added a m_enqueueEvents count. (WebCore::FrameView::layout): Raise the enqueue count before starting layout and until after enqueued events are dispatched. (WebCore::FrameView::scheduleEvent): Made this function dispatch the event immediately unless the enqueue count is positive.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset): Schedule the scroll event through the FrameView. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
18:30 Changeset [19203] by ddkilzer

JavaScriptCore:

Reviewed by Darin.

Creating a function using 'new Function()' was not setting its prototype with the
same flags as 'function() { }'.

Test: fast/js/function-prototype.html

  • kjs/function_object.cpp: (FunctionObjectImp::construct): Change flags from DontEnum|DontDelete|ReadOnly to Internal|DontDelete to match FuncDeclNode::processFuncDecl() and FuncExprNode::evaluate() in kjs/nodes.cpp.

LayoutTests:

Reviewed by Darin.

  • fast/js/function-prototype-expected.txt: Added.
  • fast/js/function-prototype.html: Added.
16:03 Changeset [19202] by eseidel

2007-01-28 Charles Ying <charles_ying@yahoo.com>

Reviewed by eseidel. Landed by eseidel.

Fix http://bugs.webkit.org/show_bug.cgi?id=12429

animateTransform rotate, with cx/cy is broken


SVGTransform now contains a float point to store the rotation center, needed

to track rotation center for interpolation by animateTransform.


SVGTransform now has an additional constructor:

SVGTransform(type) to make empty base value transforms that match their
distanced values.


Removed m_colorDistance and m_transformDistance from their respective classes

as they are now computed at update time.

Fix a case where animateTransform did not parse transform values correctly

according to BNF in W3C spec:

Test case in:

  • manual-tests/animation/animateTransform-toanimation.svg: Added.

Fix a case where animateTransform only specified a to animation only.

Test case in:

  • manual-tests/animation/animateTransform-parser.svg: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateColorElement::updateAnimatedValue): (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::updateAnimatedValue): (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateTransformElement::calculateFromAndToValues): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::angle): (SVGTransform::rotationCenter): (SVGTransform::setTranslate): (SVGTransform::setScale): (SVGTransform::setRotate): (SVGTransform::setSkewX): (SVGTransform::setSkewY):
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformDistance.h:
  • manual-tests/animation/animateTransform-parser.svg: Added.
  • manual-tests/animation/animateTransform-toanimation.svg: Added.
14:48 Changeset [19201] by brmorris

spadma

DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
Reviewed by Zalan, merge of r19200 from 3.1 branch to s60/trunk by brad.
http://bugzilla.opendarwin.org/show_bug.cgi?id=12415

14:12 Changeset [19200] by brmorris

spadma <Sachin.Padma@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: Entering or leaving a secure web site causes several confirmations MLIO-6XCCTG
http://bugzilla.opendarwin.org/show_bug.cgi?id=12415

11:35 Changeset [19199] by ap

Fixed a broken test to actually work (and fail).

  • dom/svg/level3/xpath/Conformance_ID-expected.checksum: Removed.
  • dom/svg/level3/xpath/Conformance_ID-expected.png: Removed.
  • dom/svg/level3/xpath/Conformance_ID-expected.txt:
  • dom/svg/level3/xpath/Conformance_ID.svg:
10:17 Changeset [19198] by brmorris

bujtas <zbujtas@gmail.com>

Rs'd by Brad
DESC: display fallback content in case of unsupported plugin.
http://bugs.webkit.org/show_bug.cgi?id=12426

fix: webkit should return null, if the plugin is not supported.

  • bridge/WebCoreBridge.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::createPart): (KWQKHTMLPart::createSoundstart):
Note: See TracTimeline for information about the timeline view.