Timeline


and

02/17/07:

22:28 Changeset [22960] by aroben
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Removed bogus single-file configuration for MimeTypeRegistryWin.cpp.
22:04 Changeset [22959] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-02-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.

  • Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
  • WebView.cpp: (WebView::scrollOffset): Add null check (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here) (WebView::visibleContentRect): Added so we can size find overlay appropriately (not including scroll bars)
  • WebView.h: Added scrollBy, visibleContentRect
17:59 Changeset [22958] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Part of the OpenSource fix to make sure the fill color starts off as transparent. Make sure our CG context
has its state properly in sync with the CGContext.

Reviewed by aroben

  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
17:58 Changeset [19687] by hyatt
  • 2 edits in trunk/WebCore

Fix textarea resizers to not fill with black by making sure the fill color starts off as
transparent instead of black.

Reviewed by aroben

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
17:52 Changeset [22957] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Build fix.

  • platform/win/CursorWin.cpp: (WebCore::notAllowedCursor):
14:23 Changeset [19686] by aroben
  • 2 edits in trunk

Added missing Radar references to ChangeLogs.

14:21 Changeset [19685] by aroben
  • 3 edits
    4 adds in trunk

2007-02-17 Lars Knoll <lars@trolltech.com>

LayoutTests:

Reviewed by Adam.

test for http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

  • fast/images/image-in-map-expected.checksum: Added.
  • fast/images/image-in-map-expected.png: Added.
  • fast/images/image-in-map-expected.txt: Added.
  • fast/images/image-in-map.html: Added.

WebCore:

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

Test: fast/images/image-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD):
14:09 Changeset [19684] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • fast/xpath/namespace-vs-predicate-expected.txt: Added.
  • fast/xpath/namespace-vs-predicate.xhtml: Added.

WebCore:

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its resulting type is an expanded name, rather than a string. It is not really possible to store the namespace inside Parser, because it gets used in wrong steps then.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::expandQName):
  • xml/XPathParser.h: Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::Step):
  • xml/XPathStep.h: Added a constructor that takes a namespace.
11:03 Changeset [19683] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
  • fast/loader/simultaneous-reloads-assert-expected.txt: Added.
  • fast/loader/simultaneous-reloads-assert.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/simultaneous-reloads-assert.html

  • loader/Cache.cpp: (WebCore::Cache::remove): Replaced the assertion with a check whether the resource is in the cache. The resource could have been removed from the cache as a result of a reload occurring simultaneously in a different document.
10:58 Changeset [19682] by adele
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12711
Prettier and more distinct cursors

  • Resources/crossHairCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/notAllowedCursor.png: Added.
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::crossCursor): (WebCore::notAllowedCursor):
10:35 Changeset [19681] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/shadow-boundary-crossing-expected.txt: Added.
  • fast/events/shadow-boundary-crossing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/shadow-boundary-crossing.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new eventParentNode() function for constructing the chain of ancestors for capture and bubbling.
  • dom/Node.h: (WebCore::Node::eventParentNode): Added. Returns the node's parent for the purpose of of event capture and bubbling. The base class implementation is to return the parent node.
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble to and can be captured across the shadow DOM boundary, returns the shadow parent for shadow nodes.
01:58 Changeset [22956] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix how resizers invalidate so that there aren't glitches in the lower right corner of the window as you switch pages.

01:50 Changeset [19680] by hyatt
  • 2 edits in trunk/WebCore

Improve textarea resizer painting.

01:07 Changeset [19679] by kjk
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
by Mike Emmel.

  • kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
  • kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
  • wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions

WebCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
from Mike Emmel.

  • platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
  • platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData to the end, to avoid crashes on ARM due to different struct packing.
00:27 Changeset [19678] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

  • fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • fast/forms/input-readonly-autoscroll-expected.png: Added.
  • fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • fast/forms/input-readonly-autoscroll.html: Added.

WebCore:

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

Test: fast/forms/input-readonly-autoscroll.html

Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
00:21 Changeset [22955] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text). This will also reveal the selection properly.
00:14 Changeset [19677] by kjk
  • 7 edits in trunk/WebCore

Reviewed by Adam Roben.

Curl networking improvements inspired by Mike Emmel's patches in
http://bugs.webkit.org/show_bug.cgi?id=11332.
Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.

  • loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API. (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::willUseArchive):
  • loader/gdk/FrameLoaderClientGdk.h: Ditto.
  • platform/network/ResourceHandleInternal.h: Remember url and custom headers for the request lifetime and free them at the end. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: Ditto. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: url improvements:
  • remove m_useSimple code-path since it wasn't used anywhere
  • don't use hashmap for keeping track of outstanding jobs - curl does it anyway
  • set custom headers from request
  • enable gzip and deflate through Accept-Encoding
  • setup curl to share cookies and DNS cache between requests
  • enable persisting of cookies in a file (if client provides file name for cookies via ResourceHandleManager::setCookieJarFileName()) (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h:
00:09 Changeset [19676] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Gdk fixes.

  • page/gdk/EventHandlerGdk.cpp: Comment out chatty message. (WebCore::EventHandler::handleDrag):
  • platform/gdk/EditorClientGdk.cpp: Enable entering text into text field. (WebCore::EditorClientGdk::shouldInsertText):

02/16/07:

22:33 Changeset [19675] by kjk
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Move Path implementation from TemporaryLinkStubs.cpp to
its own file.
Implement setLineCap, setLineJoin and setMiterLimit for
cairo's GraphicsContext.

  • WebCoreSources.bkl:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit):
  • platform/graphics/cairo/PathCairo.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::Path::apply):
21:00 Changeset [19674] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix uninitialized variable

20:39 Changeset [19673] by adachan
  • 2 edits in trunk/WebCore

2007-02-16 Ada Chan <adachan@apple.com>

Reviewed by Adam and Maciej.

Use a RefPtr to store the old hover node.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):


17:15 Changeset [19672] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames

This symptom is specific to Safari, so no layout test.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the text field is focused.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text field is focused. (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast. (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if the text field is focused.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea, textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
17:04 Changeset [19671] by hyatt
  • 2 edits in trunk/WebCore/platform

API tweaks to widget and scrollview.

17:04 Changeset [22954] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix RSS scrollbar.

16:31 Changeset [19670] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4811446> "Check Grammar" checkbox in Spelling+Grammar window doesn't live update with menu change in WebKit
  • WebView/WebView.mm: (-[WebView setGrammarCheckingEnabled:]): Use sekrit AppKit knowledge to tell NSSpellChecker about the change, since there's no API for this yet. Also restructured a little to avoid extra work when the value hasn't changed.
15:59 WikiStart edited by aroben@apple.com
Added login link (diff)
15:58 WikiStart edited by aroben@apple.com
Added registration link (diff)
15:48 Changeset [22953] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

15:21 Changeset [19669] by brmorris
  • 3 edits in S60/trunk/WebKit

wei, reviewed by zalan. reverted and re-merged by mbradley

DESC: Reverts r19963 and re-applies with and updated patch. PNIO-6YFCUT conversion problem w/ google search
http://bugs.webkit.org/show_bug.cgi?id=12792

15:05 Changeset [19668] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by yongjun

DESC: Browser crash when exited upon loading JKRL-6Y9HXC
http://bugs.webkit.org/show_bug.cgi?id=12772

14:29 Changeset [19667] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4943985>
REGRESSION: Dragging standalone images to Finder fails to download the image file


Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in
ImageDocumentMac.mm


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
14:02 Changeset [22952] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

ScrollView fixes.

13:56 Changeset [19666] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Anders.

  • fix <rdar://problem/5000216> JavaScriptGlue framework started turning all CFNumbers into signed 32bit values

Circumstantial evidence seems to indicate that JavaScriptGlue was depending on a bug
in CFNumber where CFNumberIsFloatType was returning true for 64-bit integer values.

  • JSUtils.cpp: (JSObjectKJSValue): Removed the call to CFNumberIsFloatType in the conversion of numeric values, and always use kCFNumberDoubleType, since double is the internal format of numbers in JavaScriptCore. There's no value to having a separate code path for integers. There's also no reason to check the return value from CFNumberGetValue -- if it returns false it still does the best it can to convert to a double, which is what we want.
  • UserObjectImp.cpp: (UserObjectImp::toString): Removed a similar code path that tried to handle integers separate from double. Instead, always use a double. For compatibility, use a format without a decimal point when CFNumberIsFloatType returns false. Also removed a bogus cast to float; the "%f" format string takes a double, not a float, so all the cast did was cut down on precision.
13:54 Changeset [19665] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)

  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Change the default to log the violations.
12:52 Changeset [19664] by zbujtas
  • 3 edits in S60/branches/3.1m/WebKit

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
http://bugs.webkit.org/show_bug.cgi?id=12792

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::LoadUrlL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::SetUrlL):
12:13 Changeset [19663] by brmorris
  • 5 edits in S60/trunk

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
http://bugs.webkit.org/show_bug.cgi?id=12792

12:07 Changeset [22951] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4993040>
Crash in plugin code watching yahoo news video


Zero out the plugin function struct.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
11:41 Changeset [22950] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebDownload.cpp: (WebDownload::init): (WebDownload::initWithRequest):
11:40 Changeset [19662] by adele
  • 10 edits in trunk/WebCore

Reviewed by Mitz.

Fixed: http://bugs.webkit.org/show_bug.cgi?id=12768
<rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field

No test case added. This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.

  • dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
  • dom/Element.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
  • html/HTMLInputElement.h: ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
  • html/HTMLTextAreaElement.h: ditto.
  • page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page. Pass true for the restorePreviousSelection argument.
  • rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView. It shouldn't be null, but if it is, we'll fail silently on release builds. (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::windowClipRect): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
11:16 Changeset [19661] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=12788
REGRESSION: Going back one page in history has a noticeable delay


Um...if all elements in two vectors are equal, then I guess we could say that
the two vectors are equal too.


  • wtf/Vector.h: (WTF::):
11:03 Changeset [22949] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Fix build.

Use adoptCF instead of adopt.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
11:00 Changeset [19660] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC

Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.


  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptNSReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adoptCF): (WebCore::::adoptNS):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
10:58 WebKit Team edited by sullivan@apple.com
(diff)
08:56 Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
08:56 Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
08:52 Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
08:31 Changeset [19659] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao, Reviewed by Yongjun.

DESC: Merge of 19656 to 3.1m branch (Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query. ISHG-6Q2ST8)
Fix: Change the confirmation query softkey buttons to Yes|No
http://bugs.webkit.org/show_bug.cgi?id=12742

08:27 Changeset [19658] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by <yongjun.zhang@nokia.com>.

DESC: Browser crash when exited upon loading. JKRL-6Y9HXC
http://bugs.webkit.org/show_bug.cgi?id=12772

08:24 Changeset [19657] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: 3.2:webkit "page not found" problem, which is before TelService be launched (TLUU-6YDPRT)
http://bugs.webkit.org/show_bug.cgi?id=12771

08:22 Changeset [19656] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by Yongjun

DESC: [S60] Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query.ISHG-6Q2ST8
Fix: Change the confirmation query softkey buttons to Yes|No
http://bugs.webkit.org/show_bug.cgi?id=12742

08:20 Changeset [19655] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen Reviewed by <yongjun.zhang@nokia.com>.

DESC: Selection list not shown correctly in www.elisa.fi [ TSW ID: HMNN-6XQJMX]
http://bugs.webkit.org/show_bug.cgi?id=12719

08:18 Changeset [19654] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun

DESC: When application is launched via hyperlink, the cursor stays as wait cursor (TSW EAJA-6VDH84)
http://bugs.webkit.org/show_bug.cgi?id=12715

03:35 Changeset [22948] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Oliver.

Implemented square button look.

02/15/07:

21:19 Changeset [19653] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Lost Objective-C Hippyness (or hippiness)

Oh boy, did I ever botch this one up...

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Null check the FrameView
20:44 Changeset [19652] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam's complaint

aroben wanted me to do an early return, instead.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
20:40 Changeset [19651] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele

Forgot to bring the null check with me when I backed this code out of
the FrameLoaderClient

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): null check the HistoryItem
20:19 Changeset [22947] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-15 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5001181> Crash: autofilling empty page


Return an error from WebFrame::DOMDocument if there's no document

  • WebFrame.cpp: (WebFrame::DOMDocument): null document now maps to E_FAIL
20:13 Changeset [22946] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://4778394> - Save scroll position in the back/forward list


  • WebFrame.cpp: (WebFrame::restoreViewState): Renamed, as scroll position was pushed to WebCore (WebFrame::saveViewStateToItem): Ditto
  • WebFrame.h:
20:11 Changeset [19650] by beidson
  • 11 edits in trunk

WebCore:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Actually save the scroll position here instead of asking the FrameLoaderClient (WebCore::FrameLoader::restoreScrollPositionAndViewState): Ditto
  • loader/FrameLoaderClient.h: Renamed/repurposed 2 methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::restoreViewState): Ditto (WebCore::SVGEmptyFrameLoaderClient::saveViewStateToItem): Ditto

WebKit:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • WebCoreSupport/WebFrameLoaderClient.h: Renamed the save/restore methods
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::saveViewStateToItem): Save viewstate only (WebFrameLoaderClient::restoreViewState): Restore viewstate only

WebKitQt:

Reviewed by Adam

Moved scroll state down into the cross platform FrameLoader -
Blind attempt at keeping Qt building

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::restoreViewState): (WebCore::FrameLoaderClientQt::saveViewStateToItem):
  • WebCoreSupport/FrameLoaderClientQt.h:
20:00 Changeset [19649] by bdash
  • 2 edits in trunk/WebKitTools

2007-02-16 Mark Rowe <mrowe@apple.com>

Not reviewed.

<rdar://problem/4982312> leaks bot should run in normal mode, rather than quiet mode

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Switch back to default verbosity for output of leaks tests.
18:35 Changeset [19648] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

Added:

  • editing/pasteboard/4989774-expected.checksum: Added.
  • editing/pasteboard/4989774-expected.png: Added.
  • editing/pasteboard/4989774-expected.txt: Added.
  • editing/pasteboard/4989774.html: Added. Equivalent trees:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

<span><img><span><img></span></span> will appear as two
images on different lines because of a layout/rendering
bug. This patch avoids the bug by producing cleaner
markup so that the paste code can safely remove the style
spans.

  • editing/markup.cpp: (WebCore::createMarkup): Get the default style from the editable root or body instead of the document element. This produces cleaner markup since we don't inline the root's styles.
17:47 Changeset [19647] by kjk
  • 3 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Add gdk version of ContextMenuClient based on qt version.

  • WebCoreSources.bkl:
  • page/gdk/ContextMenuClientGdk.cpp: Added. (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/ContextMenuClientGdk.h: Added.
  • webcore-base.bkl: curl is needed when building webcore_base files.
17:07 Changeset [22945] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix <rdar://problem/4968731> Printing scales frames to page width
instead of doing a layout at that width

  • Interfaces/IWebFramePrivate.idl: Added setInPrintingMode method.
  • WebFrame.cpp: (WebFrame::WebFrame): Initialize new member. (printerRect): New helper function. (WebFrame::setPrinting): Ported from WebHTMLView. (WebFrame::setInPrintingMode): Implemented. (WebFrame::computePageRects): Changed to store the page rects. (WebFrame::getPrintedPageCount): Added an ASSERT and updated for change to computePageRects. (WebFrame::spoolPages): Use the stored page rects, and set mediaBox's size using the print rect instead of the page rect so we will scale the pages to the full width of the print DC. (WebFrame::forceLayoutWithPageWidthRange): Ported from WebFrameBridge.
  • WebFrame.h: Updated declarations.
15:58 Changeset [22944] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

15:57 Changeset [19646] by sfalken
  • 1 copy in tags/Safari-521.34.5b

New tag.

14:35 Changeset [22943] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Add the default Flash plugin location to the list of plugin paths.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addFlashPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths):
14:13 Changeset [22942] by sfalken
  • 6 edits in branches/WindowsMerge

2007-02-15 Lou Amadio <lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • WebKit.vcproj/WebKit.vcproj:
  • WebPreferences.cpp: (WebPreferences::setFontSmoothing):
  • WebView.cpp: (WebViewWndProc):

2007-02-15 Lou Amadio <lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

2007-02-15 Lou Amadio <lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style

2007-02-15 Lou Amadio <lamadio@apple.com>

Reviewed by Steve.

Added WebKitSystemInterfaceWin

14:10 Changeset [19645] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Fixed: <rdar://problem/4983883> Background of a .mov window should not be white

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Set a background color of gray for full frame plug-ins, which makes it easier on the eyes. It's also the same gray that PDFKit uses, too.
14:05 Changeset [19644] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

The problem was that selectionRect() was being called on a render tree that
had pending style changes. The changes were committed as a side effect in
the middle of traversing the render tree, and the current object got
deleted as a result. The solution is to update the render tree before
starting to traverse it.

The inspector was affected because it makes style changes in response to
an AppKit notification that's sent right before the windowDidResignKey:
notification, under which WebKit calls selectionRect(). I couldn't recreate
the same conditions (having uncommitted style changes in the tree when the
window becomes inactive) using HTML/JS in Safari, hence the lack of
a regression test to go with this patch.

  • rendering/RenderView.cpp: (WebCore::RenderView::selectionRect): Added call to updateRendering().
13:03 Changeset [19643] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Document::removeMarkers() was using a Vector iterator (which is just a
pointer) and inserting into the Vector at the same time, which made the
iterator invalid as the Vector's data buffer was relocated.


Replaced all instances of Vector<DocumentMarker>::iterator with indices.

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):
12:51 Changeset [22941] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4987529>
Regression: first clicks don't work at flash-based Nokia.com

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Don't set buttons for mouse move. Also, ignore unknown mouse events.
11:00 Changeset [19642] by darin
  • 2 edits in trunk/WebKitSite
  • projects/performance/index.html: Fix i-Bench link.
10:46 Changeset [19641] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • tables/mozilla/bugs/bug45486-expected.checksum:
  • tables/mozilla/bugs/bug45486-expected.png:
  • tables/mozilla/bugs/bug45486-expected.txt:
  • tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Darin.

Fixes existing layout tests: tables/mozilla/bugs/bug45486.html

tables/mozilla_expected_failures/core/col_span2.html

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): Fixed a mismatch between which columns count as percentage columns when adding up the total percent and which columns count as percentage columns when converting non-percentage columns to effectively-percentage.
10:21 Changeset [19640] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


  • DumpRenderTree/DumpRenderTree.m: Don't ignore NSAttributedString WebCore::Node leaks anymore, either, since r19486 fixed them, too. (shouldIgnoreWebCoreNodeLeaks):
09:47 Changeset [19639] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't ignore NSAttributedString leaks any more. Those were fixed by change 19486.
09:29 Changeset [19638] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:

02/14/07:

21:51 Changeset [19637] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-02-14 Mitz Pettel <mitz@webkit.org>

Reviewed by Sam Weinig!

  • manual-tests/background-image-change-in-page-cache.html: Added.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Bail out if the object is not in a view, which can happen if the document is in the page cache and the same cached image used for its background is also being used in another document that is currently in view.
19:17 Changeset [19636] by aroben
  • 10 edits
    1 copy
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

  • fast/events/frame-programmatic-focus-expected.txt: Added.
  • fast/events/frame-programmatic-focus.html: Added.
  • fast/forms/focus2-expected.txt: Updated results to now-correct behavior.

WebCore:

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

Test: fast/events/frame-programmatic-focus.html

  • dom/Element.cpp: (WebCore::Element::focus): Call FocusController::setFocusedNode to set the focus for the whole page.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Send the textInput event to the same target that was sent the keypress event before it.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Added a FIXME. (WebCore::FocusController::setFocusedNode): Added. Sets the focused node for a whole page.
  • page/FocusController.h: Added declaration.
  • platform/cf/RetainPtr.h: Removed unused pointer_cast functions.
17:15 Changeset [19635] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/execCommand/4976800-expected.txt: Added.
  • editing/execCommand/4976800.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): Add line breaks if removing the indented node causes content before or after it to collapse into the same paragraph as its content.
17:11 Changeset [19634] by justing
  • 2 edits
    8 adds in trunk

Reviewed by adele


<rdar://problem/4960120>
REGRESSION: First Enter key ignored on initial focus of textarea after page load (11967)


We'd insert a newline, but into an empty div. We need two newlines
in that case.

  • editing/InsertLineBreakCommand.cpp: (WebCore::lineBreakExistsAtPosition): Returns true if there is a br or a '\n' in text that preserves newlines at the incoming position. (WebCore::InsertLineBreakCommand::doApply): Fixed to handle the empty block case, the anonymous block case.
16:35 Changeset [19633] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/forms/select-enter-key-expected.txt: Added.
  • fast/forms/select-enter-key.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/forms/select-enter-key.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Add code to submit when someone hits the Enter key.
15:50 Changeset [19632] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4960112>
http://bugs.webkit.org/show_bug.cgi?id=12417
REGRESSION: "Are you sure you want to send a form again?" sheet is displayed twice (validator.w3.org)


The problem was that doing a reload would cause the "Cache-Control" HTTP header to be set on the request _after_ the first
navigation policy delegate callback was called. This would break the request equality check that's used to prevent multiple policy
delegate callbacks from getting called for the same request. The solution is to set the header as early as possible.


This patch also fixes some bugs in the ResourceRequest equality operator.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Set the "Cache-Control" header field on the request here.


  • platform/network/FormData.h: (WebCore::operator==): Short-circuit if the pointers are the same.


  • platform/network/ResourceRequest.cpp: (WebCore::operator==): Check the equality of the objects, not the pointers.
15:42 Changeset [19631] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add new canCompareWithMemcmp vector trait and use it to determine whether
operator== can use memcmp.


  • wtf/Vector.h: (WTF::): (WTF::VectorTypeOperations::compare): (WTF::operator==):
  • wtf/VectorTraits.h: (WTF::):
15:31 Changeset [19630] by hyatt
  • 3 edits
    1 delete in trunk/WebCore

Move setPlatformData out of FontFallbackListMac.mm and delete the file. The function was completely
cross-platform already.

Reviewed by Ada

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontFallbackList.cpp: (WebCore::FontFallbackList::setPlatformFont):
14:29 Changeset [19629] by hyatt
  • 4 edits in trunk/WebCore

Make the Font constructor that takes a FontPlatformData cross-platform, since the implementation was already
completely cross-platform.

Reviewed by Ada

  • platform/Font.cpp: (WebCore::Font::Font):
  • platform/Font.h:
  • platform/mac/FontMac.mm:
13:44 Changeset [19628] by antti
  • 2 edits in trunk/WebCore

Reverting http://bugs.webkit.org/show_bug.cgi?id=11974, it causes repainting problems in some cases.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::avoidsFloats):
12:44 Changeset [19627] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Darin Adler, tweaked and committed by Geoff Garen.


Reverting my fix for find-after-replace.html and committing this one because
its results don't rely on an editing bug and because stomping bugzilla patches
is just plain uncivilized.

  • editing/execCommand/find-after-replace.html: Use the frame's onload handler instead of relying on a timeout. Force a layout to get a correct render tree when dumping. (This requirement may be an editing bug.)
11:02 Changeset [19626] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/textfield-overflow-expected.checksum: Added.
  • fast/forms/textfield-overflow-expected.png: Added.
  • fast/forms/textfield-overflow-expected.txt: Added.
  • fast/forms/textfield-overflow.html: Added.

WebCore:

Reviewed by Maciej.



Set controlClip for non-search text controls.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):
10:01 Changeset [19625] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Check for possible conversion failure.
09:17 Changeset [19624] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:
09:15 Changeset [19623] by brmorris
  • 2 edits in S60/trunk/WebKit

DESC: add widget registry client dll to rom image via webkit.iby
http://bugs.webkit.org/show_bug.cgi?id=12765

09:13 Changeset [19622] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Beth Dakin.


Blind attempt to make this test more reliable. (It fails intermittently
on the buildbot.)

  • editing/execCommand/find-after-replace-expected.checksum:
  • editing/execCommand/find-after-replace-expected.png:
  • editing/execCommand/find-after-replace-expected.txt:
  • editing/execCommand/find-after-replace.html: Use a load event handler instead of a 100ms timer. There's no guarantee that everything will be done loading in under 100ms (and there's no reason to wait that long all the time, either!).
06:10 Changeset [19621] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/text/break-word-expected.checksum: Added.
  • fast/text/break-word-expected.png: Added.
  • fast/text/break-word-expected.txt: Added.
  • fast/text/break-word.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/text/break-word.html

The wrapW variable used to keep track of the width of the characters scanned
so far by adding up the widths of individual characters. Because of the
rounding hack, the total ended up being bigger than the width of the same characters
when measured together as a single run.

The fix is to use wrapW only as an upper bound, and once it overflows the line's width,
fall back on measuring everything from the beginning of the line as one run.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Implemented the above fix, including not measuring additional single characters once wrapW overflows the line. Also moved the assignment to breakNBSP out of the loop since it is constant for the entire text object, made breakWords and midWordBreak update only when they might change, and cleaned up a few things.
02:52 Changeset [19620] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/forms/password-placeholder-expected.checksum: Added.
  • fast/forms/password-placeholder-expected.png: Added.
  • fast/forms/password-placeholder-expected.txt: Added.
  • fast/forms/password-placeholder.html: Added.

WebCore:

Reviewed by Hyatt.


Disable textSecurity when placeholder is visible.


  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updatePlaceholder):

02/13/07:

22:31 Changeset [22940] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-13 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


Send tab keypresses to IWebFormDelegate::doCommandBySelector.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
21:23 Changeset [19619] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mark Rowe.

http://bugs.webkit.org/show_bug.cgi?id=12763
REGRESSION: button title is displayed incorrectly at quotes.burntelectrons.org

Test: fast/parser/entities-in-attributes.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Set a correct type for the found entity (I'm not really sure if XML_INTERNAL_GENERAL_ENTITY is _the_ correct one, but it fixes the problem).
20:10 Changeset [22939] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

Switch permanently from CFStreamError to CFErrorRef in ResourceHandleCF

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::start):
19:11 Changeset [19618] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • fast/dom/Window/window-properties-expected.txt: Update results.
18:05 Changeset [19617] by darin
  • 10 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed some bogus names (Hyatt smacked me since this doesn't fix a P1)
  • dom/EventNames.h: Removed half-implemented khtmlDragdrop and khtmlMove (you could add listeners, but nobody ever sent the events). Renamed the other two khtml-prefixed internal event names to use the webkit prefix.
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): Removed ondragdrop and onmove. (KJS::DOMEventTargetNode::putValueProperty): Ditto.
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::put): Ditto.
  • bindings/js/kjs_window.h:
  • dom/BeforeTextInsertedEvent.cpp: (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent): Renamed to webkit.
  • editing/Editor.cpp: (WebCore::dispatchEditableContentChangedEvents): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Ditto.
17:39 Changeset [19616] by darin
  • 2 edits in trunk/WebCore

Rubber stamped by Maciej.

  • dom/EventNames.h: Resort names. Removed unused names.
17:24 Changeset [22938] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

17:23 Changeset [19615] by sfalken
  • 1 copy in tags/Safari-521.34.4b

New tag.

14:57 Changeset [19614] by oliver
  • 2 edits in trunk/WebKit

2007-02-13 Oliver Hunt <oliver@apple.com>

Reviewed by John.

Modify entry point ASSERTs for dragging functions to allow for the case
where a load has occurred mid-drag. The load may detach the HTMLView
from the WebView so it is no longer possible to check _isTopHTMLView.

The assertion changes match that of revision 14897 which fixed the
more common case ([WebHTMLView draggedImage:endedAt:operation:])

It's also necessary to check for a null Page now prior to accessing
the DragController, which is necessary in all of these methods.

See rdar://problem/4994870


  • WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
14:44 Changeset [22937] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Remove SVGDOMImplementation.(cpp|h)
14:19 Changeset [19613] by beidson
  • 2 edits in trunk/JavaScriptCore

Tweaked Vector a bit

13:47 Changeset [19612] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

  • http/tests/misc/redirect-to-about-blank-expected.txt: Added.
  • http/tests/misc/redirect-to-about-blank.html: Added.
  • http/tests/misc/resources/redirect-to-about-blank.php: Added.

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

The problem is that redirecting to about:blank causes the delegate to be released even though the load wasn't finished.
This is usally not a problem since NSURLConnection retains its delegate. However, the proxy delegate does not retain _it's_
delegate. The solution is to make releaseDelegate clear out the proxy delegate's delegate.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::releaseDelegate): If there's a proxy, nil out its delegate too.
13:28 Changeset [19611] by brmorris
  • 5 edits in S60/branches/3.1m/WebCore

bujtas, reviewed by yongjun

DESC: merging trunk r16319 to s60/3.1m PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. http://bugs.webkit.org/show_bug.cgi?id=3898

http://bugs.webkit.org/show_bug.cgi?id=12748

13:11 Changeset [19610] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Correcting ChangeLog entry (thx Mitz!).

13:06 Changeset [19609] by ap
  • 1 edit
    4 deletes in trunk/LayoutTests

Actually removed pixel results that were supposed to be removed three
weeks ago, in r12290.

  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.
  • fast/parser/head-comment-expected.png: Removed.
11:31 Changeset [19608] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Use kCFStringEncodingUTF8.
11:23 Changeset [19607] by beidson
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by The Spirit of Layout Test Fixing!

Re-added a directory and some files Darin removed that one of my layout tests
relied on.

  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added.
10:32 Changeset [19606] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/Vector.h: fixed comparison operators (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Darin.

  • rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion. The only reason this compiled before was that the comparing two vectors with a != was simply comparing the pointers.
10:16 Changeset [19605] by darin
  • 519 edits
    1 delete in trunk/LayoutTests
  • update test results for Hyatt's focus node enhancement (fix for 12149) 518 of tests had extra "begin editing" delegate callbacks.
  • editing: Updated test results of many tests in this directory.
  • removed tests for rolled-out fix for rdar://problem/4922454
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Removed.
  • http/tests/security/local-JavaScript-from-remote.html: Removed.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Removed.
  • http/tests/security/local-iFrame-from-remote.html: Removed.
  • http/tests/security/local-image-from-remote-expected.txt: Removed.
  • http/tests/security/local-image-from-remote.html: Removed.
  • http/tests/security/resources/compass.jpg: Removed.
  • http/tests/security/resources/green250x50.png: Removed.
  • http/tests/security/resources/localPage.html: Removed.
  • http/tests/security/resources/localScript.js: Removed.
  • http/tests/security/resources/red200x100.png: Removed.
  • http/tests/security/resources/showRefererImage.php: Removed.
10:11 Changeset [19604] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix wording of a change log comment.

09:58 Changeset [19603] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fix a bug where --reset-results output would all go in one giant line.
09:52 Changeset [19602] by darin
  • 2 edits in trunk/WebCore
  • roll out fix for <rdar://problem/4874059> REGRESSION: Painter IX:register -
Crash in WebCore
ResourceLoader::willSendRequest()

This fix was causing a crash in at least one layout test.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
05:09 Changeset [19601] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/lists/item-not-in-list-line-wrapping-expected.checksum: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.png: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/lists/item-not-in-list-line-wrapping.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Use the list marker's isInside() instead of looking at its style()->listStylePosition(), since if the list item is not in a list, the marker is inside regardless of the style.
03:02 Changeset [19600] by rwlbuis
  • 13 edits in trunk

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12578
WebKit incorrectly strokes zero-width/height rectangles

Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.

02:05 Changeset [19599] by rwlbuis
  • 3 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove SVGDOMImplementation from the project.

01:52 Changeset [19598] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.


  • fixed to still be a valid test (wouldn't crash without the relevant fix).
  • fast/text/text-shadow-extreme-value.html:
00:59 Changeset [19597] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Adam

Fixes <rdar://problem/4985497> - Crash when opening a new window to "Same Page"

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null check documentLoader() since if we're a brand new WebView, cloning the history of another view, we have no documentLoader()
00:55 Changeset [19596] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

-fix REGRESSION: <select disabled size="5"> listbox cannot be scrolled
http://bugs.webkit.org/show_bug.cgi?id=11852
<rdar://problem/4960129>


Pass mouse press events to scrollbars even if event is swallowed.


No layout test, DumpRenderTree eventSender can't hit scrollbars.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):
Note: See TracTimeline for information about the timeline view.