Timeline


and

02/26/07:

23:54 Changeset [23002] by oliver

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

To stop the drag image for transparent images from looking
ugly (especially fully transparent images) we render the
image to a white background prior to passing the image on to
Windows


<rdar://problem/5015946>

  • platform/win/DragImageWin.cpp: (WebCore::createDragImageFromImage):
23:19 Changeset [19878] by mjs

LayoutTests:

Reviewed by Oliver.

  • svg/custom/circular-marker-reference-1-expected.checksum: Added.
  • svg/custom/circular-marker-reference-1-expected.png: Added.
  • svg/custom/circular-marker-reference-1-expected.txt: Added.
  • svg/custom/circular-marker-reference-1.svg: Added.
  • svg/custom/circular-marker-reference-2-expected.checksum: Added.
  • svg/custom/circular-marker-reference-2-expected.png: Added.
  • svg/custom/circular-marker-reference-2-expected.txt: Added.
  • svg/custom/circular-marker-reference-2.svg: Added.
  • svg/custom/circular-marker-reference-3-expected.checksum: Added.
  • svg/custom/circular-marker-reference-3-expected.png: Added.
  • svg/custom/circular-marker-reference-3-expected.txt: Added.
  • svg/custom/circular-marker-reference-3.svg: Added.
  • svg/custom/circular-marker-reference-4-expected.checksum: Added.
  • svg/custom/circular-marker-reference-4-expected.png: Added.
  • svg/custom/circular-marker-reference-4-expected.txt: Added.
  • svg/custom/circular-marker-reference-4.svg: Added.
  • svg/custom/non-circular-marker-reference-expected.checksum: Added.
  • svg/custom/non-circular-marker-reference-expected.png: Added.
  • svg/custom/non-circular-marker-reference-expected.txt: Added.
  • svg/custom/non-circular-marker-reference.svg: Added.

WebCore:

Reviewed by Oliver.

  • platform/graphics/svg/SVGResourceMarker.cpp: (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against reference cycles.
21:30 Changeset [19877] by mjs

WebCore:

Reviewed by Kevin McCullough.

  • fix Qt build for earlier SVG changes.
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

WebKitQt:

Reviewed by Kevin McCullough.

  • fix Qt build for earlier SVG changes.
  • WebCoreSupport/EditCommandQt.cpp:
21:23 Changeset [19876] by oliver

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fix for <rdar://problem/4827378>: Canvas with large height
uses lots of memory, computer almost stops responding


Put cap on maximum area of canvas, size is similar too the
maximum size allowed by firefox (firefox seems to to cut off
at area == 32767 * 9358).

Also protect renderer against the possibility of a null context
(this was triggering a CG warning)

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext):

Apply maximum canvas area

(WebCore::HTMLCanvasElement::createPlatformImage):

Protect against null CG Context

21:13 Changeset [19875] by bdash

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

Test: fast/lists/list-style-type-dynamic-change.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger updating of the marker.

2007-02-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Antti Koivisto.

  • fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
  • fast/lists/list-style-type-dynamic-change-expected.png: Added.
  • fast/lists/list-style-type-dynamic-change-expected.txt: Added.
  • fast/lists/list-style-type-dynamic-change.html: Added.
20:04 Changeset [19874] by mjs

Reviewed by Lars.


  • set ENABLE_XSLT even when compiling without SVG support, since that is no longer hardcoded into config.h.
  • Scripts/build-webkit:
17:56 Changeset [19873] by kjk

JavaScriptCore:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

  • jscore.bkl:

WebKitTools:

Reviewed by Adam Roben.

Rename *_SUPPORT defines to ENABLE_*.

  • GdkLauncher/gdklauncher.bkl:
17:36 Changeset [19872] by adele

LayoutTests:

Reviewed by Maciej.

Test for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

  • fast/events/submit-reset-nested-bubble-expected.txt: Added.
  • fast/events/submit-reset-nested-bubble.html: Added.

WebCore:

Reviewed by Maciej.

Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

Test: fast/events/submit-reset-nested-bubble.html

  • dom/EventTargetNode.h: Made handleLocalEvents virtual.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're not in the capture phase, and the target is a different form, and we're handling the submitEvent or the resetEvent, then stop propagation of the event. This matches Firefox behavior. You can only get in this situation if misnested tags cause forms to be nested.
  • html/HTMLFormElement.h: Added handleLocalEvents.
17:32 Changeset [19871] by darin

Reviewed by Oliver Hunt.

  • <rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should
  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter): Added a call to ucnv_setFallback(TRUE).
17:16 Changeset [19870] by oliver

2007-02-26 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for rdar://problem/5021127

Need to add null check to node -- original Obj-C didn't need
the null check due to the Obj-C null messaging semantics

  • editing/Editor.cpp: (WebCore::Editor::shouldInsertFragment):

Layout tests:

Layout test for rdar://problem/5021127

  • fast/events/standalone-image-drag-to-editable-expected.checksum: Added.
  • fast/events/standalone-image-drag-to-editable-expected.png: Added.
  • fast/events/standalone-image-drag-to-editable-expected.txt: Added.
  • fast/events/standalone-image-drag-to-editable.html: Added.
16:39 Changeset [23001] by aroben

WebCoreWin:

Reviewed by Adele.

  • platform/win/GraphicsContextWin.cpp: Get rid of so-five-hours-ago SVG_SUPPORT.

WebKitWin:

Reviewed by Adele.

Stop bizarre crashes from happening on startup.

  • WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
16:33 Changeset [19869] by sullivan

Reviewed by Darin and Geoff

  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): This method was copied from WebBrowser, and it was wrong. Fixed it. This only affects the Dictionary pop-up panel.
16:09 Changeset [19868] by hyatt

Make text files render using white-space: pre-wrap instead of white-space: pre.


Reviewed by aroben

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::write):
15:53 Changeset [23000] by hyatt

Fix Boomer.

15:24 Changeset [19867] by hyatt

Update expected results for overflow test.

15:22 Changeset [19866] by hyatt

Back out the change to add fullyClippedContentRect. The layout test
was actually showing more correct results.

  • page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
15:14 Changeset [22999] by aroben

Build fix.

  • config.h: Remove redundant #define.
  • WebCore.vcproj/WebCore.vcproj: Update to new macros.
14:55 Changeset [19865] by hyatt

Update web inspector to account for border-fit.

Reviewed by darin

14:43 Changeset [19864] by ggaren

Reviewed by Darin Adler.


Re-arranged things to put deprecated methods at the bottom.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
  • WebKit.xcodeproj/project.pbxproj:
14:42 Changeset [19863] by hyatt

Land layout test demonstrating border-fit.

Reviewed by darin

  • fast/borders/border-fit-expected.checksum: Added.
  • fast/borders/border-fit-expected.png: Added.
  • fast/borders/border-fit-expected.txt: Added.
  • fast/borders/border-fit.html: Added.
  • fast/borders/resources/Balloon_12641896.tiff: Added.
  • fast/borders/resources/Balloon_8107502.tiff: Added.
  • fast/borders/resources/largePerson.png: Added.
14:40 Changeset [22998] by aroben

Rubberstamped by Ada.

  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Make #if match the header file.
14:36 Changeset [19862] by hyatt

Add support for a new property called -webkit-border-fit. This property
has two values: border and lines. The "border" value means the border and
background paint normally at the border box level. The "lines" value indicates
that the border and background should shrink dynamically to snugly hug the
line boxes of normal flow descendants.

Reviewed by darin

fast/borders/border-fit.html

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustForBorderFit): (WebCore::RenderBlock::borderFitAdjust):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/RenderBox.h: (WebCore::RenderBox::borderFitAdjust):
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::borderFit): (WebCore::RenderStyle::setBorderFit): (WebCore::RenderStyle::initialBorderFit):
14:33 Changeset [22997] by aroben

Reviewed by Darin.

Build fix.

  • WebCore.vcproj/build-generated-files.sh: Updated FEATURE_DEFINES.
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: Use shiny new ENABLE(SVG).
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: Ditto.
14:32 Changeset [19861] by mjs

Rubber stamped by Mitz.


  • fix layout tests by fixing discrepancy in feature macros.
  • WebInspector/WebInspector.m: (-_highlightNode:):
  • WebKit.xcodeproj/project.pbxproj:
14:30 Changeset [19860] by aroben

Reviewed by Darin.

Build fix.

  • rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.
13:49 Changeset [19859] by adele

LayoutTests:

Reviewed by Adam.

Test for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

  • fast/forms/select-out-of-bounds-index-expected.txt: Added.
  • fast/forms/select-out-of-bounds-index.html: Added.

WebCore:

Reviewed by Adam.

Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

Test: fast/forms/select-out-of-bounds-index.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1. (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable. Rewrote using a simpler for-loop to prevent out-of-bounds errors.
13:11 Changeset [19858] by andersca

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.
12:49 Changeset [19857] by brmorris

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
​http://bugs.webkit.org/show_bug.cgi?id=12831

12:49 Changeset [19856] by brmorris

vbradley, reviewed by Zalan

DESC: [S60] MLIO-6YCACU: Browser freeze and panic in symbianoggplay.sourceforge.com
​http://bugs.webkit.org/show_bug.cgi?id=12831

11:29 Changeset [19855] by mjs

JavaScriptCore:

Reviewed by Lars.


  • <rdar://problem/5021698> Disable experimental SVG features (12883)
  • wtf/Platform.h: Add ENABLE() macro similar to HAVE() and USE(), to allow nicer handling of optional WebKit features.

WebCore:

Reviewed by Lars.

  • fixed <rdar://problem/5021698> Disable experimental SVG features (12883)


I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
features, and used it to guard relevant tag names, elements, JS bindings and renderers.


I also converted all the existing optional feature defines to
ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
way to do it in open source projects and works with the handy new
ENABLE() macro.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.pro:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSSVGElementWrapperFactory.cpp:
  • bindings/js/JSSVGElementWrapperFactory.h:
  • bindings/js/JSSVGMatrixCustom.cpp:
  • bindings/js/JSSVGPODTypeWrapper.h:
  • bindings/js/JSSVGPathSegCustom.cpp:
  • bindings/js/JSSVGPathSegListCustom.cpp:
  • bindings/js/JSSVGPointListCustom.cpp:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.cpp: (KJS::setDOMException):
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_dom.cpp: (KJS::toJS):
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction):
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_proxy.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): (+[DOMNode _nodeWith:WebCore::]):
  • bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
  • bindings/objc/DOMCustomXPathNSResolver.h:
  • bindings/objc/DOMCustomXPathNSResolver.mm:
  • bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMSVGPathSegInternal.mm:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException):
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • config.h:
  • css/CSSGrammar.y:
  • css/CSSStyleDeclaration.cpp: (WebCore::propertyID):
  • css/StyleBase.h:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • css/cssstyleselector.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::hasFeature): (WebCore::DOMImplementation::createDocument):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createElement): (WebCore::Document::implicitClose): (WebCore::Document::recalcStyleSelector): (WebCore::Document::createEvent):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/Event.cpp:
  • dom/Event.h:
  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/MappedAttributeEntry.h: (WebCore::):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::shadowAncestorNode):
  • dom/Node.h:
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setCSSStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/Text.cpp: (WebCore::Text::createRenderer):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::endElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::end): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLObjectElement.h:
  • ksvg2/css/SVGCSSParser.cpp:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/events/JSSVGLazyEventListener.cpp:
  • ksvg2/events/JSSVGLazyEventListener.h:
  • ksvg2/events/SVGZoomEvent.cpp:
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/PointerEventsHitRules.cpp:
  • ksvg2/misc/PointerEventsHitRules.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/misc/SVGTimer.cpp:
  • ksvg2/misc/SVGTimer.h:
  • ksvg2/misc/TimeScheduler.cpp:
  • ksvg2/misc/TimeScheduler.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/ColorDistance.cpp:
  • ksvg2/svg/ColorDistance.h:
  • ksvg2/svg/GradientAttributes.h:
  • ksvg2/svg/LinearGradientAttributes.h:
  • ksvg2/svg/PatternAttributes.h:
  • ksvg2/svg/RadialGradientAttributes.h:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.cpp:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.cpp:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateElement.idl:
  • ksvg2/svg/SVGAnimateMotionElement.cpp:
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.idl:
  • ksvg2/svg/SVGAnimatedPathData.cpp:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.cpp:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.cpp:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.cpp:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::dispatchEvent):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstance.cpp:
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstance.idl:
  • ksvg2/svg/SVGElementInstanceList.cpp:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGElementInstanceList.idl:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGException.h:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEBlendElement.idl:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFECompositeElement.idl:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.idl:
  • ksvg2/svg/SVGFEDistantLightElement.cpp:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.idl:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFloodElement.idl:
  • ksvg2/svg/SVGFEFuncAElement.cpp:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncAElement.idl:
  • ksvg2/svg/SVGFEFuncBElement.cpp:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncBElement.idl:
  • ksvg2/svg/SVGFEFuncGElement.cpp:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncGElement.idl:
  • ksvg2/svg/SVGFEFuncRElement.cpp:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEFuncRElement.idl:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFEImageElement.idl:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeElement.idl:
  • ksvg2/svg/SVGFEMergeNodeElement.cpp:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEOffsetElement.idl:
  • ksvg2/svg/SVGFEPointLightElement.cpp:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFEPointLightElement.idl:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.idl:
  • ksvg2/svg/SVGFESpotLightElement.cpp:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFESpotLightElement.idl:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETileElement.idl:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.idl:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterElement.idl:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGForeignObjectElement.idl:
  • ksvg2/svg/SVGGElement.cpp:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGListTraits.h:
  • ksvg2/svg/SVGLocatable.cpp: (WebCore::SVGLocatable::nearestViewportElement): (WebCore::SVGLocatable::farthestViewportElement):
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMPathElement.cpp:
  • ksvg2/svg/SVGMPathElement.h:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMetadataElement.cpp:
  • ksvg2/svg/SVGMetadataElement.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.cpp:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGParserUtilities.cpp:
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.cpp:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.cpp:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.cpp:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.cpp:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.cpp:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.cpp:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.cpp:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.cpp:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGRenderingIntent.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.cpp:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.cpp:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.cpp:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::notifyAttributeChange):
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.cpp:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.cpp:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.cpp:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.cpp:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.cpp:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.cpp:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformDistance.cpp:
  • ksvg2/svg/SVGTransformDistance.h:
  • ksvg2/svg/SVGTransformList.cpp:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUnitTypes.h:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGUseElement.idl:
  • ksvg2/svg/SVGViewElement.cpp:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.cpp:
  • ksvg2/svg/SVGZoomAndPan.h:
  • ksvg2/svg/svgtags.in:
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/DOMWindow.idl:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::selectCursor):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedNonImageMimeTypes):
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/ImageBuffer.cpp: (WebCore::ImageBuffer::renderSubtreeToImage):
  • platform/graphics/svg/SVGImage.cpp:
  • platform/graphics/svg/SVGImage.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:
  • platform/graphics/svg/SVGPaintServer.cpp:
  • platform/graphics/svg/SVGPaintServer.h:
  • platform/graphics/svg/SVGPaintServerGradient.cpp:
  • platform/graphics/svg/SVGPaintServerGradient.h:
  • platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
  • platform/graphics/svg/SVGPaintServerLinearGradient.h:
  • platform/graphics/svg/SVGPaintServerPattern.cpp:
  • platform/graphics/svg/SVGPaintServerPattern.h:
  • platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
  • platform/graphics/svg/SVGPaintServerRadialGradient.h:
  • platform/graphics/svg/SVGPaintServerSolid.cpp:
  • platform/graphics/svg/SVGPaintServerSolid.h:
  • platform/graphics/svg/SVGResource.cpp:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceFilter.cpp:
  • platform/graphics/svg/SVGResourceFilter.h:
  • platform/graphics/svg/SVGResourceMarker.cpp:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.cpp:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/CgSupport.cpp:
  • platform/graphics/svg/cg/CgSupport.h:
  • platform/graphics/svg/cg/RenderPathCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
  • platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
  • platform/graphics/svg/cg/SVGResourceFilterCg.mm:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
  • platform/graphics/svg/filters/SVGDistantLightSource.h:
  • platform/graphics/svg/filters/SVGFEBlend.cpp:
  • platform/graphics/svg/filters/SVGFEBlend.h:
  • platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEColorMatrix.h:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
  • platform/graphics/svg/filters/SVGFEComponentTransfer.h:
  • platform/graphics/svg/filters/SVGFEComposite.cpp:
  • platform/graphics/svg/filters/SVGFEComposite.h:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
  • platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
  • platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
  • platform/graphics/svg/filters/SVGFEDisplacementMap.h:
  • platform/graphics/svg/filters/SVGFEFlood.cpp:
  • platform/graphics/svg/filters/SVGFEFlood.h:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
  • platform/graphics/svg/filters/SVGFEGaussianBlur.h:
  • platform/graphics/svg/filters/SVGFEImage.cpp:
  • platform/graphics/svg/filters/SVGFEImage.h:
  • platform/graphics/svg/filters/SVGFEMerge.cpp:
  • platform/graphics/svg/filters/SVGFEMerge.h:
  • platform/graphics/svg/filters/SVGFEMorphology.cpp:
  • platform/graphics/svg/filters/SVGFEMorphology.h:
  • platform/graphics/svg/filters/SVGFEOffset.cpp:
  • platform/graphics/svg/filters/SVGFEOffset.h:
  • platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
  • platform/graphics/svg/filters/SVGFESpecularLighting.h:
  • platform/graphics/svg/filters/SVGFETile.h:
  • platform/graphics/svg/filters/SVGFETurbulence.cpp:
  • platform/graphics/svg/filters/SVGFETurbulence.h:
  • platform/graphics/svg/filters/SVGFilterEffect.cpp:
  • platform/graphics/svg/filters/SVGFilterEffect.h:
  • platform/graphics/svg/filters/SVGLightSource.cpp:
  • platform/graphics/svg/filters/SVGLightSource.h:
  • platform/graphics/svg/filters/SVGPointLightSource.h:
  • platform/graphics/svg/filters/SVGSpotLightSource.h:
  • platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
  • platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
  • platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
  • platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
  • platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
  • platform/graphics/svg/filters/cg/SVGFETileCg.mm:
  • platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
  • platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
  • platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink):
  • rendering/RenderForeignObject.cpp:
  • rendering/RenderForeignObject.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparent):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock):
  • rendering/RenderObject.h:
  • rendering/RenderPath.cpp:
  • rendering/RenderPath.h:
  • rendering/RenderSVGBlock.cpp:
  • rendering/RenderSVGBlock.h:
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
  • rendering/RenderSVGGradientStop.cpp:
  • rendering/RenderSVGGradientStop.h:
  • rendering/RenderSVGHiddenContainer.cpp:
  • rendering/RenderSVGHiddenContainer.h:
  • rendering/RenderSVGImage.cpp:
  • rendering/RenderSVGImage.h:
  • rendering/RenderSVGInline.cpp:
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGInlineText.cpp:
  • rendering/RenderSVGInlineText.h:
  • rendering/RenderSVGTSpan.cpp:
  • rendering/RenderSVGTSpan.h:
  • rendering/RenderSVGText.cpp:
  • rendering/RenderSVGText.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::RenderStyle::RenderStyle): (WebCore::RenderStyle::inheritFrom): (WebCore::RenderStyle::operator==): (WebCore::RenderStyle::inheritedNotEqual): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): (WebCore::RenderText::setTextInternal):
  • rendering/RenderTreeAsText.cpp: (WebCore::write): (WebCore::externalRepresentation):
  • rendering/SVGInlineFlowBox.cpp:
  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRenderTreeAsText.cpp:
  • rendering/SVGRenderTreeAsText.h:
  • rendering/SVGRootInlineBox.cpp:
  • rendering/SVGRootInlineBox.h:
  • rendering/bidi.cpp: (WebCore::shouldPreserveNewline): (WebCore::RenderBlock::findNextLineBreak):
  • webcore-base.bkl:
  • xml/NativeXPathNSResolver.cpp:
  • xml/NativeXPathNSResolver.h:
  • xml/XPathEvaluator.cpp:
  • xml/XPathEvaluator.h:
  • xml/XPathExpression.cpp:
  • xml/XPathExpression.h:
  • xml/XPathExpressionNode.cpp:
  • xml/XPathExpressionNode.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathFunctions.h:
  • xml/XPathGrammar.y:
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h:
  • xml/XPathNamespace.cpp:
  • xml/XPathNamespace.h:
  • xml/XPathParser.cpp:
  • xml/XPathParser.h:
  • xml/XPathPath.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp:
  • xml/XPathPredicate.h:
  • xml/XPathResult.cpp:
  • xml/XPathResult.h:
  • xml/XPathStep.cpp:
  • xml/XPathStep.h:
  • xml/XPathUtil.cpp:
  • xml/XPathUtil.h:
  • xml/XPathValue.cpp:
  • xml/XPathValue.h:
  • xml/XPathVariableReference.cpp:
  • xml/XPathVariableReference.h:
  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessor.h:
11:18 Changeset [19854] by brmorris

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

11:16 Changeset [19853] by brmorris

spadma, reviewed by Yongjun

DESC: Urls are doubly encoded HIIN-6YMGYV

02/25/07:

21:31 Changeset [19852] by bdash

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

Test: fast/dynamic/float-withdrawal.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25 Mitz Pettel <​mitz@webkit.org>

Reviewed by David Hyatt.

  • fast/dynamic/float-withdrawal-expected.checksum: Added.
  • fast/dynamic/float-withdrawal-expected.png: Added.
  • fast/dynamic/float-withdrawal-expected.txt: Added.
  • fast/dynamic/float-withdrawal.html: Added.
19:00 Changeset [19851] by hyatt

Revert my change to the default fill color. Just set the color to transparent explicitly when
drawing textarea resizer frames.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintOverflowControls):
18:28 Changeset [19850] by weinig

Update forgotten files.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
18:07 Changeset [19849] by hyatt

Forgot to land FrameView.cpp in previous commit.

17:29 Changeset [19848] by hyatt

Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
to be the initial containing block (represented in our tree by the RenderView). Rework RenderView's layout
to have very few special cases. Now it will just relayout its children when the width/height of the
view actually changes. Positioned elements no longer get a special additional layout, since width/height
adjustments are caught by the base class already anyway.

Reviewed by mjs, darin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutVerticalBox):
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::layout):
  • rendering/RenderView.h:
16:47 Changeset [22996] by mjs

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrolView::fullyClippedContentRect):
16:41 Changeset [19847] by mjs

Not reviewed, build fix.

  • fix build breakage
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::fullyClippedContentRect):
15:44 Changeset [19846] by mjs

Reviewed by Adam.

  • fixed layout test failure in fast/overflow/scrollRevealButton


I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
as clipped by all ancestor scroll views, not just this one. Currently it only works
correctly on mac however. visibleContentRect, only accounting for the clipping from
this particular scroll view, is sufficient for most purposes.

  • page/Frame.cpp: (WebCore::Frame::visibleSelectionRect): (WebCore::Frame::setIsActive): (WebCore::Frame::markAllMatchesForText):
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::fullyClippedContentRect):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrolView::fullyClippedContentRect):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
14:23 Changeset [19845] by andersca

Reviewed by Maciej.

  • building/checkout.html: Add Trac link to our SVN repository,

02/24/07:

23:20 Changeset [22995] by aroben

Change #if to #ifdef to match style.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show):
23:14 Changeset [22994] by aroben

Reviewed by Steve.

Fix <rdar://problem/5013502> REGRESSION: <select> menus are not
animating smoothly

This was caused by making the menus partially transparent in r12250.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Disable animations.
23:12 Changeset [19844] by aroben

Reviewed by Steve.

"Look Up in Dictionary" context menu item should be Mac-only for now,
since it's only implemented on that platform (<rdar://problem/5021468>)

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Wrap all instances of the dictionary menu item in #if PLATFORM(MAC).
20:35 Changeset [22993] by sfalken

2007-02-24 Steve Falkenburg <​sfalken@apple.com>

Pre-emptive build fix.
Removed CGPThreads DLL copy

  • WebKit.vcproj/WebKit.vcproj:
18:14 Changeset [19843] by ggaren

LayoutTests:

Reviewed by Darin Adler.


Layout tests for BidiRun leaks.


  • fast/leaks/001-expected.txt: Added.
  • fast/leaks/001.html: Added.
  • fast/leaks/002-expected.txt: Added.
  • fast/leaks/002.html: Added.

WebCore:

Reviewed by Darin Adler.


Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
running WebKit unit tests


In bidi.cpp, some functions allocate BidiRuns and put them in a global data
structure, while others uses the BidiRuns in the global data structure.
The caller is responsible for knowing which functions may allocate runs
and which may use them, and calling deleteBidiRuns() at the appropriate time.

The fix is to add some calls to deleteBidiRuns() where they were missing.


I also added a BidiRun counter because these two leaks were introduced by
our two bidi.cpp experts, so the odds that leaks will creep in again
in the future seem pretty high.

  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added missing call to deleteBidiRuns(). (WebCore::BidiRunCounter::~BidiRunCounter): (WebCore::BidiRun::operator delete): (WebCore::RenderBlock::layoutInlineChildren): Added missing call to deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to bidiReorderLine(), to emphasize that they go together like new/delete. In theory, the old code was just as good, but I didn't want to rely on theory.

WebKitTools:

Reviewed by Darin Adler.


  • Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're fixed.
06:35 Changeset [19842] by harrison

Reviewed by Kevin.

<rdar://problem/4961431> Image with empty string alt tag should be ignored

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Ignore img element that has an alt attribute, but that string is empty.
05:14 Changeset [19841] by zack

Adjust the animation a little bit to make it more natural.

03:14 Changeset [19840] by ap

Reviewed by Anders.

Fix the test not to include any custom content in its auto-generated HTML wrapper.

  • fast/js/resources/select-options-add.js:
  • fast/js/select-options-add-expected.txt:
  • fast/js/select-options-add.html:
00:45 Changeset [19839] by kjk

WebCore:

Reviewed by Adam Roben.

Gdk improvements.

  • platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup. (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent): (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::dragImageForSelection):
  • platform/network/gdk/ResourceHandleManager.cpp: don't free memory that doesn't belong to us. (WebCore::ResourceHandleManager::downloadTimerCallback):

WebKitTools:

Reviewed by Adam Roben.

Improve gdklauncher: add text field for entering url.

  • GdkLauncher/gdklauncher.bkl:
  • GdkLauncher/main.cpp: (strEmpty): (strEq): (handleGdkEvent): (goToUrlBarText): (goButtonClickedCb): (urlBarEnterCb): (registerRenderingAreaEvents): (frameResizeCb): (frameDestroyCb): (main):

02/23/07:

23:42 Changeset [19838] by kdecker

Reviewed by Anders.

Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)


There were two problems here:


  • page/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said "if there is no text encoding name than assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
  • platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.
20:35 Changeset [22992] by andersca

Reviewed by Adam.

<rdar://problem/4516049>
Basic Infrastructure: Get regression tests running.


Make boomer-run-webkit-tests work with our internal setup.


  • Scripts/boomer-run-webkit-tests:
18:55 Changeset [19837] by weinig

LayoutTests:

Reviewed by Maciej.

  • editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

Reviewed by Maciej.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted is empty, first delete the selection, and only then bail out.
18:52 Changeset [19836] by andersca

Reviewed by Adam.

<rdar://problem/5001923>
REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

Fix an error that was introduced in revision r18541. We should check if the provisional document loader
has an unreachable URL, not the actual document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForCommit):
18:35 Changeset [19835] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/events/selectstart-during-autoscroll-expected.txt: Added.
  • fast/events/selectstart-during-autoscroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/selectstart-during-autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Invoke the renderer's shouldSelect() -- which dispatches the selection DOM event and gives it a chance to cancel the selection -- before updating the selection during autoscroll.
18:22 Changeset [19834] by weinig

Reviewed by Maciej.

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController endRevertingChange:moveLeft:]):
18:21 Changeset [22991] by andersca

Reviewed by Adam.

<rdar://problem/4761543>
nike.com doesn't finish loading if Flash plugin is installed.


If a plugin requests a JavaScript URL with a non null frame target, execute the JavaScript expression. If the result
is not "undefined", replace the contents of the frame with the result converted to a string.

  • plugins/win/PluginViewWin.cpp: (WebCore::getString): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired):
17:25 Changeset [19833] by oliver

Correcting ChangeLog

17:22 Changeset [19832] by oliver

2007-02-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12870

It turns out short circuiting DragData::containsURL() was bad

  • ChangeLog:
  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/directory-drop-on-view.html: Added.
  • platform/mac/DragDataMac.mm: (WebCore::DragData::containsURL):
14:35 Changeset [19831] by brmorris

forrest, reviewed by sachin

DESC: re-insert ability to handle EDoNothing case for disposition of downloaded content SXUU-6XZ232

11:13 Changeset [19830] by thatcher

Reviewed by Brady.

<rdar://problem/5016395> _recursive_pauseNullEventsForAllNetscapePlugins still gone

  • WebView/WebFrameInternal.h: Remove _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFramePrivate.h: Add _recursive_pauseNullEventsForAllNetscapePlugins
  • WebView/WebFrame.mm: More _recursive_pauseNullEventsForAllNetscapePlugins
08:43 Changeset [19829] by mjs

Added missing bug numbers.

08:32 Changeset [19828] by mjs

Reviewed by Mitz.

  • 12.5% speedup on BenchJS test 6


It turns out that calling documentVisibleRect on an NSScrollView is pretty expensive,
and calling visibleRect even more so. Take measures to call them less often.

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): Use documentVisibleRect when possible. (WebCore::ScrollView::updateContents): Use visibleContentRect to be able to use documentVisibleRect when possible.
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Don't get or intersect with viewRect if we don't have a parent frame, since the ScrollView will do that anyway. Also, don't get contentX and contentY separately since they are in the viewRect already. (WebCore::RenderView::viewRect): Use visibleContentRect instead of getting each coordinate individually, to avoid calling documentVisibleRect repeatedly.
08:25 Changeset [19827] by mjs

Reviewed by Mitz.

  • 2% speedup on BenchJS test 6
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cssText): Use format() instead of number() followed by append of a constant string.
07:34 Changeset [19826] by staikos

add return values (!!)

07:26 Changeset [19825] by staikos

Fix the Qt build.

07:08 Changeset [19824] by zack

Adding a little bit of eye-candy to the last
commit (animations on hover events)

06:21 Changeset [19823] by zack

Adding API and code for notification of when the
mouse is hovering over a link and adding code to
the sample app to showcase it.
r=Lars

02/22/07:

22:54 Changeset [22990] by oliver

2007-02-22 Oliver Hunt <​oliver@apple.com>

rs = adam


Replacing radar numbers from previous patch with one
the isn't fictitious <rdar://problem/5018591>

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor):
22:48 Changeset [19822] by kjk

Reviewed by Adam Roben, who never sleeps.

To avoid code duplication, move notImplementedGdk() macro to a separate
header file. Remove existing notImplementedGdk() macros and replace
remaining notImplemented() to notImplementedGdk() in gdk code.

  • loader/gdk/DocumentLoaderGdk.cpp: (WebCore::DocumentLoader::getResponseModifiedHeader):
  • loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::hasWebView): (WebCore::FrameLoaderClientGdk::hasFrameView):
  • page/gdk/ContextMenuClientGdk.cpp: (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/EventHandlerGdk.cpp:
  • platform/gdk/CursorGdk.cpp: (WebCore::Cursor::Cursor):
  • platform/gdk/EditorClientGdk.cpp:
  • platform/gdk/NotImplementedGdk.h: Added.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/ScreenGdk.cpp: (WebCore::screenDepth): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::screenRect): (WebCore::screenAvailableRect):
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/gdk/ImageGdk.cpp: (WebCore::Image::drawPattern):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST):
22:30 Changeset [22989] by oliver

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Implemented a couple more cursor methods

  • platform/win/CursorWin.cpp: (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::verticalTextCursor): Added radar bug reference <rdar://problem/5018452> (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::notAllowedCursor): Making them return the correct cursor


20:32 Changeset [19821] by thatcher

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12852
Bug#12852: Drosera should select function name, not "function" keyword when selecting from function list pop-up

  • Drosera/debugger.js: Fixed some logic errors resulting in generating double IDs and names.
19:48 Changeset [19820] by weinig

LayoutTests:

Reviewed by Maciej.

  • fast/events/remove-event-listener-expected.txt: Added.
  • fast/events/remove-event-listener.html: Added.

WebCore:

Reviewed by Maciej.

and

Problem: RemoveEventListener leaks memory if the listener is not
registered.
Fix: Added Window::findJSEventListener function w/o creating a
JSEventListener; Renamed getJSEventListener to findOrCreateJSEventListener;

As an enhancement, added a leak counter for EventListeners.

Added a test case, LayoutTests/fast/events/remove-event-listener.html.

  • WebCore/bindings/js/kjs_dom.cpp:
  • WebCore/bindings/js/kjs_window.h:
  • WebCore/bindings/js/kjs_window.cpp:
  • WebCore/bindings/js/kjs_event.cpp: Add a leak counter.
  • WebCore/bindings/js/JSXMLHttpRequest.cpp:
  • LayoutTests/fast/events/remove-event-listener.html:
19:38 Changeset [19819] by andersca

Reviewed by Geoff.

<rdar://problem/4998203>
REGRESSION: Back-forward list gets messed up when navigating to error pages with back-forward cache turned off


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove call to setPolicyDocumentLoader(), the policy document loader is set immediately after, and setting it before calling shouldReloadToHandleUnreachableURL causes us to get the wrong URL.


(WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
Check if the unreachable URL is equal to the document loader's request.


(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
Check the provisional document loader's unreachable URL.

18:47 Changeset [22988] by oliver

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Anders.

Removing accessive COMPtr use from ClipboardWin constructors
Adding data verification to ClipoardWin::SetData
Small amount code tidying, and allowing for failure when writing an URL

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Updated for new ClipboardWin constructor
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::writeURL): (WebCore::ClipboardWin::getData): Tidying code, and allowing failure (WebCore::ClipboardWin::setData): Verifying that we're writing a valid url


  • platform/win/ClipboardWin.h:
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
17:13 Changeset [19818] by bdash

Versioning.

16:35 Changeset [19817] by bdash

Versioning.

16:32 Changeset [19816] by bdash

Merge in r19806.

2007-02-22 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
16:29 Changeset [19815] by bdash

Merge in r19805.

2007-02-22 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
16:26 Changeset [19814] by bdash

Merge in r19783.

2007-02-21 Brady Eidson <​beidson@apple.com>

Reviewed by Dave Harrison

<rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState()
after regaining network connection

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::restoreScrollPositionAndViewState): Leave an assertion for debug build exploration, but gracefully handle the release build case
16:21 Changeset [19813] by bdash

New tag.

16:12 Changeset [22987] by adele

Updating this file to match WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
16:03 Changeset [19812] by adele

Reviewed by John.

Updating this image to match the one in WebCore.

  • WebKit.vcproj/textAreaResizeCorner.png:
15:59 Changeset [22986] by bdakin

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView.cpp: (WebView::handleContextMenuEvent): Clear the controller's context menu before propagating a new context menu event through the DOM.
15:51 Changeset [19811] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

Added, tests the removal of the use of the
recalc bool from xPosForVerticalArrowNavigation(...):

  • editing/selection/5007143-2-expected.checksum: Added.
  • editing/selection/5007143-2-expected.png: Added.
  • editing/selection/5007143-2-expected.txt: Added.
  • editing/selection/5007143-2.html: Added. Added, demonstrate the changes to modify:
  • editing/selection/5007143-expected.checksum: Added.
  • editing/selection/5007143-expected.png: Added.
  • editing/selection/5007143-expected.txt: Added.
  • editing/selection/5007143.html: Added. Demonstrates a bug (filed 5017312):
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt: Fixed:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-011-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5007143>
REGRESSION: WebKit doesn't remember horizontal position of caret when moving forward by line

  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Initialize m_xPosForVerticalArrowNavigation. (WebCore::SelectionController::setSelection): Call the new setter. (WebCore::SelectionController::modifyMovingRightForward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. Use the x position of the *start*, not the end of the selection if there is no saved xPosForVerticalArrowNavigation. This matches TextEdit's behavior. (WebCore::SelectionController::modifyMovingLeftBackward): For line and paragraph granularities, use the saved xPosForVerticalArrowNavigation even if the old selection was a range. (WebCore::SelectionController::modify): Preserve the xPosForVerticalArrowNavigation for line and paragraph granularities. (WebCore::SelectionController::xPosForVerticalArrowNavigation): Removed the recalc bool because it is now always false. (WebCore::SelectionController::setXPosForVerticalArrowNavigation): Added.
  • editing/SelectionController.h: Moved m_xPosForVerticalArrowNavigation from Frame.
  • page/Frame.cpp: Moved m_xPosForVerticalArrowNavigation to SelectionController.
  • page/Frame.h: Ditto.
  • page/FramePrivate.h: Ditto.
15:49 Changeset [19810] by bdakin

WebCore:

Reviewed by Adam. Manual test added.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

This problem appeared because of two facets of the current context
menu design. First, all context menu events are now considered to
be "swallowed" since we take care of building up the regular
context menu through the defaultEventHandler(). Second, the context
menu controller holds onto it's context menu until a new one is
created. There would be logistical problems changing this since
AppKit relies on the menu being around for as long as it is
visible on the screen and we don't get any notification once the
menu is popped-down.

This patch fixes the problem by giving WebKit a way to clear the
controller's context menu. WebKit now clears the menu before it
propagates a new context menu event through the DOM.

  • WebCore.exp:
  • manual-tests/DOMContextMenuEvent.html: Added.
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::clearContextMenu):
  • page/ContextMenuController.h:

WebKit:

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION:
Unable to prevent default context menu from appearing. <rdar://
problem/5017416>

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Clear the controller's context menu before propagating a new context menu event through the DOM.
15:44 Changeset [22985] by oliver

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou, and Steve.

WebKit:

Last of the major changes for drag and drop

  • Move COMPtr.h to WebCore
  • Added WebDragSource, a modified version of SDataSource from the App that can notify a WebView's eventhandler of drag events
  • Implement the last bits of the DragClient
  • As part of drag client added code to draw the "doubled" text used by drag links. May be useful for other parts of WebKit/App


  • COMPtr.h: Removed. Moving to WebCore
  • WebDragClient.cpp: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::dragSourceActionMaskForPoint): (WebDragClient::willPerformDragSourceAction):
Removing WebCore
as i'm now using the WebCore namespace (WebDragClient::startDrag): Implemented client method (allocImage): (dragLabelFont): Helper functions for generating the link dragging image (WebDragClient::createDragImageForLink): Implemented client method
  • WebDropSource.cpp: Added. (WebDropSource::createInstance): (WebDropSource::WebDropSource): (WebDropSource::QueryInterface): (WebDropSource::AddRef): (WebDropSource::Release): (generateMouseEvent): Generates a mouse event for the EventHandler (WebDropSource::QueryContinueDrag): (WebDropSource::GiveFeedback): Copied from SDataObject in the App. Minor changes per suggestions from Ada and Steve (error codes, potential leaks) Also includes logic to notify the source WebView of drag events (moving and drag end)
  • WebDropSource.h: Added. Header for the above
  • WebKit.vcproj/WebKit.vcproj: Removing COMPtr.h, and adding WebDropSource.{h,cpp}
  • WebKitGraphics.cpp: (DrawDoubledTextAtPoint): Utility function for drawing double text, as used by link dragging image
This resolves <rdar://problem/4821407> Cannot drag link to bookmarks bar to create new link <rdar://problem/4869496> User Interaction Essentials: Drag
  • WebCore.vcproj/WebCore.vcproj: Adding new files


  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize): Maximum size of drag image to allow sharp edges is 208x208


  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Properly implemented now


  • platform/win/ClipboardWin.cpp: (WebCore::): (WebCore::clipboardTypeFromMIMEType): (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::~ClipboardWin): (WebCore::writeURL): Helper function to write a url to a WCDataObject (WebCore::ClipboardWin::clearData): (WebCore::ClipboardWin::clearAllData): (WebCore::ClipboardWin::getData): (WebCore::ClipboardWin::setData): (WebCore::addMimeTypesForFormat): Helper function for ClipboardWin::types (WebCore::ClipboardWin::types): (WebCore::ClipboardWin::setDragImage): (WebCore::ClipboardWin::setDragImageElement): General setters, match behaviour of WebKit/Mac (WebCore::ClipboardWin::createDragImage): Creates a drag image for a DOM specified Image is specified can't currently generate an image for an arbitrary element (WebCore::imageToMarkup): Wraps a url in an img tag (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Implement Clipboard required by DragController. Provides read/write DOM Clipboard implementation for dragging, read only when accessing system clipboard.


  • platform/win/ClipboardWin.h: (WebCore::ClipboardWin::dataObject): Provide an accessor for the dataObject


  • platform/win/DragDataWin.cpp: (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::getURL): (WebCore::DragData::asURL): (WebCore::getPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asFragment): Refactoring and removing of a few static modifiers to allow sharing with Clipboard


  • platform/win/DragImageWin.cpp: (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::allocImage): (WebCore::createCgContextFromBitmap): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Implement DragImage functions


  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Creating a Clipboard that wraps the system clipboard


  • platform/win/PasteboardWin.cpp: (WebCore::createGlobalData): (WebCore::markupToCF_HTML): (WebCore::urlToMarkup): (WebCore::replaceNBSP): removing 'static'


  • platform/win/WCDataObject.cpp: Added. (WebCore::WCEnumFormatEtc::WCEnumFormatEtc): (WebCore::WCEnumFormatEtc::QueryInterface): (WebCore::WCEnumFormatEtc::AddRef): (WebCore::WCEnumFormatEtc::Release): (WebCore::WCEnumFormatEtc::Next): (WebCore::WCEnumFormatEtc::Skip): (WebCore::WCEnumFormatEtc::Reset): (WebCore::WCEnumFormatEtc::Clone): (WebCore::WCDataObject::createInstance): (WebCore::WCDataObject::WCDataObject): (WebCore::WCDataObject::~WCDataObject): (WebCore::WCDataObject::QueryInterface): (WebCore::WCDataObject::AddRef): (WebCore::WCDataObject::Release): (WebCore::WCDataObject::GetData): (WebCore::WCDataObject::GetDataHere): (WebCore::WCDataObject::QueryGetData): (WebCore::WCDataObject::GetCanonicalFormatEtc): (WebCore::WCDataObject::SetData): (WebCore::WCDataObject::CopyMedium): (WebCore::WCDataObject::EnumFormatEtc): (WebCore::WCDataObject::DAdvise): (WebCore::WCDataObject::DUnadvise): (WebCore::WCDataObject::EnumDAdvise): (WebCore::WCDataObject::clearData): Copied from SDataObject in the App createInstance and clearData are the only new functions. clearData removes any entries in the object with a specified CLIPFORMAT. Have also made a few error and memory handling changes suggested by Steve and Ada
  • platform/win/WCDataObject.h: Added. Header for the above


15:42 Changeset [19809] by sullivan

Reviewed by Kevin and Adele


  • fixed <rdar://problem/4129417> Need final art for textarea's resize corner


This probably broke some layout pixel tests since the image changed. I'm going to
track those down in a moment (non-trivial since there are a bunch failing for other
reasons).

  • Resources/textAreaResizeCorner.tiff: new art
  • Resources/deleteButton.tiff:
  • Resources/deleteButtonPressed.tiff: these got smaller when I ran compress-tiffs on this directory
15:40 Changeset [19808] by oliver

2007-02-22 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada, Lou and Steve.

Moving basic components of ClipboardMac to Clipboard,
last of the basic common code merge will come later (namely setting the
drag element/image).


Tidying up in DragController including a few bad PassRefPtr uses and
removing unnecessary accessors. Also initialise fields properly to
fix <rdar:/problems/5014889>

  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard): New constructor


  • dom/Clipboard.h: (WebCore::Clipboard::isForDragging): (WebCore::Clipboard::dragLocation): (WebCore::Clipboard::dragImage): (WebCore::Clipboard::dragImageElement): Exposing common data


  • page/DragController.cpp: (WebCore::DragController::DragController): Initialise m_isHandlingDrag (oops) (WebCore::documentFragmentFromDragData): (WebCore::DragController::tryDocumentDrag): Fixing PassRefPtr misuse (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doSystemDrag): Make sure we're using the correct coordinate space


  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): Reset drag source correctly


  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): update constructor to use new Clipboard constructor
15:07 Changeset [22984] by aroben

Reviewed by Adele.

Make sure we always paint the right size search results icon.

15:02 Changeset [22983] by sfalken

Bump version for submit

15:00 Changeset [19807] by sfalken

New tag.

14:20 Changeset [19806] by adele

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • fast/events/keypress-insert-tab-expected.txt: Added.
  • fast/events/keypress-insert-tab.html: Added.

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body

Test: fast/events/keypress-insert-tab.html

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler): If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.

WebKitTools:

Reviewed by Darin.

Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body

  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setTabKeyCyclesThroughElements:]):
14:10 Changeset [19805] by ggaren

Reviewed by Darin Adler.


Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional
volumes..."


The problem was that JavaScriptGlue held a JSObject in a static pointer
without protecting it from garbage collection.


sUserObjectPrototypeImp = new UserObjectPrototypeImp();
static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; valiant, brave, but useless

Through an interesting comedy of errors, this object would be collected
and then assigned as the prototype of another object allocated at the
same address, thus becoming its own prototype. (See ​http://www.ziplo.com/grandpa.htm
for further explanation of this phenomenon.) Hence the infinte loop in
property lookup.


The solution is equally humorous: all of this code was completely useless --
it only served to create an empty object in the prototype chain -- so
I just removed it.

  • UserObjectImp.cpp: (UserObjectImp::UserObjectImp):
  • UserObjectImp.h:
13:55 Changeset [19804] by brmorris

naguo, reviewed by sachin

DESC: Open while downloading UI setting functionality is not working correctly SCHY-6YFQ66
​http://bugs.webkit.org/show_bug.cgi?id=12846

13:25 Changeset [19803] by brmorris

hongzhao, reviewed by Zalan, merged by mbradley++

DESC: merge of r19802 to s60 trunk. Cache memory collector is not initialized in 3.2 HZHO-6YMQCK
Fix: Initialize the initial size of cache memory collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

13:22 Changeset [19802] by brmorris

hongzhao, Reviewed by Zalan

DESC: [S60] Cache memory collector is not initialized in 3.1m HZHO-6YMQCK
Fix: Initialze the initial size of cache mem collector after create it.
​http://bugs.webkit.org/show_bug.cgi?id=12844

13:16 Changeset [19801] by brmorris

sareen by yongjun

DESC: Merge of r19655 to s60/3.1m. Selection list not shown correctly in www.elisa.fi HMNN-6XQJMX
​http://bugs.webkit.org/show_bug.cgi?id=12719

13:00 Changeset [19800] by thatcher

Reviewed by Darin.

<rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard

  • bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
  • bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
  • dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
  • html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
  • html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
12:50 Changeset [19799] by adele

Reviewed by John.

Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
12:19 Changeset [19798] by ggaren

LayoutTests:

Used svn merge -r19786:19785 to roll out previous SVG results produced by
hack to work around SVG painting issue in DRT.


The new work-around preserves the old SVG results -- both text and pixel.
This should fix the ~400 new pixel failures introduced in r19786.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/carto.net/button-expected.txt:
  • svg/carto.net/colourpicker-expected.txt:
  • svg/carto.net/combobox-expected.txt:
  • svg/carto.net/scrollbar-expected.txt:
  • svg/carto.net/selectionlist-expected.txt:
  • svg/carto.net/slider-expected.txt:
  • svg/carto.net/tabgroup-expected.txt:
  • svg/carto.net/textbox-expected.txt:
  • svg/carto.net/window-expected.txt:
  • svg/custom/gradient-stop-style-change-expected.txt:
  • svg/custom/js-late-clipPath-and-object-creation-expected.txt:
  • svg/custom/js-late-clipPath-creation-expected.txt:
  • svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/pointer-events-text-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/text-repaint-including-stroke-expected.txt:
  • svg/custom/use-elementInstance-event-target-expected.txt:
  • svg/custom/use-on-text-expected.txt:

WebKitTools:

Used svn merge -r19786:19785 to roll out previous hack to work around
SVG painting issue in DRT.


Implemented new work-around, which makes --paint paint *after* dumping
the render tree instead of before, so that painting doesn't influence
the SVG render tree.

This should fix the ~400 new pixel failures introduced in r19786.

  • DumpRenderTree/DumpRenderTree.m: (dump):
  • Scripts/run-webkit-tests:
11:57 Changeset [19797] by antti

LayoutTests:

Reviewed by Darin.


  • fast/forms/select-initial-position-expected.checksum: Added.
  • fast/forms/select-initial-position-expected.png: Added.
  • fast/forms/select-initial-position-expected.txt: Added.
  • fast/forms/select-initial-position.html: Added.

WebCore:

Reviewed by Darin.


Initiate scroll when selected <option> is added to <select>.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::insertedIntoDocument):
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::updateListBoxSelection): (WebCore::HTMLSelectElement::scrollToSelection):
  • html/HTMLSelectElement.h:
11:32 Changeset [19796] by zack

Fix sites with fixed positioned backgrounds. (my blog =) )
r=Lars,George

11:18 Changeset [19795] by ggaren

Resetting --leaks mode default to run 1000 tests at a time because setting it
to 750 didn't stop the stack logging related crashes, and running more tests
at a time is faster. The crashes seem to be a real bug in stack logging,
not an out of memory condition.

  • Scripts/run-webkit-tests:
09:38 Changeset [19794] by sullivan

Reviewed by Darin


Removed some unused keyView-related code that I happened to run across.
Replacement code is now in WebChromeClient.

  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: removed unused stuff
08:52 Changeset [19793] by zack

Fixing the default scroll offset, cleaning
up private methods and making the default
look not use any frames.
r=Lars

08:17 Changeset [19792] by zack

Properly implement canvas/scrollview's. Get
rid of ScrollViewCanvasQt and replace it with
a tailor abstractscrollview (now in qwebframe).
Scrolling of pages is finally completely smooth :)
r=Lars

07:59 Changeset [19791] by weinig

Reviewed by Maciej.

Fix ARM-specific alignment problem in FastMalloc
​http://bugs.webkit.org/show_bug.cgi?id=12841

  • wtf/FastMalloc.cpp: Modify how pageheap_memory is declared to ensure proper alignment on architectures such as ARM
07:45 Changeset [19790] by weinig

Reviewed by Maciej.

This patch also fixes a bug where using the arrow keys while
the suggestion popup is open moves the caret instead of changing the
selection in the popup (for up/down) or accepting the selection and
closing the popup (for left/right).

  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open before the current event, so that the Option-Esc that opens the popup will not close it immediately. (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a chance to intercept keydown events. (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the suggestion popup is open.
07:34 Changeset [19789] by weinig

Reviewed by Mark (age 21).

  • WebView/WebHTMLView.mm: (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow SPI that forces the scroll bar to look active. Also replaced a call to the deprecated NSTableView method setAutoresizesAllColumnsToFit: with the new method setColumnAutoresizingStyle: to eliminate console spew.
Note: See TracTimeline for information about the timeline view.