Timeline



Mar 2, 2007:

6:18 PM Changeset in webkit [19952] by kmccullo
  • 39 edits
    20 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • fast/loader/local-CSS-from-local-expected.txt: Added.
  • fast/loader/local-CSS-from-local.html: Added.
  • fast/loader/local-JavaScript-from-local-expected.txt: Added.
  • fast/loader/local-JavaScript-from-local.html: Added.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Added.
  • fast/loader/local-iFrame-source-from-local.html: Added.
  • fast/loader/local-image-from-local-expected.txt: Added.
  • fast/loader/local-image-from-local.html: Added.
  • http/tests/security/local-CSS-from-remote-expected.txt: Added.
  • http/tests/security/local-CSS-from-remote.html: Added.
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
  • http/tests/security/local-JavaScript-from-remote.html: Added.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Added.
  • http/tests/security/local-iFrame-from-remote.html: Added.
  • http/tests/security/local-image-from-remote-expected.txt: Added.
  • http/tests/security/local-image-from-remote.html: Added.
  • http/tests/security/resources/compass.jpg: Added.
  • http/tests/security/resources/cssStyle.css: Added.
  • http/tests/security/resources/localPage.html: Added.
  • http/tests/security/resources/localScript.js: Added.

WebCore:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • WebCore.exp: added exported functions
  • bindings/objc/DOM.mm: consolodated function to base class (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/Document.cpp: Cache the document's ability to load local resources. (WebCore::Document::Document): (WebCore::Document::setURL): (WebCore::Document::shouldBeAllowedToLoadLocalResources): (WebCore::Document::stylesheetLoaded):
  • dom/Document.h: Cache the docuent's ability to load local resources. (WebCore::Document::getPendingSheet): (WebCore::Document::isAllowedToLoadLocalResources):
  • html/HTMLImageLoader.cpp: Moved functionality into base class. (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLLinkElement.cpp: Handles null returns correctly now.
  • html/HTMLTokenizer.cpp: Moved functionality into base class. (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class. (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: Checks if the cached resource can be loaded. (WebCore::Cache::requestResource):
  • loader/CachedCSSStyleSheet.cpp: Moved functionality into base class. (WebCore::CachedCSSStyleSheet::ref): (WebCore::CachedCSSStyleSheet::error):
  • loader/CachedImage.cpp: Moved functionality into base class. (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h: Moved functionality into base class. (WebCore::CachedImage::canRender):
  • loader/CachedResource.cpp: Cache if the CachedResource should be treated as local (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: Moved functionality into base class. (WebCore::CachedResource::errorOccurred): (WebCore::CachedResource::shouldTreatAsLocal):
  • loader/CachedScript.cpp: Moved functionality into base class. (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h: Moved functionality into base class. (WebCore::CachedScript::schedule):
  • loader/CachedXBLDocument.cpp: Moved functionality into base class. (WebCore::CachedXBLDocument::error):
  • loader/CachedXSLStyleSheet.cpp: Moved functionality into base class. (WebCore::CachedXSLStyleSheet::error):
  • loader/FrameLoader.cpp: See comments for each function below. (WebCore::FrameLoader::loadSubframe): Use new canLoad. (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check. (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check. (WebCore::localSchemes): Return set of schemes that are to be treated as local. (WebCore::FrameLoader::loadPlugin): Use new canLoad. (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously. (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed. (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info. (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local. (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
  • loader/FrameLoader.h: Declared functions for this security fix. See above.
  • loader/MainResourceLoader.cpp: Optized order of bools to regain performance. (WebCore::MainResourceLoader::continueAfterContentPolicy):
  • loader/SubresourceLoader.cpp: Now restricts remote from loading local resources. (WebCore::SubresourceLoader::create):
  • page/EventHandler.cpp: Moved functionality into base class. (WebCore::selectCursor):
  • platform/KURL.cpp: KURLs need to check all the registered schemes now. (WebCore::KURL::isLocalFile):
  • rendering/HitTestResult.cpp: Moved functionality into base class. (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: Moved functionality into base class. (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: Moved functionality into base class. (WebCore::RenderImage::errorOccurred):
  • rendering/RenderListItem.cpp: Moved functionality into base class. (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: Moved functionality into base class. (WebCore::RenderListMarker::isImage):
  • xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently. (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):

WebKit:

Reviewed by Geoff.

  • rdar://problem/4922454
  • This fixes a security issue by making remote referrers not able to access local resources, unless they register their schemes to be treated as local. The result is that those schemes can access local resources and cannot be accessed by remote referrers. Because this behavior is new a link-on-or-after check is made to determine if the app should use the older, less safe, behavior.
  • Misc/WebKitVersionChecks.h: added linked-on-or-after check
  • Misc/WebNSAttributedStringExtras.mm: Moved functionalit into the base class. (fileWrapperForElement):
  • Plugins/WebNetscapePluginStream.mm: uses new canLoad functions
  • Plugins/WebPluginContainerCheck.mm: uses new canLoad functions (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebView.mm: make linked-on-or-after check and cache value, exposes SPI for registering a scheme as local. (-[WebView _commonInitializationWithFrameName:groupName:]): (+[WebView registerSchemeAsLocal:]):
  • WebView/WebViewPrivate.h: exposes SPI for registering a scheme as local.
5:46 PM Changeset in webkit [19951] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by kevin


<rdar://problem/5028447>
REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

  • editing/pasteboard/5028447-expected.checksum: Added.
  • editing/pasteboard/5028447-expected.png: Added.
  • editing/pasteboard/5028447-expected.txt: Added.
  • editing/pasteboard/5028447.html: Added.

WebCore:

Reviewed by kevin


<rdar://problem/5028447>
REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

  • editing/markup.cpp: (WebCore::createMarkup): The style of the div that holds a fully selected body's styles didn't include styles inherited from the body's ancestors.
4:48 PM Changeset in webkit [19950] by ggaren
  • 2 edits in trunk/WebKitTools

Tweaked parse-malloc-history to work with new malloc_history output format.

  • Scripts/parse-malloc-history:
4:09 PM Changeset in webkit [23020] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Beth.

Make submenus draw using the UIDelegate.

  • Interfaces/IWebUIDelegate.idl: Added new delegate method to add custom drawing data for menus.
  • WebView.cpp: (WebView::onInitMenuPopup): Added. Calls new delegate method. (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called for all submenus.
  • WebView.h: Added declaration.
3:02 PM Changeset in webkit [19949] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4545040>
innerHTML does not HTML-escape text nodes inside PRE elements
<rdar://problem/5027857>
Pasting into Mail from Safari's view-source window renders the HTML

  • editing/pasteboard/5027857-expected.checksum: Added.
  • editing/pasteboard/5027857-expected.png: Added.
  • editing/pasteboard/5027857-expected.txt: Added.
  • editing/pasteboard/5027857.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4545040>
innerHTML does not HTML-escape text nodes inside PRE elements
<rdar://problem/5027857>
Pasting into Mail from Safari's view-source window renders the HTML

  • editing/HTMLInterchange.cpp: (WebCore::convertHTMLTextToInterchangeFormat): Send this function the node that the text comes from as a parameter. It shouldn't convert '\n's to spaces/nbsps if the text is coming from text where newlines are preserved.
  • editing/HTMLInterchange.h:
  • editing/markup.cpp: (WebCore::startMarkup): Escape text inside the children of PREs.
2:35 PM Changeset in webkit [23019] by aroben
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Added optional underlining of a single character to
WebCoreTextRenderer.

No layout tests possible.

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::doDrawTextAtPoint): Added. This is an extraction of the code from DrawTextAtPoint that now also contains the underlining code. (WebCore::WebCoreDrawTextAtPoint): Call the helper function. (WebCore::WebCoreDrawDoubledTextAtPoint): Ditto.
  • platform/win/WebCoreTextRenderer.h: Added optional underlinedIndex parameters.

WebKitWin:

Reviewed by Anders.

Added optional underlining of a single character to WebKitGraphics.

1:10 PM Changeset in webkit [19948] by weinig
  • 4 edits in trunk

WebCore:

Reviewed by Anders.

Try to fix the Qt build.

  • platform/qt/TemporaryLinkStubs.cpp: Add stubs. (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):

WebKitQt:

Reviewed by Anders.

Try to fix the Qt build

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragDestinationAction): (WebCore::DragClientQt::dragControllerDestroyed): (WebCore::DragClientQt::createDragImageForLink):
1:06 PM Changeset in webkit [19947] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-03-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Anders.


Add unsigned int hash traits (matches existing unsigned long version)

  • wtf/HashTraits.h: (WTF::):
1:06 PM Changeset in webkit [19946] by harrison
  • 2 edits in trunk/WebCore

Suggested by Darin.

A more efficient solution to rdar://4961431.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]):
11:55 AM Changeset in webkit [19945] by aroben
  • 4 edits in trunk/JavaScriptCore

Reviewed by Kevin M.

Try to fix the Qt build.

  • kjs/DateMath.cpp: (KJS::msToGregorianDateTime): Removed unnecessary "struct" keyword.
  • kjs/DateMath.h: Moved forward declarations to the top of the file before they are used.
  • kjs/date_object.cpp: (KJS::formatLocaleDate): Changed to take a const GregorianDateTime& since GregorianDateTime is Noncopyable.
11:53 AM Changeset in webkit [19944] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5032095>
Gmail Editor: Copied text pastes on a new line instead of current line

  • editing/pasteboard/5032095-expected.checksum: Added.
  • editing/pasteboard/5032095-expected.png: Added.
  • editing/pasteboard/5032095-expected.txt: Added.
  • editing/pasteboard/5032095.html: Added.

WebCore:

Reviewed by john


<rdar://problem/5032095>
Gmail Editor: Copied text pastes on a new line instead of current line


Start merge failed to occur because positionAtStartOfInsertedContent
had a bug.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Was failing when inserting <span><div>foo/div></span>. Return the inserted content's first VisiblePosition.
9:42 AM Changeset in webkit [19943] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

  • kjs/DateMath.h: Marked GregorianDateTime as noncopyable, since it has a non-trivial destructor and not the correspoding copy constructor or assignment operator. Changed the GregorianDateTime constructor to use member initialization syntax. Fixed the destructor to use the array delete operator, since timeZone is an array.
  • kjs/DateMath.cpp: (KJS::daysInYear): Changed to call isLeapYear so the rule is not repeated twice. (KJS::getUTCOffset): Added caching on PLATFORM(DARWIN), since we can rely on the notify_check function and "com.apple.system.timezone" to let us know when the offset has changed.
1:39 AM Changeset in webkit [19942] by hyatt
  • 2 edits in trunk/WebCore

Fix glyph map crasher.

12:22 AM Changeset in webkit [19941] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12895
REGRESSION: imagemap: pointer cursor is shown everywhere
<rdar://problem/5028163>


Image with imagemap should never itself be URLElement in hit test results.


No layout test, cursor state can't be captured.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest):

Mar 1, 2007:

11:59 PM Changeset in webkit [19940] by antti
  • 8 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.


HTTP layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>

also for
​http://bugs.webkit.org/show_bug.cgi?id=12604
​http://bugs.webkit.org/show_bug.cgi?id=12020


  • http/tests/misc/multiple-submit-expected.txt: Added.
  • http/tests/misc/multiple-submit.html: Added.
  • http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.

WebCore:

Reviewed by Maciej.


Fix ​http://bugs.webkit.org/show_bug.cgi?id=12690
REGRESSION: can not log in to bank of america with TOT webkit
<rdar://problem/4990044>


and ​http://bugs.webkit.org/show_bug.cgi?id=12604
REGRESSION: After closing the "Would you like to save password" sheet, the form fails
to submit automatically at ​http://www.mac.com/WebObjects/HomePage.woa
<rdar://problem/4871752>


and ​http://bugs.webkit.org/show_bug.cgi?id=12020
REGRESSION: Flickr uploading broken
<rdar://problem/4928662>


Turn protection against multiple forms submission back on. This approach is buggy
but it is way better than not having it at all. Not protecting against this
breaks number of major sites.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::resetMultipleFormSubmissionProtection): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::receivedMainResourceError):
  • loader/FrameLoader.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
  • page/Frame.cpp: (WebCore::Frame::setView):
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::mouseDown):
10:35 PM Changeset in webkit [19939] by bdash
  • 4 edits in tags/Safari-5522.1

Versioning.

9:26 PM Changeset in webkit [19938] by bdash
  • 2 edits in tags/Safari-5522.1/WebCore

Merge in r19928.

2007-03-01 David Harrison <​harrison@apple.com>

Reviewed by Darin.

<rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Initialize threadViolationIsException to true.
9:18 PM Changeset in webkit [19937] by bdash
  • 10 edits
    2 copies in tags/Safari-5522.1

Merge in r19921.

2007-02-28 Brady Eidson <​beidson@apple.com>

Reviewed by Beth

Move the Thread Safety Check functions into their own header for export to WebKit

  • WebCore.exp: Export the function
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm: Include the new header
  • platform/Logging.h: Move stuff to ThreadCheck.h
  • platform/ThreadCheck.h: Added.
  • platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
  • platform/mac/ThreadCheck.mm: Added. (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation):

2007-02-28 Brady Eidson <​beidson@apple.com>

Reviewed by Beth

Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
the WebKit API instead of the ASSERT_MAIN_THREAD() hack

  • History/WebBackForwardList.mm: (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]):
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]):
8:47 PM Changeset in webkit [19936] by bdash
  • 1 copy in tags/Safari-5522.1

New tag.

7:16 PM Changeset in webkit [23018] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:13 PM Changeset in webkit [19935] by sfalken
  • 1 copy in tags/Safari-521.35.5b

New tag.

6:42 PM Changeset in webkit [19934] by kmccullo
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

  • Tests that the url of a document after an open is what it was before the open.
  • fast/loader/external-script-URL-location-expected.txt: Added.
  • fast/loader/external-script-URL-location.html: Added.
  • fast/loader/resources/external-script-URL-location.js: Added.

WebCore:

Reviewed by Adam.

  • Added the test case: external-script-URL-location.html
  • Fix an issue where the url of a document is null after an open if the document has no parent.
  • dom/Document.cpp: (WebCore::Document::open):
6:29 PM Changeset in webkit [19933] by bdash
  • 3 edits in tags/Safari-4522.1

Versioning.

6:23 PM Changeset in webkit [19932] by bdash
  • 1 copy in tags/Safari-4522.1

New tag.

6:17 PM Changeset in webkit [19931] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4960250>
​http://bugs.webkit.org/show_bug.cgi?id=11627
REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes


In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the
didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
to be reset to null when other code wasn't expecting it.


This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
that no leaks occur.


  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::stopLoading):
5:58 PM Changeset in webkit [19930] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix ARM crash due to accessing non-4-byte-aligned memory
as 32-bit values.

  • platform/AtomicString.cpp: (WebCore::UCharBufferTranslator::equal):
5:57 PM Changeset in webkit [19929] by justing
  • 3 edits in trunk/WebKit

Reviewed by harrison


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Provide subresources used to create the fragment as a
convenience.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Update the calls to the changed method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Give the caller the subresources in the WebArchive and RTF cases.
  • WebView/WebHTMLViewPrivate.h:
5:53 PM Changeset in webkit [19928] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Initialize threadViolationIsException to true.
4:46 PM Changeset in webkit [23017] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin M.

Add support for right-truncation to WebKitGraphics.

2:04 PM Changeset in webkit [23016] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

  • plugins/win/npfunctions.h: Fix tyop.
2:00 PM Changeset in webkit [19927] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin

<rdar://problem/5030628> - Crash opening a new window with the
"New windows open to the same page" pref set

  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly
9:08 AM Changeset in webkit [19926] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12801
Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

Test: editing/pasteboard/createMarkup-assert.xml

  • editing/markup.cpp: (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.

Feb 28, 2007:

11:43 PM Changeset in webkit [19925] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Oliver and Hyatt.

Fix <rdar://problem/5024233> Crash while using Find on empty document

No layout test possible, as this involves a null document.

  • dom/Range.cpp: (WebCore::rangeOfContents): Added an ASSERT.
  • page/Frame.cpp: (WebCore::Frame::findString): Added a null-check for document(). (WebCore::Frame::markAllMatchesForText): Ditto.
8:42 PM Changeset in webkit [23015] by aroben
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Anders.

Clean up WebCoreTextRenderer. WebCoreDrawTextAtPoint now just draws
text at a point. It doesn't center truncate, clip, or modify alignment.

No layout test possible.

  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Use only WebCore types, and don't center truncate or modify alignment. (WebCore::WebCoreDrawDoubledTextAtPoint): Moved from WebKitGraphics.cpp. (WebCore::WebCoreTextFloatWidth): Added.
  • platform/win/WebCoreTextRenderer.h: Updated/added declarations.

WebKitWin:

Reviewed by Anders.

Made WebKitGraphics more flexible.

7:25 PM Changeset in webkit [19924] by oliver
  • 2 edits in trunk/WebKit

2007-02-28 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fixes <rdar://problem/5012009>


When looking for a requested resource we should also check
the set of manually added subresources if WebCore can't find it.

  • WebView/WebDataSource.mm: (-[WebDataSource subresourceForURL:]):
5:30 PM Changeset in webkit [19923] by thatcher
  • 8 edits in trunk/WebKitTools

Reviewed by Tim H.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12887
Bug#12887: [Drosera] Add ability to close loaded files

  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/English.lproj/MainMenu.nib/classes.nib:
  • Drosera/English.lproj/MainMenu.nib/info.nib:
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
  • Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
  • Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file
4:47 PM Changeset in webkit [19922] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - simple gdk build fix.

Add stubs for newly introduced localized strings.

  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText):
4:01 PM Changeset in webkit [19921] by beidson
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Beth

Move the Thread Safety Check functions into their own header for export to WebKit

  • WebCore.exp: Export the function
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm: Include the new header
  • platform/Logging.h: Move stuff to ThreadCheck.h
  • platform/ThreadCheck.h: Added.
  • platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
  • platform/mac/ThreadCheck.mm: Added. (WebCore::_WebCoreThreadViolationCheck): (WebCoreReportThreadViolation):

WebKit:

Reviewed by Beth

Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
the WebKit API instead of the ASSERT_MAIN_THREAD() hack

  • History/WebBackForwardList.mm: (-[WebBackForwardList initWithWebCoreBackForwardList:]): (-[WebBackForwardList init]): (-[WebBackForwardList dealloc]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem dealloc]): (-[WebHistoryItem finalize]): (-[WebHistoryItem copyWithZone:]): (-[WebHistoryItem initWithWebCoreHistoryItem:]):
  • Misc/WebIconDatabase.mm: (-[WebIconDatabase init]):
3:59 PM Changeset in webkit [23014] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):
3:46 PM Changeset in webkit [19920] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION:
Assertion failure copying standalone image

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Use the CachedImage as the resource. This makes more sense anyway. There is no need to null- check the renderer or the CachedImage since we return early if there is no Image* and the HitTestResult::image() function checks for these things.
3:08 PM Changeset in webkit [19919] by adele
  • 8 edits in trunk

WebCore:

Reviewed by Beth.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

Use localized strings from WebKit instead of hard coded strings.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject roleDescription]):
  • page/mac/WebCoreViewFactory.h:
  • platform/LocalizedStrings.h:
  • platform/mac/LocalizedStringsMac.mm: (WebCore::searchMenuNoRecentSearchesText): (WebCore::searchMenuRecentSearchesText): (WebCore::searchMenuClearRecentSearchesText): (WebCore::AXWebAreaText): (WebCore::AXLinkText): (WebCore::AXListMarkerText): (WebCore::AXImageMapText): (WebCore::AXHeadingText):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemText):

WebKit:

Reviewed by Beth.

Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory searchMenuNoRecentSearchesText]): (-[WebViewFactory searchMenuRecentSearchesText]): (-[WebViewFactory searchMenuClearRecentSearchesText]): (-[WebViewFactory AXWebAreaText]): (-[WebViewFactory AXLinkText]): (-[WebViewFactory AXListMarkerText]): (-[WebViewFactory AXImageMapText]): (-[WebViewFactory AXHeadingText]):
2:31 PM Changeset in webkit [19918] by brmorris
  • 2 edits in S60/trunk/JavaScriptCore

vbradley, reviewed by Yongjun

DESC: merge r19917 to s60/trunk. ALAA-6XSF7U : Reduce stack overflow counter
​http://bugs.webkit.org/show_bug.cgi?id=12928

2:26 PM Changeset in webkit [19917] by brmorris
  • 2 edits in S60/branches/3.1m/JavaScriptCore

vbradley, reviewed by Yongjun.

DESC: ALAA-6XSF7U : Reduce stack overflow counter
​http://bugs.webkit.org/show_bug.cgi?id=12928

2:23 PM Changeset in webkit [19916] by brmorris
  • 3 edits in S60/trunk/WebKit

yinxcai, reviewed by <Yongjun>

DESC: TMCN-6Y9Q7A --Browser ask permission for unsecure item load repeatedly
​http://bugs.webkit.org/show_bug.cgi?id=12901

2:17 PM Changeset in webkit [19915] by brmorris
  • 13 edits in S60/trunk/WebKit

yinxcai, reviewed by <Sachin>

DESC: merge of r19914 to s60/turnk: Browser may crash when selecting No for secure connections HMNN-6YLEHJ
​http://bugs.webkit.org/show_bug.cgi?id=12858

2:15 PM Changeset in webkit [19914] by brmorris
  • 13 edits in S60/branches/3.1m/WebKit

yinxcai, reviewed by <Sachin>

DESC Browser may crash when selecting No for secure connections HMNN-6YLEHJ
​http://bugs.webkit.org/show_bug.cgi?id=12858

2:11 PM Changeset in webkit [19913] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Sachin

DESC: Toolbar should be activated only on long keypress CR: 102-5945
​http://bugs.webkit.org/show_bug.cgi?id=12816

11:56 AM Changeset in webkit [19912] by ggaren
  • 1 edit
    1 move in trunk/LayoutTests

Reviewed by Bradeee Eidson.

Disabling this test for now because it fails on the buildbot but not on
my Intel or PPC machines. I've filed ​http://bugs.webkit.org/show_bug.cgi?id=12930
to track this issue.

  • fast/leaks/003.html: Removed.
7:46 AM Changeset in webkit [19911] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/lists/ol-start-dynamic-expected.checksum: Added.
  • fast/lists/ol-start-dynamic-expected.png: Added.
  • fast/lists/ol-start-dynamic-expected.txt: Added.
  • fast/lists/ol-start-dynamic.html: Added.

WebCore:

Reviewed by Maciej.


Update list marker value when start attribute changes.

  • html/HTMLOListElement.cpp: (WebCore::HTMLOListElement::parseMappedAttribute):
4:29 AM Changeset in webkit [19910] by zimmermann
  • 8 edits in trunk

Reviewed by Maciej.

Corrected the use of the new ENABLE() macros in some ksvg2/svg files.
Add new build-webkit flags "--(no-)xpath" / "--(no-)xslt", to be able
to switch off build features easily. Also add "--(no-)svg-experimental-features"
flag, to be able to test filters/animations/use/foreignObject easily.

1:00 AM Changeset in webkit [19909] by bdash
  • 2 edits in trunk/WebKit

2007-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

<rdar://problem/5028473> WebKit allocates a huge number of NSCalendarDates while loading history file

  • History/WebHistory.mm: (-[WebHistoryPrivate insertItem:atDateIndex:]): Use lastVisitedTimeInterval rather than _lastVisitedDate to avoid allocating NSCalendarDates.
12:42 AM Changeset in webkit [23013] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Use RetainPtr instead of explicit release, as this was caused by CFRelease on a null pointer, and REtainPtr is tolerant.
12:29 AM Changeset in webkit [19908] by rwlbuis
  • 34 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12609
Any SVG element will create renderers even when children of HTML elements

Allow creation of svg renderers only when parent is SVG, except for
the <svg> element.

12:10 AM Changeset in webkit [23012] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Feb 27, 2007:

11:55 PM Changeset in webkit [19907] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12913
Markers do not render in webkit when it misses markerWidth or markerHeight attribute

Set defaults for markerWidth/markerHeight so markers that do not specify them render.

9:33 PM Changeset in webkit [19906] by ggaren
  • 2 edits in trunk/LayoutTests

Extending the timeout on this test to see if it fixes the buildbot failure.
(I don't get a failure locally.)

  • fast/leaks/003.html:
9:13 PM Changeset in webkit [23011] by adachan
  • 7 edits
    4 adds in branches/WindowsMerge/WebKitWin
6:04 PM Changeset in webkit [23010] by aliceli1
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve, Adam, Maciej, and their mothers.

This is a general leaks fix but helps the effort towards fixing
<rdar://4974495> Boomer leaks while running HTML iBench
However, this fix doens't close that bug.

  • WebFrame.cpp: (WebFrame::setTitle):

fix a leak of WebHistory

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLUnicode):

fix a leak of WebHistory

5:17 PM Changeset in webkit [23009] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:16 PM Changeset in webkit [19905] by andersca
  • 2 edits in trunk/WebCore
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::~ResourceLoader): Remove comment.
5:15 PM Changeset in webkit [19904] by sfalken
  • 1 copy in tags/Safari-521.35.3b

New tag.

5:12 PM Changeset in webkit [23008] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Fix <rdar://problem/5004615> View source menu option is always disabled
when Netscape 8 is installed

The bug was caused by Netscape's npTrident.dll plugin, which registers
itself as a handler for text/html and text/xml.

  • WebFrame.cpp: (WebFrame::canProvideDocumentSource): Explicitly allow viewing the source of HTML and XML documents, rather than disallowing text, image, and plugin documents. Plugins can register themselves as handlers for HTML and XML MIME types, but we still want to display source in those cases.
5:08 PM Changeset in webkit [19903] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by oliver


<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

  • editing/inserting/12882-expected.checksum: Added.
  • editing/inserting/12882-expected.png: Added.
  • editing/inserting/12882-expected.txt: Added.
  • editing/inserting/12882.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5027300>
REGRESSION: Images inserted with align left/right are lost

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Don't attempt to merge to or from a position before or after a block because it will be a no-op and lead to infinite recursion. In this case it instead resulted in content loss because of bugs in start/endOfParagraph (5027702).
  • editing/visible_units.cpp: Added two FIXMEs for the problems with start/endOfParagraph.
4:38 PM Changeset in webkit [19902] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

Make resource load delegate methods pass the right document loader.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::willSendRequest): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::didFinishLoad): (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge): Use the resource loader's document loader instead of the active one.


  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::receivedError): Make it so we send the frame load delegate method before the resource load delegate method. This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader now works, both delegate methods will be called.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader):
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::documentLoader): Add document loader pointer to ResourceLoader.
4:26 PM Changeset in webkit [19901] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Follow-up to fixing ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com


Changed Interpreter cache of global constructors and prototypes from
ProtectedPtrs to bare, marked pointers. ProtectedPtrs are inefficient,
and they increase the risk of reference cycles. Also, Darin said something
about ProtectedPtrs giving him warts.


Also changed data members to precise types from generic JSObject*'s.


Layout tests and JS tests pass.

  • kjs/SavedBuiltins.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::initGlobalObject): Moved Identifier::init() call to constructor, for clarity. (KJS::Interpreter::mark):
  • kjs/interpreter.h:
4:21 PM Changeset in webkit [19900] by ggaren
  • 1 edit in trunk/LayoutTests/fast/leaks/003-expected.txt

Oops! Forgot to check in this file.

4:04 PM Changeset in webkit [19899] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/list-marker-expected.checksum: Added.
  • fast/repaint/list-marker-expected.png: Added.
  • fast/repaint/list-marker-expected.txt: Added.
  • fast/repaint/list-marker.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/list-marker.html

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): Add the marker to the visual overflow of all its ancestor blocks up to the list item. This needs to be done here since the marker is positioned only after those blocks have been laid out.
3:38 PM Changeset in webkit [19898] by bdash
  • 3 edits in trunk/WebKit

2007-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/4985524> Problem with Blot and ToT WebKit (decoding WebCoreScrollView)

References to WebCoreScrollView as a subview of a WebHTMLView may be present in some NIB
files, so NSUnarchiver must be still able to look up the WebCoreScrollView class.

  • WebKit.exp: Export WebCoreScrollView symbol.
  • WebView/WebHTMLView.mm: Add empty WebCoreScrollView class.
3:27 PM Changeset in webkit [23007] by adachan
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Oops, ChangeLog wasn't saved last time.

3:24 PM Changeset in webkit [23006] by bdakin
  • 4 edits in branches/WindowsMerge

WebKitWin:

Reviewed by Adam.

Make msimg32.lib available to the engine so that we can use
AlphaBlend.

  • WebKit.vcproj/WebKit.vcproj:

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4956528> Implement Pasteboard::writeImage for
Boomer context menus

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Copy a bitmap to the clipboard.
3:22 PM Changeset in webkit [23005] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <​adachan@apple.com>

Fix build.

  • WebFrame.cpp:
3:13 PM Changeset in webkit [19897] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/events/mouseout-dead-node-expected.checksum: Added.
  • fast/events/mouseout-dead-node-expected.png: Added.
  • fast/events/mouseout-dead-node-expected.txt: Added.
  • fast/events/mouseout-dead-node.html: Added.

WebCore:

Reviewed by Hyatt.



If a node dies while mouse is over it, it is still supposed to receive
mouseout event (wasn't case in Tiger webkit). However this event should
not propagate to any other nodes. This patch matches Firefox behavior in
this respect.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
3:10 PM Changeset in webkit [19896] by ggaren
  • 2 edits in trunk/LayoutTests

Bumped up the wiggle room on this test because it's failing on the buildbot.
(We're still well below the ~100 objects you would see in a real failure.)

  • fast/leaks/003.html:
3:09 PM Changeset in webkit [19895] by ggaren
  • 1 edit in trunk/LayoutTests/fast/dom/gc-10.html

Oops! Forgot to commit this file

3:03 PM Changeset in webkit [23004] by oliver
  • 4 edits in branches/WindowsMerge

2007-02-27 Oliver Hunt <​oliver@apple.com>

Reviewed by Lou and Steve.


WebCoreWin:

Add a store for current Cursor to fix <rdar://problem/4788352>

  • platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor):


WebKitWin:

<rdar://4983106> Stop/reload button never changes back to
reload when a click on a link spawns a download

  • WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
  • WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method


2:28 PM Changeset in webkit [19894] by ggaren
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Don't GC in the Interpreter destructor. For that to work, the Interpreter
would have to NULL out all of its ProtectedPtrs before calling collect(). But
we've decided that we don't want things to work that way, anyway. We want the
client to be in charge of manual GC so that it can optimize cases when
it will be destroying many interpreters at once
(e.g., ​http://bugs.webkit.org/show_bug.cgi?id=12900).


Also removed Interpreter::collect() because it was redundant with
Collector::collect().

  • JavaScriptCore.exp:
  • kjs/interpreter.cpp: (KJS::Interpreter::~Interpreter):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction):

LayoutTests:

Reviewed by Maciej Stachowiak.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com


  • fast/leaks/003-expected.txt: Added.
  • fast/leaks/003.html: Added.
  • fast/dom/gc-10.html: Bumped the wiggle room threshold on this test by 2 because it's failing on my machine with the patch applied but, according to the test notes, we're still well within the margin of error.

WebCore:

Reviewed by Maciej Stachowiak.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
JS objects not collected after closing window @ ebay.com/maps.google.com

Garbage collect in the KJSProxy destructor, after clearing our reference
to the interpreter, because that's when the interpreter has torn down fully.

(Technically speaking, we can't *prove* that we have the only reference to
our interpreter, but that's how it works in practice, and manual garbage
collection is just an opportunistic optimization, so it's OK for it to
work in practice even if it can't be proven in theory.)


Layout tests pass. No leaks reported.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
  • bindings/js/kjs_proxy.h:
  • page/Page.cpp: (WebCore::Page::~Page): Merged pageDestroyed() calls. Moved debug-only code to the bottom.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Don't call getObject() because globalObject() returns a JSObject* already, and the call can leave a pointer to the Window object on the stack. Don't check for NULL because it is an invariant of JavaScriptCore that no JSObject* can be NULL. Do use a volatile pointer for w because the 'w = 0' assignment just screams to the compiler, "Don't generate any code for me!"
2:26 PM Changeset in webkit [23003] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-02-27 Ada Chan <​adachan@apple.com>

Reviewed by Steve and Anders.

<rdar://4983106> Stop/reload button never changes back to reload when a click on a link spawns a download

WebKitWin:

  • WebError.cpp: (WebError::isPolicyChangeError): fixed string comparison
  • WebFrame.cpp: (WebFrame::interruptForPolicyChangeError): implemented the method
12:50 PM Changeset in webkit [19893] by aroben
  • 2 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/5011905> REGRESSION: "Open Link" contextual menu
item appears twice

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusToSendToOldClients): Remove the "Open Link" item from the default menu items array before sending it off to Tiger Mail. (WebContextMenuClient::getCustomMenuFromDefaultItems): Set the representedObject on every NSMenuItem to match our old (correct) API behavior.
12:31 PM Changeset in webkit [19892] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by David Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=4128
!important is ignored in inline styling.

Handle properties with !important flag better in inline
style declarations.

12:13 PM Changeset in webkit [19891] by hyatt
  • 2 edits in trunk/WebCore

Bug 11435. Make sure RenderViews always paintBoxDecorations. They used to before I removed RenderView's
paint method. This fix restores the original behavior.

Reviewed by mitz

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
11:51 AM Changeset in webkit [19890] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird/rare case of empty
plaintext documents (which really are buggy and should be fixed to generate root elements).

Reviewed by mitz

  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView):
10:45 AM Changeset in webkit [19889] by ap
  • 2 edits in trunk/WebCore

2007-02-27 Dex Deacon <​occupant4@gmail.com>

Reviewed by Darin.

Fixed the case where a BackForwardList of capacity==1 would grow without bound.

  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem):
10:10 AM Changeset in webkit [19888] by ap
  • 2 edits in trunk/WebCore

2007-02-22 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12848
Help cursor should have a white outline

  • Resources/helpCursor.png:
10:00 AM Changeset in webkit [19887] by ap
  • 2 edits in trunk/WebKit

2007-02-27 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::scaleFactor): If the view is not in a window, use the main screen's scale factor as a best guess.
9:48 AM Changeset in webkit [19886] by ap
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12594
REGRESSION: Strange highlight in active input area

No automated test possible.

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Restore a check lost in r12792.
8:18 AM Changeset in webkit [19885] by ggaren
  • 2 edits in trunk/WebKitTools

Small tweak to run-webkit-tests.

  • Scripts/run-webkit-tests: Allow people with lots of RAM to run more than 1000 MallocStackLogging tests at a time.
6:08 AM Changeset in webkit [19884] by darin
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Add null checks.
6:05 AM Changeset in webkit [19883] by darin
  • 3 edits in trunk/WebCore

Reviewed by Alexey.

  • platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Add "macroman" as an alias for "macintosh". We have seen that in use in mail, although I'm not sure it's used on the web.
  • platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back as part of the patch for bug 4971226. But by adding it to the this file rather than the ICU codec, we get it only on Mac OS X. And long term we are trying to get rid of the use of TEC entirely, so we want this file to be as empty as possible.
6:05 AM Changeset in webkit [19882] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • test for MacRoman encoding name alias
  • fast/encoding/charset-names-expected.txt: Added.
  • fast/encoding/charset-names.html: Added.
5:02 AM Changeset in webkit [19881] by darin
  • 2 edits in trunk/LayoutTests
  • fast/css/computed-style-expected.txt: Updated test result for Hyatt's addition of -webkit-border-fit.
2:12 AM Changeset in webkit [19880] by rwlbuis
  • 7 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12905
Not all svg shapes should support markers

Restrict marker usage to svg shapes polyline, polygon, line and path.

12:44 AM Changeset in webkit [19879] by adele
  • 6 edits in trunk

LayoutTests:

Reviewed by Lars.

Updated test for ​http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

  • fast/frames/iframe-window-focus-expected.txt:
  • fast/frames/iframe-window-focus.html: Updated test to include insertion of newlines.

WebCore:

Reviewed by Lars.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12902
<rdar://problem/5012679> REGRESSION: Pressing return key doesn't
move caret to next line after applying a font color in GMail

Test: fast/frames/iframe-window-focus-2.html

  • page/EventHandler.h: Make focusDocumentView public.
  • page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame, we should set also focus the document view. The bug here was that since the subframe view wasn't the first responder, the key down event was going to the wrong frame.
Note: See TracTimeline for information about the timeline view.