Timeline


and

03/21/07:

22:55 Changeset [20384] by ggaren

Reviewed by Beth Dakin.


Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
accept "extra" coordinates -- virtually all commands accept them.

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
22:54 Changeset [20383] by ddkilzer

WebKitSite:

Reviewed by NOBODY (more word tweaking).

  • building/checkout.html: By popular demand, the link to the svn 1.3 client has been removed.
22:48 Changeset [20382] by ddkilzer

WebKitSite:

Reviewed by NOBODY (tweaked wording).

  • building/checkout.html: Got rid of "click here" link and restructured sentences linking to svn clients.
22:17 Changeset [23159] by aroben

Reviewed by Hyatt.

Force SVG tests to paint to match the Mac results.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Force a paint if we're running an SVG test.
21:31 Changeset [20381] by harrison

Reviewed by hyatt.

<rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168

An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.


The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.

  • platform/SharedBuffer.h: Declare createCFData().


  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): Call createCFData instead of createNSData.


  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Call createCFData instead of createNSData.


  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData): Implement createCFData(). Use HardRetainWithNSRelease for gc safety.
21:16 Changeset [20380] by ddkilzer

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/dynamic/view-overflow-expected.checksum: Added.
  • fast/dynamic/view-overflow-expected.png: Added.
  • fast/dynamic/view-overflow-expected.txt: Added.
  • fast/dynamic/view-overflow.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/dynamic/view-overflow.html

  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth() before calling docHeight() and docWidth(), since the former act as a lower bound for the latter.
21:11 Changeset [20379] by ddkilzer

WebKitSite:

Reviewed by Adam.

  • building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.
21:09 Changeset [20378] by ggaren

Fixed bad version of results that I check in accidentally.

  • svg/dom/string-list-parser-expected.txt:
21:05 Changeset [20377] by ggaren

Reviewed by Beth Dakin.


A little cleanup based work I've been doing on the SVG parsers.

  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipString):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into SVGParserUtilities.h, so it could be with all its friends. Renamed "checkString" to "skipString" to match the rest of the code and to be clear about which functions move the buffer pointer. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into returns. Removed unnecessary magic number.
20:50 Changeset [20376] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the SVG rgb color parser.

  • svg/dom/rgb-color-parser-expected.txt: Added.
  • svg/dom/rgb-color-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
buffer when running fuzzing test

  • ksvg2/svg/SVGColor.cpp: (WebCore::parseNumberOrPercent): Check for past the end condition. (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end of buffer, then check if you're past the end" logic.
20:37 Changeset [20375] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the path parser.

  • svg/dom/path-parser-expected.txt: Added.
  • svg/dom/path-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
running fuzzer test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are always preceded by an 'M' or an 'm'.
20:28 Changeset [20374] by ggaren

Reviewed by Beth Dakin.


Added fuzz tester for the string list parser.

  • svg/dom/string-list-parser-expected.txt: Added.
  • svg/dom/string-list-parser.html: Added.
20:26 Changeset [20373] by ggaren

Reviewed by Beth Dakin.


Added fuzz tester for the length list parser.

  • svg/dom/length-list-parser-expected.txt: Added.
  • svg/dom/length-list-parser.html: Added.
20:21 Changeset [20372] by ggaren

Reviewed by Beth Dakin.


Factored randomizing functions into their own file, in preparation for future
tests that rely on them.


  • svg/dom/resources/scripted-random.js: Added.
  • svg/dom/transform-parser.html: Factored out scripted-random.js, added a small string that increases the normal-seemingness of the last test.
20:12 Changeset [20371] by thatcher

New results after rolling out r19828 in r20352.

  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
18:42 Changeset [20370] by sullivan

Reviewed by Adam


  • fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled or saved for .Mac homepage login
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): don't count empty strings as valid results
18:21 Changeset [23158] by aroben

Reviewed by Oliver.

  • Skipped: Added an SVG test that causes a debug ASSERT in the C Runtime.
18:15 Changeset [23157] by aroben

WebKitToolsWin:

Reviewed by Oliver.

Make W3C SVG tests render at the correct dimensions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Resize the WebView if we're running a W3C SVG test. (runTest): Save the current test filename.
17:48 Changeset [20369] by justing

Reviewed by darin

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Release the RefPtr to avoid increasing/decreasing the refcount unnecessarily. (WebCore::propertyMissingOrEqualToNone): Added and used instead of converting values to strings. (WebCore::elementHasTextDecorationProperty): (WebCore::createMarkup):
17:31 Changeset [20368] by thatcher

Reviewed by Darin.

<rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

17:07 Changeset [23156] by andersca

Reviewed by Adam.

  • WebView.cpp: (WebView::initWithFrame): Remove #ifdef now that DRT no longer crashes.
16:59 Changeset [20367] by mjs
  • some specs to propose by email
  • specs/HTML_Timed_Media_Elements.html: Added.
  • specs/Timed_Media_CSS.html: Added.
  • specs/Timed_Media_Elements-Open_Issues.html: Added.
  • specs/mediaelement.css: Added.
  • specs/movie-status-states.png: Added.
16:58 Changeset [20366] by justing

LayoutTests:

Reviewed by oliver


<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

Tests for the bug:

  • editing/pasteboard/5075944-expected.checksum: Added.
  • editing/pasteboard/5075944-expected.png: Added.
  • editing/pasteboard/5075944-expected.txt: Added.
  • editing/pasteboard/5075944.html: Added. Tests that the element that has the text-decoration and all its descendants down to the common ancestor are included in the copied markup (instead of the text-decoration property being treated as though it were inheritable and placed on the style span wrapper):
  • editing/pasteboard/5075944-2-expected.checksum: Added.
  • editing/pasteboard/5075944-2-expected.png: Added.
  • editing/pasteboard/5075944-2-expected.txt: Added.
  • editing/pasteboard/5075944-2.html: Added. Tests that moveParagraphs gets underlining right (it doesn't use annotation):
  • editing/pasteboard/5075944-3-expected.checksum: Added.
  • editing/pasteboard/5075944-3-expected.png: Added.
  • editing/pasteboard/5075944-3-expected.txt: Added.
  • editing/pasteboard/5075944-3.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text


We stopped adding markup for all the ancestors
of lastClosed up to the commonAncestorBlock
because it was adding a lot of unnecessary markup.
This caused us to lose underlining when copying a
partially selected underlined element (even though
we put all styles that the copied markup inherits
into a style span, because the text-decoration
isn't inheritable).

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Moved code here. (WebCore::elementHasTextDecorationProperty): Added. (WebCore::createMarkup): If the copied markup has a text-decoration because some common ancestor has a text-decoration property set, include that ancestor and all its descendants in the copied markup.
16:40 Changeset [23155] by hyatt

Fix broken changelog.

16:37 Changeset [23154] by hyatt

Advanced text improvements.

16:28 Changeset [20365] by thatcher

New branch.

14:59 Changeset [20364] by oliver

2007-03-21 Oliver Hunt <​oliver@apple.com>

Reviewed by Antti.

WebCore:

Update a few SVG attribute parsers to be more defensive against
reading beyond the end of input.

Fixes rdar://problem/5077218 -- SVG transform parser runs past
end of buffer when running fuzzing test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipOptionalSpacesOrDelimiter):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::parseTransformParamList): (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:

Fuzz test for SVG transform parser

  • svg/dom/transform-parser-expected.txt: Added.
  • svg/dom/transform-parser.html: Added.
14:34 Changeset [23153] by bdakin

Reviewed by Adam.

<rdar://problem/5074274> right-clicking in certain iframes ends up
left-clicking, and context menu appears far away

  • WebView.cpp: (WebView::handleContextMenuEvent): We were always calling sendContextMenuEvent() on the main frame!! Instead, call it on the focused or main frame.
14:22 Changeset [23152] by aroben

LayoutTestsWin:

Reviewed by David Kilzer (yay!).

Re-enable the editing tests, except for two crashers.

  • Skipped:
12:06 Changeset [20363] by ap

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=13140
Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

Test: svg/carto.net/frameless-svg-parse-error.html

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportError): Added a null check. (WebCore::SVGDocumentExtensions::reportWarning): Ditto.
11:03 Changeset [23151] by adele

WebKitToolsWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Call updateActiveState on the WebView in didCommitLoadForFrame. This is required so that nodes can be properly focused in the document.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didCommitLoadForFrame):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Added updateActiveState SPI for DumpRenderTree.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus. We should merge this logic into updateActiveState eventually. (WebView::updateActiveState):
  • WebView.h:
10:55 Changeset [20362] by adele

Reviewed by Geoff.

  • API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.
02:30 Changeset [20361] by zack

Fix the compile when USE(MULTIPLE_THREADS) isn't defined

00:24 Changeset [20360] by bdakin

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

I tried to fix this earlier today but my fix caused a regression
scrolling through RSS pages. It turns out that sometimes scroll
events need to propagate immediately, and sometimes they must be
delayed or they risk deleting objects that are expected to be
around after the event has propagated. Mitz's original fix made
sheduleEvent() only delay events that happen during layout. This
fix marks two other places in addition to layout where events also
need to be delayed. These two places are places that were marked
with FIXMEs that Mitz removed in his original patch. (There was a
third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
case is only called through layout and is covered by Mitz's
original patch.)

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added assertion. (WebCore::FrameView::layout): Call new functions to increment and decrement the queued events count. (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): Decrement queued events count and dispatch events if the count has zeroed.
  • page/FrameView.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::Marquee::start):
00:21 Changeset [20359] by bdash

2007-03-21 Mitz Pettel <​mitz@webkit.org>

Reviewed by John Sullivan.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing to be terminated by a mouseup event regardless of whether the frameset needs layout.

03/20/07:

22:46 Changeset [20358] by andersca

Reviewed by Oliver.

<rdar://problem/5077252>
In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.
22:39 Changeset [20357] by beidson

Reviewed by Anders

<rdar://problem/5073391> and ​http://bugs.webkit.org/show_bug.cgi?id=13137

Crash in IconDatabase when private browsing is enabled.

The problem was caused by ​http://trac.webkit.org/projects/webkit/changeset/20182
which changed many uses of char[] and Vector<char> to SharedBuffer. The patch
tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
can be null. This led to derefs.

I took the opportunity to rework the iconDB functions to live in a SharedBuffer
world, as that didn't exist when they were originally written - now they just return
SharedBuffers instead of taking a Vector<char>& as a parameter

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking it if it's empty (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer
  • loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s
21:25 Changeset [23150] by aroben

Reviewed by Brady.

Always use CCom* smart pointers when possible to avoid memory management issues.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed _T() to TEXT(). (dump): (runTest): (initializePreferences): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (mouseDownCallback): (doMouseUp): (mouseClickCallback): (doMouseMove): (keyDownCallback):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setAcceptsEditingCallback): (setTabKeyCyclesThroughElementsCallback):
20:53 Changeset [23149] by sfalken

Bump version for submit

20:49 Changeset [20356] by sfalken

New tag.

18:50 Changeset [23148] by mjs

Removed conflict markers.

18:47 Changeset [23147] by mjs

WebKitToolsWin:

Reviewed by Geoff and Adam.


  • fixed some bugs in --threaded fond in the course of testing.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runJavaScriptThread): Be smarter about thread dictionary. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Account for --threaded command-line argument better.

WebKitWin:

Reviewed by Geoff and Adam.

  • <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
  • WebView.cpp: (WebView::WebView): Tell JavaScriptCore what the main thread is.
18:29 Changeset [23146] by aroben

Rubberstamped by Adele.

Roll out r12355 now that OpenSource r20348 has been rolled out.

  • Skipped: Also removed a crash that was caused by 20348.
18:24 Changeset [20355] by aroben

Rubberstamped by Adele.

Roll out r20348 because it was causing crashes.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
17:54 Changeset [23145] by aroben

Reviewed by Hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Install Helevetica Neue.
17:46 Changeset [20354] by bdash

2007-03-20 Matt Lilek <​pewtermoose@gmail.com>

Reviewed by Darin.

Clear up the steps necessary to get a patch landed.

​http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
​http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

  • coding/contributing.html:
17:13 Changeset [23144] by aroben

Rubberstamped by Beth.

  • Skipped: Added the real crasher (arrow-navigation.html just fails, doesn't crash).
17:11 Changeset [20353] by thatcher

Build fix.

16:57 Changeset [20352] by thatcher

Reviewed by Kevin Decker.

Rolling out part of r19828 that caused a scrolling regression in Mail.

<rdar://problem/4820817> Message jumps around when trying to select text

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::updateContents):
16:57 Changeset [20351] by mjs

Reviewed by Geoff and Adam.



  • fixed a threadsafety bug discovered by testing this


  • enhanced threadsafety assertions in collector
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't DropAllLocks around the finalize callback, because it gets called from garbage collection and we can't let other threads collect!
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSLock.cpp: (KJS::JSLock::currentThreadIsHoldingLock): Added new function to allow stronger assertions than just that the lock is held by some thread (you can now assert that the current thread is holding it, given the new JSLock design).
  • kjs/JSLock.h:
  • kjs/collector.cpp: Refactored for portability plus added some stronger assertions. (KJS::Collector::allocate): (KJS::currentThreadStackBase): (KJS::Collector::registerAsMainThread): (KJS::onMainThread): (KJS::PlatformThread::PlatformThread): (KJS::getCurrentPlatformThread): (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::Collector::registerThread): (KJS::Collector::markCurrentThreadConservatively): (KJS::suspendThread): (KJS::resumeThread): (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer): (KJS::otherThreadStackBase): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::collect):
  • kjs/collector.h:
  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded):
  • wtf/FastMallocInternal.h:
  • wtf/Platform.h:
16:25 Changeset [23143] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed bogus extra linker options.
16:24 Changeset [20350] by beidson

Reviewed by John

<rdar://5071341> - Crash in IconLoader::finishLoading()


Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
Hyatt's recent caching changings to the IconLoader. This crash tends to hit on sites without favicons,
that serve up complex 404 pages, often when the load is cancelled or redirected. Occasionally, it *seems*
the IconLoader is getting failed/cancelled twice.


This patch adds some assertions and a "fail gracefully in a release build" check that will have to
serve us until we know more about the cause.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail): Add an assertion to catch this case (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail gracefully in debug builds. Also add an efficiency check to not commit to the DB if there is no IconURL
16:15 Changeset [23142] by aroben

Reviewed by Beth.

  • Skipped: Added another crasher.
15:06 Changeset [23141] by aroben

Reviewed by Adele.

Added some tests that fail due to font metric differences.

  • Skipped:
15:01 Changeset [20349] by antti

Reviewed by Darin.


Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
really a good fix, smooth scrolling should be supported properly. It should do for now.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isScrollable):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isScrollable):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isScrollable):
  • rendering/RenderTextControl.h:
14:02 Changeset [23140] by adele

Reviewed by Adam.

Explicitly pass VK_RETURN when using keyDown for "\n".


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
13:47 Changeset [23139] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set libpath.
13:29 Changeset [23138] by bdakin

Reviewed by Adam.

Re-enabling fast/layers/removed-by-scroll-handler.html because
5072678 is fixed.

13:13 Changeset [20348] by bdakin

Reviewed by Geoff.

Covered by existing test case.

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

This removes some code that was added with ​http://bugs.webkit.org/
show_bug.cgi?id=8360. This code was not needed to fix that bug, but
the idea behind it was that there are times when it is safe for
scheduleEvent() to propagate the event immediately. The
MallocScribble crash revealed that this assumption was a bit too
broad; the cause of the crash was that we were propagating events
immediately when it was not safe. Mitz and I discussed this online
and we agree that the safest solution is to revert to the old
behavior here, and always delay the propagation of the event.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
12:56 Changeset [20347] by beidson

Reviewed by John Sullivan

Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
12:09 Changeset [20346] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

  • editing/pasteboard/5071074-2-expected.checksum: Added.
  • editing/pasteboard/5071074-2-expected.png: Added.
  • editing/pasteboard/5071074-2-expected.txt: Added.
  • editing/pasteboard/5071074-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions


moveParagraphs calls createMarkup without annotation, which leaves
out anchor elements that aren't fully selected.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): We don't want createMarkup to do full annotation here. Doing so could include special ancestor blocks, which would prevent the copied content from appearing in the destination paragraph when it's re-inserted. Annotation would also inline styles from style sheets, which is unnecessary because the content is being moved to the same document it's being moved from. Added a new bool to createMarkup that when true allows markup for special ancestors as long as they are inline when annotation is off.
  • editing/markup.cpp: (WebCore::createMarkup): Don't set specialCommonAncestor if annotation is off, unless it's inline and we've been told it's ok to include such elements.
  • editing/markup.h:
11:48 Changeset [23137] by aroben

Reviewed by Ada.

Added null-checks for ResourceHandle::cookieStorage() before passing it
into CFNetwork functions, which are not null-safe.

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
11:20 Changeset [23136] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).
10:21 Changeset [20345] by ap

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12497
Implement XPath result ordering.

WebCore:

XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
to sort itself, and can remember whether it has been already sorted.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added XPathNodeSet files.
  • xml/XPathExpression.cpp: Fixed includes.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted. (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunCount::evaluate): Ditto. (WebCore::XPath::FunSum::evaluate): Ditto.
  • xml/XPathNodeSet.cpp: Added. (WebCore::XPath::parentWithDepth): (WebCore::XPath::sortBlock): (WebCore::XPath::NodeSet::sort): Sort the node-set in document order. (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as parent or ancestor sorted). (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently implemented via fully sorting the node-set, but this can obviously be optimized. (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().


  • xml/XPathNodeSet.h: Added. (WebCore::XPath::NodeSet::NodeSet): (WebCore::XPath::NodeSet::operator=): (WebCore::XPath::NodeSet::size): (WebCore::XPath::NodeSet::isEmpty): (WebCore::XPath::NodeSet::operator[]): (WebCore::XPath::NodeSet::reserveCapacity): (WebCore::XPath::NodeSet::clear): (WebCore::XPath::NodeSet::swap): (WebCore::XPath::NodeSet::append): (WebCore::XPath::NodeSet::markSorted): (WebCore::XPath::NodeSet::isSorted): Most of these methods just call Vector counterparts.
  • xml/XPathParser.cpp: Updated the copyright notice.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::Path::evaluate): Ditto. (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function always marks the result as unsorted, because it is hard to tell whether a step breaks node order. Identifying and implementing special cases when it is not necessary to do so is an important future optimization.
  • xml/XPathPath.h: Replacing NodeVector with NodeSet.
  • xml/XPathPredicate.cpp: (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet. (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just marks the result as unordered; we can consider using merge sort to avoid this.
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet. (WebCore::XPathResult::singleNodeValue): Ditto. (WebCore::XPathResult::snapshotLength): Ditto. (WebCore::XPathResult::iterateNext): Ditto. (WebCore::XPathResult::snapshotItem): Ditto. (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.
  • xml/XPathResult.h: Replacing NodeVector with NodeSet.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too. (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an attribute context node. (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
  • xml/XPathStep.h: Ditto.
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child nodes, so passing such node as a context could cause problems.
  • xml/XPathUtil.h: Removed NodeVector typedef.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::Value): (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::Value::): (WebCore::XPath::Value::isNodeSet): Replacing NodeVector with NodeSet.

LayoutTests:

  • fast/xpath/document-order-expected.txt: Added.
  • fast/xpath/document-order.html: Added.
  • fast/xpath/text-nodes-expected.txt:
  • fast/xpath/text-nodes.html:
  • fast/xpath/4XPath/Core/test_step-expected.txt: Updated results for tests that now pass.
  • fast/xpath/xpath-test-pre.js: Added.
  • fast/xpath/4XPath/Core/test.js: Moved checkSnapshot() to a separate file.
  • fast/xpath/4XPath/Core/test_core_functions.html:
  • fast/xpath/4XPath/Core/test_location_path.html:
  • fast/xpath/4XPath/Core/test_nodeset_expr.html:
  • fast/xpath/4XPath/Core/test_parser.html:
  • fast/xpath/4XPath/Core/test_predicate_list.html:
  • fast/xpath/4XPath/Core/test_step.html: Load xpath-test-pre.js for checkSnapshot().
09:44 Open Source Contributors created by ddkilzer@webkit.org
Initial page with fake contributor.
09:37 WikiStart edited by ddkilzer@webkit.org
Added link to page for open source contributors. (diff)
08:18 Changeset [20344] by bdash

2007-03-21 Mark Rowe <​mrowe@apple.com>

Build fix.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]):
08:11 Changeset [20343] by bdash

2007-03-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13129.
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

Some cross-language scripting bridges use the presence of -(int)count to determine
whether to treat objects as sequence-like. All WebScriptObject's exposed this method
which lead to non-collection WebScriptObject's being mishandled by PyObjC. We now
expose -count only when the object we wrap looks like a collection from a JavaScript
point of view (eg, it has a length property).

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _shouldRespondToCount]): (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]): (-[WebScriptObject _count]):
  • bindings/objc/WebScriptObjectPrivate.h:
07:51 Changeset [20342] by darin
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Fix obvious typo in the change from last night -- forgot to assign to the variable.
04:51 Changeset [23135] by andersca

WebKitWin:

Reviewed by Adam.

<rdar://problem/5050512>
Need invalid/expired certificate alerts


Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it
call down to WebCore.


  • Interfaces/IWebMutableURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
  • WebMutableURLRequest.h:
04:24 Changeset [23134] by aroben

Reviewed by Oliver.

Made the metrics of styled selects match those on the Mac to get
fast/forms/001.html passing.

04:22 Changeset [23133] by aroben

Rubberstamped by Anders.

Workaround a CFNetwork crash that affects DRT.

  • WebView.cpp: (WebView::initWithFrame): Commented out cookie storage initialization.
03:27 Changeset [23132] by aroben

Build fix.

  • WebView.cpp: Added missing #include.
03:18 Changeset [23131] by aroben

Build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Fix typo.
03:14 Changeset [23130] by aroben

WebKitToolsWin:

Reviewed by Oliver.

Implemented layoutTestController.setTabKeyCyclesThroughElements() to
fix fast/events/keypress-insert-tab.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Removed unnecessary string comparison.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setTabKeyCyclesThroughElementsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented [set]TabKeyCyclesThroughElements.

  • Interfaces/IWebViewPrivate.idl: Added new declarations.
  • WebView.cpp: (WebView::setTabKeyCyclesThroughElements): Implemented. (WebView::tabKeyCyclesThroughElements): Implemented.
  • WebView.h: Updated.
02:45 Changeset [23129] by aroben

Reviewed by Oliver.

Implemented layoutTestController.clearBackForwardList() to fix
fast/dom/location-hash.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (clearBackForwardListCallback): Implemented.
02:13 Changeset [23128] by hyatt

Land advanced text ( turned off )

02:12 Changeset [23127] by hyatt

Land advanced text ( turned off )

02:11 Changeset [23126] by andersca

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

  • platform/network/cf/ResourceHandleCFNet.cpp:


(WebCore::willSendRequest):
(WebCore::willCacheResponse):
Remove FIXMEs.


(WebCore::makeFinalRequest):
New function that makes a final CFURLRequest depending on cookie policy and whether any
invalid SSL certificates should be ignored.


(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Use makeFinalRequest.


(WebCore::ResourceHandle::cookieStorageAcceptPolicy):
(WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
(WebCore::ResourceHandle::cookieStorage):
(WebCore::ResourceHandle::setCookieStorage):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
New functions for setting cookie policy, the deafult cookie storage and whether invalid
SSL certificates should result in an error.


  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set cookie storage, cookie policy and SSL properties.
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Use same functions as the mac (sorta).


(WebCore::cookiesEnabled):
Implement this.

WebKitWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable


  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Update the cookie storage accept policy.


(WebView::initWithFrame):
Initialize the cookie storage.

02:11 Changeset [20341] by hyatt

Refactor fonts a bit for portability.

02:06 Changeset [23125] by aroben

Reviewed by Oliver.

Remove Arial fonts because of <rdar://problem/5074441>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Don't install Arial.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial.ttf: Removed.
02:04 Changeset [20340] by aroben

Reviewed by Adam.

Stub out a couple of CFNetwork backend functions.


  • platform/network/ResourceHandle.h:
01:19 Changeset [23124] by oliver

2007-03-20 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.


Removing mouseover-mouseout2.html from skip list

  • Skipped:
01:10 Changeset [20339] by oliver

2007-03-19 Oliver Hunt <​oliver@apple.com>

Reviewed by Ada.

Protect against possibility of JS detaching a frame (and losing its view)
midway through a mouse move.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):


00:39 Changeset [23123] by aroben

Reviewed by Ada.

  • Skipped: Added more international text tests, plus those that use textInputController.

03/19/07:

23:56 Changeset [23122] by aroben

Reviewed by Ada.

  • Skipped: Added tests that relay on DRT's built-in plugin, or on the QuickTime WebKit plugin.
22:58 Changeset [20338] by ap

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=13107
XPath should raise an exception when trying to parse an unknown function

Test: fast/xpath/invalid-functions.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
  • xml/XPathGrammar.y: Handle nulls returned from createFunction().
22:47 Changeset [23121] by aroben

LayoutTestsWin:

Reviewed by Ada.

  • Skipped: Added some more international text tests.

WebKitToolsWin:

Reviewed by Ada.

Made DRT output UTF8 strings.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Convert to UTF8 before printing.
21:01 Changeset [23120] by aroben

Reviewed by Geoff.

Added support for --threaded.

Note that this always crashes right now due to
<rdar://problem/5051141> JavaScriptCore is not thread-safe,
but that's why we need this feature!

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed NULL to 0. (runTest): Ditto. (pthread_equal): Added. (javaScriptThreads): Ported from Mac. (runJavaScriptThread): Ditto. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Parse --threaded argument and start/stop threads if needed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link against pthreadVC2.lib, and added include/pthreads to the include path.
19:45 Changeset [20337] by andersca

Reviewed by Dave Hyatt.

<rdar://problem/5067983>
iSale: Crash occurs at WebFrameLoaderClient::dispatchDecidePolicyForMIMEType() when attempting to load a HTML template


Restore old behavior (broke in r14533) where the resource load and download delegates are retained for as long as the
data source is loading.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::decreaseLoadCount):
18:05 Changeset [20336] by darin
  • kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do it right later.
17:50 Changeset [20335] by ggaren

Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
documentation says "non-zero," not "1."

  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread):
17:46 Changeset [20334] by ggaren

Reviewed by John Sullivan.

Fixed <rdar://problem/5073380> REGRESSION: Crash occurs at WTF::fastFree()
when reloading liveconnect page (applet)


Best to use free when you use malloc, especially when malloc and delete
use completely different libraries.

  • bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod):
17:30 Changeset [20333] by adele

LayoutTests:

Reviewed by Beth.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

  • fast/forms/radio_checked_name-expected.txt: Added.
  • fast/forms/radio_checked_name.html: Added.

WebCore:

Reviewed by Beth.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

Test: fast/forms/radio_checked_name.html

We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still
allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name attribute, since we setChecked will now work with unnamed radio buttons. (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment. (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here. (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons. (WebCore::HTMLInputElement::defaultEventHandler): ditto.
17:27 Changeset [20332] by aroben

Rubberstamped by Oliver.

  • bridge/JavaScriptStatistics.cpp: Added missing header for correctness.
17:16 Changeset [20331] by andrew

JavaScriptCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

JavaScriptGlue:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebKit.xcodeproj/project.pbxproj:
17:13 Changeset [23119] by aroben

Build fix.

  • WebKit.vcproj/WebKitGUID.vcproj:
16:50 Changeset [20330] by darin

Reviewed by Geoff.

  • Changed list size threshold to 5 based on testing.

I was testing the i-Bench JavaScript with the list statistics
dumping on, and discovered that there were many 5-element lists.
The fast case for lists was for 4 elements and fewer. By changing
the threshold to 5 elements we get a measurable speedup. I believe
this will help real web pages too, not just the benchmark.

  • kjs/list.cpp: Change constant from 4 to 5.
16:36 Changeset [23118] by aroben

WebCoreWin:

Reviewed by Anders and Darin.

Added JavaScriptStatistics to the project for
<rdar://problems/5071653>.

  • WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include path, and added JavaScriptStatistics.(cpp|h).

WebKitToolsWin:

Reviewed by Anders and Darin.

Fix <rdar://problem/5071653> DumpRenderTree needs to be able to
trigger GC on a separate thread

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added GCController.(cpp|h) to the project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Added. (collectCallback): (collectOnAlternateThreadCallback): (getJSObjectCountCallback): (getClass): (makeGCController):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Add the GCController to the window object.

WebKitWin:

Reviewed by Anders and Darin.

Added WebJavaScriptCollector for <rdar://problems/5071653>.

  • Interfaces/IWebJavaScriptCollector.idl: Added.
  • Interfaces/WebKit.idl:
  • WebJavaScriptCollector.cpp: Added. (WebJavaScriptCollector::WebJavaScriptCollector): (WebJavaScriptCollector::~WebJavaScriptCollector): (WebJavaScriptCollector::createInstance): (WebJavaScriptCollector::QueryInterface): (WebJavaScriptCollector::AddRef): (WebJavaScriptCollector::Release): (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
  • WebJavaScriptCollector.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added cases for WebJavaScriptCollector.
  • WebKitDLL.cpp: (DllGetClassObject): Ditto.
16:28 Changeset [20329] by darin
  • kjs/value.h: Oops, fix build.
16:12 Changeset [20328] by darin

Reviewed by Geoff.

  • remove ~JSValue; tiny low-risk performance boost
  • kjs/value.h: Remove unneeded empty virtual destructor from JSValue. The only class derived from JSValue is JSCell and it already has a virtual destructor. Declaring an empty constructor in JSValue had one good effect: it marked the destructor private, making it a compile time error to try to destroy a JSValue; but that's not a likely mistake for someone to make. It had two bad effects: (1) it caused gcc, at least, to generate code to fix up the virtual table pointer to point to the JSValue version of the virtual table inside the destructor of all classes derived from JSValue directly or indirectly; (2) it caused JSValue to be a polymorphic class so required a virtual table for it. It's cleaner to not have either of those.
15:54 Changeset [20327] by darin
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
15:39 Changeset [20326] by justing

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text

  • editing/pasteboard/5071074-expected.checksum: Added.
  • editing/pasteboard/5071074-expected.png: Added.
  • editing/pasteboard/5071074-expected.txt: Added.
  • editing/pasteboard/5071074.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text


We stopped adding markup for all commonAncestorBlocks
and the ancestors of lastClosed up to them because it
was adding a lot of unnecessary markup.

  • editing/markup.cpp: (WebCore::createMarkup): Also include markup for nodes up to an enclosing anchor. Cleaned up the code for including special common ancestors a bit.
14:39 Changeset [23117] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set the include path for release to the same as for debug.
13:22 Changeset [23116] by aroben

Reviewed by Adele.

Fix eventSender.keyDown() to create WM_CHAR messages as well, since these
are needed by WebCore.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (dispatchMessage): Added. (mouseDownCallback): Call dispatchMessage instead of DispatchMessage. (doMouseUp): Ditto. (mouseClickCallback): Ditto. (doMouseMove): Ditto. (keyDownCallback): Ditto.
12:41 Changeset [20325] by zimmermann

Reviewed by Lars Knoll.

Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.

12:31 Changeset [20324] by adele

Reviewed by Hyatt.

  • page/Frame.cpp: (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout if not adjusting view size. (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree layout instead of just whether the root needs layout.
12:28 Changeset [20323] by zimmermann

Reviewed by Maciej.

Make JS function calls on POD-types (ie. SVGLength) take effect.
Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.

This worked fine before we switched to SVGLength POD type, so this
can be considered as P1 regression fix.

Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
doesn't work as expected - needs a seperated fix.

12:07 Changeset [23115] by aroben

Reviewed by Maciej.

Skip tests with international text due to <rdar://problems/4516194>.

  • Skipped:
11:21 Changeset [20322] by adele

Reviewed by Adam.

Adding comments and a little cleanup from my last checkin.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert. Added comment about how we use onChange. (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange. (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto. (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true. (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false. (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.
11:14 JavaScript and DOM Benchmarks edited by timothy@apple.com
(diff)
09:57 Changeset [20321] by zimmermann

Reviewed by Maciej.

Import Hixie's SVG testsuite. It highlights one bug, one regression in JS and one crash.
The crashing file is marked with "-disabled", the broken ones with "-broken".

Landing fixes for the certain bugs/regressions seperated.

06:17 Changeset [20320] by sullivan

Reviewed by Justin


  • fixed <rdar://problem/5071238> REGRESSION: opt-cmd-B to show Bookmarks view does nothing when form field has focus
  • WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): we were counting any set of modifiers plus 'b' as the standard key equivalent for toggling Bold; now we only accept command+'b'
05:46 Changeset [20319] by bdash

2007-03-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

Test: fast/innerHTML/additional-inline-style.html

  • editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

  • editing/pasteboard/paste-table-002-expected.txt:
  • fast/innerHTML/additional-inline-style-expected.txt: Added.
  • fast/innerHTML/additional-inline-style.html: Added.
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:
02:32 Changeset [23114] by aroben

Reviewed by Hyatt.

Implemented some more layoutTestController methods:

  • display
  • testRepaint
  • repaintSweepHorizontally

The last two don't have any effect yet because we don't support pixel
tests yet (<rdar://problem/5071708>).

This gets all but one test in fast/repaint passing, and fixes various
other tests that use these methods as well.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (displayCallback): Implemented. (testRepaintCallback): Implemented. (repaintSweepHorizontallyCallback): Implemented.
01:19 Changeset [20318] by zack

compile fix for qt

01:00 Changeset [20317] by aroben

WebCore:

Reviewed by Hyatt and Maciej.

Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
part of <rdar://problem/5071653>.

All layout tests pass.

  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • bridge/JavaScriptStatistics.cpp: Moved from bridge/mac/WebCoreJavaScript.mm, and converted to C++. (WebCore::collect): (WebCore::JavaScriptStatistics::objectCount): (WebCore::JavaScriptStatistics::interpreterCount): (WebCore::JavaScriptStatistics::protectedObjectCount): (WebCore::JavaScriptStatistics::rootObjectTypeCounts): (WebCore::JavaScriptStatistics::garbageCollect): (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread): (WebCore::JavaScriptStatistics::shouldPrintExceptions): (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
  • bridge/JavaScriptStatistics.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Removed.
  • bridge/mac/WebCoreJavaScript.mm: Removed.

WebKit:

Reviewed by Hyatt and Maciej.

Updated WebCoreStatistics for the conversion of WebCoreJavaScript to
C++.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptInterpretersCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): Moved conversion to NSCountedSet here from WebCore. (+[WebCoreStatistics garbageCollectJavaScriptObjects]): (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThread:]): (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
00:49 Changeset [23113] by aroben

Build fix.

  • Interfaces/IWebView.idl:
00:40 Changeset [20316] by hyatt

Update SVG tests now that painting happens after onload.

00:36 Changeset [20315] by hyatt

Update tests for minimum font size change.

00:35 Changeset [20314] by hyatt

Update tests for minimum font size change.

00:34 Changeset [20313] by hyatt

Update tests for minimum font size change.

00:34 Changeset [20312] by hyatt

Update tests for minimum font size change.

00:32 Changeset [20311] by hyatt

Update the minimum font size pref to match the actual default setting in Safari. It should have been 1
all this time and not 9.

Reviewed by aroben

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree):

03/18/07:

23:52 Changeset [23112] by aroben

WebKitToolsWin:

Reviewed by Hyatt.

Fix DRT part of <rdar://problem/5066482> DumpRenderTree on Windows
doesn't dump editing callbacks

However, we still don't dump anything because of
<rdar://problem/5071598>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize shouldDumpEditingCallbacks. (main): Set the WebView's editing delegate.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added EditingDelegate.(cpp|h) to the project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Added. (EditingDelegate::EditingDelegate): (EditingDelegate::QueryInterface): (EditingDelegate::AddRef): (EditingDelegate::Release): (dumpPath): (dump): (EditingDelegate::shouldBeginEditingInDOMRange): (EditingDelegate::shouldEndEditingInDOMRange): (EditingDelegate::shouldInsertNode): (EditingDelegate::shouldInsertText): (EditingDelegate::shouldDeleteDOMRange): (EditingDelegate::shouldChangeSelectedDOMRange): (EditingDelegate::shouldApplyStyle): (EditingDelegate::shouldChangeTypingStyle): (EditingDelegate::doPlatformCommand): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Added. (EditingDelegate::setAcceptsEditing): (EditingDelegate::undoManagerForWebView):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpEditingCallbacksCallback): Ported from Mac. (setAcceptsEditingCallback): Ditto.

WebKitWin:

Reviewed by Hyatt.

Implemented getting/setting of the editing delegate (we don't actually
use it for anything yet, though. See <rdar://problem/5071598>).

  • Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate to IWebEditingDelegate to match our other delegates.
  • Interfaces/IWebView.idl: Updated for rename.
  • WebView.cpp: (WebView::setEditingDelegate): Implemented. (WebView::editingDelegate): Ditto.
  • WebView.h: Updated for rename.
22:43 Changeset [20310] by mjs

JavaScriptCore:

Reviewed by Mark.


  • avoid static construction (and global variable access) in a smarter, more portable way, to later enable MUTLI_THREAD mode to work on other platforms and compilers.


  • kjs/CommonIdentifiers.cpp: Added. New class to hold all the shared identifiers. (KJS::CommonIdentifiers::CommonIdentifiers): (KJS::CommonIdentifiers::shared):
  • kjs/CommonIdentifiers.h: Added.
  • kjs/ExecState.h: (KJS::ExecState::propertyNames): Hand the CommonIdentifiers instance here for easy access. (KJS::ExecState::ExecState):
  • API/JSObjectRef.cpp: (JSObjectMakeConstructor):
  • CMakeLists.txt:
  • JavaScriptCore.exp:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • bindings/runtime_array.cpp: (RuntimeArray::getOwnPropertySlot): (RuntimeArray::put):
  • bindings/runtime_method.cpp: (RuntimeMethod::getOwnPropertySlot):
  • kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayInstance::put): (ArrayInstance::deleteProperty): (ArrayProtoFunc::ArrayProtoFunc): (ArrayProtoFunc::callAsFunction): (ArrayObjectImp::ArrayObjectImp):
  • kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype): (BooleanProtoFunc::BooleanProtoFunc): (BooleanProtoFunc::callAsFunction): (BooleanObjectImp::BooleanObjectImp):
  • kjs/completion.h: (KJS::Completion::Completion):
  • kjs/date_object.cpp: (KJS::DateProtoFunc::DateProtoFunc): (KJS::DateObjectImp::DateObjectImp): (KJS::DateObjectFuncImp::DateObjectFuncImp):
  • kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): (ErrorProtoFunc::ErrorProtoFunc): (ErrorProtoFunc::callAsFunction): (ErrorObjectImp::ErrorObjectImp): (ErrorObjectImp::construct): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp): (NativeErrorImp::construct): (NativeErrorImp::callAsFunction):
  • kjs/function.cpp: (KJS::FunctionImp::getOwnPropertySlot): (KJS::FunctionImp::put): (KJS::FunctionImp::deleteProperty): (KJS::FunctionImp::getParameterName): (KJS::DeclaredFunctionImp::construct): (KJS::IndexToNameMap::unMap): (KJS::Arguments::Arguments): (KJS::ActivationImp::getOwnPropertySlot): (KJS::ActivationImp::deleteProperty): (KJS::GlobalFuncImp::GlobalFuncImp):
  • kjs/function_object.cpp: (FunctionPrototype::FunctionPrototype): (FunctionProtoFunc::FunctionProtoFunc): (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::FunctionObjectImp): (FunctionObjectImp::construct):
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/identifier.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::init): (KJS::Interpreter::initGlobalObject):
  • kjs/interpreter.h:
  • kjs/lookup.h:
  • kjs/math_object.cpp: (MathFuncImp::MathFuncImp):
  • kjs/nodes.cpp: (ArrayNode::evaluate): (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
  • kjs/number_object.cpp: (NumberPrototype::NumberPrototype): (NumberProtoFunc::NumberProtoFunc): (NumberObjectImp::NumberObjectImp):
  • kjs/object.cpp: (KJS::JSObject::put): (KJS::JSObject::defaultValue): (KJS::JSObject::hasInstance):
  • kjs/object.h: (KJS::JSObject::getOwnPropertySlot):
  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): (ObjectProtoFunc::ObjectProtoFunc): (ObjectObjectImp::ObjectObjectImp):
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): (RegExpProtoFunc::RegExpProtoFunc): (RegExpObjectImp::RegExpObjectImp):
  • kjs/string_object.cpp: (KJS::StringInstance::getOwnPropertySlot): (KJS::StringInstance::put): (KJS::StringInstance::deleteProperty): (KJS::StringPrototype::StringPrototype): (KJS::StringProtoFunc::StringProtoFunc): (KJS::StringProtoFunc::callAsFunction): (KJS::StringObjectImp::StringObjectImp): (KJS::StringObjectFuncImp::StringObjectFuncImp):
  • kjs/testkjs.cpp: (TestFunctionImp::TestFunctionImp):

WebCore:

Reviewed by Mark.

  • avoid static construction (and global variable access) in a smarter, more portable way, to later enable MUTLI_THREAD mode to work on other platforms and compilers.


  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBaseFunction::JSHTMLInputElementBaseFunction):
  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::HTMLElementFunction): (KJS::JSHTMLCollection::getOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
22:41 Changeset [23111] by hyatt

Fix the CSS2 system font for 'menu' to match Mac. Makes the system fonts layout test pass.

22:28 Changeset [23110] by aroben

Reviewed by Hyatt.

Changed the file upload button to say "Choose File" to match Mac.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::fileButtonChooseFileLabel):
22:05 Changeset [20309] by andrew

JavaScriptCore:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

JavaScriptGlue:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Mark Rowe

Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Mark Rowe


Set Xcode editor to use 4 space indentation (​http://webkit.org/coding/coding-style.html)

  • WebKit.xcodeproj/project.pbxproj:
21:57 Changeset [20308] by hyatt

land update results for frame pixel changes.

21:53 Changeset [20307] by hyatt

Land updated results for frames pixel tests.

21:53 Changeset [20306] by hyatt

Add layout test for frame borders case.

21:50 Changeset [20305] by hyatt

Fix for REGRESSION bug 13108, frame borders being painted when they shouldn't be. Rework both frame borders
and resizing to be more like other browsers.

Reviewed by ggaren

fast/frames/no-frame-borders.html

  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::HTMLFrameElement): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::parseMappedAttribute):
  • html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::hasFrameBorder):
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): (WebCore::HTMLFrameElementBase::parseMappedAttribute):
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasFrameBorder):
  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::HTMLIFrameElement):
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::edgeInfo):
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): (WebCore::RenderFrameSet::GridAxis::resize): (WebCore::RenderFrameSet::fillFromEdgeInfo): (WebCore::RenderFrameSet::computeEdgeInfo): (WebCore::RenderFrameSet::edgeInfo): (WebCore::RenderFrameSet::layout): (WebCore::RenderFrameSet::startResizing): (WebCore::RenderFrameSet::continueResizing): (WebCore::RenderFrameSet::canResizeRow): (WebCore::RenderFrameSet::canResizeColumn): (WebCore::RenderFrameSet::splitPosition): (WebCore::RenderFrameSet::hitTestSplit): (WebCore::RenderFrameSet::dump):
  • rendering/RenderFrameSet.h: (WebCore::): (WebCore::FrameEdgeInfo::FrameEdgeInfo): (WebCore::FrameEdgeInfo::preventResize): (WebCore::FrameEdgeInfo::allowBorder): (WebCore::FrameEdgeInfo::setPreventResize): (WebCore::FrameEdgeInfo::setAllowBorder):
21:32 Changeset [20304] by bdash

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction):
  • kjs/grammar.y:
  • kjs/keywords.table:
  • kjs/lexer.cpp: (KJS::Lexer::shift):

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • ChangeLog:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • manual-tests/ATSU-bad-layout.html:
  • manual-tests/accidental-strict-mode.html:
  • manual-tests/applet-param-no-name.html:
  • manual-tests/bidi-parens.html:
  • manual-tests/bugzilla-3855.html:
  • manual-tests/bugzilla-4840.html:
  • manual-tests/bugzilla-6821.html:
  • manual-tests/containing-block-position-chage.html:
  • manual-tests/contenteditable-link.html:
  • manual-tests/css3-cursor-fallback-quirks.html:
  • manual-tests/css3-cursor-fallback-strict.html:
  • manual-tests/custom-cursors.html:
  • manual-tests/dictionary-scrolled-iframe.html:
  • manual-tests/dom-manipulation-on-resize.html:
  • manual-tests/drag-image-to-address-bar.html:
  • manual-tests/empty-link-target.html:
  • manual-tests/empty-title-popup.html:
  • manual-tests/first-line-style-crash.html:
  • manual-tests/invalid-mouse-event.html:
  • manual-tests/left-overflow-repaint.html:
  • manual-tests/linkjump-3.html:
  • manual-tests/log-keypress-events.html:
  • manual-tests/named-window-blank-target.html:
  • manual-tests/plain-text-paste.html:
  • manual-tests/plugin-controller-datasource.html:
  • manual-tests/pre-tab-selection-rect.html:
  • manual-tests/redirection-target.html:
  • manual-tests/redraw-page-cache-visited-links.html:
  • manual-tests/reset-initiatedDrag.html:
  • manual-tests/resources/named-window-blank-target-step2.html:
  • manual-tests/resources/named-window-blank-target-step3.html:
  • manual-tests/resources/named-window-blank-target-step4.html:
  • manual-tests/resources/redraw-page-cache-visited-links-2.html:
  • manual-tests/scrollbar-hittest.html:
  • manual-tests/scrollbar-hittest2.html:
  • manual-tests/subview-click-assertion.html:
  • manual-tests/tabbing-input-google.html:
  • manual-tests/text-field-autoscroll.html:
  • manual-tests/textarea-after-stylesheet-link.html:
  • manual-tests/textarea-focus.html:
  • manual-tests/whitespace-pre-affinity.html:

2007-03-19 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Brady.

Update references to bugzilla.opendarwin.org with bugs.webkit.org.

  • WebInspector/webInspector/inspector.css:
  • WebView/WebHTMLView.mm: (-[WebHTMLView firstRectForCharacterRange:]):
  • WebView/WebView.mm: (-[WebView initWithFrame:frameName:groupName:]):
20:36 Changeset [23109] by aroben

Rubberstamped by Maciej.

  • Skipped: Added another crasher.
20:01 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
19:34 Changeset [20303] by mjs

Added a random JS benchmark.

  • misc/morph.html: Added.
19:18 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
19:14 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
19:11 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
18:53 Changeset [23108] by ggaren

Reviewed by Oliver Hunt.

Fixed <rdar://problem/5061807> STRESS (2): Crash in PlatformScrollbar::setRect

No test case because I can't seem to get the Windows DRT to cooperate. I'll try again tomorrow.

The problem was that the FrameView would try to reset the document's scrollbars after having
been removed from the page, so its page pointer would be NULL. Added NULL checks.

This situation ultimately results from the FrameView's non-trivial destructor, which
creates a fragile dependency on tear-down timing. It looks like the timing on Windows
is slightly different from the timing on Mac. I didn't see any obvious resulting bugs,
though, so the NULL checks should be sufficient for now.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
18:50 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
18:50 Changeset [20302] by bdash

Roll out r20297, fix for ​http://bugs.webkit.org/show_bug.cgi?id=13091, as it causes regressions in layout tests.

18:40 Changeset [20301] by weinig

Reviewed by Mark.

Update results after Hyatt's patch in r20268.

  • tables/mozilla/bugs/bug137388-2-expected.checksum:
  • tables/mozilla/bugs/bug137388-2-expected.png:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.checksum:
  • tables/mozilla/bugs/bug137388-3-expected.png:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.checksum:
  • tables/mozilla/bugs/bug50695-2-expected.png:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
18:32 Changeset [23107] by aroben

LayoutTestsWin:

Reviewed by Geoff.

  • Skipped: Added a new crasher.

WebKitToolsWin:

Reviewed by Geoff.

Added a basic implementation of eventSender. It supports mouse and key
events.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Added. (DraggingInfo::DraggingInfo): (DraggingInfo::~DraggingInfo): (DraggingInfo::dataObject): (DraggingInfo::dropSource):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Made the WebView's HWND a global so that EventSender can access it.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files to project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Added. (getDragModeCallback): (setDragModeCallback): (leapForwardCallback): (currentEventTime): (makeMsg): (mouseDownCallback): (pointl): (doMouseUp): (mouseUpCallback): (mouseClickCallback): (doMouseMove): (mouseMoveToCallback): (replaySavedEvents): (keyDownCallback): (getClass): (makeEventSender):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Re-ordered #includes.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Changed #include to forward declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Make the eventSender available. (WaitUntilDoneDelegate::doDragDrop): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Geoff.

Added IWebFramePrivate::layout to support eventSender in DRT.

Made IWebView inherit from IDropTarget to match Mac, and added
IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.

  • Interfaces/IWebFramePrivate.idl: Added layout().
  • Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
  • Interfaces/IWebView.idl: Added inheritance from IDropTarget.
  • WebDragClient.cpp: (WebDragClient::startDrag): Call the UI delegate if possible, otherwise fallback to OLE's DoDragDrop.
  • WebFrame.cpp: (WebFrame::layout): Implemented.
  • WebFrame.h:
  • WebView.h:
18:01 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
17:59 JavaScript and DOM Benchmarks created by mjs@apple.com
17:59 WikiStart edited by mjs@apple.com
(diff)
17:39 Changeset [20300] by kjk

Not reviewed - gdk build fix.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::update): add a stub
17:37 Changeset [20299] by beidson

Reviewed by Hyatt

​http://bugs.webkit.org/show_bug.cgi?id=13111
When stopped a load before it completes, partial images become the
broken image icon

  • loader/loader.cpp: (WebCore::Loader::didFail): Split off into a method that knows the difference between failed and cancelled. If a load is cancelled, don't call error() on the object - only remove it from the cache (WebCore::Loader::cancelRequests): Call didFail(loader, true)
  • loader/loader.h: Added didFail(SubresourceLoader*, bool cancelled)
16:42 Changeset [20298] by bdash

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

Test: fast/forms/input-text-word-wrap.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Force the inner block to 'word-wrap:normal'.

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adele.

  • fast/forms/input-text-word-wrap-expected.checksum: Added.
  • fast/forms/input-text-word-wrap-expected.png: Added.
  • fast/forms/input-text-word-wrap-expected.txt: Added.
  • fast/forms/input-text-word-wrap.html: Added.
16:40 Changeset [20297] by bdash

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

Test: fast/innerHTML/additional-inline-style.html

  • editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Tim Hatcher.

  • editing/pasteboard/paste-table-002-expected.txt:
  • fast/innerHTML/additional-inline-style-expected.txt: Added.
  • fast/innerHTML/additional-inline-style.html: Added.
16:25 Changeset [20296] by bdash

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

Add checking for NULL interpreter before throwing exception.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]):

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

DumpRenderTree changes for ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

Add tests to ensure that a plugin can safely throw an exception in dealloc.

  • DumpRenderTree/ObjCPlugin.h:
  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin webScriptNameForKey:]): (+[ObjCPlugin isKeyExcludedFromWebScript:]): (-[ObjCPlugin dealloc]):

2007-03-18 Dan Waylonis <​waylonis@mac.com>

Reviewed by Tim Hatcher.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=13005
Bug 13005: WebScriptObject +throwException needs NULL check.

A plugin that throws on dealloc can crash WebKit.

  • plugins/throw-on-dealloc-expected.txt: Added.
  • plugins/throw-on-dealloc.html: Added.
16:02 Changeset [20295] by ggaren

JavaScriptCore:

Reviewed by Oliver Hunt.


Exposed some extra toUInt32 functionality, as part of the fix for
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)

LayoutTests:

Reviewed by Oliver Hunt.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=13106
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)

  • fast/dom/collection-null-like-arguments-expected.txt: Added.
  • fast/dom/collection-null-like-arguments.html: Added.

WebCore:

Reviewed by Oliver Hunt.


Fixed ​http://bugs.webkit.org/show_bug.cgi?id=13106
REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
(Style Change Through JavaScript Blanks Content)


When indexing into collections, treat the empty string as an invalid argument,
instead of the number 0.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLCollection::getOwnPropertySlot): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
11:42 Changeset [23106] by sfalken

Bump version for submit

11:39 Changeset [20294] by sfalken

New tag.

11:10 Changeset [20293] by ggaren

Removed duplicate export name.


11:07 Changeset [20292] by ggaren

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/5064964> Repro ASSERT failure in JS Bindings when
closing window @ lowtrades.bptrade.com


Unfortunately, the bindings depend on UString and Identifier as string
representations. So, they need to acquire the JSLock when doing something
that will ref/deref their strings.

Layout tests, the original site, and Java, Flash, and Quicktime on the
web work. No leaks reported. No automated test for this because testing
the Java bindings, like math, is hard.


  • bindings/runtime.h: Made Noncopyable, just to be sure.


  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::~CClass): Acquire the JSLock and explicitly clear the keys in our hashtable, since they're UString::Reps, and ref/deref aren't thread-safe. (KJS::Bindings::CClass::methodsNamed): Also acquire the JSLock when adding keys to the table, since the table ref's them. (KJS::Bindings::CClass::fieldNamed): ditto.
  • bindings/c/c_utility.cpp: Removed dead function. (KJS::Bindings::convertValueToNPVariant): Acquire the JSLock because doing it recursively is pretty cheap, and it's just too confusing to tell whether all our callers do it for us. (KJS::Bindings::convertNPVariantToValue): ditto
  • bindings/c/c_utility.h:
  • bindings/jni/jni_class.cpp: Same deal as c_class.cpp. (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_instance.cpp: Same deal as c_utility.cpp. (JavaInstance::stringValue):
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod): Moved from header, for clarity. (appendClassName): Made this static, so the set of callers is known, and we can assert that we hold the JSLock. Also changed it to take a UString reference, which makes the calling code simpler. (JavaMethod::signature): Store the ASCII value we care about instead of a UString, since UString is so much more hassle. Hold the JSLock while building up the temporary UString.
  • bindings/jni/jni_runtime.h: Nixed dead code in JavaMethod. (KJS::Bindings::JavaString::JavaString): Hold a UString::Rep instead of a UString, so we can acquire the JSLock and explicitly release it. (KJS::Bindings::JavaString::_commonInit): (KJS::Bindings::JavaString::~JavaString): (KJS::Bindings::JavaString::UTF8String): (KJS::Bindings::JavaString::uchars): (KJS::Bindings::JavaString::length): (KJS::Bindings::JavaString::ustring):
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::convertArrayInstanceToJavaArray): Made this static, so the set of callers is known, and we can assert that we hold the JSLock. (KJS::Bindings::convertValueToJValue): Acquire the JSLock because doing it recursively is pretty cheap, and it's just too confusing to tell whether all our callers do it for us.
  • bindings/objc/objc_runtime.h: Nixed some dead code.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertNSStringToString): Same drill as above.
10:39 Changeset [20291] by ap

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=13105
REGRESSION: an exception raised when calculating base value of a dot expression is not returned

Test: fast/js/dot-node-base-exception.html

  • kjs/nodes.cpp: (FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.
10:36 Changeset [20290] by sfalken

2007-03-18 Steve Falkenburg <​sfalken@apple.com>

Build fix.

04:34 Changeset [20289] by hyatt

Use fillRect instead of drawLine, since drawLine has some odd behavior (it's only used for borders).

Reviewed by aroben

  • platform/graphics/IntRect.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder):
04:11 Changeset [20288] by hyatt

Change the frameborder color to be light gray for framesets.

Reviewed by aroben

  • rendering/RenderFrameSet.cpp: (WebCore::borderFillColor): (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder):
03:53 Changeset [20287] by hyatt

Make iframes work properly with frameborder="0".

Reviewed by aroben

  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::mapToEntry): (WebCore::HTMLIFrameElement::parseMappedAttribute):
03:52 Changeset [20286] by hyatt

Add new iframe layout test.

03:00 Changeset [20285] by hyatt

Land corrected results for frame changes.

02:58 Changeset [20284] by hyatt

Land corrected results for frame changes.

02:57 Changeset [20283] by hyatt

Land corrected results for frame changes.

02:57 Changeset [20282] by hyatt

Land corrected results for frame changes.

02:56 Changeset [20281] by hyatt

Land corrected results for frame changes.

02:56 Changeset [20280] by hyatt

Land corrected results for frame changes.

02:55 Changeset [20279] by hyatt

Land corrected results for frame changes.

02:54 Changeset [20278] by hyatt

Land corrected results for frame changes.

02:54 Changeset [20277] by hyatt

Land corrected results for frame changes.

02:52 Changeset [20276] by hyatt

Land corrected results for frame changes.

02:51 Changeset [20275] by hyatt

Land corrected results for frame changes.

02:50 Changeset [20274] by hyatt

Land corrected results for frame changes.

02:48 Changeset [20273] by hyatt

Land corrected results for frame changes.

02:47 Changeset [20272] by hyatt

Land corrected XHTML DOM test results for frames changes.

02:35 Changeset [20271] by hyatt

Reset frames results.

02:33 Changeset [20270] by hyatt

Add a 2px border by default to <iframe>s for compatibility with other browsers.

Reviewed by aroben

  • css/html4.css:
02:21 Changeset [20269] by hyatt

WebCore:

Move frame borders out of WebKit and into WebCore.

Reviewed by aroben, olliej

  • bridge/mac/FrameViewMac.mm:
  • css/html4.css:
  • html/HTMLFrameSetElement.cpp: (WebCore::HTMLFrameSetElement::HTMLFrameSetElement): (WebCore::HTMLFrameSetElement::mapToEntry): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLFrameSetElement::attach):
  • html/HTMLFrameSetElement.h: (WebCore::HTMLFrameSetElement::hasBorderColor):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/IntRect.h: (WebCore::IntRect::topLeft): (WebCore::IntRect::topRight): (WebCore::IntRect::bottomLeft): (WebCore::IntRect::bottomRight):
  • rendering/RenderFrame.cpp: (WebCore::RenderFrame::viewCleared):
  • rendering/RenderFrameSet.cpp: (WebCore::borderStartEdgeColor): (WebCore::borderEndEdgeColor): (WebCore::RenderFrameSet::paintColumnBorder): (WebCore::RenderFrameSet::paintRowBorder): (WebCore::RenderFrameSet::paint):
  • rendering/RenderFrameSet.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):

WebKit:

Move frame borders out of WebKit and into WebCore.

Reviewed by aroben, olliej

  • WebCoreSupport/WebFrameBridge.mm:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.mm: (-[WebFrameView drawRect:]): (-[WebFrameView setFrameSize:]):
  • WebView/WebFrameViewInternal.h:

03/17/07:

22:23 Changeset [23105] by hyatt

The internal side of the patch that ensures Boomer paints twice on ibench. Don't let the timer beat out
that first paint.

Reviewed by aroben

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::update):
22:18 Changeset [20268] by hyatt

Make onload do an explicit paint when a top-level document is ready (to ensure that a first paint always
happens before any timers set by the onload can fire).

Reviewed by aroben

  • dom/Document.cpp: (WebCore::Document::implicitClose):
  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::update):
22:01 Changeset [23104] by aroben

Reviewed by Hyatt.

Implemented console message dumping.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::QueryInterface): Added cases for IWebUIDelegate[Private] (WaitUntilDoneDelegate::webViewAddMessageToConsole): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Now inherits from IWebUIDelegatePrivate
19:26 Changeset [23103] by aroben

Reviewed by Brady.

Fix fast/dom/isindex-002.html.

Add default strings to our two remaining unimplemented localizable
strings in WebCore.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): Added English string from Mac. (WebCore::inputElementAltText): Ditto.
17:54 Changeset [20267] by hyatt

Tweaks to prevent timers from starving user input or painting.

17:11 Changeset [20266] by ggaren

Reviewed by Beth Dakin.

Fixed <rdar://problem/5070967> REGRESSION (r20211): Repro crash when
closing View Source window


I award myself 0 points, and may God have mercy on my soul.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::~KJSProxy):
17:04 Changeset [20265] by kjk

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Pasteboard::writeURL):
16:39 Changeset [20264] by hyatt

Fix tiny PLT regression. Don't examine the border/background data for RenderImage when images change
unless we actually have a border/background.

Reviewed by Brady

  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged):
16:17 Changeset [23102] by aroben

Reviewed by Brady.

Fix repro ASSERT when logging in to facebook.com.

  • WebMutableURLRequest.cpp: (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
10:21 Changeset [20263] by sullivan

Reviewed by Tim Hatcher


Discovered while working on <rdar://problem/5070334> that many WebView calls will crash if called
after -[WebView close] has executed because _private->page is deferenced after it's been set to 0.
It might be silly/wrong to call these methods after -close, but obviously it shouldn't crash. Made
each use of _private->page robust against nil-dereferencing.

  • WebView/WebView.mm: (-[WebView _loadBackForwardListFromOtherView:]): (-[WebView _updateWebCoreSettingsFromPreferences:]): (-[WebView _setDashboardBehavior:to:]): (-[WebView _dashboardBehavior:]): (-[WebView goBack]): (-[WebView goForward]): (-[WebView goToBackForwardItem:]): (-[WebView canGoBack]): (-[WebView canGoForward]): (-[WebView setTabKeyCyclesThroughElements:]): (-[WebView tabKeyCyclesThroughElements]): (-[WebView setEditable:]):
08:38 Changeset [20262] by zimmermann

Reviewed by Sam Weinig.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=13046 (CSS styles on hover and focus are broken for <use>)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12838 (SVG <use> CSS styles broken)
Added test: svg/custom/use-css-events.svg

In general this fixes the peepo.co.uk website.

Forgot to pass the actual StyleChange to the recalcStyle() function,
when calling it on the shadow tree root element.

07:49 Changeset [20261] by thatcher

JavaScriptCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/Version.xcconfig:

JavaScriptGlue:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/JavaScriptGlue.xcconfig:
  • Configurations/Version.xcconfig:

WebCore:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/Version.xcconfig:
  • Configurations/WebCore.xcconfig:

WebKit:

Reviewed by Mark Rowe.

Made Version.xcconfig smarter when building for different configurations.
Now uses the 522+ OpenSource version for Debug and Release, while using the
full 522.4 version for Production builds. The system prefix is also computed
based on the current system, so 4522.4 on Tiger and 5522.4 on Leopard.

  • Configurations/Version.xcconfig:
  • Configurations/WebKit.xcconfig:
04:53 Changeset [20260] by antti

LayoutTests:

Reviewed by Adele.


Test for ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>


Expanded version of Darin's test case.

  • fast/forms/old-names-expected.txt: Added.
  • fast/forms/old-names.html: Added.

WebCore:

Reviewed by Adele.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12595
REGRESSION: Can't add item to cart at lnt.com (JS type error)
<rdar://problem/4722863>


Emulate Firefox behavior where form elements accessed by a name
can be accessed with that name later even if the name changes or
even if element is removed from the document.


This is loosely based on Darin's earlier patch for the same problem but
is much less expansive. It takes somewhat different approach to more closely
mimic Firefox behavior. Includes expanded test case.

  • bindings/js/JSHTMLFormElementCustom.cpp: (WebCore::JSHTMLFormElement::canGetItemsForName):

Use new the HTMLFormElement::getNamedElements() method

(WebCore::JSHTMLFormElement::nameGetter):

Use new the HTMLFormElement::getNamedElements() method

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement): (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::elementForAlias): (WebCore::HTMLFormElement::addElementAlias):

Maintain a map of known element aliases

(WebCore::HTMLFormElement::getNamedElements):

Get a list of elements matching the name, based both their
current names and known aliases (earlier names).
Keep the alias list in sync.

  • html/HTMLFormElement.h:
00:46 Changeset [23101] by adele

Reviewed by Hyatt.

Fix for <rdar://problem/4960391> REGRESSION (r18922): onChange never fired after selecting an item from a menulist

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): Initialize m_focusedIndex to 0. Instead of using the client to track the focused index, we'll keep track of it internally. Our old behavior was trying to match Firefox by updating the selected index as you focus items, but that doesn't seem necessary if the selection never gets committed. (WebCore::PopupMenu::show): Initialize the focused index to the client's selected index. (WebCore::PopupMenu::setFocusedIndex): Remove the fireOnChange argument. Remove the call to valueChanged. (WebCore::PopupMenu::focusedIndex): Return m_focusedIndex instead of getting this from the client. (WebCore::PopupMenu::down): Use the focusedIndex. (WebCore::PopupMenu::up): ditto. (WebCore::PopupMenu::paint): Paint a selected appearance for the item with the focused index.
00:40 Changeset [20259] by adele

LayoutTests:

Reviewed by Hyatt.

Updated test for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

  • fast/forms/listbox-onchange-expected.txt:
  • fast/forms/listbox-onchange.html:

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4990050> REGRESSION: onchange gets fired when clicking on a programmatically selected element in a listbox
​http://bugs.webkit.org/show_bug.cgi?id=12725

Test: updated fast/forms/listbox-onchange.html

Added HTMLSelectElement::saveLastSelection that is called before changing a selection that could result
in onChange being called. m_lastOnChangeIndex and m_lastOnChangeSelection no longer have to be up-to date all the time,
they just have to be up-to-date before we execute an action that may trigger onChange.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelectedState): Added. The HTMLSelectElement will only set an option's selected state with this method. This ensures that notifyOptionSelected won't get called when the call originates from the select element.
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::deselectItems): Calls setSelectedState. (WebCore::HTMLSelectElement::setSelectedIndex): ditto. Don't update the last selection variables here. Scroll to the new selection. The scrolling call used to only be in notifyOptionSelected. There's no reason we shouldn't scroll when the selection is set through the HTMLSelectElement. (WebCore::HTMLSelectElement::setValue): Call setSelectedIndex to update all options selected state. (WebCore::HTMLSelectElement::restoreState): Call setSelectedState. (WebCore::HTMLSelectElement::selectAll): Call saveLastSelection before making the selection, and calling onChange. (WebCore::HTMLSelectElement::recalcListItems): Call setSelectedState. Don't need to save selection here anymore, since it will get saved before we call onChange. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::dispatchFocusEvent): Added. Call saveLastSelection for menu lists, since onChange can be fired on blur. (WebCore::HTMLSelectElement::dispatchBlurEvent): Call menuListOnChange. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Call saveLastSelection before showing the popup window. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Call saveLastSelection during mousedown (to prepare for an onchange during mouseup, or after autoscroll). (WebCore::HTMLSelectElement::updateListBoxSelection): Call setSelectedState.

(WebCore::HTMLSelectElement::menuListOnChange): Added. Compares the m_lastOnChangeIndex to the selectedIndex().
(WebCore::HTMLSelectElement::listBoxOnChange): Move the m_lastOnChangeSelection creation to saveLastSelection.
(WebCore::HTMLSelectElement::saveLastSelection): Added. Sets m_lastOnChangeIndex or m_lastOnChangeSelection.

  • html/HTMLSelectElement.h:
  • platform/PopupMenu.h:
Note: See TracTimeline for information about the timeline view.