Timeline


and

03/23/07:

23:24 Changeset [20460] by hyatt

Fix Gmail spurious glyphs issue.

21:38 Changeset [20459] by adele

LayoutTests:

Reviewed by Adele.

  • editing/selection/doubleclick-crash-expected.checksum:
  • editing/selection/doubleclick-crash-expected.png:
  • fast/text/selection-hard-linebreak-expected.checksum: Added.
  • fast/text/selection-hard-linebreak-expected.png: Added.
  • fast/text/selection-hard-linebreak-expected.txt: Added.
  • fast/text/selection-hard-linebreak.html: Added.

WebCore:

Reviewed by Adele.

  • fix a bug where selecting across a soft line break did not highlight to the end of the first line if it contained skipped whitespace

Test: fast/text/selection-hard-linebreak.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the end of a hard line break as if it ends after the line break. Fixed the case of a selection that starts and ends in the same text object as the box but does not intersect it to return SelectionNone instead of selectionBoth.
21:05 Changeset [20458] by adele

LayoutTests:

Reviewed by Adele.

  • fast/frames/hover-timer-crash-expected.txt: Added.
  • fast/frames/hover-timer-crash.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/frames/hover-timer-crash.html

  • page/Frame.cpp: (WebCore::Frame::setView): Added a call to EventHandler::clear().
20:56 Changeset [23182] by beidson

Reviewed by Adam


<rdar://5086194> - WebHistory overreleases a CFNumber


  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't legitimately get a ref for!
18:41 Changeset [23181] by aroben

Reviewed by Darin.

WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
hacks" menu item to the Debug menu

Added new IWebPrivate::setAllowSiteSpecificHacks SPI.

  • Interfaces/IWebViewPrivate.idl: Added declaration.
  • WebView.cpp: (WebView::userAgentForKURL): Only give a site-specific UA if site-specific hacks are turned on. (WebView::setAllowSiteSpecificHacks): Added.
  • WebView.h: (WebView::allowSiteSpecificHacks): Added.
18:18 Changeset [20457] by justing

Forgot to include these nil checks in my previous checkin.

17:58 Changeset [20456] by justing

LayoutTests:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/pasteboard/5078739-expected.txt: Added.
  • editing/pasteboard/5078739.html: Added.

WebCore:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Check for an empty fragment after removing a redundant style span instead of before.
15:54 Changeset [23180] by adele

Reviewed by Maciej.

Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Removed code to store lowercase characters in m_text. Now that we use the character code to create m_text this is already taken care of. This does mean that m_unmodifiedText is not right. This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596. This also fixes line endings in this file.
15:32 Changeset [23179] by bdakin

Reviewed by Hyatt.

Fix for <rdar://problem/5083914> Cursor is wrong for all context
menus

  • WebView.cpp: (WebView::handleContextMenuEvent): Set the cursor to the pointer cursor.
15:26 Changeset [20455] by aroben

Reviewed/landed by Adam.

Bug 13175: Make apollo mac project files for JavaScriptCore actually
build something
http://bugs.webkit.org/show_bug.cgi?id=13175

  • JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
14:48 Changeset [20454] by hyatt

<rdar://problem/5085063>

Fix non-looping animation on cuteoverload.com. Just always flush
decoded data for large animated images to avoid our cache getting
out of sync with the image source.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
14:09 Changeset [20453] by adele

Reviewed by Darin.

Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
http://bugs.webkit.org/show_bug.cgi?id= 13020

No known way to add a layout test for this. We would need a way to know exactly how the event was consumed.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
13:53 Changeset [20452] by brmorris

rathnasa, reviewed by zalan

DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
http://bugs.webkit.org/show_bug.cgi?id=13074

13:53 Changeset [23178] by aroben

Being a Boy Scout.

13:50 Changeset [23177] by aliceli1

Reviewed by Adam.

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
13:49 Changeset [23176] by aliceli1

Reviewed by NOBODY (OOPS!).

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
13:48 Changeset [20451] by zbujtas

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
13:43 Changeset [20450] by zbujtas

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
13:42 Changeset [20449] by justing

LayoutTests:

Reviewed by darin

Fixed (was missing a newline):

  • editing/execCommand/4917055-expected.txt: Tests setting a caet before the image and changing its alignment:
  • editing/execCommand/5080333-1-expected.checksum: Added.
  • editing/execCommand/5080333-1-expected.png: Added.
  • editing/execCommand/5080333-1-expected.txt: Added.
  • editing/execCommand/5080333-1.html: Added. Tests selecting the image and changing its alignment:
  • editing/execCommand/5080333-2-expected.checksum: Added.
  • editing/execCommand/5080333-2-expected.png: Added.
  • editing/execCommand/5080333-2-expected.txt: Added.
  • editing/execCommand/5080333-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5080333>
REGRESSION: Selection changes when changing the alignment of an image


Regression occurred when we started using moveParagraphs
to move content in applyBlockStyle. moveParagraphs
moves by copying, deleting and reinserting content, and
so must be accompanied by selection preservation code.
That code uses rangeFromLocationAndLength and rangeLength,
which use TextIterators, which don't emit anything for images
and other replaced elements, causing this bug.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength and rangeFromLocationAndLength to request that their TextIterators emit spaces for replaced elements. Use rangeCompliantEquivalent()s when creating a Range from VisiblePositions, since some VisiblePositions have illegal deepEquivalent()s.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::handleReplacedElement): Emit a space if requested. (WebCore::TextIterator::representNodeOffsetZero): Emit ranges before m_node, not around m_lastTextNode. These ranges should represent the part of the document associated with the emitted character. (WebCore::TextIterator::rangeLength): Take in the new bool. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto. Also, don't loop an extra time after finding the end of the range when we're looking for zero length ranges. This appeared to be a workaround for the bugs fixed in representNodeOffsetZero in this patch.
  • editing/TextIterator.h:
13:05 Changeset [20448] by bdash

Versioning.

13:03 Changeset [20447] by bdash

Merge in r20445.

12:58 Changeset [20446] by bdash

New tag.

12:51 Changeset [20445] by bdash

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.
12:13 Changeset [20444] by zbujtas

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix NULL pointer check for CacheImage
http://bugs.webkit.org/show_bug.cgi?id=13094

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor):
11:39 Changeset [20443] by darin
  • html/HTMLBodyElement.cpp: Fix comment typo.
11:38 Changeset [20442] by staikos

Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as
with.

11:25 Changeset [20441] by darin

Reviewed by Hyatt.

  • <rdar://problem/5074439> handle margins on frame and iframe elements without involving FrameView, FrameLoader, etc.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument): Grab the margin from the frame directly here. There was no real benefit to doing this via FrameView. Later we can delete quite a bit of unneeded code here and in WebKit that exists only to set up the margin values in FrameView, which are now unused.
11:24 Changeset [20440] by adele

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-hidden-value.html: Added.
  • fast/forms/input-value-expected.txt:

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer). In reset,
use the m_originalValue for hidden input elements.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::closeRenderer): (WebCore::HTMLInputElement::reset): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
  • html/HTMLInputElement.h:
11:01 Changeset [20439] by staikos

Patch by Adam Treat. Removes hardcoded path to .pro file.

10:48 Changeset [20438] by spadma

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:45 Changeset [20437] by spadma

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
08:08 Changeset [20436] by spadma

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
08:07 Changeset [20435] by spadma

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
08:05 Changeset [20434] by spadma

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
08:02 Changeset [20433] by spadma

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
07:57 Changeset [20432] by spadma

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
07:56 Changeset [20431] by spadma

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
04:47 Changeset [23175] by aroben

WebKitToolsWin:

Reviewed by Oliver.

Implemented dumping of frame scroll positions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Ported from Mac. (dump): Added call to dumpFrameScrollPosition. (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFrameScrollPositionsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented some WebFrame methods to support dumping frame scroll
offsets in DRT.

  • Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
  • Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
  • WebFrame.cpp: (WebFrame::name): Implemented. (WebFrame::childFrames): Implemented. (WebFrame::scrollOffset): Implemented.
  • WebFrame.h: Updated/added declarations.
04:41 Changeset [20430] by bdash

Add radar reference.

04:37 Changeset [20429] by bdash

2007-03-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-image-error.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if the image failed to load, since that means we will use a bullet instead.

2007-03-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/lists/marker-image-error-expected.checksum: Added.
  • fast/lists/marker-image-error-expected.png: Added.
  • fast/lists/marker-image-error-expected.txt: Added.
  • fast/lists/marker-image-error.html: Added.
04:23 Changeset [20428] by zack

Fix the compile

02:25 Changeset [20427] by bdash

2007-03-23 Mark Rowe <mrowe@apple.com>

Build fix for when BUILDING_ON_TIGER is not defined.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
01:32 Changeset [23174] by aroben

WebKitWin:

Reviewed by Oliver.

WebKit part of fix for <rdar://problem/4990740>.

Added IWebDataSourcePrivate::mainDocumentError.

  • Interfaces/IWebDataSource.idl: Added method declaration and updated copyrights.
  • WebDataSource.cpp: (WebDataSource::mainDocumentError): Implemented.
  • WebDataSource.h: Added declaration.
00:29 Changeset [23173] by sfalken

2007-03-23 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed

  • WebView.cpp: (WebView::userAgentForKURL): Remove gmail spoof
00:24 Changeset [20426] by andersca

Reviewed by Adam.

Make script-add.html more deterministic.


  • fast/dom/resources/script3.js:
  • fast/dom/resources/script4.js:
  • fast/dom/resources/script5.js:
  • fast/dom/script-add.html:

03/22/07:

23:14 Changeset [23172] by hyatt

Fix for print stylesheets not being honored.

23:07 Changeset [20425] by hyatt

printing changes

22:59 Changeset [23171] by ggaren

Reviewed by Adam Roben.


Fixed <rdar://problem/5082985> Select menus are too see-through

Upped alpha value from 90 to 95. Menus will still seem a little
more see-through than on the mac, since their backgrounds are
white, not grey, but white matches other Windows browsers.


  • ChangeLog:
  • platform/win/PopupMenuWin.cpp:
22:58 Changeset [20424] by bdash

Versioning.

22:55 Changeset [20423] by sfalken

New tag.

22:55 Changeset [20422] by aroben

Reviewed/landed by Adam.

  • Adding mac project files for apollo port of JavaScriptCore. Currently project just builds dftables.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: Added.
22:50 Changeset [20421] by bdash

Merge in r20390.

22:47 Changeset [20420] by bdash

New tag.

22:00 Changeset [20419] by andersca

Reviewed by Ada.

<rdar://problem/5074974>
CrashTracer: [USER] repro crash in Safari at com.apple.WebCore: WebCore::FrameLoader::activeDocumentLoader const + 6


  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): Don't use ResourceResponse:isHTTP here since that only looks at the protocol instead of if the response came from a HTTP server (and not a web archive).
21:41 Changeset [20418] by sfalken

Merged 20416 from TOT

21:07 Changeset [20417] by kjk

Not reviewed - gdk build fix.

  • platform/graphics/cairo/ImageSourceCairo.cpp:
20:36 Changeset [20416] by hyatt

Fix wheeling issue on gamespot.com

20:33 Changeset [20415] by thatcher

New branch.

20:33 Changeset [20414] by thatcher

Removing this branch.

18:43 Changeset [23170] by andersca

Reviewed by Maciej.

<rdar://problem/5081539>
QT content is dupped on a page, if page is being previewed or printed.


Don't update the frame geometry if the document is in printing mode.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry):
18:26 Changeset [23169] by andersca

Reviewed by Maciej.

<rdar://problem/5082270>
Crash in windows media player at MTV.COM


Ignore any WM_PAINT events we get while painting.


  • WebView.cpp: (WebView::WebView): (WebView::updateBackingStore): (WebView::paint): (WebViewWndProc):
  • WebView.h: (WebView::isPainting):
17:32 Writing Layout Tests for DumpRenderTree edited by mitz@webkit.org
Removed mouseClick() since it's been removed in r20407. (diff)
17:25 Changeset [20413] by justing

LayoutTests:

Reviewed by kevin


<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty


  • editing/selection/5081257-1-expected.checksum: Added.
  • editing/selection/5081257-1-expected.png: Added.
  • editing/selection/5081257-1-expected.txt: Added.
  • editing/selection/5081257-1.html: Added.
  • editing/selection/5081257-2-expected.checksum: Added.
  • editing/selection/5081257-2-expected.png: Added.
  • editing/selection/5081257-2-expected.txt: Added.
  • editing/selection/5081257-2.html: Added.

WebCore:

Reviewed by kevin

<rdar://problem/5081257>
REGRESSION: New Mail signatures start out empty

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition): Allow descent from positions inside the document into an editable body.
17:16 Changeset [23168] by bdakin

Fix by Hyatt, reviewed and committed by me.

Fix for <rdar://problem/5082360> Incomplete frame paint when
shrinking window @ google.com

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::setFrameGeometry): Wrong order!
17:15 Changeset [20412] by ddkilzer

WebKit:

Reviewed by Darin.

Use BUILDING_ON_TIGER from WebKitPrefix.h instead of local
MAC_OS_X_VERSION_MAX_ALLOWED <= MAC_OS_X_VERSION_10_4 tests.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
16:57 Changeset [20411] by beidson

Reviewed by Adele and John

<rdar://5043528> - Prepare for new API


  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::clearAuthentication): Clear CF type
16:26 Changeset [23167] by aroben

Reviewed by Adele.

Implemented layoutTestController.dumpTitleChanges.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpTitleChangesCallback): Implemented.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didReceiveTitle): Implemented.
15:14 Changeset [20410] by bdakin

Patch by Hyatt, reviewed and committed by me.

Does not reproduce consistently, so a layout test does not seem
possible.

Fix for <rdar://problem/5082421> Constantly hitting ASSERT(!
needsLayout()) in RenderView::paint()

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): It is not enough to ask if the layout timer is active. There may be times that we don't have a body yet so we cannot schedule layout yet, but the root still needs layout.
15:08 Changeset [20409] by spadma

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
15:08 Changeset [20408] by spadma

2007-03-22 spadma

Reviewed by Zalan.
DESC: TMCN-6Z8J7S Opening a web bank application crashes the browser
http://bugs.webkit.org/show_bug.cgi?id=13162

  • BrowserView/inc/WebKitLoader.h:
  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::~CWebKitLoader): (CWebKitLoader::SetPageUrlL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):
14:58 Changeset [23166] by aroben

Rubberstamped by Geoff.

Removed eventSender.mouseClick now that it isn't used.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
14:53 Changeset [20407] by aroben

LayoutTests:

Reviewed by Geoff.

Replaced all calls to eventSender.mouseClick with paired calls to
mouseDown/mouseUp.

  • fast/events/click-count.html:
  • fast/events/event-sender-mouse-click-expected.txt: Removed.
  • fast/events/event-sender-mouse-click.html: Removed.
  • fast/events/frame-click-focus.html:
  • fast/events/objc-event-api.html:
  • fast/forms/focus-selection-input.html:
  • fast/forms/focus-selection-textarea.html:

WebKitTools:

Reviewed by Geoff.

Removed eventSender.mouseClick because it was only useful for AppKit
controls, which we don't use anymore.

  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed mouseClick.
14:52 Changeset [23165] by adele

WebKitWin:

Reviewed by Anders.

Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)

  • Interfaces/IWebURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty. On the mac, NSURLRequests created from empty ResourceRequests are nil. We may want to consider that in the future, but there were too many places in the app that expected the IWebURLRequest to be non-null.
  • WebMutableURLRequest.h:
14:52 Changeset [20406] by spadma

2007-03-21 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
14:50 Changeset [20405] by spadma

2007-03-21 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin.
DESC: ASAA-6X5DX8 : NewsTicker SVG icon doesn't display
http://bugs.webkit.org/show_bug.cgi?id=13144

  • Plugin/src/PluginWin.cpp: (CPluginWin::WriteStreamToFileL):
14:20 Changeset [20404] by sullivan

Reviewed by Darin


Followup for recent fix to 5079700, found by assertion added to Safari.

  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): Fixed another place in this method where an empty NSString was being returned instead of nil. Cleaned up the style a little too.
14:03 Changeset [20403] by thatcher

Versioning

14:03 Changeset [20402] by thatcher

Merging fix from r20368.

14:00 Changeset [20401] by thatcher

New tag (part 2.)

14:00 Changeset [20400] by thatcher

Removing bad tag.

13:59 Changeset [20399] by thatcher

New tag (part 2.)

13:58 Changeset [20398] by thatcher

New tag (part 1.)

13:56 Changeset [20397] by thatcher

Move this tag.

13:53 Changeset [20396] by thatcher

Versiong.

13:52 Changeset [20395] by thatcher

Merging fix from r20381.

13:51 Changeset [20394] by thatcher

New tag (part 2.)

13:50 Changeset [20393] by thatcher

New tag (part 1.)

13:45 Changeset [20392] by hyatt

Remove unnecessary destroyFrameAtIndex call. Now that we throw away
the image source, it is no longer needed.

Reviewed by beth

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData):
12:28 Changeset [20391] by brmorris

borges, reviewed by bradley

DESC: minor fix to renderer.mmpi for new build system
http://bugs.webkit.org/show_bug.cgi?id=13027

  • group/renderer.mmpi:
12:09 Changeset [20390] by harrison

Reviewed by Geoff, Darin.

<rdar://problem/5077892> In RapidWeaver 3.5.1, a crash occurs when attempting to load Safari Bookmarks in iMedia Browser


  • platform/mac/ThreadCheck.mm: (WebCore::_WebCoreThreadViolationCheck): Change default on Tiger to NSLog rather than raise an exception.
11:22 Changeset [20389] by darin

Reviewed by Brady.

  • use binary_search instead of hash table; slightly better performance and less memory use
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::portAllowed): Use binary_search.
11:17 Changeset [20388] by darin

WebCore:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDocumentLoader): Add a call to detachChildren() after the call to prepareForDataSourceReplacement(). There was no reason for this crucial loading step to be left to the client.

WebKit:

Reviewed by Adele.

  • fix <rdar://problem/5074630> detachChildren call should move from WebKit to WebCore
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::prepareForDataSourceReplacement): Remove call to detachChildren. This should be a WebCore responsibility.
03:55 Changeset [23164] by hyatt

Fix crasher in RenderTableSection::paint

03:55 Changeset [23163] by hyatt

Fix crasher in RenderTableSection::paint

03:55 Changeset [23162] by hyatt

Fix crasher in RenderTableSection::paint

03:47 Changeset [20387] by hyatt


02:21 Changeset [20386] by aroben

LayoutTests:

Reviewed by Ada.

Added a new test to make sure that eventSender.mouseClick works
correctly.

  • fast/events/click-count-expected.txt: Added.
  • fast/events/click-count.html: Added.

Updated results for some tests that depended on the broken version of
eventSender.mouseClick.

  • fast/events/objc-event-api-expected.txt:
  • fast/forms/focus-selection-input-expected.txt:
  • fast/forms/focus-selection-textarea-expected.txt:

WebKitTools:

Reviewed by Ada.

Make eventSender.mouseClick actually send a mouse up event.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseClick]):
02:13 Changeset [20385] by hyatt

Minor refactoring and cleanup of the bridge calls that want to control layout settings on the RenderView.
Have the bridge talk through the FrameView instead of just asking for the RenderView directly.

Add an assert to help catch situations where the RenderView needs layout at paint time, since this is a known
catastrophic scenario that will (much of the time) result in a crash in RenderTableSection::paint.

Reviewed by aroben

  • page/FrameView.cpp: (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::needsLayout): (WebCore::FrameView::setNeedsLayout):
  • page/FrameView.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge needsLayout]): (-[WebCoreFrameBridge setNeedsLayout]):
  • rendering/RenderView.cpp: (WebCore::RenderView::paint):
01:51 Changeset [23161] by adachan

2007-03-22 Ada Chan <adachan@apple.com>

WebKitWin:

Reviewed by Hyatt and Alice.


Changed the mouse event processing in the WebView wndproc so we actually
allow a mouse event with click count > 3, which matches the mac safari behavior.


Set globalPrevButton and globalPrevPoint also in mouse down.

  • WebView.cpp: (WebView::handleMouseEvent):
00:04 Changeset [23160] by hyatt

Fix wheel events.

03/21/07:

22:55 Changeset [20384] by ggaren

Reviewed by Beth Dakin.


Re-worked the fix in r20375. 'M' and 'm' are not the only commands that
accept "extra" coordinates -- virtually all commands accept them.

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
22:54 Changeset [20383] by ddkilzer

WebKitSite:

Reviewed by NOBODY (more word tweaking).

  • building/checkout.html: By popular demand, the link to the svn 1.3 client has been removed.
22:48 Changeset [20382] by ddkilzer

WebKitSite:

Reviewed by NOBODY (tweaked wording).

  • building/checkout.html: Got rid of "click here" link and restructured sentences linking to svn clients.
22:17 Changeset [23159] by aroben

Reviewed by Hyatt.

Force SVG tests to paint to match the Mac results.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Force a paint if we're running an SVG test.
21:31 Changeset [20381] by harrison

Reviewed by hyatt.

<rdar://problem/5072460> CrashTracer: [USER] 1 crashes in Xcode at com.apple.ImageIO.framework: getBandProcPNG + 168

An NSData object was being alloc/init'd, then returned callers who cast the pointer as a
CFDataRef, including calling CFRelease on it. The problem is that under garbage collection, the NS
retain count is ignored (it's always 0), but the CFRetain and CFRelease are not ignored. This
caused the object to be over-released. The solution that works in both GC and non-GC is to "transfer"
the initial NS retain count to the CF retain count, using HardRetainWithNSRelease.


The creator of the NSData was SharedBuffer::createNSData. The callers were PDFDocumentImage::dataChanged()
and ImageSource::setData(). This particular crash involved the ImageSource::setData() case.

  • platform/SharedBuffer.h: Declare createCFData().


  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::setData): Call createCFData instead of createNSData.


  • platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::dataChanged): Call createCFData instead of createNSData.


  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createCFData): Implement createCFData(). Use HardRetainWithNSRelease for gc safety.
21:16 Changeset [20380] by ddkilzer

LayoutTests:

Reviewed by Darin. Patch by Mitz.

  • fast/dynamic/view-overflow-expected.checksum: Added.
  • fast/dynamic/view-overflow-expected.png: Added.
  • fast/dynamic/view-overflow-expected.txt: Added.
  • fast/dynamic/view-overflow.html: Added.

WebCore:

Reviewed by Darin. Patch by Mitz.

Test: fast/dynamic/view-overflow.html

  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Reset overflowHeight() and overflowWidth() before calling docHeight() and docWidth(), since the former act as a lower bound for the latter.
21:11 Changeset [20379] by ddkilzer

WebKitSite:

Reviewed by Adam.

  • building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.
21:09 Changeset [20378] by ggaren

Fixed bad version of results that I check in accidentally.

  • svg/dom/string-list-parser-expected.txt:
21:05 Changeset [20377] by ggaren

Reviewed by Beth Dakin.


A little cleanup based work I've been doing on the SVG parsers.

  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipString):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into SVGParserUtilities.h, so it could be with all its friends. Renamed "checkString" to "skipString" to match the rest of the code and to be clear about which functions move the buffer pointer. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into returns. Removed unnecessary magic number.
20:50 Changeset [20376] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the SVG rgb color parser.

  • svg/dom/rgb-color-parser-expected.txt: Added.
  • svg/dom/rgb-color-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
buffer when running fuzzing test

  • ksvg2/svg/SVGColor.cpp: (WebCore::parseNumberOrPercent): Check for past the end condition. (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end of buffer, then check if you're past the end" logic.
20:37 Changeset [20375] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Added fuzz tester for the path parser.

  • svg/dom/path-parser-expected.txt: Added.
  • svg/dom/path-parser.html: Added.

WebCore:

Reviewed by Beth Dakin.


Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
running fuzzer test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are always preceded by an 'M' or an 'm'.
20:28 Changeset [20374] by ggaren

Reviewed by Beth Dakin.


Added fuzz tester for the string list parser.

  • svg/dom/string-list-parser-expected.txt: Added.
  • svg/dom/string-list-parser.html: Added.
20:26 Changeset [20373] by ggaren

Reviewed by Beth Dakin.


Added fuzz tester for the length list parser.

  • svg/dom/length-list-parser-expected.txt: Added.
  • svg/dom/length-list-parser.html: Added.
20:21 Changeset [20372] by ggaren

Reviewed by Beth Dakin.


Factored randomizing functions into their own file, in preparation for future
tests that rely on them.


  • svg/dom/resources/scripted-random.js: Added.
  • svg/dom/transform-parser.html: Factored out scripted-random.js, added a small string that increases the normal-seemingness of the last test.
20:12 Changeset [20371] by thatcher

New results after rolling out r19828 in r20352.

  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
18:42 Changeset [20370] by sullivan

Reviewed by Adam


  • fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled or saved for .Mac homepage login
  • page/mac/FrameMac.mm: (WebCore::Frame::searchForLabelsBeforeElement): don't count empty strings as valid results
18:21 Changeset [23158] by aroben

Reviewed by Oliver.

  • Skipped: Added an SVG test that causes a debug ASSERT in the C Runtime.
18:15 Changeset [23157] by aroben

WebKitToolsWin:

Reviewed by Oliver.

Make W3C SVG tests render at the correct dimensions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Resize the WebView if we're running a W3C SVG test. (runTest): Save the current test filename.
17:48 Changeset [20369] by justing

Reviewed by darin

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Release the RefPtr to avoid increasing/decreasing the refcount unnecessarily. (WebCore::propertyMissingOrEqualToNone): Added and used instead of converting values to strings. (WebCore::elementHasTextDecorationProperty): (WebCore::createMarkup):
17:31 Changeset [20368] by thatcher

Reviewed by Darin.

<rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

17:07 Changeset [23156] by andersca

Reviewed by Adam.

  • WebView.cpp: (WebView::initWithFrame): Remove #ifdef now that DRT no longer crashes.
16:59 Changeset [20367] by mjs
  • some specs to propose by email
  • specs/HTML_Timed_Media_Elements.html: Added.
  • specs/Timed_Media_CSS.html: Added.
  • specs/Timed_Media_Elements-Open_Issues.html: Added.
  • specs/mediaelement.css: Added.
  • specs/movie-status-states.png: Added.
16:58 Changeset [20366] by justing

LayoutTests:

Reviewed by oliver


<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text

Tests for the bug:

  • editing/pasteboard/5075944-expected.checksum: Added.
  • editing/pasteboard/5075944-expected.png: Added.
  • editing/pasteboard/5075944-expected.txt: Added.
  • editing/pasteboard/5075944.html: Added. Tests that the element that has the text-decoration and all its descendants down to the common ancestor are included in the copied markup (instead of the text-decoration property being treated as though it were inheritable and placed on the style span wrapper):
  • editing/pasteboard/5075944-2-expected.checksum: Added.
  • editing/pasteboard/5075944-2-expected.png: Added.
  • editing/pasteboard/5075944-2-expected.txt: Added.
  • editing/pasteboard/5075944-2.html: Added. Tests that moveParagraphs gets underlining right (it doesn't use annotation):
  • editing/pasteboard/5075944-3-expected.checksum: Added.
  • editing/pasteboard/5075944-3-expected.png: Added.
  • editing/pasteboard/5075944-3-expected.txt: Added.
  • editing/pasteboard/5075944-3.html: Added.

WebCore:

Reviewed by oliver

<rdar://problem/5075944>
REGRESSION: Partially selected underlined content pastes as plain text


We stopped adding markup for all the ancestors
of lastClosed up to the commonAncestorBlock
because it was adding a lot of unnecessary markup.
This caused us to lose underlining when copying a
partially selected underlined element (even though
we put all styles that the copied markup inherits
into a style span, because the text-decoration
isn't inheritable).

  • editing/markup.cpp: (WebCore::styleFromMatchedRulesAndInlineDecl): Moved code here. (WebCore::elementHasTextDecorationProperty): Added. (WebCore::createMarkup): If the copied markup has a text-decoration because some common ancestor has a text-decoration property set, include that ancestor and all its descendants in the copied markup.
16:40 Changeset [23155] by hyatt

Fix broken changelog.

16:37 Changeset [23154] by hyatt

Advanced text improvements.

16:28 Changeset [20365] by thatcher

New branch.

14:59 Changeset [20364] by oliver

2007-03-21 Oliver Hunt <oliver@apple.com>

Reviewed by Antti.

WebCore:

Update a few SVG attribute parsers to be more defensive against
reading beyond the end of input.

Fixes rdar://problem/5077218 -- SVG transform parser runs past
end of buffer when running fuzzing test

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPathParser::parseSVG):
  • ksvg2/svg/SVGParserUtilities.h: (WebCore::skipOptionalSpacesOrDelimiter):
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::parseTransformParamList): (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:

Fuzz test for SVG transform parser

  • svg/dom/transform-parser-expected.txt: Added.
  • svg/dom/transform-parser.html: Added.
14:34 Changeset [23153] by bdakin

Reviewed by Adam.

<rdar://problem/5074274> right-clicking in certain iframes ends up
left-clicking, and context menu appears far away

  • WebView.cpp: (WebView::handleContextMenuEvent): We were always calling sendContextMenuEvent() on the main frame!! Instead, call it on the focused or main frame.
14:22 Changeset [23152] by aroben

LayoutTestsWin:

Reviewed by David Kilzer (yay!).

Re-enable the editing tests, except for two crashers.

  • Skipped:
12:06 Changeset [20363] by ap

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13140
Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

Test: svg/carto.net/frameless-svg-parse-error.html

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::reportError): Added a null check. (WebCore::SVGDocumentExtensions::reportWarning): Ditto.
11:03 Changeset [23151] by adele

WebKitToolsWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Call updateActiveState on the WebView in didCommitLoadForFrame. This is required so that nodes can be properly focused in the document.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::didCommitLoadForFrame):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:

WebKitWin:

Reviewed by Adam.


Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails


Added updateActiveState SPI for DumpRenderTree.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp: (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus. We should merge this logic into updateActiveState eventually. (WebView::updateActiveState):
  • WebView.h:
10:55 Changeset [20362] by adele

Reviewed by Geoff.

  • API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.
02:30 Changeset [20361] by zack

Fix the compile when USE(MULTIPLE_THREADS) isn't defined

00:24 Changeset [20360] by bdakin

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

I tried to fix this earlier today but my fix caused a regression
scrolling through RSS pages. It turns out that sometimes scroll
events need to propagate immediately, and sometimes they must be
delayed or they risk deleting objects that are expected to be
around after the event has propagated. Mitz's original fix made
sheduleEvent() only delay events that happen during layout. This
fix marks two other places in addition to layout where events also
need to be delayed. These two places are places that were marked
with FIXMEs that Mitz removed in his original patch. (There was a
third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
case is only called through layout and is covered by Mitz's
original patch.)

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Added assertion. (WebCore::FrameView::layout): Call new functions to increment and decrement the queued events count. (WebCore::FrameView::pauseScheduledEvents): (WebCore::FrameView::resumeScheduledEvents): Decrement queued events count and dispatch events if the count has zeroed.
  • page/FrameView.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::Marquee::start):
00:21 Changeset [20359] by bdash

2007-03-21 Mitz Pettel <mitz@webkit.org>

Reviewed by John Sullivan.

  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing to be terminated by a mouseup event regardless of whether the frameset needs layout.

03/20/07:

22:46 Changeset [20358] by andersca

Reviewed by Oliver.

<rdar://problem/5077252>
In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.
22:39 Changeset [20357] by beidson

Reviewed by Anders

<rdar://problem/5073391> and http://bugs.webkit.org/show_bug.cgi?id=13137

Crash in IconDatabase when private browsing is enabled.

The problem was caused by http://trac.webkit.org/projects/webkit/changeset/20182
which changed many uses of char[] and Vector<char> to SharedBuffer. The patch
tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
can be null. This led to derefs.

I took the opportunity to rework the iconDB functions to live in a SharedBuffer
world, as that didn't exist when they were originally written - now they just return
SharedBuffers instead of taking a Vector<char>& as a parameter

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking it if it's empty (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer
  • loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s
21:25 Changeset [23150] by aroben

Reviewed by Brady.

Always use CCom* smart pointers when possible to avoid memory management issues.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed _T() to TEXT(). (dump): (runTest): (initializePreferences): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: (dumpPath): (dump): (EditingDelegate::webViewDidBeginEditing): (EditingDelegate::webViewDidChange): (EditingDelegate::webViewDidEndEditing): (EditingDelegate::webViewDidChangeTypingStyle): (EditingDelegate::webViewDidChangeSelection):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (mouseDownCallback): (doMouseUp): (mouseClickCallback): (doMouseMove): (keyDownCallback):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setAcceptsEditingCallback): (setTabKeyCyclesThroughElementsCallback):
20:53 Changeset [23149] by sfalken

Bump version for submit

20:49 Changeset [20356] by sfalken

New tag.

18:50 Changeset [23148] by mjs

Removed conflict markers.

18:47 Changeset [23147] by mjs

WebKitToolsWin:

Reviewed by Geoff and Adam.


  • fixed some bugs in --threaded fond in the course of testing.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runJavaScriptThread): Be smarter about thread dictionary. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Account for --threaded command-line argument better.

WebKitWin:

Reviewed by Geoff and Adam.

  • <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
  • WebView.cpp: (WebView::WebView): Tell JavaScriptCore what the main thread is.
18:29 Changeset [23146] by aroben

Rubberstamped by Adele.

Roll out r12355 now that OpenSource r20348 has been rolled out.

  • Skipped: Also removed a crash that was caused by 20348.
18:24 Changeset [20355] by aroben

Rubberstamped by Adele.

Roll out r20348 because it was causing crashes.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
17:54 Changeset [23145] by aroben

Reviewed by Hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Install Helevetica Neue.
17:46 Changeset [20354] by bdash

2007-03-20 Matt Lilek <pewtermoose@gmail.com>

Reviewed by Darin.

Clear up the steps necessary to get a patch landed.

http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

  • coding/contributing.html:
17:13 Changeset [23144] by aroben

Rubberstamped by Beth.

  • Skipped: Added the real crasher (arrow-navigation.html just fails, doesn't crash).
17:11 Changeset [20353] by thatcher

Build fix.

16:57 Changeset [20352] by thatcher

Reviewed by Kevin Decker.

Rolling out part of r19828 that caused a scrolling regression in Mail.

<rdar://problem/4820817> Message jumps around when trying to select text

  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::updateContents):
16:57 Changeset [20351] by mjs

Reviewed by Geoff and Adam.



  • fixed a threadsafety bug discovered by testing this


  • enhanced threadsafety assertions in collector
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't DropAllLocks around the finalize callback, because it gets called from garbage collection and we can't let other threads collect!
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kjs/JSLock.cpp: (KJS::JSLock::currentThreadIsHoldingLock): Added new function to allow stronger assertions than just that the lock is held by some thread (you can now assert that the current thread is holding it, given the new JSLock design).
  • kjs/JSLock.h:
  • kjs/collector.cpp: Refactored for portability plus added some stronger assertions. (KJS::Collector::allocate): (KJS::currentThreadStackBase): (KJS::Collector::registerAsMainThread): (KJS::onMainThread): (KJS::PlatformThread::PlatformThread): (KJS::getCurrentPlatformThread): (KJS::Collector::Thread::Thread): (KJS::destroyRegisteredThread): (KJS::Collector::registerThread): (KJS::Collector::markCurrentThreadConservatively): (KJS::suspendThread): (KJS::resumeThread): (KJS::getPlatformThreadRegisters): (KJS::otherThreadStackPointer): (KJS::otherThreadStackBase): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively): (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collectOnMainThreadOnly): (KJS::Collector::markMainThreadOnlyObjects): (KJS::Collector::collect):
  • kjs/collector.h:
  • wtf/FastMalloc.cpp: (WTF::fastMallocSetIsMultiThreaded):
  • wtf/FastMallocInternal.h:
  • wtf/Platform.h:
16:25 Changeset [23143] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed bogus extra linker options.
16:24 Changeset [20350] by beidson

Reviewed by John

<rdar://5071341> - Crash in IconLoader::finishLoading()


Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
Hyatt's recent caching changings to the IconLoader. This crash tends to hit on sites without favicons,
that serve up complex 404 pages, often when the load is cancelled or redirected. Occasionally, it *seems*
the IconLoader is getting failed/cancelled twice.


This patch adds some assertions and a "fail gracefully in a release build" check that will have to
serve us until we know more about the cause.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFail): Add an assertion to catch this case (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail gracefully in debug builds. Also add an efficiency check to not commit to the DB if there is no IconURL
16:15 Changeset [23142] by aroben

Reviewed by Beth.

  • Skipped: Added another crasher.
15:06 Changeset [23141] by aroben

Reviewed by Adele.

Added some tests that fail due to font metric differences.

  • Skipped:
15:01 Changeset [20349] by antti

Reviewed by Darin.


Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
really a good fix, smooth scrolling should be supported properly. It should do for now.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isScrollable):
  • rendering/RenderListBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::isScrollable):
  • rendering/RenderObject.h:
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::isScrollable):
  • rendering/RenderTextControl.h:
14:02 Changeset [23140] by adele

Reviewed by Adam.

Explicitly pass VK_RETURN when using keyDown for "\n".


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
13:47 Changeset [23139] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set libpath.
13:29 Changeset [23138] by bdakin

Reviewed by Adam.

Re-enabling fast/layers/removed-by-scroll-handler.html because
5072678 is fixed.

13:13 Changeset [20348] by bdakin

Reviewed by Geoff.

Covered by existing test case.

Fix for <rdar://problem/5072678> Crash in
RenderLayer::scrollRectToVisible with MallocScribble enabled

This removes some code that was added with http://bugs.webkit.org/
show_bug.cgi?id=8360. This code was not needed to fix that bug, but
the idea behind it was that there are times when it is safe for
scheduleEvent() to propagate the event immediately. The
MallocScribble crash revealed that this assumption was a bit too
broad; the cause of the crash was that we were propagating events
immediately when it was not safe. Mitz and I discussed this online
and we agree that the safest solution is to revert to the old
behavior here, and always delay the propagation of the event.

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::layout): (WebCore::FrameView::scheduleEvent):
12:56 Changeset [20347] by beidson

Reviewed by John Sullivan

Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::didReceiveResponse): (WebCore::IconLoader::didReceiveData): (WebCore::IconLoader::didFail): (WebCore::IconLoader::didFinishLoading):
12:09 Changeset [20346] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions

  • editing/pasteboard/5071074-2-expected.checksum: Added.
  • editing/pasteboard/5071074-2-expected.png: Added.
  • editing/pasteboard/5071074-2-expected.txt: Added.
  • editing/pasteboard/5071074-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links are pasted as plain text at certain positions


moveParagraphs calls createMarkup without annotation, which leaves
out anchor elements that aren't fully selected.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): We don't want createMarkup to do full annotation here. Doing so could include special ancestor blocks, which would prevent the copied content from appearing in the destination paragraph when it's re-inserted. Annotation would also inline styles from style sheets, which is unnecessary because the content is being moved to the same document it's being moved from. Added a new bool to createMarkup that when true allows markup for special ancestors as long as they are inline when annotation is off.
  • editing/markup.cpp: (WebCore::createMarkup): Don't set specialCommonAncestor if annotation is off, unless it's inline and we've been told it's ok to include such elements.
  • editing/markup.h:
11:48 Changeset [23137] by aroben

Reviewed by Ada.

Added null-checks for ResourceHandle::cookieStorage() before passing it
into CFNetwork functions, which are not null-safe.

  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
11:20 Changeset [23136] by aroben

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added XPathNodeSet.(cpp|h).
10:21 Changeset [20345] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12497
Implement XPath result ordering.

WebCore:

XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
to sort itself, and can remember whether it has been already sorted.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl: Added XPathNodeSet files.
  • xml/XPathExpression.cpp: Fixed includes.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted. (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunCount::evaluate): Ditto. (WebCore::XPath::FunSum::evaluate): Ditto.
  • xml/XPathNodeSet.cpp: Added. (WebCore::XPath::parentWithDepth): (WebCore::XPath::sortBlock): (WebCore::XPath::NodeSet::sort): Sort the node-set in document order. (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as parent or ancestor sorted). (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently implemented via fully sorting the node-set, but this can obviously be optimized. (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().


  • xml/XPathNodeSet.h: Added. (WebCore::XPath::NodeSet::NodeSet): (WebCore::XPath::NodeSet::operator=): (WebCore::XPath::NodeSet::size): (WebCore::XPath::NodeSet::isEmpty): (WebCore::XPath::NodeSet::operator[]): (WebCore::XPath::NodeSet::reserveCapacity): (WebCore::XPath::NodeSet::clear): (WebCore::XPath::NodeSet::swap): (WebCore::XPath::NodeSet::append): (WebCore::XPath::NodeSet::markSorted): (WebCore::XPath::NodeSet::isSorted): Most of these methods just call Vector counterparts.
  • xml/XPathParser.cpp: Updated the copyright notice.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet. (WebCore::XPath::Path::evaluate): Ditto. (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function always marks the result as unsorted, because it is hard to tell whether a step breaks node order. Identifying and implementing special cases when it is not necessary to do so is an important future optimization.
  • xml/XPathPath.h: Replacing NodeVector with NodeSet.
  • xml/XPathPredicate.cpp: (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet. (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just marks the result as unordered; we can consider using merge sort to avoid this.
  • xml/XPathResult.cpp: (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet. (WebCore::XPathResult::singleNodeValue): Ditto. (WebCore::XPathResult::snapshotLength): Ditto. (WebCore::XPathResult::iterateNext): Ditto. (WebCore::XPathResult::snapshotItem): Ditto. (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.
  • xml/XPathResult.h: Replacing NodeVector with NodeSet.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too. (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an attribute context node. (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
  • xml/XPathStep.h: Ditto.
  • xml/XPathUtil.cpp: (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child nodes, so passing such node as a context could cause problems.
  • xml/XPathUtil.h: Removed NodeVector typedef.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::Value): (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::Value::): (WebCore::XPath::Value::isNodeSet): Replacing NodeVector with NodeSet.

LayoutTests:

  • fast/xpath/document-order-expected.txt: Added.
  • fast/xpath/document-order.html: Added.
  • fast/xpath/text-nodes-expected.txt:
  • fast/xpath/text-nodes.html:
  • fast/xpath/4XPath/Core/test_step-expected.txt: Updated results for tests that now pass.
  • fast/xpath/xpath-test-pre.js: Added.
  • fast/xpath/4XPath/Core/test.js: Moved checkSnapshot() to a separate file.
  • fast/xpath/4XPath/Core/test_core_functions.html:
  • fast/xpath/4XPath/Core/test_location_path.html:
  • fast/xpath/4XPath/Core/test_nodeset_expr.html:
  • fast/xpath/4XPath/Core/test_parser.html:
  • fast/xpath/4XPath/Core/test_predicate_list.html:
  • fast/xpath/4XPath/Core/test_step.html: Load xpath-test-pre.js for checkSnapshot().
09:44 Open Source Contributors created by ddkilzer@webkit.org
Initial page with fake contributor.
09:37 WikiStart edited by ddkilzer@webkit.org
Added link to page for open source contributors. (diff)
08:18 Changeset [20344] by bdash

2007-03-21 Mark Rowe <mrowe@apple.com>

Build fix.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]):
08:11 Changeset [20343] by bdash

2007-03-21 Mark Rowe <mrowe@apple.com>

Reviewed by Tim Hatcher.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13129.
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

Some cross-language scripting bridges use the presence of -(int)count to determine
whether to treat objects as sequence-like. All WebScriptObject's exposed this method
which lead to non-collection WebScriptObject's being mishandled by PyObjC. We now
expose -count only when the object we wrap looks like a collection from a JavaScript
point of view (eg, it has a length property).

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject _shouldRespondToCount]): (-[WebScriptObject methodForSelector:]): (-[WebScriptObject respondsToSelector:]): (-[WebScriptObject _count]):
  • bindings/objc/WebScriptObjectPrivate.h:
07:51 Changeset [20342] by darin
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Fix obvious typo in the change from last night -- forgot to assign to the variable.
04:51 Changeset [23135] by andersca

WebKitWin:

Reviewed by Adam.

<rdar://problem/5050512>
Need invalid/expired certificate alerts


Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it
call down to WebCore.


  • Interfaces/IWebMutableURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
  • WebMutableURLRequest.h:
04:24 Changeset [23134] by aroben

Reviewed by Oliver.

Made the metrics of styled selects match those on the Mac to get
fast/forms/001.html passing.

04:22 Changeset [23133] by aroben

Rubberstamped by Anders.

Workaround a CFNetwork crash that affects DRT.

  • WebView.cpp: (WebView::initWithFrame): Commented out cookie storage initialization.
03:27 Changeset [23132] by aroben

Build fix.

  • WebView.cpp: Added missing #include.
03:18 Changeset [23131] by aroben

Build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::makeFinalRequest): Fix typo.
03:14 Changeset [23130] by aroben

WebKitToolsWin:

Reviewed by Oliver.

Implemented layoutTestController.setTabKeyCyclesThroughElements() to
fix fast/events/keypress-insert-tab.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Removed unnecessary string comparison.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (setTabKeyCyclesThroughElementsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented [set]TabKeyCyclesThroughElements.

  • Interfaces/IWebViewPrivate.idl: Added new declarations.
  • WebView.cpp: (WebView::setTabKeyCyclesThroughElements): Implemented. (WebView::tabKeyCyclesThroughElements): Implemented.
  • WebView.h: Updated.
02:45 Changeset [23129] by aroben

Reviewed by Oliver.

Implemented layoutTestController.clearBackForwardList() to fix
fast/dom/location-hash.html.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (clearBackForwardListCallback): Implemented.
02:13 Changeset [23128] by hyatt

Land advanced text ( turned off )

02:12 Changeset [23127] by hyatt

Land advanced text ( turned off )

02:11 Changeset [23126] by andersca

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable

  • platform/network/cf/ResourceHandleCFNet.cpp:


(WebCore::willSendRequest):
(WebCore::willCacheResponse):
Remove FIXMEs.


(WebCore::makeFinalRequest):
New function that makes a final CFURLRequest depending on cookie policy and whether any
invalid SSL certificates should be ignored.


(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::loadResourceSynchronously):
Use makeFinalRequest.


(WebCore::ResourceHandle::cookieStorageAcceptPolicy):
(WebCore::ResourceHandle::setCookieStorageAcceptPolicy):
(WebCore::ResourceHandle::cookieStorage):
(WebCore::ResourceHandle::setCookieStorage):
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
New functions for setting cookie policy, the deafult cookie storage and whether invalid
SSL certificates should result in an error.


  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest): Set cookie storage, cookie policy and SSL properties.
  • platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies): Use same functions as the mac (sorta).


(WebCore::cookiesEnabled):
Implement this.

WebKitWin:

Reviewed by Adam.

<rdar://problem/4921198>
Cookie acceptance policy not settable


  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Update the cookie storage accept policy.


(WebView::initWithFrame):
Initialize the cookie storage.

02:11 Changeset [20341] by hyatt

Refactor fonts a bit for portability.

02:06 Changeset [23125] by aroben

Reviewed by Oliver.

Remove Arial fonts because of <rdar://problem/5074441>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Don't install Arial.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Bold.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial Italic.ttf: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/Resources/Arial.ttf: Removed.
02:04 Changeset [20340] by aroben

Reviewed by Adam.

Stub out a couple of CFNetwork backend functions.


  • platform/network/ResourceHandle.h:
01:19 Changeset [23124] by oliver

2007-03-20 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.


Removing mouseover-mouseout2.html from skip list

  • Skipped:
01:10 Changeset [20339] by oliver

2007-03-19 Oliver Hunt <oliver@apple.com>

Reviewed by Ada.

Protect against possibility of JS detaching a frame (and losing its view)
midway through a mouse move.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):


00:39 Changeset [23123] by aroben

Reviewed by Ada.

  • Skipped: Added more international text tests, plus those that use textInputController.

03/19/07:

23:56 Changeset [23122] by aroben

Reviewed by Ada.

  • Skipped: Added tests that relay on DRT's built-in plugin, or on the QuickTime WebKit plugin.
22:58 Changeset [20338] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13107
XPath should raise an exception when trying to parse an unknown function

Test: fast/xpath/invalid-functions.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
  • xml/XPathGrammar.y: Handle nulls returned from createFunction().
22:47 Changeset [23121] by aroben

LayoutTestsWin:

Reviewed by Ada.

  • Skipped: Added some more international text tests.

WebKitToolsWin:

Reviewed by Ada.

Made DRT output UTF8 strings.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Convert to UTF8 before printing.
21:01 Changeset [23120] by aroben

Reviewed by Geoff.

Added support for --threaded.

Note that this always crashes right now due to
<rdar://problem/5051141> JavaScriptCore is not thread-safe,
but that's why we need this feature!

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Changed NULL to 0. (runTest): Ditto. (pthread_equal): Added. (javaScriptThreads): Ported from Mac. (runJavaScriptThread): Ditto. (startJavaScriptThreads): Ditto. (stopJavaScriptThreads): Ditto. (main): Parse --threaded argument and start/stop threads if needed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link against pthreadVC2.lib, and added include/pthreads to the include path.
19:45 Changeset [20337] by andersca

Reviewed by Dave Hyatt.

<rdar://problem/5067983>
iSale: Crash occurs at WebFrameLoaderClient::dispatchDecidePolicyForMIMEType() when attempting to load a HTML template


Restore old behavior (broke in r14533) where the resource load and download delegates are retained for as long as the
data source is loading.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createDocumentLoader):
  • WebView/WebDocumentLoaderMac.h:
  • WebView/WebDocumentLoaderMac.mm: (WebDocumentLoaderMac::setDataSource): (WebDocumentLoaderMac::decreaseLoadCount):
18:05 Changeset [20336] by darin
  • kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do it right later.
17:50 Changeset [20335] by ggaren

Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
documentation says "non-zero," not "1."

  • Misc/WebKitLogging.m: (WebKitRunningOnMainThread):
17:46 Changeset [20334] by ggaren

Reviewed by John Sullivan.

Fixed <rdar://problem/5073380> REGRESSION: Crash occurs at WTF::fastFree()
when reloading liveconnect page (applet)


Best to use free when you use malloc, especially when malloc and delete
use completely different libraries.

  • bindings/jni/jni_runtime.cpp: (JavaMethod::~JavaMethod):
17:30 Changeset [20333] by adele

LayoutTests:

Reviewed by Beth.

Test for http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

  • fast/forms/radio_checked_name-expected.txt: Added.
  • fast/forms/radio_checked_name.html: Added.

WebCore:

Reviewed by Beth.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

Test: fast/forms/radio_checked_name.html

We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still
allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name attribute, since we setChecked will now work with unnamed radio buttons. (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment. (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here. (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons. (WebCore::HTMLInputElement::defaultEventHandler): ditto.
17:27 Changeset [20332] by aroben

Rubberstamped by Oliver.

  • bridge/JavaScriptStatistics.cpp: Added missing header for correctness.
17:16 Changeset [20331] by andrew

JavaScriptCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

JavaScriptGlue:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Maciej.

Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

  • WebKit.xcodeproj/project.pbxproj:
17:13 Changeset [23119] by aroben

Build fix.

  • WebKit.vcproj/WebKitGUID.vcproj:
16:50 Changeset [20330] by darin

Reviewed by Geoff.

  • Changed list size threshold to 5 based on testing.

I was testing the i-Bench JavaScript with the list statistics
dumping on, and discovered that there were many 5-element lists.
The fast case for lists was for 4 elements and fewer. By changing
the threshold to 5 elements we get a measurable speedup. I believe
this will help real web pages too, not just the benchmark.

  • kjs/list.cpp: Change constant from 4 to 5.
16:36 Changeset [23118] by aroben

WebCoreWin:

Reviewed by Anders and Darin.

Added JavaScriptStatistics to the project for
<rdar://problems/5071653>.

  • WebCore.vcproj/WebCore.vcproj: Added include/pthreads to the include path, and added JavaScriptStatistics.(cpp|h).

WebKitToolsWin:

Reviewed by Anders and Darin.

Fix <rdar://problem/5071653> DumpRenderTree needs to be able to
trigger GC on a separate thread

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added GCController.(cpp|h) to the project.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Added. (collectCallback): (collectOnAlternateThreadCallback): (getJSObjectCountCallback): (getClass): (makeGCController):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::windowScriptObjectAvailable): Add the GCController to the window object.

WebKitWin:

Reviewed by Anders and Darin.

Added WebJavaScriptCollector for <rdar://problems/5071653>.

  • Interfaces/IWebJavaScriptCollector.idl: Added.
  • Interfaces/WebKit.idl:
  • WebJavaScriptCollector.cpp: Added. (WebJavaScriptCollector::WebJavaScriptCollector): (WebJavaScriptCollector::~WebJavaScriptCollector): (WebJavaScriptCollector::createInstance): (WebJavaScriptCollector::QueryInterface): (WebJavaScriptCollector::AddRef): (WebJavaScriptCollector::Release): (WebJavaScriptCollector::collect): (WebJavaScriptCollector::collectOnAlternateThread): (WebJavaScriptCollector::objectCount):
  • WebJavaScriptCollector.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added cases for WebJavaScriptCollector.
  • WebKitDLL.cpp: (DllGetClassObject): Ditto.
16:28 Changeset [20329] by darin
  • kjs/value.h: Oops, fix build.
16:12 Changeset [20328] by darin

Reviewed by Geoff.

  • remove ~JSValue; tiny low-risk performance boost
  • kjs/value.h: Remove unneeded empty virtual destructor from JSValue. The only class derived from JSValue is JSCell and it already has a virtual destructor. Declaring an empty constructor in JSValue had one good effect: it marked the destructor private, making it a compile time error to try to destroy a JSValue; but that's not a likely mistake for someone to make. It had two bad effects: (1) it caused gcc, at least, to generate code to fix up the virtual table pointer to point to the JSValue version of the virtual table inside the destructor of all classes derived from JSValue directly or indirectly; (2) it caused JSValue to be a polymorphic class so required a virtual table for it. It's cleaner to not have either of those.
15:54 Changeset [20327] by darin
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
15:39 Changeset [20326] by justing

LayoutTests:

Reviewed by darin

<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text

  • editing/pasteboard/5071074-expected.checksum: Added.
  • editing/pasteboard/5071074-expected.png: Added.
  • editing/pasteboard/5071074-expected.txt: Added.
  • editing/pasteboard/5071074.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5071074>
REGRESSION: Links that aren't fully selected copy and paste as only text


We stopped adding markup for all commonAncestorBlocks
and the ancestors of lastClosed up to them because it
was adding a lot of unnecessary markup.

  • editing/markup.cpp: (WebCore::createMarkup): Also include markup for nodes up to an enclosing anchor. Cleaned up the code for including special common ancestors a bit.
14:39 Changeset [23117] by aroben

Release build fix.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Set the include path for release to the same as for debug.
13:22 Changeset [23116] by aroben

Reviewed by Adele.

Fix eventSender.keyDown() to create WM_CHAR messages as well, since these
are needed by WebCore.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (dispatchMessage): Added. (mouseDownCallback): Call dispatchMessage instead of DispatchMessage. (doMouseUp): Ditto. (mouseClickCallback): Ditto. (doMouseMove): Ditto. (keyDownCallback): Ditto.
12:41 Changeset [20325] by zimmermann

Reviewed by Lars Knoll.

Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.

12:31 Changeset [20324] by adele

Reviewed by Hyatt.

  • page/Frame.cpp: (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
  • page/Frame.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout if not adjusting view size. (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree layout instead of just whether the root needs layout.
12:28 Changeset [20323] by zimmermann

Reviewed by Maciej.

Make JS function calls on POD-types (ie. SVGLength) take effect.
Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.

This worked fine before we switched to SVGLength POD type, so this
can be considered as P1 regression fix.

Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
doesn't work as expected - needs a seperated fix.

12:07 Changeset [23115] by aroben

Reviewed by Maciej.

Skip tests with international text due to <rdar://problems/4516194>.

  • Skipped:
11:21 Changeset [20322] by adele

Reviewed by Adam.

Adding comments and a little cleanup from my last checkin.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert. Added comment about how we use onChange. (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange. (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto. (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto. (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true. (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false. (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.
11:14 JavaScript and DOM Benchmarks edited by timothy@apple.com
(diff)
09:57 Changeset [20321] by zimmermann

Reviewed by Maciej.

Import Hixie's SVG testsuite. It highlights one bug, one regression in JS and one crash.
The crashing file is marked with "-disabled", the broken ones with "-broken".

Landing fixes for the certain bugs/regressions seperated.

06:17 Changeset [20320] by sullivan

Reviewed by Justin


  • fixed <rdar://problem/5071238> REGRESSION: opt-cmd-B to show Bookmarks view does nothing when form field has focus
  • WebView/WebHTMLView.mm: (-[WebHTMLView _handleStyleKeyEquivalent:]): we were counting any set of modifiers plus 'b' as the standard key equivalent for toggling Bold; now we only accept command+'b'
05:46 Changeset [20319] by bdash

2007-03-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Tim Hatcher.

Test: fast/innerHTML/additional-inline-style.html

  • editing/markup.cpp: (WebCore::startMarkup): Changed to add inline style based on CSS rules only in AnnotateForInterchange mode.

2007-03-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Tim Hatcher.

  • editing/pasteboard/paste-table-002-expected.txt:
  • fast/innerHTML/additional-inline-style-expected.txt: Added.
  • fast/innerHTML/additional-inline-style.html: Added.
  • webarchive/test-duplicate-resources-expected.txt:
  • webarchive/test-frameset-expected.txt:
  • webarchive/test-link-href-expected.txt:
02:32 Changeset [23114] by aroben

Reviewed by Hyatt.

Implemented some more layoutTestController methods:

  • display
  • testRepaint
  • repaintSweepHorizontally

The last two don't have any effect yet because we don't support pixel
tests yet (<rdar://problem/5071708>).

This gets all but one test in fast/repaint passing, and fixes various
other tests that use these methods as well.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declarations.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (displayCallback): Implemented. (testRepaintCallback): Implemented. (repaintSweepHorizontallyCallback): Implemented.
01:19 Changeset [20318] by zack

compile fix for qt

01:00 Changeset [20317] by aroben

WebCore:

Reviewed by Hyatt and Maciej.

Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
part of <rdar://problem/5071653>.

All layout tests pass.

  • WebCore.exp: Updated.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • bridge/JavaScriptStatistics.cpp: Moved from bridge/mac/WebCoreJavaScript.mm, and converted to C++. (WebCore::collect): (WebCore::JavaScriptStatistics::objectCount): (WebCore::JavaScriptStatistics::interpreterCount): (WebCore::JavaScriptStatistics::protectedObjectCount): (WebCore::JavaScriptStatistics::rootObjectTypeCounts): (WebCore::JavaScriptStatistics::garbageCollect): (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread): (WebCore::JavaScriptStatistics::shouldPrintExceptions): (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
  • bridge/JavaScriptStatistics.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Removed.
  • bridge/mac/WebCoreJavaScript.mm: Removed.

WebKit:

Reviewed by Hyatt and Maciej.

Updated WebCoreStatistics for the conversion of WebCoreJavaScript to
C++.

  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics javaScriptObjectsCount]): (+[WebCoreStatistics javaScriptInterpretersCount]): (+[WebCoreStatistics javaScriptProtectedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): Moved conversion to NSCountedSet here from WebCore. (+[WebCoreStatistics garbageCollectJavaScriptObjects]): (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThread:]): (+[WebCoreStatistics shouldPrintExceptions]): (+[WebCoreStatistics setShouldPrintExceptions:]): (+[WebCoreStatistics javaScriptReferencedObjectsCount]): (+[WebCoreStatistics javaScriptRootObjectClasses]):
00:49 Changeset [23113] by aroben

Build fix.

  • Interfaces/IWebView.idl:
00:40 Changeset [20316] by hyatt

Update SVG tests now that painting happens after onload.

00:36 Changeset [20315] by hyatt

Update tests for minimum font size change.

00:35 Changeset [20314] by hyatt

Update tests for minimum font size change.

00:34 Changeset [20313] by hyatt

Update tests for minimum font size change.

00:34 Changeset [20312] by hyatt

Update tests for minimum font size change.

00:32 Changeset [20311] by hyatt

Update the minimum font size pref to match the actual default setting in Safari. It should have been 1
all this time and not 9.

Reviewed by aroben

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree):
Note: See TracTimeline for information about the timeline view.