Timeline


and

03/27/07:

23:19 Changeset [20548] by sfalken
  • 7 edits
    1 add in branches/Safari-522

Merge fix from r20476.

23:10 Changeset [20547] by sfalken
  • 30 edits
    1 delete in branches/Safari-522

Merge fix from r20475.

22:05 Changeset [20546] by darin
  • 2 edits in trunk/LayoutTests
  • svg/hixie/text/003-expected.txt: Updated results for this one test that now has different results due to the painting Adele added to DumpRenderTree. Long term, we just have to fix SVG so that painting doesn't cause changes to the render tree!
21:22 Changeset [20545] by oliver
  • 3 edits
    4 adds in trunk

2007-03-27 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Don't enforce text-selection drag delay when we are
going to drag an image anyway.

Fixes rdar://problem/4668935

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):

Layout tests:

Test to ensure there is no delay forced when dragging a selected image

  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
16:38 Changeset [20544] by andersca
  • 5 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Call JSObject:call for native JavaScript objects.

LayoutTests:

Reviewed by Geoff.

Add NPN_InvokeDefault test.


  • plugins/netscape-invoke-default-expected.txt: Added.
  • plugins/netscape-invoke-default.html: Added.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Add new function which takes a function and calls it using NPN_InvokeDefault.
16:29 Changeset [20543] by justing
  • 2 edits in trunk/WebCore

Build fix


  • editing/markup.cpp: (WebCore::startMarkup):
15:55 Changeset [20542] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

Demonstrates the bug fixed:

  • editing/style/5091898-expected.checksum: Added.
  • editing/style/5091898-expected.png: Added.
  • editing/style/5091898-expected.txt: Added.
  • editing/style/5091898.html: Added. Demonstrates a related bug fixed (deleting the line break before a paragraph could remove its underlining):
  • editing/deleting/5091898-expected.checksum: Added.
  • editing/deleting/5091898-expected.png: Added.
  • editing/deleting/5091898-expected.txt: Added.
  • editing/deleting/5091898.html: Added. Demonstrates that a link now (correctly) exists, instead of just underlined text:
  • editing/pasteboard/4840662-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family


createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.

  • editing/markup.cpp: (WebCore::startMarkup): Add an inlineBlocks option. Make sure to overwrite display:block coming from a style sheet or the inline style declaration. (WebCore::createMarkup): Don't refuse to include a specialCommonAncestor that's a block if we were asked to include only inline content, since we can now inline block elements in startMarkup.
15:53 Changeset [20541] by adele
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

Oops- my comment was missing a word.

15:50 Changeset [20540] by adele
  • 2 edits in trunk/WebKitTools

Adding comment.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
15:41 Changeset [20539] by adele
  • 2 edits in trunk/WebKitTools

Fix svg tests by calling displayIfNeeded.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
15:13 Changeset [20538] by zbujtas
  • 12 edits in S60/trunk

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Rich File Upload implementation
http://bugs.webkit.org/show_bug.cgi?id=13195

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreFormControls.h:
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
15:10 Changeset [20537] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim


  • fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
14:59 Changeset [20536] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20456 and r20457.

14:58 Changeset [20535] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we
move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/5092361>.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
14:56 Changeset [20534] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20441.

14:52 Changeset [20533] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20425.

14:22 Changeset [20532] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20474.

14:18 Changeset [20531] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20473.

14:16 Changeset [20530] by thatcher
  • 5 edits in branches/Safari-522/WebKit

Merge fix from r20471.

14:14 Changeset [20529] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20461.

14:12 Changeset [20528] by thatcher
  • 3 edits in branches/Safari-522/WebKit

Merge build fix from r20427.

13:47 Changeset [20527] by thatcher
  • 4 edits in branches/Safari-522/WebCore

Merge fix from r20460.

13:45 Changeset [20526] by thatcher
  • 3 edits
    2 copies in branches/Safari-522

Merge fix from r20458.

13:43 Changeset [20525] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20454.

13:41 Changeset [20524] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20453.

13:39 Changeset [20523] by thatcher
  • 7 edits
    8 copies in branches/Safari-522

Merge fix from r20449.

13:35 Changeset [20522] by thatcher
  • 5 edits
    2 copies in branches/Safari-522

Merge fix from r20440.

13:29 Changeset [20521] by thatcher
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20419.

13:21 Changeset [23202] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Fix for 5090964, arabic text piled on top of itself.

13:09 Changeset [20520] by justing
  • 3 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • editing/pasteboard/5065605-expected.checksum: Added.
  • editing/pasteboard/5065605-expected.png: Added.
  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html: Added.
  • editing/style/4916887-expected.checksum: Added.
  • editing/style/4916887-expected.png: Added.
  • editing/style/4916887-expected.txt: Added.
  • editing/style/4916887.html: Added.
  • editing/style/5065910-expected.checksum: Added.
  • editing/style/5065910-expected.png: Added.
  • editing/style/5065910-expected.txt: Added.
  • editing/style/5065910.html: Added.
  • editing/style/5084241-expected.checksum: Added.
  • editing/style/5084241-expected.png: Added.
  • editing/style/5084241-expected.txt: Added.
  • editing/style/5084241.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): If a node's text fill color is invalid, then its children use their font-color as their text fill color (they don't inherit it). Likewise for stroke color.
13:07 Changeset [23201] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5085076> WebView stops painting after
loading stand-alone netflix movie preview in WMP format


The stand-alone WMP plug-in seems to do all its drawing in
the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
InvalidateRect call for plug-in windows needs to specify
'true' for whether the background region should be erased.


A smart plug-in that wants to avoid background draws can
still do so by just returning 1 in response to WM_ERASEBKGN,
or by setting its background brush to NULL.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
12:58 Changeset [20519] by yongjzha
  • 2 edits in S60/trunk/WebKit

yaharon, reviewed by <reviewer>

DESC: [S60] S60 3.2 Touch Help: Application crash when tapping scroll bar of XHTML topic
http://bugs.webkit.org/show_bug.cgi?id=13196

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::HandleScrollEventL):
11:06 Changeset [23200] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

<rdar://problem/5091459>
Crash when destroying "null plugin"


<rdar://problem/5056845>
Invoking itunes page has missing plugin icon on it


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paintMissingPluginIcon): Clip before painting.


(WebCore::freeStringArray):
Add null-check.


(WebCore::PluginViewWin::PluginViewWin):
Initialize plugin names and values.

09:40 Changeset [20518] by andersca
  • 2 edits in trunk/WebCore
  • platform/ScrollBar.h: Use wtf/MathExtras.h instead of math.h
06:02 Changeset [20517] by bdash
  • 1 edit in tags/Safari-4522.5.3/WebKit/Configurations/Version.xcconfig

Versioning.

06:02 Changeset [20516] by bdash
  • 2 edits in tags/Safari-4522.5.3/WebKit

Merge in r20513.

05:58 Changeset [20515] by bdash
  • 1 copy in tags/Safari-4522.5.3/WebKit

New tag (part 2).

05:57 Changeset [20514] by bdash
  • 1 add in tags/Safari-4522.5.3

New tag (part 1).

05:49 Changeset [20513] by bdash
  • 2 edits in trunk/WebKit

2007-03-27 Mark Rowe <mrowe@apple.com>

Reviewed by Dave Harrison.

  • Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
04:08 Changeset [20512] by zack
  • 2 edits in trunk/WebCore

Fix the build

03:02 Changeset [20511] by oliver
  • 2 edits
    1 add in trunk/WebCore

2007-03-27 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

The WebArchiver needs all the subresources of a document to be accessible
through the DocLoader, so we can't remove a CachedResource simultaneously
from the global Cache and all DocLoaders, just because it needs to be
reloaded in one.

Fixes rdar://problem/5044366

  • loader/Cache.cpp: (WebCore::Cache::remove):

Don't evict the resource from all DocLoaders

  • manual-tests/test-iframes-loading-the-same-resource.html: Added.

Alas it wasn't possible to make a nice layout test, even this manual test
is not entirely deterministic

02:14 Changeset [20510] by bdash
  • 2 edits in trunk/WebCore

2007-03-27 Mark Rowe <mrowe@apple.com>

Build fix.

  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
02:04 Changeset [20509] by zack
  • 3 edits in trunk/WebKitQt

Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port

01:59 Changeset [23199] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Add support for glyph offsets to the GlyphBuffer.

01:52 Changeset [20508] by hyatt
  • 3 edits in trunk/WebCore

Add support for glyph offsets to the GlyphBuffer.

01:32 Changeset [20507] by antti
  • 2 edits in trunk/WebCore

Keep buildbot happy.

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::scrollbarHit):
01:10 Changeset [23198] by antti
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Darin.


Initialize new m_isContinuous field in WheelEvent

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
01:03 Changeset [20506] by antti
  • 18 edits in trunk

WebCore:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCore.exp:

Export _wkGetWheelEventDeltas

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):

Remove (0, 0) scroll event hack, it is not needed anymore.
Do per-pixel scrolling for fine grained events.

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::isContinuous):

Add new m_isContinuous boolean to indicate fine grained wheel events.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value):

Use float to represent current position to support finer grained scrolling.
Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)

  • platform/ScrollTypes.h: (WebCore::):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkGetWheelEventDeltas for getting fine grained wheel events

  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Get the wheel deltas using new wkGetWheelEventDeltas interface

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight):

Pass item height to scrollbar

WebKit:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

Reviewed by Darin.


Added wkGetWheelEventDeltas

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
00:02 Changeset [23197] by hyatt
  • 6 edits in branches/WindowsMerge

Enable complex text.

03/26/07:

21:45 Changeset [23196] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

This one didn't actually have any leaks, but I just felt like doing the
same style cleanup as the others :)


  • WebPreferences.cpp: (WebPreferences::stringValueForKey): (WebPreferences::integerValueForKey): (WebPreferences::floatValueForKey): (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::save): (WebPreferences::load):
20:49 Changeset [20505] by ddkilzer
  • 2 edits in trunk

Added Radar references.

19:46 Changeset [20504] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

fixed up order of ChangeLog entries

19:36 Changeset [20503] by ggaren
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin Adler.


Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at
WebCore::Node::createRendererIfNeeded() when changing map views with MS
Virtual Earth (http://www.ziprealty.com/)

  • fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
  • fast/dom/mutation-event-remove-inserted-node.html: Added.
  • fast/dom/script-element-remove-self-expected.txt: Added.
  • fast/dom/script-element-remove-self.html: Added.

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
19:33 Changeset [23195] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

<rdar://5090412> - Plug CFNumberRef leaks in WebCache


  • WebCache.cpp: (WebCache::statistics):
18:57 Changeset [20502] by andersca
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Darin, landed by Anders.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142

The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636
introduced new JNIType to enum in jni_utility.h This is a
problem on the Mac as it seems that the JNIType enum is also
used in the JVM, it is used to specify the return type in
jni_objc.mm
Corrected the fix by moving type to the end, and changing
jni_objc.mm to convert the new type to an old compatible
type.

  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_utility.h:

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
18:11 Changeset [20501] by aroben
  • 5 edits in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13198: Move build settings from project file to xcconfig file for apollo
port JSCore
http://bugs.webkit.org/show_bug.cgi?id=13198

  • Moving build settings from xcode project file to xcconfig files.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
17:12 Changeset [23194] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

Fix build without breaking anything.

  • WebHistory.cpp: (releaseUserInfo): Added silly void statement for now.
16:55 Changeset [23193] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Rubber-stamped by Brady.

Build fix for release build.

  • WebHistory.cpp: (releaseUserInfo): Do not store userInfo->Release() in a local variable since it is only used for an ASSERT.
16:52 Changeset [20500] by beidson
  • 3 edits in trunk/JavaScriptCore

Rubberstamped by Anders and Maciej aand Geoff (oh my!)


Since CFTypeRef is really void*, a RetainPtr couldn't be used.
RefType was "void", which doesn't actually exist as a type.
Since RefType only existed for operator*(), and since that operator
doesn't make any sense for RetainPtr, I removed them!

  • kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the compiler with dependencies
  • wtf/RetainPtr.h: Nuke RefType and operator*()
16:46 Changeset [20499] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.png: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
  • fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/replaced/selection-rect-in-table-cell.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
15:09 Changeset [20498] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison


  • fixed <rdar://problem/4769772> Problem with Find on certain PDF page
  • WebView/WebPDFView.mm: (-[WebPDFView _scaledAttributedString:]): We were hitting an exception trying to set the font attribute to nil, which was happening because the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now filed separately, but this works around the exception.
13:55 Changeset [23192] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.


<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

  • WebIconDatabase.cpp: (userIconDatabasePath): Move icon database to non-roaming location
13:32 Changeset [20497] by ggaren
  • 2 edits in trunk/JavaScriptCore

Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

  • kjs/nodes.cpp: (Node::deref):
13:31 Changeset [20496] by ggaren
  • 9 edits in trunk/WebCore

Removed now-stale #includes of <assert.h>.


  • WebCorePrefix.h:
  • config.h:
  • css/CSSGrammar.y:
  • platform/Arena.cpp:
  • platform/KURL.cpp:
  • platform/SegmentedString.h:
  • rendering/DataRef.h:
  • rendering/RenderArena.cpp:
13:08 Changeset [20495] by ggaren
  • 56 edits in trunk/WebCore

Reviewed by Kevin McCulough.

Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
one instance of commented-out code containing "assert(" instead of replacing it.

13:00 Changeset [23191] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page


Fixes test: fast/forms/control-restrict-line-height.html


This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons,
buttons and search fields.


09:57 Changeset [20494] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."

03/25/07:

21:10 Changeset [20493] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Put !important on right/wrong colors so they override the green color that comes from the green.css stylesheet.
21:07 Changeset [20492] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple minor wording tweaks.
21:05 Changeset [20491] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.
20:54 Changeset [23190] by beidson
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver

<rdar://problem/5086888> - WebHistory(Item) Leak

  • platform/win/COMPtr.h: (COMPtr::COMPtr): An an adoptRef constructor


WebKitWin:

Reviewed by Oliver


<rdar://problem/5086888> - WebHistory(Item) Leak


This is a pretty thourough touchup up style and correctness that
plugs at least 1 definite leak and many potential leaks with
extensive use of RetainPtr and COMPtr.


This should result in no change in behavior

  • MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
  • MarshallingHelpers.h: Ditto


  • WebHistory.cpp: (createUserInfoFromArray): (createUserInfoFromHistoryItem): (releaseUserInfo): (WebHistory::WebHistory): (WebHistory::~WebHistory): (WebHistory::loadFromURL): (createHistoryListFromStream): Split of the Structured Exception Handling to a seperate function to cooperate with C++ (WebHistory::loadHistoryGutsFromURL): (WebHistory::saveToURL): (WebHistory::saveHistoryGuts): (WebHistory::datesArray): (WebHistory::addItems): (WebHistory::removeItems): (WebHistory::removeAllItems): (WebHistory::orderedLastVisitedDays): (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::removeItem): (WebHistory::addItem): (WebHistory::addItemForURL): (WebHistory::itemForURLString): (WebHistory::itemForURL): (WebHistory::containsItemForURLString): (WebHistory::removeItemForURLString): (WebHistory::addItemToDateCaches): (WebHistory::removeItemFromDateCaches): (WebHistory::findIndex): (WebHistory::insertItem): (WebHistory::ageLimitDate):
  • WebHistory.h:


  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::mergeAutoCompleteHints):
16:45 Changeset [23189] by aroben
  • 2 edits
    4 adds in branches/WindowsMerge/LayoutTests

LayoutTestsWin:

Reviewed by Anders.

Fix <rdar://problem/5066290> boomer-run-webkit-tests doesn't support
http tests

  • Skipped: Removed http tests from the skipped list.
  • http/conf/cygwin-httpd.conf: Added.
  • http/conf/libphp4.dll: Added.
15:42 Changeset [20490] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adam.


Test for <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

  • editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
  • editing/pasteboard/drag-drop-dead-frame.html: Added.

WebCore:

Reviewed by Adam.

Fix <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

Null check frame in m_dragTarget, it might be gone already.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop):
13:14 Changeset [23188] by aroben
  • 11 edits
    4 adds in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Oliver.

  • Skipped: Added two more crashers for when we enable http tests.

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Ported Mac code to check the MIME type before dumping. (runTest): Clear the work queue before each test.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Only dump if the work queue is empty. (jsValueToCString): Added. (queueLoadCallback): Added. (queueReloadCallback): Added. (queueScriptCallback): Added. (queueBackNavigationCallback): Added. (queueForwardNavigationCallback): Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::processWork): Added. (processWorkTimer): Added. (WaitUntilDoneDelegate::locationChangeDone): Changed to match Mac.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Added declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Added. (WorkQueue::shared): (WorkQueue::WorkQueue): (WorkQueue::queue): (WorkQueue::dequeue): (WorkQueue::count): (WorkQueue::clear):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Added. (WorkQueue::setFrozen):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Added. (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script): (BackItem::BackItem): (ForwardItem::ForwardItem):

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • WebFrame.cpp: (WebFrame::findFrameNamed): Implemented.
  • WebHistoryItem.cpp: (WebHistoryItem::children): Don't increment i twice per loop!
08:10 Changeset [20489] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-26 Mark Rowe <mrowe@apple.com>

Reviewed by Sam Weinig.

Upload crash logs from DumpRenderTree as part of the test results to ease debugging
of hard-to-reproduce crashes.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
03:33 Changeset [20488] by bdash
  • 2 edits in trunk/WebKitSite

2007-03-25 Mark Rowe <mrowe@apple.com>

Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity.

  • coding/RefPtr.html:
03:25 Changeset [23187] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebDownload.h: Include RetainPtr from WTF.
01:39 Changeset [20487] by ap
  • 6 edits in trunk/WebCore

Reviewed by Darin.

A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document from being destroyed in time.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
  • dom/ContainerNode.h: (WebCore::ContainerNode::fastSetFirstChild): (WebCore::ContainerNode::fastSetLastChild): Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeMatches):
  • xml/XPathStep.h: Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
00:43 Changeset [20486] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: A couple wording tweaks.
00:11 Changeset [20485] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document, suggested by Anders.

03/24/07:

23:52 Changeset [20484] by darin
  • 2 edits in trunk/WebKitSite
  • css/main.css: Try tighter spacing for code examples.
23:48 Changeset [20483] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: <span> -> </span>
23:44 Changeset [20482] by darin
  • 2 edits in trunk/WebKitSite
  • coding/RefPtr.html: "smart pointer" -> "smart pointers"
23:38 Changeset [20481] by darin
  • 17 edits
    1 add in trunk/WebKitSite
  • coding/RefPtr.html: Added. First draft of a document about RefPtr.

Also tweaked the MIME types of a few files and removed a stray executable bit.

23:37 Changeset [20480] by hyatt
  • 2 edits in trunk/WebKit

Amend the statistics reporting for the WebCore cache to include XSL and to report live/decoded sizes.

  • Misc/WebCache.mm: (+[WebCache statistics]):
23:28 Changeset [20479] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/midword-break-after-breakable-char-expected.checksum: Added.
  • fast/text/midword-break-after-breakable-char-expected.png: Added.
  • fast/text/midword-break-after-breakable-char-expected.txt: Added.
  • fast/text/midword-break-after-breakable-char.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/text/midword-break-after-breakable-char.html

Breaking in the middle of the word
is allowed only if no breaking opportunity between words has occurred yet. The
first position on the line should not be considered "between words" even if
it is a breaking opportunity.


  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed according to the above. Also cleaned up a couple of lines.
22:53 Changeset [20478] by hyatt
  • 13 edits in trunk/WebCore

Fix for bugzilla bug 13187, place a hard limit on the amount of decoded data that WebCore will keep
around even on live pages (pages being displayed in tabs/windows or in the back/forward cache).
Images will decode to paint and once the decoded data exceeds the cache size, the decoded data will be
tossed.

Refine the flushing algorithm to apply the two-pass decode/evict model to each LRU-SP queue individually, rather
than to all the lists at once. This allows the cache to evict large encoded resources before flushing small
or frequently accessed decoded onces.

Added information on live/decoded data to the cache statistics.

Reviewed by darin

  • loader/Cache.cpp: (WebCore::Cache::Cache): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneAllResources): (WebCore::Cache::setMaximumSize): (WebCore::Cache::remove): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::liveLRUListFor): (WebCore::Cache::removeFromLiveResourcesList): (WebCore::Cache::insertInLiveResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::getStatistics):
  • loader/Cache.h: (WebCore::Cache::TypeStatistic::TypeStatistic):
  • loader/CachedImage.cpp: (WebCore::CachedImage::decodedSizeWillChange): (WebCore::CachedImage::decodedSizeChanged):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::ref): (WebCore::CachedResource::deref): (WebCore::CachedResource::setEncodedSize): (WebCore::CachedResource::liveResourceAccessed):
  • loader/CachedResource.h: (WebCore::CachedResource::liveAccessCount): (WebCore::CachedResource::resetLiveAccessCount): (WebCore::CachedResource::increaseLiveAccessCount):
  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::destroyDecodedData): (WebCore::BitmapImage::cacheFrame):
  • platform/graphics/ImageObserver.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):
22:14 Changeset [23186] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-24 Steve Falkenburg <sfalken@apple.com>

Build fix.

  • WebDownload.h: Remove WebCore namespace
21:31 Changeset [23185] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

Unfortunately the ported code is mostly untested due to
<rdar://problem/5086934>.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (compareHistoryItems): Ported from Mac. (dumpHistoryItem): Ditto. (dumpBackForwardList): Ditto. (dump): Dump the back-forward list if requested. (runTest): Initialize new globals.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpBackForwardListCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
layoutTestController.dumpBackForwardList

  • Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
  • WebFrame.cpp: (WebFrame::childFrames): Removed unused variable.
  • WebHistoryItem.cpp: (WebHistoryItem::target): Implemented. (WebHistoryItem::isTargetItem): Implemented. (WebHistoryItem::children): Implemented.
  • WebHistoryItem.h: Added declarations.
19:48 Changeset [20477] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Mitz.

  • fast/css/css-selector-text-expected.txt: Added.
  • fast/css/css-selector-text.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/css/css-selector-text.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::selectorText): Add the namespace prefix for tag or attribute names, the sub-selector for :not, and the argument for :lang.
18:27 Changeset [23184] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix <rdar://problem/5076610> Crash in PluginViewWin::updateWindow when
loading a PDF page for the first time after installing Acrobat Reader

Don't call PluginPackageWin::load() until the PluginViewWin has been
inserted into the Widget tree. load() can result in arbitrary code
execution (in this case, a EULA window appears which takes focus from
the WebView, causing Frame::setIsActive(false) to be called), and we
don't want to be in a transitional state when that happens.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView): Call PluginViewWin's one and only constructor.
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setParent): Call init() after inserting ourselves into the Widget tree. (WebCore::PluginViewWin::PluginViewWin): Defer all real work until init() is called. (WebCore::PluginViewWin::init): Added. Calls m_plugin->load(), then does the rest of the work that was once done by the constructor.
  • plugins/win/PluginViewWin.h: Removed createNullPlugin and simplified constructor, added setParent override and new init method.
18:22 Changeset [20476] by beidson
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Adam

Whoops, RetainPtr should be in the WTF namespace

  • wtf/RetainPtr.h:

WebKit:

Reviewed by Adam

RetainPtr is no longer in the WebCore namespace

  • History/WebBackForwardList.mm:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView/WebDocumentLoaderMac.h:
16:27 Changeset [23183] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF for WebKitWin and the App

  • WebCore.vcproj/WebCore.vcproj: Add the ForwardingHeader to the vcprojs
16:21 Changeset [20475] by beidson
  • 30 edits
    1 move
    2 adds in trunk

JavaScriptCore:

Reviewed by Adam


<rdar://problem/5086210> - Move RetainPtr to WTF

WebCore:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF

  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCore/RetainPtr.h


  • history/HistoryItem.h: Changed #include to <wtf/RetainPtr.h>
  • history/PageCache.h: Ditto
  • page/mac/WebCoreFrameBridge.mm: Ditto
  • platform/ContextMenu.h: Ditto
  • platform/ContextMenuItem.h: Ditto
  • platform/DragImage.h: Ditto
  • platform/FileChooser.h: Ditto
  • platform/PlatformKeyboardEvent.h: Ditto
  • platform/PopupMenu.h: Ditto
  • platform/SharedBuffer.h: Ditto
  • platform/cf/RetainPtr.h: Removed.
  • platform/graphics/Icon.h: Changed #include
  • platform/mac/ClipboardMac.h: Ditto
  • platform/mac/PasteboardMac.mm: Ditto
  • platform/mac/WidgetMac.mm: Ditto
  • platform/network/AuthenticationChallenge.h: Ditto
  • platform/network/ResourceError.h: Ditto
  • platform/network/ResourceHandle.h: Ditto
  • platform/network/ResourceRequest.h: Ditto
  • platform/network/ResourceResponse.h: Ditto
  • rendering/RenderThemeMac.mm: Ditto

WebKit:

Reviewed by Adam

<rdar://problem/5086210> - Move RetainPtr to WTF


  • ForwardingHeaders/wtf/RetainPtr.h: Added.
  • History/WebBackForwardList.mm: Changed #import to <wtf/RetainPtr.h>
  • WebCoreSupport/WebEditorClient.h: Ditto
  • WebCoreSupport/WebFrameLoaderClient.h: Ditto
  • WebView/WebDocumentLoaderMac.h: Ditto
16:15 Changeset [20474] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086797>, layoutPending is now reporting incorrect results, which will lead
to all sorts of layout issues. This is in bugzilla as 13179.

Reviewed by hyatt

Moved the root->needsLayout() check from layoutPending() to needsLayout()
to restore the behavior before r20324.

  • page/FrameView.cpp: (WebCore::FrameView::layoutPending): (WebCore::FrameView::needsLayout):
15:13 Changeset [20473] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Adele.

<rdar://problem/5084478>

Another debug build crash from ASSERTION FAILED: !needsLayout()

No test possible because updateRendering() is always called after script
execution.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Get the layout root after calling recalcStyle() since a style recalc may result in needing to do start layout at the root.
14:53 Changeset [20472] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed. Build fix.
Fix FloatRect vs. IntRect confusion.

10:25 Changeset [20471] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Adele

  • fixed <rdar://problem/5084872> Need to add flickr to spoof list in WebKit
  • only do site-specific spoofing if a preference is set
  • WebView/WebPreferenceKeysPrivate.h: added WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferences.m: (+[WebPreferences initialize]): initialize WebKitUseSiteSpecificSpoofingPreferenceKey to false (-[WebPreferences _useSiteSpecificSpoofing]): get value of WebKitUseSiteSpecificSpoofingPreferenceKey (-[WebPreferences _setUseSiteSpecificSpoofing:]): set value of WebKitUseSiteSpecificSpoofingPreferenceKey


  • WebView/WebPreferencesPrivate.h: declare _useSiteSpecificSpoofing and _setUseSiteSpecificSpoofing


  • WebView/WebView.mm: cache the value of WebKitUseSiteSpecificSpoofingPreferenceKey in a bool in _private (-[WebView _preferencesChangedNotification:]): update the cached value (-[WebView setPreferences:]): ditto (-[WebView WebCore::_userAgentForURL:WebCore::]): Only spoof here if the new site-specific spoofing preference is enabled. If it is, pass Safari 2.0.4's user agent string for flickr.com. We can remove this case when 5081617 is addressed.
06:26 Changeset [20470] by bdash
  • 2 edits in trunk/WebCore

Fix incorrect radar number.

05:27 Changeset [20469] by zimmermann
  • 3 edits
    4 adds in trunk

Reviewed by Oliver.

Fix all known RenderSVGImage problems.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12126 (RenderSVGImage seems to suffer from integer overflow)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12442 (raster images disappearing during script execution (SVG))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12572 (WebKit does not properly invalidate image region after image load)

Added test: svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html

03:25 Changeset [20468] by bdash
  • 2 edits in trunk/WebCore

2007-03-24 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize):
03:16 Changeset [20467] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5086400>, images scrolled offscreen continue to animate. Safari 2 would
halt animations when images were no longer visible.

Reviewed by mjs, olliej

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
02:24 Changeset [20466] by bdash
  • 1 edit in tags/Safari-4522.5.2/JavaScriptGlue/Configurations/Version.xcconfig

Versioning.

02:24 Changeset [20465] by bdash
  • 2 edits in tags/Safari-4522.5.2/JavaScriptGlue

Merge in r20461.

02:22 Changeset [20464] by bdash
  • 1 copy in tags/Safari-4522.5.2/JavaScriptGlue

New tag (part 2).

02:21 Changeset [20463] by bdash
  • 1 add in tags/Safari-4522.5.2

New tag (part 1).

02:20 Changeset [20462] by bdash
  • 2 edits in trunk/JavaScriptGlue

2007-03-24 Mark Rowe <mrowe@apple.com>

Reviewed by Dave Hyatt.

  • JavaScriptGlue.xcodeproj/project.pbxproj: Use GCC 4.0 for testjsglue.
00:07 Changeset [20461] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/508328>, sluggish text entry in search field. Make sure
our size actually changed before we decide to do a full repaint because of background/border
complexities.

Reviewed by aroben

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):

03/23/07:

23:24 Changeset [20460] by hyatt
  • 4 edits in trunk/WebCore

Fix Gmail spurious glyphs issue.

21:38 Changeset [20459] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • editing/selection/doubleclick-crash-expected.checksum:
  • editing/selection/doubleclick-crash-expected.png:
  • fast/text/selection-hard-linebreak-expected.checksum: Added.
  • fast/text/selection-hard-linebreak-expected.png: Added.
  • fast/text/selection-hard-linebreak-expected.txt: Added.
  • fast/text/selection-hard-linebreak.html: Added.

WebCore:

Reviewed by Adele.

  • fix a bug where selecting across a soft line break did not highlight to the end of the first line if it contained skipped whitespace

Test: fast/text/selection-hard-linebreak.html

  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): Changed to treat a selection that ends on the end of a hard line break as if it ends after the line break. Fixed the case of a selection that starts and ends in the same text object as the box but does not intersect it to return SelectionNone instead of selectionBoth.
21:05 Changeset [20458] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/frames/hover-timer-crash-expected.txt: Added.
  • fast/frames/hover-timer-crash.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/frames/hover-timer-crash.html

  • page/Frame.cpp: (WebCore::Frame::setView): Added a call to EventHandler::clear().
20:56 Changeset [23182] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam


<rdar://5086194> - WebHistory overreleases a CFNumber


  • WebHistory.cpp: (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't legitimately get a ref for!
18:41 Changeset [23181] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
hacks" menu item to the Debug menu

Added new IWebPrivate::setAllowSiteSpecificHacks SPI.

  • Interfaces/IWebViewPrivate.idl: Added declaration.
  • WebView.cpp: (WebView::userAgentForKURL): Only give a site-specific UA if site-specific hacks are turned on. (WebView::setAllowSiteSpecificHacks): Added.
  • WebView.h: (WebView::allowSiteSpecificHacks): Added.
18:18 Changeset [20457] by justing
  • 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Forgot to include these nil checks in my previous checkin.

17:58 Changeset [20456] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/pasteboard/5078739-expected.txt: Added.
  • editing/pasteboard/5078739.html: Added.

WebCore:

Reviewed by adele

<rdar://problem/5078739>
Crash in in ReplaceSelectionCommand if the fragment contains only a style span

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Check for an empty fragment after removing a redundant style span instead of before.
15:54 Changeset [23180] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5083928> In editable webviews, caps lock key is ignored

  • platform/win/KeyEventWin.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Removed code to store lowercase characters in m_text. Now that we use the character code to create m_text this is already taken care of. This does mean that m_unmodifiedText is not right. This is used for accesskeys, which don't work yet, so that is covered in rdar://5085596. This also fixes line endings in this file.
15:32 Changeset [23179] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5083914> Cursor is wrong for all context
menus

  • WebView.cpp: (WebView::handleContextMenuEvent): Set the cursor to the pointer cursor.
15:26 Changeset [20455] by aroben
  • 3 edits
    2 adds in trunk/JavaScriptCore

Reviewed/landed by Adam.

Bug 13175: Make apollo mac project files for JavaScriptCore actually
build something
http://bugs.webkit.org/show_bug.cgi?id=13175

  • JavaScriptCore.apolloproj/ForwardingSources/grammar.cpp: Added.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
14:48 Changeset [20454] by hyatt
  • 2 edits in trunk/WebCore

<rdar://problem/5085063>

Fix non-looping animation on cuteoverload.com. Just always flush
decoded data for large animated images to avoid our cache getting
out of sync with the image source.

Reviewed by ggaren

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::advanceAnimation):
14:09 Changeset [20453] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/5061024> REGRESSION: Returning false from onkeypress event on Input is ignored when key is Tab
http://bugs.webkit.org/show_bug.cgi?id= 13020

No known way to add a layout test for this. We would need a way to know exactly how the event was consumed.

  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): If the keypress event has its default behavior prevented, then we should consider the keydown event handled.
13:53 Changeset [20452] by brmorris
  • 2 edits in S60/trunk/WebCore

rathnasa, reviewed by zalan

DESC: [S60] ESMS-6YDMWP: TRUE - GSM - broswer crashes on certain web pages
Quick fix to validate null pointers
http://bugs.webkit.org/show_bug.cgi?id=13074

13:53 Changeset [23178] by aroben
  • 2 edits in branches/WindowsMerge

Being a Boy Scout.

13:50 Changeset [23177] by aliceli1
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Reviewed by Adam.

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
13:49 Changeset [23176] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by NOBODY (OOPS!).

Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit

  • WebView.cpp: (WebView::userAgentForKURL): added flickr spoof
13:48 Changeset [20451] by zbujtas
  • 2 edits in S60/trunk/WebCore

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
13:43 Changeset [20450] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-23 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: onFocus/onClick could destroy the node (and the associated rendered) under the cursor. fix to check
if the renderer is still valid.
http://bugs.webkit.org/show_bug.cgi?id=13172

  • kwq/KWQKHTMLPart.cpp:
13:42 Changeset [20449] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin

Fixed (was missing a newline):

  • editing/execCommand/4917055-expected.txt: Tests setting a caet before the image and changing its alignment:
  • editing/execCommand/5080333-1-expected.checksum: Added.
  • editing/execCommand/5080333-1-expected.png: Added.
  • editing/execCommand/5080333-1-expected.txt: Added.
  • editing/execCommand/5080333-1.html: Added. Tests selecting the image and changing its alignment:
  • editing/execCommand/5080333-2-expected.checksum: Added.
  • editing/execCommand/5080333-2-expected.png: Added.
  • editing/execCommand/5080333-2-expected.txt: Added.
  • editing/execCommand/5080333-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5080333>
REGRESSION: Selection changes when changing the alignment of an image


Regression occurred when we started using moveParagraphs
to move content in applyBlockStyle. moveParagraphs
moves by copying, deleting and reinserting content, and
so must be accompanied by selection preservation code.
That code uses rangeFromLocationAndLength and rangeLength,
which use TextIterators, which don't emit anything for images
and other replaced elements, causing this bug.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Ask rangeLength and rangeFromLocationAndLength to request that their TextIterators emit spaces for replaced elements. Use rangeCompliantEquivalent()s when creating a Range from VisiblePositions, since some VisiblePositions have illegal deepEquivalent()s.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ditto.
  • editing/TextIterator.cpp: (WebCore::TextIterator::TextIterator): (WebCore::TextIterator::handleReplacedElement): Emit a space if requested. (WebCore::TextIterator::representNodeOffsetZero): Emit ranges before m_node, not around m_lastTextNode. These ranges should represent the part of the document associated with the emitted character. (WebCore::TextIterator::rangeLength): Take in the new bool. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto. Also, don't loop an extra time after finding the end of the range when we're looking for zero length ranges. This appeared to be a workaround for the bugs fixed in representNodeOffsetZero in this patch.
  • editing/TextIterator.h:
13:05 Changeset [20448] by bdash
  • 4 edits in tags/Safari-4522.5.1

Versioning.

13:03 Changeset [20447] by bdash
  • 8 edits in tags/Safari-4522.5.1

Merge in r20445.

12:58 Changeset [20446] by bdash
  • 1 copy in tags/Safari-4522.5.1

New tag.

12:51 Changeset [20445] by bdash
  • 8 edits in trunk

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/JavaScriptGlue.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebCore.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.

2007-03-24 Mark Rowe <mrowe@apple.com>

Rubber-stamped by Darin.

  • Configurations/WebKit.xcconfig: Remove unnecessary INFOPLIST_PREPROCESS.
12:13 Changeset [20444] by zbujtas
  • 2 edits in S60/trunk/WebCore

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Fix NULL pointer check for CacheImage
http://bugs.webkit.org/show_bug.cgi?id=13094

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NavigableNodeUnderCursor):
11:39 Changeset [20443] by darin
  • 2 edits in trunk/WebCore
  • html/HTMLBodyElement.cpp: Fix comment typo.
11:38 Changeset [20442] by staikos
  • 2 edits in trunk/WebCore

Patch from Adam Treat to make the Qt build work without SVG and XSLT as well as
with.

11:25 Changeset [20441] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5074439> handle margins on frame and iframe elements without involving FrameView, FrameLoader, etc.
  • html/HTMLBodyElement.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument): Grab the margin from the frame directly here. There was no real benefit to doing this via FrameView. Later we can delete quite a bit of unneeded code here and in WebKit that exists only to set up the margin values in FrameView, which are now unused.
11:24 Changeset [20440] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-hidden-value.html: Added.
  • fast/forms/input-value-expected.txt:

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5080428> REGRESSION: getting value for hidden input element fails after the fix for Bug 11866
http://bugs.webkit.org/show_bug.cgi?id=13121

Rolled out the change for 11866 that made hidden input elements store the value separately from the value attribute.
Added an m_originalValue field that gets set when the element is done being parsed (in closeRenderer). In reset,
use the m_originalValue for hidden input elements.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::closeRenderer): (WebCore::HTMLInputElement::reset): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
  • html/HTMLInputElement.h:
11:01 Changeset [20439] by staikos
  • 2 edits in trunk/WebKitTools

Patch by Adam Treat. Removes hardcoded path to .pro file.

10:48 Changeset [20438] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
10:45 Changeset [20437] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: When leaving a secure web page, the query "Leaving a secure web page. Continue?" is shown twice
http://bugs.webkit.org/show_bug.cgi?id=13160
TSW ID: PNIO-6T5GMC

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::CheckForSecurityStatusChange):
08:08 Changeset [20436] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
08:07 Changeset [20435] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-20 spadma <sachin.padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser closes when clicked RSS20 feed icons on motime web
http://bugs.webkit.org/show_bug.cgi?id=13131
TSW ID: AKKO-6Z3AM2


  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::HandleError):
08:05 Changeset [20434] by spadma
  • 4 edits in S60/trunk

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
08:02 Changeset [20433] by spadma
  • 4 edits in S60/branches/3.1m

2007-03-20 sareen

Reviewed by Zalan/Sachin.
DESC: Pointer cannot be moved after opening flash to player and returning to page ( MLIO-6YEGYC )
http://bugs.webkit.org/show_bug.cgi?id=13014

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreBridge.cpp: (CWebCoreBridge::NodeTypeB):
07:57 Changeset [20432] by spadma
  • 2 edits in S60/trunk/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
07:56 Changeset [20431] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-03-22 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by zbujtas@gmail.com
DESC: [S60] Some images crash when browsing some wap page - TKWG-6Z59YX in 3.1m branch
Fix: Remove extra image content-type strings added by the server before passing it to the image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13151

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::ConstructL):
04:47 Changeset [23175] by aroben
  • 9 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Oliver.

Implemented dumping of frame scroll positions.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dumpFrameScrollPosition): Ported from Mac. (dump): Added call to dumpFrameScrollPosition. (runTest): Initialize new global.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Added extern declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (dumpChildFrameScrollPositionsCallback): Implemented.

WebKitWin:

Reviewed by Oliver.

Implemented some WebFrame methods to support dumping frame scroll
offsets in DRT.

  • Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
  • Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
  • WebFrame.cpp: (WebFrame::name): Implemented. (WebFrame::childFrames): Implemented. (WebFrame::scrollOffset): Implemented.
  • WebFrame.h: Updated/added declarations.
04:41 Changeset [20430] by bdash
  • 1 edit in trunk/WebCore/ChangeLog

Add radar reference.

04:37 Changeset [20429] by bdash
  • 3 edits
    4 adds in trunk

2007-03-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/lists/marker-image-error.html

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::imageChanged): Mark ourselves for relayout if the image failed to load, since that means we will use a bullet instead.

2007-03-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/lists/marker-image-error-expected.checksum: Added.
  • fast/lists/marker-image-error-expected.png: Added.
  • fast/lists/marker-image-error-expected.txt: Added.
  • fast/lists/marker-image-error.html: Added.
04:23 Changeset [20428] by zack
  • 2 edits in trunk/WebCore

Fix the compile

02:25 Changeset [20427] by bdash
  • 3 edits in trunk/WebKit

2007-03-23 Mark Rowe <mrowe@apple.com>

Build fix for when BUILDING_ON_TIGER is not defined.

  • Misc/WebTypesInternal.h:
  • WebView/WebHTMLView.mm:
01:32 Changeset [23174] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

WebKit part of fix for <rdar://problem/4990740>.

Added IWebDataSourcePrivate::mainDocumentError.

  • Interfaces/IWebDataSource.idl: Added method declaration and updated copyrights.
  • WebDataSource.cpp: (WebDataSource::mainDocumentError): Implemented.
  • WebDataSource.h: Added declaration.
00:29 Changeset [23173] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-03-23 Steve Falkenburg <sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed

  • WebView.cpp: (WebView::userAgentForKURL): Remove gmail spoof
00:24 Changeset [20426] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Adam.

Make script-add.html more deterministic.


  • fast/dom/resources/script3.js:
  • fast/dom/resources/script4.js:
  • fast/dom/resources/script5.js:
  • fast/dom/script-add.html:
Note: See TracTimeline for information about the timeline view.