Timeline


and

03/29/07:

20:17 Changeset [20608] by ggaren

Layout test for <rdar://problem/5061807>. (This one's for you, Boyscout!)

  • fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
  • fast/frames/remove-frame-with-scrollbars-crash.html: Added.
19:36 Changeset [20607] by weinig

LayoutTests:

Reviewed by Darin.

  • fast/tokenizer/write-partial-entity-expected.txt: Added.
  • fast/tokenizer/write-partial-entity.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/tokenizer/write-partial-entity.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position after script execution which can write to the buffer.
17:11 Changeset [20606] by justing

LayoutTests:

Reviewed by john


<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position

Tests for the bug:

  • editing/deleting/5099303-expected.checksum: Added.
  • editing/deleting/5099303-expected.png: Added.
  • editing/deleting/5099303-expected.txt: Added.
  • editing/deleting/5099303.html: Added. Tests that extending an editable selection skips non-editable content:
  • editing/selection/5099303-expected.checksum: Added.
  • editing/selection/5099303-expected.png: Added.
  • editing/selection/5099303-expected.txt: Added.
  • editing/selection/5099303.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position


We were failing to create the correct selection
for DeleteSelectionCommand because the selection extension
operations don't skip over non-editable content for editable
selections.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): When extending an editable selection, don't extend into non-editable content. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
17:04 Changeset [20605] by thatcher

Versioning.

17:04 Changeset [20604] by thatcher

Versioning.

17:03 Changeset [20603] by thatcher

Versioning.

17:03 Changeset [20602] by thatcher

Versioning.

16:58 Changeset [20601] by thatcher

Merge fix from r20516.

16:50 Changeset [20600] by thatcher

Merge fix from r20565.

16:49 Changeset [20599] by thatcher

Merge fix from r20542.

16:47 Changeset [20598] by thatcher

Merge fix from r20520.

16:26 Changeset [20597] by ggaren

LayoutTests:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)

  • plugins/destroy-stream-twice-expected.txt: Added.
  • plugins/destroy-stream-twice.html: Added.

WebKit:

Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
every time you run it.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]):

WebKitTools:

Reviewed by Beth Dakin.


Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


Added hasStream property and destroyStream function, used by layout test.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginInvoke): (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_NewStream):
16:24 Changeset [20596] by bdakin

Rubber-stamped by Adam.

Keep OpenSource building.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
16:24 Changeset [20595] by pyeh

<rdar://problem/4918397> Exception raise inspecting note contents in the background

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject subrole]): (-[WebCoreAXObject title]): Check that attachment supports the attribute before requesting it.
16:16 Changeset [20594] by justing

I forgot add this expected result in my previous checkin.

16:13 Changeset [20593] by bdakin

Reviewed by Brady.

Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise

-and-

<rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround
methodology

The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.

  • English.lproj/StringsNotToBeLocalized.txt: Two new bundle identifiers.
  • Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):
16:01 Changeset [20592] by thatcher

New tag based on r20497.

15:34 Changeset [20591] by justing

LayoutTests:

Reviewed by john

<rdar://problem/5032066> <Delete> should work between To Dos

Demonstrates the fix:

  • editing/deleting/5032066-expected.checksum: Added.
  • editing/deleting/5032066-expected.png: Added.
  • editing/deleting/5032066-expected.txt: Added.
  • editing/deleting/5032066.html: Added.


Fixed:

  • editing/deleting/delete-block-table-expected.checksum:
  • editing/deleting/delete-block-table-expected.png:
  • editing/deleting/delete-block-table-expected.txt:


shouldInsertNode:... now being called during moves:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/5032066> Delete should work between ToDos


Stop selecting the table when the user attempts to delete
the line break just after it, instead, extend the selection
into the last table cell.
Let deletion merge content into table cells (as long as
its not from another table cell).
Start calling shouldInsertNode:replacingDOMRange:givenAction:
when moving content with moveParagraphs, so that Mail can
modify content before it is moved into a ToDo during a delete.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Ask the delegate before performing the move. This will let Mail prevent styles from entering a ToDo. Added a FIXME about adding a new WebViewInsertAction
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Allow merging into table cells from content not in a table.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Don't select the table when extending by character/word from just before it. This code was here to make it easier to select tables in order to delete them, but the deletion UI makes it largely unnecessary. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
  • editing/TypingCommand.cpp: (WebCore::isFirstPositionAfterTable): Added. (WebCore::isLastPositionBeforeTable): Ditto. (WebCore::TypingCommand::deleteKeyPressed): When pressing the delete key with a caret at the beginning of a paragraph just after a table, move the paragraph into the last table cell. Do not do this if it would mean moving a block table. Removed some old irrelevant comments.
  • editing/htmlediting.cpp: Removed unused functions.
  • editing/htmlediting.h:
15:14 Changeset [20590] by thatcher

Build fix for Leopard.

13:39 Changeset [20589] by yongjzha

vbradley, reviewed by yongjun

DESC: Fix cursor when browser is brought back from background and a

plugin has focus.

http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
13:37 Changeset [20588] by yongjzha

2007-03-29 vbradley <vincent.bradley@nokia.com>

Reviewed by Yongjan.
DESC: Fix cursor when browser is brought back from background and a plugin has focus.
http://bugs.webkit.org/show_bug.cgi?id=13225

  • Plugin/src/PluginWin.cpp: (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
13:36 Changeset [20587] by yongjzha

yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
13:18 Changeset [20586] by yongjzha

2007-03-28 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
13:11 Changeset [20585] by yongjzha

2007-03-27 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun.
DESC: Regression due to patch r20436
TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page
http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ResponseCompleteL):


13:03 Changeset [20584] by yongjzha

Steve, reviewed by Yongjun Zhang

DESC:
http://bugs.webkit.org/show_bug.cgi?id=13296

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SizeChanged):
13:01 Changeset [20583] by yongjzha

hongzhao, reviewed by yongjun.zhang@nokia.com.

DESC: [S60] Browser doesn't support for DRM image content in 3.2.
Fix: Add function to handle DRM image decoder.
http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
12:13 Changeset [20582] by bdash

Versioning.

12:12 Changeset [20581] by bdash

Merge in r20565.

12:10 Changeset [20580] by bdash

New tag.

12:00 Changeset [20579] by staikos

Add a comment since our current fix is not really acceptable.

11:44 Changeset [20578] by staikos

Remove redundant line.

11:18 Changeset [20577] by yongjzha

2007-03-28 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.
DESC: RVCT complier is not handling bitfields properly
http://bugs.webkit.org/show_bug.cgi?id=13217

  • khtml/rendering/render_table.h:
11:05 BuildingOnWindows edited by tommy@ech-wel.nl
(diff)
10:34 Changeset [20576] by yongjzha

2007-03-29 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by yongjun.zhang@nokia.com.
DESC: [S60] Browser doesn't support for DRM image content.
Fix: Make some changes based on Yongjun's comments for the previous 3.1m patch.
http://bugs.webkit.org/show_bug.cgi?id=13220

  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CStaticImageDecoder::LoadNextImage): (CStaticImageDecoder::DecodeDRMImageL):
  • group/webkit.mmp:
10:07 Changeset [20575] by staikos

correct the changelog entry for the patch author.

10:05 Changeset [20574] by staikos

Take into account the entire run length to get a proper selection.
Doesn't seem to affect the Mac build but is a problem for Qt.

10:01 Changeset [20573] by ggaren

Rubber stamped by Beth Dakin.


WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
it's ObjC++ now.

  • Plugins/WebBaseNetscapePluginStream.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
09:59 Changeset [20572] by darin

Layout test for <rdar://problem/4545060>, technorati and arstechnica fail
because of getComputedStyle not reporting display:none.
http://bugs.webkit.org/show_bug.cgi?id=13103

  • fast/css/computed-style-display-none.html: Added.
  • fast/css/computed-style-display-none-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Updated to work with Gecko.
  • fast/css/computed-style-negative-top-expected.txt: Newline change needed because of change above.
  • fast/css/computed-style.html: Updated to work with Gecko.
08:18 Changeset [20571] by ggaren

Reluctantly tolerated by Darin Adler.


Fixed <rdar://problem/5091330> REGRESSION: Repro crash in
-[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:]
navigating away from page with DivX movie plug-in (13203)


The problem was that the DivX plug-in would ask us to destroy an NPStream
that had already been destroyed, causing us to wander off into freed
memory. (I believe the reason this was a regression was that we never used
to destroy plug-in streams, period.)


The solution here is to track the NPStreams belonging to a plug-in, and
guard against plug-ins making calls with NPStreams that don't belong to
them. (It turns out that NPN_DestroyStream is the only stream-based
plug-in call we support.)

(CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix. Use helper method to guard against a plug-in using an NPStream that doesn't belong to it.
  • WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++ so I could use HashMap.
01:41 Changeset [20570] by hyatt

Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
reporting display:none properly when it is set. This is bugzilla bug 13103.

Reviewed by mitz

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
00:49 Changeset [23204] by hyatt

Enable CG's local font cache.

03/28/07:

23:20 Changeset [20569] by dsmith

JavaScriptCore:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • kjs/array_object.cpp: (ArrayInstance::getOwnPropertySlot): (ArrayProtoFunc::callAsFunction):

LayoutTests:

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12963
Fix some inconsistencies in the Mozilla JS Array extras implementations
with respect to the Mozilla implementation:

  • holes in arrays should be skipped, not treated as undefined, by all such methods
  • an element with value undefined is not a hole
  • Array.prototype.forEach should return undefined
  • fast/js/array-every-expected.txt:
  • fast/js/array-filter-expected.txt: Added.
  • fast/js/array-filter.html: Added.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html:
  • fast/js/array-indexof-expected.txt:
  • fast/js/array-indexof.html:
  • fast/js/array-lastIndexOf-expected.txt:
  • fast/js/array-map-expected.txt: Added.
  • fast/js/array-map.html: Added.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html:
  • fast/js/resources/array-every.js:
  • fast/js/resources/array-lastIndexOf.js:
23:15 Changeset [20568] by oliver

2007-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.

Rename DocLoader::setPasteInProgress, etc to more generic
setAllowStaleResources, etc

  • editing/Editor.cpp: (WebCore::Editor::paste):
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::checkForReload):
  • loader/DocLoader.h: (WebCore::DocLoader::setAllowStaleResources):
  • page/DragController.cpp: (WebCore::DragController::concludeDrag):
21:59 Changeset [20567] by oliver

2007-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Anders and Steve.

Add a flag to DocLoader to prevent it from reloading
when performing a paste or drop operation.


Remove m_cachePolicy from CachedResource as it is never used


Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures
dragging image into GMail message in _web_writeImage and
documentFragmentFromDragData

  • editing/Editor.cpp: (WebCore::Editor::paste): prevent the docloader from reloading resources on paste
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource):
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader):

Tidy up constructor initialise new field

(WebCore::DocLoader::checkForReload):

Prevent reload when pasting

  • loader/DocLoader.h: (WebCore::DocLoader::setPasteInProgress): new field and setter
  • page/DragController.cpp: (WebCore::DragController::concludeDrag): prevent the docloader from reloading resources on drop
18:45 Changeset [20566] by kjk

Not reviewed - fix typo in gdk build.

  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::contentsToWindow):
18:18 Changeset [23203] by mjs

Reviewed by Darin.

  • updates for <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
18:17 Changeset [20565] by mjs

LayoutTests:

Reviewed by Darin.


  • <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:

WebCore:

Reviewed by Darin.


  • fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)


Handle scrolling external scrollviews around the webview during
autoscroll or when scrolling into view.


This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

  • page/FrameView.cpp: (WebCore::FrameView::scrollRectIntoViewRecursively):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively): (WebCore::ScrollView::updateContents):
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::scrollRectIntoViewRecursively):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
17:15 Changeset [20564] by thatcher

Versioning.

17:14 Changeset [20563] by thatcher

Merge a minimal version of r20351.

17:13 Changeset [20562] by thatcher

New tag.

16:48 JavaScript and DOM Benchmarks edited by mjs@apple.com
(diff)
16:45 Changeset [20561] by sfalken

New tag.

15:18 Changeset [20560] by adele

Reviewed by Brady.

Update to last fix.

  • Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]): Added check to only use the VitalSource workaround if the app is not linked on or after the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
14:52 Changeset [20559] by darin

Reviewed and landed by Darin

Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
http://bugs.webkit.org/show_bug.cgi?id=13138

  • platform/StringImpl.cpp: (WebCore::StringImpl::isLower): (WebCore::StringImpl::lower): (WebCore::StringImpl::equalIgnoringCase):
14:28 Changeset [20558] by antti

Reviewed by Hyatt.

Fix <rdar://problem/5092653>
REGRESSION: Image decoding making scrolling slow


If decoder gave back a null frame (which I think happens regularly if you don't have full frame
data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
led to massive growth in calculated image size and eventually made cache prune constantly.


No test, I don't know how to make one for this.

  • platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::cacheFrame):
14:19 Changeset [20557] by thatcher

<rdar://problem/5093473> incomplete render of menu (assertion failing in -[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]) (13026)

Rolling out r20042, and these build fixes that followed: r20050, r20058, r20064 and r20077.

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView restorePortState:]):
14:13 Changeset [20556] by yongjzha

2007-03-28 yongjzha <yongjun.zhang@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: refreshing crashes the browser on some sites (kauppalehti.fi, hs.fi)

fix: stop the tokenizer timer when switching to final document from preview document.

http://bugs.webkit.org/show_bug.cgi?id=13219

  • khtml/html/htmltokenizer.cpp: (khtml::):
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp: (KHTMLPart::switchToDocWithPendingSrc):
13:59 Changeset [20555] by adele

WebCore:

Reviewed by Kevin M.

WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Convert return value to a string. This matches the behavior in Safari 2.0.

WebKit:

Reviewed by Kevin M.

WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings. We used to allow this
but now we throw a JavaScript exception for return statements that aren't in functions.

Filed this evangelism bug so we can notify VitalSource of the problem:
<rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

  • WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
09:48 Changeset [20554] by ap

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13190
XPath incorrectly handles namespaces on attributes

WebCore:

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but measurable performance improvement for bug 13021. (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
  • xml/XPathStep.h: (WebCore::XPath::Step::NodeTest::NodeTest): (WebCore::XPath::Step::NodeTest::namespaceURI): (WebCore::XPath::Step::nodeTest): (WebCore::XPath::Step::setNodeTest): Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
  • xml/XPathGrammar.y:
  • xml/XPathPath.cpp: (WebCore::XPath::LocationPath::optimizeStepPair): Accounted for the above change.

LayoutTests:

  • fast/xpath/attr-namespace-expected.txt: Added.
  • fast/xpath/attr-namespace.html: Added.
  • fast/xpath/xpath-namespaces-expected.txt:
  • fast/xpath/xpath-namespaces.html: Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
08:39 Changeset [20553] by sfalken

New tag.

04:31 Changeset [20552] by antti

Update libWebKitSystemInterface, previous version was out of date.

  • libWebKitSystemInterface.a:
01:41 Changeset [20551] by oliver

2007-03-28 Oliver Hunt <oliver@apple.com>

rs=Hyatt.

Rollout local changes :-/

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
01:38 Changeset [20550] by oliver

2007-03-28 Oliver Hunt <oliver@apple.com>

Reviewed by Hyatt.

Roll out r20511 due to incredible badness

  • loader/Cache.cpp: (WebCore::Cache::pruneAllResources): (WebCore::Cache::remove):
00:18 Changeset [20549] by sfalken

Add files missed by svn merge.

03/27/07:

23:19 Changeset [20548] by sfalken

Merge fix from r20476.

23:10 Changeset [20547] by sfalken

Merge fix from r20475.

22:05 Changeset [20546] by darin
  • svg/hixie/text/003-expected.txt: Updated results for this one test that now has different results due to the painting Adele added to DumpRenderTree. Long term, we just have to fix SVG so that painting doesn't cause changes to the render tree!
21:22 Changeset [20545] by oliver

2007-03-27 Oliver Hunt <oliver@apple.com>

Reviewed by Adam.

Don't enforce text-selection drag delay when we are
going to drag an image anyway.

Fixes rdar://problem/4668935

  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag):

Layout tests:

Test to ensure there is no delay forced when dragging a selected image

  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
  • editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
16:38 Changeset [20544] by andersca

JavaScriptCore:

Reviewed by Geoff.

  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Call JSObject:call for native JavaScript objects.

LayoutTests:

Reviewed by Geoff.

Add NPN_InvokeDefault test.


  • plugins/netscape-invoke-default-expected.txt: Added.
  • plugins/netscape-invoke-default.html: Added.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Add new function which takes a function and calls it using NPN_InvokeDefault.
16:29 Changeset [20543] by justing

Build fix


  • editing/markup.cpp: (WebCore::startMarkup):
15:55 Changeset [20542] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

Demonstrates the bug fixed:

  • editing/style/5091898-expected.checksum: Added.
  • editing/style/5091898-expected.png: Added.
  • editing/style/5091898-expected.txt: Added.
  • editing/style/5091898.html: Added. Demonstrates a related bug fixed (deleting the line break before a paragraph could remove its underlining):
  • editing/deleting/5091898-expected.checksum: Added.
  • editing/deleting/5091898-expected.png: Added.
  • editing/deleting/5091898-expected.txt: Added.
  • editing/deleting/5091898.html: Added. Demonstrates that a link now (correctly) exists, instead of just underlined text:
  • editing/pasteboard/4840662-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family


createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.

  • editing/markup.cpp: (WebCore::startMarkup): Add an inlineBlocks option. Make sure to overwrite display:block coming from a style sheet or the inline style declaration. (WebCore::createMarkup): Don't refuse to include a specialCommonAncestor that's a block if we were asked to include only inline content, since we can now inline block elements in startMarkup.
15:53 Changeset [20541] by adele

Oops- my comment was missing a word.

15:50 Changeset [20540] by adele

Adding comment.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
15:41 Changeset [20539] by adele

Fix svg tests by calling displayIfNeeded.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
15:13 Changeset [20538] by zbujtas

yadavall, reviewed by <zbujtas@gmail.com>

DESC: Rich File Upload implementation
http://bugs.webkit.org/show_bug.cgi?id=13195

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreFormControls.h:
  • khtml/html/html_formimpl.cpp: (DOM::):
  • khtml/html/html_formimpl.h:
  • khtml/rendering/render_form.cpp: (RenderFileButton::updateFromElement):
  • kwq/KWQFileButton.cpp: (KWQFileButton::setAccept):
  • kwq/KWQFileButton.h:
15:10 Changeset [20537] by sullivan

Reviewed by Tim


  • fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
14:59 Changeset [20536] by thatcher

Merge fix from r20456 and r20457.

14:58 Changeset [20535] by adele

Reviewed by Hyatt.

Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we
move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/5092361>.

  • dom/Document.cpp: (WebCore::Document::implicitClose):
14:56 Changeset [20534] by thatcher

Merge fix from r20441.

14:52 Changeset [20533] by thatcher

Merge fix from r20425.

14:22 Changeset [20532] by thatcher

Merge fix from r20474.

14:18 Changeset [20531] by thatcher

Merge fix from r20473.

14:16 Changeset [20530] by thatcher

Merge fix from r20471.

14:14 Changeset [20529] by thatcher

Merge fix from r20461.

14:12 Changeset [20528] by thatcher

Merge build fix from r20427.

13:47 Changeset [20527] by thatcher

Merge fix from r20460.

13:45 Changeset [20526] by thatcher

Merge fix from r20458.

13:43 Changeset [20525] by thatcher

Merge fix from r20454.

13:41 Changeset [20524] by thatcher

Merge fix from r20453.

13:39 Changeset [20523] by thatcher

Merge fix from r20449.

13:35 Changeset [20522] by thatcher

Merge fix from r20440.

13:29 Changeset [20521] by thatcher

Merge fix from r20419.

13:21 Changeset [23202] by hyatt

Fix for 5090964, arabic text piled on top of itself.

13:09 Changeset [20520] by justing

LayoutTests:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • editing/pasteboard/5065605-expected.checksum: Added.
  • editing/pasteboard/5065605-expected.png: Added.
  • editing/pasteboard/5065605-expected.txt: Added.
  • editing/pasteboard/5065605.html: Added.
  • editing/style/4916887-expected.checksum: Added.
  • editing/style/4916887-expected.png: Added.
  • editing/style/4916887-expected.txt: Added.
  • editing/style/4916887.html: Added.
  • editing/style/5065910-expected.checksum: Added.
  • editing/style/5065910-expected.png: Added.
  • editing/style/5065910-expected.txt: Added.
  • editing/style/5065910.html: Added.
  • editing/style/5084241-expected.checksum: Added.
  • editing/style/5084241-expected.png: Added.
  • editing/style/5084241-expected.txt: Added.
  • editing/style/5084241.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
<rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
<rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
<rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): If a node's text fill color is invalid, then its children use their font-color as their text fill color (they don't inherit it). Likewise for stroke color.
13:07 Changeset [23201] by ggaren

Reviewed by Anders Carlsson.

Fixed <rdar://problem/5085076> WebView stops painting after
loading stand-alone netflix movie preview in WMP format


The stand-alone WMP plug-in seems to do all its drawing in
the WM_ERASEBKGN phase, not the WM_PAINT phase, so our
InvalidateRect call for plug-in windows needs to specify
'true' for whether the background region should be erased.


A smart plug-in that wants to avoid background draws can
still do so by just returning 1 in response to WM_ERASEBKGN,
or by setting its background brush to NULL.

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow):
12:58 Changeset [20519] by yongjzha

yaharon, reviewed by <reviewer>

DESC: [S60] S60 3.2 Touch Help: Application crash when tapping scroll bar of XHTML topic
http://bugs.webkit.org/show_bug.cgi?id=13196

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::HandleScrollEventL):
11:06 Changeset [23200] by andersca

Reviewed by Maciej.

<rdar://problem/5091459>
Crash when destroying "null plugin"


<rdar://problem/5056845>
Invoking itunes page has missing plugin icon on it


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::paintMissingPluginIcon): Clip before painting.


(WebCore::freeStringArray):
Add null-check.


(WebCore::PluginViewWin::PluginViewWin):
Initialize plugin names and values.

09:40 Changeset [20518] by andersca
  • platform/ScrollBar.h: Use wtf/MathExtras.h instead of math.h
06:02 Changeset [20517] by bdash

Versioning.

06:02 Changeset [20516] by bdash

Merge in r20513.

05:58 Changeset [20515] by bdash

New tag (part 2).

05:57 Changeset [20514] by bdash

New tag (part 1).

05:49 Changeset [20513] by bdash

2007-03-27 Mark Rowe <mrowe@apple.com>

Reviewed by Dave Harrison.

  • Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
04:08 Changeset [20512] by zack

Fix the build

03:02 Changeset [20511] by oliver

2007-03-27 Oliver Hunt <oliver@apple.com>

Reviewed by Maciej.

The WebArchiver needs all the subresources of a document to be accessible
through the DocLoader, so we can't remove a CachedResource simultaneously
from the global Cache and all DocLoaders, just because it needs to be
reloaded in one.

Fixes rdar://problem/5044366

  • loader/Cache.cpp: (WebCore::Cache::remove):

Don't evict the resource from all DocLoaders

  • manual-tests/test-iframes-loading-the-same-resource.html: Added.

Alas it wasn't possible to make a nice layout test, even this manual test
is not entirely deterministic

02:14 Changeset [20510] by bdash

2007-03-27 Mark Rowe <mrowe@apple.com>

Build fix.

  • platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear):
02:04 Changeset [20509] by zack

Fix the rendering crashes due to triggered
asserts and improve a bit the layout scheduling in the
Qt port

01:59 Changeset [23199] by hyatt

Add support for glyph offsets to the GlyphBuffer.

01:52 Changeset [20508] by hyatt

Add support for glyph offsets to the GlyphBuffer.

01:32 Changeset [20507] by antti

Keep buildbot happy.

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::scrollbarHit):
01:10 Changeset [23198] by antti

WebCoreWin:

Reviewed by Darin.


Initialize new m_isContinuous field in WheelEvent

  • platform/win/WheelEventWin.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
01:03 Changeset [20506] by antti

WebCore:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCore.exp:

Export _wkGetWheelEventDeltas

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent):

Remove (0, 0) scroll event hack, it is not needed anymore.
Do per-pixel scrolling for fine grained events.

  • platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::isContinuous):

Add new m_isContinuous boolean to indicate fine grained wheel events.

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
  • platform/ScrollBar.h: (WebCore::Scrollbar::value):

Use float to represent current position to support finer grained scrolling.
Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)

  • platform/ScrollTypes.h: (WebCore::):
  • platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add wkGetWheelEventDeltas for getting fine grained wheel events

  • platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Get the wheel deltas using new wkGetWheelEventDeltas interface

  • platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):

Initalize m_isContinuous

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight):

Pass item height to scrollbar

WebKit:

Reviewed by Darin.


On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
http://bugs.webkit.org/show_bug.cgi?id=13134
<rdar://problem/5076249?

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

Reviewed by Darin.


Added wkGetWheelEventDeltas

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
00:02 Changeset [23197] by hyatt

Enable complex text.

03/26/07:

21:45 Changeset [23196] by beidson

Reviewed by Ada

This one didn't actually have any leaks, but I just felt like doing the
same style cleanup as the others :)


  • WebPreferences.cpp: (WebPreferences::stringValueForKey): (WebPreferences::integerValueForKey): (WebPreferences::floatValueForKey): (WebPreferences::setStringValue): (WebPreferences::setIntegerValue): (WebPreferences::save): (WebPreferences::load):
20:49 Changeset [20505] by ddkilzer

Added Radar references.

19:46 Changeset [20504] by ggaren

fixed up order of ChangeLog entries

19:36 Changeset [20503] by ggaren

LayoutTests:

Reviewed by Darin Adler.


Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at
WebCore::Node::createRendererIfNeeded() when changing map views with MS
Virtual Earth (http://www.ziprealty.com/)

  • fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
  • fast/dom/mutation-event-remove-inserted-node.html: Added.
  • fast/dom/script-element-remove-self-expected.txt: Added.
  • fast/dom/script-element-remove-self.html: Added.

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
19:33 Changeset [23195] by beidson

Reviewed by Ada

<rdar://5090412> - Plug CFNumberRef leaks in WebCache


  • WebCache.cpp: (WebCache::statistics):
18:57 Changeset [20502] by andersca

JavaScriptCore:

Reviewed by Darin, landed by Anders.

Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142

The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636
introduced new JNIType to enum in jni_utility.h This is a
problem on the Mac as it seems that the JNIType enum is also
used in the JVM, it is used to specify the return type in
jni_objc.mm
Corrected the fix by moving type to the end, and changing
jni_objc.mm to convert the new type to an old compatible
type.

  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_utility.h:

WebCore:

Reviewed by Darin, landed by Anders.

Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

  • manual-tests/liveconnect-applet-get-boolean.html: Added.
  • manual-tests/resources/CheckerApplet.class: Added.
  • manual-tests/resources/CheckerApplet.java: Added.
18:11 Changeset [20501] by aroben

Reviewed/landed by Adam.

Bug 13198: Move build settings from project file to xcconfig file for apollo
port JSCore
http://bugs.webkit.org/show_bug.cgi?id=13198

  • Moving build settings from xcode project file to xcconfig files.
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
  • JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
17:12 Changeset [23194] by bdakin

Reviewed by Geoff.

Fix build without breaking anything.

  • WebHistory.cpp: (releaseUserInfo): Added silly void statement for now.
16:55 Changeset [23193] by bdakin

Rubber-stamped by Brady.

Build fix for release build.

  • WebHistory.cpp: (releaseUserInfo): Do not store userInfo->Release() in a local variable since it is only used for an ASSERT.
16:52 Changeset [20500] by beidson

Rubberstamped by Anders and Maciej aand Geoff (oh my!)


Since CFTypeRef is really void*, a RetainPtr couldn't be used.
RefType was "void", which doesn't actually exist as a type.
Since RefType only existed for operator*(), and since that operator
doesn't make any sense for RetainPtr, I removed them!

  • kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the compiler with dependencies
  • wtf/RetainPtr.h: Nuke RefType and operator*()
16:46 Changeset [20499] by darin

LayoutTests:

Reviewed and landed by Darin.

  • fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.png: Added.
  • fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
  • fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/replaced/selection-rect-in-table-cell.html

  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect):
15:09 Changeset [20498] by sullivan

Reviewed by Dave Harrison


  • fixed <rdar://problem/4769772> Problem with Find on certain PDF page
  • WebView/WebPDFView.mm: (-[WebPDFView _scaledAttributedString:]): We were hitting an exception trying to set the font attribute to nil, which was happening because the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now filed separately, but this works around the exception.
13:55 Changeset [23192] by sfalken

2007-03-26 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.


<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

  • WebIconDatabase.cpp: (userIconDatabasePath): Move icon database to non-roaming location
13:32 Changeset [20497] by ggaren

Touched a file to (hopefully) help the compiler with RetainPtr dependencies.

  • kjs/nodes.cpp: (Node::deref):
13:31 Changeset [20496] by ggaren

Removed now-stale #includes of <assert.h>.


  • WebCorePrefix.h:
  • config.h:
  • css/CSSGrammar.y:
  • platform/Arena.cpp:
  • platform/KURL.cpp:
  • platform/SegmentedString.h:
  • rendering/DataRef.h:
  • rendering/RenderArena.cpp:
13:08 Changeset [20495] by ggaren

Reviewed by Kevin McCulough.

Global replace of "assert(" with "ASSERT(" to assist debugging. Removed
one instance of commented-out code containing "assert(" instead of replacing it.

13:00 Changeset [23191] by adele

Reviewed by Adam.

Fix for <rdar://problem/5088844> Popup menu is not positioned correctly on a yahoo comics page


Fixes test: fast/forms/control-restrict-line-height.html


This change was made in RenderThemeMac a while ago, and will fix the line height for aqua popup buttons,
buttons and search fields.


09:57 Changeset [20494] by darin
  • coding/coding-style.html: Let's misquote George Orwell: "Wrong is right. Right is wrong."

03/25/07:

21:10 Changeset [20493] by darin
  • coding/coding-style.html: Put !important on right/wrong colors so they override the green color that comes from the green.css stylesheet.
21:07 Changeset [20492] by darin
  • coding/RefPtr.html: A couple minor wording tweaks.
21:05 Changeset [20491] by darin
  • coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers.
20:54 Changeset [23190] by beidson

WebCoreWin:

Reviewed by Oliver

<rdar://problem/5086888> - WebHistory(Item) Leak

  • platform/win/COMPtr.h: (COMPtr::COMPtr): An an adoptRef constructor


WebKitWin:

Reviewed by Oliver


<rdar://problem/5086888> - WebHistory(Item) Leak


This is a pretty thourough touchup up style and correctness that
plugs at least 1 definite leak and many potential leaks with
extensive use of RetainPtr and COMPtr.


This should result in no change in behavior

  • MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
  • MarshallingHelpers.h: Ditto


  • WebHistory.cpp: (createUserInfoFromArray): (createUserInfoFromHistoryItem): (releaseUserInfo): (WebHistory::WebHistory): (WebHistory::~WebHistory): (WebHistory::loadFromURL): (createHistoryListFromStream): Split of the Structured Exception Handling to a seperate function to cooperate with C++ (WebHistory::loadHistoryGutsFromURL): (WebHistory::saveToURL): (WebHistory::saveHistoryGuts): (WebHistory::datesArray): (WebHistory::addItems): (WebHistory::removeItems): (WebHistory::removeAllItems): (WebHistory::orderedLastVisitedDays): (WebHistory::orderedItemsLastVisitedOnDay): (WebHistory::removeItem): (WebHistory::addItem): (WebHistory::addItemForURL): (WebHistory::itemForURLString): (WebHistory::itemForURL): (WebHistory::containsItemForURLString): (WebHistory::removeItemForURLString): (WebHistory::addItemToDateCaches): (WebHistory::removeItemFromDateCaches): (WebHistory::findIndex): (WebHistory::insertItem): (WebHistory::ageLimitDate):
  • WebHistory.h:


  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation): (WebHistoryItem::mergeAutoCompleteHints):
16:45 Changeset [23189] by aroben

LayoutTestsWin:

Reviewed by Anders.

Fix <rdar://problem/5066290> boomer-run-webkit-tests doesn't support
http tests

  • Skipped: Removed http tests from the skipped list.
  • http/conf/cygwin-httpd.conf: Added.
  • http/conf/libphp4.dll: Added.
15:42 Changeset [20490] by antti

LayoutTests:

Reviewed by Adam.


Test for <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

  • editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • editing/pasteboard/drag-drop-dead-frame-expected.txt: Added.
  • editing/pasteboard/drag-drop-dead-frame.html: Added.

WebCore:

Reviewed by Adam.

Fix <rdar://problem/5049842>
Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler()

Null check frame in m_dragTarget, it might be gone already.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop):
13:14 Changeset [23188] by aroben

LayoutTestsWin:

Reviewed by Oliver.

  • Skipped: Added two more crashers for when we enable http tests.

WebKitToolsWin:

Reviewed by Oliver.

Fix <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Ported Mac code to check the MIME type before dumping. (runTest): Clear the work queue before each test.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added new files.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (notifyDoneCallback): Only dump if the work queue is empty. (jsValueToCString): Added. (queueLoadCallback): Added. (queueReloadCallback): Added. (queueScriptCallback): Added. (queueBackNavigationCallback): Added. (queueForwardNavigationCallback): Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: (WaitUntilDoneDelegate::processWork): Added. (processWorkTimer): Added. (WaitUntilDoneDelegate::locationChangeDone): Changed to match Mac.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Added declaration.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Added. (WorkQueue::shared): (WorkQueue::WorkQueue): (WorkQueue::queue): (WorkQueue::dequeue): (WorkQueue::count): (WorkQueue::clear):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Added. (WorkQueue::setFrozen):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Added. (LoadItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Added. (LoadItem::LoadItem): (LoadItem::url): (LoadItem::target): (ScriptItem::ScriptItem): (ScriptItem::script): (BackItem::BackItem): (ForwardItem::ForwardItem):

WebKitWin:

Reviewed by Oliver.

WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
layoutTestController.queueLoad

  • WebFrame.cpp: (WebFrame::findFrameNamed): Implemented.
  • WebHistoryItem.cpp: (WebHistoryItem::children): Don't increment i twice per loop!
08:10 Changeset [20489] by bdash

2007-03-26 Mark Rowe <mrowe@apple.com>

Reviewed by Sam Weinig.

Upload crash logs from DumpRenderTree as part of the test results to ease debugging
of hard-to-reproduce crashes.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
03:33 Changeset [20488] by bdash

2007-03-25 Mark Rowe <mrowe@apple.com>

Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity.

  • coding/RefPtr.html:
03:25 Changeset [23187] by aroben

Build fix.

  • WebDownload.h: Include RetainPtr from WTF.
01:39 Changeset [20487] by ap

Reviewed by Darin.

A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

  • xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document from being destroyed in time.
  • dom/Attr.cpp: (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform.
  • dom/ContainerNode.h: (WebCore::ContainerNode::fastSetFirstChild): (WebCore::ContainerNode::fastSetLastChild): Added operations that let Attr hack internal ContainerNode data (evil, but fast!).
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeMatches):
  • xml/XPathStep.h: Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis).
00:43 Changeset [20486] by darin
  • coding/RefPtr.html: A couple wording tweaks.
00:11 Changeset [20485] by darin
  • coding/RefPtr.html: More formatting tweaks. Added a possible new topic for the document, suggested by Anders.
Note: See TracTimeline for information about the timeline view.