Timeline


and

04/03/07:

23:39 Changeset [20698] by thatcher
  • 6 edits
    2 deletes in branches/WebInspectorRefresh/WebKit/WebInspector

Convert the Web Inspector NSOutlineView into an HTML and JavaScript based tree view. Not everything is working yet.

23:36 Changeset [20697] by thatcher
  • 1 copy in branches/WebInspectorRefresh

New branch to update the Web Inspector to use more HTML and JavaScript and remove the NSOutlineView.

22:55 Changeset [23225] by aroben
  • 6 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Anders.

DRT part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Call IDOMElementPrivate::innerText to match Mac DRT.

WebKitWin:

Reviewed by Anders.

WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
failing due to extra/missing newlines

  • DOMCoreClasses.cpp: (DOMElement::innerText): Added.
  • DOMCoreClasses.h: Added declaration.
  • Interfaces/DOMPrivate.idl: Ditto.
22:32 Changeset [23224] by aroben
  • 2 edits in branches/WindowsMerge/WebKitTools

Rubberstamped by Adele.

Make all layout tests paint to match Mac DRT. This fixes many tests in
svg/hixie.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump): Always force a paint.
19:12 Changeset [20696] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

  • Testing a post-commit hook.
18:32 Changeset [20695] by andersca
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Adam.

<rdar://problem/5107534>
http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant


  • bindings/NP_jsobject.cpp: (_NPN_InvokeDefault): Return false if the object isn't a function.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5107534>
http://bugs.webkit.org/show_bug.cgi?id=13265
REGRESSION: Crash in KJS::Bindings::convertValueToNPVariant

  • plugins/netscape-invoke-default.html: Test calling NPN_InvokeDefault on an object that isn't a function.
17:22 Changeset [20694] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget

  • plugins/get-url-that-the-resource-load-delegate-will-disallow-expected.txt: Added.
  • plugins/get-url-that-the-resource-load-delegate-will-disallow.html: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/5028178>
Crash occurs at WebCore::FrameLoader::activeDocumentLoader() after loading Froggster widget


  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream start]): If load returns no the plugin loader has already been removed by the didFail callback.

WebKitTools:

Reviewed by Darin.

Add the notion of a "disallowed URL", which the resource loader won't allow to be loaded.


  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController addDisallowedURL:]): (runTest):
  • DumpRenderTree/ResourceLoadDelegate.m: (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
16:31 Changeset [20693] by hyatt
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5108896>, make sure the assert for setEncodedSize
deals with the error case.

Reviewed by andersca

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
16:22 Changeset [20692] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • loader/ImageDocument.cpp: Don't call error() in stopParsing.
15:50 Changeset [20691] by justing
  • 5 edits
    1 delete in trunk/LayoutTests

Reviewed by darin


<http://bugs.webkit.org/show_bug.cgi?id=13268>
Make editing/selection/drag-in-iframe.html valid and deterministic

  • editing/resources/select-and-drag-iframe.html: Removed.
  • editing/selection/drag-in-iframe-expected.checksum:
  • editing/selection/drag-in-iframe-expected.png:
  • editing/selection/drag-in-iframe-expected.txt:
  • editing/selection/drag-in-iframe.html:
15:12 Changeset [23223] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-04-03 Oliver Hunt <oliver@apple.com>

Buildfix

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse):

Adding .get() calls

15:07 Changeset [20690] by adele
  • 4 edits in trunk/LayoutTests

Updated results for recent change to always lighten disabled text color for black text.

  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-disabled-color-expected.png:
  • fast/forms/input-disabled-color-expected.txt:
14:57 Changeset [20689] by justing
  • 119 edits in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app

moveParagraphs no longer calls shouldInsert:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-block-merge-contents-022-expected.txt:
  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-listitem-001-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/deleting/merge-different-styles-expected.txt:
  • editing/deleting/merge-no-br-expected.txt:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/deleting/pruning-after-merge-2-expected.txt:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-with-hr-expected.txt:
  • editing/execCommand/format-block-expected.txt:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/execCommand/format-block-with-braces-expected.txt:
  • editing/execCommand/format-block-with-trailing-br-expected.txt:
  • editing/execCommand/indent-list-item-expected.txt:
  • editing/execCommand/indent-selection-expected.txt:
  • editing/execCommand/insert-list-and-stitch-expected.txt:
  • editing/execCommand/insert-list-with-id-expected.txt:
  • editing/execCommand/nsresponder-indent-expected.txt:
  • editing/execCommand/outdent-selection-expected.txt:
  • editing/execCommand/queryCommandState-01-expected.txt:
  • editing/execCommand/remove-list-1-expected.txt:
  • editing/execCommand/remove-list-from-range-selection-expected.txt:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/multiple-lines-selected-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/pasteboard/4076267-2-expected.txt:
  • editing/pasteboard/4700297-expected.txt:
  • editing/pasteboard/8145-3-expected.txt:
  • editing/pasteboard/display-block-on-spans-expected.txt:
  • editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/interchange-newline-2-expected.txt:
  • editing/pasteboard/merge-after-delete-1-expected.txt:
  • editing/pasteboard/merge-after-delete-2-expected.txt:
  • editing/pasteboard/merge-after-delete-expected.txt:
  • editing/pasteboard/merge-end-1-expected.txt:
  • editing/pasteboard/merge-end-2-expected.txt:
  • editing/pasteboard/merge-end-3-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/merge-end-5-expected.txt:
  • editing/pasteboard/merge-end-blockquote-expected.txt:
  • editing/pasteboard/merge-end-borders-expected.txt:
  • editing/pasteboard/merge-end-list-expected.txt:
  • editing/pasteboard/merge-end-table-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-004-expected.txt:
  • editing/pasteboard/paste-text-005-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-010-expected.txt:
  • editing/pasteboard/smart-paste-001-expected.txt:
  • editing/pasteboard/smart-paste-002-expected.txt:
  • editing/pasteboard/smart-paste-003-expected.txt:
  • editing/pasteboard/smart-paste-004-expected.txt:
  • editing/pasteboard/smart-paste-005-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/pasteboard/smart-paste-008-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/style-boundary-005-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/5107422>
TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
<rdar://problem/5107413>
TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Back out the call to shouldInsert until we add WebViewInsertActionMoved, because Mail returns NO from shouldInsert for WebViewInsertActionPasted to override our Paste operation.
14:39 Changeset [20688] by andersca
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Add tests for innerWidth/innerHeight and clientWidth/clientHeight in quirks mode.

Modify the strict clientWidth/clientHeight test to test the behavior with scrollbars visible.


  • fast/dom/client-width-height-quirks-expected.txt: Added.
  • fast/dom/client-width-height-quirks.html: Added.
  • fast/dom/client-width-height.html:
  • fast/dom/inner-width-height-expected.txt: Added.
  • fast/dom/inner-width-height.html: Added.

WebCore:

Reviewed by Mitz.

Make window.innerWidth/innerHeight include the size of any present scrollbar to match Firefox.


Make document.body.clientWidth/clientHeight return the width/height of the visible content when in
quirks mode to match WinIE.


  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Return the width and height of the scroll view, not the visible width and height.


  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): Return the visible size if the element is the body element and we're in quirks mode.
13:51 Changeset [20687] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-03-30 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
13:50 Changeset [20686] by spadma
  • 4 edits in S60/trunk/WebKit

2007-03-30 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: When the request dispatcher does not define a loader

no pending transaction will exist, so set this undefined status
to KErrCancel so the callers don't wait indefinitely. Also, create, use,
and close the download property string when it's needed to avoid closing
the rstring after the string pool which it's using has somehow gone away.

http://bugs.webkit.org/show_bug.cgi?id=13232

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::~CHttpTransaction): (CHttpTransaction::MHFRunL): (CHttpTransaction::MHFRunError): (CHttpTransaction::HandleGotResponseHeadersL):
13:15 Changeset [23222] by mjs
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

  • fixed <rdar://problem/5107069> WebCore leaks a copy of the CFHTTPMessage CFDictionary (from CFHTTPMessageCopyAllHeaderFields)
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Use RetainPtr (once to avoid a leak and once just as style cleanup).
12:22 Changeset [20685] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Updated fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

  • platform/graphics/Color.cpp: Moved optimization for lightening black and darkening white into the Color class. (WebCore::Color::light): (WebCore::Color::dark):
  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor): Skip the difference calculation for black text, which will always be lightened.
11:35 Changeset [20684] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Tim.

<rdar://problem/4649516>
Turn off slow script dialog or crank up time that makes it come up


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Increase the timeout to 10 seconds to match Firefox.
11:30 Changeset [23221] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix crashes seen when running the plugin layout tests.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Fill in the enumerate pointer, not the evaluate pointer (it's already been filled in).


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::didFinishLoading): Handle the case where there was no plugin stream data at all.
07:51 Changeset [20683] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-03-27 raalexan <rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun.
DESC: Connection shown as Normal in secure page
http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):
07:44 Changeset [20682] by yongjzha
  • 2 edits in S60/trunk/WebKit

rathnasa, reviewed by Yongjun.

DESC: Reset the iDownloadContent flag properly.

TSW Id: TKWG-6Z477F-Browser auto exit when browsing web Page

http://bugs.webkit.org/show_bug.cgi?id=13207

  • ResourceLoader/src/DefaultContentHandler.cpp: (CDefaultContentHandler::ProcessHeadersL):
07:39 Changeset [20681] by yongjzha
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 hongzhao <set EMAIL_ADDRESS environment variable>

Reviewed by yongjun.zhang@nokia.com
DESC: [S60]Animated images with DRM content won't be displayed in Browser in 3.1m.
Fix: Handle DRM image content during construct the content.
http://bugs.webkit.org/show_bug.cgi?id=13258

  • BrowserCore/Renderers/inc/AnimationDecoder.h:
  • BrowserCore/Renderers/inc/StaticImageDecoder.h:
  • BrowserCore/Renderers/src/StaticImageDecoder.cpp: (CRawData::ConstructL): (CRawData::DecodeDRMImageContentL): (CStaticImageDecoder::LoadNextImage):
07:29 Changeset [20680] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2007-04-02 ligman <joseph.ligman@nokia.com>

Reviewed by yongjun.zhang@nokia.com
DESC: Animated gif in xhtml fails. Start the animation timer for single scaled animated bitmaps.
http://bugs.webkit.org/show_bug.cgi?id=13254

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
07:26 Changeset [20679] by yongjzha
  • 3 edits in S60/trunk/WebKit

ligman, reviewed by <reviewer>

DESC: Animated gif in xhtml fails. Start animation timer for single animated gifs
http://bugs.webkit.org/show_bug.cgi?id=13255

  • BrowserCore/Renderers/inc/ImageRenderer.h: (CImageRenderer::GetParent):
  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::DrawImageInRect): (NextFrameCb): (CImageRenderer::NextFrame): (CImageRenderer::InitAnimationCallback):
05:56 Changeset [20678] by bdash
  • 8 edits in trunk

2007-04-03 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Covered by existing editing tests.

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::getFloatValue): Added ASSERTs that the requested conversion is from a scalar type to a scalar type. The intermittent failures in the test were the result of trying to convert an identifier type to a scalar type.
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::checkForLegacyHTMLStyleChange): Added a check that the font-size property value is an absolute length. If it is not (such as in the case of relative units or keywords like "x-large"), then no corresponding 'size' attribute will be generated for legacy HTML.

2007-04-03 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/fontsize-1-expected.txt:
05:51 Changeset [20677] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-04-03 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • manual-tests/stale-currentEvent.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::hoverTimerFired): Instead of faking a mouse event, just hit-test the last mouse event coordinates and update for hover state changes. This eliminates the use of currentEvent, which can be a non-mouse event or even a stale event.
04:24 Changeset [20676] by bdash
  • 2 edits in trunk/WebKitTools

2007-04-03 Mark Rowe <mrowe@apple.com>

Reviewed by Antti.

  • BuildSlaveSupport/build-launcher-dmg: Use bzip2 compression in nightly build disk images rather than gzip.

04/02/07:

22:54 Changeset [20675] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5107095> REGRESSION: disabled text color calculations are slowing down launchtime measurements

Hardcode disabled text colors for the most common cases- black and white.

  • rendering/RenderTextControl.cpp: (WebCore::disabledTextColor):
18:11 Changeset [20674] by hyatt
  • 19 edits in trunk/WebCore

Fix for <rdar://problem/5105784>, assertion failure in cache. Encoded sizes were being set to
garbage by accident because of a mismatch between derived class and base class constructors. This
patch cleans all of this up and gets rid of expiration date as a concept separate from the response.

Reviewed by anders

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::finish):
  • loader/CachedResource.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
18:01 Changeset [20673] by antti
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 3


These changes shrink all RenderBlocks by additional 28 bytes. Together with parts 1 and 2
RenderBlock goes from 172 bytes to 128 bytes, a saving of 26%.


  • Pack bitfields together in RenderFlow
  • Move top/bottom min/max margin values to a struct that is only allocated in case these variables have non default values. Usually this is <5% of all blocks.
  • Move rarely used column variables to hash
  • rendering/RenderBlock.cpp: (WebCore::ColumnInfo::ColumnInfo): (WebCore::RenderBlock::RenderBlock): (WebCore::RenderBlock::~RenderBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject): (WebCore::RenderBlock::fillSelectionGaps): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::setDesiredColumnCountAndWidth): (WebCore::RenderBlock::desiredColumnWidth): (WebCore::RenderBlock::desiredColumnCount): (WebCore::RenderBlock::columnRects): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents): (WebCore::RenderBlock::adjustRectForColumns): (WebCore::RenderBlock::setMaxTopMargins): (WebCore::RenderBlock::setMaxBottomMargins):
  • rendering/RenderBlock.h: (WebCore::RenderBlock::maxTopMargin): (WebCore::RenderBlock::maxBottomMargin): (WebCore::RenderBlock::maxTopPosMargin): (WebCore::RenderBlock::maxTopNegMargin): (WebCore::RenderBlock::maxBottomPosMargin): (WebCore::RenderBlock::maxBottomNegMargin): (WebCore::RenderBlock::initMaxMarginValues): (WebCore::RenderBlock::MaxMargin::MaxMargin): (WebCore::RenderBlock::MaxMargin::topPosDefault): (WebCore::RenderBlock::MaxMargin::topNegDefault): (WebCore::RenderBlock::MaxMargin::bottomPosDefault): (WebCore::RenderBlock::MaxMargin::bottomNegDefault):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow): (WebCore::RenderFlow::hasColumns):
  • rendering/RenderInline.cpp: (WebCore::RenderInline::RenderInline):
  • rendering/RenderInline.h:
18:00 Changeset [23220] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin
17:54 Changeset [23219] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Check that NPStream pointers passed to NPN_DestroyStream are valid.


  • plugins/win/PluginStreamWin.cpp: (WebCore::streams): (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::ownerForStream):
  • plugins/win/PluginStreamWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream):
17:22 Changeset [20672] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test you don't crash when you have abs positioned elements inside rel inline.

  • fast/block/positioning/abs-inside-inline-rel-expected.checksum: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.png: Added.
  • fast/block/positioning/abs-inside-inline-rel-expected.txt: Added.
  • fast/block/positioning/abs-inside-inline-rel.html: Added.

WebCore:

Reviewed by Hyatt.

Fix asserts, these may also be called for rel positioned elements

  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
16:49 Changeset [20671] by andersca
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

Fix crash when running plugins/destroy-stream-twice.html under GuardMalloc

  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebBaseNetscapePluginStream.mm: (+[WebBaseNetscapePluginStream ownerForStream:]): (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]): (-[WebBaseNetscapePluginStream dealloc]): (-[WebBaseNetscapePluginStream finalize]): Change the streams hash map to contain an NPStream*, and change ownerForStream to take an NPStream*.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView destroyStream:reason:]): Check that the NPStream pointer is valid before accessing stream->ndata.
16:41 Changeset [20670] by hyatt
  • 2 edits in trunk/WebCore

Throw in an assert to try to track down a problem where an image is being set to a smaller encoded
size.

  • loader/CachedResource.cpp: (WebCore::CachedResource::setEncodedSize):
16:32 Changeset [23218] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

<rdar://problem/5095582>
PluginViewWin doesn't implement NPN_DestroyStream.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Handle the case where NPN_DestroyStream is called from the newstream handler.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::destroyStream): Implement this.
15:29 Changeset [20669] by adachan
  • 2 edits in trunk/WebCore

2007-04-02 Ada Chan <adachan@apple.com>

Reviewed by Adele.

<rdar://5105331> Missing null check in Editor::execCommand
Added null check.

  • editing/Editor.cpp: (WebCore::Editor::execCommand):
15:19 Changeset [23217] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/5097225>
Mouse cursors don't work with windowless plugins


  • platform/win/WidgetWin.cpp: (WebCore::Widget::setCursor): Add an "ignoreNextSetCursor" boolean and don't call SetCursor if it's true.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Store away the current cursor and make sure that it won't be reset.
14:28 Changeset [23216] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Fix logic in windowless paint functions.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw):
14:15 Changeset [20668] by darin
  • 3 edits in trunk/WebKit

Reviewed by Geoff.

  • set clip path for CoreGraphics plug-ins in the same way we do for QuickDraw plug-ins this is a better fix for <rdar://problem/4939511> WebKit should set the the CG clip path for plug-ins that draw using Core Graphics

Incorporates changes from a patch by Mark Ambachtsheer.

Here are the changes:

1) Don't try to use the offscreen code path if GGBitmapContextGetData returns 0.
2) Handle kCGBitmapByteOrderDefault when computing the QD pixel format, even though

we don't have any evidence that this happens in practice.

3) Keep the GWorld around until we create a new one or the plug-in is destroyed.
4) Use the GWorld pointer itself as a flag to indicate whether we are using an

offscreen GWorld.

5) Set up clipping for CoreGraphics in the same way we do for QuickDraw; remove an

earlier attempt that handled CoreGraphics differently.

  • Plugins/WebBaseNetscapePluginView.h: Added a field named offscreenGWorld to hold the GWorld until it's needed.
  • Plugins/WebBaseNetscapePluginView.mm: (getQDPixelFormatForBitmapContext): Replaced QDPixelFormatFromCGBitmapInfo. Used the "get" prefix so we don't intrude on the QD namespace. Added code to handle the kCGBitmapByteOrderDefault case, although I'm not sure it will really come up in practice -- it wasn't really coming up in the buggy case. (getNPRect): Added helper functions. Used to make the code below clearer. (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Use getNPRect to streamline code. Use GetGWorld to save the port since we use SetGWorld to restore it later. Store the GWorld we create in the offscreenGWorld field and dispose the existing one. Don't treat the CGBitmapContext as an offscreen bitmap if it has a data pointer of 0. Set up the clip based on the result of -[NSView getRectsBeingDrawn:count] when setting up the port for CoreGraphics (after saving the port state). (-[WebBaseNetscapePluginView restorePortState:]): Remove now-unneeded code to destroy the offscreen GWorld, and simplified the code that restores the port so we don't need a separate case for offscreen. (-[WebBaseNetscapePluginView fini]): Renamed from freeAttributeKeysAndValues, since this method now does more than just the attributes. This is the shared method that does things needed in both dealloc and finalize. Added a call to DisposeGWorld here. (-[WebBaseNetscapePluginView dealloc]): Updated for name change. (-[WebBaseNetscapePluginView finalize]): Ditto. (-[WebBaseNetscapePluginView drawRect:]): Removed code to set clip. This is done in the saveAndSetNewPortStateForUpdate: method instead.
13:38 Changeset [20667] by zbujtas
  • 2 edits in S60/branches/3.1m/WebCore

2007-03-30 jadhan <jade.han@nokia.com>

Reviewed by Zalan <zbujtas@gmail.com>
DESC: special handling for utf8 encoding of danish character. Merged fix from 3.2 to 3.1
http://bugs.webkit.org/show_bug.cgi?id=13231

WARNING: NO TEST CASES ADDED OR CHANGED

  • ChangeLog:
  • kwq/KWQTextCodec.cpp: (validateUtf8):
13:30 Changeset [23215] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Add TestNetscapeObject project.
13:23 Changeset [23214] by andersca
  • 1 edit in branches/WindowsMerge/WebKitTools/ChangeLog

Adam is not a nobody.

13:23 Changeset [23213] by andersca
  • 4 edits
    4 adds in branches/WindowsMerge/WebKitTools

WebKitToolsWin:

Reviewed by NOBODY (OOPS!).

Add netscape test plugin VC project. Make DumpRenderTree look for the test plugin.


12:46 Changeset [20666] by bdash
  • 5 edits in branches/Safari-522/WebKit

Merge r20571.

12:37 Changeset [20665] by bdash
  • 7 edits in branches/Safari-522

Merge r20593 and r20596.

12:33 Changeset [20664] by andersca
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Don't use #import in a header included by C files.
12:23 Changeset [20663] by bdash
  • 5 edits in branches/Safari-522

Merge r20555 and r20560.

11:37 Changeset [20662] by spadma
  • 4 edits in S60/trunk/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:37 Changeset [20661] by spadma
  • 4 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: user hits cancel on connection dialog, send EventLoadError to the host app
http://bugs.webkit.org/show_bug.cgi?id=13257

  • BrowserView/inc/WebKitControl.h:
  • BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequestCancelled):
  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::FinalProgressComplete):
11:23 Changeset [20660] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/inserting/5058163-1-expected.checksum: Added.
  • editing/inserting/5058163-1-expected.png: Added.
  • editing/inserting/5058163-1-expected.txt: Added.
  • editing/inserting/5058163-1.html: Added.
  • editing/inserting/5058163-2-expected.checksum: Added.
  • editing/inserting/5058163-2-expected.png: Added.
  • editing/inserting/5058163-2-expected.txt: Added.
  • editing/inserting/5058163-2.html: Added.

WebCore:

Reviewed by darin

<rdar://problem/5058163>
Hitting return inserts a new line between two To Dos, but caret is position after second ToDo

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Removed refPos, it was unused. Don't assume that upstream() moves to a different node. This assumption caused the line break to be inserted *after* the caret and a bad position to be set (added a testcase). Use isStartOfParagraph instead of checking for the existence of a br because the line might be broken by a newline character in text that preserves newlines. Paragraphs that are created in other ways, like with blocks, are handled above (added a testcase).
11:22 Changeset [20659] by spadma
  • 5 edits in S60/trunk/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
11:22 Changeset [20658] by spadma
  • 5 edits in S60/branches/3.1m/WebKit

2007-04-02 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
DESC: implement client side accept header support
http://bugs.webkit.org/show_bug.cgi?id=13256

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::SetParamL):
  • ResourceLoader/inc/LoaderContainer.h: (CLoaderContainer::ClientAcceptHeaders):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::AddRequestHeadersL):
  • ResourceLoader/src/LoaderContainer.cpp: (CLoaderContainer::~CLoaderContainer): (CLoaderContainer::SetClientAcceptHeadersL):
10:39 Changeset [20657] by zbujtas
  • 3 edits in S60/trunk/WebCore

2007-04-02 yongjzha <yonjun.zhang@nokia.com>

Reviewed by bjutas@gmail.com.
DESC: suppress false memory leaking alert.
http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
10:36 Changeset [20656] by harrison
  • 2 edits in trunk/WebCore

2007-04-02 David Harrison <harrison@apple.com>

Reviewed by Darin.

<rdar://problem/4906488> text attributes are not working for frame based web page

Attribute handling now treats each WebArea as its own world, rather than sometimes
referring back up to the top WebArea. e.g. getting/setting the selection now
operates on the WebArea containing the WebCoreAXObject that is being messaged (self).
The methods that sit above this and are able to go into arbitrary WebAreas
are accessibilityFocusedUIElement and doAXTextMarkerForPosition, allowing VoiceOver
to navigate between frames.


  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject topRenderer]): (-[WebCoreAXObject frameView]): (-[WebCoreAXObject topFrameView]): Removed topDocument, renamed topView to topFrameView, added frameView.


(-[WebCoreAXObject accessibilityAttributeValue:]):
AXSelectedTextMarkerRange, AXStartTextMarker, and AXEndTextMarker now use
self's WebArea, rather than the top WebArea.


(-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
Use self's WebArea, rather than the top WebArea.

(-[WebCoreAXObject doAXTextMarkerForPosition:]):
Use renamed methods for accessing top WebArea.


(-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
Use renamed methods for accessing self's WebArea.

(AXAttributeStringSetColor):
(AXAttributeStringSetNumber):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
(AXAttributeStringSetElement):
(-[WebCoreAXObject rendererForView:]):
Clean up uses of nil and NULL.


(-[WebCoreAXObject accessibilityFocusedUIElement]):
Find the focused node on the whole page. If there is no focused node,
return the WebArea for the focused document.


(-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
Use self's WebArea, rather than the top WebArea.

10:36 Changeset [20655] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-04-02 yongjzha <yonjun.zhang@nokia.com>

Reviewed by bjutas@gmail.com.
DESC: suppress false memory leaking alert.
http://bugs.webkit.org/show_bug.cgi?id=13253

  • khtml/css/css_base.h: (DOM::):
  • khtml/css/cssparser.h: (DOM::Value::): (DOM::qString): (DOM::domString): (DOM::atomicString): (DOM::):
03:06 Changeset [20654] by antti
  • 2 edits in trunk/WebCore

Fix build. This one was not supposed to be checked in.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
02:43 Changeset [20653] by antti
  • 9 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 2


  • Move staticX and staticY variables to RenderLayer since they are only applicable to positioned objects
  • Move very rarely used overrideSize variable to hash


These changes shrink all box types by 12 bytes

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::destroy): (WebCore::RenderBox::overrideSize): (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::overrideWidth): (WebCore::RenderBox::overrideHeight): (WebCore::RenderBox::position): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::staticX): (WebCore::RenderBox::staticY): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::staticX): (WebCore::RenderLayer::staticY): (WebCore::RenderLayer::setStaticX): (WebCore::RenderLayer::setStaticY):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject):
  • rendering/RenderObject.h: (WebCore::): (WebCore::RenderObject::hasOverrideSize): (WebCore::RenderObject::setHasOverrideSize):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy):

04/01/07:

20:04 Changeset [20652] by sfalken
  • 1 copy in tags/Safari-522.5.4b

New tag.

16:29 Changeset [20651] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20570

16:27 Changeset [20650] by sfalken
  • 14 edits in branches/Safari-522

Merge fix from r20565

16:01 Changeset [20649] by kjk
  • 2 edits in trunk/WebCore

Not reviewed - gdk build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText): (Font::drawComplexText):

03/31/07:

22:41 Changeset [20648] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12778
REGRESSION: Nightly won't load Curl plugin for full page use

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Re-order cases to give more priority to plugins. This also fixes Adobe SVG Viewer and any plugins that register XML MIME types. Added a case for XHTML to avoid enumerating plugins.
22:33 Changeset [23212] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove bogus comment.

22:30 Changeset [23211] by hyatt
  • 5 edits in branches/WindowsMerge/WebCore

Fix layout of justified selected text.

22:21 Changeset [20647] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text
22:20 Changeset [20646] by hyatt
  • 13 edits in trunk/WebCore

Fix for bug 13234, layout of selected justified text is broken. Rework TextRuns to avoid having
from/to members. Let those be passed in only by the functions that need them (drawing and selection rect).

Reviewed by mitz

fast/text/justified-selection-at-edge.html

  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): (WebCore::WidthIterator::advance): (WebCore::Font::canUseGlyphCache): (WebCore::Font::drawSimpleText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): (WebCore::Font::selectionRectForText): (WebCore::Font::selectionRectForSimpleText): (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h: (WebCore::TextRun::m_len):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): (WebCore::GraphicsContext::drawHighlightForText):
  • platform/graphics/GraphicsContext.h:
  • platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
  • platform/qt/FontQt.cpp: (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
  • platform/qt/TemporaryLinkStubs.cpp: (Font::selectionRectForComplexText):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateOptionsWidth):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::width):
22:04 Changeset [20645] by bdash
  • 2 edits in trunk/WebCore

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

<rdar://problem/5103226>

REGRESSION (r20506): Repro crash/assert when using scroll wheel on a list box taller than its contents

  • platform/ScrollBar.cpp: (WebCore::Scrollbar::setValue): Cleaned up a little. (WebCore::Scrollbar::scroll): Changed to apply the minimum and maximum constraints in the right order, and cleaned up a little.
21:59 Changeset [20644] by andrew
  • 3 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

  • fast/images/text-content-crash-expected.txt: Added.
  • fast/images/text-content-crash.html: Added.

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

Test: fast/images/text-content-crash.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::parseMappedAttribute): Added a check that the renderer is an image. (WebCore::HTMLImageElement::attach): Ditto.
21:50 Changeset [20643] by bdash
  • 2 edits in trunk/WebKitTools

2007-03-31 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Fix http://bugs.webkit.org/show_bug.cgi?id=13239
Bug 13239: REGRESSION (r20343): Drosera hits exception trying to call "count" cross-process

Use -[WebScriptObject valueForKey:@"length"] to retrieve the length of a JavaScript array
rather than -[WebScriptObject count].

  • Drosera/DebuggerDocument.m: (-[DebuggerDocument webScriptAttributeKeysForScriptObject:]):
21:48 Changeset [20642] by bdash
  • 3 edits in trunk/WebCore

2007-03-31 Mark Rowe <mrowe@apple.com>

Reviewed by Darin.

A more correct fix for http://bugs.webkit.org/show_bug.cgi?id=13129
Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup

The previous attempt at a fix in r20343 attempted to conditionally expose the 'count'
method. It did not work which resulted in 'count' always being hidden. This change
disables -[WebScriptObject count] completely until it can be determined whether it is
needed and how to support it without breaking third-party applications.

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject count]):
  • bindings/objc/WebScriptObjectPrivate.h:
21:28 Changeset [23210] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

Filesystem layout changes:

<rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
<rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"

11:24 Changeset [23209] by adele
  • 2 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

A little cleanup from my last change. Added a comment, and moved a JSStringRelease call to a better place.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback):
08:32 Changeset [20641] by ddkilzer
  • 3 edits in trunk/LayoutTests

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.
Fixed one instance where 'allow-tabs' property and 'true' value were reversed.

04:30 Changeset [20640] by ddkilzer
  • 2 edits in trunk/LayoutTests/fast/js/resources

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

03:25 Changeset [20639] by ap
  • 2 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Sam Weinig.

  • pixel test for partially selected justified text
  • fast/text/justified-selection-expected.checksum: Added.
  • fast/text/justified-selection-expected.png: Added.
  • fast/text/justified-selection-expected.txt: Added.
  • fast/text/justified-selection.html: Added.
03:18 Changeset [20638] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

A layout test documenting shrink-to-fit width calculation for floating elements.

  • fast/block/float/shrink-to-fit-width-expected.checksum: Added.
  • fast/block/float/shrink-to-fit-width-expected.png: Added.
  • fast/block/float/shrink-to-fit-width-expected.txt: Added.
  • fast/block/float/shrink-to-fit-width.html: Added.
03:07 Changeset [20637] by ap
  • 3 edits
    2 adds in trunk

2007-03-31 Nicholas Shanks <webkit@nickshanks.com>

Reviewed by Adele.

http://bugs.webkit.org/show_bug.cgi?id=13184
HTMLImageElement longdesc should be complete resolved URL

Test: fast/dom/HTMLImageElement/image-longdesc-absolute-url.html

  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::longDesc): Return absolute URL. Behaviour now matches Firefox and Opera.
01:26 Changeset [20636] by ap
  • 5 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/repaint/list-marker-2.html

A list marker can increase the horizontal overflow after layoutInlineChildren(),
so made that function return only the vertical bounds of the repaint rect. As the
horizontal bounds, made layoutBlock() just use the overflow bounds after layout.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
00:59 Changeset [20635] by ap
  • 3 edits
    4 adds in trunk

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

Test: fast/text/wide-zero-width-space.html

  • platform/FontData.cpp: (WebCore::FontData::FontData): Force the ZERO WIDTH SPACE glyph to have width 0, unless the SPACE character maps to the same glyph.
00:49 Changeset [20634] by ap
  • 11 edits
    2 adds in trunk

2007-03-31 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

WebCore:

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Made "<" terminate tag and attribute names. This matches Firefox.

LayoutTests:

  • fast/overflow/002-expected.checksum:
  • fast/overflow/002-expected.png:
  • fast/overflow/002-expected.txt:
  • fast/overflow/002.html: Added missing ">" to one of the BR tags.
  • fast/text/atsui-multiple-renderers-expected.checksum:
  • fast/text/atsui-multiple-renderers-expected.png:
  • fast/text/atsui-multiple-renderers-expected.txt:
  • fast/text/atsui-multiple-renderers.html: Added missing ">" to the TITLE tag.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs-expected.txt: Added.
  • fast/tokenizer/lessthan-terminates-tags-and-attrs.html: Added.

03/30/07:

20:39 Changeset [20633] by sfalken
  • 1 copy in tags/Safari-522.5.3b

New tag.

19:41 Changeset [20632] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20543

19:25 Changeset [20631] by ddkilzer
  • 1 edit in trunk/LayoutTests/fast/js/resources/dot-node-base-exception.js

Replaced bogus 'text/plain' svn property with svn:mime-type property set to 'text/javascript'.

16:13 Changeset [23208] by adele
  • 4 edits in branches/WindowsMerge

WebKitToolsWin:

Reviewed by Beth.

Fix for <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: (keyDownCallback): Added hack to convert option-delete to ctrl-delete. Also fixed this to correctly convert ascii codes to virtual key codes, which removes the need for the special conversion of '\n' to VK_RETURN.

WebKitWin:

Reviewed by Beth.

Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing

  • WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
15:31 Changeset [23207] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adele.

<rdar://problem/5101970>
Crash when submitting form, running under App Verifier


  • WebActionPropertyBag.cpp: (findMouseEvent): Return the right event.
14:56 Changeset [20630] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20558

14:53 Changeset [20629] by sfalken
  • 5 edits
    8 copies in branches/Safari-522

Merge fix from r20542

14:51 Changeset [20628] by sfalken
  • 2 edits in branches/Safari-522/WebKit

Merge fix from r20537

14:46 Changeset [20627] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merge fix from r20535

14:43 Changeset [20626] by sfalken
  • 3 edits
    16 copies in branches/Safari-522

Merge fix from r20520

14:41 Changeset [20625] by andersca
  • 5 edits in trunk

LayoutTests:

Reviewed by Geoff.

  • plugins/destroy-stream-twice.html: Put the scripts before the embed element. Set the timeout in the onstreamload handler.

WebKitTools:

Reviewed by Geoff.

Add an "onstreamload" attribute to the plugin which is called when a stream starts loading.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): Look for the onstreamload attribute.


(NPP_Destroy):
Free the onstreamload attribute.


(NPP_NewStream):
Call the onstreamload handler.

14:40 Changeset [20624] by sfalken
  • 3 edits
    4 copies in branches/Safari-522

Merge fix from r20503

14:33 Changeset [20623] by sfalken
  • 4 edits
    3 copies in branches/Safari-522

Merge fix from r20502

13:57 Changeset [20622] by ap
  • 2 edits in trunk/WebCore

Debug build fix.

  • xml/XPathValue.cpp: (WebCore::XPath::): Define Value::adopt.
13:54 Changeset [20621] by ggaren
  • 2 edits in trunk/WebKitTools

Removing an assertion I just added because it's crashing the Leopard
buildbot. The related layout test will still report a failure, so we
don't really need this assertion.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke):
13:31 Changeset [20620] by ap
  • 11 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13021
XPath can be very slow

This patch finally makes us faster than Firefox 2.0 on this test case.

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunConcat::evaluate): Use a Vector buffer for faster appending. (WebCore::XPath::FunId::evaluate): Move the result NodeSet into Value instead of copying it. (WebCore::XPath::FunLocalName::evaluate): Cosmetic changes. (WebCore::XPath::FunNamespaceURI::evaluate): Ditto. (WebCore::XPath::FunName::evaluate): Ditto. (WebCore::XPath::FunNormalizeSpace::evaluate): Ditto.
  • xml/XPathValue.cpp: (WebCore::XPath::Value::toNodeSet): (WebCore::XPath::Value::modifiableNodeSet): (WebCore::XPath::Value::toBoolean): (WebCore::XPath::Value::toNumber): (WebCore::XPath::Value::toString):
  • xml/XPathValue.h: (WebCore::XPath::ValueData::ValueData): (WebCore::XPath::Value::Value): Made Value copying faster by putting large data members into a separate refcounted ValueData class. Added provisions for moving a NodeSet in and out of Value without copying. Made construction safer by moving bool version to a template constructor. Removed an (almost) unused default constructor.
  • xml/XPathPredicate.h: Store a Value for literal string and number expressions to avoid constructing one each time.
  • xml/XPathPath.cpp: (WebCore::XPath::Filter::evaluate): (WebCore::XPath::LocationPath::evaluate): (WebCore::XPath::Path::evaluate):
  • xml/XPathPath.h:
  • xml/XPathPredicate.cpp: (WebCore::XPath::NumericOp::evaluate): (WebCore::XPath::Union::evaluate):
  • xml/XPathResult.cpp: (WebCore::XPathResult::snapshotItem):
  • xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis):
  • xml/XPathStep.h: Got rid of unnecessary NodeSet copying in many cases.
13:13 Changeset [20619] by andersca
  • 3 edits in trunk/WebKitTools

Reviewed by Geoff.

  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: (testAllocate): (testEnumerate): Add casts.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Don't use #import, use #include.
13:12 Changeset [23206] by andersca
  • 12 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Geoff.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::addExtraPluginPath):
  • plugins/win/PluginDatabaseWin.h: New function for adding an extra plugin path, to be used by DRT.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load): Set the current directory tho the plugin directory while loading the plugin. Add new NPN callbacks.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::invalidateRect): (WebCore::PluginViewWin::invalidateRegion): (WebCore::PluginViewWin::forceRedraw): Don't do anything if the plugin is windowed.


  • plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs.


  • plugins/win/npfunctions.h: Add new methods and merge some fixes from the open source version.

WebKitWin:

Reviewed by Geoff.

  • Interfaces/IWebViewPrivate.idl: Add addAdditionalPluginPath method.


  • WebKit.vcproj/WebKit.vcproj: Copy NP includes so they can be included by the test plugin.


  • WebView.cpp: (WebView::stringByEvaluatingJavaScriptFromString): Hold JSLock while we call JSValue::getString().


(WebView::addAdditionalPluginPath):

  • WebView.h: Implement addAdditionalPluginPath.
12:59 Changeset [20618] by andersca
  • 2 edits in trunk/WebKitTools

Reviewed by Alexey.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): Free the identifier string.
12:50 Changeset [20617] by justing
  • 4 edits
    9 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/5076323> Only one To Do can be created by a selection in a message

  • editing/selection/5076323-1-expected.checksum: Added.
  • editing/selection/5076323-1-expected.txt: Added.
  • editing/selection/5076323-1.html: Added.
  • editing/selection/5076323-2-expected.checksum: Added.
  • editing/selection/5076323-2-expected.txt: Added.
  • editing/selection/5076323-2.html: Added.
  • editing/selection/5076323-3-expected.checksum: Added.
  • editing/selection/5076323-3-expected.txt: Added.
  • editing/selection/5076323-3.html: Added.

WebCore:

Reviewed by john

<rdar://problem/5076323> Only one To Do can be created by a selection in a message

When Mail's ToDoify operation called moveToEndOfDocument:
with a selection that started just before a ToDo, we'd
move them to the end of the document, not to the end
of the editable root, because we incorrectly checked
for the editability of positions before ToDos. Then Mail
would refuse to create a ToDo because the selection was
outside of the region where they allowed editing.

  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): Check the position for editability, not the position's node, since there are editable positions of the form [node, offset] where node is contenteditable=false. Re-use pos. Nothing that happens after it's created can invalidate it or the position and affinity used to create it. (WebCore::SelectionController::modifyMovingRightForward): Ditto. (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto. (WebCore::SelectionController::modifyMovingLeftBackward): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret): Ditto.
11:24 Changeset [20616] by beidson
  • 3 edits in trunk/LayoutTests

Reviewed by Brian Dash

Fixes an intermittent failure in the port blocking layout test where
some sort of indeterminacy would change the error code the networking
layer reported.

  • security/block-test-expected.txt:
  • security/block-test.html: Use 255.255.255.255 instead of a bogus domain name
11:13 Changeset [20615] by adele
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

Added DeleteWordBackward and DeleteWordForward to execCommand.

  • editing/Editor.cpp: (WebCore::execDeleteWordBackward): (WebCore::execDeleteWordForward): (WebCore::CommandEntry::):

WebKit:

Reviewed by Darin.

Call execCommand for deleteWordForward and deleteWordBackward instead of calling
deleteWithDirection directly.

  • WebView/WebHTMLView.mm: (-[WebHTMLView deleteWordForward:]): (-[WebHTMLView deleteWordBackward:]):
11:10 Changeset [20614] by andersca
  • 2 edits in trunk/JavaScriptCore

Build fix.


  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
10:45 Changeset [23205] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebKitTools

Reviewed by Geoff.

10:29 Changeset [20613] by andersca
  • 20 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Implement _NPN_Enumerate support.


  • JavaScriptCore.exp:
  • bindings/NP_jsobject.cpp: (_NPN_Enumerate):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getPropertyNames):
  • bindings/c/c_instance.h:
  • bindings/npapi.h:
  • bindings/npruntime.h:
  • bindings/npruntime_impl.h:
  • bindings/runtime.h: (KJS::Bindings::Instance::getPropertyNames):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getPropertyNames):
  • bindings/runtime_object.h: (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Geoff.

Add enumeration test.


  • plugins/netscape-enumerate-expected.txt: Added.
  • plugins/netscape-enumerate.html: Added.

WebKit:

Reviewed by Geoff.

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.


  • Plugins/npapi.m: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Add stubs for these functions.


  • Plugins/npfunctions.h: Add new methods to NPNetscapeFuncs.

WebKitTools:

Reviewed by Geoff.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Add TestObject.c and TestObject.h


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): Implement the testObject property.


(pluginInvoke):
Implement testEnumerate which takes an object and an array and enumerates
the properties of the object and adds them to the array.


(pluginAllocate):
Allocate the test object.


(pluginDeallocate):
Free the test object.


  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added. Add a test object with two enumerable properties.
08:33 Changeset [20612] by hausmann
  • 2 edits in trunk/WebCore

Fix Qt release builds

05:55 Changeset [20611] by antti
  • 2 edits in trunk/WebCore

Reviewed by bdash.

Spotted an int that should be float in previous patch.

  • platform/Font.cpp: (WebCore::WidthIterator::advance):
02:59 Changeset [20610] by antti
  • 12 edits in trunk/WebCore

Reviewed by Hyatt.

Render tree memory savings, part 1


  • Eliminate caching of monospace char width from RenderText. This optimization is not needed anymore since Font already caches space width (RenderText -4 bytes)
  • Eliminate caching of tab width from RenderBlock. Similary this optimization has become obsolete (RenderBlock -4 bytes)
  • platform/Font.cpp: (WebCore::WidthIterator::advance): (WebCore::Font::spaceWidth):
  • platform/Font.h: (WebCore::Font::tabWidth):
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::allowTabs):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::setStyle):
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setStyle): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidthInternal): (WebCore::RenderText::setTextInternal): (WebCore::RenderText::width):
  • rendering/RenderText.h: (WebCore::RenderText::allowTabs):
  • rendering/bidi.cpp:
02:51 Changeset [20609] by hyatt
  • 4 edits
    4 adds in trunk

Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency.

Reviewed by mitz

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
Note: See TracTimeline for information about the timeline view.